Re: [PATCH 2/2] clk: qcom: Add display clock controller driver for SDM845

2018-06-19 Thread Stephen Boyd
Quoting Taniya Das (2018-06-13 02:18:59) > Hello Stephen, > > Thanks for review. > > On 6/12/2018 1:25 PM, Stephen Boyd wrote: > > Quoting Taniya Das (2018-06-04 00:56:25) > >> diff --git a/drivers/clk/qcom/dispcc-sdm845.c > >> b/drivers/clk/qcom/dispcc-sdm845.c > >> new file mode 100644 > >> in

Re: [PATCH] arm64: mm: mark tramp_pg_dir read-only

2018-06-19 Thread Will Deacon
Hi Ard, Sorry, I forgot to reply to this. On Wed, May 30, 2018 at 11:53:20AM +0200, Ard Biesheuvel wrote: > On 30 May 2018 at 11:14, Will Deacon wrote: > > On Wed, May 30, 2018 at 12:48:06PM +0800, YaoJun wrote: > >> To protect against KSMA(Kernel Space Mirroring Attack), make > >> tramp_pg_dir

Re: [PATCH v11 09/13] x86, sgx: basic routines for enclave page cache

2018-06-19 Thread Neil Horman
On Tue, Jun 19, 2018 at 05:57:53PM +0300, Jarkko Sakkinen wrote: > On Fri, Jun 08, 2018 at 11:24:12AM -0700, Dave Hansen wrote: > > On 06/08/2018 10:09 AM, Jarkko Sakkinen wrote: > > > SGX has a set of data structures to maintain information about the > > > enclaves > > > and their security proper

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-19 Thread Paolo Bonzini
On 15/06/2018 20:45, Nick Desaulniers wrote: >> >>> In any case I think it it preferable to fix the code over disabling >>> the warning, unless the warning is bogus or there are just too many >>> occurrences. >> Maybe. > Spurious warning today, actual bug tomorrow? I prefer to not to > disable war

Re: Possible regression in "slab, slub: skip unnecessary kasan_cache_shutdown()"

2018-06-19 Thread Jason A. Donenfeld
On Tue, Jun 19, 2018 at 5:08 PM Shakeel Butt wrote: > > > Are you using SLAB or SLUB? We stress kernel pretty heavily, but with > > > SLAB, and I suspect Shakeel may also be using SLAB. So if you are > > > using SLUB, there is significant chance that it's a bug in the SLUB > > > part of the change

Re: [4.17 regression] Performance drop on kernel-4.17 visible on Stream, Linpack and NAS parallel benchmarks

2018-06-19 Thread Mel Gorman
On Tue, Jun 19, 2018 at 03:36:53PM +0200, Jirka Hladky wrote: > Hi Mel, > > we have tested following variants: > > var1: 4.16 + 2c83362734dad8e48ccc0710b5cd2436a0323893 > fix1: var1+ ratelimit_pages __read_mostly increased by factor 4x > -static unsigned int ratelimit_pages __read_mostly = 128 <<

Re: [PATCH 3/3] perf stat: Remove duplicate event counting

2018-06-19 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 15, 2018 at 10:21:24AM +0200, Jiri Olsa escreveu: > On Thu, Jun 14, 2018 at 01:48:45PM +0200, Thomas Richter wrote: > > SNIP > > > +static void perf_pmu_assign_str(char *name, const char *field, char > > **old_str, > > + char **new_str) > > +{ > > + if (!*

Re: [PATCH 2/3 v2] perf alias: Rebuild alias expression string to make it comparable

2018-06-19 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 15, 2018 at 12:11:04PM +0200, Thomas Richter escreveu: > PMU alias definitions in sysfs files may have spaces, newlines > and numbers with leading zeroes. Some alias definitions may > also appear in JSON files without spaces, etc. > > Scan alias definitions and remove leading zeroes, s

Re: [RFC PATCH 1/2] spi: Add QuadSPI driver for Atmel SAMA5D2

2018-06-19 Thread Mark Brown
On Mon, Jun 18, 2018 at 06:21:23PM +0200, Piotr Bugalski wrote: > +static int atmel_qspi_adjust_op_size(struct spi_mem *mem, struct spi_mem_op > *op) > +{ > + return 0; > +} If this can be empty should we adjust the callers to allow it to just be omitted? > +static int atmel_qspi_remove(str

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Michal Hocko
On Tue 19-06-18 15:54:26, Punit Agrawal wrote: [...] > In terms of $SUBJECT, I wonder if it's worth taking the original patch > as a temporary fix (it'll also be easier to backport) while we work on > fixing these other issues and enabling memoryless nodes. Well, x86 already does that but copying

Re: [PATCH v2 0/4] have the vt console preserve unicode characters

2018-06-19 Thread Adam Borowski
On Tue, Jun 19, 2018 at 09:52:13AM -0400, Dave Mielke wrote: > [quoted lines by Adam Borowski on 2018/06/19 at 15:09 +0200] > > >You're thinking small. That 256 possible values for Braille are easily > >encodable within the 512-glyph space (256 char + stolen fg brightness bit, > >another CGA pecu

Re: [PATCH 1/3 v2] perf alias: Remove trailing newline when reading sysfs files

2018-06-19 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 15, 2018 at 12:11:03PM +0200, Thomas Richter escreveu: > Remove a trailing newline when reading sysfs file contents > such as /sys/devices/cpum_cf/events/TX_NC_TEND. > This shows when verbose option -v is used. > > Output before: > tx_nc_tend -> 'cpum_cf'/'event=0x008d > '/ Thanks, ap

[PATCH 1/4] slimbus: messaging: pass correct wbuf

2018-06-19 Thread Srinivas Kandagatla
There seems to be a typo while filling msg for slim_write, wbuf is set to NULL instead of rbuf. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index 4

Re: [RFC PATCH] ARM: Use logical or instead of addition for badr address calculation

2018-06-19 Thread Russell King - ARM Linux
On Tue, Jun 19, 2018 at 03:35:07PM +0200, Ard Biesheuvel wrote: > On 19 June 2018 at 15:29, Guenter Roeck wrote: > > Hi Ard, > > > > > > On 06/19/2018 12:48 AM, Ard Biesheuvel wrote: > >> > >> On 19 June 2018 at 07:07, Guenter Roeck wrote: > >>> > >>> Modern assemblers may take the ISA into accou

[PATCH 3/4] slimbus: messaging: initialize completion correctly

2018-06-19 Thread Srinivas Kandagatla
slim_val_inf can contain random value from stack, make sure the completion is initialized to NULL while filling the msg. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.

[PATCH 4/4] slimbus: qcom: remove redundant depends in Kconfig

2018-06-19 Thread Srinivas Kandagatla
QCOM SLIMBus controller is already under a 'if SLIMBUS' in Kconfig, having depends on SLIMBUS is totally redundant. Just remove it. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig

[PATCH 0/4] slimbus: fixes for v4.18

2018-06-19 Thread Srinivas Kandagatla
Hi Greg, Here are few trivial slimbus fixes, Could you please take them for next possible rc. Thanks, srini Srinivas Kandagatla (4): slimbus: messaging: pass correct wbuf slimbus: messaging: remove multiple calls to pm_runtime_mark_last_busy slimbus: messaging: initialize completion corre

[PATCH 2/4] slimbus: messaging: remove multiple calls to pm_runtime_mark_last_busy

2018-06-19 Thread Srinivas Kandagatla
There seems to be a multiple calls to pm_runtime_mark_last_busy(), which looks like a typo. Fix this by properly adding pm_runtime_put_autosuspend to put controller in auto suspend state. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [RFC PATCH 5/8] x86/umwait.c: Add sysfs interface to show tsc_khz

2018-06-19 Thread Fenghua Yu
On Tue, Jun 19, 2018 at 11:08:46AM +0200, Thomas Gleixner wrote: > On Fri, 15 Jun 2018, Fenghua Yu wrote: > > > +static ssize_t tsc_khz_show(struct device *dev, struct device_attribute > > *attr, > > + char *buf) > > +{ > > + return sprintf(buf, "%d\n", tsc_khz); > > +} >

Re: [PATCH] of/platform: add initcall_debug logs for device creates

2018-06-19 Thread Frank Rowand
Hi Todd, On 06/18/18 18:46, Todd Poynor wrote: > From: Todd Poynor > > Add initcall_debug logs for the amount of time taken by each OF platform > bus device create call. For example: > >of platform device create /reserved-memory/ramoops@a380 took >3255 usecs > > initcall_debug alr

[PATCH v2] regulator: arizona-ldo1: Use correct device to get enable GPIO

2018-06-19 Thread Charles Keepax
Currently the enable GPIO is being looked up on the regulator device itself but that does not have its own DT node, this causes the lookup to fail and the regulator not to get its GPIO. The DT node is shared across the whole MFD and as such the lookup needs to happen on that parent device. Moving t

Re: Possible regression in "slab, slub: skip unnecessary kasan_cache_shutdown()"

2018-06-19 Thread Shakeel Butt
On Tue, Jun 19, 2018 at 6:05 AM Jason A. Donenfeld wrote: > > HI Dimitry, > > On Tue, Jun 19, 2018 at 6:55 AM Dmitry Vyukov wrote: > > Your code frees all entries before freeing the cache, right? If you > > add total_entries check before freeing the cache, it does not fire, > > right? > > Yes, ce

Re: [intel-sgx-kernel-dev] [PATCH v11 13/13] intel_sgx: in-kernel launch enclave

2018-06-19 Thread Jarkko Sakkinen
On Fri, Jun 08, 2018 at 11:50:14AM -0700, Andy Lutomirski wrote: > On Fri, Jun 8, 2018 at 10:32 AM Jarkko Sakkinen > wrote: > > > > The Launch Enclave (LE) generates cryptographic launch tokens for user > > enclaves. A launch token is used by EINIT to check whether the enclave > > is authorized to

Re: [PATCH 4.4 10/24] x86/fpu: Hard-disable lazy FPU mode

2018-06-19 Thread Ben Hutchings
On Fri, 2018-06-15 at 13:24 +0900, Daniel Sangorrin wrote: > Hi Greg, > > >  /* Intel-defined CPU features, CPUID level 0x0001 (ecx), word 4 */ > > --- a/arch/x86/include/asm/fpu/internal.h > > +++ b/arch/x86/include/asm/fpu/internal.h > > @@ -58,7 +58,7 @@ extern u64 fpu__get_supported_xfeatu

Re: [PATCH v11 09/13] x86, sgx: basic routines for enclave page cache

2018-06-19 Thread Jarkko Sakkinen
On Fri, Jun 08, 2018 at 11:24:12AM -0700, Dave Hansen wrote: > On 06/08/2018 10:09 AM, Jarkko Sakkinen wrote: > > SGX has a set of data structures to maintain information about the enclaves > > and their security properties. BIOS reserves a fixed size region of > > physical memory for these structu

Re: [PATCH 15/20] dts: arm: imx7{d,s}: Update coresight binding for hardware ports

2018-06-19 Thread Mathieu Poirier
On Mon, 18 Jun 2018 at 20:13, Shawn Guo wrote: > > Hi Stefan, > > Can you take a look at the patch? Thanks. > These bindings are still being discussed and patches related to them shouldn't be merged. The next iteration of this patchset will not included individual modifications to device tree f

Re: [PATCH 07/39] vfs: export vfs_ioctl() to modules

2018-06-19 Thread Al Viro
On Tue, Jun 19, 2018 at 04:34:33PM +0200, Miklos Szeredi wrote: > On Tue, Jun 19, 2018 at 4:24 PM, Christoph Hellwig wrote: > > On Tue, Jun 19, 2018 at 04:04:41PM +0200, Miklos Szeredi wrote: > >> FS_IOC* > >> > >> Haven't looked deeply. For now overlayfs just implements > >> FS_IOC_{GET|SET}FLAG

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Punit Agrawal
Lorenzo Pieralisi writes: > On Tue, Jun 19, 2018 at 01:52:16PM +0100, Punit Agrawal wrote: >> Michal Hocko writes: >> >> > On Tue 19-06-18 20:03:07, Xie XiuQi wrote: >> > [...] >> >> I tested on a arm board with 128 cores 4 numa nodes, but I set >> >> CONFIG_NR_CPUS=72. >> >> Then node 3 is no

Re: [PATCH 0/3] sched/swait: Convert to full exclusive mode

2018-06-19 Thread Paul E. McKenney
On Wed, Jun 13, 2018 at 06:27:42PM -0700, Paul E. McKenney wrote: > On Tue, Jun 12, 2018 at 10:34:49AM +0200, Peter Zijlstra wrote: > > As mentioned by Linus, swait is exclusive mode and had better behave like it > > and be named like it. > > > > Make it so. > > Cool! > > When I tried testing it

[PATCH v4] clk: add duty cycle support

2018-06-19 Thread Jerome Brunet
Add the possibility to apply and query the clock signal duty cycle ratio. This is useful when the duty cycle of the clock signal depends on some other parameters controlled by the clock framework. For example, the duty cycle of a divider may depends on the raw divider setting (ratio = N / div) ,

Re: [PATCH 07/39] vfs: export vfs_ioctl() to modules

2018-06-19 Thread Miklos Szeredi
On Tue, Jun 19, 2018 at 4:24 PM, Christoph Hellwig wrote: > On Tue, Jun 19, 2018 at 04:04:41PM +0200, Miklos Szeredi wrote: >> FS_IOC* >> >> Haven't looked deeply. For now overlayfs just implements >> FS_IOC_{GET|SET}FLAGS because some of these flags are quite generic >> and implementing them on

Re: [PATCH 4.4 173/268] sched/rt: Fix rq->clock_update_flags < RQCF_ACT_SKIP warning

2018-06-19 Thread Davidlohr Bueso
On Thu, 14 Jun 2018, Steven Rostedt wrote: Although the change log is a bit ambiguous in if it is fixing an actual miss update, or if it is just quieting a false positive. Davidlohr? It fixes an update, not a false positive. Thanks, Davidlohr

Re: [PATCH] of/platform: add initcall_debug logs for device creates

2018-06-19 Thread Rob Herring
On Mon, Jun 18, 2018 at 7:46 PM, Todd Poynor wrote: > From: Todd Poynor > > Add initcall_debug logs for the amount of time taken by each OF platform > bus device create call. For example: > >of platform device create /reserved-memory/ramoops@a380 took >3255 usecs > > initcall_debug a

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

2018-06-19 Thread Peter Zijlstra
On Tue, Jun 19, 2018 at 04:21:16PM +0200, Peter Zijlstra wrote: > On Tue, Jun 19, 2018 at 04:16:42PM +0200, Peter Zijlstra wrote: > > On Tue, Jun 19, 2018 at 02:38:45PM +0100, Quentin Perret wrote: > > > But maybe I could use something simpler than a lock in this case ? > > > Would WRITE_ONCE/READ_

Re: [PATCH 3/3] hwrng: msm - Add support for prng v2

2018-06-19 Thread Herbert Xu
On Mon, Jun 18, 2018 at 07:42:59PM +0530, Vinod Koul wrote: > Qcom 8996 and later chips support prng v2 where we need to only > implement .read callback for hwrng. > > Add a new table for v2 which supports this and get version required for > driver data. > > Signed-off-by: Vinod Koul Is this re

Re: [PATCH 4.4 00/24] 4.4.138-stable review

2018-06-19 Thread Ben Hutchings
On Thu, 2018-06-14 at 16:04 +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.138 release. > There are 24 patches in this series, all will be posted as a response > to this one.  If anyone has any issues with these being applied, please > let me know. > >

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

2018-06-19 Thread Quentin Perret
On Tuesday 19 Jun 2018 at 16:16:42 (+0200), Peter Zijlstra wrote: > On Tue, Jun 19, 2018 at 02:38:45PM +0100, Quentin Perret wrote: > > But maybe I could use something simpler than a lock in this case ? > > Would WRITE_ONCE/READ_ONCE be enough to ensure that atomicity for > > example ? > > Yes, si

Re: [PATCH 07/39] vfs: export vfs_ioctl() to modules

2018-06-19 Thread Christoph Hellwig
On Tue, Jun 19, 2018 at 04:04:41PM +0200, Miklos Szeredi wrote: > FS_IOC* > > Haven't looked deeply. For now overlayfs just implements > FS_IOC_{GET|SET}FLAGS because some of these flags are quite generic > and implementing them on the overlay is easy. > > Yes, turning into a method makes sense.

Re: [PATCH v10 3/7] x86/time: read_boot_clock64() implementation

2018-06-19 Thread Pavel Tatashin
> > > +void __init read_boot_clock64(struct timespec64 *now, struct timespec64 > > > *ts) > > > +{ > > > + u64 ns_boot = sched_clock_cpu(smp_processor_id()); > > > + bool valid_clock; > > > + u64 ns_now; > > > + > > > + ns_now = timespec64_to_ns(now); > > > + valid_cl

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

2018-06-19 Thread Peter Zijlstra
On Tue, Jun 19, 2018 at 04:16:42PM +0200, Peter Zijlstra wrote: > On Tue, Jun 19, 2018 at 02:38:45PM +0100, Quentin Perret wrote: > > But maybe I could use something simpler than a lock in this case ? > > Would WRITE_ONCE/READ_ONCE be enough to ensure that atomicity for > > example ? > > Yes, sinc

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

2018-06-19 Thread Peter Zijlstra
On Tue, Jun 19, 2018 at 02:38:45PM +0100, Quentin Perret wrote: > But maybe I could use something simpler than a lock in this case ? > Would WRITE_ONCE/READ_ONCE be enough to ensure that atomicity for > example ? Yes, since its a single pointer, smp_store_release() + READ_ONCE() should be sufficie

Re: INFO: task hung in __get_super

2018-06-19 Thread Dmitry Vyukov
On Tue, Jun 19, 2018 at 4:10 PM, Tetsuo Handa wrote: > On 2018/06/19 20:53, Dmitry Vyukov wrote: >> On Tue, Jun 19, 2018 at 1:44 PM, Tetsuo Handa >> wrote: >>> This bug report is getting no feedback, but I guess that this bug is in >>> block or mm or locking layer rather than fs layer. >>> >>> NM

Re: [PATCH 2/3] fs: fsnotify: account fsnotify metadata to kmemcg

2018-06-19 Thread Shakeel Butt
On Tue, Jun 19, 2018 at 12:20 AM Amir Goldstein wrote: > > On Tue, Jun 19, 2018 at 8:13 AM, Shakeel Butt wrote: > > A lot of memory can be consumed by the events generated for the huge or > > unlimited queues if there is either no or slow listener. This can cause > > system level memory pressure

Re: INFO: task hung in __get_super

2018-06-19 Thread Tetsuo Handa
On 2018/06/19 20:53, Dmitry Vyukov wrote: > On Tue, Jun 19, 2018 at 1:44 PM, Tetsuo Handa > wrote: >> This bug report is getting no feedback, but I guess that this bug is in >> block or mm or locking layer rather than fs layer. >> >> NMI backtrace for this bug tends to report that sb_bread() from

Re: [PATCH v4 1/1] nvme: trace: add disk name to tracepoints

2018-06-19 Thread Sagi Grimberg
On 06/11/2018 09:46 PM, Johannes Thumshirn wrote: Add disk name to tracepoints so we can better distinguish between individual disks in the trace output. Signed-off-by: Johannes Thumshirn --- I'm not entirely sure if this adding the ctrl pointers to nvme_complete_rq() and nvme_setup_cmd()

Re: [PATCH] staging: pi433: fix race condition in pi433_open

2018-06-19 Thread Dan Carpenter
On Tue, Jun 19, 2018 at 09:42:20AM -0400, Hugo Lefeuvre wrote: > This TODO seems to be related to this misunderstanding too: > > 890 /* TODO? guard against device removal before, or while, > 891 * we issue this ioctl. --> device_get() > 892 */ > > Device removal can't

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Lorenzo Pieralisi
On Tue, Jun 19, 2018 at 01:52:16PM +0100, Punit Agrawal wrote: > Michal Hocko writes: > > > On Tue 19-06-18 20:03:07, Xie XiuQi wrote: > > [...] > >> I tested on a arm board with 128 cores 4 numa nodes, but I set > >> CONFIG_NR_CPUS=72. > >> Then node 3 is not be created, because node 3 has no m

Re: [PATCH v11 09/13] x86, sgx: basic routines for enclave page cache

2018-06-19 Thread Jarkko Sakkinen
On Fri, Jun 08, 2018 at 11:21:48AM -0700, Jethro Beekman wrote: > On 2018-06-08 10:09, Jarkko Sakkinen wrote: > > +/* > > + * Writing the LE hash MSRs is extraordinarily expensive, e.g. > > + * 3-4x slower than normal MSRs, so we use a per-cpu cache to > > + * track the last known value of the MSRs

Re: [PATCH] regulator: arizona-ldo1: Use correct device to get enable GPIO

2018-06-19 Thread Charles Keepax
On Tue, Jun 19, 2018 at 02:24:33PM +0200, Matthias Reichl wrote: > On Tue, Jun 19, 2018 at 10:32:45AM +0100, Charles Keepax wrote: > > + config.ena_gpiod = gpiod_get_optional(parent_dev, "wlf,ldoena", > > + GPIOD_OUT_HIGH); > > The WM5102 datasheet lists L

Re: [PATCH 07/39] vfs: export vfs_ioctl() to modules

2018-06-19 Thread Miklos Szeredi
On Mon, Jun 11, 2018 at 6:24 PM, Christoph Hellwig wrote: > On Mon, Jun 11, 2018 at 09:19:01AM +0200, Miklos Szeredi wrote: >> We don't. Obviously need to make sure to only ever do ioctl's in >> overlayfs that have a common definition across filesystems. Not a lot >> of those, luckily... > > Whi

[PATCH] sched/core: Remove useless hrtimer_active check

2018-06-19 Thread Daniel Lezcano
The function tick_clear() checks if the timer is active and in this case cancels the timer. However, hrtimer_cancel does the same check. Perhaps, this test is made on purpose to skip some function calls for efficiency reasons but if it is not the case we can safely remove it. Signed-off-by: Danie

Re: [PATCH v11 04/13] x86, sgx: add SGX definitions to msr-index.h

2018-06-19 Thread Dave Hansen
On 06/19/2018 06:18 AM, Jarkko Sakkinen wrote: > On Fri, Jun 08, 2018 at 10:25:29AM -0700, Dave Hansen wrote: >> On 06/08/2018 10:09 AM, Jarkko Sakkinen wrote: >>> Signed-off-by: Sean Christopherson >>> Signed-off-by: Haim Cohen >>> Tested-by: Serge Ayoun >>> Reviewed-by: Jarkko Sakkinen >>> Te

Re: [PATCH v3 0/8] vfio: ccw: Refactoring the VFIO CCW state machine

2018-06-19 Thread Cornelia Huck
On Thu, 14 Jun 2018 10:06:31 +0200 Pierre Morel wrote: > I tried to make a better description to add later in documentation > or in the next cover-letter. > > Note that in the current patch series I did not implement online/offline > events but just kept the previous state changes. > Not sure if

Re: [PATCH v2 0/4] have the vt console preserve unicode characters

2018-06-19 Thread Dave Mielke
[quoted lines by Adam Borowski on 2018/06/19 at 15:09 +0200] >You're thinking small. That 256 possible values for Braille are easily >encodable within the 512-glyph space (256 char + stolen fg brightness bit, >another CGA peculiarity). Not at all. We braille users, especially when working with

Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-19 Thread Rohit Kumar
Thanks Srinivas for reviewing. On 6/19/2018 2:16 PM, Srinivas Kandagatla wrote: Thanks Rohit for the patch! On 18/06/18 12:16, Rohit kumar wrote: This patch adds sdm845 audio machine driver support. Signed-off-by: Rohit kumar ---   .../devicetree/bindings/sound/qcom,sdm845.txt  |  87 ++

Re: [PATCH v10 13/14] cpufreq: Add module to register cpufreq on Krait CPUs

2018-06-19 Thread Sudeep Holla
On 19/06/18 14:45, Sricharan R wrote: > From: Stephen Boyd > > Register a cpufreq-generic device whenever we detect that a > "qcom,krait" compatible CPU is present in DT. > Just curious to know how different is this from qcom kryo driver that was added recently. IIRC even that gets the speed

Re: [PATCH v1]: perf tests: check that complex event name is parsed correctly

2018-06-19 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 19, 2018 at 11:45:40AM +0300, Alexey Budankov escreveu: > > Extend regression testing to cover case of complex event names enabled > by the patch "perf record: enable arbitrary event names thru name= modifier". > > tools/perf/perf test > 1: vmlinux symtab matches kallsyms

Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-19 Thread Rohit Kumar
Thanks Vinod for reviewing. On 6/19/2018 10:35 AM, Vinod wrote: On 18-06-18, 16:46, Rohit kumar wrote: +struct sdm845_snd_data { + struct snd_soc_card *card; + struct regulator *vdd_supply; + struct snd_soc_dai_link dai_link[]; +}; + +static struct mutex pri_mi2s_res_lock; +

[PATCH v10 02/14] clk: qcom: Add support for High-Frequency PLLs (HFPLLs)

2018-06-19 Thread Sricharan R
From: Stephen Boyd HFPLLs are the main frequency source for Krait CPU clocks. Add support for changing the rate of these PLLs. Signed-off-by: Stephen Boyd --- drivers/clk/qcom/Makefile| 1 + drivers/clk/qcom/clk-hfpll.c | 244 +++ drivers/clk/qcom/

[PATCH v10 06/14] clk: qcom: Add IPQ806X's HFPLLs

2018-06-19 Thread Sricharan R
From: Stephen Boyd Describe the HFPLLs present on IPQ806X devices. Signed-off-by: Stephen Boyd --- drivers/clk/qcom/gcc-ipq806x.c | 82 ++ 1 file changed, 82 insertions(+) diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c inde

Re: [PATCH 2/6] irqchip/ls-scfg-msi: Fix MSI affinity handling

2018-06-19 Thread Thomas Gleixner
On Tue, 19 Jun 2018, Marc Zyngier wrote: > diff --git a/drivers/irqchip/irq-ls-scfg-msi.c > b/drivers/irqchip/irq-ls-scfg-msi.c > index 2811cc53e425..c671b3212010 100644 > --- a/drivers/irqchip/irq-ls-scfg-msi.c > +++ b/drivers/irqchip/irq-ls-scfg-msi.c > @@ -93,8 +93,12 @@ static void ls_scfg_msi

[PATCH v10 08/14] clk: qcom: Add KPSS ACC/GCC driver

2018-06-19 Thread Sricharan R
From: Stephen Boyd The ACC and GCC regions present in KPSSv1 contain registers to control clocks and power to each Krait CPU and L2. For CPUfreq purposes probe these devices and expose a mux clock that chooses between PXO and PLL8. Cc: Signed-off-by: Stephen Boyd --- drivers/clk/qcom/Kconfig

[PATCH v10 09/14] dt-bindings: arm: Document qcom,kpss-gcc

2018-06-19 Thread Sricharan R
From: Stephen Boyd The ACC and GCC regions present in KPSSv1 contain registers to control clocks and power to each Krait CPU and L2. Documenting the bindings here. Reviewed-by: Rob Herring Signed-off-by: Stephen Boyd --- [v10] Updated to add clocks and clock-names property newly .../devicetr

[PATCH v10 12/14] clk: qcom: Add safe switch hook for krait mux clocks

2018-06-19 Thread Sricharan R
When the Hfplls are reprogrammed during the rate change, the primary muxes which are sourced from the same hfpll for higher frequencies, needs to be switched to the 'safe secondary mux' as the parent for that small window. This is done by registering a clk notifier for the muxes and switching to th

[PATCH v10 13/14] cpufreq: Add module to register cpufreq on Krait CPUs

2018-06-19 Thread Sricharan R
From: Stephen Boyd Register a cpufreq-generic device whenever we detect that a "qcom,krait" compatible CPU is present in DT. Acked-by: Viresh Kumar [Sricharan: updated to use dev_pm_opp_set_prop_name and nvmem apis] Signed-off-by: Sricharan R [Thierry Escande: update to add support

[PATCH v10 14/14] dt-bindings: cpufreq: Document operating-points-v2-krait-cpu

2018-06-19 Thread Sricharan R
In Certain QCOM SoCs like ipq8064, apq8064, msm8960, msm8974 that has KRAIT processors the voltage/current value of each OPP varies based on the silicon variant in use. operating-points-v2-krait-cpu specifies the phandle to nvmem efuse cells and the operating-points-v2 table for each opp. The qcom-

[PATCH v10 10/14] clk: qcom: Add Krait clock controller driver

2018-06-19 Thread Sricharan R
From: Stephen Boyd The Krait CPU clocks are made up of a primary mux and secondary mux for each CPU and the L2, controlled via cp15 accessors. For Kraits within KPSSv1 each secondary mux accepts a different aux source, but on KPSSv2 each secondary mux accepts the same aux source. Cc: Signed-off

[PATCH v10 11/14] dt-bindings: clock: Document qcom,krait-cc

2018-06-19 Thread Sricharan R
From: Stephen Boyd The Krait clock controller controls the krait CPU and the L2 clocks consisting a primary mux and secondary mux. Add document for that. Reviewed-by: Rob Herring Signed-off-by: Stephen Boyd --- [v10] updated to include clocks and clock-names property newly .../devicetree/bi

[PATCH v10 07/14] clk: qcom: Add support for Krait clocks

2018-06-19 Thread Sricharan R
From: Stephen Boyd The Krait clocks are made up of a series of muxes and a divider that choose between a fixed rate clock and dedicated HFPLLs for each CPU. Instead of using mmio accesses to remux parents, the Krait implementation exposes the remux control via cp15 registers. Support these clocks

Re: [PATCH] Input: elan: enable middle button of touchpads on ThinkPad P52

2018-06-19 Thread Benjamin Tissoires
On Tue, Jun 19, 2018 at 3:13 PM Aaron Ma wrote: > > On 06/19/2018 08:21 PM, Benjamin Tissoires wrote: > > On Tue, Jun 12, 2018 at 9:10 AM Aaron Ma wrote: > >> PNPID is better way to identify the type of touchpads. > >> Enable middle button support on 2 types of touchpads on Lenovo P52. > >> > >>

[PATCH v10 04/14] dt-bindings: clock: Document qcom,hfpll

2018-06-19 Thread Sricharan R
From: Stephen Boyd Adds bindings document for qcom,hfpll instantiated within the Krait processor subsystem as separate register region. Reviewed-by: Rob Herring Signed-off-by: Stephen Boyd --- [v10] Updated to add clocks and clock-names properties newly .../devicetree/bindings/clock/qcom,hfp

[PATCH v10 05/14] clk: qcom: Add MSM8960/APQ8064's HFPLLs

2018-06-19 Thread Sricharan R
From: Stephen Boyd Describe the HFPLLs present on MSM8960 and APQ8064 devices. Acked-by: Rob Herring (bindings) Signed-off-by: Stephen Boyd --- drivers/clk/qcom/gcc-msm8960.c | 172 +++ include/dt-bindings/clock/qcom,gcc-msm8960.h | 2 + 2 files changed

[PATCH v10 03/14] clk: qcom: Add HFPLL driver

2018-06-19 Thread Sricharan R
From: Stephen Boyd On some devices (MSM8974 for example), the HFPLLs are instantiated within the Krait processor subsystem as separate register regions. Add a driver for these PLLs so that we can provide HFPLL clocks for use by the system. Cc: Signed-off-by: Stephen Boyd --- drivers/clk/qcom/

[PATCH v10 01/14] ARM: Add Krait L2 register accessor functions

2018-06-19 Thread Sricharan R
From: Stephen Boyd Krait CPUs have a handful of L2 cache controller registers that live behind a cp15 based indirection register. First you program the indirection register (l2cpselr) to point the L2 'window' register (l2cpdr) at what you want to read/write. Then you read/write the 'window' regi

[PATCH v10 00/14] Krait clocks + Krait CPUfreq

2018-06-19 Thread Sricharan R
[v10] * Addressed Stephen's comments to add clocks bindings properties to the newly introduced nodes. * Added a change to include opp-supported-hw to qcom-cpufreq.c * Rebased on top of clk-next * Although there were minor changes to bindings and the driver retained the acked-by tags

Re: [RFC PATCH] x86/arch_prctl: Add ARCH_SET_XCR0 to mask XCR0 per-thread

2018-06-19 Thread Andi Kleen
> In particular 1) means that any extra instructions executed/not executed > will cause a replay divergence (in practice rr uses retired conditional > branches rather than instructions, because the instruction counter is > not accurate, while the branch one is). This alone causes a problem > for th

Re: [PATCH] staging: pi433: fix race condition in pi433_open

2018-06-19 Thread Hugo Lefeuvre
> > It would be great to get rid of this counter, indeed. But how to do it > > properly without breaking things ? It seems to be useful to me... > > These things are refcounted so you can't unload the module while a file > is open. When we do an open it does a cdev_get(). When we call the > dele

[PATCH 1/2] clk: qcom: drop CLK_SET_RATE_GATE from sdc clocks

2018-06-19 Thread Jerome Brunet
the mmci driver (drivers/mmc/host/mmci.c) does the following sequence: * clk_prepare_enable() * clk_set_rate() on SDCx_clk which is a children of SDCx_src. SDCx_src has CLK_SET_RATE_GATE so this sequence should not be allowed but this was not enforced. IOW, the flag is ignored. Dropping the flag w

[PATCH 2/2] clk: fix CLK_SET_RATE_GATE with clock rate protection

2018-06-19 Thread Jerome Brunet
CLK_SET_RATE_GATE should prevent any operation which may result in a rate change or glitch while the clock is prepared/enabled. IOW, the following sequence is not allowed anymore with CLK_SET_RATE_GATE: * clk_get() * clk_prepare_enable() * clk_get_rate() * clk_set_rate() At the moment this is enf

Re: Possible regression in "slab, slub: skip unnecessary kasan_cache_shutdown()"

2018-06-19 Thread Jason A. Donenfeld
On Tue, Jun 19, 2018 at 3:31 PM Dmitry Vyukov wrote: > Since I already looked at the code, if init and uninit can be called > concurrently, I think there is a prominent race condition between init > and uninit: a concurrent uninit can run concurrnetly with the next > init and this will totally mes

[PATCH 0/2] clk: enforce CLK_SET_RATE_GATE along the tree

2018-06-19 Thread Jerome Brunet
This is a resend of the last unmerged patch of the clock protect v5 [0] patchset. It makes use of the clock protection mechanism to fix and enforce CLK_SET_RATE_GATE flag. With this flag set, any operation resulting in a rate change or glitch should be prevented. This might be useful when, for exa

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

2018-06-19 Thread Quentin Perret
On Tuesday 19 Jun 2018 at 15:23:38 (+0200), Peter Zijlstra wrote: > On Tue, Jun 19, 2018 at 01:58:58PM +0100, Quentin Perret wrote: > > On Tuesday 19 Jun 2018 at 13:34:08 (+0200), Peter Zijlstra wrote: > > > On Mon, May 21, 2018 at 03:24:58PM +0100, Quentin Perret wrote: > > > > +struct em_freq_dom

Re: [PATCH v11 11/13] intel_sgx: ptrace() support

2018-06-19 Thread Jarkko Sakkinen
On Mon, Jun 11, 2018 at 08:02:09AM -0700, Sean Christopherson wrote: > On Fri, 2018-06-08 at 11:34 -0700, Dave Hansen wrote: > > On 06/08/2018 10:09 AM, Jarkko Sakkinen wrote: > > > > > > + ret = sgx_edbgrd(encl, entry, align, data); > > > + if (ret) > > > + break;

Re: linux-next: manual merge of the vfs tree with the overlayfs tree

2018-06-19 Thread Miklos Szeredi
On Tue, Jun 19, 2018 at 10:40 AM, David Howells wrote: > Stephen Rothwell wrote: > >> /* These sb flags are internal to the kernel */ >> #define MS_SUBMOUNT (1<<26) >> -#define MS_NOREMOTELOCK (1<<27) >> #define MS_NOSEC (1<<28) >> #define MS_BORN (1<<29) >> #define

Re: [RFC PATCH] ARM: Use logical or instead of addition for badr address calculation

2018-06-19 Thread Ard Biesheuvel
On 19 June 2018 at 15:29, Guenter Roeck wrote: > Hi Ard, > > > On 06/19/2018 12:48 AM, Ard Biesheuvel wrote: >> >> On 19 June 2018 at 07:07, Guenter Roeck wrote: >>> >>> Modern assemblers may take the ISA into account when resolving local >>> symbols. This can result in bad address calculations w

Re: [PATCH v11 07/13] x86, sgx: detect Intel SGX

2018-06-19 Thread Jarkko Sakkinen
On Mon, Jun 11, 2018 at 07:35:21AM -0400, Neil Horman wrote: > On Fri, Jun 08, 2018 at 07:09:42PM +0200, Jarkko Sakkinen wrote: > > From: Sean Christopherson > > > > Intel(R) SGX is a set of CPU instructions that can be used by applications > > to set aside private regions of code and data. The c

Re: [PATCH v11 07/13] x86, sgx: detect Intel SGX

2018-06-19 Thread Jarkko Sakkinen
On Fri, Jun 08, 2018 at 10:36:14AM -0700, Dave Hansen wrote: > > +config INTEL_SGX_CORE > > + prompt "Intel SGX core functionality > > + depends on X86_64 && CPU_SUP_INTEL > > + help > > + Intel Software Guard eXtensions (SGX) is a set of CPU instructions > > + that allows ring 3 applicat

[PATCH for 4.18 3/3] rseq: cleanup: no need to abort rseq c.s. in child on fork

2018-06-19 Thread Mathieu Desnoyers
Considering that we explicitly forbid system calls in rseq critical sections, it is not valid to issue a fork or clone system call within a rseq critical section, so rseq_fork() is not required to restart an active rseq c.s. in the child process. Signed-off-by: Mathieu Desnoyers Cc: Thomas Gleixn

[PATCH for 4.18 2/3] rseq/selftests: arm: align struct rseq_cs on 32 bytes

2018-06-19 Thread Mathieu Desnoyers
uapi/linux/rseq.h aligns struct rseq_cs on 32 bytes. Satisfy this alignment requirement in its definition within the rseq-arm.h inline assembly. Signed-off-by: Mathieu Desnoyers Cc: Thomas Gleixner Cc: Joel Fernandes Cc: Peter Zijlstra Cc: Catalin Marinas Cc: Dave Watson Cc: Will Deacon Cc:

[PATCH for 4.18 0/3] rseq: minor fixes, cleanup

2018-06-19 Thread Mathieu Desnoyers
Hi Thomas, Those are 2 small fixes, and a cleanup to the rseq feature, targeting 4.18. The first fix takes care of an issue that arose in the integration of the rseq patchset (executable bit on run_param_test.sh was lost). The second fix aligns struct rseq_cs on 32 bytes on arm32, following the r

[PATCH for 4.18 1/3] rseq/selftests: run_param_test.sh should be executable

2018-06-19 Thread Mathieu Desnoyers
The executable bit of the run_param_test.sh script got lost in the merge. Signed-off-by: Mathieu Desnoyers Cc: Thomas Gleixner Cc: Joel Fernandes Cc: Peter Zijlstra Cc: Catalin Marinas Cc: Dave Watson Cc: Will Deacon Cc: Shuah Khan Cc: Andi Kleen Cc: linux-kselft...@vger.kernel.org Cc: "H

Re: [PATCH 2/6] device: Add #define dev_fmt similar to #define pr_fmt

2018-06-19 Thread Joe Perches
Greg? Ping? The patches to impi have hit -next and the impi code works differently without this patch. On Wed, 2018-05-09 at 08:15 -0700, Joe Perches wrote: > Add a prefixing macro to dev_ uses similar to the pr_fmt > prefixing macro used in pr_ calls. > > This can help avoid some string dupli

Re: [PATCH v11 12/13] intel_sgx: driver documentation

2018-06-19 Thread Jarkko Sakkinen
On Fri, Jun 08, 2018 at 02:41:07PM -0700, Randy Dunlap wrote: > On 06/08/2018 10:09 AM, Jarkko Sakkinen wrote: > > Documentation of the features of the Software Guard eXtensions usable > > for the Linux kernel and how the driver internals uses these features. > > In addition, contains documentatio

Re: [PATCH] printk: Make CONSOLE_LOGLEVEL_QUIET configurable

2018-06-19 Thread Steven Rostedt
On Tue, 19 Jun 2018 13:57:26 +0200 Hans de Goede wrote: > The goal of passing the "quiet" option to the kernel is for the kernel > to be quiet unless something really is wrong. > > Sofar passing quiet has been (mostly) equivalent to passing > loglevel=4 on the kernel commandline. Which means to

Re: Possible regression in "slab, slub: skip unnecessary kasan_cache_shutdown()"

2018-06-19 Thread Dmitry Vyukov
On Tue, Jun 19, 2018 at 3:25 PM, Jason A. Donenfeld wrote: > On Tue, Jun 19, 2018 at 7:06 AM Shakeel Butt wrote: >> Currently refcnt in your >> code can underflow, through it does not seem like the selftest will >> cause the underflow but still you should fix it. > > Indeed, and if this happened

Re: [PATCH v11 10/13] intel_sgx: driver for Intel Software Guard Extensions

2018-06-19 Thread Jarkko Sakkinen
On Fri, Jun 08, 2018 at 12:35:51PM -0700, Dave Hansen wrote: > > +#define sgx_pr_ratelimited(level, encl, fmt, ...) \ > > + pr_ ## level ## _ratelimited("[%d:0x%p] " fmt, \ > > +pid_nr((encl)->tgid), \ > > +

[PATCH V9] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-19 Thread Daniel Lezcano
Initially, the cpu_cooling device for ARM was changed by adding a new policy inserting idle cycles. The intel_powerclamp driver does a similar action. Instead of implementing idle injections privately in the cpu_cooling device, move the idle injection code in a dedicated framework and give the opp

Re: [RFC PATCH] ARM: Use logical or instead of addition for badr address calculation

2018-06-19 Thread Guenter Roeck
Hi Ard, On 06/19/2018 12:48 AM, Ard Biesheuvel wrote: On 19 June 2018 at 07:07, Guenter Roeck wrote: Modern assemblers may take the ISA into account when resolving local symbols. This can result in bad address calculations when using badr in the wrong location since the offset + 1 may be added

Re: [PATCH v2] printk: make sure to print log on console.

2018-06-19 Thread Steven Rostedt
On Tue, 19 Jun 2018 18:49:53 +0900 Sergey Senozhatsky wrote: > On (06/19/18 11:32), Petr Mladek wrote: > > > - if (suppress_message_printing(msg->level)) { > > > + if (!ignore_loglevel && (msg->flags & LOG_NOCONS)) { > > > > > > > > > `ignore_loglevel' is a module pa

Re: Possible regression in "slab, slub: skip unnecessary kasan_cache_shutdown()"

2018-06-19 Thread Jason A. Donenfeld
On Tue, Jun 19, 2018 at 7:06 AM Shakeel Butt wrote: > Currently refcnt in your > code can underflow, through it does not seem like the selftest will > cause the underflow but still you should fix it. Indeed, and if this happened this would be a bug in the caller, not the ratelimiter itself, kind

<    1   2   3   4   5   6   7   8   9   >