Re: [PATCH 3/4] tty: Lock tty pair in tty_init_dev()

2018-08-30 Thread Jiri Slaby
On 08/29/2018, 06:28 PM, Dmitry Safonov wrote: > On Wed, 2018-08-29 at 16:46 +0200, Jiri Slaby wrote: >> On 08/29/2018, 04:23 AM, Dmitry Safonov wrote: >>> It's safe to not lock both here - done to silence attempt lockdep >>> assert in >>> tty_ldisc_open(), which will be added with following patch.

Re: Affinity managed interrupts vs non-managed interrupts

2018-08-30 Thread Ming Lei
On Wed, Aug 29, 2018 at 6:47 PM Sumit Saxena wrote: > > > -Original Message- > > From: Ming Lei [mailto:ming@redhat.com] > > Sent: Wednesday, August 29, 2018 2:16 PM > > To: Sumit Saxena > > Cc: t...@linutronix.de; h...@lst.de; linux-kernel@vger.kernel.org > > Subject: Re: Affinity ma

Re: [PATCH 2/4] tty: Hold tty_ldisc_lock() during tty_reopen()

2018-08-30 Thread Jiri Slaby
On 08/29/2018, 05:19 PM, Tetsuo Handa wrote: > On 2018/08/29 11:23, Dmitry Safonov wrote: >> tty_ldisc_reinit() doesn't race with neither tty_ldisc_hangup() >> nor set_ldisc() nor tty_ldisc_release() as they use tty lock. >> But it races with anyone who expects line discipline to be the same >> aft

Re: [PATCH 1/4] tty: Drop tty->count on tty_reopen() failure

2018-08-30 Thread Jiri Slaby
On 08/29/2018, 06:13 PM, Dmitry Safonov wrote: >> I would just do: >> if (!retval) >> tty->count++; >> here. Nobody from ldiscs should rely on tty->count. > > I thought about that and probably should have described in commit > message why I haven't done that: I prefer to keep it as was as I

Re: 4.19.0-rc1 rtsx_pci_sdmmc.0: error: data->host_cookie = 62, host->cookie = 63

2018-08-30 Thread Ulf Hansson
On 30 August 2018 at 21:06, Douglas Gilbert wrote: > On 2018-08-30 02:03 PM, Ulf Hansson wrote: >> >> On 28 August 2018 at 23:47, Douglas Gilbert wrote: >>> >>> I usually boot my Lenovo X270 with a SD card in its: >>># lspci >>> 02:00.0 Unassigned class [ff00]: Realtek Semiconductor Co., Ltd.

Re: [PATCH v2] riscv: Do not overwrite initrd_start and initrd_end

2018-08-30 Thread Christoph Hellwig
On Tue, Aug 28, 2018 at 05:33:46PM -0700, Guenter Roeck wrote: > setup_initrd() overwrites initrd_start and initrd_end if __initramfs_size > is larger than 0, which is always true even if there is no embedded > initramfs. This prevents booting qemu with "-initrd" parameter. > Overwriting initrd_sta

Re: [PATCH v2 3/3] RISC-V: Support cpu hotplug.

2018-08-30 Thread Christoph Hellwig
> +#else > +static inline bool can_hotplug_cpu(void) { return 0; } > +static inline void arch_send_call_wakeup_ipi(int cpu) { } Please use normal coding style for these stubs. > #define INTERRUPT_CAUSE_FLAG (1UL << (__riscv_xlen - 1)) > +#define get_scause(cause)(cause & ~INTERRUPT_CAUSE_FLA

Re: [PATCH] x86, mm: Reserver some memory for bootmem allocator for NO_BOOTMEM

2018-08-30 Thread Feng Tang
On Thu, Aug 30, 2018 at 03:25:42PM +0200, Thomas Gleixner wrote: > And where is the problem? We know that we need the fixmap during early boot > anyway, so allocating the PTE page statically and setting it up early > enough is not really rocket science. No allocator required. Further check shows

Re: [PATCH v2 2/3] RISC-V: Use Linux logical cpu number instead of hartid

2018-08-30 Thread Christoph Hellwig
> -#define flush_tlb_all() sbi_remote_sfence_vma(NULL, 0, -1) > +static inline void remote_sfence_vma(struct cpumask *cmask, unsigned long > start, > + unsigned long size) > +{ > + struct cpumask hmask; > + > + riscv_cpuid_to_hartid_mask(cmask, &hmask); > +

Re: [PATCH v2 1/3] RISC-V: Add logical CPU indexing for RISC-V

2018-08-30 Thread Christoph Hellwig
On Tue, Aug 28, 2018 at 01:36:08AM -0700, Atish Patra wrote: > Currently, both linux cpu id and hardware cpu id are same. > This is not recommended as it will lead to discontinuous cpu > indexing in Linux. Moreover, kdump kernel will run from CPU0 > which would be absent if we follow existing schem

Re: [PATCH v2] fs: Convert return type int to vm_fault_t

2018-08-30 Thread Souptick Joarder
On Fri, Aug 31, 2018 at 5:03 AM Andrew Morton wrote: > > On Thu, 30 Aug 2018 22:55:47 +0530 Souptick Joarder > wrote: > > > Return type for fault handlers in ext4 and nilfs are > > changed to use vm_fault_t. > > > > Return type of block_page_mkwrite() is changed from > > int to vm_fault_t. The

Re: [PATCH 2/2] power: supply: Add Spreadtrum SC2731 charger support

2018-08-30 Thread Baolin Wang
Hi Sebastian, On 31 August 2018 at 05:27, Sebastian Reichel wrote: > Hi, > > On Thu, Aug 30, 2018 at 11:08:59AM +0800, Baolin Wang wrote: >> >> +static int sc2731_charger_hw_init(struct sc2731_charger_info *info) >> >> +{ >> >> + int ret; >> >> + >> >> + /* Enable charger module */ >>

Re: [PATCH 5/8] RISC-V: Rename im_okay_therefore_i_am to found_boot_cpu

2018-08-30 Thread Christoph Hellwig
On Thu, Aug 30, 2018 at 09:11:11AM -0700, Atish Patra wrote: > On 8/30/18 7:41 AM, Christoph Hellwig wrote: > > > struct device_node *dn = NULL; > > > - int hart, im_okay_therefore_i_am = 0; > > > + int hart, found_boot_cpu = 0; > > > > If you rename this anyway please switch to use a bo

Re: [PATCH v6 1/2] leds: core: Introduce LED pattern trigger

2018-08-30 Thread Baolin Wang
Hi Jacek, On 31 August 2018 at 03:55, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/30/2018 09:40 AM, Baolin Wang wrote: >> Some LED controllers have support for autonomously controlling >> brightness over time, according to some preprogrammed pattern or >> function. > > I think that this commit

[PATCH V6 3/4] clk: add managed version of clk_bulk_get_all

2018-08-30 Thread Dong Aisheng
This patch introduces the managed version of clk_bulk_get_all. Cc: Michael Turquette Cc: Stephen Boyd Tested-by: Thor Thayer Signed-off-by: Dong Aisheng --- v3->v4: * improve 'devres->clks = *clks' according to Stephen's suggestion v2->v3: * a minor fix of build warning on PowerPC platform.

[PATCH V6 2/4] clk: add new APIs to operate on all available clocks

2018-08-30 Thread Dong Aisheng
This patch introduces of_clk_bulk_get_all and clk_bulk_x_all APIs to users who just want to handle all available clocks from device tree without need to know the detailed clock information likes clock numbers and names. This is useful in writing some generic drivers to handle clock part. Cc: Steph

Re: v4.17 regression: PowerMac G3 won't boot, was Re: [PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

2018-08-30 Thread Benjamin Herrenschmidt
On Fri, 2018-08-31 at 14:35 +1000, Benjamin Herrenschmidt wrote: > > > If I force output with "-f", the resulting file has no occurrences > > of "phandle". > > Are you booting with BootX or Open Firmware ? Assuming you are using BootX (or miBoot), can you try this patch ? --- a/arch/powerpc/pl

[PATCH V6 4/4] video: simplefb: switch to use clk_bulk API to simplify clock operations

2018-08-30 Thread Dong Aisheng
Switching to use clk_bulk API to simplify clock operations. Cc: Hans de Goede Cc: Bartlomiej Zolnierkiewicz Cc: linux-fb...@vger.kernel.org Cc: Masahiro Yamada Cc: Stephen Boyd Tested-by: Thor Thayer Signed-off-by: Dong Aisheng --- v5->v6: * address Hans's comments v4->v5: * fix wrong sett

[PATCH V6 0/4] clk: new APIs to handle all available clocks

2018-08-30 Thread Dong Aisheng
This patch series is a continue of discussion from here, https://patchwork.kernel.org/patch/9986293/ that some users may want to handle all available clocks from device tree without need to know the detailed clock information likes clock numbers and names. This is useful in writing some generic dri

[PATCH V6 1/4] clk: bulk: add of_clk_bulk_get()

2018-08-30 Thread Dong Aisheng
'clock-names' property is optional in DT, so of_clk_bulk_get() is introduced here to handle this for DT users without 'clock-names' specified. Later clk_bulk_get_all() will be implemented on top of it and this API will be kept private until someone proves they need it because they don't have a stru

Re: [PATCH 0/6] x86/alternatives: text_poke() fixes

2018-08-30 Thread Masami Hiramatsu
On Fri, 31 Aug 2018 13:46:35 +0900 Masami Hiramatsu wrote: > On Thu, 30 Aug 2018 10:32:12 -0700 > Nadav Amit wrote: > > > This patch-set addresses some issues that were raised in a recent > > correspondence and might affect the security and the correctness of code > > patching. (Note that patch

Re: [PATCH 0/6] x86/alternatives: text_poke() fixes

2018-08-30 Thread Masami Hiramatsu
On Thu, 30 Aug 2018 10:32:12 -0700 Nadav Amit wrote: > This patch-set addresses some issues that were raised in a recent > correspondence and might affect the security and the correctness of code > patching. (Note that patching performance is not addressed by this > patch-set). > > The main issu

Re: [RFC PATCH 2/6] x86/mm: temporary mm struct

2018-08-30 Thread Masami Hiramatsu
On Wed, 29 Aug 2018 18:59:52 -0700 Andy Lutomirski wrote: > > > > On Aug 29, 2018, at 6:38 PM, Masami Hiramatsu wrote: > > > > On Wed, 29 Aug 2018 08:41:00 -0700 > > Andy Lutomirski wrote: > > > >>> On Wed, Aug 29, 2018 at 2:49 AM, Masami Hiramatsu > >>> wrote: > >>> On Wed, 29 Aug 2018 0

Re: [PATCH] x86/mce: Fix set_mce_nospec() to avoid #GP fault

2018-08-30 Thread Linus Torvalds
On Thu, Aug 30, 2018 at 6:49 PM Tony Luck wrote: > > Just checking "do we have a non-canonical address" at the bottom of that > call stack and flipping bit 63 back on again seems like a bad idea. You could literally do something like /* Make it canonical in case we flipped the high bit */

Re: 32-bit PTI with THP = userspace corruption

2018-08-30 Thread Meelis Roos
> > I am seeing userland corruption and application crashes on multiple > > 32-bit machines with 4.19-rc1+git. The machines vary: PII, PIII, P4. > > They are all Intel. AMD Duron/Athlon/AthlonMP have been fine in my tests > > so far (may be configuration dependent). > > Thanks for the report! I

Re: [PATCH v3] rpmsg: qcom_smd: Access APCS through mailbox framework

2018-08-30 Thread Bjorn Andersson
On Thu 30 Aug 20:57 PDT 2018, Frank Rowand wrote: > Hi Bjorn, > > > On 04/19/18 18:17, Bjorn Andersson wrote: > > Attempt to acquire the APCS IPC through the mailbox framework and fall > > back to the old syscon based approach, to allow us to move away from > > using the syscon. > > > > Reviewe

Re: [PATCH v3] rpmsg: qcom_smd: Access APCS through mailbox framework

2018-08-30 Thread Frank Rowand
On 08/30/18 20:57, Frank Rowand wrote: > Hi Bjorn, > > > On 04/19/18 18:17, Bjorn Andersson wrote: >> Attempt to acquire the APCS IPC through the mailbox framework and fall >> back to the old syscon based approach, to allow us to move away from >> using the syscon. >> >> Reviewed-by: Arun Kumar N

Re: [PATCH v3] rpmsg: qcom_smd: Access APCS through mailbox framework

2018-08-30 Thread Frank Rowand
On 08/30/18 20:57, Frank Rowand wrote: > Hi Bjorn, > > > On 04/19/18 18:17, Bjorn Andersson wrote: >> Attempt to acquire the APCS IPC through the mailbox framework and fall >> back to the old syscon based approach, to allow us to move away from >> using the syscon. >> >> Reviewed-by: Arun Kumar N

Re: [PATCH v3] rpmsg: qcom_smd: Access APCS through mailbox framework

2018-08-30 Thread Frank Rowand
Hi Bjorn, On 04/19/18 18:17, Bjorn Andersson wrote: > Attempt to acquire the APCS IPC through the mailbox framework and fall > back to the old syscon based approach, to allow us to move away from > using the syscon. > > Reviewed-by: Arun Kumar Neelakantam > Signed-off-by: Bjorn Andersson > ---

Re: VirtIO console hangs

2018-08-30 Thread Nicholas Piggin
On Tue, 28 Aug 2018 15:00:14 + Matteo Croce wrote: > On Tue, Aug 28, 2018 at 2:35 PM Nicholas Piggin wrote: > > > > On Tue, 28 Aug 2018 12:54:08 + > > Matteo Croce wrote: > > > > > With kernel 4.19.0-rc1 virtio_console hangs very often. > > > I can always trigger the bug by pasting so

linux-next: Signed-off-by missing for commit in the arc-current tree

2018-08-30 Thread Stephen Rothwell
Hi Vineet, Commit c0a7bc6e5585 ("ARC: atomics: unbork atomic_fetch_##op()") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell pgp8axos1HTI4.pgp Description: OpenPGP digital signature

Re: [PATCH 0/2] ARM: dts: socfpga: Add support for PMU on Arria5/Cyclone5

2018-08-30 Thread Marek Vasut
On 03/08/2017 04:19 PM, Dinh Nguyen wrote: > > > On 02/28/2017 09:52 AM, Florian Vaussard wrote: >> Hi, >> >> These patches add suport for ARM Performance Monitor Units on Arria5 and >> Cyclone5 SoCFPGA. This was tested on a Cyclone 5 SoC DK board. >> >> Side note: the same change can be probably

Re: [PATCH] remoteproc: qcom: Rename Hexagon v5 PAS driver

2018-08-30 Thread Bjorn Andersson
On Wed 29 Aug 02:25 PDT 2018, Niklas Cassel wrote: > On Mon, Aug 27, 2018 at 10:12:03PM -0700, Bjorn Andersson wrote: > > The Hexagon v5 ADSP driver is used for more than only the ADSP and > > there's an upcoming non-PAS ADSP PIL for SDM845, so rename the driver to > > qcom_q6v5_pas in order to be

Re: [PATCH] x86/pkeys: Explicitly treat PK #PF on kernel address as a bad area

2018-08-30 Thread Andy Lutomirski
> On Aug 30, 2018, at 7:38 PM, Jann Horn wrote: > >> On Tue, 7 Aug 2018 Dave Hansen wrote: >> >>> On 08/07/2018 10:29 AM, Sean Christopherson wrote: >>> if (unlikely(fault_in_kernel_space(address))) { >>> + /* >>> + * We should never encounter a protection keys

linux-next: Tree for Aug 31

2018-08-30 Thread Stephen Rothwell
Hi all, Changes since 20180830: Dropped trees: xarray, ida (temporarily) Non-merge commits (relative to Linus' tree): 1248 1497 files changed, 48772 insertions(+), 16144 deletions(-) I have created today&#x

Re: [PATCH 2/2] mm: zero remaining unavailable struct pages

2018-08-30 Thread Naoya Horiguchi
On Wed, Aug 29, 2018 at 11:16:30AM -0400, Masayoshi Mizuma wrote: > Hi Horiguchi-san and Pavel > > Thank you for your comments! > The Pavel's additional patch looks good to me, so I will add it to this > series. > > However, unfortunately, the movable_node option has something wrong yet... > Whe

tools/include/asm-generic/bitsperlong.h:14:2: error: #error Inconsistent word size. Check asm/bitsperlong.h

2018-08-30 Thread kbuild test robot
Hi Alexei, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 217c3e0196758662aa0429863b09d1c13da1c5d6 commit: 819dd92b9c0bc7bce9097d8c1f14240f471bb386 bpfilter: switch to CC from HOSTCC date: 3 months ago config: al

Re: [PATCH] x86/pkeys: Explicitly treat PK #PF on kernel address as a bad area

2018-08-30 Thread Jann Horn
On Tue, 7 Aug 2018 Dave Hansen wrote: > > On 08/07/2018 10:29 AM, Sean Christopherson wrote: > > if (unlikely(fault_in_kernel_space(address))) { > > + /* > > + * We should never encounter a protection keys fault on a > > + * kernel address as kernel addr

import from China/safe transport & good price

2018-08-30 Thread 949713...@qq.com
Dear Sir: Good day Simon greeting from Everbright international logistics co.,ltd,and we specialize in overseas international logistics for 15 years,our major core business scope cover: International sea freight International air freight International courier service Local logistics servi

Re: [PATCH tip/core/rcu 01/19] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-08-30 Thread Byungchul Park
On Thu, Aug 30, 2018 at 02:10:32PM -0400, Steven Rostedt wrote: > On Wed, 29 Aug 2018 15:20:29 -0700 > "Paul E. McKenney" wrote: > > > This commit also changes order of execution from this: > > > > rcu_dynticks_task_exit(); > > rcu_dynticks_eqs_exit(); > > trace_rcu_dyntick(); > >

Re: [PATCH 20/23] mm: percpu: remove unnecessary unlikely()

2018-08-30 Thread Dennis Zhou
On Fri, Aug 31, 2018 at 01:34:26AM +0300, Igor Stoppa wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to > wrap it into another. > > Signed-off-by: Igor Stoppa > Cc: zijun_hu > Cc: Tejun Heo > Cc: Christoph Lameter > Cc: Dennis Zhou > --- > mm/percpu.c | 2 +- > 1 fi

Re: [PATCH] x86/mce: Fix set_mce_nospec() to avoid #GP fault

2018-08-30 Thread Tony Luck
On Thu, Aug 30, 2018 at 6:30 PM Linus Torvalds wrote: > > On Thu, Aug 30, 2018 at 2:45 PM Tony Luck wrote: > > > > Fix is to move one step at a time. First mark the page not present > > (using the decoy address). Then it is safe to use the actual address > > of the 1:1 mapping to mark it "uc", an

Re: [PATCH v2 1/2] dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller

2018-08-30 Thread Hanjie Lin
On 2018/8/30 21:59, Rob Herring wrote: > On Thu, Aug 30, 2018 at 2:37 AM Hanjie Lin wrote: >> >> >> >> On 2018/8/29 8:41, Rob Herring wrote: >>> On Mon, Aug 27, 2018 at 04:55:20PM +0800, Hanjie Lin wrote: On 2018/8/24 16:22, Jerome Brunet wrote: > On Fri, 2018-08-24 at 15:36

RE: [PATCH 2/2] clk: imx: imx7d: remove clks_init_on array

2018-08-30 Thread Anson Huang
Hi, Stephen Anson Huang Best Regards! > -Original Message- > From: Stephen Boyd > Sent: Friday, August 31, 2018 9:29 AM > To: ker...@pengutronix.de; linux-arm-ker...@lists.infradead.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > mturque...@baylibre.com; s.ha...@pengut

Re: [PATCH] staging: android: ion: check for kref overflow

2018-08-30 Thread Daniel Rosenberg
On 08/30/2018 05:41 PM, Greg Kroah-Hartman wrote: On Thu, Aug 30, 2018 at 04:09:46PM -0700, Daniel Rosenberg wrote: This patch is against 4.9. It does not apply to master due to a large rework of ion in 4.12 which removed the affected functions altogther. 4c23cbff073f3b9b ("staging: android: ion

WARNING in enter_vmx_operation

2018-08-30 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:3f16503b7d22 Merge branch 'fixes' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16c7df6a40 kernel config: https://syzkaller.appspot.com/x/.config?x=49927b422dcf0b29 da

Re: [PATCH] clk: mediatek: remove unused array audio_parents

2018-08-30 Thread Stephen Boyd
Quoting Colin King (2018-08-06 06:44:02) > From: Colin Ian King > > Array audio_parents is declared but never used, hence it is redundant > and can be removed. > > Cleans up clang warning: > warning: 'audio_parents' defined but not used [-Wunused-const-variable=] > > Signed-off-by: Colin Ian Ki

RE: [PATCH 2/2] clk: imx: imx7d: remove clks_init_on array

2018-08-30 Thread Stephen Boyd
Quoting Peng Fan (2018-08-12 18:15:41) > Hi Anson, > > > > > -Original Message- > > > > From: Anson Huang > > > > Sent: 2018年8月8日 12:39 > > > > To: shawn...@kernel.org; s.ha...@pengutronix.de; > > > > ker...@pengutronix.de; Fabio Estevam ; > > > > mturque...@baylibre.com; sb...@kernel.org;

Re: [PATCH] x86/mce: Fix set_mce_nospec() to avoid #GP fault

2018-08-30 Thread Linus Torvalds
On Thu, Aug 30, 2018 at 2:45 PM Tony Luck wrote: > > Fix is to move one step at a time. First mark the page not present > (using the decoy address). Then it is safe to use the actual address > of the 1:1 mapping to mark it "uc", and finally as present. Can't we do it in one step, but make sure th

Re: [PATCH v3] clk: qcom: Add camera clock controller driver for SDM845

2018-08-30 Thread Stephen Boyd
Quoting Amit Nischal (2018-08-08 03:47:19) > Add support for the camera clock controller found on SDM845 > based devices. This would allow camera drivers to probe and > control their clocks. > > Signed-off-by: Amit Nischal > --- Applied to clk-next

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-30 Thread Benjamin Herrenschmidt
On Mon, 2018-08-27 at 19:02 +1000, Nicholas Piggin wrote: > > More tlbies ? With the cost of the broadasts on the fabric ? I don't > > think so.. or I'm not understanding your point... > > More tlbies are no good, but there will be some places where it works > out much better (and fewer tlbies). W

Re: [PATCH 09/12] asm-generic/tlb: Track which levels of the page tables have been cleared

2018-08-30 Thread Nicholas Piggin
On Thu, 30 Aug 2018 17:15:43 +0100 Will Deacon wrote: > It is common for architectures with hugepage support to require only a > single TLB invalidation operation per hugepage during unmap(), rather than > iterating through the mapping at a PAGE_SIZE increment. Currently, > however, the level in

Re: [PATCH 0/3] firmware: qcom: scm: Improve clock handling

2018-08-30 Thread Bjorn Andersson
On Thu 30 Aug 18:07 PDT 2018, Stephen Boyd wrote: > Quoting Bjorn Andersson (2018-08-29 16:15:02) > > We're currently facing the issue that every new platform requires the > > addition > > of a compatible to the DT binding as well as the driver. > > > > The DT binding patch to allow us to use qc

Re: linux-next: disabling -Wstringop-truncation

2018-08-30 Thread Linus Torvalds
On Thu, Aug 30, 2018 at 3:07 PM Stephen Rothwell wrote: > > I am now mainly using gcc v8.2 for my builds and -Wstringop-truncation > causes so many warnings that I am sure to miss others, so I have > applied the below to my fixes tree until the noise reduces. Applied. If people want the warning

Re: [PATCH v8 0/5] Support for Qualcomm UFS QMP PHY on SDM845

2018-08-30 Thread Bjorn Andersson
On Thu 30 Aug 03:44 PDT 2018, Vivek Gautam wrote: > On Thu, Aug 30, 2018 at 11:46 AM Bjorn Andersson > wrote: > > > > On Tue 31 Jul 03:09 PDT 2018, Can Guo wrote: > > > > > This patch series adds support for UFS QMP PHY on SDM845 and the > > > compatible string for it. This patch series depends o

Re: [PATCH 0/3] firmware: qcom: scm: Improve clock handling

2018-08-30 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-08-29 16:15:02) > We're currently facing the issue that every new platform requires the addition > of a compatible to the DT binding as well as the driver. > > The DT binding patch to allow us to use qcom,scm for all these new platforms > that doesn't require any cloc

Re: [PATCH 3/3] dt-bindings: firmware: scm: Add MSM8998 and SDM845

2018-08-30 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-08-29 16:15:05) > Now that the compatible/clock handling is reworked add compatibles for > MSM8998 and SDM845 to the SCM binding. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/3] firmware: qcom: scm: Refactor clock handling

2018-08-30 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-08-29 16:15:04) > At one point in time all "future" platforms required three clocks, so > the binding and driver was written to treat this as the default case. > But new platforms has no clock requirements, which currently makes them > all a special case, causing the n

Re: [PATCH 1/3] dt-bindings: firmware: scm: Refactor compatibles and clocks

2018-08-30 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-08-29 16:15:03) > When the binding was written all "future" platforms required three > clocks, so the default compatible (qcom,scm) was defined to require > this. But as history shows all "future" platforms actually lack required > clocks. Given how the binding is writ

Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-30 Thread Linus Torvalds
On Thu, Aug 30, 2018 at 6:01 PM Nicholas Piggin wrote: > > Well it would help if powerpc say wanted to start using them without a > merge cycle lag. Not a huge issue because powerpc already does > reasonably well here and there's other work that can be done. Sure. If somebody wants to send the ge

Re: [PATCH 00/12] Avoid synchronous TLB invalidation for intermediate page-table entries on arm64

2018-08-30 Thread Nicholas Piggin
On Thu, 30 Aug 2018 09:39:38 -0700 Linus Torvalds wrote: > On Thu, Aug 30, 2018 at 9:15 AM Will Deacon wrote: > > > > It's also had a lot more testing, but has held up nicely so far on arm64. > > I haven't figured out how to merge this yet, but I'll probably end up > > pulling > > the core chan

Re: [RFT PATCH 2/2] pinctrl: spmi-mpp: Fix pmic_mpp_config_get() to be compliant

2018-08-30 Thread Stephen Boyd
Quoting Douglas Anderson (2018-08-30 08:23:39) > If you look at "pinconf-groups" in debugfs for ssbi-mpp you'll notice > it looks like nonsense. > > The problem is fairly well described in commit 1cf86bc21257 ("pinctrl: > qcom: spmi-gpio: Fix pmic_gpio_config_get() to be compliant") and > commit 0

Re: [RFT PATCH 1/2] pinctrl: ssbi-gpio: Fix pm8xxx_pin_config_get() to be compliant

2018-08-30 Thread Stephen Boyd
Quoting Douglas Anderson (2018-08-30 08:23:38) > If you look at "pinconf-groups" in debugfs for ssbi-gpio you'll notice > it looks like nonsense. > > The problem is fairly well described in commit 1cf86bc21257 ("pinctrl: > qcom: spmi-gpio: Fix pmic_gpio_config_get() to be compliant") and > commit

[PATCH] pinctrl: qcom: spmi-mpp: Fix drive strength setting

2018-08-30 Thread Stephen Boyd
It looks like we parse the drive strength setting here, but never actually write it into the hardware to update it. Parse the setting and then write it at the end of the pinconf setting function so that it actually sticks in the hardware. Fixes: 0e948042c420 ("pinctrl: qcom: spmi-mpp: Implement su

Re: [PATCH tip/core/rcu 3/3] srcu: Make early-boot call_srcu() reuse workqueue lists

2018-08-30 Thread Steven Rostedt
On Thu, 30 Aug 2018 17:09:52 -0700 "Paul E. McKenney" wrote: > On Thu, Aug 30, 2018 at 07:53:22PM -0400, Steven Rostedt wrote: > > On Thu, 30 Aug 2018 16:12:11 -0700 > > "Paul E. McKenney" wrote: > > > > > > > > > - WARN_ON_ONCE(rcu_scheduler_active == RCU_SCHEDULER_INIT); > > > > >

Re: linux-next: Signed-off-by missing for commit in the ipmi tree

2018-08-30 Thread Corey Minyard
On 08/30/2018 04:37 PM, Stephen Rothwell wrote: Hi Corey, Commit 6320fd2c65b5 ("ipmi: fix return value of ipmi_set_my_LUN") is missing a Signed-off-by from its committer. Thanks, got it. -corey

Re: [PATCH V3] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

2018-08-30 Thread Stephen Boyd
Quoting Dilip Kota (2018-08-24 03:42:15) > + > +static int __maybe_unused spi_geni_suspend(struct device *dev) > +{ > + if (!pm_runtime_status_suspended(dev)) > + return -EBUSY; This looks odd. Why are we doing this? The i2c driver had a recent fix from Evan squashed in that re

Re: [PATCH v2 6/9] net: bcmgenet: fix OF child-node lookup

2018-08-30 Thread Florian Fainelli
On 08/27/2018 01:21 AM, Johan Hovold wrote: > Use the new of_get_compatible_child() helper to lookup the mdio child > node instead of using of_find_compatible_node(), which searches the > entire tree from a given start node and thus can return an unrelated > (i.e. non-child) node. > > This also ad

Re: [PATCH] staging: android: ion: check for kref overflow

2018-08-30 Thread Greg Kroah-Hartman
On Thu, Aug 30, 2018 at 04:09:46PM -0700, Daniel Rosenberg wrote: > This patch is against 4.9. It does not apply to master due to a large > rework of ion in 4.12 which removed the affected functions altogther. > 4c23cbff073f3b9b ("staging: android: ion: Remove import interface") > > Userspace can

Re: [PATCH v2] KVM: LAPIC: Fix pv ipis out-of-bounds access

2018-08-30 Thread Wanpeng Li
On Thu, 30 Aug 2018 at 19:01, Radim Krčmář wrote: > > 2018-08-30 10:03+0800, Wanpeng Li: > > From: Wanpeng Li > > > > Dan Carpenter reported that the untrusted data returns from > > kvm_register_read() > > results in the following static checker warning: > > arch/x86/kvm/lapic.c:576 kvm_pv_sen

Re: [PATCH 2/2] scripts: add kmemleak2pprof.py for slab usage analysis

2018-08-30 Thread Andrew Morton
On Thu, 30 Aug 2018 09:29:40 +0200 Vincent Whitchurch wrote: > On Tue, Aug 28, 2018 at 04:28:04PM -0700, Andrew Morton wrote: > > On Tue, 28 Aug 2018 12:39:14 +0200 Vincent Whitchurch > > wrote: > > > > > Add a script which converts /sys/kernel/debug/kmemleak_all to the pprof > > > format, wh

Re: [PATCH tip/core/rcu 3/3] srcu: Make early-boot call_srcu() reuse workqueue lists

2018-08-30 Thread Paul E. McKenney
On Thu, Aug 30, 2018 at 07:53:22PM -0400, Steven Rostedt wrote: > On Thu, 30 Aug 2018 16:12:11 -0700 > "Paul E. McKenney" wrote: > > > > > > - WARN_ON_ONCE(rcu_scheduler_active == RCU_SCHEDULER_INIT); > > > > > > Well it boots without warning ;-) > > > > > > Tested-by: Steven Rostedt (

[GIT PULL] Power management fixes for v4.19-rc2

2018-08-30 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-4.19-rc2 with top-most commit a0b9c4de7bf3dacc32a7e70fff25e158a0bf848f Merge branch 'pm-core' on top of commit dfec4a8478e8e81483a94b663f13153bb7796800 Merge tag 'pm-4.19-rc1-2' of gi

Re: [PATCH tip/core/rcu 3/3] srcu: Make early-boot call_srcu() reuse workqueue lists

2018-08-30 Thread Steven Rostedt
On Thu, 30 Aug 2018 16:12:11 -0700 "Paul E. McKenney" wrote: > > > - WARN_ON_ONCE(rcu_scheduler_active == RCU_SCHEDULER_INIT); > > > > Well it boots without warning ;-) > > > > Tested-by: Steven Rostedt (VMware) > > Thank you again! I applied this to 1/3 and 3/3 on the assumption that

Re: [PATCH 2/3] ARM: dts: am335x: add support for Moxa UC-2101 open platform

2018-08-30 Thread Grygorii Strashko
On 08/29/2018 11:09 PM, SZ Lin (林上智) wrote: Add support for Moxa UC-2101 open platform The UC-2101 computing platform is designed for industrial embedded data acquisition and processing applications. The features of UC-2101 are: * eMMC * SPI flash * 1x LAN * 1x RS-232/422/485 ports, software

Re: [PATCH v2 22/32] selftests/ftrace: Add ringbuffer size changing testcase

2018-08-30 Thread Steven Rostedt
On Fri, 31 Aug 2018 08:35:28 +0900 Masami Hiramatsu wrote: > On Thu, 30 Aug 2018 11:50:55 -0400 > Steven Rostedt wrote: > > > On Thu, 30 Aug 2018 16:12:18 +0900 > > Masami Hiramatsu wrote: > > > > > > I'm fine with this, but one day I need to port over some of my other > > > > tests. I have

Re: [PATCH v2] fs: Convert return type int to vm_fault_t

2018-08-30 Thread Andrew Morton
On Thu, 30 Aug 2018 22:55:47 +0530 Souptick Joarder wrote: > Return type for fault handlers in ext4 and nilfs are > changed to use vm_fault_t. > > Return type of block_page_mkwrite() is changed from > int to vm_fault_t. The function signature of > block_page_mkwrite() is changed to add one new

Re: [PATCH v2 22/32] selftests/ftrace: Add ringbuffer size changing testcase

2018-08-30 Thread Masami Hiramatsu
On Thu, 30 Aug 2018 11:50:55 -0400 Steven Rostedt wrote: > On Thu, 30 Aug 2018 16:12:18 +0900 > Masami Hiramatsu wrote: > > > > I'm fine with this, but one day I need to port over some of my other > > > tests. I have a test that stresses the ring buffer size (basically > > > checks to see if it

Re: [PATCH v2] fs: Convert return type int to vm_fault_t

2018-08-30 Thread Andrew Morton
On Thu, 30 Aug 2018 22:55:47 +0530 Souptick Joarder wrote: > Return type for fault handlers in ext4 and nilfs are > changed to use vm_fault_t. > > Return type of block_page_mkwrite() is changed from > int to vm_fault_t. The function signature of > block_page_mkwrite() is changed to add one new

Re: [PATCH] x86/pkeys: Explicitly treat PK #PF on kernel address as a bad area

2018-08-30 Thread Dave Hansen
On 08/30/2018 03:40 AM, Thomas Gleixner wrote: > Given the time span you should be close to ground water with your digging > by now. So, turns out that we start our spurious_fault() code with this check: > if (error_code != (X86_PF_WRITE | X86_PF_PROT) && > error_code != (X86_

Re: [PATCH] lib/parser.c: switch match_strdup() over to use kmemdup_nul()

2018-08-30 Thread Andrew Morton
On Thu, 30 Aug 2018 12:44:36 -0700 Eric Biggers wrote: > From: Eric Biggers > > This simplifies the code. No change in behavior. > > ... > > --- a/lib/parser.c > +++ b/lib/parser.c > @@ -327,10 +327,6 @@ EXPORT_SYMBOL(match_strlcpy); > */ > char *match_strdup(const substring_t *s) > { > -

Re: [PATCH tip/core/rcu 3/3] srcu: Make early-boot call_srcu() reuse workqueue lists

2018-08-30 Thread Paul E. McKenney
On Thu, Aug 30, 2018 at 02:36:17PM -0400, Steven Rostedt wrote: > On Thu, 30 Aug 2018 10:37:42 -0700 > "Paul E. McKenney" wrote: > > > > > > But still triggered the following: > > > > > > > > WARNING: CPU: 0 PID: 0 at > > > > /work/git/linux-trace.git/kernel/rcu/srcutree.c:242 > > > > check_

Re: [PATCH 5/7] mm/hmm: use a structure for update callback parameters

2018-08-30 Thread Balbir Singh
On Fri, Aug 24, 2018 at 03:25:47PM -0400, jgli...@redhat.com wrote: > From: Jérôme Glisse > > Use a structure to gather all the parameters for the update callback. > This make it easier when adding new parameters by avoiding having to > update all callback function signature. > > Signed-off-by:

[PATCH] staging: android: ion: check for kref overflow

2018-08-30 Thread Daniel Rosenberg
This patch is against 4.9. It does not apply to master due to a large rework of ion in 4.12 which removed the affected functions altogther. 4c23cbff073f3b9b ("staging: android: ion: Remove import interface") Userspace can cause the kref to handles to increment arbitrarily high. Ensure it does not

Re: [PATCH 05/23] selftest: vm: add unlikely() to BUG_ON()

2018-08-30 Thread Dmitry Safonov
On Thu, 2018-08-30 at 23:57 +0100, Dmitry Safonov wrote: > Hi Igor, > > On Fri, 2018-08-31 at 01:34 +0300, Igor Stoppa wrote: > > BUG_ON() is unlikely() to BUG() > > This selftest runs in userspace.. > So, we should define the macro somehow, as i.e: > rseq/rseq.h:#define rseq_unlikely(x)__bui

Re: [PATCH tip/core/rcu 01/19] rcu: Refactor rcu_{nmi,irq}_{enter,exit}()

2018-08-30 Thread Paul E. McKenney
On Thu, Aug 30, 2018 at 02:10:32PM -0400, Steven Rostedt wrote: > On Wed, 29 Aug 2018 15:20:29 -0700 > "Paul E. McKenney" wrote: > > > This commit also changes order of execution from this: > > > > rcu_dynticks_task_exit(); > > rcu_dynticks_eqs_exit(); > > trace_rcu_dyntick(); > >

Re: [PATCH 05/23] selftest: vm: add unlikely() to BUG_ON()

2018-08-30 Thread Dmitry Safonov
Hi Igor, On Fri, 2018-08-31 at 01:34 +0300, Igor Stoppa wrote: > BUG_ON() is unlikely() to BUG() This selftest runs in userspace.. So, we should define the macro somehow, as i.e: rseq/rseq.h:#define rseq_unlikely(x)__builtin_expect(!!(x), 0) Otherwise, [selftests]$ make vm/map_populate cc

Re: [PATCH 18/23] infiniband: scsi: remove unnecessary unlikely()

2018-08-30 Thread Bart Van Assche
On Thu, Aug 30, 2018 at 3:35 PM Igor Stoppa wrote: > > WARN_ON() already contains an unlikely(), so it's not necessary to > wrap it into another. Reviewed-by: Bart Van Assche

Re: linux-next: disabling -Wstringop-truncation

2018-08-30 Thread Stephen Rothwell
Hi Andi, On Thu, 30 Aug 2018 15:32:06 -0700 Andi Kleen wrote: > > Stephen Rothwell writes: > > > I am now mainly using gcc v8.2 for my builds and -Wstringop-truncation > > causes so many warnings that I am sure to miss others, so I have > > applied the below to my fixes tree until the noise red

[PATCH 09/23] cpufreq: remove unnecessary unlikely()

2018-08-30 Thread Igor Stoppa
WARN_ON() already contains an unlikely(), so it's not necessary to wrap it into another. Signed-off-by: Igor Stoppa Cc: "Rafael J. Wysocki" Cc: Srivatsa S. Bhat --- drivers/cpufreq/cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers

[PATCH 22/23] powerpc: remove unnecessary unlikely()

2018-08-30 Thread Igor Stoppa
WARN_ON() already contains an unlikely(), so it's not necessary to wrap it into another. Signed-off-by: Igor Stoppa Cc: Arseny Solokha Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman --- arch/powerpc/mm/tlb_nohash.c | 2 +- arch/powerpc/sysdev/xive/common.c | 2 +- 2

[PATCH 23/23] scsi: remove unnecessary unlikely()

2018-08-30 Thread Igor Stoppa
BUG_ON() already contains an unlikely(), there is no need for another one. Signed-off-by: Igor Stoppa Cc: "Martin K. Petersen" Cc: "James E.J. Bottomley" --- drivers/scsi/scsi_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/s

[PATCH 16/23] lvm: device mapper: remove unnecessary unlikely()

2018-08-30 Thread Igor Stoppa
WARN_ON() already contains an unlikely(), so it's not necessary to wrap it into another. Signed-off-by: Igor Stoppa Cc: Joe Thornber Cc: Alasdair Kergon --- drivers/md/dm-cache-policy-smq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-cache-policy-smq.c b/d

[PATCH 13/23] freescale: ethernet: remove unnecessary unlikely()

2018-08-30 Thread Igor Stoppa
Both WARN_ON() and WARN_ONCE() already contain an unlikely(), so it's not necessary to wrap it into another. Signed-off-by: Igor Stoppa Cc: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/et

[PATCH 18/23] infiniband: scsi: remove unnecessary unlikely()

2018-08-30 Thread Igor Stoppa
WARN_ON() already contains an unlikely(), so it's not necessary to wrap it into another. Signed-off-by: Igor Stoppa Cc: Bart Van Assche --- drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/

Re: [PATCH v1 5/5] mm/memory_hotplug: print only with DEBUG_VM in online/offline_pages()

2018-08-30 Thread Pasha Tatashin
On 8/20/18 6:46 AM, David Hildenbrand wrote: > On 16.08.2018 12:06, David Hildenbrand wrote: >> Let's try to minimze the noise. >> >> Signed-off-by: David Hildenbrand >> --- >> mm/memory_hotplug.c | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_

[PATCH 21/23] filesystems: remove unnecessary unlikely()

2018-08-30 Thread Igor Stoppa
WARN_ON() already contains an unlikely(), so it's not necessary to wrap it into another. Signed-off-by: Igor Stoppa Cc: Alexander Viro --- fs/open.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/open.c b/fs/open.c index 0285ce7dbd51..19a9e4b378d3 100644 --- a/fs/open.c

[PATCH 10/23] wireless: remove unnecessary unlikely()

2018-08-30 Thread Igor Stoppa
WARN_ON_ONCE() already contains an unlikely(), and the logical or of two of them is still unlikely(), so it's not necessary to wrap them into another. Signed-off-by: Igor Stoppa Cc: Christian Lamparter Cc: Kalle Valo --- drivers/net/wireless/ath/carl9170/tx.c | 4 ++-- 1 file changed, 2 insert

[PATCH 20/23] mm: percpu: remove unnecessary unlikely()

2018-08-30 Thread Igor Stoppa
WARN_ON() already contains an unlikely(), so it's not necessary to wrap it into another. Signed-off-by: Igor Stoppa Cc: zijun_hu Cc: Tejun Heo Cc: Christoph Lameter Cc: Dennis Zhou --- mm/percpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/percpu.c b/mm/percpu.c i

[PATCH 01/23] infiniband: nes: add unlikely() to assert()

2018-08-30 Thread Igor Stoppa
Typically the assert is expected to not fail. Signed-off-by: Igor Stoppa Cc: Chien Tung Cc: Roland Dreier Cc: Faisal Latif Cc: Doug Ledford Cc: Jason Gunthorpe --- drivers/infiniband/hw/nes/nes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/nes/n

  1   2   3   4   5   6   7   >