Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Russell King - ARM Linux
On Sun, Nov 25, 2018 at 11:11:05AM +, Russell King - ARM Linux wrote: > On Sat, Nov 24, 2018 at 05:07:17PM -0800, Tony Lindgren wrote: > > * Russell King - ARM Linux [181124 20:10]: > > > On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > > > > Hi, > > > > > > > > On Fri, Nov

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Russell King - ARM Linux
On Sun, Nov 25, 2018 at 11:11:05AM +, Russell King - ARM Linux wrote: > On Sat, Nov 24, 2018 at 05:07:17PM -0800, Tony Lindgren wrote: > > * Russell King - ARM Linux [181124 20:10]: > > > On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > > > > Hi, > > > > > > > > On Fri, Nov

Re: [PATCH v2 5/5] Staging: iio: adt7316: Use device tree data to assign irq_type

2018-11-25 Thread Jonathan Cameron
On Wed, 21 Nov 2018 15:02:52 +0530 Shreeya Patel wrote: > On Wed, 2018-11-21 at 08:21 +, Ardelean, Alexandru wrote: > > On Tue, 2018-11-20 at 22:30 +0530, Shreeya Patel wrote: > > > ADT7316 driver no more uses platform data and hence use device tree > > > data instead of platform data for

Re: [PATCH v2 5/5] Staging: iio: adt7316: Use device tree data to assign irq_type

2018-11-25 Thread Jonathan Cameron
On Wed, 21 Nov 2018 15:02:52 +0530 Shreeya Patel wrote: > On Wed, 2018-11-21 at 08:21 +, Ardelean, Alexandru wrote: > > On Tue, 2018-11-20 at 22:30 +0530, Shreeya Patel wrote: > > > ADT7316 driver no more uses platform data and hence use device tree > > > data instead of platform data for

Re: [PATCH v2 4/5] Staging: iio: adt7316: Change the name from irq_flags to irq_type

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 22:28:36 +0530 Shreeya Patel wrote: > Most of the drivers in IIO uses irq_type as the name for > storing the interrupt type and hence change the name from > irq_flags to irq_type for maintaining the consistency. > > Signed-off-by: Shreeya Patel Applied to the togreg branch

Re: [PATCH v2 4/5] Staging: iio: adt7316: Change the name from irq_flags to irq_type

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 22:28:36 +0530 Shreeya Patel wrote: > Most of the drivers in IIO uses irq_type as the name for > storing the interrupt type and hence change the name from > irq_flags to irq_type for maintaining the consistency. > > Signed-off-by: Shreeya Patel Applied to the togreg branch

Re: [PATCH v2 3/5] Staging: iio: adt7316: Switch irq_flags to a local variable

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 22:26:58 +0530 Shreeya Patel wrote: > There is no need to store irq_flags into the structure as it > is always set to the same thing. Hence switch irq_flags to a > local variable. > > Signed-off-by: Shreeya Patel Applied to the togreg branch of iio.git and pushed out as

Re: [PATCH v2 3/5] Staging: iio: adt7316: Switch irq_flags to a local variable

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 22:26:58 +0530 Shreeya Patel wrote: > There is no need to store irq_flags into the structure as it > is always set to the same thing. Hence switch irq_flags to a > local variable. > > Signed-off-by: Shreeya Patel Applied to the togreg branch of iio.git and pushed out as

Re: [PATCH v2 2/5] Staging: iio: adt7316: Use device tree data to set ldac_pin

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 22:24:36 +0530 Shreeya Patel wrote: > Make the driver use device tree instead of the platform data. > Hence, use devm_gpiod_get_optional function to get the data from > device tree for ldac-pin and accordingly make the needed changes > in the driver. > > Signed-off-by:

Re: [PATCH v2 2/5] Staging: iio: adt7316: Use device tree data to set ldac_pin

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 22:24:36 +0530 Shreeya Patel wrote: > Make the driver use device tree instead of the platform data. > Hence, use devm_gpiod_get_optional function to get the data from > device tree for ldac-pin and accordingly make the needed changes > in the driver. > > Signed-off-by:

Re: [PATCH v2 1/5] Staging: iio: adt7316: Add of_device_id table

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 22:22:30 +0530 Shreeya Patel wrote: > When the kernel starts up, it kicks off compiled-in drivers > that match “compatible” entries it finds in the device tree. > At a later stage (when /lib/modules is available), all kernel modules > that match “compatible” entries in the

Re: [PATCH v2 1/5] Staging: iio: adt7316: Add of_device_id table

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 22:22:30 +0530 Shreeya Patel wrote: > When the kernel starts up, it kicks off compiled-in drivers > that match “compatible” entries it finds in the device tree. > At a later stage (when /lib/modules is available), all kernel modules > that match “compatible” entries in the

Re: [PATCH v2 2/2] dt-bindings: iio: adc: Add docs for AD7606 ADC

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 17:44:37 +0200 Stefan Popa wrote: > Document support for AD7606 Analog to Digital Converter. > > Signed-off-by: Stefan Popa This looks good to me, but given my recent inability to pick up on the subtle (and not so subtle) issues in DT patches, I'd like a review from the DT

Re: [PATCH v2 2/2] dt-bindings: iio: adc: Add docs for AD7606 ADC

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 17:44:37 +0200 Stefan Popa wrote: > Document support for AD7606 Analog to Digital Converter. > > Signed-off-by: Stefan Popa This looks good to me, but given my recent inability to pick up on the subtle (and not so subtle) issues in DT patches, I'd like a review from the DT

Re: [PATCH v2 1/2] staging: iio: ad7606: Move out of staging

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 17:43:46 +0200 Stefan Popa wrote: > Move ad7606 ADC driver out of staging and into the mainline. > > Signed-off-by: Stefan Popa One idle thought, how much would the performance suffer if we moved the parallel path over to the new gpiod_get/set_raw_array_value and friends?

Re: [PATCH v2 1/2] staging: iio: ad7606: Move out of staging

2018-11-25 Thread Jonathan Cameron
On Tue, 20 Nov 2018 17:43:46 +0200 Stefan Popa wrote: > Move ad7606 ADC driver out of staging and into the mainline. > > Signed-off-by: Stefan Popa One idle thought, how much would the performance suffer if we moved the parallel path over to the new gpiod_get/set_raw_array_value and friends?

Re: [PATCH] ALSA: pcm: Fix starvation on down_write_nonblock()

2018-11-25 Thread kbuild test robot
Hi Chanho, I love your patch! Yet something to improve: [auto build test ERROR on sound/for-next] [also build test ERROR on v4.20-rc3 next-20181123] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] ALSA: pcm: Fix starvation on down_write_nonblock()

2018-11-25 Thread kbuild test robot
Hi Chanho, I love your patch! Yet something to improve: [auto build test ERROR on sound/for-next] [also build test ERROR on v4.20-rc3 next-20181123] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: WARNING in sysfs_remove_group (2)

2018-11-25 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:e195ca6cb6f2 Merge branch 'for-linus' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1659a62b40 kernel config:

Re: WARNING in sysfs_remove_group (2)

2018-11-25 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:e195ca6cb6f2 Merge branch 'for-linus' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1659a62b40 kernel config:

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 05:07:17PM -0800, Tony Lindgren wrote: > * Russell King - ARM Linux [181124 20:10]: > > On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > > > Hi, > > > > > > On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > > > > On 22/11/2018 17.12,

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 05:07:17PM -0800, Tony Lindgren wrote: > * Russell King - ARM Linux [181124 20:10]: > > On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > > > Hi, > > > > > > On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > > > > On 22/11/2018 17.12,

Re: [PATCH] staging: iio: ad7780: Add gain & filter gpio support

2018-11-25 Thread Jonathan Cameron
On Thu, 22 Nov 2018 11:01:00 + "Popa, Stefan Serban" wrote: > On Mi, 2018-11-21 at 16:04 -0200, Giuliano Belinassi wrote: > > Previously, the AD7780 driver only supported gpio for the 'powerdown' > > pin. This commit adds suppport for the 'gain' and 'filter' pin. > Hey, > > Comments

Re: [PATCH] staging: iio: ad7780: Add gain & filter gpio support

2018-11-25 Thread Jonathan Cameron
On Thu, 22 Nov 2018 11:01:00 + "Popa, Stefan Serban" wrote: > On Mi, 2018-11-21 at 16:04 -0200, Giuliano Belinassi wrote: > > Previously, the AD7780 driver only supported gpio for the 'powerdown' > > pin. This commit adds suppport for the 'gain' and 'filter' pin. > Hey, > > Comments

Re: [PATCH] staging: iio: ad5933: replaced kfifo by triggered_buffer

2018-11-25 Thread Jonathan Cameron
On Thu, 22 Nov 2018 10:53:47 -0200 Marcelo Schmitt wrote: > Previously, there was an implicit creation of a kfifo which was replaced > by a call to triggered_buffer_setup, which is already implemented in iio > infrastructure. > > Signed-off-by: Marcelo Schmitt I'm a little surprised that this

Re: [PATCH] staging: iio: ad5933: replaced kfifo by triggered_buffer

2018-11-25 Thread Jonathan Cameron
On Thu, 22 Nov 2018 10:53:47 -0200 Marcelo Schmitt wrote: > Previously, there was an implicit creation of a kfifo which was replaced > by a call to triggered_buffer_setup, which is already implemented in iio > infrastructure. > > Signed-off-by: Marcelo Schmitt I'm a little surprised that this

Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-11-25 Thread Himanshu Jha
On Sat, Nov 24, 2018 at 11:14:14PM +0100, Tomasz Duszynski wrote: > Add support for Sensirion SPS30 particulate matter sensor. > > Signed-off-by: Tomasz Duszynski > --- > drivers/iio/chemical/Kconfig | 11 ++ > drivers/iio/chemical/Makefile | 1 + > drivers/iio/chemical/sps30.c | 359

Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-11-25 Thread Himanshu Jha
On Sat, Nov 24, 2018 at 11:14:14PM +0100, Tomasz Duszynski wrote: > Add support for Sensirion SPS30 particulate matter sensor. > > Signed-off-by: Tomasz Duszynski > --- > drivers/iio/chemical/Kconfig | 11 ++ > drivers/iio/chemical/Makefile | 1 + > drivers/iio/chemical/sps30.c | 359

Re: [PATCH 1/1] iio: adc: meson-saradc: fix internal clock names

2018-11-25 Thread Jonathan Cameron
On Thu, 22 Nov 2018 23:01:11 +0100 Martin Blumenstingl wrote: > Before this patch we are registering the internal clocks (for example on > Meson8b, where the SAR ADC IP block implements the divider and gate > clocks) with the following names: > - /soc/cbus@c110/adc@8680#adc_div > -

Re: [PATCH 1/1] iio: adc: meson-saradc: fix internal clock names

2018-11-25 Thread Jonathan Cameron
On Thu, 22 Nov 2018 23:01:11 +0100 Martin Blumenstingl wrote: > Before this patch we are registering the internal clocks (for example on > Meson8b, where the SAR ADC IP block implements the divider and gate > clocks) with the following names: > - /soc/cbus@c110/adc@8680#adc_div > -

Re: [PATCH] iio: adc: meson-saradc: check for devm_kasprintf failure

2018-11-25 Thread Jonathan Cameron
On Thu, 22 Nov 2018 22:44:55 +0100 Martin Blumenstingl wrote: > On Thu, Nov 22, 2018 at 8:52 AM Nicholas Mc Guire wrote: > > > > devm_kasprintf() may return NULL on failure of internal allocation thus > > the assignments to init.name are not safe if not checked. On error > >

Re: [PATCH] iio: adc: meson-saradc: check for devm_kasprintf failure

2018-11-25 Thread Jonathan Cameron
On Thu, 22 Nov 2018 22:44:55 +0100 Martin Blumenstingl wrote: > On Thu, Nov 22, 2018 at 8:52 AM Nicholas Mc Guire wrote: > > > > devm_kasprintf() may return NULL on failure of internal allocation thus > > the assignments to init.name are not safe if not checked. On error > >

Re: [PATCH v3 2/4] iio: adc: add STMPE ADC driver using IIO framework

2018-11-25 Thread Jonathan Cameron
On Fri, 23 Nov 2018 15:24:09 +0100 Philippe Schenker wrote: > From: Stefan Agner > > This adds an ADC driver for the STMPE device using the industrial > input/output interface. The driver supports raw reading of values. > The driver depends on the MFD STMPE driver. If the touchscreen > block

Re: [PATCH v3 2/4] iio: adc: add STMPE ADC driver using IIO framework

2018-11-25 Thread Jonathan Cameron
On Fri, 23 Nov 2018 15:24:09 +0100 Philippe Schenker wrote: > From: Stefan Agner > > This adds an ADC driver for the STMPE device using the industrial > input/output interface. The driver supports raw reading of values. > The driver depends on the MFD STMPE driver. If the touchscreen > block

Re: [PATCH v4] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-11-25 Thread Pavel Machek
Hi! > Use the gpiod interface instead of the deprecated old non-descriptor > interface in olpc_dcon_xo_1.c. > > Signed-off-by: Nishad Kamdar You may want to cc: lkund...@v3.sk, he was doing great work on OLPC lately... Best regards,

Re: [PATCH v4] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-11-25 Thread Pavel Machek
Hi! > Use the gpiod interface instead of the deprecated old non-descriptor > interface in olpc_dcon_xo_1.c. > > Signed-off-by: Nishad Kamdar You may want to cc: lkund...@v3.sk, he was doing great work on OLPC lately... Best regards,

Re: [PATCH v3 3/4] iio: adc: add STMPE ADC devicetree bindings

2018-11-25 Thread Jonathan Cameron
On Fri, 23 Nov 2018 15:24:10 +0100 Philippe Schenker wrote: > From: Stefan Agner > > This adds the devicetree bindings for the STMPE ADC. > > Signed-off-by: Stefan Agner > Signed-off-by: Max Krummenacher > Signed-off-by: Philippe Schenker Clearly this will need review from input and mfd.

Re: [PATCH v3 3/4] iio: adc: add STMPE ADC devicetree bindings

2018-11-25 Thread Jonathan Cameron
On Fri, 23 Nov 2018 15:24:10 +0100 Philippe Schenker wrote: > From: Stefan Agner > > This adds the devicetree bindings for the STMPE ADC. > > Signed-off-by: Stefan Agner > Signed-off-by: Max Krummenacher > Signed-off-by: Philippe Schenker Clearly this will need review from input and mfd.

Re: [PATCH v2] staging: iio: ad5933: add device tree support

2018-11-25 Thread Jonathan Cameron
On Sat, 24 Nov 2018 11:18:57 -0200 Marcelo Schmitt wrote: > Add a of_device_id struct variable and subsequent call to > MODULE_DEVICE_TABLE macro to complete device tree support. > > Signed-off-by: Marcelo Schmitt Applied to the togreg branch of iio.git and pushed out as testing for the

Re: [PATCH v2] staging: iio: ad5933: add device tree support

2018-11-25 Thread Jonathan Cameron
On Sat, 24 Nov 2018 11:18:57 -0200 Marcelo Schmitt wrote: > Add a of_device_id struct variable and subsequent call to > MODULE_DEVICE_TABLE macro to complete device tree support. > > Signed-off-by: Marcelo Schmitt Applied to the togreg branch of iio.git and pushed out as testing for the

Re: [PATCH v3 7/7] staging:iio:ad2s90: Move out of staging

2018-11-25 Thread Jonathan Cameron
On Fri, 23 Nov 2018 22:23:12 -0200 Matheus Tavares wrote: > Move ad2s90 resolver driver out of staging to the main tree. > > Signed-off-by: Matheus Tavares > Signed-off-by: Victor Colombo Hi. One totally trivial comment inline, but if you want to clean that up, do it after we have moved this

Re: [PATCH v3 7/7] staging:iio:ad2s90: Move out of staging

2018-11-25 Thread Jonathan Cameron
On Fri, 23 Nov 2018 22:23:12 -0200 Matheus Tavares wrote: > Move ad2s90 resolver driver out of staging to the main tree. > > Signed-off-by: Matheus Tavares > Signed-off-by: Victor Colombo Hi. One totally trivial comment inline, but if you want to clean that up, do it after we have moved this

Re: [PATCH 00/16] x86/microcode/AMD: Improve container verification

2018-11-25 Thread Pavel Machek
On Wed 2018-11-07 18:02:02, Borislav Petkov wrote: > From: Borislav Petkov > > Hi all, > > this is work which got started by Maciej a while ago. I have finally had > the time to redo all the ideas properly, split it in self-contained, > logical chunks and test it. > > Reveiew and comments are

Re: [PATCH 00/16] x86/microcode/AMD: Improve container verification

2018-11-25 Thread Pavel Machek
On Wed 2018-11-07 18:02:02, Borislav Petkov wrote: > From: Borislav Petkov > > Hi all, > > this is work which got started by Maciej a while ago. I have finally had > the time to redo all the ideas properly, split it in self-contained, > logical chunks and test it. > > Reveiew and comments are

Re: [PATCH v2] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-25 Thread Frank Lee
On Sun, Nov 25, 2018 at 5:43 PM Daniel Lezcano wrote: > > On 25/11/2018 06:00, Yangtao Li wrote: > > of_find_node_by_path() acquires a reference to the node > > returned by it and that reference needs to be dropped by its caller. > > integrator_ap_timer_init_of() doesn't do that.The pri_node and

Re: [PATCH v2] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-25 Thread Frank Lee
On Sun, Nov 25, 2018 at 5:43 PM Daniel Lezcano wrote: > > On 25/11/2018 06:00, Yangtao Li wrote: > > of_find_node_by_path() acquires a reference to the node > > returned by it and that reference needs to be dropped by its caller. > > integrator_ap_timer_init_of() doesn't do that.The pri_node and

Re: [PATCH v2] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-25 Thread Daniel Lezcano
On 25/11/2018 06:00, Yangtao Li wrote: > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > integrator_ap_timer_init_of() doesn't do that.The pri_node and the > sec_node are used as an identifier to compare against the

Re: [PATCH v2] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-25 Thread Daniel Lezcano
On 25/11/2018 06:00, Yangtao Li wrote: > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > integrator_ap_timer_init_of() doesn't do that.The pri_node and the > sec_node are used as an identifier to compare against the

Re: [PATCH] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-25 Thread Daniel Lezcano
On 25/11/2018 05:25, Frank Lee wrote: > On Sun, Nov 25, 2018 at 3:49 AM Daniel Lezcano > wrote: >> >> On 24/11/2018 15:58, Frank Lee wrote: >>> On Thu, Nov 22, 2018 at 11:23 PM Yangtao Li wrote: of_find_node_by_path() acquires a reference to the node returned by it and that

Re: [PATCH] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-25 Thread Daniel Lezcano
On 25/11/2018 05:25, Frank Lee wrote: > On Sun, Nov 25, 2018 at 3:49 AM Daniel Lezcano > wrote: >> >> On 24/11/2018 15:58, Frank Lee wrote: >>> On Thu, Nov 22, 2018 at 11:23 PM Yangtao Li wrote: of_find_node_by_path() acquires a reference to the node returned by it and that

Question about "regulator: core: Only count load for enabled consumers" in -next

2018-11-25 Thread Brian Masney
Hi all, I see errors like the following in linux next-20181123 when trying to boot a mainline kernel on a LG Nexus 5 phone: [ 14.495056] mmc1: Card stuck in wrong state! mmcblk1 card_busy_detect status: 0xe00 [ 14.495185] mmc1: cache flush error -110 [ 14.601547] mmc1: Reset 0x1 never

Re: [PATCH 1/3] x86: add support for Huawei WMI hotkeys.

2018-11-25 Thread Pavel Machek
On Wed 2018-10-31 15:19:36, Ayman Bagabas wrote: > This driver adds support for missing hotkeys on some Huawei laptops. > Currently, only Huawei Matebook X Pro is supported. The driver > recognizes the following keys: brightness keys, micmute, wlan, and > Huawei special key. The brightness keys

Question about "regulator: core: Only count load for enabled consumers" in -next

2018-11-25 Thread Brian Masney
Hi all, I see errors like the following in linux next-20181123 when trying to boot a mainline kernel on a LG Nexus 5 phone: [ 14.495056] mmc1: Card stuck in wrong state! mmcblk1 card_busy_detect status: 0xe00 [ 14.495185] mmc1: cache flush error -110 [ 14.601547] mmc1: Reset 0x1 never

Re: [PATCH 1/3] x86: add support for Huawei WMI hotkeys.

2018-11-25 Thread Pavel Machek
On Wed 2018-10-31 15:19:36, Ayman Bagabas wrote: > This driver adds support for missing hotkeys on some Huawei laptops. > Currently, only Huawei Matebook X Pro is supported. The driver > recognizes the following keys: brightness keys, micmute, wlan, and > Huawei special key. The brightness keys

[PATCH] openrisc: Add spaces around & operator

2018-11-25 Thread Liu Xiang
Add spaces around '&' to follow kernel coding style. Signed-off-by: Liu Xiang --- arch/openrisc/include/asm/fixmap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/openrisc/include/asm/fixmap.h b/arch/openrisc/include/asm/fixmap.h index 5a01595..75c7a77 100644 ---

[PATCH] openrisc: Add spaces around & operator

2018-11-25 Thread Liu Xiang
Add spaces around '&' to follow kernel coding style. Signed-off-by: Liu Xiang --- arch/openrisc/include/asm/fixmap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/openrisc/include/asm/fixmap.h b/arch/openrisc/include/asm/fixmap.h index 5a01595..75c7a77 100644 ---

[PATCH] asm-generic: Add spaces around & operator

2018-11-25 Thread Liu Xiang
Add spaces around '&' to follow kernel coding style. Signed-off-by: Liu Xiang --- include/asm-generic/fixmap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/asm-generic/fixmap.h b/include/asm-generic/fixmap.h index 827e4d3..d6e8da3 100644 ---

[PATCH] asm-generic: Add spaces around & operator

2018-11-25 Thread Liu Xiang
Add spaces around '&' to follow kernel coding style. Signed-off-by: Liu Xiang --- include/asm-generic/fixmap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/asm-generic/fixmap.h b/include/asm-generic/fixmap.h index 827e4d3..d6e8da3 100644 ---

[PATCH] arm64: mm: Add spaces around + operator

2018-11-25 Thread Liu Xiang
Add spaces around '+' to follow kernel coding style. Signed-off-by: Liu Xiang --- arch/arm64/mm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index d1d6601..1dbd7be 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c

[PATCH] arm64: mm: Add spaces around + operator

2018-11-25 Thread Liu Xiang
Add spaces around '+' to follow kernel coding style. Signed-off-by: Liu Xiang --- arch/arm64/mm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index d1d6601..1dbd7be 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c

[PATCH] staging: pi433: fix potential null dereference

2018-11-25 Thread Michael Straube
Add a test for successful call to cdev_alloc() to avoid potential null dereference. Issue reported by smatch. Signed-off-by: Michael Straube --- drivers/staging/pi433/pi433_if.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/pi433/pi433_if.c

[PATCH] staging: pi433: fix potential null dereference

2018-11-25 Thread Michael Straube
Add a test for successful call to cdev_alloc() to avoid potential null dereference. Issue reported by smatch. Signed-off-by: Michael Straube --- drivers/staging/pi433/pi433_if.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/pi433/pi433_if.c

RFC: script to convert vsprintf uses of %pf to %ps and %pF to %pS

2018-11-25 Thread Joe Perches
commit 04b8eb7a4ccd ("symbol lookup: introduce dereference_symbol_descriptor()}" deprecated vsprintf extension %pf and %pF. There are approximately these total uses of the symbolic lookup vsprintf extensions %p[SsFf]: $ git grep '".*[^%]%p[SsFf]' | \ grep -oh '%p[SsFf]' | sort | uniq -c |

RFC: script to convert vsprintf uses of %pf to %ps and %pF to %pS

2018-11-25 Thread Joe Perches
commit 04b8eb7a4ccd ("symbol lookup: introduce dereference_symbol_descriptor()}" deprecated vsprintf extension %pf and %pF. There are approximately these total uses of the symbolic lookup vsprintf extensions %p[SsFf]: $ git grep '".*[^%]%p[SsFf]' | \ grep -oh '%p[SsFf]' | sort | uniq -c |

For your Perusal

2018-11-25 Thread John William
Dearest , Its really good to see your Prompt Response it show how Responsible and diligent you will be in handling the sum of $10.5 MILLION if placed in your care and for investment Purposes in your Country . These said Funds have being placed in Safekeeping in DEUTSCHE BANK in SOUTH AFRICA

For your Perusal

2018-11-25 Thread John William
Dearest , Its really good to see your Prompt Response it show how Responsible and diligent you will be in handling the sum of $10.5 MILLION if placed in your care and for investment Purposes in your Country . These said Funds have being placed in Safekeeping in DEUTSCHE BANK in SOUTH AFRICA

Re: [PATCH 3/3] iio: chemical: sps30: add device tree support

2018-11-25 Thread Jonathan Cameron
On Sat, 24 Nov 2018 23:14:15 +0100 Tomasz Duszynski wrote: > Add device tree support for Sensirion SPS30 particulate > matter sensor. > > Signed-off-by: Tomasz Duszynski one comment inine, around the fact we are trying to move to generic names in DT where ever possible. Now we don't have a

Re: [PATCH 3/3] iio: chemical: sps30: add device tree support

2018-11-25 Thread Jonathan Cameron
On Sat, 24 Nov 2018 23:14:15 +0100 Tomasz Duszynski wrote: > Add device tree support for Sensirion SPS30 particulate > matter sensor. > > Signed-off-by: Tomasz Duszynski one comment inine, around the fact we are trying to move to generic names in DT where ever possible. Now we don't have a

Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-11-25 Thread Jonathan Cameron
On Sat, 24 Nov 2018 23:14:14 +0100 Tomasz Duszynski wrote: > Add support for Sensirion SPS30 particulate matter sensor. > > Signed-off-by: Tomasz Duszynski A few things inline. I'm particularly curious as to why we are ignoring two of the particle sizes that the sensor seems to capture?

Re: [PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-11-25 Thread Jonathan Cameron
On Sat, 24 Nov 2018 23:14:14 +0100 Tomasz Duszynski wrote: > Add support for Sensirion SPS30 particulate matter sensor. > > Signed-off-by: Tomasz Duszynski A few things inline. I'm particularly curious as to why we are ignoring two of the particle sizes that the sensor seems to capture?

Re: [PATCH 1/3] iio: add IIO_MASSCONCENTRATION channel type

2018-11-25 Thread Jonathan Cameron
On Sat, 24 Nov 2018 23:14:13 +0100 Tomasz Duszynski wrote: > Measuring particulate matter in ug / m3 (micro-grams per cubic meter) > is de facto standard. Existing air quality sensors usually follow > this convention and are capable of returning measurements using > this unit. > > IIO currently

Re: [PATCH 1/3] iio: add IIO_MASSCONCENTRATION channel type

2018-11-25 Thread Jonathan Cameron
On Sat, 24 Nov 2018 23:14:13 +0100 Tomasz Duszynski wrote: > Measuring particulate matter in ug / m3 (micro-grams per cubic meter) > is de facto standard. Existing air quality sensors usually follow > this convention and are capable of returning measurements using > this unit. > > IIO currently

Re: [RFC PATCH 1/5] mm: print more information about mapping in __dump_page

2018-11-25 Thread Michal Hocko
On Fri 23-11-18 16:04:04, Andrew Morton wrote: > On Wed, 7 Nov 2018 11:18:26 +0100 Michal Hocko wrote: > > > From: Michal Hocko > > > > __dump_page prints the mapping pointer but that is quite unhelpful > > for many reports because the pointer itself only helps to distinguish > > anon/ksm

Re: [RFC PATCH 1/5] mm: print more information about mapping in __dump_page

2018-11-25 Thread Michal Hocko
On Fri 23-11-18 16:04:04, Andrew Morton wrote: > On Wed, 7 Nov 2018 11:18:26 +0100 Michal Hocko wrote: > > > From: Michal Hocko > > > > __dump_page prints the mapping pointer but that is quite unhelpful > > for many reports because the pointer itself only helps to distinguish > > anon/ksm

<    1   2   3   4   5   6