[PATCH v2 1/5] base: soc: Add serial_number attribute to soc

2019-02-19 Thread Vaishali Thakkar
From: Bjorn Andersson Add new attribute named "serial_number" as a standard interface for user space to acquire the serial number of the device. For ST-Ericsson SoCs this is exposed by the cryptically named "soc_id" attribute, but this provides a human readable standardized name for this propert

Re: [RFC PATCH 02/27] containers: Implement containers as kernel objects

2019-02-19 Thread Ian Kent
On Tue, 2019-02-19 at 19:46 -0800, James Bottomley wrote: > On Wed, 2019-02-20 at 11:04 +0800, Ian Kent wrote: > > On Tue, 2019-02-19 at 18:20 -0800, James Bottomley wrote: > > > On Tue, 2019-02-19 at 23:06 +, David Howells wrote: > > > > James Bottomley wrote: > > > > > > > > > I thought we

Re: linux-next: Fixes tag needs some work in the net-next tree

2019-02-19 Thread Vinod Koul
On 20-02-19, 09:31, Stephen Rothwell wrote: > Hi all, > > In commit > > a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode") > > Fixes tag > > Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode") > > has these problem(s): > > - Target SHA1 does not exist >

Re: [RFC PATCH 01/31] mm: migrate: Add exchange_pages to exchange two lists of pages.

2019-02-19 Thread Anshuman Khandual
On 02/19/2019 06:26 PM, Matthew Wilcox wrote: > On Tue, Feb 19, 2019 at 01:12:07PM +0530, Anshuman Khandual wrote: >> But the location of this temp page matters as well because you would like to >> saturate the inter node interface. It needs to be either of the nodes where >> the source or desti

[PATCH] kbuild: refactor cc-cross-prefix implementation

2019-02-19 Thread Masahiro Yamada
- $(word 1, ) is equivalent to $(firstword, ) - hardcode "gcc" instead of $(CC) - minimize the shell script part A little more notes since $(filter-out -%, ...) is not clear. arch/mips/Makefile passes prefixes depending on the configuration. CROSS_COMPILE := $(call cc-cross-prefix, $(tool-a

Re: [PATCH v2] kcm: remove any offset before parsing messages

2019-02-19 Thread Dominique Martinet
Dominique Martinet wrote on Fri, Feb 15, 2019: > With all that said I guess my patch should work correctly then, I'll try > to find some time to check the error does come back up the tcp socket in > my reproducer but I have no reason to believe it doesn't. Ok, so I can confirm this part - the 'cso

Re: [RFC 0/5] RCU fixes for rcu_assign_pointer usage

2019-02-19 Thread Joel Fernandes
On Tue, Feb 19, 2019 at 8:08 PM Joel Fernandes (Google) wrote: > > These patches fix various RCU API usage issues found due to sparse errors as a > result of the recent check to add rcu_check_sparse() to rcu_assign_pointer(). > > This is very early RFC stage, and is only build tested. I am also on

Re: [PATCH v2 2/4] crypto: hisilicon: Add queue management driver for HiSilicon QM module

2019-02-19 Thread Herbert Xu
On Sat, Feb 02, 2019 at 10:25:43AM +0800, Zhou Wang wrote: > > In fact, I planned to register to acomp later. > > It also makes sense to use scomp if hardware engine is faster than CPU. > So how about registering to scomp firstly, then we register this engine to > acomp later? Sorry, but the fact

[RFC 4/5] sched/toplogy: Use smp_store_release() instead of rcu_assign_pointer

2019-02-19 Thread Joel Fernandes (Google)
From: Joel Fernandes The scheduler's topology code seems to want to use rcu_assign_pointer() to initialize various pointers for no apparent reason. With a guess that what was needed here is smp_store_release(), I am replacing it with that. This suppresses the new sparse errors caused by an annot

[RFC 3/5] sched/cpufreq: Fix incorrect RCU API usage

2019-02-19 Thread Joel Fernandes (Google)
From: Joel Fernandes Recently I added an RCU annotation check to rcu_assign_pointer(). All pointers assigned to RCU protected data are to be annotated with __rcu inorder to be able to use rcu_assign_pointer() similar to checks in other RCU APIs. This resulted in a sparse error: kernel//sched/cpu

[RFC 5/5] rcuwait: Replace rcu_assign_pointer with smp_store_release

2019-02-19 Thread Joel Fernandes (Google)
From: Joel Fernandes This suppresses a sparse error generated to the recently added rcu_assign_pointer sparse check: >> kernel//locking/percpu-rwsem.c:162:9: sparse: error: incompatible types in comparison expression (different address spaces) Signed-off-by: Joel Fernandes --- include/linux/r

[RFC 0/5] RCU fixes for rcu_assign_pointer usage

2019-02-19 Thread Joel Fernandes (Google)
These patches fix various RCU API usage issues found due to sparse errors as a result of the recent check to add rcu_check_sparse() to rcu_assign_pointer(). This is very early RFC stage, and is only build tested. I am also only sending to the RCU group for initial review before sending to LKML. Th

[RFC 1/5] net: rtnetlink: Fix incorrect RCU API usage

2019-02-19 Thread Joel Fernandes (Google)
From: Joel Fernandes rtnl_register_internal() and rtnl_unregister_all tries to directly dereference an RCU protected pointed outside RCU read side section. While this is Ok to do since a lock is held, let us use the correct API to avoid programmer bugs in the future. This also fixes sparse warni

[RFC 2/5] ixgbe: Fix incorrect RCU API usage

2019-02-19 Thread Joel Fernandes (Google)
From: Joel Fernandes Recently, I added an RCU annotation check in rcu_assign_pointer. This caused a sparse error to be reported by the ixgbe driver. Further looking, it seems the adapter->xdp_prog pointer is not annotated with __rcu. Annonating it fixed the error, but caused a bunch of other war

Re: [Outreachy kernel] [PATCH] net: dsa: add missing of_node_put

2019-02-19 Thread Vaishali Thakkar
On Wed, Feb 20, 2019 at 8:54 AM Himadri Pandya wrote: > Hi Himadri, Thanks for the patch! For the scope of Outreachy, we prefer that you send patches in staging directory as Greg makes sure to pick them during the application period. Of course, you're very much encouraged to contribute to other

[PATCH] MAINTAINERS: add linux-security-module mailing list to TPM drivers

2019-02-19 Thread Jerry Snitselaar
I've seen requests to add linux-security-module to tpm patch submissions a couple of times recently, so just add the list to MAINTAINERS so get_maintainers.pl will mention it. Cc: Peter Huewe Cc: Jarkko Sakkinen Cc: Jason Gunthorpe Signed-off-by: Jerry Snitselaar --- MAINTAINERS | 1 + 1 file

RE: [PATCH] dt-bindings: imx: update scu resource id headfile

2019-02-19 Thread Anson Huang
Best Regards! Anson Huang > -Original Message- > From: Aisheng Dong > Sent: 2019年2月20日 11:43 > To: Anson Huang ; robh...@kernel.org; > mark.rutl...@arm.com; shawn...@kernel.org; s.ha...@pengutronix.de; > ker...@pengutronix.de; feste...@gmail.com; ulf.hans...@linaro.org; > devicet...@vger

Re: xarray reserve/release?

2019-02-19 Thread Jason Gunthorpe
On Tue, Feb 19, 2019 at 05:26:09PM -0800, Matthew Wilcox wrote: > On Tue, Feb 19, 2019 at 04:53:49PM -0700, Jason Gunthorpe wrote: > > Hey Matt, > > > > Did you intend that xa_release doesn't work on allocating arrays: > > That surprises me. I'll take a look in the morning. I think the issue is

Re: [RFC PATCH 02/27] containers: Implement containers as kernel objects

2019-02-19 Thread James Bottomley
On Wed, 2019-02-20 at 11:04 +0800, Ian Kent wrote: > On Tue, 2019-02-19 at 18:20 -0800, James Bottomley wrote: > > On Tue, 2019-02-19 at 23:06 +, David Howells wrote: > > > James Bottomley wrote: > > > > > > > I thought we got agreement years ago that containers don't > > > > exist in Linux a

RE: [PATCH V6 1/4] dt-bindings: fsl: scu: add thermal binding

2019-02-19 Thread Anson Huang
Best Regards! Anson Huang > -Original Message- > From: Aisheng Dong > Sent: 2019年2月20日 11:27 > To: Anson Huang ; robh...@kernel.org; > mark.rutl...@arm.com; shawn...@kernel.org; s.ha...@pengutronix.de; > ker...@pengutronix.de; feste...@gmail.com; catalin.mari...@arm.com; > will.dea...@ar

Re: [PATCH 1/8] kbuild: pkg: use -f $(srctree)/Makefile to recurse to top Makefile

2019-02-19 Thread Masahiro Yamada
On Thu, Feb 14, 2019 at 7:41 PM Masahiro Yamada wrote: > > '$(MAKE) KBUILD_SRC=' changes the working directory back and forth > between objtree and srctree. > > It is better to recurse to the top-level Makefile directly. > > Signed-off-by: Masahiro Yamada > --- Patch 1/8 - 4/8 applied to linux-k

RE: [PATCH] dt-bindings: imx: update scu resource id headfile

2019-02-19 Thread Aisheng Dong
> > > > You need at least explain what changes made like what new features added? > > What removed? Side affect if any? > > No new features added, looks like SCFW just remove some unused resources. > No side-effect, as they are NOT used by anyone. > That seems not true. I see some new IDs added.

[PATCH] kbuild: hardcode genksyms path and remove GENKSYMS variable

2019-02-19 Thread Masahiro Yamada
The genksyms source was integrated into the kernel tree in 2003. I do not expect anybody still using the external /sbin/genksyms. Kbuild does not need to provide the ability to override GENKSYMS. Let's remove the GENKSYMS variable, and use the hardcoded path. Since it occurred in the pre-git era

Re: [RFC v4 08/17] kunit: test: add support for test abort

2019-02-19 Thread Brendan Higgins
On Mon, Feb 18, 2019 at 11:52 AM Frank Rowand wrote: > > On 2/14/19 1:37 PM, Brendan Higgins wrote: > > Add support for aborting/bailing out of test cases. Needed for > > implementing assertions. > > > > Signed-off-by: Brendan Higgins > > --- > > Changes Since Last Version > > - This patch is ne

Re: [PATCH -next] btrfs: Fix type conversion in btrfs_read_root_item

2019-02-19 Thread Qu Wenruo
On 2019/2/20 上午11:08, YueHaibing wrote: > btrfs_item_size_nr return value is u32, convert it to int may result > in truncation.Also read_extent_buffer expect a unsigned param, so > min_t should use type u32 to compare. Btrfs has a up limit on item size, it will never exceed 64K - various overhea

RE: [PATCH] dt-bindings: imx: update scu resource id headfile

2019-02-19 Thread Aisheng Dong
[...] > > I don't like droping some ID's (e.g. IMX_SC_R_DC_0_CAPTURE0) by mark > > them as unused or even worse give them a other meaning. IMHO the > > scu-api should be stable since day 1 and the ID's should only be extended. > > Marking ID's as deprecated is much better than moving them around.

Re: linux-next: build warning after merge of the device-mapper tree

2019-02-19 Thread Mike Snitzer
On Tue, Feb 19 2019 at 9:15pm -0500, Stephen Rothwell wrote: > Hi all, > > After merging the device-mapper tree, today's linux-next build > (powerpc_ppc64_defconfig) produced this warning: > > In file included from include/linux/blkdev.h:21, > from include/linux/blk-mq.h:5, >

RE: [PATCH] dt-bindings: imx: update scu resource id headfile

2019-02-19 Thread Anson Huang
Best Regards! Anson Huang > -Original Message- > From: Aisheng Dong > Sent: 2019年2月20日 11:29 > To: Anson Huang ; robh...@kernel.org; > mark.rutl...@arm.com; shawn...@kernel.org; s.ha...@pengutronix.de; > ker...@pengutronix.de; feste...@gmail.com; ulf.hans...@linaro.org; > devicet...@vger

RE: [PATCH] dt-bindings: imx: update scu resource id headfile

2019-02-19 Thread Aisheng Dong
> From: Anson Huang > Sent: Tuesday, February 19, 2019 5:01 PM > Subject: [PATCH] dt-bindings: imx: update scu resource id headfile > > Update i.MX SCU resource ID table according to latest system controller > firmware. > You need at least explain what changes made like what new features added?

RE: [PATCH V6 1/4] dt-bindings: fsl: scu: add thermal binding

2019-02-19 Thread Aisheng Dong
> From: Anson Huang > Sent: Thursday, February 7, 2019 5:53 PM [...] > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > controller, the system controller is in charge of system power, clock and > thermal sensors etc. management, Linux kernel has to communicate with > system

[PATCH] net: dsa: add missing of_node_put

2019-02-19 Thread Himadri Pandya
Decrement the reference count on port while returning out of the loop. Signed-off-by: Himadri Pandya --- net/dsa/dsa2.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index a1917025e155..396e7433dd8f 100644 --- a/net/dsa/dsa2.c

Re: [PATCH v2 1/3] arm64: mm: use appropriate ctors for page tables

2019-02-19 Thread Anshuman Khandual
On 02/20/2019 07:04 AM, Matthew Wilcox wrote: > On Tue, Feb 19, 2019 at 11:47:12AM +0530, Anshuman Khandual wrote: >> + Matthew Wilcox >> On 02/19/2019 11:02 AM, Yu Zhao wrote: >>> On Tue, Feb 19, 2019 at 09:51:01AM +0530, Anshuman Khandual wrote: On 02/19/2019 04:43 AM, Yu Zhao w

Re: [RFC PATCH 00/31] Generating physically contiguous memory after page allocation

2019-02-19 Thread Mike Kravetz
On 2/19/19 6:33 PM, Zi Yan wrote: > On 19 Feb 2019, at 17:42, Mike Kravetz wrote: > >> On 2/15/19 2:08 PM, Zi Yan wrote: >> >> Thanks for working on this issue! >> >> I have not yet had a chance to take a look at the code. However, I do have >> some general questions/comments on the approach. >

[PATCH -next] drm/amdgpu: remove set but not used variables 'vm, bo'

2019-02-19 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: In function 'update_gpuvm_pte': drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:840:20: warning: variable 'bo' set but not used [-Wunused-but-set-variable] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_

Re: [PATCH 1/3] dt-bindings: dmaengine: Add one new cell to present hardware slave id

2019-02-19 Thread Baolin Wang
On Tue, 19 Feb 2019 at 20:20, Vinod Koul wrote: > > On 19-02-19, 17:49, Baolin Wang wrote: > > Hi Geert, > > > > On Tue, 19 Feb 2019 at 17:30, Geert Uytterhoeven > > wrote: > > > > > > Hi Baolin, > > > > > > On Tue, Feb 19, 2019 at 4:15 AM Baolin Wang > > > wrote: > > > > On Mon, 18 Feb 2019 a

RE: [PATCHv6 3/4] pci: layerscape: Add the EP mode support.

2019-02-19 Thread Xiaowei Bao
-Original Message- From: Lorenzo Pieralisi Sent: 2019年2月19日 19:27 To: Xiaowei Bao Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; Leo Li ; kis...@ti.com; a...@arndb.de; gre...@linuxfoundation.org; M.h. Lian ; Mingkai Hu ; Roy Zang ; kstew...@

Re: [PATCH V5 0/8] make mt7623 clock of hdmi stable

2019-02-19 Thread Ryder Lee
On Wed, 2019-02-20 at 10:53 +0800, wangyan wang wrote: > From: Wangyan Wang > > V4 adopt maintainer's suggestion. > Here is the change list between V4 & V5 > 1. add Reviewed-by:CK Hu > in " drm/mediatek: fix the rate ..." commit message. > > 2. describe the reason why mt7623 clock of hdmi > is

Re: [RFC PATCH 02/27] containers: Implement containers as kernel objects

2019-02-19 Thread Ian Kent
On Tue, 2019-02-19 at 18:20 -0800, James Bottomley wrote: > On Tue, 2019-02-19 at 23:06 +, David Howells wrote: > > James Bottomley wrote: > > > > > I thought we got agreement years ago that containers don't exist in > > > Linux as a single entity: they're currently a collection of cgroups >

Re: linux-next: manual merge of the net-next tree with the bpf tree

2019-02-19 Thread Stanislav Fomichev
On Tue, Feb 19, 2019 at 5:07 PM Daniel Borkmann wrote: > > On 02/20/2019 01:41 AM, Alexei Starovoitov wrote: > > On Tue, Feb 19, 2019 at 4:37 PM Stephen Rothwell > > wrote: > >> > >> Hi all, > >> > >> Today's linux-next merge of the net-next tree got a conflict in: > >> > >> tools/testing/self

Re: [RFC PATCH net-next v3 13/21] ethtool: provide timestamping information in GET_INFO request

2019-02-19 Thread Jakub Kicinski
On Mon, 18 Feb 2019 19:22:29 +0100 (CET), Michal Kubecek wrote: > Add timestamping information as provided by ETHTOOL_GET_TS_INFO ioctl > command in GET_INFO reply if ETH_INFO_IM_TSINFO flag is set in the request. > > Add constants for counts of HWTSTAMP_TX_* and HWTSTAM_FILTER_* constants > and p

Re: [PATCH 03/11] x86 topology: Add CPUID.1F multi-die/package support

2019-02-19 Thread Like Xu
On 2019/2/19 11:40, Len Brown wrote: From: Len Brown Some new systems have multiple software-visible die within each package. The new CPUID.1F leaf can enumerate this multi-die/package topology. CPUID.1F a super-set of the CPUID.B "Extended Toplogy Leaf", and a common updated routine can parse

Re: [PATCH] acpi/nfit: Fix bus command validation

2019-02-19 Thread Dan Williams
On Tue, Feb 19, 2019 at 5:57 PM Jeff Moyer wrote: > > Dan Williams writes: > > > Commit 11189c1089da "acpi/nfit: Fix command-supported detection" broke > > ND_CMD_CALL for bus-level commands. The "func = cmd" assumption is only > > valid for: > > > > ND_CMD_ARS_CAP > > ND_CMD_ARS_START >

Re: [RFC PATCH net-next v3 10/21] ethtool: provide string sets with GET_STRSET request

2019-02-19 Thread Jakub Kicinski
On Mon, 18 Feb 2019 19:22:14 +0100 (CET), Michal Kubecek wrote: > Requests a contents of one or more string sets, i.e. indexed arrays of > strings; this information is provided by ETHTOOL_GSSET_INFO and > ETHTOOL_GSTRINGS commands of ioctl interface. There are three types of > requests: > > - no

[PATCH v5 1/8] drm/mediatek: recalculate hdmi phy clock of MT2701 by querying hardware

2019-02-19 Thread wangyan wang
From: chunhui dai Recalculate the rate of this clock, by querying hardware. Signed-off-by: chunhui dai Signed-off-by: wangyan wang --- drivers/gpu/drm/mediatek/mtk_hdmi_phy.c| 7 ++ drivers/gpu/drm/mediatek/mtk_hdmi_phy.h| 3 +-- drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_

[PATCH V5 8/8] drm/mediatek: fix the rate of parent for hdmi phy in MT2701

2019-02-19 Thread wangyan wang
From: chunhui dai We should not change the rate of parent for hdmi phy when doing round_rate for this clock. The parent clock of hdmi phy must be the same as it. We change it when doing set_rate only. Signed-off-by: chunhui dai Signed-off-by: wangyan wang --- drivers/gpu/drm/mediatek/mtk_hdmi

[PATCH -next] btrfs: Fix type conversion in btrfs_read_root_item

2019-02-19 Thread YueHaibing
btrfs_item_size_nr return value is u32, convert it to int may result in truncation.Also read_extent_buffer expect a unsigned param, so min_t should use type u32 to compare. Fixes: 8ea05e3a4262 ("Btrfs: introduce subvol uuids and times") Signed-off-by: YueHaibing --- fs/btrfs/root-tree.c | 4 ++--

[PATCH V5 0/8] make mt7623 clock of hdmi stable

2019-02-19 Thread wangyan wang
From: Wangyan Wang V4 adopt maintainer's suggestion. Here is the change list between V4 & V5 1. add Reviewed-by:CK Hu in " drm/mediatek: fix the rate ..." commit message. 2. describe the reason why mt7623 clock of hdmi is more stable than before. the tvdpll should be stable in hdmi normal sett

[PATCH V5 6/8] clk: mediatek: using CLK_MUX_ROUND_CLOSEST for the clock of dpi1_sel

2019-02-19 Thread wangyan wang
From: chunhui dai The MUX clock of dpi1_sel should select the closet clock for itself. We could add this flag to enable this function of MUX in CCF. Signed-off-by: chunhui dai Signed-off-by: wangyan wang --- drivers/clk/mediatek/clk-mt2701.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH V5 3/8] drm/mediatek: using different flags of clk for HDMI phy

2019-02-19 Thread wangyan wang
From: chunhui dai The parent rate of hdmi phy had set by DPI driver. We should not set or change the parent rate of MT2701 hdmi phy, as a result we should remove the flags of "CLK_SET_RATE_PARENT" from the clock of MT2701 hdmi phy. Signed-off-by: chunhui dai Signed-off-by: wangyan wang --- dr

[PATCH V5 4/8] drm/mediatek: fix the rate and divder of hdmi phy for MT2701

2019-02-19 Thread wangyan wang
From: chunhui dai Due to a clerical error,there is one zero less for 1280. Fix it for 12800. Fixes: 0fc721b2968e ("drm/mediatek: add hdmi driver for MT2701 and MT7623") Reviewed-by: CK Hu Signed-off-by: chunhui dai Signed-off-by: wangyan wang --- drivers/gpu/drm/mediatek/mtk_mt2701_

[PATCH V5 7/8] drm/mediatek: using new factor for tvdpll in MT2701

2019-02-19 Thread wangyan wang
From: chunhui dai The factor depends on the divider of DPI in MT2701, therefore, we should fix this factor to the right and new one. Signed-off-by: chunhui dai Signed-off-by: wangyan wang --- drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) dif

[PATCH V5 5/8] clk: mediatek: add MUX_GATE_FLAGS_2

2019-02-19 Thread wangyan wang
From: chunhui dai Add MUX_GATE_FLAGS_2 for the clock which needs to set two falgs. Such as some mux need to set the flags of "CLK_MUX_ROUND_CLOSEST". Signed-off-by: chunhui dai Signed-off-by: wangyan wang --- drivers/clk/mediatek/clk-mtk.c | 2 +- drivers/clk/mediatek/clk-mtk.h | 20

[PATCH V5 2/8] drm/mediatek: move the setting of fixed divider

2019-02-19 Thread wangyan wang
From: chunhui dai move the setting of fixed divider from enable/disable to the function of setting rate. the patch is for hdmi pll divider, the divder should be configured before clock calculation to ensure the clock is right. Signed-off-by: chunhui dai Signed-off-by: wangyan wang --- driver

Re: [RFC PATCH 02/27] containers: Implement containers as kernel objects

2019-02-19 Thread Ian Kent
On Fri, 2019-02-15 at 16:07 +, David Howells wrote: > Implement a kernel container object such that it contains the following > things: > > (1) Namespaces. > > (2) A root directory. > > (3) A set of processes, including one designated as the 'init' process. Yeah, I think a name other tha

Information !!

2019-02-19 Thread Mr.Yacouba Frank
Dear friend, I know that this letter may be a very big surprise to you, My name is Mr. Frank Yacouba, Head of file Department in Africa Develop bank Burkina Faso. I need your sincere cooperation to transfer the sum of $15 million U.S.A dollars to your bank account. I want you stand as next of kin

Re: [RFC PATCH net-next v3 08/21] ethtool: generic handlers for GET requests

2019-02-19 Thread Jakub Kicinski
On Mon, 18 Feb 2019 19:22:04 +0100 (CET), Michal Kubecek wrote: > +static struct common_req_info *alloc_get_data(const struct get_request_ops > *ops) nit: IMHO prefixing all structures and functions with a common phrase (ethnl) makes the code easier to navigate. > +{ > + struct common_r

Re: [PATCH] staging: erofs: remove rcu_read_lock() in erofs_try_to_free_cached_page

2019-02-19 Thread Gao Xiang
Hi Greg, Could you consider take some time on these two patches for linux-5.1-rc1? 1) staging: erofs: fix race of initializing xattrs of a inode at the same time 2) staging: erofs: remove rcu_read_lock() in erofs_try_to_free_cached_page It will be of great help, especially patch 1 (it could cau

[PATCH v2] firmware: hardcode the debug message for -ENOENT

2019-02-19 Thread yuankuiz
From: John Zhao When no file /path was found, the error code of -ENOENT enumerated in errno-base.h, is returned. Stating clearly that the file was not found is much more useful for debugging, So let's be explicit about that. Signed-off-by: John Zhao --- drivers/base/firmware_loader/main.c | 8

Re: [PATCH] x86/asm: Pin sensitive CR4 bits

2019-02-19 Thread Jann Horn
On Wed, Feb 20, 2019 at 1:55 AM Kees Cook wrote: > Several recent exploits have used direct calls to the native_write_cr4() > function to disable SMEP and SMAP before then continuing their exploits > using userspace memory access. This pins bits of cr4 so that they cannot > be changed through a co

Re: [dm-devel] [PATCH V15 00/18] block: support multi-page bvec

2019-02-19 Thread Bart Van Assche
On 2/19/19 5:17 PM, Ming Lei wrote: On Tue, Feb 19, 2019 at 08:28:19AM -0800, Bart Van Assche wrote: With this patch applied test nvmeof-mp/002 fails as follows: [ 694.700400] kernel BUG at lib/sg_pool.c:103! [ 694.705932] invalid opcode: [#1] PREEMPT SMP KASAN [ 694.708297] CPU: 2 PID:

[Patch net-next 01/12] net: hns3: add pointer checking at the beginning of the exported functions.

2019-02-19 Thread Huazhong Tan
From: Yonglong Liu These functions are exported, add pointer checking at the beginning can make them more safe. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 21 + 1 file changed, 21 insert

Re: [RFC PATCH 00/31] Generating physically contiguous memory after page allocation

2019-02-19 Thread Zi Yan
On 19 Feb 2019, at 17:42, Mike Kravetz wrote: On 2/15/19 2:08 PM, Zi Yan wrote: Thanks for working on this issue! I have not yet had a chance to take a look at the code. However, I do have some general questions/comments on the approach. Thanks for replying. The code is very intrusive and

[Patch net-next 11/12] net: hns3: uninitialize command queue while unloading PF driver

2019-02-19 Thread Huazhong Tan
According to the hardware's description, the driver should clear the command queue's registers when uloading driver. Otherwise, these existing value may lead the IMP get into a wrong state. Also this patch adds hclge_cmd_uninit() to do the command queue uninitialization which includes clearing reg

[Patch net-next 06/12] net: hns3: some bugfix of ppu(rcb) ras errors

2019-02-19 Thread Huazhong Tan
From: Weihang Li The 3rd and 4th of PPU(RCB) PF Abnormal is RAS errors instead of MSI-X like other bits. This patch adds process of handling and logging this two bits. Otherwise, this patch modifies print message of 28th and 29th bit of PPU MPF Abnormal errors, which keep same with other errors n

[Patch net-next 09/12] net: hns3: Record VF unicast and multicast tables

2019-02-19 Thread Huazhong Tan
From: liuzhongzhu Record the unicast and multicast tables that the VF sends to the chip. After the VF exception, the PF actively clears the VF to chip config. Signed-off-by: liuzhongzhu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h

[Patch net-next 02/12] net: hns3: Check variable is valid before assigning it to another

2019-02-19 Thread Huazhong Tan
From: Yonglong Liu In hnae3_register_ae_dev(), ae_algo->ops is assigned to ae_dev->ops before check that ae_algo->ops is valid. And in hnae3_register_ae_algo(), missing check for ae_algo->ops. This patch fixes them. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: Huazhong T

Re: [PATCH v2 02/10] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960

2019-02-19 Thread Chen Yu
Hi, On 2019/2/19 16:25, Sergei Shtylyov wrote: > Hello! > > On 18.02.2019 14:23, Yu Chen wrote: > >> This patch adds binding documentation to support usb hub and usb >> data role switch of Hisilicon HiKey960 Board. >> >> Cc: Sergei Shtylyov >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc: John S

[Patch net-next 10/12] net: hns3: Record VF vlan tables

2019-02-19 Thread Huazhong Tan
From: liuzhongzhu Record the vlan tables that the VF sends to the chip. After the VF exception, the PF actively clears the VF to chip config. Signed-off-by: liuzhongzhu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 80

[Patch net-next 05/12] net: hns3: modify print message of ssu common ecc errors

2019-02-19 Thread Huazhong Tan
From: Weihang Li This patch add information of specific bit in log to be consistent with other type of errors, so that we can know which memory of ssu has occurred a ecc ras errors. Signed-off-by: Weihang Li Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- .../net/ethernet/hisilicon/hn

[Patch net-next 12/12] net: hns3: clear command queue's registers when unloading VF driver

2019-02-19 Thread Huazhong Tan
According to the hardware's description, the driver should clear the command queue's registers when uloading VF driver. Otherwise, these existing value may lead the IMP get into a wrong state. Fixes: fedd0c15d288 ("net: hns3: Add HNS3 VF IMP(Integrated Management Proc) cmd interface") Signed-off-

[Patch net-next 03/12] net: hns3: convert mac advertize and supported from u32 to link mode

2019-02-19 Thread Huazhong Tan
From: Jian Shen The link mode with bits has been up to more than 31 for some MAC and phy. Convert to using a linkmode bitmap, which can support all link modes. Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c|

[Patch net-next 04/12] net: hns3: fix port info query issue for copper port

2019-02-19 Thread Huazhong Tan
From: Jian Shen In original codes, for copper port which doesn't connect to phy, it always returns -EOPNOTSUPP when query port information. This patch fixes it by return the port information of MAC. Fixes: 5f373b158523 ("net: hns3: Fix speed/duplex information loss problem when executing ethtoo

[Patch net-next 07/12] net: hns3: enable 8~11th bit of mac common msi-x error

2019-02-19 Thread Huazhong Tan
From: Weihang Li These bits are enabled now and have been test. Signed-off-by: Weihang Li Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 6 ++ drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h | 4 ++-- 2 files changed

[Patch net-next 08/12] net: hns3: fix 6th bit of ppp mpf abnormal errors

2019-02-19 Thread Huazhong Tan
From: Weihang Li This patch modify print message of 6th bit of ppp mpf abnormal errors, there is a extra letter e in it. Signed-off-by: Weihang Li Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 2 +- 1 file changed, 1 insertion

[Patch net-next 00/12] code optimizations & bugfixes for HNS3 driver

2019-02-19 Thread Huazhong Tan
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver. Huazhong Tan (2): net: hns3: uninitialize command queue while unloading PF driver net: hns3: clear command queue's registers when unloading VF driver Jian Shen (2): net: hns3: convert mac adverti

Re: [RFC PATCH net-next v3 05/21] ethtool: netlink bitset handling

2019-02-19 Thread Jakub Kicinski
On Mon, 18 Feb 2019 19:21:49 +0100 (CET), Michal Kubecek wrote: > + else if (is_u32) > + bitmap_from_arr32(val, bitmap, nbits); > + else > + bitmap_copy(val, bitmap, nbits); > + nla_for_each_nested(bit_attr, tb[ETHA_BITSET_

[PATCH v2 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()

2019-02-19 Thread YueHaibing
calc_tpm2_event_size() has an invalid signature because it returns a 'size_t' where as its signature says that it returns 'int'. Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event log") Suggested-by: Jarkko Sakkinen Signed-off-by: YueHaibing --- v2: modify patch title

Re: [RFC v4 15/17] of: unittest: migrate tests to run on KUnit

2019-02-19 Thread Brendan Higgins
On Fri, Feb 15, 2019 at 4:24 PM Frank Rowand wrote: > > On 2/14/19 1:37 PM, Brendan Higgins wrote: > > Migrate tests without any cleanup, or modifying test logic in anyway to > > run under KUnit using the KUnit expectation and assertion API. > > > > Signed-off-by: Brendan Higgins > > --- > > dri

Re: [RFC PATCH 02/27] containers: Implement containers as kernel objects

2019-02-19 Thread James Bottomley
On Tue, 2019-02-19 at 23:06 +, David Howells wrote: > James Bottomley wrote: > > > I thought we got agreement years ago that containers don't exist in > > Linux as a single entity: they're currently a collection of cgroups > > and namespaces some of which may and some of which may not be loca

linux-next: build warning after merge of the device-mapper tree

2019-02-19 Thread Stephen Rothwell
Hi all, After merging the device-mapper tree, today's linux-next build (powerpc_ppc64_defconfig) produced this warning: In file included from include/linux/blkdev.h:21, from include/linux/blk-mq.h:5, from drivers/md/dm-core.h:14, from drivers/md/

[PATCH] usb: core: Replace hardcoded check with inline function from usb.h

2019-02-19 Thread Keyur Patel
From: Keyur Patel Expression (urb->transfer_flags & URB_DIR_MASK) == URB_DIR_IN can be replaced by usb_urb_dir_in(struct urb *urb) from usb.h for better readability. Signed-off-by: Keyur Patel --- drivers/usb/core/devio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[PATCH] soc: imx: gpcv2: Make use of regmap_read_poll_timeout()

2019-02-19 Thread Andrey Smirnov
Replace explicit polling loop with a call to regmap_read_poll_timeout() to avoid code repetition. Also fix misspelled "failed" while at it. Signed-off-by: Andrey Smirnov Cc: Lucas Stach Cc: Chris Healy Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/soc/im

Re: [PATCH] ARM: dts: rockchip: remove disable-wp from rv1108-elgin-r1 emmc node【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips....@lists.infradead.org代发】

2019-02-19 Thread Shawn Lin
On 2019/2/19 21:03, Johan Jonker wrote: The mmc.txt didn't explicitly say disable-wp is for SD card slot only, but that is what it was designed for in the first place. Remove all disable-wp from emmc or sdio controllers. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rv1108-elgin-r1.dts |

Re: [PATCH -next] tpm: change the return type of calc_tpm2_event_size to size_t

2019-02-19 Thread YueHaibing
On 2019/2/20 1:31, Jarkko Sakkinen wrote: > On Tue, Feb 19, 2019 at 09:34:56AM -0700, Jason Gunthorpe wrote: >>> - Your real name is formatted incorrectly. It should be like "Yue Haibig" >>> as shown in [1]. >>> - If there is no actual regression, this change is useless. >> >> Clarity of the code

Re: [PATCH v7 0/3] Fixes for Tegra soctherm

2019-02-19 Thread Zhang Rui
On 一, 2019-02-18 at 15:59 +0800, Wei Ni wrote: > Rui, > Will you take this serial? > it is already in my tree. I missed -rc6, thus I will queue them for 5.1-rc1. thanks, rui > Thanks. > Wei. > > On 21/1/2019 5:17 PM, Wei Ni wrote: > > > > Does there have any comments? > > > > Thanks. > > Wei.

[PATCH] slub: fix a crash with SLUB_DEBUG + KASAN_SW_TAGS

2019-02-19 Thread Qian Cai
In process_slab(), "p = get_freepointer()" could return a tagged pointer, but "addr = page_address()" always return a native pointer. As the result, slab_index() is messed up here, return (p - addr) / s->size; All other callers of slab_index() have the same situation where "addr" is from page_add

Re: [RFC PATCH] tools/memory-model: Remove (dep ; rfi) from ppo

2019-02-19 Thread Paul E. McKenney
On Tue, Feb 19, 2019 at 11:57:37PM +0100, Andrea Parri wrote: > Remove this subtle (and, AFAICT, unused) ordering: we can add it back, > if necessary, but let us not encourage people to rely on this thing. > > For example, the following "exists" clause can be satisfied with this > change: > > C d

Re: [PATCH 1/2] tools/memory-model: Fix comment in MP+poonceonces.litmus

2019-02-19 Thread Paul E. McKenney
On Tue, Feb 19, 2019 at 11:55:22PM +0100, Andrea Parri wrote: > The comment should say "Sometimes" for the result. I queued both of these, thank you! Just to be clear "Maybe" is "don't care", so this patch is changing this litmus test from "LKMM can allow or forbid, at its option" to "LKMM must

[PATCH v3 3/5] arm64: dts: imx8mq: Combine PCIE power domains

2019-02-19 Thread Andrey Smirnov
According to NXP's FAE feedback and a comment in ATF firmware, PCIE1 and PCIE2 power domains can't really be used independently. Due to shared reset line both power domains have to be turned on at the same time. Account for that quirk by combining PCIE power domains into a single 'pgc_pcie' power d

[PATCH v3 2/5] arm64: dts: imx8mq: Add a node for SRC IP block

2019-02-19 Thread Andrey Smirnov
Add a node for reset controller IP block found on i.MX8MQ. Signed-off-by: Andrey Smirnov Reviewed-by: Lucas Stach Cc: Shawn Guo Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-...@nxp.com Cc: linux-arm-ker...@lists.infradead.

[PATCH v3 5/5] arm64: dts: imx8mq-evk: Enable PCIE0 interface

2019-02-19 Thread Andrey Smirnov
Enable PCIE0 interface connected to BCM4356 WiFi/Bluetooth module. Signed-off-by: Andrey Smirnov Cc: Shawn Guo Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-...@nxp.com Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kern

[PATCH v3 0/5] PCIE support for i.MX8MQ (DT changes)

2019-02-19 Thread Andrey Smirnov
Everyone: This series contains all of the i.MX Device Tree changes I made to enable support of PCIe on i.MX8MQ EVK. NOTE: Immutable brach containing imx8mq-reset.h used in "arm64: dts: Add nodes for PCIe IP blocks" is availible in [reset-imx8mq] Feedback is welcome! Changes since [v2]: - F

[PATCH v3 4/5] arm64: dts: imx8mq: Add nodes for PCIe IP blocks

2019-02-19 Thread Andrey Smirnov
Add nodes for two PCIe controllers found on i.MX8MQ. Signed-off-by: Andrey Smirnov Reviewed-by: Lucas Stach Cc: Shawn Guo Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-...@nxp.com Cc: linux-arm-ker...@lists.infradead.org Cc

[PATCH v3 1/5] arm64: dts: imx8mq: Mark iomuxc_gpr as i.MX6Q compatible

2019-02-19 Thread Andrey Smirnov
Mark iomuxc_gpr as compatible with "fsl,imx6q-iomuxc-gpr" in order for to allow i.MX6 PCIe driver to use it. Signed-off-by: Andrey Smirnov Acked-by: Lucas Stach Cc: Shawn Guo Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-..

Re: [PATCH] acpi/nfit: Fix bus command validation

2019-02-19 Thread Jeff Moyer
Dan Williams writes: > Commit 11189c1089da "acpi/nfit: Fix command-supported detection" broke > ND_CMD_CALL for bus-level commands. The "func = cmd" assumption is only > valid for: > > ND_CMD_ARS_CAP > ND_CMD_ARS_START > ND_CMD_ARS_STATUS > ND_CMD_CLEAR_ERROR > > The function numb

[RESEND][PATCH 2/2] regulator: max77650: Add missing .owner field in regulator_desc

2019-02-19 Thread Axel Lin
Add missing .owner field in regulator_desc, which is used for refcounting. Signed-off-by: Axel Lin --- This patch was sent on https://lkml.org/lkml/2019/1/30/467 drivers/regulator/max77650-regulator.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/regulator/max77650-regulator

[RESEND][PATCH 1/2] regulator: max77620: Add missing .owner field in regulator_desc

2019-02-19 Thread Axel Lin
Add missing .owner field in regulator_desc, which is used for refcounting. Signed-off-by: Axel Lin --- This patch was sent on https://lkml.org/lkml/2019/1/30/466 drivers/regulator/max77620-regulator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/max77620-regulator.c

Re: [PATCH v3] of: unittest: unflatten device tree on UML when testing

2019-02-19 Thread Frank Rowand
On 2/19/19 3:54 PM, Brendan Higgins wrote: > UML supports enabling OF, and is useful for running the device tree > tests, so add support for unflattening device tree blobs so we can > actually use it. > > Signed-off-by: Brendan Higgins > --- > drivers/of/unittest.c | 4 > 1 file changed, 4

[PATCH] x86/nmi: ratelimit unknown nmi logs

2019-02-19 Thread Olof Johansson
Getting notified of unknown NMIs is obviously important, but getting notified on every single one, especially on larger systems with slow (serial) console causes more harm than good when it's a known noisy non-relevant event. So, let's ratelimit to avoid locking up the system. Signed-off-by: Olof

Re: [RFC PATCH 00/31] Generating physically contiguous memory after page allocation

2019-02-19 Thread Mike Kravetz
On 2/15/19 2:08 PM, Zi Yan wrote: Thanks for working on this issue! I have not yet had a chance to take a look at the code. However, I do have some general questions/comments on the approach. > Patch structure > > > The patchset I developed to generate physically contiguous memory/arbit

<    1   2   3   4   5   6   7   8   9   10   >