[PATCH 1/2] gpio: davinci: Fix the compiler warning with ARM64 config enabled

2019-06-04 Thread Keerthy
Fix the compiler warning with ARM64 config enabled as the current mask assumes 32 bit by default. Signed-off-by: Keerthy --- drivers/gpio/gpio-davinci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index

[PATCH 2/2] gpio: Davinci: Add K3 dependencies

2019-06-04 Thread Keerthy
Add K3 dependencies to enable the driver on K3 platforms. Signed-off-by: Keerthy --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 62f3fe06cd2f..28dba62e2219 100644 --- a/drivers/gpio/Kconfig +++

[PATCH 0/2] gpio: davinci: Add support for TI K3 AM6 platform

2019-06-04 Thread Keerthy
K3 AM6 platform has 2 instances of gpio banks on main domain and 1 instance on wakeup domin. All are capable of generating banked interrupts. Keerthy (2): gpio: davinci: Fix the compiler warning with ARM64 config enabled gpio: Davinci: Add K3 Specific dependencies drivers/gpio/Kconfig

[PATCH -next] net: ethernet: mediatek: fix mtk_eth_soc build errors & warnings

2019-06-04 Thread Randy Dunlap
by: Randy Dunlap Cc: Sean Wang Cc: John Crispin Cc: Felix Fietkau Cc: Nelson Chang --- drivers/net/ethernet/mediatek/Makefile |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-next-20190604.orig/drivers/net/ethernet/mediatek/Makefile +++ linux-next-20190604/driver

RE: [PATCH 0/3] (Qualcomm) UFS device reset support

2019-06-04 Thread Avri Altman
Hi, > > On Tue, Jun 4, 2019 at 12:22 AM Bjorn Andersson > wrote: > > > > This series exposes the ufs_reset line as a gpio, adds support for ufshcd to > > acquire and toggle this and then adds this to SDM845 MTP. > > > > Bjorn Andersson (3): > > pinctrl: qcom: sdm845: Expose ufs_reset as gpio

Re: [PATCH v3 1/4] iommu: Add gfp parameter to iommu_ops::map

2019-06-04 Thread Christoph Hellwig
On Mon, May 06, 2019 at 07:52:03PM +0100, Tom Murphy via iommu wrote: > We can remove the mutex lock from amd_iommu_map and amd_iommu_unmap. > iommu_map doesn’t lock while mapping and so no two calls should touch > the same iova range. The AMD driver already handles the page table page >

[PATCH v6 1/5] usb: fsl: Set USB_EN bit to select ULPI phy

2019-06-04 Thread Yinbo Zhu
From: Nikhil Badola Set USB_EN bit to select ULPI phy for USB controller version 2.5 Signed-off-by: Nikhil Badola Signed-off-by: Yinbo Zhu --- drivers/usb/host/ehci-fsl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index

[PATCH v6 3/5] usb: linux/fsl_device: Add platform member has_fsl_erratum_a006918

2019-06-04 Thread Yinbo Zhu
This patch is to add member has_fsl_erratum_a006918 in platform data Signed-off-by: Yinbo Zhu --- include/linux/fsl_devices.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h index cb2b46f57af3..5d231ce8709b 100644 ---

[PATCH v6 5/5] usb :fsl: Change string format for errata property

2019-06-04 Thread Yinbo Zhu
From: Nikhil Badola Remove USB errata checking code from driver. Applicability of erratum is retrieved by reading corresponding property in device tree. This property is written during device tree fixup. Signed-off-by: Ramneek Mehresh Signed-off-by: Nikhil Badola Signed-off-by: Yinbo Zhu ---

[PATCH v6 4/5] usb: host: Stops USB controller init if PLL fails to lock

2019-06-04 Thread Yinbo Zhu
From: Ramneek Mehresh USB erratum-A006918 workaround tries to start internal PHY inside uboot (when PLL fails to lock). However, if the workaround also fails, then USB initialization is also stopped inside Linux. Erratum-A006918 workaround failure creates "fsl,erratum_a006918" node in

[PATCH v6 2/5] usb: phy: Workaround for USB erratum-A005728

2019-06-04 Thread Yinbo Zhu
From: Suresh Gupta PHY_CLK_VALID bit for UTMI PHY in USBDR does not set even if PHY is providing valid clock. Workaround for this involves resetting of PHY and check PHY_CLK_VALID bit multiple times. If PHY_CLK_VALID bit is still not set even after 5 retries, it would be safe to deaclare that

[PATCH] nilfs2: do not use unexported cpu_to_le32()/le32_to_cpu() in uapi header

2019-06-04 Thread Masahiro Yamada
cpu_to_le32/le32_to_cpu is defined in include/linux/byteorder/generic.h, which is not exported to user-space. UAPI headers must use the ones prefixed with double-underscore. Detected by compile-testing exported headers: ./usr/include/linux/nilfs2_ondisk.h: In function

Re: [PATCH] arm64: dts: qcom: sdm845-mtp: Add Truly display

2019-06-04 Thread Vivek Gautam
On Tue, May 14, 2019 at 2:39 AM Bjorn Andersson wrote: > > Bring in the Truly display and enable the DSI channels to make the > mdss/gpu probe, even though we're lacking LABIB, preventing us from > seeing anything on the screen. > > Signed-off-by: Bjorn Andersson > --- Looks good to me and work

[PATCH] lib/test_stackinit: Handle Clang auto-initialization pattern

2019-06-04 Thread Kees Cook
While the gcc plugin for automatic stack variable initialization (i.e. CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL) performs initialization with 0x00 bytes, the Clang automatic stack variable initialization (i.e. CONFIG_INIT_STACK_ALL) uses various type-specific patterns that are typically 0xAA.

Re: [PATCH] media: do not use C++ style comments in uapi headers

2019-06-04 Thread Joe Perches
On Wed, 2019-06-05 at 07:10 +0200, Greg KH wrote: > On Wed, Jun 05, 2019 at 01:10:41PM +0900, Masahiro Yamada wrote: > > On Wed, Jun 5, 2019 at 3:21 AM Arnd Bergmann wrote: [] > > This means we cannot reliably use uint{8,16,32,64}_t in UAPI headers. > > We should not be doing that as they are in

Re: [PATCH] media: do not use C++ style comments in uapi headers

2019-06-04 Thread Greg KH
On Wed, Jun 05, 2019 at 01:10:41PM +0900, Masahiro Yamada wrote: > On Wed, Jun 5, 2019 at 3:21 AM Arnd Bergmann wrote: > > > > > > > > > > There are two ways to define fixed-width type. > > > > > > > > > > [1] #include , __u8, __u16, __u32, __u64 > > > > > > > > > > vs > > > > > > > > > >

Re: [PATCH AUTOSEL 5.1 06/60] driver core: platform: Fix the usage of platform device name(pdev->name)

2019-06-04 Thread Greg Kroah-Hartman
On Tue, Jun 04, 2019 at 07:21:16PM -0400, Sasha Levin wrote: > From: Venkata Narendra Kumar Gutta > > [ Upstream commit edb16da34b084c66763f29bee42b4e6bb33c3d66 ] > > Platform core is using pdev->name as the platform device name to do > the binding of the devices with the drivers. But, when the

Re: [PATCH] wcd9335: fix a incorrect use of kstrndup()

2019-06-04 Thread Jiri Slaby
On 29. 05. 19, 3:53, Gen Zhang wrote: > In wcd9335_codec_enable_dec(), 'widget_name' is allocated by kstrndup(). > However, according to doc: "Note: Use kmemdup_nul() instead if the size > is known exactly." Except the size is not known exactly. It is at most 15, not 15. Right? > So we should

Re: [PATCH] arm64: dts: sdm845: Add iommus property to qup1

2019-06-04 Thread Vivek Gautam
On Wed, Jun 5, 2019 at 4:16 AM Stephen Boyd wrote: > > Quoting Bjorn Andersson (2019-06-04 15:37:00) > > On Tue 04 Jun 15:29 PDT 2019, Stephen Boyd wrote: > > > > > The SMMU that sits in front of the QUP needs to be programmed properly > > > so that the i2c geni driver can allocate DMA

[PATCH] phy: renesas: rcar-gen3-usb2: fix imbalance powered flag

2019-06-04 Thread Yoshihiro Shimoda
The powered flag should be set for any other phys anyway. Otherwise, after we have revised the device tree for the usb phy, the following warning happened during a second system suspend. So, this patch fixes the issue. [ 56.026531] unbalanced disables for USB20_VBUS0 [ 56.031108] WARNING:

Re: bcache: oops when writing to writeback_percent without a cache device

2019-06-04 Thread Coly Li
On 2019/6/5 1:24 上午, Bjørn Forsman wrote: > On Tue, 4 Jun 2019 at 17:41, Coly Li wrote: >> >> On 2019/6/4 10:59 下午, Coly Li wrote: >>> On 2019/6/4 7:00 下午, Bjørn Forsman wrote: Hi all, I get a kernel oops from bcache when writing to /sys/block/bcache0/bcache/writeback_percent

Re: [PATCH v6 01/10] mm: add missing smp read barrier on getting memcg kmem_cache pointer

2019-06-04 Thread Shakeel Butt
On Tue, Jun 4, 2019 at 7:45 PM Roman Gushchin wrote: > > Johannes noticed that reading the memcg kmem_cache pointer in > cache_from_memcg_idx() is performed using READ_ONCE() macro, > which doesn't implement a SMP barrier, which is required > by the logic. > > Add a proper smp_rmb() to be paired

Re: [PATCH 0/3] Enhance virtio rpmsg bus driver buffer allocation

2019-06-04 Thread Bjorn Andersson
On Thu 31 Jan 07:41 PST 2019, Xiang Xiao wrote: > Hi, > This series enhance the buffer allocation by: > 1.Support the different buffer number in rx/tx direction > 2.Get the individual rx/tx buffer size from config space > > Here is the related OpenAMP change: >

Re: [PATCH] RDMA/ucma: Use struct_size() helper

2019-06-04 Thread Leon Romanovsky
On Tue, Jun 04, 2019 at 10:42:22AM -0500, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. What does "in particular in the context in

Re: [PATCH v6 00/10] mm: reparent slab memory on cgroup removal

2019-06-04 Thread Andrew Morton
On Tue, 4 Jun 2019 19:44:44 -0700 Roman Gushchin wrote: > So instead of trying to find a maybe non-existing balance, let's do reparent > the accounted slabs to the parent cgroup on cgroup removal. s/slabs/slab caches/. Take more care with the terminology, please... > There is a bonus:

Re: [PATCH] media: do not use C++ style comments in uapi headers

2019-06-04 Thread Masahiro Yamada
On Wed, Jun 5, 2019 at 3:21 AM Arnd Bergmann wrote: > > > > > > > > There are two ways to define fixed-width type. > > > > > > > > [1] #include , __u8, __u16, __u32, __u64 > > > > > > > > vs > > > > > > > > [2] #include , uint8_t, uint16_t, uint32_t, uint64_t > > > > > > > > > > > > Both

Re: linux-next: Tree for Jun 4 (drivers/iio/addac/adt7316.c)

2019-06-04 Thread Randy Dunlap
On 6/3/19 11:09 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190603: > on x86_64: when GPIOLIB is not set/enabled: ../drivers/staging/iio/addac/adt7316.c: In function ‘adt7316_store_update_DAC’: ../drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of

RE: rcar_gen3_phy_usb2: unbalanced disables for USB20_VBUS0

2019-06-04 Thread Yoshihiro Shimoda
Hi Geert-san, Thank you very much for your report! > From: Geert Uytterhoeven, Sent: Wednesday, June 5, 2019 3:06 AM > > Hi Shimoda-san, > > Using a tree based on renesas-drivers-2019-06-04-v5.2-rc3, I started seeing > the following warning during a second system suspend (s2idle): > So far

Re: [RFC PATCH v2 1/3] vfio: Use capability chains to handle device specific irq

2019-06-04 Thread Zhenyu Wang
On 2019.06.04 17:55:32 +0800, Tina Zhang wrote: > Caps the number of irqs with fixed indexes and uses capability chains > to chain device specific irqs. > > VFIO vGPU leverages this mechanism to trigger primary plane and cursor > plane page flip event to the user space. > > Signed-off-by: Tina

Re: rcu_read_lock lost its compiler barrier

2019-06-04 Thread Paul E. McKenney
On Wed, Jun 05, 2019 at 10:21:17AM +0800, Herbert Xu wrote: > On Tue, Jun 04, 2019 at 02:14:49PM -0700, Paul E. McKenney wrote: > > > > Yeah, I know, even with the "volatile" keyword, it is not entirely clear > > how much reordering the compiler is allowed to do. I was relying on > >

Re: [PATCH 2/3] i2c: slave-mqueue: add a slave backend to receive and queue messages

2019-06-04 Thread Eduardo Valentin
Hey Andry, Long time no seeing :-) On Tue, Jun 04, 2019 at 08:16:11PM +0300, Andy Shevchenko wrote: > On Thu, May 30, 2019 at 09:33:46PM -0700, Eduardo Valentin wrote: > > From: Haiyue Wang > > > > Some protocols over I2C are designed for bi-directional transferring > > messages by using I2C

Re: [PATCH v3 net-next 00/17] PTP support for the SJA1105 DSA driver

2019-06-04 Thread David Miller
From: Vladimir Oltean Date: Tue, 4 Jun 2019 20:07:39 +0300 > This patchset adds the following: > > - A timecounter/cyclecounter based PHC for the free-running >timestamping clock of this switch. > > - A state machine implemented in the DSA tagger for SJA1105, which >keeps track of

[GIT PULL] pstore fixes for v5.2-rc4

2019-06-04 Thread Kees Cook
Hi Linus, Please pull these pstore fixes for v5.2-rc4. They've been in linux-next for a bit now and catch some pstore corner cases found recently. Thanks! -Kees The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9: Linux 5.2-rc1 (2019-05-19 15:47:09 -0700) are

Re: [PATCH net] tcp: avoid creating multiple req socks with the same tuples

2019-06-04 Thread Eric Dumazet
On Tue, Jun 4, 2019 at 7:07 PM maowenan wrote: > > > > On 2019/6/4 23:24, Eric Dumazet wrote: > > On Tue, Jun 4, 2019 at 7:47 AM Mao Wenan wrote: > >> > >> There is one issue about bonding mode BOND_MODE_BROADCAST, and > >> two slaves with diffierent affinity, so packets will be handled > >> by

Re: [PATCH net-next v4 00/10] net: dsa: mv88e6xxx: support for mv88e6250

2019-06-04 Thread David Miller
From: Rasmus Villemoes Date: Tue, 4 Jun 2019 07:34:22 + > This adds support for the mv88e6250 chip. Initially based on the > mv88e6240, this time around, I've been through each ->ops callback and > checked that it makes sense, either replacing with a 6250 specific > variant or dropping it if

[PATCH] spi: mediatek: add SPI_LSB_FIRST support

2019-06-04 Thread Leilk Liu
this patch add SPI_LSB_FIRST feature support. Signed-off-by: Leilk Liu --- drivers/spi/spi-mt65xx.c | 15 ++- include/linux/platform_data/spi-mt65xx.h |2 -- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/spi/spi-mt65xx.c

Re: [PATCH net-next] vmxnet3: turn off lro when rxcsum is disabled

2019-06-04 Thread David Miller
From: Ronak Doshi Date: Mon, 3 Jun 2019 23:58:38 -0700 > Currently, when rx csum is disabled, vmxnet3 driver does not turn > off lro, which can cause performance issues if user does not turn off > lro explicitly. This patch adds fix_features support which is used to > turn off LRO whenever

Re:Hello

2019-06-04 Thread chervosvita
Dear Sir/Madam, Invest-Capital, gives you an opportunity to grow your business and bring happiness to your loved ones through hassle-free loans. We provide international loan for corporate and private entities around the world. Attractive interest rates 4% For further details please contacts

Re: [PATCH] net: ipvlan: Fix ipvlan device tso disabled while NETIF_F_IP_CSUM is set

2019-06-04 Thread David Miller
From: Miaohe Lin Date: Tue, 4 Jun 2019 06:07:34 + > There's some NICs, such as hinic, with NETIF_F_IP_CSUM and NETIF_F_TSO > on but NETIF_F_HW_CSUM off. And ipvlan device features will be > NETIF_F_TSO on with NETIF_F_IP_CSUM and NETIF_F_IP_CSUM both off as > IPVLAN_FEATURES only care about

Re: [PATCH v5 2/8] KVM: x86: Implement CET CPUID support for Guest

2019-06-04 Thread Yang Weijiang
On Tue, Jun 04, 2019 at 12:58:01PM -0700, Sean Christopherson wrote: > On Wed, May 22, 2019 at 03:00:55PM +0800, Yang Weijiang wrote: > > CET SHSTK and IBT features are introduced here so that > > CPUID.(EAX=7, ECX=0):ECX[bit 7] and EDX[bit 20] reflect them. > > CET xsave components for supervisor

[PATCH v6 05/10] mm: introduce __memcg_kmem_uncharge_memcg()

2019-06-04 Thread Roman Gushchin
Let's separate the page counter modification code out of __memcg_kmem_uncharge() in a way similar to what __memcg_kmem_charge() and __memcg_kmem_charge_memcg() work. This will allow to reuse this code later using a new memcg_kmem_uncharge_memcg() wrapper, which calls __memcg_kmem_uncharge_memcg()

[PATCH v6 03/10] mm: rename slab delayed deactivation functions and fields

2019-06-04 Thread Roman Gushchin
The delayed work/rcu deactivation infrastructure of non-root kmem_caches can be also used for asynchronous release of these objects. Let's get rid of the word "deactivation" in corresponding names to make the code look better after generalization. It's easier to make the renaming first, so that

[PATCH v6 07/10] mm: synchronize access to kmem_cache dying flag using a spinlock

2019-06-04 Thread Roman Gushchin
Currently the memcg_params.dying flag and the corresponding workqueue used for the asynchronous deactivation of kmem_caches is synchronized using the slab_mutex. It makes impossible to check this flag from the irq context, which will be required in order to implement asynchronous release of

[PATCH v6 08/10] mm: rework non-root kmem_cache lifecycle management

2019-06-04 Thread Roman Gushchin
Currently each charged slab page holds a reference to the cgroup to which it's charged. Kmem_caches are held by the memcg and are released all together with the memory cgroup. It means that none of kmem_caches are released unless at least one reference to the memcg exists, which is very far from

[PATCH v6 02/10] mm: postpone kmem_cache memcg pointer initialization to memcg_link_cache()

2019-06-04 Thread Roman Gushchin
Initialize kmem_cache->memcg_params.memcg pointer in memcg_link_cache() rather than in init_memcg_params(). Once kmem_cache will hold a reference to the memory cgroup, it will simplify the refcounting. For non-root kmem_caches memcg_link_cache() is always called before the kmem_cache becomes

[PATCH v6 06/10] mm: unify SLAB and SLUB page accounting

2019-06-04 Thread Roman Gushchin
Currently the page accounting code is duplicated in SLAB and SLUB internals. Let's move it into new (un)charge_slab_page helpers in the slab_common.c file. These helpers will be responsible for statistics (global and memcg-aware) and memcg charging. So they are replacing direct

[PATCH v6 10/10] mm: reparent slab memory on cgroup removal

2019-06-04 Thread Roman Gushchin
Let's reparent memcg slab memory on memcg offlining. This allows us to release the memory cgroup without waiting for the last outstanding kernel object (e.g. dentry used by another application). So instead of reparenting all accounted slab pages, let's do reparent a relatively small amount of

[PATCH v6 04/10] mm: generalize postponed non-root kmem_cache deactivation

2019-06-04 Thread Roman Gushchin
Currently SLUB uses a work scheduled after an RCU grace period to deactivate a non-root kmem_cache. This mechanism can be reused for kmem_caches release, but requires generalization for SLAB case. Introduce kmemcg_cache_deactivate() function, which calls allocator-specific

[PATCH v6 00/10] mm: reparent slab memory on cgroup removal

2019-06-04 Thread Roman Gushchin
# Why do we need this? We've noticed that the number of dying cgroups is steadily growing on most of our hosts in production. The following investigation revealed an issue in userspace memory reclaim code [1], accounting of kernel stacks [2], and also the mainreason: slab objects. The underlying

[PATCH v6 01/10] mm: add missing smp read barrier on getting memcg kmem_cache pointer

2019-06-04 Thread Roman Gushchin
Johannes noticed that reading the memcg kmem_cache pointer in cache_from_memcg_idx() is performed using READ_ONCE() macro, which doesn't implement a SMP barrier, which is required by the logic. Add a proper smp_rmb() to be paired with smp_wmb() in memcg_create_kmem_cache(). The same applies to

[PATCH v6 09/10] mm: stop setting page->mem_cgroup pointer for slab pages

2019-06-04 Thread Roman Gushchin
Every slab page charged to a non-root memory cgroup has a pointer to the memory cgroup and holds a reference to it, which protects a non-empty memory cgroup from being released. At the same time the page has a pointer to the corresponding kmem_cache, and also hold a reference to the kmem_cache.

Re: [PATCH 3/3] rpmsg: virtio_rpmsg_bus: get buffer size from config space

2019-06-04 Thread xiang xiao
On Tue, Jun 4, 2019 at 10:25 PM Arnaud Pouliquen wrote: > > Hello Xiang, > > On 5/9/19 3:00 PM, xiang xiao wrote: > > On Thu, May 9, 2019 at 8:36 PM Arnaud Pouliquen > > wrote: > >> > >> Hello Xiang, > >> > >> Similar mechanism has been proposed by Loic 2 years ago (link to the > >> series here

Re: [PATCH v3] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work

2019-06-04 Thread Martin K. Petersen
Nathan, > clang warns: > > drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used > uninitialized whenever switch case is taken [-Wsometimes-uninitialized] > case IBMVSCSI_HOST_ACTION_NONE: > ^ Applied to 5.3/scsi-queue, thanks! --

Re: [PATCH V2 2/2] zswap: Add module parameter malloc_movable_if_support

2019-06-04 Thread Hui Zhu
Shakeel Butt 于2019年6月5日周三 上午1:12写道: > > On Sun, Jun 2, 2019 at 2:47 AM Hui Zhu wrote: > > > > This is the second version that was updated according to the comments > > from Sergey Senozhatsky in https://lkml.org/lkml/2019/5/29/73 > > > > zswap compresses swap pages into a dynamically allocated

Re: [PATCH v5 1/8] KVM: VMX: Define CET VMCS fields and control bits

2019-06-04 Thread Yang Weijiang
On Tue, Jun 04, 2019 at 07:46:13AM -0700, Sean Christopherson wrote: > On Wed, May 22, 2019 at 03:00:54PM +0800, Yang Weijiang wrote: > > CET(Control-flow Enforcement Technology) is an upcoming Intel® processor > > family feature that blocks return/jump-oriented programming (ROP) attacks. > > It

Re: [PATCH -next] scsi: lpfc: Make some symbols static

2019-06-04 Thread Martin K. Petersen
YueHaibing, > Fix sparse warnings: > > drivers/scsi/lpfc/lpfc_sli.c:115:1: warning: symbol 'lpfc_sli4_pcimem_bcopy' > was not declared. Should it be static? > drivers/scsi/lpfc/lpfc_sli.c:7854:1: warning: symbol > 'lpfc_sli4_process_missed_mbox_completions' was not declared. Should it be >

Re: [PATCH -next] scsi: lpfc: Remove set but not used variables 'qp'

2019-06-04 Thread Martin K. Petersen
YueHaibing, > Fixes gcc '-Wunused-but-set-variable' warnings: > > drivers/scsi/lpfc/lpfc_init.c: In function lpfc_setup_cq_lookup: > drivers/scsi/lpfc/lpfc_init.c:9359:30: warning: variable qp set but not used > [-Wunused-but-set-variable] Applied to 5.3/scsi-queue, thanks. -- Martin K.

Re: [PATCH v3 7/8] dmaengine: fsl-edma: add i.mx7ulp edma2 version support

2019-06-04 Thread Robin Gong
On 2019-06-04 at 12:37 +, Vinod Koul wrote: > On 29-05-19, 17:08, yibin.g...@nxp.com wrote: > > > > From: Robin Gong > > > >   Add edma2 for i.mx7ulp by version v3, since v2 has already > Why leading spaces at start of line? Sorry for the typo, will fix in next version > > > > > been used

Re: [PATCH v3 5/8] dmaengine: fsl-edma: add drvdata for vf610

2019-06-04 Thread Robin Gong
On 二, 2019-06-04 at 18:03 +0530, Vinod Koul wrote: > On 29-05-19, 17:08, yibin.g...@nxp.com wrote: > > > > > @@ -205,8 +228,9 @@ static int fsl_edma_probe(struct > > platform_device *pdev) > >   if (!fsl_edma) > >   return -ENOMEM; > >   > > - fsl_edma->version = v1; > > -

Re: [PATCH 0/6] hisi_sas: Some misc patches

2019-06-04 Thread Martin K. Petersen
John, > This patchset introduces some misc patches for the driver. Nothing > particularly stands out, maybe apart from a patch to delete a PHY's > timer when necessary. Applied to 5.3/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: rcu_read_lock lost its compiler barrier

2019-06-04 Thread Herbert Xu
On Tue, Jun 04, 2019 at 02:14:49PM -0700, Paul E. McKenney wrote: > > Yeah, I know, even with the "volatile" keyword, it is not entirely clear > how much reordering the compiler is allowed to do. I was relying on > https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html, which says: The volatile

Re: [RFC PATCH v4] rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver

2019-06-04 Thread Chris Chiu
On Tue, Jun 4, 2019 at 3:21 AM Jes Sorensen wrote: > > On 5/31/19 5:12 AM, Chris Chiu wrote: > > We have 3 laptops which connect the wifi by the same RTL8723BU. > > The PCI VID/PID of the wifi chip is 10EC:B720 which is supported. > > They have the same problem with the in-kernel rtl8xxxu driver,

Re: [PATCH] USB: move usb debugfs directory creation to the usb common core

2019-06-04 Thread Chunfeng Yun
On Tue, 2019-06-04 at 13:59 +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 04, 2019 at 11:32:58AM +0200, Greg Kroah-Hartman wrote: > > The USB gadget subsystem wants to use the USB debugfs root directory, so > > move it to the common "core" USB code so that it is properly initialized > > and

Re: [PATCH] scsi: ufs: Check that space was properly alloced in copy_query_response

2019-06-04 Thread Martin K. Petersen
Avri, > struct ufs_dev_cmd is the main container that supports device management > commands. In the case of a read descriptor request, we assume that the > proper space was allocated in dev_cmd to hold the returning descriptor. > > This is no longer true, as there are flows that doesn't use

linux-next: build failure after merge of the tpmdd tree

2019-06-04 Thread Stephen Rothwell
errors Caused by commit b25b956d13d5 ("tpm: Reserve the TPM final events table") I have used the tpmdd tree from next-20190604 for today. -- Cheers, Stephen Rothwell pgpVmsRswq6ex.pgp Description: OpenPGP digital signature

Re: [PATCH net] tcp: avoid creating multiple req socks with the same tuples

2019-06-04 Thread maowenan
On 2019/6/4 23:24, Eric Dumazet wrote: > On Tue, Jun 4, 2019 at 7:47 AM Mao Wenan wrote: >> >> There is one issue about bonding mode BOND_MODE_BROADCAST, and >> two slaves with diffierent affinity, so packets will be handled >> by different cpu. These are two pre-conditions in this case. >> >>

[PATCH] drivers/usb/host/imx21-hcd.c: fix divide-by-zero in func nonisoc_etd_done

2019-06-04 Thread Duyanlin
If the function usb_maxpacket(urb->dev, urb->pipe, usb_pipeout(urb->pipe)) returns 0, that will cause a illegal divide-by-zero operation, unexpected results may occur. It is best to ensure that the denominator is non-zero before dividing by zero. Signed-off-by: Yanlin Du ---

Re: [PATCH v5 5/8] KVM: VMX: Load Guest CET via VMCS when CET is enabled in Guest

2019-06-04 Thread Yang Weijiang
On Tue, Jun 04, 2019 at 01:03:36PM -0700, Sean Christopherson wrote: > On Wed, May 22, 2019 at 03:00:58PM +0800, Yang Weijiang wrote: > > "Load Guest CET state" bit controls whether Guest CET states > > will be loaded at Guest entry. Before doing that, KVM needs > > to check if CPU CET feature is

Re: [PATCH v2] ARM: configs: Remove useless UEVENT_HELPER_PATH

2019-06-04 Thread Andrew Jeffery
On Tue, 4 Jun 2019, at 17:45, Krzysztof Kozlowski wrote: > Remove the CONFIG_UEVENT_HELPER_PATH because: > 1. It is disabled since commit 1be01d4a5714 ("driver: base: Disable >CONFIG_UEVENT_HELPER by default") as its dependency (UEVENT_HELPER) was >made default to 'n', > 2. It is not

[PATCH] media: platform: Fix Warning of Unneeded Semicolon reported by coccicheck

2019-06-04 Thread Shobhit Kukreti
fixed the warning in the files below drivers/media/platform/pxa_camera.c:1391:2-3: Unneeded semicolon drivers/media/platform/qcom/venus/vdec_ctrls.c:78:2-3: Unneeded semicolon drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c:146:3-4: Unneeded semicolon Signed-off-by: Shobhit Kukreti ---

Re: [RFC v2] irqchip/gic-its: fix command queue pointer comparison bug

2019-06-04 Thread Guoheyi
On 2019/6/4 18:28, Marc Zyngier wrote: Hi Heyi, On 13/05/2019 12:42, Heyi Guo wrote: When we run several VMs with PCI passthrough and GICv4 enabled, not pinning vCPUs, we will occasionally see below warnings in dmesg: ITS queue timeout (65440 65504 480) ITS cmd its_build_vmovp_cmd failed

Re: [PATCH 1/3 linux dev-5.1 v2] ARM: dts: aspeed: Add SGPM pinmux

2019-06-04 Thread Andrew Jeffery
On Wed, 5 Jun 2019, at 07:23, Hongwei Zhang wrote: > Add SGPM pinmux to ast2500-pinctrl function and group, to prepare for > supporting SGPIO in AST2500 SoC. > > Signed-off-by: Hongwei Zhang Reviewed-by: Andrew Jeffery > --- > Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt |

Re: [PATCH 1/3 linux dev-5.1 arm/soc v2] ARM: dts: aspeed: Add SGPM pinmux

2019-06-04 Thread Andrew Jeffery
On Wed, 5 Jun 2019, at 07:12, Hongwei Zhang wrote: > Add SGPM pinmux to ast2500-pinctrl function and group, to prepare for > supporting SGPIO in AST2500 SoC. > > Signed-off-by: Hongwei Zhang Reviewed-by: Andrew Jeffery > --- > arch/arm/boot/dts/aspeed-g5.dtsi | 5 + > 1 file changed,

Re: [RFC 4/6] workqueue: Convert for_each_wq to use built-in list check

2019-06-04 Thread Daniel Jordan
On Sat, Jun 01, 2019 at 06:27:36PM -0400, Joel Fernandes (Google) wrote: > list_for_each_entry_rcu now has support to check for RCU reader sections > as well as lock. Just use the support in it, instead of explictly > checking in the caller. > > Signed-off-by: Joel Fernandes (Google) > --- >

Re: possible deadlock in get_user_pages_unlocked (2)

2019-06-04 Thread syzbot
: 56b697c6 Add linux-next specific files for 20190604 git tree: linux-next final crash:https://syzkaller.appspot.com/x/report.txt?x=1255a2f2a0 console output: https://syzkaller.appspot.com/x/log.txt?x=1455a2f2a0 kernel config: https://syzkaller.appspot.com/x/.config?x

[PATCH 3/6] staging: kpc2000: kpc_spi: remove unnecessary struct member word_len

2019-06-04 Thread Geordan Neukum
The structure kp_spi_controller_state, defined in the kpc2000_spi driver, contains a member named word_len which is never used after initialization. Therefore, it should be removed for simplicity's sake. Signed-off-by: Geordan Neukum --- drivers/staging/kpc2000/kpc2000_spi.c | 3 --- 1 file

[PATCH 5/6] staging: kpc2000: kpc_spi: remove unnecessary ulong repr of i/o addr

2019-06-04 Thread Geordan Neukum
The kpc_spi driver stashes off an unsigned long representation of the i/o mapping returned by devm_ioremap_nocache(). This is unnecessary, as the only use of the unsigned long repr is to eventually be re-cast to an (u64 __iomem *). Instead of casting the (void __iomem *) to an (unsigned long) then

[PATCH 4/6] staging: kpc2000: kpc_spi: remove unnecessary struct member chip_select

2019-06-04 Thread Geordan Neukum
The structure kp_spi_controller_state, defined in the kpc2000_spi driver, contains a member named chip_select which is never used after initialization. Therefore, it should be removed for simplicity's sake. Signed-off-by: Geordan Neukum --- drivers/staging/kpc2000/kpc2000_spi.c | 2 -- 1 file

[PATCH 0/6] staging: kpc2000: kpc_spi: Assorted minor fixups

2019-06-04 Thread Geordan Neukum
Primarily just a bunch of unused / unnecessarily used struct member cleanup patches with the exception of one patch which removes an unnecessary cast to a (void *) in a couple of functions. Geordan Neukum (6): staging: kpc2000: kpc_spi: remove unnecessary struct member phys staging: kpc2000:

[PATCH 2/6] staging: kpc2000: kpc_spi: remove unnecessary struct member pin_dir

2019-06-04 Thread Geordan Neukum
The structure kpc_spi, defined in in the kpc2000_spi driver, contains a member named pin_dir which is never used after initialization. Therefore, it should be removed for simplicity's sake. Signed-off-by: Geordan Neukum --- drivers/staging/kpc2000/kpc2000_spi.c | 2 -- 1 file changed, 2

[PATCH 6/6] staging: kpc2000: kpc_spi: remove unnecessary cast in [read|write]_reg()

2019-06-04 Thread Geordan Neukum
The kpc_spi driver unnecessarily casts from a (u64 __iomem *) to a (void *) when invoking readq and writeq which both take a (void __iomem *) arg. There is no need for this cast, and it actually harms us by discarding the sparse cookie, __iomem. Make the driver stop performing this casting

[PATCH 1/6] staging: kpc2000: kpc_spi: remove unnecessary struct member phys

2019-06-04 Thread Geordan Neukum
The structure kp_spi_controller_state, defined in the kpc2000_spi driver, contains a member named phys which is never used after initialization. Therefore, it should be removed for simplicity's sake. Signed-off-by: Geordan Neukum --- drivers/staging/kpc2000/kpc2000_spi.c | 2 -- 1 file changed,

[RFC] Kernel Access to Ftrace instances.

2019-06-04 Thread Divya Indi
Hi, Please Review the patches that follow. These include - [PATCH 1/3] tracing: Relevant changes for kernel access to Ftrace instances. [PATCH 2/3] tracing: Adding additional NULL checks. [PATCH 3/3] tracing: Add 2 new funcs. for kernel access to Ftrace instances. Let me know if you have any

[PATCH 2/3] tracing: Adding additional NULL checks.

2019-06-04 Thread Divya Indi
Now that we have exported certain functions providing access to Ftrace instances from other kernel components, we are adding some additional NULL checks to ensure safe usage by the users. Signed-off-by: Divya Indi --- kernel/trace/trace.c| 3 +++ kernel/trace/trace_events.c | 2 ++ 2

[PATCH 1/3] tracing: Relevant changes for kernel access to Ftrace instances.

2019-06-04 Thread Divya Indi
For commit (f45d122): tracing: Kernel access to Ftrace instances. We need the following additional changes to ensure other kernel components can use these functions - 1) Remove static keyword for newly exported fn - ftrace_set_clr_event. 2) Add the req functions to header file

[PATCH 3/3] tracing: Add 2 new funcs. for kernel access to Ftrace instances.

2019-06-04 Thread Divya Indi
Adding 2 new functions - 1) trace_array_lookup : Look up and return a trace array, given its name. 2) trace_array_set_clr_event : Enable/disable event recording to the given trace array. Signed-off-by: Divya Indi --- include/linux/trace_events.h | 3 +++ kernel/trace/trace.c | 11

Re: [PATCH 4/4] cpufreq: add driver for Raspbery Pi

2019-06-04 Thread Eric Anholt
Nicolas Saenz Julienne writes: > Raspberry Pi's firmware offers and interface though which update it's > performance requirements. It allows us to request for specific runtime > frequencies, which the firmware might or might not respect, depending on > the firmware configuration and thermals. >

KMSAN: uninit-value in i2c_w

2019-06-04 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:f75e4cfe kmsan: use kmsan_handle_urb() in urb.c git tree: kmsan console output: https://syzkaller.appspot.com/x/log.txt?x=1514cdaaa0 kernel config: https://syzkaller.appspot.com/x/.config?x=602468164ccdc30a dashboard link:

KMSAN: uninit-value in sd_init

2019-06-04 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:f75e4cfe kmsan: use kmsan_handle_urb() in urb.c git tree: kmsan console output: https://syzkaller.appspot.com/x/log.txt?x=17eadebaa0 kernel config: https://syzkaller.appspot.com/x/.config?x=602468164ccdc30a dashboard link:

Re: [PATCH 1/4] clk: bcm2835: remove pllb

2019-06-04 Thread Eric Anholt
Nicolas Saenz Julienne writes: > Raspberry Pi's firmware controls this pll, we should use the firmware > interface to access it. > > Signed-off-by: Nicolas Saenz Julienne Acked-by: Eric Anholt If someone ever has a non-rpi 2835 to support, they can resurrect this. signature.asc

Re: [PATCH 3/4] clk: bcm2835: register Raspberry Pi's firmware clk device

2019-06-04 Thread Eric Anholt
Nicolas Saenz Julienne writes: > Registers clk-raspberrypi as a platform device as part of the driver's > probe sequence. Similar to how we have VCHI register platform devices for the services VCHI provides, shouldn't we have the firmware driver register the device for clk_raspberrypi? Or put

Re: [RFC 1/6] rcu: Add support for consolidated-RCU reader checking

2019-06-04 Thread Joel Fernandes
On Tue, Jun 04, 2019 at 04:01:00PM +0200, Rasmus Villemoes wrote: > On 02/06/2019 00.27, Joel Fernandes (Google) wrote: > > This patch adds support for checking RCU reader sections in list > > traversal macros. Optionally, if the list macro is called under SRCU or > > other lock/mutex protection,

[mm/vmalloc.c] 728e0fbf26: kernel_BUG_at_mm/vmalloc.c

2019-06-04 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-7): commit: 728e0fbf263e3ed359c10cb13623390564102881 ("mm/vmalloc.c: get rid of one single unlink_va() when merge") https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master in testcase: boot on test machine:

Re: [PATCH] signal: remove the wrong signal_pending() check in restore_user_sigmask()

2019-06-04 Thread Eric W. Biederman
Linus Torvalds writes: > On Tue, Jun 4, 2019 at 6:41 AM Oleg Nesterov wrote: >> >> This is the minimal fix for stable, I'll send cleanups later. > > Ugh. I htink this is correct, but I wish we had a better and more > intuitive interface. > > In particular, since restore_user_sigmask() basically

[PATCH v2 2/2] x86/asm: Pin sensitive CR0 bits

2019-06-04 Thread Kees Cook
With sensitive CR4 bits pinned now, it's possible that the WP bit for CR0 might become a target as well. Following the same reasoning for the CR4 pinning, this pins CR0's WP bit (but this can be done with a static value). Suggested-by: Peter Zijlstra Signed-off-by: Kees Cook ---

[PATCH v2 0/2] x86/asm: Pin sensitive CR4 and CR0 bits

2019-06-04 Thread Kees Cook
Hi, Here's a v2 that hopefully addresses the concerns from the v1 thread[1] on CR4 pinning. Now it's using static branches to avoid potential atomicity problems (though perhaps that is overkill), and it has dropped the needless volatile marking in favor of proper asm constraint flags. The one

[PATCH v2 1/2] x86/asm: Pin sensitive CR4 bits

2019-06-04 Thread Kees Cook
Several recent exploits have used direct calls to the native_write_cr4() function to disable SMEP and SMAP before then continuing their exploits using userspace memory access. This pins bits of CR4 so that they cannot be changed through a common function. This is not intended to be general ROP

[PATCH] irqchip/qcom: Use struct_size() in devm_kzalloc()

2019-06-04 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; struct boo entry[]; }; size = sizeof(struct foo) +

Re: [PATCH] phy: qcom-qmp: Correct READY_STATUS poll break condition

2019-06-04 Thread Evan Green
On Tue, Jun 4, 2019 at 4:24 PM Bjorn Andersson wrote: > > After issuing a PHY_START request to the QMP, the hardware documentation > states that the software should wait for the PCS_READY_STATUS to become > 1. > > With the introduction of c9b589791fc1 ("phy: qcom: Utilize UFS reset > controller")

mmotm 2019-06-04-16-33 uploaded

2019-06-04 Thread akpm
The mm-of-the-moment snapshot 2019-06-04-16-33 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You

  1   2   3   4   5   6   7   8   9   10   >