[PATCH] staging: emxx_udc: Use standard BIT() macro

2020-08-18 Thread Alex Dewar
Currently emxx_udc.h defines bit values using local macros. Use the standard one instead. Also, combine bit values with bitwise-or rather than addition, as suggested by Coccinelle. Signed-off-by: Alex Dewar --- drivers/staging/emxx_udc/emxx_udc.h | 456 +--- 1 file

[RFC PATCH V2] iomap: add support to track dirty state of sub pages

2020-08-18 Thread Yu Kuai
changes from v1: - separate set dirty and clear dirty functions - don't test uptodate bit in iomap_writepage_map() - use one bitmap array for uptodate and dirty. commit 9dc55f1389f9 ("iomap: add support for sub-pagesize buffered I/O without buffer heads") replace the per-block structure

[PATCH net] net: gemini: Fix missing free_netdev() in error path of gemini_ethernet_port_probe()

2020-08-18 Thread Wang Hai
Fix the missing free_netdev() before return from gemini_ethernet_port_probe() in the error handling case. Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/cortina/gemini.c | 35

Re: Kernel build error on BTFIDS vmlinux

2020-08-18 Thread Jiri Olsa
On Tue, Aug 18, 2020 at 12:56:08PM +0200, Jiri Olsa wrote: > On Tue, Aug 18, 2020 at 11:14:10AM +0200, Jiri Olsa wrote: > > On Tue, Aug 18, 2020 at 10:55:55AM +0200, Jesper Dangaard Brouer wrote: > > > > > > On latest DaveM net-git tree (06a4ec1d9dc652), after linking (LD vmlinux) > > > the > >

Re: [PATCH v2] hwmon: corsair-cpro: fix ccp_probe, add delay [HID related]

2020-08-18 Thread Guenter Roeck
On 8/18/20 6:12 AM, Marius Zachmann wrote: > On 18.08.20 at 17:35:33 CEST, Guenter Roeck wrote >> On Mon, Aug 17, 2020 at 09:00:40AM +0200, Marius Zachmann wrote: >>> Possibly because of the changes in usbhid/hid-core.c the first >>> raw input report is not received during ccp_probe function and

Re: [PATCH v3 2/5] coredump: Let dump_emit() bail out on short writes

2020-08-18 Thread Oleg Nesterov
On 08/18, Jann Horn wrote: > > + if (dump_interrupted()) > + return 0; > + n = __kernel_write(file, addr, nr, ); > + if (n != nr) > + return 0; > + file->f_pos = pos; Just curious, can't we simply do __kernel_write(file, addr, nr, >f_pos); and

RE: [PATCH v3 1/3] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role()

2020-08-18 Thread Shaikh, Azhar
Hi Enric, > -Original Message- > From: Enric Balletbo i Serra > Sent: Tuesday, August 18, 2020 6:38 AM > To: Shaikh, Azhar ; ble...@chromium.org; > gro...@chromium.org; heikki.kroge...@linux.intel.com; > pmal...@chromium.org > Cc: linux-kernel@vger.kernel.org; Mani, Rajmohan > ; Patel,

Re: [PATCH v5] usb: typec: tcpm: Migrate workqueue to RT priority for processing events

2020-08-18 Thread Guenter Roeck
On 8/18/20 3:58 AM, Greg Kroah-Hartman wrote: > On Thu, Jul 30, 2020 at 11:58:30PM -0700, Badhri Jagan Sridharan wrote: >> "tReceiverResponse 15 ms Section 6.6.2 >> The receiver of a Message requiring a response Shall respond >> within tReceiverResponse in order to ensure that the >> sender’s

Re: [PATCH v3 1/3] platform/chrome: cros_ec_typec: Send enum values to usb_role_switch_set_role()

2020-08-18 Thread Enric Balletbo i Serra
Hi Azhar, Thank you for your patch. On 11/8/20 21:37, Azhar Shaikh wrote: > usb_role_switch_set_role() has the second argument as enum for usb_role. > Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent. > This eventually translates to USB_ROLE_NONE in case of UFP and >

[PATCH] PCI: tegra: no need to check return value of debugfs_create functions

2020-08-18 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Lorenzo Pieralisi Cc: Rob Herring Cc: Bjorn Helgaas Cc: Thierry Reding Cc: Jonathan Hunter Cc: Vidya Sagar

[PATCH 3/7] media: exynos4-is: no need to check return value of debugfs_create functions

2020-08-18 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Kyungmin Park Cc: Sylwester Nawrocki Cc: Mauro Carvalho Chehab Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc:

[PATCH] regulator: dbx500: no need to check return value of debugfs_create functions

2020-08-18 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Liam Girdwood Cc: Mark Brown Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman ---

[PATCH 5/7] media: sti: no need to check return value of debugfs_create functions

2020-08-18 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Fabien Dessenne Cc: Mauro Carvalho Chehab Cc: Jean-Christophe Trotin Cc: linux-me...@vger.kernel.org Cc:

[PATCH 6/7] media: radio: si476x: no need to check return value of debugfs_create functions

2020-08-18 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman Cc: Alexios Zavras Cc: Thomas Gleixner Cc: Hans Verkuil Cc:

Re: [greybus-dev] [RFC PATCH v2 3/3] Add Device Tree Bindings for mikroBUS port

2020-08-18 Thread Laurent Pinchart
Hi Vaishnav, Thank you for the patch. On Tue, Aug 18, 2020 at 06:18:15PM +0530, Vaishnav M A wrote: > This patch adds device tree bindings for the mikroBUS port, > device tree overlays for the mikrobus Port on the BeagleBoard.org > PocketBeagle is available here : >

[PATCH 7/7] media: usb: uvc: no need to check return value of debugfs_create functions

2020-08-18 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Cc: linux-kernel@vger.kernel.org

[PATCH 4/7] media: mtk-vpu: no need to check return value of debugfs_create functions

2020-08-18 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Minghsiu Tsai Cc: Houlong Wei Cc: Andrew-CT Chen Cc: Tiffany Lin Cc: Mauro Carvalho Chehab Cc: Matthias

[PATCH 2/7] media: coda: no need to check return value of debugfs_create functions

2020-08-18 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Philipp Zabel Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Cc: linux-kernel@vger.kernel.org

[PATCH 1/7] media: cec: no need to check return value of debugfs_create functions

2020-08-18 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Cc: linux-kernel@vger.kernel.org

Re: [RFC 1/5] tty/sysrq: Make sysrq handler NMI aware

2020-08-18 Thread Sumit Garg
On Mon, 17 Aug 2020 at 22:49, Doug Anderson wrote: > > Hi, > > On Mon, Aug 17, 2020 at 7:08 AM Sumit Garg wrote: > > > > On Fri, 14 Aug 2020 at 20:27, Doug Anderson wrote: > > > > > > Hi, > > > > > > On Fri, Aug 14, 2020 at 12:24 AM Sumit Garg wrote: > > > > > > > > + Peter (author of

Re: [PATCH v36 15/24] x86/sgx: Allow a limited use of ATTRIBUTE.PROVISIONKEY for attestation

2020-08-18 Thread Jarkko Sakkinen
On Thu, Aug 06, 2020 at 06:00:02PM +0100, Darren Kenny wrote: > On Thursday, 2020-07-16 at 16:52:54 +03, Jarkko Sakkinen wrote: > > Provisioning Certification Enclave (PCE), the root of trust for other > > enclaves, generates a signing key from a fused key called Provisioning > > Certification

Re: [RFC 2/5] serial: core: Add framework to allow NMI aware serial drivers

2020-08-18 Thread Sumit Garg
On Mon, 17 Aug 2020 at 20:02, Daniel Thompson wrote: > > On Mon, Aug 17, 2020 at 07:53:55PM +0530, Sumit Garg wrote: > > On Mon, 17 Aug 2020 at 19:27, Doug Anderson wrote: > > > > > > Hi, > > > > > > On Mon, Aug 17, 2020 at 5:27 AM Sumit Garg wrote: > > > > > > > > Thanks for your suggestion,

Re: [PATCH] tools/power turbostat: fix output formatting for ACPI CST enumeration

2020-08-18 Thread David Arcari
Hi, Just want to make sure that this doesn't get lost. Please let me know if you feel there is a better approach. Thanks, -Dave On 8/10/20 10:43 AM, David Arcari wrote: turbostat formatting is broken with ACPI CST for enumeration. The problem is that the CX_ACPI% is eight characters long

Re: [PATCH] uart:8250: change lock order in serial8250_do_startup()

2020-08-18 Thread Andy Shevchenko
On Tue, Aug 18, 2020 at 02:52:18PM +0200, Petr Mladek wrote: > On Fri 2020-08-14 12:59:28, Andy Shevchenko wrote: > > On Fri, Aug 14, 2020 at 10:38:02AM +0900, Sergey Senozhatsky wrote: > > > We have a number of "uart.port->desc.lock vs desc.lock->uart.port" > > > lockdep reports coming from 8250

[PATCH v7 2/6] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage()

2020-08-18 Thread Coly Li
Currently nvme_tcp_try_send_data() doesn't use kernel_sendpage() to send slab pages. But for pages allocated by __get_free_pages() without __GFP_COMP, which also have refcount as 0, they are still sent by kernel_sendpage() to remote end, this is problematic. The new introduced helper

[PATCH v7 4/6] drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage()

2020-08-18 Thread Coly Li
In _drbd_send_page() a page is checked by following code before sending it by kernel_sendpage(), (page_count(page) < 1) || PageSlab(page) If the check is true, this page won't be send by kernel_sendpage() and handled by sock_no_sendpage(). This kind of check is exactly what macro

[PATCH v7 5/6] scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map()

2020-08-18 Thread Coly Li
In iscsci driver, iscsi_tcp_segment_map() uses the following code to check whether the page should or not be handled by sendpage: if (!recv && page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg))) The "page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)" part is to make sure the page can

Re: [PATCH] selftests: kvm: Use a shorter encoding to clear RAX

2020-08-18 Thread Yang Weijiang
On Mon, Aug 17, 2020 at 01:20:34PM -0400, Paolo Bonzini wrote: > From: Yang Weijiang > > If debug_regs.c is built with newer binutils, the resulting binary is > "optimized" > by the assembler: > > asm volatile("ss_start: " > "xor %%rax,%%rax\n\t" > "cpuid\n\t" >

[PATCH v7 6/6] libceph: use sendpage_ok() in ceph_tcp_sendpage()

2020-08-18 Thread Coly Li
In libceph, ceph_tcp_sendpage() does the following checks before handle the page by network layer's zero copy sendpage method, if (page_count(page) >= 1 && !PageSlab(page)) This check is exactly what sendpage_ok() does. This patch replace the open coded checks by sendpage_ok() as a code

[PATCH v7 3/6] tcp: use sendpage_ok() to detect misused .sendpage

2020-08-18 Thread Coly Li
commit a10674bf2406 ("tcp: detecting the misuse of .sendpage for Slab objects") adds the checks for Slab pages, but the pages don't have page_count are still missing from the check. Network layer's sendpage method is not designed to send page_count 0 pages neither, therefore both PageSlab() and

[PATCH v7 1/6] net: introduce helper sendpage_ok() in include/linux/net.h

2020-08-18 Thread Coly Li
The original problem was from nvme-over-tcp code, who mistakenly uses kernel_sendpage() to send pages allocated by __get_free_pages() without __GFP_COMP flag. Such pages don't have refcount (page_count is 0) on tail pages, sending them by kernel_sendpage() may trigger a kernel panic from a

Re: [PATCH v2] hwmon: corsair-cpro: fix ccp_probe, add delay [HID related]

2020-08-18 Thread Marius Zachmann
On 18.08.20 at 17:35:33 CEST, Guenter Roeck wrote > On Mon, Aug 17, 2020 at 09:00:40AM +0200, Marius Zachmann wrote: > > Possibly because of the changes in usbhid/hid-core.c the first > > raw input report is not received during ccp_probe function and it will > > timeout. I am not sure, whether

[PATCH v7 0/6] Introduce sendpage_ok() to detect misused sendpage in network related drivers

2020-08-18 Thread Coly Li
This series was original by a bug fix in nvme-over-tcp driver which only checked whether a page was allocated from slab allcoator, but forgot to check its page_count: The page handled by sendpage should be neither a Slab page nor 0 page_count page. As Sagi Grimberg suggested, the original fix is

Re: [RFC 2/5] serial: core: Add framework to allow NMI aware serial drivers

2020-08-18 Thread Sumit Garg
On Mon, 17 Aug 2020 at 19:58, Daniel Thompson wrote: > > On Mon, Aug 17, 2020 at 05:57:03PM +0530, Sumit Garg wrote: > > On Fri, 14 Aug 2020 at 19:43, Daniel Thompson > > wrote: > > > On Fri, Aug 14, 2020 at 04:47:11PM +0530, Sumit Garg wrote: > > > Does it look better if you create a new type

Re: [PATCH v3] ata: use generic power management

2020-08-18 Thread Vaibhav Gupta
On Mon, Aug 17, 2020 at 07:06:03AM -0700, Jens Axboe wrote: > On 8/17/20 2:25 AM, Vaibhav Gupta wrote: > > Hello, > > > > I am working to upgrade power management framework support for PCI drivers, > > as > > my project under the Linux Kernel Mentorship Program. > > > > The ultimate goal is to

drivers/usb/isp1760/isp1760-udc.c:270:17: sparse: sparse: incorrect type in assignment (different base types)

2020-08-18 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 06a4ec1d9dc652e17ee3ac2ceb6c7cf6c2b75cdd commit: 005b73d0dd83c9cb9420a196bea8070cde30ecac m68knommu: __force type casts for raw IO access date: 3 weeks ago config: m68k-randconfig-s031-20200818 (attached

Re: [PATCH] lockdep: Introduce CONFIG_LOCKDEP_LARGE

2020-08-18 Thread Tetsuo Handa
Peter, Ingo and Will. Would you answer (Q1) and (Q2)? On 2020/08/18 21:02, Dmitry Vyukov wrote: > On Tue, Aug 18, 2020 at 1:07 PM Tetsuo Handa > wrote: >> >> On 2020/08/18 18:57, Dmitry Vyukov wrote: >>> On Tue, Aug 4, 2020 at 4:36 AM Tetsuo Handa >>> wrote: Hello, Peter, Ingo and

Re: [PATCH] memory: omap-gpmc: Fix build error without CONFIG_OF

2020-08-18 Thread Krzysztof Kozlowski
On Tue, Aug 18, 2020 at 08:53:38PM +0800, YueHaibing wrote: > If CONFIG_OF is n, gcc fails: > > drivers/memory/omap-gpmc.o: In function `gpmc_omap_onenand_set_timings': > omap-gpmc.c:(.text+0x2a88): undefined reference to `gpmc_read_settings_dt' > > Add helper function to fix this. > > Fixes:

Re: [PATCH 11/17] bpf/task_iter: In task_file_seq_get_next use fnext_task

2020-08-18 Thread Eric W. Biederman
gt; [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: > https://github.com/0day-ci/linux/commits/Eric-W-Biederman/exec-Move-unshare_files-to

[PATCH V3] ARM: dts: omap3: Add cpu trips and cooling map for omap34/36 families

2020-08-18 Thread Adam Ford
Currently, OMAP3_THERMAL is disabled by default, so the bandgap sensor is unavailable, and enabling it will somewhat increase power consumption. However for boards which operate near their thermal limit, OMAP3_THERMAL can be enabled and monitored to keep the processor from either running too fast,

Re: [RFC PATCH 0/8] memcg: Enable fine-grained per process memory control

2020-08-18 Thread Matthew Wilcox
On Tue, Aug 18, 2020 at 12:04:44PM +0200, pet...@infradead.org wrote: > On Tue, Aug 18, 2020 at 10:27:37AM +0100, Chris Down wrote: > > pet...@infradead.org writes: > > > On Mon, Aug 17, 2020 at 10:08:23AM -0400, Waiman Long wrote: > > > > Memory controller can be used to control and limit the

Re: [PATCH] rndis_wlan: tighten check of rndis_query_oid return

2020-08-18 Thread Kalle Valo
t...@redhat.com wrote: > From: Tom Rix > > clang static analysis reports this problem > > rndis_wlan.c:3147:25: warning: Assigned value is garbage or undefined > wiphy->max_num_pmkids = le32_to_cpu(caps.num_pmkids); > ^

[PATCH] memory: omap-gpmc: Fix build error without CONFIG_OF

2020-08-18 Thread YueHaibing
If CONFIG_OF is n, gcc fails: drivers/memory/omap-gpmc.o: In function `gpmc_omap_onenand_set_timings': omap-gpmc.c:(.text+0x2a88): undefined reference to `gpmc_read_settings_dt' Add helper function to fix this. Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT") Signed-off-by:

Re: [PATCH] mwifiex: Do not use GFP_KERNEL in atomic context

2020-08-18 Thread Kalle Valo
Christophe JAILLET wrote: > A possible call chain is as follow: > mwifiex_sdio_interrupt(sdio.c) > --> mwifiex_main_process(main.c) > --> mwifiex_process_cmdresp (cmdevt.c) > --> mwifiex_process_sta_cmdresp

Re: [PATCH] uart:8250: change lock order in serial8250_do_startup()

2020-08-18 Thread Petr Mladek
On Fri 2020-08-14 12:59:28, Andy Shevchenko wrote: > On Fri, Aug 14, 2020 at 10:38:02AM +0900, Sergey Senozhatsky wrote: > > We have a number of "uart.port->desc.lock vs desc.lock->uart.port" > > lockdep reports coming from 8250 driver; this causes a bit of trouble > > to people, so let's fix it.

Re: [PATCH] adm8211: switch from 'pci_' to 'dma_' API

2020-08-18 Thread Kalle Valo
Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in

Re: [PATCH 17/17] file: Rename __close_fd to close_fd and remove the files parameter

2020-08-18 Thread Eric W. Biederman
Christoph Hellwig writes: > Please kill off ksys_close as well while you're at it. Good point. ksys_close is just a trivial wrapper around close_fd. So the one caller of ksys_close autofs_dev_ioctl_closemount can be trivially changed to call close_fd. Eric

Re: [PATCH] rtw88: fix spelling mistake: "unsupport" -> "unsupported"

2020-08-18 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > There are some spelling mistakes in rtw_info messages. Fix these. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 86c96422a3b3 rtw88: fix spelling mistake: "unsupport" -> "unsupported" --

Re: file metadata via fs API

2020-08-18 Thread Miklos Szeredi
On Tue, Aug 18, 2020 at 12:44 AM Linus Torvalds wrote: > So please. Can we just make a simple extended statfs() and be done > with it, instead of this hugely complex thing that does five different > things with the same interface and makes it really odd as a result? How do you propose handling

Re: [PATCH] wl1251, wlcore: fix spelling mistake "buld" -> "build"

2020-08-18 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in warning messages. Fix these. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. db8655c6299c wl1251, wlcore: fix spelling mistake "buld" -> "build" --

Re: [PATCH] brcmfmac: check ndev pointer

2020-08-18 Thread Kalle Valo
t...@redhat.com wrote: > From: Tom Rix > > Clang static analysis reports this error > > brcmfmac/core.c:490:4: warning: Dereference of null pointer > (*ifp)->ndev->stats.rx_errors++; > ^~~ > > In this block of code > > if (ret || !(*ifp) ||

[RFC PATCH v2 1/3] add mikrobus descriptors to greybus_manifest

2020-08-18 Thread Vaishnav M A
This patch adds new descriptors used in the manifest parsing inside the mikrobus driver, the device descriptor help to describe the devices on a mikroBUS port, mikrobus descriptor is used to set up the mikrobus port pinmux and GPIO states and property descriptor to pass named properties to device

[PATCH v6 3/6] tcp: use sendpage_ok() to detect misused .sendpage

2020-08-18 Thread Coly Li
commit a10674bf2406 ("tcp: detecting the misuse of .sendpage for Slab objects") adds the checks for Slab pages, but the pages don't have page_count are still missing from the check. Network layer's sendpage method is not designed to send page_count 0 pages neither, therefore both PageSlab() and

[RFC PATCH v2 3/3] Add Device Tree Bindings for mikroBUS port

2020-08-18 Thread Vaishnav M A
This patch adds device tree bindings for the mikroBUS port, device tree overlays for the mikrobus Port on the BeagleBoard.org PocketBeagle is available here : github.com/beagleboard/bb.org-overlays/blob/master/src/arm/PB-MIKROBUS-0.dts Signed-off-by: Vaishnav M A ---

[PATCH v6 5/6] scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map()

2020-08-18 Thread Coly Li
In iscsci driver, iscsi_tcp_segment_map() uses the following code to check whether the page should or not be handled by sendpage: if (!recv && page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg))) The "page_count(sg_page(sg)) >= 1 && !PageSlab(sg_page(sg)" part is to make sure the page can

[PATCH v6 6/6] libceph: use sendpage_ok() in ceph_tcp_sendpage()

2020-08-18 Thread Coly Li
In libceph, ceph_tcp_sendpage() does the following checks before handle the page by network layer's zero copy sendpage method, if (page_count(page) >= 1 && !PageSlab(page)) This check is exactly what sendpage_ok() does. This patch replace the open coded checks by sendpage_ok() as a code

[RFC PATCH v2 2/3] mikroBUS driver for add-on boards on mikrobus ports

2020-08-18 Thread Vaishnav M A
The mikrobus driver is updated to add mikrobus ports from device-tree overlays, the debug interfaces for adding mikrobus ports through sysFS is removed, and the driver considers the extended usage of mikrobus port pins from their standard purpose, for example an SHT15 add-on board will need the

[RFC PATCH v2 0/3] mikroBUS driver for add-on boards

2020-08-18 Thread Vaishnav M A
Hi, This Patch series is an update to the mikroBUS driver RFC v1 Patch : https://lkml.org/lkml/2020/7/24/518 . The mikrobus driver is updated to add mikrobus ports from device-tree overlays, the debug interfaces for adding mikrobus ports through sysFS is removed, and the driver considers the

Re: [PATCH] coresight: cti: remove pm_runtime_get_sync() from CPU hotplug

2020-08-18 Thread Mike Leach
On Tue, 18 Aug 2020 at 12:11, Tingwei Zhang wrote: > > Below BUG is triggered by call pm_runtime_get_sync() in > cti_cpuhp_enable_hw(). It's in CPU hotplug callback with interrupt > disabled. Pm_runtime_get_sync() calls clock driver to enable clock > which could sleep. Remove

[PATCH v6 0/6] Introduce sendpage_ok() to detect misused sendpage in network related drivers

2020-08-18 Thread Coly Li
This series was original by a bug fix in nvme-over-tcp driver which only checked whether a page was allocated from slab allcoator, but forgot to check its page_count: The page handled by sendpage should be neither a Slab page nor 0 page_count page. As Sagi Grimberg suggested, the original fix is

[PATCH v6 2/6] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage()

2020-08-18 Thread Coly Li
Currently nvme_tcp_try_send_data() doesn't use kernel_sendpage() to send slab pages. But for pages allocated by __get_free_pages() without __GFP_COMP, which also have refcount as 0, they are still sent by kernel_sendpage() to remote end, this is problematic. The new introduced helper

[PATCH v6 4/6] drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage()

2020-08-18 Thread Coly Li
In _drbd_send_page() a page is checked by following code before sending it by kernel_sendpage(), (page_count(page) < 1) || PageSlab(page) If the check is true, this page won't be send by kernel_sendpage() and handled by sock_no_sendpage(). This kind of check is exactly what macro

[PATCH v6 1/6] net: introduce helper sendpage_ok() in include/linux/net.h

2020-08-18 Thread Coly Li
The original problem was from nvme-over-tcp code, who mistakenly uses kernel_sendpage() to send pages allocated by __get_free_pages() without __GFP_COMP flag. Such pages don't have refcount (page_count is 0) on tail pages, sending them by kernel_sendpage() may trigger a kernel panic from a

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-18 Thread Roger Pau Monné
On Tue, Aug 18, 2020 at 02:01:35PM +0200, Marek Marczykowski-Górecki wrote: > On Mon, Aug 17, 2020 at 11:00:13AM +0200, Roger Pau Monné wrote: > > On Sun, Aug 16, 2020 at 02:19:49AM +0200, Marek Marczykowski-Górecki wrote: > > > In case of Xen PV dom0, Xen passes along info about system tables

Re: [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach

2020-08-18 Thread Kalle Valo
Wang Yufen wrote: > When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL, > we should destroy the workqueue. > > Reported-by: Hulk Robot > Signed-off-by: Wang Yufen Patch applied to wireless-drivers-next.git, thanks. 6c151410d5b5 brcm80211: fix possible memleak in

Re: [PATCH] perf top: Skip side-band event setup if HAVE_LIBBPF_SUPPORT is not set

2020-08-18 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 18, 2020 at 08:30:37PM +0800, Tiezhu Yang escreveu: > When I execute perf top without HAVE_LIBBPF_SUPPORT, there exists the > following segmentation fault, skip the side-band event setup to fix it, > this is similar with commit 1101c872c8c7 ("perf record: Skip side-band > event setup

Re: [PATCH] MIPS: Loongson64: Fix build error about redeclaration of enumerator 'VIRTUAL' and "CONFIG_DM_THIN_PROVISIONING"

2020-08-18 Thread Huacai Chen
Hi, Youling, On Tue, Aug 18, 2020 at 7:35 PM Youling Tang wrote: > > After commit 39c1485c8baa (MIPS: KVM: Add kvm guestsupport for Loongson-3) > > Fix the following build error: > > drivers/md/dm-thin.c:116:2: error: redeclaration of enumerator ‘VIRTUAL’ > VIRTUAL, > ^ > In file included

Re: [PATCH] block: rnbd: rnbd-srv: silence uninitialized variable warning

2020-08-18 Thread Brooke Basile
On 8/18/20 1:29 AM, Nathan Chancellor wrote: I don't think this is a proper fix since the root cause of the warning appears to be that we are ignoring the return value of rnbd_bio_map_kern. Should we not set err to that value like this (completely untested)? Cheers, Nathan diff --git

Re: [PATCH] p54: avoid accessing the data mapped to streaming DMA

2020-08-18 Thread Kalle Valo
Jia-Ju Bai wrote: > In p54p_tx(), skb->data is mapped to streaming DMA on line 337: > mapping = pci_map_single(..., skb->data, ...); > > Then skb->data is accessed on line 349: > desc->device_addr = ((struct p54_hdr *)skb->data)->req_id; > > This access may cause data inconsistency between

Re: [powerpc] 5.9.0-rc1 boot failure on POWER9 PowerVM LPAR

2020-08-18 Thread Michael Ellerman
Sachin Sant writes: > 5.9.0-rc1 fails to boot on POWER9 PowerVM LPAR with following message Looks like: https://lore.kernel.org/linuxppc-dev/20200814150509.225615-1-vaib...@linux.ibm.com/ cheers > Starting udev Kernel Device Manager... > [ OK ] Started udev Kernel Device

Good morning

2020-08-18 Thread Lisa Dennis
-- Hello. Greetings dd you received my previous email?

[PATCH v6] mm/zswap: move to use crypto_acomp API for hardware acceleration

2020-08-18 Thread Barry Song
Right now, all new ZIP drivers are adapted to crypto_acomp APIs rather than legacy crypto_comp APIs. Tradiontal ZIP drivers like lz4,lzo etc have been also wrapped into acomp via scomp backend. But zswap.c is still using the old APIs. That means zswap won't be able to work on any new ZIP drivers

[PATCH] perf top: Skip side-band event setup if HAVE_LIBBPF_SUPPORT is not set

2020-08-18 Thread Tiezhu Yang
When I execute perf top without HAVE_LIBBPF_SUPPORT, there exists the following segmentation fault, skip the side-band event setup to fix it, this is similar with commit 1101c872c8c7 ("perf record: Skip side-band event setup if HAVE_LIBBPF_SUPPORT is not set"). [yangtiezhu@linux perf]$ ./perf top

Re: [RFC PATCH v1 1/2] ASoC: rockchip-spdif: add description for rk3308

2020-08-18 Thread Mark Brown
On Sat, Aug 15, 2020 at 01:24:36PM +0200, Johan Jonker wrote: > A test with the command below shows that the compatible string > > "rockchip,rk3308-spdif", "rockchip,rk3328-spdif" This doesn't apply against current code, please check and resend. signature.asc Description: PGP signature

[PATCH] libceph: Convert to use the preferred fallthrough macro

2020-08-18 Thread Miaohe Lin
Convert the uses of fallthrough comments to fallthrough macro. Signed-off-by: Miaohe Lin --- net/ceph/ceph_hash.c| 20 ++-- net/ceph/crush/mapper.c | 2 +- net/ceph/messenger.c| 4 ++-- net/ceph/mon_client.c | 2 +- net/ceph/osd_client.c | 4 ++-- 5 files

Re: [PATCH 1/2] arm64/mm: Change THP helpers to comply with generic MM semantics

2020-08-18 Thread Jonathan Cameron
On Tue, 18 Aug 2020 15:11:58 +0530 Anshuman Khandual wrote: > On 08/18/2020 02:43 PM, Jonathan Cameron wrote: > > On Mon, 17 Aug 2020 14:49:43 +0530 > > Anshuman Khandual wrote: > > > >> pmd_present() and pmd_trans_huge() are expected to behave in the following > >> manner during various

Re: [PATCH STABLE 4.9] mm: Avoid calling build_all_zonelists_init under hotplug context

2020-08-18 Thread David Hildenbrand
On 18.08.20 13:00, Oscar Salvador wrote: > Recently a customer of ours experienced a crash when booting the > system while enabling memory-hotplug. > > The problem is that Normal zones on different nodes don't get their private > zone->pageset allocated, and keep sharing the initial boot_pageset.

Re: [PATCH STABLE 4.9] mm: Avoid calling build_all_zonelists_init under hotplug context

2020-08-18 Thread Michal Hocko
On Tue 18-08-20 13:00:46, Oscar Salvador wrote: > Recently a customer of ours experienced a crash when booting the > system while enabling memory-hotplug. > > The problem is that Normal zones on different nodes don't get their private > zone->pageset allocated, and keep sharing the initial

[PATCH] Harden autofs ioctl table

2020-08-18 Thread Matthew Wilcox
The table of ioctl functions should be marked const in order to put them in read-only memory, and we should use array_index_nospec() to avoid speculation disclosing the contents of kernel memory to userspace. Signed-off-by: Matthew Wilcox (Oracle) diff --git a/fs/autofs/dev-ioctl.c

out of bounds access on array error_text[] because of -ETIMEDOUT return from __send_command()

2020-08-18 Thread Colin Ian King
Hi, static analysis with coverity has found a buffer overflow issue with the brcmstb driver, I believe it may have been introduced with the following commit: commit a7c25759d8d84b64c437a78f05df7314b02934e5 Author: Markus Mayer Date: Tue Apr 2 16:01:00 2019 -0700 memory: brcmstb: dpfe:

Re: [PATCH v2] soc: fsl: enable acpi support

2020-08-18 Thread kernel test robot
Hi Ran, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.9-rc1 next-20200818] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

Re: [PATCH v3 3/3] selinux: add permission names to trace event

2020-08-18 Thread Stephen Smalley
On Tue, Aug 18, 2020 at 4:11 AM peter enderborg wrote: > > On 8/17/20 10:16 PM, Stephen Smalley wrote: > > On 8/17/20 1:07 PM, Thiébaud Weksteen wrote: > > > >> From: Peter Enderborg > >> > >> In the print out add permissions, it will look like: > >> <...>-1042 [007] 201.965142:

drivers/mtd/devices/pmc551.c:783:53: sparse: sparse: incorrect type in argument 2 (different address spaces)

2020-08-18 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 06a4ec1d9dc652e17ee3ac2ceb6c7cf6c2b75cdd commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 9 weeks ago config: arm-randconfig-s032-20200818 (attached

ATM

2020-08-18 Thread Company

[char-misc-next 08/13] mei: handle tx queue flushing for vtag connections

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin Since multiple file pointers (fp) can be associated with a single host client, upon close() only objects associated with the fp has to flushed from the tx queues. The control queues should be flushed only when all the connections are closed and the client is disconnected.

[char-misc-next 04/13] mei: add support for mei extended header.

2020-08-18 Thread Tomas Winkler
Add an extend header beyond existing 4 bytes of the mei message header. The extension is of variable length, starting with meta header that contains the number of headers and the overall size of the extended headers excluding meta header itself followed by TLV list of extended headers. Currently

[char-misc-next 06/13] mei: add a spin lock to protect rd_completed queue

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin In order to support vtags we need to access read completed queue out of driver big lock. Add a spin lock to protect rd_completed queue. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 6 ++--- drivers/misc/mei/client.c

[char-misc-next 10/13] mei: bus: unconditionally enable clients with vtag support

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin The list of clients is only visible via mei client bus. Enabling vtag clients on the mei client bus allows user-space to enumerate clients with vtag support by traversing the mei bus on sysfs. This feature is required for ACRN device model service. Signed-off-by:

[char-misc-next 12/13] mei: docs: add vtag ioctl documentation

2020-08-18 Thread Tomas Winkler
Add structured documenation for the new vtag ioctl Signed-off-by: Tomas Winkler --- Documentation/driver-api/mei/mei.rst | 37 1 file changed, 37 insertions(+) diff --git a/Documentation/driver-api/mei/mei.rst b/Documentation/driver-api/mei/mei.rst index

[char-misc-next 09/13] mei: bus: use zero vtag for bus clients.

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin The zero vtag is required for the read flow to work also for devices on the mei client bus. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 72 +- 1 file changed, 71 insertions(+), 1

[char-misc-next 13/13] mei: virtio: virtualization frontend driver

2020-08-18 Thread Tomas Winkler
This frontend driver implements MEI hw interface based on virtio framework to let MEI driver work without changes under virtualization. It requires a backend service in the ACRN device-model on the service OS side to make it work. The backend service will emulate mei routing and assign vtags for

[char-misc-next 11/13] mei: add connect with vtag ioctl

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin This IOCTL is used to associate the current file descriptor with a FW Client (given by UUID), and virtual tag (vtag). The IOCTL opens a communication channel between a host client and a FW client on a tagged channel. From this point on, every reader and write will

[char-misc-next 05/13] mei: bump hbm version to 2.2

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin Bump HBM version to 2.2 to indicate vtag support. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/hw.h b/drivers/misc/mei/hw.h index

Re: [PATCH 2/2] soundwire: fix port_ready[] dynamic allocation in mipi_disco and ASoC codecs

2020-08-18 Thread Pierre-Louis Bossart
On 8/18/20 1:36 AM, Vinod Koul wrote: On 18-08-20, 01:47, Bard Liao wrote: From: Pierre-Louis Bossart The existing code allocates memory for the total number of ports. This only works if the ports are contiguous, but will break if e.g. a Devices uses port0, 1, and 14. The port_ready[]

[char-misc-next 03/13] mei: add vtag support bit in client properties

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin Vtag support is on a client basis, meaning not every client supports it. The vtag capability is communicated via the client properties structure during client enumeration process. Export the propertiy via sysfs. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas

[char-misc-next 02/13] mei: restrict vtag support to hbm version 2.2

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin The vtag allows partitioning the mei messages into virtual groups/channels. Vtags are supported for firmwares with HBM version 2.2 and newer and only when a firmware confirms the support via capability handshake. This change only define vtag restrictions in order to make

[char-misc-next 07/13] mei: add a vtag map for each client

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin Vtag map is a list of tuples of vtag and file pointer (struct mei_cl_vtag) associated with a particular me host client. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 168 -

[PATCH][next] drm/amd/display: fix potential integer overflow when shifting 32 bit variable bl_pwm

2020-08-18 Thread Colin King
From: Colin Ian King The 32 bit unsigned integer bl_pwm is being shifted using 32 bit arithmetic and then being assigned to a 64 bit unsigned integer. There is a potential for a 32 bit overflow so cast bl_pwm to enforce a 64 bit shift operation to avoid this. Addresses-Coverity:

[char-misc-next 01/13] mei: hbm: add capabilities message

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin The new capabilities command in HBM version 2.2 allows performing capabilities handshake between the firmware and the host driver. The driver requests a capability by setting the appropriate bit in 24bit wide bitmask and the fw responses with the bit set providing the

[char-misc-next 00/13] mei: add support for virtual tags

2020-08-18 Thread Tomas Winkler
Add support for mei virtualization for ACRN but might be used for other purposes such as sandboxing. ACRN is an open-source hypervisor maintained by The Linux Foundation. The support for ACRN was added in kernel in v5.3. The patches were part of the ACRN service OS kernel for a while.

<    4   5   6   7   8   9   10   11   12   13   >