[PATCH] net: tipc: Convert to use the preferred fallthrough macro

2020-08-18 Thread Miaohe Lin
Convert the uses of fallthrough comments to fallthrough macro. Signed-off-by: Miaohe Lin --- net/tipc/bearer.c | 2 +- net/tipc/link.c | 2 +- net/tipc/socket.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index

drivers/media/cec/platform/tegra/tegra_cec.c:455:34: warning: unused variable 'tegra_cec_of_match'

2020-08-18 Thread kernel test robot
months ago config: x86_64-randconfig-r006-20200818 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 790878f291fa5dc58a1c560cb6cc76fd1bfd1c5a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin

Re: [PATCH v2] HID: usbhid: do not sleep when opening device

2020-08-18 Thread Johannes Hirte
On 2020 Jun 09, Dmitry Torokhov wrote: > usbhid tries to give the device 50 milliseconds to drain its queues when > opening the device, but dies it naively by simply sleeping in open handler, > which slows down device probing (and thus may affect overall boot time). > > However we do not need to

[PATCH] habanalabs: Include linux/bitfield.h only in habanalabs.h

2020-08-18 Thread Tomer Tayar
Include linux/bitfield.h only in habanalabs.h, instead of in each and every file that needs it, as habanalabs.h is already included by all. Signed-off-by: Tomer Tayar --- drivers/misc/habanalabs/common/habanalabs.h | 1 + drivers/misc/habanalabs/common/hw_queue.c | 1 -

[PATCH rdma-next 00/14] Cleanup locking and events in ucma

2020-08-18 Thread Leon Romanovsky
From: Leon Romanovsky >From Jason: Rework how the uevents for new connections are handled so all the locking ends up simpler and a work queue can be removed. This should also speed up destruction of ucma_context's as a flush_workqueue() was replaced with cancel_work_sync(). The simpler locking

Re: [PATCH] lockdep: Introduce CONFIG_LOCKDEP_LARGE

2020-08-18 Thread Dmitry Vyukov
On Tue, Aug 18, 2020 at 1:07 PM Tetsuo Handa wrote: > > On 2020/08/18 18:57, Dmitry Vyukov wrote: > > On Tue, Aug 4, 2020 at 4:36 AM Tetsuo Handa > > wrote: > >> > >> Hello, Peter, Ingo and Will. > >> > >> (Q1) Can we change the capacity using kernel config? > >> > >> (Q2) If we can change the

Re: [PATCH] mm/memory.c: Replace vmf->vma with variable vma

2020-08-18 Thread Matthew Wilcox
On Tue, Aug 18, 2020 at 04:46:07PM +0800, yanfei...@windriver.com wrote: > From: Yanfei Xu > > The code has declared a vma_struct named vma which is assigned a > value of vmf->vma. Thus, use variable vma directly here. > > Signed-off-by: Yanfei Xu Reviewed-by: Matthew Wilcox (Oracle)

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-18 Thread Marek Marczykowski-Górecki
On Mon, Aug 17, 2020 at 11:00:13AM +0200, Roger Pau Monné wrote: > On Sun, Aug 16, 2020 at 02:19:49AM +0200, Marek Marczykowski-Górecki wrote: > > In case of Xen PV dom0, Xen passes along info about system tables (see > > arch/x86/xen/efi.c), but not the memory map from EFI. > > I think that's

[PATCH] net: Relax the npages test against MAX_SKB_FRAGS

2020-08-18 Thread Miaohe Lin
The npages test against MAX_SKB_FRAGS can be relaxed if we succeed to allocate high order pages as the note in comment said. Signed-off-by: Miaohe Lin --- net/core/skbuff.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c

PROBLEM: Long Workqueue delays V2

2020-08-18 Thread Jim Baxter
I am asking this question again to include the fs-devel list. We have issues with the workqueue of the kernel overloading the CPU 0 when we we disconnect a USB stick. This results in other items on the shared workqueue being delayed by around 6.5 seconds with a default kernel configuration and

[PATCH -next] dmaengine: iop-adma: Fix pointer cast warnings

2020-08-18 Thread YueHaibing
drivers/dma/iop-adma.c: In function ‘iop_adma_alloc_chan_resources’: drivers/dma/iop-adma.c:447:13: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] hw_desc = (char *) iop_chan->device->dma_desc_pool; ^ drivers/dma/iop-adma.c:449:4: warning: cast

Re: [PATCH v2] perf sched timehist: Fix use of CPU list with summary option

2020-08-18 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 18, 2020 at 10:29:29AM +0900, Namhyung Kim escreveu: > Hi David, > > On Tue, Aug 18, 2020 at 2:09 AM David Ahern wrote: > > > > Do not update thread stats or show idle summary unless CPU is in > > the list of interest. > > > > Fixes: c30d630d1bcf ("perf sched timehist: Add support

Re: [PATCH 1/8] tty: n_gsm, eliminate indirection for gsm->{output,error}()

2020-08-18 Thread Greg KH
On Tue, Aug 18, 2020 at 10:56:48AM +0200, Jiri Slaby wrote: > gsm->output and ->error are set only to gsmld_output and gsm_error, > respectively. Call these functions directly and remove error and output > function pointers from struct gsm_mux completely. > > Note: we need a forward declaration

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-08-18 Thread Mike Rapoport
On Tue, Aug 18, 2020 at 08:30:29AM +0300, Jarkko Sakkinen wrote: > On Sun, Jul 26, 2020 at 11:14:08AM +0300, Mike Rapoport wrote: > > > > > > I'm not still sure that I fully understand this feedback as I don't see > > > any inherent and obvious difference to the v4. In that version fallbacks > >

Re: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-08-18 Thread Jason Gunthorpe
On Tue, Aug 18, 2020 at 01:09:01AM +, Tian, Kevin wrote: > The difference in my reply is not just about the implementation gap > of growing a userspace DMA framework to a passthrough framework. > My real point is about the different goals that each wants to achieve. > Userspace DMA is purely

[PATCH -next] vdpa: Remove duplicate include

2020-08-18 Thread YueHaibing
Remove duplicate include file Signed-off-by: YueHaibing --- drivers/vhost/vdpa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 3fab94f88894..95e2b8307a2a 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -22,7 +22,6 @@

Re: [PATCH v2 16/17] arm64: dts: imx8mp: Add media_blk_ctrl node

2020-08-18 Thread Dong Aisheng
On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa wrote: > > Some of the features of the media_ctrl will be used by some > different drivers in a way those drivers will know best, so adding the > syscon compatible we allow those to do just that. Only the resets > and the clocks are registered bit the

Re: [PATCH v2 15/17] arm64: dts: imx8mp: Add audio_blk_ctrl node

2020-08-18 Thread Dong Aisheng
On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa wrote: > > Some of the features of the audio_ctrl will be used by some > different drivers in a way those drivers will know best, so adding the > syscon compatible we allow those to do just that. Only the resets > and the clocks are registered bit the

[PATCH -next] phy: ti: j721e-wiz: Remove duplicate include

2020-08-18 Thread YueHaibing
Remove duplicate include file Signed-off-by: YueHaibing --- drivers/phy/ti/phy-j721e-wiz.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index 33c4cf0105a4..c9cfafe89cbf 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++

Re: [PATCH v2] ASoC: hdac_hdmi: support 'ELD' mixer

2020-08-18 Thread Kai Vehmanen
Hey, a general comment first. We are trying to move development to patch_hdmi, but given we still have platforms using hdac_hdmi, this patch seems like a useful addition. On Tue, 18 Aug 2020, Brent Lu wrote: > Add an binary mixer 'ELD' to each HDMI PCM device so user space > could read the

[PATCH -next] vdpa/mlx5: Remove duplicate include

2020-08-18 Thread YueHaibing
Remove duplicate include file Signed-off-by: YueHaibing --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index 9df69d5efe8c..12fb83dc1de9 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-18 Thread Marek Marczykowski-Górecki
On Mon, Aug 17, 2020 at 10:16:07AM +0200, Ard Biesheuvel wrote: > > @@ -331,7 +333,8 @@ void __init efi_esrt_init(void) > > > > end = esrt_data + size; > > pr_info("Reserving ESRT space from %pa to %pa.\n", _data, > > ); > > - if (md.type == EFI_BOOT_SERVICES_DATA) > > + > >

[PATCH -next] mm/madvise: Remove duplicate include

2020-08-18 Thread YueHaibing
Remove duplicate header which is included twice. Signed-off-by: YueHaibing --- mm/madvise.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/madvise.c b/mm/madvise.c index 843f6fad3b89..fda6164db356 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -29,7 +29,6 @@ #include #include

Re: [PATCH v2 12/17] clk: imx8mp: Add audio blk_ctrl clocks and resets

2020-08-18 Thread Dong Aisheng
On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa wrote: > > Add audio blk_ctrl clocks and resets in the i.MX8MP clock > driver to be picked up by the clk-blk-ctrl driver. > > Signed-off-by: Abel Vesa > --- > drivers/clk/imx/clk-blk-ctrl.c | 4 ++ > drivers/clk/imx/clk-imx8mp.c | 138 >

Re: [PATCH 02/16] vt: declare xy for get/putconsxy properly

2020-08-18 Thread Greg KH
On Tue, Aug 18, 2020 at 10:56:52AM +0200, Jiri Slaby wrote: > That is: > 1) call the parameter 'xy' to denote what it really is, not generic 'p' > 2) tell the compiler and users that we expect an array: >* with at least 2 chars (static 2) >* which we don't modify in putconsxy (const) > >

[PATCH] scsi: libfc: Fix passing zero to 'PTR_ERR' warning

2020-08-18 Thread YueHaibing
drivers/scsi/libfc/fc_disc.c:304 fc_disc_error() warn: passing zero to 'PTR_ERR' fc_disc_error() expect a ERR_PTR pointer, so pass ERR_PTR(err) to fix this. Signed-off-by: YueHaibing --- drivers/scsi/libfc/fc_disc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [RFC PATCH V3 04/21] mmc: core: UHS-II support, try to select UHS-II interface

2020-08-18 Thread Ulf Hansson
On Fri, 10 Jul 2020 at 13:08, Ben Chuang wrote: > > From: Ben Chuang > > The flow of "interface selection and initialization" was a bit modified > for UHS-II card. This commit follows the sequence defined in SD > specification (Part 1). > See section 7.2.3 in "UHS-II Simplified Addendum." > >

[PATCH -next] mm: slab: Remove duplicate include

2020-08-18 Thread YueHaibing
Remove duplicate header which is included twice. Signed-off-by: YueHaibing --- mm/slab.h | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/slab.h b/mm/slab.h index 6cc323f1313a..95e5cc1bb2a3 100644 --- a/mm/slab.h +++ b/mm/slab.h @@ -46,7 +46,6 @@ struct kmem_cache { #include #include

[PATCH] net: Avoid strcmp current->comm with warncomm when warned >= 5

2020-08-18 Thread Miaohe Lin
We can possibly avoid strcmp warncomm with current->comm by check warned first. Signed-off-by: Miaohe Lin --- net/core/sock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/sock.c b/net/core/sock.c index e4f40b175acb..51e13bc42791 100644 --- a/net/core/sock.c +++

Re: [PATCH v2 11/17] clk: imx: Add blk_ctrl combo driver

2020-08-18 Thread Dong Aisheng
On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa wrote: > > On i.MX8MP, there is a new type of IP which is called BLK_CTRL in > RM and usually is comprised of some GPRs that are considered too > generic to be part of any dedicated IP from that specific subsystem. > > In general, some of the GPRs have

[RFC][PATCH v2 06/10] irq_work: Provide irq_work_queue_remote_static()

2020-08-18 Thread Peter Zijlstra
Provide the same horrible semantics provided by smp_call_function_single_async(), doing so allows skiping a bunch of atomic ops. API wise this is horrible crap as it relies on external serialization. Signed-off-by: Peter Zijlstra (Intel) --- include/linux/irq_work.h |3 ++-

[PATCH v2 05/10] irq_work: Provide irq_work_queue_remote()

2020-08-18 Thread Peter Zijlstra
While the traditional irq_work relies on the ability to self-IPI, it makes sense to provide an unconditional irq_work_queue_remote() interface. This can be used to replace the plagued smp_call_function_single_async(). Signed-off-by: Peter Zijlstra (Intel) --- include/linux/irq_work.h | 17

[RFC][PATCH v2 10/10] irq_work: Add a few comments

2020-08-18 Thread Peter Zijlstra
Signed-off-by: Peter Zijlstra (Intel) --- include/linux/irq_work.h | 80 +-- kernel/irq_work.c| 10 + 2 files changed, 80 insertions(+), 10 deletions(-) --- a/include/linux/irq_work.h +++ b/include/linux/irq_work.h @@ -4,15 +4,6 @@

[RFC][PATCH v2 08/10] smp,irq_work: Use the new irq_work API

2020-08-18 Thread Peter Zijlstra
Convert the performance sensitive users of smp_call_single_function_async() over to the new irq_work_queue_remote_static(). The new API is marginally less crap but taking these users away allows fixing up smp_call_single_function_async() without risk of performance regressions. Signed-off-by:

[PATCH v2 03/10] irq_work: Optimize irq_work_single()

2020-08-18 Thread Peter Zijlstra
Trade one atomic op for a full memory barrier. Signed-off-by: Peter Zijlstra (Intel) --- include/linux/irqflags.h |8 kernel/irq_work.c| 29 + 2 files changed, 21 insertions(+), 16 deletions(-) --- a/include/linux/irqflags.h +++

[PATCH v2 02/10] smp: Cleanup smp_call_function*()

2020-08-18 Thread Peter Zijlstra
Get rid of the __call_single_node union and cleanup the API a little to avoid external code relying on the structure layout as much. Signed-off-by: Peter Zijlstra (Intel) --- arch/mips/kernel/process.c |5 +-- arch/mips/kernel/smp.c | 25

[PATCH] MIPS: Loongson64: Fix build error about redeclaration of enumerator 'VIRTUAL' and "CONFIG_DM_THIN_PROVISIONING"

2020-08-18 Thread Youling Tang
After commit 39c1485c8baa (MIPS: KVM: Add kvm guestsupport for Loongson-3) Fix the following build error: drivers/md/dm-thin.c:116:2: error: redeclaration of enumerator ‘VIRTUAL’ VIRTUAL, ^ In file included from ./arch/mips/include/asm/mach-loongson64/mmzone.h:12:0, from

[RFC][PATCH v2 09/10] smp: Make smp_call_function_single_async() safer

2020-08-18 Thread Peter Zijlstra
Make smp_call_function_single_async() a safer and more convenient interface by using an atomic op for setting CSD_FLAG_LOCK. This allows safe concurrent use of this function as would be expected by the -EBUSY return value. Signed-off-by: Peter Zijlstra (Intel) --- kernel/smp.c | 28

Re: [PATCH v3] sched/fair: simplfy the work when reweighting entity

2020-08-18 Thread peterz
On Tue, Aug 18, 2020 at 11:07:37AM +0200, Vincent Guittot wrote: > On Tue, 11 Aug 2020 at 13:32, Jiang Biao wrote: > > > > From: Jiang Biao > > > > The code in reweight_entity() can be simplified. > > > > For a sched entity on the rq, the entity accounting can be replaced by > > cfs_rq

Re: [PATCH] char: ipmi: convert tasklets to use new tasklet_setup() API

2020-08-18 Thread Corey Minyard
On Tue, Aug 18, 2020 at 02:46:23PM +0530, Allen wrote: > > > > > > Signed-off-by: Romain Perier > > > Signed-off-by: Allen Pais > > > > This looks good to me. > > > > Reviewed-by: Corey Minyard > > > > Are you planning to push this, or do you want me to take it? If you > > want me to take it,

[PATCH v2 00/10] smp: irq_work / smp_call_function rework

2020-08-18 Thread Peter Zijlstra
Hi, Here is a new version of the irq_work / smp_call_function integration / cleanup. I'm thinking the first (5?) patches should be ready to go in, all the dependents (i915, block) landed this merge window. The rest attempts to 'fix' smp_call_function_single_async() while migrating a number of

[PATCH v2 01/10] irq_work: Cleanup

2020-08-18 Thread Peter Zijlstra
Get rid of the __call_single_node union and clean up the API a little to avoid external code relying on the structure layout as much. Signed-off-by: Peter Zijlstra (Intel) --- drivers/gpu/drm/i915/i915_request.c |4 ++-- include/linux/irq_work.h| 33

[RFC][PATCH v2 07/10] sched/fair: Exclude the current CPU from find_new_ilb()

2020-08-18 Thread Peter Zijlstra
It is possible for find_new_ilb() to select the current CPU, however, this only happens from newidle balancing, in which case need_resched() will be true, and consequently nohz_csd_func() will not trigger the softirq. Exclude the current CPU from becoming an ILB target. Signed-off-by: Peter

Re: [PATCH] bfq: fix blkio cgroup leakage v4

2020-08-18 Thread Дмитрий Монахов
11.08.2020, 09:43, "Dmitry Monakhov" : > Changes from v1: > - update commit description with proper ref-accounting justification Ping paolo.valente@, please take a look at the patch proposed, it works fine on our fleet. Current situation is bad, it is impossible to use bfq with cgroup

[PATCH v3 1/2] tty/sysrq: Extend the sysrq_key_table to cover capital letters

2020-08-18 Thread Andrzej Pietrasiewicz
All slots in sysrq_key_table[] are either used, reserved or at least commented with their intended use. This patch adds capital letter versions available, which means adding 26 more entries. For already existing SysRq operations the user presses Alt-SysRq-, and for the newly added ones

[PATCH v3 0/2] Add configurable handler to execute a compound action

2020-08-18 Thread Andrzej Pietrasiewicz
This is a follow-up of this thread: https://www.spinics.net/lists/linux-input/msg68446.html It only touches DRM (dri-devel) in such a way that it changes the help message of sysrq_drm_fb_helper_restore_op, otherwise it is unrelated to DRM. Patch 2/2 adds a configurable handler to execute a

[PATCH v2 04/10] irq_work: Unconditionally build on SMP

2020-08-18 Thread Peter Zijlstra
Signed-off-by: Peter Zijlstra (Intel) --- kernel/Makefile |1 + kernel/irq_work.c |3 +++ 2 files changed, 4 insertions(+) --- a/kernel/Makefile +++ b/kernel/Makefile @@ -105,6 +105,7 @@ obj-$(CONFIG_TRACE_CLOCK) += trace/ obj-$(CONFIG_RING_BUFFER) += trace/

Re: [PATCH v2 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-08-18 Thread Andrzej Pietrasiewicz
W dniu 17.08.2020 o 22:09, kernel test robot pisze: Hi Andrzej, I love your patch! Yet something to improve: [auto build test ERROR on 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5] url:

Re: [PATCH 0/3] pinctrl: mcp23s08: Fixups for mcp23x17

2020-08-18 Thread Thomas Preston
On 17/08/2020 20:29, Rob Herring wrote: On Fri, Aug 14, 2020 at 02:56:54PM +0100, Thomas Preston wrote: Actually I think I'm wrong about the interrupt-controller changes in patches 0002 and 0003. You are. Looking at the datasheet, the GPIOs have interrupt capability. GPIO controllers are

[PATCH v3 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-08-18 Thread Andrzej Pietrasiewicz
Userland might want to execute e.g. 'w' (show blocked tasks), followed by 's' (sync), followed by 1000 ms delay and then followed by 'c' (crash) upon a single magic SysRq. Or one might want to execute the famous "Raising Elephants Is So Utterly Boring" action. This patch adds a configurable

drivers/irqchip/irq-ath79-misc.c:36:36: sparse: sparse: incorrect type in initializer (different address spaces)

2020-08-18 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 06a4ec1d9dc652e17ee3ac2ceb6c7cf6c2b75cdd commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 9 weeks ago config: mips-randconfig-s032-20200818 (attached

Re: [PATCH 17/17] file: Rename __close_fd to close_fd and remove the files parameter

2020-08-18 Thread Christoph Hellwig
Please kill off ksys_close as well while you're at it.

Re: [PATCH v2] Fixes: tty: serial: earlycon dependency

2020-08-18 Thread Greg KH
On Mon, Aug 17, 2020 at 02:54:19PM -0400, Tong Zhang wrote: > parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon > in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON > should automatically select SERIAL_CORE, otherwise will result in symbol > not found

Re: drivers/accessibility/speakup/serialio.c:139:9: sparse: sparse: cast removes address space '__iomem' of expression

2020-08-18 Thread Greg Kroah-Hartman
On Sun, Aug 16, 2020 at 03:51:20PM +0200, Samuel Thibault wrote: > kernel test robot, le dim. 16 août 2020 19:25:17 +0800, a ecrit: > > First bad commit (maybe != root cause): > > > >> drivers/accessibility/speakup/serialio.c:139:9: sparse: sparse: cast > > >> removes address space '__iomem' of

Re: [PATCH] genksyms: keywords: Use __restrict not _restrict

2020-08-18 Thread Masahiro Yamada
On Tue, Aug 18, 2020 at 12:32 PM Randy Dunlap wrote: > > On 8/17/20 6:05 PM, Masahiro Yamada wrote: > > On Sun, Aug 16, 2020 at 7:46 AM Randy Dunlap wrote: > >> > >> On 8/14/20 8:17 PM, Joe Perches wrote: > >>> On Fri, 2020-08-14 at 20:05 -0700, Linus Torvalds wrote: > On Fri, Aug 14, 2020

Re: [PATCH -next] binderfs: make symbol 'binderfs_fs_parameters' static

2020-08-18 Thread Christian Brauner
On Tue, Aug 18, 2020 at 07:22:45PM +0800, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/android/binderfs.c:66:32: warning: > symbol 'binderfs_fs_parameters' was not declared. Should it be static? > > This variable is not used outside of binderfs.c, so this commit >

[PATCH -next] binderfs: make symbol 'binderfs_fs_parameters' static

2020-08-18 Thread Wei Yongjun
The sparse tool complains as follows: drivers/android/binderfs.c:66:32: warning: symbol 'binderfs_fs_parameters' was not declared. Should it be static? This variable is not used outside of binderfs.c, so this commit marks it static. Fixes: 095cf502b31e ("binderfs: port to new mount api")

drivers/mtd/maps/physmap-versatile.c:116:17: sparse: sparse: incorrect type in argument 1 (different address spaces)

2020-08-18 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 06a4ec1d9dc652e17ee3ac2ceb6c7cf6c2b75cdd commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 9 weeks ago config: openrisc-randconfig-s031-20200818

[PATCH] coresight: cti: write regsiters directly in cti_enable_hw()

2020-08-18 Thread Tingwei Zhang
Deadlock as below is triggered by one CPU holds drvdata->spinlock and calls cti_enable_hw(). Smp_call_function_single() is called in cti_enable_hw() and tries to let another CPU write CTI registers. That CPU is trying to get drvdata->spinlock in cti_cpu_pm_notify() and doesn't response to IPI from

[PATCH] coresight: cti: remove pm_runtime_get_sync() from CPU hotplug

2020-08-18 Thread Tingwei Zhang
Below BUG is triggered by call pm_runtime_get_sync() in cti_cpuhp_enable_hw(). It's in CPU hotplug callback with interrupt disabled. Pm_runtime_get_sync() calls clock driver to enable clock which could sleep. Remove pm_runtime_get_sync() in cti_cpuhp_enable_hw() since pm_runtime_get_sync() is

[PATCH] coresight: cti: disclaim device only when it's claimed

2020-08-18 Thread Tingwei Zhang
Coresight_claim_device() is called in cti_starting_cpu() only when CTI is enabled while coresight_disclaim_device() is called uncontionally in cti_dying_cpu(). This triggered below WARNING. Only call disclaim device when CTI device is enabled to fix it. [ 75.989643] WARNING: CPU: 1 PID: 14 at

[PATCH v3.1 43/44] dt: document HiSilicon SPMI controller and mfd/regulator properties

2020-08-18 Thread Mauro Carvalho Chehab
From e464ec2c38c083403b556e60f189ee8ae2f2c9c6 Mon Sep 17 00:00:00 2001 From: Mauro Carvalho Chehab Date: Fri, 31 Jul 2020 09:46:02 +0200 Subject: [PATCH] dt: document HiSilicon SPMI controller and mfd/regulator properties Add documentation for the properties needed by the HiSilicon 6421v600

Re: [PATCH net-next RFC v2 13/13] devlink: Add Documentation/networking/devlink/devlink-reload.rst

2020-08-18 Thread Jiri Pirko
Tue, Aug 18, 2020 at 11:14:16AM CEST, mo...@nvidia.com wrote: > >On 8/17/2020 7:39 PM, Jiri Pirko wrote: >> Mon, Aug 17, 2020 at 11:37:52AM CEST, mo...@mellanox.com wrote: >> > Add devlink reload rst documentation file. >> > Update index file to include it. >> > >> > Signed-off-by: Moshe Shemesh

Re: [PATCH] lockdep: Introduce CONFIG_LOCKDEP_LARGE

2020-08-18 Thread Tetsuo Handa
On 2020/08/18 18:57, Dmitry Vyukov wrote: > On Tue, Aug 4, 2020 at 4:36 AM Tetsuo Handa > wrote: >> >> Hello, Peter, Ingo and Will. >> >> (Q1) Can we change the capacity using kernel config? >> >> (Q2) If we can change the capacity, is it OK to specify these constants >> independently? (In

Re: [PATCH 09/17] file: Implement fnext_task

2020-08-18 Thread Christian Brauner
On Mon, Aug 17, 2020 at 06:17:35PM -0700, Linus Torvalds wrote: > On Mon, Aug 17, 2020 at 6:06 PM Eric W. Biederman > wrote: > > > > I struggle with the fcheck name as I have not seen or at least not > > registed on the the user that just checks to see if the result is NULL. > > So the name

Re: [PATCH v5 0/6] Support running driver's probe for a device powered off

2020-08-18 Thread Sakari Ailus
Hi Tomasz, Bingbu, On Fri, Aug 14, 2020 at 03:17:58PM +0200, Tomasz Figa wrote: > On Fri, Aug 14, 2020 at 6:12 AM Bingbu Cao wrote: > > > > > > > > On 8/10/20 10:27 PM, Sakari Ailus wrote: > > > Hi all, > > > > > ...snip... > > > > > > The use case is such that there is a privacy LED next to an

Re: [PATCH v5 0/9] Raspberry Pi 4 USB firmware initialization rework

2020-08-18 Thread Greg KH
On Fri, Aug 14, 2020 at 12:04:05PM +0200, Nicolas Saenz Julienne wrote: > On Fri, 2020-08-14 at 08:11 +0200, Greg KH wrote: > > On Thu, Aug 13, 2020 at 12:17:49PM -0700, Florian Fainelli wrote: > > > > > > On 8/13/2020 3:01 AM, Nicolas Saenz Julienne wrote: > > > > Hi everyone. > > > > > > > >

drivers/usb/gadget/udc/fsl_udc_core.c:2423:33: sparse: sparse: cast removes address space '__iomem' of expression

2020-08-18 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 06a4ec1d9dc652e17ee3ac2ceb6c7cf6c2b75cdd commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 9 weeks ago config: powerpc-randconfig-s031-20200818

[PATCH] memory: brcmstb_dpfe: Fix memory leak

2020-08-18 Thread Alex Dewar
In brcmstb_dpfe_download_firmware(), memory is allocated to variable fw by firmware_request_nowarn(), but never released. Fix up to release fw on all return paths. Signed-off-by: Alex Dewar --- drivers/memory/brcmstb_dpfe.c | 18 +++--- 1 file changed, 11 insertions(+), 7

[PATCH STABLE 4.9] mm: Avoid calling build_all_zonelists_init under hotplug context

2020-08-18 Thread Oscar Salvador
Recently a customer of ours experienced a crash when booting the system while enabling memory-hotplug. The problem is that Normal zones on different nodes don't get their private zone->pageset allocated, and keep sharing the initial boot_pageset. The sharing between zones is normally safe as

Re: [PATCH 00/10] sound: convert tasklets to use new tasklet_setup()

2020-08-18 Thread Takashi Iwai
On Tue, 18 Aug 2020 12:44:32 +0200, Mark Brown wrote: > > On Tue, Aug 18, 2020 at 12:25:31PM +0200, Takashi Iwai wrote: > > > Mark, may I apply those ASoC patches through my tree together with > > others? Those seem targeting to 5.9, and I have a patch set to > > convert to tasklet for 5.10,

Re: [PATCH v5] usb: typec: tcpm: Migrate workqueue to RT priority for processing events

2020-08-18 Thread Greg Kroah-Hartman
On Thu, Jul 30, 2020 at 11:58:30PM -0700, Badhri Jagan Sridharan wrote: > "tReceiverResponse 15 ms Section 6.6.2 > The receiver of a Message requiring a response Shall respond > within tReceiverResponse in order to ensure that the > sender’s SenderResponseTimer does not expire." > > When the cpu

Re: [PATCH 0/3] Chunk Heap Support on DMA-HEAP

2020-08-18 Thread Brian Starkey
Hi, On Tue, Aug 18, 2020 at 05:04:12PM +0900, Hyesoo Yu wrote: > These patch series to introduce a new dma heap, chunk heap. > That heap is needed for special HW that requires bulk allocation of > fixed high order pages. For example, 64MB dma-buf pages are made up > to fixed order-4 pages * 1024.

Re: Kernel build error on BTFIDS vmlinux

2020-08-18 Thread Jiri Olsa
On Tue, Aug 18, 2020 at 11:14:10AM +0200, Jiri Olsa wrote: > On Tue, Aug 18, 2020 at 10:55:55AM +0200, Jesper Dangaard Brouer wrote: > > > > On latest DaveM net-git tree (06a4ec1d9dc652), after linking (LD vmlinux) > > the > > "BTFIDS vmlinux" fails. Are anybody else experiencing this? Are there

Re: PROBLEM: Long Workqueue delays.

2020-08-18 Thread Jim Baxter
On 17/08/2020 19:47, Alan Stern wrote: > > Unplugging a R/W USB drive without unmounting it first is a great way to > corrupt the data. > Thank you, post development we will only mount the USB stick as R/O. >> Using perf Iidentified the hub_events workqueue was spending a lot of time in >>

Re: [PATCH 2/2] nvme: add emulation for zone-append

2020-08-18 Thread Matias Bjørling
On 18/08/2020 11.50, Javier Gonzalez wrote: On 18.08.2020 09:12, Christoph Hellwig wrote: On Tue, Aug 18, 2020 at 10:59:36AM +0530, Kanchan Joshi wrote: If drive does not support zone-append natively, enable emulation using regular write. Make emulated zone-append cmd write-lock the zone,

Re: [PATCH drm/hisilicon 0/4] Use drv_err instead of DRM_ERROR in hibmc driver

2020-08-18 Thread Sam Ravnborg
On Tue, Aug 18, 2020 at 02:51:40PM +0800, Tian Tao wrote: > patch #1 is using the drv_err instead of DRM_ERROR in hibmc_ttm.c > patch #2 is using the drv_err instead of DRM_ERROR in hibmc_drm_vdac.c > patch #3 is using the drv_err and drm_dbg_atomic instead of DRM_ERROR > and DRM_DEBUG_ATOMIC in

RE: [PATCH 4.19 051/168] dyndbg: fix a BUG_ON in ddebug_describe_flags

2020-08-18 Thread David Laight
From: Pavel Machek > Sent: 18 August 2020 10:51 > > On Mon 2020-08-17 17:16:22, Greg Kroah-Hartman wrote: > > From: Jim Cromie > > > > [ Upstream commit f678ce8cc3cb2ad29df75d8824c74f36398ba871 ] > > > > ddebug_describe_flags() currently fills a caller provided string buffer, > > after testing

Re: [PATCH 4.19 040/168] drm/radeon: disable AGP by default

2020-08-18 Thread Christian König
Am 18.08.20 um 11:41 schrieb Pavel Machek: On Mon 2020-08-17 17:16:11, Greg Kroah-Hartman wrote: From: Christian König [ Upstream commit ba806f98f868ce107aa9c453fef751de9980e4af ] Always use the PCI GART instead. We just have to many cases where AGP still causes problems. This means a

Re: linux-next: manual merge of the fsinfo tree with the kbuid tree

2020-08-18 Thread Stephen Rothwell
Hi David, On Tue, 18 Aug 2020 09:19:18 +0100 David Howells wrote: > > Please drop the fsinfo branch for now, thanks. OK, done. What about the notifications tree? (not pushing, just wondering) -- Cheers, Stephen Rothwell pgpDmLj6JQZ34.pgp Description: OpenPGP digital signature

Re: [PATCH][RFC] ACPI: processor: Print more information when acpi_processor_evaluate_cst() failed

2020-08-18 Thread Rafael J. Wysocki
On Sun, Aug 16, 2020 at 5:12 PM Chen Yu wrote: > > Some platforms have bogus _CST which might cause expectd behavior > in the cpu idle driver. Some bogus _CST might be unable to be > disassembled by acpica-tools due to broken format. > Print extra log if the _CST extraction/verification failed. >

Re: [PATCH] n_gsm: Fix write handling for zero bytes written

2020-08-18 Thread Tony Lindgren
* Jiri Slaby [200818 10:14]: > On 18. 08. 20, 11:56, Tony Lindgren wrote: > > Hi, > > > > * Jiri Slaby [200818 08:24]: > >> On 17. 08. 20, 15:54, Tony Lindgren wrote: > >>> If write returns zero we currently end up removing the message > >>> from the queue. Instead of removing the message, we

Re: [PATCH 00/10] sound: convert tasklets to use new tasklet_setup()

2020-08-18 Thread Mark Brown
On Tue, Aug 18, 2020 at 12:25:31PM +0200, Takashi Iwai wrote: > Mark, may I apply those ASoC patches through my tree together with > others? Those seem targeting to 5.9, and I have a patch set to > convert to tasklet for 5.10, which would be better manageable when > based on top of those

[PATCH v2] mm/memory: Fix typo in __do_fault() comment

2020-08-18 Thread yanfei.xu
From: Yanfei Xu It's "pte_alloc_one", not "pte_alloc_pne". Let's fix that. Signed-off-by: Yanfei Xu Reviewed-by: David Hildenbrand --- v2: modify the commit message mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index

Re: [PATCH 12/17] proc/fd: In fdinfo seq_show don't use get_files_struct

2020-08-18 Thread Christian Brauner
On Mon, Aug 17, 2020 at 05:04:20PM -0500, Eric W. Biederman wrote: > When discussing[1] exec and posix file locks it was realized that none > of the callers of get_files_struct fundamentally needed to call > get_files_struct, and that by switching them to helper functions > instead it will both

RE: pcm|dmaengine|imx-sdma race condition on i.MX6

2020-08-18 Thread Robin Gong
On 2020/08/17 19:38 Benjamin Bara - SKIDATA wrote: > > -Original Message- > > From: Robin Gong > > Sent: Montag, 17. August 2020 11:23 > > busy_wait is not good I think, would you please have a try with the > > attached patch which is based on > >

Re: [PATCH 13/17] file: Remove get_files_struct

2020-08-18 Thread Christian Brauner
On Mon, Aug 17, 2020 at 05:04:21PM -0500, Eric W. Biederman wrote: > When discussing[1] exec and posix file locks it was realized that none > of the callers of get_files_struct fundamentally needed to call > get_files_struct, and that by switching them to helper functions > instead it will both

Re: [PATCH v3 43/44] dt: document HiSilicon SPMI controller and mfd/regulator properties

2020-08-18 Thread Mauro Carvalho Chehab
Em Tue, 18 Aug 2020 11:13:51 +0200 Mauro Carvalho Chehab escreveu: > Em Mon, 17 Aug 2020 14:12:11 -0600 > Rob Herring escreveu: > > > > + 'irq-mask-addr': > > > +description: Address for the interrupt request mask > > > + > > > + 'irq-addr': > > > +description: Address for the

Re: [PATCH 06/17] file: Implement fcheck_task

2020-08-18 Thread Christian Brauner
On Mon, Aug 17, 2020 at 05:04:14PM -0500, Eric W. Biederman wrote: > As a companion to fget_task implement fcheck_task for use for querying > a process about a specific file. > > Signed-off-by: "Eric W. Biederman" > --- Acked-by: Christian Brauner

Re: [RFC PATCH 0/8] memcg: Enable fine-grained per process memory control

2020-08-18 Thread peterz
On Tue, Aug 18, 2020 at 12:30:59PM +0200, Michal Hocko wrote: > The proposal also aims at much richer interface to define the > oom behavior. Oh yeah, I'm not defending any of that prctl() nonsense. Just saying that from a math / control theory point of view, the current thing is a abhorrent

[PATCH] x86/fsgsbase: Replace static_cpu_has() with boot_cpu_has()

2020-08-18 Thread Borislav Petkov
From: Borislav Petkov ptrace and prctl() are not really fast paths to warrant the use of static_cpu_has() and cause alternatives patching for no good reason. Replace with boot_cpu_has() which is simple and fast enough. No functional changes. Signed-off-by: Borislav Petkov ---

Re: [PATCH 07/17] proc/fd: In tid_fd_mode use fcheck_task

2020-08-18 Thread Christian Brauner
On Mon, Aug 17, 2020 at 05:04:15PM -0500, Eric W. Biederman wrote: > When discussing[1] exec and posix file locks it was realized that none > of the callers of get_files_struct fundamentally needed to call > get_files_struct, and that by switching them to helper functions > instead it will both

Re: [PATCH 08/17] proc/fd: In proc_fd_link use fcheck_task

2020-08-18 Thread Christian Brauner
On Mon, Aug 17, 2020 at 05:04:16PM -0500, Eric W. Biederman wrote: > When discussing[1] exec and posix file locks it was realized that none > of the callers of get_files_struct fundamentally needed to call > get_files_struct, and that by switching them to helper functions > instead it will both

Re: [RFC PATCH 0/8] memcg: Enable fine-grained per process memory control

2020-08-18 Thread Chris Down
pet...@infradead.org writes: On Tue, Aug 18, 2020 at 11:17:56AM +0100, Chris Down wrote: I'd ask that you understand a bit more about the tradeoffs and intentions of the patch before rushing in to declare its failure, considering it works just fine :-) Clamping the maximal time allows the

Re: [RFC][PATCH 1/9] irq_work: Cleanup

2020-08-18 Thread peterz
On Mon, Aug 17, 2020 at 06:00:05AM -0700, Paul E. McKenney wrote: > On Mon, Aug 17, 2020 at 11:16:33AM +0200, pet...@infradead.org wrote: > > On Mon, Aug 17, 2020 at 11:03:25AM +0200, pet...@infradead.org wrote: > > > On Thu, Jul 23, 2020 at 09:14:11AM -0700, Paul E. McKenney wrote: > > > > > ---

Re: [PATCH 0/2] KVM: arm64: Fix sleeping while atomic BUG() on OOM

2020-08-18 Thread Marc Zyngier
On Tue, 11 Aug 2020 11:27:23 +0100, Will Deacon wrote: > While stress-testing my arm64 stage-2 page-table rewrite [1], I ran into > a sleeping while atomic BUG() during OOM that I can reproduce with > mainline. > > The problem is that the arm64 page-table code periodically calls >

Re: [PATCH 0/2] KVM: arm64: Fix sleeping while atomic BUG() on OOM

2020-08-18 Thread Marc Zyngier
On 2020-08-18 11:16, Will Deacon wrote: On Tue, Aug 18, 2020 at 08:31:08AM +0200, Paolo Bonzini wrote: On 11/08/20 12:27, Will Deacon wrote: > Will Deacon (2): > KVM: Pass MMU notifier range flags to kvm_unmap_hva_range() > KVM: arm64: Only reschedule if MMU_NOTIFIER_RANGE_BLOCKABLE is not

Re: [RFC PATCH 0/8] memcg: Enable fine-grained per process memory control

2020-08-18 Thread Michal Hocko
On Tue 18-08-20 12:18:44, Peter Zijlstra wrote: > On Tue, Aug 18, 2020 at 12:05:16PM +0200, Michal Hocko wrote: > > > But then how can it run-away like Waiman suggested? > > > > As Chris mentioned in other reply. This functionality is quite new. > > > > > /me goes look... and finds

Re: [PATCH v5 2/2] Add Intel LGM soc DMA support.

2020-08-18 Thread Peter Ujfalusi
On 18/08/2020 13.16, Peter Ujfalusi wrote: ... >> +static void dma_issue_pending(struct dma_chan *chan) >> +{ >> +struct ldma_chan *c = to_ldma_chan(chan); >> +struct ldma_dev *d = to_ldma_dev(c->vchan.chan.device); >> +unsigned long flags; >> + >> +if (d->ver == DMA_VER22) {

Re: [PATCH] mm/memory.c: Correct the function name in comment

2020-08-18 Thread Xu, Yanfei
On 8/18/20 3:34 PM, David Hildenbrand wrote: On 18.08.20 09:29, yanfei...@windriver.com wrote: From: Yanfei Xu Correct the function name which is "pte_alloc_pne" to "pte_alloc_one" I'd have phrased this like "mm/memory: Fix typo in __do_fault() comment It's "pte_alloc_one", not

<    5   6   7   8   9   10   11   12   13   14   >