Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-16 Thread Jann Horn
On Sat, Oct 17, 2020 at 8:44 AM Willy Tarreau wrote: > On Sat, Oct 17, 2020 at 07:52:48AM +0200, Jann Horn wrote: > > On Sat, Oct 17, 2020 at 7:37 AM Willy Tarreau wrote: > > > On Sat, Oct 17, 2020 at 07:01:31AM +0200, Jann Horn wrote: > > > > Microsoft's documentation > > > > (http://go.microsof

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-16 Thread Willy Tarreau
On Sat, Oct 17, 2020 at 07:52:48AM +0200, Jann Horn wrote: > On Sat, Oct 17, 2020 at 7:37 AM Willy Tarreau wrote: > > On Sat, Oct 17, 2020 at 07:01:31AM +0200, Jann Horn wrote: > > > Microsoft's documentation > > > (http://go.microsoft.com/fwlink/?LinkId=260709) says that the VM > > > Generation I

Re: [RFC PATCH] topology: Represent clusters of CPUs within a die.

2020-10-16 Thread Greg Kroah-Hartman
On Fri, Oct 16, 2020 at 11:27:02PM +0800, Jonathan Cameron wrote: > Both ACPI and DT provide the ability to describe additional layers of > topology between that of individual cores and higher level constructs > such as the level at which the last level cache is shared. > In ACPI this can be repres

[PATCH] fat: Add KUnit tests for checksums and timestamps

2020-10-16 Thread David Gow
Add some basic sanity-check tests for the fat_checksum() function and the fat_time_unix2fat() and fat_time_fat2unix() functions. These unit tests verify these functions return correct output for a number of test inputs. These tests were inspored by -- and serve a similar purpose to -- the timestam

Re: [PATCH v2] checkpatch: add new exception to repeated word check

2020-10-16 Thread Joe Perches
On Wed, 2020-10-14 at 11:35 -0700, Joe Perches wrote: > On Wed, 2020-10-14 at 23:42 +0530, Dwaipayan Ray wrote: > > On Wed, Oct 14, 2020 at 11:33 PM Joe Perches wrote: > > > On Wed, 2020-10-14 at 22:07 +0530, Dwaipayan Ray wrote: > > > > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated wo

Dearest beloved in the Lord,

2020-10-16 Thread Mrs. Barbara Roth.
Dearest beloved in the Lord, Mine names are Mrs. Barbara Roth, I am a 66 years old woman. My beloved late husband is from United Kingdom England, while I am of a Dutch nationality by birth .I was born an orphan and GOD blessed me and mine late beloved husband with abundantly with riches bu

Re: [PATCH] video: fbdev: fsl-diu-fb: remove unneeded variable 'res'

2020-10-16 Thread Sam Ravnborg
On Thu, Sep 10, 2020 at 10:05:58PM +0800, Jason Yan wrote: > Eliminate the following coccicheck warning: > > drivers/video/fbdev/fsl-diu-fb.c:1428:5-8: Unneeded variable: "res". > Return "0" on line 1450 > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Hi Jason, applied to drm-misc-next

Re: [PATCH] video: fbdev: sis: remove unneeded semicolon

2020-10-16 Thread Sam Ravnborg
On Thu, Sep 10, 2020 at 10:05:36PM +0800, Jason Yan wrote: > Eliminate the following coccicheck warning: > > drivers/video/fbdev/sis/sis_accel.h:143:72-73: Unneeded semicolon > drivers/video/fbdev/sis/sis_accel.h:144:72-73: Unneeded semicolon > drivers/video/fbdev/sis/sis_accel.h:145:72-73: Unneed

Re: [PATCH] drm/mediatek: Optimize functions which do not need to return

2020-10-16 Thread Chun-Kuang Hu
Bernard Zhao 於 2020年10月13日 週二 下午4:55寫道: > > Function mtk_hdmi_aud_set_input always return 0, no need to > keep the return value. Functions mtk_hdmi_aud_enable_packet & > mtk_hdmi_aud_on_off_hw_ncts are the same, these two functions > just call next functions. Maybe it`s a bit better to just call >

[PATCH] drivers/thermal: remove unnecessary structure members allocated_tzp

2020-10-16 Thread Bernard Zhao
Struct power_allocator_params element allocated_tzp is only used in unbind to kfree the kzalloc space. Maybe we don’t have to need this member to mark, also, kfree will handle NULL point, there is no risk. This change is to make the code run a bit fast. Signed-off-by: Bernard Zhao --- drivers/th

Re: [PATCH -next] omapfb: connector-dvi: simplify the return expression of dvic_connect()

2020-10-16 Thread Sam Ravnborg
Hi Liu. On Tue, Sep 15, 2020 at 11:26:27AM +0800, Liu Shixin wrote: > Simplify the return expression. > > Signed-off-by: Liu Shixin Thanks, also applied. If you have other drm/fbdev patches pending then I have missed them. So please resend if this is the case. Sam > --- > drivers/vid

Re: UBSAN: array-index-out-of-bounds in alg_bind

2020-10-16 Thread Jann Horn
+linux-api because this is about fixing UAPI without breaking userspace On Sat, Oct 17, 2020 at 8:02 AM Kees Cook wrote: > On Fri, Oct 16, 2020 at 01:12:24AM -0700, syzbot wrote: > > dashboard link: https://syzkaller.appspot.com/bug?extid=92ead4eb8e26a26d465e > > [...] > > Reported-by: syzbot+92e

Re: [PATCH -next] drm/panel: simplify the return expression of rb070d30_panel_enable()

2020-10-16 Thread Sam Ravnborg
Hi Liu On Tue, Sep 15, 2020 at 11:26:23AM +0800, Liu Shixin wrote: > Simplify the return expression. > > Signed-off-by: Liu Shixin Thanks, applied to drm-misc-next. The patch will appear in drm-misc-next in a few weeks. Sam > --- > drivers/gpu/drm/panel/panel-ronbo-rb070d30.c | 7 +--

Re: [PATCH] staging: wfx: make a const array static, makes object smaller

2020-10-16 Thread Joe Perches
On Fri, 2020-10-16 at 23:33 +0100, Colin King wrote: > From: Colin Ian King > > Don't populate const array filter_ies on the stack but instead > make it static. Makes the object code smaller by 261 bytes. > > Before: >text data bss dec hex filename > 21674 316

Re: [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel

2020-10-16 Thread Sam Ravnborg
Hi Neil. On Tue, Sep 29, 2020 at 11:25:17AM +0200, Neil Armstrong wrote: > Hi Sam, > > Is there anything more to change ? Sorry for taking so long to get back to you on this. All patches looks good and are: Reviewed-by: Sam Ravnborg I assume you will apply the patches. Sam

Re: For review: seccomp_user_notif(2) manual page

2020-10-16 Thread Jann Horn
On Fri, Oct 16, 2020 at 8:29 PM Michael Kerrisk (man-pages) wrote: > On 10/15/20 10:32 PM, Jann Horn wrote: > > On Thu, Oct 15, 2020 at 1:24 PM Michael Kerrisk (man-pages) > > wrote: > >> On 9/30/20 5:53 PM, Jann Horn wrote: > >>> On Wed, Sep 30, 2020 at 1:07 PM Michael Kerrisk (man-pages) > >>>

Re: [PATCH v3] checkpatch: add new exception to repeated word check

2020-10-16 Thread Dwaipayan Ray
> Why include a + character here? > Hi, I tried it without + first, but then lines like "The the repeated word." didn't register a warning. I think checkpatch adds a + to the line when used on files. Am not sure but my $rawline was: +The the repeated word. > Please use "next if (test);" to be sim

Re: [PATCH v7 2/6] rcu/segcblist: Add counters to segcblist datastructure

2020-10-16 Thread joel
On Thu, Oct 15, 2020 at 02:21:58PM +0200, Frederic Weisbecker wrote: > On Wed, Oct 14, 2020 at 08:22:57PM -0400, Joel Fernandes (Google) wrote: > > Add counting of segment lengths of segmented callback list. > > > > This will be useful for a number of things such as knowing how big the > > ready-t

[PATCH v4 5/7] dma-buf: system_heap: Allocate higher order pages if available

2020-10-16 Thread John Stultz
While the system heap can return non-contiguous pages, try to allocate larger order pages if possible. This will allow slight performance gains and make implementing page pooling easier. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasa

Re: [PATCH 2/2] ASoC: fsl_spdif: Add support for i.MX8QM platform

2020-10-16 Thread Nicolin Chen
On Thu, Oct 15, 2020 at 01:28:48PM +0800, Shengjiu Wang wrote: > On i.MX8QM, there are separate interrupts for TX and RX. > > As the EDMA can't be configured to swing back to first FIFO > after writing the second FIFO, so we need to force the burst > size to be 2 on i.MX8QM. And EDMA don't support

Re: [PATCH v7 6/6] rcu/segcblist: Add additional comments to explain smp_mb()

2020-10-16 Thread joel
Adding Alan as well as its memory barrier discussion ;-) On Thu, Oct 15, 2020 at 03:35:11PM +0200, Frederic Weisbecker wrote: > On Wed, Oct 14, 2020 at 08:23:01PM -0400, Joel Fernandes (Google) wrote: > > Memory barriers are needed when updating the full length of the > > segcblist, however it is

Re: [PATCH v4 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-10-16 Thread Nicolin Chen
On Tue, Oct 13, 2020 at 03:17:32PM +0300, Viorel Suman (OSS) wrote: > From: Viorel Suman > > XCVR (Audio Transceiver) is a on-chip functional module found > on i.MX8MP. It support HDMI2.1 eARC, HDMI1.4 ARC and SPDIF. > > Signed-off-by: Viorel Suman Acked-by: Nicolin Chen

[PATCH v4 4/7] dma-buf: heaps: Skip sync if not mapped

2020-10-16 Thread John Stultz
This patch is basically a port of Ørjan Eide's similar patch for ION https://lore.kernel.org/lkml/20200414134629.54567-1-orjan.e...@arm.com/ Only sync the sg-list of dma-buf heap attachment when the attachment is actually mapped on the device. dma-bufs may be synced at any time. It can be reache

Re: [PATCH 0/3] net: dsa: move skb reallocation to dsa_slave_xmit

2020-10-16 Thread Florian Fainelli
On 10/16/2020 1:02 PM, Christian Eggers wrote: [snip] On Friday, 16 October 2020, 20:03:11 CEST, Jakub Kicinski wrote: FWIW if you want to avoid the reallocs you may want to set needed_tailroom on the netdev. I haven't looked for this yet. If this can really solve the tagging AND padding p

[PATCH v4 1/7] dma-buf: system_heap: Rework system heap to use sgtables instead of pagelists

2020-10-16 Thread John Stultz
In preparation for some patches to optmize the system heap code, rework the dmabuf exporter to utilize sgtables rather then pageslists for tracking the associated pages. This will allow for large order page allocations, as well as more efficient page pooling. In doing so, the system heap stops us

[PATCH v4 2/7] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation

2020-10-16 Thread John Stultz
Since the heap-helpers logic ended up not being as generic as hoped, move the heap-helpers dma_buf_ops implementations into the cma_heap directly. This will allow us to remove the heap_helpers code in a following patch. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hri

Re: [PATCH 5.8 00/14] 5.8.16-rc1 review

2020-10-16 Thread Jeffrin Jose T
On Fri, 2020-10-16 at 17:00 +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 16, 2020 at 07:41:05PM +0530, Jeffrin Jose T wrote: > > On Fri, 2020-10-16 at 11:07 +0200, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 5.8.16 > > > release. > > > There are 14 patches

[PATCH v4 6/7] dma-buf: dma-heap: Keep track of the heap device struct

2020-10-16 Thread John Stultz
Keep track of the heap device struct. This will be useful for special DMA allocations and actions. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Daniel Mentz Cc: Chris Goldsworthy Cc: Ørjan Eide Cc: Ro

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-16 Thread Jann Horn
On Sat, Oct 17, 2020 at 5:36 AM Willy Tarreau wrote: > On Sat, Oct 17, 2020 at 03:40:08AM +0200, Jann Horn wrote: > > [adding some more people who are interested in RNG stuff: Andy, Jason, > > Theodore, Willy Tarreau, Eric Biggers. also linux-api@, because this > > concerns some pretty fundamental

Re: UBSAN: array-index-out-of-bounds in alg_bind

2020-10-16 Thread Kees Cook
On Fri, Oct 16, 2020 at 01:12:24AM -0700, syzbot wrote: > dashboard link: https://syzkaller.appspot.com/bug?extid=92ead4eb8e26a26d465e > [...] > Reported-by: syzbot+92ead4eb8e26a26d4...@syzkaller.appspotmail.com > [...] > UBSAN: array-index-out-of-bounds in crypto/af_alg.c:166:2 > index 91 is out o

Re: [PATCH v39 21/24] x86/vdso: Implement a vDSO for Intel SGX enclave call

2020-10-16 Thread Andy Lutomirski
On Fri, Oct 2, 2020 at 9:51 PM Jarkko Sakkinen wrote: > > From: Sean Christopherson > > An SGX runtime must be aware of the exceptions, which happen inside an > enclave. Introduce a vDSO call that wraps EENTER/ERESUME cycle and returns > the CPU exception back to the caller exactly when it happen

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-16 Thread Jann Horn
[adding some more people who are interested in RNG stuff: Andy, Jason, Theodore, Willy Tarreau, Eric Biggers. also linux-api@, because this concerns some pretty fundamental API stuff related to RNG usage] On Fri, Oct 16, 2020 at 4:33 PM Catangiu, Adrian Costin wrote: > - Background > > The VM Gen

[PATCH v4 7/7] dma-buf: system_heap: Add a system-uncached heap re-using the system heap

2020-10-16 Thread John Stultz
This adds a heap that allocates non-contiguous buffers that are marked as writecombined, so they are not cached by the CPU. This is useful, as most graphics buffers are usually not touched by the CPU or only written into once by the CPU. So when mapping the buffer over and over between devices, we

Re: [PATCH net-next 1/3] net: dsa: don't pass cloned skb's to drivers xmit function

2020-10-16 Thread Florian Fainelli
On 10/16/2020 1:02 PM, Christian Eggers wrote: Ensure that the skb is not cloned and has enough tail room for the tail tag. This code will be removed from the drivers in the next commits. Signed-off-by: Christian Eggers --- [snip] + /* We have to pad he packet to the minimum Ethern

[PATCH v4 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation

2020-10-16 Thread John Stultz
Hey All, So this is another revision of my patch series to performance optimizations to the dma-buf system heap. This series reworks the system heap to use sgtables, and then consolidates the pagelist method from the heap-helpers into the CMA heap. After which the heap-helpers logic is removed (

[PATCH v4 3/7] dma-buf: heaps: Remove heap-helpers code

2020-10-16 Thread John Stultz
The heap-helpers code was not as generic as initially hoped and it is now not being used, so remove it from the tree. Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Daniel Mentz Cc: Chris Goldsworthy Cc:

Re: [RFC PATCH resend 3/6] mm: Add refcount for preserving mm_struct without pgd

2020-10-16 Thread Jann Horn
On Sat, Oct 17, 2020 at 1:21 AM Jason Gunthorpe wrote: > On Sat, Oct 17, 2020 at 01:09:12AM +0200, Jann Horn wrote: > > Currently, mm_struct has two refcounts: > > > > - mm_users: preserves everything - the mm_struct, the page tables, the > >memory mappings, and so on > > - mm_count: preserv

[PATCH v7 4/4] bus: mhi: Add userspace client interface driver

2020-10-16 Thread Hemant Kumar
This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates uci device object which is associated to device file node. uci device object instantiates uci channel object when device file node is opened. uci chan

Re: [PATCH v2] checkpatch: add new exception to repeated word check

2020-10-16 Thread Joe Perches
On Sat, 2020-10-17 at 10:02 +0530, Dwaipayan Ray wrote: > On Sat, Oct 17, 2020 at 8:26 AM Joe Perches wrote: > > On Wed, 2020-10-14 at 11:35 -0700, Joe Perches wrote: > > > On Wed, 2020-10-14 at 23:42 +0530, Dwaipayan Ray wrote: > > > > On Wed, Oct 14, 2020 at 11:33 PM Joe Perches wrote: > > > >

[PATCH v7 0/4] userspace MHI client interface driver

2020-10-16 Thread Hemant Kumar
This patch series adds support for UCI driver. UCI driver enables userspace clients to communicate to external MHI devices like modem and WLAN. UCI driver probe creates standard character device file nodes for userspace clients to perform open, read, write, poll and release file operations. These f

Re: [patch 4/4] media: cx231xx: Consolidate dmesg output

2020-10-16 Thread kernel test robot
Hi Thomas, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on linus/master linux/master v5.9 next-20201016] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

[PATCH v7 3/4] docs: Add documentation for userspace client interface

2020-10-16 Thread Hemant Kumar
MHI userspace client driver is creating device file node for user application to perform file operations. File operations are handled by MHI core driver. Currently Loopback MHI channel is supported by this driver. Signed-off-by: Hemant Kumar --- Documentation/mhi/index.rst | 1 + Documentation/

[PATCH v7 1/4] bus: mhi: core: Add helper API to return number of free TREs

2020-10-16 Thread Hemant Kumar
Introduce mhi_get_free_desc_count() API to return number of TREs available to queue buffer. MHI clients can use this API to know before hand if ring is full without calling queue API. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo --- drivers/bus/mhi/core/main.c | 12 includ

[PATCH v7 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file

2020-10-16 Thread Hemant Kumar
Currently this macro is defined in internal MHI header as a TRE length mask. Moving it to external header allows MHI client drivers to set this upper bound for the transmit buffer size. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo --- drivers/bus/mhi/core/internal.h | 1 - include/linu

[PATCH V2] mm: fix potential pte_unmap_unlock pte error

2020-10-16 Thread Shijie Luo
When flags don't have MPOL_MF_MOVE or MPOL_MF_MOVE_ALL bits, code breaks and passing origin pte - 1 to pte_unmap_unlock seems like not a good idea. Signed-off-by: Shijie Luo Signed-off-by: Michal Hocko Signed-off-by: Miaohe Lin --- mm/mempolicy.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 2/2] arm64: allow hotpluggable sections to be offlined

2020-10-16 Thread Sudarshan Rajagopalan
On receiving the MEM_GOING_OFFLINE notification, we disallow offlining of any boot memory by checking if section_early or not. With the introduction of SECTION_MARK_HOTPLUGGABLE, allow boot mem sections that are marked as hotpluggable with this bit set to be offlined and removed. This now allows ce

[PATCH 1/2] mm/memory_hotplug: allow marking of memory sections as hotpluggable

2020-10-16 Thread Sudarshan Rajagopalan
Certain architectures such as arm64 doesn't allow boot memory to be offlined and removed. Distinguish certain memory sections as "hotpluggable" which can be marked by module drivers stating to memory hotplug layer that these sections can be offlined and then removed. This is done by using a separat

[PATCH 0/2] mm/memory_hotplug, arm64: allow certain bootmem sections to be offlinable

2020-10-16 Thread Sudarshan Rajagopalan
In the patch that enables memory hot-remove (commit bbd6ec605c0f ("arm64/mm: Enable memory hot remove")) for arm64, there’s a notifier put in place that prevents boot memory from being offlined and removed. The commit text mentions that boot memory on arm64 cannot be removed. But x86 and other a

[PATCH v4 0/3] iommu/arm-smmu-qcom: Support maintaining bootloader mappings

2020-10-16 Thread Bjorn Andersson
This is the fourth attempt of inheriting the stream mapping for the framebuffer on many Qualcomm platforms, in order to not hit catastrophic faults during arm-smmu initialization. The new approach does, based on Robin's suggestion, take a much more direct approach with the allocation of a context

[PATCH v4 2/3] iommu/arm-smmu-qcom: Read back stream mappings

2020-10-16 Thread Bjorn Andersson
The Qualcomm boot loader configures stream mapping for the peripherals that it accesses and in particular it sets up the stream mapping for the display controller to be allowed to scan out a splash screen or EFI framebuffer. Read back the stream mappings during initialization and make the arm-smmu

[PATCH v4 3/3] iommu/arm-smmu-qcom: Implement S2CR quirk

2020-10-16 Thread Bjorn Andersson
The firmware found in some Qualcomm platforms intercepts writes to S2CR in order to replace bypass type streams with fault; and ignore S2CR updates of type fault. Detect this behavior and implement a custom write_s2cr function in order to trick the firmware into supporting bypass streams by the me

[PATCH v4 1/3] iommu/arm-smmu: Allow implementation specific write_s2cr

2020-10-16 Thread Bjorn Andersson
The firmware found in some Qualcomm platforms intercepts writes to the S2CR register in order to replace the BYPASS type with FAULT. Further more it treats faults at this level as catastrophic and restarts the device. Add support for providing implementation specific versions of the S2CR write fun

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-16 Thread Jann Horn
On Sat, Oct 17, 2020 at 7:37 AM Willy Tarreau wrote: > On Sat, Oct 17, 2020 at 07:01:31AM +0200, Jann Horn wrote: > > Microsoft's documentation > > (http://go.microsoft.com/fwlink/?LinkId=260709) says that the VM > > Generation ID that we get after a fork "is a 128-bit, > > cryptographically rando

drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c:932:2: warning: 'strncpy' specified bound 128 equals destination size

2020-10-16 Thread kernel test robot
Hi Jacopo, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 8119c4332d253660e0a6b8748fe0749961cfbc97 commit: b18ee53ad297264a79cf4ea53f20786b6455 staging: bcm2835: Break MMAL support out from camera date: 4 mon

Re: [PATCH v7 6/6] rcu/segcblist: Add additional comments to explain smp_mb()

2020-10-16 Thread joel
On Fri, Oct 16, 2020 at 09:27:53PM -0400, j...@joelfernandes.org wrote: [..] > > > + * > > > + * Memory barrier is needed after adding to length for the case > > > + * where length transitions from 0 -> 1. This is because rcu_barrier() > > > + * should never miss an update to the length. So the upd

Re: [PATCH v9 12/15] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR

2020-10-16 Thread Kuppuswamy, Sathyanarayanan
On 10/16/20 3:29 PM, Bjorn Helgaas wrote: [+cc Christoph, Ethan, Sinan, Keith; sorry should have cc'd you to begin with since you're looking at this code too. Particularly interested in your thoughts about whether we should be touching PCI_ERR_ROOT_COMMAND and PCI_ERR_ROOT_STATUS when we don't

Re: [PATCH v2] checkpatch: add new exception to repeated word check

2020-10-16 Thread Dwaipayan Ray
On Sat, Oct 17, 2020 at 8:26 AM Joe Perches wrote: > > On Wed, 2020-10-14 at 11:35 -0700, Joe Perches wrote: > > On Wed, 2020-10-14 at 23:42 +0530, Dwaipayan Ray wrote: > > > On Wed, Oct 14, 2020 at 11:33 PM Joe Perches wrote: > > > > On Wed, 2020-10-14 at 22:07 +0530, Dwaipayan Ray wrote: > > >

drivers/media/i2c/mt9t112.c:670:12: warning: stack frame size of 8344 bytes in function 'mt9t112_init_camera'

2020-10-16 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 071a0578b0ce0b0e543d1e38ee6926b9cc21c198 commit: f0fe00d4972a8cd4b98cc2c29758615e4d51cdfe security: allow using Clang's zero initialization for stack variables date: 4 months ago config: x86_64-randconfig-

Re: [EXT] Re: [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-10-16 Thread Alex Belits
On Mon, 2020-10-05 at 14:52 -0400, Nitesh Narayan Lal wrote: > On 10/4/20 7:14 PM, Frederic Weisbecker wrote: > > On Sun, Oct 04, 2020 at 02:44:39PM +, Alex Belits wrote: > > > On Thu, 2020-10-01 at 15:56 +0200, Frederic Weisbecker wrote: > > > > External Email > > > > > > > > ---

Re: [PATCH v4 3/3] clk: qcom: lpasscc-sc7180: Re-configure the PLL in case lost

2020-10-16 Thread Doug Anderson
Hi, On Fri, Oct 16, 2020 at 7:01 PM Stephen Boyd wrote: > > Quoting Stephen Boyd (2020-10-15 20:16:27) > > Quoting Douglas Anderson (2020-10-14 17:13:29) > > > From: Taniya Das > > > > > > In the case where the PLL configuration is lost, then the pm runtime > > > resume will reconfigure before u

Re: [PATCH 1/1] net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500

2020-10-16 Thread Andrew Lunn
> + if (priv->is_aspeed && > + phy_intf != PHY_INTERFACE_MODE_RMII && > + phy_intf != PHY_INTERFACE_MODE_RGMII && > + phy_intf != PHY_INTERFACE_MODE_RGMII_ID && > + phy_intf != PHY_INTERFACE_MODE_RGMII_RXID && > +

Re: [EXT] Re: [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-10-16 Thread Alex Belits
On Tue, 2020-10-06 at 12:35 +0200, Frederic Weisbecker wrote: > On Mon, Oct 05, 2020 at 02:52:49PM -0400, Nitesh Narayan Lal wrote: > > On 10/4/20 7:14 PM, Frederic Weisbecker wrote: > > > On Sun, Oct 04, 2020 at 02:44:39PM +, Alex Belits wrote: > > > > > > > The idea behind this is that isol

Re: [PATCH RFC V3 5/9] x86/pks: Add PKS kernel API

2020-10-16 Thread Ira Weiny
On Fri, Oct 16, 2020 at 01:07:47PM +0200, Peter Zijlstra wrote: > On Fri, Oct 09, 2020 at 12:42:54PM -0700, ira.we...@intel.com wrote: > > +static inline void pks_update_protection(int pkey, unsigned long > > protection) > > +{ > > + current->thread.saved_pkrs = update_pkey_val(current->thread.s

Re: [PATCH] mm: fix potential pte_unmap_unlock pte error

2020-10-16 Thread Shijie Luo
On 2020/10/16 22:05, osalva...@suse.de wrote: On 2020-10-16 15:42, Michal Hocko wrote: OK, I finally managed to convince my friday brain to think and grasped what the code is intended to do. The loop is hairy and we want to prevent from spurious EIO when all the pages are on a proper node. So th

Re: [PATCH v3] checkpatch: add new exception to repeated word check

2020-10-16 Thread Joe Perches
On Sat, 2020-10-17 at 10:52 +0530, Dwaipayan Ray wrote: > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test") > moved the repeated word test to check for more file types. But after > this, if checkpatch.pl is run on MAINTAINERS, it generates several > new warnings of the type: >

Re: 5.9.0-next-20201015: autofs oops in update-binfmts

2020-10-16 Thread Ian Kent
On Fri, 2020-10-16 at 14:35 +0200, Pavel Machek wrote: > Hi! > > I'm getting this during boot: 32-bit thinkpad x60. This is very odd. The change in next is essentially a revert of a change, maybe I'm missing something and the revert isn't quite a revert. Although there was one difference. I'll

drivers/dma/ppc4xx/adma.c:1188:34: sparse: sparse: incorrect type in argument 1 (different address spaces)

2020-10-16 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 071a0578b0ce0b0e543d1e38ee6926b9cc21c198 commit: 8f28ca6bd8211214faf717677bbffe375c2a6072 iomap: constify ioreadX() iomem argument (as in generic implementation) date: 9 weeks ago config: powerpc-randconfi

Re: [PATCH v7 3/3] iommu/tegra-smmu: Add PCI support

2020-10-16 Thread Nicolin Chen
On Fri, Oct 16, 2020 at 03:10:26PM +0100, Robin Murphy wrote: > On 2020-10-16 04:53, Nicolin Chen wrote: > > On Thu, Oct 15, 2020 at 10:55:52AM +0100, Robin Murphy wrote: > > > On 2020-10-15 05:13, Nicolin Chen wrote: > > > > On Wed, Oct 14, 2020 at 06:42:36PM +0100, Robin Murphy wrote: > > > > > O

[PATCH] skd_main: remove unused including

2020-10-16 Thread Tian Tao
Remove including that don't need it. Signed-off-by: Tian Tao --- drivers/block/skd_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index ae6454c..a962b45 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -25,7 +

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-16 Thread Jann Horn
On Sat, Oct 17, 2020 at 6:34 AM Colm MacCarthaigh wrote: > On 16 Oct 2020, at 21:02, Jann Horn wrote: > > On Sat, Oct 17, 2020 at 5:36 AM Willy Tarreau wrote: > > But in userspace, we just need a simple counter. There's no need for > > us to worry about anything else, like timestamps or whatever.

Re: [PATCH 1/2] tools/include: Update if_link.h and netlink.h

2020-10-16 Thread Jesse Brandeburg
Jakub Kicinski wrote: > On Fri, 16 Oct 2020 14:23:48 -0700 Jesse Brandeburg wrote: > > > These are tested to be the latest as part of the tools/lib/bpf build. > > > > But you didn't mention why you're making these changes, and you're > > removing a lot of comments without explaining why/where t

Re: [PATCH RFC V3 4/9] x86/pks: Preserve the PKRS MSR on context switch

2020-10-16 Thread Ira Weiny
On Fri, Oct 16, 2020 at 01:06:36PM +0200, Peter Zijlstra wrote: > On Fri, Oct 09, 2020 at 12:42:53PM -0700, ira.we...@intel.com wrote: > > > @@ -644,6 +663,8 @@ void __switch_to_xtra(struct task_struct *prev_p, > > struct task_struct *next_p) > > > > if ((tifp ^ tifn) & _TIF_SLD) > >

Re: [PATCH v4 3/3] clk: qcom: lpasscc-sc7180: Re-configure the PLL in case lost

2020-10-16 Thread Stephen Boyd
Quoting Stephen Boyd (2020-10-15 20:16:27) > Quoting Douglas Anderson (2020-10-14 17:13:29) > > From: Taniya Das > > > > In the case where the PLL configuration is lost, then the pm runtime > > resume will reconfigure before usage. > > Taniya, this commit needs a lot more describing than one sen

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-16 Thread Willy Tarreau
On Sat, Oct 17, 2020 at 07:01:31AM +0200, Jann Horn wrote: > Microsoft's documentation > (http://go.microsoft.com/fwlink/?LinkId=260709) says that the VM > Generation ID that we get after a fork "is a 128-bit, > cryptographically random integer value". If multiple people use the > same image, it gu

[PATCH] clk: qcom: gdsc: Keep RETAIN_FF bit set if gdsc is already on

2020-10-16 Thread Stephen Boyd
If the GDSC is enabled out of boot but doesn't have the retain ff bit set we will get confusing results where the registers that are powered by the GDSC lose their contents on the first power off of the GDSC but thereafter they retain their contents. This is because gdsc_init() fails to make sure t

Re: [PATCH RFC V3 4/9] x86/pks: Preserve the PKRS MSR on context switch

2020-10-16 Thread Ira Weiny
On Fri, Oct 16, 2020 at 01:12:26PM +0200, Peter Zijlstra wrote: > On Tue, Oct 13, 2020 at 11:31:45AM -0700, Dave Hansen wrote: > > > +/** > > > + * It should also be noted that the underlying WRMSR(MSR_IA32_PKRS) is > > > not > > > + * serializing but still maintains ordering properties similar to

[PATCH] nds32: Fix a broken copyright header in gen_vdso_offsets.sh

2020-10-16 Thread Palmer Dabbelt
From: Palmer Dabbelt I was going to copy this but I didn't want to chase around the build system stuff so I did it a different way. Signed-off-by: Palmer Dabbelt --- arch/nds32/kernel/vdso/gen_vdso_offsets.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/nds32/kernel

Re: [PATCH RFC V3 2/9] x86/fpu: Refactor arch_set_user_pkey_access() for PKS support

2020-10-16 Thread Ira Weiny
On Fri, Oct 16, 2020 at 12:57:43PM +0200, Peter Zijlstra wrote: > On Fri, Oct 09, 2020 at 12:42:51PM -0700, ira.we...@intel.com wrote: > > From: Fenghua Yu > > > > Define a helper, update_pkey_val(), which will be used to support both > > Protection Key User (PKU) and the new Protection Key for S

Re: [PATCH net-next 1/3] net: dsa: don't pass cloned skb's to drivers xmit function

2020-10-16 Thread Vladimir Oltean
On Fri, Oct 16, 2020 at 10:02:24PM +0200, Christian Eggers wrote: > Ensure that the skb is not cloned and has enough tail room for the tail > tag. This code will be removed from the drivers in the next commits. > > Signed-off-by: Christian Eggers > --- Does 1588 work for you using this change, o

Re: [PATCH 3/5] gpio: msc313: MStar MSC313 GPIO driver

2020-10-16 Thread Daniel Palmer
Hi Linus On Sat, 17 Oct 2020 at 01:56, Linus Walleij wrote: > (...) > > > +config GPIO_MSC313 > > + bool "MStar MSC313 GPIO support" > > + default y if ARCH_MSTARV7 > > + depends on ARCH_MSTARV7 > > + select GPIO_GENERIC > > Selecting GPIO_GENERIC, that is good. > But you'

[PATCH] arm64: Fix a broken copyright header in gen_vdso_offsets.sh

2020-10-16 Thread Palmer Dabbelt
From: Palmer Dabbelt I was going to copy this but I didn't want to chase around the build system stuff so I did it a different way. Signed-off-by: Palmer Dabbelt --- arch/arm64/kernel/vdso/gen_vdso_offsets.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel

Re: [PATCH v2] HID: i2c-hid: add polling mode based on connected GPIO chip's pin status

2020-10-16 Thread Coiby Xu
Hi, Thank you for examine this patch in such a careful way! On Fri, Oct 16, 2020 at 03:00:49PM +, Barnabás Pőcze wrote: Hi, I still think that `i2c_hid_resume()` and `i2c_hid_suspend()` are asymmetric and that might lead to issues. Do you think this commit message is relevant to your co

Re: fw_devlink on will break all snps,dw-apb-gpio users

2020-10-16 Thread Saravana Kannan
On Thu, Oct 15, 2020 at 8:39 PM Jisheng Zhang wrote: > > On Thu, 15 Oct 2020 15:08:33 +0100 > Robin Murphy wrote: > > > > > > > On 2020-10-15 10:52, Jisheng Zhang wrote: > > > On Thu, 15 Oct 2020 01:48:13 -0700 > > > Saravana Kannan wrote: > > > > > >> On Thu, Oct 15, 2020 at 1:15 AM Jisheng Zha

Re: [EXT] Re: [PATCH v4 10/13] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu()

2020-10-16 Thread Alex Belits
On Tue, 2020-10-06 at 23:41 +0200, Frederic Weisbecker wrote: > On Sun, Oct 04, 2020 at 03:22:09PM +, Alex Belits wrote: > > On Thu, 2020-10-01 at 16:44 +0200, Frederic Weisbecker wrote: > > > > @@ -268,7 +269,8 @@ static void tick_nohz_full_kick(void) > > > > */ > > > > void tick_nohz_full

[rcu:master] BUILD SUCCESS 78b9b11ec17709681e5fc7b50287354f9b0f7728

2020-10-16 Thread kernel test robot
onfig i386defconfig mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a005-202

Re: [PATCH v9 12/15] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR

2020-10-16 Thread Kuppuswamy, Sathyanarayanan
On 10/16/20 3:29 PM, Bjorn Helgaas wrote: [+cc Christoph, Ethan, Sinan, Keith; sorry should have cc'd you to begin with since you're looking at this code too. Particularly interested in your thoughts about whether we should be touching PCI_ERR_ROOT_COMMAND and PCI_ERR_ROOT_STATUS when we don't

[PATCH v3] checkpatch: add new exception to repeated word check

2020-10-16 Thread Dwaipayan Ray
Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test") moved the repeated word test to check for more file types. But after this, if checkpatch.pl is run on MAINTAINERS, it generates several new warnings of the type: WARNING: Possible repeated word: 'git' For example: WARNING: Poss

[PATCH v5 0/4] Qualcomm Light Pulse Generator

2020-10-16 Thread Bjorn Andersson
This series introduces a generic pattern interface in the LED class and a driver for the Qualcomm Light Pulse Generator. It seems like it's been almost 3 years since I posted v3, which was hung up on the lack of conclusion on the hw_pattern and multicolor support. Now that those are concluded I ho

[PATCH net-next] drivers/net/wan/hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-10-16 Thread Xie He
1. Change the fr_rx function to make this driver support any Ethertype when receiving. (This driver is already able to handle any Ethertype when sending.) Originally in the fr_rx function, the code that parses the long (10-byte) header only recognizes a few Ethertype values and drops frames with o

[PATCH v5 3/4] arm64: dts: qcom: pm(i)8994: Add mpp and lpg blocks

2020-10-16 Thread Bjorn Andersson
The pm8994 contains a 6 LPG channels and the pmi8994 contains 4 MPP channels and a 4 channel LPG, with TRILED and LUT blocks. Add nodes for these blocks. Signed-off-by: Bjorn Andersson --- Changes since v4: - Replaced msm8996 with pm(i)8994 in subject arch/arm64/boot/dts/qcom/pm8994.dtsi |

[PATCH v5 4/4] arm64: dts: qcom: Add user LEDs on db820c

2020-10-16 Thread Bjorn Andersson
The db820c has 4 "user LEDs", all connected to the PMI8994. The first three are connected to the three current sinks provided by the TRILED and the fourth is connected to MPP2. By utilizing the DTEST bus the MPP is fed the control signal from the fourth LPG block, providing a consistent interface

Re: [PATCH v2] checkpatch: add new exception to repeated word check

2020-10-16 Thread Dwaipayan Ray
On Sat, Oct 17, 2020 at 10:12 AM Joe Perches wrote: > > On Sat, 2020-10-17 at 10:02 +0530, Dwaipayan Ray wrote: > > On Sat, Oct 17, 2020 at 8:26 AM Joe Perches wrote: > > > On Wed, 2020-10-14 at 11:35 -0700, Joe Perches wrote: > > > > On Wed, 2020-10-14 at 23:42 +0530, Dwaipayan Ray wrote: > > >

[PATCH v5 1/4] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding

2020-10-16 Thread Bjorn Andersson
This adds the binding document describing the three hardware blocks related to the Light Pulse Generator found in a wide range of Qualcomm PMICs. Signed-off-by: Bjorn Andersson --- Changes since v4: - Dropped quotes around power-source - Moved "multi-led" to properties - Corrected tab-indented l

[PATCH v5 2/4] leds: Add driver for Qualcomm LPG

2020-10-16 Thread Bjorn Andersson
The Light Pulse Generator (LPG) is a PWM-block found in a wide range of PMICs from Qualcomm. It can operate on fixed parameters or based on a lookup-table, altering the duty cycle over time - which provides the means for e.g. hardware assisted transitions of LED brightness. Signed-off-by: Bjorn An

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-16 Thread Colm MacCarthaigh
On 16 Oct 2020, at 22:01, Jann Horn wrote: On Sat, Oct 17, 2020 at 6:34 AM Colm MacCarthaigh wrote: For user-space, even a single bit would do. We added MADVISE_WIPEONFORK so that userspace libraries can detect fork()/clone() robustly, for the same reasons. It just wipes a page as the in

[PATCH] ipmi_si: replace spin_lock_irqsave by spin_lock in hard IRQ

2020-10-16 Thread Tian Tao
It is redundant to do irqsave and irqrestore in hardIRQ context. Signed-off-by: Tian Tao --- drivers/char/ipmi/ipmi_si_intf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index 45546ac..97452a8 100644

Re: [PATCH v6 07/25] treewide: remove DISABLE_LTO

2020-10-16 Thread Masahiro Yamada
On Thu, Oct 15, 2020 at 7:43 AM Kees Cook wrote: > > On Mon, Oct 12, 2020 at 05:31:45PM -0700, Sami Tolvanen wrote: > > This change removes all instances of DISABLE_LTO from > > Makefiles, as they are currently unused, and the preferred > > method of disabling LTO is to filter out the flags instea

Re: [PATCH 3/3] MIPS: Loongson64: Add /proc/boardinfo

2020-10-16 Thread Tiezhu Yang
On 10/16/2020 09:11 PM, Pavel Machek wrote: Hi! Add /proc/boardinfo to get mainboard and BIOS info easily on the Loongson platform, this is useful to point out the current used mainboard type and BIOS version when there exists problems related with hardware or firmware. E.g. with this patch:

Re: [PATCH v9 09/10] fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile

2020-10-16 Thread kernel test robot
Hi Konstantin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.9 next-20201016] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-16 Thread Willy Tarreau
On Sat, Oct 17, 2020 at 03:40:08AM +0200, Jann Horn wrote: > [adding some more people who are interested in RNG stuff: Andy, Jason, > Theodore, Willy Tarreau, Eric Biggers. also linux-api@, because this > concerns some pretty fundamental API stuff related to RNG usage] > > On Fri, Oct 16, 2020 at

  1   2   3   4   5   6   7   8   9   10   >