Re: [PATCH v3 3/6] modpost: Make mod_device_table aliases more unique

2025-06-05 Thread Masahiro Yamada
On Tue, Jun 3, 2025 at 3:44 AM Alexey Gladkov wrote: > > On Tue, Jun 03, 2025 at 03:00:07AM +0900, Masahiro Yamada wrote: > > On Mon, Jun 2, 2025 at 5:24 PM Alexey Gladkov wrote: > > > > > > On Mon, Jun 02, 2025 at 04:52:36PM +0900, Masahiro Yamada wrote: > > > > On Tue, May 27, 2025 at 6:08 PM A

Re: [PATCH v3 3/6] modpost: Make mod_device_table aliases more unique

2025-06-05 Thread Masahiro Yamada
On Wed, Jun 4, 2025 at 8:26 PM Alexey Gladkov wrote: > > On Tue, Jun 03, 2025 at 01:18:25AM +0900, Masahiro Yamada wrote: > > > > > Before these patches this was not a problem as non-unique characters > > > > > are > > > > > in separate object files when the module is compiled separately. > > > >

Re: [PATCH v4 5/7] cxl/region: Introduce SOFT RESERVED resource removal on region teardown

2025-06-05 Thread Zhijian Li (Fujitsu)
The term "region teardown" in the subject line appears inaccurate. As I understand, cxl_region_softreserv_update() should work only when the region is ready, but the current logic only guarantees that the *memdev* is ready. Is there truly no timing gap between region readiness and memdev readi

Re: [PATCH v2 45/62] x86/extable: Define ELF section entry size for exception tables

2025-06-05 Thread Brian Gerst
On Fri, May 9, 2025 at 4:51 PM Josh Poimboeuf wrote: > > In preparation for the objtool klp diff subcommand, define the entry > size for the __ex_table section in its ELF header. This will allow > tooling to extract individual entries. > > Signed-off-by: Josh Poimboeuf > --- > arch/x86/include/

Re: [PATCH 1/3] soc: qcom: mdt_loader: Ensure we don't read past the ELF header

2025-06-05 Thread Dmitry Baryshkov
On Thu, Jun 05, 2025 at 02:29:53PM -0500, Bjorn Andersson wrote: > On Thu, Jun 05, 2025 at 06:57:41PM +0300, Dmitry Baryshkov wrote: > > On Thu, Jun 05, 2025 at 08:43:00AM -0500, Bjorn Andersson wrote: > > > When the MDT loader is used in remoteproc, the ELF header is sanitized > > > beforehand, bu

[PATCH v2 3/3] remoteproc: imx_rproc: Add support for i.MX95

2025-06-05 Thread Peng Fan (OSS)
From: Peng Fan Add imx_rproc_cfg_imx95_m7 and address(TCM and DDR) mapping Add i.MX95 of_device_id entry Reviewed-by: Daniel Baluta Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/remoteproc/imx_rproc.

Re: [PATCH] dt-bindings: pmem: Convert binding to YAML

2025-06-05 Thread Oliver O'Halloran
On Wed, May 21, 2025 at 7:08 AM Drew Fustini wrote: > > On Tue, May 20, 2025 at 04:51:42PM +0100, Conor Dooley wrote: > > On Mon, May 19, 2025 at 07:22:21PM -0700, Drew Fustini wrote: > > > On Mon, May 19, 2025 at 07:14:40PM -0700, Drew Fustini wrote: > > > > Convert the PMEM device tree binding f

[PATCH v2 2/3] remoteproc: imx_rproc: Add support for System Manager API

2025-06-05 Thread Peng Fan (OSS)
From: Peng Fan i.MX95 features a Cortex-M33 core, six Cortex-A55 cores, and one Cortex-M7 core. The System Control Management Interface(SCMI) firmware runs on the M33 core. The i.MX95 SCMI firmware named System Manager(SM) includes vendor extension protocols, Logical Machine Management(LMM) proto

[PATCH v2 1/3] dt-bindings: remoteproc: fsl,imx-rproc: Add support for i.MX95

2025-06-05 Thread Peng Fan (OSS)
From: Peng Fan i.MX95 has a System Manager(SM) core runs the System Control Management Interface(SCMI) firmware. Vendor extenions are implemented in the firmware, Logical Machine Management(LMM) protocol to manage Logical Machines and CPU protocol to manage cores. The documentation could be found

[PATCH v2 0/3] remoteproc: imx_rproc: Support i.MX95

2025-06-05 Thread Peng Fan (OSS)
i.MX95 features a Cortex-M33 core, six Cortex-A55 cores, and one Cortex-M7 core. The System Control Management Interface(SCMI) firmware runs on the M33 core. The i.MX95 SCMI firmware named System Manager(SM) includes vendor extension protocols, Logical Machine Management(LMM) protocol and CPU proto

Re: [PATCH] selftests/mm: Skip failed memfd setups in gup_longterm

2025-06-05 Thread Andrew Morton
to avoid hitting failures when hugetlb isn't configured. Link: https://lkml.kernel.org/r/20250605-selftest-mm-gup-longterm-tweaks-v1-1-2fae34b05...@kernel.org Fies: 66bce7afbaca ("selftests/mm: fix test result reporting in gup_longterm") Signed-off-by: Mark Brown Repo

Re: RCU changes for v6.16

2025-06-05 Thread Z qiang
> > Hi Linus, > > When the merge window opens, please pull the RCU changes for v6.16: > > The following changes since commit 0af2f6be1b4281385b618cb86ad946eded089ac8: > > Linux 6.15-rc1 (2025-04-06 13:11:33 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linu

Re: [PATCH v2 49/62] kbuild,objtool: Defer objtool validation step for CONFIG_LIVEPATCH

2025-06-05 Thread Josh Poimboeuf
On Wed, May 28, 2025 at 10:45:22AM -0400, Joe Lawrence wrote: > > - if is_enabled CONFIG_LTO_CLANG || is_enabled CONFIG_X86_KERNEL_IBT; then > > + if is_enabled CONFIG_LTO_CLANG || is_enabled CONFIG_X86_KERNEL_IBT || > > + is_enabled CONFIG_LIVEPATCH; then > > # Use vmlinux.o i

Re: [PATCH v1 0/2] mm/huge_memory: don't mark refcounted pages special in vmf_insert_folio_*()

2025-06-05 Thread Dan Williams
David Hildenbrand wrote: > Based on Linus' master. > > While working on improving vm_normal_page() and friends, I stumbled > over this issues: refcounted "normal" pages must not be marked > using pmd_special() / pud_special(). > > Fortunately, so far there doesn't seem to be serious damage. > >

[PATCH v2] remoteproc: qcom: pas: Conclude the rename from adsp

2025-06-05 Thread Bjorn Andersson
s of qcom_q6v5_adsp.c - Fixed ADSP-prefixed define - Ensured qcom_ prefix in a few comments, and rewrote two to be more succinct - Fixed spelling of peripheral and reworded Kconfig help text slightly. - Link to v1: https://lore.kernel.org/r/20250605-pas-rename-v1-1-900b770d6...@oss.qualcomm

Re: [PATCH v2 45/62] x86/extable: Define ELF section entry size for exception tables

2025-06-05 Thread Josh Poimboeuf
On Wed, May 28, 2025 at 10:40:55AM -0400, Joe Lawrence wrote: > On 5/9/25 4:17 PM, Josh Poimboeuf wrote: > > In preparation for the objtool klp diff subcommand, define the entry > > size for the __ex_table section in its ELF header. This will allow > > tooling to extract individual entries. > > >

Re: [PATCH v2 52/62] objtool/klp: Introduce klp diff subcommand for diffing object files

2025-06-05 Thread Josh Poimboeuf
On Mon, May 26, 2025 at 08:57:16PM +0200, Peter Zijlstra wrote: > > @@ -50,10 +51,12 @@ struct section { > > bool _changed, text, rodata, noinstr, init, truncate; > > struct reloc *relocs; > > unsigned long nr_alloc_relocs; > > + struct section *twin; > > }; > > > > struct symbol

Re: [PATCH v4 0/2] x86/fred: Prevent single-step upon ERETU completion

2025-06-05 Thread Sohil Mehta
On 6/5/2025 12:32 PM, Sohil Mehta wrote: > On 6/5/2025 11:10 AM, Xin Li (Intel) wrote: > >> >> Xin Li (Intel) (2): >> x86/fred/signal: Prevent single-step upon ERETU completion >> selftests/x86: Add a test to detect infinite sigtrap handler loop >> > > I tested the patches on a machine that s

[PATCH] selftests/mm: Skip failed memfd setups in gup_longterm

2025-06-05 Thread Mark Brown
Unlike the other cases gup_longterm's memfd tests previously skipped the test when failing to set up the file descriptor to test, restore this behaviour. Signed-off-by: Mark Brown --- tools/testing/selftests/mm/gup_longterm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --gi

Re: [PATCH v2 52/62] objtool/klp: Introduce klp diff subcommand for diffing object files

2025-06-05 Thread Josh Poimboeuf
On Mon, May 26, 2025 at 08:50:40PM +0200, Peter Zijlstra wrote: > > Let me hand you a fresh bucket of curlies, you must've run out :-) Thanks for the freebies, imported curlies aren't so cheap these days! -- Josh

Re: [PATCH bpf-next] selftests/bpf: rbtree: Fix incorrect global variable usage

2025-06-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov : On Thu, 5 Jun 2025 16:45:14 +0800 you wrote: > From: Rong Tao > > Within __add_three() function, should use function parameters instead of > global variables. So that the variables groot_nested.inner.root and >

Re: [PATCH v3 1/2] libbpf: add support for printing BTF character arrays as strings

2025-06-05 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (master) by Andrii Nakryiko : On Tue, 3 Jun 2025 13:37:00 -0700 you wrote: > The BTF dumper code currently displays arrays of characters as just that - > arrays, with each character formatted individually. Sometimes this is what > makes sense, b

Re: [PATCH v3 2/2] Tests for the ".emit_strings" functionality in the BTF dumper.

2025-06-05 Thread Andrii Nakryiko
On Tue, Jun 3, 2025 at 1:37 PM Blake Jones wrote: > > When this mode is turned on, "emit_zeroes" and "compact" have no effect, > and embedded NUL characters always terminate printing of an array. > > Signed-off-by: Blake Jones > --- > .../selftests/bpf/prog_tests/btf_dump.c | 118 +

Re: [PATCH] remoteproc: qcom: pas: Conclude the rename from adsp

2025-06-05 Thread Bjorn Andersson
On Thu, Jun 05, 2025 at 03:27:19PM -0500, Bjorn Andersson wrote: > On Thu, Jun 05, 2025 at 06:01:07PM +0200, Luca Weiss wrote: > > Hi Bjorn, > > > > Awesome to see this being cleaned up! > > > > On 05-06-2025 5:23 p.m., Bjorn Andersson wrote: > > > The change that renamed the driver from "adsp" t

Re: [PATCH] remoteproc: qcom: pas: Conclude the rename from adsp

2025-06-05 Thread Bjorn Andersson
On Thu, Jun 05, 2025 at 09:37:42PM +0530, Wasim Nazir wrote: > On Thu, Jun 05, 2025 at 10:23:51AM -0500, Bjorn Andersson wrote: > > The change that renamed the driver from "adsp" to "pas" didn't change > > any of the implementation. The result is an aesthetic eyesore, and > > confusing to many. > >

Re: [PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-05 Thread David Hildenbrand
On 05.06.25 21:19, Jann Horn wrote: On Wed, Jun 4, 2025 at 4:21 PM Lorenzo Stoakes wrote: The walk_page_range_novma() function is rather confusing - it supports two modes, one used often, the other used only for debugging. The first mode is the common case of traversal of kernel page tables, w

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread Andrew Morton
On Thu, 5 Jun 2025 18:48:49 +0200 David Hildenbrand wrote: > On 05.06.25 18:15, Mark Brown wrote: > > On Thu, Jun 05, 2025 at 05:00:49PM +0100, Lorenzo Stoakes wrote: > > > >> This seems to be causing tests to fail rather than be skipped if hugetlb > >> isn't configured. I bisected the problem t

Re: [PATCH] remoteproc: qcom: pas: Conclude the rename from adsp

2025-06-05 Thread Bjorn Andersson
On Thu, Jun 05, 2025 at 06:01:07PM +0200, Luca Weiss wrote: > Hi Bjorn, > > Awesome to see this being cleaned up! > > On 05-06-2025 5:23 p.m., Bjorn Andersson wrote: > > The change that renamed the driver from "adsp" to "pas" didn't change > > any of the implementation. The result is an aesthetic

Re: [PATCH] module: make __mod_device_table__* symbols static

2025-06-05 Thread Masahiro Yamada
On Wed, Jun 4, 2025 at 5:50 PM Petr Pavlu wrote: > > On 6/2/25 12:55 PM, Masahiro Yamada wrote: > > The __mod_device_table__* symbols are only parsed by modpost to generate > > MODULE_ALIAS() entries from MODULE_DEVICE_TABLE(). > > > > Therefore, these symbols do not need to be globally visible, o

Re: [PATCH v2 52/62] objtool/klp: Introduce klp diff subcommand for diffing object files

2025-06-05 Thread Josh Poimboeuf
On Mon, May 26, 2025 at 08:47:00PM +0200, Peter Zijlstra wrote: > On Fri, May 09, 2025 at 01:17:16PM -0700, Josh Poimboeuf wrote: > > +#define SEC_NAME_LEN 512 > > #define SYM_NAME_LEN 512 > > > > > +static int validate_ffunction_fdata_sections(struct elf *elf) > > +

Re: [PATCH v4 0/2] x86/fred: Prevent single-step upon ERETU completion

2025-06-05 Thread Sohil Mehta
On 6/5/2025 11:10 AM, Xin Li (Intel) wrote: > > Xin Li (Intel) (2): > x86/fred/signal: Prevent single-step upon ERETU completion > selftests/x86: Add a test to detect infinite sigtrap handler loop > I tested the patches on a machine that supports FRED. The results are as expected: FRED on

Re: [PATCH 1/3] soc: qcom: mdt_loader: Ensure we don't read past the ELF header

2025-06-05 Thread Bjorn Andersson
On Thu, Jun 05, 2025 at 06:57:41PM +0300, Dmitry Baryshkov wrote: > On Thu, Jun 05, 2025 at 08:43:00AM -0500, Bjorn Andersson wrote: > > When the MDT loader is used in remoteproc, the ELF header is sanitized > > beforehand, but that's not necessary the case for other clients. > > > > Validate the

Re: [PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-05 Thread Jann Horn
On Wed, Jun 4, 2025 at 4:21 PM Lorenzo Stoakes wrote: > The walk_page_range_novma() function is rather confusing - it supports two > modes, one used often, the other used only for debugging. > > The first mode is the common case of traversal of kernel page tables, which > is what nearly all caller

Re: [QUESTION] problems report: rcu_read_unlock_special() called in irq_exit() causes dead loop

2025-06-05 Thread Joel Fernandes
On 6/4/2025 8:26 AM, Paul E. McKenney wrote: >>> Or just don't send subsequent self-IPIs if we just sent one for the >>> rdp. Chances are, if we did not get the scheduler's attention during >>> the first one, we may not in subsequent ones I think. Plus we do send >>> other IPIs a

Re: [PATCH v4 1/2] x86/fred/signal: Prevent single-step upon ERETU completion

2025-06-05 Thread H. Peter Anvin
On June 5, 2025 11:10:19 AM PDT, "Xin Li (Intel)" wrote: >Clear the software event flag in the augmented SS to prevent infinite >SIGTRAP handler loop if the trap flag (TF) is set without an external >debugger attached. > >Following is a typical single-stepping flow for a user process: > >1) The us

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread Mark Brown
On Thu, Jun 05, 2025 at 07:34:28PM +0200, David Hildenbrand wrote: > On 05.06.25 19:19, Mark Brown wrote: > > TBH this has been a lot better than the more common failure mode with > > working on selftests where people just completely ignore or are openly > > dismissive about them :/ . Probably ro

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread Lorenzo Stoakes
On Thu, Jun 05, 2025 at 07:29:58PM +0100, Mark Brown wrote: > On Thu, Jun 05, 2025 at 06:47:28PM +0100, Lorenzo Stoakes wrote: > > > Mark, I'm not finding this productive. > > > Bottom line is you've broken the tests, please fix them or if you're not > > willing to I'll send a fix. > > Sure, like I

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread Mark Brown
On Thu, Jun 05, 2025 at 06:47:28PM +0100, Lorenzo Stoakes wrote: > Mark, I'm not finding this productive. > Bottom line is you've broken the tests, please fix them or if you're not > willing to I'll send a fix. Sure, like I said further up I'm just running my patch through testing at the minute.

[PATCH v4 2/2] selftests/x86: Add a test to detect infinite sigtrap handler loop

2025-06-05 Thread Xin Li (Intel)
When FRED is enabled, if the Trap Flag (TF) is set without an external debugger attached, it can lead to an infinite loop in the SIGTRAP handler. To avoid this, the software event flag in the augmented SS must be cleared, ensuring that no single-step trap remains pending when ERETU completes. Thi

[PATCH v4 1/2] x86/fred/signal: Prevent single-step upon ERETU completion

2025-06-05 Thread Xin Li (Intel)
Clear the software event flag in the augmented SS to prevent infinite SIGTRAP handler loop if the trap flag (TF) is set without an external debugger attached. Following is a typical single-stepping flow for a user process: 1) The user process is prepared for single-stepping by setting RFLAGS.T

[PATCH v4 0/2] x86/fred: Prevent single-step upon ERETU completion

2025-06-05 Thread Xin Li (Intel)
IDT event delivery has a debug hole in which it does not generate #DB upon returning to userspace before the first userspace instruction is executed if the Trap Flag (TF) is set. FRED closes this hole by introducing a software event flag, i.e., bit 17 of the augmented SS: if the bit is set and ERE

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread Lorenzo Stoakes
Mark, I'm not finding this productive. Bottom line is you've broken the tests, please fix them or if you're not willing to I'll send a fix. Thanks. On Thu, Jun 05, 2025 at 06:38:36PM +0100, Mark Brown wrote: > On Thu, Jun 05, 2025 at 06:09:09PM +0100, Lorenzo Stoakes wrote: > > On Thu, Jun 05, 2

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread Mark Brown
On Thu, Jun 05, 2025 at 06:09:09PM +0100, Lorenzo Stoakes wrote: > On Thu, Jun 05, 2025 at 05:42:55PM +0100, Mark Brown wrote: > > > Better to do all of these formating fixes and maintain the _same > > > behaviour_ then > > > separately tackle whether or not we should skip. > > I'm confused, tha

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread David Hildenbrand
On 05.06.25 19:19, Mark Brown wrote: On Thu, Jun 05, 2025 at 06:55:53PM +0200, David Hildenbrand wrote: On 05.06.25 18:42, Mark Brown wrote: I can't remember off hand, sorry. I assume in ... my review to patch #4? Oh, yeah - it's there. I did look there but the "not a fan" bit made me t

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread Mark Brown
On Thu, Jun 05, 2025 at 06:55:53PM +0200, David Hildenbrand wrote: > On 05.06.25 18:42, Mark Brown wrote: > > I can't remember off hand, sorry. > I assume in ... my review to patch #4? Oh, yeah - it's there. I did look there but the "not a fan" bit made me think it was one of the stylistic thin

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread Lorenzo Stoakes
On Thu, Jun 05, 2025 at 05:42:55PM +0100, Mark Brown wrote: > On Thu, Jun 05, 2025 at 05:26:05PM +0100, Lorenzo Stoakes wrote: > > On Thu, Jun 05, 2025 at 05:15:51PM +0100, Mark Brown wrote: > > > > That's the thing with memfd being special and skipping on setup failure > > > that David mentioned,

Re: [PATCH bpf-next] selftests/bpf: Fix compile error of bin_attribute::read/write()

2025-06-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov : On Wed, 4 Jun 2025 13:53:22 +0800 you wrote: > From: Rong Tao > > Since commit 97d06802d10a ("sysfs: constify bin_attribute argument of > bin_attribute::read/write()"), make bin_attribute parameter of > bin_attr

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread David Hildenbrand
On 05.06.25 18:42, Mark Brown wrote: On Thu, Jun 05, 2025 at 05:26:05PM +0100, Lorenzo Stoakes wrote: On Thu, Jun 05, 2025 at 05:15:51PM +0100, Mark Brown wrote: That's the thing with memfd being special and skipping on setup failure that David mentioned, I've got a patch as part of the forma

Re: [PATCH v4 6/7] dax/hmem: Save the DAX HMEM platform device pointer

2025-06-05 Thread Dave Jiang
On 6/3/25 3:19 PM, Smita Koralahalli wrote: > From: Nathan Fontenot > > To enable registration of HMEM devices for SOFT RESERVED regions after > the DAX HMEM device is initialized, this patch saves a reference to the > DAX HMEM platform device. > > This saved pointer will be used in a follow-

Re: [PATCH v2] module: Make sure relocations are applied to the per-CPU section

2025-06-05 Thread Petr Pavlu
On 6/5/25 5:54 PM, Sebastian Andrzej Siewior wrote: > On 2025-06-05 15:44:23 [+0200], Petr Pavlu wrote: >> Isn't this broken earlier by "Don't relocate non-allocated regions in >> modules." >> (pre-Git, [1])? > > Looking further back into the history, we have > 21af2f0289dea ("[PATCH] per-c

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread David Hildenbrand
On 05.06.25 18:15, Mark Brown wrote: On Thu, Jun 05, 2025 at 05:00:49PM +0100, Lorenzo Stoakes wrote: This seems to be causing tests to fail rather than be skipped if hugetlb isn't configured. I bisected the problem to this patch so it's definitely changed how things are handled (though of cour

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread Mark Brown
On Thu, Jun 05, 2025 at 05:26:05PM +0100, Lorenzo Stoakes wrote: > On Thu, Jun 05, 2025 at 05:15:51PM +0100, Mark Brown wrote: > > That's the thing with memfd being special and skipping on setup failure > > that David mentioned, I've got a patch as part of the formatting series > > I was going to

Re: [PATCH v2 32/62] objtool: Suppress section skipping warnings with --dryrun

2025-06-05 Thread Josh Poimboeuf
On Thu, Jun 05, 2025 at 04:52:24PM +0200, Peter Zijlstra wrote: > On Thu, Jun 05, 2025 at 09:32:46AM +0200, Peter Zijlstra wrote: > > > > But also, feel free to resurrect --backup, or you can yell at me to do > > > it as the backup code changed a bit. > > > > I have the patch somewhere, failed to

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread Lorenzo Stoakes
On Thu, Jun 05, 2025 at 05:15:51PM +0100, Mark Brown wrote: > On Thu, Jun 05, 2025 at 05:00:49PM +0100, Lorenzo Stoakes wrote: > > > This seems to be causing tests to fail rather than be skipped if hugetlb > > isn't configured. I bisected the problem to this patch so it's definitely > > changed how

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread Mark Brown
On Thu, Jun 05, 2025 at 05:00:49PM +0100, Lorenzo Stoakes wrote: > This seems to be causing tests to fail rather than be skipped if hugetlb > isn't configured. I bisected the problem to this patch so it's definitely > changed how things are handled (though of course it might just be > _revealing_

Re: [PATCH] remoteproc: qcom: pas: Conclude the rename from adsp

2025-06-05 Thread Luca Weiss
Hi Bjorn, Awesome to see this being cleaned up! On 05-06-2025 5:23 p.m., Bjorn Andersson wrote: The change that renamed the driver from "adsp" to "pas" didn't change any of the implementation. The result is an aesthetic eyesore, and confusing to many. Conclude the rename of the driver, by upda

Re: [Question] attributes encoding in BTF

2025-06-05 Thread Alexei Starovoitov
On Thu, Jun 5, 2025 at 12:35 AM Alexis Lothoré wrote: > > Hi Ihor, > > On Wed Jun 4, 2025 at 7:31 PM CEST, Ihor Solodrai wrote: > > On 6/4/25 2:02 AM, Alexis Lothoré wrote: > > [...] > > >> Could I be missing something obvious ? Or did I misunderstand the actual > >> attribute encoding feature ?

Re: [PATCH] remoteproc: qcom: pas: Conclude the rename from adsp

2025-06-05 Thread Wasim Nazir
On Thu, Jun 05, 2025 at 10:23:51AM -0500, Bjorn Andersson wrote: > The change that renamed the driver from "adsp" to "pas" didn't change > any of the implementation. The result is an aesthetic eyesore, and > confusing to many. > > Conclude the rename of the driver, by updating function, structures

Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm

2025-06-05 Thread Lorenzo Stoakes
This seems to be causing tests to fail rather than be skipped if hugetlb isn't configured. I bisected the problem to this patch so it's definitely changed how things are handled (though of course it might just be _revealing_ some previously existing bug in this test...). Using a couple of tests as

Re: [PATCH 3/3] soc: qcom: mdt_loader: Actually use the e_phoff

2025-06-05 Thread Dmitry Baryshkov
On Thu, Jun 05, 2025 at 08:43:02AM -0500, Bjorn Andersson wrote: > Rather than relying/assuming that the tools generating the firmware > places the program headers immediately following the ELF header, use > e_phoff as intended to find the program headers. > > Signed-off-by: Bjorn Andersson > ---

Re: [PATCH 2/3] soc: qcom: mdt_loader: Rename mdt_phdr_valid()

2025-06-05 Thread Dmitry Baryshkov
On Thu, Jun 05, 2025 at 08:43:01AM -0500, Bjorn Andersson wrote: > The function checks if a program header refers to a PT_LOAD segment, > that isn't a hash segment (which should be PT_LOAD in the first place), > andwith non-zero size. That's not the definition of "valid", but rather > if it's "load

Re: [PATCH 1/3] soc: qcom: mdt_loader: Ensure we don't read past the ELF header

2025-06-05 Thread Dmitry Baryshkov
On Thu, Jun 05, 2025 at 08:43:00AM -0500, Bjorn Andersson wrote: > When the MDT loader is used in remoteproc, the ELF header is sanitized > beforehand, but that's not necessary the case for other clients. > > Validate the size of the firmware buffer to ensure that we don't read > past the end as w

Re: [PATCH v2] module: Make sure relocations are applied to the per-CPU section

2025-06-05 Thread Sebastian Andrzej Siewior
On 2025-06-05 15:44:23 [+0200], Petr Pavlu wrote: > Isn't this broken earlier by "Don't relocate non-allocated regions in > modules." > (pre-Git, [1])? Looking further back into the history, we have 21af2f0289dea ("[PATCH] per-cpu support inside modules (minimal)") which does + if

[PATCH] remoteproc: qcom: pas: Conclude the rename from adsp

2025-06-05 Thread Bjorn Andersson
The change that renamed the driver from "adsp" to "pas" didn't change any of the implementation. The result is an aesthetic eyesore, and confusing to many. Conclude the rename of the driver, by updating function, structures and variable names to match what the driver actually is. The "Hexagon v5"

Re: [PATCH bpf-next v1 1/2] bpf,ktls: Fix data corruption when using bpf_msg_pop_data() in ktls

2025-06-05 Thread John Fastabend
On 2025-06-02 11:04:50, Jiayuan Chen wrote: > 2025/5/30 02:16, "Cong Wang" 写到: > > > > > On Fri, May 23, 2025 at 09:18:58PM +0800, Jiayuan Chen wrote: > > [...] > > > > I am wondering if we need to WARN here? Because the code below this > > > > handles it gracefully: > > > > Hi Cong > >

Re: [PATCH v2 32/62] objtool: Suppress section skipping warnings with --dryrun

2025-06-05 Thread Peter Zijlstra
On Thu, Jun 05, 2025 at 09:32:46AM +0200, Peter Zijlstra wrote: > > But also, feel free to resurrect --backup, or you can yell at me to do > > it as the backup code changed a bit. > > I have the patch somewhere, failed to send it out. I'll try and dig it > out later today. This is what I had. Wa

Re: [PATCH net] virtio-net: drop the multi-buffer XDP packet in zerocopy

2025-06-05 Thread Jakub Kicinski
On Thu, 5 Jun 2025 21:33:26 +0700 Bui Quang Minh wrote: > On 6/5/25 18:03, Paolo Abeni wrote: > > On 6/3/25 5:06 PM, Bui Quang Minh wrote: > >> In virtio-net, we have not yet supported multi-buffer XDP packet in > >> zerocopy mode when there is a binding XDP program. However, in that > >> case, w

Re: [PATCH net] virtio-net: drop the multi-buffer XDP packet in zerocopy

2025-06-05 Thread Bui Quang Minh
On 6/5/25 18:03, Paolo Abeni wrote: On 6/3/25 5:06 PM, Bui Quang Minh wrote: In virtio-net, we have not yet supported multi-buffer XDP packet in zerocopy mode when there is a binding XDP program. However, in that case, when receiving multi-buffer XDP packet, we skip the XDP program and return XD

Re: [PATCH v2] module: Make sure relocations are applied to the per-CPU section

2025-06-05 Thread Peter Zijlstra
On Thu, Jun 05, 2025 at 03:44:23PM +0200, Petr Pavlu wrote: > For instance: > > /* >* Don't bother with non-allocated sections. >* >* An exception is the percpu section, which has separate allocations >* for individual CPUs. We relocate the percpu section in

Re: [PATCH net] virtio-net: drop the multi-buffer XDP packet in zerocopy

2025-06-05 Thread Bui Quang Minh
On 6/4/25 23:55, Zvi Effron wrote: On Tue, Jun 3, 2025 at 8:09 AM Bui Quang Minh wrote: In virtio-net, we have not yet supported multi-buffer XDP packet in zerocopy mode when there is a binding XDP program. However, in that case, when receiving multi-buffer XDP packet, we skip the XDP program a

Re: [PATCH v3] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-05 Thread Vlastimil Babka
On 6/5/25 15:51, Lorenzo Stoakes wrote: > The walk_page_range_novma() function is rather confusing - it supports two > modes, one used often, the other used only for debugging. > > The first mode is the common case of traversal of kernel page tables, which > is what nearly all callers use this for

[PATCH 0/3] (no cover subject)

2025-06-05 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson --- Bjorn Andersson (3): soc: qcom: mdt_loader: Ensure we don't read past the ELF header soc: qcom: mdt_loader: Rename mdt_phdr_valid() soc: qcom: mdt_loader: Actually use the e_phoff drivers/soc/qcom/mdt_loader.c | 57

[PATCH v3] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-05 Thread Lorenzo Stoakes
The walk_page_range_novma() function is rather confusing - it supports two modes, one used often, the other used only for debugging. The first mode is the common case of traversal of kernel page tables, which is what nearly all callers use this for. Secondly it provides an unusual debugging inter

[PATCH 1/3] soc: qcom: mdt_loader: Ensure we don't read past the ELF header

2025-06-05 Thread Bjorn Andersson
When the MDT loader is used in remoteproc, the ELF header is sanitized beforehand, but that's not necessary the case for other clients. Validate the size of the firmware buffer to ensure that we don't read past the end as we iterate over the header. Fixes: 2aad40d911ee ("remoteproc: Move qcom_mdt

Re: [PATCH v2] module: Make sure relocations are applied to the per-CPU section

2025-06-05 Thread Petr Pavlu
On 6/5/25 8:07 AM, Sebastian Andrzej Siewior wrote: > The per-CPU data section is handled differently than the other sections. > The memory allocations requires a special __percpu pointer and then the > section is copied into the view of each CPU. Therefore the SHF_ALLOC > flag is removed to ensure

Re: [PATCH v4 3/3] remoteproc: imx_rproc: detect and attach to pre-booted remote cores

2025-06-05 Thread Hiago De Franco
Hi Peng, On Wed, Jun 04, 2025 at 03:19:52AM +, Peng Fan wrote: > > Subject: [PATCH v4 3/3] remoteproc: imx_rproc: detect and attach to > > pre-booted remote cores > > > > From: Hiago De Franco > > > > When the remote core is started before Linux boots (e.g., by the > > bootloader), the driv

[PATCH 3/3] soc: qcom: mdt_loader: Actually use the e_phoff

2025-06-05 Thread Bjorn Andersson
Rather than relying/assuming that the tools generating the firmware places the program headers immediately following the ELF header, use e_phoff as intended to find the program headers. Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/mdt_loader.c | 10 +- 1 file changed, 5 insertions

[PATCH 2/3] soc: qcom: mdt_loader: Rename mdt_phdr_valid()

2025-06-05 Thread Bjorn Andersson
The function checks if a program header refers to a PT_LOAD segment, that isn't a hash segment (which should be PT_LOAD in the first place), andwith non-zero size. That's not the definition of "valid", but rather if it's "loadable". Rename the function to reflect what it does. Signed-off-by: Bjor

Re: [PATCH v3 0/4] KVM: arm64: selftests: arch_timer_edge_cases fixes

2025-06-05 Thread Marc Zyngier
On Thu, 05 Jun 2025 12:36:09 +0200, Sebastian Ott wrote: > Some small fixes for arch_timer_edge_cases that I stumbled upon > while debugging failures for this selftest on ampere-one. > > Changes since v1: > * determine effective counter width based on suggestions from Marc > Changes since v2: >

selftests/filesystem: clang warning null passed to a callee that requires a non-null argument [-Wnonnull]

2025-06-05 Thread Naresh Kamboju
L, AT_EMPTY_PATH), 0); |^~~~ ## Source * Kernel version: 6.15.0-next-20250605 * Git tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/linux-next.git * Git sha: a0bea9e39035edc56a994630e6048c8a191a99d8 * Toolchain: Debian clang version 21.0.0 (++20250529012636

Re: [PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-05 Thread Muchun Song
> On Jun 5, 2025, at 17:56, Lorenzo Stoakes wrote: > > On Thu, Jun 05, 2025 at 05:42:16PM +0800, Muchun Song wrote: >> >> >>> On Jun 5, 2025, at 17:24, Lorenzo Stoakes >>> wrote: >>> >>> On Thu, Jun 05, 2025 at 08:56:59AM +0200, Vlastimil Babka wrote: On 6/4/25 16:19, Lorenzo Stoakes

Re: [PATCH bpf-next v2 2/2] selftests/bpf: Add test for bpftool access to read-only protected maps

2025-06-05 Thread Quentin Monnet
2025-05-31 02:48 UTC+1000 ~ Slava Imameev > Add selftest cases that validate bpftool's expected behavior when > accessing maps protected from modification via security_bpf_map. > > The test includes a BPF program attached to security_bpf_map with two maps: > - A protected map that only allows rea

Re: [PATCH bpf-next v2 1/2] bpftool: Use appropriate permissions for map access

2025-06-05 Thread Quentin Monnet
2025-05-31 02:48 UTC+1000 ~ Slava Imameev > Modify several functions in tools/bpf/bpftool/common.c to allow > specification of requested access for file descriptors, such as > read-only access. > > Update bpftool to request only read access for maps when write > access is not required. This fixes

Re: [PATCH net] virtio-net: drop the multi-buffer XDP packet in zerocopy

2025-06-05 Thread Paolo Abeni
On 6/3/25 5:06 PM, Bui Quang Minh wrote: > In virtio-net, we have not yet supported multi-buffer XDP packet in > zerocopy mode when there is a binding XDP program. However, in that > case, when receiving multi-buffer XDP packet, we skip the XDP program > and return XDP_PASS. As a result, the packet

Re: [PATCH RFC net-next v2 3/3] vsock/test: Cover more CIDs in transport_uaf test

2025-06-05 Thread Stefano Garzarella
On Wed, Jun 04, 2025 at 09:11:33PM +0200, Michal Luczaj wrote: On 6/4/25 11:37, Stefano Garzarella wrote: On Wed, May 28, 2025 at 10:44:43PM +0200, Michal Luczaj wrote: +static bool test_stream_transport_uaf(int cid) { int sockets[MAX_PORT_RETRIES]; struct sockaddr_vm addr; -

Re: [PATCH RFC net-next v2 2/3] vsock/test: Introduce get_transports()

2025-06-05 Thread Stefano Garzarella
On Wed, Jun 04, 2025 at 09:10:19PM +0200, Michal Luczaj wrote: On 6/4/25 11:07, Stefano Garzarella wrote: On Wed, May 28, 2025 at 10:44:42PM +0200, Michal Luczaj wrote: +static int __get_transports(void) +{ + /* Order must match transports defined in util.h. +* man nm: "d" The sym

[PATCH v3 4/4] KVM: arm64: selftests: arch_timer_edge_cases - determine effective counter width

2025-06-05 Thread Sebastian Ott
arch_timer_edge_cases uses ~0 as the maximum counter value, however there's no architectural guarantee that this is valid. Figure out the effective counter width based on the effective frequency like it's done by the kernel. This also serves as a workaround for AC03_CPU_14 that led to the followi

[PATCH v3 3/4] KVM: arm64: selftests: arch_timer_edge_cases - fix xval init

2025-06-05 Thread Sebastian Ott
arch_timer_edge_cases hits the following assertion in < 10% of the test runs: Test Assertion Failure arm64/arch_timer_edge_cases.c:490: timer_get_cntct(timer) >= DEF_CNT + (timer_get_cntfrq() * (uint64_t)(delta_2_ms) / 1000) pid=17110 tid=17110 errno=4 - Interrupted system call

[PATCH v3 2/4] KVM: arm64: selftests: fix thread migration in arch_timer_edge_cases

2025-06-05 Thread Sebastian Ott
arch_timer_edge_cases tries to migrate itself across host cpus. Before the first test it migrates to cpu 0 by setting up an affinity mask with only bit 0 set. After that it looks for the next possible cpu in the current affinity mask which still has only bit 0 set. So there is no migration at all.

[PATCH v3 0/4] KVM: arm64: selftests: arch_timer_edge_cases fixes

2025-06-05 Thread Sebastian Ott
Some small fixes for arch_timer_edge_cases that I stumbled upon while debugging failures for this selftest on ampere-one. Changes since v1: * determine effective counter width based on suggestions from Marc Changes since v2: * new patch to fix xval initialization I've done tests with this on va

[PATCH v3 1/4] KVM: arm64: selftests: fix help text for arch_timer_edge_cases

2025-06-05 Thread Sebastian Ott
Fix the help text for arch_timer_edge_cases to show the correct option for setting the wait time. Signed-off-by: Sebastian Ott --- tools/testing/selftests/kvm/arm64/arch_timer_edge_cases.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/arm64/arch_

Re: [PATCH RESEND v10 3/3] vhost: Add new UAPI to select kthread mode and KConfig to enable this IOCTL

2025-06-05 Thread Cindy Lu
On Sun, Jun 1, 2025 at 6:49 PM Michael S. Tsirkin wrote: > > On Sat, May 31, 2025 at 05:57:28PM +0800, Cindy Lu wrote: > > This patch introduces a new UAPI that allows the vhost device to select > > in kthread mode. Userspace applications can utilize IOCTL > > VHOST_FORK_FROM_OWNER to select betwe

Re: [PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-05 Thread Lorenzo Stoakes
On Thu, Jun 05, 2025 at 05:42:16PM +0800, Muchun Song wrote: > > > > On Jun 5, 2025, at 17:24, Lorenzo Stoakes > > wrote: > > > > On Thu, Jun 05, 2025 at 08:56:59AM +0200, Vlastimil Babka wrote: > >> On 6/4/25 16:19, Lorenzo Stoakes wrote: > >>> The walk_page_range_novma() function is rather conf

Re: [PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-05 Thread Lorenzo Stoakes
On Thu, Jun 05, 2025 at 09:45:47AM +0200, David Hildenbrand wrote: > On 04.06.25 16:19, Lorenzo Stoakes wrote: > > The walk_page_range_novma() function is rather confusing - it supports two > > modes, one used often, the other used only for debugging. > > > > The first mode is the common case of tr

Re: [PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-05 Thread Muchun Song
> On Jun 5, 2025, at 17:24, Lorenzo Stoakes wrote: > > On Thu, Jun 05, 2025 at 08:56:59AM +0200, Vlastimil Babka wrote: >> On 6/4/25 16:19, Lorenzo Stoakes wrote: >>> The walk_page_range_novma() function is rather confusing - it supports two >>> modes, one used often, the other used only for d

Re: [PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-05 Thread Lorenzo Stoakes
On Thu, Jun 05, 2025 at 08:56:59AM +0200, Vlastimil Babka wrote: > On 6/4/25 16:19, Lorenzo Stoakes wrote: > > The walk_page_range_novma() function is rather confusing - it supports two > > modes, one used often, the other used only for debugging. > > > > The first mode is the common case of traver

[PATCH bpf-next] selftests/bpf: rbtree: Fix incorrect global variable usage

2025-06-05 Thread Rong Tao
From: Rong Tao Within __add_three() function, should use function parameters instead of global variables. So that the variables groot_nested.inner.root and groot_nested.inner.glock in rbtree_add_nodes_nested() are tested correctly. Signed-off-by: Rong Tao --- tools/testing/selftests/bpf/progs/

Re: [PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-05 Thread Vlastimil Babka
On 6/4/25 16:19, Lorenzo Stoakes wrote: > The walk_page_range_novma() function is rather confusing - it supports two > modes, one used often, the other used only for debugging. > > The first mode is the common case of traversal of kernel page tables, which > is what nearly all callers use this for

Re: [Question] attributes encoding in BTF

2025-06-05 Thread Alexis Lothoré
Hi Ihor, On Wed Jun 4, 2025 at 7:31 PM CEST, Ihor Solodrai wrote: > On 6/4/25 2:02 AM, Alexis Lothoré wrote: [...] >> Could I be missing something obvious ? Or did I misunderstand the actual >> attribute encoding feature ? > > Hi Alexis. > > The changes recently landed in pahole and libbpf re a

Re: [PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-05 Thread David Hildenbrand
On 04.06.25 16:19, Lorenzo Stoakes wrote: The walk_page_range_novma() function is rather confusing - it supports two modes, one used often, the other used only for debugging. The first mode is the common case of traversal of kernel page tables, which is what nearly all callers use this for. Sec

  1   2   >