From: Sumit Semwal
Enabling the Display panel for beryllium requires DSI
labibb regulators and panel dts nodes to be added.
It is also required to keep some of the regulators as
always-on.
Signed-off-by: Sumit Semwal
Signed-off-by: Amit Pundir
Reviewed-by: Konrad Dybcio
---
v4: Added
Hi Angelo,
On Thu, 11 Feb 2021 at 00:25, AngeloGioacchino Del Regno
wrote:
>
> Il 10/02/21 09:18, Amit Pundir ha scritto:
> > From: Sumit Semwal
> >
> > Enabling the Display panel for beryllium requires DSI
> > labibb regulators and panel dts nodes to be added.
&
; configuration.
>
> Rather than providing some basic set that works on the MTP and then
> piecemeal patch this up on the various devices, push the configuration
> of these regions out to the individual device dts files.
>
Smoke tested on sdm845-xiaomi-beryllium.
Tested-by: Amit P
On Sun, 14 Mar 2021 at 22:32, Joel Selvaraj wrote:
>
> This patch adds audio support for Xiaomi Poco F1 phone. Phone's primary
> Mic and 3.5mm Headphone jack are handled through the SDM845 sound card
> and WCD9340 codec.
>
Tested-by: Amit Pundir
> Signed-off
Hi,
On Fri, 12 Feb 2021 at 23:11, AngeloGioacchino Del Regno
wrote:
>
> Il 12/02/21 10:24, Amit Pundir ha scritto:
> > Hi,
> >
> > On Thu, 11 Feb 2021 at 00:25, AngeloGioacchino Del Regno
> > wrote:
> >>
> >> Il 10/02/21 09:18,
Hi,
On Thu, 11 Feb 2021 at 00:25, AngeloGioacchino Del Regno
wrote:
>
> Il 10/02/21 09:18, Amit Pundir ha scritto:
> > From: Sumit Semwal
> >
> > Enabling the Display panel for beryllium requires DSI
> > labibb regulators and panel dts nodes to be added.
> &
esitant to
> > tinker around anything regulator related that can potentially damage
> > the hardware. Having said that, I do see lab/ibb nodes being set in
> > the downstream dts, with relevant soft-start and discharge-resistor
> > properties and I can try switching to that once the
From: Sumit Semwal
Enabling the Display panel for beryllium requires DSI
labibb regulators and panel dts nodes to be added.
It is also required to keep some of the regulators as
always-on.
Signed-off-by: Sumit Semwal
Signed-off-by: Amit Pundir
---
v3: Addressed Konrad's concerns. Configured
ially damage
the hardware. Having said that, I do see lab/ibb nodes being set in
the downstream dts, with relevant soft-start and discharge-resistor
properties and I can try switching to that once the new lab/ibb
changes land upstream.
Regards,
Amit Pundir
>
>
>
> Ko
From: Sumit Semwal
Enabling the Display panel for beryllium phone (Xiaomi
Pocophone F1) requires DSI labibb regulators and panel
dts nodes to be added. It is also required to keep some
of the regulators as always-on.
Signed-off-by: Sumit Semwal
Signed-off-by: Amit Pundir
---
v2: Rebased
Argh.. This patch is not formatted on top of mainline. It doesn't
apply cleanly. Sorry about that. I'll fix that in the next version.
Regards,
Amit Pundir
On Wed, 3 Feb 2021 at 15:29, Amit Pundir wrote:
>
> From: Sumit Semwal
>
> Enabling the Display panel for beryllium p
From: Sumit Semwal
Enabling the Display panel for beryllium phone (Xiaomi
Pocophone F1) requires DSI labibb regulators and panel
dts nodes to be added. It is also required to keep some
of the regulators as always-on.
Signed-off-by: Sumit Semwal
Signed-off-by: Amit Pundir
---
.../boot/dts
sion (WLAN.HL.2.0.XXX), used by Dragonboard 845c (which has
Wi-Fi working upstream).
Regards,
Amit Pundir
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
:
> - Sony Xperia 10(SDM630 Ganges Kirin)
> - Sony Xperia 10 Plus (SDM636 Ganges Mermaid)
>
Tested the patch series on Xiaomi Poco F1 (SDM845 Beryllium, Novatek
NT36672A IC).
For the whole series:
Tested-by: Amit Pundir
Regards,
Amit Pundir
> Changes in v2:
> - Fixed sparse
etch is enabled. Use vfp in the prefill calculation
> as dpu driver enables prefetch if the blanking is not sufficient
> to fill the latency lines.
Tested on Xiaomi Poco F1 (sdm845).
Tested-by: Amit Pundir
>
> Signed-off-by: Kalyan Thota
> ---
> drivers/gpu/drm/msm/di
Hi Kalyan,
On Tue, 24 Nov 2020 at 18:27, wrote:
>
> On 2020-11-08 23:25, Amit Pundir wrote:
> > On Tue, 4 Aug 2020 at 21:09, Rob Clark wrote:
> >>
> >> On Thu, Jul 16, 2020 at 4:36 AM Kalyan Thota
> >> wrote:
> >> >
> >> > This c
idn't help and neither did
building board-2.bin file from stock bdwlan* files.
This workaround will be removed once we have a viable fix.
Thanks to postmarketOS guys for catching this.
Signed-off-by: Amit Pundir
---
We dropped this workaround last time in the favor of
a generic dts quirk to skip host
:
> - Sony Xperia 10(SDM630 Ganges Kirin)
> - Sony Xperia 10 Plus (SDM636 Ganges Mermaid)
Tested the patch series on Xiaomi Poco F1 (SDM845 Beryllium) using
Novatek NT36672A IC. May I suggest adding "novatek,nt36672a" in the
list of compatible of_device_id{} as well.
Reg
.org/dri-devel/20201027102304.945424-1-dmitry.barysh...@linaro.org/
Am I missing any other followup fix?
Regards,
Amit Pundir
Hi Rob, Bjorn, Kalle,
On Thu, 29 Oct 2020 at 19:10, Bjorn Andersson
wrote:
>
> On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote:
>
> > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote:
> > > There are firmware versions which do not support host capability
>
On Wed, 30 Sep 2020 at 00:38, Rob Herring wrote:
>
> On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote:
> > There are firmware versions which do not support host capability
> > QMI request. We suspect either the host cap is not implemented or
> > there may be
On Tue, 29 Sep 2020 at 03:21, Dmitry Torokhov wrote:
>
> On Mon, Sep 28, 2020 at 03:18:18PM +0530, Amit Pundir wrote:
> > On Sun, 27 Sep 2020 at 18:06, wrote:
> > >
> > > From: AngeloGioacchino Del Regno
> > >
> > > This is a driver for the Nov
ve to make a minor change to get it working. The
downstream driver and even the github code you linked above use
GPIO mapped IRQ, and I had to switch to that to get touchscreen
working with your driver
https://github.com/pundiramit/linux/commit/0a73eb656c1e80787dc195641ce7b0076fddb38e.
I wonder if I'm mis
On Fri, 25 Sep 2020 at 20:57, Bjorn Andersson
wrote:
>
> On Thu 24 Sep 11:31 CDT 2020, Kalle Valo wrote:
>
> > Amit Pundir writes:
> >
> > > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845)
> > > phone. We get a non-fatal QMI_ER
rmware nor to the ath10k driver and we can still
bring up the WiFi services successfully if we just ignore it.
Hence introducing this DeviceTree quirk to skip host capability
QMI request for the firmware versions which do not support this
feature.
Suggested-by: Bjorn Andersson
Signed-off-by: A
On Thu, 17 Sep 2020 at 21:35, Bjorn Andersson
wrote:
>
> On Thu 17 Sep 02:41 CDT 2020, Amit Pundir wrote:
>
> > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845)
> > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error
> > message in ath10k_qmi_host_cap_se
idn't help and neither did
building board-2.bin file from stock bdwlan* files.
This workaround will be removed once we have a viable fix.
Thanks to postmarketOS guys for catching this.
Signed-off-by: Amit Pundir
---
Device-tree for Xiaomi Poco F1(Beryllium) got merged in
qcom/arm64-for-5.10 last
that shipped with
Android-9 based release. Newer bootloader version do not
support switching OFF the display panel at all.
Signed-off-by: Amit Pundir
---
My WIP tree with a few out-of-tree patches to support
display, touchscreen, wifi, audio etc is here:
https://github.com/pundiramit/linux/commits
Rob for the Adreno
> SMMU support. It applies cleanly ontop of v16 of their series, which can be
> found at
> https://lore.kernel.org/linux-arm-msm/20200901164707.2645413-1-robdcl...@gmail.com/
>
Boot tested the series on Xiaomi Poco F1 phone (sdm845)
Tested-by: Amit Pundir
> B
ummy regulators, which is working fine for me so far.
Also I see that vdd-*-supply properties are optional according to
Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt,
so I assume it is safe to skip them?
Regards,
Amit Pundir
>
> Konrad
Hi Konrad,
I couldn't find answer to your question around missing
(regulatorname)-supply properties. Need help in figuring out that
part.
Regards,
Amit Pundir
On Mon, 31 Aug 2020 at 10:54, Amit Pundir wrote:
>
> Add initial dts support for Xiaomi Poco F1 (Beryllium).
>
> This ini
that shipped with
Android-9 based release. Newer bootloader version do not
support switching OFF the display panel at all.
Signed-off-by: Amit Pundir
---
My WIP tree with a few out-of-tree patches to support
display, touchscreen, wifi, audio etc is here:
https://github.com/pundiramit/linux/commits
ete this now here, that fork can remain just fine, with the added
> benifit of it reducing developer workloads here in-kernel.
>
> So why wait?
Hi,
I don't know what is the right thing to do here. I just want to
highlight that AOSP's audio (codec2) HAL depends on the ION system
heap and it will break AOSP for people who boot mainline on their
devices, even for just testing purpose like we do in Linaro. Right now
we need only 1 (Android specific out-of-tree) patch to boot AOSP with
mainline and Sumit is already trying to upstream that vma naming
patch. Removal of in-kernel ION, will just add more to that delta.
Regards,
Amit Pundir
>
> thanks,
>
> greg k-h
* It seems that mmc_test reports errors if drive
> > + * strength is not 16 on clk, cmd, and data pins.
>
> You say that, but then you set "drive-strength = <10>;" for cmd and data,
> please confirm it's intentional.
In sync with db845c as well a
that shipped with
Android-9 based release. Newer bootloader version do not
support switching OFF the display panel at all. So we need
a few additional smmu patches (under review) from here:
https://github.com/pundiramit/linux/commits/beryllium-mainline
Signed-off-by: Amit Pundir
---
v5: Bumped _mem size
downstream _region (of size 0x1A0) +
previously unreserved downstream memory region (of size 0x20), to
align with the starting address of _mem?
I just gave this _mem change a spin and I do not see any obvious
regression in my limited smoke testing (Boots AOSP to UI with
v5.9-rc1. Touch/BT/WiFi works) so far, with 20+ out-of-tree patches.
Regards,
Amit Pundir
>
> Regards,
> Bjorn
during the shutdown/reboot process. But I'm happy
to take a swing at any intermediate/in-progress solution available.
Regards,
Amit Pundir
>
> Forcing QCA6390 users to use the userspace qrtr-ns would be bad user
> experience, I really would want to avoid that.
>
> --
> h
atches [1]) and I see no obvious regressions.
For both the patches in the series:
Tested-by: Amit Pundir
[1] https://github.com/pundiramit/linux/commits/beryllium-mainline-display
>
> ---
> Changes since v3:
> - Do not use memblock_start_of_DRAM()
>
> Changes since v2:
&g
On Fri, 7 Aug 2020 at 04:02, Konrad Dybcio wrote:
>
> Subject: Re: [PATCH v4] arm64: dts: qcom: Add support for Xiaomi Poco F1
> (Beryllium)
>
> >// This removed_region is needed to boot the device
> > // TODO: Find out the user of this reserved memory
> >
tables belongs to an
> early engineering rev of the SoC.
> Fix up the OPP tables such that it now matches with the
> production rev of sdm845 SoC.
>
> Fixes: 13cadb34e593 ("arm64: dts: sdm845: Add OPP table for all qup
> devices")
Fixes BT on Xiaomi Poco F1 phone running
as also reported on venus [1] because the
> clock frequency tables apparently don;t exactly match the achievable clock
> frequencies (which we also used to construct the OPP tables)
>
> Can you try updating the OPP table for QUP to have 10240 instead of the
> current 1 and see if that fixes it?
That worked. Thanks.
Should this change be common to base sdm845.dtsi or platform specific dts?
For what it's worth, we see this BT breakage on PocoF1 phone too.
Regards,
Amit Pundir
>
> [1] https://lkml.org/lkml/2020/7/27/507
>
> >
> > thanks
> > -john
> >
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
that shipped with
Android-9 based release. Newer bootloader version do not
support switching OFF the display panel at all. So we need
a few additional smmu patches (under review) from here to
boot to shell:
https://github.com/pundiramit/linux/commits/beryllium-mainline
Signed-off-by: Amit Pundir
---
v4
On Wed, 5 Aug 2020 at 16:21, Amit Pundir wrote:
>
> Add initial dts support for Xiaomi Poco F1 (Beryllium).
>
> This initial support is based on upstream Dragonboard 845c
> (sdm845) device. With this dts, Beryllium boots AOSP up to
> ADB shell over USB-C.
>
> Supported fu
On Tue, 4 Aug 2020 at 11:46, Bjorn Andersson wrote:
>
> On Sat 01 Aug 08:55 PDT 2020, Amit Pundir wrote:
>
> > Add initial dts support for Xiaomi Poco F1 (Beryllium).
> >
> > This initial support is based on upstream Dragonboard 845c
> > (sdm845) device. With
that shipped with
Android-9 based release. Newer bootloader version do not
support switching OFF the display panel at all. So we need
a few additional smmu patches (under review) from here to
boot to shell:
https://github.com/pundiramit/linux/commits/beryllium-mainline
Signed-off-by: Amit Pundir
---
v3
that shipped with
Android-9 based release. Newer bootloader version do not
support switching OFF the display panel at all. So we need
a few additional smmu patches (under review) from here to
boot to shell:
https://github.com/pundiramit/linux/commits/beryllium-mainline
Signed-off-by: Amit Pundir
---
v2
dress: Add bus type match for pci ranges parser": OK
> v5.8-rc1 + both: BROKEN
>
> I wanted to test the series to see if this fixes anything. If you would
> prefer a different thread for this or further information, please let
> me know.
Hi Nathan,
Here is the patch series:
https://lists.linuxfoundation.org/pipermail/iommu/2020-July/047008.html
https://lists.linuxfoundation.org/pipermail/iommu/2020-July/047010.html
I hope it works for you, it didn't work for me. More details in this
thread here:
https://lists.linuxfoundation.org/pipermail/iommu/2020-July/047009.html
Regards,
Amit Pundir
>
> Cheers,
> Nathan
ow hackish) way to not apply the addressability check for dma-iommu
> allocations.
Thank you. The below patch worked on today's linux/master (f37e99aca03f).
Regards,
Amit Pundir
>
> diff --git a/kernel/dma/pool.c b/kernel/dma/pool.c
> index 6bc74a2d51273e..ec5e525d2b9309 100644
> --- a/ke
On Fri, 24 Jul 2020 at 15:06, Nicolas Saenz Julienne
wrote:
>
> Hi Amit,
>
> On Thu, 2020-07-23 at 10:44 +0530, Amit Pundir wrote:
> > Hi Nicolas,
> >
> > Sorry I got stuck on other things yesterday.
>
> No worries :)
>
> > On Tue,
Hi Nicolas,
Sorry I got stuck on other things yesterday.
On Tue, 21 Jul 2020 at 21:57, Nicolas Saenz Julienne
wrote:
>
> On Tue, 2020-07-21 at 20:52 +0530, Amit Pundir wrote:
>
> [...]
>
> > > > > Can you try booting *without* my patch and this in the kernel
&g
On Tue, 21 Jul 2020 at 18:15, Nicolas Saenz Julienne
wrote:
>
> On Tue, 2020-07-21 at 17:45 +0530, Amit Pundir wrote:
> > On Tue, 21 Jul 2020 at 16:45, Nicolas Saenz Julienne
> > wrote:
> > > On Tue, 2020-07-21 at 14:24 +0530, Amit Pundir wrote:
> > > >
rom CMA but check the
> > address a try? (just because we can..)
>
> Yes, good idea!
>
> Amir, could you also test this patch[1] (having reverted the one that
> casues trouble) and report on whether it boots or not?
Can't boot with that patch either.
Regards,
Amit Pundir
On Tue, 21 Jul 2020 at 16:45, Nicolas Saenz Julienne
wrote:
>
> On Tue, 2020-07-21 at 14:24 +0530, Amit Pundir wrote:
> > On Tue, 21 Jul 2020 at 14:09, Nicolas Saenz Julienne
> > wrote:
> > > Hi Amit,
> > > > Hi Nicolas,
> > > >
> > >
On Tue, 21 Jul 2020 at 14:09, Nicolas Saenz Julienne
wrote:
>
> Hi Amit,
>
> On Tue, 2020-07-21 at 12:51 +0530, Amit Pundir wrote:
> > On Wed, 8 Jul 2020 at 22:43, Nicolas Saenz Julienne
> > wrote:
> > > There is no guarantee to CMA's placement, so allocating a
happy to
help debug things. For what it's worth, I don't see this regression on
other two sdm845 devices (db845c and Pixel 3) I tested on.
Regards,
Amit Pundir
> Reported-by: Jeremy Linton
> Signed-off-by: Nicolas Saenz Julienne
> ---
>
> An more costly alternative would be addin
that shipped with
Android-9 based release. Newer bootloader version do not
support switching OFF the display panel at all. So we need
a couple of additional smmu patches (under review) from here
to boot to shell:
https://github.com/pundiramit/linux/commits/beryllium-mainline
Signed-off-by: Amit Pundir
definition. It is added
in 582e2b4aecda ("MIPS: GIC: Introduce asm/mips-gic.h with accessor
functions"), which need to be backported too because it doesn't apply
cleanly on linux-4.9.y.
Regards,
Amit Pundir
>
> Jann Horn
> mm/vmstat.c: fix outdated vmstat_text
>
definition. It is added
in 582e2b4aecda ("MIPS: GIC: Introduce asm/mips-gic.h with accessor
functions"), which need to be backported too because it doesn't apply
cleanly on linux-4.9.y.
Regards,
Amit Pundir
>
> Jann Horn
> mm/vmstat.c: fix outdated vmstat_text
>
.org/r/1504764252-29091-1-git-send-email-prs...@codeaurora.org
This patch applies cleanly to 4.14.y and 4.9.y. But I'm confused if
this particular patch alone is good enough for these stable kernels,
since the commit message talks about some "recent cpu/hotplug
refactoring" dependency(?).
Regards,
Amit Pundir
>
> thanks,
>
> greg k-h
>
> >
> > --
> > Regards
> > Sudip
.org/r/1504764252-29091-1-git-send-email-prs...@codeaurora.org
This patch applies cleanly to 4.14.y and 4.9.y. But I'm confused if
this particular patch alone is good enough for these stable kernels,
since the commit message talks about some "recent cpu/hotplug
refactoring" dependency(?).
Regards,
Amit Pundir
>
> thanks,
>
> greg k-h
>
> >
> > --
> > Regards
> > Sudip
current HEAD: 6b4703768268 ("Merge branch 'fixes' of
git://git.armlinux.org.uk/~rmk/linux-arm"). Thanks.
Regards,
Amit Pundir
current HEAD: 6b4703768268 ("Merge branch 'fixes' of
git://git.armlinux.org.uk/~rmk/linux-arm"). Thanks.
Regards,
Amit Pundir
5..1af6915 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -402,7 +402,8 @@ static int ashmem_mmap(struct file *file, struct
> vm_area_struct *vma)
> fput(asma->file);
> goto out;
> }
> - }
> + } else
> + vma_set_anonymous(vma);
>
> if (vma->vm_file)
> fput(vma->vm_file);
>
This ashmem change ^^ worked too.
Regards,
Amit Pundir
>
> Seem to resolve it? (Sorry, I'd test it myself, but I'm away from my
> desk for the night).
> thanks
> -john
5..1af6915 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -402,7 +402,8 @@ static int ashmem_mmap(struct file *file, struct
> vm_area_struct *vma)
> fput(asma->file);
> goto out;
> }
> - }
> + } else
> + vma_set_anonymous(vma);
>
> if (vma->vm_file)
> fput(vma->vm_file);
>
This ashmem change ^^ worked too.
Regards,
Amit Pundir
>
> Seem to resolve it? (Sorry, I'd test it myself, but I'm away from my
> desk for the night).
> thanks
> -john
On Mon, 30 Jul 2018 at 18:31, Kirill A. Shutemov wrote:
>
> On Mon, Jul 30, 2018 at 12:17:46PM +0530, Amit Pundir wrote:
> > On Mon, 30 Jul 2018 at 03:39, Linus Torvalds
> > wrote:
> > >
> > > So unless something odd happens, this should be the last rc for 4.
On Mon, 30 Jul 2018 at 18:31, Kirill A. Shutemov wrote:
>
> On Mon, Jul 30, 2018 at 12:17:46PM +0530, Amit Pundir wrote:
> > On Mon, 30 Jul 2018 at 03:39, Linus Torvalds
> > wrote:
> > >
> > > So unless something odd happens, this should be the last rc for 4.
(android::AndroidRuntime::startVm(_JavaVM**, _JNIEnv**, bool)+5038)
F DEBUG : #09 pc 2381 /system/lib/libandroid_runtime.so
(android::AndroidRuntime::start(char const*,
android::Vector const&, bool)+196)
F DEBUG : #10 pc 046b /system/bin/app_process32 (main+702)
Regards,
Amit Pundir
(android::AndroidRuntime::startVm(_JavaVM**, _JNIEnv**, bool)+5038)
F DEBUG : #09 pc 2381 /system/lib/libandroid_runtime.so
(android::AndroidRuntime::start(char const*,
android::Vector const&, bool)+196)
F DEBUG : #10 pc 046b /system/bin/app_process32 (main+702)
Regards,
Amit Pundir
Remove redundant __func__ parameter from dev_dgb() calls and
delete empty dev_dbg() trace calls, which are redundant if
function tracer is enabled.
Signed-off-by: Amit Pundir <amit.pun...@linaro.org>
Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
v3:
Updated co
Remove redundant __func__ parameter from dev_dgb() calls and
delete empty dev_dbg() trace calls, which are redundant if
function tracer is enabled.
Signed-off-by: Amit Pundir
Reviewed-by: Andy Shevchenko
---
v3:
Updated commit message.
v2:
Deleted empty dev_dbg() trace calls, which
.kernel.org>
Signed-off-by: Suren Baghdasaryan <sur...@google.com>
Signed-off-by: Amit Pundir <amit.pun...@linaro.org>
Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
v3..v1:
Resend. No changes.
net/nfc/hci/core.c | 10 ++
1 file changed, 10 insert
Signed-off-by: Amit Pundir
Reviewed-by: Andy Shevchenko
---
v3..v1:
Resend. No changes.
net/nfc/hci/core.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/net/nfc/hci/core.c b/net/nfc/hci/core.c
index ac8030c4bcf8..19cb2e473ea6 100644
--- a/net/nfc/hci/core.c
+++ b/net/nfc/hci/core.c
tra bytes resulting in OOB read from the kernel heap.
cc: Stable <sta...@vger.kernel.org>
Signed-off-by: Suren Baghdasaryan <sur...@google.com>
Signed-off-by: Amit Pundir <amit.pun...@linaro.org>
Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
v3..v1:
Resend. N
rom the kernel heap.
cc: Stable
Signed-off-by: Suren Baghdasaryan
Signed-off-by: Amit Pundir
Reviewed-by: Andy Shevchenko
---
v3..v1:
Resend. No changes.
drivers/nfc/st21nfca/dep.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nfc/st21nfca/dep.c b/drivers/
From: Suren Baghdasaryan <sur...@google.com>
Possible buffer overflow when reading next_read_size bytes into
tmp buffer after next_read_size was extracted from a previous packet.
cc: Stable <sta...@vger.kernel.org>
Signed-off-by: Suren Baghdasaryan <sur...@google.com>
Signed-o
From: Suren Baghdasaryan
Possible buffer overflow when reading next_read_size bytes into
tmp buffer after next_read_size was extracted from a previous packet.
cc: Stable
Signed-off-by: Suren Baghdasaryan
Signed-off-by: Amit Pundir
Reviewed-by: Andy Shevchenko
---
v3:
Reset next_read_size
On 3 May 2018 at 15:50, Andy Shevchenko
<andriy.shevche...@linux.intel.com> wrote:
> On Wed, 2018-05-02 at 23:18 +0530, Amit Pundir wrote:
>> From: Suren Baghdasaryan <sur...@google.com>
>>
>> Possible buffer overflow when reading next_read_size bytes into
&
On 3 May 2018 at 15:50, Andy Shevchenko
wrote:
> On Wed, 2018-05-02 at 23:18 +0530, Amit Pundir wrote:
>> From: Suren Baghdasaryan
>>
>> Possible buffer overflow when reading next_read_size bytes into
>> tmp buffer after next_read_size was extracted from a previo
Remove redundant __func__ parameter from dev_dgb() calls.
v2:
Deleted empty dev_dbg() trace calls, which are redundant if
function tracer is enabled.
Signed-off-by: Amit Pundir <amit.pun...@linaro.org>
---
drivers/nfc/fdp/fdp.c | 18 +++---
drivers/nfc/fdp/i2c.
Remove redundant __func__ parameter from dev_dgb() calls.
v2:
Deleted empty dev_dbg() trace calls, which are redundant if
function tracer is enabled.
Signed-off-by: Amit Pundir
---
drivers/nfc/fdp/fdp.c | 18 +++---
drivers/nfc/fdp/i2c.c | 17 -
2 files changed, 7
Remove redundant __func__ parameter from dev_dgb() calls.
Signed-off-by: Amit Pundir <amit.pun...@linaro.org>
---
drivers/nfc/fdp/fdp.c | 22 +++---
drivers/nfc/fdp/i2c.c | 20 +---
2 files changed, 20 insertions(+), 22 deletions(-)
diff --git a/drivers/n
Remove redundant __func__ parameter from dev_dgb() calls.
Signed-off-by: Amit Pundir
---
drivers/nfc/fdp/fdp.c | 22 +++---
drivers/nfc/fdp/i2c.c | 20 +---
2 files changed, 20 insertions(+), 22 deletions(-)
diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp
tra bytes resulting in OOB read from the kernel heap.
Signed-off-by: Suren Baghdasaryan <sur...@google.com>
Signed-off-by: Amit Pundir <amit.pun...@linaro.org>
---
v2:
Resend. No changes.
drivers/nfc/st21nfca/dep.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers
rom the kernel heap.
Signed-off-by: Suren Baghdasaryan
Signed-off-by: Amit Pundir
---
v2:
Resend. No changes.
drivers/nfc/st21nfca/dep.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nfc/st21nfca/dep.c b/drivers/nfc/st21nfca/dep.c
index fd08be2..3420c51 100
aghdasaryan <sur...@google.com>
Signed-off-by: Amit Pundir <amit.pun...@linaro.org>
---
v2:
Resend. No changes.
net/nfc/hci/core.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/net/nfc/hci/core.c b/net/nfc/hci/core.c
index ac8030c4..19cb2e4 100644
--- a/net/nfc/hci/cor
From: Suren Baghdasaryan
When handling SHDLC I-Frame commands "pipe" field used for indexing
into an array should be checked before usage. If left unchecked it
might access memory outside of the array of size NFC_HCI_MAX_PIPES(127).
Signed-off-by: Suren Baghdasaryan
Signed-off-by: A
From: Suren Baghdasaryan <sur...@google.com>
Possible buffer overflow when reading next_read_size bytes into
tmp buffer after next_read_size was extracted from a previous packet.
Signed-off-by: Suren Baghdasaryan <sur...@google.com>
Signed-off-by: Amit Pundir <amit.pun...@lin
From: Suren Baghdasaryan
Possible buffer overflow when reading next_read_size bytes into
tmp buffer after next_read_size was extracted from a previous packet.
Signed-off-by: Suren Baghdasaryan
Signed-off-by: Amit Pundir
---
v2:
Remove redundant __func__ from dev_dgb().
drivers/nfc/fdp/i2c.c
ter usage in dev_dbg(),
so submitting a new patch separately to clean that up.
Regards,
Amit Pundir
[1] https://android.googlesource.com/kernel/common/+log/android-4.14
Suren Baghdasaryan (3):
NFC: st21nfca: Fix out of bounds kernel access when handling ATR_REQ
NFC: Fix possible memory corr
ter usage in dev_dbg(),
so submitting a new patch separately to clean that up.
Regards,
Amit Pundir
[1] https://android.googlesource.com/kernel/common/+log/android-4.14
Suren Baghdasaryan (3):
NFC: st21nfca: Fix out of bounds kernel access when handling ATR_REQ
NFC: Fix possible memory corr
On 20 April 2018 at 22:15, Mark Greer <mgr...@animalcreek.com> wrote:
> On Fri, Apr 20, 2018 at 03:39:46PM +0300, Andy Shevchenko wrote:
>> On Wed, 2018-04-18 at 15:35 +0530, Amit Pundir wrote:
>>
>> > if (skb-
On 20 April 2018 at 22:15, Mark Greer wrote:
> On Fri, Apr 20, 2018 at 03:39:46PM +0300, Andy Shevchenko wrote:
>> On Wed, 2018-04-18 at 15:35 +0530, Amit Pundir wrote:
>>
>> > if (skb->data[transaction->aid_len + 2] !=
>> > -
On 20 April 2018 at 18:09, Andy Shevchenko
<andriy.shevche...@linux.intel.com> wrote:
> On Wed, 2018-04-18 at 15:35 +0530, Amit Pundir wrote:
>
>> if (skb->data[transaction->aid_len + 2] !=
>> -
On 20 April 2018 at 18:09, Andy Shevchenko
wrote:
> On Wed, 2018-04-18 at 15:35 +0530, Amit Pundir wrote:
>
>> if (skb->data[transaction->aid_len + 2] !=
>> - NFC_EVT_TRANSACTION_PARAMS_TAG)
>> +
On 23 April 2018 at 14:46, Greg KH <gre...@linuxfoundation.org> wrote:
> On Wed, Apr 18, 2018 at 03:35:04PM +0530, Amit Pundir wrote:
>> From: Suren Baghdasaryan <sur...@google.com>
>>
>> Possible buffer overflow when reading next_read_size bytes into
&
On 23 April 2018 at 14:46, Greg KH wrote:
> On Wed, Apr 18, 2018 at 03:35:04PM +0530, Amit Pundir wrote:
>> From: Suren Baghdasaryan
>>
>> Possible buffer overflow when reading next_read_size bytes into
>> tmp buffer after next_read_size was extracted from a previo
tra bytes resulting in OOB read from the kernel heap.
Signed-off-by: Suren Baghdasaryan <sur...@google.com>
Signed-off-by: Amit Pundir <amit.pun...@linaro.org>
---
drivers/nfc/st21nfca/dep.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nfc/st21nfca/dep.c b/drive
rom the kernel heap.
Signed-off-by: Suren Baghdasaryan
Signed-off-by: Amit Pundir
---
drivers/nfc/st21nfca/dep.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nfc/st21nfca/dep.c b/drivers/nfc/st21nfca/dep.c
index fd08be2917e6..3420c5104c94 100644
--- a/drivers/
Suren Baghdasaryan <sur...@google.com>
Signed-off-by: Amit Pundir <amit.pun...@linaro.org>
---
drivers/nfc/st21nfca/se.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/nfc/st21nfca/se.c b/drivers/nfc/st21nfca/se.c
index 4bed9e842db3..a
-by: Amit Pundir
---
drivers/nfc/st21nfca/se.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/nfc/st21nfca/se.c b/drivers/nfc/st21nfca/se.c
index 4bed9e842db3..acdce231e227 100644
--- a/drivers/nfc/st21nfca/se.c
+++ b/drivers/nfc/st21nfca/se.c
1 - 100 of 296 matches
Mail list logo
