On Mon, 08 Apr 2019 21:14:44 +0200
Robert Jarzmik wrote:
> Arnd Bergmann writes:
>
> > On Mon, Apr 8, 2019 at 8:58 AM Antonio Ospite wrote:
> >> On Sun, 7 Apr 2019 16:07:41 +0200
> >> Alexandre Belloni wrote:
> >> adding Robert to CC as he is listed as
ZX hardware "recently".
FWIW I think EZX code can be removed if it is a maintenance burden for
anyone.
Thank you,
Antonio
--
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
can ignore some of them, and motivate your decision in an
annotation.
Also try to comment when you do not agree with the reviewer or cannot
comply (for example about using an interrupt instead of polling).
It's fine if your English is not perfect yet, don't let that stop you :)
Ciao ciao,
erest. Robert already agreed to act as a fallback so
> we would still be safe. :)
>
I still use a Motorola A1200 with the original EZX stack as my main
phone (and that tells something about how much I use a phone...)
however I haven't touched any OpenEZX stuff in a while.
I don'
9e42579fd
After that any v4l2 program using libv4l2 will at least be able to show
_an_ image.
You can play with "false color" representations too in libv4lconvert,
however I don't know if such representations are generic enough to be
mainlined, in the Kinect case the false color representation of the
depth map was done in specialized software like libfreenect.
Ciao,
Antonio
--
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
On Mon, 25 Jul 2016 11:14:04 +0200
Benjamin Tissoires wrote:
> On Jul 21 2016 or thereabouts, Antonio Ospite wrote:
[...]
> > It would be interesting to understand why some (supposedly) compatible
> > devices break, maybe they rely on the fact that the PS3 would use the
>
ected.
>
> Signed-off-by: Mikko Perttunen
Acked-by: Antonio Ospite
> ---
> v2: don't use usb device properties
>
> drivers/hid/hid-sony.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony
ges and I
can test patches with some original controllers if needed.
Ciao ciao,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
en found by scripts/checkpatch.pl as:
WARNING: Missing a blank line after declarations
#252: FILE: drivers/media/usb/hackrf/hackrf.c:252:
+ const bool tx = test_bit(TX_ON, &dev->flags);
+ static const struct {
it is a false positive, as the code which follows the blank line
The email address is not active anymore, use
Antonio's personal email address in case someone wants to
get in touch for the code wrote for Amarula Solutions.
Signed-off-by: Antonio Ospite
Cc: Michael Trimarchi
Cc: Linus Torvalds
---
.mailmap | 1 +
1 file changed, 1 insertion(+)
diff
On Thu, 20 Aug 2015 16:44:02 +0200
Jacek Anaszewski wrote:
> From: Andrew Lunn
>
> Now the core implements the work queue, remove it from the drivers,
> and switch to using brightness_set_blocking op.
>
> Signed-off-by: Andrew Lunn
> Cc: Antonio Ospite
> Signed-
On Thu, 20 Aug 2015 16:43:49 +0200
Jacek Anaszewski wrote:
> From: Andrew Lunn
>
> Now the core implements the work queue, remove it from the driver,
> and switch to using brightness_set_blocking op.
>
> Signed-off-by: Andrew Lunn
> Cc: Antonio Ospite
> Signed-
On Fri, 17 Jul 2015 10:47:14 +0200
Jacek Anaszewski wrote:
> Now the core implements the work queue, remove it from the drivers.
>
> Signed-off-by: Andrew Lunn
> Cc: Antonio Ospite
I can't test the changes, but they look good to me.
Acked-by: Antonio Ospite
Maybe regula
On Fri, 17 Jul 2015 10:47:01 +0200
Jacek Anaszewski wrote:
> From: Andrew Lunn
>
> Now the core implements the work queue, remove it from the driver.
>
> Signed-off-by: Andrew Lunn
> Cc: Antonio Ospite
I can't test the changes but they look good to me.
Acked-by:
On Wed, 3 Jun 2015 10:26:47 +
"Tirdea, Irina" wrote:
> > -Original Message-
> > From: Antonio Ospite [mailto:a...@ao2.it]
> > Sent: 28 May, 2015 18:58
> > To: Tirdea, Irina
> > Cc: Dmitry Torokhov; Bastien Nocera; linux-in...@vger.kernel.org
ry.
Thanks,
Antonio
> int touch_num;
> int i;
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.or
e can ease this a bit by introducing acpi_dev_gpio_irq_get() analogous to
> of_irq_get(). This function translates given GpioInt resource under the
> device in question to the suitable Linux IRQ number.
>
> Signed-off-by: Mika Westerberg
> Acked-by: Rafael J. Wysocki
Tested-by: An
rupt */
> + struct gpio_desc*desc;
Just curious: can't the gpio_desc be local in the probe function?
I take that the gpio descriptor needs to be alive even after the irq
number has been derived from it in order for the gpio chip to remember
that the gpio has been requested by som
On Mon, 16 Feb 2015 15:06:59 +0200
Lauri Kasanen wrote:
> Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send
> any events. Now everything works including the leds.
>
> Based on work by Andrew Haines and Antonio Ospite.
>
> cc: Antonio Ospite
> cc:
On Tue, 10 Feb 2015 14:52:52 +0200
Lauri Kasanen wrote:
> Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send
> any events. Now everything works including the leds.
>
> Based on work by Andrew Haines and Antonio Ospite.
>
> cc: Antonio Ospite
> cc:
Hi Lauri,
On Sun, 8 Feb 2015 11:11:38 +0200
Lauri Kasanen wrote:
> Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send
> any events. Now everything works including the leds.
>
> Based on work by Andrew Haines and Antonio Ospite.
>
> v2:
>
gt; > Based on work by Andrew Haines and Antonio Ospite.
> >
> > cc: Antonio Ospite
> > cc: Andrew Haines
> > Signed-off-by: Lauri Kasanen
> > ---
> > drivers/hid/hid-sony.c | 26 --
> > 1 file changed, 24 insertions(+), 2 d
BTN_SIDE:
> + index = 3; break;
>
> case BTN_4:
> - case BTN_EXTRA: index = 4; break;
> + case BTN_EXTRA:
> + index = 4; break;
>
> - default: return;
> + default:
> + return;
>
nge supports such high frame rates.
>
> Correct a QVGA mode that was listed as 40 FPS. It is really 37 FPS
> (half of 75 FPS).
>
> Tests confirm that the nominal frame rates are achieved.
>
> Signed-off-by: Joe Howse
Tested-by: Antonio Ospite
Thanks Joe.
I noticed t
On Mon, 17 Nov 2014 21:01:44 -0500
bri wrote:
> On Mon, Nov 17, 2014 at 01:35:18PM +0100, Antonio Ospite wrote:
> > I had tried doing something similar in the past (the parsing was just a
> > sscanf): http://thread.gmane.org/gmane.linux.bluez.kernel/5261 but then
> > we
stronger voice in the decisions.
If you ask me, wrt. usefulness and necessity the two functionality
are more or less on the same level but the code which is already there
will more likely stay in.
> But whatever. I made this for my own use, and offered it up, and if the
> community does
failed to create master_bdaddr sysfs file\n");
> + goto err_nosysfs1;
> }
>
> if (sc->quirks & SIXAXIS_CONTROLLER_USB) {
> @@ -1932,13 +2120,17 @@ static int sony_probe(struct hid_device
> err_close:
> hid_hw_close(hdev);
> err_
for charging
and it does not show as a USB HID device when plugged in, can you
confirm that?
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad
On Wed, 23 Jul 2014 23:30:48 +0100
Jamie Lentin wrote:
> Add support for both ThinkPad Compact Bluetooth Keyboard with
> TrackPoint and ThinkPad Compact USB Keyboard with TrackPoint.
>
> Signed-off-by: Jamie Lentin
I think this version is OK, thanks.
Reviewed-by: An
;);
> - }
>
> data_pointer = devm_kzalloc(&hdev->dev,
> sizeof(struct lenovo_drvdata_tpkbd),
> --
> 2.0.0
>
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.o
ra postfixed functions.
>
> Signed-off-by: Jamie Lentin
>
Reviewed-by: Antonio Ospite
> ---
> drivers/hid/hid-lenovo.c | 53
>
> 1 file changed, 45 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/hid/hid-leno
n
Reviewed-by: Antonio Ospite
> ---
> ...er-hid-lenovo-tpkbd => sysfs-driver-hid-lenovo} | 0
> drivers/hid/Kconfig| 14 +-
> drivers/hid/Makefile | 2 +-
> drivers/hid/hid-core.c |
On Fri, 18 Jul 2014 10:35:35 +0100 (BST)
Jamie Lentin wrote:
> On Mon, 14 Jul 2014, Antonio Ospite wrote:
>
> > On Sun, 13 Jul 2014 08:24:19 +0100
> > Jamie Lentin wrote:
> >
> >> Rename module and all functions within so we can add support for other
> >&
th Trackpoint
Maybe rename Bluetooth to BT if this becomes too long with the prefix.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
ENOVO_TPKBD:
> lenovo_remove_tpkbd(hdev);
> break;
> + case USB_DEVICE_ID_LENOVO_CUSBKBD:
> + case USB_DEVICE_ID_LENOVO_CBTKBD:
> + lenovo_remove_cptkbd(hdev);
> + break;
> }
>
> hid_hw_stop(hdev);
>
On Sun, 13 Jul 2014 08:24:21 +0100
Jamie Lentin wrote:
> Signed-off-by: Jamie Lentin
Reviewed-by: Antonio Ospite
> ---
> drivers/hid/hid-lenovo.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hi
> - if (hid_get_drvdata(hdev))
> + switch (hdev->product) {
> + case USB_DEVICE_ID_LENOVO_TPKBD:
> lenovo_remove_tpkbd(hdev);
> + break;
> + }
>
> hid_hw_stop(hdev);
> }
> @@ -454,7 +485,7 @@ MODULE_DEVICE_TABLE(hid, lenovo_devic
n
Reviewed-by: Antonio Ospite
Patch looks good to me, easier to validate now :)
A few ideas below for some possible _future_ cleanups, but no reason to
hold this one any longer IMHO.
Ciao,
Antonio
> ---
> ...er-hid-lenovo-tpkbd => sysfs-driver-hid-lenovo} |
novo_remove_cptkbd(hdev);
> + break;
> }
>
> hid_hw_stop(hdev);
> @@ -478,6 +677,8 @@ static void lenovo_remove(struct hid_device *hdev)
>
> static const struct hid_device_id lenovo_devices[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEV
gt; + if (ret)
> + goto err_hid;
>
This hunk would also go in the preparatory patch.
> return 0;
> err_hid:
> @@ -422,12 +449,15 @@ err:
> return ret;
> }
>
> -static void tpkbd_remove_tp(struct hid_device *hdev)
> +static void lenovo_r
On Thu, 12 Jun 2014 09:56:41 +0100 (BST)
Jamie Lentin wrote:
> On Wed, 11 Jun 2014, Antonio Ospite wrote:
>
[...]
> >> +static int tpcompactkbd_input_mapping(struct hid_device *hdev,
> >
> > Maybe name these functions like tpkbd_input_mapping_compact()?
> >
&
id tpkbd_devices[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_TPKBD) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_CUSBKBD) },
> + { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LENOVO,
> USB_DEVICE_ID_LENOVO_CBTKBD) },
> { }
&g
in tpkbd_remove() like
you are doing as hid_hw_stop() must be always called.
> + if (hdev->product == USB_DEVICE_ID_LENOVO_TPKBD)
> tpkbd_remove_tp(hdev);
>
> hid_hw_stop(hdev);
> --
> 2.0.0.rc2
>
> --
> To unsubscribe from this li
request_threaded_irq(pcap_to_irq(pcap_keys->pcap, PCAP_IRQ_MIC),
> > + NULL, pcap_keys_handler, 0,
> > + "Headphone button", pcap_keys);
>
> So I guess we do need threaded IRQ here, but I do not see the pcap&#
On Mon, 12 May 2014 19:14:56 -0700
Dmitry Torokhov wrote:
> On Sun, Apr 06, 2014 at 11:37:44PM +0200, Antonio Ospite wrote:
> > On Sun, 6 Apr 2014 13:24:36 -0700
> > Dmitry Torokhov wrote:
> >
> > > On Sun, Apr 06, 2014 at 12:54:50AM +0400, Alexey Khoroshilov wr
evices[] = {
> .driver_data = DUALSHOCK4_CONTROLLER_USB },
> { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY,
> USB_DEVICE_ID_SONY_PS4_CONTROLLER),
> .driver_data = DUALSHOCK4_CONTROLLER_BT },
> +
Extra blank line here.
> { }
> };
> MODULE_DE
On Sat, 26 Apr 2014 13:57:38 +0200
Michal Malý wrote:
> Add ff-memless-next module
>
Hi Michal, what about adding the notes from 0/24 to this commit
message? This is the one which will actually get into the project
history. And perhaps hint briefly about the improvements also in the
commit messa
pcap's
> irqchip specifying IRQCHIP_ONESHOT_SAFE so I do not think
> request_threaded_irq() without IRQF_ONESHOT would succeed.
>
> Can someone test the change to be sure?
>
I can try to test it in a couple of weeks, I don't have the hardware
at hand right now.
Ciao,
Antoni
On Mon, 10 Mar 2014 12:32:53 +0100
Antonio Ospite wrote:
> On Sat, 8 Mar 2014 22:52:42 -0500
> Benjamin Tissoires wrote:
>
> > hid_out_raw_report is going to be obsoleted as it is not part of the
> > unified HID low level transport documentation
> > (Document
ith the PS3 SixAxis
> controllers in USB mode.
>
> Reviewed-by: David Herrmann
> Signed-off-by: Benjamin Tissoires
>
I confirm that using hidraw via USB works again now, thanks, so the
patch is OK:
Tested-by: Antonio Ospite
However I still get the failure with hidraw via BT,
hid.h
> index 5eb282e..2baf834 100644
> --- a/include/linux/hid.h
> +++ b/include/linux/hid.h
> @@ -287,6 +287,8 @@ struct hid_item {
> #define HID_QUIRK_NO_EMPTY_INPUT 0x0100
> #define HID_QUIRK_NO_INIT_INPUT_REPORTS 0x0200
> #define HID_QUI
}
actual_len -= sizeof(*rhdr);
Proper patches on their way, to libfreenect too.
Thanks again,
Antonio
[1]
http://lxr.linux.no/#linux+v3.12.6/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c#L37
[2]
http://lxr.linux.no/#linux+v3.12.6/Documentation/usb/error-codes.txt#L134
[3]
https://github.com/O
t;diff"
blocks, so this is the best place to put annotations and patch
commentary.
See git-format-patch and git-am man pages for the details.
Ciao,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia
On Wed, 18 Dec 2013 15:44:48 +0100
David Herrmann wrote:
> Hi
>
> On Wed, Dec 18, 2013 at 3:27 PM, Antonio Ospite
> wrote:
> > Hi David,
> >
> > thanks for the update.
> >
> > On Tue, 17 Dec 2013 16:48:52 +0100
> > David Herrmann wrote:
> &
9,19 @@ struct input_keymap_entry {
> #define ABS_MAX 0x3f
> #define ABS_CNT (ABS_MAX+1)
>
> +#define ABS_ACCEL_X 0x40/* Accelerometer X axis */
> +#define ABS_ACCEL_Y 0x41/* Accelerometer Y axis */
> +#define AB
rnels right?
If a program decides to support only newer kernels it can check the
protocol version and use only the new ioctls, right?
Maybe you can be more explicit about that in the comment?
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people
On Mon, 16 Dec 2013 14:03:43 +0100
David Herrmann wrote:
> Hi
>
CCing linux-input which I forgot.
> On Mon, Dec 16, 2013 at 1:34 PM, Antonio Ospite
> wrote:
> > Fix some typos and while at it also use "PS" as the name for the central
> > "HOME"
Fix some typos and while at it also use "PS" as the name for the central
"HOME" button on Sony controllers, this is how Sony itself calls it.
Signed-off-by: Antonio Ospite
---
Documentation/input/gamepad.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -
Make Lindent recognize and format properly at least the commonly used
primitive types.
Something like this has been suggested before by J.R. Mauro:
https://lkml.org/lkml/2008/10/14/233
Signed-off-by: Antonio Ospite
---
Hi,
I had this local change and I felt like sharing it.
Another way of
On Wed, 20 Nov 2013 20:56:21 -0800
Dmitry Torokhov wrote:
> Hi Benjamin, Antonio,
>
> On Wed, Nov 20, 2013 at 04:32:19PM -0500, Benjamin Tissoires wrote:
> > From: Antonio Ospite
> >
> > This fixes the case when a non-multitouch device happens to have a HID
> >
On Sat, 26 Jan 2013 21:40:47 +1000
Ben Skeggs wrote:
> On Sat, 2013-01-26 at 11:53 +0100, Antonio Ospite wrote:
> > Hi,
> >
> > I am experiencing a bug with nouveau with linux-3.8-rc5, my video
> > adapter is the one integrated on the MSI M3N78-VM motherboard (hen
From: Antonio Ospite
Some audio drivers are calling snd_dma_continuous_data(GFP_KERNEL)
which makes "sparse" give a warning:
$ make C=2 M=sound/usb modules
...
sound/usb/6fire/pcm.c:625:25: warning: cast from restricted gfp_t
sound/usb/caiaq/audio.c:845:41: war
the cause,
I am not sure if this is the same scenario tho.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
--
To unsubscribe from thi
gt; sizeof(sixaxis_rdesc_fixup));
> }
> +
Ditto.
> return rdesc;
> }
>
> @@ -217,6 +219,8 @@ static const struct hid_device_id sony_d
> .driver_data = SIXAXIS_CONTROLLER_BT },
> { HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEV
On Mon, 5 Nov 2012 08:40:38 +
Dave Airlie wrote:
> On Mon, Nov 5, 2012 at 8:29 AM, Antonio Ospite
> wrote:
> > On Mon, 29 Oct 2012 23:16:24 +0100
> > Antonio Ospite wrote:
> >
> >> Hi,
> >>
> >> I am experiencing a bug with nouveau with l
On Mon, 29 Oct 2012 23:16:24 +0100
Antonio Ospite wrote:
> Hi,
>
> I am experiencing a bug with nouveau with linux-3.7-rc3 (and since rc1),
> my video adapter is the one integrated on the MSI M3N78-VM motherboard
> (hence x86_64):
>
[...]
> [ 1943.858601] BUG: unable to
veau E[ DRM] EvoCh 1 Mthd 0x0080 Data 0x (0x000b
0x05)
[ 1945.880013] [sched_delayed] sched: RT throttling activated
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_s
%27s_Manual
FTDI FT2232H provides two serial channels (A and B), but on the TUMPA
channel A is dedicated to JTAG/SPI while channel B can be used for
UART/RS-232: use the ftdi_jtag_quirk to expose only channel B as
a usb-serial interface to userspace.
Signed-off-by: Antonio Ospite
---
drivers/usb
68 matches
Mail list logo
