RE: [PATCH v2 1/3] clk: axi-clkgen: remove ARCH dependency in Kconfig

2021-01-27 Thread Ardelean, Alexandru
> -Original Message- > From: Moritz Fischer > Sent: Wednesday, January 27, 2021 4:39 AM > To: Ardelean, Alexandru > Cc: linux-...@vger.kernel.org; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; mturque...@baylibre.com; sb...@kernel.org; >

RE: [PATCH 1/2] clk: axi-clkgen: add support for ZynqMP (UltraScale)

2021-01-12 Thread Ardelean, Alexandru
> -Original Message- > From: Tom Rix > Sent: Thursday, December 24, 2020 4:03 PM > To: Ardelean, Alexandru ; linux- > c...@vger.kernel.org; devicet...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: mturque...@baylibre.com; sb...@kernel.org; robh...@kernel.org;

RE: [PATCH] spi: stm32: update dev_dbg() print format for SPI params

2021-01-04 Thread Ardelean, Alexandru
> -Original Message- > From: Andy Shevchenko > Sent: Monday, January 4, 2021 3:51 PM > To: Ardelean, Alexandru > Cc: linux-spi ; Linux Kernel Mailing List ker...@vger.kernel.org>; Mark Brown ; Stephen Rothwell > > Subject: Re: [PATCH] spi: stm32: update dev_db

RE: linux-next: build warning after merge of the spi tree

2021-01-04 Thread Ardelean, Alexandru
> -Original Message- > From: Stephen Rothwell > Sent: Monday, January 4, 2021 2:07 AM > To: Mark Brown > Cc: Ardelean, Alexandru ; Andy Shevchenko > ; Linux Kernel Mailing List ker...@vger.kernel.org>; Linux Next Mailing List > Subject: linux-next: b

RE: [PATCH v5 2/3] spi: Add SPI_NO_TX/RX support

2020-12-21 Thread Ardelean, Alexandru
> -Original Message- > From: Andy Shevchenko > Sent: Monday, December 21, 2020 4:37 PM > To: Ardelean, Alexandru > Cc: linux-spi ; devicetree > ; Linux Kernel Mailing List ker...@vger.kernel.org>; Bogdan, Dragos ; > Mark Brown ; Rob Herring > Subject:

RE: [PATCH v3 1/4] Input: adp5589-keys - add default platform data

2020-12-08 Thread Ardelean, Alexandru
> -Original Message- > From: Alexandru Ardelean > Sent: Friday, November 27, 2020 1:14 PM > To: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org; > devicet...@vger.kernel.org > Cc: l...@metafoo.de; dmitry.torok...@gmail.com; robh...@kernel.org; > Ardelean,

RE: [PATCH] net: phy: adin: add signal mean square error registers to phy-stats

2020-12-03 Thread Ardelean, Alexandru
> -Original Message- > From: Andrew Lunn > Sent: Thursday, December 3, 2020 4:16 PM > To: Ardelean, Alexandru > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > hkallwe...@gmail.com; li...@armlinux.org.uk; da...@davemloft.net; > k...@kernel.or

RE: [PATCH v3 3/3] spi: dt-bindings: document zero value for spi-{rx,tx}-bus-width properties

2020-12-03 Thread Ardelean, Alexandru
> -Original Message- > From: Andy Shevchenko > Sent: Friday, November 27, 2020 4:26 PM > To: Ardelean, Alexandru > Cc: linux-spi ; devicetree > ; Linux Kernel Mailing List ker...@vger.kernel.org>; Rob Herring ; Mark Brown > ; Bogdan, Dragos > Subject:

RE: [PATCH v3 2/3] spi: Add SPI_NO_TX/RX support

2020-12-03 Thread Ardelean, Alexandru
> -Original Message- > From: Andy Shevchenko > Sent: Friday, November 27, 2020 4:24 PM > To: Ardelean, Alexandru > Cc: linux-spi ; devicetree > ; Linux Kernel Mailing List ker...@vger.kernel.org>; Rob Herring ; Mark Brown > ; Bogdan, Dragos > Subject:

RE: [PATCH v3 1/3] spi: uapi: unify SPI modes into a single spi.h header

2020-12-03 Thread Ardelean, Alexandru
> -Original Message- > From: Andy Shevchenko > Sent: Friday, November 27, 2020 4:13 PM > To: Ardelean, Alexandru > Cc: linux-spi ; devicetree > ; Linux Kernel Mailing List ker...@vger.kernel.org>; Rob Herring ; Mark Brown > ; Bogdan, Dragos > Subject: R

RE: [PATCH v2 3/3] Input: adp5589-keys - add basic devicetree support

2020-11-24 Thread Ardelean, Alexandru
> -Original Message- > From: Lars-Peter Clausen > Sent: Tuesday, November 24, 2020 10:43 AM > To: Ardelean, Alexandru ; linux- > in...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: dmitry.torok...@gmail.com > Subject: Re: [PATCH v2 3/3] Input: adp5589-keys -

RE: [PATCH v2 1/3] spi: convert to BIT() all spi_device flags

2020-11-24 Thread Ardelean, Alexandru
> -Original Message- > From: Andy Shevchenko > Sent: Tuesday, November 24, 2020 1:50 PM > To: kernel test robot > Cc: Ardelean, Alexandru ; linux-spi s...@vger.kernel.org>; devicetree ; Linux Kernel > Mailing List ; kbuild-...@lists.01.org; Mark > Brow

RE: [PATCH v2] uio/uio_pci_generic: remove unneeded pci_set_drvdata()

2020-11-23 Thread Ardelean, Alexandru
> -Original Message- > From: Alexandru Ardelean > Sent: Monday, November 23, 2020 4:35 PM > To: linux-kernel@vger.kernel.org; k...@vger.kernel.org > Cc: m...@redhat.com; gre...@linuxfoundation.org; Ardelean, Alexandru > > Subject: [PATCH v2] uio/uio_pci_gen

RE: [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata()

2020-11-20 Thread Ardelean, Alexandru
> -Original Message- > From: Greg KH > Sent: Friday, November 20, 2020 5:46 PM > To: Ardelean, Alexandru > Cc: linux-kernel@vger.kernel.org > Subject: Re: [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata() > > [External] > > On Thu, No

RE: [PATCH] Input: adp5589-keys - use BIT()

2020-11-19 Thread Ardelean, Alexandru
> -Original Message- > From: Dmitry Torokhov > Sent: Thursday, November 19, 2020 9:25 AM > To: linux-in...@vger.kernel.org > Cc: Ardelean, Alexandru ; linux- > ker...@vger.kernel.org > Subject: [PATCH] Input: adp5589-keys - use BIT() > > [External] > &

RE: [PATCH] Input: adp5589-keys - mark suspend and resume methods as __maybe_unused

2020-11-19 Thread Ardelean, Alexandru
> -Original Message- > From: Dmitry Torokhov > Sent: Thursday, November 19, 2020 9:24 AM > To: linux-in...@vger.kernel.org > Cc: Ardelean, Alexandru ; linux- > ker...@vger.kernel.org > Subject: [PATCH] Input: adp5589-keys - mark suspend and resume method

RE: [PATCH v2] dt-bindings: adau1977: convert text binding to yaml format

2020-11-17 Thread Ardelean, Alexandru
> -Original Message- > From: Mark Brown > Sent: Monday, November 16, 2020 11:19 PM > To: Ardelean, Alexandru > Cc: alsa-de...@alsa-project.org; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; l...@metafoo.de; robh...@kernel.org; > lgirdw...@gmail.com

RE: [PATCH RESEND net-next 18/18] net: phy: adin: remove the use of the .ack_interrupt()

2020-11-13 Thread Ardelean, Alexandru
> -Original Message- > From: Ioana Ciornei > Sent: Friday, November 13, 2020 6:52 PM > To: Andrew Lunn ; Heiner Kallweit ; > Russell King ; Florian Fainelli ; > Jakub Kicinski ; net...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: Ioana Ciorn

RE: [PATCH RESEND net-next 17/18] net: phy: adin: implement generic .handle_interrupt() callback

2020-11-13 Thread Ardelean, Alexandru
> -Original Message- > From: Ioana Ciornei > Sent: Friday, November 13, 2020 6:52 PM > To: Andrew Lunn ; Heiner Kallweit ; > Russell King ; Florian Fainelli ; > Jakub Kicinski ; net...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: Ioana Ciorn

RE: [PATCH 1/6] Input: adp5589: use a single variable for error in probe

2020-11-11 Thread Ardelean, Alexandru
> -Original Message- > From: Ardelean, Alexandru > Sent: Thursday, November 12, 2020 8:40 AM > To: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: RE: [PATCH 1/6] Input: adp5589: use a single variable for

RE: [PATCH 1/6] Input: adp5589: use a single variable for error in probe

2020-11-11 Thread Ardelean, Alexandru
> -Original Message- > From: Dmitry Torokhov > Sent: Thursday, November 12, 2020 2:38 AM > To: Ardelean, Alexandru > Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/6] Input: adp5589: use a single variable for error in >

RE: [PATCH v1] Input: ads7846: do not overwrite spi->mode flags set by spi framework

2020-10-21 Thread Ardelean, Alexandru
> -Original Message- > From: Oleksij Rempel > Sent: Wednesday, October 21, 2020 12:05 PM > To: Dmitry Torokhov ; Ardelean, Alexandru > > Cc: Oleksij Rempel ; ker...@pengutronix.de; linux- > ker...@vger.kernel.org; linux-in...@vger.kernel.org; David Jander &g

RE: [PATCH] ASoC: adau1977: remove platform data and move micbias bindings include

2020-10-19 Thread Ardelean, Alexandru
> -Original Message- > From: Mark Brown > Sent: Monday, October 19, 2020 4:04 PM > To: Ardelean, Alexandru > Cc: linux-kernel@vger.kernel.org; alsa-de...@alsa-project.org; > lgirdw...@gmail.com; l...@metafoo.de; Sa, Nuno ; > pe...@perex.cz; ti...@suse.com > S

RE: [PATCH] dt-bindings: clock: adi,axi-clkgen: convert old binding to yaml format

2020-10-08 Thread Ardelean, Alexandru
> -Original Message- > From: Rob Herring > Sent: Tuesday, October 6, 2020 11:25 PM > To: Ardelean, Alexandru > Cc: linux-...@vger.kernel.org; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; Hennerich, Michael > ; l...@metafoo.de; sb...@

RE: [PATCH] MAINTAINERS: Remove bouncing email of Beniamin Bia

2020-09-01 Thread Ardelean, Alexandru
ust 29, 2020 5:58 PM To: Jonathan Cameron Cc: Andy Shevchenko ; Linux Kernel Mailing List ; Hennerich, Michael ; linux-iio ; Ardelean, Alexandru Subject: Re: [PATCH] MAINTAINERS: Remove bouncing email of Beniamin Bia On Sat, 29 Aug 2020 at 16:54, Jonathan Cameron wrote: (...) > > >

RE: [PATCH 5/6] include: fpga: adi-axi-common.h: add definitions for supported FPGAs

2020-08-06 Thread Ardelean, Alexandru
-Original Message- From: Tom Rix Sent: Wednesday, August 5, 2020 7:02 PM To: Ardelean, Alexandru ; linux-...@vger.kernel.org; linux-f...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: mturque...@baylibre.com; sb...@kernel.org; m...@kernel.org; Caprioru, Mircea Subject: Re: [PATCH

RE: [PATCH] iio: trigger: Staticise stub functions

2020-07-18 Thread Ardelean, Alexandru
. -Original Message- From: Lars-Peter Clausen Sent: Saturday, July 18, 2020 7:37 PM To: Jonathan Cameron ; Ardelean, Alexandru Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: trigger: Staticise stub functions [External] On 7/18/20 6:25 PM, Jonathan Cameron

Re: [PATCH 1/3] iio: Move attach/detach of the poll func to the core

2020-07-14 Thread Ardelean, Alexandru
On Fri, 2020-05-22 at 13:46 +0300, Alexandru Ardelean wrote: > From: Lars-Peter Clausen > > All devices using a triggered buffer need to attach and detach the > trigger > to the device in order to properly work. Instead of doing this in each > and > every driver by hand move this into the core.

Re: [PATCH v4 2/2] iio: adc: ad7192: move ad7192_of_match table closer to the end of the file

2020-07-13 Thread Ardelean, Alexandru
On Wed, 2020-04-15 at 08:58 +0300, Alexandru Ardelean wrote: > The change is more cosmetic. There is no need to reference this table in > the probe function since 'of_device_get_match_data' is used, which > obtains > this information from the driver object. This looks like it could be applied

Re: [PATCH v8 2/6] IIO: Ingenic JZ47xx: Error check clk_enable calls.

2020-07-12 Thread Ardelean, Alexandru
On Sun, 2020-07-12 at 13:02 +0100, Jonathan Cameron wrote: > On Thu, 9 Jul 2020 17:21:56 +0200 > Artur Rojek wrote: > > > Introduce error checks for the clk_enable calls used in this driver. > > As part of the changes, move clk_enable/clk_disable calls out of > > ingenic_adc_set_config and into

Re: [PATCH 1/3] iio: dac: ad5592r: fix unbalanced mutex unlocks in ad5592r_read_raw()

2020-07-06 Thread Ardelean, Alexandru
On Mon, 2020-07-06 at 14:02 +0300, Alexandru Ardelean wrote: > [External] > > There are 2 exit paths where the lock isn't held, but try to unlock the > mutex when exiting. In these places we should just return from the > function. > > A neater approach would be to cleanup the ad5592r_read_raw(),

Re: [PATCH v4 4/7] iio: core: move debugfs data on the private iio dev info

2020-07-02 Thread Ardelean, Alexandru
On Wed, 2020-07-01 at 19:42 +0100, Jonathan Cameron wrote: > [External] > > On Tue, 30 Jun 2020 04:58:06 + > "Ardelean, Alexandru" wrote: > > > On Tue, 2020-06-30 at 07:57 +0300, Alexandru Ardelean wrote: > > > This change moves all iio_dev debugfs

Re: [PATCH] spi: Avoid setting the chip select if we don't need to

2020-07-01 Thread Ardelean, Alexandru
On Mon, 2020-06-29 at 16:41 -0700, Douglas Anderson wrote: > [External] > > On some SPI controllers (like spi-geni-qcom) setting the chip select > is a heavy operation. For instance on spi-geni-qcom, with the current > code, is was measured as taking upwards of 20 us. Even on SPI > controllers

Re: [PATCH v4 4/7] iio: core: move debugfs data on the private iio dev info

2020-06-29 Thread Ardelean, Alexandru
On Tue, 2020-06-30 at 07:57 +0300, Alexandru Ardelean wrote: > This change moves all iio_dev debugfs fields to the iio_dev_priv object. > It's not the biggest advantage yet (to the whole thing of > abstractization) > but it's a start. > > The iio_get_debugfs_dentry() function (which is moved in >

Re: [PATCH v3 2/7] iio: core: wrap IIO device into an iio_dev_opaque object

2020-06-29 Thread Ardelean, Alexandru
On Sat, 2020-06-27 at 17:40 +0100, Jonathan Cameron wrote: > On Sun, 21 Jun 2020 15:33:40 +0300 > Alexandru Ardelean wrote: > > > There are plenty of bad designs we want to discourage or not have to > > review > > manually usually about accessing private (marked as [INTERN]) fields of > >

Re: [PATCH] iio: at91_adc: remove usage of iio_priv_to_dev() helper

2020-06-19 Thread Ardelean, Alexandru
On Sun, 2020-05-31 at 15:42 +0100, Jonathan Cameron wrote: > [External] > > On Mon, 25 May 2020 13:25:13 +0300 > Alexandru Ardelean wrote: > > > We may want to get rid of the iio_priv_to_dev() helper. The reason is > > that > > we will hide some of the members of the iio_dev structure (to

Re: [PATCH v2] iio: stm32-dfsdm-adc: remove usage of iio_priv_to_dev() helper

2020-06-19 Thread Ardelean, Alexandru
On Sun, 2020-05-31 at 15:45 +0100, Jonathan Cameron wrote: > [External] > > On Mon, 25 May 2020 11:26:48 +0300 > Alexandru Ardelean wrote: > > > We may want to get rid of the iio_priv_to_dev() helper. The reason is > > that > > we will hide some of the members of the iio_dev structure (to

Re: [PATCH v2 3/3] iio: remove iio_triggered_buffer_postenable()/iio_triggered_buffer_predisable()

2020-06-18 Thread Ardelean, Alexandru
On Thu, 2020-06-18 at 13:01 +, eugen.hris...@microchip.com wrote: > On 17.06.2020 16:52, Ardelean, Alexandru wrote: > > On Wed, 2020-06-17 at 13:37 +, eugen.hris...@microchip.com wrote: > > > [External] > > > > > > On 02.06.2020 11:54, Jonathan Cameron

Re: [PATCH] iio: at91-sama5d2_adc: remove usage of iio_priv_to_dev() helper

2020-06-18 Thread Ardelean, Alexandru
On Thu, 2020-06-18 at 12:47 +, eugen.hris...@microchip.com wrote: > [External] > > On 17.06.2020 17:02, Ardelean, Alexandru wrote: > > On Wed, 2020-06-17 at 13:25 +, eugen.hris...@microchip.com wrote: > > > On 31.05.2020 17:39, Jonathan Cameron wrote: > > >

Re: [PATCH] iio: at91-sama5d2_adc: remove usage of iio_priv_to_dev() helper

2020-06-17 Thread Ardelean, Alexandru
On Wed, 2020-06-17 at 13:25 +, eugen.hris...@microchip.com wrote: > On 31.05.2020 17:39, Jonathan Cameron wrote: > > > On Mon, 25 May 2020 13:53:41 +0300 > > Alexandru Ardelean wrote: > > > > > We may want to get rid of the iio_priv_to_dev() helper. The reason is that > > > we will hide

Re: [PATCH v2 3/3] iio: remove iio_triggered_buffer_postenable()/iio_triggered_buffer_predisable()

2020-06-17 Thread Ardelean, Alexandru
On Wed, 2020-06-17 at 13:37 +, eugen.hris...@microchip.com wrote: > [External] > > On 02.06.2020 11:54, Jonathan Cameron wrote: > > On Tue, 2 Jun 2020 07:50:23 +0000 > > "Ardelean, Alexandru" wrote: > > > > > On Sun, 2020-05-31 at 16:40 +0100,

Re: [PATCH v2 6/6] iio: remove left-over parent assignments

2020-06-11 Thread Ardelean, Alexandru
On Sat, 2020-06-06 at 17:05 +0100, Jonathan Cameron wrote: > [External] > > On Wed, 3 Jun 2020 14:40:23 +0300 > Alexandru Ardelean wrote: > > > These were found by doing some shell magic: > > > > for file in $(git grep -w devm_iio_device_alloc | cut -d: -f1 | sort | uniq) > > ; do

Re: [PATCH v2 0/6] iio: core: pass parent device as parameter during allocation

2020-06-03 Thread Ardelean, Alexandru
On Wed, 2020-06-03 at 14:40 +0300, Alexandru Ardelean wrote: > This patch updates the {devm_}iio_device_alloc() functions to automatically > assign the parent device on allocation. > For iio_device_alloc() this means a new parameter. > For devm_iio_device_alloc() this means a new behavior; the

Re: [PATCH v3] iio: amplifiers: ad8366: Change devm_gpiod_get() to optional and add the missed check

2020-06-03 Thread Ardelean, Alexandru
On Wed, 2020-06-03 at 17:26 +0800, Chuhong Yuan wrote: > Since if there is no GPIO, nothing happens, replace devm_gpiod_get() > with devm_gpiod_get_optional(). > Also add IS_ERR() to fix the missing-check bug. > Acked-by: Alexandru Ardelean > Fixes: cee211f4e5a0 ("iio: amplifiers: ad8366: Add

Re: [PATCH 4/5] iio: light: lm3533-als: remove explicit parent assignment

2020-06-02 Thread Ardelean, Alexandru
On Sun, 2020-05-31 at 15:54 +0100, Jonathan Cameron wrote: > [External] > > On Fri, 29 May 2020 15:45:33 +0200 > Johan Hovold wrote: > > > [ Trimming CC to something more reasonable... ] > > > > On Fri, May 29, 2020 at 11:08:38AM +, Ardelean, Alexandru wrot

Re: [PATCH v2 3/3] iio: remove iio_triggered_buffer_postenable()/iio_triggered_buffer_predisable()

2020-06-02 Thread Ardelean, Alexandru
On Sun, 2020-05-31 at 16:40 +0100, Jonathan Cameron wrote: > On Mon, 25 May 2020 14:38:55 +0300 > Alexandru Ardelean wrote: > > > From: Lars-Peter Clausen > > > > This patch should be squashed into the first one, as the first one is > > breaking the build (intentionally) to make the IIO core

Re: [PATCH v2] iio: amplifiers: ad8366: Add the missed check for devm_gpiod_get()

2020-05-28 Thread Ardelean, Alexandru
On Thu, 2020-05-28 at 14:40 +0800, Chuhong Yuan wrote: > [External] > > ad8366_probe() forgets to check the return value of devm_gpiod_get(). > Add the missed check to fix it. > > Fixes: cee211f4e5a0 ("iio: amplifiers: ad8366: Add support for the > ADA4961 DGA") > Signed-off-by: Chuhong Yuan >

Re: [PATCH 4/6] iio: dac: ad5686: Constify static struct iio_chan_spec

2020-05-26 Thread Ardelean, Alexandru
On Tue, 2020-05-26 at 23:02 +0200, Rikard Falkeborn wrote: > [External] > > These are never modified and can be made const to allow the compiler to > put it in read-only memory. > > Before: >textdata bss dec hex filename >6642 12608 64 193144b72

Re: [PATCH 3/6] iio: dac: ad5592r-base: Constify struct iio_chan_spec_ext_info

2020-05-26 Thread Ardelean, Alexandru
On Tue, 2020-05-26 at 23:02 +0200, Rikard Falkeborn wrote: > [External] > > ad5592r_ext_info is not modified and can be made const to allow the > compiler to put it in read-only memory. > > Before: >textdata bss dec hex filename > 132932088 256 156373d15

Re: [PATCH 2/6] iio: dac: ad5380: Constify struct iio_chan_spec_ext_info

2020-05-26 Thread Ardelean, Alexandru
On Tue, 2020-05-26 at 23:02 +0200, Rikard Falkeborn wrote: > [External] > > ad5380_ext_info is not modified and can be made const to allow the > compiler to put it in read-only memory. > > Before: >textdata bss dec hex filename > 120603280 192 155323cac

Re: [PATCH v2] iio: stm32-adc: remove usage of iio_priv_to_dev() helper

2020-05-26 Thread Ardelean, Alexandru
On Mon, 2020-05-25 at 18:27 +0200, Fabrice Gasnier wrote: > [External] > > On 5/25/20 11:07 AM, Alexandru Ardelean wrote: > > We may want to get rid of the iio_priv_to_dev() helper. The reason is > > that > > we will hide some of the members of the iio_dev structure (to prevent > > drivers from

Re: [PATCH 3/3] iio: remove iio_triggered_buffer_postenable()/iio_triggered_buffer_predisable()

2020-05-25 Thread Ardelean, Alexandru
On Sun, 2020-05-24 at 14:38 +0100, Jonathan Cameron wrote: > [External] > > On Fri, 22 May 2020 13:46:32 +0300 > Alexandru Ardelean wrote: > > > From: Lars-Peter Clausen > > > > This patch should be squashed into the first one, as the first one is > > breaking the build (intentionally) to

Re: [RFC PATCH 09/14] iio: buffer: split buffer sysfs creation to take buffer as primary arg

2020-05-25 Thread Ardelean, Alexandru
On Sun, 2020-05-24 at 17:49 +0100, Jonathan Cameron wrote: > [External] > > On Fri, 8 May 2020 16:53:43 +0300 > Alexandru Ardelean wrote: > > > Currently the iio_buffer_{alloc,free}_sysfs_and_mask() take 'indio_dev' as > > primary argument. This change converts to take an IIO buffer as a

Re: [RFC PATCH 08/14] iio: core: use new common ioctl() mechanism

2020-05-25 Thread Ardelean, Alexandru
On Sun, 2020-05-24 at 17:47 +0100, Jonathan Cameron wrote: > [External] > > On Fri, 8 May 2020 16:53:42 +0300 > Alexandru Ardelean wrote: > > > This change makes use of the new centralized ioctl() mechanism. The event > > interface registers it's ioctl() handler to IIO device. > > Both the

Re: [RFC PATCH 07/14] iio: core: add simple centralized mechanism for ioctl() handlers

2020-05-25 Thread Ardelean, Alexandru
On Sun, 2020-05-24 at 17:45 +0100, Jonathan Cameron wrote: > [External] > > On Fri, 8 May 2020 16:53:41 +0300 > Alexandru Ardelean wrote: > > > The aim of this is to reduce the organization violation of ioctl() calls in > > IIO core. Currently, since the chardev is split across files, event

Re: [PATCH] iio: humidity: hts221: remove usage of iio_priv_to_dev()

2020-05-25 Thread Ardelean, Alexandru
On Sun, 2020-05-24 at 15:39 +0100, Jonathan Cameron wrote: > [External] > > On Fri, 22 May 2020 09:56:16 +0300 > Alexandru Ardelean wrote: > > > We may want to get rid of the iio_priv_to_dev() helper. That's a bit > > uncertain at this point. The reason is that we will hide some of the > >

Re: [PATCH v2 0/8] iio: core: wrap IIO device into an iio_dev_opaque object

2020-05-22 Thread Ardelean, Alexandru
On Thu, 2020-05-14 at 16:17 +0300, Alexandru Ardelean wrote: > This change starts to hide some internal fields of the IIO device into > the framework. > > Because the iio_priv_to_dev() will be hidden some pre-work is done to > try to remove it from some interrupt handlers. > iio_priv_to_dev()

Re: [PATCH] iio: dac: ad5592r-base: Replace indio_dev->mlock with own device lock

2020-05-20 Thread Ardelean, Alexandru
On Wed, 2020-05-20 at 09:18 +0300, Sergiu Cuciurean wrote: > [External] > > As part of the general cleanup of indio_dev->mlock, this change replaces > it with a local lock on the device's state structure. > This requires a V2. It produces a warning: 159 | struct iio_dev *iio_dev =

Re: [PATCH v2 3/8] iio: at91_adc: pass ref to IIO device via param for int function

2020-05-18 Thread Ardelean, Alexandru
On Sat, 2020-05-16 at 18:17 +0100, Jonathan Cameron wrote: > [External] > > On Thu, 14 May 2020 16:17:05 +0300 > Alexandru Ardelean wrote: > > > Since there will be some changes to how iio_priv_to_dev() is implemented, > > it could be that the helper becomes a bit slower, as it will be hidden

Re: [PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object

2020-05-18 Thread Ardelean, Alexandru
On Sat, 2020-05-16 at 17:29 +0100, Jonathan Cameron wrote: > [External] > > On Tue, 12 May 2020 11:26:08 + > "Ardelean, Alexandru" wrote: > > > On Mon, 2020-05-11 at 18:42 +0100, Jonathan Cameron wrote: > > > [External] > > > > &g

Re: [RFC PATCH 00/14] iio: buffer: add support for multiple buffers

2020-05-17 Thread Ardelean, Alexandru
On Sat, 2020-05-16 at 17:24 +0100, Jonathan Cameron wrote: > [External] > > On Sat, 16 May 2020 13:08:46 + > "Ardelean, Alexandru" wrote: > > > On Tue, 2020-05-12 at 06:26 +, Ardelean, Alexandru wrote: > > > [External] > > > > >

Re: [RFC PATCH 00/14] iio: buffer: add support for multiple buffers

2020-05-16 Thread Ardelean, Alexandru
On Tue, 2020-05-12 at 06:26 +, Ardelean, Alexandru wrote: > [External] > > On Mon, 2020-05-11 at 21:56 +0200, Lars-Peter Clausen wrote: > > [External] > > > > On 5/11/20 4:56 PM, Ardelean, Alexandru wrote: > > > On Mon, 2020-05-11 at 15:58 +0200, Lars-Pe

Re: [PATCH v2 7/8] iio: core: simplify alloc alignment code

2020-05-15 Thread Ardelean, Alexandru
..@st.com; > > mcoquelin.st...@gmail.com; a...@it-klinger.de; Ardelean, Alexandru > > > > Subject: [PATCH v2 7/8] iio: core: simplify alloc alignment code > > > > There was a recent discussion about this code: > > https://urldefense.com/v3/__https://

Re: [PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object

2020-05-12 Thread Ardelean, Alexandru
On Mon, 2020-05-11 at 18:42 +0100, Jonathan Cameron wrote: > [External] > > On Mon, 11 May 2020 09:16:32 + > "Ardelean, Alexandru" wrote: > > > On Fri, 2020-05-08 at 16:44 +0100, Jonathan Cameron wrote: > > > [External] > > > > > >

Re: [RFC PATCH 00/14] iio: buffer: add support for multiple buffers

2020-05-12 Thread Ardelean, Alexandru
On Mon, 2020-05-11 at 21:56 +0200, Lars-Peter Clausen wrote: > [External] > > On 5/11/20 4:56 PM, Ardelean, Alexandru wrote: > > On Mon, 2020-05-11 at 15:58 +0200, Lars-Peter Clausen wrote: > > > [External] > > > > > > On 5/11/20 3:24 PM, Ardelean, A

Re: [RFC PATCH 00/14] iio: buffer: add support for multiple buffers

2020-05-11 Thread Ardelean, Alexandru
On Mon, 2020-05-11 at 15:58 +0200, Lars-Peter Clausen wrote: > [External] > > On 5/11/20 3:24 PM, Ardelean, Alexandru wrote: > > On Mon, 2020-05-11 at 13:03 +0000, Ardelean, Alexandru wrote: > > > [External] > > > > > > On Mon, 2020-05-1

Re: [RFC PATCH 00/14] iio: buffer: add support for multiple buffers

2020-05-11 Thread Ardelean, Alexandru
On Mon, 2020-05-11 at 13:03 +, Ardelean, Alexandru wrote: > [External] > > On Mon, 2020-05-11 at 12:37 +0200, Lars-Peter Clausen wrote: > > [External] > > > > On 5/11/20 12:33 PM, Ardelean, Alexandru wrote: > > > On Sun, 2020-05-10 at 11:09 +0100, Jonat

Re: [RFC PATCH 00/14] iio: buffer: add support for multiple buffers

2020-05-11 Thread Ardelean, Alexandru
On Mon, 2020-05-11 at 12:37 +0200, Lars-Peter Clausen wrote: > [External] > > On 5/11/20 12:33 PM, Ardelean, Alexandru wrote: > > On Sun, 2020-05-10 at 11:09 +0100, Jonathan Cameron wrote: > > > [External] > > > > > > On Sat, 9 May 2020 10:5

Re: [RFC PATCH 00/14] iio: buffer: add support for multiple buffers

2020-05-11 Thread Ardelean, Alexandru
On Sun, 2020-05-10 at 11:09 +0100, Jonathan Cameron wrote: > [External] > > On Sat, 9 May 2020 10:52:14 +0200 > Lars-Peter Clausen wrote: > > > On 5/8/20 3:53 PM, Alexandru Ardelean wrote: > > > [...] > > > What I don't like, is that iio:device3 has iio:buffer3:0 (to 3). > > > This is because

Re: [PATCH] iio: buffer: rework buffer attr read-only stat-flags with 'is_visible' hook

2020-05-11 Thread Ardelean, Alexandru
On Thu, 2020-04-16 at 17:31 +0300, Alexandru Ardelean wrote: > [External] > > The kernel provides a facility for attribute groups to specify the stat > flags of a sysfs file with an 'is_visible()' hook. This mechanism is > usually more flexible than assigning read-only attributes at construction

Re: [PATCH 1/3] iio: core: wrap IIO device into a iio_dev_priv object

2020-05-11 Thread Ardelean, Alexandru
On Fri, 2020-05-08 at 16:44 +0100, Jonathan Cameron wrote: > [External] > > On Fri, 8 May 2020 16:40:15 +0100 > Jonathan Cameron wrote: > > > On Fri, 8 May 2020 17:13:04 +0300 > > Alexandru Ardelean wrote: > > > > > There are plenty of bad designs we want to discourage or not have to > > >

Re: [PATCH v6 0/6] iio: core,buffer: re-organize chardev creation

2020-05-06 Thread Ardelean, Alexandru
On Sun, 2020-05-03 at 16:51 +0100, Jonathan Cameron wrote: > [External] > > On Mon, 27 Apr 2020 16:10:54 +0300 > Alexandru Ardelean wrote: > > > The main intent is to be able to add more chardevs per IIO device, one > > for each buffer. To get there, some rework is needed. > > This tries to

Re: [PATCH] iio: adc: ad7476: fix clang -Wpointer-bool-conversion warning

2020-05-05 Thread Ardelean, Alexandru
On Tue, 2020-05-05 at 16:23 +0200, Arnd Bergmann wrote: > [External] > > Checking the pointer value of st->chip_info->convst_channel is pointless > since this this an array inside of a struct: even if st->chip_info is NULL, > the pointer is non-zero. Clang warns about this: > >

Re: [PATCH v6 3/6] iio: core: register chardev only if needed

2020-05-04 Thread Ardelean, Alexandru
On Sun, 2020-05-03 at 16:39 +0100, Jonathan Cameron wrote: > [External] > > On Mon, 27 Apr 2020 16:10:57 +0300 > Alexandru Ardelean wrote: > > > The final intent is to localize all buffer ops into the > > industrialio-buffer.c file, to be able to add support for multiple buffers > > per IIO

Re: [PATCH v2 1/2] iio: Move scan mask management to the core

2020-05-04 Thread Ardelean, Alexandru
On Sun, 2020-05-03 at 13:51 +0100, Jonathan Cameron wrote: > On Wed, 29 Apr 2020 18:17:39 +0300 > Alexandru Ardelean wrote: > > > From: Lars-Peter Clausen > > > > Let the core handle the buffer scan mask management including allocation > > and channel selection. Having this handled in a

Re: [PATCH] staging: iio: ad2s1210: Fix SPI reading

2020-05-04 Thread Ardelean, Alexandru
On Sun, 2020-05-03 at 12:37 +0100, Jonathan Cameron wrote: > [External] > > On Wed, 29 Apr 2020 10:21:29 +0300 > Alexandru Ardelean wrote: > > > From: Dragos Bogdan > > > > If the serial interface is used, the 8-bit address should be latched using > > the rising edge of the WR/FSYNC signal. >

Re: [PATCH] staging: iio: ad5933: rework probe to use devm_ function variants

2020-05-03 Thread Ardelean, Alexandru
On Sat, 2020-05-02 at 19:25 +0100, Jonathan Cameron wrote: > On Tue, 28 Apr 2020 12:31:28 +0300 > Alexandru Ardelean wrote: > > > This change cleans up the driver's probe function to use only devm_ > > function variants. This also gets rid of the remove function and moves the > > clock &

Re: [PATCH] iio: remove iio_get_debugfs_dentry() helper

2020-04-30 Thread Ardelean, Alexandru
On Thu, 2020-04-30 at 11:52 +0300, Alexandru Ardelean wrote: > Not used anywhere. > Looks like it was forgotten in iio.h > Actually, disregard this. I've found places where 'indio_dev->debugfs_dentry' is accessed directly and that should have used this instead. Apologies for the spam. >

Re: [PATCH v2 1/2] iio: at91-sama5d2_adc: split at91_adc_current_chan_is_touch() helper

2020-04-30 Thread Ardelean, Alexandru
On Thu, 2020-04-30 at 07:30 +, Ardelean, Alexandru wrote: > On Mon, 2020-04-27 at 13:00 +0000, Ardelean, Alexandru wrote: > > [External] > > > > On Mon, 2020-04-27 at 12:20 +, eugen.hris...@microchip.com wrote: > > > [External] > > > > > >

Re: [PATCH v2 1/2] iio: at91-sama5d2_adc: split at91_adc_current_chan_is_touch() helper

2020-04-30 Thread Ardelean, Alexandru
On Mon, 2020-04-27 at 13:00 +, Ardelean, Alexandru wrote: > [External] > > On Mon, 2020-04-27 at 12:20 +, eugen.hris...@microchip.com wrote: > > [External] > > > > On 15.04.2020 09:33, Ardelean, Alexandru wrote: > > > > > On Tue, 2020-04

Re: [PATCH] staging: iio: ad9834: add a check for devm_clk_get

2019-10-17 Thread Ardelean, Alexandru
On Wed, 2019-10-16 at 22:25 +0800, Chuhong Yuan wrote: > ad9834_probe misses a check for devm_clk_get and may cause problems. > Add a check like what ad9832 does to fix it. > This could also use a Fixes tag, but not a big deal. Reviewed-by: Alexandru Ardelean > Signed-off-by: Chuhong Yuan >

Re: [PATCH] dmaengine: axi-dmac: simple device_config operation implemented

2019-10-16 Thread Ardelean, Alexandru
On Wed, 2019-10-16 at 10:38 +0530, Vinod Koul wrote: > [External] > > On 15-10-19, 23:06, Lars-Peter Clausen wrote: > > > > > This DMA controller is a bit special. > > > > It gets synthesized in FPGA, so the configuration is fixed and > > > > cannot be > > > > changed at runtime. Maybe later we

Re: [PATCH] dmaengine: axi-dmac: simple device_config operation implemented

2019-10-15 Thread Ardelean, Alexandru
On Mon, 2019-10-14 at 12:31 +0530, Vinod Koul wrote: > [External] > Hey, > On 13-09-19, 17:54, Alexandru Ardelean wrote: > > From: Rodrigo Alencar > > > > dmaengine_slave_config is called by dmaengine_pcm_hw_params when using > > axi-i2s with axi-dmac. If device_config is NULL, -ENOSYS is

Re: [PATCH 2/2] iio: light: Add support for ADUX1020 sensor

2019-10-09 Thread Ardelean, Alexandru
On Wed, 2019-10-09 at 15:15 +0530, Manivannan Sadhasivam wrote: > [External] > > Hi Ardelean, > > Thanks for the quick review! > > On Tue, Oct 08, 2019 at 06:52:50AM +, Ardelean, Alexandru wrote: > > On Mon, 2019-10-07 at 15:40 +0530, Manivannan Sadhas

Re: [PATCH 02/10] iio: imu: adis: add unlocked read/write function versions

2019-10-08 Thread Ardelean, Alexandru
On Tue, 2019-10-08 at 08:47 +, Ardelean, Alexandru wrote: > [External] > > On Tue, 2019-10-08 at 06:54 +, Ardelean, Alexandru wrote: > > [External] > > > > On Mon, 2019-10-07 at 22:16 +0100, Jonathan Cameron wrote: > > > On Sun, 6 Oct 2019 10:12:01

Re: [PATCH 02/10] iio: imu: adis: add unlocked read/write function versions

2019-10-08 Thread Ardelean, Alexandru
On Tue, 2019-10-08 at 06:54 +, Ardelean, Alexandru wrote: > [External] > > On Mon, 2019-10-07 at 22:16 +0100, Jonathan Cameron wrote: > > On Sun, 6 Oct 2019 10:12:01 +0100 > > Jonathan Cameron wrote: > > > > > On Thu, 26 Sep 2019 14:18:04 +

Re: [PATCH 02/10] iio: imu: adis: add unlocked read/write function versions

2019-10-08 Thread Ardelean, Alexandru
On Mon, 2019-10-07 at 22:16 +0100, Jonathan Cameron wrote: > On Sun, 6 Oct 2019 10:12:01 +0100 > Jonathan Cameron wrote: > > > On Thu, 26 Sep 2019 14:18:04 +0300 > > Alexandru Ardelean wrote: > > > > > This will allow more flexible control to group reads & writes into a > > > single > > > lock

Re: [PATCH 2/2] iio: light: Add support for ADUX1020 sensor

2019-10-08 Thread Ardelean, Alexandru
On Mon, 2019-10-07 at 15:40 +0530, Manivannan Sadhasivam wrote: > [External] > Hey, Comments inline. I thought I sent an initial review, but seems to have gotten lost [maybe in my email client]. Oh well. I managed to re-do it anyway. I tried to group them this time. The more prominent part

Re: [PATCH 1/2] dt-bindings: iio: light: Add binding for ADUX1020

2019-10-07 Thread Ardelean, Alexandru
On Mon, 2019-10-07 at 18:10 +0530, Manivannan Sadhasivam wrote: > [External] > > Hi Ardelean, > > On 7 October 2019 3:51:16 PM IST, "Ardelean, Alexandru" < > alexandru.ardel...@analog.com> wrote: > > On Mon, 2019-10-07 at 15:40 +0530, Mani

Re: [PATCH 1/2] dt-bindings: iio: light: Add binding for ADUX1020

2019-10-07 Thread Ardelean, Alexandru
On Mon, 2019-10-07 at 15:40 +0530, Manivannan Sadhasivam wrote: > [External] > > Add devicetree binding for Analog Devices ADUX1020 Photometric > sensor. > Hey, Thanks for the patches. This dt-binding docs is in text format. dt-binding docs now need to be in YAML format. Also, patches for

Re: [PATCH 01/10] iio: imu: adis: rename txrx_lock -> state_lock

2019-10-07 Thread Ardelean, Alexandru
On Sun, 2019-10-06 at 10:06 +0100, Jonathan Cameron wrote: > [External] > > On Sun, 6 Oct 2019 09:53:33 +0100 > Jonathan Cameron wrote: > > > On Thu, 26 Sep 2019 14:18:03 +0300 > > Alexandru Ardelean wrote: > > > > > The lock can be extended a bit to protect other elements that are not > > >

Re: [PATCH] iio: imu: adis16480: clean up a condition

2019-09-26 Thread Ardelean, Alexandru
On Thu, 2019-09-26 at 11:10 +0300, Dan Carpenter wrote: > [External] > > The "t" variable is unsigned so it can't be less than zero. We really > are just trying to prevent divide by zero bugs so just checking against > zero is sufficient. > > Signed-off-by: Dan Carpenter > --- >

Re: [EXT] [PATCH v3] serial: imx: adapt rx buffer and dma periods

2019-09-26 Thread Ardelean, Alexandru
On Wed, 2019-09-25 at 10:14 -0500, Adam Ford wrote: > [External] > > On Fri, Sep 20, 2019 at 2:06 AM Philipp Puschmann > wrote: > > Hi Andy, > > > > Am 20.09.19 um 05:42 schrieb Andy Duan: > > > From: Philipp Puschmann Sent: Thursday, > > > September 19, 2019 10:51 PM > > > > Using only 4 DMA

Re: [PATCH v2] iio: imu: adis16400: fix memory leak

2019-09-20 Thread Ardelean, Alexandru
On Thu, 2019-09-19 at 10:56 -0500, Navid Emamdoost wrote: > In adis_update_scan_mode_burst, if adis->buffer allocation fails release > the adis->xfer. > > v2: set adis->xfer = NULL to avoid any potential double free. > Reviewed-by: Alexandru Ardelean > Signed-off-by: Navid Emamdoost > --- >

Re: [PATCH v2] iio: imu: adis16400: release allocated memory on failure

2019-09-20 Thread Ardelean, Alexandru
On Thu, 2019-09-19 at 10:50 -0500, Navid Emamdoost wrote: > In adis_update_scan_mode, if allocation for adis->buffer fails, > previously allocated adis->xfer needs to be released. > > v2: added adis->xfer = NULL to avoid any potential double free. Reviewed-by: Alexandru Ardelean >

Re: [PATCH] iio: imu: adis16400: fix memory leak

2019-09-19 Thread Ardelean, Alexandru
On Wed, 2019-09-18 at 12:03 -0500, Navid Emamdoost wrote: > [External] > Hey, Thanks for this patch as well. Comments inline here as well. > In adis_update_scan_mode_burst, if adis->buffer allocation fails release > the adis->xfer. > > Signed-off-by: Navid Emamdoost > --- >

Re: [PATCH] iio: imu: adis16400: release allocated memory on failure

2019-09-19 Thread Ardelean, Alexandru
On Wed, 2019-09-18 at 11:57 -0500, Navid Emamdoost wrote: > [External] > Hey, Good catch. One comment inline. > In adis_update_scan_mode, if allocation for adis->buffer fails, > previously allocated adis->xfer needs to be released. > > Signed-off-by: Navid Emamdoost > --- >

Re: [PATCH] dt-bindings: net: dwmac: fix 'mac-mode' type

2019-09-17 Thread Ardelean, Alexandru
On Tue, 2019-09-17 at 14:41 +0200, Andrew Lunn wrote: > [External] > > On Tue, Sep 17, 2019 at 01:30:52PM +0300, Alexandru Ardelean wrote: > > The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type', > > which are enums of mode strings. > > > > The 'dwmac' driver supports

Re: [PATCH 2/2] dt-bindings: net: dwmac: document 'mac-mode' property

2019-09-17 Thread Ardelean, Alexandru
On Mon, 2019-09-16 at 12:49 +0300, Alexandru Ardelean wrote: > On Fri, 2019-09-13 at 15:36 +0100, Rob Herring wrote: > > [External] > > > > On Fri, Sep 06, 2019 at 04:02:56PM +0300, Alexandru Ardelean wrote: > > > This change documents the 'mac-mode' property that was introduced in > > > the > >

Re: [RFC PATCH 03/15] spi: make `cs_change_delay` the first user of the `spi_delay` logic

2019-09-17 Thread Ardelean, Alexandru
On Mon, 2019-09-16 at 14:43 +0100, Mark Brown wrote: > [External] > > On Mon, Sep 16, 2019 at 01:04:42PM +, Ardelean, Alexandru wrote: > > On Mon, 2019-09-16 at 13:47 +0100, Mark Brown wrote: > > > That v3 seems to be a small subset of this series? > > Ack. >

  1   2   3   >