On Mon, Sep 09, 2019 at 05:48:25PM +0800, Xin Long wrote:
> On Fri, Aug 23, 2019 at 3:58 PM Bharath Vedartham
> wrote:
> >
> > Hi all,
> >
> > I just want to bring attention to the syzbot bug [1]
> >
> > Even though syzbot claims the bug to be in net
Hi Nitin,
On Wed, Sep 11, 2019 at 10:33:39PM +, Nitin Gupta wrote:
> On Wed, 2019-09-11 at 08:45 +0200, Michal Hocko wrote:
> > On Tue 10-09-19 22:27:53, Nitin Gupta wrote:
> > [...]
> > > > On Tue 10-09-19 13:07:32, Nitin Gupta wrote:
> > > > > For some applications we need to allocate almost
Built and booted on my x86 machine. No dmesg regressions found.
Thank you
Bharath
Built and booted on my x86 machine. NO dmesg regressions found.
Thank you
Bharath
Built and booted on my x86 machine. No dmesg regressions found.
Thank you
Bharath
Built and booted on my x86 arch machine. No dmesg regressions found.
Thank you
Bharath
Hi Michal, Thank you for spending your time on this.
On Tue, Aug 27, 2019 at 08:16:06AM +0200, Michal Hocko wrote:
> On Tue 27-08-19 02:14:20, Bharath Vedartham wrote:
> > Hi Michal,
> >
> > Here are some of my thoughts,
> > On Wed, Aug 21, 2019 at 04:06:32P
Hi Michal,
Here are some of my thoughts,
On Wed, Aug 21, 2019 at 04:06:32PM +0200, Michal Hocko wrote:
> On Thu 15-08-19 14:51:04, Khalid Aziz wrote:
> > Hi Michal,
> >
> > The smarts for tuning these knobs can be implemented in userspace and
> > more knobs added to allow for what is missing
Hi all,
I just want to bring attention to the syzbot bug [1]
Even though syzbot claims the bug to be in net/tipc, I feel it is in
net/dst_cache.c. Please correct me if I am wrong.
This bug is being triggered a lot of times by syzbot since the day it
was reported. Also given that this is core
On Mon, Aug 19, 2019 at 12:30:18PM -0700, John Hubbard wrote:
> On 8/19/19 12:06 PM, Bharath Vedartham wrote:
> >On Mon, Aug 19, 2019 at 07:56:11AM -0500, Dimitri Sivanich wrote:
> >>Reviewed-by: Dimitri Sivanich
> >Thanks!
> >
> >John, would you like to tak
context at all. The only
> code that deals with host interrupts in a virtualization host is in VFIO,
> but all it needs to do is signal an eventfd.
>
> Paolo
Great, answers my question. Thank you for your time.
Thank you
Bharath
>
> Il gio 15 ago 2019, 19:18 Bharath Vedartham
On Mon, Aug 19, 2019 at 07:56:11AM -0500, Dimitri Sivanich wrote:
> Reviewed-by: Dimitri Sivanich
Thanks!
John, would you like to take this patch into your miscellaneous
conversions patch set?
Thank you
Bharath
> On Mon, Aug 19, 2019 at 01:08:54AM +0530, Bharath Vedartham wrote:
> &g
On Mon, Aug 19, 2019 at 08:00:57AM -0500, Dimitri Sivanich wrote:
> Reviewed-by: Dimitri Sivanich
Thanks!
> On Mon, Aug 19, 2019 at 01:08:55AM +0530, Bharath Vedartham wrote:
> > is_vm_hugetlb_page will always return false if CONFIG_HUGETLB_PAGE is
> > not set.
> >
&
On Mon, Aug 19, 2019 at 01:08:53AM +0530, Bharath Vedartham wrote:
CC'ing lkml, the mail id was wrong.
> This version only converts put_page to put_user_page and removes
> an unecessary ifdef.
>
> It does not convert atomic_pte_lookup to __get_user_pages as
> gru_vtop could run
CC'ing lkml.
On Mon, Aug 19, 2019 at 01:08:54AM +0530, Bharath Vedartham wrote:
> For pages that were retained via get_user_pages*(), release those pages
> via the new put_user_page*() routines, instead of via put_page() or
> release_pages().
>
> This is part a tree-wide conversio
CC'ing lkml.
On Mon, Aug 19, 2019 at 01:08:55AM +0530, Bharath Vedartham wrote:
> is_vm_hugetlb_page will always return false if CONFIG_HUGETLB_PAGE is
> not set.
>
> Cc: Ira Weiny
> Cc: John Hubbard
> Cc: Jérôme Glisse
> Cc: Greg Kroah-Hartman
> Cc: Dimitri Sivan
Cc: linux-kernel-ment...@lists.linuxfoundation.org
Reviewed-by: Ira Weiny
Reviewed-by: John Hubbard
Reviewed-by: William Kucharski
Signed-off-by: Bharath Vedartham
---
drivers/misc/sgi-gru/grufault.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git
Reviewed-by: John Hubbard
Reviewed-by: William Kucharski
Signed-off-by: Bharath Vedartham
---
drivers/misc/sgi-gru/grufault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/sgi-gru/grufault.c b/drivers/misc/sgi-gru/grufault.c
index 4b713a8..61b3447 100644
--- a/dr
.
Thank you
Bharath
On Sat, Aug 10, 2019 at 01:08:17AM +0530, Bharath Vedartham wrote:
> For pages that were retained via get_user_pages*(), release those pages
> via the new put_user_page*() routines, instead of via put_page() or
> release_pages().
>
> This is part a tree-
On Tue, Aug 13, 2019 at 10:17:09PM +0200, Paolo Bonzini wrote:
> On 13/08/19 21:14, Bharath Vedartham wrote:
> > Hi all,
> >
> > I was looking at the function hva_to_pfn_fast(in virt/kvm/kvm_main) which
> > is
> > executed in an atomic context(
On Wed, Aug 14, 2019 at 02:38:30PM -0300, Jason Gunthorpe wrote:
> On Wed, Aug 14, 2019 at 11:00:34PM +0530, Bharath Vedartham wrote:
> > On Tue, Aug 13, 2019 at 01:19:38PM -0500, Dimitri Sivanich wrote:
> > > On Tue, Aug 13, 2019 at 10:53:01PM +0530, Bharath Vedartham wrote:
&
On Tue, Aug 13, 2019 at 01:19:38PM -0500, Dimitri Sivanich wrote:
> On Tue, Aug 13, 2019 at 10:53:01PM +0530, Bharath Vedartham wrote:
> > On Tue, Aug 13, 2019 at 09:50:29AM -0500, Dimitri Sivanich wrote:
> > > Bharath,
> > >
> > > I do not believe
Hi all,
I was looking at the function hva_to_pfn_fast(in virt/kvm/kvm_main) which is
executed in an atomic context(even in non-atomic context, since
hva_to_pfn_fast is much faster than hva_to_pfn_slow).
My question is can this be executed in an interrupt context?
The motivation for this
in get_user_pages_remote?
Thank you
Bharath
> On Sat, Aug 10, 2019 at 01:08:17AM +0530, Bharath Vedartham wrote:
> > For pages that were retained via get_user_pages*(), release those pages
> > via the new put_user_page*() routines, instead of via put_page() or
> > release
.
There is nothing different in this series compared to the v2
series, It essentially compresses the 3 patches of the original series
into one patch.
This series survives a compile test.
Bharath Vedartham (1):
sgi-gru: Remove *pte_lookup functions
drivers/misc/sgi-gru/grufault.c | 112
harski
Cc: Christoph Hellwig
Cc: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org
Cc: linux-kernel-ment...@lists.linuxfoundation.org
Reviewed-by: Ira Weiny
Reviewed-by: John Hubbard
Reviewed-by: William Kucharski
Signed-off-by: Bharath Vedartham
---
This is a fold of the 3 patches in the v2 pa
On Thu, Aug 08, 2019 at 04:21:44PM -0700, John Hubbard wrote:
> On 8/8/19 11:55 AM, Bharath Vedartham wrote:
> ...
> > static int gru_vtop(struct gru_thread_state *gts, unsigned long vaddr,
> > int write, int atomic, unsigned long *gpa, int *pageshift)
>
On Thu, Aug 08, 2019 at 04:30:48PM -0700, John Hubbard wrote:
> On 8/8/19 4:21 PM, John Hubbard wrote:
> > On 8/8/19 11:55 AM, Bharath Vedartham wrote:
> > ...
> >>if (is_gru_paddr(paddr))
> >>goto inval;
> >> - paddr = paddr & ~((1
On Thu, Aug 08, 2019 at 04:21:44PM -0700, John Hubbard wrote:
> On 8/8/19 11:55 AM, Bharath Vedartham wrote:
> ...
> > static int gru_vtop(struct gru_thread_state *gts, unsigned long vaddr,
> > int write, int atomic, unsigned long *gpa, int *pageshift)
>
Hellwig
Cc: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org
Cc: linux-kernel-ment...@lists.linuxfoundation.org
Reviewed-by: Ira Weiny
Reviewed-by: John Hubbard
Reviewed-by: William Kucharski
Signed-off-by: Bharath Vedartham
---
This is a fold of the 3 patches in the v2 patch series
.
There is nothing different in this series compared to the previous
series, It essentially compresses the 3 patches of the original series
into one patch.
This series survives a compile test.
Bharath Vedartham (1):
sgi-gru: Remove *pte_lookup functions
drivers/misc/sgi-gru/grufault.c | 112
Hellwig
Cc: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org
Cc: linux-kernel-ment...@lists.linuxfoundation.org
Reviewed-by: Ira Weiny
Reviewed-by: John Hubbard
Reviewed-by: William Kucharski
Signed-off-by: Bharath Vedartham
---
This is a fold of the 3 patches in the v2 patch series
.
There is nothing different in this series compared to the previous
series, It essentially compresses the 3 patches of the original series
into one patch.
Bharath Vedartham (1):
sgi-gru: Remove *pte_lookup functions
drivers/misc/sgi-gru/grufault.c | 112 +---
1 file
On Mon, Jul 29, 2019 at 08:48:42AM +0200, Christoph Hellwig wrote:
> On Sat, Jul 27, 2019 at 01:12:00AM +0530, Bharath Vedartham wrote:
> > + ret = get_user_pages_fast(vaddr, 1, write, );
>
> I think you want to pass "write ? FOLL_WRITE : 0" here, as
&g
On Tue, Jul 30, 2019 at 11:36:06AM +0200, Greg KH wrote:
> On Tue, Jul 30, 2019 at 02:58:44PM +0530, Bharath Vedartham wrote:
> > put_page() to put_user_page*()
>
> What does this mean?
That must have been a mistake! I just wanted to forward this patch to
the Linux-kernel-mente
put_page() to put_user_page*()
Reply-To:
In-Reply-To: <1564058658-3551-1-git-send-email-linux.b...@gmail.com>
On Thu, Jul 25, 2019 at 06:14:18PM +0530, Bharath Vedartham wrote:
[Forwarding patch to linux-kernel-mentees mailing list]
> For pages that were retained via get_user_pages*()
On Sat, Jul 27, 2019 at 05:22:28PM +0800, Hillf Danton wrote:
>
> On Fri, 26 Jul 2019 12:42:26 -0700 (PDT) Bharath Vedartham wrote:
> >
> > static int gru_vtop(struct gru_thread_state *gts, unsigned long vaddr,
> > int write, int atomic, unsigned l
.
There is nothing different in this series compared to the previous
series, It essentially compresses the 3 patches of the original series
into one patch.
Bharath Vedartham (1):
sgi-gru: Remove *pte_lookup functions
drivers/misc/sgi-gru/grufault.c | 114
Hellwig
Cc: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org
Reviewed-by: Ira Weiny
Reviewed-by: John Hubbard
Reviewed-by: William Kucharski
Signed-off-by: Bharath Vedartham
---
This is a fold of the 3 patches in the previous patch series.
The review tags were given to the individual patches
Built and booted on my x86_64 test system. No dmesg regressions.
Thank you
Bharath
Built and booted on my x86_64 test system. No dmesg regressions.
Thank you
Bharath
Built and booted on my x86_64 system. No dmesg regressions.
Thank you
Bharath
Cc: John Hubbard
Cc: Jérôme Glisse
Cc: Greg Kroah-Hartman
Cc: Matt Sickler
Cc: de...@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org
Reviewed-by: John Hubbard
Signed-off-by: Bharath Vedartham
---
Changes since v1
- Improved changelog by John's
On Thu, Jul 25, 2019 at 09:46:34AM +0200, Greg KH wrote:
> On Sat, Jul 20, 2019 at 11:02:14PM +0530, Bharath Vedartham wrote:
> > For pages that were retained via get_user_pages*(), release those pages
> > via the new put_user_page*() routines, instead of via put_page().
> &
On Wed, Jul 24, 2019 at 09:09:29AM -0700, Christoph Hellwig wrote:
> I think the atomic_pte_lookup / non_atomic_pte_lookup helpers
> should simply go away. Most of the setup code is common now and should
> be in the caller where it can be shared. Then just do a:
>
> if (atomic) {
>
Sivanich
Cc: Arnd Bergmann
Cc: William Kucharski
Cc: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org
Reviewed-by: Ira Weiny
Signed-off-by: Bharath Vedartham
---
Changes since v2
- Modified the return value of atomic_pte_lookup
to use booleans rather than numeric values
: Greg Kroah-Hartman
Cc: Dimitri Sivanich
Cc: Arnd Bergmann
Cc: William Kucharski
Cc: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org
Reviewed-by: John Hubbard
Reviewed-by: William Kucharski
Reviewed-by: Ira Weiny
Signed-off-by: Bharath Vedartham
---
Changes since v2
- Added
Cc: John Hubbard
Cc: Jérôme Glisse
Cc: Greg Kroah-Hartman
Cc: Dimitri Sivanich
Cc: Arnd Bergmann
Cc: William Kucharski
Cc: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org
Reviewed-by: Ira Weiny
Reviewed-by: John Hubbard
Signed-off-by: Bharath Vedartham
---
drivers/misc/sgi-gru/grufault.c
it by applying the first patch to the above tree and test it.
More details are in the individual changelogs.
Bharath Vedartham (3):
sgi-gru: Convert put_page() to get_user_page*()
sgi-gru: Remove CONFIG_HUGETLB_PAGE ifdef
sgi-gru: Use __get_user_pages_fast in atomic_pte_lookup
drivers/misc/sgi
On Sun, Jul 21, 2019 at 07:32:36PM -0700, John Hubbard wrote:
> On 7/21/19 8:58 AM, Bharath Vedartham wrote:
> > *pte_lookup functions get the physical address for a given virtual
> > address by getting a physical page using gup and use page_to_phys to get
> >
e. I am not really sure as to how much of
an improvement it would be, the condition will be evaluated eitherways
AFAIK? Eitherways, the ternary operator does not look good. I ll make a
version 2 of this.
> > On Jul 21, 2019, at 9:58 AM, Bharath Vedartham wrote:
> >
> > is_vm_hugetlb_page h
On Sun, Jul 21, 2019 at 07:25:31PM -0700, John Hubbard wrote:
> On 7/21/19 8:58 AM, Bharath Vedartham wrote:
> > For pages that were retained via get_user_pages*(), release those pages
> > via the new put_user_page*() routines, instead of via put_page().
> >
> &g
__get_user_pages_fast
in hva_to_pfn_fast function which can run in an atomic context.
Cc: Ira Weiny
Cc: John Hubbard
Cc: Jérôme Glisse
Cc: Greg Kroah-Hartman
Cc: Dimitri Sivanich
Cc: Arnd Bergmann
Cc: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org
Signed-off-by: Bharath Vedartham
---
drivers
. But that is to change in the future.
Any suggestions as to how to test this code?
The implementation of gup tracking is in:
https://github.com/johnhubbard/linux/tree/gup_dma_core
We could test it by applying the first patch to the above tree and test it.
More details are in the individual changelogs.
Bharath
: Greg Kroah-Hartman
Cc: Dimitri Sivanich
Cc: Arnd Bergmann
Cc: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org
Signed-off-by: Bharath Vedartham
---
drivers/misc/sgi-gru/grufault.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/misc/sgi-gru
Cc: John Hubbard
Cc: Jérôme Glisse
Cc: Greg Kroah-Hartman
Cc: Dimitri Sivanich
Cc: Arnd Bergmann
Cc: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org
Signed-off-by: Bharath Vedartham
---
drivers/misc/sgi-gru/grufault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dr
On Fri, Jul 19, 2019 at 08:59:02PM +, Matt Sickler wrote:
> >From: Bharath Vedartham
> >Changes since v2
> >- Added back PageResevered check as suggested by John Hubbard.
> >
> >The PageReserved check needs a closer look and is not worth messing
>
Cc: John Hubbard
Cc: Jérôme Glisse
Cc: Greg Kroah-Hartman
Cc: Matt Sickler
Cc: de...@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org
Reviewed-by: John Hubbard
Signed-off-by: Bharath Vedartham
---
Changes since v1
- Improved changelog by John's
On Fri, Jul 19, 2019 at 02:28:39PM -0700, John Hubbard wrote:
> On 7/19/19 1:02 PM, Bharath Vedartham wrote:
> > There have been issues with coordination of various subsystems using
> > get_user_pages. These issues are better described in [1].
> >
> > An implementation
tt Sickler
Cc: de...@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org
Signed-off-by: Bharath Vedartham
---
Changes since v1
- Improved changelog by John's suggestion.
- Moved logic to dirty pages below sg_dma_unmap
and removed PageReserved chec
Built and booted on my x86 machine. No dmesg regressions.
Thank you
Bharath
Built and booted on my x86 system. No dmesg regressions found.
Thank you
Bharath
Built and booted on my x86 machine. No dmesg regressions found.
Thank you
Bharath
Built and booted in my x86 test machine. No regressions found.
Thank you
Bharath
On Mon, Jul 15, 2019 at 03:01:43PM -0700, John Hubbard wrote:
> On 7/15/19 2:47 PM, Matt Sickler wrote:
> > It looks like Outlook is going to absolutely trash this email. Hopefully
> > it comes through okay.
> >
> ...
> >>
> >> Because this is a common pattern, and because the code here doesn't
-by: John Hubbard
Signed-off-by: Bharath Vedartham
---
Changes since v1
- Added John's reviewed-by tag
- Moved para talking about testing below
the '---'
- Moved logic of set_page_diry below dma_unmap_sg
as per John's suggestion
I currently do not have
On Mon, Jul 15, 2019 at 01:14:13PM -0700, John Hubbard wrote:
> On 7/15/19 12:52 PM, Bharath Vedartham wrote:
> > There have been issues with get_user_pages and filesystem writeback.
> > The issues are better described in [1].
> >
> > The solution being proposed wants
...@driverdev.osuosl.org
Signed-off-by: Bharath Vedartham
---
drivers/staging/kpc2000/kpc_dma/fileops.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c
b/drivers/staging/kpc2000/kpc_dma/fileops.c
index 6166587..82c70e6 100644
--- a/drivers
Tested and booted in my x86 system. No regressions.
Tested and booted on my x86 system. No regressions.
Booted and tested in my x86 systems. No regressions.
On Fri, Jun 21, 2019 at 02:09:31PM +0200, Vlastimil Babka wrote:
> On 6/21/19 1:43 PM, Alan Jenkins wrote:
> > When setting the low and high watermarks we use min_wmark_pages(zone).
> > I guess this is to reduce the line length. But we forgot that this macro
> > includes zone->watermark_boost.
IMO the reason why a lot of failures must not have occured in the past
might be because the programs which use it use stuff like cpu_to_node or
have checks for nid.
If one day we do get a program which passes an invalid node id without
VM_BUG_ON enabled, it might get weird.
[Not replying inline as my mail is bouncing back]
This patch is based on reading the code rather than a kernel crash. My
thought process was that if an invalid node id was passed to
__alloc_pages_node, it would be better to add a VM_WARN_ON and fail the
allocation rather than crashing the kernel.
MNODES) also considers NUMA_NO_NODE
as an invalid nid, but the caller of __alloc_pages_node is assumed to
have checked for the case where nid == NUMA_NO_NODE.
Signed-off-by: Bharath Vedartham
---
include/linux/gfp.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/include/l
v9fs_fill_super has a param 'void *data' which is unused in the
function.
This patch removes the 'void *data' param in v9fs_fill_super and changes
the parameters in all function calls of v9fs_fill_super.
Signed-off-by: Bharath Vedartham
---
fs/9p/vfs_super.c | 4 ++--
1 file changed, 2
Cool! Thanks!
Thank you,
Bharath
a73b6c1e9833...@syzkaller.appspotmail.com
Signed-off-by: Bharath Vedartham
---
Changes since v2
- Made v9ses->cachetag NULL after freeing to avoid any
side effects.
---
fs/9p/cache.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/9p/cache.c b/fs/9p/cache.c
index 9eb3470.
a73b6c1e9833...@syzkaller.appspotmail.com
Signed-off-by: Bharath Vedartham
---
fs/9p/cache.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/9p/cache.c b/fs/9p/cache.c
index 9eb3470..4463b91 100644
--- a/fs/9p/cache.c
+++ b/fs/9p/cache.c
@@ -66,6 +66,7 @@ void v9fs_cache_session_get_c
Replace kmalloc + memcpy with kmemdup.
This was reported by coccinelle.
Signed-off-by: Bharath Vedartham
---
Changes since v2:
Removed the cast from pIoc2.
---
drivers/message/fusion/mptbase.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/message/fusion
On Wed, May 22, 2019 at 04:48:33AM -0700, Joe Perches wrote:
> On Wed, 2019-05-22 at 15:23 +0530, Bharath Vedartham wrote:
> > Replace kmalloc + memcpy with kmemdup.
> > This was reported by coccinelle.
> []
> > diff --git a/drivers/message/fusion/mptbase.c
> > b/dr
Replace kmalloc + memcpy with kmemdup.
This was reported by coccinelle.
Signed-off-by: Bharath Vedartham
---
drivers/message/fusion/mptbase.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index d8882b0
compiling the kernel and also running
./scripts/checkincludes.pl on fs/nfs/dns_resolve.c
Signed-off-by: Bharath Vedartham
---
fs/nfs/dns_resolve.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/nfs/dns_resolve.c b/fs/nfs/dns_resolve.c
index a7d3df8..b34e575 100644
--
follow_page_mask is only used in gup.c, make it static.
Tested by compiling and booting. Grepped the source for
"follow_page_mask" to be sure it is not used else where.
Signed-off-by: Bharath Vedartham
---
mm/gup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
Built and booted on my x86_64 machine. No dmesg regressions observed.
Thanks
Bharath
On Sat, May 04, 2019 at 07:54:46AM -0400, Michal Hocko wrote:
Hi Michal,
Thanks for having a look at the patch.
> On Sat 04-05-19 15:53:54, Bharath Vedartham wrote:
> > __thp_get_unmapped_area is only used in mm/huge_memory.c. Make it
> > static.
>
> Makes sense. L
__thp_get_unmapped_area is only used in mm/huge_memory.c. Make it
static. Tested by building and booting the kernel.
Signed-off-by: Bharath Vedartham
---
mm/huge_memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 165ea46
Built and booted on my x86 machine. No dmesg regression.
Built and booted on my x86 machine with defconfig. No dmesg regressions.
Thank you
Bharath
Make add_hwgenerator_randomness static as it is only declared on
drivers/char/random.c
Signed-off-by: Bharath Vedartham
---
drivers/char/random.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 38c6d1a..08fd00a 100644
This patch fixes the sparse warning:
warning: cast removes address space '' of expression.
Signed-off-by: Bharath Vedartham
---
security/apparmor/lsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
index 87500bd..36478c4
On Tue, Apr 23, 2019 at 09:48:31PM +0530, Bharath Vedartham wrote:
> csum_partial() gives different results for little-endian and big-endian
> hosts. This causes images created on little-endian hosts and mounted on
> big endian hosts to see csum mismatches. This causes an endianness bug.
and xattr_hash expects __u32. This warning acts as a reminder
for this bug and should not be suppressed.
This comment aims to convey these endianness issues.
Signed-off-by: Bharath Vedartham
---
fs/reiserfs/xattr.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/fs/reiserfs
On Mon, Apr 22, 2019 at 12:27:05PM -0700, Andrew Morton wrote:
> On Sun, 21 Apr 2019 18:02:35 +0100 Al Viro wrote:
>
> > IOW, what sparse has caught here is a genuine endianness bug; images
> > created on little-endian host and mounted on big-endian (or vice
> > versa) will see csum mismatches
On Sun, Apr 21, 2019 at 06:02:35PM +0100, Al Viro wrote:
> On Thu, Apr 18, 2019 at 03:50:19PM -0700, Andrew Morton wrote:
> > On Wed, 17 Apr 2019 17:22:00 +0530 Bharath Vedartham
> > wrote:
> >
> > > This patch fixes the sparse warning:
> > >
>
This patch fixes the sparse warning:
warning: restricted __fs16 degrades to integer
inode->ui_u1.oldids.ui_suid is of type __fs16, a restricted integer.
0X is a 16 bit unsigned integer. Use __force to fix the sparse
warning.
Signed-off-by: Bharath Vedartham
---
fs/ufs/util.h | 4 ++--
Built and booted on my x86 machine.
Observed no dmesg regressions.
Built and booted the kernel with defconfig on my x86 machine.
Observed no dmesg regressions.
On Thu, Apr 18, 2019 at 03:50:19PM -0700, Andrew Morton wrote:
> On Wed, 17 Apr 2019 17:22:00 +0530 Bharath Vedartham
> wrote:
>
> > This patch fixes the sparse warning:
> >
> > fs/reiserfs//xattr.c:453:28: warning: incorrect type in return
> > expression (diff
ddr is of type __le32.
Signed-off-by: Bharath Vedartham
---
fs/f2fs/dir.c | 2 +-
fs/f2fs/node.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
index 59bc460..4f39872 100644
--- a/fs/f2fs/dir.c
+++ b/fs/f2fs/dir.c
@@ -828,7 +828,7 @@
1 - 100 of 137 matches
Mail list logo
