[PATCH v4 2/3] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC

This patch adds operation region driver for Intel BXT WhiskeyCove PMIC. The register mapping is done as per the BXT WC data sheet. Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanic...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- Changes in v4: - Reverted(remove

[PATCH v4 2/3] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC

This patch adds operation region driver for Intel BXT WhiskeyCove PMIC. The register mapping is done as per the BXT WC data sheet. Signed-off-by: Ajay Thomas Signed-off-by: Bin Gao --- Changes in v4: - Reverted(removed) regs_read() and regs_write() methods Changes in v3: - Added regs_read

[PATCH v4 1/3] acpi/pmic: modify the pen function signature to take bit field

the first approach. Solution: Modified the policy enable function to take bit field as well. The use of bit field is left to the pmic specific opregion driver. Signed-off-by: Yegnesh Iyer <yegnesh.s.i...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- Changes in v4: none Changes

[PATCH v4 1/3] acpi/pmic: modify the pen function signature to take bit field

the first approach. Solution: Modified the policy enable function to take bit field as well. The use of bit field is left to the pmic specific opregion driver. Signed-off-by: Yegnesh Iyer Signed-off-by: Bin Gao --- Changes in v4: none Changes in v3: none Changes in v2: - Fixed subject line. drivers

[PATCH v4 0/3] acpi/pmic: add opregion driver for Intel BXT WhiskeyCove PMIC

This series modifies the pen function signature to take bit field and adds a new opregion driver for Intel BXT WhiskeyCove PMIC. It also adds support for PMIC regs operation region. Yegnesh Iyer (1): acpi: pmic: Modifying the pen function signature to take bit field Ajay Thomas (1): acpi:

[PATCH v4 0/3] acpi/pmic: add opregion driver for Intel BXT WhiskeyCove PMIC

This series modifies the pen function signature to take bit field and adds a new opregion driver for Intel BXT WhiskeyCove PMIC. It also adds support for PMIC regs operation region. Yegnesh Iyer (1): acpi: pmic: Modifying the pen function signature to take bit field Ajay Thomas (1): acpi:

Re: [PATCH v3 0/3] acpi/pmic: add opregion driver for Intel BXT WhiskeyCove PMIC

> Well, I'm dropping the old series due to comments from Aaron on the > second patch. > > I will be waiting for an update addressing the Aaron's comments in > [2/3] and [3/3]. Right, there was no change on [1/3]. I'll address Aaron's comments and re-send all as v4. Thanks. -Bin

Re: [PATCH v3 0/3] acpi/pmic: add opregion driver for Intel BXT WhiskeyCove PMIC

> Well, I'm dropping the old series due to comments from Aaron on the > second patch. > > I will be waiting for an update addressing the Aaron's comments in > [2/3] and [3/3]. Right, there was no change on [1/3]. I'll address Aaron's comments and re-send all as v4. Thanks. -Bin

[PATCH v3 3/3] acpi/pmic: Add support for PMIC regs operation region

. Signed-off-by: Chandra Sekhar Anagani <chandra.sekhar.anag...@intel.com> Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- Changes in v3: none Changes in v2: none drivers/acpi/pmic

[PATCH v3 3/3] acpi/pmic: Add support for PMIC regs operation region

. Signed-off-by: Chandra Sekhar Anagani Signed-off-by: Felipe Balbi Signed-off-by: Bin Gao --- Changes in v3: none Changes in v2: none drivers/acpi/pmic/intel_pmic.c | 74 +- drivers/acpi/pmic/intel_pmic.h | 5 +++ 2 files changed, 71 insertions(+), 8

[PATCH v3 2/3] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC

khar Anagani <chandra.sekhar.anag...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- Changes in v3: - Added regs_read() and regs_write() methods to the intel_pmic_opregion_data{} structure. Changs in v2: - Replaced module_init() with device_initcall(). drivers/acpi/Kconf

[PATCH v3 2/3] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC

This patch adds operation region driver for Intel BXT WhiskeyCove PMIC. The register mapping is done as per the BXT WC data sheet. Signed-off-by: Ajay Thomas Signed-off-by: Felipe Balbi Signed-off-by: Chandra Sekhar Anagani Signed-off-by: Bin Gao --- Changes in v3: - Added regs_read

[PATCH v3 1/3] acpi/pmic: modify the pen function signature to take bit field

the first approach. Solution: Modified the policy enable function to take bit field as well. The use of bit field is left to the pmic specific opregion driver. Signed-off-by: Yegnesh Iyer <yegnesh.s.i...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- Changes in v3: no change C

[PATCH v3 1/3] acpi/pmic: modify the pen function signature to take bit field

the first approach. Solution: Modified the policy enable function to take bit field as well. The use of bit field is left to the pmic specific opregion driver. Signed-off-by: Yegnesh Iyer Signed-off-by: Bin Gao --- Changes in v3: no change Changes in v2: - Fixed subject line. drivers/acpi/pmic

[PATCH v3 0/3] acpi/pmic: add opregion driver for Intel BXT WhiskeyCove PMIC

This series modifies the pen function signature to take bit field and adds a new opregion driver for Intel BXT WhiskeyCove PMIC. It also adds support for PMIC regs operation region. Yegnesh Iyer (1): acpi: pmic: Modifying the pen function signature to take bit field Ajay Thomas (1): acpi:

[PATCH v3 0/3] acpi/pmic: add opregion driver for Intel BXT WhiskeyCove PMIC

This series modifies the pen function signature to take bit field and adds a new opregion driver for Intel BXT WhiskeyCove PMIC. It also adds support for PMIC regs operation region. Yegnesh Iyer (1): acpi: pmic: Modifying the pen function signature to take bit field Ajay Thomas (1): acpi:

[PATCH v3] mfd: intel_soc_pmic_bxtwc: Add Intel BXT WhiskeyCove PMIC ADC thermal channel mapping and USB type-C resources

: struct trip_config_map{}, struct thermal_irq_map {} and struct pmic_thermal_data {} which are required by changes we did on intel_soc_pmic_bxtwc.c. Signed-off-by: Yegnesh S Iyer <yegnesh.s.i...@intel.com> Signed-off-by: Rohit S Kenchanpura <rohit.s.kenchanp...@intel.com> Signed-off-by:

[PATCH v3] mfd: intel_soc_pmic_bxtwc: Add Intel BXT WhiskeyCove PMIC ADC thermal channel mapping and USB type-C resources

: struct trip_config_map{}, struct thermal_irq_map {} and struct pmic_thermal_data {} which are required by changes we did on intel_soc_pmic_bxtwc.c. Signed-off-by: Yegnesh S Iyer Signed-off-by: Rohit S Kenchanpura Signed-off-by: Bin Gao --- Changes in v3: - Added USB type-C resources. Changes in v2

Re: [PATCH v3] gpio: add Intel WhiskeyCove GPIO driver

On Tue, Jun 21, 2016 at 02:19:57AM +0300, Andy Shevchenko wrote: > My comments below. Thanks for your review. > > +config GPIO_WHISKEY_COVE > > + tristate "GPIO support for Whiskey Cove PMIC" > > + depends on INTEL_SOC_PMIC > > + select GPIOLIB_IRQCHIP > > + help > > +

Re: [PATCH v3] gpio: add Intel WhiskeyCove GPIO driver

On Tue, Jun 21, 2016 at 02:19:57AM +0300, Andy Shevchenko wrote: > My comments below. Thanks for your review. > > +config GPIO_WHISKEY_COVE > > + tristate "GPIO support for Whiskey Cove PMIC" > > + depends on INTEL_SOC_PMIC > > + select GPIOLIB_IRQCHIP > > + help > > +

Re: x86/tsc: Set X86_FEATURE_TSC_RELIABLE to skip refined calibration

On Mon, Jun 20, 2016 at 04:20:26PM -0700, John Stultz wrote: > On Fri, Jun 17, 2016 at 12:48 AM, Thomas Gleixner <t...@linutronix.de> wrote: > > On Thu, 16 Jun 2016, Bin Gao wrote: > > > >> Unlike PIT based calibration which counts TSC cycles against another timer

Re: x86/tsc: Set X86_FEATURE_TSC_RELIABLE to skip refined calibration

On Mon, Jun 20, 2016 at 04:20:26PM -0700, John Stultz wrote: > On Fri, Jun 17, 2016 at 12:48 AM, Thomas Gleixner wrote: > > On Thu, 16 Jun 2016, Bin Gao wrote: > > > >> Unlike PIT based calibration which counts TSC cycles against another timer, > >> MSR o

Re: [PATCH v2] mfd: intel_soc_pmic_bxtwc: Add Intel BXT WhiskeyCove PMIC ADC thermal channel-zone mapping

On Mon, Jun 20, 2016 at 09:52:00AM +0100, Lee Jones wrote: > > > > > +static struct trip_config_map str3_trip_config[] = { > > > > > + { > > > > > + .irq_reg = BXTWC_THRM2IRQ, > > > > > + .irq_mask = 0x10, > > > > > + .irq_en = BXTWC_MTHRM2IRQ, > > > > > +

Re: [PATCH v2] mfd: intel_soc_pmic_bxtwc: Add Intel BXT WhiskeyCove PMIC ADC thermal channel-zone mapping

On Mon, Jun 20, 2016 at 09:52:00AM +0100, Lee Jones wrote: > > > > > +static struct trip_config_map str3_trip_config[] = { > > > > > + { > > > > > + .irq_reg = BXTWC_THRM2IRQ, > > > > > + .irq_mask = 0x10, > > > > > + .irq_en = BXTWC_MTHRM2IRQ, > > > > > +

[PATCH v3] gpio: add Intel WhiskeyCove GPIO driver

This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. This driver is based on gpio-crystalcove.c. Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanic...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- Changes in v3: - Fixed the year in copyright line

[PATCH v3] gpio: add Intel WhiskeyCove GPIO driver

This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. This driver is based on gpio-crystalcove.c. Signed-off-by: Ajay Thomas Signed-off-by: Bin Gao --- Changes in v3: - Fixed the year in copyright line(2015-->2016). - Removed DRV_NAME macro. - Added kernel-

Re: [PATCH v2] mfd: intel_soc_pmic_bxtwc: Add Intel BXT WhiskeyCove PMIC ADC thermal channel-zone mapping

On Fri, Jun 17, 2016 at 09:01:59AM +0100, Lee Jones wrote: > > +static struct trip_config_map str0_trip_config[] = { > > + { > > + .irq_reg = BXTWC_THRM0IRQ, > > + .irq_mask = 0x01, > > + .irq_en = BXTWC_MTHRM0IRQ, > > + .irq_en_mask = 0x01, > > +

Re: [PATCH v2] mfd: intel_soc_pmic_bxtwc: Add Intel BXT WhiskeyCove PMIC ADC thermal channel-zone mapping

On Fri, Jun 17, 2016 at 09:01:59AM +0100, Lee Jones wrote: > > +static struct trip_config_map str0_trip_config[] = { > > + { > > + .irq_reg = BXTWC_THRM0IRQ, > > + .irq_mask = 0x01, > > + .irq_en = BXTWC_MTHRM0IRQ, > > + .irq_en_mask = 0x01, > > +

Re: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver

> > Looks good. I have couple of minor comments, see below. Thanks for review again. > > > + * Copyright (C) 2015 Intel Corporation. All rights reserved. > > It is 2016 now isn't it? :-) Will fix this in v3. > > +#define DRV_NAME "bxt_wcove_gpio" > > Drop this. We have _TWO_ places using

Re: [PATCH v2] gpio: add Intel WhiskeyCove GPIO driver

> > Looks good. I have couple of minor comments, see below. Thanks for review again. > > > + * Copyright (C) 2015 Intel Corporation. All rights reserved. > > It is 2016 now isn't it? :-) Will fix this in v3. > > +#define DRV_NAME "bxt_wcove_gpio" > > Drop this. We have _TWO_ places using

x86/tsc: Set X86_FEATURE_TSC_RELIABLE to skip refined calibration

() with setup_force_cpu_cap() in other files. Signed-off-by: Bin Gao <bin@intel.com> --- arch/x86/kernel/tsc_msr.c | 2 ++ arch/x86/platform/intel-mid/mfld.c | 2 +- arch/x86/platform/intel-mid/mrfl.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ar

x86/tsc: Set X86_FEATURE_TSC_RELIABLE to skip refined calibration

() with setup_force_cpu_cap() in other files. Signed-off-by: Bin Gao --- arch/x86/kernel/tsc_msr.c | 2 ++ arch/x86/platform/intel-mid/mfld.c | 2 +- arch/x86/platform/intel-mid/mrfl.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/tsc_msr.c b/arch

[PATCH v2] mfd: intel_soc_pmic_bxtwc: Add Intel BXT WhiskeyCove PMIC ADC thermal channel-zone mapping

{}, struct thermal_irq_map {} and struct pmic_thermal_data {} which are required by changes we did on intel_soc_pmic_bxtwc.c. Signed-off-by: Yegnesh S Iyer <yegnesh.s.i...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- Changes in v2: - Fixed subject line. - Combined two patc

[PATCH v2] mfd: intel_soc_pmic_bxtwc: Add Intel BXT WhiskeyCove PMIC ADC thermal channel-zone mapping

{}, struct thermal_irq_map {} and struct pmic_thermal_data {} which are required by changes we did on intel_soc_pmic_bxtwc.c. Signed-off-by: Yegnesh S Iyer Signed-off-by: Bin Gao --- Changes in v2: - Fixed subject line. - Combined two patches into one. drivers/mfd/intel_soc_pmic_bxtwc.c | 109

[PATCH v2] gpio: add Intel WhiskeyCove GPIO driver

This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. This driver is based on gpio-crystalcove.c. Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanic...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- Changes in v2: - Typo fix (Whsikey --> Whiske

[PATCH v2] gpio: add Intel WhiskeyCove GPIO driver

This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. This driver is based on gpio-crystalcove.c. Signed-off-by: Ajay Thomas Signed-off-by: Bin Gao --- Changes in v2: - Typo fix (Whsikey --> Whiskey). - Included linux/gpio/driver.h instead of linux/gpio.h - Implemen

Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

On Tue, Jun 14, 2016 at 01:09:31PM +0300, Mika Westerberg wrote: > On Fri, Jun 10, 2016 at 11:01:51PM -0700, Bin Gao wrote: > > +static const struct platform_device_id pmic_gpio_id_table[] = { > > + { "bxt_wcove_gpio", }, > > +}; > > Do you really n

Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

On Tue, Jun 14, 2016 at 01:09:31PM +0300, Mika Westerberg wrote: > On Fri, Jun 10, 2016 at 11:01:51PM -0700, Bin Gao wrote: > > +static const struct platform_device_id pmic_gpio_id_table[] = { > > + { "bxt_wcove_gpio", }, > > +}; > > Do you really n

Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

On Mon, Jun 13, 2016 at 02:43:16PM +0200, Linus Walleij wrote: > On Sat, Jun 11, 2016 at 8:01 AM, Bin Gao <bin@linux.intel.com> wrote: > > > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > > This driver is based on gpio-crystalcove.c. >

Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

On Mon, Jun 13, 2016 at 02:43:16PM +0200, Linus Walleij wrote: > On Sat, Jun 11, 2016 at 8:01 AM, Bin Gao wrote: > > > This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. > > This driver is based on gpio-crystalcove.c. > > > > Signed-off-b

Re: [PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC

On Sun, Jun 12, 2016 at 10:13:33AM +0800, Aaron Lu wrote: > Last time Paul suggests device_initcall instead of module_init here: > > commit 75829dcf10862966f52716f2d67ac1c1b1eb486b > Author: Paul Gortmaker > Date: Mon Feb 15 00:27:51 2016 -0500 > >

Re: [PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC

On Sun, Jun 12, 2016 at 10:13:33AM +0800, Aaron Lu wrote: > Last time Paul suggests device_initcall instead of module_init here: > > commit 75829dcf10862966f52716f2d67ac1c1b1eb486b > Author: Paul Gortmaker > Date: Mon Feb 15 00:27:51 2016 -0500 > > drivers/acpi: make pmic/intel_pmic_crc.c

[PATCH v2 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC

This patch adds operation region driver for Intel BXT WhiskeyCove PMIC. The register mapping is done as per the BXT WC data sheet. Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanic...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- drivers/acpi/Kconfig

[PATCH v2 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC

This patch adds operation region driver for Intel BXT WhiskeyCove PMIC. The register mapping is done as per the BXT WC data sheet. Signed-off-by: Ajay Thomas Signed-off-by: Bin Gao --- drivers/acpi/Kconfig | 6 + drivers/acpi/Makefile| 1 + drivers/acpi/pmic

[PATCH v2 1/2] acpi/pmic: modify the pen function signature to take bit field

the first approach. Solution: Modified the policy enable function to take bit field as well. The use of bit field is left to the pmic specific opregion driver. Signed-off-by: Yegnesh Iyer <yegnesh.s.i...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- drivers/acpi/pmic/intel_pmi

[PATCH v2 1/2] acpi/pmic: modify the pen function signature to take bit field

the first approach. Solution: Modified the policy enable function to take bit field as well. The use of bit field is left to the pmic specific opregion driver. Signed-off-by: Yegnesh Iyer Signed-off-by: Bin Gao --- drivers/acpi/pmic/intel_pmic.c | 13 +++-- drivers/acpi/pmic/intel_pmic.h

[PATCH v2 0/2] acpi/pmic: add opregion driver for Intel BXT WhiskeyCove PMIC

This series modifies the pen function signature to take bit field and adds a new opregion driver for Intel BXT WhiskeyCove PMIC. Changes in v2: - Replaced module_init() with device_initcall() as the driver is supposed to be built-in. Yegnesh Iyer (1): acpi/pmic: Modifying the pen function

[PATCH v2 0/2] acpi/pmic: add opregion driver for Intel BXT WhiskeyCove PMIC

This series modifies the pen function signature to take bit field and adds a new opregion driver for Intel BXT WhiskeyCove PMIC. Changes in v2: - Replaced module_init() with device_initcall() as the driver is supposed to be built-in. Yegnesh Iyer (1): acpi/pmic: Modifying the pen function

[PATCH 3/3] mfd/intel_soc_pmic_bxtwc: add Intel BXT WhiskeyCove PMIC ADC thermal channel-zone mapping

This changes adds the mapping of Intel BXT WhiskeyCove PMIC ADC channel to thermal zone. This mapping is used in the pmic thermal driver to notify the thermal zone with the pmic adc channel alert interrupts. Signed-off-by: Yegnesh Iyer <yegnesh.s.i...@intel.com> Signed-off-by: Bin Ga

[PATCH 3/3] mfd/intel_soc_pmic_bxtwc: add Intel BXT WhiskeyCove PMIC ADC thermal channel-zone mapping

This changes adds the mapping of Intel BXT WhiskeyCove PMIC ADC channel to thermal zone. This mapping is used in the pmic thermal driver to notify the thermal zone with the pmic adc channel alert interrupts. Signed-off-by: Yegnesh Iyer Signed-off-by: Bin Gao --- drivers/mfd

[PATCH 2/3] thermal: add Intel BXT WhiskeyCove PMIC thermal driver

<yegnesh.s.i...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- drivers/thermal/Kconfig | 10 +++ drivers/thermal/Makefile | 1 + drivers/thermal/intel_pmic_thermal.c | 159 +++ 3 files changed, 170 insertions(+) create

[PATCH 2/3] thermal: add Intel BXT WhiskeyCove PMIC thermal driver

-off-by: Bin Gao --- drivers/thermal/Kconfig | 10 +++ drivers/thermal/Makefile | 1 + drivers/thermal/intel_pmic_thermal.c | 159 +++ 3 files changed, 170 insertions(+) create mode 100644 drivers/thermal/intel_pmic_thermal.c diff --git

[PATCH 1/3] include/linux/mfd/intel_soc_pmic.h: add new data structures

This patch adds three new data structures: struct trip_config_map {}, struct thermal_irq_map {} and struct pmic_thermal_data {} which are required by some new drivers. Signed-off-by: ysiyer <yegnesh.s.i...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- inclu

[PATCH 1/3] include/linux/mfd/intel_soc_pmic.h: add new data structures

This patch adds three new data structures: struct trip_config_map {}, struct thermal_irq_map {} and struct pmic_thermal_data {} which are required by some new drivers. Signed-off-by: ysiyer Signed-off-by: Bin Gao --- include/linux/mfd/intel_soc_pmic.h | 21 + 1 file changed

[PATCH 0/3] thermal: add thermal support for Intel BXT WhiskeyCove PMIC

This series adds thermal support for Intel BXT WhiskeyCove PMIC Yegnesh Iyer (3): include/linux/mfd/intel_soc_pmic.h: add new data structures thermal: add Intel BXT WhiskeyCove PMIC thermal driver mfd/intel_soc_pmic_bxtwc: add Intel BXT WhiskeyCove PMIC ADC thermal channel-zone mapping

[PATCH 0/3] thermal: add thermal support for Intel BXT WhiskeyCove PMIC

This series adds thermal support for Intel BXT WhiskeyCove PMIC Yegnesh Iyer (3): include/linux/mfd/intel_soc_pmic.h: add new data structures thermal: add Intel BXT WhiskeyCove PMIC thermal driver mfd/intel_soc_pmic_bxtwc: add Intel BXT WhiskeyCove PMIC ADC thermal channel-zone mapping

[PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC

This patch adds operation region driver for Intel BXT WhiskeyCove PMIC. The register mapping is done as per the BXT WC data sheet. Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanic...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- drivers/acpi/Kconfig

[PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC

This patch adds operation region driver for Intel BXT WhiskeyCove PMIC. The register mapping is done as per the BXT WC data sheet. Signed-off-by: Ajay Thomas Signed-off-by: Bin Gao --- drivers/acpi/Kconfig | 6 + drivers/acpi/Makefile| 1 + drivers/acpi/pmic

[PATCH 1/2] acpi/pmic: modify the pen function signature to take bit field

the first approach. Solution: Modified the policy enable function to take bit field as well. The use of bit field is left to the pmic specific opregion driver. Signed-off-by: Yegnesh Iyer <yegnesh.s.i...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- drivers/acpi/pmic/intel_pmi

[PATCH 1/2] acpi/pmic: modify the pen function signature to take bit field

the first approach. Solution: Modified the policy enable function to take bit field as well. The use of bit field is left to the pmic specific opregion driver. Signed-off-by: Yegnesh Iyer Signed-off-by: Bin Gao --- drivers/acpi/pmic/intel_pmic.c | 13 +++-- drivers/acpi/pmic/intel_pmic.h

[PATCH 0/2] acpi/pmic: add opregion driver for Intel BXT WhiskeyCove PMIC

This series modifies the pen function signature to take bit field and adds a new opregion driver for Intel BXT WhiskeyCove PMIC. Yegnesh Iyer (1): acpi/pmic: Modifying the pen function signature to take bit field Ajay Thomas (1): acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC

[PATCH 0/2] acpi/pmic: add opregion driver for Intel BXT WhiskeyCove PMIC

This series modifies the pen function signature to take bit field and adds a new opregion driver for Intel BXT WhiskeyCove PMIC. Yegnesh Iyer (1): acpi/pmic: Modifying the pen function signature to take bit field Ajay Thomas (1): acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC

[PATCH] gpio: add Intel WhiskeyCove GPIO driver

This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. This driver is based on gpio-crystalcove.c. Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanic...@intel.com> Signed-off-by: Bin Gao <bin@intel.com> --- drivers/gpio/Kconfig | 13 ++ drivers/g

[PATCH] gpio: add Intel WhiskeyCove GPIO driver

This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC. This driver is based on gpio-crystalcove.c. Signed-off-by: Ajay Thomas Signed-off-by: Bin Gao --- drivers/gpio/Kconfig | 13 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-wcove.c | 402

Re: [PATCH v6 1/2] serial_core: add pci uart early console support

On Thu, Jul 23, 2015 at 03:21:27PM -0700, Greg Kroah-Hartman wrote: > > +config PCI_EARLY > > + bool "Early PCI access" > > + depends on PCI > > + default n > > Default is always 'n' so this isn't needed here. Will fix this. > > diff --git a/drivers/tty/serial/serial_core.c > >

Re: [PATCH v6 1/2] serial_core: add pci uart early console support

On Thu, Jul 23, 2015 at 03:21:27PM -0700, Greg Kroah-Hartman wrote: +config PCI_EARLY + bool Early PCI access + depends on PCI + default n Default is always 'n' so this isn't needed here. Will fix this. diff --git a/drivers/tty/serial/serial_core.c

[PATCH v6 2/2] arch/x86: remove pci uart early console from early_prink.c

5140fda16051 ("Specify PCI based UART for earlyprintk")' is removed. And its equivalent function will be available from uart8250 early console driver. Signed-off-by: Bin Gao --- Changes in v6: - limited the early parameter 'earlyprintk' in drivers/tty/serial/earlycon.c to uart8

[PATCH v6 1/2] serial_core: add pci uart early console support

the following line to the kernel command line (assume baud rate is 115200): earlyprintk=uart8250,pci32,0:24.2,115200n8 Signed-off-by: Bin Gao --- Changes in v6: None Changes in v5: - updated Documentation/kernel-parameters.txt. - moved earlyprintk= to patch 2/2 (requires x86 people's review

[PATCH v6 1/2] serial_core: add pci uart early console support

the following line to the kernel command line (assume baud rate is 115200): earlyprintk=uart8250,pci32,0:24.2,115200n8 Signed-off-by: Bin Gao bin@intel.com --- Changes in v6: None Changes in v5: - updated Documentation/kernel-parameters.txt. - moved earlyprintk= to patch 2/2 (requires x86

[PATCH v6 2/2] arch/x86: remove pci uart early console from early_prink.c

5140fda16051 (Specify PCI based UART for earlyprintk)' is removed. And its equivalent function will be available from uart8250 early console driver. Signed-off-by: Bin Gao bin@intel.com --- Changes in v6: - limited the early parameter 'earlyprintk' in drivers/tty/serial/earlycon.c

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

On Wed, Jun 03, 2015 at 08:35:29AM -0400, Peter Hurley wrote: > > +/* x86 uses "earlyprintk=xxx", so we keep the compatibility here */ > > +#ifdef CONFIG_X86 > > +static int __init param_setup_earlycon_x86(char *buf) > > +{ > > + return param_setup_earlycon(buf); > > +} > >

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

On Wed, Jun 03, 2015 at 08:35:29AM -0400, Peter Hurley wrote: +/* x86 uses earlyprintk=xxx, so we keep the compatibility here */ +#ifdef CONFIG_X86 +static int __init param_setup_earlycon_x86(char *buf) +{ + return param_setup_earlycon(buf); +} +early_param(earlyprintk,

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

On Wed, Jun 03, 2015 at 12:16:36AM +, Anderson, Stuart R wrote: > Bin, et al, > > What we are losing here is the ability to specify a UART by its bus address > instead of just supplying the memory or io address. There are some cases > where this is useful, though I admit it is probably not

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

On Tue, Jun 02, 2015 at 01:37:52PM -0700, Yinghai Lu wrote: > how about > earlyprintk=serial,ttyS0 > earlyprintk=ttyS0 > > Thanks > > Yinghai Yes, both work. -Bin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

On Tue, Jun 02, 2015 at 11:07:39PM +0200, Thomas Gleixner wrote: > What about the memory mapped uarts which have been source of trouble > in the past? > > Thanks, > > tglx Not sure which specific early console you are referring to. Currently we have serial, ttyS, vga, dbgp, xen, efi and

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

On Tue, Jun 02, 2015 at 11:46:02PM +0200, Ingo Molnar wrote: > So the format on x86 used to be: > > earlyprintk=serial,ttyS0,115200 > > does that work too? > > Thanks, > > Ingo Just tested it, and yes it works. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

On Tue, Jun 02, 2015 at 01:54:33PM +0200, Ingo Molnar wrote: > > * Bin Gao wrote: > > > The arch independent uart8250 early console driver has good support for > > memory > > mapped and io port based 8250 uarts. Since pci is arch independent so it's > > natu

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

On Tue, Jun 02, 2015 at 01:54:33PM +0200, Ingo Molnar wrote: * Bin Gao bin@linux.intel.com wrote: The arch independent uart8250 early console driver has good support for memory mapped and io port based 8250 uarts. Since pci is arch independent so it's natural to extend uart8250

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

On Tue, Jun 02, 2015 at 11:46:02PM +0200, Ingo Molnar wrote: So the format on x86 used to be: earlyprintk=serial,ttyS0,115200 does that work too? Thanks, Ingo Just tested it, and yes it works. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

On Tue, Jun 02, 2015 at 11:07:39PM +0200, Thomas Gleixner wrote: What about the memory mapped uarts which have been source of trouble in the past? Thanks, tglx Not sure which specific early console you are referring to. Currently we have serial, ttyS, vga, dbgp, xen, efi and

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

On Wed, Jun 03, 2015 at 12:16:36AM +, Anderson, Stuart R wrote: Bin, et al, What we are losing here is the ability to specify a UART by its bus address instead of just supplying the memory or io address. There are some cases where this is useful, though I admit it is probably not going

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

On Tue, Jun 02, 2015 at 01:37:52PM -0700, Yinghai Lu wrote: how about earlyprintk=serial,ttyS0 earlyprintk=ttyS0 Thanks Yinghai Yes, both work. -Bin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

[PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

5140fda16051 ("Specify PCI based UART for earlyprintk")' is removed. And its equivalent function will be available from uart8250 early console driver. Signed-off-by: Bin Gao --- Changes in v5: - moved earlyprintk= (an alias to earlycon=) from patch 1/2 to patch 2/2 Change

[PATCH v5 1/2] serial_core: add pci uart early console support

the following line to the kernel command line (assume baud rate is 115200): earlyprintk=uart8250,pci32,0:24.2,115200n8 Signed-off-by: Bin Gao --- Changes in v5: - updated Documentation/kernel-parameters.txt. - moved earlyprintk= to patch 2/2 (requires x86 people's review). - rolled back

[PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

5140fda16051 (Specify PCI based UART for earlyprintk)' is removed. And its equivalent function will be available from uart8250 early console driver. Signed-off-by: Bin Gao bin@intel.com --- Changes in v5: - moved earlyprintk= (an alias to earlycon=) from patch 1/2 to patch 2/2 Changes in v2

[PATCH v5 1/2] serial_core: add pci uart early console support

the following line to the kernel command line (assume baud rate is 115200): earlyprintk=uart8250,pci32,0:24.2,115200n8 Signed-off-by: Bin Gao bin@intel.com --- Changes in v5: - updated Documentation/kernel-parameters.txt. - moved earlyprintk= to patch 2/2 (requires x86 people's review

Re: [PATCH v4 1/2] serial_core: add pci uart early console support

On Wed, May 27, 2015 at 08:21:21PM -0400, Peter Hurley wrote: > I meant that the patch hunk below should be moved to patch > 2/2, and the purpose of patch 2/2 should be to replace x86-specific > earlyprintk=pciserial with arch-independent earlyprintk=pciserial. > > There are 2 reasons for my

Re: [PATCH v4 1/2] serial_core: add pci uart early console support

On Wed, May 27, 2015 at 08:21:21PM -0400, Peter Hurley wrote: I meant that the patch hunk below should be moved to patch 2/2, and the purpose of patch 2/2 should be to replace x86-specific earlyprintk=pciserial with arch-independent earlyprintk=pciserial. There are 2 reasons for my

Re: [PATCH v4 1/2] serial_core: add pci uart early console support

On Sun, May 24, 2015 at 12:52:25PM -0700, Greg Kroah-Hartman wrote: > > Signed-off-by: Bin Gao > > --- > > Changes in v4: > > - moved PCI_EARLY definition from arch/x86/Kconfig to drivers/pci/Kconfig > > - added 'earlyprintk' for x86 as alias to the early pa

Re: [PATCH v4 1/2] serial_core: add pci uart early console support

Peter Hurley, First of all, thank you for your reviewing. Please see my answers below. On Tue, May 26, 2015 at 01:12:34PM -0400, Peter Hurley wrote: > Hi Bin, > > Please don't drop lists (or other addressees) from patch revisions. > > [ +cc linux-serial] Will fix this. > Please update

Re: [PATCH v4 1/2] serial_core: add pci uart early console support

Peter Hurley, First of all, thank you for your reviewing. Please see my answers below. On Tue, May 26, 2015 at 01:12:34PM -0400, Peter Hurley wrote: Hi Bin, Please don't drop lists (or other addressees) from patch revisions. [ +cc linux-serial] Will fix this. Please update

Re: [PATCH v4 1/2] serial_core: add pci uart early console support

On Sun, May 24, 2015 at 12:52:25PM -0700, Greg Kroah-Hartman wrote: Signed-off-by: Bin Gao bin@intel.com --- Changes in v4: - moved PCI_EARLY definition from arch/x86/Kconfig to drivers/pci/Kconfig - added 'earlyprintk' for x86 as alias to the early param 'earlycon' What about

[PATCH v4 2/2] arch/x86: remove pci uart early console from early_prink.c

5140fda16051 ("Specify PCI based UART for earlyprintk")' is removed. And its equivalent function will be available from uart8250 early console driver. Signed-off-by: Bin Gao --- arch/x86/kernel/early_printk.c | 180 - 1 file changed, 15 insertio

[PATCH v4 1/2] serial_core: add pci uart early console support

the following line to the kernel command line (assume baud rate is 115200): earlyprintk=uart8250,pci32,0:24.2,115200n8 Signed-off-by: Bin Gao --- Changes in v4: - moved PCI_EARLY definition from arch/x86/Kconfig to drivers/pci/Kconfig - added 'earlyprintk' for x86 as alias to the early param

[PATCH v4 2/2] arch/x86: remove pci uart early console from early_prink.c

5140fda16051 (Specify PCI based UART for earlyprintk)' is removed. And its equivalent function will be available from uart8250 early console driver. Signed-off-by: Bin Gao bin@intel.com --- arch/x86/kernel/early_printk.c | 180 - 1 file changed, 15

[PATCH v4 1/2] serial_core: add pci uart early console support

the following line to the kernel command line (assume baud rate is 115200): earlyprintk=uart8250,pci32,0:24.2,115200n8 Signed-off-by: Bin Gao bin@intel.com --- Changes in v4: - moved PCI_EARLY definition from arch/x86/Kconfig to drivers/pci/Kconfig - added 'earlyprintk' for x86 as alias

Re: [PATCH v4 1/2] serial_core: add pci uart early console support

On Wed, May 20, 2015 at 09:31:45PM -0700, Greg Kroah-Hartman wrote: > What changed in this version? > > You can't just put "v4" without giving us some hint as to the > differences here, sorry. I just resent [PATCH v4 1/2] with "Changes in v4" added. There is no change for patch 2/2 since the

[PATCH v4 1/2] serial_core: add pci uart early console support

the following line to the kernel command line (assume baud rate is 115200): earlyprintk=uart8250,pci32,0:24.2,115200n8 Signed-off-by: Bin Gao --- Changes in v4: - moved PCI_EARLY definition from arch/x86/Kconfig to drivers/pci/Kconfig - added 'earlyprintk' for x86 as alias to the early param

[PATCH v4 1/2] serial_core: add pci uart early console support

the following line to the kernel command line (assume baud rate is 115200): earlyprintk=uart8250,pci32,0:24.2,115200n8 Signed-off-by: Bin Gao bin@intel.com --- Changes in v4: - moved PCI_EARLY definition from arch/x86/Kconfig to drivers/pci/Kconfig - added 'earlyprintk' for x86 as alias

Re: [PATCH v4 1/2] serial_core: add pci uart early console support

On Wed, May 20, 2015 at 09:31:45PM -0700, Greg Kroah-Hartman wrote: What changed in this version? You can't just put v4 without giving us some hint as to the differences here, sorry. I just resent [PATCH v4 1/2] with Changes in v4 added. There is no change for patch 2/2 since the first

<    1   2   3   >