Re: [uml-devel] [PATCH 3/6] UML - Userspace files should call libc directly

2007-08-26 Thread Blaisorblade
er, not to simplify it for users). Btw, the inlined abs() call is not very nice; on the other hand, it's a simple solution to make it robust, and we do not to be extra-optimal on these debug code paths. Bye -- "Doh!" (cit.), I've made another mistake! Paolo Giarrusso, aka Bl

Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style

2007-08-24 Thread Blaisorblade
On venerdì 24 agosto 2007, Jeff Dike wrote: > On Thu, Aug 23, 2007 at 04:54:59PM +0200, Blaisorblade wrote: > > > actually. Personally I'd prefer: > > > > > > else > > > type = OS_TYPE_DIR; > > > > I strongly agree with this s

[PATCH] Script to check for undefined Kconfig symbols - v2

2007-08-24 Thread Paolo 'Blaisorblade' Giarrusso
s(-) diff --git a/scripts/checkunknowndefines.sh b/scripts/checkunknowndefines.sh new file mode 100755 index 000..dbb5cef --- /dev/null +++ b/scripts/checkunknowndefines.sh @@ -0,0 +1,59 @@ +#!/bin/sh +# Find Kconfig variables used in source code but never defined in Kconfig +# Copyright (C) 2007, Paol

[PATCH 2/2] Script to check for undefined Kconfig symbols

2007-08-24 Thread Paolo 'Blaisorblade' Giarrusso
-0,0 +1,59 @@ +#!/bin/sh +# Find Kconfig variables used in source code but never defined in Kconfig +# Copyright (C) 2007, Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> + +# Tested with dash. +paths="$@" +[ -z "$paths" ] && paths=. + +# Doing this once

[PATCH 1/2] Replace CONFIG_USB_OHCI with CONFIG_USB_OHCI_HCD in a few overlooked files

2007-08-24 Thread Paolo &#x27;Blaisorblade' Giarrusso
he fix had not yet been applied. Cc: Giuseppe Patanè <[EMAIL PROTECTED]> Cc: Ralf Baechle <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> --- arch/mips/au1000/mtx-1/board_setup.c |4 ++-- arch/

[PATCH] usbmon doc update - mention new wildcard ('0') bus

2007-08-24 Thread Paolo &#x27;Blaisorblade' Giarrusso
Update usbmon documentation, mentioning the "zero" (wildcard) bus. Possibly, in my first hunk, the 'either ... or ...' should be rephrased a bit to be expressed better. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Cc: USB development list

Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style

2007-08-23 Thread Blaisorblade
Personally I'd prefer: > > else > type = OS_TYPE_DIR; I strongly agree with this style; beyond style itself, one strong reason is that joining statements hinder singlestepping through function code (it's easy to run gdb on UML, and anyway kgdb exists). Bye

Re: [uml-devel] [PATCH] UML - Add a .note.SuSE section

2007-08-23 Thread Blaisorblade
On mercoledì 22 agosto 2007, Jeff Dike wrote: > On Tue, Aug 21, 2007 at 07:05:53PM +0200, Blaisorblade wrote: > > It's not the first time we hit effects of such bugs, is it? > > I don't remember seeing this before. > > > The .note.ABI-tag fix, time ago, may be a

Re: [uml-devel] [PATCH] UML - Add a .note.SuSE section

2007-08-21 Thread Blaisorblade
} > > Ooh, this sounds promising, thanks. It's not the first time we hit effects of such bugs, is it? The .note.ABI-tag fix, time ago, may be about the same problem. Can you double-check all UML linker scripts for more instances of this bug? Bye -- "Doh!" (cit.), I'v

Re: [uml-devel] [PATCH 4/5] UML - Simplify helper stack handling

2007-07-03 Thread Blaisorblade
sprintf() because it used 32K of stack. -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade signature.asc Description: This is a digitally signed message part.

Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Blaisorblade
On mercoledì 20 giugno 2007, Jeff Dike wrote: > On Wed, Jun 20, 2007 at 04:06:58PM +0200, Blaisorblade wrote: > > Oh, it's exactly what CONFIG_DEBUG_STACK_USAGE does for i386... (not sure > > if you were still wondering...). > > Where? The only usage in i386 that I se

Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Blaisorblade
er this thursday (i.e. tomorrow). I'd need to get Jeff's patchset to fix it. Please let me know. Bye! -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade do-src-style-fix Description: application/shellscript

Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring

2007-06-20 Thread Blaisorblade
neric, utilising the > stack-page-zeroing which CONFIG_DEBUG_STACK_USAGE enables. There's nothing > UML-specific about it. > low_water_lock and lowest_to_date should be static to check_stack_usage(), > btw.. -- Inform me of my mistakes, so I can add them to my list! Paolo Giarru

Re: [PATCH 5/6] UML - Network and pcap cleanup

2007-05-03 Thread Blaisorblade
). -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo in

Re: [uml-devel] [PATCH 2/4] UML - tidy process.c

2007-04-03 Thread Blaisorblade
rn unsigned long stack_sp(unsigned long page); > +#endif > extern int kernel_thread_proc(void *data); > extern void syscall_segv(int sig); > extern int current_pid(void); -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://ww

Re: [uml-devel] [RFC] UML kernel & rootfs bundle with every kernel release ?

2007-04-03 Thread Blaisorblade
browser image (running IE via wine in a limited image > with just X + wine + IE - I would much prefer that to having wine+IE > installed locally), testing framebuffer apps like gtk-fb/cairo-fb > without risking your dev environment, etc... > > Antoine -- Inform me of my mistakes, so

Re: [RFC] UML kernel & rootfs bundle with every kernel release ?

2007-04-01 Thread Blaisorblade
hot is a faster COW? Something to setup it automatically would be good). There would be more to say on this, but I can't right now (I've other stuff to do). -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[RFC] Auto-fixups for CodingStyle against major UML violations

2007-03-31 Thread Blaisorblade
Have you got sick of fixing your sources CodingStyle by hand? Are you reintroducing violations because you've always programmed in a certain style and those kernel hacker have dictated an insane one which you'll never learn? Stop that, the spamful company "BlaisorBlade Inc.

Re: [uml-devel] [PATCH] UML - fix I/O hang when multiple devices are in use

2007-03-31 Thread Blaisorblade
On giovedì 29 marzo 2007, Jeff Dike wrote: > On Thu, Mar 29, 2007 at 02:36:43AM +0200, Blaisorblade wrote: > > > Sometimes you need to. I'd probably just remove the do_ubd check and > > > always recall the request function when handling completions, it's &g

Re: [uml-devel] [patch 06/37] UML - Fix static linking

2007-03-30 Thread Blaisorblade
e = .; >__ex_table : { *(__ex_table) } >__stop___ex_table = .; -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

[PATCH] [PATCH] uml: fix static linking for real

2007-03-30 Thread Paolo &#x27;Blaisorblade' Giarrusso
There was a typo in commit 7632fc8f809a97f9d82ce125e8e3e579390ce2e5, preventing it from working - 32bit binaries crashed hopelessly before the below fix and work perfectly now. Merge for 2.6.21, please. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> ---

[PATCH 3/3] slab: avoid __initdata warning (may be a bogus one)

2007-03-30 Thread Paolo &#x27;Blaisorblade' Giarrusso
false positive. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> --- mm/slab.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/slab.c b/mm/slab.c index 0934f8d..0772faf 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -305,7 +305,7 @@ struct

[PATCH 1/3] utrace - uml: make UML compile with utrace enabled

2007-03-30 Thread Paolo &#x27;Blaisorblade' Giarrusso
* The prototype of arch_ptrace doesn't match the one in include/linux/ptrace.h. * utrace_um_native is referred to by utrace_native_view but never defined. Cc: Jeff Dike <[EMAIL PROTECTED]> Cc: Roland McGrath <[EMAIL PROTECTED]> Signed-off-by: Paolo 'Blaisorblade'

Re: [uml-devel] [PATCH 1/2] UML - Fix umid in xterm titles

2007-03-30 Thread Blaisorblade
On venerdì 30 marzo 2007, Jeff Dike wrote: > From: Davide Brini <[EMAIL PROTECTED]> > > Calls lines_init() *after* xterm_title is modified to include umid. > > Signed-off-by: Davide Brini <[EMAIL PROTECTED]> > Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> Acke

[PATCH 2/3] sys_futex64-allows-64bit-futexes-workaround for uml

2007-03-30 Thread Paolo &#x27;Blaisorblade' Giarrusso
. Pierre Peiffer, please consider that. Cc: Pierre Peiffer <[EMAIL PROTECTED]> Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> --- include/asm-um/futex.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/include/asm-um/fu

[PATCH 0/3] mm-only patches

2007-03-30 Thread Paolo &#x27;Blaisorblade' Giarrusso
Patch-arounds for mm-only compile errors/warnings, got on 2.6.21-rc5-mm2, still apply on 2.6.21-rc5-mm3. -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade - To unsubscribe from this list: send the line

Re: [uml-devel] [PATCH 2/2] UML - Speed up exec

2007-03-30 Thread Blaisorblade
force_sig(SIGKILL, current); > + } > + > switch_mm_skas(¤t->mm->context.skas.id); > } -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade Index: linux-2.6.git/arch/um/include/sk

Re: [uml-devel] [PATCH] UML - fix I/O hang when multiple devices are in use

2007-03-30 Thread Blaisorblade
On giovedì 29 marzo 2007, Jeff Dike wrote: > On Thu, Mar 29, 2007 at 02:36:43AM +0200, Blaisorblade wrote: > > > Sometimes you need to. I'd probably just remove the do_ubd check and > > > always recall the request function when handling completions, it's &g

Re: [uml-devel] [PATCH] UML - fix I/O hang when multiple devices are in use

2007-03-28 Thread Blaisorblade
On giovedì 29 marzo 2007, Blaisorblade wrote: > On mercoledì 28 marzo 2007, Jeff Dike wrote: > > [ This patch needs to get into 2.6.21, as it fixes a serious bug > > introduced soon after 2.6.20 ] > > > > Commit 62f96cb01e8de7a5daee472e540f726db2801499 introduced per-d

Re: [uml-devel] [PATCH] UML - fix I/O hang when multiple devices are in use

2007-03-28 Thread Blaisorblade
ike 150 Mbit/s - 100 Mbit/s, depending whether UML trasmits or receives data; with 2GHz double rates). Update: I now get 150Mbit / 200Mbit (Uml receives/Uml sends) at 1GHz, and still the double at 2Ghz. This is a different UML though. * using futexes instead of pipes for synchronization (required

[PATCH][2.6.21] uml: fix unreasonably long udelay

2007-03-28 Thread Paolo &#x27;Blaisorblade' Giarrusso
x86_64 users, especially using Device Mapper. To hit this bug, a compile-time constant time parameter must be passed - that's why UML seems to work most times. Fix this with a simple udelay implementation. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> -

Re: + uml-fix-pte-bit-collision.patch added to -mm tree

2007-03-28 Thread Blaisorblade
On martedì 27 marzo 2007, [EMAIL PROTECTED] wrote: > The patch titled > uml: fix pte bit collision > has been added to the -mm tree. Its filename is > uml-fix-pte-bit-collision.patch ACK from me: Acked-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED

Re: + uml-create-archh.patch added to -mm tree

2007-03-22 Thread Blaisorblade
e -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade Chiacchiera con i tuoi amici in tempo reale! http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com - To unsubscribe from this list: send the lin

Re: [uml-devel] [ PATCH 4/7 ] UML - create as-layout.h

2007-03-22 Thread Blaisorblade
Bye! -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade Chiacchiera con i tuoi amici in tempo reale! http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com - To unsubscribe from this list: send the line

Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

2007-03-21 Thread Blaisorblade
On Tuesday 20 March 2007 07:00, Nick Piggin wrote: > On Mon, Mar 19, 2007 at 09:44:28PM +0100, Blaisorblade wrote: > > On Sunday 18 March 2007 03:50, Nick Piggin wrote: > > > > > Yes, I believe that is the case, however I wonder if that is going > > > > >

Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

2007-03-19 Thread Blaisorblade
On Sunday 18 March 2007 03:50, Nick Piggin wrote: > On Sat, Mar 17, 2007 at 01:17:00PM +0100, Blaisorblade wrote: > > On Tuesday 13 March 2007 02:19, Nick Piggin wrote: > > > On Tue, Mar 13, 2007 at 12:01:13AM +0100, Blaisorblade wrote: > > > > On Wednesday 07 March

Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

2007-03-17 Thread Blaisorblade
On Tuesday 13 March 2007 02:19, Nick Piggin wrote: > On Tue, Mar 13, 2007 at 12:01:13AM +0100, Blaisorblade wrote: > > On Wednesday 07 March 2007 11:02, Nick Piggin wrote: > > > > Yeah, tmpfs/shm segs are what I was thinking about. If UML can live > > > > with th

Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

2007-03-12 Thread Blaisorblade
, I really like removing ->populate and merging the common code together. filemap_populate and shmem_populate are so obnoxiously different that I already wanted to do that (after merging remap_file_pages() core). Also, I'm curious. Since my patches are already changing remap_file_pages() co

Lockdep report against pktcdvd

2007-03-09 Thread Blaisorblade
  56.526335]  [] get_unused_fd+0xfa/0x10b [   56.526356]  [] do_sys_open+0x4d/0xd5 [   56.526377]  [] sys_open+0x1b/0x1d [   56.526396]  [] system_call+0x7e/0x83 [   56.526417] -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~

Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)

2007-03-08 Thread Blaisorblade
hing saved on-disk itself. > > > -- wli -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade Chiacchiera con i tuoi amici in tempo reale! http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo

Re: [patch 027/101] Kconfig: FAULT_INJECTION can be selected only if LOCKDEP is enabled.

2007-03-08 Thread Blaisorblade
On Wednesday 07 March 2007 18:11, Greg KH wrote: > From: "Paolo 'Blaisorblade' Giarrusso" <[EMAIL PROTECTED]> > > There is no prompt for STACKTRACE, so it is enabled only when 'select'ed. > FAULT_INJECTION depends on it, while LOCKDEP selects it.

Re: [uml-devel] [PATCH 4/5] UML - driver formatting fixes

2007-03-06 Thread Blaisorblade
goto out_close; > } The second line should better say -err instead of err. -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade Chiacchiera con i tuoi amici in tempo reale! http://it.yahoo.

[PATCH 1/2] uml: make sigio_lock() irq-safe

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> sigio_lock is taken both from process context and from interrupt context. So we *must* use irqsave. Then, remove irq disabling from update_thread(), as it's called with sigio_lock() held (yes, set_signals(0) is loca

[PATCH 2/2] uml: avoid calling request_irq in atomic context

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> To avoid calling request_irq under a spinlock, and to simplify code around, code a state machine to allow safely dropping and retaking sigio_lock during initialization. The state variable is protected by a spinlock together

Re: [uml-devel] [PATCH 04/11] uml - hostfs: avoid possible escapes from hostfs=.

2007-03-05 Thread Blaisorblade
On Monday 05 March 2007 23:03, Jeff Dike wrote: > On Mon, Mar 05, 2007 at 09:49:02PM +0100, Paolo 'Blaisorblade' Giarrusso wrote: > > From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> > > > > Avoid accepting things like -o .., -o dir/../../

[PATCH 03/11] uml - hostfs: make hostfs= option work as a jail, as intended.

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> When a given host directory is specified to be mounted both in hostfs=path1 and with mount option -o path2, we should give access to path1/path2, but this does not happen. Fix that in the simpler way. Also, root_ino can be

[PATCH 08/11] uml: mark both consoles as CON_ANYTIME

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Since both UML consoles do not use percpu variables, they may be called when the cpu is still offline, and they may be marked CON_ANYTIME (this is documented in kernel/printk.c, grep for CON_ANYTIME to find mentions of this)

[PATCH 05/11] hostfs: rename some vars for clarity

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> * rename name to host_root_path * rename data to req_root. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> --- fs/hostfs/hostfs_kern.c | 26 +- 1 files changed

[PATCH 11/11] uml: fix errno usage

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Avoid reusing userspace errno twice - it can be cleared by libc code everywhere (in particular printk() does clear it in my setup). Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> ---

[PATCH 07/11] uml: remove dead code about os_usr1_signal() and os_usr1_process()

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> os_usr1_signal() is totally unused, os_usr1_process() is used only by TT mode. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> --- arch/um/include/os.h |3 ++- arch/um/os-Linux/

[PATCH 00/11] Uml simple fixes

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
Some tested UML fixes - should be applied for 2.6.21. -- Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo inf

[PATCH 01/11] uml: code convention cleanup of a file

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Fix coding conventions violations is arch/um/os-Linux/helper.c. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> --- arch/um/os-Linux/helper.c |2 +- 1 files changed, 1 insertions(

[PATCH 04/11] uml - hostfs: avoid possible escapes from hostfs=.

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Avoid accepting things like -o .., -o dir/../../dir2, -o dir/../.. . This may be considered useless, but YMMV. I consider that this has a limited security value, exactly like disabling module support (in many case it is usef

[PATCH 09/11] uml: fix confusion irq early reenabling

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Fix confusion about call context - comments and code are inconsistent and plain wrong, my fault. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> --- arch/um/drivers/line.c |6 +++--

[PATCH 06/11] uml: fix a memory leak in the multicast driver

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Memory allocated by mcast_user_init must be freed in the matching mcast_remove. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> --- arch/um/drivers/mcast_user.c | 10 +- 1 f

[PATCH 02/11] uml - hostfs: fix double free

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Fix double free in the error path - when name is assigned into root_inode we do not own it any more and we must not kfree() it - see patch for details. Thanks to William Stearns for the initial report. CC: William

[PATCH 10/11] uml - activate_fd: return ENOMEM only when appropriate

2007-03-05 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Avoid returning ENOMEM in case of a duplicate IRQ - ENOMEM was saved into err earlier. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> --- arch/um/kernel/irq.c |1 + 1 files chang

Re: [uml-devel] [PATCH] UML - Fix 2.6.20 hang

2007-02-21 Thread Blaisorblade
.events = read ? POLLIN : POLLOUT, > Was that removal wanted or it happened by mistake? That way, err is completely lost. -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade Chiacchiera con i tu

Re: [uml-devel] [PATCH 2/3] UML - x86_64 thread fixes

2007-02-21 Thread Blaisorblade
ebug at that time). -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade Chiacchiera con i tuoi amici in tempo reale! http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com - To unsubscribe from this

Re: [uml-devel] [PATCH 4/4] UML - lock host ldt retrieval

2007-02-21 Thread Blaisorblade
Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share > your opinions on IT & business topics through brief surveys-and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV >

Re: patch x86_64-fix-2.6.18-regression-ptrace_oldsetoptions-should-be-accepted.patch queued to -stable tree

2007-02-21 Thread Blaisorblade
ble-queue.git;a=sum >mary Hmm, this should be (note the missing gregkh in the path): http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary -- Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blai

x86_64: PTRACE_[GS]ET_THREAD_AREA should be accepted

2007-02-21 Thread Paolo &#x27;Blaisorblade' Giarrusso
: Andi Kleen <[EMAIL PROTECTED]> Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Index: linux-2.6.18/arch/x86_64/ia32/ptrace32.c === --- linux-2.6.18.orig/arch/x86_64/ia32/ptrace32.c +++ linux-2

Re: [uml-devel] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted

2007-02-16 Thread Blaisorblade
On Friday 16 February 2007 20:02, Jeff Dike wrote: > On Thu, Feb 15, 2007 at 08:05:56PM +0100, Blaisorblade wrote: > > Jeff, I verified my patch is _almost_ enough for 2.6.18 for fully booting > > a 32bit UML; on 2.6.18 I had to also add PTRACE_GET/SET_THREAD_AREA (this > &

Re: [uml-devel] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted

2007-02-16 Thread Blaisorblade
o I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade Chiacchiera con i tuoi amici in tempo reale! http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [uml-devel] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted

2007-02-14 Thread Blaisorblade
On Thursday 15 February 2007 03:54, Jeff Dike wrote: > On Thu, Feb 15, 2007 at 03:34:23AM +0100, Paolo 'Blaisorblade' Giarrusso wrote: > > Index: linux-2.6.git/arch/x86_64/ia32/ptrace32.c > > === > &

x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted

2007-02-14 Thread Paolo &#x27;Blaisorblade' Giarrusso
was a style change - when a case is added, it must be explicitly tested this way. In this case, not enough testing was done. Cc: Andi Kleen <[EMAIL PROTECTED]> Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Index: linux-2.6.git/arch/

[PATCH] Kconfig: FAULT_INJECTION can be selected only if LOCKDEP is enabled.

2007-02-12 Thread Paolo &#x27;Blaisorblade' Giarrusso
There is no prompt for STACKTRACE, so it is enabled only when 'select'ed. FAULT_INJECTION depends on it, while LOCKDEP selects it. So FAULT_INJECTION becomes visible in Kconfig only when LOCKDEP is enabled. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]>

Re: [uml-devel] [PATCH] [UML] fix mknod

2007-01-26 Thread Blaisorblade
On Thursday 25 January 2007 05:31, Andrew Morton wrote: > On Tue, 23 Jan 2007 23:33:29 +0100 > > Blaisorblade <[EMAIL PROTECTED]> wrote: > > On Tuesday 23 January 2007 14:17, Johannes Stezenbach wrote: > > > On Tue, Jan 23, 2007 at 09:02:30AM +0100, Blaisorblade wrote

Re: [uml-devel] [PATCH] [UML] fix mknod

2007-01-23 Thread Blaisorblade
On Tuesday 23 January 2007 14:17, Johannes Stezenbach wrote: > On Tue, Jan 23, 2007 at 09:02:30AM +0100, Blaisorblade wrote: > > On Monday 22 January 2007 21:13, Johannes Stezenbach wrote: > > > I was playing with user-mode Linux and found that mknod creates > > > device

Re: [uml-devel] [PATCH] [UML] fix mknod

2007-01-23 Thread Blaisorblade
join.php&p=sourceforge&CID=DEVDEV > ___ > User-mode-linux-devel mailing list > User-mode-linux-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel -- Inform me of my mistakes, so I can add th

Re: [uml-devel] [PATCH 1/6] UML - Console locking fixes

2007-01-03 Thread Blaisorblade
(unlike the count) nobody but the original setter is allowed to change it, and that who finds it set (say a concurrent open) must return without touching it. The state diagram is like: CLOSED -> OPENING -> OPEN (only the function which triggered the transition from CLOSED to OPENING ca

Re: [PATCH 1/2] Make x86_64 udelay() round up instead of down - try2

2006-11-17 Thread Blaisorblade
On Friday 17 November 2006 23:00, Andrew Morton wrote: > On Fri, 17 Nov 2006 20:30:47 +0100 > > "Paolo 'Blaisorblade' Giarrusso" <[EMAIL PROTECTED]> wrote: > > Port two patches from i386 to x86_64 delay.c to make sure all rounding is > > done upw

TTY layer locking design

2006-11-17 Thread Blaisorblade
s can be avoided in other drivers. -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade Chiacchiera con i tuoi amici in tempo reale! http://it.yahoo.com/mail_it/foot/*http://it

We're still coping with GCC < 3.0

2006-11-17 Thread Blaisorblade
re promptly removed when deprecating old compilers. What about this? -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade Chiacchie

[PATCH 1/2] Make x86_64 udelay() round up instead of down - try2

2006-11-17 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Port two patches from i386 to x86_64 delay.c to make sure all rounding is done upward instead of downward. There is no sign in commit messages that the mismatch was done on purpose, and "delay() guarantees slee

[PATCH 2/2] i386, x86_64: comment magic constants in delay.h

2006-11-17 Thread Paolo &#x27;Blaisorblade' Giarrusso
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> For both i386 and x86_64, copy from arch/$ARCH/lib/delay.c comments about the used magic constants, plus a few other niceties. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> --- i

Re: [uml-devel] Re: [RFC] [patch 0/18] remap_file_pages protection support (for UML), try 3

2005-09-04 Thread Blaisorblade
On Friday 02 September 2005 23:02, Hugh Dickins wrote: > On Fri, 26 Aug 2005, Blaisorblade wrote: > > * The first 2 patches modify the PTE encoding macros and start preparing > > the VM for the new situation (i.e. VMA which have variable protections, > > which are called VM_

Re: [uml-devel] Re: [patch 1/3] uml: share page bits handling between 2 and 3 level pagetables

2005-09-04 Thread Blaisorblade
On Friday 02 September 2005 22:17, Jeff Dike wrote: > On Wed, Aug 10, 2005 at 09:37:28PM +0200, Blaisorblade wrote: > > Also look, on the "set_pte" theme, at the attached patch. > + WARN_ON(!pte_young(*pte) || pte_write(*pte) && !pte_dirty(*pte)); > This

Re: [uml-devel] [PATCH 10/12] UML - Allow host capability usage to be disabled

2005-09-02 Thread Blaisorblade
> Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA > Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > ___ > User-mode-linux-devel mailing list &g

Re: [patch 1/1] Ptrace - i386: fix "syscall audit" interaction with singlestep

2005-09-01 Thread Blaisorblade
On Wednesday 31 August 2005 04:02, Andrew Morton wrote: > [EMAIL PROTECTED] wrote: > > From: Bodo Stroesser <[EMAIL PROTECTED]>, Paolo > > 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> CC: Roland McGrath > > <[EMAIL PROTECTED]> > > > &g

Memory reclaim: permanently pinned dentries (aka libfs/sysfs) and the blunderbuss effect

2005-09-01 Thread Blaisorblade
uld probably be fixed some way. -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade _

Re: [patch 1/2] Fixup symlink function pointers for hppfs [for 2.6.13]

2005-08-26 Thread Blaisorblade
On Friday 26 August 2005 21:03, Al Viro wrote: > On Fri, Aug 26, 2005 at 04:57:44PM +0200, [EMAIL PROTECTED] wrote: > > From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> > > Update hppfs for the symlink functions prototype change. > > Should be tr

Re: [uml-devel] Re: [RFC] [patch 0/18] remap_file_pages protection support (for UML), try 3

2005-08-26 Thread Blaisorblade
On Friday 26 August 2005 21:11, Hugh Dickins wrote: > On Fri, 26 Aug 2005, Blaisorblade wrote: > > This is a followup to my post of last week (Aug 12) about > > remap_file_pages protection support. I've improved and consolidated the > > patches and updated them agains

[RFC] [patch 0/18] remap_file_pages protection support (for UML), try 3

2005-08-26 Thread Blaisorblade
. But here we are reading pages, not the reverse! Seems rewriting the kernel locking is a quite time-consuming task! -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade fremap-test-complete.c.bz2 Description: BZip2 compressed data

Re: remove-stale-comment-from-swapfilec.patch added to -mm tree

2005-08-26 Thread Blaisorblade
On Wednesday 24 August 2005 15:26, Hugh Dickins wrote: > On Wed, 17 Aug 2005 [EMAIL PROTECTED] wrote: > > From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> > > Seems like on 2.4.9.4 this comment got out of sync ;-) > Not at all. That comment (not mine

[patch 05/18] remap_file_pages protection support: enhance syscall interface

2005-08-26 Thread blaisorblade
From: Ingo Molnar <[EMAIL PROTECTED]>, Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> This contains simply the changes to the syscall code, based on Ingo's patch. Differently from his one, I've *not* added a new syscall, choosing to add a new flag (MAP_NOINH

[patch 18/18] remap_file_pages linear nonuniform support: (2) fix truncation on nonuniform VMA

2005-08-26 Thread blaisorblade
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Since we aren't going to support nonuniform linear VMAs, this is probably not needed. Otherwise, you may want to look at this patch, but I must first note that it's a bit intrusive. We must save protections a

[patch 01/18] remap_file_pages protection support: uml, i386, x64 bits

2005-08-26 Thread blaisorblade
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]>, Ingo Molnar <[EMAIL PROTECTED]> Update pte encoding macros for UML, i386 and x86-64. Also, add the MAP_NOINHERIT flag to arch headers. *** remap_file_pages protection support: improvement for UML bits Recover o

[patch 11/18] remap_file_pages protection support: also set VM_NONLINEAR on nonuniform VMAs

2005-08-26 Thread blaisorblade
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> To simplify the VM code, and to reflect expected application usage, we decide to also set VM_NONLINEAR when setting VM_NONUNIFORM. Otherwise, we'd have to possibly save nonlinear PTEs even on paths which cope w

[patch 17/18] remap_file_pages linear nonuniform support: (1) try_to_unmap_one fix

2005-08-26 Thread blaisorblade
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Since we probably will not support linear nonuniform VMAs, this will not probably be needed. However I'm sending it just in case. Fix try_to_unmap_one for linear VM_NONUNIFORM vma's. When unmapping linea

[patch 16/18] remap_file_pages protection support: avoid truncating COW PTEs

2005-08-26 Thread blaisorblade
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]>, Ingo Molnar <[EMAIL PROTECTED]> This patch may or may not be wanted. I took this from the original Ingo's patch and improved it, but probably we want to keep this bug. However, I'm not sure of what Ing

[patch 10/18] remap_file_pages protection support: adapt to uml peculiarities

2005-08-26 Thread blaisorblade
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Uml is particular in respect with other architectures (and possibly this is to fix) in the fact that our arch fault handler handles indifferently both TLB and page faults. In particular, we may get to call handle_mm_fault()

[patch 08/18] remap file pages protection support: use FAULT_SIGSEGV for protection checking

2005-08-26 Thread blaisorblade
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]>, Ingo Molnar <[EMAIL PROTECTED]> This is the more intrusive patch, but it can't be reduced a lot, even if I limit the protection support to the bare minimum for Uml. The arch handler used to check itself prote

[patch 12/18] remap_file_pages protection support: optimize install_file_pte for MAP_POPULATE

2005-08-26 Thread blaisorblade
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Add an optimization to install_file_pte: if the VMA is uniform (and thus we're likely called by MAP_POPULATE), and the PTE was null, it will be installed correctly if needed at fault time - we avoid thus touching th

[patch 09/18] remap_file_pages protection support: fix get_user_pages() on VM_NONUNIFORM vmas

2005-08-26 Thread blaisorblade
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> get_user_pages may well call handle_mm_fault on present and valid PTEs. Signal that by using VM_MAYREAD in the access_mask. Also, get_user_pages() may give write faults on present readonly PTEs in VM_NONUNIFORM

[patch 06/18] remap_file_pages protection support: support private vma for MAP_POPULATE

2005-08-26 Thread blaisorblade
From: Ingo Molnar <[EMAIL PROTECTED]> Fix MAP_POPULATE | MAP_PRIVATE. We don't need the VMA to be shared if we don't rearrange pages around. And it's trivial to do. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> --- linux-2.6.git-paolo/

[patch 03/18] remap_file_pages protection support: make mprotect skip pagetables on nonuniform

2005-08-26 Thread blaisorblade
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> There is IMHO no reason to support using mprotect on non-uniform VMAs. The only exception is to change the VMA's default protection (which is used for non-individually remapped pages), but it must still ignore the pa

[patch 14/18] remap_file_pages protection support: avoid lookup and I/O of pages for PROT_NONE remapping

2005-08-26 Thread blaisorblade
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]>, Ingo Molnar <[EMAIL PROTECTED]> This optimization avoid looking up pages for PROT_NONE mappings, and instead simply clear the page tables. This code was taken straight from Ingo's patch. However, this code is

[patch 02/18] remap_file_pages protection support: handle nonuniform VMAs

2005-08-26 Thread blaisorblade
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> Handle the possible existance of VM_NONUNIFORM vmas, without actually creating them. * Replace old uses of pgoff_to_pte with pgoff_prot_to_pte. * Introduce the flag, use it to read permissions from the PTE rather than from

[patch 04/18] remap_file_pages protection support: cleanup syscall checks

2005-08-26 Thread blaisorblade
From: Paolo 'Blaisorblade' Giarrusso <[EMAIL PROTECTED]> This patch reorganizes the code only, without differences in behaviour. It makes the code more readable on its own, and is needed for next patches. I've split this out to avoid cluttering real patches. Signed-off-by

  1   2   3   4   >