Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-27 Thread Boris Brezillon
On Mon, 27 Aug 2018 23:02:29 +0800 (CST) liuxiang wrote: > Fixes:e46ecda764dc37f9fc6279d95ea2c007daef1a71("mtd: spi-nor: Add Freescale > QuadSPI driver") 12 digits should be enough for the commit-id. > Cc: sta...@vger.kernel.org > > Should I send a V2 patch that adds these above? Yes

Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-27 Thread Boris Brezillon
On Mon, 27 Aug 2018 23:02:29 +0800 (CST) liuxiang wrote: > Fixes:e46ecda764dc37f9fc6279d95ea2c007daef1a71("mtd: spi-nor: Add Freescale > QuadSPI driver") 12 digits should be enough for the commit-id. > Cc: sta...@vger.kernel.org > > Should I send a V2 patch that adds these above? Yes

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-08-27 Thread Boris Brezillon
On Mon, 27 Aug 2018 10:44:14 +0200 Johan Hovold wrote: > On Mon, Aug 27, 2018 at 10:28:20AM +0200, Boris Brezillon wrote: > > Hi Johan > > > > On Mon, 27 Aug 2018 10:21:49 +0200 > > Johan Hovold wrote: > > > > > Use the new of_get_compatible_child()

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-08-27 Thread Boris Brezillon
On Mon, 27 Aug 2018 10:44:14 +0200 Johan Hovold wrote: > On Mon, Aug 27, 2018 at 10:28:20AM +0200, Boris Brezillon wrote: > > Hi Johan > > > > On Mon, 27 Aug 2018 10:21:49 +0200 > > Johan Hovold wrote: > > > > > Use the new of_get_compatible_child()

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-08-27 Thread Boris Brezillon
> Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") > Cc: stable # 4.11 > Cc: Nicolas Ferre > Cc: Josh Wu > Cc: Boris Brezillon > Signed-off-by: Johan Hovold Acked-by: Boris Brezillon I'll let Miquel queue this patch to the nand/next branch

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-08-27 Thread Boris Brezillon
> Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") > Cc: stable # 4.11 > Cc: Nicolas Ferre > Cc: Josh Wu > Cc: Boris Brezillon > Signed-off-by: Johan Hovold Acked-by: Boris Brezillon I'll let Miquel queue this patch to the nand/next branch

Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-27 Thread Boris Brezillon
On Sat, 18 Aug 2018 17:14:23 +0800 Liu Xiang wrote: > If the size of spi-nor flash is larger than 16MB, the read_opcode > is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will > return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can > cause read operation fail. > >

Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB

2018-08-27 Thread Boris Brezillon
On Sat, 18 Aug 2018 17:14:23 +0800 Liu Xiang wrote: > If the size of spi-nor flash is larger than 16MB, the read_opcode > is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will > return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can > cause read operation fail. > >

Re: [PATCH] mtd: rawnand: atmel: use struct_size() in devm_kzalloc()

2018-08-27 Thread Boris Brezillon
Hi Gustavo, On Thu, 23 Aug 2018 20:09:38 -0500 "Gustavo A. R. Silva" wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: >

Re: [PATCH] mtd: rawnand: atmel: use struct_size() in devm_kzalloc()

2018-08-27 Thread Boris Brezillon
Hi Gustavo, On Thu, 23 Aug 2018 20:09:38 -0500 "Gustavo A. R. Silva" wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: >

Re: [PATCH v2] mtd: rawnand: denali: do not pass zero maxchips to nand_scan()

2018-08-27 Thread Boris Brezillon
On Mon, 27 Aug 2018 16:01:41 +0900 Masahiro Yamada wrote: > Commit 49aa76b16676 ("mtd: rawnand: do not execute nand_scan_ident() > if maxchips is zero") gave a new meaning for calling nand_scan_ident() > with maxchips=0. > > It is a special usage for some drivers such as docg4, but actually >

Re: [PATCH v2] mtd: rawnand: denali: do not pass zero maxchips to nand_scan()

2018-08-27 Thread Boris Brezillon
On Mon, 27 Aug 2018 16:01:41 +0900 Masahiro Yamada wrote: > Commit 49aa76b16676 ("mtd: rawnand: do not execute nand_scan_ident() > if maxchips is zero") gave a new meaning for calling nand_scan_ident() > with maxchips=0. > > It is a special usage for some drivers such as docg4, but actually >

Re: [PATCH] mtd: rawnand: denali: do not pass zero maxchips to nand_scan()

2018-08-24 Thread Boris Brezillon
On Sat, 25 Aug 2018 00:04:43 +0900 Masahiro Yamada wrote: > Hi Boris, > > 2018-08-24 21:55 GMT+09:00 Boris Brezillon : > > Hi Masahiro, > > > > On Tue, 21 Aug 2018 17:23:19 +0900 > > Masahiro Yamada wrote: > > > >> Commit 49aa76b1667

Re: [PATCH] mtd: rawnand: denali: do not pass zero maxchips to nand_scan()

2018-08-24 Thread Boris Brezillon
On Sat, 25 Aug 2018 00:04:43 +0900 Masahiro Yamada wrote: > Hi Boris, > > 2018-08-24 21:55 GMT+09:00 Boris Brezillon : > > Hi Masahiro, > > > > On Tue, 21 Aug 2018 17:23:19 +0900 > > Masahiro Yamada wrote: > > > >> Commit 49aa76b1667

Re: [PATCH v4 3/3] mtd: rawnand: ams-delta: Set port direction when needed

2018-08-24 Thread Boris Brezillon
> needed. > > This optimisation will become particularly important as soon as > planned conversion of the driver to GPIO API for data I/O will be > implemented. > > Signed-off-by: Janusz Krzysztofik Reviewed-by: Boris Brezillon > --- > d

Re: [PATCH v4 3/3] mtd: rawnand: ams-delta: Set port direction when needed

2018-08-24 Thread Boris Brezillon
> needed. > > This optimisation will become particularly important as soon as > planned conversion of the driver to GPIO API for data I/O will be > implemented. > > Signed-off-by: Janusz Krzysztofik Reviewed-by: Boris Brezillon > --- > d

Re: [PATCH] mtd: rawnand: denali: do not pass zero maxchips to nand_scan()

2018-08-24 Thread Boris Brezillon
Hi Masahiro, On Tue, 21 Aug 2018 17:23:19 +0900 Masahiro Yamada wrote: > Commit 49aa76b16676 ("mtd: rawnand: do not execute nand_scan_ident() > if maxchips is zero") gave a new meaning for calling nand_scan_ident() > with maxchips=0. > > It is a special usage for some drivers such as docg4,

Re: [PATCH] mtd: rawnand: denali: do not pass zero maxchips to nand_scan()

2018-08-24 Thread Boris Brezillon
Hi Masahiro, On Tue, 21 Aug 2018 17:23:19 +0900 Masahiro Yamada wrote: > Commit 49aa76b16676 ("mtd: rawnand: do not execute nand_scan_ident() > if maxchips is zero") gave a new meaning for calling nand_scan_ident() > with maxchips=0. > > It is a special usage for some drivers such as docg4,

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-24 Thread Boris Brezillon
On Wed, 22 Aug 2018 22:08:42 +0800 Liang Yang wrote: > > You have to wait tWB, that's for sure. > > > we have a maximum 32 commands fifo. when command is written into > NFC_REG_CMD, it doesn't mean that command is executing right now, maybe > it is buffering on the queue.Assume one ERASE

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-24 Thread Boris Brezillon
On Wed, 22 Aug 2018 22:08:42 +0800 Liang Yang wrote: > > You have to wait tWB, that's for sure. > > > we have a maximum 32 commands fifo. when command is written into > NFC_REG_CMD, it doesn't mean that command is executing right now, maybe > it is buffering on the queue.Assume one ERASE

Re: [PATCH] mtd: rawnand: jz4780: use struct_size() in devm_kzalloc()

2018-08-23 Thread Boris Brezillon
ruct_size() helper: > > instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL); Oh, I didn't know about that one. That's nice! > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/jz4780_nand.c | 2 +- > 1

Re: [PATCH] mtd: rawnand: jz4780: use struct_size() in devm_kzalloc()

2018-08-23 Thread Boris Brezillon
ruct_size() helper: > > instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL); Oh, I didn't know about that one. That's nice! > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/jz4780_nand.c | 2 +- > 1

Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-08-21 Thread Boris Brezillon
On Tue, 21 Aug 2018 09:22:07 + Naga Sureshkumar Relli wrote: > Hi Boris, > > > -Original Message- > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > Sent: Tuesday, August 21, 2018 11:30 AM > > To: Naga Sureshkumar Relli > >

Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-08-21 Thread Boris Brezillon
On Tue, 21 Aug 2018 09:22:07 + Naga Sureshkumar Relli wrote: > Hi Boris, > > > -Original Message- > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > Sent: Tuesday, August 21, 2018 11:30 AM > > To: Naga Sureshkumar Relli > >

Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-08-21 Thread Boris Brezillon
On Tue, 21 Aug 2018 10:44:54 + Naga Sureshkumar Relli wrote: > Hi Miquel, > > > -Original Message- > > From: Miquel Raynal [mailto:miquel.ray...@bootlin.com] > > Sent: Tuesday, August 21, 2018 3:23 PM > > To: Naga Sureshkumar Relli > > Cc: Boris

Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-08-21 Thread Boris Brezillon
On Tue, 21 Aug 2018 10:44:54 + Naga Sureshkumar Relli wrote: > Hi Miquel, > > > -Original Message- > > From: Miquel Raynal [mailto:miquel.ray...@bootlin.com] > > Sent: Tuesday, August 21, 2018 3:23 PM > > To: Naga Sureshkumar Relli > > Cc: Boris

Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-08-21 Thread Boris Brezillon
On Tue, 21 Aug 2018 05:47:18 + Naga Sureshkumar Relli wrote: > > > +Required properties: > > > +- compatible:Should be "xlnx,zynqmp-nand" or > > > "arasan,nfc-v3p10" > > > > In your example it's not an "or" since both are defined. > In our previous discussion

Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-08-21 Thread Boris Brezillon
On Tue, 21 Aug 2018 05:47:18 + Naga Sureshkumar Relli wrote: > > > +Required properties: > > > +- compatible:Should be "xlnx,zynqmp-nand" or > > > "arasan,nfc-v3p10" > > > > In your example it's not an "or" since both are defined. > In our previous discussion

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Boris Brezillon
Hi Naga, On Fri, 17 Aug 2018 18:49:24 +0530 Naga Sureshkumar Relli wrote: > > +config MTD_NAND_ARASAN > + tristate "Support for Arasan Nand Flash controller" > + depends on HAS_IOMEM > + depends on HAS_DMA Just nitpicking, but you can place them on the same line: depends

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Boris Brezillon
Hi Naga, On Fri, 17 Aug 2018 18:49:24 +0530 Naga Sureshkumar Relli wrote: > > +config MTD_NAND_ARASAN > + tristate "Support for Arasan Nand Flash controller" > + depends on HAS_IOMEM > + depends on HAS_DMA Just nitpicking, but you can place them on the same line: depends

Re: [PATCH] mtd: m25p80: consider max message size when use the spi_mem_xx() API

2018-08-20 Thread Boris Brezillon
On Mon, 20 Aug 2018 13:01:13 + David Laight wrote: > From: Chuanhua Han > > Sent: 20 August 2018 13:44 > > Still no message here, and the subject prefix is still wrong. Fixes and Cc-stable tags should be placed here... > > Signed-off-by: Chuanhua Han > > --- > > Changes in v3: > >

Re: [PATCH] mtd: m25p80: consider max message size when use the spi_mem_xx() API

2018-08-20 Thread Boris Brezillon
On Mon, 20 Aug 2018 13:01:13 + David Laight wrote: > From: Chuanhua Han > > Sent: 20 August 2018 13:44 > > Still no message here, and the subject prefix is still wrong. Fixes and Cc-stable tags should be placed here... > > Signed-off-by: Chuanhua Han > > --- > > Changes in v3: > >

Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-08-20 Thread Boris Brezillon
On Fri, 17 Aug 2018 18:49:23 +0530 Naga Sureshkumar Relli wrote: > This patch adds the dts binding document for arasan nand flash > controller. > > Signed-off-by: Naga Sureshkumar Relli > --- > Changes in v10: > - None > Changes in v9: > - None > Changes in v8: > - Updated compatible and

Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-08-20 Thread Boris Brezillon
On Fri, 17 Aug 2018 18:49:23 +0530 Naga Sureshkumar Relli wrote: > This patch adds the dts binding document for arasan nand flash > controller. > > Signed-off-by: Naga Sureshkumar Relli > --- > Changes in v10: > - None > Changes in v9: > - None > Changes in v8: > - Updated compatible and

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Boris Brezillon
On Mon, 20 Aug 2018 12:21:12 + Naga Sureshkumar Relli wrote: > Hi Boris, > > > -Original Message- > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > Sent: Monday, August 20, 2018 5:40 PM > > To: Naga Sureshkumar Relli > > Cc: r

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Boris Brezillon
On Mon, 20 Aug 2018 12:21:12 + Naga Sureshkumar Relli wrote: > Hi Boris, > > > -Original Message- > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > Sent: Monday, August 20, 2018 5:40 PM > > To: Naga Sureshkumar Relli > > Cc: r

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Boris Brezillon
On Mon, 20 Aug 2018 10:49:38 + Naga Sureshkumar Relli wrote: > > Thanks for your suggestion and are you saying something like Marvell parser > patterns for nfcv1 as below? > > static const struct nand_op_parser marvell_nfcv1_op_parser = NAND_OP_PARSER( > /* Naked commands not

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Boris Brezillon
On Mon, 20 Aug 2018 10:49:38 + Naga Sureshkumar Relli wrote: > > Thanks for your suggestion and are you saying something like Marvell parser > patterns for nfcv1 as below? > > static const struct nand_op_parser marvell_nfcv1_op_parser = NAND_OP_PARSER( > /* Naked commands not

Re: [PATCH] mtd: m25p80: consider max message size when use the spi_mem_xx() API

2018-08-20 Thread Boris Brezillon
Hi Chuanhua, On Mon, 20 Aug 2018 17:43:26 +0800 Chuanhua Han wrote: Subject prefix should be "spi: spi-mem: " not "mtd: m25p80: ", and you need a commit message explaining what this patch does and why it's needed. > Signed-off-by: Chuanhua Han Fixes: c36ff266dc82 ("spi: Extend the core to

Re: [PATCH] mtd: m25p80: consider max message size when use the spi_mem_xx() API

2018-08-20 Thread Boris Brezillon
Hi Chuanhua, On Mon, 20 Aug 2018 17:43:26 +0800 Chuanhua Han wrote: Subject prefix should be "spi: spi-mem: " not "mtd: m25p80: ", and you need a commit message explaining what this patch does and why it's needed. > Signed-off-by: Chuanhua Han Fixes: c36ff266dc82 ("spi: Extend the core to

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Boris Brezillon
On Sat, 18 Aug 2018 05:49:32 + Naga Sureshkumar Relli wrote: > Hi Boris, > > Thanks for the review. > > > -Original Message----- > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > Sent: Friday, August 17, 2018 11:29 PM > > To: Naga S

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Boris Brezillon
On Sat, 18 Aug 2018 05:49:32 + Naga Sureshkumar Relli wrote: > Hi Boris, > > Thanks for the review. > > > -Original Message----- > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > Sent: Friday, August 17, 2018 11:29 PM > > To: Naga S

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-17 Thread Boris Brezillon
Hi Naga, On Fri, 17 Aug 2018 18:49:24 +0530 Naga Sureshkumar Relli wrote: > +static int anfc_exec_op_cmd(struct nand_chip *chip, > +const struct nand_subop *subop) > +{ > + const struct nand_op_instr *instr; > + struct anfc_op nfc_op = {}; > + struct

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-17 Thread Boris Brezillon
Hi Naga, On Fri, 17 Aug 2018 18:49:24 +0530 Naga Sureshkumar Relli wrote: > +static int anfc_exec_op_cmd(struct nand_chip *chip, > +const struct nand_subop *subop) > +{ > + const struct nand_op_instr *instr; > + struct anfc_op nfc_op = {}; > + struct

Re: how to fix acpi_pci_root_remap_iospace?

2018-08-17 Thread Boris Brezillon
On Fri, 17 Aug 2018 15:56:23 + "Luck, Tony" wrote: > >> - Some targets don't have any support for I/O space on their PCI bus and > >> just > >>want to get things to compile by setting PCI_IOBASE to zero, this still > >> opens > >> up some of the same problems as above, but doesn't

Re: how to fix acpi_pci_root_remap_iospace?

2018-08-17 Thread Boris Brezillon
On Fri, 17 Aug 2018 15:56:23 + "Luck, Tony" wrote: > >> - Some targets don't have any support for I/O space on their PCI bus and > >> just > >>want to get things to compile by setting PCI_IOBASE to zero, this still > >> opens > >> up some of the same problems as above, but doesn't

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-17 Thread Boris Brezillon
On Fri, 17 Aug 2018 21:03:59 +0800 Liang Yang wrote: > Hi Boris, > On 2018/8/2 5:50, Boris Brezillon wrote: > > > Hi Yixun, > > > > On Thu, 19 Jul 2018 17:46:12 +0800 > > Yixun Lan wrote: > > > > I haven't finished reviewing the driver yet (I'

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-17 Thread Boris Brezillon
On Fri, 17 Aug 2018 21:03:59 +0800 Liang Yang wrote: > Hi Boris, > On 2018/8/2 5:50, Boris Brezillon wrote: > > > Hi Yixun, > > > > On Thu, 19 Jul 2018 17:46:12 +0800 > > Yixun Lan wrote: > > > > I haven't finished reviewing the driver yet (I'

Re: [PATCH] spi: fsl-espi: master->mem_ops is implemented in the controller

2018-08-17 Thread Boris Brezillon
On Fri, 17 Aug 2018 18:07:05 +0800 Chuanhua Han wrote: > The length of the transmitted data needs to be adjusted due to the maximum > length limit for espi transmission messages > > Signed-off-by: Chuanhua Han > --- > drivers/spi/spi-fsl-espi.c | 25 + > 1 file

Re: [PATCH] spi: fsl-espi: master->mem_ops is implemented in the controller

2018-08-17 Thread Boris Brezillon
On Fri, 17 Aug 2018 18:07:05 +0800 Chuanhua Han wrote: > The length of the transmitted data needs to be adjusted due to the maximum > length limit for espi transmission messages > > Signed-off-by: Chuanhua Han > --- > drivers/spi/spi-fsl-espi.c | 25 + > 1 file

Re: how to fix acpi_pci_root_remap_iospace?

2018-08-17 Thread Boris Brezillon
On Fri, 17 Aug 2018 10:47:34 +0200 Arnd Bergmann wrote: > On Fri, Aug 17, 2018 at 1:27 AM Luck, Tony wrote: > > > > On Thu, Aug 16, 2018 at 11:10:33PM +0200, Arnd Bergmann wrote: > > > Another way would be to add > > > > > > #include > > > +#undef PCI_IOBASE > > > > > > in your asm/io.h.

Re: how to fix acpi_pci_root_remap_iospace?

2018-08-17 Thread Boris Brezillon
On Fri, 17 Aug 2018 10:47:34 +0200 Arnd Bergmann wrote: > On Fri, Aug 17, 2018 at 1:27 AM Luck, Tony wrote: > > > > On Thu, Aug 16, 2018 at 11:10:33PM +0200, Arnd Bergmann wrote: > > > Another way would be to add > > > > > > #include > > > +#undef PCI_IOBASE > > > > > > in your asm/io.h.

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-17 Thread Boris Brezillon
Hi Yixun, I know I said I would finish reviewing the driver, but I didn't have time to do it, so feel free to send a new version addressing the comments I already made. On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: > +static void meson_nfc_select_chip(struct mtd_info *mtd, int chip) >

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-17 Thread Boris Brezillon
Hi Yixun, I know I said I would finish reviewing the driver, but I didn't have time to do it, so feel free to send a new version addressing the comments I already made. On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: > +static void meson_nfc_select_chip(struct mtd_info *mtd, int chip) >

Re: [PATCH v3 7/7] mtd: rawnand: ams-delta: use GPIO API for data I/O

2018-08-16 Thread Boris Brezillon
On Tue, 14 Aug 2018 00:34:48 +0200 Janusz Krzysztofik wrote: > Don't readw()/writew() data directly from/to GPIO port which is under > control of gpio-omap driver, use GPIO API instead. > > Degrade of performance on Amstrad Delta is significant, can be > recognized as a regression, that's why

Re: [PATCH v3 7/7] mtd: rawnand: ams-delta: use GPIO API for data I/O

2018-08-16 Thread Boris Brezillon
On Tue, 14 Aug 2018 00:34:48 +0200 Janusz Krzysztofik wrote: > Don't readw()/writew() data directly from/to GPIO port which is under > control of gpio-omap driver, use GPIO API instead. > > Degrade of performance on Amstrad Delta is significant, can be > recognized as a regression, that's why

Re: [PATCH v3 5/7] mtd: rawnand: ams-delta: Set port direction when needed

2018-08-16 Thread Boris Brezillon
On Tue, 14 Aug 2018 00:34:46 +0200 Janusz Krzysztofik wrote: > In its current shape, the driver sets data port direction before each > byte read/write operation, even during multi-byte transfers. Improve > performance of the driver by setting the port direction only when > needed. > > This

Re: [PATCH v3 5/7] mtd: rawnand: ams-delta: Set port direction when needed

2018-08-16 Thread Boris Brezillon
On Tue, 14 Aug 2018 00:34:46 +0200 Janusz Krzysztofik wrote: > In its current shape, the driver sets data port direction before each > byte read/write operation, even during multi-byte transfers. Improve > performance of the driver by setting the port direction only when > needed. > > This

Re: [PATCH] mtd: m25p80: consider max message size in m25p80_read when use the spi_mem_xx() API

2018-08-16 Thread Boris Brezillon
Hi Chuanhua, On Wed, 15 Aug 2018 14:33:43 +0800 Chuanhua Han wrote: > Consider a message size limit when calculating the maximum amount > of data that can be read. > > Signed-off-by: Chuanhua Han > --- > drivers/mtd/devices/m25p80.c | 7 ++- > 1 file changed, 6 insertions(+), 1

Re: [PATCH] mtd: m25p80: consider max message size in m25p80_read when use the spi_mem_xx() API

2018-08-16 Thread Boris Brezillon
Hi Chuanhua, On Wed, 15 Aug 2018 14:33:43 +0800 Chuanhua Han wrote: > Consider a message size limit when calculating the maximum amount > of data that can be read. > > Signed-off-by: Chuanhua Han > --- > drivers/mtd/devices/m25p80.c | 7 ++- > 1 file changed, 6 insertions(+), 1

Re: mmotm 2018-08-09-20-10 uploaded (mtd/nand/raw/atmel/)

2018-08-11 Thread Boris Brezillon
Hi Randy, On Fri, 10 Aug 2018 08:37:01 -0700 Randy Dunlap wrote: > On 08/09/2018 08:11 PM, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2018-08-09-20-10 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for

Re: mmotm 2018-08-09-20-10 uploaded (mtd/nand/raw/atmel/)

2018-08-11 Thread Boris Brezillon
Hi Randy, On Fri, 10 Aug 2018 08:37:01 -0700 Randy Dunlap wrote: > On 08/09/2018 08:11 PM, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2018-08-09-20-10 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for

Re: [RFC PATCH v2 07/12] mtd: rawnand: ams-delta: Set port direction once per transfer

2018-08-07 Thread Boris Brezillon
On Tue, 7 Aug 2018 00:29:13 +0200 Janusz Krzysztofik wrote: > In its current shape, the driver sets data port direction before each > byte read/write operation, even during multi-byte transfers. Since > performance of the driver is completely not acceptable on Amstrad Delta > after it has been

Re: [RFC PATCH v2 07/12] mtd: rawnand: ams-delta: Set port direction once per transfer

2018-08-07 Thread Boris Brezillon
On Tue, 7 Aug 2018 00:29:13 +0200 Janusz Krzysztofik wrote: > In its current shape, the driver sets data port direction before each > byte read/write operation, even during multi-byte transfers. Since > performance of the driver is completely not acceptable on Amstrad Delta > after it has been

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

2018-08-06 Thread Boris Brezillon
On Mon, 6 Aug 2018 15:01:37 +0300 Dan Carpenter wrote: > On Mon, Aug 06, 2018 at 01:46:48PM +0200, Boris Brezillon wrote: > > Hi Dan, > > > > On Wed, 1 Aug 2018 15:05:51 +0300 > > Dan Carpenter wrote: > > > > > On Wed, Aug 01, 2018

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

2018-08-06 Thread Boris Brezillon
On Mon, 6 Aug 2018 15:01:37 +0300 Dan Carpenter wrote: > On Mon, Aug 06, 2018 at 01:46:48PM +0200, Boris Brezillon wrote: > > Hi Dan, > > > > On Wed, 1 Aug 2018 15:05:51 +0300 > > Dan Carpenter wrote: > > > > > On Wed, Aug 01, 2018

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

2018-08-06 Thread Boris Brezillon
Hi Dan, On Wed, 1 Aug 2018 15:05:51 +0300 Dan Carpenter wrote: > On Wed, Aug 01, 2018 at 11:24:19AM +0800, Jheng-Jhong Wu wrote: > > For NAND flash chips with more than 1Gbit (e.g. MT29F2G) more than 16 bits > > are necessary to address the correct page. The driver sets the address for > > more

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

2018-08-06 Thread Boris Brezillon
Hi Dan, On Wed, 1 Aug 2018 15:05:51 +0300 Dan Carpenter wrote: > On Wed, Aug 01, 2018 at 11:24:19AM +0800, Jheng-Jhong Wu wrote: > > For NAND flash chips with more than 1Gbit (e.g. MT29F2G) more than 16 bits > > are necessary to address the correct page. The driver sets the address for > > more

Re: [RFC PATCH v2] mtd: nand: toshiba: Add support for ->exec_op()

2018-08-03 Thread Boris Brezillon
take With the commit message adjusted as suggested above, Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/nand_toshiba.c | 53 > - > 1 file changed, 52 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/nand_toshiba.c

Re: [RFC PATCH v2] mtd: nand: toshiba: Add support for ->exec_op()

2018-08-03 Thread Boris Brezillon
take With the commit message adjusted as suggested above, Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/nand_toshiba.c | 53 > - > 1 file changed, 52 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/nand_toshiba.c

Re: [PATCH v6] mtd: nand: toshiba: Add support for Toshiba Memory BENAND (Built-in ECC NAND)

2018-08-03 Thread Boris Brezillon
command only knows whether there was bitflips above the > threshold and can not get accurate bitflips. For now, I set > max_bitflips mtd->bitflip_threshold. > > Signed-off-by: KOBAYASHI Yoshitake Reviewed-by: Boris Brezillon > --- > drivers

Re: [PATCH v6] mtd: nand: toshiba: Add support for Toshiba Memory BENAND (Built-in ECC NAND)

2018-08-03 Thread Boris Brezillon
command only knows whether there was bitflips above the > threshold and can not get accurate bitflips. For now, I set > max_bitflips mtd->bitflip_threshold. > > Signed-off-by: KOBAYASHI Yoshitake Reviewed-by: Boris Brezillon > --- > drivers

Re: [PATCH v3 3/3] mtd: m25p80: Call spi_mem_get_name() to let controller set a custom name

2018-08-02 Thread Boris Brezillon
D to the SPI layer. > > Suggested-by: Boris Brezillon > Signed-off-by: Frieder Schrempf Acked-by: Boris Brezillon > --- > drivers/mtd/devices/m25p80.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p8

Re: [PATCH v3 3/3] mtd: m25p80: Call spi_mem_get_name() to let controller set a custom name

2018-08-02 Thread Boris Brezillon
D to the SPI layer. > > Suggested-by: Boris Brezillon > Signed-off-by: Frieder Schrempf Acked-by: Boris Brezillon > --- > drivers/mtd/devices/m25p80.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p8

Re: [PATCH v3 2/3] spi: spi-mem: Extend the SPI mem interface to set a custom memory name

2018-08-02 Thread Boris Brezillon
new driver without spi_mem_get_name: spi4.0 > > Suggested-by: Boris Brezillon > Signed-off-by: Frieder Schrempf Reviewed-by: Boris Brezillon > --- > drivers/spi/spi-mem.c | 28 > include/linux/spi/spi-mem.h | 12 > 2 files ch

Re: [PATCH v3 2/3] spi: spi-mem: Extend the SPI mem interface to set a custom memory name

2018-08-02 Thread Boris Brezillon
new driver without spi_mem_get_name: spi4.0 > > Suggested-by: Boris Brezillon > Signed-off-by: Frieder Schrempf Reviewed-by: Boris Brezillon > --- > drivers/spi/spi-mem.c | 28 > include/linux/spi/spi-mem.h | 12 > 2 files ch

Re: [PATCH v3 1/3] spi: spi-mem: Fix a typo in the documentation of struct spi_mem

2018-08-02 Thread Boris Brezillon
On Thu, 2 Aug 2018 14:53:52 +0200 Frieder Schrempf wrote: We usually try to avoid empty commit message, even if this one is pretty obvious, I'd suggest adding something here. " Fix a typo in the @drvpriv description. " ? > Signed-off-by: Frieder Schrempf Acked-by: Bo

Re: [PATCH v3 1/3] spi: spi-mem: Fix a typo in the documentation of struct spi_mem

2018-08-02 Thread Boris Brezillon
On Thu, 2 Aug 2018 14:53:52 +0200 Frieder Schrempf wrote: We usually try to avoid empty commit message, even if this one is pretty obvious, I'd suggest adding something here. " Fix a typo in the @drvpriv description. " ? > Signed-off-by: Frieder Schrempf Acked-by: Bo

Re: [RFC PATCH v2 5/6] spi: Add QuadSPI driver for Atmel SAMA5D2

2018-08-02 Thread Boris Brezillon
On Thu, 2 Aug 2018 12:46:36 +0200 Frieder Schrempf wrote: > Hi Mark, > > On 02.08.2018 12:17, Mark Brown wrote: > > On Wed, Aug 01, 2018 at 09:57:33PM +0200, Boris Brezillon wrote: > >> Mark Brown wrote: > > > >> 2/ Getting this patch [1] merged

Re: [RFC PATCH v2 5/6] spi: Add QuadSPI driver for Atmel SAMA5D2

2018-08-02 Thread Boris Brezillon
On Thu, 2 Aug 2018 12:46:36 +0200 Frieder Schrempf wrote: > Hi Mark, > > On 02.08.2018 12:17, Mark Brown wrote: > > On Wed, Aug 01, 2018 at 09:57:33PM +0200, Boris Brezillon wrote: > >> Mark Brown wrote: > > > >> 2/ Getting this patch [1] merged

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-01 Thread Boris Brezillon
Hi Yixun, On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: I haven't finished reviewing the driver yet (I'll try to do that later this week), but I already pointed a few things to fix/improve. > + > +static int meson_nfc_exec_op(struct nand_chip *chip, > + const

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-01 Thread Boris Brezillon
Hi Yixun, On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: I haven't finished reviewing the driver yet (I'll try to do that later this week), but I already pointed a few things to fix/improve. > + > +static int meson_nfc_exec_op(struct nand_chip *chip, > + const

Re: [RFC PATCH v2 5/6] spi: Add QuadSPI driver for Atmel SAMA5D2

2018-08-01 Thread Boris Brezillon
Hi Mark, On Wed, 1 Aug 2018 18:27:47 +0100 Mark Brown wrote: > On Wed, Jun 27, 2018 at 03:16:08PM +0200, Piotr Bugalski wrote: > > Kernel contains QSPI driver strongly tied to MTD and nor-flash memory. > > New spi-mem interface allows usage also other memory types, especially > > much larger

Re: [RFC PATCH v2 5/6] spi: Add QuadSPI driver for Atmel SAMA5D2

2018-08-01 Thread Boris Brezillon
Hi Mark, On Wed, 1 Aug 2018 18:27:47 +0100 Mark Brown wrote: > On Wed, Jun 27, 2018 at 03:16:08PM +0200, Piotr Bugalski wrote: > > Kernel contains QSPI driver strongly tied to MTD and nor-flash memory. > > New spi-mem interface allows usage also other memory types, especially > > much larger

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

2018-08-01 Thread Boris Brezillon
Hi Jheng-Jhong, On Wed, 1 Aug 2018 11:24:19 +0800 Jheng-Jhong Wu wrote: > For NAND flash chips with more than 1Gbit (e.g. MT29F2G) more than 16 bits > are necessary to address the correct page. The driver sets the address for > more than 16 bits, but it uses 16-bit arguments and variables

Re: [PATCH] staging:mt29f_spinand: MT29F2G failing as only 16-bit arguments and variables used for addressing.

2018-08-01 Thread Boris Brezillon
Hi Jheng-Jhong, On Wed, 1 Aug 2018 11:24:19 +0800 Jheng-Jhong Wu wrote: > For NAND flash chips with more than 1Gbit (e.g. MT29F2G) more than 16 bits > are necessary to address the correct page. The driver sets the address for > more than 16 bits, but it uses 16-bit arguments and variables

Re: [RFC PATCH 7/8] mtd: rawnand: ams-delta: Check sanity of data GPIO resource

2018-07-29 Thread Boris Brezillon
On Sun, 29 Jul 2018 22:36:49 +0200 Linus Walleij wrote: > On Thu, Jul 19, 2018 at 8:44 AM Boris Brezillon > wrote: > > > I guess you'd prefer to have the pin values in a bitmap instead of an > > array of integers. That's probably something you can discuss with > > Li

Re: [RFC PATCH 7/8] mtd: rawnand: ams-delta: Check sanity of data GPIO resource

2018-07-29 Thread Boris Brezillon
On Sun, 29 Jul 2018 22:36:49 +0200 Linus Walleij wrote: > On Thu, Jul 19, 2018 at 8:44 AM Boris Brezillon > wrote: > > > I guess you'd prefer to have the pin values in a bitmap instead of an > > array of integers. That's probably something you can discuss with > > Li

Re: [PATCH] mtd: spi-nor: cadence-quadspi: make return type fit wait_for_completion_timeout

2018-07-27 Thread Boris Brezillon
On Fri, 27 Jul 2018 05:21:49 + Nicholas Mc Guire wrote: > On Thu, Jul 26, 2018 at 10:09:28PM +0200, Boris Brezillon wrote: > > On Wed, 25 Jul 2018 06:31:37 + > > Nicholas Mc Guire wrote: > > > > > On Tue, Jul 24, 2018 at 10:46:26PM +0200, Boris Brezill

Re: [PATCH] mtd: spi-nor: cadence-quadspi: make return type fit wait_for_completion_timeout

2018-07-27 Thread Boris Brezillon
On Fri, 27 Jul 2018 05:21:49 + Nicholas Mc Guire wrote: > On Thu, Jul 26, 2018 at 10:09:28PM +0200, Boris Brezillon wrote: > > On Wed, 25 Jul 2018 06:31:37 + > > Nicholas Mc Guire wrote: > > > > > On Tue, Jul 24, 2018 at 10:46:26PM +0200, Boris Brezill

Re: [PATCH] mtd: spi-nor: cadence-quadspi: make return type fit wait_for_completion_timeout

2018-07-26 Thread Boris Brezillon
On Wed, 25 Jul 2018 06:31:37 + Nicholas Mc Guire wrote: > On Tue, Jul 24, 2018 at 10:46:26PM +0200, Boris Brezillon wrote: > > On Sat, 21 Jul 2018 18:08:13 +0200 > > Nicholas Mc Guire wrote: > > > > > wait_for_completion_timeout returns an unsigned long not

Re: [PATCH] mtd: spi-nor: cadence-quadspi: make return type fit wait_for_completion_timeout

2018-07-26 Thread Boris Brezillon
On Wed, 25 Jul 2018 06:31:37 + Nicholas Mc Guire wrote: > On Tue, Jul 24, 2018 at 10:46:26PM +0200, Boris Brezillon wrote: > > On Sat, 21 Jul 2018 18:08:13 +0200 > > Nicholas Mc Guire wrote: > > > > > wait_for_completion_timeout returns an unsigned long not

Re: [PATCH v3] mtd/maps: fix solutionengine.c printk format warnings

2018-07-26 Thread Boris Brezillon
ined > here > printk(KERN_NOTICE "Solution Engine: Flash at 0x%08lx, EPROM at 0x%08lx\n", > ^ > %08x > > Cc: David Woodhouse > Cc: Brian Norris > Cc: Boris Brezillon > Cc:

Re: [PATCH v3] mtd/maps: fix solutionengine.c printk format warnings

2018-07-26 Thread Boris Brezillon
ined > here > printk(KERN_NOTICE "Solution Engine: Flash at 0x%08lx, EPROM at 0x%08lx\n", > ^ > %08x > > Cc: David Woodhouse > Cc: Brian Norris > Cc: Boris Brezillon > Cc:

Re: [PATCH v4 27/35] mtd: rawnand: sm_common: convert driver to nand_scan_with_ids()

2018-07-26 Thread Boris Brezillon
On Sun, 22 Jul 2018 08:44:32 +0200 Boris Brezillon wrote: > On Fri, 20 Jul 2018 17:15:19 +0200 > Miquel Raynal wrote: > > > Two helpers have been added to the core to make ECC-related > > configuration between the detection phase and the final NAND scan. Use > &

Re: [PATCH v4 27/35] mtd: rawnand: sm_common: convert driver to nand_scan_with_ids()

2018-07-26 Thread Boris Brezillon
On Sun, 22 Jul 2018 08:44:32 +0200 Boris Brezillon wrote: > On Fri, 20 Jul 2018 17:15:19 +0200 > Miquel Raynal wrote: > > > Two helpers have been added to the core to make ECC-related > > configuration between the detection phase and the final NAND scan. Use > &

Re: [PATCH v4 14/35] mtd: rawnand: mtk: convert driver to nand_scan()

2018-07-26 Thread Boris Brezillon
On Thu, 26 Jul 2018 14:06:41 +0800 xiaolei li wrote: > On Sat, 2018-07-21 at 19:10 +0200, Boris Brezillon wrote: > > On Fri, 20 Jul 2018 17:15:06 +0200 > > Miquel Raynal wrote: > > > > > Two helpers have been added to the core to make ECC-related > > &

Re: [PATCH v4 14/35] mtd: rawnand: mtk: convert driver to nand_scan()

2018-07-26 Thread Boris Brezillon
On Thu, 26 Jul 2018 14:06:41 +0800 xiaolei li wrote: > On Sat, 2018-07-21 at 19:10 +0200, Boris Brezillon wrote: > > On Fri, 20 Jul 2018 17:15:06 +0200 > > Miquel Raynal wrote: > > > > > Two helpers have been added to the core to make ECC-related > > &

Re: [PATCH] MAINTAINERS: drop Wenyou Yang from Atmel NAND driver support

2018-07-25 Thread Boris Brezillon
On Wed, 25 Jul 2018 16:56:28 +0200 Miquel Raynal wrote: > Mails to wenyou.y...@microchip.com are not deliverable. > Drop him as Microchip/Atmel NAND controller driver maintainer. > > Signed-off-by: Miquel Raynal > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH] MAINTAINERS: drop Wenyou Yang from Atmel NAND driver support

2018-07-25 Thread Boris Brezillon
On Wed, 25 Jul 2018 16:56:28 +0200 Miquel Raynal wrote: > Mails to wenyou.y...@microchip.com are not deliverable. > Drop him as Microchip/Atmel NAND controller driver maintainer. > > Signed-off-by: Miquel Raynal > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git

<    7   8   9   10   11   12   13   14   15   16   >