This patch registers the Exynos Bus-Frequency scaling device
as a cooling device of thermal management.
Signed-off-by: Chanwoo Choi
Cc: Kukjin Kim
Cc: Krzysztof Kozlowski
Cc: linux-samsung-...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
eij <linus.wall...@linaro.org>
> ---
> drivers/extcon/extcon-gpio.c | 9 +
> 1 file changed, 9 insertions(+)
Looks good to me.
Acked-by: Chanwoo Choi <cw00.c...@samsung.com>
>
> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
> index b735
gt; ---
> drivers/extcon/extcon-gpio.c | 9 +
> 1 file changed, 9 insertions(+)
Looks good to me.
Acked-by: Chanwoo Choi
>
> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
> index b7353f5018b5..4f0ad5ad2722 100644
> --- a/drivers/extcon/extcon-
1 insertions(+), 2 deletions(-)
I checked the pinctrl-bindings.txt[1] in order to check
the property name of 'input-debounce'. It looks good to me.
[1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
Acked-by: Chanwoo Choi <cw00.c...@samsung.com>
>
> diff --git a/drive
I checked the pinctrl-bindings.txt[1] in order to check
the property name of 'input-debounce'. It looks good to me.
[1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
Acked-by: Chanwoo Choi
>
> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
> 1 file changed, 19 insertions(+), 10 deletions(-)
Looks good to me.
Acked-by: Chanwoo Choi <cw00.c...@samsung.com>
>
> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
> index 86f3ec6d6014..6d9cb4ed11c2 100644
> --- a/drivers/extcon/extcon-gp
ions(+), 10 deletions(-)
Looks good to me.
Acked-by: Chanwoo Choi
>
> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
> index 86f3ec6d6014..6d9cb4ed11c2 100644
> --- a/drivers/extcon/extcon-gpio.c
> +++ b/drivers/extcon/extcon-gpio.c
> @@ -30,26 +30,22 @
Hi Linus,
Looks good to me. But, there is one comment
of gpiod_to_irq()'s return value.
If you modify it, feel free to add my tag:
Acked-by: Chanwoo Choi <cw00.c...@samsung.com>
On 2017년 09월 24일 23:56, Linus Walleij wrote:
> Since we are not getting the GPIO from any platform data a
Hi Linus,
Looks good to me. But, there is one comment
of gpiod_to_irq()'s return value.
If you modify it, feel free to add my tag:
Acked-by: Chanwoo Choi
On 2017년 09월 24일 23:56, Linus Walleij wrote:
> Since we are not getting the GPIO from any platform data and global
> GPIO numberspa
binding method. But, as you mentioned,
it is not used on kernel with platform_data method.
Looks good to me.
Acked-by: Chanwoo Choi <cw00.c...@samsung.com>
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
wall...@linaro.org>
> ---
> drivers/extcon/extcon-gpio.c | 56
>
> 1 file changed, 26 insertions(+), 30 deletions(-)
Looks good to me.
Acked-by: Chanwoo Choi <cw00.c...@samsung.com>
>
> diff --git a/drivers/extcon/extcon-gpio.c b/driv
But, as you mentioned,
it is not used on kernel with platform_data method.
Looks good to me.
Acked-by: Chanwoo Choi
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
/extcon/extcon-gpio.c | 56
>
> 1 file changed, 26 insertions(+), 30 deletions(-)
Looks good to me.
Acked-by: Chanwoo Choi
>
> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
> index 6abf5f70fdbf..9c4094edd123
this type.
>
> Someone else would have to answer, this is based on the current
> connector types supported by the Linux kernel.
>
>>> +/* Display external connector */
>>> +#define EXTCON_DISP_HDMI 40 /* High-Definition Multimedia
>>> Interface */
>>> +#define EXTCON_DISP_MHL41 /* Mobile High-Definition
>>> Link */
>>> +#define EXTCON_DISP_DVI42 /* Digital Visual Interface
>>> */
>>> +#define EXTCON_DISP_VGA43 /* Video Graphics Array */
>>> +#define EXTCON_DISP_DP 44 /* Display Port */
>>> +#define EXTCON_DISP_HMD45 /* Head-Mounted Display */
>>
>> We already have connector bindings for most of these. Use those as a
>> model for whatever you want to do.
>
> I guess they are not in Documentation/devicetree/bindings/extcon/*
>
> Please point me in the right direction and I'll check it out.
>
> Yours,
> Linus Walleij
>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
sed on the current
> connector types supported by the Linux kernel.
>
>>> +/* Display external connector */
>>> +#define EXTCON_DISP_HDMI 40 /* High-Definition Multimedia
>>> Interface */
>>> +#define EXTCON_DISP_MHL41 /* Mobile High-Definition
>>> Link */
>>> +#define EXTCON_DISP_DVI42 /* Digital Visual Interface
>>> */
>>> +#define EXTCON_DISP_VGA43 /* Video Graphics Array */
>>> +#define EXTCON_DISP_DP 44 /* Display Port */
>>> +#define EXTCON_DISP_HMD45 /* Head-Mounted Display */
>>
>> We already have connector bindings for most of these. Use those as a
>> model for whatever you want to do.
>
> I guess they are not in Documentation/devicetree/bindings/extcon/*
>
> Please point me in the right direction and I'll check it out.
>
> Yours,
> Linus Walleij
>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Dear all,
Please ignore this patch. It has some problem.
I'll fix and resend this patch on v2.
Chanwoo Choi
Samsung Electronics
On 2017년 09월 21일 09:33, Chanwoo Choi wrote:
> This patch registers the Exynos Bus-Frequency scaling device
> as a cooling device of thermal management.
>
>
Dear all,
Please ignore this patch. It has some problem.
I'll fix and resend this patch on v2.
Chanwoo Choi
Samsung Electronics
On 2017년 09월 21일 09:33, Chanwoo Choi wrote:
> This patch registers the Exynos Bus-Frequency scaling device
> as a cooling device of thermal management.
>
>
>available' status in order to decicde the next freq
by the devfreq_recommended_opp().
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devf
>available' status in order to decicde the next freq
by the devfreq_recommended_opp().
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 1c4b377cacfb.
The commit 0ec09ac2cebe9 ("PM / devfreq: Set the freq_table of devfreq
device") initializes the freq_table array of each devfreq device always.
In result, it is unneeded to check whether profile->freq_table is NULL
or not.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
-
The commit 0ec09ac2cebe9 ("PM / devfreq: Set the freq_table of devfreq
device") initializes the freq_table array of each devfreq device always.
In result, it is unneeded to check whether profile->freq_table is NULL
or not.
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c |
Prior to that, the devfreq device uses the governor name when adding
the itself. In order to prevent the mistake used the wrong governor name,
this patch defines the governor name as a constant and then uses them
instead of using the string directly.
Signed-off-by: Chanwoo Choi <cw0
. This patch
shows the available minimum and maximum frequency through sysfs node.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/d
. This patch
shows the available minimum and maximum frequency through sysfs node.
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index
Prior to that, the devfreq device uses the governor name when adding
the itself. In order to prevent the mistake used the wrong governor name,
this patch defines the governor name as a constant and then uses them
instead of using the string directly.
Signed-off-by: Chanwoo Choi
Cc: Kukjin Kim
This patch registers the Exynos Bus-Frequency scaling device
as a cooling device of thermal management.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
Cc: Kukjin Kim <kg...@kernel.org>
Cc: Krzysztof Kozlowski <k...@kernel.org>
Cc: linux-samsung-...@vger.kernel.org
This patch registers the Exynos Bus-Frequency scaling device
as a cooling device of thermal management.
Signed-off-by: Chanwoo Choi
Cc: Kukjin Kim
Cc: Krzysztof Kozlowski
Cc: linux-samsung-...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
value. So, this patch revert the macro
in order to add the additional codes.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/d
value. So, this patch revert the macro
in order to add the additional codes.
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index ae8717a6eee1
-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c | 43 +++
1 file changed, 43 insertions(+)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index a1c4ee818614..ae8717a6eee1 100644
--- a/drivers/devfreq/devfreq.c
-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 43 +++
1 file changed, 43 insertions(+)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index a1c4ee818614..ae8717a6eee1 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq
freq_table' is initialized, devfreq core just uses the 'freq_table'.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq
to cw00.c...@samsung.com
- Drop the patches related to opp_notifier
- Add new patch5/6/7/8
Chanwoo Choi (8):
PM / devfreq: Set min/max_freq when adding the devfreq device
Revert "PM / devfreq: Add show_one macro to delete the duplicate code"
PM / devfreq: Show the available min/m
freq_table' is initialized, devfreq core just uses the 'freq_table'.
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 799a0cf75d39..1c
to cw00.c...@samsung.com
- Drop the patches related to opp_notifier
- Add new patch5/6/7/8
Chanwoo Choi (8):
PM / devfreq: Set min/max_freq when adding the devfreq device
Revert "PM / devfreq: Add show_one macro to delete the duplicate code"
PM / devfreq: Show the available min/m
Hi Viresh,
On 2017년 09월 21일 05:25, Viresh Kumar wrote:
> The notifier callbacks may want to call some OPP helper routines which
> may try to take the same opp_table->lock again and cause a deadlock. One
> such usecase was reported by Chanwoo Choi, where calling
> dev_pm_opp_dis
Hi Viresh,
On 2017년 09월 21일 05:25, Viresh Kumar wrote:
> The notifier callbacks may want to call some OPP helper routines which
> may try to take the same opp_table->lock again and cause a deadlock. One
> such usecase was reported by Chanwoo Choi, where calling
> dev_pm_opp_dis
d int id;
> const char *name;
>
Applied it for v4.15. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
con.c
> +++ b/drivers/extcon/extcon.c
> @@ -36,7 +36,7 @@
>
> #define SUPPORTED_CABLE_MAX 32
>
> -struct __extcon_info {
> +static const struct __extcon_info {
> unsigned int type;
> unsigned int id;
> const char *name;
>
Applied it for v4.15. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
_freq_table()
>>
>> Also, this patch changes the return value of set_freq_table()
>> from 'void' to 'int' and then removes the function description
>> of internal helper function. Because the internal helper function
>> is used by the devfreq core.
>>
>> Sign
_freq_table()
>>
>> Also, this patch changes the return value of set_freq_table()
>> from 'void' to 'int' and then removes the function description
>> of internal helper function. Because the internal helper function
>> is used by the devfreq core.
>>
>> Sign
e is NULL or not because the device_unregister()
>> frees the devfreq instance when jumping to the 'err_init'.
>> It is to prevent the duplicate the kfee(devfreq).
>>
>> Cc: sta...@vger.kernel.org
>> Fixes: ac4b281176a5 ("PM / devfreq: fix duplicated kfree on devfreq poin
e is NULL or not because the device_unregister()
>> frees the devfreq instance when jumping to the 'err_init'.
>> It is to prevent the duplicate the kfee(devfreq).
>>
>> Cc: sta...@vger.kernel.org
>> Fixes: ac4b281176a5 ("PM / devfreq: fix duplicated kfree on devfreq pointer&q
On 2017년 08월 24일 23:23, Rob Herring wrote:
> On Wed, Aug 23, 2017 at 6:18 PM, Chanwoo Choi <cw00.c...@samsung.com> wrote:
>> Hi Rob,
>>
>> On 2017년 08월 24일 03:09, Rob Herring wrote:
>>> On Thu, Jul 20, 2017 at 12:25 AM, MyungJoo Ham <myungjoo@samsung.com
On 2017년 08월 24일 23:23, Rob Herring wrote:
> On Wed, Aug 23, 2017 at 6:18 PM, Chanwoo Choi wrote:
>> Hi Rob,
>>
>> On 2017년 08월 24일 03:09, Rob Herring wrote:
>>> On Thu, Jul 20, 2017 at 12:25 AM, MyungJoo Ham
>>> wrote:
>>>>> On 2017년 07월
Dear Greg,
This is extcon-next pull request for v4.14. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877:
Linux v4.13-rc1 (2017-07-15 15
Dear Greg,
This is extcon-next pull request for v4.14. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877:
Linux v4.13-rc1 (2017-07-15 15
fo->edev,
> + extcon_set_state_sync(info->edev,
> EXTCON_DISP_MHL, cable_attached);
> break;
> }
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
;edev,
> + extcon_set_state_sync(info->edev,
> EXTCON_DISP_MHL, cable_attached);
> break;
> }
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Dear all,
On 2017년 08월 24일 10:42, Chanwoo Choi wrote:
> The devfreq uses the OPP interface as a mandatory method
> and so the devfreq has to support the OPP notifier in order to
> catch the OPP events. So, this patch adds the new opp_notifier_cb()
> function pointer i
Dear all,
On 2017년 08월 24일 10:42, Chanwoo Choi wrote:
> The devfreq uses the OPP interface as a mandatory method
> and so the devfreq has to support the OPP notifier in order to
> catch the OPP events. So, this patch adds the new opp_notifier_cb()
> function pointer i
hanged OPP information
in the default_opp_notifier_cb().
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c | 46 +-
include/linux/devfreq.h | 12
2 files changed, 57 insertions(+), 1 deletion(-)
diff
hanged OPP information
in the default_opp_notifier_cb().
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 46 +-
include/linux/devfreq.h | 12
2 files changed, 57 insertions(+), 1 deletion(-)
diff --git a/drivers/devfreq/d
freq_table' is initialized, devfreq core just uses the 'freq_table'.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
in
' to 'int' and then removes the function description
of internal helper function. Because the internal helper function
is used by the devfreq core.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c | 34 --
1 file chang
' to 'int' and then removes the function description
of internal helper function. Because the internal helper function
is used by the devfreq core.
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 34 --
1 file changed, 16 insertions(+), 18 deletions
freq_table' is initialized, devfreq core just uses the 'freq_table'.
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 8b0bbfa0a50b..d8ff16419
to handle the frequency and voltage. If so, the OPP notifier is
mandatory. So, the OPP notifier have to be handled in the devfreq core
instead of each device driver.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c
value. So, this patch revert the macro
in order to add the additional codes.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/d
to handle the frequency and voltage. If so, the OPP notifier is
mandatory. So, the OPP notifier have to be handled in the devfreq core
instead of each device driver.
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c| 77
drivers/devfreq/exynos
value. So, this patch revert the macro
in order to add the additional codes.
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index f10017fe400f
Previously, the min/max_freq of devfreq device are always zero
before the user changes the min/max_freq through sysfs entry.
It might make the confusion of min/max_freq.
This patch initializes the available min/max_freq by using the OPP API.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.
Previously, the min/max_freq of devfreq device are always zero
before the user changes the min/max_freq through sysfs entry.
It might make the confusion of min/max_freq.
This patch initializes the available min/max_freq by using the OPP API.
Signed-off-by: Chanwoo Choi
---
drivers/devfreq
. This patch
shows the available minimum and maximum frequency through sysfs node.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/d
. This patch
shows the available minimum and maximum frequency through sysfs node.
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index
n callback function to receive the OPP events.
Also, the devfreq provides the default OPP notifeir callback
in order to remake the frequency table when OPP events happen.
- default_opp_notifier_cb()
Chanwoo Choi (12):
PM / devfreq: Fix memory leak when fail to register device
PM / devfreq: Fix loc
.org
Fixes: 0ec09ac2cebe ("PM / devfreq: Set the freq_table of devfreq device")
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/de
n callback function to receive the OPP events.
Also, the devfreq provides the default OPP notifeir callback
in order to remake the frequency table when OPP events happen.
- default_opp_notifier_cb()
Chanwoo Choi (12):
PM / devfreq: Fix memory leak when fail to register device
PM / devfreq: Fix loc
.org
Fixes: 0ec09ac2cebe ("PM / devfreq: Set the freq_table of devfreq device")
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index a1c4ee818614.
The devfreq ues the OPP library to handle the voltage and frequency
for the device basically. This patch adds the dependency on CONFIG_PM_OPP
in order to prevent either the build break or the unknow behavior.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/Kconf
The devfreq ues the OPP library to handle the voltage and frequency
for the device basically. This patch adds the dependency on CONFIG_PM_OPP
in order to prevent either the build break or the unknow behavior.
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/Kconfig | 1 +
1 file changed, 1
From: Chanwoo Choi <cwcho...@gmail.com>
THe devfreq_update_stats() updates the 'struct devfreq_dev_status'
in order to get current status of devfreq device. It is only used
for the governors.
This patch moves the devfreq_update_stats() into devfreq directory.
Signed-off-by: Chanwoo Choi
req, the devfreq show the unsupported
frequency value.
In order to fix this issue, this patch checks whether the entered
frequency is supported or not by OPP interface.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c | 35 +++
1 file ch
From: Chanwoo Choi
THe devfreq_update_stats() updates the 'struct devfreq_dev_status'
in order to get current status of devfreq device. It is only used
for the governors.
This patch moves the devfreq_update_stats() into devfreq directory.
Signed-off-by: Chanwoo Choi
---
drivers/devfreq
req, the devfreq show the unsupported
frequency value.
In order to fix this issue, this patch checks whether the entered
frequency is supported or not by OPP interface.
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 35 +++
1 file changed, 31 insertions(+)
to the 'err_init'.
It is to prevent the duplicate the kfee(devfreq).
Cc: sta...@vger.kernel.org
Fixes: ac4b281176a5 ("PM / devfreq: fix duplicated kfree on devfreq pointer")
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/devfreq/devfreq.c | 5 -
1 file changed, 4
to the 'err_init'.
It is to prevent the duplicate the kfee(devfreq).
Cc: sta...@vger.kernel.org
Fixes: ac4b281176a5 ("PM / devfreq: fix duplicated kfree on devfreq pointer")
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 5 -
1 file changed, 4 insertions(+), 1 deletio
gt;>>> full_name to use %pOF instead. This is preparation to remove storing
>>>> of the full path string for each node.
>>>>
>>>> Signed-off-by: Rob Herring <r...@kernel.org>
>>>> Cc: Chanwoo Choi <cw00.c...@samsung.com>
>>&
instead. This is preparation to remove storing
>>>> of the full path string for each node.
>>>>
>>>> Signed-off-by: Rob Herring
>>>> Cc: Chanwoo Choi
>>>> Cc: MyungJoo Ham
>>>> Cc: Kyungmin Park
>>>> Cc: linux...
Hi Maciej,
Why do you miss my reviewed-by tag?
If there is no huge changes, you need to keep the previous review tag.
Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com>
On 2017년 08월 23일 15:30, Maciej Purski wrote:
> This patch adds muic of_compatible in order to use the muic device
Hi Maciej,
Why do you miss my reviewed-by tag?
If there is no huge changes, you need to keep the previous review tag.
Reviewed-by: Chanwoo Choi
On 2017년 08월 23일 15:30, Maciej Purski wrote:
> This patch adds muic of_compatible in order to use the muic device
> driver in devic
.name = "max77693-charger",
> .of_compatible = "maxim,max77693-charger",
> },
> - { .name = "max77693-muic", },
> + {
> + .name = "max77693-muic",
> + .of_compatible = "maxim,max77693-mui
me = "max77693-charger",
> .of_compatible = "maxim,max77693-charger",
> },
> - { .name = "max77693-muic", },
> + {
> + .name = "max77693-muic",
> + .of_compatible = "maxim,max77693-muic",
> + },
&
On 2017년 08월 22일 16:14, Chanwoo Choi wrote:
> Hi,
>
> On 2017년 08월 22일 16:09, Maciej Purski wrote:
>> This patch adds muic of_compatible in order to use the muic device
>> driver in device tree.
>>
>> v2:
>> - added muic to documentation
>>
>>
On 2017년 08월 22일 16:14, Chanwoo Choi wrote:
> Hi,
>
> On 2017년 08월 22일 16:09, Maciej Purski wrote:
>> This patch adds muic of_compatible in order to use the muic device
>> driver in device tree.
>>
>> v2:
>> - added muic to documenta
e = "max77693-muic",
> + .of_compatible = "maxim,max77693-muic",
> + },
> {
> .name = "max77693-haptic",
> .of_compatible = "maxim,max77693-haptic",
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
,
> + .of_compatible = "maxim,max77693-muic",
> + },
> {
> .name = "max77693-haptic",
> .of_compatible = "maxim,max77693-haptic",
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
t;,
> + },
> {
> .name = "max77693-haptic",
> .of_compatible = "maxim,max77693-haptic",
>
Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
{
> .name = "max77693-haptic",
> .of_compatible = "maxim,max77693-haptic",
>
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Dear Kishon and Felipe,
I applied these patches on extcon-next branch for v4.14-rc1.
And I created the immutable branch ('ib-extcon-usb-phy-4.14')
and send the pull-request for these patches in order to
prevent the merge conflict.
Best Regards,
Chanwoo Choi
The following changes since commit
Dear Kishon and Felipe,
I applied these patches on extcon-next branch for v4.14-rc1.
And I created the immutable branch ('ib-extcon-usb-phy-4.14')
and send the pull-request for these patches in order to
prevent the merge conflict.
Best Regards,
Chanwoo Choi
The following changes since commit
On 2017년 07월 17일 10:30, Chanwoo Choi wrote:
> These patches just clean-up code for extcon functions.
>
> Firstly, patch2 modifies the description for functions/structures
> in order to improve the readability and guide the role of
> functions more well.
>
> Second, the extco
On 2017년 07월 17일 10:30, Chanwoo Choi wrote:
> These patches just clean-up code for extcon functions.
>
> Firstly, patch2 modifies the description for functions/structures
> in order to improve the readability and guide the role of
> functions more well.
>
> Second, the extco
Hi,
On 2017년 08월 15일 18:48, Felipe Balbi wrote:
>
> Hi,
>
> Chanwoo Choi <cw00.c...@samsung.com> writes:
>> This patch replaces the deprecated extcon API as following:
>> - extcon_get_cable_state_() -> extcon_get_state()
>>
>> Cc: Felipe Balbi <
Hi,
On 2017년 08월 15일 18:48, Felipe Balbi wrote:
>
> Hi,
>
> Chanwoo Choi writes:
>> This patch replaces the deprecated extcon API as following:
>> - extcon_get_cable_state_() -> extcon_get_state()
>>
>> Cc: Felipe Balbi
>> Cc: Greg Kroah-Hart
maintainer.
Usually, I send the extcon's pull request to the GregKH
for the next merge after releasing 4.x-rc6.
(4.x-rc4 was released)
Please review this patch.
On 2017년 08월 07일 11:07, Chanwoo Choi wrote:
> Dear Felipe,
>
> Could you please review this patch?
> I hope to remove th
maintainer.
Usually, I send the extcon's pull request to the GregKH
for the next merge after releasing 4.x-rc6.
(4.x-rc4 was released)
Please review this patch.
On 2017년 08월 07일 11:07, Chanwoo Choi wrote:
> Dear Felipe,
>
> Could you please review this patch?
> I hope to remove th
0)
> err = count;
> +out:
> mutex_unlock(>lock);
> return err;
> }
>
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
(buf, "%lu", );
> + err = sscanf(buf, "%lu", );
> + if (err != 1)
> + goto out;
> data->user_frequency = wanted;
> data->valid = true;
> err = update_devfreq(devfreq);
> if (err == 0)
> err = count
;
> + if (!msg)
> + return -ENOMEM;
>
> msg->version = version;
> msg->command = command;
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
1201 - 1300 of 7212 matches
Mail list logo
