ake more than 1 second
> but less than 2.5 seconds and emit a warning on resume for those
> scenarios.
>
> Suggested-by: Aaron Ma
> Suggested-by: Sasha Netfin
> Suggested-by: Hans de Goede
> CC: Mark Pearson
> Fixes: f15bb6dde738cc8fa0 ("e1000e: Add support for S0ix&
adjust it until the kernel could have your
> configuration in a disallow list.
>
> Signed-off-by: Mario Limonciello
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/net/ethernet/intel/e1000e/e1000.h | 1 +
> drivers/net/eth
r.
> - Increase ULP timeout to 2.5 seconds, but show a warning after 1 second.
Thank you. I've given v5 a test on a Lenovo X1 Carbon 8th gen (AMT capable)
and things work fine there with v5:
Tested-by: Hans de Goede
Regards,
Hans
> Changes from v3 to v4:
> - Drop patch 1 for pro
Hi,
On 12/14/20 8:36 PM, Limonciello, Mario wrote:
>> Hi All,
>>
>> Sasha (and the other intel-wired-lan folks), thank you for investigating this
>> further and for coming up with a better solution.
>>
>> Mario, thank you for implementing the new scheme.
>>
>
> Sure.
>
>> I've tested this patch
ontrol methods used for device enumeration.
Thank you for you work on this!
I started with reviewing the series so that I would know what to
expect during testing. All 3 patches look good to me:
Reviewed-by: Hans de Goede
As is the series does not fix the Bluetooth HID misreporting on
the s
Hi,
On 12/14/20 4:34 PM, Mario Limonciello wrote:
> This flag can be used by an end user to disable S0ix flows on a
> buggy system or by an OEM for development purposes.
>
> If you need this flag to be persisted across reboots, it's suggested
> to use a udev rule to call adjust it until the
Hi All,
Sasha (and the other intel-wired-lan folks), thank you for investigating this
further and for coming up with a better solution.
Mario, thank you for implementing the new scheme.
I've tested this patch set on a Lenovo X1C8 with vPRO and AMT enabled in the
BIOS
(the previous issues were
Elia Devito (2):
platform/x86: intel-hid: Add support for SW_TABLET_MODE
platform/x86: intel-hid: Add alternative method to enable switches
Hans de Goede (14):
platform/x86: touchscreen_dmi: Add info for the Predia Basic tablet
platform/x86: acer-wmi: Drop no-op set_quirks call f
Hi,
On 12/9/20 5:50 AM, Chris Chiu wrote:
> The ECS EF20EA laptop ships an AXP288 but it is actually using a
> different, separate FG chip for AC and battery monitoring. On this
> laptop we need to keep using the regular ACPI driver and disable the
> AXP288 FG to avoid reporting two batteries to
Hi,
On 12/8/20 5:14 PM, Alexander Duyck wrote:
> On Tue, Dec 8, 2020 at 1:30 AM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 12/8/20 6:08 AM, Neftin, Sasha wrote:
>>> On 12/7/2020 17:41, Limonciello, Mario wrote:
>>>>> First of all thank you for wo
Hi,
On 12/8/20 1:28 PM, Zou Wei wrote:
> Fix the following sparse warnings:
>
> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:23:24: warning:
> symbol 'mmio_range_devid_0' was not declared. Should it be static?
> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:28:24:
Hi,
On 12/8/20 4:22 PM, Pandruvada, Srinivas wrote:
> On Tue, 2020-12-08 at 20:28 +0800, Zou Wei wrote:
>> Fix the following sparse warnings:
>>
>> drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:23:24:
>> warning: symbol 'mmio_range_devid_0' was not declared. Should it be
>> static?
>>
Hi,
On 12/8/20 3:37 PM, Maximilian Luz wrote:
>>> +
>>> + obj = acpi_evaluate_dsm_typed(handle, _SSH_DSM_GUID,
>>> + SSAM_SSH_DSM_REVISION, func, NULL,
>>> + ACPI_TYPE_INTEGER);
>>> + if (!obj)
>>> + return -EIO;
>>> +
>>> + val =
Hi,
On 12/8/20 7:11 AM, Chris Chiu wrote:
> From: Carlo Caione
>
> The WiFi media button on the Quanta NL3 reports keycodes 0x8b and 0x9b
> to the platform driver. Add the mapping to support these codes.
>
> Signed-off-by: Carlo Caione
> Reviewed-by: Chris Chiu
Thank you for your patch,
Hi,
On 12/7/20 6:47 PM, Vadim Pasternak wrote:
> Fix array names to match assignments for data items and data items
> counter for power and fan attributes.
>
> Patch #1: Provide fixes for system types MSN2700, MSN24xx.
> Patch #1: Provide fixes for system type MSN2700/ComEx.
Thank you for your
Hi,
On 12/8/20 6:08 AM, Neftin, Sasha wrote:
> On 12/7/2020 17:41, Limonciello, Mario wrote:
>>> First of all thank you for working on this.
>>>
>>> I must say though that I don't like the approach taken here very
>>> much.
>>>
>>> This is not so much a criticism of this series as it is a
any
> external specifications.
>
> Change the language used through-out to supplier/consumer.
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
> drivers/acpi/scan.c | 12 ++
Hi,
On 12/7/20 7:15 PM, Srinivas Pandruvada wrote:
> v2
> Fix sparse warnings reported by LKP.
>
> Srinivas Pandruvada (3):
> platform/x86: ISST: Check for unaligned mmio address
> platform/x86: ISST: Allow configurable offset range
> platform/x86: ISST: Change PCI device macros
I've
ids[] any more.
>
> Link:
> https://lore.kernel.org/linux-acpi/52a2b98c-6bf3-760b-eca9-93cf05fb4...@redhat.com/
> Suggested-by: Hans de Goede
> Signed-off-by: Rafael J. Wysocki
Thanks, patch looks good to me. FWIW:
Acked-by: Hans de Goede
Regards,
Hans
> ---
>
> On top of
>
Hi,
On 12/4/20 5:01 PM, Elia Devito wrote:
> From: Elia Devito
>
> Some convertible use the intel-hid ACPI interface to report SW_TABLET_MODE,
> implement this with DMI based allow-list to be sure to activate support
> only on models that effectively have it.
>
> Signed-off-by: Elia Devito
I can take them through the drivers/platform/x86 (pdx86) tree,
but if you prefer to take them upstream through the thermal tree,
then that is fine too...
Here is my ack (as pdx86 maintainer) for taking them through
the thermal tree:
Acked-by: Hans de Goede
Regards,
Hans
Hi,
On 12/4/20 2:57 AM, Srinivas Pandruvada wrote:
> The address should be aligned to 4 byte boundary. So send an error for
> unaligned address.
>
> Signed-off-by: Srinivas Pandruvada
Thank you for your patch-series.
One thing which still seems to be missing after this series is a check for
Hi,
On 12/2/20 2:19 PM, Divya Bharathi wrote:
> BIOS sets incorrect value (zero) when SET value passed for integer attribute
> with + sign. Added workaround to remove + sign before passing input to BIOS
>
> Co-developed-by: Mario Limonciello
> Signed-off-by: Mario Limonciello
>
Hi,
On 12/7/20 7:43 AM, Chris Chiu wrote:
> From: Daniel Drake
>
> Sending the switch state change twice within the same frame is invalid
> evdev protocol and only works if the client handles keys immediately as
> well. Processing events immediately is incorrect, it forces a fake
> order of
Hi,
On 12/3/20 11:30 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The only reference to the mlxplat_mlxcpld_psu[] array got removed,
> so there is now a warning from clang:
>
> drivers/platform/x86/mlx-platform.c:322:30: error: variable
> 'mlxplat_mlxcpld_psu' is not needed and will not
Hi,
On 12/4/20 9:09 PM, Mario Limonciello wrote:
> commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME
> systems")
> disabled s0ix flows for systems that have various incarnations of the
> i219-LM ethernet controller. This was done because of some regressions
> caused by an
Hi,
On 12/6/20 4:58 PM, Maximilian Luz wrote:
> On 12/6/20 8:07 AM, Leon Romanovsky wrote:
>> On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote:
>>> Hello,
>>>
>>> Here is version two of the Surface System Aggregator Module (SAM/SSAM)
>>> driver series, adding initial support for the
Hi,
On 12/6/20 11:33 AM, Leon Romanovsky wrote:
> On Sun, Dec 06, 2020 at 11:04:06AM +0100, Hans de Goede wrote:
>> But there is a difference between being careful and just nacking
>> it because no new UAPI may be added at all (also see GKH's response).
>
> I saw, the
Hi,
On 12/6/20 11:33 AM, Maximilian Luz wrote:
> On 12/6/20 10:06 AM, Leon Romanovsky wrote:> On Sun, Dec 06, 2020 at
> 05:58:32PM +0900, Blaž Hrastnik wrote:
> More on that, the whole purpose of proposed interface is to debug and
> not intended to be used by any user space code.
Hi,
On 12/6/20 9:56 AM, Leon Romanovsky wrote:
> On Sun, Dec 06, 2020 at 09:41:21AM +0100, Hans de Goede wrote:
>> Hi Leon,
>>
>> On 12/6/20 8:07 AM, Leon Romanovsky wrote:
>>> On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote:
>>>> Hello,
&g
want people to work upstream as much as possible.
I know this is not a reason for taking bad code, but I'm not
convinced that this is bad code.
I have not reviewed this myself yet, but once I have reviewed
this and any review remarks have been addressed I do expect to
merge this series through the platform-drivers-x86 tree.
Regards,
Hans de Goede
(drivers/platform/x86 and drivers/platform/surface subsys maintainer)
Hi,
On 12/5/20 4:29 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
>
> The PNP0D80 ("Windows-compatible System Power Management Controller")
> device ID is used for identifying the special device object providing
> the LPI (Low-power S0 Idle) _DSM interface [1]. That device object
>
Hi,
On 12/2/20 7:56 AM, Divya Bharathi wrote:
> BIOS sets incorrect value (zero) when SET value passed for integer attribute
> with + sign. Added workaround to remove + sign before passing input to BIOS
>
> Co-developed-by: Mario Limonciello
> Signed-off-by: Mario Limonciello
>
Hi,
On 11/27/20 7:10 PM, t...@redhat.com wrote:
> From: Tom Rix
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix
Thank you for your patch, I've applied this patch to my review-hans
branch:
Hi,
On 11/25/20 7:50 AM, Qinglang Miao wrote:
> Fix to return the error code -ENODEV when fails to init wmi and
> smm.
>
> Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-*
> modules together")
> Reported-by: Hulk Robot
> Signed-off-by: Qinglang Miao
Thank you for your
Hi Elia,
Thank you for your patch series.
I'm fraid that always enabling this on devices with a chassis_type of 31 is
not a good idea though.
Many 360 degree hinges (yoga) style 2-in-1s use 2 accelerometers to tell
the angle between the 2 halves; and they rely on a HingleAngleService
process
Hi,
On 12/1/20 8:21 PM, Andy Shevchenko wrote:
> On Tue, Dec 01, 2020 at 09:06:38PM +0200, Laurent Pinchart wrote:
>> On Tue, Dec 01, 2020 at 09:05:23PM +0200, Andy Shevchenko wrote:
>>> On Tue, Dec 01, 2020 at 08:55:48PM +0200, Laurent Pinchart wrote:
On Tue, Dec 01, 2020 at 08:54:17PM
s that for 5.10 we really should just go with the 3 reverts
which I suggested earlier.
Regards,
Hans
>
> On Mon, 30 Nov 2020 at 17:48, Hans de Goede wrote:
>>
>> Hi,
>>
>> On 11/28/20 4:48 PM, Tom Yan wrote:
>>> Apparently the former (with the chosen d
Hi,
On 11/30/20 6:20 PM, Alan Stern wrote:
> On Mon, Nov 30, 2020 at 02:36:38PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 11/30/20 2:30 PM, Greg KH wrote:
>>> On Mon, Nov 30, 2020 at 02:23:48PM +0100, Hans de Goede wrote:
>>>> Hi,
>>>>
>
Hi,
On 11/30/20 2:53 PM, Greg KH wrote:
> On Mon, Nov 30, 2020 at 02:36:38PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 11/30/20 2:30 PM, Greg KH wrote:
>>> On Mon, Nov 30, 2020 at 02:23:48PM +0100, Hans de Goede wrote:
>>>> Hi,
>>>>
>
Hi,
On 11/30/20 2:30 PM, Greg KH wrote:
> On Mon, Nov 30, 2020 at 02:23:48PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 11/30/20 1:58 PM, Tom Yan wrote:
>>> It's merely a moving of comment moving for/and a no-behavioral-change
>>> adaptation fo
l 'uv_hubs_kset' was not
> declared. Should it be static?
>
> Signed-off-by: Zou Wei
Since this is a fix to a series merged through the x86/tip tree, this should be
merged
to the x86/tip tree too (or I can pick it up after 5.11-rc1).
Here is my ack for merging this through the x86/tip tree:
oved to its
new place and another patch was added on top, so that is different.
Regards,
Hans
>
> On Mon, 30 Nov 2020 at 17:50, Hans de Goede wrote:
>>
>> Hi,
>>
>> On 11/28/20 4:48 PM, Tom Yan wrote:
>>> While the change only seemed to have cau
Hi,
On 11/28/20 4:48 PM, Tom Yan wrote:
> While the change only seemed to have caused issue on uas drives, we
> probably want to avoid it in the usb-storage driver as well, until
> we are sure it is the right thing to do.
>
> Signed-off-by: Tom Yan
This seems to do a whole lot more then just
al gbit LAN goes back from the regressed 1 MB/s to its original
100MB/s
as it should be:
Tested-by: Hans de Goede
Regards,
Hans
> ---
> drivers/usb/storage/uas.c | 11 +++
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/storage/uas.c b/
Hi,
On 11/28/20 6:15 PM, Christoph Hellwig wrote:
> Can you give this one-liner a spin?
>
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index c6622011d4938c..e889111b55c71d 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -4007,6
Hi Stephen,
On 11/29/20 6:43 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 912b341585e3 ("platform/x86: mlx-platform: Remove PSU EEPROM from MSN274x
> platform configuration")
>
> Fixes tag
>
> Fixes: ef08e14a3 ("platform/x86: mlx-platform: Add support for new msn274x
> system
Hi All,
On 11/29/20 4:23 AM, Jarkko Sakkinen wrote:
> On Tue, Nov 24, 2020 at 10:45:01PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 11/24/20 6:52 PM, Jerry Snitselaar wrote:
>>>
>>> Jarkko Sakkinen @ 2020-11-23 20:26 MST:
>>>
>>>> On W
set).
Here is my ack for the drivers/platform/x86 bits being merged through the
x86/tip tree:
Acked-by: Hans de Goede
Regards,
Hans
>
> v2: Updated to apply to v3 of dependency patch set listed above.
>
> Mike Travis (5):
> x86/platform/uv: Add kernel interfaces for ob
i_add_host())?
I would expect that to work / avoid the regression, so yes that is
a good option.
If you can provide me with a patch doing that, then I can test it to
make sure it does indeed fix the regression.
Regards,
Hans
>
> On Sat, 28 Nov 2020 at 02:12, Hans de Goede wrote:
Hi,
On 11/27/20 5:19 PM, Christoph Hellwig wrote:
> On Fri, Nov 27, 2020 at 01:32:16PM +0100, Hans de Goede wrote:
>> I ran some more tests, I can confirm that reverting:
>>
>> 5df7ef7d32fe "uas: bump hw_max_sectors to 2048 blocks for SS or faster
>> drives"
Hi,
On 11/27/20 3:58 PM, Mike Travis wrote:
>
>
> On 11/26/2020 2:45 AM, Hans de Goede wrote:
>> Hi,
>>
>> On 11/25/20 6:29 PM, Mike Travis wrote:
>>> Add "deprecated" message to any access to old /proc/sgi_uv/* leaves.
>>>
>
Hi,
On 11/27/20 12:41 PM, Hans de Goede wrote:
> Hi,
>
> On 11/24/20 11:27 AM, Christoph Hellwig wrote:
>> On Mon, Nov 23, 2020 at 03:49:09PM +0100, Hans de Goede wrote:
>>> Hi,
>>>
>>> +Cc Christoph Hellwig
>>>
>>> Christop
Hi,
On 11/24/20 11:27 AM, Christoph Hellwig wrote:
> On Mon, Nov 23, 2020 at 03:49:09PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> +Cc Christoph Hellwig
>>
>> Christoph, this is still an issue, so I've been looking around a bit and
>> think this
>> mi
:
- Add info for the Irbis TW118 tablet
- Add info for the Predia Basic tablet
Benjamin Berg (1):
platform/x86: thinkpad_acpi: Send tablet mode switch at wakeup time
Hans de Goede (4):
platform/x86: thinkpad_acpi: Do
Hi,
On 11/25/20 11:10 AM, Vadim Pasternak wrote:
> Remove PSU EEPROM configuration for systems MSN2700, MSN2100, MSN274x
> to support the requirement of power unit replacement by "off the shelf"
> device, matching electrical required parameters. Such device can be
> equipped with different EEPROM
Hi,
On 11/25/20 6:29 PM, Mike Travis wrote:
> Add "deprecated" message to any access to old /proc/sgi_uv/* leaves.
>
> Signed-off-by: Mike Travis
> Reviewed-by: Steve Wahl
> ---
> arch/x86/kernel/apic/x2apic_uv_x.c | 26 +-
> 1 file changed, 25 insertions(+), 1
Hi,
On 11/25/20 6:29 PM, Mike Travis wrote:
>
> Duplicate the current UV procfs leaves to the uv_sysfs driver so they show
> up under /sys/firmware/sgi_uv. Show a 'deprecated' warning message if
> any of the old /proc/sgi_uv leaves are used.
>
> These patches depend on the prior set sent by
| 862 ++
> 10 files changed, 1217 insertions(+), 78 deletions(-)
> create mode 100644 arch/x86/include/asm/uv/uv_geo.h
> delete mode 100644 arch/x86/platform/uv/uv_sysfs.c
> create mode 100644 drivers/platform/x86/uv_sysfs.c
My acked-by for merging the drivers/platform/x86 bits through the x86/tip
tree still stands:
Acked-by: Hans de Goede
REgards,
Hans
Hi,
+Cc Mario
On 11/25/20 7:50 AM, Qinglang Miao wrote:
> Fix to return the error code -ENODEV when fails to init wmi and
> smm.
>
> Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-*
> modules together")
> Reported-by: Hulk Robot
> Signed-off-by: Qinglang Miao
Mario,
Hi,
On 11/24/20 6:52 PM, Jerry Snitselaar wrote:
>
> Jarkko Sakkinen @ 2020-11-23 20:26 MST:
>
>> On Wed, Nov 18, 2020 at 11:36:20PM -0700, Jerry Snitselaar wrote:
>>>
>>> Matthew Garrett @ 2020-10-15 15:39 MST:
>>>
On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar
wrote:
>
>
Hi,
On 11/24/20 1:37 PM, Mathias Nyman wrote:
> On 23.11.2020 15.54, Hans de Goede wrote:
>> Hi,
>>
>> On 11/11/20 3:31 PM, Mika Westerberg wrote:
>>> On Wed, Nov 11, 2020 at 12:27:32PM +0100, Hans de Goede wrote:
>>>> Hi,
>>>>
>>>>
Hi,
On 11/24/20 2:16 PM, Max Verevkin wrote:
> Signed-off-by: Max Verevkin
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans
Hi,
On 11/13/20 11:39 PM, Maximilian Luz wrote:
> In addition to a 13" version, there is also a 15" (business) version of
> the Surface Laptop 3 based on Intel CPUs. This version also handles
> wakeup by lid via (unmarked) GPEs, so add support for it as well.
>
> Signed-off-by: Maximilian Luz
Hi,
On 11/22/20 6:49 AM, xiakaixu1...@gmail.com wrote:
> From: Kaixu Xia
>
> The commit 78429e55e4057 ("platform/x86: toshiba_acpi: Clean up
> variable declaration") cleans up variable declaration in
> video_proc_write(). Seems it does the variable assignment in the
> wrong place, this results
>
> ---
>
> Changes in v3:
> Use only two more generic wildcards.
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
>
> Changes in v2:
> In comparison to first version [0] we use wildcards to enumerate the
> firmware configuration files. Wi
Hi,
On 11/15/20 8:21 PM, Maximilian Luz wrote:
> Hello,
>
> N.B.: the following text is mostly a repeat of cover letter from the
> previous RFC for the uninitiated, which can be found at
>
>
> https://lore.kernel.org/linux-serial/20200923151511.3842150-1-luzmaximil...@gmail.com/
>
>
les under both arch/x86/ and drivers/platform/x86/ ,
I believe this is best merged through the x86/tip tree and I don't
expect conflicts for the drivers/platform/x86/{Kconfig,Makefile} changes.
So here is my ack for merging this series through the x86/tip tree:
Acked-by: Hans de Goede
Regards,
Hans
Hi,
On 11/24/20 11:27 AM, Christoph Hellwig wrote:
> On Mon, Nov 23, 2020 at 03:49:09PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> +Cc Christoph Hellwig
>>
>> Christoph, this is still an issue, so I've been looking around a bit and
>> think this
>> mi
lared (first use in this function)
> irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW);
>
> Fixes: 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which
> modify the irqflags")
> Signed-off-by: Randy Dunlap
> Reported-by: kernel test robot
> Cc: Hans de Goede
> Cc: Dmi
?
Regards,
Hans
On 11/10/20 12:36 PM, Hans de Goede wrote:
> Hi All,
>
> Not sure if this is a XHCI driver problem at all, but I needed to start
> somewhere with reporting this so I went with:
>
> scripts/get_maintainer.pl -f drivers/usb/host/xhci-pci.c
>
&g
Hi,
On 11/11/20 3:31 PM, Mika Westerberg wrote:
> On Wed, Nov 11, 2020 at 12:27:32PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 11/10/20 6:25 PM, Mika Westerberg wrote:
>>> On Tue, Nov 10, 2020 at 04:02:33PM +, Limonciello, Mario wrote:
>>>>>
&
Hi,
On 11/12/20 2:52 PM, Andy Shevchenko wrote:
>
> +Cc: Hans.
>
> I can't speak for AMD, but I think it may be useful for Intel pin control.
> However, I didn't check what may be the side effects of this change and
> neither
> contributor answered to my comments...
AFAICT setting
Hi,
On 11/19/20 6:05 PM, Jerry Snitselaar wrote:
>
> Hans de Goede @ 2020-11-19 07:42 MST:
>
>> Hi,
>>
>> On 11/19/20 7:36 AM, Jerry Snitselaar wrote:
>>>
>>> Matthew Garrett @ 2020-10-15 15:39 MST:
>>>
>>>
q_type(irq, IRQ_TYPE_LEVEL_LOW);
> ^
> 2 errors generated.
>
> Fixes: 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which
> modify the irqflags")
> Reported-by: kernel test robot
> Signed-off-by: Dmitry Torokhov
Thanks, patch l
Hi,
On 11/23/20 7:53 AM, Dmitry Torokhov wrote:
> On Fri, Oct 30, 2020 at 10:56:20AM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 10/29/20 9:36 PM, Dmitry Torokhov wrote:
>>> Hi Andrej,
>>>
>>> On Thu, Oct 29, 2020 at 06:03:11PM +0100, Andrej V
Hi,
On 11/20/20 12:11 PM, Matthias Brugger wrote:
>
>
> On 20/11/2020 11:05, Dmitry Osipenko wrote:
>> 20.11.2020 12:52, matthias@kernel.org пишет:
>>> From: Matthias Brugger
>>>
>>> Apart from a firmware binary the chip needs a config file used by the
>>> FW. Add the config files to
Hi,
On 11/19/20 7:36 AM, Jerry Snitselaar wrote:
>
> Matthew Garrett @ 2020-10-15 15:39 MST:
>
>> On Thu, Oct 15, 2020 at 2:44 PM Jerry Snitselaar wrote:
>>>
>>> There is a misconfiguration in the bios of the gpio pin used for the
>>> interrupt in the T490s. When interrupts are enabled in the
Hi All,
On 11/10/20 12:36 PM, Hans de Goede wrote:
> Hi All,
>
> Not sure if this is a XHCI driver problem at all, but I needed to start
> somewhere with reporting this so I went with:
>
> scripts/get_maintainer.pl -f drivers/usb/host/xhci-pci.c
>
> And added a Cc: l
Hi,
On 11/17/20 9:42 PM, Justin Ernst wrote:
> Introduce a new platform driver to gather topology information from UV systems
> and expose that information via a sysfs interface at /sys/firmware/sgi_uv/.
>
> Justin Ernst (5):
> x86/platform/uv: Remove existing /sys/firmware/sgi_uv/ interface
>
Hi,
On 11/12/20 4:31 PM, Limonciello, Mario wrote:
>>> Pressing the mute key activates a time delayed circuit to physically cut
>>> off the mute. The LED is in the same circuit, so it reflects the true
>>> state of the HW mute. The reason for the EC "ack" is so that software
>>> can first
Hi,
On 11/10/20 6:25 PM, Mika Westerberg wrote:
> On Tue, Nov 10, 2020 at 04:02:33PM +, Limonciello, Mario wrote:
>>>
>>> On Tue, Nov 10, 2020 at 11:57:07AM +0100, Bastien Nocera wrote:
Hey,
systemd has been shipping this script to enable auto-suspend on a
number of USB
Hi,
On 11/10/20 11:17 PM, Doug Anderson wrote:
> Hi,
>
> On Tue, Nov 10, 2020 at 1:01 AM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 11/9/20 10:36 PM, Douglas Anderson wrote:
>>> This patch rejiggers the i2c-hid code so that the OF (Open Firmware
>>
Hi,
On 11/11/20 1:04 AM, Dmitry Torokhov wrote:
> On Tue, Nov 10, 2020 at 02:17:27PM -0800, Doug Anderson wrote:
>> Hi,
>>
>> On Tue, Nov 10, 2020 at 1:01 AM Hans de Goede wrote:
>>>
>>> Hi,
>>>
>>> On 11/9/20 10:36 PM, Douglas Ande
Hi All,
Quick self intro: I have take over drivers/platform/x86
maintainership from Andy; and I'm working my way through
the backlog of old patches in patchwork:
https://patchwork.kernel.org/project/platform-driver-x86/list/
On 8/21/20 8:14 PM, Kenneth Chan wrote:
> The physical optical drive
Hi All,
Not sure if this is a XHCI driver problem at all, but I needed to start
somewhere with reporting this so I went with:
scripts/get_maintainer.pl -f drivers/usb/host/xhci-pci.c
And added a Cc: linux-...@vger.kernel.org as bonus.
I'm seeing the following errors and very slow network
Hi,
Quick self intro: I have take over drivers/platform/x86
maintainership from Andy; and I'm working my way through
the backlog of old patches in patchwork:
https://patchwork.kernel.org/project/platform-driver-x86/list/
On 8/4/20 2:14 AM, Timo Witte wrote:
> Got a dmesg message on my AMD Renoir
vice => power_up (same with power_down).
> - subclass => ops.
>
Thanks this looks good to now, 2 small remarks below (since you are
going to do a v6 anyways). Feel free to ignore these remarks if
you prefer to keep things as is.
And feel free to add my reviewed-by to v6 of this patch:
R
Hi,
On 11/10/20 9:26 AM, Coiby Xu wrote:
> On Mon, Nov 09, 2020 at 02:52:17PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 11/6/20 12:19 AM, Coiby Xu wrote:
>>> Debounce filter setting should be independent from IRQ type setting
>>> because according to the A
Hi,
On 11/9/20 3:29 PM, Benjamin Tissoires wrote:
> Hi,
>
> sorry for the delay. I have been heavily sidetracked and have a bunch
> of internal deadlines coming in :/
>
> On Mon, Nov 9, 2020 at 12:24 PM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 11
-mp2/issues/11#issuecomment-721331582
> [2] https://forum.manjaro.org/t/random-short-touchpad-freezes/30832/28
>
> Cc: Hans de Goede
> Cc: Andy Shevchenko
> Cc: Benjamin Tissoires
> Cc: sta...@vger.kernel.org
> Reviewed-by: Andy Shevchenko
> BugLink: https://bug
henko
> Suggested-by: Hans de Goede
> Reviewed-by: Andy Shevchenko
> Link:
> https://lore.kernel.org/linux-gpio/2f4706a1-502f-75f0-9596-cc25b4933...@redhat.com/
> Signed-off-by: Coiby Xu
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
> ---
Hi,
On 11/6/20 12:19 AM, Coiby Xu wrote:
> The correct way to disable debounce filter is to clear bit 5 and 6
> of the register.
>
> Cc: Hans de Goede
> Link:
> https://lore.kernel.org/linux-gpio/df2c008b-e7b5-4fdd-42ea-4d1c62b52...@redhat.com/
> Signed-off-by: Coiby Xu
Hi,
On 11/5/20 4:25 PM, Iakov 'Jake' Kirilenko wrote:
> Tested on my P1 gen3, works fine with `thinkfan`. Since thinkpad_acpi fan
> control is off by default, it is safe to add 2nd fan control for brave
> overclockers
>
> Signed-off-by: Iakov 'Jake' Kirilenko
Thank you for your patch, I've
Hi,
On 11/4/20 5:06 PM, Doug Anderson wrote:
> Hi,
>
> On Wed, Nov 4, 2020 at 4:07 AM Hans de Goede wrote:
>>
>>> +#include "i2c-hid.h"
>>> +
>>> +struct i2c_hid_acpi {
>>> + struct i2chid_subclass_data subclass;
>>
&
Hi,
On 11/3/20 1:55 PM, Perry Yuan wrote:
> From: perry_yuan
>
> add support for dell privacy driver for the dell units equipped
> hardware privacy design, which protect users privacy
> of audio and camera from hardware level. once the audio or camera
> privacy mode enabled, any
cciss*.h
> F: include/uapi/linux/cciss*.h
>
> +MICROSOFT SURFACE GPE LID SUPPORT DRIVER
> +M: Maximilian Luz
> +L: platform-driver-...@vger.kernel.org
> +S: Maintained
> +F: drivers/platform/surface/surface_gpe.c
> +
> MICROSOFT SURFACE HARDWARE PLATFORM SUPPORT
> M:
Hi,
On 11/4/20 12:17 PM, Lee Jones wrote:
> Enjoy!
>
> The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec:
>
> Linux 5.10-rc1 (2020-10-25 15:14:11 -0700)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git
Hi,
On 11/4/20 2:29 AM, Douglas Anderson wrote:
> Goodix i2c-hid touchscreens are mostly i2c-hid compliant but have some
> special power sequencing requirements, including the need to drive a
> reset line during the sequencing.
>
> Let's use the new ability of i2c-hid to have subclasses for
Hi,
On 11/4/20 2:29 AM, Douglas Anderson wrote:
> This patch rejiggers the i2c-hid code so that the OF (Device Tree) and
> ACPI support is separated out a bit. The OF and ACPI drivers are now
> effectively "subclasses" of the generic code.
>
> Essentially, what we're doing here:
> * Make "power
401 - 500 of 4303 matches
Mail list logo
