On Friday, February 26, 2021 12:23 PM, Alexander Sverdlin wrote:
> On Fri, 2021-02-26 at 17:43 +0100, Arnd Bergmann wrote:
>> Randconfig builds with ep93xx fail with the clang integrated assembler
>> that does not understand the maverick crunch extensions:
>>
>> arch/arm/mach-ep93xx/crunch-bits.S
On Monday, April 15, 2019 12:47 PM, Arnd Bergmann wrote:
> On Mon, Apr 15, 2019 at 9:39 PM Hartley Sweeten
> wrote:
>>> -#define EP93XX_KEYPAD_KDIV (1<<4) /* 1/4 clock or 1/16 clock */
>>> -#define EP93XX_KEYPAD_AUTOREPEAT (1<<5) /* e
On Monday, April 15, 2019 12:25 PM, Arnd Bergmann wrote:
> We can communicate the clock rate using platform data rather than setting a
> flag to use a particular value in the driver, which is cleaner and avoids the
> dependency.
>
> No platform in the kernel currently defines the ep93xx keypad dev
MAINTAINERS | 6 ++
> arch/arm/mach-ep93xx/Kconfig | 7 ++
> arch/arm/mach-ep93xx/ts72xx.c | 165
> +++---
> arch/arm/mach-ep93xx/ts72xx.h | 9 +++
> arch/arm/tools/mach-types | 1 +
> 5 files changed, 176 insertions(+), 12 deletions(-)
Looks good. Thanks!
Acked-by: H Hartley Sweeten
On Monday, December 11, 2017 2:40 PM, Lukasz Majewski wrote:
> Hi Hartley,
>
>> On Thursday, November 30, 2017 4:52 PM, Lukasz Majewski wrote:
>>>
>>> The BK3 board is a derivative of the ts72xx reference design.
>>
>> Lukasz,
>>
>> I was just reviewing the other TS-72xx boards and noticed this
On Thursday, November 30, 2017 4:52 PM, Lukasz Majewski wrote:
>
> The BK3 board is a derivative of the ts72xx reference design.
Lukasz,
I was just reviewing the other TS-72xx boards and noticed this:
> +/* BK3 specific defines */
> +#define BK3_CPLDVER_PHYS_BASE0x2340
> +#
/tools/mach-types | 1 +
> 5 files changed, 202 insertions(+), 19 deletions(-)
Looks good.
Acked-by: H Hartley Sweeten
Linus,
Would you mind picking this series up?
Thanks,
Hartley
On Wednesday, November 29, 2017 5:45 PM, Lukasz Majewski wrote:
> This patch extends readability of ts72xx.c code.
>
> Signed-off-by: Lukasz Majewski
> ---
> Changes for v2:
> - New patch
> ---
> arch/arm/mach-ep93xx/ts72xx.c | 12
> 1 file changed, 12 insertions(+)
This patch does
On Wednesday, November 29, 2017 5:45 PM, Lukasz Majewski wrote:
> The map IO common code has been excluded to be reused by other ts72xx clones.
>
> Signed-off-by: Lukasz Majewski
> Acked-by: Alexander Sverdlin
> arch/arm/mach-ep93xx/ts72xx.c | 23 ---
> 1 file changed, 16 i
On Wednesday, November 29, 2017 5:45 PM, Lukasz Majewski wrote:
> This commit extend the ts72xx_register_flash() to accept passed parameters,
> which makes it more reusable.
>
> Now it is possible to accept ep93xx flash start address and partitions.
@@ -223,7 +217,9 @@ static struct platform_de
On Wednesday, November 29, 2017 5:45 PM, Lukasz Majewski wrote:
> This commit cleans up the code by using dedicated macros instead of full
> definitions.
>
> Signed-off-by: Lukasz Majewski
> Acked-by: Alexander Sverdlin
> @@ -187,16 +187,8 @@ static struct platform_device ts72xx_rtc_device =
On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote:
> On 26/11/17 01:50, Alex Frappier Lachapelle wrote:
>> +const struct comedi_lrange *lrange;
>
> NAK. The following lines of source code allocate memory pointed to by
> 'lrange' and modify it, so 'const' is not appropriate here.
On Monday, May 22, 2017 6:30 AM, Alexander Sverdlin wrote:
> As agreed with Ryan, change the maintainership.
>
> Signed-off-by: Alexander Sverdlin
Acked-by: H Hartley Sweeten
Welcome aboard!
n");
> + pr_warn("scl != EECLK, open drain has no effect\n");
>
> __raw_writel((data->sda_is_open_drain << 1) |
>(data->scl_is_open_drain << 0),
For the ep93xx part:
Acked-by: H Hartley Sweeten
Commit-ID: f435da416beaacc8934fc21820d9488269b39c98
Gitweb: http://git.kernel.org/tip/f435da416beaacc8934fc21820d9488269b39c98
Author: H Hartley Sweeten
AuthorDate: Fri, 10 Feb 2017 09:54:16 -0700
Committer: Thomas Gleixner
CommitDate: Fri, 10 Feb 2017 20:17:52 +0100
genirq: Fix /proc
If the irq_desc being output does not have a domain the information
following the 'name' is not aligned correctly.
Signed-off-by: H Hartley Sweeten
Cc: Thomas Gleixner
---
kernel/irq/proc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/irq/proc.c b/kernel/irq/pr
rious reboot.
>
> Do not pull ts72xx.h, but instead locally define what we need to disable
> the watchdog.
>
> Signed-off-by: Florian Fainelli
> ---
> Arnd, this is a recent, so you can queue this up, thanks!
Reviewed-by: H Hartley Sweeten
or Tested-by/Acked-by as appropriate...
Hartley
On Monday, January 30, 2017 12:02 PM, Guenter Roeck wrote:
> On Mon, Jan 30, 2017 at 09:55:48AM -0700, H Hartley Sweeten wrote:
>> Cleanup this driver and convert it to use the watchdog framework API.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc: Mika Westerberg
>
On Monday, January 30, 2017 11:55 AM, Guenter Roeck wrote:
> On Mon, Jan 30, 2017 at 09:55:47AM -0700, H Hartley Sweeten wrote:
>> Cleanup this driver and remove the 200ms heartbeat timer. The core now
>> has the ability to handle the heartbeat.
>>
>> Signed-off-by: H
The ep93xx_wdt driver is used by EP93xx based platforms for the internal
watchdog of the EP93xx processor. The TS-72xx platforms have an additional
watchdog provided by the CPLD on those boards.
Cleanup both drivers.
H Hartley Sweeten (2):
watchdog: ep93xx_wdt: cleanup and let the core handle
Cleanup this driver and remove the 200ms heartbeat timer. The core now
has the ability to handle the heartbeat.
Signed-off-by: H Hartley Sweeten
Cc: Wim Van Sebroeck
Cc: Guenter Roeck
---
drivers/watchdog/ep93xx_wdt.c | 115 +-
1 file changed, 46
Cleanup this driver and convert it to use the watchdog framework API.
Signed-off-by: H Hartley Sweeten
Cc: Mika Westerberg
Cc: Wim Van Sebroeck
Cc: Guenter Roeck
---
drivers/watchdog/ts72xx_wdt.c | 447 +-
1 file changed, 93 insertions(+), 354
On Tuesday, January 03, 2017 6:14 PM, Florian Fainelli wrote:
>
> In preparation for adding CONFIG_DEBUG_VIRTUAL support, define a set of
> common constants: KERNEL_START and KERNEL_END which abstract
> CONFIG_XIP_KERNEL vs. !CONFIG_XIP_KERNEL. Update the code where
> relevant.
>
> Acked-by: Russel
On Sunday, December 18, 2016 7:08 PM, Florian Fainelli wrote:
> Le 12/11/16 à 11:16, Florian Fainelli a écrit :
>> The TS-72xx/73xx boards have a CPLD watchdog which is configured to
>> reset the board after 8 seconds, if the kernel is large enough that this
>> takes about this time to decompress t
> Reviewed-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
On Thursday, December 15, 2016 4:47 AM, Ian Abbott wrote:
> On 14/12/16 16:14, Hartley Sweeten wrote:
>> On December 14, 2016 6:42 AM, Piotr Gregor wrote:
>>> -struct pci_dev *comedi_to_pci_dev(struct comedi_device *);
>>> +struct pci_dev *comedi_to_pci_dev(struct com
On Wednesday, December 14, 2016 11:55 AM, Florian Fainelli wrote:
> My understanding is that, yes, this triggers the final write. You are
> right that ts73xx_fpga_write() can be called multiple times. It sounds
> like what my write_complete function does right now is just return that
> we successfu
On Monday, December 12, 2016 9:02 AM, Alan Tull wrote:
> On Sun, 11 Dec 2016, Florian Fainelli wrote:
>> Add support for loading bitstreams on the Altera Cyclone II FPGA
>> populated on the TS-7300 board. This is done through the configuration
>> and data registers offered through a memory interfac
On December 14, 2016 6:42 AM, Piotr Gregor wrote:
> Add names of parameters to function prototypes in comedi PCI.
> Checkpatch reports now no errors.
>
> Signed-off-by: Piotr Gregor
> ---
> drivers/staging/comedi/comedi_pci.h | 18 ++
> 1 file changed, 10 insertions(+), 8 deletion
-ep93xx/ts72xx.c | 26 ++
> 1 file changed, 26 insertions(+)
For the ep93xx core change:
Acked-by: H Hartley Sweeten
s a bit clearer:
+ /*
+* Require trig_num == cmd->start_arg when cmd->start_src == TRIG_INT.
+* For backwards compatibility, any trig_num is valid when
+* cmd->start_src != TRIG_INT (i.e. when cmd->start_src == TRIG_EXT);
+* in that case, the internal tri
On Sunday, June 26, 2016 3:03 PM, Alexandre Belloni wrote:
> m48t86.h belongs to include/linux/platform_data/
>
> Signed-off-by: Alexandre Belloni
> ---
> Cc: Hartley Sweeten
> Cc: Ryan Mallon
> Cc: Alexander Clouter
> Cc: Jason Cooper
> Cc: Andrew Lunn
> C
On Friday, June 17, 2016 9:02 PM, Greg KH wrote:
>> The patch looks fine (although this odd-ball Comedi driver shouldn't really
>> be sending signals to a user-space task!).
>
> Yeah, that's really odd, fixing that would be nice...
This is the last addi-data driver that does this. It's on my list
On Tuesday, June 07, 2016 4:51 AM, Ravishankar Karkala Mallikarjunayya wrote:
> Subject: [PATCH 5/5] Staging: comedi: Prefer using the BIT macro issue in
> dmm32at.c
Please don't add random patches to a series. You started this series with 1/4,
2/4,
3/4 and 4/4 then added a 5/5.
Also, please f
On Friday, May 20, 2016 10:18 AM, Ian Abbott wrote:
> On 20/05/16 17:37, Hartley Sweeten wrote:
>> On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote:
>>> Rename the macros for the PLX PCI 9080 LAS0RR and LAS1RR registers in
>>> "plx9080.h", using the prefix
On Friday, May 20, 2016 9:31 AM, Ian Abbott wrote:
> On 20/05/16 17:21, Hartley Sweeten wrote:
>> Just an comment on your renaming.
>>
>> You also renamed the registers in the daqbook2000 driver in the
>> _REG_ format. Personally I prefer the format to be
>>
On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote:
> Rename the macros for the PLX PCI 9080 LAS0RR and LAS1RR registers in
> "plx9080.h", using the prefix `PLX_LASRR_`. Make use of the `BIT(x)`
> and `GENMASK(h,l)` macros to define the values.
>
> Define a macro `PLX_LASRR_PREFETCH` for the "prefe
On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote:
> Rename the macros in "plx9080.h" that define the offsets of registers,
> following the pattern `PLX_REG_`, where `` is the register
> name from the PLX PCI 9080 Data Book.
>
> Add defines for the "Mailbox" registers, and add parameterized macros
On Thursday, May 19, 2016 2:56 AM, Ian Abbott wrote:
> Rename the macros defining register offsets to avoid CamelCase, and to
> use namespace associated with the driver.
>
> Signed-off-by: Ian Abbott
> Reviewed-by: H Hartley Sweeten
> ---
> Other CamelCase issues in this pat
On Wednesday, May 18, 2016 5:37 AM, Ian Abbott wrote:
> Rename the macros that define values for the reference DACs register to
> avoid CamelCase, and to make it clearer which register they are
> associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value
> `0x80` that triggers setting
On Wednesday, May 18, 2016 5:37 AM, Ian Abbott wrote:
> Rename the macros defining register offsets to avoid CamelCase, and to
> use namespace associated with the driver.
>
> Signed-off-by: Ian Abbott
> Reviewed-by: H Hartley Sweeten
> ---
> Other CamelCase issues in thi
188 deletions(-)
Ian,
I had a couple comments on patches 1, 5, 6, and 14 but they are really just
nitpicks. If you prefer to leave this series as-is:
Reviewed-by: H Hartley Sweeten
Thanks for going through this one, it's annoyed me...
Hartley
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
> The checkpatch.pl warns about two `udelay(x)` calls, one of 100
> microseconds, and one of 10 microseconds. The 100 microseconds one is
> used when waiting for FPGA to become ready to accept firmware, and is
> not that critical, so replace it w
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
> Rename the macros defining register offsets to avoid CamelCase, and to
> use namespace associated with the driver.
>
> Signed-off-by: Ian Abbott
> ---
> Other CamelCase issues in this patch will be dealt with by later
> patches in the series.
>
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
> Remove some commented out code. Some of it uses constructs that don't
> exist in the driver, and probably come from the source code for the MS
> Windows driver.
>
> Signed-off-by: Ian Abbott
> ---
> drivers/staging/comedi/drivers/daqboard2000
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote:
> Rename the macros defining values for the Serial EEPROM Control Register
> to avoid CamelCase.
>
> Signed-off-by: Ian Abbott
> ---
> drivers/staging/comedi/drivers/daqboard2000.c | 26 +-
> 1 file changed, 13 insertions
On Wednesday, April 06, 2016 3:41 AM, Ian Abbott wrote:
> On 06/04/16 10:41, Ian Abbott wrote:
>> On 06/04/16 02:21, Hartley Sweeten wrote:
>>> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
>>>> The variable unipolar was never used.
>>&g
On Wednesday, April 06, 2016 2:41 AM, Ian Abbott wrote:
> On 06/04/16 02:21, Hartley Sweeten wrote:
>> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
>>> The variable unipolar was never used.
>>>
>>> Signed-off-by: Sudip Mukherjee
>>> -
On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote:
> The variable unipolar was never used.
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> There may be a chance that reading from DAS1800_CONTROL_C is necessary
> before reading from DAS1800_STATUS. If that is true then please discard
> this pa
io_c_common.c
> deleted file mode 100644
> index e69de29..000
Weird. Good catch.
Reviewed-by: H Hartley Sweeten
On Thursday, March 17, 2016 9:09 AM, Arnd Bergmann wrote:
> On Thursday 17 March 2016 15:47:57 Hartley Sweeten wrote:
>> On Wednesday, March 16, 2016 1:51 PM, Arnd Bergmann wrote:
>>
>> Is this a gcc-6 specific issue? Seems line this warning should be showing
>> up in a
hough the code is correct as far as I
> can tell.
>
> This disambiguates the operation by making the constant expressions
> we pass here explicitly 'unsigned', which helps to avoid the warning.
>
> As pointed out by Hartley Sweeten, scripts/checkpatch.pl notices that
> th
On Tuesday, March 15, 2016 2:50 PM, Arnd Bergmann wrote:
> On Tuesday 15 March 2016 21:35:40 Hartley Sweeten wrote:
>> On Monday, March 14, 2016 3:48 PM, Arnd Bergmann wrote:
>>> gcc-6 warns about passing negative signed integer into swab16()
>>> in the dt282x driver:
On Monday, March 14, 2016 3:48 PM, Arnd Bergmann wrote:
> gcc-6 warns about passing negative signed integer into swab16()
> in the dt282x driver:
> The warning makes sense, though the code is correct as far as I
> can tell.
>
> This disambiguates the operation by making the constant expressions
comedi: comedi.h: Fix comment for struct comedi_krange
>
> drivers/staging/comedi/comedi.h | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
Thanks for fixing this. I noticed the same issue yesterday.
Reviewed-by: H Hartley Sweeten
On Monday, February 01, 2016 5:26 AM, Ian Abbott wrote:
> On 01/02/16 01:06, Pablo G. Gallardo wrote:
>> This patch wraps lines over 80 characters.
>>
>> Signed-off-by: Pablo G. Gallardo
>> ---
>> drivers/staging/comedi/comedi_pcmcia.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
letions(-)
Ian,
Other than the minor nit-pick in patch 1 about the 'count == 0'
when becoming non-busy (the same situation is in comedi_read),
this looks good to me. It also makes the 'write' look more like the
'read'.
Thanks,
Reviewed-by: H Hartley Sweeten
--
T
replace counter mode bitfield struct
> 2) staging: comedi: s526: add macros for counter control reg values
>
> drivers/staging/comedi/drivers/s526.c | 197
> ++
> 1 file changed, 130 insertions(+), 67 deletions(-)
Thanks! This one has bugged me.
On Wednesday, November 18, 2015 10:55 AM, Ian Abbott wrote:
> Rearrange the code in `comedi_write()` to reduce the amount of
> indentation. The code never reiterates the `while` loop once `count`
> has become non-zero, so we can check that in the `while` condition to
> save an indentation level.
On Wednesday, November 18, 2015 9:42 AM, Ian Abbott wrote:
> On 16/11/15 17:18, Ranjith Thangavel wrote:
[snip]
>> -#define DMM32AT_AI_CFG_SCINT_20US (0 << 4)
>> -#define DMM32AT_AI_CFG_SCINT_15US (1 << 4)
>> -#define DMM32AT_AI_CFG_SCINT_10US (2 << 4)
>> -#define DMM32AT_AI_CFG_SCINT_5US
On Monday, November 16, 2015 10:09 AM, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator, usleep_range is preferred over
> udelay - coding style issue
>
> Signed-off-by: Ranjith Thangavel
> ---
> drivers/staging/comedi/drivers/dmm32at.c |4 +
On Monday, November 09, 2015 10:14 AM, Ranjith wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith
This has already been fixed. Please base your patches on linux-next
or Greg Kroah-Hartman's staging-next tree.
Also,
On Monday, November 09, 2015 8:09 AM, Ranjith wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith
> ---
> drivers/staging/comedi/drivers/pcmmio.c | 44
> +++
> 1 file changed, 22 inserti
On Monday, November 09, 2015 8:17 AM, Ranjith wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith
> ---
> drivers/staging/comedi/drivers/comedi_parport.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
On Monday, November 09, 2015 9:26 AM, Ranjith wote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith
This has already been fixed in by:
commit c98f4011ebd41ab9ff15e1c52acc446e1ee7e191
staging: comedi: ii_pci20kc: prefer
; drivers/staging/comedi/drivers/comedi_test.c | 565
> ++++++++++++---
> 1 file changed, 416 insertions(+), 149 deletions(-)
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@v
ne.
>
> 1) staging: comedi: comedidev.h: add comments to spin-lock and mutex
> 2) staging: comedi: comedidev.h: spaces preferred around that '*'
>
> drivers/staging/comedi/comedidev.h | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
Thanks!
Revi
> 08) staging: comedi: return error on "read" if no command set up
> 09) staging: comedi: simplify returned errors for comedi_read()
> 10) staging: comedi: check for more errors for zero-length read
>
> drivers/staging/comedi/comedi_fops.c | 68
> +---
g/comedi/comedi_buf.c | 19 +--
> drivers/staging/comedi/comedi_fops.c | 17 +
> drivers/staging/comedi/comedi_internal.h | 1 +
> 3 files changed, 23 insertions(+), 14 deletions(-)
Thanks!
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from
On Friday, October 09, 2015 4:27 AM, Ian Abbott wrote:
> The main mutex in a comedi device can get held for quite a while when
> processing comedi instructions, so for performance reasons, the "read"
> and "write" file operations do not use it; they use use the
> `attach_lock` rwsemaphore to protec
On Wednesday, September 30, 2015 9:37 AM, Ian Abbott wrote:
> Expand the descriptions of the functions and document the return values.
>
> Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&quo
On Wednesday, September 30, 2015 9:11 AM, Ian Abbott wrote:
> Expand the descriptions of the functions and document the return values.
>
> Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&quo
On Wednesday, September 30, 2015 8:44 AM, Ian Abbott wrote:
> Fix the 'Return' tags in the kernel-doc comments as they currently say
> 'Returns', which is not recognized by kernel-doc.
>
> Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
--
To unsubscri
On Wednesday, September 23, 2015 11:36 AM, Ian Abbott wrote:
> Expand the descriptions of the functions and document the return values.
>
> Signed-off-by: Ian Abbott
Thanks,
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kerne
eturn values sections.
>
> Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info
changed, 516 insertions(+), 101 deletions(-)
Thanks,
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-
> 1 file changed, 88 insertions(+), 18 deletions(-)
Thanks,
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info
parent = &pdev->dev;
watchdog_set_nowayout(&ep93xx_wdt_wdd, nowayout);
For ep93xx_wdt.c, use whichever tag you prefer:
Reviewed-by: H Hartley Sweeten
Acked-by: H Hartley Sweeten
Thanks,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the bo
states of clockevent
> devices, for example: ONESHOT_STOPPED.
>
> Signed-off-by: Viresh Kumar
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
invalid.
> + */
> int comedi_check_chanlist(struct comedi_subdevice *s, int n,
> unsigned int *chanlist)
> {
Thanks,
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
gma: round down AI scan_begin_arg at step 4.
> 5) staging: comedi: usbduxsigma: remove unused "convert" timing for AO
> 6) staging: comedi: usbduxsigma: round down AO scan_begin_arg at step 4.
>
> drivers/staging/comedi/drivers/usbduxsigma.c | 139
> +++-------
.h | 48 ++---
> 2 files changed, 188 insertions(+), 193 deletions(-)
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-
vers/amplc_dio200_pci.c | 35 +++---
> 4 files changed, 91 insertions(+), 80 deletions(-)
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info a
gt; function prototype. Just declare the structure type incompletely and
> don't bother including the header file.
>
> Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
ng/comedi/drivers/8255.h| 19 +-
> drivers/staging/comedi/drivers/Makefile | 3 +-
> drivers/staging/comedi/drivers/comedi_8255.c | 285
> +++
> 5 files changed, 322 insertions(+), 235 deletions(-)
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from
y by including .
>
> Signed-off-by: Ian Abbott
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
s
> the `dma_addr_t` type, so include to declare it. (Also,
> that indirectly takes care of the use of `NULL`.) It uses `struct
> comedi_device *` in various function prototypes, so add an incomplete
> declaration of `struct comedi_device`.
>
> Signed-off-by: Ian Abbott
Rev
On Tuesday, May 19, 2015 1:40 PM, Alexandre Belloni wrote:
> On 21/03/2012 at 10:55:31 -0700, hartleys wrote :
>> Drivers should not be using the __raw_* io accessors.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc: Alessandro Zummo
>
>
> Rebased and appli
comedi: gsc_hpdi: use a better MODULE_DESCRIPTION()
>
> drivers/staging/comedi/drivers/gsc_hpdi.c | 184 +-
> 1 file changed, 80 insertions(+), 104 deletions(-)
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linu
On Wednesday, May 06, 2015 7:06 AM, nick wrote:
> On 2015-05-06 05:10 AM, Ian Abbott wrote:
>> On 06/05/15 01:22, nick wrote:
>>> Greetings All,
>>> I am wondering if in the function,ni_stc_dma_channel_select_bitfield the
>>> line:
>>> return 1 << channel;
>>> is guaranteed to be below the thresho
xported functions in "mite.c".
>
> drivers/staging/comedi/drivers/mite.c | 110
> +-
> drivers/staging/comedi/drivers/mite.h | 88 ++-
> 2 files changed, 101 insertions(+), 97 deletions(-)
Reviewed-by: H Hartley Sw
nternal.h | 1 +
> drivers/staging/comedi/comedidev.h | 18 +-
> drivers/staging/comedi/drivers.c | 2 +-
> .../staging/comedi/drivers/amplc_dio200_common.c | 6 ++--
> 5 files changed, 45 insertions(+), 23 deletions(-)
Reviewed-by: H Hartley Sw
On Tuesday, March 31, 2015 2:43 AM, Ian Abbott wrote:
> On 30/03/15 17:47, Hartley Sweeten wrote:
>> On Friday, March 27, 2015 8:13 AM, Ian Abbott wrote:
>>> `comedi_event()` is called from low-level drivers to handle comedi
>>> asynchronous command event flags. As a
.h"
> 47) staging: comedi: pcl711: remove #include "comedi_fc.h"
> 48) staging: comedi: pcl726: remove #include "comedi_fc.h"
> 49) staging: comedi: pcl812: remove #include "comedi_fc.h"
> 50) staging: comedi: pcl816: remove #include "comedi_fc.h"
On Sunday, March 29, 2015 10:35 AM, Ian Abbott wrote:
> On 29/03/15 14:42, Michael S. Tsirkin wrote:
>> Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h,
>> use the new header directly so we can drop
>> the wrapper in include/linux/pci_ids.h.
>>
>> Signed-off-by: Michael S. Tsirkin
>> ---
ce
> *hardware_device);
Seems sane. Just to be clear, the build isn't currently broken.
This just insures that it doesn't break... :-)
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
on patch 7, which can be addressed in a separate
patch if you prefer.
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Friday, March 27, 2015 8:13 AM, Ian Abbott wrote:
> `comedi_event()` is called from low-level drivers to handle comedi
> asynchronous command event flags. As a safety check, it checks the
> subdevice's "run" flags to make sure an asynchronous command is running.
> It can also change the run fla
medidev.h" so that comedi PCI drivers do not need to include them
> explicitly.
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kern
On Tuesday, March 10, 2015 9:25 AM, Joe Perches wrote:
> On Tue, 2015-03-10 at 16:10 +, Ian Abbott wrote:
>> "comedidev.h" includes PCI-specific stuff that gets included by all
>> comedi drivers including non-PCI ones. Separate it out into its own
>> header "comedi_pci.h". Make the new header
1 - 100 of 716 matches
Mail list logo
