[PATCH] ipvs: Avoid unnecessary calls to skb_is_gso_sctp

In the context of the SCTP SNAT/DNAT handler, these calls can only return true. Ref: e10d3ba4d434 ("ipvs: Fix checksumming on GSO of SCTP packets") Signed-off-by: Ismael Luceno CC: Pablo Neira Ayuso CC: Michal Kubeček CC: Simon Horman CC: Julian Anastasov CC: lvs-de...@vger.ker

[PATCH v3] ipvs: Fix checksumming on GSO of SCTP packets

-developed-by: Firo Yang Signed-off-by: Ismael Luceno Tested-by: Andreas Taschner CC: Michal Kubeček CC: Simon Horman CC: Julian Anastasov CC: lvs-de...@vger.kernel.org CC: netfilter-de...@vger.kernel.org CC: net...@vger.kernel.org CC: coret...@netfilter.org --- Notes: Changes since v2:

Re: [PATCH] ipvs: Fix checksumming on GSO of SCTP packets

On 21/Apr/2024 14:01, Julian Anastasov wrote: <...> > Thanks for the fix, I'll accept this but skb_is_gso_sctp() > has comment for pre-condition: skb_is_gso(skb). Can you send v2 > with it? Thanks; sent! > I'm guessing what should be the Fixes line, may be?: > > Fixes: 90017accff61 (

[PATCH v2] ipvs: Fix checksumming on GSO of SCTP packets

-developed-by: Firo Yang Signed-off-by: Ismael Luceno Tested-by: Andreas Taschner CC: Michal Kubeček CC: Simon Horman CC: Julian Anastasov CC: lvs-de...@vger.kernel.org CC: netfilter-de...@vger.kernel.org CC: net...@vger.kernel.org CC: coret...@netfilter.org --- Notes: Changes since v1:

[PATCH] ipvs: Fix checksumming on GSO of SCTP packets

It was observed in the wild that pairs of consecutive packets would leave the IPVS with the same wrong checksum, and the issue only went away when disabling GSO. IPVS needs to avoid computing the SCTP checksum when using GSO. Co-developed-by: Firo Yang Signed-off-by: Ismael Luceno Tested-by

Re: [PATCH] media: solo6x10: remove useless function

c, > int skip, > } > > /* Extract values from VOP header - VE_STATUSxx */ > -static inline int vop_interlaced(const vop_header *vh) > -{ > - return (__le32_to_cpu((*vh)[0]) >> 30) & 1; > -} > - > static inline u8 vop_channel(const vop_header *vh) &

[PATCH] docs: reporting-issues: Remove reference to oldnoconfig

Replace it with olddefconfig. oldnoconfig didn't do what the document suggests (it aliased to olddefconfig), and isn't available since 4.19. Ref: 04c459d20448 ("kconfig: remove oldnoconfig target") Ref: 312ee68752fa ("kconfig: announce removal of oldnoconfig if used"

[PATCH] checkpatch: Use python3 by default with spdxcheck.py

Allow to override this via the PYTHON environment variable. Some systems still provide Python 2.x under the python name for compatibility reasons; plus the spdxcheck.py script already specifies python3 as it's interpreter. Signed-off-by: Ismael Luceno --- scripts/checkpatch.pl | 5 +++

Re: [PATCH] media: solo6x10: switch from 'pci_' to 'dma_' API

solo_dev->vh_size, > - &solo_dev->vh_dma); > + solo_dev->vh_buf = dma_alloc_coherent(&solo_dev->pdev->dev, > + solo_dev->vh_size, > + &solo_dev->vh_dma, GFP_KERNEL); > if (solo_dev->vh_buf == NULL) > return -ENOMEM; > > @@ -1363,8 +1364,8 @@ int solo_enc_v4l2_init(struct solo_dev *solo_dev, > unsigned nr) > > while (i--) > solo_enc_free(solo_dev->v4l2_enc[i]); > - pci_free_consistent(solo_dev->pdev, solo_dev->vh_size, > - solo_dev->vh_buf, solo_dev->vh_dma); > + dma_free_coherent(&solo_dev->pdev->dev, solo_dev->vh_size, > + solo_dev->vh_buf, solo_dev->vh_dma); > solo_dev->vh_buf = NULL; > return ret; > } > @@ -1391,6 +1392,6 @@ void solo_enc_v4l2_exit(struct solo_dev *solo_dev) > solo_enc_free(solo_dev->v4l2_enc[i]); > > if (solo_dev->vh_buf) > - pci_free_consistent(solo_dev->pdev, solo_dev->vh_size, > - solo_dev->vh_buf, solo_dev->vh_dma); > + dma_free_coherent(&solo_dev->pdev->dev, solo_dev->vh_size, > + solo_dev->vh_buf, solo_dev->vh_dma); > } > -- > 2.27.0 > Signed-off-by: Ismael Luceno

Re: [PATCH] media: solo6x10: fix missing snd_card_free in error handling case

if (ret < 0) > - return ret; > + goto snd_error; > > ret = solo_snd_pcm_init(solo_dev); > if (ret < 0) > -- > 2.23.0 > Signed-off-by: Ismael Luceno

Re: [PATCH] Replace HTTP links with HTTPS ones: SOFTLOGIC 6x10 MPEG CODEC

o6x10-v4l2.c > index 54434f3c428d..24ef0c446bef 100644 > --- a/drivers/media/pci/solo6x10/solo6x10-v4l2.c > +++ b/drivers/media/pci/solo6x10/solo6x10-v4l2.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-or-later > /* > - * Copyright (C) 2010-2013 Bluecherry, LLC <http://www.bluecherrydvr.com> > + * Copyright (C) 2010-2013 Bluecherry, LLC <https://www.bluecherrydvr.com> > * > * Original author: > * Ben Collins > diff --git a/drivers/media/pci/solo6x10/solo6x10.h > b/drivers/media/pci/solo6x10/solo6x10.h > index 9f2314688cec..126f6fb7b755 100644 > --- a/drivers/media/pci/solo6x10/solo6x10.h > +++ b/drivers/media/pci/solo6x10/solo6x10.h > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0-or-later */ > /* > - * Copyright (C) 2010-2013 Bluecherry, LLC <http://www.bluecherrydvr.com> > + * Copyright (C) 2010-2013 Bluecherry, LLC <https://www.bluecherrydvr.com> > * > * Original author: > * Ben Collins > -- > 2.27.0 > Signed-off-by: Ismael Luceno

Re: [PATCH 3/8] [media] solo6x10: use ktime_get_ts64() for time sync

ong)ts.tv_sec - (long)sec; > + diff = (s32)ts.tv_sec - (s32)sec; > diff = (diff * 100) > - + ((long)(ts.tv_nsec / NSEC_PER_USEC) - (long)usec); > + + ((s32)(ts.tv_nsec / NSEC_PER_USEC) - (s32)usec); > > if (diff > 1000 || diff < -1000) { > solo_set_time(solo_dev); > -- > 2.9.0 > Signed-off-by: Ismael Luceno signature.asc Description: PGP signature

Re: [PATCH] [media] solo6x10: hide unused variable

pio.c > +++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c > @@ -162,7 +162,9 @@ static void solo_gpiochip_set(struct gpio_chip *chip, > > int solo_gpio_init(struct solo_dev *solo_dev) > { > +#ifdef CONFIG_GPIOLIB > int ret; > +#endif > > solo_gpio_config(solo_dev); > #ifdef CONFIG_GPIOLIB > -- > 2.9.0 > Signed-off-by: Ismael Luceno

Re: [PATCH v2] [media] pci: make video_device const

; b/drivers/media/pci/tw68/tw68-video.c > index 58c4dd7..8c1f4a0 100644 > --- a/drivers/media/pci/tw68/tw68-video.c > +++ b/drivers/media/pci/tw68/tw68-video.c > @@ -916,7 +916,7 @@ static int vidioc_s_register(struct file *file, void > *priv, > #endif > }; > > -static struct video_device tw68_video_template = { > +static const struct video_device tw68_video_template = { > .name = "tw68_video", > .fops = &video_fops, > .ioctl_ops = &video_ioctl_ops, > -- > 1.9.1 Signed-off-by: Ismael Luceno

Re: [PATCH 3/5] [media] solo6x10: make video_device const

4l2_fops, > .ioctl_ops = &solo_v4l2_ioctl_ops, > -- > 1.9.1 > Signed-off-by: Ismael Luceno

Re: [PATCH 2/2] [media] solo6x10: make snd_kcontrol_new const

e = "Capture Volume", > .info = snd_solo_capture_volume_info, > -- > 1.9.1 > Signed-off-by: Ismael Luceno signature.asc Description: PGP signature

Re: [PATCH] [media] solo6x10: export hardware GPIO pins 8:31 to gpiolib interface

o6x10.h > index 3f8da5e8c430..3a1893ae2dad 100644 > --- a/drivers/media/pci/solo6x10/solo6x10.h > +++ b/drivers/media/pci/solo6x10/solo6x10.h > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -199,6 +200,10 @@ struct solo_dev { > u32 irq_mask; > u32 motion_mask; > struct v4l2_device v4l2_dev; > +#ifdef CONFIG_GPIOLIB > + /* GPIO */ > + struct gpio_chipgpio_dev; > +#endif > > /* tw28xx accounting */ > u8 tw2865, tw2864, tw2815; > -- > 2.13.0 > Signed-off-by: Ismael Luceno

Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static

= { > + static const u8 saa7128_regs_ntsc[] = { > /* :0x26 */ > 0x0d, 0x00, > /* :0x28 */ Signed-off-by: Ismael Luceno

Re: [PATCH] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

On 08/Mar/2017 21:59, Andrey Utkin wrote: > Signed-off-by: Andrey Utkin > Signed-off-by: Andrey Utkin > > Please welcome Anton who is now in charge of solo6x10 and tw5864 support > and development in Bluecherry company, I have sent out to him the > hardware samples I possessed. (We will prepare

Re: [PATCH v2] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

ctive)) { > + struct solo_vb2_buf *buf = list_entry( > + solo_dev->vidq_active.next, > + struct solo_vb2_buf, list); > + > + list_del(&buf->list); > + vb2_buffer_done(&buf->

Re: [PATCH 0505/1285] Replace numeric parameter like 0444 with macro

On 02/Ago/2016 19:18, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using mac

Re: [Intel-gfx] [PATCH] drm/i915: Fix screen flickering on X

On Fri, 8 May 2015 12:10:15 -0300 Ismael Luceno wrote: > On Thu, 07 May 2015 16:41:48 +0300 > Jani Nikula wrote: > > On Thu, 07 May 2015, Matt Roper wrote: > > > On Thu, May 07, 2015 at 12:12:18PM +0300, Jani Nikula wrote: > > >> On Thu, 23 Apr 2015, Chris Wilso

Re: [Intel-gfx] [PATCH] drm/i915: Fix screen flickering on X

On Thu, 07 May 2015 16:41:48 +0300 Jani Nikula wrote: > On Thu, 07 May 2015, Matt Roper wrote: > > On Thu, May 07, 2015 at 12:12:18PM +0300, Jani Nikula wrote: > >> On Thu, 23 Apr 2015, Chris Wilson wrote: > >> > [cc'ing the authors] > >> > >> This has been posted earlier [1] and it has review

Re: [Intel-gfx] [PATCH] drm/i915: Fix screen flickering on X

On Thu, 7 May 2015 15:18:27 +0100 Chris Wilson wrote: > On Thu, May 07, 2015 at 04:41:48PM +0300, Jani Nikula wrote: > > On Thu, 07 May 2015, Matt Roper wrote: > > > On Thu, May 07, 2015 at 12:12:18PM +0300, Jani Nikula wrote: > > >> On Thu, 23 Apr 2015, Chris Wilson > > >> wrote: > > >> > [cc'i

[PATCH] drm/i915: Fix screen flickering on X

should be calculated and programmed when any of the watermark calculation inputs change. This includes planes enabling or disabling, plane source format or size changing, etc." So I'm re-adding the few lines that update the watermarks after a cursor size change. Signed-off-by: Ismael Luc

Re: [PATCH] Update MAINTAINERS for solo6x10

b/MAINTAINERS > @@ -8787,7 +8787,9 @@ S: Maintained > F: drivers/leds/leds-net48xx.c > > SOFTLOGIC 6x10 MPEG CODEC > -M: Ismael Luceno > +M: Bluecherry Maintainers > +M: Andrey Utkin > +M: Andrey Utkin > L: linux-me...@vger.kernel.org > S: Sup

Re: [PATCH] [media] staging/solo6x10: SOLO6X10 should select BITREVERSE

O_DEV && SND && I2C > + select BITREVERSE > select FONT_SUPPORT > select FONT_8x16 > select VIDEOBUF2_DMA_SG Signed-off-by: Ismael Luceno signature.asc Description: PGP signature

Re: [PATCH 5/6] staging/media/solo6x10: use module_pci_driver macro

init solo_module_init(void) > -{ > - return pci_register_driver(&solo_pci_driver); > -} > - > -static void __exit solo_module_exit(void) > -{ > - pci_unregister_driver(&solo_pci_driver); > -} > - > -module_init(solo_module_init); > -module_exit(s