Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Dan Murphy
---
Documentation/devicetree/bindings/leds/leds-lm3692x.txt | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --
new
devm_led_classdev_register_ext() API.
Signed-off-by: Jacek Anaszewski
Cc: Dan Murphy
---
drivers/leds/leds-lm3692x.c | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c
index 4f413a7c5f05..d2b30074d87a 100644
--- a/driv
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Oleh Kravchenko
---
.../devicetree/bindings/leds/leds-cr0014114.txt| 26 --
1 file changed, 19 insertions(+), 7 deletions(
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Daniel Mack
---
Documentation/devicetree/bindings/leds/leds-lt3593.txt | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Simon Shields
---
.../devicetree/bindings/leds/leds-an30259a.txt | 22 +-
1 file changed, 17 insertions(+), 5 deletions(
Switch to using generic LED support for composing LED class
device name.
Signed-off-by: Jacek Anaszewski
Cc: Baolin Wang
---
drivers/leds/leds-sc27xx-bltc.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/drivers/leds/leds-sc27xx-bltc.c b/drivers
he driver internals where hardware interaction was needed
for proper probing.
Thanks,
Jacek Anaszewski
Jacek Anaszewski (25):
leds: class: Improve LED and LED flash class registration API
dt-bindings: leds: Add LED_FUNCTION definitions
dt-bindings: leds: Add LED_COLOR_ID definitions
dt-binding
Switch to using generic LED support for composing LED class
device name.
Signed-off-by: Jacek Anaszewski
---
drivers/leds/leds-aat1290.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c
index
Switch to using generic LED support for composing LED class
device name.
Signed-off-by: Jacek Anaszewski
Cc: Simon Shields
---
drivers/leds/leds-an30259a.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/leds/leds-an30259a.c b/drivers
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Dan Murphy
---
Documentation/devicetree/bindings/leds/leds-lp8860.txt | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --
Switch to using generic LED support for composing LED class
device name.
Signed-off-by: Jacek Anaszewski
Cc: Sakari Ailus
---
drivers/leds/leds-as3645a.c | 69 -
1 file changed, 25 insertions(+), 44 deletions(-)
diff --git a/drivers/leds/leds
act didn't need to pass struct device_node on
registration from the beginning.
Signed-off-by: Jacek Anaszewski
Cc: Baolin Wang
Cc: Pavel Machek
Cc: Dan Murphy
Cc: Daniel Mack
Cc: Linus Walleij
Cc: Oleh Kravchenko
Cc: Sakari Ailus
Cc: Simon Shields
---
drivers/leds/led-class-flash.c | 9 +
Introduce dedicated properties for conveying information about
LED function and color. Mark old "label" property as deprecated.
Additionally led-enumerator property is being provided for the
cases when neither function nor color can be used for LED
differentiation.
Signed-off
Hi Geert,
Thank you for the notification.
On 3/31/19 11:06 AM, Geert Uytterhoeven wrote:
Hi Jacek,
On Sun, Mar 10, 2019 at 9:40 PM Jacek Anaszewski
wrote:
On 3/9/19 7:04 AM, Kangjie Lu wrote:
In case of_match_device cannot find a match, the fixes returns
-EINVAL to avoid NULL pointer
it for -rc4.
Sorry for the confusion.
Best regards,
Jacek Anaszewski
On 3/31/19 11:06 AM, Geert Uytterhoeven wrote:
Hi Jacek,
On Sun, Mar 10, 2019 at 9:40 PM Jacek Anaszewski
wrote:
On 3/9/19 7:04 AM, Kangjie Lu wrote:
In case of_match_device cannot find a match, the fixes returns
-EINVAL to avoid
-leds.git
tags/led-fixes-for-5.1-rc3
for you to fetch changes up to 909346433064b8d840dc82af26161926b8d37558:
leds: trigger: netdev: use memcpy in device_name_store (2019-03-30 19:09:32
+0100)
Thanks,
Jacek Anaszewski
LED fixes
On 3/28/19 1:19 AM, Rob Herring wrote:
On Sun, Mar 10, 2019 at 07:28:11PM +0100, Jacek Anaszewski wrote:
Changes from v1:
- improved led_parse_properties() to parse label property at first
and return immediately after parsing succeeds
- added tool get_led_device_info.sh for retrieving LED
Hi Rob,
Thanks for the review.
On 3/28/19 1:03 AM, Rob Herring wrote:
On Sun, Mar 10, 2019 at 07:28:14PM +0100, Jacek Anaszewski wrote:
Add common LED function definitions for use in Device Tree.
The function names were extracted from existing dts files
after eliminating oddities.
I'd like
On 3/27/19 10:31 PM, Rasmus Villemoes wrote:
On 27/03/2019 22.20, Jacek Anaszewski wrote:
Thanks for the heads-up. I must admit I'm hitting into that for the
first time. After "git am" it was all OK, but it got screwed up after
"git rebase -i". And having "commi
On 3/27/19 4:26 PM, Rasmus Villemoes wrote:
On 26/03/2019 20.53, Jacek Anaszewski wrote:
Hi Rasmus,
Thank you for the patch.
On 3/14/19 3:06 PM, Rasmus Villemoes wrote:
If userspace doesn't end the input with a newline (which can easily
happen if the write happens from a C program that does
trigger_data->device_name[size - 1] = 0;
Added tag:
Fixes: 06f502f57d0d ("leds: trigger: Introduce a NETDEV trigger")
and applied to the fixes-for-5.1-rc3 branch.
--
Best regards,
Jacek Anaszewski
On 3/25/19 8:53 AM, Lee Jones wrote:
On Sat, 23 Mar 2019, Jacek Anaszewski wrote:
Hi Lee,
Can we have your ack for this going via LED tree, please?
Patch looks okay.
You can take it through the LED, but if you do I will need you to send
me a pull-request to a minimised immutable branch
Hi Lee,
Can we have your ack for this going via LED tree, please?
Best regards,
Jacek Anaszewski
On 3/21/19 3:28 PM, Dan Murphy wrote:
Remove the LM3532 backlight driver references from the ti-lmu
code as dedicated driver support is available.
Signed-off-by: Dan Murphy
---
v5 - No changes
.
Signed-off-by: Bartosz Golaszewski
Acked-by: Jacek Anaszewski
Acked-by: Pavel Machek
+ label = of_get_property(child, "label", NULL);
+ if (!label) {
+ led->cdev.name = "max77650::";
+ } else {
+
banks in a group or as individually controlled strings.
I have a v5 series ready for posting and only the DT was reviewed.
Do we have any comments on the code?
I've just added one comment. After it is addressed please submit v5.
--
Best regards,
Jacek Anaszewski
ct i2c_client *client)
+{
+ struct lm3532_data *drvdata = i2c_get_clientdata(client);
mutex_destroy(>lock);
+ if (drvdata->enable_gpio)
+ gpiod_direction_output(drvdata->enable_gpio, 0);
+
+ return 0;
+}
+
+static const struct of_device_id of_lm3532_leds_match[] = {
+ { .compatible = "ti,lm3532", },
+ {},
+};
+MODULE_DEVICE_TABLE(of, of_lm3532_leds_match);
+
+static const struct i2c_device_id lm3532_id[] = {
+ {LM3532_NAME, 0},
+ {}
+};
+MODULE_DEVICE_TABLE(i2c, lm3532_id);
+
+static struct i2c_driver lm3532_i2c_driver = {
+ .probe = lm3532_probe,
+ .remove = lm3532_remove,
+ .id_table = lm3532_id,
+ .driver = {
+ .name = LM3532_NAME,
+ .of_match_table = of_lm3532_leds_match,
+ },
+};
+module_i2c_driver(lm3532_i2c_driver);
+
+MODULE_DESCRIPTION("Back Light driver for LM3532");
+MODULE_LICENSE("GPL v2");
+MODULE_AUTHOR("Dan Murphy ");
--
Best regards,
Jacek Anaszewski
devid = (int)(uintptr_t) of_id->data;
Introduced by commit
6b788fae618c ("leds: fix a potential NULL pointer dereference")
--
Best regards,
Jacek Anaszewski
On 3/14/19 4:05 PM, Rasmus Villemoes wrote:
On 14/03/2019 15.24, Jacek Anaszewski wrote:
Rasmus,
Thank you for the update.
Still, there is one thing to improve.
static int netdev_trig_activate(struct led_classdev *led_cdev)
{
struct led_netdev_data *trigger_data;
@@ -423,6
on
each LED trigger activation for the LED class device, but only on the
first one. That's why the triggers using this flags clean it here:
led_cdev->flags &= ~LED_INIT_DEFAULT_TRIGGER;
led_set_trigger_data(led_cdev, trigger_data);
--
Best regards,
Jacek Anaszewski
On 3/12/19 6:46 PM, Dan Murphy wrote:
On 3/12/19 12:28 PM, Jacek Anaszewski wrote:
Hi Dan,
On 3/12/19 6:15 PM, Dan Murphy wrote:
On 3/10/19 1:28 PM, Jacek Anaszewski wrote:
Add public led_compose_name() API for composing LED class device
name basing on fwnode_handle data. The function
Hi Dan,
On 3/12/19 6:15 PM, Dan Murphy wrote:
On 3/10/19 1:28 PM, Jacek Anaszewski wrote:
Add public led_compose_name() API for composing LED class device
name basing on fwnode_handle data. The function composes device name
according to either a new pattern or the legacy
pattern
Two auto corrections:
On 3/10/19 7:28 PM, Jacek Anaszewski wrote:
Add public led_compose_name() API for composing LED class device
name basing on fwnode_handle data. The function composes device name
according to either a new pattern or the legacy
pattern. The decision on using the
particular
On 3/11/19 6:24 PM, Jacek Anaszewski wrote:
Dan,
On 3/11/19 1:26 PM, Dan Murphy wrote:
On 3/10/19 1:28 PM, Jacek Anaszewski wrote:
Introduce dedicated properties for conveying information about
LED function and color. Mark old "label" property as deprecated.
Signed-off-by: Jacek
Dan,
On 3/11/19 1:26 PM, Dan Murphy wrote:
On 3/10/19 1:28 PM, Jacek Anaszewski wrote:
Introduce dedicated properties for conveying information about
LED function and color. Mark old "label" property as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Baolin Wang
Cc: Daniel Mac
Dan,
On 3/11/19 1:28 PM, Dan Murphy wrote:
On 3/10/19 1:28 PM, Jacek Anaszewski wrote:
Switch to using generic LED support for composing LED class
device name.
While at it, avoid iterating through available child of nodes
in favor of obtaining single expected child node using single
call
Dan,
On 3/11/19 1:38 PM, Dan Murphy wrote:
On 3/10/19 1:28 PM, Jacek Anaszewski wrote:
Switch to using generic LED support for composing LED class
device name.
Since the same device strings would be used in two places,
then add macros LM36922_NAME and LM36922_NAME for use in
lm3692x_probe_dt
2_RAMP_1024us 0x01
+#define LM3532_RAMP_2048us 0x02
+#define LM3532_RAMP_4096us 0x03
+#define LM3532_RAMP_8192us 0x04
+#define LM3532_RAMP_16384us 0x05
+#define LM3532_RAMP_32768us 0x06
+#define LM3532_RAMP_65536us 0x07
+
+#endif /* __DT_BINDINGS_LEDS_LM3532_H */
--
Best regards,
Jacek Anaszewski
Dan,
On 3/11/19 1:23 PM, Dan Murphy wrote:
Jacek
On 3/10/19 1:28 PM, Jacek Anaszewski wrote:
Add common LED color name definitions for use in Device Tree.
Signed-off-by: Jacek Anaszewski
Cc: Baolin Wang
Cc: Daniel Mack
Cc: Dan Murphy
Cc: Linus Walleij
Cc: Oleh Kravchenko
Cc: Sakari
Hi Dan,
Thanks for the review.
On 3/11/19 1:22 PM, Dan Murphy wrote:
Jacek
On 3/10/19 1:28 PM, Jacek Anaszewski wrote:
Add common LED function definitions for use in Device Tree.
The function names were extracted from existing dts files
after eliminating oddities.
Signed-off-by: Jacek
nch of linux-leds.git.
--
Best regards,
Jacek Anaszewski
...
I assumed that would be obvious (my editor explicitly shows tabs) :o
Signed-off-by: Enrico Weigelt, metux IT consult
Acked-by: Pavel Machek
thx.
--mtx
Applied to the for-5.2 branch of linux-leds.git.
--
Best regards,
Jacek Anaszewski
MP_1_37K 0x1b
+#define LM3532_IMP_1_32K 0x1c
+#define LM3532_IMP_1_28K 0x1d
+#define LM3532_IMP_1_23K 0x1e
+#define LM3532_IMP_1_19K 0x1f
+
+/* ALS Averaging Time */
+#define LM3532_ALS_AVRG_TIME_17_92ms 0x00
+#define LM3532_ALS_AVRG_TIME_35_84ms 0x01
+#define LM3532_ALS_AVRG_TIME_71_68ms 0x02
+#define LM3532_ALS_AVRG_TIME_143_36ms 0x03
+#define LM3532_ALS_AVRG_TIME_286_72ms 0x04
+#define LM3532_ALS_AVRG_TIME_573_44ms 0x05
+#define LM3532_ALS_AVRG_TIME_1146_88ms 0x06
+#define LM3532_ALS_AVRG_TIME_2293_76ms 0x07
+
+/* ALS input select */
+#define LM3532_ALS_INPUT_AVRG 0x00 /* ALS1 and ALS2 input average */
+#define LM3532_ALS_INPUT_ALS1 0x01 /* ALS1 Input */
+#define LM3532_ALS_INPUT_ALS2 0x02 /* ALS2 Input */
+#define LM3532_ALS_INPUT_CEIL 0x03 /* Max of ALS1 and ALS2 */
+
+/* Ramp Times */
+#define LM3532_RAMP_8us0x00
+#define LM3532_RAMP_1024us 0x01
+#define LM3532_RAMP_2048us 0x02
+#define LM3532_RAMP_4096us 0x03
+#define LM3532_RAMP_8192us 0x04
+#define LM3532_RAMP_16384us0x05
+#define LM3532_RAMP_32768us0x06
+#define LM3532_RAMP_65536us0x07
+
+#endif /* __DT_BINDINGS_LEDS_LM3532_H */
--
Best regards,
Jacek Anaszewski
act didn't need to pass struct device_node on
registration from the beginning.
Signed-off-by: Jacek Anaszewski
Tested-by: Baolin Wang
Acked-by: Pavel Machek
Acked-by: Dan Murphy
Cc: Daniel Mack
Cc: Linus Walleij
Cc: Oleh Kravchenko
Cc: Sakari Ailus
Cc: Simon Shields
---
drivers/leds/led-class-fl
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Baolin Wang
---
Documentation/devicetree/bindings/leds/leds-sc27xx-bltc.txt | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Daniel Mack
---
Documentation/devicetree/bindings/leds/leds-lt3593.txt | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --
Add common LED color name definitions for use in Device Tree.
Signed-off-by: Jacek Anaszewski
Cc: Baolin Wang
Cc: Daniel Mack
Cc: Dan Murphy
Cc: Linus Walleij
Cc: Oleh Kravchenko
Cc: Sakari Ailus
Cc: Simon Shields
---
include/dt-bindings/leds/common.h | 9 +
1 file changed, 9
formation is already available in sysfs.
Signed-off-by: Jacek Anaszewski
Cc: Baolin Wang
Cc: Daniel Mack
Cc: Dan Murphy
Cc: Linus Walleij
Cc: Oleh Kravchenko
Cc: Sakari Ailus
---
Documentation/leds/leds-class.txt | 20 +-
drivers/leds/led-core.c | 82
Switch to using generic LED support for composing LED class
device name.
Signed-off-by: Jacek Anaszewski
Tested-by: Baolin Wang
Acked-by: Pavel Machek
---
drivers/leds/leds-sc27xx-bltc.c | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/drivers/leds
Add common LED function definitions for use in Device Tree.
The function names were extracted from existing dts files
after eliminating oddities.
Signed-off-by: Jacek Anaszewski
Cc: Baolin Wang
Cc: Daniel Mack
Cc: Dan Murphy
Cc: Linus Walleij
Cc: Oleh Kravchenko
Cc: Sakari Ailus
Cc: Simon
Switch to using generic LED support for composing LED class
device name.
Signed-off-by: Jacek Anaszewski
Acked-by: Daniel Mack
---
drivers/leds/leds-lt3593.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/leds/leds-lt3593.c b/drivers/leds/leds
Switch to using generic LED support for composing LED class
device name.
Signed-off-by: Jacek Anaszewski
Acked-by: Dan Murphy
---
drivers/leds/leds-lm3601x.c | 45 -
1 file changed, 24 insertions(+), 21 deletions(-)
diff --git a/drivers/leds/leds
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
Acked-by: Dan Murphy
---
Documentation/devicetree/bindings/leds/leds-lp8860.txt | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --
Switch to using generic LED support for composing LED class
device name.
While at it, avoid iterating through available child of nodes
in favor of obtaining single expected child node using single
call to of_get_next_available_child().
Signed-off-by: Jacek Anaszewski
Cc: Dan Murphy
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Dan Murphy
---
Documentation/devicetree/bindings/leds/leds-lm3692x.txt | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --
Switch to using generic LED support for composing LED class
device name.
Since the same device strings would be used in two places,
then add macros LM36922_NAME and LM36922_NAME for use in
lm3692x_probe_dt(() and lm3692x_id array.
Signed-off-by: Jacek Anaszewski
Acked-by: Pavel Machek
Cc: Dan
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Dan Murphy
---
Documentation/devicetree/bindings/leds/leds-lm3601x.txt | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Also, fix malformed syntax of address-cells and size-cells
in the example.
Signed-off-by: Jacek Anaszewski
Cc: Sakari Ailus
---
.../devicetree/bindings/leds/ams,as3645a.txt | 22
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Linus Walleij
---
.../devicetree/bindings/leds/leds-gpio.txt | 23 +++---
1 file changed, 16 insertions(+), 7 deletions(
Switch to using generic LED support for composing LED class
device name.
Signed-off-by: Jacek Anaszewski
Cc: Sakari Ailus
---
drivers/leds/leds-as3645a.c | 73 ++---
1 file changed, 29 insertions(+), 44 deletions(-)
diff --git a/drivers/leds/leds
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Simon Shields
---
.../devicetree/bindings/leds/leds-an30259a.txt | 22 +-
1 file changed, 17 insertions(+), 5 deletions(
Switch to using generic LED support for composing LED class
device name.
Signed-off-by: Jacek Anaszewski
Cc: Simon Shields
---
drivers/leds/leds-an30259a.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/drivers/leds/leds-an30259a.c b/drivers
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
---
Documentation/devicetree/bindings/leds/leds-aat1290.txt | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/Documentation
Switch to using generic LED support for composing LED class
device name.
Signed-off-by: Jacek Anaszewski
---
drivers/leds/leds-aat1290.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c
index
Switch to using generic LED support for composing LED class
device name.
Signed-off-by: Jacek Anaszewski
Cc: Linus Walleij
---
drivers/leds/leds-gpio.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds
Switch to using generic LED support for composing LED class
device name.
Signed-off-by: Jacek Anaszewski
Cc: Oleh Kravchenko
---
drivers/leds/leds-cr0014114.c | 29 ++---
1 file changed, 10 insertions(+), 19 deletions(-)
diff --git a/drivers/leds/leds-cr0014114.c b
Refer to new "function" and "color" properties and mark "label"
as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Oleh Kravchenko
---
.../devicetree/bindings/leds/leds-cr0014114.txt| 26 --
1 file changed, 19 insertions(+), 7 deletions(
Introduce dedicated properties for conveying information about
LED function and color. Mark old "label" property as deprecated.
Signed-off-by: Jacek Anaszewski
Cc: Baolin Wang
Cc: Daniel Mack
Cc: Dan Murphy
Cc: Linus Walleij
Cc: Oleh Kravchenko
Cc: Sakari Ailus
Cc: Sim
the first
candidates for optimalization and the first users of the new
led_compose_name() API. The modifications were tested with Qemu,
by stubbing the driver internals where hardware interaction was needed
for proper probing.
Thanks,
Jacek Anaszewski
[0] https://lore.kernel.org/patchwork/patch/858993/
: lp55xx: fix null deref on firmware load failure (2019-02-14 22:03:44
+0100)
Thanks,
Jacek Anaszewski
LED updates for 5.1-rc1
Krzysztof Kozlowski (5):
dt-bindings
compatible = "x-powers,axp803";
+
+ ...
+
+ led@0 {
+ compatible = "x-powers,axp20x-led";
+ status = "okay";
+
+ label = "axp20x:yellow:chgled";
+ x-powers,charger-mode = <1>;
+ };
+ };
--
2.17.1
--
Best regards,
Jacek Anaszewski
e, which we need to do anyways for the hw_pattern file?
In Documentation/ABI/testing/sysfs-class-led-cht-wc we should
have a description of hw_pattern semantics for Whiskey Cove PMIC LED,
with regard to how hw_control state impacts the mode of trigger
(manual/triggered when charging).
--
Best regards,
Jacek Anaszewski
Hi,
On 2/16/19 11:03 PM, Hans de Goede wrote:
Hi,
On 2/16/19 10:54 PM, Jacek Anaszewski wrote:
On 2/16/19 8:37 PM, Pavel Machek wrote:
Hi!
I think that should work fine, which means that we can use the
timer and
pattern trigger support for the blinking and breathing modes.
That still
oduce new mechanisms when
existing ones fit. It will still describe a pattern but activated
on some condition.
--
Best regards,
Jacek Anaszewski
Hi Hans,
On 2/16/19 12:14 AM, Hans de Goede wrote:
Hi,
On 2/15/19 11:31 PM, Jacek Anaszewski wrote:
On 2/15/19 11:26 PM, Hans de Goede wrote:
I think that should work fine, which means that we can use the timer and
pattern trigger support for the blinking and breathing modes.
That still
On 2/15/19 11:26 PM, Hans de Goede wrote:
Hi,
On 2/15/19 10:42 PM, Jacek Anaszewski wrote:
Hi all,
On 2/15/19 12:27 PM, Hans de Goede wrote:
Hi,
On 15-02-19 00:03, Pavel Machek wrote:
Hi!
I suggest that we deal with this special case by adding 3 custom
sysfs attributes:
1) "mode&q
or this device, similarly like in:
Documentation/ABI/testing/sysfs-class-led-driver-sc27xx
--
Best regards,
Jacek Anaszewski
interactions with the standard API I suggest we reset pattern
to "on" when brightness gets set to 0, similar to how we stop the timer
trigger then, etc.
Regards,
Hans
--
Best regards,
Jacek Anaszewski
eve the freq. attribute should
be called pattern_freq to make clear it applies to blinking / breathing
set through the pattern attribute.
Take a look at blinking trigger. It can already do hardware
acceleration, but uses different format than what you proposed.
Best regards,
Pavel
--
Best regards,
Jacek Anaszewski
called pattern_freq to make clear it applies to blinking / breathing
set through the pattern attribute.
Regards,
Hans
--
Best regards,
Jacek Anaszewski
: warning: label 'out' defined but not
used [-Wunused-label]
out:
^~~
Thank you for the heads-up. It's my bad - I didn't use sparse on it.
Fixed up the original patch.
Introduced by commit
905c2157dd19 ("leds: lp55xx: fix null deref on firmware load failure")
--
Best rega
,
},
{ .name = "cht_wcove_region", },
+ { .name = "cht_wcove_leds", },
};
/*
--
Best regards,
Jacek Anaszewski
ODULE_DEVICE_TABLE(platform, cht_wc_leds_table);
+
+static struct platform_driver cht_wc_leds_driver = {
+ .probe = cht_wc_leds_probe,
+ .id_table = cht_wc_leds_table,
+ .driver = {
+ .name = "cht_wcove_leds",
+ },
+};
+module_platform_driver(cht_wc_leds_driver);
+
+MODULE_DESCRIPTION("Intel Cherrytrail Whiskey Cove PMIC LEDs driver");
+MODULE_AUTHOR("Yauhen Kharuzhy ");
+MODULE_LICENSE("GPL");
s/GPL/GPL v2/
+
--
Best regards,
Jacek Anaszewski
maintainers are
M: Jacek Anaszewski
M: Pavel Machek
Also would be nice to cc to Hans de Goede.
I follow the list. I beileve Jacek does, too.
Right, there is no issue with that.
--
Best regards,
Jacek Anaszewski
- INIT_WORK(>work, cap11xx_led_work);
-
error = devm_led_classdev_register(dev, >cdev);
if (error) {
of_node_put(child);
Acked-by: Jacek Anaszewski
--
Best regards,
Jacek Anaszewski
error = devm_led_classdev_register(dev, >cdev);
if (error) {
of_node_put(child);
--
Best regards,
Jacek Anaszewski
ter().
--
Best regards,
Jacek Anaszewski
iver max77650_led_driver = {
+ .driver = {
+ .name = "max77650-led",
+ },
+ .probe = max77650_led_probe,
+};
+module_platform_driver(max77650_led_driver);
+
+MODULE_DESCRIPTION("MAXIM 77650/77651 LED driver");
+MODULE_AUTHOR("Bartosz Golaszewski ");
+MODULE_LICENSE("GPL v2");
Acked-by: Jacek Anaszewski
--
Best regards,
Jacek Anaszewski
if (ret < 0) {
+ dev_err(>dev, "Failed to configure led");
+ return ret;
+ }
+
+ return devm_led_classdev_register(>dev, >cdev);
+}
+
+static struct platform_driver axp20x_led_driver = {
+ .driver = {
+ .name = "axp20x-led",
+ .of_match_table = of_match_ptr(axp20x_led_of_match),
+ },
+ .probe = axp20x_led_probe,
+};
+
+module_platform_driver(axp20x_led_driver);
+
+MODULE_AUTHOR("Stefan Mavrodiev
--
Best regards,
Jacek Anaszewski
quot;;
+
+ label = "axp20x:yellow:chgled";
+ x-powers,charger-mode = "mode-b";
+ };
+ };
--
Best regards,
Jacek Anaszewski
Hi Dan,
On 1/31/19 2:48 PM, Dan Murphy wrote:
Jacek
On 1/30/19 4:14 PM, Jacek Anaszewski wrote:
Dan,
On 1/30/19 10:07 PM, Dan Murphy wrote:
Jacek
On 1/30/19 2:20 PM, Jacek Anaszewski wrote:
Dan,
On 1/30/19 8:59 PM, Dan Murphy wrote:
Jacek
On 1/30/19 1:37 PM, Jacek Anaszewski wrote:
Hi
Dan,
On 1/30/19 10:07 PM, Dan Murphy wrote:
Jacek
On 1/30/19 2:20 PM, Jacek Anaszewski wrote:
Dan,
On 1/30/19 8:59 PM, Dan Murphy wrote:
Jacek
On 1/30/19 1:37 PM, Jacek Anaszewski wrote:
Hi Dan,
Thank you for the RFC.
One vital thing is missing - documentation of brightness file must
Dan,
On 1/30/19 8:59 PM, Dan Murphy wrote:
Jacek
On 1/30/19 1:37 PM, Jacek Anaszewski wrote:
Hi Dan,
Thank you for the RFC.
One vital thing is missing - documentation of brightness file must
be updated to define its semantics for LED multi color class.
Either we need brightness-model file
iver(max77650_led_driver);
+
+MODULE_DESCRIPTION("MAXIM 77650/77651 LED driver");
+MODULE_AUTHOR("Bartosz Golaszewski ");
+MODULE_LICENSE("GPL v2");
--
Best regards,
Jacek Anaszewski
leds {
+ compatible = "maxim,max77650-leds";
s/leds/led/
With that:
Acked-by: Jacek Anaszewski
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@0 {
+ reg = <0>;
+
LED multi
color class to 1 (which will map to max intensity level for each color).
Best regards,
Jacek Anaszewski
On 1/30/19 7:30 PM, Dan Murphy wrote:
Add a documentation of LED Multicolor LED class specific
sysfs attributes.
Signed-off-by: Dan Murphy
---
.../ABI/testing/sysfs-class-led-
Dan,
On 1/29/19 9:26 PM, Dan Murphy wrote:
Jacek
On 1/29/19 2:19 PM, Jacek Anaszewski wrote:
Hi Dan,
On 1/29/19 2:56 PM, Dan Murphy wrote:
Jacek
On 1/24/19 3:55 PM, Jacek Anaszewski wrote:
Dan
On 1/24/19 10:00 PM, Dan Murphy wrote:
Jacek
On 1/23/19 3:52 PM, Jacek Anaszewski wrote:
Dan
Hi Dan,
On 1/29/19 2:56 PM, Dan Murphy wrote:
Jacek
On 1/24/19 3:55 PM, Jacek Anaszewski wrote:
Dan
On 1/24/19 10:00 PM, Dan Murphy wrote:
Jacek
On 1/23/19 3:52 PM, Jacek Anaszewski wrote:
Dan,
On 1/22/19 11:44 PM, Dan Murphy wrote:
Jacek
On 1/22/19 3:39 PM, Jacek Anaszewski wrote:
Hi
Dan
On 1/24/19 10:00 PM, Dan Murphy wrote:
Jacek
On 1/23/19 3:52 PM, Jacek Anaszewski wrote:
Dan,
On 1/22/19 11:44 PM, Dan Murphy wrote:
Jacek
On 1/22/19 3:39 PM, Jacek Anaszewski wrote:
Hi all,
On 1/20/19 7:42 AM, Vesa Jääskeläinen wrote:
Hi Dan,
On 18/01/2019 15.58, Dan Murphy wrote
Dan,
On 1/24/19 9:32 PM, Dan Murphy wrote:
Jacek
Replying to code comments.
On 1/15/19 3:47 PM, Jacek Anaszewski wrote:
Hi Da,
Thank you for the v2.
I will probably submit v3 outside the realm of the multi color framework.
We can always convert as Pavel pointed out.
I have some remarks
Dan,
On 1/22/19 11:44 PM, Dan Murphy wrote:
Jacek
On 1/22/19 3:39 PM, Jacek Anaszewski wrote:
Hi all,
On 1/20/19 7:42 AM, Vesa Jääskeläinen wrote:
Hi Dan,
On 18/01/2019 15.58, Dan Murphy wrote:
Jacek
On 1/18/19 7:45 AM, Dan Murphy wrote:
Jacek
On 1/17/19 3:10 PM, Jacek Anaszewski wrote
401 - 500 of 3275 matches
Mail list logo
