The following commit has been merged into the core/rcu branch of tip:
Commit-ID: 7c47ee5aa00817d8b10f415b4a92d5fb3ac35273
Gitweb:
https://git.kernel.org/tip/7c47ee5aa00817d8b10f415b4a92d5fb3ac35273
Author:Joe Perches
AuthorDate:Sat, 03 Oct 2020 17:18:08 -07:00
Committer
On Sun, 2020-12-13 at 13:48 +0530, Dwaipayan Ray wrote:
> On Sun, Dec 13, 2020 at 1:31 PM Lukas Bulwahn wrote:
[]
> > Will you also add a checkpatch rule to identify other DEVICE_ATTR(...)
> > that can be adjusted to the refined macros, so that checkpatch informs
> > other submitters as well?
> >
On Sat, 2020-12-12 at 14:17 +0100, Alexandre Belloni wrote:
> On 12/12/2020 01:16:39-0800, Joe Perches wrote:
> > In this case Alexandre it seems true, but in the generic case
> > it may be false. It may depend on stack size and location.
> >
> > For instance, with la
On Fri, 2020-12-11 at 09:03 +0100, Alexandre Belloni wrote:
> On 11/12/2020 07:34:41+0100, Markus Elfring wrote:
> > > > How do you think about a patch like “staging: speakup: remove redundant
> > > > initialization
> > > > of pointer p_key” for comparison?
> > > >
On Fri, 2020-12-11 at 11:05 +0100, Vasyl Gomonovych wrote:
> Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable
> Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable
[]
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c
>
On Fri, 2020-12-11 at 19:40 +0100, Lukas Bulwahn wrote:
> On Fri, Dec 11, 2020 at 7:23 PM Julia Lawall wrote:
> > On Fri, 11 Dec 2020, Lukas Bulwahn wrote:
> > > Commit 8410d38c2552 ("loop: use __register_blkdev to allocate devices on
> > > demand") simplified loop_init(); so computing the range
On Fri, 2020-12-11 at 16:17 +, David Laight wrote:
> From: Eric Sandeen
> > Sent: 11 December 2020 15:51
> >
> > On 12/11/20 2:41 AM, Zheng Yongjun wrote:
> > > Replace a comma between expression statements by a semicolon.
> > >
> > > Signed-off-by: Zheng Yongjun
> >
> > hah, that's an old
On Fri, 2020-12-11 at 16:38 +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
If you are using a tool to find and fix these, you should mention the tool.
btw: using Julia Lawall's cocci script to update these is probably best.
On Wed, 2020-12-09 at 15:24 +0100, Nicolai Fischer wrote:
> We understand that checkpatch may not be the ideal place for all of these
> checks.
So please work on an ideal thing.
> However the current implementation has some problems we would like to fix.
> Would you be interested in a patch
On Thu, 2020-12-10 at 18:50 +, Kalle Valo wrote:
> Zheng Yongjun wrote:
>
> > Replace a comma between expression statements by a semicolon.
> >
> > Signed-off-by: Zheng Yongjun
>
> Patch applied to wireless-drivers-next.git, thanks.
>
> c42d492c672a cw1200: txrx: convert comma to
On Thu, 2020-12-10 at 20:09 +, Matthew Wilcox wrote:
> On Thu, Dec 10, 2020 at 12:05:04PM -0800, Joe Perches wrote:
> > Also, given the ever increasing average identifier length, strict
> > adherence to 80 columns is sometimes just not possible without silly
> > visual gy
On Thu, 2020-12-10 at 09:22 +0100, Christoph Hellwig wrote:
> Add a new informational message that lines <= 80 chars are still
> preffered. Without this people unfortunately auto format code way over
> 80 lines without the required benefit for readability.
In general, I agree with some of the
On Thu, 2020-12-10 at 18:52 +0100, Christophe JAILLET wrote:
> "Missing a blank line after declarations" is not triggered on patches.
That's not true.
It does work on any patch that does a new function addition.
There are some patch context complications here when lines are
added and removed such
On Thu, 2020-12-10 at 19:49 +0530, Dwaipayan Ray wrote:
> Documentation/process/coding-style.rst specifies the use of
> IS_ENABLED macro:
>
> Within code, where possible, use the IS_ENABLED macro to convert a Kconfig
> symbol into a C boolean expression, and use it in a normal C conditional:
>
>
On Thu, 2020-12-10 at 09:34 +, David Laight wrote:
> From: Joe Perches
> > Sent: 10 December 2020 05:26
> >
> > On Wed, 2020-12-09 at 19:13 +0100, Thomas Gleixner wrote:
> > > Joe,
> >
> > Hi Thomas.
> >
> > > the below made it thro
On Wed, 2020-12-09 at 19:13 +0100, Thomas Gleixner wrote:
> Joe,
Hi Thomas.
> the below made it through my filters for some reason so I actually
> looked and immediately wondered why checkpatch.pl did not identify this
> as pure garbage.
>
> Original mail is here:
>
On Wed, 2020-12-09 at 10:58 +0300, Dan Carpenter wrote:
> On Tue, Dec 08, 2020 at 09:01:49PM -0800, Joe Perches wrote:
> > On Tue, 2020-12-08 at 16:34 -0800, Kees Cook wrote:
> >
> > > If not "Adjusted-by", what about "Tweaked-by", "He
On Tue, 2020-12-01 at 14:35 -0800, mgr...@linux.intel.com wrote:
> Refactor the too large IOCTL function to call helper functions.
[]
> diff --git a/drivers/misc/xlink-core/xlink-ioctl.c
> b/drivers/misc/xlink-core/xlink-ioctl.c
[]
> +int ioctl_write_data(unsigned long arg)
> +{
> + struct
Add the _once and _ratelimited variants to the test for
printk(KERN_ that should prefer pr_.
Miscellanea:
o Add comment description for the conversions
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/scripts
On Tue, 2020-12-08 at 16:34 -0800, Kees Cook wrote:
> If not "Adjusted-by", what about "Tweaked-by", "Helped-by",
> "Corrected-by"?
Improved-by: / Enhanced-by: / Revisions-by:
Or simply don't use anything but a link to the conversion thread
like Konstantin suggested.
I still want to know what
On Tue, 2020-12-08 at 18:18 +0100, Nicolai Fischer wrote:
> Checkpatch currently only warns if the help text is too short.
> To determine this the diff gets parsed for keywords starting
> a new entry, but several kinds of false positives can occur with
> the current implementation, especially when
On Tue, 2020-12-08 at 00:42 +0100, Philipp Bruegmann wrote:
> Print a check if the last Signed-off-by is by the From: author.
>
> submitting-patches.rst states 'the last Signed-off-by: must always be
> that of the developer submitting the patch.'.
> This patch tries to enforce this, under the
On Mon, 2020-12-07 at 23:26 +0106, John Ogness wrote:
> In preparation for removing logbuf_lock, inline log_output()
> and log_store() into vprintk_store(). This will simplify dealing
> with the various code branches and fallbacks that are possible.
One nicety would be to add various pr_
On Mon, 2020-12-07 at 12:37 -0800, Eric Biggers wrote:
> On Thu, Nov 26, 2020 at 06:32:09PM +0800, Chao Yu wrote:
> > + if (!ret && fi->i_compress_flag & 1 << COMPRESS_CHKSUM) {
>
> This really could use some parentheses. People shouldn't have to look up a
> C operator precedence table to
On Tue, 2020-12-01 at 14:35 -0800, mgr...@linux.intel.com wrote:
> From: Seamus Kelly
>
> Refactor the too large IOCTL function to call helper functions.
This should not be sent as a known poor patch as patch 21 of 22
and then updated in patch 22 of 22 with a better style.
This should be sent
On Tue, 2020-12-01 at 14:35 -0800, mgr...@linux.intel.com wrote:
> Enable asynchronous channel and event communication.
[]
> diff --git a/drivers/misc/xlink-core/xlink-core.c
> b/drivers/misc/xlink-core/xlink-core.c
[]
> +
> +// sysfs attribute functions
> +
> +static ssize_t event0_show(struct
On Tue, 2020-12-01 at 14:35 -0800, mgr...@linux.intel.com wrote:
> From: Seamus Kelly
>
> Add xLink driver, which interfaces the xLink Core driver with the Keem
> Bay VPU IPC driver, thus enabling xLink to control and communicate with
> the VPU IP present on the Intel Keem Bay SoC.
Trivial
On Sun, 2020-12-06 at 13:09 +0530, Clement Smith wrote:
> Fixed a coding style issue
Don't send 8 identically titled patches that each change a single line.
Send one patch, with an updated title like:
Subject: [PATCH] jsm_tty: Whitespace neatening
that changes _all_ the whitespace that
On Sat, 2020-12-05 at 15:52 +0530, Aditya wrote:
> On 4/12/20 8:10 pm, Aditya Srivastava wrote:
> > Currently, checkpatch.pl warns us for BAD_SIGN_OFF on the usage of
> > non-standard signatures.
[]
> > The standard signature equivalent for 'Co-authored-by' is
> > 'Co-developed-by'.
> >
> >
On Fri, 2020-12-04 at 16:09 -0800, Jakub Kicinski wrote:
> On Wed, 2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult
> wrote:
> > Remove MODULE_VERSION(), as it isn't needed at all: the only version
> > making sense is the kernel version.
> >
> > Signed-off-by: Enrico Weigelt, metux IT
On Fri, 2020-12-04 at 17:37 -0600, Travis Carter wrote:
> drivers/staging/media/rkvdec/rkvdec.c
You might consider using Julia Lawall's cocci script for all of
drivers/staging or subsets of staging like drivers/staging/media/
On Fri, 2020-12-04 at 10:49 -0500, Sasha Levin wrote:
> On Fri, Dec 04, 2020 at 09:27:28AM +0100, Paolo Bonzini wrote:
> > On 01/12/20 00:59, Sasha Levin wrote:
> > >
> > > It's quite easy to NAK a patch too, just reply saying "no" and it'll be
> > > dropped (just like this patch was dropped
On Fri, 2020-12-04 at 20:10 +0530, Aditya Srivastava wrote:
> Currently, checkpatch.pl warns us for BAD_SIGN_OFF on the usage of
> non-standard signatures.
>
> An evaluation on v4.13..v5.8 showed that out of 539 warnings due to
> non-standard signatures, 43 are due to the use of 'Co-authored-by'
On Fri, 2020-12-04 at 21:56 +1100, Michael Ellerman wrote:
> Christophe Leroy writes:
> > Since some time now, printk() adds carriage return, leading to
> > unusable xmon output:
> >
> > [ 54.288722] sysrq: Entering xmon
> > [ 54.292209] Vector: 0 at [cace3d2c]
> > [ 54.292274] pc:
>
, Dec 3, 2020 at 10:59 AM Aditya wrote:
> > > > >
> > > > > On 3/12/20 12:26 am, Joe Perches wrote:
> > > > > > On Thu, 2020-12-03 at 00:00 +0530, Aditya Srivastava wrote:
> > > > > > > Currently, checkpatch.pl warns us for BAD
On Thu, 2020-12-03 at 14:17 -0500, Konstantin Ryabitsev wrote:
> On Thu, Dec 03, 2020 at 08:55:54AM -0800, Joe Perches wrote:
> > Perhaps automate a mechanism to capture that information as
> > git notes for the patches when applied.
>
> Git notes have
On Thu, 2020-12-03 at 10:31 -0800, Randy Dunlap wrote:
> On 12/3/20 9:58 AM, Joe Perches wrote:
> > On Wed, 2020-12-02 at 10:59 -0800, Randy Dunlap wrote:
> >
> > > There are also large hunks of block/Kconfig and drivers/hid/Kconfig
> > > that don't
On Wed, 2020-12-02 at 10:59 -0800, Randy Dunlap wrote:
> There are also large hunks of block/Kconfig and drivers/hid/Kconfig
> that don't use any indentation for help text...
> in case that matters here.
Maybe something like this could help.
Indent the unindented help blocks by 2 spaces and
On Thu, 2020-12-03 at 15:11 +0100, Enrico Weigelt, metux IT consult
wrote:
> pr_*() printing helpers are preferred over using bare printk().
Please run your proposed patches through checkpatch --strict
and see if any of its bleats are things that should be fixed
at the same time. For this patch:
On Thu, 2020-12-03 at 05:58 -0800, James Bottomley wrote:
> So there are two embedded questions here: firstly, should we be as
> wedded to clean history as we are, because showing the evolution would
> simply solve this? Secondly, if we are agreed on clean history, how
> can we make engagement
On Thu, 2020-12-03 at 06:39 -0800, Tom Rix wrote:
> I agree if it can be done in checkpatch it should.
> It is good to have multiple passes on cleaning.
true
> checkpatch is best at fixing new problems,
> clang-tidy-fix is best at fixing old problems.
checkpatch is a set of brainless regexes
On Thu, 2020-12-03 at 10:39 +0530, Srinivasan Raju wrote:
> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
> and LiFi-XL USB devices.
The below is a trivial readability possible enhancement and should not
hinder this patch being applied.
> diff --git
On Thu, 2020-12-03 at 02:27 +0530, Dwaipayan Ray wrote:
> Commit log lines starting with '#' are dropped by git as comments.
> Add a check to emit a warning for these lines.
>
> Also add a --fix option to insert a space before the leading '#' in
> such lines.
>
> Sugg
On Thu, 2020-12-03 at 01:52 +0530, Dwaipayan Ray wrote:
> Commit log lines starting with a '#' can be dropped by git if
> the corresponding commit message is reworded by a maintainer.
> This minor error can be easily avoided if checkpatch warns
> for the same.
This makes no sense to me.
How
On Thu, 2020-12-03 at 01:30 +0530, Dwaipayan Ray wrote:
> On Wed, Dec 2, 2020 at 3:45 PM Dwaipayan Ray wrote:
> >
> > Commit log lines starting with a '#' can be dropped by git if
> > the corresponding commit message is reworded by a maintainer.
> > This minor error can be easily avoided if
On Wed, 2020-12-02 at 10:59 -0800, Randy Dunlap wrote:
> On 12/2/20 10:54 AM, Joe Perches wrote:
[]
> > Indentation can vary in the help blocks. For instance:
> >
> > arch/Kconfig: help
> > arch/Kconfig- Functions will have the stack-protector canary logic
>
On Thu, 2020-12-03 at 00:00 +0530, Aditya Srivastava wrote:
> Currently, checkpatch.pl warns us for BAD_SIGN_OFF on the usage of
> non-standard signatures.
>
> An evaluation on v4.13..v5.8 showed that out of 539 warnings due to
> non-standard signatures, 43 are due to the use of 'Co-authored-by'
>
On Wed, 2020-12-02 at 19:27 +0100, Nicolai Fischer wrote:
> Currently, checkpatch uses keywords to determine the end
> of a Kconfig help message which leads to false positives:
>
> 1) if a line of the help text starts with any of the keywords, e.g. if:
>
> +config FOO
> + help
> + help
On Wed, 2020-12-02 at 14:38 +0530, Aditya Srivastava wrote:
> Currently, checkpatch.pl warns for BAD_SIGN_OFF on the usage of
> non-standard signatures.
>
> An evaluation on v4.13..v5.8 showed that out of 539 warnings due to
> non-standard signatures, 43 are due to the use of 'Co-authored-by'
>
On Tue, 2020-12-01 at 11:32 -0800, Joe Perches wrote:
> On Wed, 2020-12-02 at 00:37 +0530, Dwaipayan Ray wrote:
> > checkpatch reports a false TYPO_SPELLING warning for some words
> > containing an apostrophe when run with --codespell option.
Hey Andrew. If Dwaipayan doesn't mind,
On Tue, 2020-12-01 at 16:50 +0100, Michal Simek wrote:
> Fix parameters alignment reported by checkpatch --strict.
Please use a newer checkpatch as the 80 column warning
isn't enforced quite the same way.
> diff --git a/include/linux/firmware/xlnx-zynqmp.h
>
On Wed, 2020-12-02 at 00:37 +0530, Dwaipayan Ray wrote:
> checkpatch reports a false TYPO_SPELLING warning for some words
> containing an apostrophe when run with --codespell option.
Thanks.
Acked-by: Joe Perches
>
> A false positive is "doesn't". Occurrence of the wo
On Tue, 2020-12-01 at 19:21 +0100, Lukas Bulwahn wrote:
> On Tue, Dec 1, 2020 at 6:24 PM Joe Perches wrote:
> >
> > On Tue, 2020-12-01 at 16:59 +0530, Aditya Srivastava wrote:
> > > Currently, checkpatch.pl warns for BAD_SIGN_OFF on non-standard signature
> > >
On Tue, 2020-12-01 at 23:39 +0530, Dwaipayan Ray wrote:
> On Tue, Dec 1, 2020 at 11:32 PM Joe Perches wrote:
> > On Tue, 2020-12-01 at 12:53 +0530, Dwaipayan Ray wrote:
> > > checkpatch reports a false TYPO_SPELLING warning for some words
> > > containing an apostroph
mit the following warning:
>
> "WARNING: 'doesn'' may be misspelled - perhaps 'doesn't'?"
>
> Modify the regex pattern to be more in line with the codespell
> default word matching regex. This fixes the word capture and
> avoids the false warning.
>
> Sugges
On Tue, 2020-12-01 at 16:59 +0530, Aditya Srivastava wrote:
> Currently, checkpatch.pl warns for BAD_SIGN_OFF on non-standard signature
> styles.
>
> This warning occurs because of incorrect use of signature tags,
> e.g. an evaluation on v4.13..v5.8 showed the use of following incorrect
>
On Mon, 2020-11-30 at 23:56 +0530, Dwaipayan Ray wrote:
> Thanks, this does resolve the original problem, but again the following
> line throws 0 warnings:
>
> "zeebra" ther, yourr.
>
> Any punctuation separators are ignored :(
>
> (?:^|\s)($misspellings)(?=[\s\.\,\:\;\"\?\!]|$)
>
> Would
On Mon, 2020-11-30 at 23:02 +0530, Dwaipayan Ray wrote:
> Sorry I think i explained wrong. For words like "doesn't", it still
> has the same problem.
I think you explained it wrong when you didn't mention this is
_only_ a problem when using --codespell.
Likely it'd be better to use
On Mon, 2020-11-30 at 22:33 +0530, Dwaipayan Ray wrote:
> On Mon, Nov 30, 2020 at 10:13 PM Joe Perches wrote:
> >
> > On Mon, 2020-11-30 at 20:15 +0530, Dwaipayan Ray wrote:
> > > checkpatch reports a false TYPO_SPELLING warning for some words
> > > containing an
On Mon, 2020-11-30 at 20:15 +0530, Dwaipayan Ray wrote:
> checkpatch reports a false TYPO_SPELLING warning for some words
> containing an apostrophe.
>
> A false positive is "doesn't". Occurrence of the word causes
> checkpatch to emit the following warning:
>
> "WARNING: 'doesn'' may be
$ size drivers/scsi/built-in.a (allyesconfig x86-64)
text data bss dec
new: 14968308 2718234 165792 17852334
old: 14976884 2723130 165792 17865806
Signed-off-by: Joe Perches
---
drivers/scsi/scsi_logging.c | 30 ++
include/scsi/scsi_device.h
On Fri, 2020-03-06 at 16:07 -0800, Joe Perches wrote:
> On Fri, 2020-03-06 at 11:02 -0800, Nick Desaulniers wrote:
> > Turns out there are hundreds of unused static inline
> > > functions in kernel .h files.
> > >
> > > A trivial script to find some of the
On Sun, 2020-11-29 at 10:15 -0800, James Bottomley wrote:
> I think nowadays we should always use static inlines for argument
> checking unless we're capturing debug information like __FILE__ or
> __LINE__ or something that a static inline can't.
IMO: __LINE__ should never be used.
__func__ is
On Sun, 2020-11-29 at 14:25 +0530, Aditya wrote:
> On 23/11/20 3:58 pm, Aditya Srivastava wrote:
> > Currently, checkpatch warns if logical continuations are placed at the
> > start of a line and not at the end of previous line.
Acked-by: Joe Perches
> >
> > E.g., r
On Sun, 2020-11-29 at 06:45 +0200, Jarkko Sakkinen wrote:
> On Fri, Nov 27, 2020 at 11:15:43AM -0800, t...@redhat.com wrote:
> > From: Tom Rix
> >
> > The macro use will already have a semicolon.
> >
> > Signed-off-by: Tom Rix
>
> I'm in-between whether this is worth of merging. The commit
On Sat, 2020-11-28 at 08:30 -0800, Tom Rix wrote:
> On 11/28/20 8:00 AM, Joe Perches wrote:
> > On Sat, 2020-11-28 at 07:36 -0800, Tom Rix wrote:
> > > On 11/27/20 2:10 PM, Joe Perches wrote:
> > []
> > > > I think an exception mechanism would be better tha
On Sat, 2020-11-28 at 18:35 +0530, Aditya Srivastava wrote:
> Currently checkpatch warns for BAD_SIGN_OFF on non-standard signature
> styles.
>
> A large number of these warnings occur because of typo mistakes in
> signature tags. An evaluation over v4.13..v5.8 showed that out of 539
> warnings
On Sat, 2020-11-28 at 07:36 -0800, Tom Rix wrote:
> On 11/27/20 2:10 PM, Joe Perches wrote:
[]
> > I think an exception mechanism would be better than a specific
> > mechanism added to various entries.
> Can you give an example of what you mean ?
Inherit the parent prefix the
ck.
>
> Link:
> https://lore.kernel.org/lkml/4910042649a4f3ab22fac93191b8c1fa0a2e17c3.ca...@perches.com/
>
> Suggested-by: Joe Perches
> Suggested-by: Lukas Bulwahn
> Signed-off-by: Dwaipayan Ray
> ---
> Changes in v3:
> - Change warning message
> - Fix regex match
On Sun, 2020-11-29 at 02:13 +0530, Aditya Srivastava wrote:
> Currently checkpatch warns for BAD_SIGN_OFF on non-standard signature
> styles.
Thanks.
Acked-by: Joe Perches
> A large number of these warnings occur because of typo mistakes in
> signature tags. An evaluation over
On Sun, 2020-11-29 at 01:30 +0530, Dwaipayan Ray wrote:
> Modifiers %h and %hh should never be used.
Seems OK, thanks.
Acked-by: Joe Perches
> Commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use
> of unnecessary %h[xudi] and %hh[xudi]") specifies that:
>
On Sun, 2020-11-29 at 00:05 +0530, Aditya Srivastava wrote:
> Currently checkpatch warns for BAD_SIGN_OFF on non-standard signature
> styles.
Seems OK, but here are some last trivial notes:
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> +sub find_standard_signature {
> +
On Fri, 2020-11-27 at 13:43 -0800, t...@redhat.com wrote:
> From: Tom Rix
>
> From
> RFC MAINTAINERS tag for cleanup robot
> https://lkml.org/lkml/2020/11/21/190
I think this should be RFC.
It looks as as if it's only for subsystems through A
> The prefix used by subsystems in their commit log
On Fri, 2020-11-27 at 08:05 -0800, t...@redhat.com wrote:
> Function like macros should have a semicolon.
[]
> diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
[]
> @@ -1172,7 +1172,7 @@ decrypt_pki_encrypted_session_key(struct
> ecryptfs_auth_tok *auth_tok,
> rc =
On Thu, 2020-11-26 at 14:16 +0530, Dwaipayan Ray wrote:
> Modifiers %h and %hh should never be used.
>
> Commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use
> of unnecessary %h[xudi] and %hh[xudi]") specifies that:
>
> "Standard integer promotion is already done and %hx and %hhx is
On Thu, 2020-11-26 at 12:58 +0530, Dwaipayan Ray wrote:
> Modifiers %h and %hh should never be used.
>
> Commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use
> of unnecessary %h[xudi] and %hh[xudi]") specifies that:
>
> "Standard integer promotion is already done and %hx and %hhx is
On Wed, 2020-11-25 at 12:08 +0800, Tiezhu Yang wrote:
> On 11/25/2020 11:51 AM, Joe Perches wrote:
> > On Wed, 2020-11-25 at 11:35 +0800, Tiezhu Yang wrote:
> > > When backport the upstream commit to the internal LTS kernel version,
> > > we usually use the f
On Wed, 2020-11-25 at 12:08 +0800, Tiezhu Yang wrote:
> On 11/25/2020 11:51 AM, Joe Perches wrote:
> > On Wed, 2020-11-25 at 11:35 +0800, Tiezhu Yang wrote:
> > > When backport the upstream commit to the internal LTS kernel version,
> > > we usually use the f
On Wed, 2020-11-25 at 11:35 +0800, Tiezhu Yang wrote:
> When backport the upstream commit to the internal LTS kernel version,
> we usually use the following description [1] [2]:
>
> [ Upstream commit cc6528bc9a0c901c83b8220a2e2617f3354d6dd9 ]
> or
> commit c51f8f88d705e06bd696d7510aff22b33eb8e638
On Tue, 2020-11-24 at 21:54 -0300, Matheus Castello wrote:
> > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
[]
> > The above would be marginally better if organized as follows so that the
> > main execution path isn't in an "if" clause. Also reduces indentation.
> >
> >
On Tue, 2020-11-24 at 07:54 +0100, Lukas Bulwahn wrote:
> On Mon, Nov 23, 2020 at 6:33 PM Joe Perches wrote:
[]
> Maybe a patch reduced to the very obvious synonyms helps newcomers or
> people with lousy memory to be reminded that it is called
> "Co-developed-by:" not &qu
Make the logging macro uses clearer and fix a whitespace defect.
Joe Perches (2):
scsi: pm8001: Convert pm8001_printk to pm8001_info
scsi: pm8001: Fix misindentation
drivers/scsi/pm8001/pm8001_init.c | 32 +++
drivers/scsi/pm8001/pm8001_sas.c | 4 ++--
drivers
Use the more common logging style.
Signed-off-by: Joe Perches
---
drivers/scsi/pm8001/pm8001_init.c | 12 ++--
drivers/scsi/pm8001/pm8001_sas.c | 4 ++--
drivers/scsi/pm8001/pm8001_sas.h | 4 ++--
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/pm8001
kernel robot reported a misindentation of a goto.
Fix it.
At the same time, use a temporary for a repeated entry in the same block
to reduce visual noise.
Reported-by: kernel test robot
Signed-off-by: Joe Perches
---
drivers/scsi/pm8001/pm8001_init.c | 20 ++--
1 file changed
On Mon, 2020-11-23 at 22:23 -0500, Martin K. Petersen wrote:
> > Reduce code duplication and generic neatening of logging macros
>
> Applied to 5.11/scsi-staging, thanks!
Thanks.
The kernel robot reported an indentation defect here so I will send
a couple more patches on top of this.
On Tue, 2020-11-24 at 01:14 +, Arulprabhu Ponnusamy (arulponn)
wrote:
> Looks good.
I'm not sure why this look good. It looks very odd to me.
> On 11/20/20, 5:38 PM, "Karan Tilak Kumar" wrote:
>
> Replacing shost_printk with FNIC_MAIN_DBG so that
> these log messages are
On Mon, 2020-11-23 at 18:05 -0800, Nick Desaulniers wrote:
> (minus all of these lists, except LKML, CBL, and ACPI)
>
> On Mon, Nov 23, 2020 at 5:46 PM Jakub Kicinski wrote:
>
> > On Mon, 23 Nov 2020 17:32:51 -0800 Nick Desaulniers wrote:
> > > On Sun, Nov 22, 2020 at 8:17 AM Kees Cook wrote:
On Tue, 2020-11-24 at 11:58 +1100, Finn Thain wrote:
> it's not for me to prove that such patches don't affect code
> generation. That's for the patch author and (unfortunately) for reviewers.
Ideally, that proof would be provided by the compilation system itself
and not patch authors nor
On Mon, 2020-11-23 at 22:42 +0100, Sam Ravnborg wrote:
> For this old driver we should try to limit patches to bug fixing and
> infrastructure updates.
It might be useful to add a new "S:" entry type to these old drivers
as supported/maintained/obsolete may not really be appropriate.
How about
On Mon, 2020-11-23 at 20:11 +, David Howells wrote:
> Organise the security information in the rxrpc_connection struct to use a
> union to allow for different data for different security classes.
Is there a known future purpose to this?
> diff --git a/net/rxrpc/ar-internal.h
On Mon, 2020-11-23 at 22:54 +0530, Aditya Srivastava wrote:
> Currently, checkpatch.pl warns for BAD_SIGN_OFF on non-standard signature
> styles.
I think this proposed change is unnecessary.
> This warning occurs because of incorrect use of signature tags,
> e.g. an evaluation on v4.13..v5.8
On Mon, 2020-11-23 at 16:10 +, David Howells wrote:
> Joe Perches wrote:
>
> > > call->unmarshall++;
> > > +
> > > + fallthrough;
> >
> > My preference would be to change these to break and not fallthrough;
> >
&g
On Mon, 2020-11-23 at 07:58 -0800, James Bottomley wrote:
> We're also complaining about the inability to recruit maintainers:
>
> https://www.theregister.com/2020/06/30/hard_to_find_linux_maintainers_says_torvalds/
>
> And burn out:
>
> http://antirez.com/news/129
On Sun, 2020-11-22 at 18:29 +0530, Aditya Srivastava wrote:
> Currently, checkpatch warns if logical continuations are placed at the
> start of a line and not at the end of previous line.
>
> E.g., running checkpatch on commit 3485507fc272 ("staging:
> bcm2835-camera: Reduce length of enum
(removing almost all the cc: lists and leaving scsi and lkml)
On Sat, 2020-11-21 at 10:02 -0800, Joe Perches wrote:
> On Sat, 2020-11-21 at 09:18 -0800, James Bottomley wrote:
> > On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote:
> > > A difficult part of automating co
On Mon, 2020-11-23 at 09:33 +1100, Finn Thain wrote:
> On Sun, 22 Nov 2020, Joe Perches wrote:
> > But provably correct conversions IMO _should_ be done and IMO churn
> > considerations should generally have less importance.
[]
> Moreover, the patch review workload for skill
On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote:
> On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote:
> > On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote:
> > > Please tell me our reward for all this effort isn't a single
> > > missing error print
On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote:
> Please tell me
> our reward for all this effort isn't a single missing error print.
There were quite literally dozens of logical defects found
by the fallthrough additions. Very few were logging only.
On Sun, 2020-11-22 at 08:49 -0800, James Bottomley wrote:
> We can enforce sysfs_emit going forwards
> using tools like checkpatch
It's not really possible for checkpatch to find or warn about
sysfs uses of sprintf. checkpatch is really just a trivial
line-by-line parser and it has no concept of
On Sun, 2020-11-22 at 08:33 -0800, Tom Rix wrote:
> On 11/21/20 9:10 AM, Joe Perches wrote:
> > On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote:
> > > A difficult part of automating commits is composing the subsystem
> > > preamble in the commit log. For th
301 - 400 of 18599 matches
Mail list logo
