Re: [PATCH 29/32] rcu: delete __cpuinit usage from all rcu files

2013-06-24 Thread Josh Triplett
t. Once all the users are gone, > we can then finally remove the macros themselves from linux/init.h. > > This removes all the drivers/rcu uses of the __cpuinit macros > from all C files. > > [1] https://lkml.org/lkml/2013/5/20/589 > > Cc: "Paul E. McKenney" >

[PATCH] turbostat: Increase output buffer size to accommodate C8-C10

2013-06-12 Thread Josh Triplett
On platforms with C8-C10 support, the additional C-states cause turbostat to overrun its output buffer of 128 bytes per CPU. Increase this to 256 bytes per CPU. Signed-off-by: Josh Triplett --- As a bugfix, this should go into 3.10; however, since the C8-C10 support didn't go in until afte

Re: [PATCH tip/core/rcu 13/13] rcu: Shrink TINY_RCU by reworking CPU-stall ifdefs

2013-05-21 Thread Josh Triplett
On Tue, May 21, 2013 at 02:09:57PM -0700, Paul E. McKenney wrote: > On Tue, May 21, 2013 at 10:31:41AM -0700, Josh Triplett wrote: > > On Mon, May 20, 2013 at 07:58:20AM -0700, Paul E. McKenney wrote: > > > From: "Paul E. McKenney" > > > > &g

Re: [PATCH tip/core/rcu 0/2] Documentation changes for 3.11

2013-05-21 Thread Josh Triplett
ng OS jitter form the kworker workqueue > kthreads. For some reason these are numbered 1/2, 2/2, and 1/1. In any case, for all three: Reviewed-by: Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

Re: [PATCH tip/core/rcu 13/13] rcu: Shrink TINY_RCU by reworking CPU-stall ifdefs

2013-05-21 Thread Josh Triplett
are static, and called in only one place, so shouldn't the compiler inline them (and thus throw them away completely when empty)? Why does it not do so? - Josh Triplett > --- > kernel/rcutiny.c| 4 ++-- > kernel/rcutiny_plugin.h | 6 ++ > 2 files changed, 4 inse

Re: [PATCH] Remove warning in efi_enter_virtual_mode

2013-04-18 Thread Josh Triplett
endliness POV > is probably verboten I'd much rather see the code do the right thing automatically, rather than requiring an "unbreak me" command-line parameter. But in any case, since BGRT is a "make my system look prettier" feature rather than core functionality

Re: [PATCH] Remove warning in efi_enter_virtual_mode

2013-04-18 Thread Josh Triplett
On Thu, Apr 18, 2013 at 09:38:04AM -0700, H. Peter Anvin wrote: > On 04/18/2013 09:33 AM, Josh Triplett wrote: > > On Thu, Apr 18, 2013 at 12:00:26PM +0100, Matt Fleming wrote: > >>> No, no - we *don't* have a BGRT object at all. > >>> > >>> We

Re: [PATCH] Remove warning in efi_enter_virtual_mode

2013-04-18 Thread Josh Triplett
rk. We can address this > properly if we ever start seeing i386 machines with bgrt pointers that > reference highmem. The machine I developed the BGRT changes on kept the image below the 4G mark, inside one of the memory regions reclaimable via ExitBootServices(). - Josh Triplett -- To unsubscr

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-04-13 Thread Josh Triplett
On Sat, Apr 13, 2013 at 12:34:25PM -0700, Paul E. McKenney wrote: > On Sat, Apr 13, 2013 at 11:18:00AM -0700, Josh Triplett wrote: > > On Fri, Apr 12, 2013 at 11:38:04PM -0700, Paul E. McKenney wrote: > > > On Fri, Apr 12, 2013 at 04:54:02PM -0700, Josh Triplett wrote: > >

Re: [PATCH tip/core/rcu 0/8] RCU callback-numbering simplifications for 3.11

2013-04-13 Thread Josh Triplett
caller, so inline check_for_new_grace_period(). > > 7.Given that rcu_start_gp_per_cpu() is a trivial wrapper function > with only one caller, inline it into its sole remaining call site. > > 8.Eliminate now-redundant call to note_gp_changes(). For all 8: Reviewed

Re: [PATCH tip/core/rcu 0/12] TINY_RCU changes for 3.11

2013-04-13 Thread Josh Triplett
ing formats from documentation. > > 12. Shrink TINY_RCU a bit by moving exit_rcu() to TREE_RCU, leaving > TINY_RCU with a static inline empty function. For 2-7 and 9-12: Reviewed-by: Josh Triplett I responded to patch 8 with a note about moving part of it to patch 1; with that

Re: [PATCH tip/core/rcu 08/12] rcu: Remove the CONFIG_TINY_RCU ifdefs in rcutiny.h

2013-04-13 Thread Josh Triplett
IG_TINY_RCU legs of those ifdefs. > > Signed-off-by: Paul E. McKenney The #else branches of these ifdefs ought to disappear in the first patch of the series, since they cover the CONFIG_TINY_PREEMPT_RCU case. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-04-13 Thread Josh Triplett
On Fri, Apr 12, 2013 at 11:38:04PM -0700, Paul E. McKenney wrote: > On Fri, Apr 12, 2013 at 04:54:02PM -0700, Josh Triplett wrote: > > On Fri, Apr 12, 2013 at 04:19:13PM -0700, Paul E. McKenney wrote: > > > From: "Paul E. McKenney" > > > > > > Syst

Re: [PATCH tip/core/rcu 0/2] SRCU changes for 3.11

2013-04-12 Thread Josh Triplett
s time for them to go. > > 2.Fix a bug where srcu_read_lock() is not released upon return > from kvmppc_hv_setup_htab_rma(). For both: Reviewed-by: Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [PATCH tip/core/rcu 0/7] RCU fixes for 3.11

2013-04-12 Thread Josh Triplett
Don't allocate bootmem from rcu_init(), courtesy of Sasha Levin. > > 5.Remove "Experimental" flags from old RCU Kconfig options. > > 6.Automatically tune defaults for delays between attempts to > force quiescent states. > > 7.Merge adjacen

Re: [PATCH tip/core/rcu 6/7] rcu: Drive quiescent-state-forcing delay from HZ

2013-04-12 Thread Josh Triplett
> 250 > +#define RCU_JIFFIES_TILL_FORCE_QS 2 > +#else > +#define RCU_JIFFIES_TILL_FORCE_QS 1 > +#endif This seems like it really wants to use a duration calculated directly from HZ; perhaps (HZ/100)? - Josh Triplett -- To unsubscribe from this list: send the line "unsubs

[PATCH] fs: Make binfmt support for #! scripts modular and removable

2013-03-15 Thread Josh Triplett
don't need scripts before mounting the root filesystem can build this as a module. Signed-off-by: Josh Triplett --- Resending this because I received a bounce notification from v...@zeniv.linux.org.uk. Hopefully this one will go through. Note when testing this that many shells implement su

Re: NULL pointer dereference in ext4_superblock_csum_set with mounted filesystem

2013-03-14 Thread Josh Triplett
On Thu, Mar 14, 2013 at 12:08:35AM -0400, Theodore Ts'o wrote: > Huh. This is very, very weird. Is this a repeatable crash? I could reliably replicate it for that particular session, but now that I've rebooted the host, no. - Josh Triplett -- To unsubscribe from this list:

[PATCH] fs: Don't compile in drop_caches.c when CONFIG_SYSCTL=n

2013-03-13 Thread Josh Triplett
drop_caches.c provides code only invokable via sysctl, so don't compile it in when CONFIG_SYSCTL=n. Signed-off-by: Josh Triplett --- fs/Makefile|3 ++- include/linux/mm.h |4 kernel/sysctl.c|1 - 3 files changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH] fs: Make binfmt support for #! scripts modular and removable

2013-03-13 Thread Josh Triplett
don't need scripts before mounting the root filesystem can build this as a module. Signed-off-by: Josh Triplett --- Note when testing this that many shells implement support for shell scripts themselves, so try it with something like #!/bin/cat instead. fs/Kconfig.binfmt | 14

Re: NULL pointer dereference in ext4_superblock_csum_set with mounted filesystem

2013-03-13 Thread Josh Triplett
On Wed, Mar 13, 2013 at 03:01:41PM -0400, Theodore Ts'o wrote: > On Wed, Mar 13, 2013 at 11:59:13AM -0700, Josh Triplett wrote: > > I frequently test kernel changes by booting them with kvm's -kernel > > option, with -hda pointing to my host system's root filesystem

NULL pointer dereference in ext4_superblock_csum_set with mounted filesystem

2013-03-13 Thread Josh Triplett
I frequently test kernel changes by booting them with kvm's -kernel option, with -hda pointing to my host system's root filesystem, and -snapshot to prevent writing to (and likely corrupting) that root filesystem. I tried this with a kernel built from git commit 7c6baa304b841673d3a55ea4fcf9a5cbf7a

Re: very strange dependencies on CONFIG_EXPERT=n in kernel 3.8

2013-03-12 Thread Josh Triplett
[Please don't top-post.] On Tue, Mar 12, 2013 at 03:52:24PM +0100, Konrad Vrba wrote: > On 3/11/13, Josh Triplett wrote: > > On Sun, Mar 10, 2013 at 04:14:27PM +0100, Konrad Vrba wrote: > >> I have noticed that CONFIG_EXPERT=n makes the following options in the > >&

Re: [PATCH] drivers: gpu: drm: i915: Replaced calls to kmalloc & memcpy with kmemdup

2013-03-11 Thread Josh Triplett
this should just "return kmemdup(...);". That suggests an obvious further cleanup that coccinelle could easily handle: if (!foo) return NULL; return foo; should become just "return foo;". And you might then want to check for variables used *only* to capture a return value and

Re: very strange dependencies on CONFIG_EXPERT=n in kernel 3.8

2013-03-11 Thread Josh Triplett
xing. So, for now, turn on CONFIG_EXPERT and live with having CONFIG_DEBUG_KERNEL turned on. That aside, several of the above options should not depend on EXPERT; why would PCSPKR_PLATFORM or DEBUG_MEMORY_INIT need to depend on EXPERT? - Josh Triplett -- To unsubscribe from this list: send the lin

Re: linux-next: manual merge of the tty tree with the input tree

2013-01-28 Thread Josh Triplett
On Mon, Jan 28, 2013 at 04:23:57PM -0800, Dmitry Torokhov wrote: > On Tue, Jan 29, 2013 at 10:59:17AM +1100, Josh Triplett wrote: > > On Mon, Jan 28, 2013 at 02:44:43PM -0800, Dmitry Torokhov wrote: > > > On Mon, Jan 28, 2013 at 02:09:31PM -0800, Joe Millenbach wrote: > >

Re: linux-next: manual merge of the tty tree with the input tree

2013-01-28 Thread Josh Triplett
cept that it does not. Are you confusing SERIO with SERIAL by any > chance? A few serial drivers don't actually need the TTY layer. However, most do, including many that don't obviously appear to at first glance. For instance, MOUSE_PS2 doesn't *appear* to need TTY, but with

Re: [PATCH tip/core/rcu 0/2] v2 Tiny RCU changes for 3.9

2013-01-27 Thread Josh Triplett
with a suggestion; with that change, Reviewed-by: Josh Triplett for the whole series. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordo

Re: [PATCH tip/core/rcu 2/2] rcu: Allow TREE_PREEMPT_RCU on UP systems

2013-01-27 Thread Josh Triplett
ween TINY_PREEMPT_RCU and TREE_PREEMPT_RCU > are quite small compared to the memory footprint of CONFIG_PREEMPT. > > This commit therefore takes a first step towards eliminating > TINY_PREEMPT_RCU by allowing TREE_PREEMPT_RCU to be configured on !SMP > systems. > > Signe

Re: [PATCH tip/core/rcu 1/2] rcu: Provide RCU CPU stall warnings for tiny RCU

2013-01-27 Thread Josh Triplett
TALL_COMMON > config variable to simplify #if expressions. > > Reported-by: Thomas Gleixner > Signed-off-by: Paul E. McKenney > Signed-off-by: Paul E. McKenney One suggestion below; with that change, Reviewed-by: Josh Triplett > --- a/init/Kconfig > +++ b/init/Kconfig >

Re: [PATCH tip/core/rcu 2/2] rcu: Trace callback acceleration

2013-01-27 Thread Josh Triplett
You probably don't want to use --chain-reply-to; that makes patch N a reply to patch N-1 rather than to the cover letter, which creates much deeper and harder to follow threads. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH tip/core/rcu 4/4] rcu: Make rcutorture's shuffler task shuffle recently added tasks

2013-01-27 Thread Josh Triplett
if (barrier_cbs_tasks[i]) > + set_cpus_allowed_ptr(barrier_cbs_tasks[i], > + shuffle_tmp_mask); > + if (barrier_task) > + set_cpus_allowed_ptr(barrier_task, shuffle_tmp_mask); The r

Re: [tip:x86/debug] x86/EFI: Properly init-annotate BGRT code

2013-01-25 Thread Josh Triplett
On Fri, Jan 25, 2013 at 07:36:57PM +0100, Ingo Molnar wrote: > > * Josh Triplett wrote: > > > On Fri, Jan 25, 2013 at 07:45:42AM +, Jan Beulich wrote: > > > >>> On 24.01.13 at 23:28, Josh Triplett wrote: > > > > On Thu, Jan 24, 2013 at 12

Re: [tip:x86/debug] x86/EFI: Properly init-annotate BGRT code

2013-01-25 Thread Josh Triplett
On Fri, Jan 25, 2013 at 07:45:42AM +, Jan Beulich wrote: > >>> On 24.01.13 at 23:28, Josh Triplett wrote: > > On Thu, Jan 24, 2013 at 12:34:21PM -0800, tip-bot for Jan Beulich wrote: > >> Commit-ID: 13f0e4d2b9e2209f13d5a4122478eb79e6136870 > >> Gitweb

Re: [tip:x86/debug] x86/EFI: Properly init-annotate BGRT code

2013-01-24 Thread Josh Triplett
On Thu, Jan 24, 2013 at 12:34:21PM -0800, tip-bot for Jan Beulich wrote: > Commit-ID: 13f0e4d2b9e2209f13d5a4122478eb79e6136870 > Gitweb: http://git.kernel.org/tip/13f0e4d2b9e2209f13d5a4122478eb79e6136870 > Author: Jan Beulich > AuthorDate: Fri, 23 Nov 2012 16:30:07 + > Committer: Ing

Re: [PATCHv4] tty: Added a CONFIG_TTY option to allow removal of TTY

2013-01-18 Thread Josh Triplett
19 -13 > do_exit 15431526 -17 > bitmap_zero 60 40 -20 > arch_local_irq_save 137 117 -20 > release_task 674 652 -22 > s

Re: [PATCH tip/core/rcu 1/1] Tiny RCU changes for 3.9

2013-01-07 Thread Josh Triplett
On Mon, Jan 07, 2013 at 02:19:15PM -0800, Paul E. McKenney wrote: > On Mon, Jan 07, 2013 at 09:56:06AM -0800, Josh Triplett wrote: > > On Mon, Jan 07, 2013 at 08:57:48AM -0800, Paul E. McKenney wrote: > > > On Mon, Jan 07, 2013 at 07:58:10AM -0800, Josh Triplett wrote: > &

Re: [PATCH tip/core/rcu 4/6] rcu: Silence compiler array out-of-bounds false positive

2013-01-07 Thread Josh Triplett
On Mon, Jan 07, 2013 at 07:08:55PM +0100, Markus Trippelsdorf wrote: > On 2013.01.07 at 09:16 -0800, Paul E. McKenney wrote: > > On Mon, Jan 07, 2013 at 07:50:02AM -0800, Josh Triplett wrote: > > > On Sat, Jan 05, 2013 at 09:09:36AM -0800, Paul E. McKenney wrote: > > >

Re: [PATCH tip/core/rcu 1/1] Tiny RCU changes for 3.9

2013-01-07 Thread Josh Triplett
On Mon, Jan 07, 2013 at 08:57:48AM -0800, Paul E. McKenney wrote: > On Mon, Jan 07, 2013 at 07:58:10AM -0800, Josh Triplett wrote: > > On Sat, Jan 05, 2013 at 09:50:59AM -0800, Paul E. McKenney wrote: > > > rcu: Provide RCU CPU stall warnings for tiny RCU > > > >

Re: [PATCH tip/core/rcu 04/14] rcu: Provide compile-time control for no-CBs CPUs

2013-01-07 Thread Josh Triplett
> printk(KERN_INFO "\tRCU restricting CPUs from NR_CPUS=%d to > nr_cpu_ids=%d.\n", NR_CPUS, nr_cpu_ids); > #ifdef CONFIG_RCU_NOCB_CPU > +#if CONFIG_RCU_NOCB_CPU_DEFAULT != 0 That would then make each of these conditionals self-documenting as well. - Josh Triplett -- To unsubscribe

Re: [PATCH tip/core/rcu 05/14] rcu: Distinguish "rcuo" kthreads by RCU flavor

2013-01-07 Thread Josh Triplett
a name ending in /$cpunum ?, rather than just $cpunum? For instance, kworker/0, kworker/1, and so on? Seems like these threads should follow that convention. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH tip/core/rcu 0/3] Documentation and rcutorture changes for 3.9

2013-01-07 Thread Josh Triplett
e list of atomic operations and memory > barriers, courtesy of Richard Braun. For the whole series: Reviewed-by: Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH tip/core/rcu 1/1] Tiny RCU changes for 3.9

2013-01-07 Thread Josh Triplett
sual "---" line between the commit message and the patch. This patch seems reasonable to me, but the repeated use of #if defined(CONFIG_SMP) || defined(CONFIG_RCU_TRACE) seems somewhat annoying, and fragile if you ever decide to change the conditions. How about defining an appropriate s

Re: [PATCH tip/core/rcu 0/6] RCU fixes for 3.9

2013-01-07 Thread Josh Triplett
cu_start_batch(). > > 2. Declare rcu_is_cpu_rrupt_from_idle() static, courtesy of > > Josh Triplett. > > 3. Make rcu_eqs_enter_common() trace the new nesting value instead > > of zero, courtesy of Li Zhong. > > 4. Silence a gcc array-out-of-bounds false positive in rcu

Re: [PATCH tip/core/rcu 4/6] rcu: Silence compiler array out-of-bounds false positive

2013-01-07 Thread Josh Triplett
t change it unexpectedly, since rcu_num_lvls doesn't get declared as static? Unfortunately, the loop macros in rcutree.h make it difficult to make rcu_num_lvls static, but as far as I can tell only one use of those macros ever gets expanded outside of rcutree.c: the one in rcutree_trace.c. If

Re: [PATCH v4] lib: cpu_rmap: avoid flushing all workqueues

2013-01-02 Thread Josh Triplett
some pending works might try to acquire the > lock we are already holding. > > This commit uses reference-counting to replace > irq_run_affinity_notifiers(). It also removes > irq_run_affinity_notifiers() altogether. > > Signed-off-by: David Decotigny Reviewed-by: Josh

Re: [PATCH v3] lib: cpu_rmap: avoid flushing all workqueues

2012-12-29 Thread Josh Triplett
adding a cpu_rmap_get to parallel cpu_rmap_put. Also, why keep free_cpu_rmap around at this point? As far as I can tell, it has no callers. Otherwise, this looks good to me. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH v1] lib: cpu_rmap: avoid flushing all workqueues

2012-12-28 Thread Josh Triplett
On Fri, Dec 28, 2012 at 10:18:11AM -0800, David Decotigny wrote: > Thank you, Josh, > > A few comments below, and the revised version shortly. Responses below. > On Thu, Dec 27, 2012 at 8:04 PM, Josh Triplett wrote: > > On Thu, Dec 27, 2012 at 11:24:34AM -0800, David Decoti

Re: [PATCH v1] lib: cpu_rmap: avoid flushing all workqueues

2012-12-27 Thread Josh Triplett
w; with those addressed, Reviewed-by: Josh Triplett > include/linux/cpu_rmap.h | 13 > include/linux/interrupt.h |5 - > lib/cpu_rmap.c| 48 > +++-- > 3 files changed, 46 insertions(+), 20 deletions

Re: [PATCH] rcutorture: don't compare ptr with 0

2012-12-20 Thread Josh Triplett
On Thu, Dec 20, 2012 at 02:11:28PM -0500, Sasha Levin wrote: > Signed-off-by: Sasha Levin Fair enough. You might as well change the first half of the conditional too, though. In any case: Reviewed-by: Josh Triplett > kernel/rcutorture.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 52/58] x86: vdso: Add prototypes for __vdso_* functions

2012-11-19 Thread Josh Triplett
On Mon, Nov 19, 2012 at 12:04:23PM -0800, Andy Lutomirski wrote: > On Sun, Nov 18, 2012 at 9:28 PM, Josh Triplett wrote: > > arch/x86/vdso/vclock_gettime.c and arch/x86/vdso/vgetcpu.c define > > several functions prefixed by __vdso_*, used in the alias definitions > > for th

Re: [PATCH 46/58] x86: arch/x86/kernel/irqinit.c: Add prototype for init_IRQ

2012-11-19 Thread Josh Triplett
On Mon, Nov 19, 2012 at 10:36:17AM +, David Howells wrote: > Josh Triplett wrote: > > arch/x86/kernel/irqinit.c defines an __init function init_IRQ, called > > from init/main.c. No header file prototypes init_IRQ, because > > init/main.c tends to directly define prototyp

[PATCH 00/58] Eliminate GCC -Wmissing-prototypes warnings from allnoconfig

2012-11-18 Thread Josh Triplett
ering in through several dozen different trees. Josh Triplett (58): pty: Mark pty_resize static drivers/tty/vt/vt_ioctl.c: Include for pm_set_vt_switch sched: Mark scale_rt_power static x86: apic: Mark enable_IR static x86: Only define default_init_apic_ldr for 32-bit trace: Mark trac

[PATCH 06/58] trace: Mark tracing_dentry_percpu static

2012-11-18 Thread Josh Triplett
Nothing outside of kernel/trace/trace.c references tracing_dentry_percpu. Signed-off-by: Josh Triplett --- kernel/trace/trace.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 31e4f55..032f9ee 100644 --- a/kernel/trace

[PATCH 11/58] tty: Mark sysfs_attr_ns static

2012-11-18 Thread Josh Triplett
Nothing outside of fs/sysfs/file.c references this function, so mark it static. Signed-off-by: Josh Triplett --- fs/sysfs/file.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index 00012e3..602f56d 100644 --- a/fs/sysfs/file.c +++ b

[PATCH 08/58] tty: Mark tty_del_file and __tty_hangup static

2012-11-18 Thread Josh Triplett
Nothing outside of drivers/tty/tty_io.c references these functions, so mark them static. Signed-off-by: Josh Triplett --- drivers/tty/tty_io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 2ea176b..023d1fd 100644

[PATCH 13/58] RCU: Make rcu_is_cpu_rrupt_from_idle helper functions static

2012-11-18 Thread Josh Triplett
Both rcutiny and rcutree define a helper funtion rcu_is_cpu_rrupt_from_idle, each used exactly once, later in the same file. Declare these helper functions static. Signed-off-by: Josh Triplett --- kernel/rcutiny.c |2 +- kernel/rcutree.c |2 +- 2 files changed, 2 insertions(+), 2

[PATCH 15/58] kernel/time/timekeeping.c: Include tick-internal.h for do_timer prototype

2012-11-18 Thread Josh Triplett
C files should include the header files that prototype their functions. This keeps the types in sync, and eliminates warnings from GCC (-Wmissing-prototypes) and Sparse (-Wdecl). Signed-off-by: Josh Triplett --- kernel/time/timekeeping.c |1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH 14/58] x86: Mark EVT_TO_HPET_DEV static

2012-11-18 Thread Josh Triplett
Nothing outside of arch/x86/kernel/hpet.c references this function, so mark it static. Signed-off-by: Josh Triplett --- arch/x86/kernel/hpet.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index 1460a5d..2dd92ae 100644

[PATCH 07/58] lib/iommu-helper.c: Include for function prototypes

2012-11-18 Thread Josh Triplett
-helper.c:19:15: warning: no previous prototype for ‘iommu_area_alloc’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- lib/iommu-helper.c |1 + 1 file changed, 1 insertion(+) diff --git a/lib/iommu-helper.c b/lib/iommu-helper.c index c27e269..41d35fb 100644 --- a/lib/iommu-helper.c

[PATCH 02/58] drivers/tty/vt/vt_ioctl.c: Include for pm_set_vt_switch

2012-11-18 Thread Josh Triplett
C files should include the header files that prototype their functions. This keeps the types in sync, and eliminates warnings from GCC (-Wmissing-prototypes) and Sparse (-Wdecl). Signed-off-by: Josh Triplett --- drivers/tty/vt/vt_ioctl.c |1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH 19/58] block: Mark __blkdev_issue_zeroout static

2012-11-18 Thread Josh Triplett
Nothing outside of block/blk-lib.c references __blkdev_issue_zeroout, so mark it static. Signed-off-by: Josh Triplett --- block/blk-lib.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-lib.c b/block/blk-lib.c index 9373b58..b19377f 100644 --- a/block/blk-lib.c

[PATCH 28/58] x86: io_apic: Don't define acpi_get_override_irq if CONFIG_ACPI=n

2012-11-18 Thread Josh Triplett
GCC (-Wmissing-prototypes) and Sparse (-Wdecl). arch/x86/kernel/apic/io_apic.c:3638:5: warning: no previous prototype for ‘acpi_get_override_irq’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- arch/x86/kernel/apic/io_apic.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch

[PATCH 33/58] kernel/resource.c: Make internal function reallocate_resource static

2012-11-18 Thread Josh Triplett
Nothing outside of kernel/resource.c references reallocate_resource, so mark it static. This eliminates warnings from GCC (-Wmissing-prototypes) and Sparse (-Wdecl). kernel/resource.c:476:5: warning: no previous prototype for ‘reallocate_resource’ [-Wmissing-prototypes] Signed-off-by: Josh

[PATCH 27/58] x86: apic: Make apic_flat_64.c include asm/apic_flat_64.h for flat_init_apic_ldr prototype

2012-11-18 Thread Josh Triplett
-prototypes] Signed-off-by: Josh Triplett --- arch/x86/kernel/apic/apic_flat_64.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/apic/apic_flat_64.c b/arch/x86/kernel/apic/apic_flat_64.c index 00c77cf..3cdd11a 100644 --- a/arch/x86/kernel/apic/apic_flat_64.c +++ b/arch/x86/kernel

[PATCH 52/58] x86: vdso: Add prototypes for __vdso_* functions

2012-11-18 Thread Josh Triplett
prototype for ‘__vdso_time’ [-Wmissing-prototypes] arch/x86/vdso/vgetcpu.c:16:1: warning: no previous prototype for ‘__vdso_getcpu’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- arch/x86/vdso/vclock_gettime.c |3 +++ arch/x86/vdso/vgetcpu.c|2 ++ 2 files changed, 5

[PATCH 55/58] sched: Add prototype for sched_set_stop_task

2012-11-18 Thread Josh Triplett
). kernel/sched/core.c:803:6: warning: no previous prototype for ‘sched_set_stop_task’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- kernel/sched/core.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 2d8927f..2d2f5a4 100644 --- a

[PATCH 57/58] sched: Move stubs for CONFIG_FAIR_GROUP_SCHED=n to sched.h

2012-11-18 Thread Josh Triplett
] kernel/sched/fair.c:5284:6: warning: no previous prototype for ‘unregister_fair_sched_group’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- kernel/sched/fair.c | 11 --- kernel/sched/sched.h | 13 + 2 files changed, 13 insertions(+), 11 deletions(-) diff

[PATCH 56/58] sched: Only define init_cfs_bandwidth stub when CONFIG_FAIR_GROUP_SCHED=y

2012-11-18 Thread Josh Triplett
stub in an ifdef CONFIG_FAIR_GROUP_SCHED as well, to avoid defining it when not needed, and to satisfy GCC (-Wmissing-prototypes) and Sparse (-Wdecl). kernel/sched/fair.c:2098:6: warning: no previous prototype for ‘init_cfs_bandwidth’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett

[PATCH 58/58] sched: Move stubs for CONFIG_RT_GROUP_SCHED=n to sched.h

2012-11-18 Thread Josh Triplett
(-Wmissing-prototypes) and Sparse (-Wdecl). kernel/sched/rt.c:220:6: warning: no previous prototype for ‘free_rt_sched_group’ [-Wmissing-prototypes] kernel/sched/rt.c:222:5: warning: no previous prototype for ‘alloc_rt_sched_group’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- kernel

[PATCH 54/58] linux/syscalls.h: Include asm/syscalls.h for additional prototypes

2012-11-18 Thread Josh Triplett
) and Sparse (-Wdecl). fs/exec.c:1667:2: warning: no previous prototype for ‘sys_execve’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- include/linux/syscalls.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h index 4ec00c1

[PATCH 53/58] linux/syscalls.h: Add prototypes for sys_rt_sigaction and sys_rt_sigsuspend

2012-11-18 Thread Josh Triplett
for ‘sys_rt_sigaction’ [-Wmissing-prototypes] kernel/signal.c:3280:7: warning: no previous prototype for ‘sys_rt_sigsuspend’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- include/linux/syscalls.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/syscalls.h b

[PATCH 50/58] x86: arch/x86/kernel/irq_work.c: Add prototype for smp_irq_work_interrupt

2012-11-18 Thread Josh Triplett
’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- arch/x86/kernel/irq_work.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kernel/irq_work.c b/arch/x86/kernel/irq_work.c index ca8f703..7c25e97 100644 --- a/arch/x86/kernel/irq_work.c +++ b/arch/x86/kernel/irq_work.c

[PATCH 51/58] x86: perf: Add prototype for arch_perf_update_userpage

2012-11-18 Thread Josh Triplett
(-Wdecl). arch/x86/kernel/cpu/perf_event.c:1692:6: warning: no previous prototype for ‘arch_perf_update_userpage’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- arch/x86/kernel/cpu/perf_event.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kernel/cpu/perf_event.c b

[PATCH 49/58] x86: init: Mark internal functions iommu_init_noop and iommu_shutdown_noop static

2012-11-18 Thread Josh Triplett
-prototypes] arch/x86/kernel/x86_init.c:30:6: warning: no previous prototype for ‘iommu_shutdown_noop’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- arch/x86/kernel/x86_init.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/x86_init.c b/arch

[PATCH 48/58] x86: arch/x86/kernel/time.c: Include asm/setup.h for setup_default_timer_irq prototype

2012-11-18 Thread Josh Triplett
] Signed-off-by: Josh Triplett --- arch/x86/kernel/time.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/time.c b/arch/x86/kernel/time.c index 24d3c91..c7cb1b3 100644 --- a/arch/x86/kernel/time.c +++ b/arch/x86/kernel/time.c @@ -21,6 +21,7 @@ #include #include #include

[PATCH 46/58] x86: arch/x86/kernel/irqinit.c: Add prototype for init_IRQ

2012-11-18 Thread Josh Triplett
/kernel/irqinit.c right above the definition, to satisfy gcc (-Wmissing-prototypes) and Sparse (-Wdecl). arch/x86/kernel/irqinit.c:118:116: warning: no previous prototype for ‘init_IRQ’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- arch/x86/kernel/irqinit.c |1 + 1 file changed, 1

[PATCH 47/58] x86: arch/x86/kernel/process.c: Include asm/switch_to.h for __switch_to_xtra prototype

2012-11-18 Thread Josh Triplett
-off-by: Josh Triplett --- arch/x86/kernel/process.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index b644e1c..7c292ee 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -28,6 +28,7 @@ #include #include

[PATCH 45/58] x86: Fix prototype for renamed function smp_threshold_interrupt

2012-11-18 Thread Josh Triplett
(-Wdecl). arch/x86/kernel/traps.c:597:29: warning: no previous prototype for ‘smp_threshold_interrupt’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- arch/x86/include/asm/traps.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/traps.h b/arch

[PATCH 44/58] mm: Only define is_pageblock_removable_nolock when needed

2012-11-18 Thread Josh Triplett
-prototypes) and Sparse (-Wdecl). mm/page_alloc.c:5634:6: warning: no previous prototype for ‘is_pageblock_removable_nolock’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- mm/page_alloc.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index

[PATCH 43/58] mm: Mark fallback version of __early_pfn_to_nid static

2012-11-18 Thread Josh Triplett
:4075:118: warning: no previous prototype for ‘__early_pfn_to_nid’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- mm/page_alloc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 5b74de6..d857953 100644 --- a/mm/page_alloc.c

[PATCH 41/58] init/calibrate.c: Add prototype for __weak stub of calibrate_delay_is_known

2012-11-18 Thread Josh Triplett
previous prototype for ‘calibrate_delay_is_known’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- init/calibrate.c |1 + 1 file changed, 1 insertion(+) diff --git a/init/calibrate.c b/init/calibrate.c index fda0a7b..7177627 100644 --- a/init/calibrate.c +++ b/init/calibrate.c @@ -254,6

[PATCH 42/58] kernel/events/hw_breakpoint.c: Add prototype for __weak stub of arch_unregister_hw_breakpoint

2012-11-18 Thread Josh Triplett
: warning: no previous prototype for ‘arch_unregister_hw_breakpoint’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- kernel/events/hw_breakpoint.c |1 + 1 file changed, 1 insertion(+) diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c index 4a3867a..a792001

[PATCH 40/58] panic: Add prototype for __weak stub of panic_smp_self_stop

2012-11-18 Thread Josh Triplett
‘panic_smp_self_stop’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- kernel/panic.c |1 + 1 file changed, 1 insertion(+) diff --git a/kernel/panic.c b/kernel/panic.c index e1b2822..38a4ed4 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -52,6 +52,7 @@ EXPORT_SYMBOL(panic_blink

[PATCH 39/58] kernel/events/core.c: Add prototype for __weak stub of arch_perf_update_userpage

2012-11-18 Thread Josh Triplett
previous prototype for ‘arch_perf_update_userpage’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- kernel/events/core.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/events/core.c b/kernel/events/core.c index 543638a..69ab633 100644 --- a/kernel/events/core.c +++ b

[PATCH 38/58] block: Mark internal function blk_drain_queue static

2012-11-18 Thread Josh Triplett
Nothing outside of block/blk-core.c references blk_drain_queue, so mark it static. This eliminates warnings from GCC (-Wmissing-prototypes) and Sparse (-Wdecl). block/blk-core.c:360:6: warning: no previous prototype for ‘blk_drain_queue’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett

[PATCH 36/58] kernel/fork.c: Add prototype for __weak stub of arch_release_thread_info

2012-11-18 Thread Josh Triplett
‘arch_release_thread_info’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- kernel/fork.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/fork.c b/kernel/fork.c index 8b20ab7..8532f1a 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -132,6 +132,8 @@ static inline void

[PATCH 37/58] kernel/fork.c: Add prototype for fork_init

2012-11-18 Thread Josh Triplett
right above the definition, to satisfy gcc (-Wmissing-prototypes) and Sparse (-Wdecl). kernel/fork.c:251:116: warning: no previous prototype for ‘fork_init’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- kernel/fork.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/fork.c b

[PATCH 35/58] x86: arch/x86/kernel/asm-offsets.c: Add prototype for dummy function common

2012-11-18 Thread Josh Triplett
: warning: no previous prototype for ‘common’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- arch/x86/kernel/asm-offsets.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kernel/asm-offsets.c b/arch/x86/kernel/asm-offsets.c index 2861082..bae77e4 100644 --- a/arch/x86/kernel

[PATCH 34/58] kbuild: kernel/bounds.c: Add prototype for dummy function foo

2012-11-18 Thread Josh Triplett
‘foo’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- kernel/bounds.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/bounds.c b/kernel/bounds.c index 0c9b862..cfb4805 100644 --- a/kernel/bounds.c +++ b/kernel/bounds.c @@ -11,6 +11,8 @@ #include #include +void foo

[PATCH 32/58] kernel/resource.c: Include linux/mm.h for page_is_ram prototype

2012-11-18 Thread Josh Triplett
: Josh Triplett --- kernel/resource.c |1 + 1 file changed, 1 insertion(+) diff --git a/kernel/resource.c b/kernel/resource.c index 73f35d4..f593f18 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -21,6 +21,7 @@ #include #include #include +#include #include -- 1.7.10.4

[PATCH 31/58] perf: cgroup: Drop unused perf_cgroup_switch stub

2012-11-18 Thread Josh Triplett
). kernel/events/core.c:604:1: warning: no previous prototype for ‘perf_cgroup_switch’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- kernel/events/core.c |5 - 1 file changed, 5 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 01ba4db..543638a 100644 --- a

[PATCH 30/58] block: Eliminate unused function kblockd_schedule_delayed_work

2012-11-18 Thread Josh Triplett
chedule_delayed_work once again. This also eliminates a warning from gcc (-Wmissing-prototypes) and from Sparse (-Wdecl). block/blk-core.c:2820:5: warning: no previous prototype for ‘kblockd_schedule_delayed_work’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- block/blk-core.c |7 ---

[PATCH 24/58] mm: include/linux/huge_mm.h: Declare is_vma_temporary_stack unconditionally

2012-11-18 Thread Josh Triplett
:1440:6: warning: no previous prototype for ‘is_vma_temporary_stack’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- include/linux/huge_mm.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index b31cb7d..3f39803

[PATCH 29/58] mm: Make copy_pte_range static

2012-11-18 Thread Josh Triplett
mm/memory.c. Make the function static. This eliminates a warning from gcc (-Wmissing-prototypes) and from Sparse (-Wdecl). mm/memory.c:917:5: warning: no previous prototype for ‘copy_pte_range’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- include/linux/huge_mm.h |4 mm

[PATCH 25/58] mm: include/linux/huge_mm.h: Declare handle_pte_fault unconditionally

2012-11-18 Thread Josh Triplett
:5: warning: no previous prototype for ‘handle_pte_fault’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- include/linux/huge_mm.h |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 3f39803..8ed2187 100644

[PATCH 26/58] mm/internal.h: Declare vma_address unconditionally

2012-11-18 Thread Josh Triplett
previous prototype for ‘vma_address’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- mm/internal.h |2 -- 1 file changed, 2 deletions(-) diff --git a/mm/internal.h b/mm/internal.h index a4fa284..6cd14dc 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -221,10 +221,8 @@ static inline

[PATCH 23/58] mm: Avoid defining set_iounmap_nonlazy on non-x86

2012-11-18 Thread Josh Triplett
. Meanwhile, include the appropriate header with the prototype, to eliminate a warning from gcc (-Wmissing-prototypes) and from Sparse (-Wdecl). mm/vmalloc.c:563:6: warning: no previous prototype for ‘set_iounmap_nonlazy’ [-Wmissing-prototypes] Signed-off-by: Josh Triplett --- mm/vmalloc.c |3

[PATCH 22/58] arch/x86/kernel/cpu/common.c: Mark cpu_detect_tlb static

2012-11-18 Thread Josh Triplett
Nothing outside of arch/x86/kernel/cpu/common.c references cpu_detect_tlb, so mark it static. Signed-off-by: Josh Triplett --- arch/x86/kernel/cpu/common.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index

[PATCH 21/58] kernel/events/core.c: Mark internal function static

2012-11-18 Thread Josh Triplett
Nothing outside of kernel/events/core.c references perf_cgroup_switch, perf_init_event, or perf_event_init_context; mark these functions static. Signed-off-by: Josh Triplett --- kernel/events/core.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/events

<    6   7   8   9   10   11   12   13   14   >