Re: [PATCH v4 10/10] x86: Support compiling out userspace IO (iopl and ioperm)

2014-11-03 Thread Josh Triplett
On Mon, Nov 03, 2014 at 12:10:49PM +, One Thousand Gnomes wrote: On Sun, 2 Nov 2014 09:33:01 -0800 Josh Triplett j...@joshtriplett.org wrote: On the vast majority of modern systems, no processes will use the userspsace IO syscalls, iopl and ioperm. Add a new config option

Re: [PATCH] compiler: Correct macro parameter expansion problem

2014-11-03 Thread Josh Triplett
-by: Mark Rustad mark.d.rus...@intel.com Tested-by: Aaron Brown aaron.f.br...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com Good catch. Reviewed-by: Josh Triplett j...@joshtriplett.org include/linux/compiler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] CodingStyle: Add a chapter on conditional compilation

2014-11-03 Thread Josh Triplett
On Mon, Nov 03, 2014 at 09:47:40AM -0800, Joe Perches wrote: On Mon, 2014-11-03 at 11:46 -0500, Jonathan Corbet wrote: On Wed, 29 Oct 2014 11:15:17 -0700 Josh Triplett j...@joshtriplett.org wrote: Document several common practices and conventions regarding conditional compilation

[PATCH v4 09/10] x86: process: Introduce helper to switch IO bitmap

2014-11-02 Thread Josh Triplett
This simplifies __switch_to_xtra, and will make it easier to make IO optional later. Signed-off-by: Josh Triplett --- arch/x86/kernel/process-io.h | 23 +++ arch/x86/kernel/process.c| 14 +- 2 files changed, 24 insertions(+), 13 deletions(-) diff --git

[PATCH v4 08/10] x86: process: Introduce helper for IO-related bits of exit_thread

2014-11-02 Thread Josh Triplett
This makes the two major functions of exit_thread (IO and FPU) more obvious, and will make it easier to make IO optional later. Signed-off-by: Josh Triplett --- arch/x86/kernel/process-io.h | 20 arch/x86/kernel/process.c| 20 +++- 2 files changed, 23

[PATCH v4 10/10] x86: Support compiling out userspace IO (iopl and ioperm)

2014-11-02 Thread Josh Triplett
8576 384 -8192 Signed-off-by: Josh Triplett --- arch/x86/Kconfig | 10 ++ arch/x86/include/asm/paravirt.h | 2 ++ arch/x86/include/asm/paravirt_types.h | 4 arch/x86/include/asm/processor.h | 19 ++- arch/x86/include/asm

[PATCH v4 03/10] x86: processor.h: Introduce macros to initialize IO fields of thread and TSS

2014-11-02 Thread Josh Triplett
No functional change, just splitting out parts of the existing INIT_THREAD and INIT_TSS macros. This will simplify making those fields optional later. Signed-off-by: Josh Triplett --- arch/x86/include/asm/processor.h | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions

[PATCH v4 04/10] x86: paravirt: Wrap initialization of set_iopl_mask in a macro

2014-11-02 Thread Josh Triplett
This will allow making set_iopl_mask optional later. Signed-off-by: Josh Triplett --- arch/x86/include/asm/paravirt_types.h | 1 + arch/x86/kernel/paravirt.c| 2 +- arch/x86/xen/enlighten.c | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch

[PATCH v4 06/10] x86: process: Introduce helper to clear a thread's IO bitmap

2014-11-02 Thread Josh Triplett
This will make it easier to make the io_bitmap_ptr field optional later. Signed-off-by: Josh Triplett --- arch/x86/kernel/process-io.h | 5 + arch/x86/kernel/process_32.c | 4 ++-- arch/x86/kernel/process_64.c | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/x86

[PATCH v4 07/10] x86: process: Introduce helper to switch iopl mask

2014-11-02 Thread Josh Triplett
This simplifies __switch_to a bit, and will make it easier to make iopl optional later. Signed-off-by: Josh Triplett --- arch/x86/kernel/process-io.h | 13 + arch/x86/kernel/process_32.c | 9 + 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/arch/x86/kernel

[PATCH v4 05/10] x86: cpu: Add helper function unifying 32-bit and 64-bit IO init in cpu_init

2014-11-02 Thread Josh Triplett
-related fields optional later. Signed-off-by: Josh Triplett --- arch/x86/include/asm/processor.h | 14 ++ arch/x86/kernel/cpu/common.c | 12 ++-- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h

[PATCH v4 01/10] x86: process: Unify 32-bit and 64-bit copy_thread I/O bitmap handling

2014-11-02 Thread Josh Triplett
; move the resulting identical code to a static inline in a common header. Signed-off-by: Josh Triplett Acked-by: Kees Cook --- arch/x86/kernel/process-io.h | 22 ++ arch/x86/kernel/process_32.c | 28 arch/x86/kernel/process_64.c | 25

[PATCH v4 02/10] x86: tss: Eliminate fragile calculation of TSS segment limit

2014-11-02 Thread Josh Triplett
the array. That then removes the last use of IO_BITMAP_OFFSET, so delete it. Signed-off-by: Josh Triplett Acked-by: Alexander van Heukelum --- arch/x86/include/asm/desc.h | 11 +-- arch/x86/include/asm/processor.h | 4 +++- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/arch/x

[PATCH v4 00/10] x86: Support compiling out userspace IO (iopl and ioperm)

2014-11-02 Thread Josh Triplett
, as requested by Thomas Gleixner. I've verified that this compiles after each patch. Josh Triplett (10): x86: process: Unify 32-bit and 64-bit copy_thread I/O bitmap handling x86: tss: Eliminate fragile calculation of TSS segment limit x86: processor.h: Introduce macros to initialize IO

[PATCH v4 00/10] x86: Support compiling out userspace IO (iopl and ioperm)

2014-11-02 Thread Josh Triplett
, as requested by Thomas Gleixner. I've verified that this compiles after each patch. Josh Triplett (10): x86: process: Unify 32-bit and 64-bit copy_thread I/O bitmap handling x86: tss: Eliminate fragile calculation of TSS segment limit x86: processor.h: Introduce macros to initialize IO

[PATCH v4 01/10] x86: process: Unify 32-bit and 64-bit copy_thread I/O bitmap handling

2014-11-02 Thread Josh Triplett
; move the resulting identical code to a static inline in a common header. Signed-off-by: Josh Triplett j...@joshtriplett.org Acked-by: Kees Cook keesc...@chromium.org --- arch/x86/kernel/process-io.h | 22 ++ arch/x86/kernel/process_32.c | 28 arch/x86

[PATCH v4 03/10] x86: processor.h: Introduce macros to initialize IO fields of thread and TSS

2014-11-02 Thread Josh Triplett
No functional change, just splitting out parts of the existing INIT_THREAD and INIT_TSS macros. This will simplify making those fields optional later. Signed-off-by: Josh Triplett j...@joshtriplett.org --- arch/x86/include/asm/processor.h | 18 +++--- 1 file changed, 11 insertions

[PATCH v4 04/10] x86: paravirt: Wrap initialization of set_iopl_mask in a macro

2014-11-02 Thread Josh Triplett
This will allow making set_iopl_mask optional later. Signed-off-by: Josh Triplett j...@joshtriplett.org --- arch/x86/include/asm/paravirt_types.h | 1 + arch/x86/kernel/paravirt.c| 2 +- arch/x86/xen/enlighten.c | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions

[PATCH v4 02/10] x86: tss: Eliminate fragile calculation of TSS segment limit

2014-11-02 Thread Josh Triplett
. That then removes the last use of IO_BITMAP_OFFSET, so delete it. Signed-off-by: Josh Triplett j...@joshtriplett.org Acked-by: Alexander van Heukelum heuke...@fastmail.fm --- arch/x86/include/asm/desc.h | 11 +-- arch/x86/include/asm/processor.h | 4 +++- 2 files changed, 4 insertions(+), 11

[PATCH v4 06/10] x86: process: Introduce helper to clear a thread's IO bitmap

2014-11-02 Thread Josh Triplett
This will make it easier to make the io_bitmap_ptr field optional later. Signed-off-by: Josh Triplett j...@joshtriplett.org --- arch/x86/kernel/process-io.h | 5 + arch/x86/kernel/process_32.c | 4 ++-- arch/x86/kernel/process_64.c | 2 +- 3 files changed, 8 insertions(+), 3 deletions

[PATCH v4 07/10] x86: process: Introduce helper to switch iopl mask

2014-11-02 Thread Josh Triplett
This simplifies __switch_to a bit, and will make it easier to make iopl optional later. Signed-off-by: Josh Triplett j...@joshtriplett.org --- arch/x86/kernel/process-io.h | 13 + arch/x86/kernel/process_32.c | 9 + 2 files changed, 14 insertions(+), 8 deletions(-) diff

[PATCH v4 05/10] x86: cpu: Add helper function unifying 32-bit and 64-bit IO init in cpu_init

2014-11-02 Thread Josh Triplett
-related fields optional later. Signed-off-by: Josh Triplett j...@joshtriplett.org --- arch/x86/include/asm/processor.h | 14 ++ arch/x86/kernel/cpu/common.c | 12 ++-- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/arch/x86/include/asm/processor.h b/arch/x86

[PATCH v4 10/10] x86: Support compiling out userspace IO (iopl and ioperm)

2014-11-02 Thread Josh Triplett
8576 384 -8192 Signed-off-by: Josh Triplett j...@joshtriplett.org --- arch/x86/Kconfig | 10 ++ arch/x86/include/asm/paravirt.h | 2 ++ arch/x86/include/asm/paravirt_types.h | 4 arch/x86/include/asm/processor.h | 19

[PATCH v4 09/10] x86: process: Introduce helper to switch IO bitmap

2014-11-02 Thread Josh Triplett
This simplifies __switch_to_xtra, and will make it easier to make IO optional later. Signed-off-by: Josh Triplett j...@joshtriplett.org --- arch/x86/kernel/process-io.h | 23 +++ arch/x86/kernel/process.c| 14 +- 2 files changed, 24 insertions(+), 13 deletions

[PATCH v4 08/10] x86: process: Introduce helper for IO-related bits of exit_thread

2014-11-02 Thread Josh Triplett
This makes the two major functions of exit_thread (IO and FPU) more obvious, and will make it easier to make IO optional later. Signed-off-by: Josh Triplett j...@joshtriplett.org --- arch/x86/kernel/process-io.h | 20 arch/x86/kernel/process.c| 20 +++- 2

Re: [PATCH v3 3/3] x86: Support compiling out userspace I/O (iopl and ioperm)

2014-11-01 Thread Josh Triplett
On Wed, Oct 29, 2014 at 10:00:54PM +0100, Thomas Gleixner wrote: > On Wed, 29 Oct 2014, Josh Triplett wrote: > > v3: Eliminated several #ifdefs, and in particular almost all #ifdefs in > > .c files, by adding a macro INIT_SET_IOPL_MASK to use in place of > >

Re: [PATCH v3 3/3] x86: Support compiling out userspace I/O (iopl and ioperm)

2014-11-01 Thread Josh Triplett
On Wed, Oct 29, 2014 at 10:00:54PM +0100, Thomas Gleixner wrote: On Wed, 29 Oct 2014, Josh Triplett wrote: v3: Eliminated several #ifdefs, and in particular almost all #ifdefs in .c files, by adding a macro INIT_SET_IOPL_MASK to use in place of the initializer for set_iopl_mask

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Josh Triplett
at have nowhere for the output to go at all, it still makes sense to compile all of the printing infrastructure out of the decompression stub, especially since that code itself does not get compressed and thus has a higher impact than code in vmlinux. - Josh Triplett -- To unsubscribe from this list

Re: [PATCH v2] x86, boot: add hex output for debugging

2014-10-31 Thread Josh Triplett
ad attached one in local tree for a while. or even sent it before > several years ago. I don't think we need the full generality of printf in the decompression stub. I prefer Kees' patch, though I'd still like to see __puthex made conditional. - Josh Triplett -- To unsubscribe from this list

Re: [PATCH v2] x86, boot: add hex output for debugging

2014-10-31 Thread Josh Triplett
prefer Kees' patch, though I'd still like to see __puthex made conditional. - Josh Triplett -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Josh Triplett
infrastructure out of the decompression stub, especially since that code itself does not get compressed and thus has a higher impact than code in vmlinux. - Josh Triplett -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH tip/core/rcu 1/6] torture: Run Linux-kernel binary out of results directory

2014-10-30 Thread Josh Triplett
ater builds. This commit therefore runs > the kernel out of the results directory so that less hand-editing is > required to re-run a previous test. > > Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett > tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh | 4 ++

Re: [PATCH 3.18] tiny: rename ENABLE_DEV_COREDUMP to ALLOW_DEV_COREDUMP

2014-10-30 Thread Josh Triplett
to ALLOW_DEV_COREDUMP to better capture its semantics. > > Signed-off-by: Johannes Berg Seems reasonable. The original "DISABLE" was really "FORCE_DISABLE" (even if used), and the inverse of "FORCE_DISABLE" is not "ENABLE", it's "ALLOW" (if

Re: [PATCH 3.18] tiny: rename ENABLE_DEV_COREDUMP to ALLOW_DEV_COREDUMP

2014-10-30 Thread Josh Triplett
it to ALLOW_DEV_COREDUMP to better capture its semantics. Signed-off-by: Johannes Berg johannes.b...@intel.com Seems reasonable. The original DISABLE was really FORCE_DISABLE (even if used), and the inverse of FORCE_DISABLE is not ENABLE, it's ALLOW (if used). Reviewed-by: Josh Triplett j

Re: [PATCH tip/core/rcu 1/6] torture: Run Linux-kernel binary out of results directory

2014-10-30 Thread Josh Triplett
builds. This commit therefore runs the kernel out of the results directory so that less hand-editing is required to re-run a previous test. Signed-off-by: Paul E. McKenney paul...@linux.vnet.ibm.com Reviewed-by: Josh Triplett j...@joshtriplett.org tools/testing/selftests/rcutorture/bin/kvm

Re: [PATCH] CodingStyle: Add a chapter on conditional compilation

2014-10-29 Thread Josh Triplett
On Wed, Oct 29, 2014 at 05:35:02PM -0700, Randy Dunlap wrote: > On 10/29/14 12:12, Geert Uytterhoeven wrote: > > On Wed, Oct 29, 2014 at 7:15 PM, Josh Triplett > > wrote: > >> Document several common practices and conventions regarding conditional > >> compila

Re: [PATCH] CodingStyle: Add a chapter on conditional compilation

2014-10-29 Thread Josh Triplett
On Wed, Oct 29, 2014 at 08:12:49PM +0100, Geert Uytterhoeven wrote: > On Wed, Oct 29, 2014 at 7:15 PM, Josh Triplett wrote: > > Document several common practices and conventions regarding conditional > > compilation, most notably the preference for ifdefs in headers rather &g

[PATCH] CodingStyle: Add a chapter on conditional compilation

2014-10-29 Thread Josh Triplett
Document several common practices and conventions regarding conditional compilation, most notably the preference for ifdefs in headers rather than .c files. Signed-off-by: Josh Triplett --- I found myself explaining a few of these unwritten rules in patch feedback, so I figured I'd document

[PATCH v3 1/3] x86: process: Unify 32-bit and 64-bit copy_thread I/O bitmap handling

2014-10-29 Thread Josh Triplett
; move the resulting identical code to a static inline in a common header. Signed-off-by: Josh Triplett Acked-by: Kees Cook --- v3: No changes in this patch, only in patch 3/3. arch/x86/kernel/process-io.h | 22 ++ arch/x86/kernel/process_32.c | 28

[PATCH v3 3/3] x86: Support compiling out userspace I/O (iopl and ioperm)

2014-10-29 Thread Josh Triplett
257-107 __switch_to_xtra 234 123-111 sys_ioperm 240 --240 init_tss8576 384 -8192 Signed-off-by: Josh Triplett --- v3: Eliminated several #ifdefs, and in particular almost all

[PATCH v3 2/3] x86: tss: Eliminate fragile calculation of TSS segment limit

2014-10-29 Thread Josh Triplett
the array. That then removes the last use of IO_BITMAP_OFFSET, so delete it. Signed-off-by: Josh Triplett Acked-by: Alexander van Heukelum --- v3: No changes in this patch, only in patch 3/3. arch/x86/include/asm/desc.h | 11 +-- arch/x86/include/asm/processor.h | 4 +++- 2 files changed, 4

Re: linux-next: manual merge of the tiny tree with the tip tree

2014-10-29 Thread Josh Triplett
On Tue, Sep 23, 2014 at 10:36:03AM +0200, Ingo Molnar wrote: > * Josh Triplett wrote: > > I've dropped tiny/no-io from tiny/next; I'll poke at it further > > and resubmit for the x86 tree later, likely not for the next > > merge window at this point. > > > > T

Re: linux-next: manual merge of the tiny tree with the tip tree

2014-10-29 Thread Josh Triplett
On Tue, Sep 23, 2014 at 10:36:03AM +0200, Ingo Molnar wrote: * Josh Triplett j...@joshtriplett.org wrote: I've dropped tiny/no-io from tiny/next; I'll poke at it further and resubmit for the x86 tree later, likely not for the next merge window at this point. Thanks for the feedback

[PATCH v3 2/3] x86: tss: Eliminate fragile calculation of TSS segment limit

2014-10-29 Thread Josh Triplett
. That then removes the last use of IO_BITMAP_OFFSET, so delete it. Signed-off-by: Josh Triplett j...@joshtriplett.org Acked-by: Alexander van Heukelum heuke...@fastmail.fm --- v3: No changes in this patch, only in patch 3/3. arch/x86/include/asm/desc.h | 11 +-- arch/x86/include/asm/processor.h | 4

[PATCH v3 3/3] x86: Support compiling out userspace I/O (iopl and ioperm)

2014-10-29 Thread Josh Triplett
257-107 __switch_to_xtra 234 123-111 sys_ioperm 240 --240 init_tss8576 384 -8192 Signed-off-by: Josh Triplett j...@joshtriplett.org --- v3: Eliminated several #ifdefs

[PATCH v3 1/3] x86: process: Unify 32-bit and 64-bit copy_thread I/O bitmap handling

2014-10-29 Thread Josh Triplett
; move the resulting identical code to a static inline in a common header. Signed-off-by: Josh Triplett j...@joshtriplett.org Acked-by: Kees Cook keesc...@chromium.org --- v3: No changes in this patch, only in patch 3/3. arch/x86/kernel/process-io.h | 22 ++ arch/x86/kernel

[PATCH] CodingStyle: Add a chapter on conditional compilation

2014-10-29 Thread Josh Triplett
Document several common practices and conventions regarding conditional compilation, most notably the preference for ifdefs in headers rather than .c files. Signed-off-by: Josh Triplett j...@joshtriplett.org --- I found myself explaining a few of these unwritten rules in patch feedback, so I

Re: [PATCH] CodingStyle: Add a chapter on conditional compilation

2014-10-29 Thread Josh Triplett
On Wed, Oct 29, 2014 at 08:12:49PM +0100, Geert Uytterhoeven wrote: On Wed, Oct 29, 2014 at 7:15 PM, Josh Triplett j...@joshtriplett.org wrote: Document several common practices and conventions regarding conditional compilation, most notably the preference for ifdefs in headers rather than

Re: [PATCH] CodingStyle: Add a chapter on conditional compilation

2014-10-29 Thread Josh Triplett
On Wed, Oct 29, 2014 at 05:35:02PM -0700, Randy Dunlap wrote: On 10/29/14 12:12, Geert Uytterhoeven wrote: On Wed, Oct 29, 2014 at 7:15 PM, Josh Triplett j...@joshtriplett.org wrote: Document several common practices and conventions regarding conditional compilation, most notably

Re: [PATCH 3/3] x86_64,vsyscall: Make vsyscall emulation configurable

2014-10-28 Thread Josh Triplett
tiny amount of core mm code that supports a gate area, > and possibly 4k for a wasted pagetable. The latter is because the > vsyscall addresses are misaligned and fit poorly in the fixmap. > > Signed-off-by: Andy Lutomirski One minor nit below, but with or without that change, Re

Re: [PATCH 3/3] x86_64,vsyscall: Make vsyscall emulation configurable

2014-10-28 Thread Josh Triplett
IS_ENABLED? if (IS_ENABLED(CONFIG_X86_VSYSCALL_EMULATION) user_pgd != NULL) That has the advantage of ensuring that the code continues to compile. (Given that you haven't removed level3_user_vsyscall, that should work.) - Josh Triplett -- To unsubscribe from this list: send

Re: [PATCH net] bpf: split eBPF out of NET

2014-10-24 Thread Josh Triplett
On Thu, Oct 23, 2014 at 10:32:50PM -0700, Alexei Starovoitov wrote: > On Thu, Oct 23, 2014 at 8:23 PM, Josh Triplett wrote: > > On Thu, Oct 23, 2014 at 06:41:08PM -0700, Alexei Starovoitov wrote: > >> introduce two configs: > >> - hidden CONFIG_BPF to select eBPF inte

Re: [PATCH net] bpf: split eBPF out of NET

2014-10-24 Thread Josh Triplett
On Thu, Oct 23, 2014 at 10:32:50PM -0700, Alexei Starovoitov wrote: On Thu, Oct 23, 2014 at 8:23 PM, Josh Triplett j...@joshtriplett.org wrote: On Thu, Oct 23, 2014 at 06:41:08PM -0700, Alexei Starovoitov wrote: introduce two configs: - hidden CONFIG_BPF to select eBPF interpreter

Re: [PATCH net] bpf: split eBPF out of NET

2014-10-23 Thread Josh Triplett
On Thu, Oct 23, 2014 at 06:41:08PM -0700, Alexei Starovoitov wrote: > introduce two configs: > - hidden CONFIG_BPF to select eBPF interpreter that classic socket filters > depend on > - visible CONFIG_BPF_SYSCALL (default off) that tracing and sockets can use > > that solves several problems: >

Re: [PATCH net] bpf: split eBPF out of NET

2014-10-23 Thread Josh Triplett
On Thu, Oct 23, 2014 at 06:41:08PM -0700, Alexei Starovoitov wrote: introduce two configs: - hidden CONFIG_BPF to select eBPF interpreter that classic socket filters depend on - visible CONFIG_BPF_SYSCALL (default off) that tracing and sockets can use that solves several problems: -

Re: [PATCH] init: Remove CONFIG_INIT_FALLBACK

2014-10-21 Thread Josh Triplett
ad" > > - default y > > - help > > The above is not in mainline, nor in -next? > Seems it only exists in a patch series you sent yourself? > > Confused... See the previous thread. The previous patch adds this config option to make the current default behavior o

Re: [PATCH 2/2] fs: Support compiling out sendfile

2014-10-21 Thread Josh Triplett
On Tue, Oct 21, 2014 at 02:13:56AM -0700, Christoph Hellwig wrote: > On Tue, Oct 21, 2014 at 02:04:22AM -0700, Josh Triplett wrote: > > That's the plan, but since sendfile depends on some of the splice bits, > > sendfile needs to be optional as well; SENDFILE_SYSCALL w

Re: [PATCH 2/2] fs: Support compiling out sendfile

2014-10-21 Thread Josh Triplett
take the series through the tiny tree when it's ready > > to merge. > > I think it's rather pointless - there is very little sendfile code, > so you'd rather want to disable splice. That's the plan, but since sendfile depends on some of the splice bits, sendfile needs to be opti

Re: [PATCH 2/2] fs: Support compiling out sendfile

2014-10-21 Thread Josh Triplett
pointless - there is very little sendfile code, so you'd rather want to disable splice. That's the plan, but since sendfile depends on some of the splice bits, sendfile needs to be optional as well; SENDFILE_SYSCALL will then select SPLICE_SYSCALLS. - Josh Triplett -- To unsubscribe from this list

Re: [PATCH 2/2] fs: Support compiling out sendfile

2014-10-21 Thread Josh Triplett
On Tue, Oct 21, 2014 at 02:13:56AM -0700, Christoph Hellwig wrote: On Tue, Oct 21, 2014 at 02:04:22AM -0700, Josh Triplett wrote: That's the plan, but since sendfile depends on some of the splice bits, sendfile needs to be optional as well; SENDFILE_SYSCALL will then select SPLICE_SYSCALLS

Re: [PATCH] init: Remove CONFIG_INIT_FALLBACK

2014-10-21 Thread Josh Triplett
the previous thread. The previous patch adds this config option to make the current default behavior optional. The removal patch then removes the old default behavior. Andrew plans to push them in successive kernels, to give more review time. - Josh Triplett -- To unsubscribe from this list: send

Re: [PATCH v5] init: Disable defaults if init= fails

2014-10-20 Thread Josh Triplett
plement, easy to > understand, and has extremely predictable behavior. The fallback > behavior is more user friendly if you consider having a chance of > booting to something useful if you typo your init= option (but also a > chance of booting to something actively undesirable). Here's

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

2014-10-20 Thread Josh Triplett
> > switch off DEV_COREDUMP regardless if any drivers select > > WANT_DEV_COREDUMP. > > > > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to > > 'n' (as in allnconfig or tinyconfig) will effectively disable device > > coredump. > > > >

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

2014-10-20 Thread Josh Triplett
regardless if any drivers select WANT_DEV_COREDUMP. This patch renames the option to ENABLE_DEV_COREDUMP and setting it to 'n' (as in allnconfig or tinyconfig) will effectively disable device coredump. Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Josh Triplett j

Re: [PATCH v5] init: Disable defaults if init= fails

2014-10-20 Thread Josh Triplett
if anyone screams, and if they do, we add that code back in under a Kconfig option as in your current patch? Would that make your Kconfig senses stop tingling, Andrew? :) - Josh Triplett -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

2014-10-16 Thread Josh Triplett
c: Greg Kroah-Hartman > Cc: Josh Triplett > Cc: Johannes Berg > Reviewed-by: Josh Triplett > Signed-off-by: Aristeu Rozanski You should have a "---" line here, followed by a diffstat. If you're not using git format-patch to format your patches, you should. - Josh Tripl

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

2014-10-16 Thread Josh Triplett
On Thu, Oct 16, 2014 at 12:18:43PM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 16, 2014 at 05:51:58AM +0200, Josh Triplett wrote: > > On Thu, Oct 16, 2014 at 01:14:46AM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Oct 15, 2014 at 11:25:23AM -0400, Aristeu Rozanski w

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

2014-10-16 Thread Josh Triplett
On Thu, Oct 16, 2014 at 12:18:43PM +0200, Greg Kroah-Hartman wrote: On Thu, Oct 16, 2014 at 05:51:58AM +0200, Josh Triplett wrote: On Thu, Oct 16, 2014 at 01:14:46AM +0200, Greg Kroah-Hartman wrote: On Wed, Oct 15, 2014 at 11:25:23AM -0400, Aristeu Rozanski wrote: It's desirable

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

2014-10-16 Thread Josh Triplett
...@linuxfoundation.org Cc: Josh Triplett j...@joshtriplett.org Cc: Johannes Berg johan...@sipsolutions.net Reviewed-by: Josh Triplett j...@joshtriplett.org Signed-off-by: Aristeu Rozanski aroza...@redhat.com You should have a --- line here, followed by a diffstat. If you're not using git format-patch to format

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

2014-10-15 Thread Josh Triplett
y to > > switch off DEV_COREDUMP regardless if any drivers select > > WANT_DEV_COREDUMP. > > > > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to > > 'n' (as in allnconfig or tinyconfig) will effectively disable device > > coredump. >

Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

2014-10-15 Thread Josh Triplett
DEV_COREDUMP regardless if any drivers select WANT_DEV_COREDUMP. This patch renames the option to ENABLE_DEV_COREDUMP and setting it to 'n' (as in allnconfig or tinyconfig) will effectively disable device coredump. Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Josh Triplett j

Re: [PATCH 2/5] fs/anon_inodes.c: Simplify control flow in anon_inode_getfd()

2014-10-12 Thread Josh Triplett
IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO) ... static inline bool __must_check IS_ERR(__force const void *ptr) { return IS_ERR_VALUE((unsigned long)ptr); } So unless GCC fails to propagate expected-value handling through static inline functions, you should never need to wri

Re: [PATCH 2/5] fs/anon_inodes.c: Simplify control flow in anon_inode_getfd()

2014-10-12 Thread Josh Triplett
__must_check IS_ERR(__force const void *ptr) { return IS_ERR_VALUE((unsigned long)ptr); } So unless GCC fails to propagate expected-value handling through static inline functions, you should never need to write unlikely(IS_ERR(...)). - Josh Triplett -- To unsubscribe from this list: send

[GIT PULL 3.18] tinification fixup for 3.18: fadvise without CONFIG_MMU

2014-10-10 Thread Josh Triplett
The following changes since commit d3ac21cacc24790eb45d735769f35753f5b56ceb: mm: Support compiling out madvise and fadvise (2014-08-17 19:44:24 -0500) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/josh/linux.git tags/tiny/no-advice-fixup-3.18 for

[GIT PULL 3.18] tinification fixup for 3.18: fadvise without CONFIG_MMU

2014-10-10 Thread Josh Triplett
The following changes since commit d3ac21cacc24790eb45d735769f35753f5b56ceb: mm: Support compiling out madvise and fadvise (2014-08-17 19:44:24 -0500) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/josh/linux.git tags/tiny/no-advice-fixup-3.18 for

Re: [Ksummit-discuss] [tpmdd-devel] [TrouSerS-tech] TPM MiniSummit @ LinuxCon Europe

2014-10-08 Thread Josh Triplett
we run out. Whether we add dynamic resource management beyond that to userspace or the kernel is a good question. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [Ksummit-discuss] [tpmdd-devel] [TrouSerS-tech] TPM MiniSummit @ LinuxCon Europe

2014-10-08 Thread Josh Triplett
applications, but we *could* support giving individual TPM resources to individual userspace processes on an exclusive basis, and give an error if we run out. Whether we add dynamic resource management beyond that to userspace or the kernel is a good question. - Josh Triplett -- To unsubscribe from

[GIT PULL 3.18] tinification for 3.18

2014-10-05 Thread Josh Triplett
) Tinification for 3.18 Josh Triplett (10): x86, platform, kconfig: move kvmconfig functionality to a helper x86: Add "make tinyconfig" to configure the tiniest possible kernel x86,

[GIT PULL 3.18] tinification for 3.18

2014-10-05 Thread Josh Triplett
) Tinification for 3.18 Josh Triplett (10): x86, platform, kconfig: move kvmconfig functionality to a helper x86: Add make tinyconfig to configure the tiniest possible kernel x86, boot: Use

Re: [PATCH] rcutorture: Remove obsolete kversion param in kvm.sh

2014-10-04 Thread Josh Triplett
On Sat, Oct 04, 2014 at 01:04:15PM -0400, Pranith Kumar wrote: > Now that we have removed configs based on kernel version, we can also remove > the > kversion parameter in kvm.sh. > > Signed-off-by: Pranith Kumar Reviewed-by: Josh Triplett > .../selftests/rcutorture/bin

Re: [PATCH] rcutorture: Remove obsolete kversion param in kvm.sh

2014-10-04 Thread Josh Triplett
On Sat, Oct 04, 2014 at 01:04:15PM -0400, Pranith Kumar wrote: Now that we have removed configs based on kernel version, we can also remove the kversion parameter in kvm.sh. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com Reviewed-by: Josh Triplett j...@joshtriplett.org .../selftests

[GIT PULL 3.18] tinification for 3.18

2014-10-03 Thread Josh Triplett
Josh Triplett (10): x86, platform, kconfig: move kvmconfig functionality to a helper x86: Add "make tinyconfig" to configure the tiniest possible kernel x86, boot: Use the usual -y -n mechanism for objects in vmlinux

[GIT PULL 3.17] tinification: Kconfig bugfixes for 3.17

2014-10-03 Thread Josh Triplett
han waiting for 3.18. Josh Triplett (2): init/Kconfig: Hide printk log config if CONFIG_PRINTK=n init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu init/Kconfig | 3 +++ 1 file changed, 3 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 2/2] init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu

2014-10-03 Thread Josh Triplett
On Fri, Oct 03, 2014 at 05:00:18PM -0700, Randy Dunlap wrote: > On 10/03/14 16:47, Josh Triplett wrote: > > On Fri, Oct 03, 2014 at 04:36:36PM -0700, Randy Dunlap wrote: > >> On 10/03/14 16:31, Josh Triplett wrote: > >>> commit 03b8c7b623c80af264c4c8d61

Re: [PATCH 2/2] init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu

2014-10-03 Thread Josh Triplett
On Fri, Oct 03, 2014 at 04:36:36PM -0700, Randy Dunlap wrote: > On 10/03/14 16:31, Josh Triplett wrote: > > commit 03b8c7b623c80af264c4c8d6111e5c6289933666 ("futex: Allow > > architectures to skip futex_atomic_cmpxchg_inatomic() test") added the > > HAVE_FUTEX_C

[PATCH 2/2] init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu

2014-10-03 Thread Josh Triplett
self depend on FUTEX. With this change, the subsequent items display as part of the EXPERT menu again; the EMBEDDED menu now appears as the next top-level item in the General Setup menu, which makes General Setup much shorter and more usable. Signed-off-by: Josh Triplett --- Posting for review. I can u

[PATCH 1/2] init/Kconfig: Hide printk log config if CONFIG_PRINTK=n

2014-10-03 Thread Josh Triplett
The buffers sized by CONFIG_LOG_BUF_SHIFT and CONFIG_LOG_CPU_MAX_BUF_SHIFT do not exist if CONFIG_PRINTK=n, so don't ask about their size at all. Signed-off-by: Josh Triplett --- Posting for review. I can upstream this through the tiny tree. init/Kconfig | 2 ++ 1 file changed, 2 insertions

[PATCH 1/2] init/Kconfig: Hide printk log config if CONFIG_PRINTK=n

2014-10-03 Thread Josh Triplett
The buffers sized by CONFIG_LOG_BUF_SHIFT and CONFIG_LOG_CPU_MAX_BUF_SHIFT do not exist if CONFIG_PRINTK=n, so don't ask about their size at all. Signed-off-by: Josh Triplett j...@joshtriplett.org --- Posting for review. I can upstream this through the tiny tree. init/Kconfig | 2 ++ 1 file

[PATCH 2/2] init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu

2014-10-03 Thread Josh Triplett
. With this change, the subsequent items display as part of the EXPERT menu again; the EMBEDDED menu now appears as the next top-level item in the General Setup menu, which makes General Setup much shorter and more usable. Signed-off-by: Josh Triplett j...@joshtriplett.org --- Posting for review. I can upstream

Re: [PATCH 2/2] init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu

2014-10-03 Thread Josh Triplett
On Fri, Oct 03, 2014 at 04:36:36PM -0700, Randy Dunlap wrote: On 10/03/14 16:31, Josh Triplett wrote: commit 03b8c7b623c80af264c4c8d6111e5c6289933666 (futex: Allow architectures to skip futex_atomic_cmpxchg_inatomic() test) added the HAVE_FUTEX_CMPXCHG symbol right below FUTEX. This placed

Re: [PATCH 2/2] init/Kconfig: Fix HAVE_FUTEX_CMPXCHG to not break up the EXPERT menu

2014-10-03 Thread Josh Triplett
On Fri, Oct 03, 2014 at 05:00:18PM -0700, Randy Dunlap wrote: On 10/03/14 16:47, Josh Triplett wrote: On Fri, Oct 03, 2014 at 04:36:36PM -0700, Randy Dunlap wrote: On 10/03/14 16:31, Josh Triplett wrote: commit 03b8c7b623c80af264c4c8d6111e5c6289933666 (futex: Allow architectures to skip

[GIT PULL 3.17] tinification: Kconfig bugfixes for 3.17

2014-10-03 Thread Josh Triplett
menu much more usable. Neither of these fixes changes the resulting built kernel in any way; they just improve the usability of the kconfig General Setup menu. Randy Dunlap suggested them for 3.17 rather than waiting for 3.18. Josh

[GIT PULL 3.18] tinification for 3.18

2014-10-03 Thread Josh Triplett
Josh Triplett (10): x86, platform, kconfig: move kvmconfig functionality to a helper x86: Add make tinyconfig to configure the tiniest possible kernel x86, boot: Use the usual -y -n mechanism for objects in vmlinux x86

Re: [PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock

2014-09-28 Thread Josh Triplett
On Sun, Sep 28, 2014 at 09:26:32PM +0200, Fabian Frederick wrote: > fs/jffs2/summary.c:846:5: warning: context imbalance in > 'jffs2_sum_write_sumnode' - unexpected unlock > > Suggested-by: Brian Norris > Suggested-by: Josh Triplett > Signed-off-by: Fabian Frederick

Re: [PATCH 1/1] jffs2: fix sparse warning: unexpected unlock

2014-09-28 Thread Josh Triplett
ld will actually cover what we want. (I haven't tested it.) > > > > __must_hold is indeed the correct annotation.  (There isn't currently > > anything enforcing that, though.) > > > > - Josh Triplett > > There are 137 __releases && __acquires anno

Re: [PATCH 1/1] jffs2: fix sparse warning: unexpected unlock

2014-09-28 Thread Josh Triplett
want. (I haven't tested it.) __must_hold is indeed the correct annotation.  (There isn't currently anything enforcing that, though.) - Josh Triplett There are 137 __releases __acquires annotated functions in stable. AFAICS those are based on lock held on function entry / lock held

Re: [PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock

2014-09-28 Thread Josh Triplett
On Sun, Sep 28, 2014 at 09:26:32PM +0200, Fabian Frederick wrote: fs/jffs2/summary.c:846:5: warning: context imbalance in 'jffs2_sum_write_sumnode' - unexpected unlock Suggested-by: Brian Norris computersforpe...@gmail.com Suggested-by: Josh Triplett j...@joshtriplett.org Signed-off

Re: [PATCH 0/7] Silence even more W=2 warnings

2014-09-23 Thread Josh Triplett
366:21: warning: shadowed declaration is here > [-Wshadow] > extern struct apic *apic; > ^ > > So gcc complains that an unsigned int shadows a struct apic pointer. Here, I think the right fix involves picking a more descriptive name than "apic" for the g

Re: linux-next: manual merge of the tiny tree with the tip tree

2014-09-23 Thread Josh Triplett
for the next merge window at this point. Thanks for the feedback on process; this is day 1 of having a merge-window-bound tree in -next for the first time. :) - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tiny tree

2014-09-23 Thread Josh Triplett
by commit b37a3fee8450 ("mm: Disable mm/balloon_compaction.c > completely when !CONFIG_VIRTIO_BALLOON"). > > I have reverted that commit for today. Strange. That commit compiled just fine here with several configurations; I'll investigate what's up with ppc64_defconfig. Wi

<    5   6   7   8   9   10   11   12   13   14   >