to 32 [-Wpacked-not-aligned]
> 1041 | struct pmcraid_ioarcb ioarcb;
>
> The inner structure is documented as having 32 byte alignment here,
> but is starts at a 16 byte offset in the outer structure, so it's never
> actually aligned, as the outer structure is also marked 'packed
On Mon, 01 Feb 2021, Rafael J. Wysocki wrote:
> On Mon, Feb 1, 2021 at 7:45 PM Andy Shevchenko
> wrote:
> >
> > On Tue, Jan 26, 2021 at 12:39:59PM +0200, Andy Shevchenko wrote:
> > > On Tue, Jan 26, 2021 at 08:21:01AM +, Lee Jones wrote:
> > > > On
> 6 files changed, 902 deletions(-)
> delete mode 100644 drivers/mfd/intel_msic.c
> delete mode 100644 include/linux/mfd/intel_msic.h
Acked-by: Lee Jones
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
n, to avoid the driver to bail out completely.
>
> Signed-off-by: Andre Przywara
> ---
> drivers/mfd/axp20x.c | 17 +++--
> 1 file changed, 11 insertions(+), 6 deletions(-)
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jone
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_hpt366.c:200: warning: Function parameter or member 'mask'
not described in 'hpt366_filter'
Cc: Jens Axboe
Cc: Andre Hedrick
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_hpt366.c | 1 +
1 file
was for soc_is_65n() instead
Cc: Jens Axboe
Cc: Mark Lord
Cc: ALWAYS copy
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/sata_mv.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 664ef658a955f
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_ali.c:119: warning: Function parameter or member 'mask' not
described in 'ali_20_filter'
Cc: Jens Axboe
Cc: CJ
Cc: Andre Hedrick
Cc: Alan Cox
Cc: Clear Zhang
Cc: linux-...@vger.kernel.org
Cc: and cc
Signed-off-by: Lee
Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_cs5520.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c
index 9052148b306d9..d09d432d3c442 100644
--- a/drivers/ata/pata_cs5520.c
+++ b/drivers/ata
in 'xgene_ahci_handle_broken_edge_irq'
Cc: Jens Axboe
Cc: Loc Ho
Cc: Tuan Phan
Cc: Suman Tripathi
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/ahci_xgene.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
index 16246c843365e
-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_marvell.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c
index b066809ba9a11..361597d14c569 100644
--- a/drivers/ata/pata_marvell.c
+++ b/drivers/ata
in 'optidma_set_mode'
drivers/ata/pata_optidma.c:361: warning: Function parameter or member 'pdev'
not described in 'optiplus_with_udma'
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_optidma.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
/pata_pdc2027x.c:599: warning: expecting prototype for
detect_pll_input_clock(). Prototype was for pdc_detect_pll_input_clock() instead
Cc: Jens Axboe
Cc: Albert Lee
Cc: Andre Hedrick
Cc: Frank Tiernan
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_pdc2027x.c | 10
-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_jmicron.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_jmicron.c b/drivers/ata/pata_jmicron.c
index c3dedd3e71fb7..d1b3ce8958ddc 100644
--- a/drivers/ata/pata_jmicron.c
+++ b/drivers/ata
Cc: Jens Axboe
Cc: ATI Inc
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_atiixp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/pata_atiixp.c b/drivers/ata/pata_atiixp.c
index c68aa3f585f22..d671d33ef2874 100644
--- a/drivers
Signed-off-by: Lee Jones
---
drivers/ata/pata_artop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c
index 02e4fd5e3b934..ad3c5808aaad6 100644
--- a/drivers/ata/pata_artop.c
+++ b/drivers/ata/pata_artop.c
@@ -268,7 +268,7
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_hpt3x2n.c:247: warning: expecting prototype for
hpt3x2n_bmdma_end(). Prototype was for hpt3x2n_bmdma_stop() instead
Cc: Jens Axboe
Cc: Andre Hedrick
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_amd.c:331: warning: expecting prototype for nv_probe_init().
Prototype was for nv_pre_reset() instead
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_amd.c | 2 +-
1 file changed, 1
-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_hpt37x.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_hpt37x.c b/drivers/ata/pata_hpt37x.c
index fad6c6a873130..f242157bc81bb 100644
--- a/drivers/ata/pata_hpt37x.c
+++ b/drivers/ata/pata_hpt37x.c
'
drivers/ata/pata_artop.c:359: warning: Excess function parameter 'ent'
description in 'artop_init_one'
Cc: Jens Axboe
Cc: Andre Hedrick
Cc: Thibaut VARENE
Cc: Alessandro Zummo
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_artop.c | 2 +-
1 file changed, 1 insertion
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/libata-pmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c
index 79f2aeeb482ab..ba7be3f386171 100644
--- a/drivers/ata/libata-pmp.c
+++ b/drivers/ata
() instead
Cc: Jens Axboe
Cc: Tejun Heo
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/libata-sata.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
index c16423e445255..8adeab76dd382 100644
' not described in 'ata_tdev_delete'
drivers/ata/libata-transport.c:640: warning: Excess function parameter 'port'
description in 'ata_tdev_delete'
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/libata-transport.c | 6 +++---
1 file changed, 3 insertions
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
This is set 1 out of 2 sets required.
v2:
- Removed "Ignore -Woverride-init" patches
- Back-filled them with others
Lee Jones (
Signed-off-by: Lee Jones
---
drivers/ata/pata_ali.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
index 0b122f903b8a8..e18aa02f89530 100644
--- a/drivers/ata/pata_ali.c
+++ b/drivers/ata/pata_ali.c
@@ -108,7 +108,7 @@ static
: Function parameter or member 'deadline'
not described in 'nv_pre_reset'
drivers/ata/pata_amd.c:331: warning: expecting prototype for nv_probe_init().
Prototype was for nv_pre_reset() instead
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_amd.c | 4
On Mon, 01 Feb 2021, Arnd Bergmann wrote:
> On Thu, Jan 28, 2021 at 7:32 PM Lee Jones wrote:
> >
> > On Thu, 28 Jan 2021, Christoph Hellwig wrote:
> >
> > > On Thu, Jan 28, 2021 at 06:02:20PM +, Lee Jones wrote:
> > > > Some ATA drivers use the
On Thu, 28 Jan 2021, Christoph Hellwig wrote:
> On Thu, Jan 28, 2021 at 06:02:20PM +0000, Lee Jones wrote:
> > Some ATA drivers use the SCSI host template, a series of interwoven
> > macros, to aid with initialisation. Some of these macros conflict,
> > resultin
in 'xgene_ahci_handle_broken_edge_irq'
Cc: Jens Axboe
Cc: Loc Ho
Cc: Tuan Phan
Cc: Suman Tripathi
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/ahci_xgene.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
index 16246c843365e
initialization for
‘ahci_highbank_platform_sht.sdev_attrs’)
drivers/ata/sata_highbank.c:442:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b
' not
described in 'sata_pmp_write'
drivers/ata/libata-pmp.c:76: warning: Excess function parameter 'r_val'
description in 'sata_pmp_write'
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata
for
‘ahci_dm816_platform_sht.sdev_attrs’)
drivers/ata/ahci_dm816.c:138:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_ali.c:119: warning: Function parameter or member 'mask' not
described in 'ali_20_filter'
Cc: Jens Axboe
Cc: CJ
Cc: Andre Hedrick
Cc: Alan Cox
Cc: Clear Zhang
Cc: linux-...@vger.kernel.org
Cc: and cc
Signed-off-by: Lee
:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index a6755a524efa0..4580a0306bf3d 100644
--- a/drivers/ata
was for soc_is_65n() instead
Cc: Jens Axboe
Cc: Mark Lord
Cc: ALWAYS copy
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/sata_mv.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 664ef658a955f
-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 4542f101042ac..c7460c6b94c1d 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -1,6 +1,7 @@
# SPDX-License
for
‘ahci_platform_sht.sdev_attrs’)
drivers/ata/ahci_brcm.c:414:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index
-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_hpt37x.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_hpt37x.c b/drivers/ata/pata_hpt37x.c
index fad6c6a873130..f242157bc81bb 100644
--- a/drivers/ata/pata_hpt37x.c
+++ b/drivers/ata/pata_hpt37x.c
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_hpt366.c:200: warning: Function parameter or member 'mask'
not described in 'hpt366_filter'
Cc: Jens Axboe
Cc: Andre Hedrick
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_hpt366.c | 1 +
1 file
for
‘ahci_platform_sht.sdev_attrs’)
drivers/ata/ahci_mtk.c:41:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index c7c26a0ef7632
'
drivers/ata/pata_artop.c:359: warning: Excess function parameter 'ent'
description in 'artop_init_one'
Cc: Jens Axboe
Cc: Andre Hedrick
Cc: Thibaut VARENE
Cc: Alessandro Zummo
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_artop.c | 2 +-
1 file changed, 1 insertion
for
‘acard_ahci_sht.sdev_attrs’)
drivers/ata/acard-ahci.c:70:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 79c59550c23a0
Signed-off-by: Lee Jones
---
drivers/ata/pata_ali.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
index 0b122f903b8a8..e18aa02f89530 100644
--- a/drivers/ata/pata_ali.c
+++ b/drivers/ata/pata_ali.c
@@ -108,7 +108,7 @@ static
: Function parameter or member 'deadline'
not described in 'nv_pre_reset'
drivers/ata/pata_amd.c:331: warning: expecting prototype for nv_probe_init().
Prototype was for nv_pre_reset() instead
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/pata_amd.c | 4
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/libata-pmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c
index 79f2aeeb482ab..ba7be3f386171 100644
--- a/drivers/ata/libata-pmp.c
+++ b/drivers/ata
for
‘ahci_platform_sht.sdev_attrs’)
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
This is set 1 out of 3 sets required.
Lee Jones (20):
ata: ahci_dm816: Ignore -Woverride-init
ata: libata-transport: Fix some potential doc
' not described in 'ata_tdev_delete'
drivers/ata/libata-transport.c:640: warning: Excess function parameter 'port'
description in 'ata_tdev_delete'
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/libata-transport.c | 6 +++---
1 file changed, 3 insertions
() instead
Cc: Jens Axboe
Cc: Tejun Heo
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/ata/libata-sata.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
index c16423e445255..8adeab76dd382 100644
On Thu, 28 Jan 2021, Mika Westerberg wrote:
> Hi Lee,
>
> On Wed, Jan 27, 2021 at 11:25:42AM +0000, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly littl
Cc: Michael Jamet
Cc: Mika Westerberg
Cc: Yehezkel Bernat
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
v2: Different approach: actually handle the error.
drivers/thunderbolt/dma_port.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/thunderbolt/dma_port.c b/drivers
On Thu, 28 Jan 2021, Mika Westerberg wrote:
> On Thu, Jan 28, 2021 at 08:23:30AM +0000, Lee Jones wrote:
> > On Wed, 27 Jan 2021, Mika Westerberg wrote:
> >
> > > On Wed, Jan 27, 2021 at 04:13:20PM +, Lee Jones wrote:
> > > > On Wed
On Wed, 27 Jan 2021, Mika Westerberg wrote:
> On Wed, Jan 27, 2021 at 04:13:20PM +0000, Lee Jones wrote:
> > On Wed, 27 Jan 2021, Andy Shevchenko wrote:
> >
> > > On Wednesday, January 27, 2021, Lee Jones wrote:
> > >
> > > > F
mi-pmic.c (100%)
I've already reviewed this:
https://lore.kernel.org/driverdev-devel/20210127110537.GI4903@dell/
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On Wed, 27 Jan 2021, Andy Shevchenko wrote:
> On Wednesday, January 27, 2021, Lee Jones wrote:
>
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/thunderbolt/dma_port.c: In function ‘dma_port_flash_write_block’:
> > drivers/thunderbolt/dma_p
On Wed, 27 Jan 2021, Andy Shevchenko wrote:
> On Wednesday, January 27, 2021, Lee Jones wrote:
>
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/thunderbolt/path.c:476: warning: Function parameter or member
> > 'path' not described in '
: Yehezkel Bernat
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/thunderbolt/dma_port.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/thunderbolt/dma_port.c b/drivers/thunderbolt/dma_port.c
index 847dd07a7b172..5aced91e17dc4 100644
Fixes the following W=1 kernel build warning(s):
drivers/thunderbolt/cap.c:189: warning: Function parameter or member 'sw' not
described in 'tb_switch_find_cap'
Cc: Andreas Noever
Cc: Michael Jamet
Cc: Mika Westerberg
Cc: Yehezkel Bernat
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee
Noever
Cc: Michael Jamet
Cc: Mika Westerberg
Cc: Yehezkel Bernat
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/thunderbolt/path.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thunderbolt/path.c b/drivers/thunderbolt/path.c
index
.org
Cc: b...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/thunderbolt/xdomain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c
index f2d4db1cd84d0..6e8bea6a7d392 100644
--- a/drivers/thunderbolt/xdomain.c
+++ b/drivers/t
-off-by: Lee Jones
---
drivers/thunderbolt/switch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
index ce1b120d1cd46..6a3d5608431f6 100644
--- a/drivers/thunderbolt/switch.c
+++ b/drivers/thunderbolt/switch.c
: Function parameter or member 'sw'
not described in 'tb_sw_set_unplugged'
Cc: Andreas Noever
Cc: Michael Jamet
Cc: Mika Westerberg
Cc: Yehezkel Bernat
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/thunderbolt/switch.c | 12 ++--
1 file changed, 6 insertions(+), 6
in 'tb_tunnel_alloc_dma'
Cc: Andreas Noever
Cc: Michael Jamet
Cc: Mika Westerberg
Cc: Yehezkel Bernat
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/thunderbolt/tunnel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/tunnel.c b/drivers/thunderbolt
Noever
Cc: Michael Jamet
Cc: Mika Westerberg
Cc: Yehezkel Bernat
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/thunderbolt/icm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
index b8c4159bc32d0
: Mika Westerberg
Cc: Yehezkel Bernat
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/thunderbolt/nhi.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
index cfc622da4f832..2ba33b53d4eb1
in 'tb_drom_copy_efi'
drivers/thunderbolt/eeprom.c:526: warning: Function parameter or member 'sw'
not described in 'tb_drom_read'
Cc: Andreas Noever
Cc: Michael Jamet
Cc: Mika Westerberg
Cc: Yehezkel Bernat
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/thunderbolt/eeprom.c | 24
was for tb_handle_event() instead
Cc: Andreas Noever
Cc: Michael Jamet
Cc: Mika Westerberg
Cc: Yehezkel Bernat
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/thunderbolt/tb.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/thunderbolt/tb.c b/drivers
: Mika Westerberg
Cc: Yehezkel Bernat
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/thunderbolt/ctl.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
index bac08b820015d
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Only 1 small set required for Thunderbolt. Pretty good!
Lee Jones (12):
thunderbolt: dma_port: Remove unused variable 'ret'
thunderbolt: cap
mic.c (100%)
Replied to an earlier submission where I was able to reply in-line.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
421_spmi_irq_handler, NULL,
> +IRQF_TRIGGER_LOW | IRQF_SHARED |
> IRQF_NO_SUSPEND,
> +"pmic", pmic);
> + if (ret < 0) {
> + dev_err(dev, "could not claim pmic IRQ: error %d\n", ret);
This is inconsistent with other prints. Better to start with a
capital I think. Also, it should be "PMIC", as it's an abbreviation.
> + goto irq_malloc;
> + }
> +
> + dev_set_drvdata(>dev, pmic);
> +
> + /*
> + * The logic below will rely that the pmic is already stored at
> + * drvdata.
> + */
Which logic?
> + dev_dbg(>dev, "SPMI-PMIC: adding children for %pOF\n",
> + pdev->dev.of_node);
Please remove this.
> + ret = devm_mfd_add_devices(>dev, PLATFORM_DEVID_NONE,
> +hi6421v600_devs, ARRAY_SIZE(hi6421v600_devs),
> +NULL, 0, NULL);
> + if (!ret)
> + return 0;
> +
> + dev_err(dev, "Failed to add child devices: %d\n", ret);
> +
> +irq_malloc:
> + free_irq(pmic->irq, pmic);
Does gpio_to_irq() need freeing?
> + return ret;
> +}
> +
> +static void hi6421_spmi_pmic_remove(struct spmi_device *pdev)
> +{
> + struct hi6421_spmi_pmic *pmic = dev_get_drvdata(>dev);
> +
> + free_irq(pmic->irq, pmic);
> +}
> +
> +static const struct of_device_id pmic_spmi_id_table[] = {
> + { .compatible = "hisilicon,hi6421-spmi" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, pmic_spmi_id_table);
> +
> +static struct spmi_driver hi6421_spmi_pmic_driver = {
> + .driver = {
> + .name = "hi6421-spmi-pmic",
Odd spacing. Just use one ' ' please.
> + .of_match_table = pmic_spmi_id_table,
> + },
> + .probe = hi6421_spmi_pmic_probe,
> + .remove = hi6421_spmi_pmic_remove,
> +};
> +module_spmi_driver(hi6421_spmi_pmic_driver);
> +
> +MODULE_DESCRIPTION("HiSilicon Hi6421v600 SPMI PMIC driver");
> +MODULE_LICENSE("GPL v2");
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
have expected the whole set to be merged as a set into a
single tree, placed on an immutable branch and a pull-request to be
sent out for the other maintainers to pull from (if they so wished).
This would ensure development could continue on any/all of the
affected drivers/files.
If it's n
LDO2,
> MAX8997_LDO3,
> @@ -207,4 +207,4 @@ struct max8997_platform_data {
> struct max8997_led_platform_data *led_pdata;
> };
>
> -#endif /* __LINUX_MFD_MAX8998_H */
> +#endif /* __LINUX_MFD_MAX8997_H */
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On Tue, 26 Jan 2021, Maxime Ripard wrote:
> On Tue, Jan 26, 2021 at 12:45:31PM +0000, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/clk/sunxi/clk-sun6i-ar100.c:26: warning: Function parameter or
> > member 'req' not described
On Mon, 25 Jan 2021, Matti Vaittinen wrote:
> Hello Lee,
>
> Thanks again for the review!
>
> On Mon, 2021-01-25 at 14:10 +, Lee Jones wrote:
> > On Tue, 19 Jan 2021, Matti Vaittinen wrote:
> >
> > > Add core support for ROHM BD71815 Power Managemen
pe for an integration to the mainline.
>
> Because we are on a vendor kernel we were not able to test this patch
> on the current mainline kernel. Though, we tested a (very similar)
> patch on our (close to mainline) Linux 4.14 and 5.4 vendor kernels.
This is the 3rd cover-letter I
On Mon, 25 Jan 2021, Cristian Ciocaltea wrote:
> Hi Lee,
>
> On Mon, Jan 25, 2021 at 02:25:58PM +0000, Lee Jones wrote:
> > On Wed, 20 Jan 2021, Cristian Ciocaltea wrote:
> >
> > > Add initial support for the Actions Semi ATC260x PMICs which integrates
> > &g
ux-arm-ker...@lists.infradead.org
Signed-off-by: Lee Jones
---
drivers/clk/zynq/pll.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/zynq/pll.c b/drivers/clk/zynq/pll.c
index dcb2037a95964..54f4184de89af 100644
--- a/drivers/clk/zynq/pll.c
+++ b/driver
'
drivers/clk/ti/clkt_dpll.c:284: warning: Excess function parameter 'clk'
description in 'omap2_dpll_round_rate'
Cc: Tero Kristo
Cc: Michael Turquette
Cc: Stephen Boyd
Cc: Richard Woodruff
Cc: linux-o...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/clk/ti
in 'sun9i_a80_get_apb1_factors'
Cc: "Emilio López"
Cc: Michael Turquette
Cc: Stephen Boyd
Cc: Maxime Ripard
Cc: Chen-Yu Tsai
Cc: Jernej Skrabec
Cc: linux-...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lee Jones
---
drivers/clk/sunxi/clk-sun9i-core.c | 8 --
Zabel
Cc: linux-...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lee Jones
---
drivers/clk/sunxi/clk-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/sunxi/clk-usb.c b/drivers/clk/sunxi/clk-usb.c
index d78a78495bede..5460218f34
'
description in 'omap3_clkoutx2_recalc'
Cc: Tero Kristo
Cc: Michael Turquette
Cc: Stephen Boyd
Cc: linux-o...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/clk/ti/dpll3xxx.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git
Turquette
Cc: Stephen Boyd
Cc: Thierry Reding
Cc: Jonathan Hunter
Cc: linux-...@vger.kernel.org
Cc: linux-te...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/clk/tegra/clk-tegra30.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/clk/tegra/clk-tegra30.c b
: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/clk/ti/dpll44xx.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/ti/dpll44xx.c b/drivers/clk/ti/dpll44xx.c
index 89c3ed1a24b82..3fc2cab69a3fe 100644
--- a/drivers/clk/ti/dpll44xx.c
+++ b/drivers
Cc: linux-...@vger.kernel.org
Cc: linux-te...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/clk/tegra/cvb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/tegra/cvb.c b/drivers/clk/tegra/cvb.c
index 21115c4e5d3a1..a7fdc7622913c 100644
--- a/drivers/clk/tegra/cvb.c
+++ b
-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/clk/qcom/clk-rpm.c | 63 --
1 file changed, 63 deletions(-)
diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c
index f71d228fd6bd5..a18811c380187 100644
--- a/drivers/clk/qcom/clk-rpm.c
+++ b
-variable=]
Cc: Andy Gross
Cc: Bjorn Andersson
Cc: Michael Turquette
Cc: Stephen Boyd
Cc: linux-arm-...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/clk/qcom/mmcc-msm8974.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/clk/qcom
: Stephen Boyd
Cc: Loc Ho
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/clk/clk-xgene.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/clk-xgene.c b/drivers/clk/clk-xgene.c
index 3fd53057c01fe..857217cbcef87 100644
--- a/drivers/clk/clk
Maimon
Cc: Tali Perry
Cc: Patrick Venture
Cc: Nancy Yuen
Cc: Benjamin Fair
Cc: Michael Turquette
Cc: Stephen Boyd
Cc: Nuvoton Technologies
Cc: open...@lists.ozlabs.org
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/clk/clk-npcm7xx.c | 108
]
Cc: Viresh Kumar
Cc: Shiraz Hashim
Cc: Russell King
Cc: Rajeev Kumar
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lee Jones
---
arch/arm/mach-spear/generic.h | 12
arch/arm/mach-spear/spear13xx.c | 1 +
drivers/clk/spear/spear1310_clock.c | 1 +
drivers
-...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/clk/renesas/renesas-cpg-mssr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c
b/drivers/clk/renesas/renesas-cpg-mssr.c
index 1c3215dc4877c..bffbc3d2faf5f
ej Skrabec
Cc: Boris BREZILLON
Cc: linux-...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lee Jones
---
drivers/clk/sunxi/clk-sun6i-ar100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/sunxi/clk-sun6i-ar100.c
b/drivers/clk/sunxi/clk-s
...@lists.infradead.org
Signed-off-by: Lee Jones
---
drivers/clk/zynqmp/divider.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c
index 66da02b83d393..e9bf7958b8218 100644
--- a/drivers/clk/zynqmp/divider.c
+++ b/drivers/clk/zynqmp
Fatoum
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lee Jones
---
arch/arm/mach-imx/common.h | 1 -
arch/arm/mach-imx/cpuidle-imx6sl.c | 1 +
arch/arm/mach-imx/pm-imx6.c| 1 +
drivers/clk/imx/clk-imx6sl.c | 1 +
include/linux/clk/imx.h| 15
in 'hfi1_format_hwerrors'
drivers/infiniband/hw/hfi1/intr.c:115: warning: Function parameter or member
'msgl' not described in 'hfi1_format_hwerrors'
Cc: Mike Marciniszyn
Cc: Dennis Dalessandro
Cc: Doug Ledford
Cc: Jason Gunthorpe
Cc: linux-r...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers
Signed-off-by: Lee Jones
---
drivers/infiniband/hw/hfi1/user_exp_rcv.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/hw/hfi1/user_exp_rcv.c
b/drivers/infiniband/hw/hfi1/user_exp_rcv.c
index b94fc7fd75a96..58dcab2679d9d 100644
--- a/drivers
-by: Lee Jones
---
drivers/infiniband/hw/hfi1/pio_copy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/hfi1/pio_copy.c
b/drivers/infiniband/hw/hfi1/pio_copy.c
index 4a4ec23978579..14bfd8287f4ae 100644
--- a/drivers/infiniband/hw/hfi1/pio_copy.c
+++ b/drivers/infiniband/hw
parameter or member
'ps' not described in 'get_send_routine'
Cc: Mike Marciniszyn
Cc: Dennis Dalessandro
Cc: Doug Ledford
Cc: Jason Gunthorpe
Cc: linux-r...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/infiniband/hw/hfi1/verbs.c | 6 +++---
1 file changed, 3 insertions(+), 3
: Stephen Boyd
Cc: linux-arm-...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/clk/qcom/gcc-ipq4019.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/qcom/gcc-ipq4019.c b/drivers/clk/qcom/gcc-ipq4019.c
index ef5137fd50f3f
function parameter 'qp'
description in 'hfi1_ud_rcv'
Cc: Mike Marciniszyn
Cc: Dennis Dalessandro
Cc: Doug Ledford
Cc: Jason Gunthorpe
Cc: linux-r...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/infiniband/hw/hfi1/ud.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff
'
drivers/infiniband/hw/hfi1/rc.c:1388: warning: Excess function parameter 'qp'
description in 'hfi1_send_rc_ack'
Cc: Mike Marciniszyn
Cc: Dennis Dalessandro
Cc: Doug Ledford
Cc: Jason Gunthorpe
Cc: linux-r...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/infiniband/hw/hfi1/rc.c | 3
801 - 900 of 24015 matches
Mail list logo