Re: [PATCH v2] vhost/vsock: specify module version

2024-10-03 Thread Lucas De Marchi
On Thu, Oct 03, 2024 at 12:48:22PM -0700, Luis Chamberlain wrote: + linux-modu...@vger.kernel.org + Lucas On Mon, Sep 30, 2024 at 07:03:52PM +0200, Aleksandr Mikhalitsyn wrote: On Mon, Sep 30, 2024 at 5:43 PM Stefano Garzarella wrote: > > Hi Aleksandr, > > On Mon, Sep 30, 2024 a

Re: [PATCH 0/2] kmod /usr support

2024-08-21 Thread Lucas De Marchi
On Tue, Dec 19, 2023 at 05:37:31PM GMT, Masahiro Yamada wrote: On Thu, Dec 7, 2023 at 3:37 AM Lucas De Marchi wrote: On Fri, Nov 10, 2023 at 01:13:53PM +0100, Michal Suchanek wrote: >Hello, > >This is resend of the last patch in the series that adds prefix support >to kernel mod

Re: [PATCH 0/2] kmod /usr support

2024-08-21 Thread Lucas De Marchi
On Wed, Aug 21, 2024 at 10:58:43AM GMT, Nathan Chancellor wrote: Did this conversation go anywhere? After the upgrade to kmod 33 in Arch no, it stalled, thanks for reminding me. I will follow up on it. Lucas De Marchi

Re: [PATCH] module: Add hard dependencies as syntactic sugar

2024-07-25 Thread Lucas De Marchi
On Thu, Jul 25, 2024 at 04:39:40PM GMT, Steven Price wrote: On 25/07/2024 15:29, Lucas De Marchi wrote: On Thu, Jul 25, 2024 at 01:37:46PM GMT, Dragan Simic wrote: Panfrost and Lima DRM drivers use devfreq to perform DVFS, which is supported on the associated platforms, while using

Re: [PATCH] module: Add hard dependencies as syntactic sugar

2024-07-25 Thread Lucas De Marchi
softdep") could indeed be solved with a weakdep, so I'm not sure why you'd want to alias it as a "hard dep". Lucas De Marchi sugar, currently implemented as an alias for MODULE_WEAKDEP, so the actual hard module dependencies can be expressed properly, and possibly handled d

Re: [PATCH] lib/test_kmod: add missing MODULE_DESCRIPTION() macro

2024-06-14 Thread Lucas De Marchi
On Fri, May 31, 2024 at 05:23:09PM GMT, Jeff Johnson wrote: make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_kmod.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson Reviewed-by: Lucas D

Re: Current status and possible improvements in CONFIG_MODULE_FORCE_UNLOAD

2024-06-14 Thread Lucas De Marchi
heir driver and start sending the issues to their side. Lucas De Marchi Regards Aditya

Re: [PATCH v3] module: create weak dependecies

2024-05-14 Thread Lucas De Marchi
new enough. If it isn't, depmod will have the same behavior as always (keeping backward compatibility) and the information for the 'weak' dependency will not be provided. Signed-off-by: Jose Ignacio Tornos Martinez Reviewed-by: Lucas De Marchi thanks Lucas De Marchi --- V2

Re: [PATCH v2] module: create weak dependecies

2024-05-09 Thread Lucas De Marchi
ux/module.h @@ -173,6 +173,11 @@ extern void cleanup_module(void); */ #define MODULE_SOFTDEP(_softdep) MODULE_INFO(softdep, _softdep) +/* Weak module dependencies. See man modprobe.d for details. Documentation/process/coding-style.rst section 8 says to balance the /* and */, but up to Luis what h

Re: [PATCH 0/2] kmod /usr support

2023-12-06 Thread Lucas De Marchi
applied, thanks Lucas De Marchi

Re: [PATCH] kmod: Add FIPS 202 SHA-3 support

2023-12-06 Thread Lucas De Marchi
case NID_sha3_512: + return PKEY_HASH_SHA3_512; with your other patch, libkmod: remove pkcs7 obj_to_hash_algo(), this hunk is not needed anymore. Do you want to send a new version of this patch? thanks Lucas De Marchi default: return -1; } -- 2.34.1

Re: [PATCH kmod] libkmod: remove pkcs7 obj_to_hash_algo()

2023-11-07 Thread Lucas De Marchi
openssl and kernel know about. For example SHA3 are being added for v6.7 and with this patch are automatically supported. Signed-off-by: Dimitri John Ledkov Applied, thanks Lucas De Marchi

Re: [PATCH kmod v5 5/5] libkmod, depmod, modprobe: Make directory for kernel modules configurable

2023-10-17 Thread Lucas De Marchi
/mod-loop-g.ko"]="mod-loop-g.ko" + ["test-depmod/detect-loop$MODULE_DIRECTORY/4.4.4/kernel/mod-loop-h.ko"]="mod-loop-h.ko" + ["test-depmod/detect-loop$MODULE_DIRECTORY/4.4.4/kernel/mod-loop-i.ko"]="mod-loop-i.ko" + ["test-depm

Re: [PATCH kmod v5 0/5] kmod /usr support

2023-10-17 Thread Lucas De Marchi
g the preferred solution? Lucas De Marchi

[ANNOUNCE] kmod 31

2023-09-29 Thread Lucas De Marchi
testsuite: fix override of `stat` on 32-bit architectures Lucas De Marchi (8): testsuite: Move setup-rootfs logic from Makefile to script testsuite: Handle different sysconfdir libkmod: Do not inititialize file->memory on open libkmod: Extract finit_module vs init

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-20 Thread Lucas Stach
Am Dienstag, dem 20.04.2021 um 13:47 + schrieb Robin Gong: > On 2021/04/19 17:46 Lucas Stach wrote: > > Am Montag, dem 19.04.2021 um 07:17 + schrieb Robin Gong: > > > Hi Lucas, > > > > > > On 2021/04/14 Lucas Stach wrote: > > > > Hi Robin,

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-19 Thread Lucas Stach
Am Montag, dem 19.04.2021 um 07:17 + schrieb Robin Gong: > Hi Lucas, > > On 2021/04/14 Lucas Stach wrote: > > Hi Robin, > > > > Am Mittwoch, dem 14.04.2021 um 14:33 + schrieb Robin Gong: > > > On 2020/05/20 17:43 Lucas Stach wrote: > > &g

[PATCH v2 2/2] staging: iio: cdc: ad7746: use dt for capacitive channel setup.

2021-04-18 Thread Lucas Stankus
ff-by: Lucas Stankus --- Changes in v2: Previously this change set was composed of two patches, but it lead to regressions between the two. Merging them avoids the unwanted behaviour without having to deal with the special cases. drivers/staging/iio/cdc/ad7746.c

[PATCH v2 1/2] dt-bindings: staging: iio: cdc: ad7746: add binding documentation for AD7746

2021-04-18 Thread Lucas Stankus
Add device tree binding documentation for AD7746 cdc in YAML format. Signed-off-by: Lucas Stankus --- A minor note about the adi,excitation-vdd-permille property. Jonathan suggested the name to be adi,excitation-vdd-milicent, but I was unsure of the milicent naming. With a quick search I found

[PATCH v2 0/2] staging: iio: cdc: ad7746: add dt properties for capacitive channel setup

2021-04-18 Thread Lucas Stankus
two patches to avoid special handling of remaining platform_data properties. Lucas Stankus (2): dt-bindings: staging: iio: cdc: ad7746: add binding documentation for AD7746 staging: iio: cdc: ad7746: use dt for capacitive channel setup. .../bindings/iio/cdc/adi,ad7746.yaml |

Re: [PATCH v9 03/13] media: hantro: Use syscon instead of 'ctrl' register

2021-04-16 Thread Lucas Stach
Am Freitag, dem 16.04.2021 um 15:08 +0200 schrieb Benjamin Gaignard: > Le 16/04/2021 à 12:54, Lucas Stach a écrit : > > Am Mittwoch, dem 07.04.2021 um 09:35 +0200 schrieb Benjamin Gaignard: > > > In order to be able to share the control hardware block between > > >

Re: [PATCH v9 03/13] media: hantro: Use syscon instead of 'ctrl' register

2021-04-16 Thread Lucas Stach
gn the i.MX8MQ VPU blkctl with what we are planning to do on the later chip generations. CC'ing Jacky Bai and Peng Fan from NXP, as they were going to give this virtual power domain thing a shot. Regards, Lucas > Signed-off-by: Benjamin Gaignard > Reviewed-by: Philipp Zabel >

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-14 Thread Lucas Stach
Hi Robin, Am Mittwoch, dem 14.04.2021 um 14:33 + schrieb Robin Gong: > On 2020/05/20 17:43 Lucas Stach wrote: > > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > > Hi > > > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach > >

Re: [PATCH v2 0/7] remove different PHY fixups

2021-04-13 Thread Lucas Stach
Hi Russell, sorry for the noise of this arriving in your inbox twice. Apparently I messed up and replied in private in my last mail. Am Dienstag, dem 13.04.2021 um 11:51 +0100 schrieb Russell King - ARM Linux admin: > On Tue, Apr 13, 2021 at 12:00:45PM +0200, Lucas Stach wrote: > > I a

Re: [PATCH v2 0/7] remove different PHY fixups

2021-04-13 Thread Lucas Stach
ke such a case is to apply this series and look for any fallout. So for what it is worth: Acked-by: Lucas Stach > regards, > Oleksij > > Oleksij Rempel (7): >   ARM: imx6q: remove PHY fixup for KSZ9031 >   ARM: imx6q: remove TX clock delay of ar8031_phy_fixup() >   ARM:

[PATCH 3/3] staging: iio: cdc: ad7746: use dt binding to set the excitation level

2021-04-09 Thread Lucas Stankus
Set device excitation level using properties from device tree binding instead of using platform_data. As this replaces the last instance where the platform_data struct was used, remove ad7746.h header file since it's no longer needed. Signed-off-by: Lucas Stankus --- drivers/staging/ii

[PATCH 1/3] dt-bindings: staging: iio: cdc: ad7746: add binding documentation for AD7746

2021-04-09 Thread Lucas Stankus
Add device tree binding documentation for AD7746 cdc in YAML format. Signed-off-by: Lucas Stankus --- .../bindings/iio/cdc/adi,ad7746.yaml | 79 +++ 1 file changed, 79 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/cdc/adi,ad7746.yaml diff

[PATCH 2/3] staging: iio: cdc: ad7746: use dt bindings to set the EXCx pins output

2021-04-09 Thread Lucas Stankus
Ditch platform_data fields in favor of device tree properties for configuring EXCA and EXCB output. This also removes the fields from the platform_data struct, since they're not used anymore. Signed-off-by: Lucas Stankus --- drivers/staging/iio/cdc/ad7746.c

[PATCH 0/3] staging: iio: cdc: ad7746: remove platform_data in favor of device tree bindings

2021-04-09 Thread Lucas Stankus
entirely. Lucas Stankus (3): dt-bindings: staging: iio: cdc: ad7746: add binding documentation for AD7746 staging: iio: cdc: ad7746: use dt bindings to set the EXCx pins output staging: iio: cdc: ad7746: use dt binding to set the excitation level .../bindings/iio/cdc/adi,ad7746.yaml

Re: [PATCH v3] drivers: introduce and use WANT_DMA_CMA for soft dependencies on DMA_CMA

2021-04-09 Thread Lucas Stach
to a soft dependency. Hm, to me this sounds much like the reasoning for the etnaviv dependency. There is no actual build dependency, as the allocations are done through the DMA API, but for the allocations to succeed you most likely want CMA to be enabled. But that's just an observation from the

Re: [PATCH v1 0/7] imx-gpcv2 improvements

2021-04-07 Thread Lucas Stach
Hi Adrien, I feel like I already mentioned to you some time ago that there is already a much more complete patch series to add this functionality on the list [1]. If you want this functionality to go upstream, please help test and extend this patch series. Regards, Lucas [1] https

Re: [PATCH v4 1/2] dt-bindings: imx6q-pcie: add one regulator used to power up pcie phy

2021-03-29 Thread Lucas Stach
_BYPASS bits of GPR registers should be cleared from default > value 1b'1 to 1b'0. Thus, the internal 3v3 to 1v8 translator would be > turned on. > > Signed-off-by: Richard Zhu Reviewed-by: Lucas Stach > --- >  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt

[PATCH 3/3] iio: adc: ad7923: register device with devm_iio_device_register

2021-03-28 Thread Lucas Stankus
Registers the device using the devm variant. This is the final step of converting the ad7923 to only use devm routines, meaning that the ad7923_remove() function is no longer needed to release resources on device detach. Signed-off-by: Lucas Stankus --- drivers/iio/adc/ad7923.c | 12

[PATCH 2/3] iio: adc: ad7923: use device-managed function for triggered buffer

2021-03-28 Thread Lucas Stankus
Converts the iio_triggered_buffer_setup() call to its device-managed counterpart. With this, the error handling routine in the ad7923_probe() function becomes unnecessary as well as the iio_triggered_buffer_cleanup() call. Signed-off-by: Lucas Stankus --- drivers/iio/adc/ad7923.c | 15

[PATCH 1/3] iio: adc: ad7923: use devm_add_action_or_reset for regulator disable

2021-03-28 Thread Lucas Stankus
Adds a device-managed action to handle disabling the driver's regulator on device detach. This slightly simplifies deinitialization and enables further conversion of the driver to device-managed routines without breaking the init order. Signed-off-by: Lucas Stankus --- drivers/iio/adc/ad7

[PATCH 0/3] iio: adc: ad7923: convert driver resources routines to device-managed counterparts

2021-03-28 Thread Lucas Stankus
was no longer necessary and could be entirely removed from the driver. Lucas Stankus (3): iio: adc: ad7923: use devm_add_action_or_reset for regulator disable iio: adc: ad7923: use device-managed function for triggered buffer iio: adc: ad7923: register device with devm_iio_device_register

Re: [PATCH v3 3/3] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3

2021-03-26 Thread Lucas Stach
VREG_BYPASS bits of GPR registers should be cleared from default > value 1b'1 to 1b'0. Thus, the internal 3v3 to 1v8 translator would be > turned on. > > Signed-off-by: Richard Zhu Reviewed-by: Lucas Stach > --- >  drivers/pci/controller/dwc/pci-imx6.c | 20 ++

Re: [PATCH v3 2/3] arm64: dts: imx8mq-evk: add one regulator used to power up pcie phy

2021-03-26 Thread Lucas Stach
VREG_BYPASS bits of GPR registers should be cleared from default > value 1b'1 to 1b'0. Thus, the internal 3v3 to 1v8 translator would be > turned on. > > Signed-off-by: Richard Zhu Reviewed-by: Lucas Stach I guess you need to split this patch out of the series and post it

Re: [PATCH v3 1/3] dt-bindings: imx6q-pcie: add one regulator used to power up pcie phy

2021-03-26 Thread Lucas Stach
y the regulator in charge of VPH one of the three > + PCIe PHY powers. This regulator can be supplied by both 1.8v and 3.3v > voltage > + supplies. Might be used to distinguish different HW board designs. Please just get rid of the last sentence. All DT properties are used in one way or the other to distinguish different HW designs, so no need to mention this. Regards, Lucas

Re: [PATCH v2 3/3] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3

2021-03-24 Thread Lucas Stach
00) > + regmap_update_bits(imx6_pcie->iomuxc_gpr, > +imx6_pcie_grp_offset(imx6_pcie), > +IMX8MQ_GPR_PCIE_VREG_BYPASS, > +0); ...if you just fo

Re: [PATCH v2 1/3] dt-bindings: imx6q-pcie: add one regulator used to power up pcie phy

2021-03-24 Thread Lucas Stach
t I can see that there are actually 3 supplies (VPH, VP, VPTX) going into the PCIe PHY, so "regulator in charge of PCIe PHY power" doesn't seem like a very accurate description. Regards, Lucas

Re: Re: [PATCH 1/3] dt-bindings: imx6q-pcie: specify the imx8mq pcie phy voltage

2021-03-22 Thread Lucas Stach
Hi Richard, Am Montag, dem 22.03.2021 um 09:06 + schrieb Richard Zhu: > > -Original Message- > > From: Lucas Stach > > Sent: Friday, March 19, 2021 5:49 PM > > To: Richard Zhu ; andrew.smir...@gmail.com; > > shawn...@kernel.org; k...@linux.com

Re: [PATCH 1/3] dt-bindings: imx6q-pcie: specify the imx8mq pcie phy voltage

2021-03-19 Thread Lucas Stach
f we need to know the voltage of PCIE_VPH, we should really add the VPH regulator as a supply to the PCIe controller node, then work out the voltage the usual way by using the Linux regulator API. Regards, Lucas

[PATCH v3] kunit: Match parenthesis alignment to improve code readability

2021-03-12 Thread Lucas Stankus
Tidy up code by fixing the following checkpatch warnings: CHECK: Alignment should match open parenthesis CHECK: Lines should not end with a '(' Signed-off-by: Lucas Stankus Reviewed-by: Brendan Higgins --- Changelog v2 -> v3: Reword subject line lib/kunit/

[PATCH v3 02/15] ASoC: cs42l42: Fix channel width support

2021-03-06 Thread Lucas Tanure
Remove the hard coded 32 bits width and replace with the correct width calculated by params_width. Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 47 ++ sound/soc/codecs/cs42l42.h | 1

[PATCH v3 08/15] ASoC: cs42l42: Provide finer control on playback path

2021-03-06 Thread Lucas Tanure
Removing cs42l42_hpdrv_evt that enables the entire chain and replace by a set of widgets that can better define the codec Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 65 +- sound/soc

[PATCH v3 12/15] ASoC: cs42l42: Use bclk from hw_params if set_sysclk was not called

2021-03-06 Thread Lucas Tanure
Add support for reading the source clock from snd_soc_params_to_bclk so the machine driver is not required to call cs42l42_set_sysclk Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 17 + sound/soc/codecs

[PATCH v3 10/15] ASoC: cs42l42: Add Capture Support

2021-03-06 Thread Lucas Tanure
Add support for capture path on headseat pins Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 39 ++ sound/soc/codecs/cs42l42.h | 12 2 files changed, 51 insertions(+) diff

[PATCH v3 03/15] ASoC: cs42l42: Fix mixer volume control

2021-03-06 Thread Lucas Tanure
The minimum value is 0x3f (-63dB), which also is mute Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs

[PATCH v3 09/15] ASoC: cs42l42: Set clock source for both ways of stream

2021-03-06 Thread Lucas Tanure
Move the enable/disable of clocks to cs42l42_mute_stream so the record path also get clocks. Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - Add missing cs42l42_private struct pointer sound/soc/codecs/cs42l42.c | 86 +- sound

[PATCH v3 04/15] ASoC: cs42l42: Don't enable/disable regulator at Bias Level

2021-03-06 Thread Lucas Tanure
dev_pm_ops already enable/disable the codec if not in use Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 38 -- 1 file changed, 38 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b

[PATCH v3 07/15] ASoC: cs42l42: Disable regulators if probe fails

2021-03-06 Thread Lucas Tanure
In case of cs42l42_i2c_probe() fail, the regulators were left enabled. Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c

[PATCH v3 06/15] ASoC: cs42l42: Remove power if the driver is being removed

2021-03-06 Thread Lucas Tanure
Ensure the power supplies are turned off when removing the driver Signed-off-by: Lucas Tanure --- Changes in v3: - Free IRQ before pm_suspend Changes in v2: - Use PM functions to shutdown the codec - Disable IRQ before pm_suspend sound/soc/codecs/cs42l42.c | 6 -- 1 file changed, 4

[PATCH v3 05/15] ASoC: cs42l42: Always wait at least 3ms after reset

2021-03-06 Thread Lucas Tanure
This delay is part of the power-up sequence defined in the datasheet. A runtime_resume is a power-up so must also include the delay. Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 3 ++- sound/soc/codecs/cs42l42.h | 1 + 2

[PATCH v3 13/15] ASoC: cs42l42: Wait at least 150us after writing SCLK_PRESENT

2021-03-06 Thread Lucas Tanure
Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - struct cs42l42_private add by this patch was wrong and moved to the correct patch - Lucas signed-off added sound/soc/codecs/cs42l42.c | 27 ++- sound/soc/codecs/cs42l42.h | 1 + 2 files changed

[PATCH v3 14/15] ASoC: cs42l42: Only start PLL if it is needed

2021-03-06 Thread Lucas Tanure
From: Richard Fitzgerald The PLL is only needed for sclk < 11289600 Hz and cs42l42_pll_config() will not configure it for higher rates. So it must only be enabled when it is needed. Signed-off-by: Richard Fitzgerald Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in

[PATCH v3 15/15] ASoC: cs42l42: Wait for PLL to lock before switching to it

2021-03-06 Thread Lucas Tanure
From: Richard Fitzgerald The PLL should have locked before using it to supply MCLK. Signed-off-by: Richard Fitzgerald Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - Lucas signed-off added sound/soc/codecs/cs42l42.c | 12 +++- sound/soc/codecs/cs42l42.h

[PATCH v3 11/15] ASoC: cs42l42: Report jack and button detection

2021-03-06 Thread Lucas Tanure
Report the Jack events to the user space through ALSA. Also moves request_threaded_irq() to component_probe so it don't get interrupts before the initialization the struct snd_soc_jack. Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - Don't move the c

[PATCH v3 00/15] Report jack and button detection + Capture Support

2021-03-06 Thread Lucas Tanure
Hi All, Here is a patch series for reporting to user space jack and button events and add the support for Capture. With some cleanups and fixes along the way. Regards, Lucas Tanure Lucas Tanure (12): ASoC: cs42l42: Fix Bitclock polarity inversion ASoC: cs42l42: Fix channel width support

[PATCH v3 01/15] ASoC: cs42l42: Fix Bitclock polarity inversion

2021-03-06 Thread Lucas Tanure
The driver was setting bit clock polarity opposite to intended polarity. Also simplify the code by grouping ADC and DAC clock configurations into a single field. Signed-off-by: Lucas Tanure --- Changes in v3: - No changes Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 20

[PATCH v2 07/15] ASoC: cs42l42: Disable regulators if probe fails

2021-03-05 Thread Lucas Tanure
In case of cs42l42_i2c_probe() fail, the regulators were left enabled. Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c

[PATCH v2 00/15] Report jack and button detection + Capture Support

2021-03-05 Thread Lucas Tanure
Hi All, Here is a patch series for reporting to user space jack and button events and add the support for Capture. With some cleanups and fixes along the way. Regards, Lucas Tanure Lucas Tanure (12): ASoC: cs42l42: Fix Bitclock polarity inversion ASoC: cs42l42: Fix channel width support

[PATCH v2 13/15] ASoC: cs42l42: Wait at least 150us after writing SCLK_PRESENT

2021-03-05 Thread Lucas Tanure
Signed-off-by: Lucas Tanure --- Changes in v2: - struct cs42l42_private add by this patch was wrong and moved to the correct patch - Lucas signed-off added sound/soc/codecs/cs42l42.c | 27 ++- sound/soc/codecs/cs42l42.h | 1 + 2 files changed, 23 insertions(+), 5 deletions

[PATCH v2 01/15] ASoC: cs42l42: Fix Bitclock polarity inversion

2021-03-05 Thread Lucas Tanure
The driver was setting bit clock polarity opposite to intended polarity. Also simplify the code by grouping ADC and DAC clock configurations into a single field. Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 20 sound/soc/codecs

[PATCH v2 11/15] ASoC: cs42l42: Report jack and button detection

2021-03-05 Thread Lucas Tanure
Report the Jack events to the user space through ALSA. Also moves request_threaded_irq() to component_probe so it don't get interrupts before the initialization the struct snd_soc_jack. Signed-off-by: Lucas Tanure --- Changes in v2: - Don't move the code around - Removed rename

[PATCH v2 09/15] ASoC: cs42l42: Set clock source for both ways of stream

2021-03-05 Thread Lucas Tanure
Move the enable/disable of clocks to cs42l42_mute_stream so the record path also get clocks. Signed-off-by: Lucas Tanure --- Changes in v2: - Add missing cs42l42_private struct pointer sound/soc/codecs/cs42l42.c | 86 +- sound/soc/codecs/cs42l42.h | 1 + 2

[PATCH v2 08/15] ASoC: cs42l42: Provide finer control on playback path

2021-03-05 Thread Lucas Tanure
Removing cs42l42_hpdrv_evt that enables the entire chain and replace by a set of widgets that can better define the codec Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 65 +- sound/soc/codecs/cs42l42.h | 8 ++--- 2

[PATCH v2 04/15] ASoC: cs42l42: Don't enable/disable regulator at Bias Level

2021-03-05 Thread Lucas Tanure
dev_pm_ops already enable/disable the codec if not in use Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 38 -- 1 file changed, 38 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c

[PATCH v2 10/15] ASoC: cs42l42: Add Capture Support

2021-03-05 Thread Lucas Tanure
Add support for capture path on headseat pins Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 39 ++ sound/soc/codecs/cs42l42.h | 12 2 files changed, 51 insertions(+) diff --git a/sound/soc/codecs

[PATCH v2 15/15] ASoC: cs42l42: Wait for PLL to lock before switching to it

2021-03-05 Thread Lucas Tanure
From: Richard Fitzgerald The PLL should have locked before using it to supply MCLK. Signed-off-by: Richard Fitzgerald Signed-off-by: Lucas Tanure --- Changes in v2: - Lucas signed-off added sound/soc/codecs/cs42l42.c | 12 +++- sound/soc/codecs/cs42l42.h | 2 ++ 2 files changed, 13

[PATCH v2 12/15] ASoC: cs42l42: Use bclk from hw_params if set_sysclk was not called

2021-03-05 Thread Lucas Tanure
Add support for reading the source clock from snd_soc_params_to_bclk so the machine driver is not required to call cs42l42_set_sysclk Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 17 + sound/soc/codecs/cs42l42.h | 1 + 2 files changed, 14 insertions(+), 4

[PATCH v2 05/15] ASoC: cs42l42: Always wait at least 3ms after reset

2021-03-05 Thread Lucas Tanure
This delay is part of the power-up sequence defined in the datasheet. A runtime_resume is a power-up so must also include the delay. Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 3 ++- sound/soc/codecs/cs42l42.h | 1 + 2 files changed, 3 insertions

[PATCH v2 14/15] ASoC: cs42l42: Only start PLL if it is needed

2021-03-05 Thread Lucas Tanure
From: Richard Fitzgerald The PLL is only needed for sclk < 11289600 Hz and cs42l42_pll_config() will not configure it for higher rates. So it must only be enabled when it is needed. Signed-off-by: Richard Fitzgerald Signed-off-by: Lucas Tanure --- Changes in v2: - Lucas signed-off ad

[PATCH v2 06/15] ASoC: cs42l42: Remove power if the driver is being removed

2021-03-05 Thread Lucas Tanure
Ensure the power supplies are turned off when removing the driver Signed-off-by: Lucas Tanure --- Changes in v2: - Use PM functions to shutdown the codec - Disable IRQ before pm_suspend sound/soc/codecs/cs42l42.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound

[PATCH v2 03/15] ASoC: cs42l42: Fix mixer volume control

2021-03-05 Thread Lucas Tanure
The minimum value is 0x3f (-63dB), which also is mute Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 4f9ad95479292

[PATCH v2 02/15] ASoC: cs42l42: Fix channel width support

2021-03-05 Thread Lucas Tanure
Remove the hard coded 32 bits width and replace with the correct width calculated by params_width. Signed-off-by: Lucas Tanure --- Changes in v2: - No changes sound/soc/codecs/cs42l42.c | 47 ++ sound/soc/codecs/cs42l42.h | 1 - 2 files changed, 22

Re: [PATCH v2] kunit: fix checkpatch warning

2021-03-03 Thread Lucas Stankus
On Wed, Mar 03, 2021 at 12:56:05PM -0800, Brendan Higgins wrote: > Did you change anything other than fixing the Signed-off-by that Shuah > requested? No, I only fixed the Signed-off-by warning. > Generally when you make a small change after receiving a Reviewed-by > (especially one so small as h

[PATCH v2] kunit: fix checkpatch warning

2021-03-03 Thread Lucas Stankus
Tidy up code by fixing the following checkpatch warnings: CHECK: Alignment should match open parenthesis CHECK: Lines should not end with a '(' Signed-off-by: Lucas Stankus --- Change log v1 -> v2 fixed signed-off-by tag lib/kunit/assert.c | 31 --- 1

[PATCH 12/15] ASoC: cs42l42: Wait at least 150us after writing SCLK_PRESENT

2021-03-02 Thread Lucas Tanure
From: Richard Fitzgerald There must be a delay of at least 150us after writing SCLK_PRESENT before issuing another I2C write. This is done using struct reg_sequence because it can specify a delay after the write and the whole sequence is written atomically. Signed-off-by: Richard Fitzgerald --

[PATCH 14/15] ASoC: cs42l42: Wait for PLL to lock before switching to it

2021-03-02 Thread Lucas Tanure
From: Richard Fitzgerald The PLL should have locked before using it to supply MCLK. Signed-off-by: Richard Fitzgerald --- sound/soc/codecs/cs42l42.c | 12 +++- sound/soc/codecs/cs42l42.h | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs42l42.c

[PATCH 04/15] ASoC: cs42l42: Disable regulators if probe fails

2021-03-02 Thread Lucas Tanure
In case of cs42l42_i2c_probe() fail, the regulators were left enabled. Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 00e303c711ddc

[PATCH 13/15] ASoC: cs42l42: Only start PLL if it is needed

2021-03-02 Thread Lucas Tanure
From: Richard Fitzgerald The PLL is only needed for sclk < 11289600 Hz and cs42l42_pll_config() will not configure it for higher rates. So it must only be enabled when it is needed. Signed-off-by: Richard Fitzgerald --- sound/soc/codecs/cs42l42.c | 5 +++-- 1 file changed, 3 insertions(+), 2 d

[PATCH 08/15] ASoC: cs42l42: Fix channel width support

2021-03-02 Thread Lucas Tanure
Remove the hard coded 32 bits width and replace with the correct width calculated by params_width. Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 47 ++ sound/soc/codecs/cs42l42.h | 1 - 2 files changed, 22 insertions(+), 26 deletions(-) diff

[PATCH 09/15] ASoC: cs42l42: Add Capture Support

2021-03-02 Thread Lucas Tanure
Add support for capture path on headseat pins Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 39 ++ sound/soc/codecs/cs42l42.h | 12 2 files changed, 51 insertions(+) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs

[PATCH 07/15] ASoC: cs42l42: Set clock source for both ways of stream

2021-03-02 Thread Lucas Tanure
Move the enable/disable of clocks to cs42l42_mute_stream so the record path also get clocks. Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 85 +- sound/soc/codecs/cs42l42.h | 1 + 2 files changed, 48 insertions(+), 38 deletions(-) diff --git

[PATCH 11/15] ASoC: cs42l42: Use bclk from hw_params if set_sysclk was not called

2021-03-02 Thread Lucas Tanure
Add support for reading the source clock from snd_soc_params_to_bclk so the machine driver is not required to call cs42l42_set_sysclk Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 17 + sound/soc/codecs/cs42l42.h | 1 + 2 files changed, 14 insertions(+), 4

[PATCH 10/15] ASoC: cs42l42: Report jack and button detection

2021-03-02 Thread Lucas Tanure
Report the Jack events to the user space through ALSA. Also moves request_threaded_irq() to component_probe so it don't get interrupts before the initialization the struct snd_soc_jack. Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 142 +

[PATCH 06/15] ASoC: cs42l42: Provide finer control on playback path

2021-03-02 Thread Lucas Tanure
Removing cs42l42_hpdrv_evt that enables the entire chain and replace by a set of widgets that can better define the codec Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 65 +- sound/soc/codecs/cs42l42.h | 8 ++--- 2 files changed, 26 insertions

[PATCH 03/15] ASoC: cs42l42: Remove power if the driver is being removed

2021-03-02 Thread Lucas Tanure
Ensure the power supplies are turned off when removing the driver Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 2a25a30f842b1..00e303c711ddc 100644 --- a/sound/soc

[PATCH 15/15] ASoC: cs42l42: Fix mixer volume control

2021-03-02 Thread Lucas Tanure
The minimum value is 0x3f (-63dB), which also is mute Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 96f4e98ceaa0b..39f742a83cd2c 100644 --- a/sound

[PATCH 02/15] ASoC: cs42l42: Always wait at least 3ms after reset

2021-03-02 Thread Lucas Tanure
This delay is part of the power-up sequence defined in the datasheet. A runtime_resume is a power-up so must also include the delay. Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 3 ++- sound/soc/codecs/cs42l42.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 05/15] ASoC: cs42l42: Fix Bitclock polarity inversion

2021-03-02 Thread Lucas Tanure
The driver was setting bit clock polarity opposite to intended polarity. Also simplify the code by grouping ADC and DAC clock configurations into a single field. Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 20 sound/soc/codecs/cs42l42.h | 11 ++- 2

[PATCH 01/15] ASoC: cs42l42: Don't enable/disable regulator at Bias Level

2021-03-02 Thread Lucas Tanure
dev_pm_ops already enable/disable the codec if not in use Signed-off-by: Lucas Tanure --- sound/soc/codecs/cs42l42.c | 38 -- 1 file changed, 38 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 210fcbedf2413

[PATCH 00/15] Report jack and button detection + Capture Support

2021-03-02 Thread Lucas Tanure
Hi All, Here is a patch series for reporting to user space jack and button events and add the support for Capture. With some cleanups and fixes along the way. Regards, Lucas Tanure Lucas Tanure (12): ASoC: cs42l42: Don't enable/disable regulator at Bias Level ASoC: cs42l42: Always wa

[PATCH] kunit: fix checkpatch warning

2021-02-26 Thread Lucas Pires Stankus
Tidy up code by fixing the following checkpatch warnings: CHECK: Alignment should match open parenthesis CHECK: Lines should not end with a '(' Signed-off-by: Lucas Stankus --- lib/kunit/assert.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-)

Re: [PATCH v1 03/18] arm64: dts: imx8mq-evk: add reserve memory node for CMA region

2021-02-18 Thread Lucas Stach
ld only imagine the DMA addressing restrictions on the platform. DMA masters on the i.MX8MQ can not access memory beyond the 4GB mark and 1GB of address space is reserved for MMIO, so if you have 4GB installed the upper 1GB of DRAM is only accessible to the CPU. But this restriction is already properly communicated to the Linux DMA framework by the dma-ranges in the top level SoC bus node in the DT, so I don't think this CMA setup is necessary. Regards, Lucas

Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie

2021-02-18 Thread Lucas Stach
oo. > > Signed-off-by: Richard Zhu Reviewed-by: Lucas Stach > --- >  drivers/pci/controller/dwc/pci-imx6.c | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c > b/drivers/pci/controller/dwc/pci-imx6.c > index 0cf1333c0440..8

Re: [BUG REPORT] media: coda: mpeg4 decode corruption on i.MX6qp only

2021-02-15 Thread Lucas Stach
Am Montag, dem 15.02.2021 um 10:54 -0500 schrieb Sven Van Asbroeck: > Hi Lucas, > > On Mon, Feb 15, 2021 at 5:15 AM Lucas Stach wrote: > > > > The straight forward way to fix this would be to just disable the PRE > > when the stride is getting too large, which might

Re: DMA-buf and uncached system memory

2021-02-15 Thread Lucas Stach
Am Montag, dem 15.02.2021 um 13:04 +0100 schrieb Christian König: > Am 15.02.21 um 12:53 schrieb Lucas Stach: > > Am Montag, dem 15.02.2021 um 10:34 +0100 schrieb Christian König: > > > Am 15.02.21 um 10:06 schrieb Simon Ser: > > > > On Monday, February 15th, 20

Re: DMA-buf and uncached system memory

2021-02-15 Thread Lucas Stach
f is correct and doesn't > crash the system must happen in the kernel. What exactly do you mean by "scanout requires non-coherent memory"? Does the scanout requestor always set the no-snoop PCI flag, so you get garbage if some writes to memory are still stuck in the caches, or is it some other requirement? Regards, Lucas

  1   2   3   4   5   6   7   8   9   10   >