quot;lacks major and minor information. "
> + "Ignoring.\n", mod->modname, devname);
> }
> }
>
> --
Patch has been applied. Thanks.
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Cc: Lucas De Marchi lucas.demar...@profusion.mobi
---
tools/depmod.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/tools/depmod.c b/tools/depmod.c
index 985cf3a..5855b2a 100644
--- a/tools/depmod.c
+++ b/tools/depmod.c
@@ -2120,11 +2120,18 @@ static int
what you were missing.
>
>
>>> >> 2. When wait=UMH_NO_WAIT, __call_usermodehelper() starts child thread
>>> >> and instantly frees subprocess_info. The child thread reads
>>> >> subprocess_info. Looks like another use-after-free.
>>
>> Same, ker
the child thread that will do exec. I don't know whether it's
a problem with the code or with the name.
Same.
Agreed
Lucas De Marchi
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
to the library is kind of an workaround
for people doing initrd needing their tools to be statically linked.
As usual, shortlog is below.
Cheers
Lucas De Marchi
---
Jan Engelhardt (1):
depmod: add missing "else" clause
Lucas De Marchi (15):
tools: Do not link dynamically wi
to the library is kind of an workaround
for people doing initrd needing their tools to be statically linked.
As usual, shortlog is below.
Cheers
Lucas De Marchi
---
Jan Engelhardt (1):
depmod: add missing else clause
Lucas De Marchi (15):
tools: Do not link dynamically with libkmod
Use
On Tue, Aug 13, 2013 at 9:17 PM, Steven Rostedt wrote:
> On Tue, 13 Aug 2013 20:34:58 -0300
> Lucas De Marchi wrote:
>
>
>> so in kcmdline we would have modulename.param instead of modulename.param=1?
>>
>> I guess we need to update kmod then, because currently we
On Tue, Aug 13, 2013 at 10:00 PM, Lucas De Marchi
wrote:
> On Tue, Aug 13, 2013 at 9:17 PM, Steven Rostedt wrote:
>> On Tue, 13 Aug 2013 20:34:58 -0300
>> Lucas De Marchi wrote:
>>
>>
>>> so in kcmdline we would have modulename.param instead of modulen
guess we need to update kmod then, because currently we ignore and
treat this case as a wrong token. From a quick look, allowing it in
kmod would be as simple as removing a condition check.
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
as a wrong token. From a quick look, allowing it in
kmod would be as simple as removing a condition check.
Lucas De Marchi
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Tue, Aug 13, 2013 at 10:00 PM, Lucas De Marchi
lucas.de.mar...@gmail.com wrote:
On Tue, Aug 13, 2013 at 9:17 PM, Steven Rostedt rost...@goodmis.org wrote:
On Tue, 13 Aug 2013 20:34:58 -0300
Lucas De Marchi lucas.de.mar...@gmail.com wrote:
so in kcmdline we would have modulename.param
On Tue, Aug 13, 2013 at 9:17 PM, Steven Rostedt rost...@goodmis.org wrote:
On Tue, 13 Aug 2013 20:34:58 -0300
Lucas De Marchi lucas.de.mar...@gmail.com wrote:
so in kcmdline we would have modulename.param instead of modulename.param=1?
I guess we need to update kmod then, because currently
ERR("unsupported file mode %s: %#x\n", path, st.st_mode);
> return -EINVAL;
> }
> --
Applied, thanks.
Please make sure to CC linux-modu...@vger.kernel.org
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Lucas De Marchi
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
e number of processes to get a full
> trace; see attached file.
>
> Please note that in this case the proprietary "nvidia" module was loaded,
> since I currently onyl have remove access to the machine.
> The original trace from yesterday happend without the nvidia module
for the past releases. Any chance a bad entry in
your .conf was added too? You may want to paste the output of modprobe
-c, at least until "# End of configuration files. Dumping indexes
now:"
>
> On my systems, that's snd-seq-dummy, which depends on snd_seq. Which,
> in fact, is al
files. Dumping indexes
now:
On my systems, that's snd-seq-dummy, which depends on snd_seq. Which,
in fact, is already loaded.
Lucas, any clues?
I don't think I could help, but we need more data, like the ones above.
Lucas De Marchi
--
To unsubscribe from this list: send the line unsubscribe
file.
Please note that in this case the proprietary nvidia module was loaded,
since I currently onyl have remove access to the machine.
The original trace from yesterday happend without the nvidia module ever
being loaded.
Am Dienstag 16 Juli 2013, 08:42:35 schrieb Lucas De Marchi:
On Tue
at boot. It may be worth adding a more
>> intentional way to do that.
>
> Hm, right, there seems to be no clean way to achieve this via a
> commandline argument. Maybe define a magic module option to tell the
> module loader not to load a module?
modprobe.blacklist=modname1,mod
to everyone involved in this release. Shortlog is below.
Cheers
Lucas De Marchi
---
Chengwei Yang (2):
Several minor fixes for documentation
Add document for exported enums
Jan Luebbe (1):
libkmod: Avoid calling syscall() with -1
Johannes Berg (1):
modprobe: don't check
in this release. Shortlog is below.
Cheers
Lucas De Marchi
---
Chengwei Yang (2):
Several minor fixes for documentation
Add document for exported enums
Jan Luebbe (1):
libkmod: Avoid calling syscall() with -1
Johannes Berg (1):
modprobe: don't check refcount with remove command
to tell the
module loader not to load a module?
modprobe.blacklist=modname1,modname2,... is already there, though all
the silliness of blacklist applies unless -b is passed (that's the
equivalent behavior of udev)
Lucas De Marchi
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
ch a value so I guess it might be difficult to reproduce it
again.
Any hints on what could cause decs to be greater than incs in module_refcount()?
--
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@
I guess it might be difficult to reproduce it
again.
Any hints on what could cause decs to be greater than incs in module_refcount()?
--
Lucas De Marchi
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
nt to detect the "disabled by admin" case.
>
> Kill it. Not only it looks strange, it can confuse other callers.
> And this allows us to revert 264b83c0 "usermodehelper: check
> subprocess_info->path != NULL", do_execve(NULL) is safe.
>
> Signed-off-by: O
to detect the disabled by admin case.
Kill it. Not only it looks strange, it can confuse other callers.
And this allows us to revert 264b83c0 usermodehelper: check
subprocess_info-path != NULL, do_execve(NULL) is safe.
Signed-off-by: Oleg Nesterov o...@redhat.com
Acked-By: Lucas De Marchi
@@ int call_usermodehelper_exec(struct subprocess_info
> *sub_info, int wait)
> int retval = 0;
>
> helper_lock();
> + if (!sub_info->path) {
> + retval = -EINVAL;
> + goto out;
> + }
> +
>
wait)
int retval = 0;
helper_lock();
+ if (!sub_info-path) {
+ retval = -EINVAL;
+ goto out;
+ }
+
if (sub_info-path[0] == '\0')
goto out;
--
Acked-By: Lucas De Marchi lucas.demar...@intel.com
Lucas De
is MC we proposed:
>
> http://wiki.linuxplumbersconf.org/2013:boot_and_core_os
>
> which sounds pretty close to fastboot?
>
What if we merge the proposals?
John, are you ok with proposing (some of) these topics in the "Boot
and Core OS" track? I could help with the module-related part, too.
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
proposed:
http://wiki.linuxplumbersconf.org/2013:boot_and_core_os
which sounds pretty close to fastboot?
What if we merge the proposals?
John, are you ok with proposing (some of) these topics in the Boot
and Core OS track? I could help with the module-related part, too.
Lucas De Marchi
On Fri, May 10, 2013 at 2:10 PM, Oleg Nesterov wrote:
> On 05/10, Lucas De Marchi wrote:
>>
>> On Fri, May 10, 2013 at 12:36 PM, Oleg Nesterov wrote:
>> > Well, personally I think it would be better to use kasprintf(), see the
>> > patch I sent (it is actuall
On Fri, May 10, 2013 at 2:10 PM, Oleg Nesterov o...@redhat.com wrote:
On 05/10, Lucas De Marchi wrote:
On Fri, May 10, 2013 at 12:36 PM, Oleg Nesterov o...@redhat.com wrote:
Well, personally I think it would be better to use kasprintf(), see the
patch I sent (it is actually wrong, needs
On Fri, May 10, 2013 at 2:35 PM, Oleg Nesterov wrote:
> On 05/10, Oleg Nesterov wrote:
>>
>> On 05/10, Lucas De Marchi wrote:
>> >
>> > but I think it's a good tradeoff and covers other use cases as you
>> > pointed out as well.
>>
>&
On Fri, May 10, 2013 at 12:36 PM, Oleg Nesterov wrote:
> On 05/10, Lucas De Marchi wrote:
>>
>> Oh, right. Forgot about that. And this patch set should have been sent
>> as RFC, since I'm interested in feedback about the idea. What do you
>> think?
>
> Well, pers
On Fri, May 10, 2013 at 9:58 AM, Oleg Nesterov wrote:
>
> On 05/10, Lucas De Marchi wrote:
> >
> > -char modprobe_path[KMOD_PATH_LEN] = "/sbin/modprobe -q --";
> > +char modprobe_path[KMOD_PATH_LEN] = CONFIG_DEFAULT_MODULE_LOAD_BIN;
>
> But even after 1/3 a
On Fri, May 10, 2013 at 9:58 AM, Oleg Nesterov o...@redhat.com wrote:
On 05/10, Lucas De Marchi wrote:
-char modprobe_path[KMOD_PATH_LEN] = /sbin/modprobe -q --;
+char modprobe_path[KMOD_PATH_LEN] = CONFIG_DEFAULT_MODULE_LOAD_BIN;
But even after 1/3 and 2/3 this can break
On Fri, May 10, 2013 at 12:36 PM, Oleg Nesterov o...@redhat.com wrote:
On 05/10, Lucas De Marchi wrote:
Oh, right. Forgot about that. And this patch set should have been sent
as RFC, since I'm interested in feedback about the idea. What do you
think?
Well, personally I think it would
On Fri, May 10, 2013 at 2:35 PM, Oleg Nesterov o...@redhat.com wrote:
On 05/10, Oleg Nesterov wrote:
On 05/10, Lucas De Marchi wrote:
but I think it's a good tradeoff and covers other use cases as you
pointed out as well.
OK, good.
Yes, perhaps this makes sense anyway but...
Ok
would have to be done very early in the boot sequence and on every
boot since modprobe may be called even before / is mounted. In this
scenario booting without and initrd would be more difficult as well.
Signed-off-by: Lucas De Marchi
---
init/Kconfig | 7 +++
kernel/kmod.c | 2 +-
2 files
Now that argv_split() leaves room for extra parameter, make
call_modprobe() use it.
Signed-off-by: Lucas De Marchi
---
kernel/kmod.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/kernel/kmod.c b/kernel/kmod.c
index 166aff5..70df90b 100644
--- a/kernel
Add an argument allowing argv_split to leave room for parameters to be
filled by the caller. This is useful in situations we want to split the
command and add a options as the last arguments.
Signed-off-by: Lucas De Marchi
---
fs/coredump.c | 2 +-
include/linux/string.h
Add an argument allowing argv_split to leave room for parameters to be
filled by the caller. This is useful in situations we want to split the
command and add a options as the last arguments.
Signed-off-by: Lucas De Marchi lucas.de.mar...@gmail.com
---
fs/coredump.c | 2
Now that argv_split() leaves room for extra parameter, make
call_modprobe() use it.
Signed-off-by: Lucas De Marchi lucas.de.mar...@gmail.com
---
kernel/kmod.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/kernel/kmod.c b/kernel/kmod.c
index 166aff5
to be done very early in the boot sequence and on every
boot since modprobe may be called even before / is mounted. In this
scenario booting without and initrd would be more difficult as well.
Signed-off-by: Lucas De Marchi lucas.de.mar...@gmail.com
---
init/Kconfig | 7 +++
kernel/kmod.c | 2
. The older syscall is also used in case the module is
compressed.
There are also bug fixes and other minor new features. Check the NEWS
file. Thanks to everyone involved in this release. Shortlog is below.
Cheers,
Lucas De Marchi
---
Andrey Mazo (2):
depmod: --symbol-prefix actually
. The older syscall is also used in case the module is
compressed.
There are also bug fixes and other minor new features. Check the NEWS
file. Thanks to everyone involved in this release. Shortlog is below.
Cheers,
Lucas De Marchi
---
Andrey Mazo (2):
depmod: --symbol-prefix actually
to broaden your audience. linux-modu...@vger.kernel.org
is really low traffic and mostly intended for the module
loading/removal process, not really about writing modules.
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord.
...@vger.kernel.org
is really low traffic and mostly intended for the module
loading/removal process, not really about writing modules.
Lucas De Marchi
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
EM;-)
Yep, it's in -mm with -ENOMEM:
http://git.cmpxchg.org/?p=linux-mmotm.git;a=commitdiff;h=a8c67c6e380a8ff15997e8673e97d9fcdf7b8f9c
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
in -mm with -ENOMEM:
http://git.cmpxchg.org/?p=linux-mmotm.git;a=commitdiff;h=a8c67c6e380a8ff15997e8673e97d9fcdf7b8f9c
Lucas De Marchi
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
ce, it's probably better to warn, and load the module anyway.
However loading the module anyway would bring at least one drawback:
if the user made a typo when passing the option the module would load
anyway and he will probably not even look in the log, since there's
was no errors from modprobe.
For f
in the log, since there's
was no errors from modprobe.
For finit_module we could put a flag to trigger this behavior and
propagate it to modprobe, but this is not possible with init_module().
I can't think in any other option right now... do you have any?
Lucas De Marchi
--
To unsubscribe from this list
>
> Lucas, Andrew, sorry. If this patch will be applied, then
>
> kernel-sysc-use-the-simpler-call_usermodehelper.patch
No problem for me... your patch already does what this one is doing.
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
that orderly_poweroff() doesn't need
the keventd_up() check, I hope this is correct...
Lucas, Andrew, sorry. If this patch will be applied, then
kernel-sysc-use-the-simpler-call_usermodehelper.patch
No problem for me... your patch already does what this one is doing.
Lucas De
On Tue, Mar 12, 2013 at 5:31 PM, Andrew Morton
wrote:
> On Mon, 11 Mar 2013 21:48:06 -0300 Lucas De Marchi
> wrote:
>
>> call_usermodehelper_setup() + call_usermodehelper_exec() need to be
>> called instead of call_usermodehelper_fns() when the cleanup function
>> n
xport call_usermodehelper_{setup,exec}.
Doing this we can separate the allocation part using GFP_ATOMIC in
order to make it work on interrupt context. May I suggest going with
something like below after that patches are applied (sorry, whitespace
damaged)? I can also rework the patch series so this can b
the allocation part using GFP_ATOMIC in
order to make it work on interrupt context. May I suggest going with
something like below after that patches are applied (sorry, whitespace
damaged)? I can also rework the patch series so this can be applied
regardless of the rest.
Lucas De Marchi
diff --git
On Tue, Mar 12, 2013 at 5:31 PM, Andrew Morton
a...@linux-foundation.org wrote:
On Mon, 11 Mar 2013 21:48:06 -0300 Lucas De Marchi
lucas.demar...@profusion.mobi wrote:
call_usermodehelper_setup() + call_usermodehelper_exec() need to be
called instead of call_usermodehelper_fns() when
or not.
Signed-off-by: Lucas De Marchi
---
include/linux/kmod.h | 8
kernel/kmod.c| 56 +---
2 files changed, 31 insertions(+), 33 deletions(-)
diff --git a/include/linux/kmod.h b/include/linux/kmod.h
index 5398d58..7eebcf5 100644
This function suffers from not being able to determine if the cleanup is
called in case it returns -ENOMEM. Nobody is using it anymore, so let's
remove it.
Signed-off-by: Lucas De Marchi
---
include/linux/kmod.h | 11 +--
kernel/kmod.c| 31 +--
2
Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of
calling call_usermodehelper_fns(). In case there's an OOM in this last
function the cleanup function may not be called - in this case we would
miss a call to key_put().
Signed-off-by: Lucas De Marchi
---
Changes from v2
remove the _fns variant.
Signed-off-by: Lucas De Marchi
---
Changes from v2: simplify error handling as suggested by Oleg.
fs/coredump.c | 12 +---
init/do_mounts_initrd.c | 8 ++--
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/fs/coredump.c b/fs
Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of
calling call_usermodehelper_fns(). In case the latter returns -ENOMEM
the cleanup function may had not been called - in this case we would
not free argv and module_name.
Signed-off-by: Lucas De Marchi
---
Changes from v2
Signed-off-by: Lucas De Marchi
---
fs/coredump.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/coredump.c b/fs/coredump.c
index c647965..7dfb3b0 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -522,7 +522,7 @@ void do_coredump(siginfo_t *siginfo)
ispipe
Commit "7ff6764 usermodehelper: cleanup/fix __orderly_poweroff() &&
argv_free()" simplified __orderly_poweroff() removing the need to use
call_usermodehelper_fns().
Since we are not passing any callback, it's simpler to use
call_usermodehelper().
Signed-off-by: Lucas De Marchi
Commit 7ff6764 usermodehelper: cleanup/fix __orderly_poweroff()
argv_free() simplified __orderly_poweroff() removing the need to use
call_usermodehelper_fns().
Since we are not passing any callback, it's simpler to use
call_usermodehelper().
Signed-off-by: Lucas De Marchi lucas.demar
Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of
calling call_usermodehelper_fns(). In case the latter returns -ENOMEM
the cleanup function may had not been called - in this case we would
not free argv and module_name.
Signed-off-by: Lucas De Marchi lucas.demar
Signed-off-by: Lucas De Marchi lucas.demar...@profusion.mobi
---
fs/coredump.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/coredump.c b/fs/coredump.c
index c647965..7dfb3b0 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -522,7 +522,7 @@ void do_coredump
Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of
calling call_usermodehelper_fns(). In case there's an OOM in this last
function the cleanup function may not be called - in this case we would
miss a call to key_put().
Signed-off-by: Lucas De Marchi lucas.demar
remove the _fns variant.
Signed-off-by: Lucas De Marchi lucas.demar...@profusion.mobi
---
Changes from v2: simplify error handling as suggested by Oleg.
fs/coredump.c | 12 +---
init/do_mounts_initrd.c | 8 ++--
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git
This function suffers from not being able to determine if the cleanup is
called in case it returns -ENOMEM. Nobody is using it anymore, so let's
remove it.
Signed-off-by: Lucas De Marchi lucas.demar...@profusion.mobi
---
include/linux/kmod.h | 11 +--
kernel/kmod.c| 31
or not.
Signed-off-by: Lucas De Marchi lucas.demar...@profusion.mobi
---
include/linux/kmod.h | 8
kernel/kmod.c| 56 +---
2 files changed, 31 insertions(+), 33 deletions(-)
diff --git a/include/linux/kmod.h b/include/linux/kmod.h
On Sat, Mar 9, 2013 at 5:42 PM, Oleg Nesterov wrote:
> On 03/08, Lucas De Marchi wrote:
>>
>> @@ -571,9 +572,17 @@ void do_coredump(siginfo_t *siginfo)
>> goto fail_dropcount;
>> }
>>
>> - retval = call_usermod
On Sat, Mar 9, 2013 at 5:25 PM, Oleg Nesterov wrote:
> On 03/08, Lucas De Marchi wrote:
>>
>> static int call_usermodehelper_keys(char *path, char **argv, char **envp,
>> struct key *session_keyring, int wait)
>> {
>> -
On Sat, Mar 9, 2013 at 5:23 PM, Oleg Nesterov wrote:
> On 03/08, Lucas De Marchi wrote:
>>
>> Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of
>> calling call_usermodehelper_fns(). In case the latter returns -ENOMEM
>> the cleanup funct
On Sat, Mar 9, 2013 at 5:23 PM, Oleg Nesterov o...@redhat.com wrote:
On 03/08, Lucas De Marchi wrote:
Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of
calling call_usermodehelper_fns(). In case the latter returns -ENOMEM
the cleanup function may had not been called
On Sat, Mar 9, 2013 at 5:25 PM, Oleg Nesterov o...@redhat.com wrote:
On 03/08, Lucas De Marchi wrote:
static int call_usermodehelper_keys(char *path, char **argv, char **envp,
struct key *session_keyring, int wait)
{
- return
On Sat, Mar 9, 2013 at 5:42 PM, Oleg Nesterov o...@redhat.com wrote:
On 03/08, Lucas De Marchi wrote:
@@ -571,9 +572,17 @@ void do_coredump(siginfo_t *siginfo)
goto fail_dropcount;
}
- retval = call_usermodehelper_fns(helper_argv[0
This function suffers from not being able to determine if the cleanup is
called in case it returns -ENOMEM. Nobody is using it anymore, so let's
remove it.
Signed-off-by: Lucas De Marchi
---
include/linux/kmod.h | 11 +--
kernel/kmod.c| 31 +--
2
Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of
calling call_usermodehelper_fns(). In case the latter returns -ENOMEM
the cleanup function may had not been called - in this case we would
not free argv and module_name.
Signed-off-by: Lucas De Marchi
---
kernel/kmod.c | 15
Commit "7ff6764 usermodehelper: cleanup/fix __orderly_poweroff() &&
argv_free()" simplified __orderly_poweroff() removing the need to use
call_usermodehelper_fns().
Since we are not passing any callback, it's simpler to use
call_usermodehelper().
Signed-off-by: Lucas De Marchi
or not.
Signed-off-by: Lucas De Marchi
---
include/linux/kmod.h | 8
kernel/kmod.c| 56 +---
2 files changed, 31 insertions(+), 33 deletions(-)
diff --git a/include/linux/kmod.h b/include/linux/kmod.h
index 5398d58..7eebcf5 100644
is separating from executing it, it's safe to
allways call the cleanup.
Lucas De Marchi (7):
kernel/sys.c: Use the simpler call_usermodehelper()
usermodehelper: Export _exec() and _setup() functions
kmod: split call to call_usermodehelper_fns()
KEYS: split call to call_usermodehelper_fns
Signed-off-by: Lucas De Marchi
---
fs/coredump.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/coredump.c b/fs/coredump.c
index c647965..7dfb3b0 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -522,7 +522,7 @@ void do_coredump(siginfo_t *siginfo)
ispipe
Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of
calling call_usermodehelper_fns(). In case there's an OOM in this last
function the cleanup function may not be called - in this case we would
miss a call to key_put().
Signed-off-by: Lucas De Marchi
---
security/keys
remove the _fns variant.
Signed-off-by: Lucas De Marchi
---
fs/coredump.c | 15 ---
init/do_mounts_initrd.c | 11 +--
2 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/fs/coredump.c b/fs/coredump.c
index 7dfb3b0..468b4f6 100644
--- a/fs/coredump.c
+++ b
On Thu, Mar 7, 2013 at 5:07 PM, Oleg Nesterov wrote:
> On 03/07, Lucas De Marchi wrote:
>>
>> On Thu, Mar 7, 2013 at 4:37 PM, Oleg Nesterov wrote:
>> >
>> >> @@ -98,12 +93,13 @@ static int call_modprobe(char *module_name, int wait)
>> >> arg
On Thu, Mar 7, 2013 at 4:37 PM, Oleg Nesterov wrote:
> Hi Lucas,
>
> On 03/06, Lucas De Marchi wrote:
>>
>> On Mon, Feb 25, 2013 at 3:08 PM, Oleg Nesterov wrote:
>> >
>> > So, I hope you will send v2. I'd suggest to split the fixes. 1/3
>> > s
Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of
calling call_usermodehelper_fns(). In case there's an OOM in this last
function the cleanup function may not be called - in this case we would
miss a call to key_put().
Signed-off-by: Lucas De Marchi lucas.demar
remove the _fns variant.
Signed-off-by: Lucas De Marchi lucas.demar...@profusion.mobi
---
fs/coredump.c | 15 ---
init/do_mounts_initrd.c | 11 +--
2 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/fs/coredump.c b/fs/coredump.c
index 7dfb3b0..468b4f6
Signed-off-by: Lucas De Marchi lucas.demar...@profusion.mobi
---
fs/coredump.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/coredump.c b/fs/coredump.c
index c647965..7dfb3b0 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -522,7 +522,7 @@ void do_coredump
is separating from executing it, it's safe to
allways call the cleanup.
Lucas De Marchi (7):
kernel/sys.c: Use the simpler call_usermodehelper()
usermodehelper: Export _exec() and _setup() functions
kmod: split call to call_usermodehelper_fns()
KEYS: split call to call_usermodehelper_fns
Commit 7ff6764 usermodehelper: cleanup/fix __orderly_poweroff()
argv_free() simplified __orderly_poweroff() removing the need to use
call_usermodehelper_fns().
Since we are not passing any callback, it's simpler to use
call_usermodehelper().
Signed-off-by: Lucas De Marchi lucas.demar
or not.
Signed-off-by: Lucas De Marchi lucas.demar...@profusion.mobi
---
include/linux/kmod.h | 8
kernel/kmod.c| 56 +---
2 files changed, 31 insertions(+), 33 deletions(-)
diff --git a/include/linux/kmod.h b/include/linux/kmod.h
Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of
calling call_usermodehelper_fns(). In case the latter returns -ENOMEM
the cleanup function may had not been called - in this case we would
not free argv and module_name.
Signed-off-by: Lucas De Marchi lucas.demar
This function suffers from not being able to determine if the cleanup is
called in case it returns -ENOMEM. Nobody is using it anymore, so let's
remove it.
Signed-off-by: Lucas De Marchi lucas.demar...@profusion.mobi
---
include/linux/kmod.h | 11 +--
kernel/kmod.c| 31
On Thu, Mar 7, 2013 at 4:37 PM, Oleg Nesterov o...@redhat.com wrote:
Hi Lucas,
On 03/06, Lucas De Marchi wrote:
On Mon, Feb 25, 2013 at 3:08 PM, Oleg Nesterov o...@redhat.com wrote:
So, I hope you will send v2. I'd suggest to split the fixes. 1/3
should create/export the new helpers
On Thu, Mar 7, 2013 at 5:07 PM, Oleg Nesterov o...@redhat.com wrote:
On 03/07, Lucas De Marchi wrote:
On Thu, Mar 7, 2013 at 4:37 PM, Oleg Nesterov o...@redhat.com wrote:
@@ -98,12 +93,13 @@ static int call_modprobe(char *module_name, int wait)
argv[3] = module_name; /* check
Hi Oleg,
On Mon, Feb 25, 2013 at 3:08 PM, Oleg Nesterov wrote:
> On 02/25, Lucas De Marchi wrote:
>>
>> Yep. The current interface is confusing. I agree that a separate
>> setup() + exec() would make more sense.
>
> Great,
>
>> > @@ -98,8 +98,14 @@ s
Hi Oleg,
On Mon, Feb 25, 2013 at 3:08 PM, Oleg Nesterov o...@redhat.com wrote:
On 02/25, Lucas De Marchi wrote:
Yep. The current interface is confusing. I agree that a separate
setup() + exec() would make more sense.
Great,
@@ -98,8 +98,14 @@ static int call_modprobe(char *module_na
201 - 300 of 348 matches
Mail list logo
