[RESEND V2 1/2] dt-bindings: Document the DesignWare IP reset bindings

2019-07-23 Thread Luis Oliveira
This adds documentation of device tree bindings for the DesignWare IP reset controller. Signed-off-by: Gustavo Pimentel Signed-off-by: Luis Oliveira Reviewed-by: Rob Herring --- Changelog -no changes .../devicetree/bindings/reset/snps,dw-reset.txt| 30 ++ 1 file

[RESEND V2 0/2] Add DesignWare IP support to simple reset

2019-07-23 Thread Luis Oliveira
This patch series adds a reset-simple compatible string for DesignWare IPs allowing active high and low resets inputs. Also adds the corresponding documentation. Gustavo Pimentel (1): reset: Add DesignWare IP support to simple reset Luis Oliveira (1): dt-bindings: Document the DesignWare IP

[RESEND V2 2/2] reset: Add DesignWare IP support to simple reset

2019-07-23 Thread Luis Oliveira
From: Gustavo Pimentel The reset-simple driver can be now used on DesignWare IPs by default by selecting the following compatible strings: - snps,dw-high-reset for active high resets inputs - snps,dw-low-reset for active low resets inputs Signed-off-by: Gustavo Pimentel Signed-off-by: Luis

[v4 5/6] media: platform: dwc: Add DW MIPI DPHY Rx driver

2019-06-11 Thread Luis Oliveira
Add of Synopsys MIPI D-PHY in RX mode support. Separated in the implementation are platform dependent probing functions. Signed-off-by: Luis Oliveira --- Changelog v3-v4 - This patch suffered from some changes, but still the D-PHY is configured on boot-up either from dt or by pdata (check

[v4 3/6] media: platform: dwc: Add MIPI CSI-2 platform data

2019-06-11 Thread Luis Oliveira
This allows the driver loading via platform data which makes the driver not device tree dependent. Signed-off-by: Luis Oliveira --- Changelog v3-v4 - not present on v3, allows configuration using pdata MAINTAINERS | 1 + drivers/media/platform/dwc/dw-csi-plat.c

[v4 4/6] dt-bindings: phy: Document the Synopsys MIPI DPHY Rx bindings

2019-06-11 Thread Luis Oliveira
Add device-tree bindings documentation for SNPS DesignWare MIPI D-PHY in RX mode. Signed-off-by: Luis Oliveira --- Changelog v3-v4 - @Laurent I know I told you I could remove the snps,dphy-frequency on V3 but it is really useful for me here. I removed all other the proprietary properties

[v4 2/6] media: platform: dwc: Add MIPI CSI-2 controller driver

2019-06-11 Thread Luis Oliveira
Add the Synopsys MIPI CSI-2 controller driver. This controller driver is divided in platform functions and core functions. This way it serves as platform for future DesignWare drivers. Signed-off-by: Luis Oliveira --- Changelog v3-v4 - fix v4l2_fwnode_endpoint bad initialization @eugen - removed

[v4 6/6] media: platform: dwc: Add platform data support to D-Phy

2019-06-11 Thread Luis Oliveira
This patch allows the configuration via platform data. This allows the driver loading not devicetree dependent. Signed-off-by: Luis Oliveira --- Changelog v3-v4 - This patch was not in the v3. This enables pdata to configure the driver drivers/media/platform/dwc/dw-dphy-plat.c | 87

[v4 1/6] dt-bindings: media: Document bindings for DW MIPI CSI-2 Host

2019-06-11 Thread Luis Oliveira
From: Luis Oliveira Add bindings for Synopsys DesignWare MIPI CSI-2 host. Signed-off-by: Luis Oliveira --- Changelog v3-v4 - remove "plat" from the block name @rob @laurent - remove "phy-names" when single-entry @rob - remove "snps,output-type" -> w

[v4 0/6] platform: dwc: Adding DesignWare MIPI CSI-2 Host and D-PHY

2019-06-11 Thread Luis Oliveira
series are following an old series submitted on v4.19.rc1 and are result of all the feedback received, please check the changelog per patch. This was applied in: https://git.linuxtv.org/media_tree.git Luis Oliveira (6): dt-bindings: media: Document bindings for DW MIPI CSI-2 Host media

[PATCH V2 2/2] dt-bindings: Document the DesignWare IP reset bindings

2019-06-06 Thread Luis Oliveira
This adds documentation of device tree bindings for the DesignWare IP reset controller. Signed-off-by: Gustavo Pimentel Signed-off-by: Luis Oliveira --- Changelog - Add active low configuration example - Fix compatible string in the active high example .../devicetree/bindings/reset/snps,dw

[PATCH V2 1/2] reset: Add DesignWare IP support to simple reset

2019-06-06 Thread Luis Oliveira
From: Gustavo Pimentel The reset-simple driver can be now used on DesignWare IPs by default by selecting the following compatible strings: - snps,dw-high-reset for active high resets inputs - snps,dw-low-reset for active low resets inputs Signed-off-by: Gustavo Pimentel Signed-off-by: Luis

[PATCH V2 0/2] Add DesignWare IP support to simple reset

2019-06-06 Thread Luis Oliveira
This patch series adds a reset-simple compatible string for DesignWare IPs allowing active high and low resets inputs. Also adds the corresponding documentation. Gustavo Pimentel (1): reset: Add DesignWare IP support to simple reset Luis Oliveira (1): dt-bindings: Document the DesignWare IP

Re: [PATCH v3 1/2] media: i2c: OV5647: ensure clock lane in LP-11 state before streaming on

2017-10-16 Thread Luis Oliveira
>> + >> ret = ov5647_write(sd, 0x4202, 0x0f); >> if (ret < 0) >> return ret; >> @@ -320,7 +328,10 @@ static int __sensor_init(struct v4l2_subdev *sd) >> return ret; >> } >> >> -return ov5647_write(sd, 0x4800, 0x04); >> +/* >> + * stream off to make the clock lane into LP-11 state. >> + */ >> +return ov5647_stream_off(sd); >> } >> >> static int ov5647_sensor_power(struct v4l2_subdev *sd, int on) >> -- >> 2.14.1 >> > Reviewed-by: Luis Oliveira

Re: [PATCH] media: i2c: OV5647: gate clock lane before stream on

2017-08-07 Thread Luis Oliveira
Hi all, I'm new here, I got to be Maintainer of this driver by the old Maintainer recommendation. Still getting the hang of it :) On 07-Aug-17 13:26, Philipp Zabel wrote: > Hi Jacob, > > On Mon, 2017-08-07 at 19:06 +0800, Jacob Chen wrote: > [...] > --- a/drivers/media/i2c/ov5647.c > +++

[PATCH v12 2/2] i2c: designware: enable SLAVE in platform module

2017-06-22 Thread Luis Oliveira
- Slave mode selected in platform module if the support is detected in the DT. Signed-off-by: Luis Oliveira Reviewed-by: Andy Shevchenko --- V11-V12 - no changes drivers/i2c/busses/i2c-designware-core.h| 2 ++ drivers/i2c/busses/i2c-designware-platdrv.c | 41

[PATCH v12 0/2] i2c: designware: add I2C SLAVE support

2017-06-22 Thread Luis Oliveira
SLAVE mode to be detected by the platform module. The functionality was tested using the hardware independent slave-eeprom driver based on top of i2c/for-next. The tree I used can be found here: https://git.kernel.org/cgit/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-next Luis Oliveira (2): i2c

[PATCH v12 1/2] i2c: designware: add SLAVE mode functions

2017-06-22 Thread Luis Oliveira
architecture. All the SLAVE flow is added but it is not enabled via platform driver. Signed-off-by: Luis Oliveira --- V11-v12 - Changed ifdef condition in the Makefile fixed Kbuild error drivers/i2c/busses/Kconfig | 14 +- drivers/i2c/busses/Makefile| 3 + drivers/i2c

Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

2017-06-19 Thread Luis Oliveira
On 19-Jun-17 17:05, Andy Shevchenko wrote: > On Mon, Jun 19, 2017 at 6:58 PM, Wolfram Sang wrote: >>> Believe me I've looked for mistakes like this but I've read the code so many >>> times I don't think I can see the obvious anymore. >> >> Yes, I know this. And you worked hard on this slave featur

Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

2017-06-14 Thread Luis Oliveira
On 14-Jun-17 13:20, Andy Shevchenko wrote: > On Wed, Jun 14, 2017 at 1:43 PM, Luis Oliveira > wrote: >> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support >> - Slave functions added to core library file >> - Slave abort sources added to common source file >>

[PATCH v11 2/6] i2c: designware: refactoring of the i2c-designware

2017-06-14 Thread Luis Oliveira
prepare the controller to have is I2C MASTER flow in a separate driver. To do this first all the functions/definitions related to the MASTER flow were identified. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko Acked-by: Jarkko Nikula --- v10-v11 - no changes drivers/i2c/busses/i2c

[PATCH v11 3/6] i2c: designware: MASTER mode as separated driver

2017-06-14 Thread Luis Oliveira
s now part of the "master" source. The difference is the functions used by both modes and they are in the "common" source file. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko Acked-by: Jarkko Nikula --- v10-v11 - checkpatch.pl told me to correct a few blank lines

[PATCH v11 1/6] i2c: designware: Cleaning and comment style fixes.

2017-06-14 Thread Luis Oliveira
ll make my future patch a lot bigger and complicated to review. The work here won't bring any additional work to backported fixes because is just style and reordering. Signed-off-by: Luis Oliveira Acked-by: Jarkko Nikula Reviewed-by: Andy Shevchenko --- v10-v11 - two extra spaces added to align t

[PATCH v11 0/6] i2c: designware: add I2C SLAVE support

2017-06-14 Thread Luis Oliveira
platform module. The functionality was tested using the hardware independent slave-eeprom driver based on top of i2c/for-next. The tree I used can be found here: https://git.kernel.org/cgit/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-next Luis Oliveira (6): i2c: designware: Cleaning and comment

[PATCH v11 5/6] i2c: designware: add SLAVE mode functions

2017-06-14 Thread Luis Oliveira
architecture. All the SLAVE flow is added but it is not enabled via platform driver. Signed-off-by: Luis Oliveira --- v10-v11 - select I2C_DESIGNWARE_SLAVE had to be moved to this patch drivers/i2c/busses/Kconfig | 14 +- drivers/i2c/busses/Makefile| 3 + drivers/i2c

[PATCH v11 6/6] i2c: designware: enable SLAVE in platform module

2017-06-14 Thread Luis Oliveira
- Slave mode selected in platform module if the support is detected in the DT. Signed-off-by: Luis Oliveira --- v10-v11 - no changes drivers/i2c/busses/i2c-designware-core.h| 2 ++ drivers/i2c/busses/i2c-designware-platdrv.c | 41 + 2 files changed, 38

[PATCH v11 4/6] i2c: designware: introducing I2C_SLAVE definitions

2017-06-14 Thread Luis Oliveira
- Definitions were added to core library - A example was added to designware-core.txt Documentation that shows how the slave can be setup using DTS SLAVE related definitions were added to the core of the controller. Signed-off-by: Luis Oliveira Reviewed-by: Andy Shevchenko Acked-by: Rob

Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.

2017-06-09 Thread Luis Oliveira
On 09-Jun-17 6:12, Peter Rosin wrote: > On 2017-06-08 19:36, Luis Oliveira wrote: >> complicated to review. The work here won't bring any additional work to >> backported fixes because is just style and reordering. > > I challenge that. If there is an old bug that existe

[PATCH v10 4/6] i2c: designware: introducing I2C_SLAVE definitions

2017-06-08 Thread Luis Oliveira
- Definitions were added to core library - A example was added to designware-core.txt Documentation that shows how the slave can be setup using DTS SLAVE related definitions were added to the core of the controller. Signed-off-by: Luis Oliveira Reviewed-by: Andy Shevchenko Acked-by: Rob

[PATCH v10 3/6] i2c: designware: MASTER mode as separated driver

2017-06-08 Thread Luis Oliveira
s now part of the "master" source. The difference is the functions used by both modes and they are in the "common" source file. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko Acked-by: Jarkko Nikula --- v9-v10 - no changes drivers/i2c/busses/Makefile

[PATCH v10 6/6] i2c: designware: enable SLAVE in platform module

2017-06-08 Thread Luis Oliveira
- Slave mode selected in platform module if the support is detected in the DT. Signed-off-by: Luis Oliveira --- v9-v10 - Removed "default y" from Kconfig because it was not needed (only for tests) drivers/i2c/busses/Kconfig | 1 + drivers/i2c/busses/i2c-designw

[PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.

2017-06-08 Thread Luis Oliveira
ll make my future patch a lot bigger and complicated to review. The work here won't bring any additional work to backported fixes because is just style and reordering. Signed-off-by: Luis Oliveira Acked-by: Jarkko Nikula Reviewed-by: Andy Shevchenko --- v9-v10 - no changes dri

[PATCH v10 2/6] i2c: designware: refactoring of the i2c-designware

2017-06-08 Thread Luis Oliveira
prepare the controller to have is I2C MASTER flow in a separate driver. To do this first all the functions/definitions related to the MASTER flow were identified. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko Acked-by: Jarkko Nikula --- v9-v10 - no changes drivers/i2c/busses/i2c

[PATCH v10 5/6] i2c: designware: add SLAVE mode functions

2017-06-08 Thread Luis Oliveira
architecture. All the SLAVE flow is added but it is not enabled via platform driver. Signed-off-by: Luis Oliveira --- v9-v10 (@Andy) - Fixed Makefile selection of I2C_DESIGNWARE_SLAVE as suggested - Corrected wrong comments - Little refactoring on irq_handler_slave flow drivers/i2c/busses/Kconfig

[PATCH v10 0/6] i2c: designware: add I2C SLAVE support

2017-06-08 Thread Luis Oliveira
platform module. The functionality was tested using the hardware independent slave-eeprom driver based on top of i2c/for-next. The tree I used can be found here: https://git.kernel.org/cgit/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-next Luis Oliveira (6): i2c: designware: Cleaning and comment

Re: [PATCH v9 5/6] i2c: designware: add SLAVE mode functions

2017-05-22 Thread Luis Oliveira
On 08-May-17 17:53, Andy Shevchenko wrote: > On Mon, 2017-05-08 at 11:37 +0100, Luis Oliveira wrote: >> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support >> - Slave functions added to core library file >> - Slave abort sources added to common source file >> -

[PATCH v9 2/6] i2c: designware: refactoring of the i2c-designware

2017-05-08 Thread Luis Oliveira
prepare the controller to have is I2C MASTER flow in a separate driver. To do this first all the functions/definitions related to the MASTER flow were identified. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko Acked-by: Jarkko Nikula --- v8-v9 - no changes drivers/i2c/busses/i2c

[PATCH v9 5/6] i2c: designware: add SLAVE mode functions

2017-05-08 Thread Luis Oliveira
architecture. All the SLAVE flow is added but it is not enabled via platform driver. Signed-off-by: Luis Oliveira --- v8-v9 - removed I2C_SLAVE_EEPROM selection drivers/i2c/busses/Kconfig | 13 +- drivers/i2c/busses/Makefile| 1 + drivers/i2c/busses/i2c-designware

[PATCH v9 3/6] i2c: designware: MASTER mode as separated driver

2017-05-08 Thread Luis Oliveira
s now part of the "master" source. The difference is the functions used by both modes and they are in the "common" source file. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko Acked-by: Jarkko Nikula --- v8-v9 - no changes drivers/i2c/busses/Makefile

[PATCH v9 6/6] i2c: designware: enable SLAVE in platform module

2017-05-08 Thread Luis Oliveira
- Slave mode selected in platform module if the support is detected in the DT. Signed-off-by: Luis Oliveira --- v8-v9 - fixed kbuild error regarding I2C_DESIGNWARE_SLAVE auto selection to correctly compile the module drivers/i2c/busses/Kconfig | 2 ++ drivers/i2c/busses

[PATCH v9 4/6] i2c: designware: introducing I2C_SLAVE definitions

2017-05-08 Thread Luis Oliveira
- Definitions were added to core library - A example was added to designware-core.txt Documentation that shows how the slave can be setup using DTS SLAVE related definitions were added to the core of the controller. Signed-off-by: Luis Oliveira Reviewed-by: Andy Shevchenko Acked-by: Rob

[PATCH v9 0/6] i2c: designware: add I2C SLAVE support

2017-05-08 Thread Luis Oliveira
platform module. The functionality was tested using the hardware independent slave-eeprom driver based on top of i2c/for-next. The tree I used can be found here: https://git.kernel.org/cgit/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-next Luis Oliveira (6): i2c: designware: Cleaning and comment

[PATCH v9 1/6] i2c: designware: Cleaning and comment style fixes.

2017-05-08 Thread Luis Oliveira
ll make my future patch a lot bigger and complicated to review. The work here won't bring any additional work to backported fixes because is just style and reordering. Signed-off-by: Luis Oliveira Acked-by: Jarkko Nikula Reviewed-by: Andy Shevchenko --- v8-v9 - no changes dri

Re: [PATCH v8 5/6] i2c: designware: add SLAVE mode functions

2017-04-20 Thread Luis Oliveira
On 20-Apr-17 13:50, Jarkko Nikula wrote: > On 04/12/2017 07:47 PM, Luis Oliveira wrote: >> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support >> - Slave functions added to core library file >> - Slave abort sources added to common source file >> - New driver:

[PATCH] staging: media: atomisp: fix misspelled word in comment

2017-04-19 Thread Luis Oliveira
This fix "overrided", the correct past tense form of "override" is "overridden". Signed-off-by: Luis Oliveira --- drivers/staging/media/atomisp/i2c/ov2680.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/i2c/ov2

[PATCH v8 2/6] i2c: designware: refactoring of the i2c-designware

2017-04-12 Thread Luis Oliveira
prepare the controller to have is I2C MASTER flow in a separate driver. To do this first all the functions/definitions related to the MASTER flow were identified. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko Acked-by: Jarkko Nikula --- v7-v8 - no changes drivers/i2c/busses/i2c

[PATCH v8 4/6] i2c: designware: introducing I2C_SLAVE definitions

2017-04-12 Thread Luis Oliveira
- Definitions were added to core library - A example was added to designware-core.txt Documentation that shows how the slave can be setup using DTS SLAVE related definitions were added to the core of the controller. Signed-off-by: Luis Oliveira Reviewed-by: Andy Shevchenko Acked-by: Rob

[PATCH v8 6/6] i2c: designware: enable SLAVE in platform module

2017-04-12 Thread Luis Oliveira
- Slave mode selected in platform module if the support is detected in the DT. Signed-off-by: Luis Oliveira --- v7-v8 - moved "bool mode;" comment/description to this patch drivers/i2c/busses/Kconfig | 1 + drivers/i2c/busses/i2c-designware-core.h| 2 ++ d

[PATCH v8 5/6] i2c: designware: add SLAVE mode functions

2017-04-12 Thread Luis Oliveira
architecture. All the SLAVE flow is added but it is not enabled via platform driver. Signed-off-by: Luis Oliveira --- v7-v8 - no changes drivers/i2c/busses/Kconfig | 14 +- drivers/i2c/busses/Makefile| 1 + drivers/i2c/busses/i2c-designware-common.c | 6 + drivers

[PATCH v8 1/6] i2c: designware: Cleaning and comment style fixes.

2017-04-12 Thread Luis Oliveira
ll make my future patch a lot bigger and complicated to review. The work here won't bring any additional work to backported fixes because is just style and reordering. Signed-off-by: Luis Oliveira Acked-by: Jarkko Nikula Reviewed-by: Andy Shevchenko --- v7-v8 - no changes dri

[PATCH v8 3/6] i2c: designware: MASTER mode as separated driver

2017-04-12 Thread Luis Oliveira
s now part of the "master" source. The difference is the functions used by both modes and they are in the "common" source file. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko --- v7-v8 - removed "@dynamic_tar_update_enabled" comment drivers/i2c/buss

[PATCH v8 0/6] i2c: designware: add I2C SLAVE support

2017-04-12 Thread Luis Oliveira
platform module. The functionality was tested using the hardware independent slave-eeprom driver based on top of i2c/for-next. The tree I used can be found here: https://git.kernel.org/cgit/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-next Luis Oliveira (6): i2c: designware: Cleaning and comment

Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver

2017-03-22 Thread Luis Oliveira
On 22-Mar-17 14:47, Jarkko Nikula wrote: > On 03/20/17 13:10, Luis Oliveira wrote: >> - The functions related to I2C master mode of operation were transformed >> in a single driver. >> - Common definitions were moved to i2c-designware-core.h >> - The i2c-designware

[PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions

2017-03-20 Thread Luis Oliveira
- Definitions were added to core library - A example was added to designware-core.txt Documentation that shows how the slave can be setup using DTS SLAVE related definitions were added to the core of the controller. Signed-off-by: Luis Oliveira Reviewed-by: Andy Shevchenko Acked-by: Rob

[PATCH v7 3/6] i2c: designware: MASTER mode as separated driver

2017-03-20 Thread Luis Oliveira
s now part of the "master" source. The difference is the functions used by both modes and they are in the "common" source file. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko --- v6-v7 - Moved kernel doc comments from patch 4/6 to this patch. @Jarkko - Fix Design

[PATCH v7 5/6] i2c: designware: add SLAVE mode functions

2017-03-20 Thread Luis Oliveira
architecture. All the SLAVE flow is added but it is not enabled via platform driver. Signed-off-by: Luis Oliveira --- v6-v7 - changed error description in [ABRT_SLAVE_RD_INTX]. @Jarkko - moved "bool mode;" comment/description to this patch drivers/i2c/busses/Kconfig | 14 +- d

[PATCH v7 6/6] i2c: designware: enable SLAVE in platform module

2017-03-20 Thread Luis Oliveira
- Slave mode selected in platform module if the support is detected in the DT. Signed-off-by: Luis Oliveira --- v6-v7 - no changes drivers/i2c/busses/Kconfig | 1 + drivers/i2c/busses/i2c-designware-platdrv.c | 41 + 2 files changed, 37

[PATCH v7 2/6] i2c: designware: refactoring of the i2c-designware

2017-03-20 Thread Luis Oliveira
prepare the controller to have is I2C MASTER flow in a separate driver. To do this first all the functions/definitions related to the MASTER flow were identified. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko Acked-by: Jarkko Nikula --- v6-v7 - no changes drivers/i2c/busses/i2c

[PATCH v7 0/6] i2c: designware: add I2C SLAVE support

2017-03-20 Thread Luis Oliveira
platform module. The functionality was tested using the hardware independent slave-eeprom driver based on top of i2c/for-next. The tree I used can be found here: https://git.kernel.org/cgit/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-next Luis Oliveira (6): i2c: designware: Cleaning and comment

[PATCH v7 1/6] i2c: designware: Cleaning and comment style fixes.

2017-03-20 Thread Luis Oliveira
ll make my future patch a lot bigger and complicated to review. The work here won't bring any additional work to backported fixes because is just style and reordering. Signed-off-by: Luis Oliveira Acked-by: Jarkko Nikula Reviewed-by: Andy Shevchenko --- v6-v7 - no changes dri

Re: [RESEND PATCH v6 5/6] i2c: designware: add SLAVE mode functions

2017-03-17 Thread Luis Oliveira
On 02-Mar-17 15:17, Luis Oliveira wrote: > On 02-Mar-17 14:33, Jarkko Nikula wrote: >> On 03/01/17 17:59, Luis Oliveira wrote: >>> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support >>> - Slave functions added to core library file >>> - Slave abort

Re: [RESEND PATCH v6 3/6] i2c: designware: MASTER mode as separated driver

2017-03-02 Thread Luis Oliveira
On 02-Mar-17 13:41, Jarkko Nikula wrote: > On 03/01/17 17:59, Luis Oliveira wrote: >> - The functions related to I2C master mode of operation were transformed >> in a single driver. >> - Common definitions were moved to i2c-designware-core.h >> - The i2c-designware

Re: [RESEND PATCH v6 5/6] i2c: designware: add SLAVE mode functions

2017-03-02 Thread Luis Oliveira
On 02-Mar-17 14:33, Jarkko Nikula wrote: > On 03/01/17 17:59, Luis Oliveira wrote: >> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support >> - Slave functions added to core library file >> - Slave abort sources added to common source file >> - New driver:

[RESEND PATCH v6 5/6] i2c: designware: add SLAVE mode functions

2017-03-01 Thread Luis Oliveira
architecture. All the SLAVE flow is added but it is not enabled via platform driver. Signed-off-by: Luis Oliveira --- V5->V6 - Enable Slave mode using a different option (kbuild reported an error) - Identation fixes needed - Changed debug prints to dev_vdbg - Fixed slave enumeration drivers/i2c/bus

[RESEND PATCH v6 2/6] i2c: designware: refactoring of the i2c-designware

2017-03-01 Thread Luis Oliveira
prepare the controller to have is I2C MASTER flow in a separate driver. To do this first all the functions/definitions related to the MASTER flow were identified. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko --- V5->v6 - Removed the __func__ of dev_dbg prints - Fix i2c_dw_configure_mas

[RESEND PATCH v6 6/6] i2c: designware: enable SLAVE in platform module

2017-03-01 Thread Luis Oliveira
- Slave mode selected in platform module if the support is detected in the DT. Signed-off-by: Luis Oliveira --- V5->V6 - No changes drivers/i2c/busses/Kconfig | 1 + drivers/i2c/busses/i2c-designware-platdrv.c | 41 + 2 files changed,

[RESEND PATCH v6 3/6] i2c: designware: MASTER mode as separated driver

2017-03-01 Thread Luis Oliveira
and they are in the "common" source file. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko --- V5->V6 - Now using ops drivers/i2c/busses/Makefile| 1 + drivers/i2c/busses/i2c-designware-common.c | 274 +++ drivers/i2c/busses/i2c-

[RESEND PATCH v6 1/6] i2c: designware: Cleaning and comment style fixes.

2017-03-01 Thread Luis Oliveira
ll make my future patch a lot bigger and complicated to review. The work here won't bring any additional work to backported fixes because is just style and reordering. Signed-off-by: Luis Oliveira Acked-by: Jarkko Nikula Reviewed-by: Andy Shevchenko --- - Added the replacement of "r"

[RESEND PATCH v6 4/6] i2c: designware: introducing I2C_SLAVE definitions

2017-03-01 Thread Luis Oliveira
- Definitions were added to core library - A example was added to designware-core.txt Documentation that shows how the slave can be setup using DTS SLAVE related definitions were added to the core of the controller. Signed-off-by: Luis Oliveira Reviewed-by: Andy Shevchenko Acked-by: Rob

[RESEND PATCH v6 0/6] i2c: designware: add I2C SLAVE support

2017-03-01 Thread Luis Oliveira
platform module. The functionality was tested using the hardware independent slave-eeprom driver based on top of i2c/for-next. The tree I used can be found here: https://git.kernel.org/cgit/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-next Luis Oliveira (6): i2c: designware: Cleaning and comment

[PATCH v6 5/6] i2c: designware: add SLAVE mode functions

2017-02-15 Thread Luis Oliveira
architecture. All the SLAVE flow is added but it is not enabled via platform driver. Signed-off-by: Luis Oliveira --- V5->V6 - Enable Slave mode using a different option (kbuild reported an error) - Identation fixes needed - Changed debug prints to dev_vdbg - Fixed slave enumeration drivers/i2c/bus

[PATCH v6 6/6] i2c: designware: enable SLAVE in platform module

2017-02-15 Thread Luis Oliveira
- Slave mode selected in platform module if the support is detected in the DT. Signed-off-by: Luis Oliveira --- V5->V6 - No changes drivers/i2c/busses/Kconfig | 1 + drivers/i2c/busses/i2c-designware-platdrv.c | 41 + 2 files changed,

[PATCH v6 3/6] i2c: designware: MASTER mode as separated driver

2017-02-15 Thread Luis Oliveira
and they are in the "common" source file. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko --- V5->V6 - Now using ops drivers/i2c/busses/Makefile| 1 + drivers/i2c/busses/i2c-designware-common.c | 274 +++ drivers/i2c/busses/i2c-

[PATCH v6 4/6] i2c: designware: introducing I2C_SLAVE definitions

2017-02-15 Thread Luis Oliveira
- Definitions were added to core library - A example was added to designware-core.txt Documentation that shows how the slave can be setup using DTS SLAVE related definitions were added to the core of the controller. Signed-off-by: Luis Oliveira Reviewed-by: Andy Shevchenko --- V5->

[PATCH v6 2/6] i2c: designware: refactoring of the i2c-designware

2017-02-15 Thread Luis Oliveira
prepare the controller to have is I2C MASTER flow in a separate driver. To do this first all the functions/definitions related to the MASTER flow were identified. Signed-off-by: Luis Oliveira Acked-by: Andy Shevchenko --- V5->v6 - Removed the __func__ of dev_dbg prints - Fix i2c_dw_configure_mas

[PATCH v6 1/6] i2c: designware: Cleaning and comment style fixes.

2017-02-15 Thread Luis Oliveira
ll make my future patch a lot bigger and complicated to review. The work here won't bring any additional work to backported fixes because is just style and reordering. Signed-off-by: Luis Oliveira Acked-by: Jarkko Nikula --- V5->v6 - Added the replacement of "r" for "ret" r

[PATCH v6 0/6] i2c: designware: add I2C SLAVE support

2017-02-15 Thread Luis Oliveira
platform module. The functionality was tested using the hardware independent slave-eeprom driver based on top of i2c/for-next. The tree I used can be found here: https://git.kernel.org/cgit/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-next Luis Oliveira (6): i2c: designware: Cleaning and comment

[PATCH v4] i2c: core: helper function to detect slave mode

2017-01-26 Thread Luis Oliveira
This function has the purpose of mode detection by checking the device nodes for a reg matching with the I2C_OWN_SLAVE_ADDREESS flag. Currently only checks using OF functions (ACPI slave not supported yet). Signed-off-by: Luis Oliveira Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko

Re: [PATCH v3] i2c: core: helper function to detect slave mode

2017-01-26 Thread Luis Oliveira
On 25-Jan-17 20:45, Wolfram Sang wrote: > >> + * i2c_slave_mode_detect - detect operation mode > > I'd rather name it 'i2c_detect_slave_mode' I will do a V4 with this change. > >> + * @dev: The device owning the bus >> + * >> + * This checks the device nodes for an I2C slave by checking the a

[PATCH v3] i2c: core: helper function to detect slave mode

2017-01-17 Thread Luis Oliveira
This function has the purpose of mode detection by checking the device nodes for a reg matching with the I2C_OWN_SLAVE_ADDREESS flag. Currently only checks using OF functions (ACPI slave not supported yet). Signed-off-by: Luis Oliveira Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko

Re: [PATCH] i2c: core: helper function to detect slave mode

2017-01-16 Thread Luis Oliveira
On 12-Jan-17 17:01, Andy Shevchenko wrote: > On Sat, 2017-01-07 at 03:24 +0200, Vladimir Zapolskiy wrote: >> On 01/07/2017 02:19 AM, Andy Shevchenko wrote: >>> On Sat, Jan 7, 2017 at 1:43 AM, Vladimir Zapolskiy >>> wrote: On 01/07/2017 12:45 AM, Andy Shevchenko wrote: > > + }

[PATCH v2] i2c: core: helper function to detect slave mode

2017-01-06 Thread Luis Oliveira
This function has the purpose of mode detection by checking the device nodes for a reg matching with the I2C_OWN_SLAVE_ADDREESS flag. Currently only checks using OF functions (ACPI slave not supported yet). Signed-off-by: Luis Oliveira Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko

Re: [PATCH] i2c: core: helper function to detect slave mode

2017-01-06 Thread Luis Oliveira
On 06-Jan-17 17:17, Andy Shevchenko wrote: > On Fri, Jan 6, 2017 at 7:15 PM, Luis Oliveira > wrote: >> On 06-Jan-17 16:29, Andy Shevchenko wrote: >>> On Thu, Jan 5, 2017 at 7:24 PM, Luis Oliveira > >>> Please, add kernel doc description here, important thing

Re: [PATCH] i2c: core: helper function to detect slave mode

2017-01-06 Thread Luis Oliveira
On 06-Jan-17 16:29, Andy Shevchenko wrote: > On Thu, Jan 5, 2017 at 7:24 PM, Luis Oliveira > wrote: >> This function has the purpose of mode detection by checking the >> device nodes for a reg matching with the I2C_OWN_SLAVE_ADDREESS flag. >> Currently only checks using

Re: [PATCH] i2c: core: helper function to detect slave mode

2017-01-06 Thread Luis Oliveira
On 06-Jan-17 16:35, Rob Herring wrote: > On Thu, Jan 5, 2017 at 11:24 AM, Luis Oliveira > wrote: >> This function has the purpose of mode detection by checking the >> device nodes for a reg matching with the I2C_OWN_SLAVE_ADDREESS flag. >> Currently only checks using OF f

[PATCH] i2c: core: helper function to detect slave mode

2017-01-05 Thread Luis Oliveira
This function has the purpose of mode detection by checking the device nodes for a reg matching with the I2C_OWN_SLAVE_ADDREESS flag. Currently only checks using OF functions (ACPI slave not supported yet). Signed-off-by: Luis Oliveira --- Due to the need of checking if the I2C slave address is

Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module

2017-01-05 Thread Luis Oliveira
On 28-Dec-16 18:10, Luis Oliveira wrote: > On 28-Dec-16 17:10, Andy Shevchenko wrote: >> On Wed, 2016-12-28 at 16:41 +0000, Luis Oliveira wrote: >>> On 28-Dec-16 16:31, Andy Shevchenko wrote: >>>> On Wed, 2016-12-28 at 15:53 +, Luis Oliveira wrote: >>>

Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module

2016-12-28 Thread Luis Oliveira
On 28-Dec-16 17:10, Andy Shevchenko wrote: > On Wed, 2016-12-28 at 16:41 +0000, Luis Oliveira wrote: >> On 28-Dec-16 16:31, Andy Shevchenko wrote: >>> On Wed, 2016-12-28 at 15:53 +0000, Luis Oliveira wrote: >>>> On 28-Dec-16 15:44, Andy Shevchenko wrote: >>&

Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module

2016-12-28 Thread Luis Oliveira
On 28-Dec-16 16:31, Andy Shevchenko wrote: > On Wed, 2016-12-28 at 15:53 +0000, Luis Oliveira wrote: >> On 28-Dec-16 15:44, Andy Shevchenko wrote: >>> On Wed, 2016-12-28 at 14:43 +0000, Luis Oliveira wrote: >>>> - Slave mode selected in platform module (devicetree

Re: [PATCH v5 5/7] i2c: designware: add SLAVE mode functions

2016-12-28 Thread Luis Oliveira
On 28-Dec-16 15:36, Andy Shevchenko wrote: > On Wed, 2016-12-28 at 14:43 +0000, Luis Oliveira wrote: >> - Changes in Kconfig to enable I2C_SLAVE support >> - Slave functions added to core library file >> - Slave abort sources added to common source file >> - New driver:

Re: [PATCH v5 6/7] i2c: designware: enable SLAVE in platform module

2016-12-28 Thread Luis Oliveira
On 28-Dec-16 15:44, Andy Shevchenko wrote: > On Wed, 2016-12-28 at 14:43 +0000, Luis Oliveira wrote: >> - Slave mode selected in platform module (devicetree support only) >> - Check for ACPI - not supported in SLAVE mode: >> - Changed the ifndef style to the use of ACP

Re: [PATCH v5 2/7] i2c: designware: refactoring of the i2c-designware

2016-12-28 Thread Luis Oliveira
On 28-Dec-16 15:12, Andy Shevchenko wrote: > On Wed, 2016-12-28 at 14:43 +0000, Luis Oliveira wrote: >> - Factor out all _master() part of code from i2c-designware-core >> and i2c-designware-platdrv to separate functions. >> - Standardize all code related with MASTER mode

[PATCH v5 6/7] i2c: designware: enable SLAVE in platform module

2016-12-28 Thread Luis Oliveira
- Slave mode selected in platform module (devicetree support only) - Check for ACPI - not supported in SLAVE mode: - Changed the ifndef style to the use of ACPI_HANDLE that returns NULL if the device was not enumerated from ACPI namespace. Signed-off-by: Luis Oliveira --- Changes V4->

[PATCH v5 2/7] i2c: designware: refactoring of the i2c-designware

2016-12-28 Thread Luis Oliveira
prepare the controller to have is I2C MASTER flow in a separate driver. To do this first all the functions/definitions related to the MASTER flow were identified. Signed-off-by: Luis Oliveira --- Changes V4->V5: (ACK by Andy) Fixed the bellow issues: - Removed a part belonging to slave pa

[PATCH v5 1/7] i2c: designware: Cleaning and comment style fixes.

2016-12-28 Thread Luis Oliveira
e and reordering. Signed-off-by: Luis Oliveira --- Changes V5 (Jarkko): - This patch was submitted by it self and it god ACK. I need it in the patchset because the next patch relly on this one. - Also fixed the commit length. drivers/i2c/busses/i2c-designware-core.c

[PATCH v5 3/7] i2c: designware: MASTER mode as separated driver

2016-12-28 Thread Luis Oliveira
by both i2c-designware-master and i2c-designware-slave. Almost all of the "core" source is now part of the "master" source. The difference is the functions used by both modes and they are in the "common" source file. Signed-off-by: Luis Oliveira --- Changes V4-&

[PATCH v5 5/7] i2c: designware: add SLAVE mode functions

2016-12-28 Thread Luis Oliveira
driver. Signed-off-by: Luis Oliveira --- Changes V4->V5: (Andy Shevchenko) - This patch adds the SLAVE support functions but it still not enable it via platform module. I think it is more readable now drivers/i2c/busses/Kconfig | 3 +- drivers/i2c/busses/Makef

[PATCH v5 4/7] i2c: designware: introducing I2C_SLAVE definitions

2016-12-28 Thread Luis Oliveira
- Definitions were added SLAVE related definitions were added to the core of the controller. Signed-off-by: Luis Oliveira --- Changes V4->V5: (Andy Shevchenko) - This patch just introduces SLAVE definitions (as suggested in V4) drivers/i2c/busses/i2c-designware-core.h |

[PATCH v5 0/7] i2c: designware: add I2C SLAVE support

2016-12-28 Thread Luis Oliveira
evaluating if is a I2C_OWN_SLAVE_ADDRESS". ACPI is not supported in this driver. The functionality was tested using the hardware independent software backend slave-eeprom driver. Luis Oliveira (7): i2c: designware: Cleaning and comment style fixes. i2c: designware: refactoring of the i2c-desig

[PATCH v5 7/7] i2c: designware: style changes in existing code

2016-12-28 Thread Luis Oliveira
Replaced all the return variables 'r' in the existing code by 'ret' to make the code easier to read (and more standard). Signed-off-by: Luis Oliveira --- Changes V4->V5: (Andy Shevchenko) - Replaced all the old code using "r" as return to "ret". For

  1   2   >