Re: [PATCH] iio: trigger: Print an error if there is no available irq

2019-02-13 Thread Martin Kelly
On 2/13/19 5:17 AM, Mathieu Othacehe wrote: > If there are more trigger consumers than > CONFIG_IIO_CONSUMERS_PER_TRIGGER, iio_trigger_attach_poll_func will > silently fail. Add an error message to inform the user that > CONFIG_IIO_CONSUMERS_PER_TRIGGER limit might be exceeded. > > Signed-off-by:

Re: [PATCH 4.14 058/105] tools: fix cross-compile var clobbering

2019-01-12 Thread Martin Kelly
On 1/12/19 1:18 PM, Sudip Mukherjee wrote: Hi Greg, On Fri, Jan 11, 2019 at 2:34 PM Greg Kroah-Hartman wrote: 4.14-stable review patch. If anyone has any objections, please let me know. -- From: Martin Kelly commit 7ed1c1901fe52e6c5828deb155920b44b0adabb1 upstream

Re: [PATCH 1/1] tools: power/acpi, revert to LD = gcc

2018-04-24 Thread Martin Kelly
ls pass CFLAGS to the linker (incl. -D_LINUX), so revert this > particular change and let LD be $(CC) again. Note that the old behaviour > was a bit different, it used $(CROSS_COMPILE)gcc which was eliminated by > the commit 7ed1c1901fe5. We use $(CC) for that reason. > > Signed-o

Re: [PATCH v2] tools: fix cross-compile var clobbering

2018-04-04 Thread Martin Kelly
On 04/04/2018 06:20 AM, Jiri Slaby wrote: On 01/07/2018, 10:40 PM, Martin Kelly wrote: From: Martin Kelly ... --- a/tools/power/acpi/Makefile.config +++ b/tools/power/acpi/Makefile.config @@ -56,9 +56,6 @@ INSTALL_SCRIPT = ${INSTALL_PROGRAM} # to compile vs uClibc, that can be done here as

Re: [linux-sunxi] [PATCH v9 0/2] Initial Allwinner V3s CSI Support

2018-03-29 Thread Martin Kelly
On 03/28/2018 06:02 PM, Yong wrote: AFAIK, there is no document about MIPI CSI-2. You can take a look at the source code in BSP: https://github.com/friendlyarm/h3_lichee/tree/master/linux-3.4/drivers/media/video/sunxi-vfe/mipi_csi And try to port it to mainline. Yep, I see there's lots of mag

Re: [linux-sunxi] [PATCH v9 0/2] Initial Allwinner V3s CSI Support

2018-03-28 Thread Martin Kelly
On 03/05/2018 05:51 PM, Yong Deng wrote: This patchset add initial support for Allwinner V3s CSI. Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2 interface and CSI1 is used for parallel interface. This is not documented in datasheet but by test and guess. This patchset im

[PATCH] kfifo: fix inaccurate comment

2018-03-26 Thread Martin Kelly
The comment in __kfifo_alloc says we round down, but we actually round up, so correct it. Signed-off-by: Martin Kelly --- lib/kfifo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/kfifo.c b/lib/kfifo.c index 90ba1eb1df06..b0f757bf7213 100644 --- a/lib/kfifo.c +++ b/lib

Kredit? so schnell wie möglich?

2018-01-31 Thread Martin Kelly
Kredit? so schnell wie möglich? unkompliziert und seriös ? Bei uns genau richtig. Wir arbeiten europaweit. Wir vermitteln Kredite und Darlehen zu fairen Konditionen. Durch unsere seriöse, kompetente und ehrliche Kreditberatung haben wir über Jahre eine starke Position auf dem Markt.

Re: [PATCH] tools: fix cross-compile var export

2018-01-07 Thread Martin Kelly
On 01/07/2018 11:04 AM, Paul Gortmaker wrote: [Re: [PATCH] tools: fix cross-compile var export] On 07/01/2018 (Sun 10:31) Martin Kelly wrote: [...] With the change, we add do CC = $(CROSS_COMPILE)gcc if and only if CC is not already set. I'm happy to add all these details to the c

[PATCH v2] tools: fix cross-compile var clobbering

2018-01-07 Thread Martin Kelly
From: Martin Kelly Currently a number of Makefiles break when used with toolchains that pass extra flags in CC and other cross-compile related variables (such as --sysroot). Thus we get this error when we use a toolchain that puts --sysroot in the CC var: ~/src/linux/tools$ make iio [snip

Re: [PATCH] tools: fix cross-compile var export

2018-01-07 Thread Martin Kelly
On 01/07/2018 10:31 AM, Martin Kelly wrote: On 01/07/2018 08:11 AM, Paul Gortmaker wrote: [[PATCH] tools: fix cross-compile var export] On 06/01/2018 (Sat 12:16) Martin Kelly wrote: From: Martin Kelly Currently in a number of Makefiles, we clobber the CC, LD, and/or STRIP env vars when

Re: [PATCH] tools: fix cross-compile var export

2018-01-07 Thread Martin Kelly
On 01/07/2018 08:11 AM, Paul Gortmaker wrote: [[PATCH] tools: fix cross-compile var export] On 06/01/2018 (Sat 12:16) Martin Kelly wrote: From: Martin Kelly Currently in a number of Makefiles, we clobber the CC, LD, and/or STRIP env vars when cross-compiling, which breaks any additional

[PATCH] tools: fix cross-compile var export

2018-01-06 Thread Martin Kelly
From: Martin Kelly Currently in a number of Makefiles, we clobber the CC, LD, and/or STRIP env vars when cross-compiling, which breaks any additional flags that might be set (such as sysroot). This easily shows up by using, for instance, a Yocto SDK. Fix this by more carefully overriding the

Wir bieten jedem ein GÜNSTIGES Darlehnen zu TOP Konditionen an

2017-11-03 Thread Martin Kelly
Sehr geehrte Damen und Herren, Sie brauchen Geld? Sie sind auf der suche nach einem Darlehnen? Seriös und unkompliziert? Dann sind Sie hier bei uns genau richtig. Durch unsere jahrelange Erfahrung und kompetente Beratung sind wir Europaweit tätig. Wir bieten jedem ein GÜNSTIGES Darlehnen zu TOP

Wir bieten jedem ein GÜNSTIGES Darlehnen zu TOP Konditionen an

2017-11-03 Thread Martin Kelly
Sehr geehrte Damen und Herren, Sie brauchen Geld? Sie sind auf der suche nach einem Darlehnen? Seriös und unkompliziert? Dann sind Sie hier bei uns genau richtig. Durch unsere jahrelange Erfahrung und kompetente Beratung sind wir Europaweit tätig. Wir bieten jedem ein GÜNSTIGES Darlehnen zu TOP

[PATCH] kconfig/merge_config.sh: add -C to choose make dir

2016-05-13 Thread Martin Kelly
This is useful for running the script from somewhere besides the root of the source tree. Signed-off-by: Martin Kelly --- scripts/kconfig/merge_config.sh | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig

[PATCH] selftest, x86: fix incorrect comment

2015-05-22 Thread Martin Kelly
The current comment indicates it's checking for a 32-bit build environment, but it actually checks for a 64-bit environment. Fix this. Signed-off-by: Martin Kelly --- tools/testing/selftests/x86/trivial_64bit_program.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [PATCH] CodingStyle: Add a chapter on conditional compilation

2014-10-29 Thread Martin Kelly
On 10/29/2014 11:15 AM, Josh Triplett wrote: > Document several common practices and conventions regarding conditional > compilation, most notably the preference for ifdefs in headers rather > than .c files. > > Signed-off-by: Josh Triplett > --- > > I found myself explaining a few of these unwr

Re: [PATCH v2] x86, e820: panic on sanitizing invalid memory map

2014-10-21 Thread Martin Kelly
On 10/21/2014 12:44 PM, Thomas Gleixner wrote: > On Tue, 21 Oct 2014, Martin Kelly wrote: >> On 10/21/2014 01:56 AM, Thomas Gleixner wrote: >> Thomas, do you see any issues with a revision that separates out the >> return values (0 for a map with 1 entry, -1 for a map with in

Re: [PATCH v2] x86, e820: panic on sanitizing invalid memory map

2014-10-21 Thread Martin Kelly
On 10/21/2014 01:56 AM, Thomas Gleixner wrote: >> This patch changes the behavior so that sanitize_e820_map is a void >> function. When the provided memory map has length 1 or it is sanitized >> (both ok cases), it returns nothing. If the provided memory map is >> invalid, then it panics. > > So y

Qemu hang introduced between next-20141013 and next-20141017

2014-10-20 Thread Martin Kelly
Hi, I have a minimal qemu setup that I used for testing development kernels. I have noticed that somewhere between next-20141013 and next-20141017, qemu started to hang at boot time, with no messages displayed on the console (previously, it would boot to a full userspace). I attempted to bisect it

Re: [PATCH] x86, e820: panic on sanitizing invalid memory map

2014-10-20 Thread Martin Kelly
On 10/17/2014 09:41 PM, Martin Kelly wrote: > sanitize_e820_map returns two possible values: > -1: Returned when either the provided memory map has length 1 (ok) or > when the provided memory map is invalid (not ok). > 0: Returned when the memory map was correctly sanitized. >

[PATCH v2] x86, e820: panic on sanitizing invalid memory map

2014-10-20 Thread Martin Kelly
handles it (except possibly by panicking). This patch changes the behavior so that sanitize_e820_map is a void function. When the provided memory map has length 1 or it is sanitized (both ok cases), it returns nothing. If the provided memory map is invalid, then it panics. Signed-off-by: Martin

[PATCH] x86, e820: panic on sanitizing invalid memory map

2014-10-17 Thread Martin Kelly
handles it (except possibly by panicking). This patch changes the behavior so that sanitize_e820_map is a void function. When the provided memory map has length 1 or it is sanitized (both ok cases), it returns nothing. If the provided memory map is invalid, then it panics. Signed-off-by: Martin

Re: [PATCH] xen/setup: add paranoid index check and warning

2014-10-16 Thread Martin Kelly
On 10/14/2014 09:28 AM, Martin Kelly wrote: > On Tue, Oct 14, 2014 at 9:09 AM, David Vrabel wrote: >> On 14/10/14 15:04, Martin Kelly wrote: >>> On 10/14/2014 02:22 AM, David Vrabel wrote: >>>> On 14/10/14 02:19, Martin Kelly wrote: >>>>> In a call to

[PATCH] x86/xen: panic on bad Xen-provided memory map

2014-10-16 Thread Martin Kelly
Panic if Xen provides a memory map with 0 entries. Although this is unlikely, it is better to catch the error at the point of seeing the map than later on as a symptom of some other crash. Signed-off-by: Martin Kelly --- arch/x86/xen/setup.c | 1 + 1 file changed, 1 insertion(+) diff --git a

Re: [PATCH] xen/setup: add paranoid index check and warning

2014-10-14 Thread Martin Kelly
On Tue, Oct 14, 2014 at 9:09 AM, David Vrabel wrote: > On 14/10/14 15:04, Martin Kelly wrote: >> On 10/14/2014 02:22 AM, David Vrabel wrote: >>> On 14/10/14 02:19, Martin Kelly wrote: >>>> In a call to set_phys_range_identity, i-1 is used without checking tha

Re: [Xen-devel] [PATCH 1/2] x86: separate out sanitize_e820_map return codes

2014-10-14 Thread Martin Kelly
On 10/14/2014 02:33 AM, David Vrabel wrote: > On 14/10/14 03:30, Martin Kelly wrote: >> Previously, sanitize_e820_map returned -1 in all cases in which it did >> nothing. However, sanitize_e820_map can do nothing either because the >> input map has size 1 (this is ok) or

Re: [PATCH] xen/setup: add paranoid index check and warning

2014-10-14 Thread Martin Kelly
On 10/14/2014 02:22 AM, David Vrabel wrote: > On 14/10/14 02:19, Martin Kelly wrote: >> In a call to set_phys_range_identity, i-1 is used without checking that >> i is non-zero. Although unlikely, a bug in the code before it could >> cause the value to be 0, leading to err

[PATCH 2/2] xen/setup: warn on bad Xen-supplied memory map

2014-10-13 Thread Martin Kelly
d-off-by: Martin Kelly --- arch/x86/xen/setup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index af72161..48c7072 100644 --- a/arch/x86/xen/setup.c +++ b/arch/x86/xen/setup.c @@ -608,7 +608,8 @@ char * __init xen_memory_setup

[PATCH 1/2] x86: separate out sanitize_e820_map return codes

2014-10-13 Thread Martin Kelly
two cases and treat them separately. Signed-off-by: Martin Kelly --- arch/x86/include/asm/e820.h | 5 + arch/x86/kernel/e820.c | 18 +++--- 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/arch/x86/include/asm/e820.h b/arch/x86/include/asm/e820.h index 779c2ef

[PATCH] xen/setup: add paranoid index check and warning

2014-10-13 Thread Martin Kelly
In a call to set_phys_range_identity, i-1 is used without checking that i is non-zero. Although unlikely, a bug in the code before it could cause the value to be 0, leading to erroneous behavior. This patch adds a check against 0 value and a corresponding warning. Signed-off-by: Martin Kelly

Re: [PATCH] context_tracking: Fix checkpatch warnings

2014-10-11 Thread Martin Kelly
On 09/25/2014 09:25 AM, Martin Kelly wrote: > On Mon, Sep 15, 2014 at 9:20 PM, Martin Kelly wrote: >> checkpatch emits several warnings for context_tracking.c, which are >> fixed in this patch: >> >> - No space after "(" >> - Lines longer than 80 c

Re: [PATCH] context_tracking: Fix checkpatch warnings

2014-09-25 Thread Martin Kelly
On Mon, Sep 15, 2014 at 9:20 PM, Martin Kelly wrote: > checkpatch emits several warnings for context_tracking.c, which are > fixed in this patch: > > - No space after "(" > - Lines longer than 80 characters > > Signed-off-by: Martin Kelly > ---

[tip:x86/platform] x86/platform/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n

2014-09-19 Thread tip-bot for Martin Kelly
Commit-ID: 9575a6a23a8081bc4c9d47d001621e2af0957c02 Gitweb: http://git.kernel.org/tip/9575a6a23a8081bc4c9d47d001621e2af0957c02 Author: Martin Kelly AuthorDate: Wed, 17 Sep 2014 07:17:56 -0700 Committer: Ingo Molnar CommitDate: Fri, 19 Sep 2014 13:02:21 +0200 x86/platform/pmc_atom: Fix

Re: [PATCH v2] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n

2014-09-17 Thread Martin Kelly
On 09/17/2014 05:24 AM, Ingo Molnar wrote: > > Just to paint the bike shed a bit, this could be further > simplified to something like: > > ... > > ret = pmc_dbgfs_register(pmc, pdev); > if (ret) > iounmap(pmc->regmap); > > return ret; > > and then your p

[PATCH v3] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n

2014-09-17 Thread Martin Kelly
When compiling with CONFIG_DEBUG_FS=n, gcc emits an unused variable warning for pmc_atom.c because "ret" is used only within the CONFIG_DEBUG_FS block. This patch adds a dummy #ifdef for pmc_dbgfs_register when CONFIG_DEBUG_FS=n to simplify the code and remove the warning. Signed-off-

Re: [PATCH v2] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n

2014-09-16 Thread Martin Kelly
On 09/16/2014 08:44 PM, Li, Aubrey wrote: > > Why do you want to call pmc_dbgfs_register() anyway even if > CONFIG_DEBUG_FS=n? > > Thanks, > -Aubrey > The compiler will optimize away the call when CONFIG_DEBUG_FS=n, as the function body is just "return 0". Since the line following the call is

Re: [PATCH v2] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n

2014-09-16 Thread Martin Kelly
On 09/16/2014 07:09 PM, Li, Aubrey wrote: > > Thanks to take care of this warning. How about this version? > > diff --git a/arch/x86/kernel/pmc_atom.c b/arch/x86/kernel/pmc_atom.c > index 0c424a6..cd91b57 100644 > --- a/arch/x86/kernel/pmc_atom.c > +++ b/arch/x86/kernel/pmc_atom.c > @@ -240,7 +24

[PATCH v2] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n

2014-09-16 Thread Martin Kelly
When compiling with CONFIG_DEBUG_FS=n, gcc emits an unused variable warning for pmc_atom.c because "ret" is used only within the CONFIG_DEBUG_FS block. This patch adds a dummy #ifdef for pmc_dbgfs_register when CONFIG_DEBUG_FS=n to simplify the code and remove the warning. Signed-off-

Re: [PATCH] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n

2014-09-16 Thread Martin Kelly
On 09/15/2014 11:38 PM, Ingo Molnar wrote: > > This uglifies the code which is bad. A nicer fix would be to > improve the code: for example define pmc_dbgfs_register() in the > !DEBUG_FS case as well, with a return 0 or so. > > Thanks, > > Ingo > I like your suggestion and will issue a

[PATCH] x86/pmc_atom: Fix warning when CONFIG_DEBUG_FS=n

2014-09-15 Thread Martin Kelly
When compiling with CONFIG_DEBUG_FS=n, gcc emits an unused variable warning for pmc_atom.c because "ret" is used only within the CONFIG_DEBUG_FS block. This patch fixes it up to eliminate "ret" when CONFIG_DEBUG_FS=n. Signed-off-by: Martin Kelly --- arch/x86/kernel/pmc_a

[PATCH] context_tracking: Fix checkpatch warnings

2014-09-15 Thread Martin Kelly
checkpatch emits several warnings for context_tracking.c, which are fixed in this patch: - No space after "(" - Lines longer than 80 characters Signed-off-by: Martin Kelly --- kernel/context_tracking.c | 40 +--- 1 file changed, 21 inserti

[PATCH] Staging/bcm: Fix whitespace/comments in Ioctl.h

2014-09-15 Thread Martin Kelly
Cleanup whitespace and comments in Ioctl.h in a few ways: - > 80 character cleanup - Comment clarification - More consistent vertical alignment Signed-off-by: Martin Kelly --- drivers/staging/bcm/Ioctl.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) d