[PATCH v4 2/2] iio: light: noa1305: Add support for NOA1305

2019-08-02 Thread Martyn Welch
ot;noa1305", 0 }, + { } +}; +MODULE_DEVICE_TABLE(i2c, noa1305_id); + +static struct i2c_driver noa1305_driver = { + .driver = { + .name = NOA1305_DRIVER_NAME, + .of_match_table = noa1305_of_match, + }, + .probe = noa1305_probe, + .id_table = noa1305_ids, +}; + +module_i2c_driver(noa1305_driver); + +MODULE_AUTHOR("Sergei Miroshnichenko "); +MODULE_AUTHOR("Martyn Welch

[PATCH v4 1/2] dt-bindings: Add binding document for NOA1305

2019-08-02 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch Reviewed-by: Rob Herring --- Changes: v2: Same as v1. v3: Same as v2. v4: Same as v3. .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44

[PATCH v3 2/2] iio: light: noa1305: Add support for NOA1305

2019-07-26 Thread Martyn Welch
{ + .driver = { + .name = NOA1305_DRIVER_NAME, + .of_match_table = noa1305_of_match, + }, + .probe = noa1305_probe, + .remove = noa1305_remove, + .id_table = noa1305_ids, +}; + +module_i2c_driver(noa1305_driver); + +MODULE_AUTHOR("Sergei Miroshnichenko "); +MODULE_AUTHOR("Martyn Welch

[PATCH v3 1/2] dt-bindings: Add binding document for NOA1305

2019-07-26 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch Reviewed-by: Rob Herring --- Changes: v2: Same as v1. v3: Same as v2. .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44 insertions(+) create

[PATCH v2 1/2] dt-bindings: Add binding document for NOA1305

2019-06-28 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch --- Changes: v2: Same as v1. .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v2 2/2] iio: light: noa1305: Add support for NOA1305

2019-06-28 Thread Martyn Welch
i2c, noa1305_id); + + +static struct i2c_driver noa1305_driver = { + .driver = { + .name = NOA1305_DRIVER_NAME, + .of_match_table = noa1305_of_match, + }, + .probe = noa1305_probe, + .remove = noa1305_remove, + .id_table = noa1305_ids, +}; + +module_i2c_driver(noa1305_driver); + +MODULE_AUTHOR("Sergei Miroshnichenko "); +MODULE_AUTHOR("Martyn Welch

[PATCH 2/2] iio: light: noa1305: Add support for NOA1305

2019-06-28 Thread Martyn Welch
From: Martyn Welch This driver adds the initial support for the ON Semiconductor NOA1305 Ambient Light Sensor. Originally written by Sergei Miroshnichenko. Found here: https://github.com/EmcraftSystems/linux-upstream/commit/196d6cf897e632d2cb82d45484bd7a1bfdd5b6d9 Signed-off-by: Sergei M

[PATCH 1/2] dt-bindings: Add binding document for NOA1305

2019-06-28 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch --- .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/light/noa1305.yaml

Re: [PATCH] ARM: dts: am335x: Add support for Bosch Guardian

2019-02-12 Thread Martyn Welch
On Tue, 2019-02-12 at 10:49 -0800, Tony Lindgren wrote: > Hi, > > * Martyn Welch [190211 04:27]: > > The Bosch Guardian is a TI am335x based device. > > > > It's hardware specifications are as follows: > > > > * 256 MB DDR3 memory > > *

[PATCH] ARM: dts: am335x: Add support for Bosch Guardian

2019-02-11 Thread Martyn Welch
The Bosch Guardian is a TI am335x based device. It's hardware specifications are as follows: * 256 MB DDR3 memory * 512 MB NAND Flash * USB OTG * RS232 * MicroSD external storage * LCD Display interface Signed-off-by: Martyn Welch --- arch/arm/boot/dts/Makefile| 1

[PATCH v3 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin

2019-01-21 Thread Martyn Welch
s hardware specifications are: * 512MB DDR3 memory * 512MB NAND flash * Dual 10/100 Ethernet * USB Host and USB OTG * RS232 * MicroSD external storage * Audio, RS232, I2C, SPI, CAN headers * Further I/O options via A/V and Expansion headers Signed-off-by: Martyn Welch --- Changes in v3: -

[PATCH v3 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor

2019-01-21 Thread Martyn Welch
Add vendor prefix "catalyst" for Catalyst Semiconductor which is already in use but undocumented. Signed-off-by: Martyn Welch Reviewed-by: Rob Herring --- Changes in v3: - Add full stop to denote abbreviation. Changes in v2: None Documentation/devicetree/bindings/vendor-prefix

Re: [PATCH v2 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin

2019-01-21 Thread Martyn Welch
Hi Fabio, On Fri, 2019-01-18 at 19:18 -0200, Fabio Estevam wrote: > diff --git a/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin- > > full.dts b/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts > > new file mode 100644 > > index ..83cdf4fa10c0 > > --- /dev/null > > +++

[PATCH v2 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor

2019-01-18 Thread Martyn Welch
Add vendor prefix "catalyst" for Catalyst Semiconductor which is already in use but undocumented. Signed-off-by: Martyn Welch Reviewed-by: Rob Herring --- Changes in v2: None Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin

2019-01-18 Thread Martyn Welch
s hardware specifications are: * 512MB DDR3 memory * 512MB NAND flash * Dual 10/100 Ethernet * USB Host and USB OTG * RS232 * MicroSD external storage * Audio, RS232, I2C, SPI, CAN headers * Further I/O options via A/V and Expansion headers Signed-off-by: Martyn Welch --- Changes in v2: - Correct

[PATCH 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor

2018-12-11 Thread Martyn Welch
Add vendor prefix "catalyst" for Catalyst Semiconductor which is already in use but undocumented. Signed-off-by: Martyn Welch --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefi

[PATCH 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin

2018-12-11 Thread Martyn Welch
s hardware specifications are: * 512MB DDR3 memory * 512MB NAND flash * Dual 10/100 Ethernet * USB Host and USB OTG * RS232 * MicroSD external storage * Audio, RS232, I2C, SPI, CAN headers * Further I/O options via A/V and Expansion headers Signed-off-by: Martyn Welch --- arch/arm/boot/dt

Re: [PATCH] vme: remove unneeded kfree

2018-09-07 Thread Martyn Welch
On Thu, 2018-09-06 at 22:04 -0700, Linus Torvalds wrote: > On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang > wrote: > > > > put_device will call vme_dev_release to free vdev, kfree is > > unnecessary here. > > That does seem to be the case.  I think "unnecessary" is overly kind, > it does seem to be

Re: [PATCH] vme: remove unneeded kfree

2018-09-07 Thread Martyn Welch
On Thu, 2018-09-06 at 22:04 -0700, Linus Torvalds wrote: > On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang > wrote: > > > > put_device will call vme_dev_release to free vdev, kfree is > > unnecessary here. > > That does seem to be the case.  I think "unnecessary" is overly kind, > it does seem to be

Re: [PATCH] vme: ca91cx42: remove redundant variable i

2018-07-14 Thread Martyn Welch
able] > > Signed-off-by: Colin Ian King Reviewed-by: Martyn Welch > --- > drivers/vme/bridges/vme_ca91cx42.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/vme/bridges/vme_ca91cx42.c > b/drivers/vme/bridges/vme_ca91cx42.c > index 5dd284008630.

Re: [PATCH] vme: ca91cx42: remove redundant variable i

2018-07-14 Thread Martyn Welch
able] > > Signed-off-by: Colin Ian King Reviewed-by: Martyn Welch > --- > drivers/vme/bridges/vme_ca91cx42.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/vme/bridges/vme_ca91cx42.c > b/drivers/vme/bridges/vme_ca91cx42.c > index 5dd284008630.

Re: [PATCH] MAINTAINERS: Update E-mail address

2018-07-10 Thread Martyn Welch
On Tue, 2018-07-10 at 16:47 +0200, Peter Senna Tschudin wrote: > Update my E-mail address on MAINTAINERS file. > > Signed-off-by: Peter Senna Tschudin Acked-by: Martyn Welch > --- >  MAINTAINERS | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [PATCH] MAINTAINERS: Update E-mail address

2018-07-10 Thread Martyn Welch
On Tue, 2018-07-10 at 16:47 +0200, Peter Senna Tschudin wrote: > Update my E-mail address on MAINTAINERS file. > > Signed-off-by: Peter Senna Tschudin Acked-by: Martyn Welch > --- >  MAINTAINERS | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > di

[PATCH v2] ahci: imx: Handle increased read failures for IMX53 temperature sensor in low frequency mode.

2017-11-13 Thread Martyn Welch
quency. Signed-off-by: Egor Starkov <egor.star...@ge.com> Signed-off-by: Martyn Welch <martyn.we...@collabora.co.uk> --- v2: - Correct spelling issues in cover letter. drivers/ata/ahci_imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/ahci_imx.c b/driv

[PATCH v2] ahci: imx: Handle increased read failures for IMX53 temperature sensor in low frequency mode.

2017-11-13 Thread Martyn Welch
Starkov Signed-off-by: Martyn Welch --- v2: - Correct spelling issues in cover letter. drivers/ata/ahci_imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c index 787567e..a58bcc0 100644 --- a/drivers/ata/ahci_imx.c +++ b

[PATCH] staging: VME: Remove PIO2 driver

2017-10-24 Thread Martyn Welch
The PIO2 device is (as far as I know) no longer manufactured. I no longer have access to the device and this seems unlikely to change. The only changes to this driver in a long time have been as a result of API changes else where. Time to remove it... Signed-off-by: Martyn Welch <martyn

[PATCH] staging: VME: Remove PIO2 driver

2017-10-24 Thread Martyn Welch
The PIO2 device is (as far as I know) no longer manufactured. I no longer have access to the device and this seems unlikely to change. The only changes to this driver in a long time have been as a result of API changes else where. Time to remove it... Signed-off-by: Martyn Welch --- drivers

[PATCH] VME: Return -EBUSY when DMA list in use

2017-10-24 Thread Martyn Welch
From: Martyn Welch <mar...@welchs.me.uk> The VME subsystem currently returns -EBUSY when trying to free a DMA resource that is busy, but returns -EINVAL when trying to free a DMA list that is in use. Switch to returning -EBUSY when trying to free a DMA list that is in use for consi

[PATCH] VME: Return -EBUSY when DMA list in use

2017-10-24 Thread Martyn Welch
From: Martyn Welch The VME subsystem currently returns -EBUSY when trying to free a DMA resource that is busy, but returns -EINVAL when trying to free a DMA list that is in use. Switch to returning -EBUSY when trying to free a DMA list that is in use for consistency and correctness. Signed-off

[PATCH] MAINTAINERS: Update VME subsystem tree.

2017-10-23 Thread Martyn Welch
VME Subsystem lists driver-core repository as canonical tree. Greg has stated that char-misc should be used for submissions instead[1]. [1] https://lkml.org/lkml/2017/9/1/486 Signed-off-by: Martyn Welch <martyn.we...@collabora.co.uk> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion

[PATCH] MAINTAINERS: Update VME subsystem tree.

2017-10-23 Thread Martyn Welch
VME Subsystem lists driver-core repository as canonical tree. Greg has stated that char-misc should be used for submissions instead[1]. [1] https://lkml.org/lkml/2017/9/1/486 Signed-off-by: Martyn Welch --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] hwmon: da9052 Increase sample rate when using TSI

2017-10-20 Thread Martyn Welch
On Fri, 2017-10-20 at 14:30 +, Steve Twiss wrote: > Hi Martyn, > > On 19 October 2017 16:52, Martyn Welch wrote: > > > To: Support Opensource; Jean Delvare; Guenter Roeck > > Subject: [PATCH] hwmon: da9052 Increase sample rate when using TSI > > > > Th

Re: [PATCH] hwmon: da9052 Increase sample rate when using TSI

2017-10-20 Thread Martyn Welch
On Fri, 2017-10-20 at 14:30 +, Steve Twiss wrote: > Hi Martyn, > > On 19 October 2017 16:52, Martyn Welch wrote: > > > To: Support Opensource; Jean Delvare; Guenter Roeck > > Subject: [PATCH] hwmon: da9052 Increase sample rate when using TSI > > > > Th

[PATCH] hwmon: da9052 Increase sample rate when using TSI

2017-10-19 Thread Martyn Welch
-by: Martyn Welch <martyn.we...@collabora.co.uk> --- drivers/hwmon/da9052-hwmon.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/hwmon/da9052-hwmon.c b/drivers/hwmon/da9052-hwmon.c index 97a62f5..a973eb6 100644 --- a/drivers/hwmon/da9052-hwmon.c +++ b/drivers/hwmon/da9052-h

[PATCH] hwmon: da9052 Increase sample rate when using TSI

2017-10-19 Thread Martyn Welch
-by: Martyn Welch --- drivers/hwmon/da9052-hwmon.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/hwmon/da9052-hwmon.c b/drivers/hwmon/da9052-hwmon.c index 97a62f5..a973eb6 100644 --- a/drivers/hwmon/da9052-hwmon.c +++ b/drivers/hwmon/da9052-hwmon.c @@ -477,6 +477,11 @@ static

Re: [GIT PULL] VME Subsystem patches for 4.14-rc4

2017-10-14 Thread Martyn Welch
On Sat, 2017-10-14 at 14:08 +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 13, 2017 at 10:09:19PM +0100, Martyn Welch wrote: > > The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: > > > > Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) > > &

Re: [GIT PULL] VME Subsystem patches for 4.14-rc4

2017-10-14 Thread Martyn Welch
On Sat, 2017-10-14 at 14:08 +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 13, 2017 at 10:09:19PM +0100, Martyn Welch wrote: > > The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: > > > > Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) > > &

[GIT PULL] VME Subsystem patches for 4.14-rc4

2017-10-13 Thread Martyn Welch
The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) are available in the git repository at: https://gitlab.collabora.com/martyn/linux.git tags/vme-next-4.14-rc4 for you to fetch changes up to

[GIT PULL] VME Subsystem patches for 4.14-rc4

2017-10-13 Thread Martyn Welch
The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) are available in the git repository at: https://gitlab.collabora.com/martyn/linux.git tags/vme-next-4.14-rc4 for you to fetch changes up to

[PATCH v2] serial: imx: Correct comment imx_flush_buffer()

2017-10-04 Thread Martyn Welch
The comment in imx_flush_buffer() states that the state of 4 registers are to be saved/restored, then only saves and restores 3 registers. The missing register (UBRC) is read only and thus can't be restored. Update the comment to reflect reality. Signed-off-by: Martyn Welch <martyn

[PATCH v2] serial: imx: Correct comment imx_flush_buffer()

2017-10-04 Thread Martyn Welch
The comment in imx_flush_buffer() states that the state of 4 registers are to be saved/restored, then only saves and restores 3 registers. The missing register (UBRC) is read only and thus can't be restored. Update the comment to reflect reality. Signed-off-by: Martyn Welch --- v2: Remove

Re: [PATCH] serial: imx: Correct comment imx_flush_buffer()

2017-10-04 Thread Martyn Welch
On Tue, 2017-10-03 at 20:27 +0200, Greg Kroah-Hartman wrote: > On Fri, Sep 29, 2017 at 10:22:19AM +0100, Martyn Welch wrote: > > The comment in imx_flush_buffer() states that the state of 4 registers > > are to be saved/restored, then only saves and restores 3 registers. The >

Re: [PATCH] serial: imx: Correct comment imx_flush_buffer()

2017-10-04 Thread Martyn Welch
On Tue, 2017-10-03 at 20:27 +0200, Greg Kroah-Hartman wrote: > On Fri, Sep 29, 2017 at 10:22:19AM +0100, Martyn Welch wrote: > > The comment in imx_flush_buffer() states that the state of 4 registers > > are to be saved/restored, then only saves and restores 3 registers. The >

[PATCH] serial: imx: Correct comment imx_flush_buffer()

2017-09-29 Thread Martyn Welch
The comment in imx_flush_buffer() states that the state of 4 registers are to be saved/restored, then only saves and restores 3 registers. The missing register (UBRC) is read only and thus can't be restored. Update the comment to reflect reality. Signed-off-by: Martyn Welch <martyn

[PATCH] serial: imx: Correct comment imx_flush_buffer()

2017-09-29 Thread Martyn Welch
The comment in imx_flush_buffer() states that the state of 4 registers are to be saved/restored, then only saves and restores 3 registers. The missing register (UBRC) is read only and thus can't be restored. Update the comment to reflect reality. Signed-off-by: Martyn Welch --- drivers/tty

[PATCH] serial: imx: Switch setting dma_is_txing from "false" to "0"

2017-09-28 Thread Martyn Welch
The variable "dma_is_txing" is an unsigned int, set as either "0" or "1" in all but one location, where it is instead set to "false". For consistency, set dma_is_txing to "0" in this location too. Signed-off-by: Martyn Welch <martyn.we...@col

[PATCH] serial: imx: Switch setting dma_is_txing from "false" to "0"

2017-09-28 Thread Martyn Welch
The variable "dma_is_txing" is an unsigned int, set as either "0" or "1" in all but one location, where it is instead set to "false". For consistency, set dma_is_txing to "0" in this location too. Signed-off-by: Martyn Welch --- drivers/tty/seri

[PATCH v2] Use RX_BUF_SIZE to set size of RX buffer

2017-09-28 Thread Martyn Welch
. Signed-off-by: Martyn Welch <martyn.we...@collabora.co.uk> Acked-by: Uwe Kleine-König <u.kleine-kön...@pengtronix.de> --- v2: Add missing SoB and Uwe's Acked-by. drivers/tty/serial/imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/imx.c b/driver

[PATCH v2] Use RX_BUF_SIZE to set size of RX buffer

2017-09-28 Thread Martyn Welch
. Signed-off-by: Martyn Welch Acked-by: Uwe Kleine-König --- v2: Add missing SoB and Uwe's Acked-by. drivers/tty/serial/imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 1691ed2..9da109a 100644 --- a/drivers/tty/serial

Re: [PATCH] Use RX_BUF_SIZE to set size of RX buffer

2017-09-28 Thread Martyn Welch
On Thu, Sep 28, 2017 at 12:00:19PM +0200, Uwe Kleine-König wrote: > On Thu, Sep 28, 2017 at 10:52:15AM +0100, Martyn Welch wrote: > > The imx serial driver uses PAGE_SIZE when allocating rx_buf, but then > > uses RX_BUF_SIZE (which is currently defined as PAGE_SIZE) to describe

Re: [PATCH] Use RX_BUF_SIZE to set size of RX buffer

2017-09-28 Thread Martyn Welch
On Thu, Sep 28, 2017 at 12:00:19PM +0200, Uwe Kleine-König wrote: > On Thu, Sep 28, 2017 at 10:52:15AM +0100, Martyn Welch wrote: > > The imx serial driver uses PAGE_SIZE when allocating rx_buf, but then > > uses RX_BUF_SIZE (which is currently defined as PAGE_SIZE) to describe

[PATCH] serial: imx: only set dma_is_rxing when DMA starts

2017-09-28 Thread Martyn Welch
; Signed-off-by: Martyn Welch <martyn.we...@collabora.co.uk> Reviewed-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> --- This patch has been split out of series: "[PATCH v3 0/6] serial: imx: various improvements" as this is a stand alone fix and some of the patches in the

[PATCH] serial: imx: only set dma_is_rxing when DMA starts

2017-09-28 Thread Martyn Welch
enabling DMA. Currently this will result in dma_is_rxing suggesting that DMA is being used for recieving. To avoid these issues, move the setting of dma_is_rxing to start_rx_dma() when appropriate. Signed-off-by: Romain Perier Signed-off-by: Martyn Welch Reviewed-by: Uwe Kleine-König

[PATCH] Use RX_BUF_SIZE to set size of RX buffer

2017-09-28 Thread Martyn Welch
The imx serial driver uses PAGE_SIZE when allocating rx_buf, but then uses RX_BUF_SIZE (which is currently defined as PAGE_SIZE) to describe the length of the buffer when initialising the scatter gather list. In order to ensure that this stays consistent, use RX_BUF_SIZE in both locations. ---

[PATCH] Use RX_BUF_SIZE to set size of RX buffer

2017-09-28 Thread Martyn Welch
The imx serial driver uses PAGE_SIZE when allocating rx_buf, but then uses RX_BUF_SIZE (which is currently defined as PAGE_SIZE) to describe the length of the buffer when initialising the scatter gather list. In order to ensure that this stays consistent, use RX_BUF_SIZE in both locations. ---

Re: [PATCH v3 1/6] serial: imx: remove CTSC and CTS handling from imx_disable_dma

2017-09-21 Thread Martyn Welch
On Thu, Sep 21, 2017 at 08:20:17PM +0200, Uwe Kleine-König wrote: > On Thu, Sep 21, 2017 at 05:18:12PM +0100, Martyn Welch wrote: > > From: Nandor Han <nandor@ge.com> > > > > The CTSC and CTS bits affect operation of the CTS/RTS hardware flow > > con

Re: [PATCH v3 1/6] serial: imx: remove CTSC and CTS handling from imx_disable_dma

2017-09-21 Thread Martyn Welch
On Thu, Sep 21, 2017 at 08:20:17PM +0200, Uwe Kleine-König wrote: > On Thu, Sep 21, 2017 at 05:18:12PM +0100, Martyn Welch wrote: > > From: Nandor Han > > > > The CTSC and CTS bits affect operation of the CTS/RTS hardware flow > > control signal (depending on whether

[PATCH v3 1/6] serial: imx: remove CTSC and CTS handling from imx_disable_dma

2017-09-21 Thread Martyn Welch
ppears to control it via calls to imx_port_rts_active() and imx_port_rts_inactive(). This configuration of the CTSC and CTS bits are therefore not needed. Signed-off-by: Nandor Han <nandor@ge.com> Signed-off-by: Romain Perier <romain.per...@collabora.com> Signed-off-by: Marty

[PATCH v3 1/6] serial: imx: remove CTSC and CTS handling from imx_disable_dma

2017-09-21 Thread Martyn Welch
to imx_port_rts_active() and imx_port_rts_inactive(). This configuration of the CTSC and CTS bits are therefore not needed. Signed-off-by: Nandor Han Signed-off-by: Romain Perier Signed-off-by: Martyn Welch --- drivers/tty/serial/imx.c | 5 - 1 file changed, 5 deletions(-) diff --git

[PATCH v3 0/6] serial: imx: various improvements

2017-09-21 Thread Martyn Welch
During shutdown when a userspace service is disabled (which generates an uart close), we got kernel crashes in the imx serial driver : [ 1257.657423] Unhandled fault: external abort on non-linefetch (0x1008) at 0xf0938000 [ 1257.665122] pgd = ecf2 [ 1257.667838] [f0938000] *pgd=de819811,

[PATCH v3 0/6] serial: imx: various improvements

2017-09-21 Thread Martyn Welch
During shutdown when a userspace service is disabled (which generates an uart close), we got kernel crashes in the imx serial driver : [ 1257.657423] Unhandled fault: external abort on non-linefetch (0x1008) at 0xf0938000 [ 1257.665122] pgd = ecf2 [ 1257.667838] [f0938000] *pgd=de819811,

[PATCH v3 4/6] serial: imx: unmap sg buffers when DMA channel is released

2017-09-21 Thread Martyn Welch
..@ge.com> Signed-off-by: Romain Perier <romain.per...@collabora.com> Signed-off-by: Martyn Welch <martyn.we...@collabora.co.uk> --- drivers/tty/serial/imx.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index

[PATCH v3 3/6] serial: imx: Simplify DMA disablement

2017-09-21 Thread Martyn Welch
<romain.per...@collabora.com> Signed-off-by: Martyn Welch <martyn.we...@collabora.co.uk> --- drivers/tty/serial/imx.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 7835279..2fb3210

[PATCH v3 4/6] serial: imx: unmap sg buffers when DMA channel is released

2017-09-21 Thread Martyn Welch
-off-by: Martyn Welch --- drivers/tty/serial/imx.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 2fb3210..ed02783 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -357,6 +357,12 @@ static void

[PATCH v3 3/6] serial: imx: Simplify DMA disablement

2017-09-21 Thread Martyn Welch
From: Nandor Han This commits simplify the function imx_disable_dma() by moving the code for disabling RX and TX DMAs to dedicated functions. This is a preparation for the next commit. Signed-off-by: Nandor Han Signed-off-by: Romain Perier Signed-off-by: Martyn Welch --- drivers/tty/serial

[PATCH v3 2/6] serial: imx: only set dma_is_rxing when DMA starts

2017-09-21 Thread Martyn Welch
; Signed-off-by: Martyn Welch <martyn.we...@collabora.co.uk> --- drivers/tty/serial/imx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index d90dae3..7835279 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/seri

[PATCH v3 2/6] serial: imx: only set dma_is_rxing when DMA starts

2017-09-21 Thread Martyn Welch
enabling DMA. Currently this will result in dma_is_rxing suggesting that DMA is being used for recieving. To avoid these issues, move the setting of dma_is_rxing to start_rx_dma() when appropriate. Signed-off-by: Romain Perier Signed-off-by: Martyn Welch --- drivers/tty/serial/imx.c | 3 +-- 1

[PATCH v3 5/6] serial: imx: update the stop rx,tx procedures

2017-09-21 Thread Martyn Welch
ocedures to stop the activity and disable the interrupts related to that. Signed-off-by: Nandor Han <nandor@ge.com> Signed-off-by: Romain Perier <romain.per...@collabora.com> Signed-off-by: Martyn Welch <martyn.we...@collabora.co.uk> --- drivers/tty/serial/imx.c | 36 +-

[PATCH v3 6/6] serial: imx: Fix imx_shutdown procedure

2017-09-21 Thread Martyn Welch
.@collabora.com> Signed-off-by: Martyn Welch <martyn.we...@collabora.co.uk> --- drivers/tty/serial/imx.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 256b128..393c1c0 100644

[PATCH v3 5/6] serial: imx: update the stop rx,tx procedures

2017-09-21 Thread Martyn Welch
nd disable the interrupts related to that. Signed-off-by: Nandor Han Signed-off-by: Romain Perier Signed-off-by: Martyn Welch --- drivers/tty/serial/imx.c | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/

[PATCH v3 6/6] serial: imx: Fix imx_shutdown procedure

2017-09-21 Thread Martyn Welch
. This disables RX and TX blocks, then it disabled interrupts. In case DMA is enabled, it disables DMA and free corresponding resources. It disables UART port and stop clocks. Signed-off-by: Nandor Han Signed-off-by: Romain Perier Signed-off-by: Martyn Welch --- drivers/tty/serial/imx.c | 34

Re: [PATCH] staging:vme Fix use BIT macro

2017-09-21 Thread Martyn Welch
On 21 September 2017 at 06:52, Janani Sankara Babu wrote: > This patch is created to solve the following warning shown by the checkpatch > script Warning: Replace all occurences of (1< > Signed-off-by: Janani Sankara Babu > --- >

Re: [PATCH] staging:vme Fix use BIT macro

2017-09-21 Thread Martyn Welch
On 21 September 2017 at 06:52, Janani Sankara Babu wrote: > This patch is created to solve the following warning shown by the checkpatch > script Warning: Replace all occurences of (1< > Signed-off-by: Janani Sankara Babu > --- > drivers/staging/vme/devices/vme_pio2.h | 6 +++--- > 1 file

Re: [PATCH v2 3/6] serial: imx: remove CTSC and CTS handling

2017-09-15 Thread Martyn Welch
Hi On Wed, Jul 05, 2017 at 03:38:45PM +0200, Uwe Kleine-König wrote: > Cc += Clemens Gruber + Fabio Estevam > > On Wed, Jul 05, 2017 at 03:07:03PM +0200, Romain Perier wrote: > > From: Nandor Han > > > > CTSC and CTS are not related to DMA and might add > > disruption in

Re: [PATCH v2 3/6] serial: imx: remove CTSC and CTS handling

2017-09-15 Thread Martyn Welch
Hi On Wed, Jul 05, 2017 at 03:38:45PM +0200, Uwe Kleine-König wrote: > Cc += Clemens Gruber + Fabio Estevam > > On Wed, Jul 05, 2017 at 03:07:03PM +0200, Romain Perier wrote: > > From: Nandor Han > > > > CTSC and CTS are not related to DMA and might add > > disruption in some cases. > > > >

Re: [PATCH v6 2/2] ARM: dts: imx53: Add GE Healthcare PPD

2017-09-13 Thread Martyn Welch
On Fri, 2017-08-18 at 16:53 +0100, Martyn Welch wrote: > From: Fabien Lahoudere <fabien.lahoud...@collabora.co.uk> > > PPD is a product from GE Healthcare to monitor vital biometric signals. > > Signed-off-by: Fabien Lahoudere <fabien.lahoud...@collabora.co.uk> > Si

Re: [PATCH v6 2/2] ARM: dts: imx53: Add GE Healthcare PPD

2017-09-13 Thread Martyn Welch
On Fri, 2017-08-18 at 16:53 +0100, Martyn Welch wrote: > From: Fabien Lahoudere > > PPD is a product from GE Healthcare to monitor vital biometric signals. > > Signed-off-by: Fabien Lahoudere > Signed-off-by: Sebastian Reichel > Signed-off-by: Martyn Welch > Re

[GIT PULL] VME Subsystem patches for 4.13-rc7

2017-09-01 Thread Martyn Welch
The following changes since commit 0f9b011d3321ca1079c7a46c18cb1956fbdb7bcb: driver core: bus: Fix a potential double free (2017-08-31 18:57:30 +0200) are available in the git repository at: https://gitlab.collabora.com/martyn/linux.git tags/vme-next-4.13-rc7 for you to fetch changes up to

[GIT PULL] VME Subsystem patches for 4.13-rc7

2017-09-01 Thread Martyn Welch
The following changes since commit 0f9b011d3321ca1079c7a46c18cb1956fbdb7bcb: driver core: bus: Fix a potential double free (2017-08-31 18:57:30 +0200) are available in the git repository at: https://gitlab.collabora.com/martyn/linux.git tags/vme-next-4.13-rc7 for you to fetch changes up to

Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations

2017-08-30 Thread Martyn Welch
On 26 August 2017 at 08:00, SF Markus Elfring wrote: >>> @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const >>> struct pci_device_id *id) >>> master_num--; >>> >>> tsi148_device->flush_image = >>> -

Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations

2017-08-30 Thread Martyn Welch
On 26 August 2017 at 08:00, SF Markus Elfring wrote: >>> @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const >>> struct pci_device_id *id) >>> master_num--; >>> >>> tsi148_device->flush_image = >>> -kmalloc(sizeof(struct

Re: [PATCH 00/14] VME: Adjustments for several function implementations

2017-08-25 Thread Martyn Welch
On Fri, Aug 25, 2017 at 05:41:13PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 25 Aug 2017 13:15:43 +0200 > > Several update suggestions were taken into account > from static source code analysis. > > Markus Elfring (14): > Delete 11

Re: [PATCH 00/14] VME: Adjustments for several function implementations

2017-08-25 Thread Martyn Welch
On Fri, Aug 25, 2017 at 05:41:13PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 25 Aug 2017 13:15:43 +0200 > > Several update suggestions were taken into account > from static source code analysis. > > Markus Elfring (14): > Delete 11 error messages for a failed memory

Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations

2017-08-25 Thread Martyn Welch
On Fri, Aug 25, 2017 at 06:15:08PM +0200, SF Markus Elfring wrote: > @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const > struct pci_device_id *id) > master_num--; > > tsi148_device->flush_image = > -

Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations

2017-08-25 Thread Martyn Welch
On Fri, Aug 25, 2017 at 06:15:08PM +0200, SF Markus Elfring wrote: > @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const > struct pci_device_id *id) > master_num--; > > tsi148_device->flush_image = > -

[PATCH v6 2/2] ARM: dts: imx53: Add GE Healthcare PPD

2017-08-18 Thread Martyn Welch
From: Fabien Lahoudere <fabien.lahoud...@collabora.co.uk> PPD is a product from GE Healthcare to monitor vital biometric signals. Signed-off-by: Fabien Lahoudere <fabien.lahoud...@collabora.co.uk> Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> Signed-of

[PATCH v6 0/2] Add device tree and associated documentation for GE Healthcare PPD

2017-08-18 Thread Martyn Welch
This series adds the device tree for the GE Healthcare PPD and binding documentation for the ge-achc, as used by the PPD device tree. Fabien Lahoudere (1): ARM: dts: imx53: Add GE Healthcare PPD Martyn Welch (1): dt-bindings: misc: achc: Add device tree binding for GE ACHC Documentation

[PATCH v6 0/2] Add device tree and associated documentation for GE Healthcare PPD

2017-08-18 Thread Martyn Welch
This series adds the device tree for the GE Healthcare PPD and binding documentation for the ge-achc, as used by the PPD device tree. Fabien Lahoudere (1): ARM: dts: imx53: Add GE Healthcare PPD Martyn Welch (1): dt-bindings: misc: achc: Add device tree binding for GE ACHC Documentation

[PATCH v6 2/2] ARM: dts: imx53: Add GE Healthcare PPD

2017-08-18 Thread Martyn Welch
From: Fabien Lahoudere PPD is a product from GE Healthcare to monitor vital biometric signals. Signed-off-by: Fabien Lahoudere Signed-off-by: Sebastian Reichel Signed-off-by: Martyn Welch Reviewed-by: Fabio Estevam --- Changes since PATCHv5: https://patchwork.kernel.org/patch/9852327

[PATCH v6 1/2] dt-bindings: misc: achc: Add device tree binding for GE ACHC

2017-08-18 Thread Martyn Welch
Add Device Tree binding document for GE Healthcare USB Management Controller (ACHC). Signed-off-by: Martyn Welch <martyn.we...@collabora.co.uk> --- Documentation/devicetree/bindings/misc/ge-achc.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documen

[PATCH v6 1/2] dt-bindings: misc: achc: Add device tree binding for GE ACHC

2017-08-18 Thread Martyn Welch
Add Device Tree binding document for GE Healthcare USB Management Controller (ACHC). Signed-off-by: Martyn Welch --- Documentation/devicetree/bindings/misc/ge-achc.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/ge

[PATCH v5] ARM: dts: imx53: Add GE Healthcare PPD

2017-07-19 Thread Martyn Welch
From: Fabien Lahoudere <fabien.lahoud...@collabora.co.uk> PPD is a product from GE Healthcare to monitor vital biometric signals. Signed-off-by: Fabien Lahoudere <fabien.lahoud...@collabora.co.uk> Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> Signed-of

[PATCH v5] ARM: dts: imx53: Add GE Healthcare PPD

2017-07-19 Thread Martyn Welch
From: Fabien Lahoudere PPD is a product from GE Healthcare to monitor vital biometric signals. Signed-off-by: Fabien Lahoudere Signed-off-by: Sebastian Reichel Signed-off-by: Martyn Welch --- Changes since PATCHv4: https://patchwork.kernel.org/patch/9834733/ - actually remove fsl,mode node

[PATCH v4 1/1] ARM: dts: imx53: Add GE Healthcare PPD

2017-07-11 Thread Martyn Welch
From: Fabien Lahoudere <fabien.lahoud...@collabora.co.uk> PPD is a product from GE Healthcare to monitor vital biometric signals. Signed-off-by: Fabien Lahoudere <fabien.lahoud...@collabora.co.uk> Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> Signed-of

[PATCH v4 1/1] ARM: dts: imx53: Add GE Healthcare PPD

2017-07-11 Thread Martyn Welch
From: Fabien Lahoudere PPD is a product from GE Healthcare to monitor vital biometric signals. Signed-off-by: Fabien Lahoudere Signed-off-by: Sebastian Reichel Signed-off-by: Martyn Welch --- Changes since PATCHv3: https://patchwork.kernel.org/patch/9819017/ - licensing modified

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

2017-03-02 Thread Martyn Welch
On Wed, Mar 01, 2017 at 02:30:31PM +0100, Benjamin Tissoires wrote: > Hi, > > On Feb 28 2017 or thereabouts, Martyn Welch wrote: > > This patch has been sitting on the list for about 2 weeks. Is there > > anything wrong with this patch? > > The only wrong thing with t

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

2017-03-02 Thread Martyn Welch
On Wed, Mar 01, 2017 at 02:30:31PM +0100, Benjamin Tissoires wrote: > Hi, > > On Feb 28 2017 or thereabouts, Martyn Welch wrote: > > This patch has been sitting on the list for about 2 weeks. Is there > > anything wrong with this patch? > > The only wrong thing with t

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

2017-02-28 Thread Martyn Welch
This patch has been sitting on the list for about 2 weeks. Is there anything wrong with this patch? Thanks, Martyn On Tue, Feb 14, 2017 at 02:17:56PM +, Martyn Welch wrote: > The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH > in it's capabilities, which is wha

Re: [PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

2017-02-28 Thread Martyn Welch
This patch has been sitting on the list for about 2 weeks. Is there anything wrong with this patch? Thanks, Martyn On Tue, Feb 14, 2017 at 02:17:56PM +, Martyn Welch wrote: > The Accutouch 2216 is reporting BTN_LEFT/BTN_MOUSE rather than BTM_TOUCH > in it's capabilities, which is wha

[PATCH] HID: Accutouch: Add driver for ELO Accutouch 2216 USB Touchscreens

2017-02-14 Thread Martyn Welch
use cursor being displayed in Weston. This patch adds a special driver for the device to correct the capabilities reported. Signed-off-by: Martyn Welch <martyn.we...@collabora.co.uk> --- drivers/hid/Kconfig | 12 +++ drivers/hid/Makefile| 1 + drivers/hid/hid-

  1   2   3   >