Re: [PATCH v13 1/8] arm64: dts: mt8183: rename rdma fifo size

2021-01-31 Thread Matthias Brugger
Hi Hsin-Yi, On 29/01/2021 10:22, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > property name must include only lowercase and '-' > > Fixes: 91f9c963ce79 ("arm64: dts: mt8183: Add display nodes for MT8183") > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Chun-Kuang

Re: [PATCH RESEND v5 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes

2021-01-31 Thread Matthias Brugger
On 29/01/2021 10:49, Hsin-Hsiung Wang wrote: > From: Wen Su > > add PMIC MT6359 related nodes which is for MT6779 platform > > Signed-off-by: Wen Su > Signed-off-by: Hsin-Hsiung Wang > --- > changes since v4: > - add pmic MT6359 support in the MT8192 evb dts. > --- >

Re: [PATCH] soc: mediatek: cmdq: Remove cmdq_pkt_flush()

2021-01-31 Thread Matthias Brugger
On 30/01/2021 10:45, Chun-Kuang Hu wrote: > Hi, Matthias: > > Chun-Kuang Hu 於 2021年1月10日 週日 上午6:59寫道: >> >> Hi, Matthias: >> >> Chun-Kuang Hu 於 2020年12月3日 週四 上午7:59寫道: >>> >>> rx_callback is a standard mailbox callback mechanism and could >>> cover the function of proprietary cmdq_task_cb,

Re: [PATCH v2] arm64: dts: mt8192: add nor_flash device node

2021-01-31 Thread Matthias Brugger
On 23/12/2020 05:22, Bayi Cheng wrote: > From: bayi cheng > > add nor_flash device node > > Change-Id: I79f0228529bd8a33e5f354b7a861a4ec8d92e9ba Applied to v5.11-next/dts64 I dropped the Change-Id. In the future please make sure to not include this tag in upstream submissions. Thanks! >

Re: [PATCH v13 0/8] drm/mediatek: add support for mediatek SOC MT8183

2021-01-31 Thread Matthias Brugger
On 29/01/2021 10:22, Hsin-Yi Wang wrote: > This series is based on kernel/git/chunkuang.hu/linux.git mediatek-drm-next > The series is tested on a mt8183 krane device. > > Change since v12 > - fix mtk_dither_config > > Change since v10, v11 > - fix review comments in v9 > > Change since v9 >

Re: [PATCH v2 2/3] soc: mediatek: pm-domains: Add domain regulator supply

2021-01-31 Thread Matthias Brugger
On 29/01/2021 11:12, Hsin-Yi Wang wrote: > Some power domains (eg. mfg) needs to turn on power supply before power > on. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Nicolas Boichat > Reviewed-by: Enric Balletbo i Serra Applied to v5.11-next/soc Thanks > --- >

Re: [PATCH v2 1/3] dt-bindings: power: Add domain regulator supply

2021-01-31 Thread Matthias Brugger
On 29/01/2021 11:12, Hsin-Yi Wang wrote: > Some power domains (eg. mfg) needs to turn on power supply before power > on. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Rob Herring > Reviewed-by: Enric Balletbo i Serra Applied to v5.11-next/soc Thanks > --- >

Re: [PATCH v2 3/3] arm64: dts: mediatek: mt8183: Add domain supply for mfg

2021-01-31 Thread Matthias Brugger
On 29/01/2021 11:12, Hsin-Yi Wang wrote: > Add domain supply node. > > Signed-off-by: Hsin-Yi Wang > --- Applied to v5.11-next/dts64 Thanks > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +- > 2 files changed, 5

Re: [PATCH v1] arm64: dts: mt8192: add nor_flash device node

2021-01-31 Thread Matthias Brugger
On 10/12/2020 09:34, Bayi Cheng wrote: > From: bayi cheng > > add nor_flash device node > > Signed-off-by: bayi cheng > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 13 + > 1 file changed, 13 insertions(+) > Applied to v5.11-next/dts64 Thanks > diff --git

Re: [PATCH v3 2/2] arm64: dts: mediatek: mt8516: add support for APDMA

2021-01-31 Thread Matthias Brugger
On 09/12/2020 12:47, Fabien Parent wrote: > Add support the APDMA IP on MT8516. APDMA is a DMA controller > for UARTs. > > Signed-off-by: Fabien Parent > --- > Applied to v5.11-next/dts64 Thanks a lot! > V3: remove unicode symbol that slips into patch summary > V2: Add missing dma-names

Re: [PATCH v3 1/2] dt-bindings: power: Add MT8167 power domains

2021-01-31 Thread Matthias Brugger
On 09/12/2020 14:32, Fabien Parent wrote: > Add power domains dt-bindings for MT8167. > > Signed-off-by: Fabien Parent > Acked-by: Rob Herring Both patches applied to v5.11-next/soc Thanks! > --- > This patch was made on top of >

Re: [PATCH] arm64: dts: mt8183: Add missing power-domain for pwm0 node

2021-01-28 Thread Matthias Brugger
On 13/01/2021 22:57, Enric Balletbo i Serra wrote: > The MT8183 display PWM device will not work until the associated > power-domain is enabled. Add the power-domain reference to the node > allows the display PWM driver to operate and the backlight turn on. > > Fixes: f15722c0fef0 ("arm64:

Re: [PATCH v12 2/8] arm64: dts: mt8183: refine gamma compatible name

2021-01-28 Thread Matthias Brugger
On 28/01/2021 12:23, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > mt8183 gamma is different with mt8173 > remove mt8173 compatible name for mt8183 gamma > > Fixes: 91f9c963ce79 ("arm64: dts: mt8183: Add display nodes for MT8183") > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang

Re: [PATCH v12 1/8] arm64: dts: mt8183: rename rdma fifo size

2021-01-28 Thread Matthias Brugger
On 28/01/2021 12:23, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > property name must include only lowercase and '-' > > Fixes: 91f9c963ce79 ("arm64: dts: mt8183: Add display nodes for MT8183") > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Chun-Kuang Hu >

Re: [PATCH v2 3/5] drm/mediatek: Change disp/ddp term to mutex in mtk mutex driver

2021-01-21 Thread Matthias Brugger
On Thu, Jan 21, 2021 at 07:46:44AM +0800, Chun-Kuang Hu wrote: > Hi, Matthias: > > Matthias Brugger 於 2021年1月21日 週四 上午2:27寫道: > > > > On Thu, Jan 07, 2021 at 07:17:27AM +0800, Chun-Kuang Hu wrote: > > > From: CK Hu > > > > > > mtk mutex is use

Re: [PATCH v4 5/9] mfd: Add support for the MediaTek MT6359 PMIC

2021-01-20 Thread Matthias Brugger
On Wed, Dec 16, 2020 at 03:47:03PM +0800, Hsin-Hsiung Wang wrote: > This adds support for the MediaTek MT6359 PMIC. This is a > multifunction device with the following sub modules: > > - Codec > - Interrupt > - Regulator > - RTC > > It is interfaced to the host controller using SPI interface >

Re: [PATCH v4, 03/10] soc: mediatek: mmsys: move register operation into mmsys path select function

2021-01-20 Thread Matthias Brugger
On Tue, Jan 05, 2021 at 11:06:26AM +0800, Yongqiang Niu wrote: > move register operation into mmsys path select function Why do you want to do that. It seems the register access pattern is the same for all SoCs so far supported, so I don't see the need to duplicate the code in every SoC.

Re: [PATCH v2 5/5] soc / drm: mediatek: Move mtk mutex driver to soc folder

2021-01-20 Thread Matthias Brugger
On Thu, Jan 07, 2021 at 07:17:29AM +0800, Chun-Kuang Hu wrote: > From: CK Hu > > mtk mutex is used by DRM and MDP driver, and its function is SoC-specific, > so move it to soc folder. > > Signed-off-by: CK Hu > Signed-off-by: Chun-Kuang Hu Acked-by: Matthias Brugger

Re: [PATCH v2 3/5] drm/mediatek: Change disp/ddp term to mutex in mtk mutex driver

2021-01-20 Thread Matthias Brugger
On Thu, Jan 07, 2021 at 07:17:27AM +0800, Chun-Kuang Hu wrote: > From: CK Hu > > mtk mutex is used by both drm and mdp driver, so change disp/ddp term to > mutex to show that it's a common driver for drm and mdp. > > Signed-off-by: CK Hu > Signed-off-by: Chun-Kuang Hu > --- >

Re: [PATCH v13 5/5] leds: mt6360: Add LED driver for MT6360

2021-01-12 Thread Matthias Brugger
On 21/12/2020 11:45, Gene Chen wrote: > From: Gene Chen [...] > + > +static const struct of_device_id __maybe_unused mt6360_led_of_id[] = { > + { .compatible = "mediatek,mt6360-led", }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, mt6360_led_of_id); > + I think we should fix MFD code to

Re: [PATCH v3 2/2] power: supply: mt6360_charger: add MT6360 charger support

2021-01-12 Thread Matthias Brugger
On 24/12/2020 08:48, Gene Chen wrote: > From: Gene Chen > > Add basic support for the battery charger for MT6360 PMIC > > Signed-off-by: Gene Chen > --- > drivers/power/supply/Kconfig | 10 + > drivers/power/supply/Makefile |1 + >

Re: [PATCH v7 04/11] mfd: mt6360: Combine mt6360 pmic/ldo resources into mt6360 regulator resources

2021-01-12 Thread Matthias Brugger
On 12/11/2020 11:39, Gene Chen wrote: > From: Gene Chen > > Combine mt6360 pmic/ldo resources into mt6360 regulator resources > to simplify the similar resources object. > > Signed-off-by: Gene Chen > Acked-for-MFD-by: Lee Jones > --- > drivers/mfd/mt6360-core.c | 11 +++ > 1 file

Re: [PATCH v2 1/3] regulator: mt6360: Add OF match table

2021-01-12 Thread Matthias Brugger
On Mon, Jan 11, 2021 at 04:41:18PM +, Mark Brown wrote: > On Sat, Jan 09, 2021 at 12:26:09PM +0100, matthias@kernel.org wrote: > > From: Matthias Brugger > > > > Binding documentation mentions that a compatible is required for the > > MT6360 device node, but

Re: [PATCH v2 1/3] regulator: mt6360: Add OF match table

2021-01-11 Thread Matthias Brugger
ang ; Axel Lin >> ; Chen Zhong ; >> gene_chen(陳俊宇) ; linux-kernel@vger.kernel.org; >> linux-media...@lists.infradead.org; linux-arm-ker...@lists.infradead.org; >> Matthias Brugger ; Matti Vaittinen >> ; Matthias Brugger >> >> Subject: [PATCH v2 1/3] regulator:

Re: [PATCH] mfd: mt6360: Fix MFD cell names and compatibles

2021-01-11 Thread Matthias Brugger
patch. Looks good to me, so please ignore this patch mine. Regards, Matthias > 於 2021年1月11日 週一 下午8:35寫道: >> >> From: Matthias Brugger >> >> MFD cell names and compatibles use '_' instead of '-', which is common >> practice for names and the standard for DT c

Re: [PATCH v2 1/3] regulator: mt6360: Add OF match table

2021-01-11 Thread Matthias Brugger
Hi Matti, On 11/01/2021 11:32, Vaittinen, Matti wrote: > > Hello Matthias & All, > > On Mon, 2021-01-11 at 11:08 +0100, Matthias Brugger wrote: >> >> On 11/01/2021 03:18, gene_chen(陳俊宇) wrote: >>> [ Internal Use - External ] >>> >> >&g

Re: [PATCH v2 1/3] regulator: mt6360: Add OF match table

2021-01-11 Thread Matthias Brugger
; Chen Zhong ; >> gene_chen(陳俊宇) ; linux-kernel@vger.kernel.org; >> linux-media...@lists.infradead.org; linux-arm-ker...@lists.infradead.org; >> Matthias Brugger ; Matti Vaittinen >> ; Matthias Brugger >> >> Subject: [PATCH v2 1/3] regulator: mt6360: Add OF match tabl

Re: Aw: [PATCH v2 3/3] regulator: mt6323: Add OF match table

2021-01-10 Thread Matthias Brugger
On 09/01/2021 17:44, Frank Wunderlich wrote: > Hi > >> Gesendet: Samstag, 09. Januar 2021 um 12:26 Uhr >> Von: matthias@kernel.org > >> Changes in v2: >> - check for CONFIG_OF >> - add Fixes tag > >> --- a/drivers/regulator/mt6323-regulator.c >> +++ b/drivers/regulator/mt6323-regulator.c

Re: [PATCH 1/2] hwrng: iproc-rng200: Fix disable of the block.

2020-12-18 Thread Matthias Brugger
On 14/12/2020 18:45, Scott Branden wrote: > > > On 2020-12-14 8:04 a.m., matthias@kernel.org wrote: >> From: Matthias Brugger >> >> When trying to disable the block we bitwise or the control >> register with value zero. This will leave the block always

Re: [PATCH 1/1] mfd: Standardise MFD_CELL_* helper names

2020-12-18 Thread Matthias Brugger
On 17/12/2020 09:34, Lee Jones wrote: > Start all helpers with "MFD_CELL_". > > Cc: Linus Walleij > Cc: Matthias Brugger > Cc: Gene Chen > Cc: linux-media...@lists.infradead.org > Signed-off-by: Lee Jones Reviewed-by: Matthias Brugger

Re: [PATCH v8] Add MediaTek MT6779 devapc driver

2020-11-27 Thread Matthias Brugger
On 15/10/2020 05:20, Neal Liu wrote: These patch series introduce a MediaTek MT6779 devapc driver. MediaTek bus fabric provides TrustZone security support and data protection to prevent slaves from being accessed by unexpected masters. The security violation is logged and sent to the

Re: [PATCH 1/4] soc / drm: mediatek: Move DDP component defines into mtk-mmsys.h

2020-11-27 Thread Matthias Brugger
On 06/10/2020 21:33, Enric Balletbo i Serra wrote: From: Yongqiang Niu MMSYS is the driver which controls the routing of these DDP components, so the definition of the mtk_ddp_comp_id enum should be placed in mtk-mmsys.h Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu

Re: [PATCH 2/4] soc: mediatek: mmsys: Use devm_platform_ioremap_resource()

2020-11-27 Thread Matthias Brugger
On 06/10/2020 21:33, Enric Balletbo i Serra wrote: For the common platform_get_resource()+devm_platform_ioremap() combination, there is a helper, so use it and make the code a bit more compact. Signed-off-by: Enric Balletbo i Serra Applied to v5.10-next/soc Thanks! ---

Re: [PATCH v2] soc / drm: mediatek: cmdq: Remove timeout handler in helper function

2020-11-27 Thread Matthias Brugger
On 27/11/2020 15:42, Chun-Kuang Hu wrote: Hi, Matthias: Matthias Brugger 於 2020年11月27日 週五 下午8:40寫道: Hi Chun-Kuang, On 20/11/2020 00:46, Chun-Kuang Hu wrote: Hi, Matthias: I've provided the example for why of this patch. How do you think about this patch? Patch looks good to me

Re: [PATCH] MAINTAINERS: assign mediatek headers to Mediatek SoC support

2020-11-27 Thread Matthias Brugger
On 03/11/2020 07:07, Lukas Bulwahn wrote: ./include/soc/mediatek/smi.h and ./include/linux/soc/mediatek/infracfg.h are currently not assigned to a specific section in MAINTAINERS. ./include/soc/mediatek/smi.h is the header file for definitions in ./drivers/memory/mtk-smi.c, which is assigned

Re: [RFC 1/3] dts64: mt7622: enable all pwm for bananapi r64

2020-11-27 Thread Matthias Brugger
On 16/10/2020 22:40, Frank Wunderlich wrote: From: Frank Wunderlich mt7622 only supports 6 pwm-channels so drop pwm7 third pwm (pwm2) is inverted and connected to fan-socket Signed-off-by: Frank Wunderlich Patch 1 and 2 now pushed to v5.10-next/dts64 Thanks! ---

Re: [PATCH v3] arm64: dts: mediatek: Add mt8192 power domains controller

2020-11-27 Thread Matthias Brugger
On 19/11/2020 15:13, Enric Balletbo Serra wrote: Hi Weiyi, Missatge de Weiyi Lu del dia dj., 19 de nov. 2020 a les 14:10: On Thu, 2020-11-19 at 13:13 +0100, Enric Balletbo Serra wrote: Hi Weiyi, Thank you for the patch Missatge de Weiyi Lu del dia dj., 19 de nov. 2020 a les 11:48:

Re: [PATCH v2] soc / drm: mediatek: cmdq: Remove timeout handler in helper function

2020-11-27 Thread Matthias Brugger
Hi Chun-Kuang, On 20/11/2020 00:46, Chun-Kuang Hu wrote: Hi, Matthias: I've provided the example for why of this patch. How do you think about this patch? Patch looks good to me. If you want to take it through your tree you can add my Acked-by: Matthias Brugger Beware that you might need

Re: [PATCH 0/3] arm64: dts: mediatek: Add dsi and display support for MT8183 based boards

2020-11-27 Thread Matthias Brugger
On 27/11/2020 11:49, Enric Balletbo i Serra wrote: Dear all, The following patches add the required nodes to enable dsi and display support for MT8183 based boards. The patches were tested on a Lenovo Ideapad Duet with an out-of-tree patch that enables the display for that board. Applied

Re: [PATCH] arm64: dts: mt8183: Add pwm and backlight node

2020-11-27 Thread Matthias Brugger
On 25/11/2020 11:24, Enric Balletbo i Serra wrote: Hi Hsin-Yi, Thank you for your patch. On 24/11/20 5:12, Hsin-Yi Wang wrote: Add pwm to mt8183 and backlight to mt8183-kukui. Signed-off-by: Hsin-Yi Wang --- Picked the patch and checked that pwm for the backlight is working as expected

Re: [PATCH v4 00/16] soc: mediatek: pm-domains: Add new driver for SCPSYS power domains controller

2020-11-27 Thread Matthias Brugger
power domains arm64: dts: mediatek: Add smi_common node for MT8183 Matthias Brugger (8): soc: mediatek: pm-domains: Add bus protection protocol soc: mediatek: pm_domains: Make bus protection generic soc: mediatek: pm-domains: Add SMI block as bus protection block soc: mediatek: pm

Re: [PATCH v6 1/1] arm64: dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile

2020-11-27 Thread Matthias Brugger
On 30/10/2020 10:22, Seiya Wang wrote: Add basic chip support for Mediatek MT8192 Signed-off-by: Seiya Wang --- arch/arm64/boot/dts/mediatek/Makefile | 1 + arch/arm64/boot/dts/mediatek/mt8192-evb.dts | 29 ++ arch/arm64/boot/dts/mediatek/mt8192.dtsi| 512

Re: [PATCH 1/2] dt-bindings: dma: mtk-apdma: add bindings for MT8516 SOC

2020-11-27 Thread Matthias Brugger
Hi Vinod, On 19/10/2020 23:16, Rob Herring wrote: On Thu, 15 Oct 2020 14:33:14 +0200, Fabien Parent wrote: Add bindings to APDMA for MT8516 SoC. MT8516 is compatible with MT6577. Signed-off-by: Fabien Parent --- Documentation/devicetree/bindings/dma/mtk-uart-apdma.txt | 1 + 1 file

Re: [PATCH 1/3] dt-bindings: arm64: dts: mediatek: Add mt8167-pumpkin board

2020-11-27 Thread Matthias Brugger
On 27/10/2020 20:48, Fabien Parent wrote: Add binding documentation for the MT8167 Pumpkin board. Signed-off-by: Fabien Parent --- Documentation/devicetree/bindings/arm/mediatek.yaml | 4 1 file changed, 4 insertions(+) All three patches applied to v5.10-next/dts64 Thanks!

Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add efuse node

2020-11-27 Thread Matthias Brugger
On 16/10/2020 19:18, Fabien Parent wrote: Add node to support e-fuses on MT8516 Signed-off-by: Fabien Parent --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 7 +++ 1 file changed, 7 insertions(+) Applied to v5.10-next/dts64 Thanks! diff --git

Re: [PATCH v2] brcmfmac: expose firmware config files through modinfo

2020-11-20 Thread Matthias Brugger
On 20/11/2020 11:05, Dmitry Osipenko wrote: 20.11.2020 12:52, matthias@kernel.org пишет: From: Matthias Brugger Apart from a firmware binary the chip needs a config file used by the FW. Add the config files to modinfo so that they can be read by userspace. Signed-off-by: Matthias

Re: [PATCH v2] mfd: syscon: Add syscon_regmap_lookup_by_phandle_optional() function.

2020-11-19 Thread Matthias Brugger
On 19/11/2020 09:32, Lee Jones wrote: On Wed, 18 Nov 2020, Matthias Brugger wrote: On 17/11/2020 17:40, Arnd Bergmann wrote: On Tue, Nov 17, 2020 at 5:07 PM Lee Jones wrote: On Tue, 17 Nov 2020, Matthias Brugger wrote: On 17/11/2020 13:37, Lee Jones wrote: On Tue, 17 Nov 2020

Re: [PATCH v2] mfd: syscon: Add syscon_regmap_lookup_by_phandle_optional() function.

2020-11-18 Thread Matthias Brugger
On 17/11/2020 17:40, Arnd Bergmann wrote: On Tue, Nov 17, 2020 at 5:07 PM Lee Jones wrote: On Tue, 17 Nov 2020, Matthias Brugger wrote: On 17/11/2020 13:37, Lee Jones wrote: On Tue, 17 Nov 2020, Matthias Brugger wrote: If you want to go the route for me rebasing my tree on top

Re: [PATCH v2] mfd: syscon: Add syscon_regmap_lookup_by_phandle_optional() function.

2020-11-17 Thread Matthias Brugger
On 17/11/2020 13:37, Lee Jones wrote: On Tue, 17 Nov 2020, Matthias Brugger wrote: Hi Lee, On 13/11/2020 11:19, Lee Jones wrote: On Tue, 10 Nov 2020, Enric Balletbo i Serra wrote: This adds syscon_regmap_lookup_by_phandle_optional() function to get an optional regmap. It behaves

Re: [PATCH v2] mfd: syscon: Add syscon_regmap_lookup_by_phandle_optional() function.

2020-11-17 Thread Matthias Brugger
. In this case, instead of returning -ENODEV, the function returns NULL. This makes error checking simpler when the regmap phandle is optional. Suggested-by: Nicolas Boichat Signed-off-by: Enric Balletbo i Serra Reviewed-by: Matthias Brugger --- Changes in v2: - Add Matthias r-b tag. - Add

Re: [PATCH] clk: mediatek: fix mtk_clk_register_mux() as static function

2020-11-10 Thread Matthias Brugger
On 10/11/2020 02:38, Weiyi Lu wrote: On Mon, 2020-11-09 at 11:20 +0100, Greg KH wrote: On Mon, Nov 09, 2020 at 05:37:07PM +0800, Weiyi Lu wrote: mtk_clk_register_mux() should be a static function Fixes: a3ae549917f16 ("clk: mediatek: Add new clkmux register API") Cc: Why is this for

Re: [PATCH] mfd: syscon: Add syscon_regmap_lookup_by_phandle_optional() function.

2020-11-05 Thread Matthias Brugger
, the function returns NULL. This makes error checking simpler when the regmap phandle is optional. Suggested-by: Nicolas Boichat Signed-off-by: Enric Balletbo i Serra Reviewed-by: Matthias Brugger --- drivers/mfd/syscon.c | 13 + include/linux/mfd/syscon.h | 11 +++ 2

Re: [PATCH v5 1/1] arm64: dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile

2020-10-30 Thread Matthias Brugger
On 29/10/2020 16:50, Matthias Brugger wrote: On 27/10/2020 11:26, Seiya Wang wrote: Add basic chip support for Mediatek MT8192 Signed-off-by: Seiya Wang Pushed to v5.10-next/dts64 Thanks! ---   arch/arm64/boot/dts/mediatek/Makefile   |   1 +   arch/arm64/boot/dts/mediatek/mt8192

Re: [RESEND PATCH v3] arm64: dts: mediatek: align GPIO hog names with dtschema

2020-10-29 Thread Matthias Brugger
On 02/10/2020 18:39, Krzysztof Kozlowski wrote: The convention for node names is to use hyphens, not underscores. dtschema for pca95xx expects GPIO hogs to end with 'hog' suffix. Signed-off-by: Krzysztof Kozlowski Pushed to v5.10-next/dts64 Thanks! ---

Re: [PATCH v5 1/1] arm64: dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile

2020-10-29 Thread Matthias Brugger
On 27/10/2020 11:26, Seiya Wang wrote: Add basic chip support for Mediatek MT8192 Signed-off-by: Seiya Wang Pushed to v5.10-next/dts64 Thanks! --- arch/arm64/boot/dts/mediatek/Makefile | 1 + arch/arm64/boot/dts/mediatek/mt8192-evb.dts | 29 ++

Re: [PATCH v3 15/16] soc: mediatek: pm-domains: Add default power off flag

2020-10-29 Thread Matthias Brugger
On 27/10/2020 12:18, Weiyi Lu wrote: On Tue, 2020-10-27 at 11:53 +0100, Matthias Brugger wrote: On 26/10/2020 18:55, Enric Balletbo i Serra wrote: From: Weiyi Lu For some power domain, like conn on MT8192, it should be default OFF. Because the power on/off control relies the function

Re: [PATCH v3 05/16] soc: mediatek: pm_domains: Make bus protection generic

2020-10-29 Thread Matthias Brugger
On 27/10/2020 13:57, Fabien Parent wrote: - ret = mtk_infracfg_set_bus_protection(pd->infracfg, - bpd[i].bus_prot_mask, - bpd[i].bus_prot_reg_update); [snip] -

Re: [PATCH v3 15/16] soc: mediatek: pm-domains: Add default power off flag

2020-10-27 Thread Matthias Brugger
On 26/10/2020 18:55, Enric Balletbo i Serra wrote: From: Weiyi Lu For some power domain, like conn on MT8192, it should be default OFF. Because the power on/off control relies the function of connectivity chip and its firmware. And if project choose other chip vendor solution, those

Re: [PATCH v2 2/4] soc: mediatek: pm-domains: Add default power off flag

2020-10-27 Thread Matthias Brugger
On 22/10/2020 14:47, Weiyi Lu wrote: For some power domain, like conn on MT8192, it should be default OFF. Because the power on/off control relies the function of connectivity chip and its firmware. And if project choose other chip vendor solution, those necessary connectivity functions will

Re: [PATCH] mmc: host: mtk-sd: enable recheck_sdio_irq for MT8516 SoC

2020-10-27 Thread Matthias Brugger
On 23/10/2020 14:29, Fabien Parent wrote: MT8516 SoC suffers from sometimes losing SDIO IRQs, this makes SDIO devices sometimes unstable. Make use of the new property recheck_sdio_irq to fix the SDIO stability issues on MT8516. Signed-off-by: Fabien Parent Reviewed-by: Matthias Brugger

Re: [PATCH 3/3] thermal: mtk_thermal: make device_reset optional

2020-10-27 Thread Matthias Brugger
On 21/10/2020 18:42, Fabien Parent wrote: MT8516 does not support thermal reset. Use device_reset_optional instead of device_reset. Signed-off-by: Fabien Parent Reviewed-by: Matthias Brugger --- drivers/thermal/mtk_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] MAINTAINERS: change mediatek wiki page

2020-10-23 Thread Matthias Brugger
On 21/10/2020 18:53, Chun-Kuang Hu wrote: Hi, Matthias: 於 2020年10月20日 週二 下午11:27寫道: From: Matthias Brugger The old wiki page unfortunately got lost by server crash. The new wiki can be found on the kernel.org infrastructure Reviewed-by: Chun-Kuang Hu pushed to v5.10-tmp/soc

Re: [PATCH 3/5] pwm: pwm-mediatek: Add MT8183 SoC support

2020-10-19 Thread Matthias Brugger
On 19/10/2020 16:07, Fabien Parent wrote: Add PWM support for the MT8183 SoC Signed-off-by: Fabien Parent Reviewed-by: Matthias Brugger --- drivers/pwm/pwm-mediatek.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c

Re: [PATCH 1/5] dt-bindings: pwm: pwm-mediatek: Add documentation for MT8183 SoC

2020-10-19 Thread Matthias Brugger
On 19/10/2020 16:07, Fabien Parent wrote: Add binding documentation for the MT8183 SoC. Signed-off-by: Fabien Parent Reviewed-by: Matthias Brugger --- Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

Re: [PATCH 2/5] pwm: pwm-mediatek: always use bus clock

2020-10-19 Thread Matthias Brugger
this register is supported or not. On all the SoC I don't have the datasheet (MT2712, MT7622, MT7623, MT7628, MT7629) I kept the behavior to be the same as before this change. Signed-off-by: Fabien Parent Reviewed-by: Matthias Brugger --- drivers/pwm/pwm-mediatek.c | 12 1

Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add usb1 node

2020-10-19 Thread Matthias Brugger
On 14/10/2020 18:24, Fabien Parent wrote: The MT8516 has 2 USB instances. Add support for the second USB instance. usb1 can only work in host mode. Signed-off-by: Fabien Parent Applied to v5.10-tmp/dts64 Thanks! --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 21 +

Re: [PATCH 1/2] arm64: dts: mediatek: mt8516: rename usb phy

2020-10-19 Thread Matthias Brugger
On 14/10/2020 18:24, Fabien Parent wrote: The USB phy node is named usb0_phy but there is only one phy with 2 ports on MT8516. Rename the phy to make it more obvious it can also support the usb1 node. The usb1 node will be added in a follow-up commit. Signed-off-by: Fabien Parent Applied

Re: [PATCH 1/2] dt-bindings: dma: mtk-apdma: add bindings for MT8516 SOC

2020-10-19 Thread Matthias Brugger
On 15/10/2020 14:33, Fabien Parent wrote: Add bindings to APDMA for MT8516 SoC. MT8516 is compatible with MT6577. Signed-off-by: Fabien Parent Reviewed-by: Matthias Brugger --- Documentation/devicetree/bindings/dma/mtk-uart-apdma.txt | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node

2020-10-19 Thread Matthias Brugger
On 12/10/2020 22:52, Fabien Parent wrote: Add node for the auxadc IP. The IP is compatible with the one found in MT8173 SoC. Signed-off-by: Fabien Parent Applied to v5.10-tmp/dts64 Thanks! --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++ 1 file changed, 10 insertions(+)

Re: [PATCH] arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells value

2020-10-19 Thread Matthias Brugger
On 18/10/2020 21:42, Fabien Parent wrote: The binding documentation says: - #mbox-cells: Should be 2. < channel priority> phandle: Label name of a gce node. channel: Channel of mailbox. Be equal to the thread id of GCE. priority: Priority of GCE thread. Fix

Re: [PATCH] dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value

2020-10-19 Thread Matthias Brugger
a ("dt-binding: gce: remove atomic_exec in mboxes property") With that: Reviewed-by: Matthias Brugger Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt

Re: [PATCH v7 2/2] soc: mediatek: add mt6779 devapc driver

2020-10-15 Thread Matthias Brugger
On 15/10/2020 04:13, Neal Liu wrote: On Thu, 2020-10-08 at 10:35 +0800, Neal Liu wrote: On Wed, 2020-10-07 at 12:44 +0200, Matthias Brugger wrote: On 27/08/2020 05:06, Neal Liu wrote: [...] +static int devapc_sync_vio_dbg(struct mtk_devapc_context *ctx) +{ + void __iomem

Re: [PATCH v6 4/4] mmc: mediatek: Add subsys clock control for MT8192 msdc

2020-10-14 Thread Matthias Brugger
On 14/10/2020 05:06, Nicolas Boichat wrote: On Wed, Oct 14, 2020 at 10:29 AM Wenbin Mei wrote: On Tue, 2020-10-13 at 17:10 +0200, Matthias Brugger wrote: On 12/10/2020 14:45, Wenbin Mei wrote: MT8192 msdc is an independent sub system, we need control more bus clocks for it. Add support

Re: [PATCH] iio: adc: mediatek: fix unset field

2020-10-13 Thread Matthias Brugger
, add mt6765 support") Signed-off-by: Fabien Parent Ouch. Reviewed-by: Matthias Brugger --- drivers/iio/adc/mt6577_auxadc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c index ac415cb089cd..7bd48377cd79 100644 ---

Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node

2020-10-13 Thread Matthias Brugger
On 13/10/2020 11:06, Fabien Parent wrote: Hi Matthias, Any reason you don't enable the status in the pumpkin dts? No particular reasons. I looked at what other MTK SoC did for this IP, and half went with the status to be disabled and the other half went with an enabled status. So I went

Re: [PATCH v6 4/4] mmc: mediatek: Add subsys clock control for MT8192 msdc

2020-10-13 Thread Matthias Brugger
On 12/10/2020 14:45, Wenbin Mei wrote: MT8192 msdc is an independent sub system, we need control more bus clocks for it. Add support for the additional subsys clocks to allow it to be configured appropriately. Signed-off-by: Wenbin Mei --- drivers/mmc/host/mtk-sd.c | 74

Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node

2020-10-13 Thread Matthias Brugger
On 12/10/2020 22:52, Fabien Parent wrote: Add node for the auxadc IP. The IP is compatible with the one found in MT8173 SoC. Signed-off-by: Fabien Parent --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PATCH 1/2] dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC

2020-10-13 Thread Matthias Brugger
On 12/10/2020 22:52, Fabien Parent wrote: Add documentation for the auxadc binding for MT8516 SoC. Signed-off-by: Fabien Parent Reviewed-by: Matthias Brugger --- Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 00/12] soc: mediatek: pm-domains: Add new driver for SCPSYS power domains controller

2020-10-09 Thread Matthias Brugger
On 06/10/2020 08:53, Weiyi Lu wrote: On Fri, 2020-09-25 at 16:04 +0200, Matthias Brugger wrote: On 25/09/2020 12:06, Weiyi Lu wrote: On Thu, 2020-09-10 at 19:28 +0200, Enric Balletbo i Serra wrote: Dear all, This is a new driver with the aim to deprecate the mtk-scpsys driver

Re: [PATCH v7 2/2] soc: mediatek: add mt6779 devapc driver

2020-10-09 Thread Matthias Brugger
On 08/10/2020 11:39, Neal Liu wrote: On Thu, 2020-10-08 at 10:45 +0200, Matthias Brugger wrote: On 08/10/2020 04:35, Neal Liu wrote: On Wed, 2020-10-07 at 12:44 +0200, Matthias Brugger wrote: On 27/08/2020 05:06, Neal Liu wrote: [...] +static int mtk_devapc_probe(struct

Re: [PATCH v10 2/3] arm64: dts: add dts nodes for MT6779

2020-10-09 Thread Matthias Brugger
On 30/07/2020 15:30, Hanks Chen wrote: this adds initial MT6779 dts settings for board support, including cpu, gic, timer, ccf, pinctrl, uart, sysirq...etc. Signed-off-by: Hanks Chen --- arch/arm64/boot/dts/mediatek/Makefile | 1 + arch/arm64/boot/dts/mediatek/mt6779-evb.dts |

Re: [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers

2020-10-08 Thread Matthias Brugger
On 08/10/2020 09:49, Enric Balletbo i Serra wrote: Hi Chun-Kuang, On 8/10/20 2:01, Chun-Kuang Hu wrote: Hi, Enric: Enric Balletbo i Serra 於 2020年10月7日 週三 上午3:33寫道: From: CK Hu Actually, setting the registers for routing, use multiple 'if-else' for different routes, but this code

Re: [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers

2020-10-08 Thread Matthias Brugger
Hi Enric and CK, On 06/10/2020 21:33, Enric Balletbo i Serra wrote: From: CK Hu Actually, setting the registers for routing, use multiple 'if-else' for different routes, but this code would be more and more complicated while we support more and more SoCs. Change that and use a table per SoC

Re: [PATCH v7 2/2] soc: mediatek: add mt6779 devapc driver

2020-10-08 Thread Matthias Brugger
On 08/10/2020 04:35, Neal Liu wrote: On Wed, 2020-10-07 at 12:44 +0200, Matthias Brugger wrote: On 27/08/2020 05:06, Neal Liu wrote: MediaTek bus fabric provides TrustZone security support and data protection to prevent slaves from being accessed by unexpected masters. The security

Re: [PATCH v10 3/3] clk: mediatek: add UART0 clock support

2020-10-08 Thread Matthias Brugger
Hi Stephen, On 08/10/2020 04:00, Stephen Boyd wrote: Quoting Hanks Chen (2020-10-03 03:06:47) Hi Michael & Stephen, Please kindly let me know your comments about this patch. Thanks What's the base for this patch? I tried applying to v5.9-rc1 and it didn't work. Can you please double

Re: [PATCH v7 2/2] soc: mediatek: add mt6779 devapc driver

2020-10-07 Thread Matthias Brugger
On 27/08/2020 05:06, Neal Liu wrote: MediaTek bus fabric provides TrustZone security support and data protection to prevent slaves from being accessed by unexpected masters. The security violation is logged and sent to the processor for further analysis or countermeasures. Any occurrence of

Re: [PATCH v2 06/12] soc: mediatek: pm-domains: Add SMI block as bus protection block

2020-10-05 Thread Matthias Brugger
On 05/10/2020 03:48, Nicolas Boichat wrote: On Fri, Oct 2, 2020 at 4:56 PM Matthias Brugger wrote: On 01/10/2020 18:01, Enric Balletbo i Serra wrote: From: Matthias Brugger Apart from the infracfg block, the SMI block is used to enable the bus protection for some power domains. Add

Re: [v5,0/4] watchdog: mt8192: add wdt support

2020-10-02 Thread Matthias Brugger
On 01/10/2020 17:16, Guenter Roeck wrote: On Thu, Oct 01, 2020 at 04:23:02PM +0200, Matthias Brugger wrote: Hi Crystal, It seems you forgot to send the email to one of the maintainers, Wim. Please make sure you add all the maintainers from get_maintainers.pl when you send a series. Regards

Re: [v5,2/4] dt-binding: mediatek: mt8192: update mtk-wdt document

2020-10-02 Thread Matthias Brugger
On 29/09/2020 05:20, Crystal Guo wrote: update mtk-wdt document for MT8192 platform Signed-off-by: Crystal Guo Reviewed-by: Matthias Brugger Reviewed-by: Guenter Roeck You added Guenters Reviewed-by in v4 of this series, but I don't see that on Guenter provided this tag. In the future

Re: [PATCH v2 07/12] soc: mediatek: pm-domains: Add extra sram control

2020-10-02 Thread Matthias Brugger
On 01/10/2020 18:01, Enric Balletbo i Serra wrote: From: Matthias Brugger For some power domains like vpu_core on MT8183 whose sram need to do clock and internal isolation while power on/off sram. We add a cap "MTK_SCPD_SRAM_ISO" to judge if we need to do the extra sram isolati

Re: [PATCH] arm64: dts: mediatek: Add smi_common node for MT8183

2020-10-02 Thread Matthias Brugger
On 01/10/2020 18:28, Enric Balletbo i Serra wrote: The SMI (Smart Multimedia Interface) Common is a bridge between the m4u (Multimedia Memory Management Unit) and the Multimedia HW. This block is needed to support different multimedia features, like display, video decode, and camera. Also is

Re: [PATCH v2 12/12] arm64: dts: mediatek: Add mt8183 power domains controller

2020-10-02 Thread Matthias Brugger
On 01/10/2020 18:01, Enric Balletbo i Serra wrote: From: Matthias Brugger Add power domains controller node for SoC mt8183 Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None arch/arm64/boot/dts/mediatek/mt8183.dtsi | 162

Re: [PATCH v2 08/12] soc: mediatek: pm-domains: Add subsystem clocks

2020-10-02 Thread Matthias Brugger
On 01/10/2020 18:01, Enric Balletbo i Serra wrote: From: Matthias Brugger For the bus protection operations, some subsystem clocks need to be enabled before releasing the protection. This patch identifies the subsystem clocks by it's name. Suggested-by: Weiyi Lu [Adapted the patch

Re: [PATCH v2 06/12] soc: mediatek: pm-domains: Add SMI block as bus protection block

2020-10-02 Thread Matthias Brugger
On 01/10/2020 18:01, Enric Balletbo i Serra wrote: From: Matthias Brugger Apart from the infracfg block, the SMI block is used to enable the bus protection for some power domains. Add support for this block. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra

Re: [PATCH] arm64: dts: mt8173-elm: Remove ddc property from panel

2020-10-01 Thread Matthias Brugger
On 26/08/2020 11:02, Enric Balletbo i Serra wrote: The elm and hana devices uses an Embedded DisplayPort (eDP) as interface for its panel, so the DDC channel specified in the binding is useless. Signed-off-by: Enric Balletbo i Serra --- Applied to v5.10-tmp/dts64 which will be rebased on

Re: [PATCH v2] soc: mediatek: Check if power domains can be powered on at boot time

2020-10-01 Thread Matthias Brugger
On 28/09/2020 05:31, Nicolas Boichat wrote: In the error case, where a power domain cannot be powered on successfully at boot time (in mtk_register_power_domains), pm_genpd_init would still be called with is_off=false, and the system would later try to disable the power domain again,

Re: [PATCH v17 06/12] soc: mediatek: Add support for hierarchical scpsys device node

2020-10-01 Thread Matthias Brugger
On 30/09/2020 05:37, Weiyi Lu wrote: On Mon, 2020-09-28 at 15:14 +0800, Nicolas Boichat wrote: On Thu, Aug 6, 2020 at 5:22 PM Weiyi Lu wrote: Try to list all the power domains of under power controller node to show the dependency between each power domain directly instead of filling the

Re: [v5,0/4] watchdog: mt8192: add wdt support

2020-10-01 Thread Matthias Brugger
Hi Crystal, It seems you forgot to send the email to one of the maintainers, Wim. Please make sure you add all the maintainers from get_maintainers.pl when you send a series. Regards, Matthias On 29/09/2020 05:20, Crystal Guo wrote: v5 changes: fix typos on:

Re: [PATCH v3 0/9] Mediatek MT8192 clock support

2020-10-01 Thread Matthias Brugger
Hi Weiyi, On 03/09/2020 05:22, Weiyi Lu wrote: This series is based on v5.9-rc1 and MT8192 dts[1]. [1] https://patchwork.kernel.org/cover/11713555/ changes since v2: - update and split dt-binding documents by functionalities - add error checking in probe() function - fix incorrect clock

Re: [PATCH v3 7/9] clk: mediatek: Fix asymmetrical PLL enable and disable control

2020-10-01 Thread Matthias Brugger
On 03/09/2020 05:22, Weiyi Lu wrote: The en_mask actually is a combination of divider enable mask and pll enable bit(bit0). Before this patch, we enabled both divider mask and bit0 in prepare(), but only cleared the bit0 in unprepare(). Now, setting the enable register(CON0) in 2 steps: first

<    1   2   3   4   5   6   7   8   9   10   >