Re: [PATCH v2 1/2] iio: stm32 trigger: Add quadrature encoder device

2017-03-25 Thread Michael Welling
own to 0. > > This preset value could be set/get by using > > /sys/bus/iio/devices/iio:deviceX/in_count0_preset attribute. > > > > Signed-off-by: Benjamin Gaignard > A few little nitpicks. > > Otherwise I like this. Would love William to give another review

Re: [PATCH v2 1/2] iio: stm32 trigger: Add quadrature encoder device

2017-03-25 Thread Michael Welling
own to 0. > > This preset value could be set/get by using > > /sys/bus/iio/devices/iio:deviceX/in_count0_preset attribute. > > > > Signed-off-by: Benjamin Gaignard > A few little nitpicks. > > Otherwise I like this. Would love William to give another review

Re: [PATCH] Input: tsc200x - Report proper input_dev name

2016-07-20 Thread Michael Welling
On Wed, Jul 20, 2016 at 08:54:05AM +0200, Pavel Machek wrote: > > By same logic we shouldn't change from TSC200X back to TSC2005 because of > > people's possibly new setup in the last 9 months. > > That's your, broken logic. > > TSC200X->TSC2005 needs to be fixed, because people seen the TSC2005

Re: [PATCH] Input: tsc200x - Report proper input_dev name

2016-07-19 Thread Michael Welling
set the input_dev->name > > variable according to the type of touchscreen used. > > > > Signed-off-by: Michael Welling > > --- > > drivers/input/touchscreen/tsc2004.c | 7 ++- > > drivers/input/touchscreen/tsc2005.c | 7 ++- > > drivers/in

[PATCH] Input: tsc200x - Report proper input_dev name

2016-07-19 Thread Michael Welling
Passes input_id struct to the the common probe function for the tsc200x drivers instead of just the bustype. This allows for the use of the product variable to set the input_dev->name variable according to the type of touchscreen used. Signed-off-by: Michael Welling --- drivers/in

Re: v4.1 to v4.7: regression in tsc2005 driver

2016-07-19 Thread Michael Welling
On Wed, Jul 20, 2016 at 04:26:44AM +0300, Aaro Koskinen wrote: > On Tue, Jul 19, 2016 at 07:39:08PM -0500, Michael Welling wrote: > > On Tue, Jul 19, 2016 at 04:51:20PM -0700, Dmitry Torokhov wrote: > > > On Sun, Jul 17, 2016 at 05:56:36PM -0500, Michael Welling wrote: > >

Re: v4.1 to v4.7: regression in tsc2005 driver

2016-07-19 Thread Michael Welling
On Tue, Jul 19, 2016 at 06:44:24PM -0700, Dmitry Torokhov wrote: > On Tue, Jul 19, 2016 at 08:34:57PM -0500, Michael Welling wrote: > > On Tue, Jul 19, 2016 at 05:53:07PM -0700, Dmitry Torokhov wrote: > > > On Tue, Jul 19, 2016 at 07:39:08PM -0500, Michael Welling wrote: >

Re: v4.1 to v4.7: regression in tsc2005 driver

2016-07-19 Thread Michael Welling
On Tue, Jul 19, 2016 at 05:53:07PM -0700, Dmitry Torokhov wrote: > On Tue, Jul 19, 2016 at 07:39:08PM -0500, Michael Welling wrote: > > On Tue, Jul 19, 2016 at 04:51:20PM -0700, Dmitry Torokhov wrote: > > > On Sun, Jul 17, 2016 at 05:56:36PM -0500, Michael Welling wrote: >

Re: v4.1 to v4.7: regression in tsc2005 driver

2016-07-19 Thread Michael Welling
On Tue, Jul 19, 2016 at 04:51:20PM -0700, Dmitry Torokhov wrote: > On Sun, Jul 17, 2016 at 05:56:36PM -0500, Michael Welling wrote: > > On Sun, Jul 17, 2016 at 10:03:39PM +0200, Pavel Machek wrote: > > > On Sun 2016-07-17 13:51:34, Michael Welling wrote: > > > > On S

Re: v4.1 to v4.7: regression in tsc2005 driver

2016-07-17 Thread Michael Welling
On Sun, Jul 17, 2016 at 10:03:39PM +0200, Pavel Machek wrote: > On Sun 2016-07-17 13:51:34, Michael Welling wrote: > > On Sun, Jul 17, 2016 at 08:42:09PM +0200, Pavel Machek wrote: > > > On Sun 2016-07-17 13:24:45, Michael Welling wrote: > > > > On Sun, Jul 17, 2

Re: v4.1 to v4.7: regression in tsc2005 driver

2016-07-17 Thread Michael Welling
On Sun, Jul 17, 2016 at 08:42:09PM +0200, Pavel Machek wrote: > On Sun 2016-07-17 13:24:45, Michael Welling wrote: > > On Sun, Jul 17, 2016 at 07:52:57PM +0200, Pavel Machek wrote: > > > Hi! > > > > > > tsc2005 driver changed input device name, from > >

Re: v4.1 to v4.7: regression in tsc2005 driver

2016-07-17 Thread Michael Welling
On Sun, Jul 17, 2016 at 07:52:57PM +0200, Pavel Machek wrote: > Hi! > > tsc2005 driver changed input device name, from > > drivers/input/touchscreen/tsc2005.c:input_dev->name = "TSC2005 > touchscreen"; > > to "TSC200X touchscreen". Unfortunately, X seems to propagate that > name to userspace

Re: Regression in inv_mpu6050: 4.6.0-rc5

2016-04-26 Thread Michael Welling
On Tue, Apr 26, 2016 at 11:26:51PM +0100, One Thousand Gnomes wrote: > > This now causes us to crash and burn on the ASUS T100TA Baytrail/T > platforms > I believe this regression has already been patched. Check the latest commits in linux-next. https://git.kernel.org/cgit/linux/kernel/git/next

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-03-01 Thread Michael Welling
On Tue, Mar 01, 2016 at 08:35:01AM +, ji...@jic23.retrosnub.co.uk wrote: > On 01.03.2016 02:42, Michael Welling wrote: > >On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: > >>On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling > >>wrote: > >>

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-03-01 Thread Michael Welling
On Tue, Mar 01, 2016 at 01:28:26PM +0200, Daniel Baluta wrote: > On Tue, Mar 1, 2016 at 4:42 AM, Michael Welling wrote: > > On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: > >> On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling wrote: > >> > On F

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-29 Thread Michael Welling
On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: > On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling wrote: > > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: > >> The driver has sysfs readings with runtime PM support for power saving. > >

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-29 Thread Michael Welling
On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: > On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling wrote: > > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: > >> The driver has sysfs readings with runtime PM support for power saving. > >

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-29 Thread Michael Welling
On Mon, Feb 29, 2016 at 10:09:10PM -0300, Lucas De Marchi wrote: > On Mon, Feb 29, 2016 at 9:50 PM, Michael Welling wrote: > > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: > >> The driver has sysfs readings with runtime PM support for power saving. > >

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-29 Thread Michael Welling
On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: > The driver has sysfs readings with runtime PM support for power saving. > It also offers buffer support that can be used together with IIO software > triggers. > Daniel, So I noticed something yesterday while testing new boards. The

Re: [LKP] [lkp] [gpio] 3c702e9987: kmsg.user_verbs:couldn't_register_device_number

2016-02-23 Thread Michael Welling
On Tue, Feb 23, 2016 at 02:35:14PM +0800, Huang, Ying wrote: > Linus Walleij writes: > > > On Mon, Feb 15, 2016 at 3:39 AM, Huang, Ying wrote: > >> Michael Welling writes: > > > >>> Could you run cat /proc/devices? > >> > >> Sorry, th

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-17 Thread Michael Welling
On Wed, Feb 10, 2016 at 10:36:22AM -0600, Michael Welling wrote: > On Wed, Feb 10, 2016 at 08:39:04PM +0530, Sricharan wrote: > > > Hi Sricharan, > > > > > > Are you looking at pca9685_pwm_probe in drivers/pwm/pwm-pca9685.c > > > right? > > > &g

Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

2016-02-15 Thread Michael Welling
On Mon, Feb 15, 2016 at 11:36:13AM -0800, Greg Kroah-Hartman wrote: > On Mon, Feb 15, 2016 at 12:50:41PM -0600, Michael Welling wrote: > > On Mon, Feb 15, 2016 at 10:15:08AM -0800, Greg Kroah-Hartman wrote: > > > On Sun, Feb 14, 2016 at 09:08:50PM -0600, Michael Welling wrote: &

Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

2016-02-15 Thread Michael Welling
On Mon, Feb 15, 2016 at 10:15:08AM -0800, Greg Kroah-Hartman wrote: > On Sun, Feb 14, 2016 at 09:08:50PM -0600, Michael Welling wrote: > > On Sun, Feb 14, 2016 at 03:17:36PM -0800, Greg Kroah-Hartman wrote: > > > On Sun, Feb 14, 2016 at 04:50:47PM -0600, Michael Welling wrote: &

Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

2016-02-15 Thread Michael Welling
On Mon, Feb 15, 2016 at 11:03:51AM +, Mark Brown wrote: > On Sun, Feb 14, 2016 at 04:50:47PM -0600, Michael Welling wrote: > > > spi: omap2-mcspi: Add calls for pinctrl state select > > That doesn't sound like stable material, it's adding a new feature which &g

Re: [lkp] [gpio] 3c702e9987: kmsg.user_verbs:couldn't_register_device_number

2016-02-14 Thread Michael Welling
On Sun, Feb 14, 2016 at 03:49:54PM -0800, Greg KH wrote: > On Sun, Feb 14, 2016 at 01:51:20PM -0600, Michael Welling wrote: > > On Sun, Feb 14, 2016 at 11:05:15AM -0800, Greg KH wrote: > > > On Sun, Feb 14, 2016 at 06:56:20PM +0100, Linus Walleij wrote: > > > > O

Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

2016-02-14 Thread Michael Welling
On Sun, Feb 14, 2016 at 03:17:36PM -0800, Greg Kroah-Hartman wrote: > On Sun, Feb 14, 2016 at 04:50:47PM -0600, Michael Welling wrote: > > On Sun, Feb 14, 2016 at 02:20:48PM -0800, Greg Kroah-Hartman wrote: > > > 4.3-stable review patch. If anyone has any objections, please

Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

2016-02-14 Thread Michael Welling
essages. > > It fixes this bug on a DM8168 SoC ES2.1 Soc and an OMAP4 ES2.1 SoC. > It was hanging all the other channels transfers when a CHCONF_FORCE > is present on the wrong channel. > > Fixes: b28cb9414db9 ("spi: omap2-mcspi: Switch driver to use transfer_one")

Re: [lkp] [gpio] 3c702e9987: kmsg.user_verbs:couldn't_register_device_number

2016-02-14 Thread Michael Welling
on this... you'd know if this happened > > >> before. > > >> > > >> On Sun, Feb 14, 2016 at 9:06 AM, Michael Welling > > >> wrote: > > >> > On Sun, Feb 14, 2016 at 02:59:06PM +0800, kernel test robot wrote: > > >> >

Re: [lkp] [gpio] 3c702e9987: kmsg.user_verbs:couldn't_register_device_number

2016-02-14 Thread Michael Welling
On Sun, Feb 14, 2016 at 02:59:06PM +0800, kernel test robot wrote: > FYI, we noticed the below changes on > > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git chardev > commit 3c702e9987e261042a07e43460a8148be254412e ("gpio: add a userspace > chardev ABI for GPIOs") > > > [

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-10 Thread Michael Welling
On Wed, Feb 10, 2016 at 08:39:04PM +0530, Sricharan wrote: > > Hi Sricharan, > > > > Are you looking at pca9685_pwm_probe in drivers/pwm/pwm-pca9685.c > > right? > > > Yes. > > > I'm asking this because this driver doesn't seem to support runtime pm and > > there is no check for regmap_write/re

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-08 Thread Michael Welling
On Mon, Feb 08, 2016 at 09:00:27PM +0100, Wolfram Sang wrote: > > > > On Mon, Feb 08, 2016 at 11:25:00AM +0100, Wolfram Sang wrote: > > > > > On Fri, Feb 05, 2016 at 06:32:45PM -0600, Michael Welling wrote: > > > > > > On Fri, Feb 05,

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-08 Thread Michael Welling
On Tue, Feb 09, 2016 at 12:41:35AM +0530, Sricharan wrote: > Hi, > > > -Original Message- > > From: Michael Welling [mailto:mwellin...@gmail.com] On Behalf Of Michael > > Welling > > Sent: Monday, February 08, 2016 10:07 PM > > To: Wolfram Sang >

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-08 Thread Michael Welling
On Mon, Feb 08, 2016 at 04:44:02PM +0200, Daniel Baluta wrote: > On Mon, Feb 8, 2016 at 12:25 PM, Wolfram Sang wrote: > > On Fri, Feb 05, 2016 at 06:32:45PM -0600, Michael Welling wrote: > >> On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote: > >> > &

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-08 Thread Michael Welling
On Mon, Feb 08, 2016 at 11:25:00AM +0100, Wolfram Sang wrote: > On Fri, Feb 05, 2016 at 06:32:45PM -0600, Michael Welling wrote: > > On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote: > > > >> +static int ads1015_read_raw(s

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Michael Welling
On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote: > >> +static int ads1015_read_raw(struct iio_dev *indio_dev, > >> + struct iio_chan_spec const *chan, int *val, > >> + int *val2, long mask) > >> +{ > >> + int ret, idx; > >> + str

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Michael Welling
On Fri, Feb 05, 2016 at 09:32:34PM +0200, Daniel Baluta wrote: > On Fri, Feb 5, 2016 at 7:25 PM, Michael Welling wrote: > > On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: > >> The driver has sysfs readings with runtime PM support for power saving. > >

Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

2016-02-05 Thread Michael Welling
On Fri, Feb 05, 2016 at 03:17:18PM +0200, Daniel Baluta wrote: > The driver has sysfs readings with runtime PM support for power saving. > It also offers buffer support that can be used together with IIO software > triggers. > > Datasheet can be found here: > http://www.ti.com.cn/cn/lit/ds/s

Re: [PATCH v3] iio: adc: Add TI ADS1015 ADC driver support

2016-02-03 Thread Michael Welling
On Wed, Feb 03, 2016 at 06:59:56PM +0200, Daniel Baluta wrote: > The driver has sysfs readings with runtime PM support for power saving. > It also offers buffer support that can be used together with IIO software > triggers. > > Datasheet can be found here: > http://www.ti.com.cn/cn/lit/ds/s

[PATCH] spi: omap2-mcspi: Prevent duplicate gpio_request

2015-11-30 Thread Michael Welling
Occasionally the setup function will be called multiple times. Only request the gpio the first time otherwise -EBUSY will occur on subsequent calls to setup. Reported-by: Joseph Bell Signed-off-by: Michael Welling --- drivers/spi/spi-omap2-mcspi.c | 19 ++- 1 file changed, 10

Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings

2015-11-03 Thread Michael Welling
On Tue, Nov 03, 2015 at 02:59:13PM -0800, Dmitry Torokhov wrote: > On Tue, Nov 03, 2015 at 09:41:17AM -0600, Michael Welling wrote: > > On Tue, Nov 03, 2015 at 09:31:10AM -0600, Rob Herring wrote: > > > On Tue, Nov 3, 2015 at 1:21 AM, Dmitry Torokhov > > > wrote: >

Re: [PATCH 1/4] Input: tsc2005 - Separate SPI and core functions

2015-11-03 Thread Michael Welling
On Mon, Nov 02, 2015 at 05:49:46PM -0800, Dmitry Torokhov wrote: > On Fri, Oct 30, 2015 at 07:41:23PM -0500, Michael Welling wrote: > > This patch separates the SPI functionality from core functionality > > that overlaps with the tsc2004. > > > > Prepares kernel for

Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings

2015-11-03 Thread Michael Welling
On Tue, Nov 03, 2015 at 09:31:10AM -0600, Rob Herring wrote: > On Tue, Nov 3, 2015 at 1:21 AM, Dmitry Torokhov > wrote: > > On Mon, Nov 02, 2015 at 02:50:29PM -0600, Michael Welling wrote: > >> On Mon, Nov 02, 2015 at 09:19:50AM -0600, Rob Herring wrote: > >

Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings

2015-11-02 Thread Michael Welling
On Mon, Nov 02, 2015 at 09:19:50AM -0600, Rob Herring wrote: > > +Required properties: > > + - compatible: "ti,tsc2004" > > + - interrupts: IRQ specifier > > + - vio-supply : Regulator specifier > > reg property? Rob, It appears that I missed this

[PATCH 3/4] Input: tsc2004 - Add support for tsc2004

2015-10-30 Thread Michael Welling
Adds support for the i2c based tsc2004. Signed-off-by: Michael Welling --- drivers/input/touchscreen/Kconfig | 13 ++ drivers/input/touchscreen/Makefile | 1 + drivers/input/touchscreen/tsc2004.c | 86 + 3 files changed, 100 insertions(+) create mode

[PATCH 1/4] Input: tsc2005 - Separate SPI and core functions

2015-10-30 Thread Michael Welling
This patch separates the SPI functionality from core functionality that overlaps with the tsc2004. Prepares kernel for new tsc2004 driver without much redundant code. Signed-off-by: Michael Welling --- drivers/input/touchscreen/Kconfig | 4 + drivers/input/touchscreen

[PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings

2015-10-30 Thread Michael Welling
Adds documentation for the devicetree bindings of the new tsc2004 driver. Signed-off-by: Michael Welling --- .../bindings/input/touchscreen/tsc2005.txt | 39 ++ 1 file changed, 39 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/tsc2005

[PATCH 2/4] Input: tsc200x-core - Rename functions and variables

2015-10-30 Thread Michael Welling
The functions, variables, and defines of the new tsc200x-core.c are renamed to tsc200x instead of tsc2005 avoid possible confusion. Signed-off-by: Michael Welling --- drivers/input/touchscreen/tsc2005.c | 2 +- drivers/input/touchscreen/tsc200x-core.c | 200

[PATCH v4 0/4] tsc2005 - Add support for tsc2004

2015-10-30 Thread Michael Welling
separate drivers with with common routines in tsc200x-core. v2: Fixes Kconfig based on report for 0-day build bot. Michael Welling (4): Input: tsc2005 - Seperate SPI and core functions Input: tsc200x-core - Rename functions and variables Input: tsc2004 - Add support for tsc2004 Input: tsc2004

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread Michael Welling
Dmitry, On Thu, Oct 29, 2015 at 06:45:22PM -0700, Dmitry Torokhov wrote: > Hi Michael, > > On Wed, Oct 28, 2015 at 07:12:34PM -0500, Michael Welling wrote: > > Adds support for the i2c based tsc2004. > > > > Due to the overlapping functionality of the tsc2004 and tsc2

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread Michael Welling
On Fri, Oct 30, 2015 at 09:39:05AM +0900, Mark Brown wrote: > On Thu, Oct 29, 2015 at 03:23:31PM -0700, Dmitry Torokhov wrote: > > > However, you have regmap in the driver core already. Mark, is it > > possible to have regmap API also allow doing raw underlying protocol > > transfer so that consum

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread Michael Welling
On Thu, Oct 29, 2015 at 10:46:20PM +0100, Arnd Bergmann wrote: > On Thursday 29 October 2015 09:22:37 Michael Welling wrote: > > > > > > All errors (new ones prefixed by >>): > > > > > >drivers/built-in.o: In function `tsc2005_cmd': &

Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-29 Thread Michael Welling
On Thu, Oct 29, 2015 at 03:25:34PM +0800, kbuild test robot wrote: > Hi Michael, > > [auto build test ERROR on input/next -- if it's inappropriate base, please > suggest rules for selecting the more suitable base] > > url: > https://github.com/0day-ci/linux/com

[PATCH v3] Input: tsc2005 - Add support for tsc2004

2015-10-28 Thread Michael Welling
Adds support for the i2c based tsc2004. Due to the overlapping functionality of the tsc2004 and tsc2005 the common code was moved to a core driver (tsc200x-core). Signed-off-by: Michael Welling --- v3: Splits the tsc2004 and tsc2005 into separate drivers with with common routines in tsc200x

Re: [PATCH v2] Input: tsc2005 - Add support for tsc2004

2015-10-27 Thread Michael Welling
On Tue, Oct 27, 2015 at 10:41:52PM -0700, Dmitry Torokhov wrote: > On Wed, Oct 28, 2015 at 12:23:34AM -0500, Michael Welling wrote: > > On Tue, Oct 27, 2015 at 06:51:41PM -0700, Dmitry Torokhov wrote: > > > Hi Michael, > > > On Tue, Oct 27, 2015 at 07:17:01PM -

Re: [PATCH v2] Input: tsc2005 - Add support for tsc2004

2015-10-27 Thread Michael Welling
On Wed, Oct 28, 2015 at 12:37:35PM +0800, kbuild test robot wrote: > Hi Michael, > > [auto build test ERROR on input/next -- if it's inappropriate base, please > suggest rules for selecting the more suitable base] > > url: > https://github.com/0day-ci/linux/com

Re: [PATCH v2] Input: tsc2005 - Add support for tsc2004

2015-10-27 Thread Michael Welling
On Tue, Oct 27, 2015 at 06:51:41PM -0700, Dmitry Torokhov wrote: > Hi Michael, > On Tue, Oct 27, 2015 at 07:17:01PM -0500, Michael Welling wrote: > > Adds support for the i2c based tsc2004. Support was added to the tsc2005 > > driver > > due to the similarity of the devi

[PATCH v2] Input: tsc2005 - Add support for tsc2004

2015-10-27 Thread Michael Welling
Adds support for the i2c based tsc2004. Support was added to the tsc2005 driver due to the similarity of the devices. Signed-off-by: Michael Welling --- v2: Fixes Kconfig based on report for 0-day build bot. .../bindings/input/touchscreen/tsc2004.txt | 38 drivers/input

Re: [PATCH] Input: tsc2005 - Add support for tsc2004

2015-10-27 Thread Michael Welling
On Tue, Oct 27, 2015 at 03:36:43PM -0500, Michael Welling wrote: > Adds support for the i2c based tsc2004. Support was added to the tsc2005 > driver > due to the similarity of the devices. > It should be noted that the new TSC2004 I2C support was tested but I do not have a dev

[PATCH] Input: tsc2005 - Add support for tsc2004

2015-10-27 Thread Michael Welling
Adds support for the i2c based tsc2004. Support was added to the tsc2005 driver due to the similarity of the devices. Signed-off-by: Michael Welling --- .../bindings/input/touchscreen/tsc2004.txt | 38 drivers/input/touchscreen/Kconfig | 5 +- drivers/input

Re: [PATCH 1/2] iio: adc: mcp320x: Deprecated compatible strings with no vendor prefix

2015-10-25 Thread Michael Welling
On Sun, Oct 25, 2015 at 12:36:37PM +, Jonathan Cameron wrote: > Small point, Michael. Please add such acks below the the Author sign off. > Otherwise sometimes I miss them! Added it now for this one. Okay sorry about the misplacement. -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH 2/2] iio: adc: mcp320x: Add compatible with vendor prefix to OF table

2015-10-14 Thread Michael Welling
[mcp3202], > + }, { > + .compatible = "microchip,mcp3204", > + .data = &mcp320x_chip_infos[mcp3204], > + }, { > + .compatible = "microchip,mcp3208", > + .data = &mcp320x_chip_infos[mcp3208], > +

Re: [PATCH 1/2] iio: adc: mcp320x: Deprecated compatible strings with no vendor prefix

2015-10-14 Thread Michael Welling
,mcp3001" > + "microchip,mcp3002" > + "microchip,mcp3004" > + "microchip,mcp3008" > + "microchip,mcp3201" > +

Re: [PATCH v2] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

2015-10-09 Thread Michael Welling
On Fri, Oct 09, 2015 at 05:29:26PM +0200, Neil Armstrong wrote: > On 10/09/2015 05:26 PM, Michael Welling wrote: > > On Fri, Oct 09, 2015 at 03:47:41PM +0200, Neil Armstrong wrote: > >> Since the "Switch driver to use transfer_one" change, the cs_change > >> be

Re: [PATCH v2] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

2015-10-09 Thread Michael Welling
On Fri, Oct 09, 2015 at 03:47:41PM +0200, Neil Armstrong wrote: > Since the "Switch driver to use transfer_one" change, the cs_change > behavior has changed and a channel chip select can still be > asserted when changing channel from a previous last transfer in a > message having the cs_change attr

Re: [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

2015-10-09 Thread Michael Welling
On Fri, Oct 09, 2015 at 12:38:10PM +0100, Mark Brown wrote: > On Thu, Oct 08, 2015 at 10:21:05AM -0500, Michael Welling wrote: > > On Thu, Oct 08, 2015 at 04:45:00PM +0200, Neil Armstrong wrote: > > > What is the point of doing this void cast below? > > Avoiding

Re: [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

2015-10-08 Thread Michael Welling
On Thu, Oct 08, 2015 at 04:45:00PM +0200, Neil Armstrong wrote: > Since the "Switch driver to use transfer_one" change, the cs_change > behavior has changed and a channel chip select can still be > asserted when changing channel from a previous last transfer in s > message having the cs_change attr

Re: McSPI hangs with cs_change after "Switch driver to use transfer_one" change

2015-10-08 Thread Michael Welling
On Thu, Oct 08, 2015 at 02:54:50PM +0100, Neil Armstrong wrote: > Hi All, > > I'm in a use case where I use cs_change on McSPI channel 3 on a single > transfer Full-Duplex message, then I transfer a single full duplex message > without cs_change on channel 1. > > Here is a better representation

Re: [PATCH] net: phy: Handle postive return codes in phy_connect

2015-09-05 Thread Michael Welling
On Sat, Sep 05, 2015 at 01:11:51PM -0700, Florian Fainelli wrote: > Le 09/05/15 12:47, Andrew Lunn a écrit : > > On Sat, Sep 05, 2015 at 02:44:01PM -0500, Michael Welling wrote: > >> On Sat, Sep 05, 2015 at 09:18:40PM +0200, Andrew Lunn wrote: > >>> On Sat, Se

Re: [PATCH] net: phy: Handle postive return codes in phy_connect

2015-09-05 Thread Michael Welling
On Sat, Sep 05, 2015 at 09:47:55PM +0200, Andrew Lunn wrote: > On Sat, Sep 05, 2015 at 02:44:01PM -0500, Michael Welling wrote: > > On Sat, Sep 05, 2015 at 09:18:40PM +0200, Andrew Lunn wrote: > > > On Sat, Sep 05, 2015 at 01:01:29PM -0500, Michael Welling wrote: &g

Re: [PATCH] net: phy: Handle postive return codes in phy_connect

2015-09-05 Thread Michael Welling
On Sat, Sep 05, 2015 at 09:18:40PM +0200, Andrew Lunn wrote: > On Sat, Sep 05, 2015 at 01:01:29PM -0500, Michael Welling wrote: > > The function phy_connect_direct can possibly return a positive > > return code. Using ERR_PTR with a positive value can lead to > > deferencing

[PATCH] net: phy: Handle postive return codes in phy_connect

2015-09-05 Thread Michael Welling
The function phy_connect_direct can possibly return a positive return code. Using ERR_PTR with a positive value can lead to deferencing of an invalid pointer. Signed-off-by: Michael Welling --- drivers/net/phy/phy_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy

Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()

2015-08-31 Thread Michael Welling
On Mon, Aug 31, 2015 at 09:53:55AM +0100, Mark Brown wrote: > On Sun, Aug 30, 2015 at 11:44:45AM -0500, Michael Welling wrote: > > > The patch is currently sitting in linux-next. > > > Not sure why it wasn't merged with 4.2.0-rc8. > > You didn't indicate t

Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()

2015-08-30 Thread Michael Welling
On Sun, Aug 30, 2015 at 05:45:21PM +0300, Jarkko Nikula wrote: > Hi > > On 07/24/2015 07:39 PM, Mark Brown wrote: > > On Wed, Jul 22, 2015 at 08:46:09PM +0200, Sebastian Reichel wrote: > >> Since commit ddcad7e9068eb omap2_mcspi_set_cs() is called without > >> runtime power management requested. T

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Michael Welling
On Fri, Aug 21, 2015 at 12:48:23AM +0200, Javier Martinez Canillas wrote: > Hello Michael, > > On 08/21/2015 12:29 AM, Michael Welling wrote: > > On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: > >> Hello Michael, > >> > >> On

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Michael Welling
On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: > Hello Michael, > > On 08/20/2015 10:09 PM, Michael Welling wrote: > > On Thu, Aug 20, 2015 at 09:07:26AM +0200, Javier Martinez Canillas wrote: > >> The driver has an OF id table but the .of_m

Re: [PATCH] input: ti_am335x_tsc: Add open delay parameter

2015-08-20 Thread Michael Welling
On Thu, Aug 20, 2015 at 05:41:30PM +0530, Vignesh R wrote: > > > On 08/19/2015 11:38 PM, Michael Welling wrote: > > On Wed, Aug 12, 2015 at 01:44:22PM -0500, Michael Welling wrote: > >> On Wed, Aug 12, 2015 at 11:56:36AM +0530, Vignesh R wrote: > >>&

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-20 Thread Michael Welling
On Thu, Aug 20, 2015 at 09:07:26AM +0200, Javier Martinez Canillas wrote: > The driver has an OF id table but the .of_match_table is not set so > the SPI core can't do an OF style match and the table was unused. > Is an OF style match necessary? I have been using devicetree and it matches based

Re: [PATCH] input: ti_am335x_tsc: Add open delay parameter

2015-08-19 Thread Michael Welling
On Wed, Aug 12, 2015 at 01:44:22PM -0500, Michael Welling wrote: > On Wed, Aug 12, 2015 at 11:56:36AM +0530, Vignesh R wrote: > > Hi Michael, > > > > + Dmitry > > > > On 08/12/2015 12:15 AM, Michael Welling wrote: > > > Adds a device tree paramete

Re: [PATCH] input: ti_am335x_tsc: Add open delay parameter

2015-08-12 Thread Michael Welling
On Wed, Aug 12, 2015 at 11:56:36AM +0530, Vignesh R wrote: > Hi Michael, > > + Dmitry > > On 08/12/2015 12:15 AM, Michael Welling wrote: > > Adds a device tree parameter to set the open delay on the touchscreen > > conversion steps. Increasing this parameter helps the

[PATCH] input: ti_am335x_tsc: Add open delay parameter

2015-08-11 Thread Michael Welling
Adds a device tree parameter to set the open delay on the touchscreen conversion steps. Increasing this parameter helps the touch accuracy on some screens. Signed-off-by: Michael Welling --- .../bindings/input/touchscreen/ti-tsc-adc.txt | 5 + drivers/input/touchscreen

Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()

2015-07-22 Thread Michael Welling
l; > > /* The controller handles the inverted chip selects > @@ -255,6 +256,12 @@ static void omap2_mcspi_set_cs(struct spi_device *spi, > bool enable) > enable = !enable; > > if (spi->controller_state) { > + i

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Michael Welling
On Wed, Jul 22, 2015 at 04:03:07AM +0200, Sebastian Reichel wrote: > Hi, > > On Tue, Jul 21, 2015 at 07:17:41PM -0500, Michael Welling wrote: > > On Tue, Jul 21, 2015 at 11:34:41AM +0200, Pavel Machek wrote: > > > > This code has my head spinning. > > > &g

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Michael Welling
On Tue, Jul 21, 2015 at 11:34:41AM +0200, Pavel Machek wrote: This code has my head spinning. I found that the errors do not occur when the driver is built into the kernel. I also found that with the patch below the errors go away. Not sure if it is acceptible but see if it fixes things on your

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Michael Welling
On Tue, Jul 21, 2015 at 11:34:41AM +0200, Pavel Machek wrote: > Actually.. for the record I'm _not_ using modules. So either I hit > something different, or problem happens regardless of modules. > Pavel I was able to reproduce

Re: linux 4.2-rc1 broken Nokia N900

2015-07-20 Thread Michael Welling
On Wed, Jul 15, 2015 at 09:49:33PM +0200, Pavel Machek wrote: > Hi! > > > > Ok, so: > > > > > > 4.2-rc1 worked for me, IIRC. > > > > This does not make sense. > > > > Nothing has changed in drivers/spi between these versions. > > Are you sure that 4.2-rc1 worked for you? > > Tested again: yes,

Re: linux 4.2-rc1 broken Nokia N900

2015-07-20 Thread Michael Welling
On Tue, Jul 14, 2015 at 09:14:12AM +0200, Pali Rohár wrote: > On Monday 13 July 2015 17:36:07 Michael Welling wrote: > > On Tue, Jul 14, 2015 at 12:02:44AM +0200, Pali Rohár wrote: > > > I think nothing special. I just call: > > > > > > export ARCH=arm > >

Re: [PATCH] iio: mcp320x: Fix NULL pointer dereference

2015-07-19 Thread Michael Welling
On Sun, Jul 19, 2015 at 02:00:24PM +0100, Jonathan Cameron wrote: > Applied to the fixes-togreg branch of iio.git > > Michael, there are moves afoot to clarify the meaning of reviewed-by > as covering only more substantial reviews (kind of tricky on a one liner > like this!) Hence for similar pat

Re: [PATCH] serial: 8250: Do XR17V35X specific wakeup in serial8250_do_startup

2015-07-16 Thread Michael Welling
terrupts after access > to all bits of this register has been enabled. > > This makes my 8-port XR17V35X working with the in-kernel > serial driver. > > Cc: Peter Hurley > Cc: Michael Welling > Cc: Joe Schultz > Signed-off-by: Joerg Roedel > --- > drivers/tty/

Re: linux 4.2-rc1 broken Nokia N900

2015-07-15 Thread Michael Welling
On Wed, Jul 15, 2015 at 09:49:33PM +0200, Pavel Machek wrote: > Hi! > > > > Ok, so: > > > > > > 4.2-rc1 worked for me, IIRC. > > > > This does not make sense. > > > > Nothing has changed in drivers/spi between these versions. > > Are you sure that 4.2-rc1 worked for you? > > Tested again: yes,

Re: linux 4.2-rc1 broken Nokia N900

2015-07-14 Thread Michael Welling
On Tue, Jul 14, 2015 at 10:01:26PM +0200, Pavel Machek wrote: > On Tue 2015-07-14 11:33:42, Michael Welling wrote: > > On Tue, Jul 14, 2015 at 09:14:12AM +0200, Pali Rohár wrote: > > > On Monday 13 July 2015 17:36:07 Michael Welling wrote: > > > > On Tue, Jul 14,

Re: linux 4.2-rc1 broken Nokia N900

2015-07-14 Thread Michael Welling
On Tue, Jul 14, 2015 at 09:14:12AM +0200, Pali Rohár wrote: > On Monday 13 July 2015 17:36:07 Michael Welling wrote: > > On Tue, Jul 14, 2015 at 12:02:44AM +0200, Pali Rohár wrote: > > > I think nothing special. I just call: > > > > > > export ARCH=arm > >

Re: linux 4.2-rc1 broken Nokia N900

2015-07-13 Thread Michael Welling
On Tue, Jul 14, 2015 at 12:02:44AM +0200, Pali Rohár wrote: > I think nothing special. I just call: > > export ARCH=arm > export CROSS_COMPILE=arm-linux-gnueabi- > make rx51_defconfig > rm -f arch/arm/boot/zImage > make -j12 zImage modules omap3-n900.dtb CONFIG_DEBUG_SECTION_MISMATCH=y > cat arch/

Re: linux 4.2-rc1 broken Nokia N900

2015-07-13 Thread Michael Welling
On Mon, Jul 13, 2015 at 10:34:21PM +0200, Pali Rohár wrote: > On Monday 13 July 2015 22:28:35 Michael Welling wrote: > > On Mon, Jul 13, 2015 at 07:09:06PM +0200, Pali Rohár wrote: > > > Hello, here is my objdump of 4.2-rc2 version: > > > > > > 0

Re: linux 4.2-rc1 broken Nokia N900

2015-07-13 Thread Michael Welling
On Mon, Jul 13, 2015 at 07:09:06PM +0200, Pali Rohár wrote: > Hello, here is my objdump of 4.2-rc2 version: > > 0064 : > 64: e3003182movwr3, #386; 0x182 > 68: e19030b3ldrhr3, [r0, r3] > 6c: e3130004tst r3, #4 >

Re: linux 4.2-rc1 broken Nokia N900

2015-07-13 Thread Michael Welling
On Mon, Jul 13, 2015 at 07:09:06PM +0200, Pali Rohár wrote: > On Monday 13 July 2015 19:03:44 Michael Welling wrote: > > On Mon, Jul 13, 2015 at 10:09:21AM +0200, Sebastian Reichel wrote: > > > [+cc Michael Welling , author of all omap-spi > > > patches between 4.1 a

Re: linux 4.2-rc1 broken Nokia N900

2015-07-13 Thread Michael Welling
On Mon, Jul 13, 2015 at 10:09:21AM +0200, Sebastian Reichel wrote: > [+cc Michael Welling , author of all omap-spi patches > between 4.1 and 4.2-rc1] > > Hi, > > On Sun, Jul 12, 2015 at 11:44:25PM -0700, Tony Lindgren wrote: > > * Pali Rohár [150711 05:07]: > &g

Re: [PATCH] iio: mcp320x: Fix NULL pointer dereference

2015-07-13 Thread Michael Welling
rs/iio/adc/mcp320x.c > +++ b/drivers/iio/adc/mcp320x.c > @@ -299,6 +299,8 @@ static int mcp320x_probe(struct spi_device *spi) > indio_dev->channels = chip_info->channels; > indio_dev->num_channels = chip_info->num_channels; > > + adc->chip_info

AT91 timer/counter as clock output from devicetree

2015-06-25 Thread Michael Welling
I have run into situation with AT91 based products where I am at a loss as to how to properly approproach implementing a driver/solution. Several boards that I have dealt with are using the AT91's timer/counter pins to emulate a simple clock output. Currently, the only way I have found to emulate

Re: [PATCH] serial: 8250: Do XR17V35X specific wakeup in serial8250_do_startup

2015-06-19 Thread Michael Welling
the EFR_ECB bit needs to be set in the > chip-specific UART_XR_EFR register, so that writing to a > couple of other configuration bits is enabled. > > Cc: Peter Hurley > Cc: Michael Welling > Cc: Joe Schultz > Signed-off-by: Joerg Roedel > --- > drivers/tty/ser

Re: [PATCH 4/4] spi: omap2-mcspi: Handle error on gpio_request

2015-05-24 Thread Michael Welling
On Sun, May 24, 2015 at 10:13:07AM +0200, Nicholas Mc Guire wrote: > On Sat, 23 May 2015, Michael Welling wrote: > > > If a valid GPIO is specified but cannot be requested by the driver, print a > > message and error out of omap2_mcspi_setup. > > > >

  1   2   >