Re: [PATCH] watchdog: intel_scu_watchdog: fix spelling mistake: "set_hearbeat" -> "set_heartbeat"

2019-04-16 Thread Mukesh Ojha
On 4/16/2019 7:03 PM, Colin King wrote: From: Colin Ian King There is a spelling mistake in a pr_debug message. Fix it. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/watchdog/intel_scu_watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] clk: mvebu: fix spelling mistake "gatable" -> "gateable"

2019-04-16 Thread Mukesh Ojha
On 4/16/2019 5:26 PM, Colin King wrote: From: Colin Ian King There are a few spelling mistakes in comments and a pr_err error message. Fix these. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/clk/mvebu/common.c | 2 +- drivers

Re: [PATCH] reiserfs: fix spelling mistake "enrty" -> "entry"

2019-04-16 Thread Mukesh Ojha
On 4/16/2019 4:55 PM, Colin King wrote: From: Colin Ian King There are a couple of spelling mistakes, fix these. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- fs/reiserfs/lbalance.c | 2 +- fs/reiserfs/namei.c| 2 +- 2 files changed, 2 insertions

Re: [PATCH] scripts/dtc: fix spelling mistake "endpont" -> "endpoint"

2019-04-16 Thread Mukesh Ojha
On 4/16/2019 4:42 PM, Colin King wrote: From: Colin Ian King There is a spelling mistake in a FAIL message, fix it. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- scripts/dtc/checks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH] staging: comedi: adv_pci1710: fix spelling mistake: "droput" -> "dropout"

2019-04-16 Thread Mukesh Ojha
On 4/15/2019 11:19 PM, Colin King wrote: From: Colin Ian King There is a spelling mistake in a dev_error message. Fix it. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/staging/comedi/drivers/adv_pci1710.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH] iwlegacy: fix spelling mistake "acumulative" -> "accumulative"

2019-04-15 Thread Mukesh Ojha
On 4/15/2019 4:07 PM, Colin King wrote: From: Colin Ian King Fix spelling mistakes in rx stats text. I missed these from an earlier round of fixing the same spelling mistake. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/net/wireless/intel

Re: [PATCH v2] Input: uinput: Avoid Object-Already-Free with a global lock

2019-04-15 Thread Mukesh Ojha
Hi Dmitry, Can you please have a look at this patch ? as this seems to reproducing quite frequently Thanks, Mukesh On 4/10/2019 1:29 PM, Mukesh Ojha wrote: uinput_destroy_device() gets called from two places. In one place, uinput_ioctl_handler() where it is protected under a lock udev

[PATCH v2] Input: uinput: Avoid Object-Already-Free with a global lock

2019-04-10 Thread Mukesh Ojha
780 [ 160.380971] CPU: 4 PID: 7098 Comm: syz-executor Tainted: G S B W O 4.14.98+ #1 So, avoid the race by taking a global lock inside uinput_release(). Signed-off-by: Mukesh Ojha Cc: Gaurav Kohli Cc: Peter Hutterer Cc: Martin Kepplinger Cc: "Paul E. McKenney" --- Also,

Re: [PATCH] alarmtimer: return correct remaining time

2019-04-07 Thread Mukesh Ojha
= &timr->it.alarm.alarmtimer; - return ktime_sub(now, alarm->node.expires); + return ktime_sub(alarm->node.expires, now); Looks good to me. Reviewed-by: Mukesh Ojha Cheers, -Mukesh } /**

Re: [PATCH -next] acpi/hmat: fix an uninitialized memory_target

2019-04-06 Thread Mukesh Ojha
t/hmat.c:369:30: note: initialize the variable 'target' to silence this warning struct memory_target *target; ^ = NULL Signed-off-by: Qian Cai Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- driv

Re: [PATCH] KVM: x86: fix warning Using plain integer as NULL pointer

2019-04-06 Thread Mukesh Ojha
On 4/6/2019 3:06 PM, Hariprasad Kelam wrote: Changed passing argument as "0 to NULL" which resolves below sparse warning arch/x86/kvm/x86.c:3096:61: warning: Using plain integer as NULL pointer Signed-off-by: Hariprasad Kelam Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- ar

Re: [PATCH] kernel: pid_namespace : fix warning Using plain integer as NULL pointer

2019-04-06 Thread Mukesh Ojha
quot; Signed-off-by: Hariprasad Kelam Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- kernel/pid_namespace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c index aa6e72f..6e4afdc 100644 --- a/kernel/pid_namespace.c +++ b/ke

Re: [PATCH] spi: bcm2835aux: Fix build error without CONFIG_DEBUG_FS

2019-04-06 Thread Mukesh Ojha
gfs") Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/spi/spi-bcm2835aux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-bcm2835aux.c b/drivers/spi/spi-bcm2835aux.c index fd8252d..bbf87ad 100644 --- a/drivers/spi/spi-b

Re: [PATCH] perf: Remove duplicate headers

2019-04-06 Thread Mukesh Ojha
On 4/6/2019 7:06 PM, Souptick Joarder wrote: Removed duplicate headers which are included twice. Signed-off-by: Souptick Joarder Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- tools/perf/util/data.c | 1 - tools/perf/util/get_current_dir_name.c | 1 - tools/perf/util

Re: [PATCH] watchdog: machzwd : fix warning Using plain integer as NULL pointer

2019-04-06 Thread Mukesh Ojha
On 4/6/2019 6:44 PM, Hariprasad Kelam wrote: Changes passing function argument 0 to NULL to avoid below sparse warning CHECK drivers/watchdog//machzwd.c drivers/watchdog//machzwd.c:321:25: warning: Using plain integer as NULL pointer Signed-off-by: Hariprasad Kelam Reviewed-by: Mukesh

Re: [PATCH v2] arm: mm: Remove duplicate header

2019-04-06 Thread Mukesh Ojha
Reviewed-by: Mukesh Ojha Cheers, -Mukesh index f3ce341..a64a3c5 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include #include

Re: [PATCH V2] staging: comedi: dt2811: Fix spelling mistake

2019-04-06 Thread Mukesh Ojha
On 4/6/2019 1:53 PM, Hariprasad Kelam wrote: changes interupts --> interrupts to fix warning reported by checkpatch tool Signed-off-by: Hariprasad Kelam Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- Changes in v2: - Make the Subject more clear by including changed file p

Re: [PATCH -next] staging: rtlwifi: base: Remove set but not used variables

2019-04-06 Thread Mukesh Ojha
et but not used [-Wunused-but-set-variable] drivers/staging/rtlwifi/base.c:2470:5: warning: variable 'ht_cap_len' set but not used [-Wunused-but-set-variable] They are never used and can be removed. Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- driv

Re: [PATCH -next] staging: rtl8192e: Remove set but not used variable 'VenderID'

2019-04-06 Thread Mukesh Ojha
sed [-Wunused-but-set-variable] u16 VenderID; ^ It's never used and can be removed. Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl

Re: [PATCH -next] staging: comedi: dyna_pci10xx: remove set but not used variables 'chan' and range'

2019-04-06 Thread Mukesh Ojha
quot;Staging: comedi: add dyna_pci10xx driver") Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/staging/comedi/drivers/dyna_pci10xx.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c b/drivers/stagin

Re: [PATCH -next] staging: rtlwifi: rtl8822be: Remove set but not used variable 'curtxbw_40mhz'

2019-04-06 Thread Mukesh Ojha
but not used [-Wunused-but-set-variable] It's never used and can be removed. Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/staging/rtlwifi/rtl8822be/hw.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtlwif

Re: [PATCH][next] acpi/hmat: fix uninitialized pointer dereference on pointer 'target'

2019-04-05 Thread Mukesh Ojha
eference when assigning target->processor_pxm when target contains a non-null garbage value. Fix this by initializing targer to null. Fixes: 665ac7e92757 ("acpi/hmat: Register processor domain to its memory") Addresses-Coverity: ("Uninitialized pointer read") Signed-off-by: Colin

Re: [PATCH v0] kernfs: Skip kernfs_put of parent from child node

2019-04-05 Thread Mukesh Ojha
ild simply has to decrement count of parent kernfs node and keep continue the free path for itself. Signed-off-by: Gaurav Kohli Signed-off-by: Mukesh Ojha diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c index b84d635..d5a36e8 100644 --- a/fs/kernfs/dir.c +++ b/fs/kernfs/dir.c @@ -515,7 +515,6 @@ v

Re: [PATCH] remoteproc: silence an uninitialized variable warning

2019-04-05 Thread Mukesh Ojha
On 4/4/2019 3:06 PM, Dan Carpenter wrote: On Thu, Apr 04, 2019 at 02:47:39PM +0530, Mukesh Ojha wrote: On 4/4/2019 2:12 PM, Dan Carpenter wrote: Smatch complains that "ret" might be uninitialized. I can see why it generates the warning, but I don't know if it's actua

Re: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry

2019-04-04 Thread Mukesh Ojha
y: YueHaibing This looks good too. Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- v2: rework patch --- drivers/extcon/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig index 1ed4b45..de06faf 100644 --- a/drivers/e

Re: [PATCH] extcon: axp288: Fix build err without CONFIG_ACPI

2019-04-04 Thread Mukesh Ojha
&adev->dev); Reported-by: Hulk Robot Fixes: 0cf064db948a ("extcon: axp288: Convert to use acpi_dev_get_first_match_dev()") Signed-off-by: YueHaibing Looks fine to me. Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/extcon/extcon-axp288.c | 8 +--- 1 file

Re: [PATCH] gpio: merrifield: Fix build err without CONFIG_ACPI

2019-04-04 Thread Mukesh Ojha
acpi_device put_device(&adev->dev); ^ Reported-by: Hulk Robot Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()") Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/gpio/gpio-merrifield.c | 9 +

Re: [PATCH][next] opa_vnic: fix check on record->event, incorrect operator used

2019-04-04 Thread Mukesh Ojha
idr to XArray") Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c b/drivers/infiniband/ulp

Re: [PATCH][V2] Documentation: bus: ti-sysc: fix spelling mistakes "multipe" and "interconnet"

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 4:46 PM, Colin King wrote: From: Colin Ian King There is are a couple of spelling mistakes in the Documentation. Fix them. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- V2: Add fix to interconnect, thanks to Mukesh Ojha for spotting that

Re: [PATCH] staging: rtl8192u: remove redundant null check on array 'data'

2019-04-04 Thread Mukesh Ojha
gned-off-by: Colin Ian King fix the commit text minor err Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

Re: [PATCH] staging: comedi: Fix spelling mistake

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 6:54 AM, Hariprasad Kelam wrote: changes interupts --> interrupts to fix warning reported by checkpatch tool Signed-off-by: Hariprasad Kelam Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/staging/comedi/drivers/dt2811.c | 2 +- 1 file changed, 1 insertion(+)

Re: [PATCH] soundwire: cdns: Fix compilation error on arm64

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 1:42 PM, Jan Kotas wrote: On arm64 the cadence_master.c file doesn't compile. readl and writel are undefined. This patch fixes that by including io.h. Signed-off-by: Jan Kotas Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/soundwire/cadence_master.c | 1 + 1

Re: [PATCH][next] HID: intel-ish-hid: fix spelling mistake "multipe" -> "multiple"

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 1:28 PM, Colin King wrote: From: Colin Ian King There is a spelling mistake in a dev_err message, fix it. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] remoteproc: silence an uninitialized variable warning

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 2:12 PM, Dan Carpenter wrote: Smatch complains that "ret" might be uninitialized. I can see why it generates the warning, but I don't know if it's actually possible. Anyway initializing "ret" here is harmless. Signed-off-by: Dan Carpenter --- drivers/soc/qcom/mdt_loader.c | 2 +

Re: [PATCH] Documentation: bus: ti-sysc: fix spelling mistake "multipe" -> "multiple"

2019-04-04 Thread Mukesh Ojha
single CPPI41 DMA instance as children of a single interconnet target module. s/interconnet/interconnect fix this as well. Reviewed-by: Mukesh Ojha Cheers, -Mukesh

Re: [PATCH] perf script: fix spelling mistake "multipe" -> "multiple"

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 1:53 PM, Colin King wrote: From: Colin Ian King There is a spelling mistake in the Documentation. Fix it. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- tools/perf/Documentation/perf-script.txt | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 2/2] tty: fix up a few remaining files without SPDX identifiers

2019-04-04 Thread Mukesh Ojha
. All rights reserved. diff --git a/drivers/tty/vt/.gitignore b/drivers/tty/vt/.gitignore index 83683a2d8e6a..9b38b85f9d9a 100644 --- a/drivers/tty/vt/.gitignore +++ b/drivers/tty/vt/.gitignore .gitignore ? Reviewed-by: Mukesh Ojha Cheers, -Mukesh @@ -1,2 +1,3 @@ +# SPDX-License-Identi

Re: [PATCH][next] ASoC: sprd: Fix spelling mistake "faied" -> "failed"

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 1:26 PM, Colin King wrote: From: Colin Ian King There are two identical spelling mistakes in dev_err messages. Fix them. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- sound/soc/sprd/sprd-pcm-compress.c | 4 ++-- 1 file changed, 2 insertions

Re: [PATCH] genirq: Fix uninitialized request_mutex

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 1:15 PM, Kefeng Wang wrote: When !CONFIG_SPARSE_IRQ, request_mutex of struct irq_desc won't be initialiezed, it leads to system hung, fix it. Fixes: 9114014cf4e6 ("genirq: Add mutex to irq desc to serialize request/free_irq()") Signed-off-by: Kefeng Wang Revi

Re: [PATCH net] trival: net: skbuff: fix comment in skbuff.h

2019-04-04 Thread Mukesh Ojha
On 4/3/2019 2:45 PM, linmiaohe wrote: From: Miaohe Lin It should be IPv6|UDP instead of IPv4|UDP for NETIF_F_IPV6_CSUM Signed-off-by: linmiaohe Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- include/linux/skbuff.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH] mm: __pagevec_lru_add_fn: typo fix

2019-04-04 Thread Mukesh Ojha
On 4/2/2019 3:13 PM, Peng Fan wrote: There is no function named munlock_vma_pages, correct it to munlock_vma_page. Signed-off-by: Peng Fan Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- mm/swap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/swap.c b/mm/swap.c

[PATCH 4/7] irqchip/irq-mbigen.c: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
devm_platform_ioremap_resource() internally have platform_get_resource() and devm_ioremap_resource() in it. So instead of calling them separately use devm_platform_ioremap_resource() directly. Signed-off-by: Mukesh Ojha --- drivers/irqchip/irq-ls-scfg-msi.c | 4 +--- drivers/irqchip/irq

[PATCH 3/7] irqchip/irq-ts4800.c: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
devm_platform_ioremap_resource() internally have platform_get_resource() and devm_ioremap_resource() in it. So instead of calling them separately use devm_platform_ioremap_resource() directly. Signed-off-by: Mukesh Ojha --- drivers/irqchip/irq-ts4800.c | 4 +--- 1 file changed, 1 insertion

[PATCH 5/7] irqchip/irq-mvebu-icu: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
devm_platform_ioremap_resource() internally have platform_get_resource() and devm_ioremap_resource() in it. So instead of calling them separately use devm_platform_ioremap_resource() directly. Signed-off-by: Mukesh Ojha --- drivers/irqchip/irq-mvebu-icu.c | 4 +--- 1 file changed, 1 insertion

[PATCH 7/7] irqchip/irq-mvebu-sei: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
devm_platform_ioremap_resource() internally have platform_get_resource() and devm_ioremap_resource() in it. So instead of calling them separately use devm_platform_ioremap_resource() directly. Signed-off-by: Mukesh Ojha --- drivers/irqchip/irq-mvebu-sei.c | 3 +-- 1 file changed, 1 insertion

[PATCH 6/7] irqchip/irq-mvebu-pic: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
devm_platform_ioremap_resource() internally have platform_get_resource() and devm_ioremap_resource() in it. So instead of calling them separately use devm_platform_ioremap_resource() directly. Signed-off-by: Mukesh Ojha --- drivers/irqchip/irq-mvebu-pic.c | 4 +--- 1 file changed, 1 insertion

[PATCH 2/7] irqchip/irq-imgpdc.c: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
devm_platform_ioremap_resource() internally have platform_get_resource() and devm_ioremap_resource() in it. So instead of calling them separately use devm_platform_ioremap_resource() directly. Signed-off-by: Mukesh Ojha --- drivers/irqchip/irq-imgpdc.c | 10 +- 1 file changed, 1

[PATCH 1/7] irqchip/irq-uniphier-aidet: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
devm_platform_ioremap_resource() internally have platform_get_resource() and devm_ioremap_resource() in it. So instead of calling them separately use devm_platform_ioremap_resource() directly. Signed-off-by: Mukesh Ojha --- drivers/irqchip/irq-uniphier-aidet.c | 4 +--- 1 file changed, 1

[PATCH 0/7] irqchip: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
single call. Mukesh Ojha (7): irqchip/irq-uniphier-aidet: Use devm_platform_ioremap_resource() irqchip/irq-imgpdc.c: Use devm_platform_ioremap_resource() irqchip/irq-ts4800.c: Use devm_platform_ioremap_resource() irqchip/irq-mbigen.c: Use devm_platform_ioremap_resource() irqchip/irq-mvebu

[PATCH 3/5] Input: s3c2410_ts: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
devm_platform_ioremap_resource() internally have platform_get_resource() and devm_ioremap_resource() in it. So instead of calling them separately use devm_platform_ioremap_resource() directly. Signed-off-by: Mukesh Ojha --- drivers/input/touchscreen/s3c2410_ts.c | 10 +- 1 file changed

[PATCH 2/5] Input: mxs-lradc-ts.c: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
devm_platform_ioremap_resource() internally have platform_get_resource() and devm_ioremap_resource() in it. So instead of calling them separately use devm_platform_ioremap_resource() directly. Signed-off-by: Mukesh Ojha --- drivers/input/touchscreen/mxs-lradc-ts.c | 6 +- 1 file changed, 1

[PATCH 5/5] Input: ts4800-ts: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
devm_platform_ioremap_resource() internally have platform_get_resource() and devm_ioremap_resource() in it. So instead of calling them separately use devm_platform_ioremap_resource() directly. Signed-off-by: Mukesh Ojha --- drivers/input/touchscreen/ts4800-ts.c | 4 +--- 1 file changed, 1

[PATCH 4/5] Input: sun4i-ts: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
devm_platform_ioremap_resource() internally have platform_get_resource() and devm_ioremap_resource() in it. So instead of calling them separately use devm_platform_ioremap_resource() directly. Signed-off-by: Mukesh Ojha --- drivers/input/touchscreen/sun4i-ts.c | 3 +-- 1 file changed, 1

[PATCH 1/5] Input: fsl-imx25-tcq: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
devm_platform_ioremap_resource() internally have platform_get_resource() and devm_ioremap_resource() in it. So instead of calling them separately use devm_platform_ioremap_resource() directly. Signed-off-by: Mukesh Ojha --- drivers/input/touchscreen/fsl-imx25-tcq.c | 4 +--- 1 file changed, 1

[PATCH 0/5] Input: Use devm_platform_ioremap_resource()

2019-04-04 Thread Mukesh Ojha
single call. Mukesh Ojha (5): Input: fsl-imx25-tcq: Use devm_platform_ioremap_resource() Input: mxs-lradc-ts.c: Use devm_platform_ioremap_resource() Input: s3c2410_ts: Use devm_platform_ioremap_resource() Input: sun4i-ts: Use devm_platform_ioremap_resource() Input: ts4800-ts: Use

Re: [PATCH 1/2] tty: add SPDX identifiers to Kconfig and Makefiles

2019-04-04 Thread Mukesh Ojha
Signed-off-by: Greg Kroah-Hartman Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/tty/Kconfig | 1 + drivers/tty/hvc/Kconfig | 1 + drivers/tty/ipwireless/Makefile | 1 + drivers/tty/serdev/Kconfig | 1 + drivers/tty/serdev/Makefile

Re: [PATCH] rtc: remove unnecessary Kconfig dependencies

2019-04-02 Thread Mukesh Ojha
On 4/3/2019 3:24 AM, Alexandre Belloni wrote: Remove the unused "depends on I2C" as the config options are already guarded by if I2C. Signed-off-by: Alexandre Belloni Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/rtc/Kconfig | 2 -- 1 file changed, 2 deletions(-) di

Re: [PATCH v2 1/3] habanalabs: remove extra semicolon

2019-04-02 Thread Mukesh Ojha
On 4/2/2019 10:37 PM, Oded Gabbay wrote: This patch removes an extra ; after the closing brackets of a while loop. Signed-off-by: Oded Gabbay Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/misc/habanalabs/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: b050de0f98 ("fs/binfmt_elf.c: free PT_INTERP filename ASAP"): BUG: KASAN: null-ptr-deref in allow_write_access

2019-04-02 Thread Mukesh Ojha
I think, this may fix the problem. https://patchwork.kernel.org/patch/10878501/ Thanks, Mukesh On 4/2/2019 8:24 PM, kernel test robot wrote: Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g

Re: [PATCH 02/16] staging: add missing SPDX lines to Makefile files

2019-04-02 Thread Mukesh Ojha
: Mukesh Ojha Cheers, -Mukesh --- drivers/staging/android/Makefile | 1 + drivers/staging/axis-fifo/Makefile | 1 + drivers/staging/board/Makefile | 1 + drivers/staging/clocking-wizard/Makefile | 1

Re: [PATCH] fs: kernfs: Corrected spelling mistake

2019-04-02 Thread Mukesh Ojha
flies => files On 4/2/2019 5:14 PM, Christina Quast wrote: Signed-off-by: Christina Quast Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- include/linux/kernfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h in

Re: [PATCH -next] Input: uinput - Avoid Use-After-Free with udev lock

2019-04-01 Thread Mukesh Ojha
Please don't consider this patch, i will send v2 of this. Thanks, Mukesh On 3/28/2019 3:36 PM, Mukesh Ojha wrote: uinput_destroy_device() gets called from two places. In one place, uinput_ioctl_handler() it is protected under a lock udev->mutex but same is not true for other plac

Re: [PATCH RESEND -next] Input: uinput - Avoid Use-After-Free with udev lock

2019-04-01 Thread Mukesh Ojha
Please don't consider this patch, i will send v2 of this. Thanks, Mukesh On 3/28/2019 3:55 PM, Mukesh Ojha wrote: uinput_destroy_device() gets called from two places. In one place, uinput_ioctl_handler() it is protected under a lock udev->mutex but same is not true for other plac

Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:43 PM, Greg KH wrote: On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote: On 4/1/2019 8:07 PM, Marcelo Schmitt wrote: Add SPDX identifier of GPL-2.0 for the ad9832 driver. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/frequency/ad9832.c | 3 +-- 1 file

Re: [PATCH] MAINTAINERS: Fix Hyperv vIOMMU driver file name

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 7:50 PM, Sasha Levin wrote: On Tue, Mar 26, 2019 at 02:57:09PM +0530, Mukesh Ojha wrote: On 3/26/2019 11:58 AM, lantianyu1...@gmail.com wrote: From: Lan Tianyu The Hyperv vIOMMU file name should be "hyperv-iommu.c" rather s/vIOMMU/IOMMU What's wrong with vIO

Re: [PATCH 04/12] phy: tegra: add missing of_node_put after of_device_is_available

2019-04-01 Thread Mukesh Ojha
) when != x = e when != e = x when any if (<+...of_device_is_available(e)...+>) { ... when != of_node_put(e) ( return e; | + of_node_put(e); return ...; ) } // Fixes: 53d2a715c2403 ("phy: Add Tegra XUSB pad controller support") Signed-off-by: Julia Lawall Rev

Re: [PATCH 01/12] arm-cci: add missing of_node_put after of_device_is_available

2019-04-01 Thread Mukesh Ojha
Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- This file doesn't seem to have a maintainer. drivers/bus/arm-cci.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -u -p a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c --- a/drivers/bus/arm-cci.c +++ b/drivers/bu

Re: [PATCH 12/12] drivers: firmware: psci: add missing of_node_put after of_device_is_available

2019-04-01 Thread Mukesh Ojha
On 2/23/2019 6:50 PM, Julia Lawall wrote: Add an of_node_put when a tested device node is not available. The semantic patch that fixes this problem is as follows (http://Reviewed-by: Mukesh Ojha Cheers, -Mukesh.lip6.fr): // @@ identifier f; local idexpression e; expression x; @@ e = f

Re: [PATCH] serial: sh-sci: Fix HSCIF RX sampling point calculation

2019-04-01 Thread Mukesh Ojha
DIV_ROUND_CLOSEST(). Fixes: 63ba1e00f178a448 ("serial: sh-sci: Support for HSCIF RX sampling point adjustment") Signed-off-by: Geert Uytterhoeven Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- Anyone with a good test setup for verifying this feature actually works as advertised? --- drivers/

Re: [PATCH] fs/open: Fix most outstanding security bugs

2019-04-01 Thread Mukesh Ojha
e mentioned processes tries opening a file, return -EPERM indicating this process does not have the permission to open files on Linux anymore. Signed-off-by: Johannes Thumshirn Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- fs/open.c | 14 ++ 1 file changed, 14 insertions(+)

Re: [PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 4:18 PM, Feng Tang wrote: Current console_flush_on_panic() will only dump the new messages in buffer, and users may need an opportunity to check all the messages on panic which could help debugging, as user may haven't seen the log before panic due to loglevel settings. Add a flag

Re: [PATCH] drivers: fix a typo in the kernel doc for devm_platform_ioremap_resource()

2019-04-01 Thread Mukesh Ojha
device * * @pdev: platform device to use both for memory resource lookup as well as - *resource managemend + *resource management :-) Reviewed-by: Mukesh Ojha Cheers, -Mukesh * @index: resource index */ #ifdef CONFIG_HAS_IOMEM

Re: [PATCH v3] arm/mach-at91/pm : fix possible object reference leak

2019-04-01 Thread Mukesh Ojha
curam"); if (!np) - goto securam_fail; + goto securam_fail_no_get; s/securam_fail_no_get/securam_fail_no_ref_dev otherwise looks good. Reviewed-by: Mukesh Ojha Cheers, -Mukesh pdev = of_find_device_by_node(np); of_node_put(np);

Re: [PATCH] iio: adc: ads124: avoid buffer overflow

2019-04-01 Thread Mukesh Ojha
ehlé Cc: Dan Murphy Cc: Jonathan Cameron Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/iio/adc/ti-ads124s08.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ti-ads124s08.c b/drivers/iio/adc/ti-ads124s08.c index 53f17e4f2f230..552c2be8d87ad 100644

Re: [PATCH] dccp: Fix memleak in __feat_register_sp

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 7:05 AM, Yue Haibing wrote: From: YueHaibing If dccp_feat_push_change fails, we forget free the mem which is alloced by kmemdup in dccp_feat_clone_sp_val. Reported-by: Hulk Robot Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values") Reviewed-

Re: [PATCH v3] arch_topology: Make cpu_capacity sysfs node as ready-only

2019-04-01 Thread Mukesh Ojha
s/ready/read On 4/1/2019 9:54 AM, Lingutla Chandrasekhar wrote: If user updates any cpu's cpu_capacity, then the new value is going to be applied to all its online sibling cpus. But this need not to be correct always, as sibling cpus (in ARM, same micro architecture cpus) would have different cp

Re: [PATCH 3/3] nvmem: imx-iim: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:29 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/nvmem/imx

Re: [PATCH 2/3] nvmem: mxs-ocotp: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:29 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/nvmem/mxs

Re: [PATCH 1/3] nvmem: imx-ocotp: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:29 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/nvmem/imx

Re: [PATCH] watchdog: imx2_wdt: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:34 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/watchdog

Re: [PATCH] pinctrl: freescale: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:37 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/pinctrl

Re: [PATCH] gpio: mxc: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:39 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/gpio/gpio

Re: [PATCH] clk: imx: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:43 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/clk/imx/clk

Re: [PATCH] mailbox: imx: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:45 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/mailbox/imx

Re: [PATCH] input: imx6ul_tsc: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:49 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/input

Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:54 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/pwm/pwm

Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:54 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/pwm/pwm

Re: [PATCH] input: keyboard: imx: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:58 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/input

Re: [PATCH] rtc: snvs: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
se old dts file, please update it\n"); - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); Remove this blank line. Reviewed-by: Mukesh Ojha Cheers, -Mukesh - mmio = devm_ioremap_resource(&pdev->dev, res); + mmio = devm_platfo

Re: [PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style error.

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 4:23 AM, Will Cunningham wrote: Removed unnecessary parentheses.` Remove the extra character at the end. Fix the above thing then you can take. Reviewed-by: Mukesh Ojha Cheers, -Mukesh Signed-off-by: Will Cunningham --- drivers/staging/comedi/drivers/pcl818.c | 8

Re: [PATCH 2/2] soc: imx: gpcv2: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 11:37 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/soc/imx/gpcv2

Re: [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 11:37 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/soc/imx/gpc.c

Re: [PATCH] irqchip/imx-irqsteer: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 11:51 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/irqchip/irq

Re: [PATCH] pwm: imx27: use devm_platform_ioremap_resource() to simplify code

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 10:54 AM, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/pwm/pwm-imx27

Re: [PATCH V2] arm/mach-at91/pm : fix possible object reference leak

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 4:50 PM, Peng Hao wrote: of_find_device_by_node() takes a reference to the struct device when it finds a match via get_device. When returning error we should call put_device. Signed-off-by: Peng Hao --- arch/arm/mach-at91/pm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deleti

Re: [PATCH 3/7] rtc: xgene: convert to SPDX identifier

2019-03-31 Thread Mukesh Ojha
mine., Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- drivers/rtc/rtc-xgene.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-xgene.c b/drivers/rtc/rtc-xgene.c index e360f8917556..ba9121d02f02 100644 --- a/drivers/rtc/rtc-xgene.c +++ b/drivers

Re: [PATCH 2/4] rtc: ps3: convert to SPDX identifier

2019-03-31 Thread Mukesh Ojha
On 3/20/2019 6:14 PM, Alexandre Belloni wrote: Use SPDX-License-Identifier instead of a verbose license text. The original text refers to version 2 so also update MODULE_LICENSE() to "GPL v2" instead of "GPL". Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ps3.c | 16 ++--

Re: [PATCH 2/7] irqchip/alpine-msi: Update driver license to use SPDX

2019-03-31 Thread Mukesh Ojha
On 3/31/2019 6:04 PM, Hanna Hawa wrote: Update driver license to be in-line with Linux conventions. Signed-off-by: Hanna Hawa --- drivers/irqchip/irq-alpine-msi.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/i

Re: [PATCH v2] ARCH: Use the correct style for SPDX License Identifier

2019-03-31 Thread Mukesh Ojha
On 3/31/2019 3:51 AM, Nishad Kamdar wrote: This patch corrects the SPDX License Identifier style in the Hardware Architecture subsystem. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used) Changes made b

Re: [PATCH v2] drivers/staging: Fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h

2019-03-31 Thread Mukesh Ojha
On 3/31/2019 5:49 PM, Mukesh Ojha wrote: On 3/31/2019 2:44 PM, Ojaswin Mujoo wrote: Fix checkpatch.pl styling error related to SPDX-License-Identifier comment in vt6656/*.h * v2: fix patch styling Above line should be after ---. Signed-off-by: Ojaswin Mujoo Although, it looks ok to me

<    1   2   3   4   >