On 16 January 2025 17:12:27 CET, Manivannan Sadhasivam
wrote:
>On Thu, Jan 16, 2025 at 04:36:07PM +0100, Niklas Cassel wrote:
>> On Thu, Jan 16, 2025 at 07:21:02PM +0530, Manivannan Sadhasivam wrote:
>> > Hi,
>> >
>> > This series carries forward the effo
t->msixnum > 2048)
> - goto usage;
> - continue;
> - case 'i':
> - test->irqtype = atoi(optarg);
> - if (test->irqtype < 0 || test->irqtype > 2)
> - goto usage;
> - test->set_irqtype = true;
> - continue;
> - case 'I':
> - test->get_irqtype = true;
> - continue;
> - case 'r':
> - test->read = true;
> - continue;
> - case 'w':
> - test->write = true;
> - continue;
> - case 'c':
> - test->copy = true;
> - continue;
> - case 'e':
> - test->clear_irq = true;
> - continue;
> - case 's':
> - test->size = strtoul(optarg, NULL, 0);
> - continue;
> - case 'd':
> - test->use_dma = true;
> - continue;
> - case 'h':
> - default:
> -usage:
> - fprintf(stderr,
> - "usage: %s [options]\n"
> - "Options:\n"
> - "\t-D PCI endpoint test device
> {default: /dev/pci-endpoint-test.0}\n"
> - "\t-b BAR test (bar number between
> 0..5)\n"
> - "\t-C Consecutive BAR test\n"
> - "\t-m MSI test (msi number between
> 1..32)\n"
> - "\t-x \tMSI-X test (msix number
> between 1..2048)\n"
> - "\t-i \tSet IRQ type (0 - Legacy, 1 -
> MSI, 2 - MSI-X)\n"
> - "\t-e Clear IRQ\n"
> - "\t-I Get current IRQ type
> configured\n"
> - "\t-d Use DMA\n"
> - "\t-l Legacy IRQ test\n"
> - "\t-r Read buffer test\n"
> - "\t-w Write buffer test\n"
> - "\t-c Copy buffer test\n"
> - "\t-s Size of buffer {default:
> 100KB}\n"
> - "\t-h Print this help message\n",
> - argv[0]);
> - return -EINVAL;
> - }
> -
> - return run_test(test);
> -}
> diff --git a/tools/testing/selftests/pci_endpoint/pcitest.sh
> b/tools/testing/selftests/pci_endpoint/pcitest.sh
> deleted file mode 100644
> index 770f4d6df34b..
> --- a/tools/testing/selftests/pci_endpoint/pcitest.sh
> +++ /dev/null
> @@ -1,73 +0,0 @@
> -#!/bin/sh
> -# SPDX-License-Identifier: GPL-2.0
> -
> -echo "BAR tests"
> -echo
> -
> -bar=0
> -
> -while [ $bar -lt 6 ]
> -do
> - pcitest -b $bar
> - bar=`expr $bar + 1`
> -done
> -pcitest -C
> -echo
> -
> -echo "Interrupt tests"
> -echo
> -
> -pcitest -i 0
> -pcitest -l
> -
> -pcitest -i 1
> -msi=1
> -
> -while [ $msi -lt 33 ]
> -do
> -pcitest -m $msi
> -msi=`expr $msi + 1`
> -done
> -echo
> -
> -pcitest -i 2
> -msix=1
> -
> -while [ $msix -lt 2049 ]
> -do
> -pcitest -x $msix
> -msix=`expr $msix + 1`
> -done
> -echo
> -
> -echo "Read Tests"
> -echo
> -
> -pcitest -i 1
> -
> -pcitest -r -s 1
> -pcitest -r -s 1024
> -pcitest -r -s 1025
> -pcitest -r -s 1024000
> -pcitest -r -s 1024001
> -echo
> -
> -echo "Write Tests"
> -echo
> -
> -pcitest -w -s 1
> -pcitest -w -s 1024
> -pcitest -w -s 1025
> -pcitest -w -s 1024000
> -pcitest -w -s 1024001
> -echo
> -
> -echo "Copy Tests"
> -echo
> -
> -pcitest -c -s 1
> -pcitest -c -s 1024
> -pcitest -c -s 1025
> -pcitest -c -s 1024000
> -pcitest -c -s 1024001
> -echo
> --
> 2.25.1
>
Reviewed-by: Niklas Cassel
+$(info ${CURDIR})
> prepare: $(OUTPUT)include/linux/
>
> PCITEST_IN := $(OUTPUT)pcitest-in.o
> diff --git a/tools/pci/pcitest.c
> b/tools/testing/selftests/pci_endpoint/pcitest.c
> similarity index 100%
> rename from tools/pci/pcitest.c
> rename to tools/testing/selftests/pci_endpoint/pcitest.c
> diff --git a/tools/pci/pcitest.sh
> b/tools/testing/selftests/pci_endpoint/pcitest.sh
> similarity index 100%
> rename from tools/pci/pcitest.sh
> rename to tools/testing/selftests/pci_endpoint/pcitest.sh
> --
> 2.25.1
>
Reviewed-by: Niklas Cassel
# echo 8 > functions/pci_epf_test/func1/msix_interrupts
+ # echo 32 > functions/pci_epf_test/func1/msi_interrupts
+ # echo 2048 > functions/pci_epf_test/func1/msix_interrupts
Such that the documentation suggests values that will actually make the
pci_endpoint_test pass without any special parameters set.
Other than that small nit, for the series:
Tested-by: Niklas Cassel
d the DMA
> controller can support both DMA_PRIVATE and DMA_MEMCPY.
>
> So fix the check and also reword the error message.
>
> Reported-by: Niklas Cassel
> Closes: https://lore.kernel.org/linux-pci/Z3QtEihbiKIGogWA@ryzen
> Fixes: 8353813c88ef ("PCI: endpoint: Enab
On Thu, Jan 16, 2025 at 10:17:25AM +0530, Manivannan Sadhasivam wrote:
> On Thu, Jan 02, 2025 at 03:23:14PM +0100, Niklas Cassel wrote:
> > Hello Mani, Vinod,
> >
> > On Thu, Jan 02, 2025 at 12:34:04PM +0530, Manivannan Sadhasivam wrote:
> > > On Tue, Dec 31, 20
Hello Mani, Vinod,
On Thu, Jan 02, 2025 at 12:34:04PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Dec 31, 2024 at 08:33:57PM +0100, Niklas Cassel wrote:
> >
> > I have some patches that adds DMA_MEMCPY to dw-edma, but I'm not sure if
> > the DWC eDMA hardware suppor
On 31 December 2024 20:18:12 CET, Manivannan Sadhasivam
wrote:
>On Tue, Dec 31, 2024 at 06:42:42PM +0100, Niklas Cassel wrote:
>> On Tue, Dec 31, 2024 at 06:43:41PM +0530, Manivannan Sadhasivam wrote:
>>
>> (...)
>>
>> > + # RUN
On Tue, Dec 31, 2024 at 06:43:41PM +0530, Manivannan Sadhasivam wrote:
(...)
> + # RUN pci_ep_data_transfer.dma.COPY_TEST ...
> + #OK pci_ep_data_transfer.dma.COPY_TEST
> + ok 11 pci_ep_data_transfer.dma.COPY_TEST
> + # PASSED: 11 / 11 tests passed.
> +
On Tue, Dec 31, 2024 at 06:43:40PM +0530, Manivannan Sadhasivam wrote:
> This just moves the existing tests under tools/pci to
> tools/testing/selftests/pci_endpoint and adjusts the paths in Makefile
> accordingly. Migration to Kselftest framework will be done in subsequent
> commits.
>
> Signed-o
lse;
> + return -ETIMEDOUT;
>
> - return pci_irq_vector(pdev, msi_num - 1) == test->last_irq;
> + if (!(pci_irq_vector(pdev, msi_num - 1) == test->last_irq))
if (pci_irq_vector(pdev, msi_num - 1) != test->last_irq) ?
Or perhaps even:
ret = pci_irq_vector();
if (ret < 0)
return ret;
if (ret != test->last_irq)
return -EIO;
Otherwise, this looks good to me:
Reviewed-by: Niklas Cassel
On Fri, Dec 20, 2024 at 12:55:04AM +0900, Krzysztof Wilczyński wrote:
[...]
> > Mani suggested that my patch (which conflicts with this),
> > should be picked up first.
> >
> > Is there a reason for the sudden chance of plans?
>
> No, no change to the plan here.
>
> There were some mixed signa
On Thu, Dec 19, 2024 at 09:01:12AM +0900, Krzysztof Wilczyński wrote:
> Hello,
>
> > This series carries forward the effort to add Kselftest for PCI Endpoint
> > Subsystem started by Aman Gupta [1] a while ago. I reworked the initial
> > version
> > based on another patch that fixes the return va
On Mon, Dec 16, 2024 at 11:33:37AM +0530, Manivannan Sadhasivam wrote:
> On Thu, Dec 12, 2024 at 10:25:53AM +0100, Niklas Cassel wrote:
> >
> > If you need to respin this series, I strongly suggest that you send the
> > Qcom fix separately. It is totally independent, and
Hello Mani,
On Wed, Dec 11, 2024 at 01:31:01PM +0530, Manivannan Sadhasivam wrote:
> Hi,
>
> This series carries forward the effort to add Kselftest for PCI Endpoint
> Subsystem started by Aman Gupta [1] a while ago. I reworked the initial
> version
> based on another patch that fixes the return
On Fri, Nov 29, 2024 at 10:22:56PM +0530, Manivannan Sadhasivam wrote:
> On Fri, Nov 29, 2024 at 05:42:26PM +0100, Niklas Cassel wrote:
> > On Fri, Nov 29, 2024 at 10:05:55PM +0530, Manivannan Sadhasivam wrote:
> > > On Fri, Nov 29, 2024 at 02:51:26PM +0100, Niklas Cassel wrote:
On Fri, Nov 29, 2024 at 10:05:55PM +0530, Manivannan Sadhasivam wrote:
> On Fri, Nov 29, 2024 at 02:51:26PM +0100, Niklas Cassel wrote:
> > Hello Mani,
> >
> > On Fri, Nov 29, 2024 at 02:54:15PM +0530, Manivannan Sadhasivam wrote:
> > > Migrate the PCI endpoint te
Hello Mani,
On Fri, Nov 29, 2024 at 02:54:15PM +0530, Manivannan Sadhasivam wrote:
> Migrate the PCI endpoint test to Kselftest framework. All the tests that
> were part of the previous pcitest.sh file were migrated.
>
> Below is the exclusive list of tests:
>
> 1. BAR Tests (BAR0 to BAR5)
> 2.
There is a single trailing whitespace in core.c.
Since this is just a single whitespace, the chances of this affecting
backports to stable should be quite low, so let's just remove it.
Signed-off-by: Niklas Cassel
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 del
There is a single trailing whitespace in multipath.c.
Since this is just a single whitespace, the chances of this affecting
backports to stable should be quite low, so let's just remove it.
Signed-off-by: Niklas Cassel
---
drivers/nvme/host/multipath.c | 2 +-
1 file changed, 1 insertion(
Hello nvme peeps,
This series removes all the trailing whitespace I could find using:
git grep '[[:blank:]]$' drivers/nvme
So this should remove all the existing trailing whitespace in
drivers/nvme/*
Kind regards,
Niklas
Niklas Cassel (3):
nvme-pci: remove single trailing whitesp
There is a single trailing whitespace in pci.c.
Since this is just a single whitespace, the chances of this affecting
backports to stable should be quite low, so let's just remove it.
Signed-off-by: Niklas Cassel
---
drivers/nvme/host/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 del
From: Niklas Cassel
According to the module parameter description for sgl_threshold,
a value of 0 means that SGLs are disabled.
If SGLs are disabled, we should respect that, even for the case
where the request is made up of a single physical segment.
Fixes: 297910571f08 ("nvme-pci: opt
From: Niklas Cassel
When a passthru command targets a specific namespace, the ns parameter to
nvme_user_cmd()/nvme_user_cmd64() is set. However, there is currently no
validation that the nsid specified in the passthru command targets the
namespace/nsid represented by the block device that the
On Tue, Mar 30, 2021 at 08:30:22PM +0200, jav...@javigon.com wrote:
> On 26.03.2021 20:59, Niklas Cassel wrote:
> > From: Niklas Cassel
> >
> > Currently when doing NVME_IOCTL_IO_CMD on the controller character device,
> > the command is rejected if there is mor
From: Niklas Cassel
Currently when doing NVME_IOCTL_IO_CMD on the controller character device,
the command is rejected if there is more than one namespace in the
ctrl->namespaces list.
There is not really any reason for this restriction.
Instead, check the nsid value specified in the passt
On Fri, Mar 26, 2021 at 12:19:42AM +0900, Keith Busch wrote:
> On Thu, Mar 25, 2021 at 09:48:37AM +0000, Niklas Cassel wrote:
> > From: Niklas Cassel
> >
> > When a passthru command targets a specific namespace, the ns parameter to
> > nvme_user_cmd()/nvme_user_cmd64(
From: Niklas Cassel
When a passthru command targets a specific namespace, the ns parameter to
nvme_user_cmd()/nvme_user_cmd64() is set. However, there is currently no
validation that the nsid specified in the passthru command targets the
namespace/nsid represented by the block device that the
On Thu, Mar 25, 2021 at 09:48:37AM +, Niklas Cassel wrote:
> From: Niklas Cassel
>
> When a passthru command targets a specific namespace, the ns parameter to
> nvme_user_cmd()/nvme_user_cmd64() is set. However, there is currently no
> validation that the nsid specified
From: Niklas Cassel
When a passthru command targets a specific namespace, the ns parameter to
nvme_user_cmd()/nvme_user_cmd64() is set. However, there is currently no
validation that the nsid specified in the passthru command targets the
namespace/nsid represented by the block device that the
On Mon, Mar 08, 2021 at 10:02:05PM +0530, Kanchan Joshi wrote:
> On Mon, Mar 8, 2021 at 4:21 PM Niklas Cassel wrote:
> >
> > From: Niklas Cassel
> >
> > This reverts commit 73d90386b559d6f4c3c5db5e6bb1b68aae8fd3e7.
> >
> > Commit 73d90386b559 ("n
From: Niklas Cassel
This reverts commit 73d90386b559d6f4c3c5db5e6bb1b68aae8fd3e7.
Commit 73d90386b559 ("nvme: cleanup zone information initialization")
introduced the following warning at boot:
WARNING: CPU: 0 PID: 7 at block/blk-settings.c:252
blk_queue_max_zone_append_sectors+0x7d
sense to collect SoC specific drivers like these, into the SoC specific
> directories.
>
> Therefore, let's move the qcom-cpr driver to the qcom directory.
>
> Cc: Niklas Cassel
> Cc: Bjorn Andersson
> Cc: Andy Gross
> Cc: linux-arm-...@vger.kernel.org
> Si
On Mon, Sep 07, 2020 at 08:18:26AM +, Niklas Cassel wrote:
> On Fri, Aug 28, 2020 at 12:54:00PM +0200, Niklas Cassel wrote:
> > Add support for user space to set a max open zone and a max active zone
> > limit via configfs. By default, the default values are 0 == no limit.
&g
On Fri, Aug 28, 2020 at 12:54:00PM +0200, Niklas Cassel wrote:
> Add support for user space to set a max open zone and a max active zone
> limit via configfs. By default, the default values are 0 == no limit.
>
> Call the block layer API functions used for exposing the configured
ZBC.
Therefore, implement the manage open zone resources function from ZBC,
but additionally add support for max active zones.
This enables user space not only to test against a device with an open
zone limit, but also to test against a device with an active zone limit.
Signed-off-by: Niklas Cassel
On Fri, Aug 28, 2020 at 07:06:26AM +, Damien Le Moal wrote:
> On 2020/08/27 22:50, Niklas Cassel wrote:
> > Add support for user space to set a max open zone and a max active zone
> > limit via configfs. By default, the default values are 0 == no limit.
> >
> &g
On Tue, Aug 25, 2020 at 11:03:58PM +, Damien Le Moal wrote:
> On 2020/08/26 7:52, Damien Le Moal wrote:
> > On 2020/08/25 21:22, Niklas Cassel wrote:
(snip)
> Arg. No, you can't. There is the trace call after the switch. So please ignore
> this comment :)
>
&g
ZBC.
Therefore, implement the manage open zone resources function from ZBC,
but additionally add support for max active zones.
This enables user space not only to test against a device with an open
zone limit, but also to test against a device with an active zone limit.
Signed-off-by: Niklas Cassel
.
Therefore, implement the manage open zone resources function from ZBC,
but additionally add support for max active zones.
This enables user space not only to test against a device with an open
zone limit, but also to test against a device with an active zone limit.
Signed-off-by: Niklas Cassel
resp_open_zone() to call zbc_close_zone()
on an implicitly open zone before calling zbc_open_zone().
Remove superfluous close zone in resp_open_zone().
Signed-off-by: Niklas Cassel
---
drivers/scsi/scsi_debug.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi
max_active_zones as 0, signifying "no limit".
Signed-off-by: Niklas Cassel
Reviewed-by: Javier González
Reviewed-by: Damien Le Moal
---
Documentation/ABI/testing/sysfs-block | 9 +
Documentation/block/queue-sysfs.rst | 7 +++
block/blk-sysfs.c
SCSI devices by
the kernel), and ZBC SCSI devices.
Add the new max_open_zones member to struct request_queue, rather
than as a queue limit, since this property cannot be split across stacking
drivers.
Signed-off-by: Niklas Cassel
Reviewed-by: Javier González
Reviewed-by: Damien Le Moal
aning "no limit".
Changes since v2:
-Picked up Damien's Reviewed-by tags.
-Update Documentation/ABI/testing/sysfs-block in addition to
Documentation/block/queue-sysfs.rst (Greg).
-Added bdev_max_open_zones()/bdev_max_active_zones() helpers
(Johannes).
Niklas Cassel (2):
b
On Fri, Jul 03, 2020 at 08:22:45AM +, Johannes Thumshirn wrote:
> On 02/07/2020 20:20, Niklas Cassel wrote:
> > Documentation/block/queue-sysfs.rst | 7 +++
> > block/blk-sysfs.c | 15 +++
> > drivers/nvme/host/zns.c |
max_active_zones as 0, signifying "no limit".
Signed-off-by: Niklas Cassel
Reviewed-by: Javier González
---
Documentation/block/queue-sysfs.rst | 7 +++
block/blk-sysfs.c | 14 +-
drivers/nvme/host/zns.c | 1 +
drivers/scsi/sd_zbc.c
SCSI devices by
the kernel), and ZBC SCSI devices.
Add the new max_open_zones member to struct request_queue, rather
than as a queue limit, since this property cannot be split across stacking
drivers.
Signed-off-by: Niklas Cassel
Reviewed-by: Javier González
---
Documentation/block/queue-sysfs.rst
d up Javier's Reviewed-by tags.
-Reworded commit message (Damien).
-Dropped unused stubs for setting MAR/MOR when building without
CONFIG_BLK_DEV_ZONED (Damien).
Niklas Cassel (2):
block: add max_open_zones to blk-sysfs
block: add max_active_zones to blk-sysfs
Documentation/bl
On Tue, Jun 30, 2020 at 01:49:41AM +, Damien Le Moal wrote:
> On 2020/06/16 19:28, Niklas Cassel wrote:
> > diff --git a/drivers/nvme/host/zns.c b/drivers/nvme/host/zns.c
> > index c08f6281b614..af156529f3b6 100644
> > --- a/drivers/nvme/host/zns.c
> > ++
On Wed, Jul 01, 2020 at 01:16:52PM +0200, Javier González wrote:
> On 16.06.2020 12:25, Niklas Cassel wrote:
> > Add a new max_active zones definition in the sysfs documentation.
> > This definition will be common for all devices utilizing the zoned block
> > device
On Mon, Jun 29, 2020 at 12:52:46AM +, Damien Le Moal wrote:
> On 2020/06/29 8:01, Matias Bjorling wrote:
> > The NVMe Zoned Namespace Command Set adds support for associating
> > data to a zone through the Zone Descriptor Extension feature.
> >
> > The Zone Descriptor Extension size is fixed t
On Wed, Jun 24, 2020 at 10:40:21PM +, Chaitanya Kulkarni wrote:
> Christoph, Sagi and Keith,
>
> On 6/24/20 9:44 AM, Christoph Hellwig wrote:
> > This looks good to me, but I'd rather wait a few releases to
> > avoid too mush backporting pain.
> >
>
> Here is a summary, for longer explanatio
On Wed, Jun 24, 2020 at 07:02:11PM +0200, Christoph Hellwig wrote:
> On Wed, Jun 24, 2020 at 04:57:48PM +0000, Niklas Cassel wrote:
> > On Wed, Jun 24, 2020 at 06:44:41PM +0200, Christoph Hellwig wrote:
> > > This looks good to me, but I'd rather wait a few releases
On Wed, Jun 24, 2020 at 06:44:41PM +0200, Christoph Hellwig wrote:
> This looks good to me, but I'd rather wait a few releases to
> avoid too mush backporting pain.
Chaitanya made me realize that about half of the nvme functions
are using "struct nvme_command c" on the stack, and then memsets
it,
uild
for anonymous union in older GCC compilers").
Changes since v1:
-Fixed RDMA build error.
Niklas Cassel (2):
nvme: remove workarounds for gcc bug wrt unnamed fields in
initializers
nvmet: remove workarounds for gcc bug wrt unnamed fields in
initializers
drivers/nv
t should now be safe to remove these workarounds
and make the code look like it did before
commit e44ac588cd61 ("drivers/block/nvme-core.c: fix build with gcc-4.4.4")
was introduced.
Signed-off-by: Niklas Cassel
---
drivers/nvme/target/rdma.c | 23 ---
1 file changed,
t should now be safe to remove these workarounds
and make the code look like it did before
commit e44ac588cd61 ("drivers/block/nvme-core.c: fix build with gcc-4.4.4")
was introduced.
Signed-off-by: Niklas Cassel
---
drivers/nvme/host/core.c | 59 ++-
On Thu, Jun 18, 2020 at 05:29:00PM +, Chaitanya Kulkarni wrote:
> I'm not against the code cleanup and it always welcome.
> Please also have a look at other comment.
>
> >> What is the issue with existing code that we need this patch for ?
> >>
> >
> > Hello Chaitanya,
> >
> > This is just
On Thu, Jun 18, 2020 at 07:11:24PM +0200, Daniel Wagner wrote:
> On Thu, Jun 18, 2020 at 04:32:40PM +0200, Niklas Cassel wrote:
> > If, for some reason, we want to allow builds with gcc < 4.6.0
> > even though the minimum gcc version is now 4.8.0,
>
> Just one thing to wat
On Thu, Jun 18, 2020 at 03:23:21PM +, Chaitanya Kulkarni wrote:
> On 6/18/20 7:32 AM, Niklas Cassel wrote:
> > drivers/nvme/target/rdma.c | 23 ---
> > 1 file changed, 12 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/nvme/t
t should now be safe to remove these workarounds
and make the code look like it did before
commit e44ac588cd61 ("drivers/block/nvme-core.c: fix build with gcc-4.4.4")
was introduced.
Signed-off-by: Niklas Cassel
---
If, for some reason, we want to allow builds with gcc < 4.6.0
even though
t should now be safe to remove these workarounds
and make the code look like it did before
commit e44ac588cd61 ("drivers/block/nvme-core.c: fix build with gcc-4.4.4")
was introduced.
Signed-off-by: Niklas Cassel
---
If, for some reason, we want to allow builds with gcc < 4.6.0
even though
SCSI devices by
the kernel), and ZBC SCSI devices.
Add the new max_open_zones struct member to the request_queue, rather
than as a queue limit, since this property cannot be split across stacking
drivers.
Signed-off-by: Niklas Cassel
---
Documentation/block/queue-sysfs.rst | 7 +++
block/blk
max_active_zones as 0, signifying "no limit".
Signed-off-by: Niklas Cassel
---
Documentation/block/queue-sysfs.rst | 7 +++
block/blk-sysfs.c | 14 +-
drivers/nvme/host/zns.c | 1 +
drivers/scsi/sd_zbc.c | 1 +
include/linu
this new definition. For ZAC/ZBC devices, this field will be
exported as 0, meaning "no limit".
Niklas Cassel (2):
block: add max_open_zones to blk-sysfs
block: add max_active_zones to blk-sysfs
Documentation/block/queue-sysfs.rst | 14 ++
block/blk-sysfs.c
696 ("nvme: enforce extended LBA format for fabrics metadata")
Signed-off-by: Niklas Cassel
---
An alternative would be to do like nvme_ns_remove(), i.e. in the error
path; check if ns->disk->flags & GENHD_FL_UP is set, and only then call
del_gendisk(). However, that seems unnec
On Tue, Apr 28, 2020 at 09:06:51AM +0200, Javier González wrote:
> CAUTION: This email originated from outside of Western Digital. Do not click
> on links or open attachments unless you recognize the sender and know that
> the content is safe.
>
>
> On 27.04.2020 18:22, N
table itself.
> >
> > The lockdep_assert_held() was added there by mistake and isn't really
> > required.
> >
> > Fixes: 5d6d106fa455 ("OPP: Populate required opp tables from
> > "required-opps" property")
> > Cc: v5.0+ # v5.0+
>
sudden load changes will be less severe, and we have not been able
to reproduce the invalid page faults with the regulator in this mode.
Signed-off-by: Niklas Cassel
Suggested-by: Bjorn Andersson
---
arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch
On Wed, Oct 02, 2019 at 11:19:50AM +0200, Niklas Cassel wrote:
> On Mon, Sep 30, 2019 at 04:20:15PM -0600, Jeffrey Hugo wrote:
> > Amit, the merged version of the below change causes a boot failure
> > (nasty hang, sometimes with RCU stalls) on the msm8998 laptops. Oddly
> >
On Mon, Sep 30, 2019 at 04:20:15PM -0600, Jeffrey Hugo wrote:
> Amit, the merged version of the below change causes a boot failure
> (nasty hang, sometimes with RCU stalls) on the msm8998 laptops. Oddly
> enough, it seems to be resolved if I remove the cpu-idle-states
> property from one of the cp
dev->parent = parent;
> dev->of_node = node;
> dev->release = qcom_glink_smem_release;
> - dev_set_name(dev, "%pOFn:%pOFn", node->parent, node);
> + dev_set_name(dev, "%s:%pOFn", dev_name(parent->parent), node);
> ret = device_register(dev);
> if (ret) {
> pr_err("failed to register glink edge\n");
> --
> 2.18.0
>
Reviewed-by: Niklas Cassel
On Mon, Aug 19, 2019 at 09:16:56PM -0700, Bjorn Andersson wrote:
> Naming the glink edge device on the parent of_node short name causes
> collisions when multiple remoteproc instances with only different unit
> address are described on the platform_bus in DeviceTree.
>
> Base the edge's name on th
find_next_bit+0x38/0xb0
Fixes: 1b497e6493c4 ("PCI: dwc: Fix uninitialized variable in
dw_handle_msi_irq()")
Signed-off-by: Niklas Cassel
---
drivers/pci/controller/dwc/pcie-designware-host.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/cont
-off-by: Niklas Cassel
Reviewed-by: Rob Herring
---
Changes since V3:
-In Example 2: rename the node name from cpr to power-controller,
and rename the label from cprpd to cpr.
.../bindings/opp/qcom-nvmem-cpufreq.txt | 113 +-
1 file changed, 112 insertions(+), 1 deletion
On Mon, Aug 19, 2019 at 10:59:36AM -0700, Stephen Boyd wrote:
> Quoting Niklas Cassel (2019-08-19 03:09:57)
> > +
> > +soc {
> > +
> > + cprpd: cpr@b018000 {
>
> Maybe node name should be 'avs' for the industry standard adaptive
> voltag
On Fri, Aug 16, 2019 at 11:14:13PM -0700, Stephen Boyd wrote:
> Quoting Niklas Cassel (2019-07-25 03:41:38)
> > + cpr@b018000 {
> > + compatible = "qcom,qcs404-cpr", "qcom,cpr";
> > + reg = <0x0b018000 0x1
ch/arm64/boot/dts/qcom/sm8150-mtp.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sm8150.dtsi
>
> --
> 2.20.1
>
Whole series is:
Reviewed-by: Niklas Cassel
On Tue, Aug 20, 2019 at 12:12:08PM +0530, Vinod Koul wrote:
> This series adds DTS for SM8150, PMIC PM8150, PM8150B, PM8150L and
> the MTP for SM8150.
>
> Changes in v2:
> - Squash patches
> - Fix comments given by Stephen namely, lowercase for hext numbers,
>making rpmhcc have xo_board as p
On Tue, Aug 20, 2019 at 12:12:09PM +0530, Vinod Koul wrote:
> This add base DTS file with cpu, psci, firmware, clock, tlmm and
> spmi nodes which enables boot to console
>
> Signed-off-by: Vinod Koul
> ---
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 305 +++
> 1 file changed
On Tue, Aug 20, 2019 at 12:12:11PM +0530, Vinod Koul wrote:
> PMIC pm8150b is a slave pmic and this adds base DTS file for pm8150b
> with pon, adc, and gpio nodes
All of your other commit messages refers to it as power-on
instead of pon, be consistent.
>
> Signed-off-by: Vinod Koul
> ---
> arc
On Tue, Aug 20, 2019 at 12:12:10PM +0530, Vinod Koul wrote:
> Add base DTS file for pm8150 along with GPIOs, power-on, rtc and vadc
> nodes
>
> Signed-off-by: Vinod Koul
> ---
> arch/arm64/boot/dts/qcom/pm8150.dtsi | 95
> 1 file changed, 95 insertions(+)
> create m
On Tue, Aug 20, 2019 at 12:12:13PM +0530, Vinod Koul wrote:
> This add base DTS file for sm8150-mtp and enables boot to console, adds
> tlmm reserved range, resin node, volume down key and also includes pmic
> file.
>
> Signed-off-by: Vinod Koul
> ---
> arch/arm64/boot/dts/qcom/Makefile |
On Tue, Aug 20, 2019 at 12:12:14PM +0530, Vinod Koul wrote:
> Add the regulators found in the mtp platform. This platform consists of
> pmic PM8150, PM8150L and PM8009.
Is there a reason not to squash this this patch 5/8 ?
>
> Signed-off-by: Vinod Koul
> ---
> arch/arm64/boot/dts/qcom/sm8150-m
On Tue, Aug 20, 2019 at 12:12:15PM +0530, Vinod Koul wrote:
> Add the reserved memory regions in SM8150
Is there a reason not to squash this this patch 1/8 ?
>
> Signed-off-by: Vinod Koul
> ---
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 111 +++
> 1 file changed, 111 inse
Add qcom-opp bindings with properties needed for Core Power Reduction
(CPR).
CPR is included in a great variety of Qualcomm SoCs, e.g. msm8916 and
msm8996. CPR was first introduced in msm8974.
Co-developed-by: Jorge Ramirez-Ortiz
Signed-off-by: Jorge Ramirez-Ortiz
Signed-off-by: Niklas Cassel
-off-by: Niklas Cassel
Reviewed-by: Rob Herring
---
Changes since V2:
-Picked up Rob's Reviewed-by on V2.
-As Rob pointed out in V1, it should be
"In 'cpu' nodes" and not "In 'cpus' nodes".
-In Example 2: include the qcom,opp-fuse-level property rather th
e
> them.
>
> But on the EVB these registers are only accessible through TrustZone, so
> these clocks must be marked as "protected" to prevent the clock code
> from touching them.
>
> Numerical values are used as the constants are not yet available in a
> common t
On Mon, Jul 29, 2019 at 03:20:11PM +0530, Amit Kucheria wrote:
> On Mon, Jul 29, 2019 at 3:03 PM Luca Weiss wrote:
> >
> > On Montag, 29. Juli 2019 11:07:35 CEST Brian Masney wrote:
> > > On Sat, Jul 27, 2019 at 12:58:54PM +0530, Amit Kucheria wrote:
> > > > On Fri, Jul 26, 2019 at 4:59 PM Brian M
Enable CONFIG_QCOM_CPR.
Signed-off-by: Niklas Cassel
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 04b7fb26a942..3e7618818250 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64
Add CPR and populate OPP table.
Co-developed-by: Jorge Ramirez-Ortiz
Signed-off-by: Jorge Ramirez-Ortiz
Signed-off-by: Niklas Cassel
---
Changes since V1:
-Removed opp-hz from CPR OPP table.
arch/arm64/boot/dts/qcom/qcs404.dtsi | 142 +--
1 file changed, 134
Add qcom-opp bindings with properties needed for Core Power Reduction
(CPR).
CPR is included in a great variety of Qualcomm SoCs, e.g. msm8916 and
msm8996. CPR was first introduced in msm8974.
Co-developed-by: Jorge Ramirez-Ortiz
Signed-off-by: Jorge Ramirez-Ortiz
Signed-off-by: Niklas Cassel
Add DT bindings to describe the CPR HW found on certain Qualcomm SoCs.
Co-developed-by: Jorge Ramirez-Ortiz
Signed-off-by: Jorge Ramirez-Ortiz
Signed-off-by: Niklas Cassel
Reviewed-by: Rob Herring
---
Changes since V1:
-Picked up tags.
.../bindings/power/avs/qcom,cpr.txt | 193
Enable CONFIG_ARM_QCOM_CPUFREQ_NVMEM.
Signed-off-by: Niklas Cassel
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 3e7618818250..9b0cc49f5fe8 100644
--- a/arch/arm64/configs/defconfig
+++ b
From: Jorge Ramirez-Ortiz
Add qcs404 to cpufreq-dt-platdev blacklist.
Signed-off-by: Jorge Ramirez-Ortiz
Co-developed-by: Niklas Cassel
Signed-off-by: Niklas Cassel
---
drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/cpufreq-dt
others on codeaurora.org[2].
[1] https://lkml.org/lkml/2015/9/18/833
[2]
https://www.codeaurora.org/cgit/quic/la/kernel/msm-3.10/tree/drivers/regulator/cpr-regulator.c?h=msm-3.10
Co-developed-by: Jorge Ramirez-Ortiz
Signed-off-by: Jorge Ramirez-Ortiz
Signed-off-by: Niklas Cassel
---
Change
-Ortiz
Signed-off-by: Niklas Cassel
---
Changes since V1:
-Adapt to dev_pm_opp_attach_genpd() API change.
drivers/cpufreq/qcom-cpufreq-nvmem.c | 50 ++--
1 file changed, 47 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c
b/drivers/cpufreq
-off-by: Niklas Cassel
---
.../bindings/opp/qcom-nvmem-cpufreq.txt | 111 ++
1 file changed, 111 insertions(+)
diff --git a/Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt
b/Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt
index c5ea8b90e35d
only be supported on certain SoCs.
Co-developed-by: Jorge Ramirez-Ortiz
Signed-off-by: Jorge Ramirez-Ortiz
Signed-off-by: Niklas Cassel
Reviewed-by: Ilia Lin
---
Changes since V1:
-Picked up tags.
-Fixed an incorrectly placed of_node_put().
drivers/cpufreq/qcom-cpufreq-nvmem.c | 123
Not all Qualcomm platforms need to care about the speedbin efuse,
nor the value blown into the speedbin efuse.
Therefore, make the nvmem-cells and opp-supported-hw properties
optional.
Signed-off-by: Niklas Cassel
Reviewed-by: Ilia Lin
Reviewed-by: Rob Herring
---
Changes since V1:
-Picked up
1 - 100 of 751 matches
Mail list logo
