t; devices using the
MAX96712 as a video source there are a lot of features missing. Most
notably the ability to operate the GMSL bus.
Signed-off-by: Niklas Söderlund
---
MAINTAINERS | 6 +
drivers/staging/media/Kconfig | 2 +
drivers/staging/medi
The following commit has been merged into the timers/core branch of tip:
Commit-ID: c4d814416fe3f5eb27438209a83582d7508ba80a
Gitweb:
https://git.kernel.org/tip/c4d814416fe3f5eb27438209a83582d7508ba80a
Author:Niklas Söderlund
AuthorDate:Thu, 11 Feb 2021 15:31:02 +01:00
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 446e1a943554e07a4e6431fff6dd06c0f130895a
Gitweb:
https://git.kernel.org/tip/446e1a943554e07a4e6431fff6dd06c0f130895a
Author:Niklas Söderlund
AuthorDate:Thu, 11 Feb 2021 15:33:44 +01:00
The following commit has been merged into the timers/core branch of tip:
Commit-ID: d4c7c28806616809e3baa0b7cd8c665516b2726d
Gitweb:
https://git.kernel.org/tip/d4c7c28806616809e3baa0b7cd8c665516b2726d
Author:Niklas Söderlund
AuthorDate:Thu, 11 Feb 2021 14:43:18 +01:00
Hi Wolfram,
Thanks for your patch.
On 2021-03-11 10:09:18 +0100, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang
Reviewed-by: Niklas Söderlund
> ---
>
> Changes since V1:
> * none, but additional testing was done which revealed that this CMT
> in deed behaves the same
Hi Wolfram,
Thanks for your patch.
On 2021-03-05 14:28:59 +0100, Wolfram Sang wrote:
> CMTOUT_IE is only supported for older SoCs. Newer SoCs shall not set
> this bit. So, add a version check.
>
> Reported-by: Phong Hoang
> Signed-off-by: Wolfram Sang
Reviewed-by: N
Hi Wolfram,
Thanks for your work.
On 2021-03-05 15:23:59 +0100, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang
Reviewed-by: Niklas Söderlund
> ---
>
> This is the correct one. TMU passed the testsuite, CMT needs a second
> look.
>
> Documentation/devicetree/b
a2c5e6 ("clocksource: add enable() and disable() callbacks")
Signed-off-by: Niklas Söderlund
---
kernel/time/timekeeping.c | 36 +++-
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 6ae
hile at it, use pm_runtime_put() instead of pm_runtime_put_sync(), as
> there is no reason to do a synchronous power down.
>
> Fixes: 7fa2955ff70ce453 ("sh_eth: Fix sleeping function called from invalid
> context")
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
dependency on implicit reset and/or
> boot loader state, and by enabling the clock supply explicitly for all
> channels used instead. This requires postponing the clk_disable() call,
> else the timer's registers cannot be accessed in sh_cmt_setup_channel().
>
> Signed-off-by: Geert
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 8ae954caf49ac403c177d117fb8e05cbc866aa3c
Gitweb:
https://git.kernel.org/tip/8ae954caf49ac403c177d117fb8e05cbc866aa3c
Author:Niklas Söderlund
AuthorDate:Sat, 05 Dec 2020 03:19:20 +01:00
by: Daniel Lezcano
Reviewed-by: Niklas Söderlund
> ---
> drivers/thermal/rcar_thermal.c | 19 ---
> 1 file changed, 19 deletions(-)
>
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index 6ae757d66f46..b49f04daaf47 100644
&g
154
[ 47.682308] smpboot_thread_fn+0x244/0x270
[ 47.690560] kthread+0x154/0x160
[ 47.697927] ret_from_fork+0x10/0x20
[ 47.708447] clocksource: Switched to clocksource e60f.timer
Signed-off-by: Niklas Söderlund
---
drivers/clocksource/sh_cmt.c | 18 ++
1 file c
anosleep CLOCK_REALTIME_ALARM[UNSUPPORTED]
Nanosleep CLOCK_BOOTTIME_ALARM[UNSUPPORTED]
Nanosleep CLOCK_TAI [OK]
# Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0
# Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0
Niklas Söderlund (2):
clocksource
a2c5e6 ("clocksource: add enable() and disable() callbacks")
Signed-off-by: Niklas Söderlund
---
kernel/time/timekeeping.c | 36 +++-
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 685
urned. Fix this.
>
> Addresses-Coverity: ("Unused value")
> Fixes: b9ad52aafe38 ("media: rcar-vin: Rework parallel firmware parsing")
> Signed-off-by: Colin Ian King
Reviewed-by: Niklas Söderlund
> ---
> drivers/media/platform/rcar-vin/rcar-core.c | 2 +-
>
applying!
For the whole series,
Reviewed-by: Niklas Söderlund
>
> Geert Uytterhoeven (1):
> dt-bindings: timer: renesas: tmu: Convert to json-schema
>
> Marian-Cristian Rotariu (1):
> dt-bindings: timer: renesas: tmu: Document r8a774e1 bindings
>
> .../devi
MN}, by default the CSI20 node is tied to
> ov5645 camera endpoint and the imx219 camera endpoint is tied to CSI40.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Biju Das
I have not reviewed the schematics but the patch in itself looks good,
Acked-by: Niklas Söderlund
Hi Tian,
Thanks for your work.
On 2020-10-21 11:05:30 +0800, Tian Tao wrote:
> The code has been in a irq-disabled context since it is hard IRQ. There
> is no necessity to do it again.
>
> Signed-off-by: Tian Tao
Tested-by: Niklas Söderlund
> ---
> drivers/thermal/
ies:
> description: VIN channel number
> $ref: /schemas/types.yaml#/definitions/uint32
> minimum: 0
> -maximum: 15
> +maximum: 31
>
>ports:
> type: object
> --
> 2.28.0
>
--
Regards,
Niklas Söderlund
0 0x1000>;
> + interrupts = ;
> + clocks = <&cpg CPG_MOD 824>;
> + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> + resets = <&cpg 824>;
> + status = "disab
g with that will be quiet significant work in the driver.
I'm not yet 100% sure the best idea is to support V3U with this driver,
maybe it's finally time to make it more modular, with more distinct
support for Gen2, Gen3 and a new module for V3U?
>
>reg:
> maxItems: 1
> --
> 2.28.0
>
--
Regards,
Niklas Söderlund
67df6c9 ("media: rcar-vin: Extend RAW8 support to all RGB
> layouts")
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Biju Das
Reviewed-by: Niklas Söderlund
> ---
> Hi Hans,
>
> If it isn't too late for v5.10 could you please queue up this patch.
>
>
Hi Bjorn,
On 2020-09-30 17:51:54 -0500, Bjorn Helgaas wrote:
> On Wed, Sep 30, 2020 at 03:34:10PM -0500, Rob Herring wrote:
> > On Wed, Sep 30, 2020 at 12:37 PM Niklas Söderlund
> > wrote:
> > >
> > > Hi Marc,
> > >
> > > On 2020-09-30 18
Hi Marc,
On 2020-09-30 18:23:21 +0100, Marc Zyngier wrote:
> Hi Niklas,
>
> [+ Samuel]
>
> On 2020-09-30 17:27, Niklas Söderlund wrote:
> > Hi Marc,
> >
> > I'm afraid this commit breaks booting my rk3399 device.
> >
> > I bisected the pro
, accept the device as PCI (with a warning).
>*/
> return of_node_is_type(np, "pci") || of_node_is_type(np, "pciex") ||
> - of_node_is_type(np, "vci") || of_node_is_type(np, "ht");
> + of_node_is_type(np, "vci") || of_node_is_type(np, "ht") ||
> + of_node_is_pcie(np);
> }
>
> static void of_bus_pci_count_cells(struct device_node *np,
> --
> 2.27.0
>
>
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Regards,
Niklas Söderlund
gt;> + }
> >>}
> >>
> >>/*
> >> diff --git a/drivers/media/platform/rcar-vin/rcar-vin.h
> >> b/drivers/media/platform/rcar-vin/rcar-vin.h
> >> index c19d077ce1cb..8396e0e45478 100644
> >> --- a/drivers/media/platform/rcar-vin/rcar-vin.h
> >> +++ b/drivers/media/platform/rcar-vin/rcar-vin.h
> >> @@ -19,6 +19,7 @@
> >> #include
> >> #include
> >> #include
> >> +#include
> >> #include
> >>
> >> /* Number of HW buffers */
> >> @@ -92,7 +93,7 @@ struct rvin_video_format {
> >> * @asd: sub-device descriptor for async framework
> >> * @subdev: subdevice matched using async framework
> >> * @mbus_type:media bus type
> >> - * @mbus_flags: media bus configuration flags
> >> + * @bus: media bus parallel configuration
> >> * @source_pad: source pad of remote subdevice
> >> * @sink_pad: sink pad of remote subdevice
> >> *
> >> @@ -102,7 +103,7 @@ struct rvin_parallel_entity {
> >>struct v4l2_subdev *subdev;
> >>
> >>enum v4l2_mbus_type mbus_type;
> >> - unsigned int mbus_flags;
> >> + struct v4l2_fwnode_bus_parallel bus;
> >>
> >>unsigned int source_pad;
> >>unsigned int sink_pad;
> >>
> >
>
--
Regards,
Niklas Söderlund
mt_rect);
> + vin->crop.top = 0;
> + vin->crop.left = 0;
> + vin->crop.width = vin->format.width;
> + vin->crop.height = vin->format.height;
> + vin->compose = vin->crop;
> vin->src_rect = src_rect;
>
> return 0;
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
>
> > /* Number of HW buffers */
> > @@ -92,7 +93,7 @@ struct rvin_video_format {
> > * @asd: sub-device descriptor for async framework
> > * @subdev:subdevice matched using async framework
> > * @mbus_type: media bus type
> > - * @mbus_flags:media bus configuration flags
> > + * @bus: media bus parallel configuration
> > * @source_pad:source pad of remote subdevice
> > * @sink_pad: sink pad of remote subdevice
> > *
> > @@ -102,7 +103,7 @@ struct rvin_parallel_entity {
> > struct v4l2_subdev *subdev;
> >
> > enum v4l2_mbus_type mbus_type;
> > - unsigned int mbus_flags;
> > + struct v4l2_fwnode_bus_parallel bus;
I think you could break this change (and the fallout) out to a separate
patch to make the functional change clearer.
> >
> > unsigned int source_pad;
> > unsigned int sink_pad;
>
> --
> Regards,
>
> Laurent Pinchart
--
Regards,
Niklas Söderlund
;vin1_data24_b",
> > + "vin1_data20_b",
> > + "vin1_data18_b",
> > + "vin1_data16_b",
> > + "vin1_data12_b",
> > + "vin1_data10_b",
> > + "vin1_data8_b",
>
> Missing vin1_data4_b.
>
> > "vin1_sync",
> > + "vin1_sync_b",
> > "vin1_field",
> > "vin1_clkenb",
> > "vin1_clk",
> > + "vin1_clk_b",
> > };
> >
> > static const char * const vin2_groups[] = {
>
> The rest looks good to me.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
--
Regards,
Niklas Söderlund
eries
with same commit message. With that fixed,
Reviewed-by: Niklas Söderlund
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Chris Paterson
> ---
> drivers/thermal/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/therma
ething like this?
The rcar-csi2 driver also supports RZ/G2 SoC's, update the description
to reflect this.
With the commit message fixed for both patches,
Reviewed-by: Niklas Söderlund
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Chris Paterson
> ---
> drivers/medi
devel.git/log/?h=renesas-arm-dt-for-v5.10
For the whole series,
Reviewed-by: Niklas Söderlund
>
> Cheers,
> Prabhakar
>
> Lad Prabhakar (2):
> dt-bindings: media: renesas,vin: Add device tree support for r8a7742
> ARM: dts: r8a7742: Add VIN DT nodes
>
>
Hi Geert and Lad,
On 2020-08-07 13:36:46 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Fri, Aug 7, 2020 at 1:27 PM Niklas Söderlund
> wrote:
> > On 2020-08-06 13:47:58 +0200, Geert Uytterhoeven wrote:
> > > On Thu, Aug 6, 2020 at 1:17 PM Lad, Prabhakar
> >
andle the warning I'm not sure. I can only really see 2
options.
1. Ignore the warning.
2. Remove #address-cells, #size-cells and reg properties from port@ if
the only endpoint described is endpoint@0.
I would prefers option 2. that is what we do in other cases (for example
on Gen2 boards that only have a single parallel sensor in some early DTS
files we don't have the ports node and just describe a single port with
the same reasoning.
We are not at risk at someone describing a second CSI-2 bock as an
overlay so I see no real harm in option 2. What are your thoughts Geert?
You know more about DT then me.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
--
Regards,
Niklas Söderlund
+++-
> .../media/test-drivers/vimc/vimc-debayer.c| 8 +
> drivers/media/test-drivers/vimc/vimc-scaler.c | 8 +
> drivers/media/test-drivers/vimc/vimc-sensor.c | 9 -
> .../media/test-drivers/vimc/vimc-streamer.c | 23 +++-
> 5 files changed, 73 insertions(+), 10 deletions(-)
>
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
[ 51.534555] ---[ end trace 94f72cbb1552c089 ]---
--
Regards,
Niklas Söderlund
Hi Michael,
On 2020-07-02 14:33:41 +0200, Michael Rodin wrote:
> Hi Niklas,
>
> On Wed, Jul 01, 2020 at 12:17:10AM +0200, Niklas Söderlund wrote:
> > Hi Michael,
> >
> > Thanks for your RFC.
>
> Thanks your your feedback!
>
> > On 2020-06-19 19:46
_id std;
>
> + struct timer_list irq_timer;
> unsigned int alpha;
> };
>
> diff --git a/include/uapi/linux/rcar-vin.h b/include/uapi/linux/rcar-vin.h
> new file mode 100644
> index ..4eb7f5e
> --- /dev/null
> +++ b/include/uapi/linux/rcar-vin.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> +
> +#ifndef RCAR_VIN_USER_H
> +#define RCAR_VIN_USER_H
> +
> +/* class for events sent by the rcar-vin driver */
> +#define V4L2_EVENT_RCAR_VIN_CLASSV4L2_EVENT_PRIVATE_START
> +#define V4L2_EVENT_RCAR_VIN_IRQ_TIMEOUT (V4L2_EVENT_RCAR_VIN_CLASS |
> 0x1)
> +
> +#endif /* RCAR_VIN_USER_H */
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
f (prev_value &&
> + ((mbps - prev_value->mbps) <= (value->mbps - mbps)))
> + value = prev_value;
> +
One to many blank lines. With this and the commit message fixed,
Reviewed-by: Niklas Söderlund
Nice work, thanks again for being persistent with this!
>
> if (!value->mbps) {
> dev_err(priv->dev, "Unsupported PHY speed (%u Mbps)", mbps);
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
-off-by: Michael Rodin
Reviewed-by: Niklas Söderlund
> ---
> drivers/media/platform/rcar-vin/rcar-csi2.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c
> b/drivers/media/platform/rcar-vin/rcar-csi2.c
> index f18dedc..11
---
>
> Fixes: 769afd212b16 ("media: rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver
> driver")
>
> Signed-off-by: Suresh Udipi
> Signed-off-by: Kazuyoshi Akiyama
> Signed-off-by: Michael Rodin
Reviewed-by: Niklas Söderlund
> ---
> Chang
Hi Hans,
On 2020-06-24 15:31:01 +0200, Hans Verkuil wrote:
> On 17/06/2020 17:28, Niklas Söderlund wrote:
> > Hi Michael,
> >
> > On 2020-06-17 17:15:37 +0200, Michael Rodin wrote:
> >> Hi Niklas and Steve,
> >>
> >> On Wed, Jun 17, 2020 at 12
Hi Michael,
On 2020-06-17 17:15:37 +0200, Michael Rodin wrote:
> Hi Niklas and Steve,
>
> On Wed, Jun 17, 2020 at 12:56:46PM +0200, Niklas Söderlund wrote:
> > Hi Michael and Steve,
> >
> > On 2020-06-16 19:31:36 +0200, Michael Rodin wrote:
> > > From
ll video nodes for the group. */
> for (i = 0; i < RCAR_VIN_NUM; i++) {
> if (vin->group->vin[i] &&
> @@ -736,8 +732,10 @@ static int rvin_group_notify_complete(struct
> v4l2_async_notifier *notifier)
> }
> }
> mutex_unlock(&vin->group->lock);
> + if (ret)
> + return ret;
>
> - return ret;
> + return media_device_register(&vin->group->mdev);
> }
>
> static void rvin_group_notify_unbind(struct v4l2_async_notifier *notifier,
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
Hello,
On 2020-06-12 19:28:06 +0200, Michael Rodin wrote:
> Hi Niklas,
> Hi Suresh,
>
> On Fri, Jun 12, 2020 at 12:10:51PM +0900, Suresh Udipi wrote:
> > On Wed, Jun 10, 2020 at 03:40:04PM +0200, Niklas Söderlund wrote:
> > > Hi Suresh,
> > >
&
struct rcsi2_mbps_reg *hsfreq;
const struct rcsi2_mbps_reg *hsfreq_prev = NULL;
for (hsfreq = priv->info->hsfreqrange; hsfreq->mbps != 0; hsfreq++) {
if (hsfreq->mbps >= mbps)
break;
hsfreq_prev = hsfreq;
}
if (!hsfreq->mbps) {
dev_err(priv->dev, "Unsupported PHY speed (%u Mbps)", mbps);
return -ERANGE;
}
if (hsfreq_prev && ((mbps - hsfreq_prev->mbps) <= (hsfreq->mbps - mbps)))
hsfreq = hsfreq_prev;
rcsi2_write(priv, PHYPLL_REG, PHYPLL_HSFREQRANGE(hsfreq->reg));
return 0;
}
> rcsi2_write(priv, PHYPLL_REG, PHYPLL_HSFREQRANGE(hsfreq->reg));
>
> return 0;
> --
> 2.7.4
>
1. https://lkml.org/lkml/2020/5/29/1038
--
Regards,
Niklas Söderlund
gt;
> This patch invalidates the pipeline by adding a check if given vin input
> format can be converted to supported output pixel format.
>
> Signed-off-by: Lad Prabhakar
Reviewed-by: Niklas Söderlund
> ---
> drivers/media/platform/rcar-vin/rcar-dma.c | 6 +-
> drive
Hi Geert,
Thanks for your work.
On 2020-05-28 15:28:53 +0200, Geert Uytterhoeven wrote:
> Convert the Renesas RZ/A1 Interrupt Controller Device Tree binding
> documentation to json-schema.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> Val
Hi Geert,
Thanks for your work.
On 2020-05-19 10:11:01 +0200, Geert Uytterhoeven wrote:
> Document Device Tree bindings for the Renesas EMMA Mobile System Timer.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> .../bindings/timer/renesas,em-sti.y
273 },
> > + { .reg = 0x33, .max = 275 },
> > + { .reg = 0x04, .max = 301 },
> > + { .reg = 0x14, .max = 328 },
> > + { .reg = 0x05, .max = 354 },
> > + { .reg = 0x15, .max = 393 },
> > + { .reg = 0x25, .max = 446 },
> > + { .reg = 0x06, .max = 498 },
> > + { .reg = 0x16, .max = 551 },
> > + { .reg = 0x07, .max = 603 },
> > + { .reg = 0x17, .max = 656 },
> > + { .reg = 0x08, .max = 708 },
> > + { .reg = 0x18, .max = 761 },
> > + { .reg = 0x09, .max = 813 },
> > + { .reg = 0x19, .max = 866 },
> > + { .reg = 0x29, .max = 918 },
> > + { .reg = 0x39, .max = 971 },
> > + { .reg = 0x0a, .max = 1023 },
> > + { .reg = 0x1a, .max = 1076 },
> > + { .reg = 0x2a, .max = 1128 },
> > + { .reg = 0x3a, .max = 1181 },
> > + { .reg = 0x0b, .max = 1233 },
> > + { .reg = 0x1b, .max = 1286 },
> > + { .reg = 0x2b, .max = 1338 },
> > + { .reg = 0x3b, .max = 1391 },
> > + { .reg = 0x0c, .max = 1443 },
> > + { .reg = 0x1c, .max = 1496 },
> > + { .reg = 0x2c, .max = 1500 },
> > + { .reg = 0x3c, .max = 1500 },
> > { /* sentinel */ },
> > };
> >
> > @@ -432,11 +432,11 @@ static int rcsi2_set_phypll(struct rcar_csi2 *priv,
> > unsigned int mbps)
> > {
> > const struct rcsi2_mbps_reg *hsfreq;
> >
> > - for (hsfreq = priv->info->hsfreqrange; hsfreq->mbps != 0; hsfreq++)
> > - if (hsfreq->mbps >= mbps)
> > + for (hsfreq = priv->info->hsfreqrange; hsfreq->max != 0; hsfreq++)
> > + if (hsfreq->max >= mbps)
> > break;
> >
> > - if (!hsfreq->mbps) {
> > + if (!hsfreq->max) {
> > dev_err(priv->dev, "Unsupported PHY speed (%u Mbps)", mbps);
> > return -ERANGE;
> > }
> > @@ -907,11 +907,11 @@ static int rcsi2_phtw_write_mbps(struct rcar_csi2
> > *priv, unsigned int mbps,
> > {
> > const struct rcsi2_mbps_reg *value;
> >
> > - for (value = values; value->mbps; value++)
> > - if (value->mbps >= mbps)
> > + for (value = values; value->max; value++)
> > + if (value->max >= mbps)
> > break;
> >
> > - if (!value->mbps) {
> > + if (!value->max) {
> > dev_err(priv->dev, "Unsupported PHY speed (%u Mbps)", mbps);
> > return -ERANGE;
> > }
> > --
> > 2.7.4
> >
>
> --
> Best Regards,
> Michael
--
Regards,
Niklas Söderlund
fc e606.pin-controller: IRQ index 0 not found
>
> Fix this by using the platform_irq_count() helper instead.
>
> Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to
> platform_get_irq*()")
> Signed-off-by: Geert Uytterhoeven
Nice change.
Reviewed-b
Hi Tim,
On 2019-09-27 12:26:40 -0700, Tim Harvey wrote:
> On Fri, Sep 27, 2019 at 12:04 PM Niklas Söderlund
> wrote:
> >
> > Hi Tim,
> >
> > Sorry for taking to so long to look at this.
> >
> > On 2019-09-23 15:04:47 -0700, Tim Harvey wrote:
> > &g
Hi Tim,
Sorry for taking to so long to look at this.
On 2019-09-23 15:04:47 -0700, Tim Harvey wrote:
> On Thu, Aug 29, 2019 at 7:29 AM Niklas Söderlund
> wrote:
> >
> > Hi,
> >
> > On 2019-08-29 13:43:49 +0200, Hans Verkuil wrote:
> > > Adding Niklas.
>
occinelle software.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 8 +---
> drivers/media/platform/rcar-vin/rcar-core.c| 7 +--
For rcar-vin:
Tested-by: Niklas Söderlund
> 2 files changed, 2 insertions(+
ADV7180_REG_VSYNC_FIELD_CTL_1,
> > + ADV7180_VSYNC_FIELD_CTL_1_NEWAV);
> > + /* Manually set V bit end position in NTSC mode */
> > + adv7180_write(state,
> > + ADV7180_REG_NTSC_V_BIT_END,
> > + ADV7180_NTSC_V_BIT_END_MANUAL_NVEND);
> > + }
> > else
> > adv7180_write(state,
> > ADV7180_REG_EXTENDED_OUTPUT_CONTROL,
> >
>
--
Regards,
Niklas Söderlund
Hi Geert,
Thanks for your work.
On 2019-07-31 14:50:53 +0200, Geert Uytterhoeven wrote:
> Use the devm_add_action_or_reset() helper instead of open-coding the
> same operations.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> drivers/thermal/r
tory and branch.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> Stephen: Can you please add my branch to linux-next, after Simon's
>branch, which may still receive fixes for v5.3?
>
>Thanks!
> ---
> MAINTAINERS | 4
>
s simplfied i2c driver registration.
>
> Signed-off-by: Kieran Bingham
Looks good,
Reviewed-by: Niklas Söderlund
> ---
> drivers/media/i2c/adv748x/adv748x-core.c | 13 ++---
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/media/i2c/ad
ocator, which I
> have pointed out numerous times and has never been addressed (and which
> explains why I didn't think the code was ready to be merged) is that the
> media_device contains operations that are based on having a single
> driver controlling the media device. A proper shared media device
> allocator needs to drop the concept of a single master for the media
> device, and thus needs to refactor those operations to allow any user of
> the media device to implement them (the .link_notify() operation is a
> prime example, and the recently added request operations will make this
> even more challenging - think of how this patch series would prevent
> vimc from properly implementing the request API). As long as these issue
> are not fixed I will be firmly opposed to spreading the usage of the
> media device allocator beyond what exists today.
>
> > Collapsing the drivers into one might be lot more difficult and complex
> > than solving this problem with Media Device Allocator API. This approach
> > has an added benefit of extending the API to be generic and not just for
> > USB.
>
> I've never disputed the fact that fixing a problem correctly is usually
> more work than hacking around it :-)
>
> > I looked at this as a good way to add generic API and have a great test
> > case for it. This patch series fixes the problem for the current vimc
> > architecture.
>
> NAK, for the reasons above. Please drop this series and fix the problem
> properly.
>
> --
> Regards,
>
> Laurent Pinchart
--
Regards,
Niklas Söderlund
Hi,
This patch breaks rcar-vin. I'm sorry I did not find out before it was
merged as a8fa55078a7784a9 ("media: v4l2-subdev: Verify arguments in
v4l2_subdev_call()").
The problem is that rcar-vin calls enum_mbus_code in its bound callback.
At this point call_enum_mbus_code() is invoked which t
was on the wrong
branch when looking up the sha1 for the fixes tag and used one from a
local development branch.
This is my mess, sorry about that. What can I do to help fix it?
--
Regards,
Niklas Söderlund
in his thread [1] where I tried to get to the bottom of the issue. My
conclusions there might be wrong due to the issues addressed in this
patch.
Michael: Did you have Steve's patch in your tree when testing this?
1. https://patchwork.kernel.org/patch/10904263/
--
Regards,
Niklas Söderlund
Hi Eugeniu,
On 2019-05-10 12:42:31 +0200, Eugeniu Rosca wrote:
> Hi Niklas,
>
> On Wed, May 08, 2019 at 01:54:03AM +0200, Niklas Söderlund wrote:
> > Hi Jiada,
> [..]
> > I really like this series, nice work.
> >
> > Tested-by: Niklas Söderlund
> > Re
issues.
I really like this series, nice work.
Tested-by: Niklas Söderlund
Reviewed-by: Niklas Söderlund
>
> ---
> v4: remove 'spinlock_t lock'
> add Fixes tag in ("thermal: rcar_gen3_thermal: fix interrupt type")
> fix typos in ("thermal: rcar_ge
ers/thermal/rcar_gen3_thermal.c | 41 +++--
> 1 file changed, 9 insertions(+), 32 deletions(-)
>
> --
> 2.19.2
>
--
Regards,
Niklas Söderlund
le for H3ES1.*, according
> to Hardware manual values 1 are "setting prohibited" for Gen3.
>
> Signed-off-by: Hoan Nguyen An
Reviewed-by: Niklas Söderlund
> ---
> drivers/thermal/rcar_gen3_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> di
mething? What scenario do you see where this can fail?
>
> strscpy(mdev->driver_name, KBUILD_MODNAME, sizeof(mdev->driver_name));
> strscpy(mdev->model, match->compatible, sizeof(mdev->model));
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
ined reference to
> `v4l2_fwnode_endpoint_parse'
>
> Fixes: 6a18865da8e3 ("media: i2c: adv748x: store number of CSI-2 lanes
> described in device tree")
> Signed-off-by: Arnd Bergmann
Reviewed-by: Niklas Söderlund
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1
nd DVB aren't streaming;
Nit-picking, as you are modifying the line anyhow I would s/;/./
With or without this changed,
Reviewed-by: Niklas Söderlund
>* - the last V4L2 file handler is closed.
> *
>* FIXME:
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
ies that are not streaming.
>
> Fixes: c0cc5aef31 ("media: rcar-vin: add link notify for Gen3")
>
> Signed-off-by: Steve Longerbeam
Reviewed-by: Niklas Söderlund
> ---
> Changes in v2:
> - bring back the media_device_for_each_entity() loop but check the
>
nk->sink->entity))
> return 0;
>
> - /* If any entity is in use don't allow link changes. */
> - media_device_for_each_entity(entity, &group->mdev)
> - if (entity->use_count)
> - return -EBUSY;
> -
> mutex_lock(&group->lock);
>
> /* Find the master VIN that controls the routes. */
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
Hi Fabrizio,
Thanks.
On 2018-12-13 20:24:12 +, Fabrizio Castro wrote:
> According to the RZ/G2 User's manual, RZ/G2E and R-Car E3 CSI-2
> blocks are identical, therefore use R-Car E3 definitions to add
> RZ/G2E support.
>
> Signed-off-by: Fabrizio Castro
Reviewed-
Hi Fabrizio,
Thanks for your patch.
On 2018-12-13 20:21:59 +, Fabrizio Castro wrote:
> Add the compatible string for RZ/G2E (a.k.a. R8A774C0) to the list
> of SoCs supported by rcar-vin driver.
>
> Signed-off-by: Fabrizio Castro
Reviewed-by: Niklas Söderlund
> ---
&
.compatible = "renesas,vin-r8a774c0",
> + .data = &rcar_info_r8a77990,
> + },
> + {
> .compatible = "renesas,vin-r8a7778",
> .data = &rcar_info_m1,
> },
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
Hi Fabrizio,
Thanks for your work.
On 2018-12-13 20:21:49 +, Fabrizio Castro wrote:
> Add the compatible string for RZ/G2E (a.k.a. R8A774C0) to the
> list of supported SoCs.
>
> Signed-off-by: Fabrizio Castro
Reviewed-by: Niklas Söderlund
> ---
> Documentation/devicet
cancel_delayed_work_sync(&priv->work);
> if (priv->chip->use_of_thermal)
> thermal_remove_hwmon_sysfs(priv->zone);
> else
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
ave a policy about describing hardware which can't be
used without flipping switches. I have no opinion on if we should do
that or not I leave that to others, but for the change itself.
Reviewed-by: Niklas Söderlund
I think it's good we describe it as it's part of the Draak b
ard switches SW-53 and SW-54 with CVBS input selected
> by the default switches configuration.
You are missing your SoB line :-)
Reviewed-by: Niklas Söderlund
> ---
> arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 36
> ++
> 1 file changed, 36 insert
Hi Jacopo,
On 2018-05-14 09:39:34 +0200, Jacopo Mondi wrote:
> Hi Niklas,
>
> On Sun, May 13, 2018 at 02:57:55PM +0200, Niklas Söderlund wrote:
> > Hi Jacopo,
> >
> > Thanks for your patch.
> >
> > On 2018-05-11 12:00:02 +0200, Jacopo Mondi wrote:
>
Hi again,
On 2018-05-14 11:49:00 +0200, Niklas Söderlund wrote:
> Hi Laurent,
>
> On 2018-05-14 05:49:41 +0300, Laurent Pinchart wrote:
>
> [snip]
>
> > > > +&vin4 {
> > > > + pinctrl-0 = <&vin4_pins>;
> > > > +
remote subdevice is not looking at its remote
endpoint for bus parameters not considered by the rcar-vin driver?
The thing is that the rcar-vin driver only looks at the remote endpoint
for these properties and ignores the on its local endpoint. Maybe some
v4l2 framework change is needed here to make sure the bus properties are
the same on both endpoints of a link. But I fear such a change would
break a lot of stuff.
--
Regards,
Niklas Söderlund
eal as the VIN driver don't use these properties so
no functional change should come of this but still a difference.
Over all I'm happy with this change but before I add my tag I would like
to understand why it differs from the Gen2 configuration for the adv7612
properties.
Also on a side not it is possible with hardware switches on the board
switch the VIN4 source to a completely different pipeline CVBS connector
-> adv7180 -> VIN4. But I think it's best we keep the HDMI as default as
this seems to be how the boards are shipped. But maybe mentioning this
in the commit message would not hurt if you end-up resending the patch.
> +
> + remote-endpoint = <&adv7612_out>;
> + };
> + };
> + };
> +};
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
Niklas,
>
> As you reviewed the rest of the series I'm wondering if you're planning
> to review this patch too.
Yes, I did not have schematics for D3 on hand when reviewing the rest of
the series. Will review it now that I do, thanks for the ping :-)
--
Regards,
Niklas Söderlund
Hi Jacopo,
Thanks for your work.
On 2018-05-11 12:00:01 +0200, Jacopo Mondi wrote:
> Describe VIN4 interface for R-Car D3 R8A77995 SoC.
>
> Signed-off-by: Jacopo Mondi
Acked-by: Niklas Söderlund
> ---
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++
>
Hi Jacopo,
Thanks for your work.
On 2018-05-11 12:00:00 +0200, Jacopo Mondi wrote:
> Add compatible string for R-Car D3 R8A7795 to list of SoCs supported by
> rcar-vin driver.
>
> Signed-off-by: Jacopo Mondi
Acked-by: Niklas Söderlund
> ---
> Documentation/devicet
of
> >> c18bb396d3d261eb ("Merge
> >> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net")
> >
> > I can confirm that with the patch bellow I can no longer produce the
> > problem. Thanks!
>
> Thanks for testing
> Do you mind if I add
>
Hi Vincent,
Thanks for all your help.
On 2018-04-26 12:31:33 +0200, Vincent Guittot wrote:
> Hi Niklas,
>
> Le Thursday 26 Apr 2018 à 00:56:03 (+0200), Niklas Söderlund a écrit :
> > Hi Vincent,
> >
> > Here are the result, sorry for the delay.
> >
> >
Hi there,
>
> While running static analysis on linux-next today a null pointer
> dereference issue was detected by CoverityScan. The following commit
> introduced the issue:
>
> commit 3bb4c3bc85bf77a76c921671800bde2e1bf82a88
> Author: Niklas Söderlund
> Date:
Hi Vincent,
On 2018-04-12 13:15:19 +0200, Niklas Söderlund wrote:
> Hi Vincent,
>
> Thanks for your feedback.
>
> On 2018-04-12 12:33:27 +0200, Vincent Guittot wrote:
> > Hi Niklas,
> >
> > On 12 April 2018 at 11:18, Niklas Söderlund
> > wrote:
> &
.7.4
>
>
> Thanks,
> Vincent
>
> > >
> > >
> > > Regards,
> > > Vincent
> > > >
> > > > 1. c18bb396d3d261eb ("Merge
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net"))
> > > > 2. 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")
> > > >
> > > > --
> > > > Regards,
> > > > Niklas Söderlund
> >
> > --
> > Regards,
> > Niklas Söderlund
--
Regards,
Niklas Söderlund
I'm using
arch/arm/configs/shmobile_defconfig for my tests.
--
Regards,
Niklas Söderlund
Hi Vincent,
Thanks for your feedback.
On 2018-04-12 12:33:27 +0200, Vincent Guittot wrote:
> Hi Niklas,
>
> On 12 April 2018 at 11:18, Niklas Söderlund
> wrote:
> > Hi Vincent,
> >
> > I have observed issues running on linus/master from a few days back [1].
> &
.org/pub/scm/linux/kernel/git/davem/net"))
2. 31e77c93e432dec7 ("sched/fair: Update blocked load when newly idle")
--
Regards,
Niklas Söderlund
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Niklas Söderlund
> ---
> To be queued in clk-renesas-for-v4.18.
>
> drivers/clk/renesas/rcar-gen2-cpg.c | 20
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/renesas/r
};
> };
>
> @@ -152,8 +179,8 @@
>
> ports {
> port@1 {
> - endpoint {
> - remote-endpoint = <&adv7511_in>;
> + lvds0_out: endpoint {
> + remote-endpoint = <&thc63lvd1024_in_0>;
> };
> };
> };
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
;dev = &pdev->dev;
> + platform_set_drvdata(pdev, thc63);
> +
> + ret = thc63_regulator_init(thc63);
> + if (ret)
> + return ret;
> +
> + ret = thc63_gpio_init(thc63);
> + if (ret)
> + return ret;
> +
>
Hi Jacopo,
Thanks for your patch,
On 2018-03-15 17:11:54 +0100, Jacopo Mondi wrote:
> Document Thine THC63LVD1024 LVDS decoder device tree bindings.
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Andrzej Hajda
Reviewed-by: Niklas Söderlund
> ---
> .../bindings/di
bus.
>
> Allow a device tree node to override the default addresses so that
> address conflicts with other devices on the same bus may be resolved at
> the board description level.
>
> Signed-off-by: Kieran Bingham
Reviewed-by: Niklas Söderlund
> ---
> driver
epresented on a single line.
>
> Define ADV748X_REGMAP_CONF for this purpose use it to create the tables.
>
> Signed-off-by: Kieran Bingham
Reviewed-by: Niklas Söderlund
>
> ---
> v2:
> - Remove unnecessary #undef
>
> drivers/media/i2c/adv748x/adv748x-core.c | 109
1 - 100 of 189 matches
Mail list logo
