Re: [PATCH] hwmon: (dell-smm) Add XPS 15 L502X to fan control blacklist

2021-01-27 Thread Pali Rohár
there's an existing Dell bug report that references > the original https://bugzilla.kernel.org/show_bug.cgi?id=195751 ??? I > could add my report there if someone has already informed Dell about > the other instances of the bug. > > Thanks > > > > Bob > > On Wed

Re: [PATCH] hwmon: (dell-smm) Add XPS 15 L502X to fan control blacklist

2021-01-27 Thread Pali Rohár
s > > > > > > Cheers > > > > > > > > > Bob > > > > > > On Tue, 26 Jan 2021 at 04:05, Tom Hebb wrote: > > > > > > > > On Mon, Jan 25, 2021 at 2:05 AM Pali Rohár wrote: > > > > > > > > &g

[PATCH] Documentation: arm: marvell: Update link to unrestricted Armada 38x Functional Spec

2021-01-26 Thread Pali Rohár
On Marvell website is documentation accessible without need to register or fill any other forms. Signed-off-by: Pali Rohár --- Documentation/arm/marvell.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/arm/marvell.rst b/Documentation/arm/marvell.rst index

Re: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2021-01-26 Thread Pali Rohár
On Tuesday 26 January 2021 04:27:37 Yoshihiro Shimoda wrote: > Hi Pali, > > > From: Pali Rohár, Sent: Monday, January 25, 2021 11:20 PM > > On Friday 15 January 2021 15:32:30 Mathias Nyman wrote: > > > On 14.1.2021 1.20, Pali Rohár wrote: > > > > On Thursd

[PATCH v4 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

2021-01-25 Thread Pali Rohár
06 00 00 55 42 4e 54 XX XX XX XX XX XX XX XX.?..UBNT 50: 20 20 20 20 31 34 30 31 32 33 20 20 60 80 02 41140123 `??A Signed-off-by: Pali Rohár --- Changes in v4: * Rewritten the commit message by Marek's suggestion Changes in v3: * no change Changes in v2: * add this m

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-25 Thread Pali Rohár
On Monday 18 January 2021 10:34:35 Pali Rohár wrote: > On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > > This is a third version of patches which add workarounds for > > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > > > Russel's PATCH v2

Re: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2021-01-25 Thread Pali Rohár
On Friday 15 January 2021 15:32:30 Mathias Nyman wrote: > On 14.1.2021 1.20, Pali Rohár wrote: > > On Thursday 24 December 2020 05:59:05 Peter Chen wrote: > >> On 20-12-23 17:18:47, Pali Rohár wrote: > >>> Currently init_quirk callbacks for xhci platform drivers ar

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-25 Thread Pali Rohár
On Monday 25 January 2021 14:42:21 Russell King - ARM Linux admin wrote: > On Mon, Jan 25, 2021 at 03:23:01PM +0100, Pali Rohár wrote: > > On Monday 25 January 2021 14:16:44 Russell King - ARM Linux admin wrote: > > > On Mon, Jan 25, 2021 at 03:09:57PM +0100, Pali Rohár wrote: &g

Re: [PATCH] hwmon: (dell-smm) Add XPS 15 L502X to fan control blacklist

2021-01-25 Thread Pali Rohár
On Monday 25 January 2021 12:19:38 Guenter Roeck wrote: > On Mon, Jan 25, 2021 at 11:05:40AM +0100, Pali Rohár wrote: > > On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote: > > > It has been reported[0] that the Dell XPS 15 L502X exhibits similar > > > freezing beha

[PATCH v4 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-25 Thread Pali Rohár
This is fourth version of patches which add workarounds for RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. The only change since third version is modification of commit messages. Pali Rohár (2): net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips net: sfp: add mode

[PATCH v4 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-25 Thread Pali Rohár
fp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround") Co-developed-by: Russell King Signed-off-by: Russell King Signed-off-by: Pali Rohár --- Changes in v4: * Rewritten the commit message by Marek's suggestion Changes in v3: * Do not break longer info messages * Do not read memory a

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-25 Thread Pali Rohár
On Monday 25 January 2021 14:16:44 Russell King - ARM Linux admin wrote: > On Mon, Jan 25, 2021 at 03:09:57PM +0100, Pali Rohár wrote: > > On Monday 18 January 2021 10:34:35 Pali Rohár wrote: > > > On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > > > > This

[PATCH] Documentation: arm: marvell: Fix dead link to Armada 37xx Product Brief

2021-01-25 Thread Pali Rohár
Signed-off-by: Pali Rohár --- Documentation/arm/marvell.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/arm/marvell.rst b/Documentation/arm/marvell.rst index b16e6f7e8dbe..fa22a72d4391 100644 --- a/Documentation/arm/marvell.rst +++ b/Documentation/arm

Re: [PATCH] hwmon: (dell-smm) Add XPS 15 L502X to fan control blacklist

2021-01-25 Thread Pali Rohár
On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote: > It has been reported[0] that the Dell XPS 15 L502X exhibits similar > freezing behavior to the other systems[1] on this blacklist. The issue > was exposed by a prior change of mine to automatically load > dell_smm_hwmon on a wider set of XPS

[PATCH 1/2] Documentation: arm: Fix marvell file name

2021-01-21 Thread Pali Rohár
Signed-off-by: Pali Rohár --- Documentation/arm/index.rst | 2 +- Documentation/arm/{marvel.rst => marvell.rst} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename Documentation/arm/{marvel.rst => marvell.rst} (100%) diff --git a/Documentation/arm/index

[PATCH 2/2] Documentation: arm: marvell: Add link to public Armada 37xx Hardware Spec

2021-01-21 Thread Pali Rohár
Signed-off-by: Pali Rohár --- Documentation/arm/marvell.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/arm/marvell.rst b/Documentation/arm/marvell.rst index 16ab2eb085b8..b16e6f7e8dbe 100644 --- a/Documentation/arm/marvell.rst +++ b/Documentation/arm/marvell.rst

[PATCH] doc: networking: ip-sysctl: Document conf/all/disable_ipv6 and conf/default/disable_ipv6

2021-01-21 Thread Pali Rohár
This patch adds documentation for sysctl conf/all/disable_ipv6 and conf/default/disable_ipv6 settings which is currently missing. Signed-off-by: Pali Rohár --- Documentation/networking/ip-sysctl.rst | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/networking/ip

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-18 Thread Pali Rohár
On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > This is a third version of patches which add workarounds for > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > Russel's PATCH v2 2/3 was dropped from this patch series as > it is being handled separately

[PATCH] arm64: dts: marvell: armada-37xx: Add SATA comphy into main armada-37xx.dtsi file

2021-01-18 Thread Pali Rohár
SATA on A3720 SOC can use only comphy2, so move this definition from board specific DTS file armada-3720-espressobin.dtsi into main A3720 SOC file armada-37xx.dtsi. Signed-off-by: Pali Rohár --- arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 -- arch/arm64/boot/dts/marvell/armada

[PATCH mvebu v2 05/10] clk: mvebu: armada-37xx-periph: Fix switching CPU freq from 250 Mhz to 1 GHz

2021-01-14 Thread Pali Rohár
2 (250 MHz) to L0 (1 GHz) causes a crash. When base CPU frequency is just 800 MHz no crashed were observed during switch from L2 to L0. Signed-off-by: Pali Rohár Fixes: 2089dc33ea0e ("clk: mvebu: armada-37xx-periph: add DVFS support for cpu clocks") Cc: sta...@vger.kernel.org # 61c40

[PATCH mvebu v2 04/10] cpufreq: armada-37xx: Fix the AVS value for loads L0 and L1

2021-01-14 Thread Pali Rohár
forum [2]. [1] - https://github.com/MarvellEmbeddedProcessors/linux-marvell/commit/dc33b62c90696afb6adc7dbcc4ebbd48bedec269 [2] - https://forum.armbian.com/topic/10429-how-to-make-espressobin-v7-stable/ Signed-off-by: Pali Rohár Fixes: 1c3528232f4b ("cpufreq: armada-37xx: Add AVS support

[PATCH mvebu v2 10/10] cpufreq: armada-37xx: Fix module unloading

2021-01-14 Thread Pali Rohár
This driver is missing module_exit hook. Add proper driver exit function which unregisters the platform device and cleans up the data. Signed-off-by: Pali Rohár --- drivers/cpufreq/armada-37xx-cpufreq.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers

[PATCH mvebu v2 08/10] cpufreq: armada-37xx: Fix determining base CPU frequency

2021-01-14 Thread Pali Rohár
ation for opp"), but only for calculating CPU frequency for opp. Fix this also for determination of base CPU frequency. Signed-off-by: Pali Rohár Fixes: 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx") Cc: sta...@vger.kernel.org # 8db82563451f ("cpufreq: armada-37xx: f

[PATCH mvebu v2 09/10] cpufreq: armada-37xx: Remove cur_frequency variable

2021-01-14 Thread Pali Rohár
Variable cur_frequency in armada37xx_cpufreq_driver_init() is unused. Signed-off-by: Pali Rohár --- drivers/cpufreq/armada-37xx-cpufreq.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c

[PATCH mvebu v2 06/10] clk: mvebu: armada-37xx-periph: Fix workaround for switching from L1 to L0

2021-01-14 Thread Pali Rohár
reproduced with userspace governor. In most cases it causes CPU to crash. This change fixes the above issue and ensures that the CPU always stays in L1 for at least 20ms when switching from any state to L0. Signed-off-by: Marek Behún Signed-off-by: Pali Rohár Fixes: 61c40f35f5cd ("clk:

[PATCH mvebu v2 07/10] cpufreq: armada-37xx: Fix driver cleanup when registration failed

2021-01-14 Thread Pali Rohár
tion fails. This fixes the issue by using the same frequency in both calls. Signed-off-by: Pali Rohár Fixes: 8db82563451f ("cpufreq: armada-37xx: fix frequency calculation for opp") Cc: sta...@vger.kernel.org --- drivers/cpufreq/armada-37xx-cpufreq.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH mvebu v2 03/10] clk: mvebu: armada-37xx-periph: remove .set_parent method for CPU PM clock

2021-01-14 Thread Pali Rohár
From: Marek Behún Remove the .set_parent method in clk_pm_cpu_ops. This method was supposed to be needed by the armada-37xx-cpufreq driver, but was never actually called due to wrong assumptions in the cpufreq driver. After this was fixed in the cpufreq driver, this method is not needed anymore.

[PATCH mvebu v2 02/10] cpufreq: armada-37xx: Fix setting TBG parent for load levels

2021-01-14 Thread Pali Rohár
From: Marek Behún With CPU frequency determining software [1] we have discovered that after this driver does one CPU frequency change, the base frequency of the CPU is set to the frequency of TBG-A-P clock, instead of the TBG that is parent to the CPU. This can be reproduced on EspressoBIN and T

[PATCH mvebu v2 01/10] arm64: dts: marvell: armada-37xx: add syscon compatible to NB clk node

2021-01-14 Thread Pali Rohár
From: Marek Behún Add "syscon" compatible to the North Bridge clocks node to allow the cpufreq driver to access these registers via syscon API. This is needed for a fix of cpufreq driver. Signed-off-by: Marek Behún Fixes: e8d66e7927b2 ("arm64: dts: marvell: armada-37xx: add nodes...") Cc: sta.

[PATCH mvebu v2 00/10] Armada 37xx: Fix cpufreq changing base CPU speed to 800 MHz from 1000 MHz

2021-01-14 Thread Pali Rohár
atible to NB clk node cpufreq: armada-37xx: Fix setting TBG parent for load levels clk: mvebu: armada-37xx-periph: remove .set_parent method for CPU PM clock Pali Rohár (7): cpufreq: armada-37xx: Fix the AVS value for loads L0 and L1 clk: mvebu: armada-37xx-periph: Fix switching CPU

Re: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2021-01-13 Thread Pali Rohár
On Thursday 24 December 2020 05:59:05 Peter Chen wrote: > On 20-12-23 17:18:47, Pali Rohár wrote: > > Currently init_quirk callbacks for xhci platform drivers are called > > xhci_plat_setup() function which is called after chip reset completes. > > It happens in the midd

Re: [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-12 Thread Pali Rohár
On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > This is a third version of patches which add workarounds for > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > Russel's PATCH v2 2/3 was dropped from this patch series as > it is being handled separately

[PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-11 Thread Pali Rohár
This is a third version of patches which add workarounds for RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. Russel's PATCH v2 2/3 was dropped from this patch series as it is being handled separately. Pali Rohár (2): net: sfp: add workaround for Realtek RTL8672 and RTL9601C

[PATCH v3 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

2021-01-11 Thread Pali Rohár
20 05 1e 00 36NT 4 ??.6 40: 00 06 00 00 55 42 4e 54 XX XX XX XX XX XX XX XX.?..UBNT 50: 20 20 20 20 31 34 30 31 32 33 20 20 60 80 02 41140123 `??A Signed-off-by: Pali Rohár --- Changes in v2: * add this module also into sfp_module_supported() function Changes in v3

[PATCH v3 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-11 Thread Pali Rohár
2a4a ("net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround") Co-developed-by: Russell King Signed-off-by: Russell King Signed-off-by: Pali Rohár --- Changes in v2: * Add explanation why also for second address is used one byte read op * Skip hwmon registration when eep

Re: [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2021-01-09 Thread Pali Rohár
On Saturday 09 January 2021 23:19:54 Russell King - ARM Linux admin wrote: > On Sat, Jan 09, 2021 at 08:14:47PM +0100, Pali Rohár wrote: > > On Saturday 09 January 2021 15:46:01 Russell King - ARM Linux admin wrote: > > > On Thu, Jan 07, 2021 at 05:54:28PM +0100, Andrew Lunn wro

Re: [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2021-01-09 Thread Pali Rohár
On Saturday 09 January 2021 15:46:01 Russell King - ARM Linux admin wrote: > On Thu, Jan 07, 2021 at 05:54:28PM +0100, Andrew Lunn wrote: > > On Wed, Jan 06, 2021 at 04:37:48PM +0100, Pali Rohár wrote: > > > From: Russell King > > > > > > Some GPON SFP mo

Re: [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-07 Thread Pali Rohár
On Thursday 07 January 2021 21:21:16 Marek Behún wrote: > On Thu, 7 Jan 2021 19:45:49 + > Russell King - ARM Linux admin wrote: > > > I think you're not reading the code very well. It checks for bytes at > > offset 1..blocksize-1, blocksize+1..2*blocksize-1, etc are zero. It > > does _not_ ch

Re: [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-07 Thread Pali Rohár
On Thursday 07 January 2021 17:40:06 Russell King - ARM Linux admin wrote: > On Thu, Jan 07, 2021 at 06:19:23PM +0100, Andrew Lunn wrote: > > Did we loose the comment: > > > > /* Some modules (Nokia 3FE46541AA) lock up if byte 0x51 is read as a > > * single read. Switch back to reading 16 byte bl

Re: [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-07 Thread Pali Rohár
On Thursday 07 January 2021 18:19:23 Andrew Lunn wrote: > > + if (sfp->i2c_block_size < 2) { > > + dev_info(sfp->dev, "skipping hwmon device registration " > > + "due to broken EEPROM\n"); > > + dev_info(sfp->dev, "diagnostic EEPROM area cannot be

Re: [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-07 Thread Pali Rohár
On Thursday 07 January 2021 03:02:36 Andrew Lunn wrote: > > + /* hwmon interface needs to access 16bit registers in atomic way to > > +* guarantee coherency of the diagnostic monitoring data. If it is not > > +* possible to guarantee coherency because EEPROM is broken in such way > > +

[PATCH v2 3/3] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

2021-01-06 Thread Pali Rohár
20 05 1e 00 36NT 4 ??.6 40: 00 06 00 00 55 42 4e 54 XX XX XX XX XX XX XX XX.?..UBNT 50: 20 20 20 20 31 34 30 31 32 33 20 20 60 80 02 41140123 `??A Signed-off-by: Pali Rohár --- Changes in v2: * add this module also into sfp_module_supported() function --- drivers

[PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2021-01-06 Thread Pali Rohár
module Ubiquiti U-Fiber Instant. Signed-off-by: Russell King Signed-off-by: Pali Rohár --- Changes in v2: * Fix author/signed-off-by lines --- drivers/net/phy/sfp.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/drivers/net/phy/sfp.c b

[PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-06 Thread Pali Rohár
2a4a ("net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround") Co-developed-by: Russell King Signed-off-by: Russell King Signed-off-by: Pali Rohár --- Changes in v2: * Add explanation why also for second address is used one byte read op * Skip hwmon registration when eep

[PATCH v2 0/3] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2021-01-06 Thread Pali Rohár
EEPROM is totally broken and does not support reading 16bit values automically. Pali Rohár (2): net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Russell King (1): net: sfp: assume that LOS is not implemented if

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-06 Thread Pali Rohár
6, 2021 at 03:55:32PM +0100, Pali Rohár wrote: > > > > On my tested CarlitoxxPro module is: > > > > > > > > Option values : 0x00 0x1c > > > > Option

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-06 Thread Pali Rohár
On Sunday 03 January 2021 03:41:32 Pali Rohár wrote: > Hello! > > On Sunday 03 January 2021 03:25:23 Thomas Schreiber wrote: > > Hi Pali, > > I have a CarlitoxxPro module and I reported an issue about RX_LOS pin > > to the manufacturer. > > It looks to me that

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-02 Thread Pali Rohár
. V > Module voltage low alarm threshold: 0. V > Module voltage high warning threshold : 0. V > Module voltage low warning threshold : 0. V > Laser rx power high alarm threshold : 0.1536 mW / -8.14 dBm > Laser rx power low alarm threshold

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-01 Thread Pali Rohár
On Thursday 31 December 2020 18:13:38 Andrew Lunn wrote: > > > Looking at sfp_module_info(), adding a check for i2c_block_size < 2 > > > when determining what length to return. ethtool should do the right > > > thing, know that the second page has not been returned to user space. > > > > But if we

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-31 Thread Pali Rohár
On Thursday 31 December 2020 16:30:33 Andrew Lunn wrote: > On Thu, Dec 31, 2020 at 01:14:10PM +0100, Pali Rohár wrote: > > On Wednesday 30 December 2020 19:09:58 Russell King - ARM Linux admin wrote: > > > On Wed, Dec 30, 2020 at 06:43:07PM +0100, Pali Rohár wrote: > > >

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-31 Thread Pali Rohár
On Thursday 31 December 2020 16:09:25 Andrew Lunn wrote: > On Thu, Dec 31, 2020 at 01:14:10PM +0100, Pali Rohár wrote: > > On Wednesday 30 December 2020 19:09:58 Russell King - ARM Linux admin wrote: > > > On Wed, Dec 30, 2020 at 06:43:07PM +0100, Pali Rohár wrote: > > >

Re: [PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF

2020-12-31 Thread Pali Rohár
On Wednesday 30 December 2020 19:12:40 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 06:27:07PM +0100, Marek Behún wrote: > > On Wed, 30 Dec 2020 18:06:52 +0100 > > Pali Rohár wrote: > > > > > if (!sfp->type->module_supported(&id) &a

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-31 Thread Pali Rohár
On Wednesday 30 December 2020 19:09:58 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 06:43:07PM +0100, Pali Rohár wrote: > > On Wednesday 30 December 2020 18:13:15 Andrew Lunn wrote: > > > Hi Pali > > > > > > I have to agree with Russell here

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-30 Thread Pali Rohár
On Wednesday 30 December 2020 18:13:15 Andrew Lunn wrote: > On Wed, Dec 30, 2020 at 05:05:46PM +, Russell King - ARM Linux admin > wrote: > > On Wed, Dec 30, 2020 at 05:56:34PM +0100, Pali Rohár wrote: > > > This change is really required for those Realtek chips. I tho

Re: [PATCH 3/4] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2020-12-30 Thread Pali Rohár
On Wednesday 30 December 2020 18:17:41 Andrew Lunn wrote: > On Wed, Dec 30, 2020 at 05:06:23PM +, Russell King - ARM Linux admin > wrote: > > On Wed, Dec 30, 2020 at 05:57:58PM +0100, Pali Rohár wrote: > > > On Wednesday 30 December 2020 16:13:10 Russell King - ARM Lin

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-30 Thread Pali Rohár
On Wednesday 30 December 2020 17:05:46 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 05:56:34PM +0100, Pali Rohár wrote: > > This change is really required for those Realtek chips. I thought that > > it is obvious that from *both* addresses 0x50 and 0x51 can be re

Re: [PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF

2020-12-30 Thread Pali Rohár
On Wednesday 30 December 2020 16:11:51 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 04:47:53PM +0100, Pali Rohár wrote: > > Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set SFF phys_id > > in their EEPROM. Kernel SFP subsystem currently does n

Re: [PATCH 3/4] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2020-12-30 Thread Pali Rohár
On Wednesday 30 December 2020 16:13:10 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 04:47:54PM +0100, Pali Rohár wrote: > > Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set both > > SFP_OPTIONS_LOS_INVERTED and SFP_OPTIONS_LOS_NORMAL bits

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-30 Thread Pali Rohár
On Wednesday 30 December 2020 16:10:37 Russell King - ARM Linux admin wrote: > On Wed, Dec 30, 2020 at 04:47:52PM +0100, Pali Rohár wrote: > > Workaround for GPON SFP modules based on VSOL V2801F brand was added in > > commit 0d035bed2a4a ("net: sfp: VSOL V2801F / Carli

[PATCH 4/4] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

2020-12-30 Thread Pali Rohár
29 55 46 2d 49 4e 53 54 41.??)UF-INSTA 30: 4e 54 20 20 20 20 20 20 34 20 20 20 05 1e 00 36NT 4 ??.6 40: 00 06 00 00 55 42 4e 54 XX XX XX XX XX XX XX XX.?..UBNT 50: 20 20 20 20 31 34 30 31 32 33 20 20 60 80 02 41140123 `??A Signed-off-by: Pali Rohár

[PATCH 3/4] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2020-12-30 Thread Pali Rohár
Instant. Co-developed-by: Russell King Signed-off-by: Russell King Signed-off-by: Pali Rohár --- drivers/net/phy/sfp.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 73f3ecf15260

[PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-30 Thread Pali Rohár
d RTL9601C chips. Fixes: 0d035bed2a4a ("net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround") Co-developed-by: Russell King Signed-off-by: Russell King Signed-off-by: Pali Rohár --- drivers/net/phy/sfp.c | 78 --- 1 file changed,

[PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF

2020-12-30 Thread Pali Rohár
Ubiquiti U-Fiber Instant is recognized. Signed-off-by: Pali Rohár --- drivers/net/phy/sfp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 490e78a72dd6..73f3ecf15260 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy

[PATCH 0/4] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2020-12-30 Thread Pali Rohár
available in my git branch sfp-rtl8672: https://git.kernel.org/pub/scm/linux/kernel/git/pali/linux.git/log/?h=sfp-rtl8672 Pali Rohár (4): net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips net: sfp: allow to use also SFP modules which are detected as SFF net: sfp: assume that LOS

Re: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-28 Thread Pali Rohár
Hello! On Monday 28 December 2020 13:11:49 Marek Behun wrote: > Hi Pali and Miquel, > > On Wed, 23 Dec 2020 17:24:03 +0100 > Pali Rohár wrote: > > > int xhci_mvebu_a3700_init_quirk(struct usb_hcd *hcd) > > { > > struct xhci_hcd *xhci = hcd_to_xhci(hcd);

Re: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-24 Thread Pali Rohár
On Thursday 24 December 2020 14:24:01 Pali Rohár wrote: > On Thursday 24 December 2020 13:15:21 Peter Chen wrote: > > > > > > > + /* Old bindings miss the PHY handle */ > > > > > + phy = of_phy_get(dev->of_node, "usb3-phy&qu

Re: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-24 Thread Pali Rohár
On Thursday 24 December 2020 13:15:21 Peter Chen wrote: > > > > > + /* Old bindings miss the PHY handle */ > > > > + phy = of_phy_get(dev->of_node, "usb3-phy"); > > > > + if (IS_ERR(phy) && PTR_ERR(phy) == -EPROBE_DEFER) > > > > + return -EPROBE_DEFER; > > > > > >

Re: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-24 Thread Pali Rohár
On Thursday 24 December 2020 05:54:55 Peter Chen wrote: > On 20-12-23 17:24:03, Pali Rohár wrote: > > Older ATF does not provide SMC call for USB 3.0 phy power on functionality > > and therefore initialization of xhci-hcd is failing when older version of > > ATF is used. In t

[PATCH] serial: mvebu-uart: fix tx lost characters at power off

2020-12-23 Thread Pali Rohár
for TX_EMP. When rebooting A3720 platform without this patch on UART is print only: [ 42.699� And with this patch on UART is full output: [ 39.530216] reboot: Restarting system Fixes: c685af1108d7 ("serial: mvebu-uart: fix tx lost characters") Signed-off-by: Pali Rohár --- driv

[PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-23 Thread Pali Rohár
s: bd3d25b07342 ("arm64: dts: marvell: armada-37xx: link USB hosts with their PHYs") Signed-off-by: Pali Rohár Cc: # 5.1+: ea17a0f153af: phy: marvell: comphy: Convert internal SMCC firmware return codes to errno Cc: # 5.1+: f768e718911e: usb: host: xhci-plat: add priv quirk for skip

[PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2020-12-23 Thread Pali Rohár
his member is set. This patch fixes implementation of the XHCI_SKIP_PHY_INIT quirk by calling init_quirk callbacks (via xhci_priv_init_quirk()) prior checking if XHCI_SKIP_PHY_INIT is set. Also checking if either xhci->quirks or priv->quirks contains this XHCI_SKIP_PHY_INIT quirk. Signed-off

Re: [PATCH] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2020-12-22 Thread Pali Rohár
On Wednesday 23 December 2020 01:02:43 Peter Chen wrote: > On 20-12-22 14:30:51, Pali Rohár wrote: > > On Tuesday 22 December 2020 10:23:27 Pali Rohár wrote: > > > On Tuesday 22 December 2020 02:14:45 Peter Chen wrote: > > > > On 20-12-21 16:09:03, Pali Rohár wrote:

Re: [PATCH] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2020-12-22 Thread Pali Rohár
On Tuesday 22 December 2020 10:23:27 Pali Rohár wrote: > On Tuesday 22 December 2020 02:14:45 Peter Chen wrote: > > On 20-12-21 16:09:03, Pali Rohár wrote: > > > Currently init_quirk callbacks for xhci platform drivers are called > > > xhci_plat_setup() function which

Re: [PATCH v2] power: supply: bq27xxx: Supporrt CHARGE_NOW for bq27z561/bq28z610/bq34z100

2020-12-22 Thread Pali Rohár
On Tuesday 22 December 2020 19:07:20 Hermes Zhang wrote: > From: Hermes Zhang > > The CHARGE_NOW is map to REG_NAC for all the gauge chips beofre. But for > some chips (e.g. bq27z561) which doesn't have the REG_NAC, we use REG_RC > (remaining capacity) for CHARGE_NOW. > > Signed-off-by: Hermes Z

Re: [PATCH] power: supply: bq27xxx: Supporrt CHARGE_NOW for bq27z561/bq28z610/bq34z100

2020-12-22 Thread Pali Rohár
On Tuesday 22 December 2020 03:44:09 Hermes Zhang wrote: > On 12/18/20 5:42 PM, Pali Rohár wrote: > > On Thursday 17 December 2020 12:03:24 Hermes Zhang wrote: > >> Hi Pali, > >> > >> From the TI spec (e.g. > >> https://www.ti.com/lit/ug/tidu077/ti

Re: [PATCH] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2020-12-22 Thread Pali Rohár
On Tuesday 22 December 2020 02:14:45 Peter Chen wrote: > On 20-12-21 16:09:03, Pali Rohár wrote: > > Currently init_quirk callbacks for xhci platform drivers are called > > xhci_plat_setup() function which is called after chip reset completes. > > It happens in the midd

[PATCH] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2020-12-21 Thread Pali Rohár
his member is set. This patch fixes implementation of the XHCI_SKIP_PHY_INIT quirk by calling init_quirk callbacks (via xhci_priv_init_quirk()) prior checking if XHCI_SKIP_PHY_INIT is set. Fixes: f768e718911e0 ("usb: host: xhci-plat: add priv quirk for skip PHY initialization") Signed

Re: [PATCH 0/3] mwifiex: disable ps_mode by default for stability

2020-12-20 Thread Pali Rohár
Hello! Please CC me in future for mwifiex discussion :-) On Wednesday 28 October 2020 23:24:30 Tsuchiya Yuto wrote: > Hello all, > > On Microsoft Surface devices (PCIe-88W8897), we are observing stability > issues when ps_mode (IEEE power_save) is enabled, then eventually causes > firmware crash

Re: [PATCH] clk: mvebu: a3700: fix the XTAL MODE pin to MPP1_9

2020-12-20 Thread Pali Rohár
On Saturday 19 December 2020 15:51:30 Stephen Boyd wrote: > Quoting Pali Rohár (2020-11-06 02:00:39) > > From: Terry Zhou > > > > There is an error in the current code that the XTAL MODE > > pin was set to NB MPP1_31 which should be NB MPP1_9. > > The latch re

Re: [PATCH] power: supply: bq27xxx: Supporrt CHARGE_NOW for bq27z561/bq28z610/bq34z100

2020-12-18 Thread Pali Rohár
t every chip has NAC or RC, but not both? > Best Regards, > Hermes > > -Original Message- > From: Pali Rohár > Sent: 2020年12月17日 19:57 > To: Hermes Zhang > Cc: Dan Murphy ; Sebastian Reichel ; kernel > ; Hermes Zhang ; > linux...@vger.kernel.org; linux-ke

Re: [PATCH] power: supply: bq27xxx: Supporrt CHARGE_NOW for bq27z561/bq28z610/bq34z100

2020-12-17 Thread Pali Rohár
On Thursday 17 December 2020 19:47:37 Hermes Zhang wrote: > From: Hermes Zhang > > The CHARGE_NOW is map to REG_NAC for all the gauge chips beofre. But for > some chips (e.g. bq27z561) which doesn't have the REG_NAC, we use REG_RC > (remaining capacity) for CHARGE_NOW. Hello! What is the differe

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-12-09 Thread Pali Rohár
On Wednesday 09 December 2020 16:19:39 Trent Piepho wrote: > On Tuesday, December 8, 2020 5:13:36 PM PST Pali Rohár wrote: > > On Tuesday 08 December 2020 15:04:29 Trent Piepho wrote: > > > Does this also give userspace a clear point at which to determine MTU > setting, &

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-12-08 Thread Pali Rohár
On Tuesday 08 December 2020 15:04:29 Trent Piepho wrote: > On Wednesday, September 23, 2020 3:22:15 AM PST Pali Rohár wrote: > > On Monday 14 September 2020 20:18:27 Joseph Hwang wrote: > > > On Thu, Sep 10, 2020 at 4:18 PM Pali Rohár wrote: > > > > And this p

Re: [PATCH v5] arm64: dts: marvell: add DT for ESPRESSObin-Ultra

2020-12-03 Thread Pali Rohár
On Sunday 29 November 2020 12:17:27 Gregory CLEMENT wrote: > Hi Vladimir, > > > This adds support for ESPRESSObin-Ultra from Globalscale. > > > > Specifications are similar to the base ESPRESSObin board, with main > > difference being being WAN port with PoE capability and 2 additional > > ethern

[PATCH v2] PCI: aardvark: Update comment about disabling link training

2020-12-02 Thread Pali Rohár
It is not HW bug or workaround for some cards but it is requirement by PCI Express spec. After fundamental reset is needed 100ms delay prior enabling link training. So update comment in code to reflect this requirement. Signed-off-by: Pali Rohár --- Changes in v2: * Add reference to the PCI

Re: [PATCH] PCI: aardvark: Update comment about disabling link training

2020-12-02 Thread Pali Rohár
On Monday 30 November 2020 10:52:00 Lorenzo Pieralisi wrote: > On Mon, Nov 30, 2020 at 12:17:41AM +0100, Pali Rohár wrote: > > On Sunday 11 October 2020 19:21:49 Pali Rohár wrote: > > > On Thursday 24 September 2020 17:22:32 Pali Rohár wrote: > > > > On Thursday 24

Re: [PATCH] clk: mvebu: a3700: fix the XTAL MODE pin to MPP1_9

2020-12-01 Thread Pali Rohár
PING! I would like to remind this patch. On Friday 13 November 2020 11:19:19 Pali Rohár wrote: > Michael, Stephen: Could you take this clk patch? > > On Friday 06 November 2020 11:51:18 Marek Behún wrote: > > Also, this is how A3720 WTMI code and ATF determines XTAL clock rate. &g

Re: [PATCH] PCI: aardvark: Update comment about disabling link training

2020-11-29 Thread Pali Rohár
On Sunday 11 October 2020 19:21:49 Pali Rohár wrote: > On Thursday 24 September 2020 17:22:32 Pali Rohár wrote: > > On Thursday 24 September 2020 10:11:06 Bjorn Helgaas wrote: > > > On Thu, Sep 24, 2020 at 10:46:18AM +0200, Pali Rohár wrote: > > > > It is not HW bu

Re: [PATCH v5] arm64: dts: marvell: add DT for ESPRESSObin-Ultra

2020-11-23 Thread Pali Rohár
On Monday 26 October 2020 19:44:42 Vladimir Vid wrote: > This adds support for ESPRESSObin-Ultra from Globalscale. > > Specifications are similar to the base ESPRESSObin board, with main > difference being being WAN port with PoE capability and 2 additional ethernet > ports. > > Full specificati

Re: PCI: Race condition in pci_create_sysfs_dev_files

2020-11-15 Thread Pali Rohár
On Sunday 15 November 2020 07:19:36 Krzysztof Wilczyński wrote: > Hello Pali! > > Sincere apologies for taking a long time to get back to you. > > On 20-11-04 17:29:31, Pali Rohár wrote: > > [...] > > > > Krzysztof, as Bjorn wrote, do you want to take this

Re: [PATCH v2] arm64: dts: marvell: espressobin: Update link to V7 schematic

2020-11-13 Thread Pali Rohár
Ping? On Monday 19 October 2020 10:19:33 Pali Rohár wrote: > Gregory, it is OK now? > > On Monday 05 October 2020 15:35:13 Pali Rohár wrote: > > Up-to-date version of V7 schematic is on new URL linked from official > > tech-spec webpage http://espressobin.net/tech-spec/ &

Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2

2020-11-13 Thread Pali Rohár
On Monday 19 October 2020 14:25:37 Andrew Lunn wrote: > On Mon, Oct 19, 2020 at 10:04:08AM +0200, Pali Rohár wrote: > > Hello! Gregory, I would like to remind you following patch. > > Hi Pali > > Since the merge window is open at the moment, no new patches will be >

Re: [PATCH] clk: mvebu: a3700: fix the XTAL MODE pin to MPP1_9

2020-11-13 Thread Pali Rohár
020 11:00:39 +0100 > Pali Rohár wrote: > > > From: Terry Zhou > > > > There is an error in the current code that the XTAL MODE > > pin was set to NB MPP1_31 which should be NB MPP1_9. > > The latch register of NB MPP1_9 has different offset of 0x8. > > >

[PATCH] clk: mvebu: a3700: fix the XTAL MODE pin to MPP1_9

2020-11-06 Thread Pali Rohár
From: Terry Zhou There is an error in the current code that the XTAL MODE pin was set to NB MPP1_31 which should be NB MPP1_9. The latch register of NB MPP1_9 has different offset of 0x8. Signed-off-by: Terry Zhou [pali: Fix pin name in commit message] Signed-off-by: Pali Rohár Fixes

Re: PCI: Race condition in pci_create_sysfs_dev_files

2020-11-04 Thread Pali Rohár
On Tuesday 06 October 2020 17:22:22 Bjorn Helgaas wrote: > It's not obvious from the code why we need pci_sysfs_init(), but > Yinghai hinted [1] that we need to create sysfs after assigning > resources. I experimented by removing pci_sysfs_init() and skipping > the ROM BAR sizing. In that case, w

Re: PCI: Race condition in pci_create_sysfs_dev_files

2020-11-04 Thread Pali Rohár
Hello Krzysztof! On Friday 09 October 2020 10:08:53 Pali Rohár wrote: > On Thursday 08 October 2020 14:59:07 Bjorn Helgaas wrote: > > On Wed, Oct 07, 2020 at 11:14:34AM -0500, Bjorn Helgaas wrote: > > > On Wed, Oct 07, 2020 at 10:14:00AM +0200, Pali Rohár wrote: > > >

[PATCH 0/9] cpufreq: Add missing modalias for tristate drivers

2020-11-03 Thread Pali Rohár
not explictily added only for speedstep-centrino, speedstep-ich and speedstep-smi drivers as it was removed in commit b11d77fa300d9 ("cpufreq: Convert to new X86 CPU match macros"). Pali Rohár (9): cpufreq: ap806: Add missing MODULE_DEVICE_TABLE cpufreq: highbank: Add missing MODULE_DE

[PATCH 6/9] cpufreq: sun50i: Add missing MODULE_DEVICE_TABLE

2020-11-03 Thread Pali Rohár
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this cpufreq driver when it is compiled as an external module. Signed-off-by: Pali Rohár Fixes: f328584f7bff8 ("cpufreq: Add sun50i nvmem based CPU scaling driver") --

[PATCH 4/9] cpufreq: qcom: Add missing MODULE_DEVICE_TABLE

2020-11-03 Thread Pali Rohár
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this cpufreq driver when it is compiled as an external module. Signed-off-by: Pali Rohár Fixes: 46e2856b8e188 ("cpufreq: Add Kryo CPU scaling driver") --- drivers/cp

[PATCH 2/9] cpufreq: highbank: Add missing MODULE_DEVICE_TABLE

2020-11-03 Thread Pali Rohár
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this cpufreq driver when it is compiled as an external module. Signed-off-by: Pali Rohár Fixes: 6754f556103be ("cpufreq / highbank: add support for highbank cpufreq") --

<    1   2   3   4   5   6   7   8   9   10   >