RE: rtlwifi/rtl8192cu AP mode broken with PS STA

> -Original Message- > From: Larry Finger [mailto:larry.fin...@gmail.com] On Behalf Of Larry Finger > Sent: Monday, April 19, 2021 9:23 AM > To: Pkshih; Maciej S. Szmigiero > Cc: linux-wirel...@vger.kernel.org; net...@vger.kernel.org; > linux-kernel@vger.k

RE: rtlwifi/rtl8192cu AP mode broken with PS STA

> -Original Message- > From: Maciej S. Szmigiero [mailto:m...@maciej.szmigiero.name] > Sent: Sunday, April 18, 2021 2:08 AM > To: Pkshih > Cc: linux-wirel...@vger.kernel.org; net...@vger.kernel.org; > linux-kernel@vger.kernel.org; > johan...@sipsolutions.net; kv...@

RE: rtlwifi/rtl8192cu AP mode broken with PS STA

> -Original Message- > From: Maciej S. Szmigiero [mailto:m...@maciej.szmigiero.name] > Sent: Thursday, April 08, 2021 4:53 AM > To: Larry Finger; Pkshih > Cc: linux-wirel...@vger.kernel.org; net...@vger.kernel.org; > linux-kernel@vger.kernel.org; > johan...

Re: rtlwifi/rtl8192cu AP mode broken with PS STA

On Tue, 2021-04-06 at 11:25 -0500, Larry Finger wrote: > On 4/6/21 7:06 AM, Maciej S. Szmigiero wrote: > > On 06.04.2021 12:00, Kalle Valo wrote: > >> "Maciej S. Szmigiero" writes: > >> > >>> On 29.03.2021 00:54, Maciej S. Szmigiero wrote: > Hi, > > It looks like rtlwifi/rtl8192cu

Re: [PATCH v2] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

On Tue, 2021-02-23 at 09:08 +0200, Kalle Valo wrote: > Pkshih writes: > > >> > --- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c > >> > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c > >> > @@ -25,7 +25,6 @@ static struct pci_driver rtw_8

Re: [PATCH v2] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

On Mon, 2021-02-22 at 20:57 +0800, Hao Chen wrote: > Because I only have the `HONOR magic 14` laptop with rtl8822ce wifi chip  > :-( > > I will try to find out why the target platform can't properly resume with > this declaration.Thanks. > > 在 2021/2/22 下午7:36, Pkshih 写道: &

Re: [PATCH v2] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

On Mon, 2021-02-22 at 12:29 +0200, Kalle Valo wrote: > Hao Chen writes: > > > The laptop's wifi disconnect after the laptop HONOR MagicBook 14 > > sleep to S3/S4 and wake up. > > > > The dmesg of kernel report: > > "[   99.990168] pcieport :00:01.2: can't change power state from D3hot > > to

Re: [PATCH] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

On Mon, 2021-02-22 at 09:27 +0200, Kalle Valo wrote: > 陈浩 writes: > > > By git blame command, I know that the assignment of .driver.pm = > > RTW_PM_OPS > > > > was in commit 44bc17f7f5b3b("rtw88: support wowlan feature for > > 8822c"), > > > > and another commit 7dc7c41607d19("avoid unused

Re: [PATCH v2] rtlwifi: rtl8192se: Simplify bool comparison.

On Tue, 2021-01-19 at 14:32 +0800, Jiapeng Zhong wrote: > Fix the follow coccicheck warnings: > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27: > WARNING: Comparison of 0/1 to bool variable. > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26: > WARNING:

Re: [PATCH] rtlwifi/rtl8192se: Simplify bool comparison.

On Fri, 2021-01-15 at 10:06 +, Jiapeng Zhong wrote: > Fix the follow coccicheck warnings: > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27: > WARNING: Comparison of 0/1 to bool variable. > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26: > WARNING:

Re: [PATCH] wireless: realtek: Simplify bool comparison

On Tue, 2021-01-12 at 16:39 +0800, YANG LI wrote: > Fix the following coccicheck warning: > ./drivers/net/wireless/realtek/rtlwifi/ps.c:803:7-21: WARNING: > Comparison to bool > > Reported-by: Abaci Robot > Signed-off-by: YANG LI > --- >  drivers/net/wireless/realtek/rtlwifi/ps.c | 4 ++-- >  1

Re: [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison

On Tue, 2021-01-12 at 16:33 +0800, YANG LI wrote: > Fix the following coccicheck warning: > ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17: > WARNING: Comparison of 0/1 to bool variable > > Reported-by: Abaci Robot > Signed-off-by: YANG LI > I think your name of

Re: [PATCH] rtw88: debug: style: Simplify bool comparison

On Mon, 2021-01-11 at 09:22 +, YANG LI wrote: > Fix the following coccicheck warning: >  ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING: > Comparison of 0/1 to bool variable > > Signed-off-by: YANG LI > Reported-by: Abaci Robot--- >  

Re: [PATCH wireless -next] rtw88: Delete useless kfree code

On Wed, 2020-12-16 at 13:04 +, Zheng Yongjun wrote: > The parameter of kfree function is NULL, so kfree code is useless, delete it. > > Signed-off-by: Zheng Yongjun Acked-by: Ping-Ke Shih > --- >  drivers/net/wireless/realtek/rtw88/main.c | 1 - >  1 file changed, 1 deletion(-) > > diff

Re: [PATCH][next] rtw88: coex: fix missing unitialization of variable 'interval'

On Thu, 2020-12-03 at 17:51 +, Colin King wrote: > From: Colin Ian King > > Currently the variable 'interval' is not initialized and is only set > to 1 when oex_stat->bt_418_hid_existi is true.  Fix this by inintializing > variable interval to 0 (which I'm assuming is the intended default).

RE: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

> -Original Message- > From: Lee Jones [mailto:lee.jo...@linaro.org] > Sent: Friday, November 27, 2020 4:57 PM > To: Pkshih > Cc: Tony Chuang; kv...@codeaurora.org; linux-kernel@vger.kernel.org; > linux-wirel...@vger.kernel.org; > da...@davemloft.net; net.

Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

On Fri, 2020-11-27 at 07:38 +, Lee Jones wrote: > On Fri, 27 Nov 2020, Pkshih wrote: > > >  > > The subject prefix doesn't need 'realtek:'; use 'rtw88:'. > >  > > On Thu, 2020-11-26 at 13:31 +, Lee Jones wrote: > > > Also strip out other

Re: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

The subject prefix doesn't need 'realtek:'; use 'rtw88:'. On Thu, 2020-11-26 at 13:31 +, Lee Jones wrote: > Also strip out other duplicates from driver specific headers. > > Ensure 'main.h' is explicitly included in 'pci.h' since the latter > uses some defines from the former.  It avoids

Re: [PATCH v2 1/4] rtlwifi: rtl8188ee: avoid accessing the data mapped to streaming DMA

On Wed, 2020-11-18 at 09:53 +0800, Jia-Ju Bai wrote: > In rtl88ee_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on > line 677: >   dma_addr_t mapping = dma_map_single(..., skb->data, ...); > > On line 680, skb->data is assigned to hdr after cast: >   struct ieee80211_hdr *hdr = (struct

Re: [PATCH] rtw88: coex: remove the unreached code in rtw_coex_set_tdma

On Sat, 2020-11-14 at 15:22 +, xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > The value of the bool variable ap_enable is always false, so the first > if branch is unreached code. Remove it. > > Reported-by: Tosk Robot > Signed-off-by: Kaixu Xia > --- >  

Re: [PATCH] rtl8192ce: avoid accessing the data mapped to streaming DMA

On Mon, 2020-10-19 at 11:09 +0800, Jia-Ju Bai wrote: > In rtl92ce_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on > line 530: >   dma_addr_t mapping = dma_map_single(..., skb->data, ...); > > On line 533, skb->data is assigned to hdr after cast: >   struct ieee80211_hdr *hdr = (struct

Re: [PATCH] rtlwifi: Fix non-canonical address access issues

On Tue, 2020-10-27 at 11:16 +0800, WeitaoWangoc wrote: > During realtek USB wireless NIC initialization, it's unexpected > disconnection will cause urb sumbmit fail. On the one hand, > _rtl_usb_cleanup_rx will be called to clean up rx stuff, especially for > rtl_wq. On the other hand,

Re: [PATCH] Net/Usb:Fix realtek wireless NIC non-canonical address access issues

On Tue, 2020-10-20 at 19:38 +0800, WeitaoWangoc wrote: For rtlwifi driver, please use 'rtlwifi: ' as prefix of mail subject, like "rtlwifi: Fix non-canonical address access issues" > During realtek USB wireless NIC initialization, it's unexpected > disconnection will cause urb sumbmit fail.On

Re: [PATCH net-next 06/11] rtlwifi: fix -Wpointer-sign warning

On Mon, 2020-10-26 at 22:29 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > There are thousands of warnings in a W=2 build from just one file: > > drivers/net/wireless/realtek/rtlwifi/rtl8821ae/table.c:3788:15: warning: > pointer targets in initialization of 'u8 *' {aka 'unsigned char *'}

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

On Mon, 2020-07-27 at 01:27 -0700, Joe Perches wrote: > On Mon, 2020-07-27 at 06:07 +0000, Pkshih wrote: > > On Sat, 2020-07-25 at 12:55 -0700, Joe Perches wrote: > > > Make these statements a little simpler. > [] > > > diff --git a/drivers/net/wireless/realtek/rt

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

On Sat, 2020-07-25 at 12:55 -0700, Joe Perches wrote: > Make these statements a little simpler. > > Signed-off-by: Joe Perches > --- >  drivers/net/wireless/realtek/rtlwifi/base.c   | 14 +-- >  .../rtlwifi/btcoexist/halbtc8192e2ant.c   | 23 ++- >  

Re: [PATCH] rtlwifi: core: use eth_broadcast_addr() to assign broadcast

On Mon, 2020-07-27 at 02:16 +, Xu Wang wrote: > This patch is to use eth_broadcast_addr() to assign broadcast address > insetad of memcpy(). > > Signed-off-by: Xu Wang > --- >  drivers/net/wireless/realtek/rtlwifi/core.c | 3 +-- >  1 file changed, 1 insertion(+), 2 deletions(-) > > diff

Re: [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path

On Thu, 2020-07-23 at 17:32 +0100, Colin King wrote: > From: Colin Ian King > > The variables ant_num and single_ant_path are being initialized with a > value that is never read and are being updated later with a new value. > The initializations are redundant and can be removed. > >

Re: [PATCH] rtlwifi/*/dm.c: Use const in swing_table declarations

On Mon, 2020-06-29 at 11:12 +0800, Pkshih wrote: > On Sun, 2020-06-28 at 19:51 -0700, j...@perches.com wrote: > > On 2020-06-28 19:09, Pkshih wrote: > > > On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote: > > >  > > > Use 'rtlwifi:' as subject title prefix i

Re: [PATCH] rtlwifi/*/dm.c: Use const in swing_table declarations

On Sun, 2020-06-28 at 19:51 -0700, j...@perches.com wrote: > On 2020-06-28 19:09, Pkshih wrote: > > On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote: > >  > > Use 'rtlwifi:' as subject title prefix is enough, likes > >   rtlwifi: Use const in swing_table declaratio

Re: [PATCH] rtlwifi/*/dm.c: Use const in swing_table declarations

On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote: Use 'rtlwifi:' as subject title prefix is enough, likes   rtlwifi: Use const in swing_table declarations > Reduce data usage about 1KB by using const. > > Signed-off-by: Joe Perches > --- >  .../net/wireless/realtek/rtlwifi/rtl8188ee/dm.c   

Re: [PATCH][next] rtw88: 8723d: fix incorrect setting of ldo_pwr

On Thu, 2020-05-14 at 18:13 +, Colin King wrote: > From: Colin Ian King > > Currently ldo_pwr has the LDO25 voltage bits set to zero and then > it is overwritten with the new voltage setting. The assignment > looks incorrect, it should be bit-wise or'ing in the new voltage > setting rather

Re: [PATCH] rtlwifi: Remove unnecessary NULL check in rtl_regd_init

On Tue, 2019-10-22 at 17:47 -0700, Nathan Chancellor wrote: > When building with Clang + -Wtautological-pointer-compare: > > drivers/net/wireless/realtek/rtlwifi/regd.c:389:33: warning: comparison > of address of 'rtlpriv->regd' equal to a null pointer is always false >

Re: [PATCH v2] rtlwifi: Fix potential overflow on P2P code

On Fri, 2019-10-18 at 07:43 -0400, Laura Abbott wrote: > Nicolas Waisman noticed that even though noa_len is checked for > a compatible length it's still possible to overrun the buffers > of p2pinfo since there's no check on the upper bound of noa_num. > Bound noa_num against P2P_MAX_NOA_NUM. > >

RE: [PATCH] rtlwifi: Fix potential overflow on P2P code

> -Original Message- > From: linux-wireless-ow...@vger.kernel.org > [mailto:linux-wireless-ow...@vger.kernel.org] On Behalf > Of Laura Abbott > Sent: Thursday, October 17, 2019 4:57 AM > To: Pkshih; Kalle Valo > Cc: Laura Abbott; David S. Miller; linux-wirel...@vg

RE: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

> -Original Message- > From: Austin Kim [mailto:austindh@gmail.com] > Sent: Monday, September 23, 2019 9:35 PM > To: Pkshih; kv...@codeaurora.org; da...@davemloft.net > Cc: linux-wirel...@vger.kernel.org; net...@vger.kernel.org; > linux-kernel@vger.kernel.org >

Re: [PATCH 0/3] rtlwifi: use generic rtl_evm_db_to_percentage

On Tue, 2019-09-10 at 21:04 +0200, Michael Straube wrote: > Functions _rtl92{c,d}_evm_db_to_percentage are functionally identical > to the generic version rtl_evm_db_to percentage. This series converts > rtl8192ce, rtl8192cu and rtl8192de to use the generic version. > > Michael Straube (3): >  

Re: [PATCH] rtlwifi: remove unneeded function _rtl_dump_channel_map()

On Wed, 2019-07-24 at 22:10 +0800, YueHaibing wrote: > Now _rtl_dump_channel_map() does not do any actual > thing using the channel. So remove it. > > Signed-off-by: YueHaibing > --- >  drivers/net/wireless/realtek/rtlwifi/regd.c | 18 -- >  1 file changed, 18 deletions(-) > >

RE: linux-5.2.2/drivers/net/wireless/realtek/rtlwifi/rtl8*/sw.c: many redundant assignments ?

> -Original Message- > From: David Binderman [mailto:dcb...@hotmail.com] > Sent: Monday, July 22, 2019 4:12 PM > To: Pkshih; kv...@codeaurora.org; da...@davemloft.net; > linux-wirel...@vger.kernel.org; > net...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject

Re: [PATCH] rtlwifi: btcoex: fix issue possible condition with no effect (if == else)

On Fri, 2019-07-12 at 19:15 +, Hariprasad Kelam wrote: > fix below issue reported by coccicheck > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:514:1-3: > WARNING: possible condition with no effect (if == else) > > Signed-off-by: Hariprasad Kelam > --- >  

Re: [PATCH] net:rtlwifi:move spin_lock_bh to spin_lock in tasklet

On Tue, 2019-03-19 at 22:31 +0800, Jeff Xie wrote: > It is unnecessary to call spin_lock_bh in a tasklet. > > Signed-off-by: Jeff Xie > > --- >  drivers/net/wireless/realtek/rtlwifi/pci.c | 6 +++--- >  1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH] wireless: remove unneeded semicolon

On Fri, 2019-01-18 at 11:32 +0800, YueHaibing wrote: > remove unneeded semicolon > > Signed-off-by: YueHaibing > --- >  drivers/net/wireless/ath/ath10k/wmi.h | 2 +- >  drivers/net/wireless/ath/ath6kl/init.c| 2 +- >  

Re: [PATCH] rtlwifi: Fix non-working BSS STA mode

On Thu, 2018-12-13 at 13:36 +0800, Kai Heng Feng wrote: > > On Dec 13, 2018, at 08:35, Pkshih wrote: > >  > > On Wed, 2018-12-12 at 13:13 +0800, Kai-Heng Feng wrote: > >> Once BSS STA mode gets started, it can be scanned by other clients but > &g

Re: [PATCH] rtlwifi: Fix non-working BSS STA mode

On Wed, 2018-12-12 at 13:13 +0800, Kai-Heng Feng wrote: > Once BSS STA mode gets started, it can be scanned by other clients but > cannot entablish a connection.          ^^^ typo: establish > > Turns out the set_bcn_reg() and its *_set_beacon_related_registers() > callbacks never get called so

Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

On Mon, 2018-10-01 at 07:15 +0300, Kalle Valo wrote: > Joe Perches writes: > > > On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote: > >> The following: > >>  bool efuse_re_pg_sec1flag; > >>  u8 efuse_re_pg_data[8]; > >> are not referenced anywhere in the rtlwifi code. > >>  > >> Signed-off-by:

Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

On Mon, 2018-10-01 at 07:15 +0300, Kalle Valo wrote: > Joe Perches writes: > > > On Sun, 2018-09-30 at 20:29 +0200, Rick Veens wrote: > >> The following: > >>  bool efuse_re_pg_sec1flag; > >>  u8 efuse_re_pg_data[8]; > >> are not referenced anywhere in the rtlwifi code. > >>  > >> Signed-off-by:

Re: [PATCH] staging: r8822be: Fix RTL8822be can't find any wireless AP

On Sun, 2018-07-08 at 11:30 -0500, Larry Finger wrote: > On 07/06/2018 12:44 AM, pks...@realtek.com wrote: > > From: Ping-Ke Shih > >  > > RTL8822be can't bring up properly on ASUS X530UN, and dmesg says: > > [ 8.591333] r8822be: module is from the staging directory, the quality > > is unknown,

Re: [PATCH] staging: r8822be: Fix RTL8822be can't find any wireless AP

On Sun, 2018-07-08 at 11:30 -0500, Larry Finger wrote: > On 07/06/2018 12:44 AM, pks...@realtek.com wrote: > > From: Ping-Ke Shih > >  > > RTL8822be can't bring up properly on ASUS X530UN, and dmesg says: > > [ 8.591333] r8822be: module is from the staging directory, the quality > > is unknown,

Re: RTL8723BE performance regression

On Wed, 2018-05-09 at 13:33 -0700, João Paulo Rechi Vita wrote: > On Tue, May 8, 2018 at 1:37 AM, Pkshih <pks...@realtek.com> wrote: > > On Mon, 2018-05-07 at 14:49 -0700, João Paulo Rechi Vita wrote: > >> On Tue, May 1, 2018 at 10:58 PM, Pkshih <pks...@realtek.com>

Re: RTL8723BE performance regression

On Wed, 2018-05-09 at 13:33 -0700, João Paulo Rechi Vita wrote: > On Tue, May 8, 2018 at 1:37 AM, Pkshih wrote: > > On Mon, 2018-05-07 at 14:49 -0700, João Paulo Rechi Vita wrote: > >> On Tue, May 1, 2018 at 10:58 PM, Pkshih wrote: > >> > On Wed, 2018-05-0

Re: RTL8723BE performance regression

On Mon, 2018-05-07 at 14:49 -0700, João Paulo Rechi Vita wrote: > On Tue, May 1, 2018 at 10:58 PM, Pkshih <pks...@realtek.com> wrote: > > On Wed, 2018-05-02 at 05:44 +, Pkshih wrote: > >> > >> > -Original Message- > >> > From:

Re: RTL8723BE performance regression

On Mon, 2018-05-07 at 14:49 -0700, João Paulo Rechi Vita wrote: > On Tue, May 1, 2018 at 10:58 PM, Pkshih wrote: > > On Wed, 2018-05-02 at 05:44 +0000, Pkshih wrote: > >> > >> > -Original Message- > >> > From: João Paulo Rechi Vita [mailto:jprv...

Re: RTL8723BE performance regression

On Wed, 2018-05-02 at 05:44 +, Pkshih wrote: > > > -Original Message- > > From: João Paulo Rechi Vita [mailto:jprv...@gmail.com] > > Sent: Wednesday, May 02, 2018 6:41 AM > > To: Larry Finger > > Cc: Steve deRosier; 莊彥宣; Pkshih; Birming Chiu; Shao

Re: RTL8723BE performance regression

On Wed, 2018-05-02 at 05:44 +, Pkshih wrote: > > > -Original Message- > > From: João Paulo Rechi Vita [mailto:jprv...@gmail.com] > > Sent: Wednesday, May 02, 2018 6:41 AM > > To: Larry Finger > > Cc: Steve deRosier; 莊彥宣; Pkshih; Birming Chiu; Shao

RE: RTL8723BE performance regression

> -Original Message- > From: João Paulo Rechi Vita [mailto:jprv...@gmail.com] > Sent: Wednesday, May 02, 2018 6:41 AM > To: Larry Finger > Cc: Steve deRosier; 莊彥宣; Pkshih; Birming Chiu; Shaofu; Steven Ting; > Chaoming_Li; Kalle Valo; > linux-wireless; Network Deve

RE: RTL8723BE performance regression

> -Original Message- > From: João Paulo Rechi Vita [mailto:jprv...@gmail.com] > Sent: Wednesday, May 02, 2018 6:41 AM > To: Larry Finger > Cc: Steve deRosier; 莊彥宣; Pkshih; Birming Chiu; Shaofu; Steven Ting; > Chaoming_Li; Kalle Valo; > linux-wireless; Network Deve

[PATCH v2 0/9] rtlwifi: btcoex: Add 8822b btcoex support

From: Ping-Ke Shih v2: fix misspelling and boolean expression in patch 1/9 Patches 1-2 are revised by patches 12 of previous patchset. 8822b coex files are split into two patches, and I remove some comments and apply 'static const' to version related variables. Patches 3-4

[PATCH v2 8/9] rtlwifi: btcoex: Add struct members to replace global varaibles

From: Ping-Ke Shih Chip specific context plays as global variables that will not support multiple devices simultaneously. This patch adds 'union' fields to hold the variables, and next patch will remove all of them. To use the declaration of fields in halbtcoutsrc.h, I move

[PATCH v2 0/9] rtlwifi: btcoex: Add 8822b btcoex support

From: Ping-Ke Shih v2: fix misspelling and boolean expression in patch 1/9 Patches 1-2 are revised by patches 12 of previous patchset. 8822b coex files are split into two patches, and I remove some comments and apply 'static const' to version related variables. Patches 3-4 aren't changed.

[PATCH v2 8/9] rtlwifi: btcoex: Add struct members to replace global varaibles

From: Ping-Ke Shih Chip specific context plays as global variables that will not support multiple devices simultaneously. This patch adds 'union' fields to hold the variables, and next patch will remove all of them. To use the declaration of fields in halbtcoutsrc.h, I move the including order

[PATCH v2 4/9] rtlwifi: btcoex: Add 8822b routine to btc interfaces

From: Ping-Ke Shih Add 8822b routines to run btcoex algorithm Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 100 + 1 file changed, 100 insertions(+) diff --git

[PATCH v2 4/9] rtlwifi: btcoex: Add 8822b routine to btc interfaces

From: Ping-Ke Shih Add 8822b routines to run btcoex algorithm Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 100 + 1 file changed, 100 insertions(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c

[PATCH v2 7/9] rtlwifi: btcoex: Add modifier const to version related variables

From: Ping-Ke Shih The variables declared as 'static' look a little weird. Since they are version of btcoex and only used to display in debug message, this patch changes them to 'static const' to make it clear. Signed-off-by: Ping-Ke Shih ---

[PATCH v2 7/9] rtlwifi: btcoex: Add modifier const to version related variables

From: Ping-Ke Shih The variables declared as 'static' look a little weird. Since they are version of btcoex and only used to display in debug message, this patch changes them to 'static const' to make it clear. Signed-off-by: Ping-Ke Shih ---

[PATCH v2 3/9] rtlwifi: btcoex: Add 8822b header files to precomp.h

From: Ping-Ke Shih Add 8822b header files to precomp.h for routing functions. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbt_precomp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v2 9/9] rtlwifi: btcoex: Remove global variables of chip specific context

From: Ping-Ke Shih Remove the global varaibles, and use local varialbes that point the fields defined in 'struct btc_coexist' instead, so it is possible to support multiple devices. Signed-off-by: Ping-Ke Shih ---

[PATCH v2 3/9] rtlwifi: btcoex: Add 8822b header files to precomp.h

From: Ping-Ke Shih Add 8822b header files to precomp.h for routing functions. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbt_precomp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbt_precomp.h

[PATCH v2 9/9] rtlwifi: btcoex: Remove global variables of chip specific context

From: Ping-Ke Shih Remove the global varaibles, and use local varialbes that point the fields defined in 'struct btc_coexist' instead, so it is possible to support multiple devices. Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtc8192e2ant.c| 44 --

[PATCH v2 6/9] rtlwifi: btcoex: remove comments that are not meaningful

From: Ping-Ke Shih The comments aren't meaningful and the use of '***...***' isn't upstream style, so remove them. This patch doesn't change any code. Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtc8192e2ant.c| 22

[PATCH v2 5/9] rtlwifi: btcoex: Add 8822b to Makefile

From: Ping-Ke Shih Add btcoex of 8822b to Makefile. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/btcoexist/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/Makefile

[PATCH v2 6/9] rtlwifi: btcoex: remove comments that are not meaningful

From: Ping-Ke Shih The comments aren't meaningful and the use of '***...***' isn't upstream style, so remove them. This patch doesn't change any code. Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtc8192e2ant.c| 22 +---

[PATCH v2 5/9] rtlwifi: btcoex: Add 8822b to Makefile

From: Ping-Ke Shih Add btcoex of 8822b to Makefile. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/btcoexist/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/Makefile

Re: [rtlwifi-btcoex] Suspicious code in halbtc8821a1ant driver

On Thu, 2018-04-05 at 01:25 +, Gustavo A. R. Silva wrote: > Hi all, > > While doing some static analysis I came across the following piece of code at > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1581: > > 1581 static void btc8821a1ant_act_bt_sco_hid_only_busy(struct

Re: [rtlwifi-btcoex] Suspicious code in halbtc8821a1ant driver

On Thu, 2018-04-05 at 01:25 +, Gustavo A. R. Silva wrote: > Hi all, > > While doing some static analysis I came across the following piece of code at > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1581: > > 1581 static void btc8821a1ant_act_bt_sco_hid_only_busy(struct

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

On Sat, 2018-03-31 at 00:05 -0700, Joe Perches wrote: > Use the new ether_broadcast_addr global instead to save some object code. > > Signed-off-by: Joe Perches > --- >  drivers/net/wireless/admtek/adm8211.c   | 3 +-- >  drivers/net/wireless/ath/carl9170/mac.c |

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

On Sat, 2018-03-31 at 00:05 -0700, Joe Perches wrote: > Use the new ether_broadcast_addr global instead to save some object code. > > Signed-off-by: Joe Perches > --- >  drivers/net/wireless/admtek/adm8211.c   | 3 +-- >  drivers/net/wireless/ath/carl9170/mac.c | 4 +--- >  

Re: [PATCH] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

On Wed, 2018-02-07 at 12:51 -0800, Matthias Kaehlcke wrote: > El Wed, Feb 07, 2018 at 02:35:59PM -0600 Larry Finger ha dit: > > > On 02/07/2018 02:26 PM, Matthias Kaehlcke wrote: > > > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal > > > is assigned to itself in an if ...

Re: [PATCH] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

On Wed, 2018-02-07 at 12:51 -0800, Matthias Kaehlcke wrote: > El Wed, Feb 07, 2018 at 02:35:59PM -0600 Larry Finger ha dit: > > > On 02/07/2018 02:26 PM, Matthias Kaehlcke wrote: > > > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal > > > is assigned to itself in an if ...

Re: [PATCH] staging: rtlwifi: remove redundant initialization of 'cfg_cmd'

On Fri, 2018-01-26 at 13:52 +, Colin King wrote: > From: Colin Ian King >  > The initialization of cfg_cmd is redundant as the value is never read > and it is being re-assigned to cfg_cmd = pwrcfgcmd[ary_idx] inside a > loop, hence it can be removed. >  > Cleans up

Re: [PATCH] staging: rtlwifi: remove redundant initialization of 'cfg_cmd'

On Fri, 2018-01-26 at 13:52 +, Colin King wrote: > From: Colin Ian King >  > The initialization of cfg_cmd is redundant as the value is never read > and it is being re-assigned to cfg_cmd = pwrcfgcmd[ary_idx] inside a > loop, hence it can be removed. >  > Cleans up clang warning: >

[PATCH] rtlwifi: Remove seq_number from rtl_tid_data

From: Ping-Ke Shih Since mac80211 maintains the sequence number for each STA/TID, driver doesn't need to maintain a copy. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/base.c | 6 ++ drivers/net/wireless/realtek/rtlwifi/pci.c

[PATCH] rtlwifi: Remove seq_number from rtl_tid_data

From: Ping-Ke Shih Since mac80211 maintains the sequence number for each STA/TID, driver doesn't need to maintain a copy. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/base.c | 6 ++ drivers/net/wireless/realtek/rtlwifi/pci.c | 17 -