Re: [PATCH 2/4] tty: atmel_serial: convert tasklets to use new tasklet_setup() API

y. > > Signed-off-by: Romain Perier > Signed-off-by: Allen Pais Acked-by: Richard Genoud > --- > drivers/tty/serial/atmel_serial.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/tty/serial/atmel_serial.c >

Re: [PATCH] can: m_can_platform: fix m_can_runtime_suspend()

Hi Dan, Le 08/06/2020 à 16:27, Dan Murphy a écrit : Richard On 6/8/20 4:43 AM, Richard Genoud wrote: Since commit f524f829b75a ("can: m_can: Create a m_can platform framework"), the can peripheral on STM32MP1 wasn't working anymore. The reason was a bad copy/paste maneuver that ad

[PATCH] can: m_can_platform: fix m_can_runtime_suspend()

gon Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework") Signed-off-by: Richard Genoud --- drivers/net/can/m_can/m_can_platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.

Re: [PATCH v6 2/2] tty: add rpmsg driver

Hi Arnaud, Le 04/09/2019 à 15:09, Arnaud Pouliquen a écrit : > This driver exposes a standard tty interface on top of the rpmsg > framework through a rpmsg service. > > This driver supports multi-instances, offering a /dev/ttyRPMSGx entry > per rpmsg endpoint. > > Signed-off-by: Arnaud

[PATCH v2] tty/serial: atmel: remove unneeded atmel_get_lines_status function

eine-König Acked-by: Uwe Kleine-König Signed-off-by: Richard Genoud --- drivers/tty/serial/atmel_serial.c | 48 ++- 1 file changed, 2 insertions(+), 46 deletions(-) Changes from v1: - point out the right commit (thx Uwe) - add Suggested-by/Acked-by diff --git a/drivers/

[PATCH] tty/serial: atmel: remove unneeded atmel_get_lines_status function

Since commit ce59e48fdbad ("serial: mctrl_gpio: implement interrupt handling"), the GPIOs interrupts are handled by mctrl_gpio_irq_handle(). So, atmel_get_lines_status() can be completely killed and replaced by : atmel_uart_readl(port, ATMEL_US_CSR); Signed-off-by: Richard Genoud --

Re: [PATCH v2 2/2] tty/serial: atmel: RS485 HD w/DMA: enable RX after TX is stopped

1 ("tty/serial: atmel: RS485 half duplex w/DMA: enable > RX after TX is done") > Signed-off-by: Razvan Stefanescu Acked-by: Richard Genoud NB: backport on kernel older than 4.20 will fail because of the iso7816 variables fidi_min/fidi_max. > --- > Changelog: > v2: > - sta

Re: [PATCH v2 1/2] tty/serial: atmel: Add is_half_duplex helper

RX after TX is done") > Signed-off-by: Razvan Stefanescu Acked-by: Richard Genoud NB: backport on kernel older than 4.20 will fail because of the SER_ISO7816_ENABLED flag. > --- > Changelog: > v2: > - remove extra check > - add fix info > > drivers/tty/serial/

Re: [PATCH 2/2] tty/serial: atmel: RS485 HD w/DMA: enable RX after TX is stopped

[ adding Gil Weber in Cc: ] Le 15/03/2019 à 10:23, Razvan Stefanescu a écrit : > In half-duplex operation, RX should be started after TX completes. > > If DMA is used, there is a case when the DMA transfer completes but the > TX FIFO is not emptied, so the RX cannot be restarted just yet. > >

Re: [PATCH 1/2] tty/serial: atmel: Add is_half_duplex helper

[ adding Gil Weber in Cc: ] Le 15/03/2019 à 10:23, Razvan Stefanescu a écrit : > Use a helper function to check that a port needs to use half duplex > communication, replacing several occurrences of multi-line bit checking. > > Signed-off-by: Razvan Stefanescu > --- >

Re: [PATCH] tty: atmel_serial: fix a NULL pointer dereference

Le 15/03/2019 à 18:16, Kangjie Lu a écrit : > In case dmaengine_prep_dma_cyclic fails, the fix returns a proper > error code to avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu > Fixes: 34df42f59a60 ("serial: at91: add rx dma support") Acked-by: Richa

Re: [PATCH v2] tty: atmel_serial: fix a NULL pointer dereference

rence. > > Signed-off-by: Kangjie Lu ^^^ here > > --- > V2: simplified the patch as suggested by > Richard Genoud > --- > drivers/tty/serial/atmel_serial.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/tty/serial/atmel_serial.c >

Re: [PATCH] tty: atmel_serial: fix a NULL pointer dereference

Hi, Good catch ! Le 14/03/2019 à 08:17, Kangjie Lu a écrit : > In case dmaengine_prep_dma_cyclic fails, the fix return a proper > error code to avoid NULL pointer dereference. > you could add: Fixes: 34df42f59a60 ("serial: at91: add rx dma support") So that -stable branches get this. >

[PATCH] dmaengine: at_hdmac: fix memory leak in at_dma_xlate()

oni Acked-by: Alexandre Belloni Signed-off-by: Richard Genoud --- drivers/dma/at_hdmac.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 7cbac6e8c113..1b7f0ca0d5cd 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/

[PATCH] dmaengine: at_hdmac: fix memory leak in at_dma_xlate()

oni Acked-by: Alexandre Belloni Signed-off-by: Richard Genoud --- drivers/dma/at_hdmac.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 7cbac6e8c113..1b7f0ca0d5cd 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/

[PATCH] dmaengine: at_hdmac: fix module unloading

org Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding") Signed-off-by: Richard Genoud --- drivers/dma/at_hdmac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 1b7f0ca0d5cd..01d936c9fe89 100644 --- a/drivers/dma/at_

[PATCH] dmaengine: at_hdmac: fix module unloading

org Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding") Signed-off-by: Richard Genoud --- drivers/dma/at_hdmac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 1b7f0ca0d5cd..01d936c9fe89 100644 --- a/drivers/dma/at_

Re: DMA: atmel_serial: Opening and closing the serial device repeatedly causes kmalloc-32 slab leak

Le 27/11/2018 à 10:58, Alexandre Belloni a écrit : > Hello Richard, > > On 27/11/2018 10:51:13+0100, richard.gen...@gmail.com wrote: >> Hi all, >> >> I reproduced the memory leak on my board (at91sam9g35-cm) with a 4.20-rc3. >> >> It triggered an OOM after a couple of hours running a code like

Re: DMA: atmel_serial: Opening and closing the serial device repeatedly causes kmalloc-32 slab leak

Le 27/11/2018 à 10:58, Alexandre Belloni a écrit : > Hello Richard, > > On 27/11/2018 10:51:13+0100, richard.gen...@gmail.com wrote: >> Hi all, >> >> I reproduced the memory leak on my board (at91sam9g35-cm) with a 4.20-rc3. >> >> It triggered an OOM after a couple of hours running a code like

DMA: atmel_serial: Opening and closing the serial device repeatedly causes kmalloc-32 slab leak

[re-sending with Vinod's correct email address. Sorry for the noise. ] [re-sending the bug report to the lists] Le 16/11/2018 à 17:04, Mario Forner a écrit : > Problem: > When I open and close the serial device /dev/ttyS4 in a loop > the amount of kmalloc-32 slabs increases slowly but steadily

DMA: atmel_serial: Opening and closing the serial device repeatedly causes kmalloc-32 slab leak

[re-sending with Vinod's correct email address. Sorry for the noise. ] [re-sending the bug report to the lists] Le 16/11/2018 à 17:04, Mario Forner a écrit : > Problem: > When I open and close the serial device /dev/ttyS4 in a loop > the amount of kmalloc-32 slabs increases slowly but steadily

DMA: atmel_serial: Opening and closing the serial device repeatedly causes kmalloc-32 slab leak

[re-sending the bug report to the lists] Le 16/11/2018 à 17:04, Mario Forner a écrit : > Problem: > When I open and close the serial device /dev/ttyS4 in a loop > the amount of kmalloc-32 slabs increases slowly but steadily without limit. > > The serial device is configured in acme-aria.dts to

DMA: atmel_serial: Opening and closing the serial device repeatedly causes kmalloc-32 slab leak

[re-sending the bug report to the lists] Le 16/11/2018 à 17:04, Mario Forner a écrit : > Problem: > When I open and close the serial device /dev/ttyS4 in a loop > the amount of kmalloc-32 slabs increases slowly but steadily without limit. > > The serial device is configured in acme-aria.dts to

Re: [PATCH v4 2/2] tty/serial: atmel: add ISO7816 support

; function as well. > > Signed-off-by: Nicolas Ferre > [ludovic.desroc...@microchip.com: rebase, add check on fidi ratio, checkpatch > fixes] > Signed-off-by: Ludovic Desroches This seems ok for me. Acked-by: Richard Genoud Thanks !

Re: [PATCH v4 2/2] tty/serial: atmel: add ISO7816 support

; function as well. > > Signed-off-by: Nicolas Ferre > [ludovic.desroc...@microchip.com: rebase, add check on fidi ratio, checkpatch > fixes] > Signed-off-by: Ludovic Desroches This seems ok for me. Acked-by: Richard Genoud Thanks !

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

[added Nicolas back in the thread, he was removed somehow] Hi Ludovic ! On 05/09/2018 14:43, Ludovic Desroches wrote: > Hi Richard, > > On Thu, Aug 09, 2018 at 01:30:35PM +0200, Ludovic Desroches wrote: >> Hi Richard, >> >> On Thu, Aug 09, 2018 at 10:47:17AM +0200, R

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

[added Nicolas back in the thread, he was removed somehow] Hi Ludovic ! On 05/09/2018 14:43, Ludovic Desroches wrote: > Hi Richard, > > On Thu, Aug 09, 2018 at 01:30:35PM +0200, Ludovic Desroches wrote: >> Hi Richard, >> >> On Thu, Aug 09, 2018 at 10:47:17AM +0200, R

Re: [PATCH RESEND 2/2] gpio: mvebu: Allow to use non-default PWM counter

Hi, On 06/08/2018 15:52, Andrew Lunn wrote: > On Mon, Aug 06, 2018 at 10:29:16AM +0800, Aditya Prayoga wrote: >> On multiple PWM lines, if the other PWM counter is unused, allocate it >> to next PWM request. The priority would be: >> 1. Default counter assigned to the bank >> 2. Unused counter

Re: [PATCH RESEND 2/2] gpio: mvebu: Allow to use non-default PWM counter

Hi, On 06/08/2018 15:52, Andrew Lunn wrote: > On Mon, Aug 06, 2018 at 10:29:16AM +0800, Aditya Prayoga wrote: >> On multiple PWM lines, if the other PWM counter is unused, allocate it >> to next PWM request. The priority would be: >> 1. Default counter assigned to the bank >> 2. Unused counter

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

Hi ! On 07/08/2018 15:00, Ludovic Desroches wrote: > From: Nicolas Ferre > > When mode is set in atmel_config_iso7816() we backup last RS232 mode > for coming back to this mode if requested. > Also allow setup of T=0 and T=1 parameter and basic support in set_termios > function as well. > >

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

Hi ! On 07/08/2018 15:00, Ludovic Desroches wrote: > From: Nicolas Ferre > > When mode is set in atmel_config_iso7816() we backup last RS232 mode > for coming back to this mode if requested. > Also allow setup of T=0 and T=1 parameter and basic support in set_termios > function as well. > >

Re: [PATCH 0/2] gpio: mvebu: Add support for multiple PWM lines

On 03/08/2018 11:42, Richard Genoud wrote: > On 03/08/2018 11:36, Gregory CLEMENT wrote: >> Hi Linus and Adita >> >> On dim., juil. 29 2018, Linus Walleij wrote: >> >>> Hoping for some review from Gergory, Ralph or Richard who all seem >>> t

Re: [PATCH 0/2] gpio: mvebu: Add support for multiple PWM lines

On 03/08/2018 11:42, Richard Genoud wrote: > On 03/08/2018 11:36, Gregory CLEMENT wrote: >> Hi Linus and Adita >> >> On dim., juil. 29 2018, Linus Walleij wrote: >> >>> Hoping for some review from Gergory, Ralph or Richard who all seem >>> t

Re: [PATCH 0/2] gpio: mvebu: Add support for multiple PWM lines

On 03/08/2018 11:36, Gregory CLEMENT wrote: > Hi Linus and Adita > > On dim., juil. 29 2018, Linus Walleij wrote: > >> Hoping for some review from Gergory, Ralph or Richard who all seem >> to use this driver! > > Would it be possible to resend the series adding me in CC? I would > like to

Re: [PATCH 0/2] gpio: mvebu: Add support for multiple PWM lines

On 03/08/2018 11:36, Gregory CLEMENT wrote: > Hi Linus and Adita > > On dim., juil. 29 2018, Linus Walleij wrote: > >> Hoping for some review from Gergory, Ralph or Richard who all seem >> to use this driver! > > Would it be possible to resend the series adding me in CC? I would > like to

Re: [PATCH v2 2/2] tty/serial: atmel: add ISO7816 support

Hi Ludovic, On 19/07/2018 10:47, Ludovic Desroches wrote: > From: Nicolas Ferre > > When mode is set in atmel_config_iso7816() we backup last RS232 mode > for coming back to this mode if requested. > Also allow setup of T=0 and T=1 parameter and basic support in set_termios > function as well.

Re: [PATCH v2 2/2] tty/serial: atmel: add ISO7816 support

Hi Ludovic, On 19/07/2018 10:47, Ludovic Desroches wrote: > From: Nicolas Ferre > > When mode is set in atmel_config_iso7816() we backup last RS232 mode > for coming back to this mode if requested. > Also allow setup of T=0 and T=1 parameter and basic support in set_termios > function as well.

Re: [PATCH v6 6/6] tty/serial: atmel: change the driver to work under at91-usart mfd

> ret = PTR_ERR(atmel_port->clk); > atmel_port->clk = NULL; > @@ -2694,13 +2696,22 @@ static void atmel_serial_probe_fifos(struct > atmel_uart_port *atmel_port, > static int atmel_serial_probe(struct platform_device *pdev) >

Re: [PATCH v6 6/6] tty/serial: atmel: change the driver to work under at91-usart mfd

> ret = PTR_ERR(atmel_port->clk); > atmel_port->clk = NULL; > @@ -2694,13 +2696,22 @@ static void atmel_serial_probe_fifos(struct > atmel_uart_port *atmel_port, > static int atmel_serial_probe(struct platform_device *pdev) >

Re: [PATCH v5 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

Typo in the subject: changed->change On 04/06/2018 18:59, Radu Pirea wrote: > This patch modifies the place where resources and device tree properties > are searched. > > Signed-off-by: Radu Pirea > --- > drivers/tty/serial/Kconfig| 1 + > drivers/tty/serial/atmel_serial.c | 41

Re: [PATCH v5 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

Typo in the subject: changed->change On 04/06/2018 18:59, Radu Pirea wrote: > This patch modifies the place where resources and device tree properties > are searched. > > Signed-off-by: Radu Pirea > --- > drivers/tty/serial/Kconfig| 1 + > drivers/tty/serial/atmel_serial.c | 41

Re: [PATCH v4 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

On 25/05/2018 19:19, Radu Pirea wrote: > This patch modifies the place where resources and device tree properties > are searched. > > Signed-off-by: Radu Pirea > --- > drivers/tty/serial/Kconfig| 1 + > drivers/tty/serial/atmel_serial.c | 40

Re: [PATCH v4 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

On 25/05/2018 19:19, Radu Pirea wrote: > This patch modifies the place where resources and device tree properties > are searched. > > Signed-off-by: Radu Pirea > --- > drivers/tty/serial/Kconfig| 1 + > drivers/tty/serial/atmel_serial.c | 40 +-- > 2 files

Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

On 25/05/2018 14:17, Radu Pirea wrote: > > > On 05/15/2018 04:14 PM, Richard Genoud wrote: >> On 15/05/2018 14:47, Radu Pirea wrote: >>> On Mon, 2018-05-14 at 12:57 +0200, Richard Genoud wrote: >>>> After your patch, the DMA is not selected anymore: >>

Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

On 25/05/2018 14:17, Radu Pirea wrote: > > > On 05/15/2018 04:14 PM, Richard Genoud wrote: >> On 15/05/2018 14:47, Radu Pirea wrote: >>> On Mon, 2018-05-14 at 12:57 +0200, Richard Genoud wrote: >>>> After your patch, the DMA is not selected anymore: >>

Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

On 15/05/2018 14:47, Radu Pirea wrote: > On Mon, 2018-05-14 at 12:57 +0200, Richard Genoud wrote: >> After your patch, the DMA is not selected anymore: >> atmel_usart_serial atmel_usart_serial.0.auto: TX channel not >> available, switch to pio >> instead of: >> a

Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

On 15/05/2018 14:47, Radu Pirea wrote: > On Mon, 2018-05-14 at 12:57 +0200, Richard Genoud wrote: >> After your patch, the DMA is not selected anymore: >> atmel_usart_serial atmel_usart_serial.0.auto: TX channel not >> available, switch to pio >> instead of: >> a

Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

On 14/05/2018 18:56, Andy Shevchenko wrote: > On Mon, May 14, 2018 at 1:57 PM, Richard Genoud > <richard.gen...@gmail.com> wrote: >> On 11/05/2018 12:38, Radu Pirea wrote: >>> This patch modifies the place where resources and device tree properties >>> are searc

Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

On 14/05/2018 18:56, Andy Shevchenko wrote: > On Mon, May 14, 2018 at 1:57 PM, Richard Genoud > wrote: >> On 11/05/2018 12:38, Radu Pirea wrote: >>> This patch modifies the place where resources and device tree properties >>> are searched. > >> I thin

Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

Hi, On 11/05/2018 12:38, Radu Pirea wrote: > This patch modifies the place where resources and device tree properties > are searched. > > Signed-off-by: Radu Pirea > --- > drivers/tty/serial/Kconfig| 1 + > drivers/tty/serial/atmel_serial.c | 29

Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

Hi, On 11/05/2018 12:38, Radu Pirea wrote: > This patch modifies the place where resources and device tree properties > are searched. > > Signed-off-by: Radu Pirea > --- > drivers/tty/serial/Kconfig| 1 + > drivers/tty/serial/atmel_serial.c | 29 +++-- > 2

[PATCH v2] clk: mvebu: armada-38x: add support for missing clocks

l.org> # 3.16.x: 9593f4f56cf5: clk: mvebu: armada-38x: add support for 1866MHz variants Cc: <sta...@vger.kernel.org> # 3.16.x Signed-off-by: Richard Genoud <richard.gen...@gmail.com> Acked-by: Gregory CLEMENT <gregory.clem...@bootlin.com> --- drivers/clk/mvebu/armada-38x.c |

[PATCH v2] clk: mvebu: armada-38x: add support for missing clocks

56cf5: clk: mvebu: armada-38x: add support for 1866MHz variants Cc: # 3.16.x Signed-off-by: Richard Genoud Acked-by: Gregory CLEMENT --- drivers/clk/mvebu/armada-38x.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/clk/mvebu/armada-38x.c b/drivers/clk/mv

Re: [PATCH] clk: mvebu: armada-38x: add support for missing clocks

On 08/03/2018 14:23, Gregory CLEMENT wrote: > Hi, > > On jeu., mars 08 2018, Gregory CLEMENT <gregory.clem...@bootlin.com> wrote: > >> Hi Richard, >> >> On jeu., mars 08 2018, Richard Genoud <richard.gen...@gmail.com> wrote: >> >>&g

Re: [PATCH] clk: mvebu: armada-38x: add support for missing clocks

On 08/03/2018 14:23, Gregory CLEMENT wrote: > Hi, > > On jeu., mars 08 2018, Gregory CLEMENT wrote: > >> Hi Richard, >> >> On jeu., mars 08 2018, Richard Genoud wrote: >> >>> Clearfog boards can come with a CPU clocked at 1600MHz (commercial) &

[PATCH] clk: mvebu: armada-38x: add support for missing clocks

with this button down, the frequency 666MHz is selected (and the kernel didn't boot). This patch add all the missing clocks. The only mode I didn't test is 2GHz (uboot found 4294MHz instead :/ ). Signed-off-by: Richard Genoud <richard.gen...@gmail.com> --- drivers/clk/mvebu/armada-38x.

[PATCH] clk: mvebu: armada-38x: add support for missing clocks

with this button down, the frequency 666MHz is selected (and the kernel didn't boot). This patch add all the missing clocks. The only mode I didn't test is 2GHz (uboot found 4294MHz instead :/ ). Signed-off-by: Richard Genoud --- drivers/clk/mvebu/armada-38x.c | 14 +++--- 1 file changed, 7

Re: Soft lockup in rt2x00usb_work_rxdone()

Le mercredi 08 novembre 2017 à 11:37 +0100, Stanislaw Gruszka a écrit : > On Tue, Nov 07, 2017 at 12:01:23PM +0100, Richard Genoud wrote: > > Le mardi 07 novembre 2017 à 11:13 +0100, Stanislaw Gruszka a > > écrit : > > > On Tue, Nov 07, 2017 at 11:06:39AM +0100, Richard G

Re: Soft lockup in rt2x00usb_work_rxdone()

Le mercredi 08 novembre 2017 à 11:37 +0100, Stanislaw Gruszka a écrit : > On Tue, Nov 07, 2017 at 12:01:23PM +0100, Richard Genoud wrote: > > Le mardi 07 novembre 2017 à 11:13 +0100, Stanislaw Gruszka a > > écrit : > > > On Tue, Nov 07, 2017 at 11:06:39AM +0100, Richard G

Re: Soft lockup in rt2x00usb_work_rxdone()

Le mardi 07 novembre 2017 à 11:13 +0100, Stanislaw Gruszka a écrit : > On Tue, Nov 07, 2017 at 11:06:39AM +0100, Richard Genoud wrote: > > > 3 short articles how to configure and use ftrace are here: > > > https://lwn.net/Articles/365835/ > > > https://lwn.ne

Re: Soft lockup in rt2x00usb_work_rxdone()

Le mardi 07 novembre 2017 à 11:13 +0100, Stanislaw Gruszka a écrit : > On Tue, Nov 07, 2017 at 11:06:39AM +0100, Richard Genoud wrote: > > > 3 short articles how to configure and use ftrace are here: > > > https://lwn.net/Articles/365835/ > > > https://lwn.ne

Re: Soft lockup in rt2x00usb_work_rxdone()

Le mardi 07 novembre 2017 à 11:13 +0100, Stanislaw Gruszka a écrit : > On Tue, Nov 07, 2017 at 11:06:39AM +0100, Richard Genoud wrote: > > > 3 short articles how to configure and use ftrace are here: > > > https://lwn.net/Articles/365835/ > > > https://lwn.ne

Re: Soft lockup in rt2x00usb_work_rxdone()

Le mardi 07 novembre 2017 à 11:13 +0100, Stanislaw Gruszka a écrit : > On Tue, Nov 07, 2017 at 11:06:39AM +0100, Richard Genoud wrote: > > > 3 short articles how to configure and use ftrace are here: > > > https://lwn.net/Articles/365835/ > > > https://lwn.ne

Re: Soft lockup in rt2x00usb_work_rxdone()

2017-11-07 9:53 GMT+01:00 Stanislaw Gruszka <sgrus...@redhat.com>: > Hi Hi ! > > On Mon, Nov 06, 2017 at 04:57:09PM +0100, Richard Genoud wrote: >> I get a soft lock-up while unbinding the USB driver on a TP-Link TL-WN727Nv3 >> (chipset 5370): >> >> # echo

Re: Soft lockup in rt2x00usb_work_rxdone()

2017-11-07 9:53 GMT+01:00 Stanislaw Gruszka : > Hi Hi ! > > On Mon, Nov 06, 2017 at 04:57:09PM +0100, Richard Genoud wrote: >> I get a soft lock-up while unbinding the USB driver on a TP-Link TL-WN727Nv3 >> (chipset 5370): >> >> # echo 1-2.2 > /sys/bus/usb

Soft lockup in rt2x00usb_work_rxdone()

Hi, I get a soft lock-up while unbinding the USB driver on a TP-Link TL-WN727Nv3 (chipset 5370): # echo 1-2.2 > /sys/bus/usb/drivers/usb/unbind watchdog: BUG: soft lockup - CPU#0 stuck for 23s! [kworker/u2:3:308] CPU: 0 PID: 308 Comm: kworker/u2:3 Not tainted 4.14.0-rc8 #11 Hardware name: Atmel

Soft lockup in rt2x00usb_work_rxdone()

Hi, I get a soft lock-up while unbinding the USB driver on a TP-Link TL-WN727Nv3 (chipset 5370): # echo 1-2.2 > /sys/bus/usb/drivers/usb/unbind watchdog: BUG: soft lockup - CPU#0 stuck for 23s! [kworker/u2:3:308] CPU: 0 PID: 308 Comm: kworker/u2:3 Not tainted 4.14.0-rc8 #11 Hardware name: Atmel

[PATCH] tty/serial: atmel: Convert timers to use timer_setup()

Le mardi 24 octobre 2017 à 03:00 -0700, Kees Cook a écrit : > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > Cc: Richar

[PATCH] tty/serial: atmel: Convert timers to use timer_setup()

Le mardi 24 octobre 2017 à 03:00 -0700, Kees Cook a écrit : > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > Cc: Richa

[PATCH] mtd: nand: atmel: fix buffer overflow in atmel_pmecc_user

eanup/rework the atmel_nand driver") Cc: Nicolas Ferre <nicolas.fe...@microchip.com> Cc: sta...@vger.kernel.org Reported-by: Richard Genoud <richard.gen...@gmail.com> Pointed-at-by: Boris Brezillon <boris.brezil...@free-electrons.com> Signed-off-by: Richard Genoud <richard.gen

[PATCH] mtd: nand: atmel: fix buffer overflow in atmel_pmecc_user

eanup/rework the atmel_nand driver") Cc: Nicolas Ferre Cc: sta...@vger.kernel.org Reported-by: Richard Genoud Pointed-at-by: Boris Brezillon Signed-off-by: Richard Genoud --- drivers/mtd/nand/atmel/pmecc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/atm

Re: atmel_nand: kernel panic when ecc_strength==4

2017-09-27 12:15 GMT+02:00 Richard Genoud <richard.gen...@gmail.com>: > 2017-09-27 12:04 GMT+02:00 Boris Brezillon > <boris.brezil...@free-electrons.com>: >> On Wed, 27 Sep 2017 11:05:57 +0200 >> Richard Genoud <richard.gen...@gmail.com> wrote: >> &g

Re: atmel_nand: kernel panic when ecc_strength==4

2017-09-27 12:15 GMT+02:00 Richard Genoud : > 2017-09-27 12:04 GMT+02:00 Boris Brezillon > : >> On Wed, 27 Sep 2017 11:05:57 +0200 >> Richard Genoud wrote: >> >>> Hi Boris, Nicolas ! >>> >>> Since commit f88fc122cc34 ("mtd: nand: Cleanu

Re: atmel_nand: kernel panic when ecc_strength==4

2017-09-27 12:04 GMT+02:00 Boris Brezillon <boris.brezil...@free-electrons.com>: > On Wed, 27 Sep 2017 11:05:57 +0200 > Richard Genoud <richard.gen...@gmail.com> wrote: > >> Hi Boris, Nicolas ! >> >> Since commit f88fc122cc34 ("mtd: nand: Cleanup/rewo

Re: atmel_nand: kernel panic when ecc_strength==4

2017-09-27 12:04 GMT+02:00 Boris Brezillon : > On Wed, 27 Sep 2017 11:05:57 +0200 > Richard Genoud wrote: > >> Hi Boris, Nicolas ! >> >> Since commit f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") >> strange things happen when nand-ecc-

atmel_nand: kernel panic when ecc_strength==4

Hi Boris, Nicolas ! Since commit f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") strange things happen when nand-ecc-strength = <4>; (previously atmel,pmecc-cap). I first saw that a NULL pointer dereference happened when "udevadm trigger" was launched. With strace, I nailed it

atmel_nand: kernel panic when ecc_strength==4

Hi Boris, Nicolas ! Since commit f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") strange things happen when nand-ecc-strength = <4>; (previously atmel,pmecc-cap). I first saw that a NULL pointer dereference happened when "udevadm trigger" was launched. With strace, I nailed it

Re: [PATCH v2 9/9] tty/serial: atmel: Prevent a warning on suspend

mel_stop_tx(struct uart_port *port) > if ((port->rs485.flags & SER_RS485_ENABLED) && > !(port->rs485.flags & SER_RS485_RX_DURING_TX)) > atmel_start_rx(port); > + > } This line feed is not needed. Otherwise, Acked-by: Richar

Re: [PATCH v2 9/9] tty/serial: atmel: Prevent a warning on suspend

rt) > if ((port->rs485.flags & SER_RS485_ENABLED) && > !(port->rs485.flags & SER_RS485_RX_DURING_TX)) > atmel_start_rx(port); > + > } This line feed is not needed. Otherwise, Acked-by: Richard Genoud > >

Re: [PATCH v2] ARM: zImage: Fix stack overflow in merge_fdt_bootargs()

property was found in the FDT. > > Signed-off-by: Rask Ingemann Lambertsen <r...@formelder.dk> > Tested-by: Pavel Machek <pa...@ucw.cz> > Tested-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> > Fixes: d0f34a11ddab ("ARM: 7437/1: zImage: Allow DTB comm

Re: [PATCH v2] ARM: zImage: Fix stack overflow in merge_fdt_bootargs()

FDT. > > Signed-off-by: Rask Ingemann Lambertsen > Tested-by: Pavel Machek > Tested-by: Sebastian Reichel > Fixes: d0f34a11ddab ("ARM: 7437/1: zImage: Allow DTB command line > concatenation with ATAG_CMDLINE") seems good to me ! Reviewed-by: Richard Genoud >

Re: [PATCH] ARM: zImage: Fix stack overflow in merge_fdt_bootargs()

On 16/07/2017 23:43, Rask Ingemann Lambertsen wrote: > This function is called very early on from head.S and currently sets up a > stack frame of more than 1024 bytes: > > atags_to_fdt.c: In function ‘merge_fdt_bootargs’: > atags_to_fdt.c:98:1: warning: the frame size of 1032 bytes is larger than

Re: [PATCH] ARM: zImage: Fix stack overflow in merge_fdt_bootargs()

On 16/07/2017 23:43, Rask Ingemann Lambertsen wrote: > This function is called very early on from head.S and currently sets up a > stack frame of more than 1024 bytes: > > atags_to_fdt.c: In function ‘merge_fdt_bootargs’: > atags_to_fdt.c:98:1: warning: the frame size of 1032 bytes is larger than

Re: [PATCH 3.10 219/268] tty/serial: atmel: fix race condition (TX+DMA)

Hi Willy, You can drop this patch. There's nothing to fix on 3.10.x since the DMA TX support has been introduced in 3.12. Thanks ! 2017-06-19 20:31 GMT+02:00 Willy Tarreau <w...@1wt.eu>: > From: Richard Genoud <richard.gen...@gmail.com> > > commit 31ca2c63fdc0aee725c

Re: [PATCH 3.10 219/268] tty/serial: atmel: fix race condition (TX+DMA)

Hi Willy, You can drop this patch. There's nothing to fix on 3.10.x since the DMA TX support has been introduced in 3.12. Thanks ! 2017-06-19 20:31 GMT+02:00 Willy Tarreau : > From: Richard Genoud > > commit 31ca2c63fdc0aee725cbd4f207c1256f5deaabde upstream. > > If ua

[PATCH] kbuild: fix header installation under fakechroot environment

r ! Fixes: fcc8487d477a ("uapi: export all headers under uapi directories") Signed-off-by: Richard Genoud <richard.gen...@gmail.com> --- scripts/Makefile.headersinst | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.headersinst b/scripts/

[PATCH] kbuild: fix header installation under fakechroot environment

r ! Fixes: fcc8487d477a ("uapi: export all headers under uapi directories") Signed-off-by: Richard Genoud --- scripts/Makefile.headersinst | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst index ce753a408c56.

Re: [PATCH] tty/serial: Kconfig: remove AVR32

ctrons.com> Acked-by: Richard Genoud <richard.gen...@gmail.com> 100 lines removed with the 4 patches, that's nice ! Thanks !

Re: [PATCH] tty/serial: Kconfig: remove AVR32

On 13/06/2017 22:35, Alexandre Belloni wrote: > AVR32 is now removed from the kernel, removed the config symbol that > doesn't exist anymore. Also take the opportunity to reword the help to > include sama5. > > Signed-off-by: Alexandre Belloni Acked-by: Richard Genoud 10

Re: [PATCH] tty/serial: remove AVR32 specific access wrappers

On 13/06/2017 22:25, Alexandre Belloni wrote: > Now that AVR32 is gone, the specific wrappers for that architecture are > unnecessary and will not be compiled anymore. > > Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Acked-by: Richard Genoud <richard.gen...@gmail.com>

Re: [PATCH] tty/serial: remove AVR32 specific access wrappers

On 13/06/2017 22:25, Alexandre Belloni wrote: > Now that AVR32 is gone, the specific wrappers for that architecture are > unnecessary and will not be compiled anymore. > > Signed-off-by: Alexandre Belloni Acked-by: Richard Genoud

Re: [PATCH v2 2/2] tty/serial: atmel: make the driver DT only

free-electrons.com> > --- > drivers/tty/serial/atmel_serial.c | 96 > + > include/linux/platform_data/atmel.h | 10 > 2 files changed, 33 insertions(+), 73 deletions(-) Acked-by: Richard Genoud <richard.gen...@gmail.com>

Re: [PATCH v2 2/2] tty/serial: atmel: make the driver DT only

; drivers/tty/serial/atmel_serial.c | 96 > + > include/linux/platform_data/atmel.h | 10 > 2 files changed, 33 insertions(+), 73 deletions(-) Acked-by: Richard Genoud

Re: [PATCH v2 1/2] tty/serial: atmel: remove atmel_default_console_device handling

t; > --- > > Changes in v2: > - added an empty line as suggested by Andy > - properly based the patch on v4.12-rc1 > > drivers/tty/serial/atmel_serial.c | 43 > --- > 1 file changed, 43 deletions(-) > Acked-by: Richard Genoud <richard.gen...@gmail.com> Thanks !

Re: [PATCH v2 1/2] tty/serial: atmel: remove atmel_default_console_device handling

> - added an empty line as suggested by Andy > - properly based the patch on v4.12-rc1 > > drivers/tty/serial/atmel_serial.c | 43 > --- > 1 file changed, 43 deletions(-) > Acked-by: Richard Genoud Thanks !

Re: [PATCH] gpio: mvebu: change compatible string for PWM support

2017-06-09 9:42 GMT+02:00 Linus Walleij : > On Thu, Jun 1, 2017 at 10:08 PM, Ralph Sennhauser > wrote: > >> As it turns out more than just Armada 370 and XP support using GPIO >> lines as PWM lines. For example the Armada 38x family has the

Re: [PATCH] gpio: mvebu: change compatible string for PWM support

2017-06-09 9:42 GMT+02:00 Linus Walleij : > On Thu, Jun 1, 2017 at 10:08 PM, Ralph Sennhauser > wrote: > >> As it turns out more than just Armada 370 and XP support using GPIO >> lines as PWM lines. For example the Armada 38x family has the same >> hardware support. As such

Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection

2017-06-09 9:37 GMT+02:00 Linus Walleij <linus.wall...@linaro.org>: > On Thu, Jun 1, 2017 at 2:18 PM, Richard Genoud <richard.gen...@gmail.com> > wrote: > >> The blink counter A was always selected because 0 was forced in the >> blink select counter register. &g

Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection

2017-06-09 9:37 GMT+02:00 Linus Walleij : > On Thu, Jun 1, 2017 at 2:18 PM, Richard Genoud > wrote: > >> The blink counter A was always selected because 0 was forced in the >> blink select counter register. >> The variable 'set' was obviously there to be used as the r

[PATCHv2 2/2] gpio: mvebu: fix gpio bank registration when pwm is used

e = id * MVEBU_MAX_GPIO_PER_BANK; Tested on clearfog-pro (Marvell 88F6828) Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support") Signed-off-by: Richard Genoud <richard.gen...@gmail.com> --- drivers/gpio/gpio-mvebu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/dr

  1   2   3   4   5   6   7   8   9   >