Re: [PATCH 0/4] remoteproc: k3-r5: Introduce suspend to ram support

2024-07-08 Thread Richard GENOUD
Le 01/07/2024 à 11:59, Hari Nagalla a écrit : On 6/21/24 10:00, Richard Genoud wrote: Richard Genoud (4):    remoteproc: k3-r5: Fix IPC-only mode detection    remoteproc: k3-r5: Introduce PM suspend/resume handlers    remoteproc: k3-r5: k3_r5_rproc_stop: code reorder    remoteproc: k3-r5

Re: [PATCH 3/4] remoteproc: k3-r5: k3_r5_rproc_stop: code reorder

2024-07-01 Thread Richard GENOUD
Le 01/07/2024 à 18:35, Mathieu Poirier a écrit : On Mon, Jul 01, 2024 at 10:03:22AM +0200, Richard GENOUD wrote: Le 28/06/2024 à 23:18, Mathieu Poirier a écrit : On Fri, Jun 21, 2024 at 05:00:57PM +0200, Richard Genoud wrote: In the next commit, a RP_MBOX_SHUTDOWN message will be sent in

Re: [PATCH 4/4] remoteproc: k3-r5: support for graceful stop of remote cores

2024-07-01 Thread Richard GENOUD
Le 29/06/2024 à 00:50, Andrew Davis a écrit : On 6/21/24 10:00 AM, Richard Genoud wrote: Introduce software IPC handshake between the K3-R5 remote proc driver and the R5 MCU to gracefully stop/reset the remote core. Upon a stop request, K3-R5 remote proc driver sends a RP_MBOX_SHUTDOWN mailbox

Re: [PATCH 4/4] remoteproc: k3-r5: support for graceful stop of remote cores

2024-07-01 Thread Richard GENOUD
[adding Vibhore in Cc] Le 28/06/2024 à 23:20, Mathieu Poirier a écrit : On Fri, Jun 21, 2024 at 05:00:58PM +0200, Richard Genoud wrote: Introduce software IPC handshake between the K3-R5 remote proc driver and the R5 MCU to gracefully stop/reset the remote core. Upon a stop request, K3-R5

Re: [PATCH 3/4] remoteproc: k3-r5: k3_r5_rproc_stop: code reorder

2024-07-01 Thread Richard GENOUD
Le 28/06/2024 à 23:18, Mathieu Poirier a écrit : On Fri, Jun 21, 2024 at 05:00:57PM +0200, Richard Genoud wrote: In the next commit, a RP_MBOX_SHUTDOWN message will be sent in k3_r5_rproc_stop() to the remote proc (in lockstep on not) Thus, the sanity check "do not allow core 0 to stop b

Re: [PATCH 2/4] remoteproc: k3-r5: Introduce PM suspend/resume handlers

2024-07-01 Thread Richard GENOUD
Le 28/06/2024 à 22:48, Mathieu Poirier a écrit : On Fri, Jun 21, 2024 at 05:00:56PM +0200, Richard Genoud wrote: This patch adds the support for system suspend/resume to the ti_k3_R5 remoteproc driver. In order to save maximum power, the approach here is to shutdown completely the cores that

[PATCH 1/4] remoteproc: k3-r5: Fix IPC-only mode detection

2024-06-21 Thread Richard Genoud
PC-only mode instead of a mismatched mode. Fixes: 1168af40b1ad ("remoteproc: k3-r5: Add support for IPC-only mode for all R5Fs") Signed-off-by: Richard Genoud --- drivers/remoteproc/ti_k3_r5_remoteproc.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-)

[PATCH 4/4] remoteproc: k3-r5: support for graceful stop of remote cores

2024-06-21 Thread Richard Genoud
the remote core through device manager Based on work from: Hari Nagalla Signed-off-by: Richard Genoud --- drivers/remoteproc/omap_remoteproc.h | 9 +- drivers/remoteproc/ti_k3_r5_remoteproc.c | 40 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a

[PATCH 3/4] remoteproc: k3-r5: k3_r5_rproc_stop: code reorder

2024-06-21 Thread Richard Genoud
de actions - !cluster_mode sanity check - !cluster_mode actions And now: - !cluster_mode sanity check - cluster_mode actions - !cluster_mode actions Signed-off-by: Richard Genoud --- drivers/remoteproc/ti_k3_r5_remoteproc.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletion

[PATCH 2/4] remoteproc: k3-r5: Introduce PM suspend/resume handlers

2024-06-21 Thread Richard Genoud
detached and processor control released. On resume, the reverse operation is done. Based on work from: Hari Nagalla Signed-off-by: Richard Genoud --- drivers/remoteproc/ti_k3_r5_remoteproc.c | 123 ++- 1 file changed, 121 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 0/4] remoteproc: k3-r5: Introduce suspend to ram support

2024-06-21 Thread Richard Genoud
omap-mailbox 31f81000.mailbox: PM: failed to suspend: error -16 Patches 2 and 4 are based on work from Hari Nagalla . @Hari, please feel free to add your Co-developed-by:/Signed-off-by: Tested on J7200X SoM Series is based on v6.10-rc4 Richard Genoud (4): remoteproc: k3-r5: Fix IPC-only mode

Re: [PATCH 2/4] tty: atmel_serial: convert tasklets to use new tasklet_setup() API

2020-08-26 Thread Richard Genoud
> > Signed-off-by: Romain Perier > Signed-off-by: Allen Pais Acked-by: Richard Genoud > --- > drivers/tty/serial/atmel_serial.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/tty/serial/atmel_serial.c >

Re: [PATCH] can: m_can_platform: fix m_can_runtime_suspend()

2020-06-09 Thread Richard Genoud
Hi Dan, Le 08/06/2020 à 16:27, Dan Murphy a écrit : Richard On 6/8/20 4:43 AM, Richard Genoud wrote: Since commit f524f829b75a ("can: m_can: Create a m_can platform framework"), the can peripheral on STM32MP1 wasn't working anymore. The reason was a bad copy/paste maneuver th

[PATCH] can: m_can_platform: fix m_can_runtime_suspend()

2020-06-08 Thread Richard Genoud
BC-Argon Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework") Signed-off-by: Richard Genoud --- drivers/net/can/m_can/m_can_platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_plat

Re: [PATCH v6 2/2] tty: add rpmsg driver

2019-09-05 Thread Richard Genoud
Hi Arnaud, Le 04/09/2019 à 15:09, Arnaud Pouliquen a écrit : > This driver exposes a standard tty interface on top of the rpmsg > framework through a rpmsg service. > > This driver supports multi-instances, offering a /dev/ttyRPMSGx entry > per rpmsg endpoint. > > Signed-off-by: Arnaud Pouliquen

[PATCH v2] tty/serial: atmel: remove unneeded atmel_get_lines_status function

2019-08-26 Thread Richard Genoud
eine-König Acked-by: Uwe Kleine-König Signed-off-by: Richard Genoud --- drivers/tty/serial/atmel_serial.c | 48 ++- 1 file changed, 2 insertions(+), 46 deletions(-) Changes from v1: - point out the right commit (thx Uwe) - add Suggested-by/Acked-by diff --git a/drivers/

[PATCH] tty/serial: atmel: remove unneeded atmel_get_lines_status function

2019-08-23 Thread Richard Genoud
Since commit ce59e48fdbad ("serial: mctrl_gpio: implement interrupt handling"), the GPIOs interrupts are handled by mctrl_gpio_irq_handle(). So, atmel_get_lines_status() can be completely killed and replaced by : atmel_uart_readl(port, ATMEL_US_CSR); Signed-off-by: Richard Genoud --

Re: [PATCH v2 2/2] tty/serial: atmel: RS485 HD w/DMA: enable RX after TX is stopped

2019-03-26 Thread Richard Genoud
1 ("tty/serial: atmel: RS485 half duplex w/DMA: enable > RX after TX is done") > Signed-off-by: Razvan Stefanescu Acked-by: Richard Genoud NB: backport on kernel older than 4.20 will fail because of the iso7816 variables fidi_min/fidi_max. > --- > Changelog: > v2: > - sta

Re: [PATCH v2 1/2] tty/serial: atmel: Add is_half_duplex helper

2019-03-26 Thread Richard Genoud
RX after TX is done") > Signed-off-by: Razvan Stefanescu Acked-by: Richard Genoud NB: backport on kernel older than 4.20 will fail because of the SER_ISO7816_ENABLED flag. > --- > Changelog: > v2: > - remove extra check > - add fix info > > drivers/tty/serial/

Re: [PATCH 2/2] tty/serial: atmel: RS485 HD w/DMA: enable RX after TX is stopped

2019-03-18 Thread Richard Genoud
[ adding Gil Weber in Cc: ] Le 15/03/2019 à 10:23, Razvan Stefanescu a écrit : > In half-duplex operation, RX should be started after TX completes. > > If DMA is used, there is a case when the DMA transfer completes but the > TX FIFO is not emptied, so the RX cannot be restarted just yet. > > Use

Re: [PATCH 1/2] tty/serial: atmel: Add is_half_duplex helper

2019-03-18 Thread Richard Genoud
[ adding Gil Weber in Cc: ] Le 15/03/2019 à 10:23, Razvan Stefanescu a écrit : > Use a helper function to check that a port needs to use half duplex > communication, replacing several occurrences of multi-line bit checking. > > Signed-off-by: Razvan Stefanescu > --- > drivers/tty/serial/atmel_s

Re: [PATCH] tty: atmel_serial: fix a NULL pointer dereference

2019-03-18 Thread Richard Genoud
Le 15/03/2019 à 18:16, Kangjie Lu a écrit : > In case dmaengine_prep_dma_cyclic fails, the fix returns a proper > error code to avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu > Fixes: 34df42f59a60 ("serial: at91: add rx dma support") Acked-by: Richa

Re: [PATCH v2] tty: atmel_serial: fix a NULL pointer dereference

2019-03-15 Thread Richard Genoud
rence. > > Signed-off-by: Kangjie Lu ^^^ here > > --- > V2: simplified the patch as suggested by > Richard Genoud > --- > drivers/tty/serial/atmel_serial.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/tty/serial/atmel_serial.c >

Re: [PATCH] tty: atmel_serial: fix a NULL pointer dereference

2019-03-14 Thread Richard Genoud
Hi, Good catch ! Le 14/03/2019 à 08:17, Kangjie Lu a écrit : > In case dmaengine_prep_dma_cyclic fails, the fix return a proper > error code to avoid NULL pointer dereference. > you could add: Fixes: 34df42f59a60 ("serial: at91: add rx dma support") So that -stable branches get this. > Signed-of

[PATCH] dmaengine: at_hdmac: fix memory leak in at_dma_xlate()

2018-11-27 Thread Richard Genoud
lloni Acked-by: Alexandre Belloni Signed-off-by: Richard Genoud --- drivers/dma/at_hdmac.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 7cbac6e8c113..1b7f0ca0d5cd 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers

[PATCH] dmaengine: at_hdmac: fix module unloading

2018-11-27 Thread Richard Genoud
org Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding") Signed-off-by: Richard Genoud --- drivers/dma/at_hdmac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 1b7f0ca0d5cd..01d936c9fe89 100644 --- a/drivers/dma/at_

Re: DMA: atmel_serial: Opening and closing the serial device repeatedly causes kmalloc-32 slab leak

2018-11-27 Thread Richard Genoud
Le 27/11/2018 à 10:58, Alexandre Belloni a écrit : > Hello Richard, > > On 27/11/2018 10:51:13+0100, richard.gen...@gmail.com wrote: >> Hi all, >> >> I reproduced the memory leak on my board (at91sam9g35-cm) with a 4.20-rc3. >> >> It triggered an OOM after a couple of hours running a code like thi

DMA: atmel_serial: Opening and closing the serial device repeatedly causes kmalloc-32 slab leak

2018-11-27 Thread richard . genoud
[re-sending with Vinod's correct email address. Sorry for the noise. ] [re-sending the bug report to the lists] Le 16/11/2018 à 17:04, Mario Forner a écrit : > Problem: > When I open and close the serial device /dev/ttyS4 in a loop > the amount of kmalloc-32 slabs increases slowly but steadily wit

DMA: atmel_serial: Opening and closing the serial device repeatedly causes kmalloc-32 slab leak

2018-11-27 Thread richard . genoud
[re-sending the bug report to the lists] Le 16/11/2018 à 17:04, Mario Forner a écrit : > Problem: > When I open and close the serial device /dev/ttyS4 in a loop > the amount of kmalloc-32 slabs increases slowly but steadily without limit. > > The serial device is configured in acme-aria.dts to use

Re: [PATCH v4 2/2] tty/serial: atmel: add ISO7816 support

2018-09-10 Thread Richard Genoud
; function as well. > > Signed-off-by: Nicolas Ferre > [ludovic.desroc...@microchip.com: rebase, add check on fidi ratio, checkpatch > fixes] > Signed-off-by: Ludovic Desroches This seems ok for me. Acked-by: Richard Genoud Thanks !

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

2018-09-05 Thread Richard Genoud
[added Nicolas back in the thread, he was removed somehow] Hi Ludovic ! On 05/09/2018 14:43, Ludovic Desroches wrote: > Hi Richard, > > On Thu, Aug 09, 2018 at 01:30:35PM +0200, Ludovic Desroches wrote: >> Hi Richard, >> >> On Thu, Aug 09, 2018 at 10:47:17AM +0200, R

Re: [PATCH RESEND 2/2] gpio: mvebu: Allow to use non-default PWM counter

2018-08-09 Thread Richard Genoud
Hi, On 06/08/2018 15:52, Andrew Lunn wrote: > On Mon, Aug 06, 2018 at 10:29:16AM +0800, Aditya Prayoga wrote: >> On multiple PWM lines, if the other PWM counter is unused, allocate it >> to next PWM request. The priority would be: >> 1. Default counter assigned to the bank >> 2. Unused counter tha

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

2018-08-09 Thread Richard Genoud
Hi ! On 07/08/2018 15:00, Ludovic Desroches wrote: > From: Nicolas Ferre > > When mode is set in atmel_config_iso7816() we backup last RS232 mode > for coming back to this mode if requested. > Also allow setup of T=0 and T=1 parameter and basic support in set_termios > function as well. > > Sig

Re: [PATCH 0/2] gpio: mvebu: Add support for multiple PWM lines

2018-08-03 Thread Richard Genoud
On 03/08/2018 11:42, Richard Genoud wrote: > On 03/08/2018 11:36, Gregory CLEMENT wrote: >> Hi Linus and Adita >> >> On dim., juil. 29 2018, Linus Walleij wrote: >> >>> Hoping for some review from Gergory, Ralph or Richard who all seem >>> to u

Re: [PATCH 0/2] gpio: mvebu: Add support for multiple PWM lines

2018-08-03 Thread Richard Genoud
On 03/08/2018 11:36, Gregory CLEMENT wrote: > Hi Linus and Adita > > On dim., juil. 29 2018, Linus Walleij wrote: > >> Hoping for some review from Gergory, Ralph or Richard who all seem >> to use this driver! > > Would it be possible to resend the series adding me in CC? I would > like to co

Re: [PATCH v2 2/2] tty/serial: atmel: add ISO7816 support

2018-07-27 Thread Richard Genoud
Hi Ludovic, On 19/07/2018 10:47, Ludovic Desroches wrote: > From: Nicolas Ferre > > When mode is set in atmel_config_iso7816() we backup last RS232 mode > for coming back to this mode if requested. > Also allow setup of T=0 and T=1 parameter and basic support in set_termios > function as well. >

Re: [PATCH v6 6/6] tty/serial: atmel: change the driver to work under at91-usart mfd

2018-06-07 Thread Richard Genoud
atmel_port->clk = clk_get(&mpdev->dev, "usart"); > if (IS_ERR(atmel_port->clk)) { > ret = PTR_ERR(atmel_port->clk); > atmel_port->clk = NULL; > @@ -2694,13 +2696,22 @@ static void atmel_serial_probe_fifos(struct >

Re: [PATCH v5 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

2018-06-06 Thread Richard Genoud
Typo in the subject: changed->change On 04/06/2018 18:59, Radu Pirea wrote: > This patch modifies the place where resources and device tree properties > are searched. > > Signed-off-by: Radu Pirea > --- > drivers/tty/serial/Kconfig| 1 + > drivers/tty/serial/atmel_serial.c | 41 ++

Re: [PATCH v4 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

2018-05-28 Thread Richard Genoud
On 25/05/2018 19:19, Radu Pirea wrote: > This patch modifies the place where resources and device tree properties > are searched. > > Signed-off-by: Radu Pirea > --- > drivers/tty/serial/Kconfig| 1 + > drivers/tty/serial/atmel_serial.c | 40 +-- > 2 files ch

Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

2018-05-25 Thread Richard Genoud
On 25/05/2018 14:17, Radu Pirea wrote: > > > On 05/15/2018 04:14 PM, Richard Genoud wrote: >> On 15/05/2018 14:47, Radu Pirea wrote: >>> On Mon, 2018-05-14 at 12:57 +0200, Richard Genoud wrote: >>>> After your patch, the DMA is not selected anymore: >>

Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

2018-05-15 Thread Richard Genoud
On 15/05/2018 14:47, Radu Pirea wrote: > On Mon, 2018-05-14 at 12:57 +0200, Richard Genoud wrote: >> After your patch, the DMA is not selected anymore: >> atmel_usart_serial atmel_usart_serial.0.auto: TX channel not >> available, switch to pio >> instead of: >> a

Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

2018-05-14 Thread Richard Genoud
On 14/05/2018 18:56, Andy Shevchenko wrote: > On Mon, May 14, 2018 at 1:57 PM, Richard Genoud > wrote: >> On 11/05/2018 12:38, Radu Pirea wrote: >>> This patch modifies the place where resources and device tree properties >>> are searched. > >> I thin

Re: [PATCH v3 6/6] tty/serial: atmel: changed the driver to work under at91-usart mfd

2018-05-14 Thread Richard Genoud
Hi, On 11/05/2018 12:38, Radu Pirea wrote: > This patch modifies the place where resources and device tree properties > are searched. > > Signed-off-by: Radu Pirea > --- > drivers/tty/serial/Kconfig| 1 + > drivers/tty/serial/atmel_serial.c | 29 +++-- > 2 files

[PATCH v2] clk: mvebu: armada-38x: add support for missing clocks

2018-03-13 Thread Richard Genoud
x: 9593f4f56cf5: clk: mvebu: armada-38x: add support for 1866MHz variants Cc: # 3.16.x Signed-off-by: Richard Genoud Acked-by: Gregory CLEMENT --- drivers/clk/mvebu/armada-38x.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/clk/mvebu/armada-38x.c b/driv

Re: [PATCH] clk: mvebu: armada-38x: add support for missing clocks

2018-03-13 Thread Richard Genoud
On 08/03/2018 14:23, Gregory CLEMENT wrote: > Hi, > > On jeu., mars 08 2018, Gregory CLEMENT wrote: > >> Hi Richard, >> >> On jeu., mars 08 2018, Richard Genoud wrote: >> >>> Clearfog boards can come with a CPU clocked at 1600MHz (commercial) &

[PATCH] clk: mvebu: armada-38x: add support for missing clocks

2018-03-08 Thread Richard Genoud
this button down, the frequency 666MHz is selected (and the kernel didn't boot). This patch add all the missing clocks. The only mode I didn't test is 2GHz (uboot found 4294MHz instead :/ ). Signed-off-by: Richard Genoud --- drivers/clk/mvebu/armada-38x.c | 14 +++--- 1 file

Re: Soft lockup in rt2x00usb_work_rxdone()

2017-11-08 Thread Richard Genoud
Le mercredi 08 novembre 2017 à 11:37 +0100, Stanislaw Gruszka a écrit : > On Tue, Nov 07, 2017 at 12:01:23PM +0100, Richard Genoud wrote: > > Le mardi 07 novembre 2017 à 11:13 +0100, Stanislaw Gruszka a > > écrit : > > > On Tue, Nov 07, 2017 at 11:06:39AM +0100, Richard G

Re: Soft lockup in rt2x00usb_work_rxdone()

2017-11-07 Thread Richard Genoud
Le mardi 07 novembre 2017 à 11:13 +0100, Stanislaw Gruszka a écrit : > On Tue, Nov 07, 2017 at 11:06:39AM +0100, Richard Genoud wrote: > > > 3 short articles how to configure and use ftrace are here: > > > https://lwn.net/Articles/365835/ > > > https://lwn.ne

Re: Soft lockup in rt2x00usb_work_rxdone()

2017-11-07 Thread Richard Genoud
Le mardi 07 novembre 2017 à 11:13 +0100, Stanislaw Gruszka a écrit : > On Tue, Nov 07, 2017 at 11:06:39AM +0100, Richard Genoud wrote: > > > 3 short articles how to configure and use ftrace are here: > > > https://lwn.net/Articles/365835/ > > > https://lwn.ne

Re: Soft lockup in rt2x00usb_work_rxdone()

2017-11-07 Thread Richard Genoud
2017-11-07 9:53 GMT+01:00 Stanislaw Gruszka : > Hi Hi ! > > On Mon, Nov 06, 2017 at 04:57:09PM +0100, Richard Genoud wrote: >> I get a soft lock-up while unbinding the USB driver on a TP-Link TL-WN727Nv3 >> (chipset 5370): >> >> # echo 1-2.2 > /sys/bus/usb

Soft lockup in rt2x00usb_work_rxdone()

2017-11-06 Thread Richard Genoud
Hi, I get a soft lock-up while unbinding the USB driver on a TP-Link TL-WN727Nv3 (chipset 5370): # echo 1-2.2 > /sys/bus/usb/drivers/usb/unbind watchdog: BUG: soft lockup - CPU#0 stuck for 23s! [kworker/u2:3:308] CPU: 0 PID: 308 Comm: kworker/u2:3 Not tainted 4.14.0-rc8 #11 Hardware name: Atmel

[PATCH] tty/serial: atmel: Convert timers to use timer_setup()

2017-10-24 Thread Richard Genoud
Le mardi 24 octobre 2017 à 03:00 -0700, Kees Cook a écrit : > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > Cc: Richa

[PATCH] mtd: nand: atmel: fix buffer overflow in atmel_pmecc_user

2017-09-27 Thread Richard Genoud
eanup/rework the atmel_nand driver") Cc: Nicolas Ferre Cc: sta...@vger.kernel.org Reported-by: Richard Genoud Pointed-at-by: Boris Brezillon Signed-off-by: Richard Genoud --- drivers/mtd/nand/atmel/pmecc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/atm

Re: atmel_nand: kernel panic when ecc_strength==4

2017-09-27 Thread Richard Genoud
2017-09-27 12:15 GMT+02:00 Richard Genoud : > 2017-09-27 12:04 GMT+02:00 Boris Brezillon > : >> On Wed, 27 Sep 2017 11:05:57 +0200 >> Richard Genoud wrote: >> >>> Hi Boris, Nicolas ! >>> >>> Since commit f88fc122cc34 ("mtd: nand: Cleanu

Re: atmel_nand: kernel panic when ecc_strength==4

2017-09-27 Thread Richard Genoud
2017-09-27 12:04 GMT+02:00 Boris Brezillon : > On Wed, 27 Sep 2017 11:05:57 +0200 > Richard Genoud wrote: > >> Hi Boris, Nicolas ! >> >> Since commit f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") >> strange things happen when nand-ecc-

atmel_nand: kernel panic when ecc_strength==4

2017-09-27 Thread Richard Genoud
Hi Boris, Nicolas ! Since commit f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") strange things happen when nand-ecc-strength = <4>; (previously atmel,pmecc-cap). I first saw that a NULL pointer dereference happened when "udevadm trigger" was launched. With strace, I nailed it

Re: [PATCH v2 9/9] tty/serial: atmel: Prevent a warning on suspend

2017-09-20 Thread Richard Genoud
t *port) > if ((port->rs485.flags & SER_RS485_ENABLED) && > !(port->rs485.flags & SER_RS485_RX_DURING_TX)) > atmel_start_rx(port); > + > } This line feed is not needed. Otherwise, Acked-by: Richard Genoud >

Re: [PATCH v2] ARM: zImage: Fix stack overflow in merge_fdt_bootargs()

2017-07-26 Thread Richard Genoud
FDT. > > Signed-off-by: Rask Ingemann Lambertsen > Tested-by: Pavel Machek > Tested-by: Sebastian Reichel > Fixes: d0f34a11ddab ("ARM: 7437/1: zImage: Allow DTB command line > concatenation with ATAG_CMDLINE") seems good to me ! Reviewed-by: Richard Genoud > ---

Re: [PATCH] ARM: zImage: Fix stack overflow in merge_fdt_bootargs()

2017-07-18 Thread Richard Genoud
On 16/07/2017 23:43, Rask Ingemann Lambertsen wrote: > This function is called very early on from head.S and currently sets up a > stack frame of more than 1024 bytes: > > atags_to_fdt.c: In function ‘merge_fdt_bootargs’: > atags_to_fdt.c:98:1: warning: the frame size of 1032 bytes is larger than

Re: [PATCH 3.10 219/268] tty/serial: atmel: fix race condition (TX+DMA)

2017-06-20 Thread Richard Genoud
Hi Willy, You can drop this patch. There's nothing to fix on 3.10.x since the DMA TX support has been introduced in 3.12. Thanks ! 2017-06-19 20:31 GMT+02:00 Willy Tarreau : > From: Richard Genoud > > commit 31ca2c63fdc0aee725cbd4f207c1256f5deaabde upstream. > > If ua

[PATCH] kbuild: fix header installation under fakechroot environment

2017-06-15 Thread Richard Genoud
subst order ! Fixes: fcc8487d477a ("uapi: export all headers under uapi directories") Signed-off-by: Richard Genoud --- scripts/Makefile.headersinst | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst index ce7

Re: [PATCH] tty/serial: Kconfig: remove AVR32

2017-06-14 Thread Richard Genoud
On 13/06/2017 22:35, Alexandre Belloni wrote: > AVR32 is now removed from the kernel, removed the config symbol that > doesn't exist anymore. Also take the opportunity to reword the help to > include sama5. > > Signed-off-by: Alexandre Belloni Acked-by: Richard Genoud 10

Re: [PATCH] tty/serial: remove AVR32 specific access wrappers

2017-06-14 Thread Richard Genoud
On 13/06/2017 22:25, Alexandre Belloni wrote: > Now that AVR32 is gone, the specific wrappers for that architecture are > unnecessary and will not be compiled anymore. > > Signed-off-by: Alexandre Belloni Acked-by: Richard Genoud

Re: [PATCH v2 2/2] tty/serial: atmel: make the driver DT only

2017-06-14 Thread Richard Genoud
; drivers/tty/serial/atmel_serial.c | 96 > + > include/linux/platform_data/atmel.h | 10 > 2 files changed, 33 insertions(+), 73 deletions(-) Acked-by: Richard Genoud

Re: [PATCH v2 1/2] tty/serial: atmel: remove atmel_default_console_device handling

2017-06-14 Thread Richard Genoud
; - added an empty line as suggested by Andy > - properly based the patch on v4.12-rc1 > > drivers/tty/serial/atmel_serial.c | 43 > --- > 1 file changed, 43 deletions(-) > Acked-by: Richard Genoud Thanks !

Re: [PATCH] gpio: mvebu: change compatible string for PWM support

2017-06-09 Thread Richard Genoud
2017-06-09 9:42 GMT+02:00 Linus Walleij : > On Thu, Jun 1, 2017 at 10:08 PM, Ralph Sennhauser > wrote: > >> As it turns out more than just Armada 370 and XP support using GPIO >> lines as PWM lines. For example the Armada 38x family has the same >> hardware support. As such "marvell,armada-370-xp-

Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection

2017-06-09 Thread Richard Genoud
2017-06-09 9:37 GMT+02:00 Linus Walleij : > On Thu, Jun 1, 2017 at 2:18 PM, Richard Genoud > wrote: > >> The blink counter A was always selected because 0 was forced in the >> blink select counter register. >> The variable 'set' was obviously there to be use

[PATCHv2 2/2] gpio: mvebu: fix gpio bank registration when pwm is used

2017-06-01 Thread Richard Genoud
>base = id * MVEBU_MAX_GPIO_PER_BANK; Tested on clearfog-pro (Marvell 88F6828) Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support") Signed-off-by: Richard Genoud --- drivers/gpio/gpio-mvebu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpio/gpio-mvebu.c

[PATCHv2 0/2] gpio: mvebu: fixes for PWM/blink

2017-06-01 Thread Richard Genoud
omments to motivate the mvpwm->chip->base = -1 choice instead of mvpwm->chip->base = mvchip->chip.base Richard Genoud (2): gpio: mvebu: fix blink counter register selection gpio: mvebu: fix gpio bank registration when pwm is used drivers/gpio/gpio-mvebu.c | 9 - 1 file ch

[PATCHv2 1/2] gpio: mvebu: fix blink counter register selection

2017-06-01 Thread Richard Genoud
7642f9a584 ("gpio: mvebu: Add limited PWM support") Reviewed-by: Gregory CLEMENT Reviewed-by: Ralph Sennhauser Signed-off-by: Richard Genoud --- drivers/gpio/gpio-mvebu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpi

Re: [PATCH 2/2] gpio: mvebu: fix gpio bank registration when pwm is used

2017-05-30 Thread Richard Genoud
2017-05-30 17:14 GMT+02:00 Ralph Sennhauser : > Hi Richard > > On Tue, 30 May 2017 16:45:24 +0200 > Richard Genoud wrote: > >> 2017-05-30 15:16 GMT+02:00 Gregory CLEMENT >> : >> > Hi Richard, >> Hi Greg ! >> >> > >> > On mar., ma

Re: [PATCH v6 1/4] gpio: mvebu: Add limited PWM support

2017-05-30 Thread Richard Genoud
2017-05-30 16:51 GMT+02:00 Ralph Sennhauser : > On Tue, 30 May 2017 15:40:00 +0200 > Gregory CLEMENT wrote: > >> Hi Ralph and Linus, >> >> I resurrect this thread following the series post by Richard Genoud: >> http://lists.infradead.org/pipermail/linux-arm-kern

Re: [PATCH 2/2] gpio: mvebu: fix gpio bank registration when pwm is used

2017-05-30 Thread Richard Genoud
2017-05-30 15:16 GMT+02:00 Gregory CLEMENT : > Hi Richard, Hi Greg ! > > On mar., mai 30 2017, Richard Genoud wrote: > >> If more than one gpio bank has the "pwm" property, only one will be >> registered successfully, all the others will fail with: >> m

[PATCH 2/2] gpio: mvebu: fix gpio bank registration when pwm is used

2017-05-30 Thread Richard Genoud
==0) ; and 0 is a meaningful start value in alloc_pwm(). What was intended is chip->base = -1. Like that, the numbering will be done auto-magically Tested on clearfog-pro (Marvell 88F6828) Signed-off-by: Richard Genoud --- drivers/gpio/gpio-mvebu.c | 1 + 1 file changed, 1 insertion(+) diff --gi

[PATCH 1/2] gpio: mvebu: fix blink counter register selection

2017-05-30 Thread Richard Genoud
The blink counter A was always selected because 0 was forced in the blink select counter register. The variable 'set' was obviously there to be used as the register value, selecting the B counter when id==1 and A counter when id==0. Tested on clearfog-pro (Marvell 88F6828) Signed-off-b

Re: [PATCH v2] tty/serial: atmel: use offset_in_page() macro

2017-05-02 Thread Richard Genoud
On 29/04/2017 03:39, Geliang Tang wrote: > Use offset_in_page() macro instead of open-coding. > > Signed-off-by: Geliang Tang Acked-by: Richard Genoud > --- > Changes in v2: > - include mm.h > --- > drivers/tty/serial/atmel_serial.c | 5 +++-- > 1 file changed, 3

Re: [PATCH] serial: sh-sci: Fix race condition causing garbage during shutdown

2017-04-26 Thread Richard Genoud
On 25/04/2017 20:15, Geert Uytterhoeven wrote: > If DMA is enabled and used, a burst of old data may be seen on the > serial console during "poweroff" or "reboot". uart_flush_buffer() > clears the circular buffer, but sci_port.tx_dma_len is not reset. > This leads to a circular buffer overflow, du

Re: [PATCH] tty/serial: atmel: use offset_in_page() macro

2017-04-24 Thread Richard Genoud
On 22/04/2017 03:21, Geliang Tang wrote: > Use offset_in_page() macro instead of open-coding. > > Signed-off-by: Geliang Tang > --- > drivers/tty/serial/atmel_serial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/atmel_serial.c > b/drivers/tty

Re: [PATCH 3.18 049/124] tty/serial: atmel: fix race condition (TX+DMA)

2017-04-20 Thread Richard Genoud
On 20/04/2017 08:35, Greg Kroah-Hartman wrote: > 3.18-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Richard Genoud > > commit 31ca2c63fdc0aee725cbd4f207c1256f5deaabde upstream. > > If uart_flush_buffer() is

[PATCHv3 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD

2017-03-27 Thread Richard Genoud
This adds support for the Winstar Display Co. WF35LTIACD 3.5" QVGA TFT LCD panel, which can be supported by the simple panel driver. Acked-by: Rob Herring Signed-off-by: Richard Genoud --- Changes since v2: Remove status, reg and unit-addresses from example Changes since v1: Add power-s

Re: [PATCHv2 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD

2017-03-27 Thread Richard Genoud
2017-03-24 16:58 GMT+01:00 Rob Herring : > On Mon, Mar 20, 2017 at 02:32:22PM +0100, Richard Genoud wrote: >> This adds support for the Winstar Display Co. WF35LTIACD 3.5" QVGA TFT >> LCD panel, which can be supported by the simple panel driver. >> >&g

[PATCHv2 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD

2017-03-20 Thread Richard Genoud
This adds support for the Winstar Display Co. WF35LTIACD 3.5" QVGA TFT LCD panel, which can be supported by the simple panel driver. Signed-off-by: Richard Genoud --- Changes since v1: Add power-supply property and an example in documentation .../bindings/display/panel/winstar,wf35l

[PATCH] tty/serial: atmel: fix race condition (TX+DMA)

2017-03-20 Thread Richard Genoud
If uart_flush_buffer() is called between atmel_tx_dma() and atmel_complete_tx_dma(), the circular buffer has been cleared, but not atmel_port->tx_len. That leads to a circular buffer overflow (dumping (UART_XMIT_SIZE - atmel_port->tx_len) bytes). Tested-by: Nicolas Ferre Signed-off-by: R

Re: [RFC PATCH] tty/serial: atmel: fix TX path in atmel_console_write()

2017-03-20 Thread Richard Genoud
ually able to send characters */ > + atmel_uart_writel(port, ATMEL_US_CR, ATMEL_US_TXEN); > + > uart_console_write(port, s, count, atmel_console_putchar); > > /* > Acked-by: Richard Genoud

Re: [RFC PATCH] tty/serial: atmel: fix TX path in atmel_console_write()

2017-03-17 Thread Richard Genoud
2017-03-15 17:56 GMT+01:00 Nicolas Ferre : > Le 15/03/2017 à 17:19, Richard Genoud a écrit : >> On 15/03/2017 16:29, Nicolas Ferre wrote: >>> A side effect of 89d8232411a8 ("tty/serial: atmel_serial: BUG: stop DMA >>> from transmitting in stop_tx") is that

Re: [RFC PATCH] tty/serial: atmel: fix TX path in atmel_console_write()

2017-03-15 Thread Richard Genoud
On 15/03/2017 16:29, Nicolas Ferre wrote: > A side effect of 89d8232411a8 ("tty/serial: atmel_serial: BUG: stop DMA > from transmitting in stop_tx") is that the console can be called with > TX path disabled. Then the system would hang trying to push charecters > out in atmel_console_putchar(). > >

Re: [PATCH] tty/serial: atmel_serial: BUG: stop DMA from transmitting in stop_tx

2017-03-15 Thread Richard Genoud
2017-03-15 12:37 GMT+01:00 Nicolas Ferre : > Le 13/12/2016 à 17:27, Richard Genoud a écrit : >> If we don't disable the transmitter in atmel_stop_tx, the DMA buffer >> continues to send data until it is emptied. >> This cause problems with the flow control (CTS is asse

Re: [PATCH 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD

2017-03-13 Thread Richard Genoud
On 12/03/2017 15:17, Rob Herring wrote: > On Fri, Mar 03, 2017 at 04:21:56PM +0100, Richard Genoud wrote: >> This adds support for the Winstar Display Co. WF35LTIACD 3.5" QVGA TFT >> LCD panel, which can be supported by the simple panel driver. >> >&g

Re: [REGRESSION] Two issues that prevent process accounting (taskstats) from working correctly

2017-03-08 Thread Richard Genoud
Cc += Al Viro 2017-02-12 16:44 GMT+01:00 Dmitry Romanov : > On Mon, Dec 19, 2016 at 01:06:00PM +0100, Martin Steigerwald wrote: >> >> 1) Sometimes process accounting does not work at all. >> >> The acct() system call (to activate process accounting) return value 0, >> which means that process acco

[PATCH 1/2] dt-bindings: mfd: Fix path to atmel/hlcdc-dc.txt

2017-03-03 Thread Richard Genoud
Atmel hlcdc-dc documentation is actually in Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt Signed-off-by: Richard Genoud --- Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings

[PATCH 2/2] dt-bindings: display: atmel: Fix path to atmel-hlcdc.txt

2017-03-03 Thread Richard Genoud
The relative path pointed to Documentation/devicetree/bindings/display/mfd/atmel-hlcdc.txt instead of Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt Signed-off-by: Richard Genoud --- Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/2] drm/panel: simple: Add support for Winstar WF35LTIACD

2017-03-03 Thread Richard Genoud
This adds support for the Winstar Display Co. WF35LTIACD 3.5" QVGA TFT LCD panel, which can be supported by the simple panel driver. Signed-off-by: Richard Genoud --- .../bindings/display/panel/winstar,wf35ltiacd | 7 ++ drivers/gpu/drm/panel/panel-simple.c

[PATCH 1/2] devicetree: add vendor prefix for Winstar Display Corp.

2017-03-03 Thread Richard Genoud
Winstar Display Corp. is specialized in LCD displays for embedded products. cf: http://www.winstar.com.tw Signed-off-by: Richard Genoud --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor

[PATCH 1/4] tty/serial: atmel: move atmel_serial header into driver directory

2017-03-03 Thread Richard Genoud
atmel_serial.h is only used by atmel_serial.c, so there's no need for it to lie in include/linux. Suggested-by: Joe Perches Signed-off-by: Richard Genoud --- MAINTAINERS | 2 +- drivers/tty/serial/atmel_serial.c| 2 +- {include/

[PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

2017-03-03 Thread Richard Genoud
Since commit 1d267ea6539f ("serial: mctrl-gpio: simplify init routine"), the mctrl_gpio_to_gpiod() function can't return an error anymore. So, just testing for a NULL pointer is ok. Signed-off-by: Richard Genoud --- drivers/tty/serial/sh-sci.c | 12 +--- 1 file change

[PATCH 3/4] tty/serial: mxs-auart: remove uneeded IS_ERR_OR_NULL calls

2017-03-03 Thread Richard Genoud
Since commit 1d267ea6539f ("serial: mctrl-gpio: simplify init routine"), the mctrl_gpio_to_gpiod() function can't return an error anymore. So, just testing for a NULL pointer is ok. Signed-off-by: Richard Genoud --- drivers/tty/serial/mxs-auart.c | 6 ++ 1 file changed, 2 i

[PATCH 2/4] tty/serial: atmel: remove uneeded IS_ERR_OR_NULL calls

2017-03-03 Thread Richard Genoud
Since commit 1d267ea6539f ("serial: mctrl-gpio: simplify init routine"), the mctrl_gpio_to_gpiod() function can't return an error anymore. So, just testing for a NULL pointer is ok. Signed-off-by: Richard Genoud --- drivers/tty/serial/atmel_serial.c | 12 1

Re: [PATCH] tty/serial: atmel: remove cache when unnecessary

2017-02-21 Thread Richard Genoud
2017-02-21 13:03 GMT+01:00 Alexandre Belloni : > struct cache is only used in suspend/resume. Exclude it when PM is not > selected. > > Suggested-by: Richard Genoud > Signed-off-by: Alexandre Belloni Acked-by: Richard Genoud > --- > drivers/tty/serial/atmel_serial.c | 2 ++

Re: [PATCH] tty/serial: atmel: increase ATMEL_MAX_UART

2017-02-21 Thread Richard Genoud
2017-02-21 13:03 GMT+01:00 Alexandre Belloni : > The samx7 family uses the same UART/USART IP as the at91/sama5 families but > has 8 of those. > > Suggested-by: Szemző András > Signed-off-by: Alexandre Belloni Acked-by: Richard Genoud > --- > drivers/tty/serial/atmel_

Re: [PATCH] atmel_serial: Use the fractional divider when possible

2017-02-13 Thread Richard Genoud
_USMODE makes it possible to get >> correct baudrates at high speed in more cases. >> >> This was tested with a board using an Atmel SAMA5D2 chip and a TI >> WL1831 WiFi/Bluetooth combo chip at 3 Mbauds, with hardware flow control >> enabled. >> >> Signed-off

  1   2   3   4   5   >