Re: [RFC please help] membarrier: Rewrite sync_core_before_usermode()

2020-12-28 Thread Russell King - ARM Linux admin
On Sun, Dec 27, 2020 at 01:36:13PM -0800, Andy Lutomirski wrote: > On Sun, Dec 27, 2020 at 12:18 PM Mathieu Desnoyers > wrote: > > > > - On Dec 27, 2020, at 1:28 PM, Andy Lutomirski l...@kernel.org wrote: > > > > > > > > > I admit that I'm rather surprised that the code worked at all on

Re: [PATCH 1/1] ARM: LPAE: use phys_addr_t instead of unsigned long in outercache hooks

2020-12-26 Thread Russell King - ARM Linux admin
On Sat, Dec 26, 2020 at 10:18:08AM +0800, Leizhen (ThunderTown) wrote: > On 2020/12/25 19:44, Zhen Lei wrote: > > The outercache of some Hisilicon SOCs support physical addresses wider > > than 32-bits. The unsigned long datatype is not sufficient for mapping > > physical addresses >= 4GB. The

Re: [PATCH 1/1] ARM: LPAE: use phys_addr_t instead of unsigned long in outercache hooks

2020-12-26 Thread Russell King - ARM Linux admin
On Fri, Dec 25, 2020 at 07:44:58PM +0800, Zhen Lei wrote: > The outercache of some Hisilicon SOCs support physical addresses wider > than 32-bits. The unsigned long datatype is not sufficient for mapping > physical addresses >= 4GB. The commit ad6b9c9d78b9 ("ARM: 6671/1: LPAE: > use phys_addr_t

Re: next/master bisection: baseline.login on ox820-cloudengines-pogoplug-series-3

2020-12-18 Thread Russell King - ARM Linux admin
On Fri, Dec 18, 2020 at 01:48:09PM +, Guillaume Tucker wrote: > Please see the bisection report below about a boot failure on > ox820-cloudengines-pogoplug-series-3. There was also a bisection > yesterday with next-20201216 which landed on the same commit, on > the same platform and also with

Re: [PATCH net v2 2/2] net: mvpp2: disable force link UP during port init procedure

2020-12-17 Thread Russell King - ARM Linux admin
On Thu, Dec 17, 2020 at 12:00:49PM +0100, Marcin Wojtas wrote: > Hi Stefan, > > czw., 17 gru 2020 o 10:42 napisał(a): > > > > From: Stefan Chulski > > > > Force link UP can be enabled by bootloader during tftpboot > > and breaks NFS support. > > Force link UP disabled during port init

Re: [PATCH] MAINTAINERS: add mvpp2 driver entry

2020-12-11 Thread Russell King - ARM Linux admin
On Fri, Dec 11, 2020 at 03:41:47PM +0100, Marcin Wojtas wrote: > Since its creation Marvell NIC driver for Armada 375/7k8k and > CN913x SoC families mvpp2 has been lacking an entry in MAINTAINERS, > which sometimes lead to unhandled bugs that persisted > across several kernel releases. Can you

Re: linux-next: Fixes tag needs some work in the arm tree

2020-12-08 Thread Russell King - ARM Linux admin
On Tue, Dec 08, 2020 at 01:02:05PM +0100, Ard Biesheuvel wrote: > On Tue, 8 Dec 2020 at 12:39, Stephen Rothwell wrote: > > > > Hi all, > > > > In commit > > > > 4812d516af55 ("ARM: 9027/1: head.S: explicitly map DT even if it lives in > > the first physical section") > > > > Fixes tag > > > >

Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-04 Thread Russell King - ARM Linux admin
On Fri, Dec 04, 2020 at 02:48:26PM +0100, Steen Hegelund wrote: > On 03.12.2020 22:52, Andrew Lunn wrote: > > What i have not yet seen is how this code plugs together with > > phylink_pcs_ops? > > > > Can this hardware also be used for SATA, USB? As far as i understand, > > the Marvell Comphy is

Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-04 Thread Russell King - ARM Linux admin
On Fri, Dec 04, 2020 at 08:56:33AM +0100, Alexandre Belloni wrote: > Hi Russell, > > On 03/12/2020 22:52:33+, Russell King - ARM Linux admin wrote: > > You still have not Cc'd me on your patches. Please can you either: > > > > 1) use get_maintainer.pl to find out

Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-03 Thread Russell King - ARM Linux admin
On Thu, Dec 03, 2020 at 10:52:53PM +0100, Andrew Lunn wrote: > > +/* map from SD25G28 interface width to configuration value */ > > +static u8 sd25g28_get_iw_setting(const u8 interface_width) > > +{ > > + switch (interface_width) { > > + case 10: return 0; > > + case 16: return 1; > > +

Re: [PATCH v10 3/3] ARM: uncompress: Validate start of physical memory against passed DTB

2020-12-03 Thread Russell King - ARM Linux admin
On Thu, Dec 03, 2020 at 01:19:16PM +0100, Geert Uytterhoeven wrote: > diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S > index d9cce7238a365081..1b6425df87e84e71 100644 > --- a/arch/arm/boot/compressed/head.S > +++ b/arch/arm/boot/compressed/head.S > @@ -282,10

Re: [PATCH v2 10/10] ARM: mstar: SMP support

2020-12-01 Thread Russell King - ARM Linux admin
On Tue, Dec 01, 2020 at 10:43:30PM +0900, Daniel Palmer wrote: > + np = of_find_compatible_node(NULL, NULL, "mstar,smpctrl"); > + smpctrl = of_iomap(np, 0); > + > + if (!smpctrl) > + return -ENODEV; Wouldn't -ENOMEM be more appropriate here? -- RMK's Patch system:

Re: [GIT PULL] ARM: SoC fixes for v5.10, part 3

2020-11-30 Thread Russell King - ARM Linux admin
On Mon, Nov 30, 2020 at 10:22:58AM -0800, Linus Torvalds wrote: > > I guess the question is: why is static assignment of numbers not an > > acceptable solution to the problem? It gives us the desired fixed > > numbers and automatically avoids all weird probe ordering / dependency > > problems. >

Re: [GIT PULL] ARM: SoC fixes for v5.10, part 3

2020-11-30 Thread Russell King - ARM Linux admin
On Mon, Nov 30, 2020 at 10:15:29AM -0800, Linus Torvalds wrote: > On Mon, Nov 30, 2020 at 10:05 AM Russell King - ARM Linux admin > wrote: > > > > If you think that /dev/sda for example is always the machine's internal > > HDD, that is wrong. > > Yes. See th

Re: [GIT PULL] ARM: SoC fixes for v5.10, part 3

2020-11-30 Thread Russell King - ARM Linux admin
On Mon, Nov 30, 2020 at 09:44:03AM -0800, Linus Torvalds wrote: > On Mon, Nov 30, 2020 at 9:04 AM Doug Anderson wrote: > > > > Without static assignment, maybe we could do numbering of MMC devices > > in some type of a pre-probe routine? Is that what you're suggesting? > > Yes. > > So

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-30 Thread Russell King - ARM Linux admin
On Mon, Nov 30, 2020 at 03:39:08PM +0100, Steen Hegelund wrote: > On 29.11.2020 11:28, Russell King - ARM Linux admin wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Sun, Nov 29, 2020 at 10:52:45A

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-30 Thread Russell King - ARM Linux admin
On Mon, Nov 30, 2020 at 03:15:56PM +0100, Steen Hegelund wrote: > On 29.11.2020 10:52, Russell King - ARM Linux admin wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Sat, Nov 28, 2020 at 10:28:28P

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-30 Thread Russell King - ARM Linux admin
On Mon, Nov 30, 2020 at 03:30:23PM +0100, Steen Hegelund wrote: > On 29.11.2020 11:30, Russell King - ARM Linux admin wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Sun, Nov 29, 2020 at 10:52:45A

Re: [RESEND,PATCH] ARM: fix __div64_32() error when compiling with clang

2020-11-30 Thread Russell King - ARM Linux admin
On Mon, Nov 30, 2020 at 01:58:27PM +, David Laight wrote: > > And actually, the same applies on BE, but the other way around. So we > > should mark __xl as an output register as well, as __xl will assume > > the right value depending on the endianness. > > Why not use "+r" to indicate than an

Re: [PATCH] net: phy: marvell: replace __phy_modify()

2020-11-30 Thread Russell King - ARM Linux admin
On Mon, Nov 30, 2020 at 06:16:39PM +0800, Yejune Deng wrote: > a set of phy_set_bits() looks more neater > > Signed-off-by: Yejune Deng Sorry, but NAK. You seem to be doing a mechanical code change without first understanding the code, as the patch shows no sign of an understanding of the

Re: [RESEND,PATCH] ARM: fix __div64_32() error when compiling with clang

2020-11-30 Thread Russell King - ARM Linux admin
On Mon, Nov 30, 2020 at 11:12:33AM +0100, Ard Biesheuvel wrote: > (+ Nico) > > On Mon, 30 Nov 2020 at 11:11, Ard Biesheuvel wrote: > > > > On Mon, 23 Nov 2020 at 08:39, Antony Yu wrote: > > > > > > __do_div64 clobbers the input register r0 in little endian system. > > > According to the inline

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-29 Thread Russell King - ARM Linux admin
On Sun, Nov 29, 2020 at 10:52:45AM +, Russell King - ARM Linux admin wrote: > There are other issues too. This is also wrong: + if (port->ndev && port->ndev->phydev) + status->link = port->ndev->phydev->link; phylink a

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-29 Thread Russell King - ARM Linux admin
On Sun, Nov 29, 2020 at 10:52:45AM +, Russell King - ARM Linux admin wrote: > On Sat, Nov 28, 2020 at 10:28:28PM +0000, Russell King - ARM Linux admin > wrote: > > On Sat, Nov 28, 2020 at 08:06:16PM +0100, Andrew Lunn wrote: > > > > +static void sparx5_phylink_mac_conf

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-29 Thread Russell King - ARM Linux admin
On Sat, Nov 28, 2020 at 10:28:28PM +, Russell King - ARM Linux admin wrote: > On Sat, Nov 28, 2020 at 08:06:16PM +0100, Andrew Lunn wrote: > > > +static void sparx5_phylink_mac_config(struct phylink_config *config, > > > +

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-28 Thread Russell King - ARM Linux admin
On Sat, Nov 28, 2020 at 08:06:16PM +0100, Andrew Lunn wrote: > > +static void sparx5_phylink_mac_config(struct phylink_config *config, > > + unsigned int mode, > > + const struct phylink_link_state *state) > > +{ > > + struct

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-11-28 Thread Russell King - ARM Linux admin
On Sat, Nov 28, 2020 at 08:06:16PM +0100, Andrew Lunn wrote: > > +static void sparx5_phylink_mac_config(struct phylink_config *config, > > + unsigned int mode, > > + const struct phylink_link_state *state) > > +{ > > + struct

Re: linux-next 20201126 - build error on arm allmodconfig

2020-11-26 Thread Russell King - ARM Linux admin
On Thu, Nov 26, 2020 at 09:22:53AM -0500, Valdis Klētnieks wrote: > On Thu, 26 Nov 2020 14:14:29 +0000, Russell King - ARM Linux admin said: > > > The real answer is for asm/kasan.h to include linux/linkage.h > > Looking deeper, there's 7 different arch/../asm/kasan.h -

Re: linux-next 20201126 - build error on arm allmodconfig

2020-11-26 Thread Russell King - ARM Linux admin
On Thu, Nov 26, 2020 at 08:25:02AM -0500, Valdis Klētnieks wrote: > Seems something is giving it indigestion regarding asmlinkage... > > CC arch/arm/mm/kasan_init.o > In file included from ./include/linux/kasan.h:15, > from arch/arm/mm/kasan_init.c:11: >

Re: [PATCH v3 net-next] net: phy: realtek: read actual speed on rtl8211f to detect downshift

2020-11-25 Thread Russell King - ARM Linux admin
On Thu, Nov 26, 2020 at 12:57:37AM +0800, Yonglong Liu wrote: > Hi, Antonio: > >     Could you help to provide a downshift warning message when this happen? > >     It's a little strange that the adv and the lpa support 1000M, but > finally the link speed is 100M. That is an identifying feature

Re: [PATCH] net: phy: fix auto-negotiation in case of 'down-shift'

2020-11-24 Thread Russell King - ARM Linux admin
On Tue, Nov 24, 2020 at 04:17:42PM +0100, Antonio Borneo wrote: > On Tue, 2020-11-24 at 14:56 +0000, Russell King - ARM Linux admin wrote: > > Userspace doesn't expect the advertising mask to change beneath it. > > Since updates from userspace are done using a re

Re: [PATCH] net: phy: fix auto-negotiation in case of 'down-shift'

2020-11-24 Thread Russell King - ARM Linux admin
On Tue, Nov 24, 2020 at 04:03:40PM +0100, Heiner Kallweit wrote: > Am 24.11.2020 um 15:38 schrieb Antonio Borneo: > > If the auto-negotiation fails to establish a gigabit link, the phy > > can try to 'down-shift': it resets the bits in MII_CTRL1000 to > > stop advertising 1Gbps and retries the

Re: [PATCH] net: phy: fix auto-negotiation in case of 'down-shift'

2020-11-24 Thread Russell King - ARM Linux admin
On Tue, Nov 24, 2020 at 03:38:48PM +0100, Antonio Borneo wrote: > If the auto-negotiation fails to establish a gigabit link, the phy > can try to 'down-shift': it resets the bits in MII_CTRL1000 to > stop advertising 1Gbps and retries the negotiation at 100Mbps. > > From commit 5502b218e001

Re: [PATCH v2] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Russell King - ARM Linux admin
On Mon, Nov 23, 2020 at 07:54:33PM +0200, stef...@marvell.com wrote: > From: Stefan Chulski > > Tx/Rx FIFO is a HW resource limited by total size, but shared > by all ports of same CP110 and impacting port-performance. > Do not divide the FIFO for ports which are not enabled in DTS, > so active

Re: [EXT] Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Russell King - ARM Linux admin
On Mon, Nov 23, 2020 at 04:03:00PM +, Stefan Chulski wrote: > > -Original Message- > > From: Russell King - ARM Linux admin > > Sent: Monday, November 23, 2020 5:52 PM > > To: Stefan Chulski > > Cc: net...@vger.kernel.org; thomas.petazz...@bootlin.com;

Re: [EXT] Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Russell King - ARM Linux admin
On Mon, Nov 23, 2020 at 03:44:05PM +, Stefan Chulski wrote: > > > > On Mon, Nov 23, 2020 at 04:52:40PM +0200, stef...@marvell.com wrote: > > > > > From: Stefan Chulski > > > > > > > > > > Tx/Rx FIFO is a HW resource limited by total size, but shared by > > > > > all ports of same CP110 and

Re: [EXT] Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Russell King - ARM Linux admin
On Mon, Nov 23, 2020 at 03:26:11PM +, Stefan Chulski wrote: > > -Original Message- > > From: Russell King - ARM Linux admin > > Sent: Monday, November 23, 2020 5:11 PM > > To: Stefan Chulski > > Cc: net...@vger.kernel.org; thomas.petazz...@bootlin.com;

Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Russell King - ARM Linux admin
On Mon, Nov 23, 2020 at 03:10:49PM +, Russell King - ARM Linux admin wrote: > Hi, > > On Mon, Nov 23, 2020 at 04:52:40PM +0200, stef...@marvell.com wrote: > > From: Stefan Chulski > > > > Tx/Rx FIFO is a HW resource limited by total size, but shared >

Re: [PATCH v1] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Russell King - ARM Linux admin
Hi, On Mon, Nov 23, 2020 at 04:52:40PM +0200, stef...@marvell.com wrote: > From: Stefan Chulski > > Tx/Rx FIFO is a HW resource limited by total size, but shared > by all ports of same CP110 and impacting port-performance. > Do not divide the FIFO for ports which are not enabled in DTS, > so

Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-15 Thread Russell King - ARM Linux admin
On Wed, Nov 11, 2020 at 09:52:18AM +0100, Bjarni Jonasson wrote: > > Russell King - ARM Linux admin writes: > > > On Tue, Nov 10, 2020 at 03:16:34PM +0100, Bjarni Jonasson wrote: > >> > >> Russell King - ARM Linux admin writes: > >> > >>

Re: [PATCH net-next] net: mvneta: Fix validation of 2.5G HSGMII without comphy

2020-11-15 Thread Russell King - ARM Linux admin
On Sun, Nov 15, 2020 at 03:26:01AM +0100, Andreas Färber wrote: > Hi Russell, > > On 15.11.20 02:02, Russell King - ARM Linux admin wrote: > > On Sun, Nov 15, 2020 at 01:41:51AM +0100, Andreas Färber wrote: > >> Commit 1a642ca7f38992b086101fe204a1ae3c90ed8016 (net: et

Re: [PATCH net-next] net: mvneta: Fix validation of 2.5G HSGMII without comphy

2020-11-14 Thread Russell King - ARM Linux admin
On Sun, Nov 15, 2020 at 01:41:51AM +0100, Andreas Färber wrote: > Commit 1a642ca7f38992b086101fe204a1ae3c90ed8016 (net: ethernet: mvneta: > Add 2500BaseX support for SoCs without comphy) added support for 2500BaseX. > > In case a comphy is not provided, mvneta_validate()'s check >

Re: rmk/for-next bisection: baseline.login on bcm2836-rpi-2-b

2020-11-13 Thread Russell King - ARM Linux admin
On Fri, Nov 13, 2020 at 03:43:27PM +, Guillaume Tucker wrote: > On 13/11/2020 10:35, Ard Biesheuvel wrote: > > On Fri, 13 Nov 2020 at 11:31, Guillaume Tucker > > wrote: > >> > >> Hi Ard, > >> > >> Please see the bisection report below about a boot failure on > >> RPi-2b. > >> > >> Reports

Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-10 Thread Russell King - ARM Linux admin
On Tue, Nov 10, 2020 at 03:16:34PM +0100, Bjarni Jonasson wrote: > > Russell King - ARM Linux admin writes: > > > On Tue, Nov 10, 2020 at 11:06:42AM +0100, Bjarni Jonasson wrote: > >> There is an issue with the current phylink driver and CuSFPs which > >> res

Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-10 Thread Russell King - ARM Linux admin
On Tue, Nov 10, 2020 at 11:06:42AM +0100, Bjarni Jonasson wrote: > There is an issue with the current phylink driver and CuSFPs which > results in a callback to the phylink validate function without any > advertisement capabilities. The workaround (in this changeset) > is to assign capabilities

Re: [PATCH usb-next] usb: dwc3: Use devm_of_platform_populate

2020-11-09 Thread Russell King - ARM Linux admin
On Mon, Nov 09, 2020 at 09:59:53AM +0800, Jisheng Zhang wrote: > diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c > b/drivers/usb/dwc3/dwc3-meson-g12a.c > index 417e05381b5d..83015bb7b926 100644 > --- a/drivers/usb/dwc3/dwc3-meson-g12a.c > +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c > @@ -702,7

Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function

2020-11-08 Thread Russell King - ARM Linux admin
On Sun, Nov 08, 2020 at 10:53:22AM +0100, Sam Ravnborg wrote: > Russell, > > On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote: > > It has been observed that resetting force in the detect function can > > result in the PHY being powered down in response to hot-plug detect > > being

Re: [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization

2020-11-07 Thread Russell King - ARM Linux admin
On Fri, Nov 06, 2020 at 07:14:36AM +0200, Adrian Ratiu wrote: > diff --git a/arch/arm/lib/xor-neon.c b/arch/arm/lib/xor-neon.c > index e1e76186ec23..84c91c48dfa2 100644 > --- a/arch/arm/lib/xor-neon.c > +++ b/arch/arm/lib/xor-neon.c > @@ -18,6 +18,10 @@ MODULE_LICENSE("GPL"); > * Pull in the

Re: [PATCH] net: macb: fix NULL dereference due to no pcs_config method

2020-11-05 Thread Russell King - ARM Linux admin
On Thu, Nov 05, 2020 at 04:22:18PM +0100, Nicolas Ferre wrote: > On 05/11/2020 at 15:37, Parshuram Thombare wrote: > > This patch fixes NULL pointer dereference due to NULL pcs_config > > in pcs_ops. > > > > Fixes: e4e143e26ce8 ("net: macb: add support for high speed interface") > > What is this

Re: [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier

2020-11-02 Thread Russell King - ARM Linux admin
On Mon, Nov 02, 2020 at 10:23:43AM +, Russell King - ARM Linux admin wrote: > On Sun, Nov 01, 2020 at 01:11:22PM +, Lee Jones wrote: > > On Sat, 31 Oct 2020, Russell King - ARM Linux admin wrote: > > > > > On Fri, Oct 30, 2020 at 06:18:22PM +, Lee Jon

Re: [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier

2020-11-02 Thread Russell King - ARM Linux admin
On Sun, Nov 01, 2020 at 01:11:22PM +, Lee Jones wrote: > On Sat, 31 Oct 2020, Russell King - ARM Linux admin wrote: > > > On Fri, Oct 30, 2020 at 06:18:22PM +, Lee Jones wrote: > > > Commit 09e5b3fd5672 ("Fonts: Support FONT_EXTRA_WORDS macros for > > &

Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

2020-10-31 Thread Russell King - ARM Linux admin
On Sat, Oct 31, 2020 at 11:47:42AM +0100, Ard Biesheuvel wrote: > On Sat, 31 Oct 2020 at 11:33, Russell King - ARM Linux admin > wrote: > > > > On Sat, Oct 31, 2020 at 11:43:45AM +0200, Mike Rapoport wrote: > > > From: Ard Biesheuvel > > > > > > fre

Re: [PATCH] ARM, xtensa: highmem: avoid clobbering non-page aligned memory reservations

2020-10-31 Thread Russell King - ARM Linux admin
On Sat, Oct 31, 2020 at 11:43:45AM +0200, Mike Rapoport wrote: > From: Ard Biesheuvel > > free_highpages() iterates over the free memblock regions in high > memory, and marks each page as available for the memory management > system. > > Until commit cddb5ddf2b76 ("arm, xtensa: simplify

Re: [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier

2020-10-31 Thread Russell King - ARM Linux admin
On Fri, Oct 30, 2020 at 06:18:22PM +, Lee Jones wrote: > Commit 09e5b3fd5672 ("Fonts: Support FONT_EXTRA_WORDS macros for Your commit ID does not exist in mainline kernels, which makes this confusing. The commit ID you should be using is 6735b4632def. -- RMK's Patch system:

Re: [PATCH 4/9] ARM: syscall: always store thread_info->syscall

2020-10-30 Thread Russell King - ARM Linux admin
On Fri, Oct 30, 2020 at 04:49:14PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The system call number is used in a a couple of places, in particular > ptrace, seccomp and /proc//syscall. > > The last one apparently never worked reliably on ARM for tasks > that are not currently

Re: [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml

2020-10-29 Thread Russell King - ARM Linux admin
On Wed, Oct 28, 2020 at 09:39:54PM +0100, Alexander Dahl wrote: > Hello, > > Peter, Russel, could you please give your Acked-by or Signed-off-by on > this patch? Your ack is needed, because the license is now explicitly > set (it was not explicit before), and you were the contributors to > this

Re: [PATCH v2 3/4] arm: mm: introduce L_PTE_SPECIAL

2020-10-27 Thread Russell King - ARM Linux admin
On Tue, Oct 27, 2020 at 03:45:12PM +0800, Miles Chen wrote: > On Fri, 2020-10-23 at 11:08 +0100, Russell King - ARM Linux admin wrote: > > On Fri, Oct 23, 2020 at 05:14:36PM +0800, Miles Chen wrote: > > > From: Minchan Kim > > > > > > This patch introd

Re: [PATCH] arm:traps:Don't dump the memory in non-system reset scenarios

2020-10-26 Thread Russell King - ARM Linux admin
On Mon, Oct 26, 2020 at 02:31:06PM +0800, Xiaoming Ni wrote: > Do not dump the memory in non-system reset scenarios to prevent virtual > address information leakage. > > This patch follows x86 and arm64's lead and removes the "Exception stack:" > dump from kernel backtraces: > commit

Re: ping //Re: [PATCH v2] arm:traps: Don't print stack or raw PC/LR hex values in backtraces

2020-10-26 Thread Russell King - ARM Linux admin
On Mon, Oct 26, 2020 at 02:33:10PM +0800, Xiaoming Ni wrote: > ping The arm tree was closed due to the merge window, and thus patches do not get applied at that point. Plus I tend not to review development patches during the merge window. > On 2020/10/16 10:31, Xiaoming Ni wrote: > > Printing

Re: [RFC net-next 0/5] net: phy: add support for shared interrupts

2020-10-24 Thread Russell King - ARM Linux admin
On Sat, Oct 24, 2020 at 07:17:05PM +0200, Andrew Lunn wrote: > > - Every PHY driver gains a .handle_interrupt() implementation that, for > > the most part, would look like below: > > > > irq_status = phy_read(phydev, INTR_STATUS); > > if (irq_status < 0) { > >

Re: [PATCH v3] net: macb: add support for high speed interface

2020-10-23 Thread Russell King - ARM Linux admin
On Fri, Oct 23, 2020 at 01:34:09PM +, Parshuram Raju Thombare wrote: > >Whenever the interface changes, we go through the full reconfiguration > >procedure that I've already outlined. This involves calling the > >mac_prepare() method which calls into mvpp2_mac_prepare() and its > >child

Re: [RFC PATCH v1 0/6] add initial CAN PHY support

2020-10-23 Thread Russell King - ARM Linux admin
On Fri, Oct 23, 2020 at 02:14:09PM +0200, Marc Kleine-Budde wrote: > On 10/23/20 1:45 PM, Russell King - ARM Linux admin wrote: > > On Fri, Oct 23, 2020 at 12:56:20PM +0200, Oleksij Rempel wrote: > >> - The upcoming CAN SIC and CAN SIC XL PHYs use a different interface to > &g

Re: [RFC PATCH v1 0/6] add initial CAN PHY support

2020-10-23 Thread Russell King - ARM Linux admin
On Fri, Oct 23, 2020 at 12:56:20PM +0200, Oleksij Rempel wrote: > - The upcoming CAN SIC and CAN SIC XL PHYs use a different interface to > the CAN controller. This means the controller needs to know which type > of PHY is attached to configure the interface in the correct mode. Use > PHY

Re: [PATCH v3] net: macb: add support for high speed interface

2020-10-23 Thread Russell King - ARM Linux admin
On Fri, Oct 23, 2020 at 10:59:42AM +, Parshuram Raju Thombare wrote: > Hi, > > I was trying to find out any ethernet driver where this issue of selecting > appropriate > pcs_ops due to phylink changing interface mode dynamically is handled. > But, apparently, so far only mvpp2 has adapted

Re: [PATCH v2 2/4] arm: mm: reordering memory type table

2020-10-23 Thread Russell King - ARM Linux admin
On Fri, Oct 23, 2020 at 05:14:35PM +0800, Miles Chen wrote: > From: Minchan Kim > > To use bit 5 in page table as L_PTE_SPECIAL, we need a room for that. > It seems we don't need 4 bits for the memory type with ARMv6+. > If it's true, let's reorder bits to make bit 5 free. > > We will use the

Re: [PATCH v2 4/4] arm: replace vector mem type with read-only type

2020-10-23 Thread Russell King - ARM Linux admin
On Fri, Oct 23, 2020 at 05:14:37PM +0800, Miles Chen wrote: > Since kernel no longer writes to the vector, try to replace > the vector mem type with read-only type and remove L_PTE_MT_VECTORS. > > from Catalin in [1]: > " > > I don't think this matters since the kernel no longer writes to the > >

Re: [PATCH v2 3/4] arm: mm: introduce L_PTE_SPECIAL

2020-10-23 Thread Russell King - ARM Linux admin
On Fri, Oct 23, 2020 at 05:14:36PM +0800, Miles Chen wrote: > From: Minchan Kim > > This patch introduces L_PTE_SPECIAL and pte functions for supporting > get_user_pages_fast. > > Cc: Russell King > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Steve Capper > Cc: Minchan Kim > Cc: Suren

Re: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error

2020-10-22 Thread Russell King - ARM Linux admin
On Thu, Oct 22, 2020 at 07:47:57PM +0200, Ard Biesheuvel wrote: > On Thu, 22 Oct 2020 at 19:38, Russell King - ARM Linux admin > wrote: > > > > On Thu, Oct 22, 2020 at 07:34:38PM +0300, Dmitry Osipenko wrote: > > > 22.10.2020 19:23, Russell King - ARM Linux admin пи

Re: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error

2020-10-22 Thread Russell King - ARM Linux admin
On Thu, Oct 22, 2020 at 06:33:17PM +0200, Ard Biesheuvel wrote: > On Thu, 22 Oct 2020 at 18:23, Russell King - ARM Linux admin > wrote: > > > > On Thu, Oct 22, 2020 at 06:20:40PM +0200, Ard Biesheuvel wrote: > > > On Thu, 22 Oct 2020 at 18:11, Russell King - A

Re: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error

2020-10-22 Thread Russell King - ARM Linux admin
On Thu, Oct 22, 2020 at 07:34:38PM +0300, Dmitry Osipenko wrote: > 22.10.2020 19:23, Russell King - ARM Linux admin пишет: > > On Thu, Oct 22, 2020 at 06:20:40PM +0200, Ard Biesheuvel wrote: > >> On Thu, 22 Oct 2020 at 18:11, Russell King - ARM Linux admin > >> wrote:

Re: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error

2020-10-22 Thread Russell King - ARM Linux admin
On Thu, Oct 22, 2020 at 06:20:40PM +0200, Ard Biesheuvel wrote: > On Thu, 22 Oct 2020 at 18:11, Russell King - ARM Linux admin > wrote: > > > > On Thu, Oct 22, 2020 at 06:06:32PM +0200, Ard Biesheuvel wrote: > > > On Thu, 22 Oct 2020 at 17:57, Dmitry Osipenko wrote: &g

Re: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error

2020-10-22 Thread Russell King - ARM Linux admin
On Thu, Oct 22, 2020 at 06:06:32PM +0200, Ard Biesheuvel wrote: > On Thu, 22 Oct 2020 at 17:57, Dmitry Osipenko wrote: > > > > 22.10.2020 10:06, Ard Biesheuvel пишет: > > > On Thu, 22 Oct 2020 at 05:30, Kees Cook wrote: > > >> > > >> On Thu, Oct 22, 2020 at 03:00:06AM +0300, Dmitry Osipenko

Re: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error

2020-10-22 Thread Russell King - ARM Linux admin
On Thu, Oct 22, 2020 at 01:57:37AM +0300, Dmitry Osipenko wrote: > The vfp_kmode_exception() function now is unreachable using relative > branching in THUMB2 kernel configuration, resulting in a "relocation > truncated to fit: R_ARM_THM_JUMP19 against symbol `vfp_kmode_exception'" > linker error.

Re: [PATCH v3] net: macb: add support for high speed interface

2020-10-21 Thread Russell King - ARM Linux admin
On Wed, Oct 21, 2020 at 07:44:05PM +0200, Parshuram Thombare wrote: > This patch adds support for 10GBASE-R interface to the linux driver for > Cadence's ethernet controller. > This controller has separate MAC's and PCS'es for low and high speed paths. > High speed PCS supports 100M, 1G, 2.5G, 5G

Re: [PATCH 2/3] arm: introduce IRQ stacks

2020-10-21 Thread Russell King - ARM Linux admin
On Wed, Oct 21, 2020 at 01:45:42PM +0100, Russell King - ARM Linux admin wrote: > On Wed, Oct 21, 2020 at 02:42:48PM +0200, Arnd Bergmann wrote: > > (also resending this reply from @kernel.org) > > > > On Fri, Oct 16, 2020 at 12:19 PM Arnd Bergmann wrote: > > >

Re: [PATCH 2/3] arm: introduce IRQ stacks

2020-10-21 Thread Russell King - ARM Linux admin
On Wed, Oct 21, 2020 at 02:42:48PM +0200, Arnd Bergmann wrote: > (also resending this reply from @kernel.org) > > On Fri, Oct 16, 2020 at 12:19 PM Arnd Bergmann wrote: > > On Thu, Oct 8, 2020 at 9:20 AM Maninder Singh > > wrote: > > > > > > This patch adds code for switching to IRQ stack. > >

Re: [PATCH 0/3] IRQ stack support for ARM

2020-10-21 Thread Russell King - ARM Linux admin
On Wed, Oct 21, 2020 at 01:58:21PM +0200, Arnd Bergmann wrote: > (replying to my own mail, apparently my normal outgoing email server is > blacklisted, so resending from @kernel.org) > > On Fri, Oct 16, 2020 at 12:09 PM Arnd Bergmann wrote: > > > > On Thu, Oct 8, 2020

Re: [PATCH v3 3/3] net: dsa: mv88e6xxx: Support serdes ports on MV88E6123/6131

2020-10-20 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 09:24:04PM +, Chris Packham wrote: > > On 20/10/20 11:18 pm, Russell King - ARM Linux admin wrote: > > On Tue, Oct 20, 2020 at 04:45:58PM +1300, Chris Packham wrote: > >> +void mv88e6123_serdes_get_regs(struct mv88e6xxx_chip *chip, int

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 09:06:32PM +, Chris Packham wrote: > > On 21/10/20 3:51 am, Marek Behun wrote: > > On Tue, 20 Oct 2020 15:15:25 +0100 > > Russell King - ARM Linux admin wrote: > > > >> On Tue, Oct 20, 2020 at 04:05:35PM +0200, Andrew Lunn wrote: &g

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 04:05:35PM +0200, Andrew Lunn wrote: > On Tue, Oct 20, 2020 at 03:49:40PM +0200, Marek Behun wrote: > > On Tue, 20 Oct 2020 11:15:52 +0100 > > Russell King - ARM Linux admin wrote: > > > > > On Tue, Oct 20, 2020 at 04:45:56PM +1300, Chr

Re: [PATCH v3 3/3] net: dsa: mv88e6xxx: Support serdes ports on MV88E6123/6131

2020-10-20 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 04:45:58PM +1300, Chris Packham wrote: > +void mv88e6123_serdes_get_regs(struct mv88e6xxx_chip *chip, int port, void > *_p) > +{ > + u16 *p = _p; > + u16 reg; > + int i; > + > + if (mv88e6xxx_serdes_get_lane(chip, port) == 0) > + return; > + > +

Re: [PATCH v3 1/3] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-10-20 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 04:45:56PM +1300, Chris Packham wrote: > When a port is configured with 'managed = "in-band-status"' don't force > the link up, the switch MAC will detect the link status correctly. > > Signed-off-by: Chris Packham > Reviewed-by: Andrew Lunn I thought we had issues with

Re: [PATCH v2] ARM: kprobes: Avoid fortify_panic() when copying optprobe template

2020-10-20 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 05:32:26AM +, Joel Stanley wrote: > On Fri, 9 Oct 2020 at 05:20, Joel Stanley wrote: > > > > On Thu, 1 Oct 2020 at 04:30, Andrew Jeffery wrote: > > > > > > Setting both CONFIG_KPROBES=y and CONFIG_FORTIFY_SOURCE=y on ARM leads > > > to a panic in memcpy() when

Re: [PATCH 3/3] timekeeping: remove arch_gettimeoffset

2020-10-18 Thread Russell King - ARM Linux admin
On Thu, Oct 15, 2020 at 02:38:07PM +0200, Linus Walleij wrote: > On Thu, Oct 15, 2020 at 11:53 AM Russell King - ARM Linux admin > wrote: > > > Don't be misled. It was not a matter of "enough gritty people", it > > was a matter that EBSA110 was blocking it. > &

Re: [PATCH 3/3] timekeeping: remove arch_gettimeoffset

2020-10-15 Thread Russell King - ARM Linux admin
On Thu, Oct 15, 2020 at 09:53:29AM +0200, Linus Walleij wrote: > On Thu, Oct 8, 2020 at 5:46 PM Arnd Bergmann wrote: > > > With Arm EBSA110 gone, nothing uses it any more, so the corresponding > > code and the Kconfig option can be removed. > > > > Signed-off-by: Arnd Bergmann > > Very nice

Re: [PATCH] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-14 Thread Russell King - ARM Linux admin
On Wed, Oct 14, 2020 at 04:39:47PM +0200, Lukasz Stelmach wrote: > It was <2020-10-14 śro 14:32>, when Russell King - ARM Linux admin wrote: > > In any case, the mii.c code does fill in the advertising mask even > > when autoneg is disabled, because, rightly or wrongly, the

Re: [PATCH] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-14 Thread Russell King - ARM Linux admin
On Wed, Oct 14, 2020 at 02:56:50PM +0200, Łukasz Stelmach wrote: > Do not report advertised link modes when autonegotiation is turned > off. mii_ethtool_get_link_ksettings() exhibits the same behaviour. Please explain why this is a desirable change. Referring to some other piece of code isn't a

Re: [PATCH] gpu/drm/armada: fix unused parameter warning

2020-10-12 Thread Russell King - ARM Linux admin
On Mon, Oct 12, 2020 at 04:57:24AM -0700, Bernard Zhao wrote: > Functions armada_drm_crtc_atomic_flush & > armada_drm_crtc_atomic_enable don`t use the second parameter. > So we may get warning like : > warning: unused parameter ‘***’ [-Wunused-parameter]. > This change is to fix the compile

Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-12 Thread Russell King - ARM Linux admin
On Mon, Oct 12, 2020 at 12:03:18PM +0200, Sebastian Andrzej Siewior wrote: > On 2020-10-11 22:32:38 [+0100], Russell King - ARM Linux admin wrote: > > I don't have a problem getting rid of the hex numbers in [< >] > > although then I will need to convert the symbol back to

Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-11 Thread Russell King - ARM Linux admin
On Fri, Oct 09, 2020 at 10:18:20AM +0200, Sebastian Andrzej Siewior wrote: > On 2020-10-09 09:08:50 [+0100], Russell King - ARM Linux admin wrote: > > I am really not happy about this - it hurts at least my ability to > > debug the kernel when people post oopses to the mailing list

Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-09 Thread Russell King - ARM Linux admin
On Fri, Oct 09, 2020 at 03:59:57PM +0800, Xiaoming Ni wrote: > Printing raw pointer values in backtraces has potential security > implications and are of questionable value anyway. > > This patch follows x86 and arm64's lead and removes the "Exception stack:" > dump from kernel backtraces: >

Re: [PATCH 0/3] ARM, timers: ebsa110 cleanup

2020-10-08 Thread Russell King - ARM Linux admin
On Thu, Oct 08, 2020 at 05:45:58PM +0200, Arnd Bergmann wrote: > The ebsa110 platform is the last thing that uses > CONFIG_ARCH_USES_GETTIMEOFFSET, and Russell has previously said that he > thinks the platform can be retired now. > > Removing it allows us clean up the timer code by throwing out

Re: [PATCH 0/3] IRQ stack support for ARM

2020-10-08 Thread Russell King - ARM Linux admin
On Thu, Oct 08, 2020 at 12:45:30PM +0530, Maninder Singh wrote: > Observed Stack Overflow on 8KB kernel stack on ARM specially > incase on network interrupts, which results in undeterministic behaviour. > So there is need for per cpu dedicated IRQ stack for ARM. > > As ARm does not have extra

Re: [PATCH v2] i2c: pxa: move to generic GPIO recovery

2020-10-04 Thread Russell King - ARM Linux admin
On Sun, Oct 04, 2020 at 12:16:56PM +0300, Codrin Ciubotariu wrote: > Starting with > commit 75820314de26 ("i2c: core: add generic I2C GPIO recovery") > GPIO bus recovery is supported by the I2C core, so we can remove the > driver implementation and use that one instead. > > Signed-off-by: Codrin

Re: [PATCH] i2c: pxa: move to generic GPIO recovery

2020-10-03 Thread Russell King - ARM Linux admin
On Sat, Oct 03, 2020 at 07:21:41PM +0300, Codrin Ciubotariu wrote: > Starting with > commit 75820314de26 ("i2c: core: add generic I2C GPIO recovery") > GPIO bus recovery is supported by the I2C core, so we can remove the > driver implementation and use that one instead. > > Signed-off-by: Codrin

Re: [net-next PATCH v1 3/7] net: phy: Introduce fwnode_get_phy_id()

2020-10-02 Thread Russell King - ARM Linux admin
On Fri, Oct 02, 2020 at 08:14:07AM -0700, Florian Fainelli wrote: > On 10/2/2020 4:05 AM, Grant Likely wrote: > > On 30/09/2020 17:04, Calvin Johnson wrote: > > > Extract phy_id from compatible string. This will be used by > > > fwnode_mdiobus_register_phy() to create phy device using the > > >

Re: [net-next PATCH v1 3/7] net: phy: Introduce fwnode_get_phy_id()

2020-09-30 Thread Russell King - ARM Linux admin
On Wed, Sep 30, 2020 at 06:34:40PM +0200, Andrew Lunn wrote: > > @@ -2866,7 +2888,15 @@ EXPORT_SYMBOL_GPL(device_phy_find_device); > > */ > > struct fwnode_handle *fwnode_get_phy_node(struct fwnode_handle *fwnode) > > { > > - return fwnode_find_reference(fwnode, "phy-handle", 0); > > +

Re: [PATCH 4/9] ARM: syscall: always store thread_info->syscall

2020-09-28 Thread Russell King - ARM Linux admin
On Mon, Sep 28, 2020 at 02:42:43PM +0200, Arnd Bergmann wrote: > > I need some idea how this numberspace is managed in order to > > understand the code so I can review it, I guess it all makes perfect > > sense but I need some background here. > > I also had never understood this part before, and

Re: [PATCH 1/4] ARM/omap1: switch to use dma_direct_set_offset for lbus DMA offsets

2020-09-23 Thread Russell King - ARM Linux admin
On Mon, Sep 21, 2020 at 08:47:23AM +0200, Christoph Hellwig wrote: > On Mon, Sep 21, 2020 at 09:44:18AM +0300, Tony Lindgren wrote: > > * Janusz Krzysztofik [200919 22:29]: > > > Hi Tony, > > > > > > On Friday, September 18, 2020 7:49:33 A.M. CEST Tony Lindgren wrote: > > > > * Christoph Hellwig

Re: [PATCH v2 0/9] ARM: remove set_fs callers and implementation

2020-09-19 Thread Russell King - ARM Linux admin
On Fri, Sep 18, 2020 at 02:46:15PM +0200, Arnd Bergmann wrote: > Hi Christoph, Russell, > > Here is an updated series for removing set_fs() from arch/arm, > based on the previous feedback. > > I have tested the oabi-compat changes using the LTP tests for the three > modified syscalls using an

Re: [PATCH 2/9] ARM: traps: use get_kernel_nofault instead of set_fs()

2020-09-18 Thread Russell King - ARM Linux admin
On Thu, Sep 17, 2020 at 07:29:37PM +0200, Arnd Bergmann wrote: > On Tue, Sep 8, 2020 at 8:15 AM Christoph Hellwig wrote: > > > > > +static void dump_mem(const char *, const char *, unsigned long, unsigned > > > long, bool kernel_mode); > > > > This adds a pointlessly long line. > > Fixed. > >

<    1   2   3   4   5   6   7   8   9   10   >