[PATCH v5] PCI: endpoint: Fix NULL pointer dereference for ->get_features()

2021-03-26 Thread Shradha Todi
: Use pci_epc_get_features() to get EPC features") Reviewed-by: Pankaj Dubey Reviewed-by: Kishon Vijay Abraham I Signed-off-by: Sriram Dash Signed-off-by: Shradha Todi --- Changes w.r.t. v4: https://lkml.org/lkml/2021/1/12/815 - Changed commit message to remove time stamp as suggested

[PATCH v3] PCI: dwc: Add upper limit address for outbound iATU

2021-02-02 Thread Shradha Todi
The size parameter is unsigned long type which can accept size > 4GB. In that case, the upper limit address must be programmed. Add support to program the upper limit address and set INCREASE_REGION_SIZE in case size > 4GB. Signed-off-by: Shradha Todi Reviewed-by: Pankaj Dubey Reviewed-b

RE: [PATCH] checkpatch: add warning for line space after "Fixes:" tag

2021-02-01 Thread Shradha Todi
> -Original Message- > From: Joe Perches > Subject: Re: [PATCH] checkpatch: add warning for line space after "Fixes:" tag > > On Thu, 2021-01-28 at 20:56 +0530, Shradha Todi wrote: > > Add a check to give warning for line break between F

[PATCH] checkpatch: add warning for line space after "Fixes:" tag

2021-01-28 Thread Shradha Todi
Add a check to give warning for line break between Fixes tag and signature tags as that is the commonly followed style. Also add a --fix option to delete space lines after "Fixes:" tag. Signed-off-by: Lakshay Mehra Signed-off-by: Shradha Todi --- scripts/checkpatch.pl | 9 +++

RE: [PATCH v4] PCI: endpoint: Fix NULL pointer dereference for ->get_features()

2021-01-27 Thread Shradha Todi
> -Original Message- > From: Leon Romanovsky > Subject: Re: [PATCH v4] PCI: endpoint: Fix NULL pointer dereference for - > >get_features() > > On Tue, Jan 19, 2021 at 03:25:10PM +0530, Shradha Todi wrote: > > > -Original Message- > > > F

RE: [PATCH v2] PCI: dwc: Add upper limit address for outbound iATU

2021-01-27 Thread Shradha Todi
Hi, Gentle Ping.. Thanks > -Original Message- > From: Shradha Todi > Sent: Wednesday, January 6, 2021 4:20 PM > Subject: [PATCH v2] PCI: dwc: Add upper limit address for outbound iATU > > The size parameter is unsigned long type which can accept size > 4GB. In t

RE: [PATCH v4] PCI: endpoint: Fix NULL pointer dereference for ->get_features()

2021-01-19 Thread Shradha Todi
> -Original Message- > From: Leon Romanovsky > Subject: Re: [PATCH v4] PCI: endpoint: Fix NULL pointer dereference for - > >get_features() > > On Tue, Jan 12, 2021 at 07:32:25PM +0530, Shradha Todi wrote: > > get_features ops of pci_epc_ops may return

RE: [PATCH v2] PCI: dwc: Change size to u64 for EP outbound iATU

2021-01-19 Thread Shradha Todi
Gentle Ping. Thanks. > -Original Message- > From: Shradha Todi > Subject: [PATCH v2] PCI: dwc: Change size to u64 for EP outbound iATU > > Since outbound iATU permits size to be greater than 4GB for which the > support is also available, allow EP function to sen

[PATCH v4] PCI: endpoint: Fix NULL pointer dereference for ->get_features()

2021-01-12 Thread Shradha Todi
Signed-off-by: Shradha Todi --- drivers/pci/endpoint/functions/pci-epf-test.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c index e4e51d8..1b30774 100644 --- a/drivers/pc

[PATCH v7 5/5] arm64: tegra: Add support for ZRX DC PHY property

2021-01-07 Thread Shradha Todi
DesignWare controller driver provides the support to handle the PHYs which are compliant to ZRX-DC specification based on "phy-zrxdc-compliant" DT property. So, add "phy-zrxdc-compliant" property in tegra PCIe PHY DT nodes. Signed-off-by: Pankaj Dubey Signed-off-by: Shradha T

[PATCH v7 4/5] PCI: tegra: Remove platform driver support for ZRX-DC compliant PHY

2021-01-07 Thread Shradha Todi
e. Signed-off-by: Anvesh Salveru Signed-off-by: Pankaj Dubey Signed-off-by: Shradha Todi Cc: Lorenzo Pieralisi Cc: Andrew Murray Cc: Bjorn Helgaas Cc: Vidya Sagar Cc: Jonathan Hunter --- drivers/pci/controller/dwc/pcie-tegra194.c | 17 - 1 file changed, 8 insertions(+), 9

[PATCH v7 3/5] dt-bindings: PHY: P2U: Add binding for ZRX-DC PHY property

2021-01-07 Thread Shradha Todi
ty in PCIe PHY DT node. Signed-off-by: Anvesh Salveru Signed-off-by: Pankaj Dubey Signed-off-by: Shradha Todi Cc: Rob Herring Cc: Kishon Vijay Abraham I Cc: Vidya Sagar --- Documentation/devicetree/bindings/phy/phy-tegra194-p2u.txt | 4 1 file changed, 4 insertions(+) diff --git a/Doc

[PATCH v7 2/5] PCI: dwc: add support to handle ZRX-DC Compliant PHYs

2021-01-07 Thread Shradha Todi
to specify this property to the controller. Signed-off-by: Anvesh Salveru Signed-off-by: Pankaj Dubey Signed-off-by: Shradha Todi Cc: Jingoo Han Cc: Gustavo Pimentel Cc: Lorenzo Pieralisi Cc: Rob Herring Cc: Bjorn Helgaas --- drivers/pci/controller/dwc/pcie-designware.c | 6

[PATCH v7 1/5] phy: core: add phy_property_present method

2021-01-07 Thread Shradha Todi
register to specify about ZRX-DC compliance property of the PHY, which reduces the power consumption during lower power states. Signed-off-by: Anvesh Salveru Signed-off-by: Pankaj Dubey Signed-off-by: Shradha Todi Cc: Kishon Vijay Abraham I Cc: Vinod Koul --- drivers/phy/phy-core.c | 20

[PATCH v7 0/5] Add support to handle ZRX-DC Compliant PHYs

2021-01-07 Thread Shradha Todi
Dubey (3): phy: core: add phy_property_present method PCI: dwc: add support to handle ZRX-DC Compliant PHYs PCI: tegra: Remove platform driver support for ZRX-DC compliant PHY Shradha Todi (2): dt-bindings: PHY: P2U: Add binding for ZRX-DC PHY property arm64: tegra: Add support for ZRX

[PATCH v2] PCI: dwc: Add upper limit address for outbound iATU

2021-01-06 Thread Shradha Todi
The size parameter is unsigned long type which can accept size > 4GB. In that case, the upper limit address must be programmed. Add support to program the upper limit address and set INCREASE_REGION_SIZE in case size > 4GB. Signed-off-by: Shradha Todi --- v1: https://lkml.org/lkml/2020/12/

[PATCH v3] PCI: endpoint: Fix NULL pointer dereference for ->get_features()

2021-01-06 Thread Shradha Todi
Signed-off-by: Shradha Todi --- v2: https://lkml.org/lkml/2020/12/18/691 v3: Addressed Bjorn's comment to enhance commit message by adding fixes tag drivers/pci/endpoint/functions/pci-epf-test.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/pci/endpoint

[PATCH v2] PCI: dwc: Change size to u64 for EP outbound iATU

2021-01-06 Thread Shradha Todi
Since outbound iATU permits size to be greater than 4GB for which the support is also available, allow EP function to send u64 size instead of truncating to u32. Signed-off-by: Shradha Todi --- v1: https://lkml.org/lkml/2020/12/18/690 v2: Addressed Bjorn's review on to keep commit message

RE: [PATCH] PCI: dwc: Change size to u64 for EP outbound iATU

2020-12-23 Thread Shradha Todi
> From: Bjorn Helgaas > Subject: Re: [PATCH] PCI: dwc: Change size to u64 for EP outbound iATU > > On Fri, Dec 18, 2020 at 09:04:08PM +0530, Shradha Todi wrote: > > Since outbound iATU permits size to be greater than 4GB for which the > > support is also available, allow

RE: [PATCH v2] PCI: endpoint: Fix NULL pointer dereference for ->get_features()

2020-12-23 Thread Shradha Todi
> From: Bjorn Helgaas > Subject: Re: [PATCH v2] PCI: endpoint: Fix NULL pointer dereference for - > >get_features() > > On Fri, Dec 18, 2020 at 09:15:16PM +0530, Shradha Todi wrote: > > get_features ops of pci_epc_ops may return NULL, causing NULL pointer > > de

RE: [PATCH] PCI: dwc: Add upper limit address for outbound iATU

2020-12-23 Thread Shradha Todi
> From: Rob Herring > Subject: Re: [PATCH] PCI: dwc: Add upper limit address for outbound iATU > > On Sun, Dec 20, 2020 at 6:56 PM Shradha Todi > wrote: > > > > The size parameter is unsigned long type which can accept size > 4GB. > > In that case, the up

[PATCH] PCI: dwc: Add upper limit address for outbound iATU

2020-12-20 Thread Shradha Todi
The size parameter is unsigned long type which can accept size > 4GB. In that case, the upper limit address must be programmed. Add support to program the upper limit address and set INCREASE_REGION_SIZE in case size > 4GB. Signed-off-by: Shradha Todi --- drivers/pci/controller/dw

[PATCH v2] PCI: endpoint: Fix NULL pointer dereference for ->get_features()

2020-12-18 Thread Shradha Todi
is not found. Reviewed-by: Pankaj Dubey Signed-off-by: Sriram Dash Signed-off-by: Shradha Todi --- v2: rebase on v1 v1: https://lore.kernel.org/patchwork/patch/1208269/ drivers/pci/endpoint/functions/pci-epf-test.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

[PATCH] PCI: dwc: Change size to u64 for EP outbound iATU

2020-12-18 Thread Shradha Todi
Since outbound iATU permits size to be greater than 4GB for which the support is also available, allow EP function to send u64 size instead of truncating to u32. Signed-off-by: Shradha Todi --- drivers/pci/controller/dwc/pcie-designware.c | 2 +- drivers/pci/controller/dwc/pcie-designware.h | 2