Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update()

2016-07-24 Thread YOSHIFUJI Hideaki/吉藤英明
Hi, Chunhui He wrote: > Hi, > > On Fri, 22 Jul 2016 10:20:01 +0300 (EEST), Julian Anastasov > wrote: >> >> Hello, >> >> On Thu, 21 Jul 2016, Chunhui He wrote: >> >>> If neigh entry was CONNECTED and address is not changed, and if new state is >>> STALE, entry state will not change. Because

Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get()

2015-12-22 Thread YOSHIFUJI Hideaki
o be free ip6addrlbl_entry pointer. >> >> Fix this by inverting ip6addrlbl_hold() check. >> >> Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address >> selection policy table.") >> Signed-off-by: Andrey Ryabinin > > Good c

Re: [PATCH] ipv6: Fixed source specific default route handling.

2015-06-22 Thread YOSHIFUJI Hideaki/吉藤英明
Matthias Schiffer wrote: > On 06/22/2015 07:58 AM, Steven Barth wrote: >> On 22.06.2015 00:35, Matthias Schiffer wrote: >>> Could you explain in detail what you mean with "If you want specific SA, >>> add same route with higher metric and/or (more) specific src match."? >>> Routes aren't bound to s

Re: [PATCH] neighbour: Convert if statment in the function, neigh_add_timer to a WARN_ON

2015-06-01 Thread YOSHIFUJI Hideaki/吉藤英明
Nicholas Krause wrote: > This converts the if statement for dumping the stack into a > WARN_ON in order to make this function's debugging check > simpler and have a cleaner output when this condition > occurs inside this function for when bugs related to > adding a duplicate neighbour table timer a

Re: [PATCH 2/2] net: Export IGMP/MLD message validation code

2015-04-13 Thread YOSHIFUJI Hideaki/吉藤英明
Linus Lüssing wrote: > On Fri, Apr 10, 2015 at 07:46:39PM +0200, Linus Lüssing wrote: >> diff --git a/net/ipv6/mcast_snoop.c b/net/ipv6/mcast_snoop.c >> new file mode 100644 >> index 000..95b34c0 >> --- /dev/null >> +++ b/net/ipv6/mcast_snoop.c >> @@ -0,0 +1,198 @@ >> +/* Copyright (C) 2015: Li

Re: [PATCH 4/9 net-next] ipv6: replace if/BUG by BUG_ON

2015-03-30 Thread YOSHIFUJI Hideaki
Hi, Fabian Frederick wrote: > Signed-off-by: Fabian Frederick > --- > net/ipv6/addrconf.c | 3 +-- > net/ipv6/esp6.c | 3 +-- > net/ipv6/netfilter/nf_conntrack_reasm.c | 3 +-- > 3 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/net/ip

Re: [PATCH net v2] ipv6: Prevent ipv6_find_hdr() from returning ENOENT for valid non-first fragments

2015-01-09 Thread YOSHIFUJI Hideaki
Acked-by: YOSHIFUJI Hideaki -- Hideaki Yoshifuji Technical Division, MIRACLE LINUX CORPORATION -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-i

Re: [PATCH 2/4] tun: Use iovec iterators

2014-11-04 Thread YOSHIFUJI Hideaki
Hi, Herbert Xu wrote: Oops, this patch had a left-over skb_pull which made it broken. Here is a fixed version. tun: Use iovec iterators This patch removes the use of skb_copy_datagram_const_iovec in favour of the iovec iterator-based skb_copy_datagram_iter. Signed-off-by: Herbert Xu diff --

[PATCH] isdnloop: Validate NUL-terminated strings from user.

2014-04-01 Thread YOSHIFUJI Hideaki
Return -EINVAL unless all of user-given strings are correctly NUL-terminated. Signed-off-by: YOSHIFUJI Hideaki --- drivers/isdn/isdnloop/isdnloop.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/isdn/isdnloop/isdnloop.c b/drivers/isdn/isdnloop/isdnloop.c index 02125e6

Re: [PATCH] isdnloop: NUL-terminate strings from userspace

2014-04-01 Thread YOSHIFUJI Hideaki
Vegard Nossum wrote: > Both the in-kernel and BSD strlcpy() require that the source string is > NUL terminated. We could use strncpy() + explicitly terminate the result, > but this relies on src and dest having the same size, so the safest thing > to do seems to explicitly terminate the source stri

Re: Disable IPv4-mapped - enforce IPV6_V6ONLY

2013-02-25 Thread YOSHIFUJI Hideaki
Hello. Alexander Holler wrote: > Am 22.02.2013 16:21, schrieb Alexander Holler: >> Hello, >> >> I'm searching for a way to either enforce IPV6_V6ONLY or to block >> IPv4-mapped addresses on ipv6-sockets (e.g. by using iptables) system-wide. >> >> E.g. net.ipv6.bindv6only doesn't help if something

Re: WARNING: at net/core/neighbour.c:1545 neigh_table_init()

2013-02-09 Thread YOSHIFUJI Hideaki
Eric Dumazet wrote: > On Sat, 2013-02-09 at 20:39 +0800, Fengguang Wu wrote: >> Greetings, >> >> I got the below oops in linux-next and the first bad commit is >> >> commit 455e987c0c2eb2c9045dc854559474cf41509965 >> Merge: 7c17e48 fd6da69 >> Author: Linus Torvalds >> Date: Sat Dec 1 13:07:48 20

[PATCH net-next] net neighbour,decnet: Ensure to align device private data on preferred alignment.

2013-02-09 Thread YOSHIFUJI Hideaki
, but on 32bit archs, it was not. Introduce NEIGH_ENTRY_SPACE() macro to ensure that protocol-specific entry-size meets our requirement. Reported-by: Fengguang Wu Signed-off-by: YOSHIFUJI Hideaki --- include/net/neighbour.h |1 + net/decnet/dn_neigh.c |2 +- 2 files changed, 2

[PATCH] digsig: Fix memory leakage in digsig_verify_rsa().

2013-01-25 Thread YOSHIFUJI Hideaki
digsig_verify_rsa() does not free kmalloc'ed buffer returned by mpi_get_buffer(). Signed-off-by: YOSHIFUJI Hideaki --- lib/digsig.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/digsig.c b/lib/digsig.c index 8c0e629..dc2be7e 100644 --- a/lib/digsig.c +++ b/lib/digsig.c @@ -

Re: [PATCH] CMAC support for CryptoAPI, fixed patch issues, indent, and testmgr build issues

2013-01-23 Thread YOSHIFUJI Hideaki
YOSHIFUJI Hideaki wrote: > Jussi Kivilinna wrote: > >>>>> diff --git a/include/uapi/linux/pfkeyv2.h >>>>> b/include/uapi/linux/pfkeyv2.h >>>>> index 0b80c80..d61898e 100644 >>>>> --- a/include/uapi/linux/pfkeyv2.h >>

Re: [PATCH] CMAC support for CryptoAPI, fixed patch issues, indent, and testmgr build issues

2013-01-23 Thread YOSHIFUJI Hideaki
Jussi Kivilinna wrote: >>> > diff --git a/include/uapi/linux/pfkeyv2.h >>> > b/include/uapi/linux/pfkeyv2.h >>> > index 0b80c80..d61898e 100644 >>> > --- a/include/uapi/linux/pfkeyv2.h >>> > +++ b/include/uapi/linux/pfkeyv2.h >>> > @@ -296,6 +296,7 @@ struct sadb_x_kmaddress { >>> > #define SADB_

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread YOSHIFUJI Hideaki
Stephan Gatzka wrote: > >> "Off-link source" means the source exists on the different L2 >> network. In other words, source is connected via router(s). >> >> ethernet firewire >> Host -- Router Host >> > > O.k., understood. But the receiving route

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread YOSHIFUJI Hideaki
Stephan Gatzka wrote: > >>> Indeed neither the device nor the lower drivers check protocol checksums. >>> But the CRCs of the encapsulating 1394 packets are checked in hardware. >>> Shall protocol checksums be verified regardless? >> >> Yes, because packets may come from off-link source. >> > > H

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread YOSHIFUJI Hideaki
Stefan Richter wrote: > On Jan 20 YOSHIFUJI Hideaki wrote: >> It is wrong to set skb->ip_summed to CHECKSUM_UNNECESSARY unless >> the device has already checked it. >> >> Signed-off-by: YOSHIFUJI Hideaki >> --- >> drivers/firewire/net.c |2 +- >

[PATCH] firewire net: Use LL_RESERVED_SPACE(), HH_DATA_OFF().

2013-01-20 Thread YOSHIFUJI Hideaki
Signed-off-by: YOSHIFUJI Hideaki --- drivers/firewire/net.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c index df6a1ca..2b27bff 100644 --- a/drivers/firewire/net.c +++ b/drivers/firewire/net.c @@ -270,7 +270,7

[PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-19 Thread YOSHIFUJI Hideaki
It is wrong to set skb->ip_summed to CHECKSUM_UNNECESSARY unless the device has already checked it. Signed-off-by: YOSHIFUJI Hideaki --- drivers/firewire/net.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c index e7a71

Re: Redefinition of struct in6_addr in and

2013-01-18 Thread YOSHIFUJI Hideaki
Carlos O'Donell wrote: > On 01/18/2013 05:44 AM, Pedro Alves wrote: >> On 01/18/2013 04:22 AM, Carlos O'Donell wrote: >>> On Thu, Jan 17, 2013 at 11:20 PM, Mike Frysinger wrote: On Wednesday 16 January 2013 22:15:38 David Miller wrote: > From: Carlos O'Donell > Date: Wed, 16 Jan 2013

Re: Redefinition of struct in6_addr in and

2013-01-16 Thread YOSHIFUJI Hideaki
Carlos O'Donell wrote: > diff --git a/include/uapi/linux/in6.h b/include/uapi/linux/in6.h > index f79c372..a2b16a5 100644 > --- a/include/uapi/linux/in6.h > +++ b/include/uapi/linux/in6.h > @@ -23,6 +23,13 @@ > > #include > > +/* If a glibc-based userspace has already included in.h, then we w

Re: Redefinition of struct in6_addr in and

2013-01-16 Thread YOSHIFUJI Hideaki
Carlos O'Donell wrote: > diff --git a/include/uapi/linux/in6.h b/include/uapi/linux/in6.h > index f79c372..a2b16a5 100644 > --- a/include/uapi/linux/in6.h > +++ b/include/uapi/linux/in6.h : > #define IPV6_PRIORITY_14 0x0e00 > #define IPV6_PRIORITY_15 0x0f00 > > + > +#ifn

Re: Redefinition of struct in6_addr in and

2013-01-16 Thread YOSHIFUJI Hideaki
Cong Wang wrote: > (Cc'ing some glibc developers...) > > Hello, > > In glibc source file inet/netinet/in.h and kernel source file > include/uapi/linux/in6.h, both define struct in6_addr, and both are > visible to user applications. Thomas reported a conflict below. > > So, how can we handle this

Re: [PATCH 1/1] ipv6: fix the noflags test in addrconf_get_prefix_route

2013-01-10 Thread YOSHIFUJI Hideaki
!= 0)) > + if ((rt->rt6i_flags & noflags) != 0) > continue; > dst_hold(&rt->dst); > break; > Acked-by: YOSHIFUJI Hideaki --yoshfuji -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [IPv6] crashed when __ip6_del_rt()

2012-12-18 Thread YOSHIFUJI Hideaki
stanley zhou wrote: > when call write_lock_bh() table is null cause crash in __ip6_del_rt(). > kernel version is 2.6.30.10 : > static int __ip6_del_rt(struct rt6_info *rt, struct nl_info *info) > { > int err; > struct fib6_table *table; > struct net *net = dev_net(rt->rt6i_dev); > > if (rt == net

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 07 Feb 2008 10:40:19 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: > [NET] IPV4: lower stack usage in cookie_hash() function > > 400 bytes allocated on stack might be a litle bit too much. Using a > per_cpu var is more friendly. > > Signed-off-by: Eric

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 7 Feb 2008 21:49:26 -0800), Glenn Griffin <[EMAIL PROTECTED]> says: > Updated to incorporate Eric's suggestion of using a per cpu buffer > rather than allocating on the stack. Just a two line change, but will > resend in it's entirety. > > Signed-off-by:

Re: [PATCH] IPV4: fix compile error building without CONFIG_FS_PROC

2008-02-03 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 04 Feb 2008 08:47:29 +0800), Li Zefan <[EMAIL PROTECTED]> says: > compile error building without CONFIG_FS_PROC. : > The exit method should have no return values... Have you really tested this with CONFIG_FS_PROC? --yoshfuji -- To unsubscribe from this li

Re: [PATCH] IPv4: Enable use of 240/4 address space

2008-01-19 Thread YOSHIFUJI Hideaki / 吉藤英明
100 > Subject: [PATCH] IPv4: enable use of 240/4 address space > > This short patch modifies the IPv4 networking to enable use of the > 240.0.0.0/4 (aka "class-E") address space as propsed in the internet > draft draft-fuller-240space-00.txt. > > Signed-off-by: Jan

Re: [PATCH] IPv4: Enable use of 240/4 address space

2008-01-17 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 18 Jan 2008 11:13:19 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> says: > Assuming IN_BADCLASS() is still there, we should not reuse the name > of "ipv6_is_badclass" because the their meanings are different. Agai

Re: [PATCH] IPv4: Enable use of 240/4 address space

2008-01-17 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 18 Jan 2008 02:52:08 +0100 (CET)), Jan Engelhardt <[EMAIL PROTECTED]> says: > > On Jan 18 2008 10:26, YOSHIFUJI Hideaki / 吉藤英明 wrote: > >> -#define IN_EXPERIMENTAL(a) long int) (a)) & 0xf000) == > >>

Re: [PATCH] IPv4: Enable use of 240/4 address space

2008-01-17 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 18 Jan 2008 02:13:52 +0100 (CET)), Jan Engelhardt <[EMAIL PROTECTED]> says: > diff --git a/include/linux/in.h b/include/linux/in.h > index 27d8a5a..b01bf75 100644 > --- a/include/linux/in.h > +++ b/include/linux/in.h > @@ -216,9 +216,6 @@ struct sockaddr_in

Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-11 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Mon, 7 Jan 2008 17:10:57 -0800), Vince Fuller <[EMAIL PROTECTED]> says: > #define IN_MULTICAST_NET 0xF000 > > +#define IN_CLASSE(a) long int) (a)) & 0xf000) == 0xf000) > +#define IN_CLASSE_NET 0xff00 > +#

Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 11 Jan 2008 17:48:57 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> > Date: Fri, 11 Jan 2008 21:41:20 +0900 (JST) > > > There is no positive consesus on this dr

Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 11 Jan 2008 12:17:02 +0100), Andi Kleen <[EMAIL PROTECTED]> says: > Vince Fuller <[EMAIL PROTECTED]> writes: > > > from Vince Fuller <[EMAIL PROTECTED]> > > > > This set of diffs modify the 2.6.20 kernel to enable use of the 240/4 > > (aka "class-E") addre

Re: [PATCH 1/4] fs/autofs: Use time_before, time_before_eq, etc.

2007-12-27 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 27 Dec 2007 08:08:53 +0100 (CET)), Julia Lawall <[EMAIL PROTECTED]> says: > On Wed, 26 Dec 2007, H. Peter Anvin wrote: > > > Ray Lee wrote: > > > On Dec 26, 2007 7:21 AM, Julia Lawall <[EMAIL PROTECTED]> wrote: > > > > - if (jiffies - ent->la

Re: [PATCH 20/38] drivers/net: Use time_before, time_before_eq, etc.

2007-12-24 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 24 Dec 2007 15:40:06 +0100 (CET)), Julia Lawall <[EMAIL PROTECTED]> says: > diff -r -u -p a/drivers/net/cassini.c b/drivers/net/cassini.c > --- a/drivers/net/cassini.c 2007-10-22 11:25:14.0 +0200 > +++ b/drivers/net/cassini.c 2007-12-23 20:38:34

Re: [PATCH 15/38] drivers/infiniband: Use time_before, time_before_eq, etc.

2007-12-24 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 24 Dec 2007 15:28:42 +0100 (CET)), Julia Lawall <[EMAIL PROTECTED]> says: > diff -r -u -p a/drivers/infiniband/hw/ipath/ipath_mad.c > b/drivers/infiniband/hw/ipath/ipath_mad.c > --- a/drivers/infiniband/hw/ipath/ipath_mad.c 2007-10-22 11:25:09.0 >

Re: [PATCH 3/38] arch/ia64/sn: Use time_before, time_before_eq, etc.

2007-12-24 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 24 Dec 2007 15:18:56 +0100 (CET)), Julia Lawall <[EMAIL PROTECTED]> says: > diff -r -u -p a/arch/ia64/sn/kernel/xpc_main.c > b/arch/ia64/sn/kernel/xpc_main.c > --- a/arch/ia64/sn/kernel/xpc_main.c 2007-11-12 10:35:56.0 +0100 > +++ b/arch/ia64/sn/k

Re: [PATCH 31/38] net/decnet: Use time_before, time_before_eq, etc.

2007-12-24 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 24 Dec 2007 15:47:32 +0100 (CET)), Julia Lawall <[EMAIL PROTECTED]> says: > From: Julia Lawall <[EMAIL PROTECTED]> > > The functions time_before, time_before_eq, time_after, and time_after_eq > are more robust for comparing jiffies against other values.

Re: "ip neigh show" not showing arp cache entries?

2007-12-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 12 Dec 2007 15:57:08 -0600), "Chris Friesen" <[EMAIL PROTECTED]> says: > > You may try other versions of this command > > > > http://devresources.linux-foundation.org/dev/iproute2/download/ > > They appear to be numbered by kernel version, and the above v

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-21 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 22 Nov 2007 10:34:03 +0800), Herbert Xu <[EMAIL PROTECTED]> says: > On Wed, Nov 21, 2007 at 07:17:40PM -0500, Jeff Garzik wrote: > > > > For those interested, I am dealing with a UDP app that already does very > > strong checksumming and encryption, so add

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-21 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 21 Nov 2007 07:45:32 -0500), Jeff Garzik <[EMAIL PROTECTED]> says: > > SO_NO_CHECK support for IPv6 appeared to be missing. This is presented, > based on a reading of net/ipv4/udp.c. Disagree. UDP checksum is mandatory in IPv6. --yoshfuji - To unsubscrib

Re: [TOMOYO #5 11/18] Network access control functions.

2007-11-16 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Sat, 17 Nov 2007 02:34:50 +0900), [EMAIL PROTECTED] says: > + *cp++ = '\0'; > + count = sscanf(cp, > +NIP6_FMT "-" NIP6_FMT, > +&min[0], &min[1], &min[2], &min[3], > +&min[4], &min[5], &

Re: [PATCH 2/2] add SubmittingPatches to Documentation/ja_JP

2007-10-26 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. Basically okay, but please refer to the original DCO document. Your mailer is broken. You should include "charset" parameter in your multipart. Maybe it is better to prepare a git repository, or attach it as a binary (application/octet-stream). --yoshfuji In article <[EMAIL PROTECTED]>

Re: NVIDIA Ethernet & invalid MAC

2007-10-16 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 16 Oct 2007 12:00:45 -0400), Jeff Garzik <[EMAIL PROTECTED]> says: > Alan Cox wrote: > >> See the below for another report of this: > >> > >> http://marc.info/?t=11921571691&r=1&w=2 > >> > >> And apparently some motherboard vendors have their own alloca

Re: [TOMOYO 05/15](repost) Domain transition handler functions.

2007-10-03 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 3 Oct 2007 23:26:57 +0900), Tetsuo Handa <[EMAIL PROTECTED]> says: > Peter Zijlstra wrote: > > Also, how do you avoid referencing dead data with your sll? I haven't > > actually looked at your patches, but the simple scheme you outlined > > didn't handle th

Re: [TOMOYO 05/15](repost) Domain transition handler functions.

2007-10-03 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 3 Oct 2007 22:04:11 +0900), Tetsuo Handa <[EMAIL PROTECTED]> says: > Well, is there a way to avoid read_lock when reading list? > > Currently, TOMOYO Linux avoids read_lock, on the assumption that > (1) First, ptr->next is initialized with NULL. > (2) Late

Re: [TOMOYO 05/15](repost) Domain transition handler functions.

2007-10-03 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 3 Oct 2007 20:24:52 +0900), Tetsuo Handa <[EMAIL PROTECTED]> says: > It seems that standard kernel list API does not have singly-linked list > manipulation. > I'm considering the following list manipulation API. Tstsuo, please name it "slist", which is we

Re: [TOMOYO 05/15](repost) Domain transition handler functions.

2007-10-02 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 2 Oct 2007 21:44:57 +0900), Tetsuo Handa <[EMAIL PROTECTED]> says: > If I use "struct hlist_node" which has two pointers, > it needs more memory than "struct something" which has one pointer. > It is possible to use API defined in include/linux/list.h , > b

Re: [PATCH] 2.6.22.6 NETWORKING [IPV4]: Always use source addr in skb to reply packet

2007-09-17 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 17 Sep 2007 19:20:44 -0700 (PDT)), David Miller <[EMAIL PROTECTED]> says: > From: lepton <[EMAIL PROTECTED]> > Date: Tue, 18 Sep 2007 10:16:17 +0800 > > > Hi, > > In some situation, icmp_reply and ip_send_reply will send > > out packet with the wrong s

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 09 Aug 2007 20:23:16 -0600), [EMAIL PROTECTED] (Eric W. Biederman) says: > YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> writes: > > > Would you explain why it does not work properly > > for those cases? > > Mostly

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 09 Aug 2007 18:56:09 -0600), [EMAIL PROTECTED] (Eric W. Biederman) says: > > - In ipv6 ndisc_ifinfo_syctl_change so it doesn't depend on binary > sysctl names for a function that works with proc. : Well, retrans_time_ms and base_reachable_time_ms superc

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 09 Aug 2007 18:49:21 -0700 (PDT)), David Miller <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> > Date: Fri, 10 Aug 2007 10:47:10 +0900 (JST) > > > I disagree. It is bad to remove existi

Re: [PATCH 3/3] sysctl: Error on bad sysctl tables

2007-08-09 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Thu, 09 Aug 2007 14:09:29 -0600), [EMAIL PROTECTED] (Eric W. Biederman) says: > After going through the kernels sysctl tables several times it has > become clear that code review and testing is just not effective in > prevent problematic sysctl tables fr

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Thu, 09 Aug 2007 18:56:09 -0600), [EMAIL PROTECTED] (Eric W. Biederman) says: > > - In ipv6 ndisc_ifinfo_syctl_change so it doesn't depend on binary > sysctl names for a function that works with proc. > > - In neighbour.c reorder the table to put the

Re: [PATCH] IPv6: ipv6_addr_type() doesn't know about RFC4193 addresses

2007-07-26 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 25 Jul 2007 17:12:03 -0700 (PDT)), David Miller <[EMAIL PROTECTED]> says: > Contrarily, there may be ipv6_addr_type() call sites that really > do want to reject rfc4193 addresses. I do not think we have such users. --yoshfuji - To unsubscribe from this li

Re: [PATCH] IPv6: ipv6_addr_type() doesn't know about RFC4193 addresses

2007-07-26 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Wed, 25 Jul 2007 19:49:09 -0400), Dave Johnson <[EMAIL PROTECTED]> says: > ipv6_addr_type() doesn't check for 'Unique Local IPv6 Unicast > Addresses' (RFC4193) and returns IPV6_ADDR_RESERVED for that range. Acked-by: YO

Re: [2.6.23-rc1 REGRESSION] ThinkPad T42 poweroff failure by "PM: Introduce pm_power_off_prepare"

2007-07-26 Thread YOSHIFUJI Hideaki / 吉藤英明
IL PROTECTED]> > > Generally, sysdev_shutdown() should be called after the ACPI preparation for > powering the system off. To make it happen, we can separate sysdev_shutdown() > from device_shutdown() and call it directly wherever necessary. > > Signed-off-by: Rafael J. Wysock

Re: [2.6.23-rc1 REGRESSION] ThinkPad T42 poweroff failure by "PM: Introduce pm_power_off_prepare"

2007-07-26 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Thu, 26 Jul 2007 14:12:33 +0200), "Rafael J. Wysocki" <[EMAIL PROTECTED]> says: > On Wednesday, 25 July 2007 17:28, YOSHIFUJI Hideaki / 吉藤英明 wrote: > > Hello. > > > > In article <[EMAIL PROTECTED]> (at

Re: [2.6.23-rc1 REGRESSION] ThinkPad T42 poweroff failure by "PM: Introduce pm_power_off_prepare"

2007-07-25 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Wed, 25 Jul 2007 14:46:55 +0200), "Rafael J. Wysocki" <[EMAIL PROTECTED]> says: > On Wednesday, 25 July 2007 00:19, YOSHIFUJI Hideaki / 吉藤英明 wrote: : > > Linux 2.6.23-rc1 fails to power off my ThinkPad T42. > >

[2.6.23-rc1 REGRESSION] ThinkPad T42 poweroff failure by "PM: Introduce pm_power_off_prepare"

2007-07-24 Thread YOSHIFUJI Hideaki / 吉藤英明
3bbecaed84d493926939cf0e1c12 M drivers :04 04 9b28a21970668ce133916bbe8d8fd4a61bce23d7 80fc84d7982369205dcf94029e3958c90db14bf0 M include :04 04 9ce5c8b5d3f87c121b2f7bc6e02bc814648a2739 2e2e1468dfa0db9dee5bd204fd3f802a975a6454 M kernel -- YOSHIFUJI Hideaki @ USAGI Proje

Re: [PATCH][RFC] network splice receive v3

2007-07-19 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Wed, 11 Jul 2007 11:19:27 +0200), Jens Axboe <[EMAIL PROTECTED]> says: > @@ -835,6 +835,7 @@ const struct proto_ops inet_stream_ops = { > .recvmsg = sock_common_recvmsg, > .mmap = sock_no_mmap, > .sendpage

Re: [PATCH try#5] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-16 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Tue, 17 Jul 2007 00:49:02 +0800), Bryan Wu <[EMAIL PROTECTED]> says: > +static void bf537mac_set_multicast_list(struct net_device *dev) > +{ > + u32 sysctl; > + > + if (dev->flags & IFF_PROMISC) { > + printk(KERN_INFO "%s: set to prom

Re: [PATCH 24/61] sysfs: make sysfs_put() ignore NULL sd

2007-07-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 11 Jul 2007 16:55:29 -0700), Greg KH <[EMAIL PROTECTED]> says: > On Thu, Jul 12, 2007 at 08:50:47AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ > wrote: > > In article <[EMAIL PROTECTED]> (at Wed, 11 Jul 2007 16:31:43 -0700), G

Re: [PATCH 24/61] sysfs: make sysfs_put() ignore NULL sd

2007-07-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 11 Jul 2007 16:31:43 -0700), Greg Kroah-Hartman <[EMAIL PROTECTED]> says: > Make sysfs_put() ignore NULL sd instead of oopsing. I do not think this is a good idea; it is non-sense (and rather a bug) to call "put" with NULL argument in general. --yoshfuji

sysfs: release mutex when kmalloc() failed in sysfs_open_file().

2007-07-09 Thread YOSHIFUJI Hideaki / 吉藤英明
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> -- diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index b502c71..1f64ce5 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c @@ -283,6 +283,7 @@ static int sysfs_open_file(struct inode *inode, struct file *file) mutex_lock(

Re: TCP_MD5 and Intel e1000

2007-05-22 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 22 May 2007 10:57:38 +0200), Eric Dumazet <[EMAIL PROTECTED]> says: > > I have tried to set up quagga with tcp-md5 support from kernel. All seems ok > > with a intel e100 NIC, but as i testetd with a intel e1000 NIC the tcp > > packets have an invalid md5 d

Re: linux-2.6.21-gitN - versioning question

2007-05-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Sat, 12 May 2007 13:19:23 +0200 (MEST)), Jan Engelhardt <[EMAIL PROTECTED]> says: > I notice that people refer to certain git snapshots as e.g. -git16; > kernel.org does so too. Hovering over the link on kernel.org reveals > http://kernel.org/pub/linux/kernel/

Re: [PATCH] x86: Fix potential overflow in perfctr reservation

2007-04-22 Thread YOSHIFUJI Hideaki / 吉藤英明
s really valid? I guess it should be DEFINE_PER_CPU(type[num], var), no? [I386] NMI: Fix per_cpu() usage. Per-cpu array should be declared as DEFINE_PER_CPU(type[size], name), not as DEFINE_PER_CPU(type, name[size]). Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/arch/i38

Re: IPv6: Connection reset/timeout under heavy load

2007-03-28 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 28 Mar 2007 02:26:24 -0700 (PDT)), David Miller <[EMAIL PROTECTED]> says: > > http://www.linux-ipv6.org/gitweb/gitweb.cgi?p=gitroot/yoshfuji/linux-2.6-fix.git;a=commit;h=33a79bba0cc2f197b46cc54182f94c31ff6ad334 > > > > I hope this patch will go in 2.6.16-s

Re: IPv6: Connection reset/timeout under heavy load

2007-03-28 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 28 Mar 2007 10:48:27 +0200), Agoston Horvath <[EMAIL PROTECTED]> says: > YOSHIFUJI Hideaki / 吉藤英明 wrote: > > Would you test with latest kernel, if possible, please? > > For the archive: switching to 2.6.20.4 fixed this problem.

Re: IPv6: Connection reset/timeout under heavy load

2007-03-27 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. (CC: netdev added.) In article <[EMAIL PROTECTED]> (at Tue, 27 Mar 2007 11:45:46 +0200), Agoston Horvath <[EMAIL PROTECTED]> says: > I'm using kernel 2.6.16.29, libc is 2.3.2.ds1-22sarge5. However, same result > was achieved using kernel version 2.6.13 on the same box. > > I'm out of f

2.6.21-rc1-git compilation error in arch/i386/kernel/io_apic.c

2007-02-27 Thread YOSHIFUJI Hideaki / 吉藤英明
26dc introduced this issue. The affinity member is only available with CONFIG_SMP. Regards, -- YOSHIFUJI Hideaki @ USAGI Project <[EMAIL PROTECTED]> GPG-FP : 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH 2/7] cxgb3 - private ioctl cleanup

2007-02-22 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 22 Feb 2007 04:50:05 -0800), Divy Le Ray <[EMAIL PROTECTED]> says: > > Even if you remove them, PLEASE DO NOT CHANGE THE VALUES, > > unless you have very, very good reason. : > The cxgb3 driver has not yet appeared in a stable version of the linux > kernel

Re: [PATCH 2/7] cxgb3 - private ioctl cleanup

2007-02-22 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 22 Feb 2007 04:34:34 -0800), Divy Le Ray <[EMAIL PROTECTED]> says: > > 1. Please do do change the values. > > 2. Explain why you are going to kill these ioctls. > > > Jeff and Arjan have required that most of these ioctls go. > Please read: > http://mar

Re: [PATCH 2/7] cxgb3 - private ioctl cleanup

2007-02-22 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 22 Feb 2007 03:59:25 -0800), [EMAIL PROTECTED] says: > From: Divy Le Ray <[EMAIL PROTECTED]> > > Clean up some private ioctls. > > Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> > --- > > drivers/net/cxgb3/cxgb3_ioctl.h | 21 - > drive

request_module: runaway loop modprobe net-pf-1 (is Re: Linux 2.6.21-rc1)

2007-02-21 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Tue, 20 Feb 2007 20:53:45 -0800 (PST)), Linus Torvalds <[EMAIL PROTECTED]> says: > But there's a ton of architecture updates (arm, mips, powerpc, x86, you > name it), ACPI updates, and lots of driver work. And just a lot of > cleanups. I cannot boot 2

Re: Coding style RFC: convert "for (i=0;i

2007-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 12 Feb 2007 15:47:50 -0800), Joe Perches <[EMAIL PROTECTED]> says: > Now that most of the sizeof(array)/sizeof(array[0]) > conversions have been done (there are about 800 done > and about another 130 left), perhaps it could be > useful to change the code to

Re: 2.6.20-git8 fails compile -- net/built-in.o __ipv6_addr_type

2007-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
- > > git 7 compiled just fine. Ah, this is because of new ipv6 support in sunrpc code. Enable it if it is statically compiled. Alternatively, we could - export __ipv6_addr_type in new net/ipv6/addrconf_core.c or - introduce tiny inline for chcking if the address is link-local.

Re: 2.6.20-git8 fails compile -- net/built-in.o __ipv6_addr_type

2007-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 12 Feb 2007 18:12:16 -0800), Andrew Morton <[EMAIL PROTECTED]> says: > > On Mon, 12 Feb 2007 20:10:13 -0500 (EST) Pete Clements <[EMAIL PROTECTED]> > > wrote: > > 2.6.20-git8 fails compile: > > > > CHK include/linux/compile.h > > UPD include/l

[USBSERIAL] PL2303: Willcom WS002IN Support.

2007-01-26 Thread YOSHIFUJI Hideaki / 吉藤英明
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- drivers/usb/serial/pl2303.c |1 + drivers/usb/serial/pl2303.h |5 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 5dc2ac9..8d72a2e 100644

Re: [stable] 2.6.19.2 regression introduced by "IPV4/IPV6: Fix inet{, 6} device initialization order."

2007-01-15 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 16 Jan 2007 03:01:56 +0100), Gabriel C <[EMAIL PROTECTED]> says: > Greg KH schrieb: > > On Sun, Jan 14, 2007 at 09:30:08PM -0800, David Miller wrote: > > > >> From: David Stevens <[EMAIL PROTECTED]> > >> Date: Sun, 14 Jan 2007 19:47:49 -0800 > >> > >>

Re: [PATCH] Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2007-01-08 Thread YOSHIFUJI Hideaki / 吉藤英明
t; correct. > > Signed-off-by: Craig Schlenter <[EMAIL PROTECTED]> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- Begin Message --- SGkgRGF2ZQ0KDQpZT1NISUZVSkkgSGlkZWFraSAvIOWQieiXpOiLseaYjiBoYXMgc3VnZ2VzdGVk IHRoYXQgSSBzZW5kIHRoZSBwYXRjaA0

Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2007-01-08 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 4 Jan 2007 14:23:30 +0200), Craig Schlenter <[EMAIL PROTECTED]> says: > On Fri, Jan 05, 2007 at 05:45:46AM +0900, Komuro wrote: > > Hi, > > > > I made a patch below. > > With this patch, the ftp-transfer-stop problem does not happen. > > Therefore, I think

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

2006-12-31 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 1 Jan 2007 01:43:00 +0100), Ingo Oeser <[EMAIL PROTECTED]> says: > On Sunday, 31. December 2006 14:38, Bernd Petrovitsch wrote: > > That depends on the decision/definition if (so called) "double free" is > > an error or not (and "free(NULL)" must work in PO

Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2006-12-30 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Sat, 30 Dec 2006 20:59:31 +0900), Komuro <[EMAIL PROTECTED]> says: > > Do you see similar issue with other simple application? > > sorry, I don't reproduce this problem on other application. Can you reproduce it with other ftp client and/or server? Anyway...

Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2006-12-29 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Sat, 30 Dec 2006 18:50:43 +0900), Komuro <[EMAIL PROTECTED]> says: > I investigated the ftp-file-transfer-stop problem by git-bisect method, > and found this problem was introduced by > "[TCP]: MD5 Signature Option (RFC2385) support" patch. > > Mr.YOSHIFUJI san

Re: [RFC][PATCH] NTP shiftR cleanup

2005-09-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 09 Sep 2005 18:03:37 -0700), john stultz <[EMAIL PROTECTED]> says: > diff --git a/kernel/time.c b/kernel/time.c > --- a/kernel/time.c > +++ b/kernel/time.c > @@ -338,30 +338,20 @@ int do_adjtimex(struct timex *txc) > if (mtemp >= MINSE

Re: 2.6.13-git3: build failure: sysctl_optmem_max

2005-09-03 Thread YOSHIFUJI Hideaki / 吉藤英明
> It seems that sysctl_optmem_max is only available if CONFIG_SYSCTL is set. > However, ip_setsockopt makes unconditional usage of this variable. This should fix the issue. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/include/net/sock.h b/include/net/sock.h --- a/inclu

Re: [PATCH] 1 Wire drivers illegally overload NETLINK_NFLOG

2005-07-22 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Sat, 23 Jul 2005 08:54:27 -0400), Harald Welte <[EMAIL PROTECTED]> says: > --- a/include/linux/netlink.h > +++ b/include/linux/netlink.h > @@ -20,7 +20,7 @@ > #define NETLINK_IP6_FW 13 > #define NETLINK_DNRTMSG 14 /* DECnet rout

Re: [PATCH 2.6.13-rc1 01/10] IOCHK interface for I/O error handling/detecting

2005-07-06 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 06 Jul 2005 13:53:06 +0900), Hidetoshi Seto <[EMAIL PROTECTED]> says: > Index: linux-2.6.13-rc1/lib/iomap.c > === > --- linux-2.6.13-rc1.orig/lib/iomap.c > +++ linux-2.6.13-rc1/lib/iomap.c > @@

Re: [PATCH] [17/48] Suspend2 2.1.9.8 for 2.6.12: 500-version-specific-i386.patch

2005-07-05 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 6 Jul 2005 12:20:41 +1000), Nigel Cunningham <[EMAIL PROTECTED]> says: > #define local_flush_tlb() __flush_tlb() > +#define local_flush_tlb_all() __flush_tlb_all(); You should remove ";". > extern void flush_tlb_page(struct vm_area_struct *, unsigned lo

[PATCH] USB: compilation failure on usb/image/microtek.c

2005-04-19 Thread YOSHIFUJI Hideaki / 吉藤英明
From: Hideaki YOSHIFUJI <[EMAIL PROTECTED]> maybe typo? Signed-off-by: Hideaki YOSHIFUJI <[EMAIL PROTECTED]> --- a/drivers/usb/image/microtek.c +++ b/drivers/usb/image/microtek.c @@ -335,7 +335,7 @@ static int mts_scsi_abort (Scsi_Cmnd *sr mts_urb_abort(desc); - return FAILURE;

Re: [PATCH] introduce generic 64bit rotations and i386 asm optimized version

2005-04-18 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 19 Apr 2005 09:18:10 +0300), Denis Vlasenko <[EMAIL PROTECTED]> says: > diff -urpN 2.6.12-rc2.1.be/include/linux/bitops.h > 2.6.12-rc2.2.ror/include/linux/bitops.h > --- 2.6.12-rc2.1.be/include/linux/bitops.hMon Apr 18 22:55:10 2005 > +++ 2.6.12-rc2.2.

Re: Off-by-one bug at unix_mkname ?

2005-03-28 Thread YOSHIFUJI Hideaki / $B5HF#1QL@(B
In article <[EMAIL PROTECTED]> (at Mon, 28 Mar 2005 11:25:39 +0200 (MEST)), Jan (BEngelhardt <[EMAIL PROTECTED]> says: (B (B> (B> On Mar 28 2005 17:39, YOSHIFUJI Hideaki / [EMAIL PROTECTED](B wrote: (B> (B> >+ * This may look like an off

Re: Off-by-one bug at unix_mkname ?

2005-03-28 Thread YOSHIFUJI Hideaki / $B5HF#1QL@(B
In article <[EMAIL PROTECTED]> (at Mon, 28 Mar 2005 17:39:38 +0900 (JST)), (BYOSHIFUJI Hideaki / [EMAIL PROTECTED](B <[EMAIL PROTECTED]> says: (B (B> So, I'd suggest to put the comment back to 2.4/2.6 instead. (B> (Note: net/socket.c refers this around MAX_SOCK_ADDR definition.) (B> (B> Sig

Re: Off-by-one bug at unix_mkname ?

2005-03-28 Thread YOSHIFUJI Hideaki / $B5HF#1QL@(B
In article <[EMAIL PROTECTED]> (at Mon, 28 Mar 2005 17:21:08 +0900 (JST)), (BYOSHIFUJI Hideaki / [EMAIL PROTECTED](B <[EMAIL PROTECTED]> says: (B (B> > It seems to me that the following code is off-by-one bug. (B: (B> Well, 2.2 has some comment on this: (B (BSo, I'd suggest to put the comme

  1   2   >