Re: [PATCH v2] rust: add `module_params` macro

2024-08-28 Thread Andreas Hindborg
Hi Trevor, Thanks a lot for the thorough review! "Trevor Gross" writes: > On Mon, Aug 19, 2024 at 8:35 AM Andreas Hindborg wrote: >> >> From: Andreas Hindborg >> >> This patch includes changes required for Rust kernel modules to utilize >> module

Re: [PATCH v2] rust: add `module_params` macro

2024-08-27 Thread Andreas Hindborg
"Trevor Gross" writes: > On Tue, Aug 27, 2024 at 10:00 AM Andreas Hindborg wrote: >> >> "Trevor Gross" writes: >> >> > On Mon, Aug 19, 2024 at 8:35 AM Andreas Hindborg wrote: >> >> >> >> From: Andreas Hindborg &

Re: [PATCH v2] rust: add `module_params` macro

2024-08-27 Thread Andreas Hindborg
"Trevor Gross" writes: > On Mon, Aug 19, 2024 at 8:35 AM Andreas Hindborg wrote: >> >> From: Andreas Hindborg >> >> This patch includes changes required for Rust kernel modules to utilize >> module parameters. This code implements read only support f

[PATCH v2] rust: add `module_params` macro

2024-08-19 Thread Andreas Hindborg
From: Andreas Hindborg This patch includes changes required for Rust kernel modules to utilize module parameters. This code implements read only support for integer types without `sysfs` support. This code is a reduced and updated version of code by Adam available in the original `rust` branch

Re: [PATCH] rust: add `module_params` macro

2024-08-15 Thread Andreas Hindborg
"Benno Lossin" writes: > On 05.08.24 12:55, Andreas Hindborg wrote: >> "Benno Lossin" writes: >>> On 02.08.24 12:27, Andreas Hindborg wrote: >>>> At a higher level where the bindings supply the parsing functions, we >>>> can de

Re: [PATCH] rust: add `module_params` macro

2024-08-05 Thread Andreas Hindborg
"Benno Lossin" writes: > On 02.08.24 12:27, Andreas Hindborg wrote: >> "Benno Lossin" writes: >>> On 01.08.24 17:11, Andreas Hindborg wrote: >>>> "Benno Lossin" writes: >>>>> On 01.08.24 15:40, Andreas Hindborg wrote:

Re: [PATCH] rust: add `module_params` macro

2024-08-02 Thread Andreas Hindborg
"Benno Lossin" writes: > On 01.08.24 17:11, Andreas Hindborg wrote: >> "Benno Lossin" writes: >>> On 01.08.24 15:40, Andreas Hindborg wrote: >>>> "Benno Lossin" writes: >>>>> On 01.08.24 13:29, Andreas Hindborg wrote:

Re: [PATCH] rust: add `module_params` macro

2024-08-01 Thread Andreas Hindborg
"Benno Lossin" writes: > On 01.08.24 15:40, Andreas Hindborg wrote: >> "Benno Lossin" writes: >>> On 01.08.24 13:29, Andreas Hindborg wrote: >>>> "Benno Lossin" writes: >>>>> On 05.07.24 13:15, Andreas Hindbo

Re: [PATCH] rust: add `module_params` macro

2024-08-01 Thread Andreas Hindborg
"Benno Lossin" writes: > On 01.08.24 13:29, Andreas Hindborg wrote: >> >> Hi Benno, >> >> Thanks for the comments! >> >> "Benno Lossin" writes: >> >>> On 05.07.24 13:15, Andreas Hindborg wrote: >

Re: [PATCH] rust: add `module_params` macro

2024-08-01 Thread Andreas Hindborg
Hi Benno, Thanks for the comments! "Benno Lossin" writes: > On 05.07.24 13:15, Andreas Hindborg wrote: [...] >> + >> +/// Types that can be used for module parameters. >> +/// >> +/// Note that displaying the type in `sysfs` will fail if >> +/

Re: [PATCH] rust: add `module_params` macro

2024-07-05 Thread Andreas Hindborg
Hi Adam, "Andreas Hindborg" writes: > From: Andreas Hindborg > > This patch includes changes required for Rust kernel modules to utilize > module parameters. This code implements read only support for integer > types without `sysfs` support. > > This code is a

[PATCH] rust: add `module_params` macro

2024-07-05 Thread Andreas Hindborg
From: Andreas Hindborg This patch includes changes required for Rust kernel modules to utilize module parameters. This code implements read only support for integer types without `sysfs` support. This code is a reduced and updated version of code by Adam available in the original `rust` branch

Re: [PATCH 006/141] gfs2: Fix fall-through warnings for Clang

2021-04-20 Thread Andreas Grünbacher
Am Di., 20. Apr. 2021 um 22:29 Uhr schrieb Gustavo A. R. Silva : > Friendly ping: who can take this, please? Oops, that got lost. I've added it to for-next now. Thanks, Andreas

Re: [PATCH v14 6/6] locking/qspinlock: Introduce the shuffle reduction optimization into CNA

2021-04-14 Thread Andreas Herrmann
ondary queue is empty, skip the call to > + * cna_order_queue() below with high probability. This > optimization > + * reduces the overhead of unnecessary shuffling of threads > + * between waiting queues when the lock is only lightly > contended. > + */ > + return 0; > + } > + > if (!cn->start_time || !intra_node_threshold_reached(cn)) { > /* >* We are at the head of the wait queue, no need to use > -- > 2.24.3 (Apple Git-128) > -- Regards, Andreas

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-04-12 Thread Andreas Schwab
NFIG_PM, and the patch > 732374a0b440d9a79c8412f318a25cd37ba6f4e2 added the enable/disable > callback functions, so the gemgxlpll PLL, I have no idea why power > management disable it, I would keep trace it. Does that mean that CONFIG_PM also affects the FU740? Andreas. -- Andreas Schwab, sch...@linux-m68k

Re: [PATCH 00/18] Rid W=1 warnings from GFS2

2021-04-09 Thread Andreas Gruenbacher
ctive, and I found a few more minor issues along the way. Those changes are now all in the following commit: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?id=c551f66c5dfef Thanks, Andreas

Re: [PATCH -next] gfs2: use kmem_cache_free() instead of kfree()

2021-04-09 Thread Andreas Grünbacher
Bob is currently investigating. Andreas

Re: [PATCH] ext4: add a configurable parameter to prevent endless loop in ext4_mb_discard_group_p

2021-04-08 Thread Andreas Dilger
On Apr 8, 2021, at 12:50 PM, Wen Yang wrote: > > Hi Ritesh and Andreas, > > Thank you for your reply. Since there is still a faulty machine, we have > analyzed it again and found it is indeed a very special case: > > > crash> struct ext4_group_info 8813bb5f72

Re: [PATCH] ext4: add a configurable parameter to prevent endless loop in ext4_mb_discard_group_preallocations

2021-04-07 Thread Andreas Dilger
uire a sysfs tunable to be set to have a properly working system? Is there anything particularly strange about the workload/system that might cause this? Filesystem is very full, memory is very low, etc? Cheers, Andreas signature.asc Description: Message signed with OpenPGP

[PATCH] mfd: rn5t618: fix IRQ trigger by changing it to level mode

2021-04-05 Thread Andreas Kemnade
: Add IRQ support") Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c index ecddd7b6500e..a852eef1f4d2 100644 --- a/drivers/mfd/rn5t618.c +++ b/drivers/mfd/rn5t618.c @@ -10

[GIT PULL] gfs2 fixes for v5.12-rc6

2021-04-03 Thread Andreas Gruenbacher
Hi Linus, please consider pulling the following two gfs2 fixes for v5.12-rc6. Thanks, Andreas The following changes since commit b77b5fdd052e7ee61b35164abb10e8433d3160e8: Merge tag 'gfs2-v5.12-rc2-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 (2021-03-12

Re: fs/gfs2/rgrp.c:1772:53: warning: Possible null pointer dereference: minext [nullPointer]

2021-04-02 Thread Andreas Gruenbacher
ility. Reported-by: kernel test robot Signed-off-by: Andreas Gruenbacher --- fs/gfs2/rgrp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 89c37a845e64..2dab313442a7 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -1783,7 +1783,7 @@ stati

Re: [PATCH v2] ext4: Fix ext4_error_err save negative errno into superblock

2021-04-01 Thread Andreas Dilger
) in the first usage but is actually changing write_mmp_block(). With that change you could add a Reviewed-by label from me. Cheers, Andreas > Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and > drop ext4_set_errno()") > Reported-by: Liu Zhi Qiang > Si

Re: [PATCH] ext4: Fix ext4_error_err save negative errno into superblock

2021-04-01 Thread Andreas Dilger
tval from write_mmp_block(). That currently returns 1, but only until your next patch is applied. I think it is better to fix write_mmp_block() as in your next patch to return a negative value to be more consistent with other code. Cheers, Andreas > Fixes: 54d3adbc29f0 ("ext4: save all error info i

Re: [PATCH v2 0/6] Add support for Actions Semi Owl socinfo

2021-04-01 Thread Andreas Färber
s is just a convention of some downstream U-Boot that's not implemented in mainline (and maybe not even for Guitar or Labrador? tested on RoseapplePi only), it might not be worth its own reserved-memory based kernel driver? Implementing a standard interface such as DMI tables or a DT property in mainline U-Boot may be more useful then. Is it still Mani's S900 only? Regards, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-03-29 Thread Andreas Schwab
8412f318a25cd37ba6f4e2. But the > network is fine by using the mainline's defconfig, this is a little > bit weird, I will check that and try to find the difference. My guess would be that it is an init dependency problem between the phy driver and the clock driver, which causes the clock

Re: [PATCH v2] lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS

2021-03-28 Thread Andreas Schwab
That doesn't look correct. It reverses the condition without reversing the result, which means the result is probably the opposite than intended. The same expression occurs two more times in this file. Do those need to be changed as well? Andreas. -- Andreas Schwab, sch...@linux-m68k.

Re: [PATCH 2/4] exec: remove compat_do_execve

2021-03-26 Thread Andreas Schwab
On Mär 26 2021, Christoph Hellwig wrote: > Just call compat_do_execve instead. ITYM compat_do_execveat here. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v3 11/17] riscv: Convert to GENERIC_CMDLINE

2021-03-26 Thread Andreas Schwab
OMMAND_LINE_SIZE); > + cmdline_build(boot_command_line, NULL, COMMAND_LINE_SIZE); > pr_info("Forcing kernel command line to: %s\n", boot_command_line); Shouldn't that message become conditional in some way? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fi

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-03-26 Thread Andreas Schwab
hat's exactly the issue. The process is stuck in D. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-03-25 Thread Andreas Schwab
iscv64.raw.xz Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-03-24 Thread Andreas Schwab
Were you able to reproduce the problem? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v2 1/2] ext4: Handle casefolding with encryption

2021-03-20 Thread Andreas Dilger
y, the change is backwards compatible > with existing ext4 filesystems. > > Signed-off-by: Daniel Rosenberg Reviewed-by: Andreas Dilger Cheers, Andreas signature.asc Description: Message signed with OpenPGP

Re: [PATCH 1/3] posic_acl: Add a helper determine if SGID should be cleared

2021-03-19 Thread Andreas Grünbacher
file server will take care of clearing SGID if it needs to be done. > > Hence move this code in a separate helper so that more than one place > can call into it. > > Cc: Jan Kara > Cc: Andreas Gruenbacher > Cc: Alexander Viro > Signed-off-by: Vivek Goyal > --- >

Re: macb broken on HiFive Unleashed

2021-03-19 Thread Andreas Schwab
On Mär 19 2021, Yixun Lan wrote: > what's the exact root cause? and any solution? Try reverting the five commits starting with 732374a0b440d9a79c8412f318a25cd37ba6f4e2. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-03-19 Thread Andreas Schwab
On Mär 19 2021, Zong Li wrote: > Could you please point me out how to test the ethernet from your side? Please use <https://github.com/openSUSE/kernel-source/blob/stable/config/riscv64/default>. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5

Re: macb broken on HiFive Unleashed

2021-03-17 Thread Andreas Schwab
It turned out to be a broken clock driver. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v7 0/5] clk: add driver for the SiFive FU740

2021-03-16 Thread Andreas Schwab
On Dez 09 2020, Zong Li wrote: > Add a driver for the SiFive FU740 PRCI IP block, which handles more > clocks than FU540. These patches also refactor the original > implementation by spliting the dependent-code of fu540 and fu740 > respectively. That breaks ethernet on the fu5

[PATCH v4] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-15 Thread Andreas Kemnade
successfully configured despite of that error. Signed-off-by: Andreas Kemnade Reviewed-by: Jonathan Neuschäfer --- Changes in v4: - rename subdevices back to v2 (suggested by Jonathan) - initialize subdevs in switch Changes in v3: - remove have_rtc variable - rename subdevices again Changes in v2

Re: [PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-15 Thread Andreas Kemnade
t afraid that your compiler cannot figure it out that things get initialized and getting comments like "This code has never seen a compiler." But I will throw it against several ones. Regards, Andreas

[PATCH] mfd: rn5t618: Do not cache various USB related registers

2021-03-14 Thread Andreas Kemnade
These register get reset to their OTP defaults after USB plugging. And while at it, also add a missing register for detecting the charger type. Signed-off-by: Andreas Kemnade --- drivers/mfd/rn5t618.c | 3 +++ include/linux/mfd/rn5t618.h | 1 + 2 files changed, 4 insertions(+) diff --git

Re: macb broken on HiFive Unleashed

2021-03-13 Thread Andreas Schwab
On Mär 13 2021, Emil Renner Berthing wrote: > As you can see I haven't updated OpenSBI or u-boot in a while Does it also work if you use the u-boot SPL instead of FSBL? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A

Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-13 Thread Andreas Kemnade
On Sat, 13 Mar 2021 12:17:34 +0100 Jonathan Neuschäfer wrote: > On Wed, Mar 10, 2021 at 09:55:45AM +, Lee Jones wrote: > > On Mon, 08 Mar 2021, Andreas Kemnade wrote: > [...] > > > -static const struct mfd_cell ntxec_subdevices[] = { > > > +static cons

[PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-13 Thread Andreas Kemnade
successfully configured despite of that error. Signed-off-by: Andreas Kemnade Reviewed-by: Jonathan Neuschäfer --- Changes in v3: - remove have_rtc variable - rename subdevices again Changes in v2: - more comments about stacking regmap construction - fix accidential line removal - better naming for

[GIT PULL] gfs2 fixes for 5.12-rc3

2021-03-12 Thread Andreas Gruenbacher
Hi Linus, please consider pulling the following gfs2 fixes. Thanks, Andreas The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gfs2

Re: [PATCH 1/1] ARM: owl: Add Actions Semi Owl S500 SoC machine

2021-03-12 Thread Andreas Färber
erate a stable MAC address. Can't that be done in either a sys_soc driver or U-Boot? Regards, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)

Re: macb broken on HiFive Unleashed

2021-03-10 Thread Andreas Schwab
assing zero to 'PTR_ERR' > 0012eeb370f8 net: macb: fix NULL dereference due to no pcs_config method > e4e143e26ce8 net: macb: add support for high speed interface Unfortunately, that didn't help. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47

[PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-08 Thread Andreas Kemnade
successfully configured despite of that error. Signed-off-by: Andreas Kemnade --- Changes in v2: - more comments about stacking regmap construction - fix accidential line removal - better naming for subdevices drivers/mfd/ntxec.c | 61 +-- include/linux/mfd

macb broken on HiFive Unleashed

2021-03-08 Thread Andreas Schwab
12.753119] macb 1009.ethernet: GEM doesn't support hardware ptp. [ 12.760178] libphy: MACB_mii_bus: probed [ 12.881792] MACsec IEEE 802.1AE [ 12.944426] macb 1009.ethernet eth0: Cadence GEM rev 0x10070109 at 0x1009 irq 16 (70:b3:d5:92:f1:07) Andreas. -- Andreas Schwa

Re: [PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Andreas Kemnade
eneric regmap code > > would be justified. > > Ok, please add a short comment here or extend the one above the repmap > config struct, to save interested readers a bit of trouble. I guess "add > a wrapper" goes in right direction, but it didn't make the stacking > obvious to me when I first read it. > I will wait for some days to see whether anybody chokes on that stack. Regards, Andreas

Re: [PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Andreas Kemnade
On Sat, 6 Mar 2021 20:14:46 +0100 Jonathan Neuschäfer wrote: > Hi, > > (Cc'ing Mark Brown because of the regmap related questions) > > On Sat, Mar 06, 2021 at 07:13:14PM +0100, Andreas Kemnade wrote: > > Add the version of the EC in the Tolino Shine 2 HD > > to

[PATCH -next] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-06 Thread Andreas Kemnade
successfully configured despite of that error. Signed-off-by: Andreas Kemnade --- drivers/mfd/ntxec.c | 57 --- include/linux/mfd/ntxec.h | 1 + 2 files changed, 55 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/ntxec.c b/drivers/mfd/ntxec.c index

Re: [PATCH AUTOSEL 4.4 4/8] sparc32: Limit memblock allocation to low memory

2021-03-03 Thread Andreas Larsson
On 2021-03-02 12:59, Sasha Levin wrote: From: Andreas Larsson [ Upstream commit bda166930c37604ffa93f2425426af6921ec575a ] Commit cca079ef8ac29a7c02192d2bad2ffe4c0c5ffdd0 changed sparc32 to use memblocks instead of bootmem, but also made high memory available via memblock allocation which

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-03 Thread Andreas Schwab
~ >> mm/kfence/report.c:233:3: note: in expansion of macro 'pr_err' >>233 | pr_err("Invalid free of 0x%p (in kfence-#%zd):\n", (void >> *)address, >>| ^~ >> >> Christophe > > No this is not expected. Is 'signed size_t' != 'long

Re: [PATCH AUTOSEL 4.9 05/10] sparc32: Limit memblock allocation to low memory

2021-03-03 Thread Andreas Larsson
On 2021-03-02 12:59, Sasha Levin wrote: From: Andreas Larsson [ Upstream commit bda166930c37604ffa93f2425426af6921ec575a ] Commit cca079ef8ac29a7c02192d2bad2ffe4c0c5ffdd0 changed sparc32 to use memblocks instead of bootmem, but also made high memory available via memblock allocation which

Re: [PATCH AUTOSEL 4.14 06/13] sparc32: Limit memblock allocation to low memory

2021-03-03 Thread Andreas Larsson
On 2021-03-02 12:58, Sasha Levin wrote: From: Andreas Larsson [ Upstream commit bda166930c37604ffa93f2425426af6921ec575a ] Commit cca079ef8ac29a7c02192d2bad2ffe4c0c5ffdd0 changed sparc32 to use memblocks instead of bootmem, but also made high memory available via memblock allocation which

Re: [PATCH 1/2] ext4: Handle casefolding with encryption

2021-02-25 Thread Andreas Dilger
On Feb 18, 2021, at 4:21 PM, Daniel Rosenberg wrote: > > On Wed, Feb 17, 2021 at 2:48 PM Andreas Dilger wrote: >> >> On Feb 17, 2021, at 9:08 AM, Theodore Ts'o wrote: >>> >>> The problem is in how the space after the filename in a directory is &g

Re: [RFC] Better page cache error handling

2021-02-24 Thread Andreas Dilger
t you _could_ store a magic, an error value, and a timeout, that are only valid if !uptodate (cleared if the page were totally overwritten by userspace). Yes, it's nasty, but better than growing struct page, and better than blocking userspace threads for tens of minutes when a block is bad. Cheers, Andreas signature.asc Description: Message signed with OpenPGP

[GIT PULL] GFS2 changes for 5.12

2021-02-23 Thread Andreas Gruenbacher
Hi Linus, please consider pulling the following gfs2 changes for 5.12. My apologies for the late request; we ended up getting stuck with two broken patches that have now both been removed. Thanks a lot, Andreas The following changes since commit 19c329f6808995b142b3966301f217c831e7cf31

Re: [PATCH 1/3] power: supply: bq27xxx: fix sign of current_now for newer ICs

2021-02-23 Thread Andreas Kemnade
> The GTA04/Openmoko device that was used for testing uses a BQ27000 or > BQ27010 IC, so I assume only the BQ27XXX_O_ZERO code path was incorrect. > Revert the behaviour for newer ICs. > > Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now" > Signed

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-17 Thread Andreas Dilger
r if the source file (procfs/sysfs/etc) does not work with CFR properly. Applications must already handle -EOPNOTSUPP with a fallback, but expecting all applications that may call copy_file_range() to be properly coded to handle corner cases is just asking for trouble. That is doubly true giv

Re: [PATCH 1/2] ext4: Handle casefolding with encryption

2021-02-17 Thread Andreas Dilger
a simple blob that is only used for one > thing in this particular case, and something which is the moral > equivalent of simple ASN.1 or protobuf encoding. > > Currently, datadata has defined uses for 2 of the 4 "chunks", which is > used in Lustre servers. The proposal which

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-16 Thread Andreas Dilger
nction, which is AFAICS not possible if COPY_FILE_SPLICE is only available to in-kernel callers. Instead, it should continue to return -EOPNOTSUPP to userspace if copy_file_range() is not valid for this combination of file descriptors, so that applications will fall back to the non-CFR implementation. The WARN_ON_ONCE(ret == -EOPNOTSUPP) in vfs_copy_file_range() would also need to be removed if this will be triggered from userspace. Cheers, Andreas signature.asc Description: Message signed with OpenPGP

[PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware

2021-02-16 Thread Andreas Eberlein
The DMI_PRODUCT_NAME entry on current firmware of PC Engines APU1 changed from "APU" to "apu1" This modification adds the missing DMI data and thereby the LED support for the PC Engines APU1 with firmware versions >= 4.6.8. Signed-off-by: Andreas Eberlein --- Changes

[PATCH] leds: apu: extend support for PC Engines APU1 with newer firmware

2021-02-16 Thread Andreas Eberlein
The DMI_PRODUCT_NAME entry on current firmware of PC Engines APU1 changed from "APU" to "apu1" This modification adds the missing DMI data and thereby the LED support for the PC Engines APU1 with firmware versions >= 4.6.8. Signed-off-by: Andreas Eberlein --- drive

Re: [PATCH] Revert "dts: phy: add GPIO number and active state used for phy reset"

2021-02-10 Thread Andreas Schwab
. > > This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65. > > Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy > reset") > Cc: sta...@vger.kernel.org > Signed-off-by: Palmer Dabbelt This fixes ethernet on the HiFive Unleashed with 5.10.12.

Re: [PATCH 1/2] ext4: Handle casefolding with encryption

2021-02-09 Thread Andreas Dilger
On Feb 9, 2021, at 4:22 PM, Theodore Ts'o wrote: > > On Wed, Feb 03, 2021 at 11:31:28AM -0500, Theodore Ts'o wrote: >> On Wed, Feb 03, 2021 at 03:55:06AM -0700, Andreas Dilger wrote: >>> >>> It looks like this change will break the dirdata feature, whi

Re: [PATCH v9 0/7] Netronix embedded controller driver for Kobo and Tolino ebook readers

2021-02-08 Thread Andreas Kemnade
euschaefer/linux/wiki/Netronix-MSP430-embedded-controller > > v9: > - Fixed a bug in the error handling of ntxec_probe, > Reported-by: kernel test robot > - Added Thierry Reding's ACK to the PWM patch > what is the fate of this one, looks like it got all acks from maintainers. Regards, Andreas

Re: [Letux-kernel] BOG: commit 89c7cb1608ac3 ("of/device: Update dma_range_map only when dev has valid dma-ranges") seems to break Pinephone display or LCDC

2021-02-06 Thread Andreas Kemnade
; > > And nice to see you're active on Pinephone as well! > > > > I have a developer unit and the LetuxOS kernel already supports it a > > little. This is why I observed the issue with -rc6 > > > > > You might remember me from > > > the Replicant project, as I've worked a bit on the GTA04 :) > > > > Sure, you are well remembered :) > > > > I still have the dream to revitalize Replicant 4.2 for the GTA04 just for > > fun. I can already boot to Replicant touch screen with a v5.4 kernel. v5.10 > > fails when trying to spawn zygote... > > Oh I see! I think Android has made some significant progress is its ability > to use mainline (4.2 was an early stage and I remember having to backport > patches to use some mainline features back then). > > Maybe it would be easier with Replicant 6, but you'd have to go through the > device bringup phase again, which is never nice. > well, we have done some experimental Replicant 6 images, but it is unbeleavable slow. Do not know why. The bootanimation process(even though there is no "animation") draws a lot of cpu power. Regards, Andreas

[PATCH v2] sparc32: Limit memblock allocation to low memory

2021-02-05 Thread Andreas Larsson
in the early stages, now using memblock allocation. Signed-off-by: Andreas Larsson Acked-by: Mike Rapoport --- Changes, in commit message, since v1: - Added a missing "not" in "does not work" - Clarified crash to kernel panic. - Added Acked-by arch/sparc/mm/init_32.c | 3 ++

Re: [PATCH] arch: m68k: include: asm: Reconstruct the sentence in file sun3ints.h

2021-02-05 Thread Andreas Schwab
On Feb 05 2021, Bhaskar Chowdhury wrote: > -/* master list of VME vectors -- don't fuck with this */ > +/* master list of VME vectors -- don't do anything with this */ don't mess with this Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47

[PATCH] nios2: Don't use _end for calculating min_low_pfn

2021-02-05 Thread Andreas Oetken
From: Andreas Oetken If there is a initramfs linked into the kernel which will be freed later on there is free memory somewhere between _etext and _end, thus using _end for min_low_pfn is not correct. This may lead to issues in dma_capable when checking 'min(addr, end) < phys_to

[PATCH] nios2: fixed broken sys_clone syscall

2021-02-05 Thread Andreas Oetken
From: Andreas Oetken The tls pointer must be pushed on the stack prior to calling nios2_clone as it is the 5th function argument. Prior handling of the tls pointer was done inside former called function copy_thread_tls using the r8 register from the current_pt_regs directly. This was a bad

[PATCH] sparc32: Preserve clone syscall flags argument for restarts due to signals

2021-02-04 Thread Andreas Larsson
the setting %l6 to 0 or 1 was removed. The use of that 0 or 1 value in %l6 was removed in commit 28e6103665301ce60634e8a77f0b657c6cc099de. Signed-off-by: Andreas Larsson --- arch/sparc/kernel/entry.S| 8 +++- arch/sparc/kernel/rtrap_32.S | 2 +- 2 files changed, 4 insertions(+), 6

[PATCH] sparc32: Limit memblock allocation to low memory

2021-02-04 Thread Andreas Larsson
early stages, now using memblock allocation. Signed-off-by: Andreas Larsson --- arch/sparc/mm/init_32.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/sparc/mm/init_32.c b/arch/sparc/mm/init_32.c index eb2946b1df8a..6139c5700ccc 100644 --- a/arch/sparc/mm/init_32.c +++ b/arch/sparc/mm

Re: [PATCH v2 0/3] fix macb phy probe failure if phy-reset is not handled

2021-02-04 Thread Andreas Schwab
b 1009.ethernet: Registered clk switch 'sifive-gemgxl-mgmt' [ 12.784559] macb 10090000.ethernet: GEM doesn't support hardware ptp. [ 12.791629] libphy: MACB_mii_bus: probed [ 12.919728] MACsec IEEE 802.1AE [ 12.984676] macb 1009.ethernet eth0: Cadence GEM rev 0x10070109 at 0x1009 irq 16 (70:b3:d5:92:f1:07) [ 14.030319] Microsemi VSC8541 SyncE 1009.ethernet-:00: phy_poll_reset failed: -110 [ 14.038986] macb 1009.ethernet eth0: Could not attach PHY (-110) Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v2] ext4: Enable code path when DX_DEBUG is set

2021-02-01 Thread Andreas Dilger
} That will hopefully avoid the "dead code" warning, while keeping the code visible for syntax checking by the compiler (unlike if it was under #ifdef). Alternately, if we want to keep the "#ifdef DX_DEBUG" check intact: #ifdef DX_DEBUG #define dxtrace(command) comm

[PATCH RESEND v2] dt-bindings: mfd: Convert rn5t618 to json-schema

2021-01-31 Thread Andreas Kemnade
Convert the RN5T618 binding to DT schema format. Also clearly state which regulators are available. Signed-off-by: Andreas Kemnade Reviewed-by: Rob Herring --- https://lore.kernel.org/lkml/cal_jsqjwt91+azwaweuvjobqgsyw6gbhqmohwu_t5qzabxx...@mail.gmail.com/ Changes in v2: - drop irq description

Re: [PATCH] ext4: Remove unreachable code

2021-01-30 Thread Andreas Dilger
if (dx_get_hash(++at) > hash) > - { > - at--; > - break; > - } > - } > - ASSERT(at == p - 1); > - } > - > at = p - 1; > d

Re: sparc32: boot fails with > 256 MB memory after switch to NO_BOOTMEM

2021-01-28 Thread Andreas Larsson
On 2021-01-28 10:35, Mike Rapoport wrote: On Wed, Jan 27, 2021 at 04:03:00PM +0100, Andreas Larsson wrote: Commit cca079ef8ac29a7c02192d2bad2ffe4c0c5ffdd0 makes sparc32 use memblocks instead of the previous bootmem solution. Unfortunately, due to this: #define PAGE_OFFSET 0xf000 #define

sparc32: boot fails with > 256 MB memory after switch to NO_BOOTMEM

2021-01-27 Thread Andreas Larsson
ress ranges that is done in bootmem_init also looks a bit worrying, but removing the second one does not affect this problem. -- Best regards, Andreas Larsson Cobham Gaisler

Re: [PATCH] dts: ARM: add kobo glo hd ebook reader

2021-01-26 Thread Andreas Kemnade
ion. The touchscreen (driver zforce_ts) should alse be supported. So you might go further forward. If you are really brave, you could add a complete devicetree on top of my branch kobo/drm-merged-5.10 of github.com/akemnade/linux. Besides of backlight, it should give full hardware support (including a drm driver for the display), so we can see what is different and whether we can use a .dtsi file to define common things. Picture of the Tolino2 internals: https://misc.andi.de1.cc/tolino2.jpg Regards, Andreas

Re: [PATCH] dts: ARM: add kobo glo hd ebook reader

2021-01-26 Thread Andreas Kemnade
go further forward. If you are really brave, you could add a complete devicetree on top of my branch kobo/drm-merged-5.10 of github.com/akemnade/linux. Besides of backlight, it should give full hardware support (including a drm driver for the display), so we can see what is different and whether we can use a .dtsi file to define common things. Picture of the Tolino2 internals: https://misc.andi.de1.cc/tolino2.jpg Regards, Andreas

Re: Getting a new fs in the kernel

2021-01-26 Thread Andreas Dilger
ew filesystem into the kernel. It may be that your ideas, time, and efforts are better spent in contributing to an exiting project. It may also be that you have something groundbreaking work, and I look forward to reading about what that is. Cheers, Andreas

[PATCH] ARM: dts: imx6sl-tolino-shine2hd: Add Netronix embedded controller

2021-01-25 Thread Andreas Kemnade
For now, the driver detects an incompatible version, but since that can be handled by auto-detection, add the controller to the devicetree now. Only PWM seems to be available, there is no RTC in that controller. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 7

[PATCH] regulator: core: avoid error messages for deferred probing

2021-01-25 Thread Andreas Kemnade
by DCDC1 [3.877211] vddsoc: bypassed regulator has no supply! [3.882538] vddsoc: failed to get the current voltage: -EPROBE_DEFER [3.888975] vddsoc: supplied by DCDC1 Handle such issues silently. Signed-off-by: Andreas Kemnade --- drivers/regulator/core.c | 8 +++- 1 file

Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2021-01-13 Thread Andreas Kemnade
On Tue, 12 Jan 2021 20:39:02 +0100 Andreas Kemnade wrote: [...] > > +static int ntxec_pwm_probe(struct platform_device *pdev) > > +{ > > + struct ntxec *ec = dev_get_drvdata(pdev->dev.parent); > > + struct ntxec_pwm *priv; > > + struct pwm_chip *chip;

Re: [PATCH 3/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux

2021-01-13 Thread Andreas Kemnade
please ignore, that was accidentially sent. On Wed, 13 Jan 2021 00:15:47 +0100 Andreas Kemnade wrote: > Configuration was correct enough to work with the pre-configuration done by > uboot. While at it, also document the location. > > Signed-off-by: Andreas Kemnade > --- >

dcn10_get_dig_frontend problem like this fixed in "drm/amd/display: Add get_dig_frontend implementation for DCEx"

2021-01-13 Thread Andreas Hartmann
fx Could you please fix this problem, too? Please CC me for any answer because I'm not regularly reading the kernel mailing list. Thanks Andreas Hartmann 2021-01-13T10:52:02.135202+01:00 localhost kernel: [ 155.645178] [ cut here ] 2021-01-13T10:52:02.135204+01:00 localh

Re: [patch 1/4] sparc/mm/highmem: Flush cache and TLB

2021-01-12 Thread Andreas Larsson
ghmem: Switch to generic kmap atomic") Reported-by: Andreas Larsson Signed-off-by: Thomas Gleixner Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org --- arch/sparc/include/asm/highmem.h |9 + 1 file changed, 5 insertions(+), 4 deletions(-) --- a/arch/sparc/include

[PATCH 1/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux

2021-01-12 Thread Andreas Kemnade
Configuration was correct enough to work with the pre-configuration done by uboot. While at it, also document the location. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts

[PATCH 3/4] ARM: dts: imx6sl-tolino-shine3: correct console uart pinmux

2021-01-12 Thread Andreas Kemnade
Configuration was correct enough to work with the pre-configuration done by uboot. While at it, also document the location. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sl

[PATCH 4/4] ARM: dts: imx: e60k02: add second uart

2021-01-12 Thread Andreas Kemnade
There is another uart next to the console uart used by vendor uboot and kernel, enable it and document its location. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/e60k02.dtsi | 6 ++ arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 13 - arch/arm/boot/dts

[PATCH 3/4] ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux

2021-01-12 Thread Andreas Kemnade
Configuration was correct enough to work with the pre-configuration done by uboot. While at it, also document the location. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sl

[PATCH 0/4] ARM: dts: imx: uart improvements for ebookreaders

2021-01-12 Thread Andreas Kemnade
- add second uart - correct pinmux for console uart (it was working before because of setup by uboot) - document locations on board Andreas Kemnade (4): ARM: dts: imx6sl-tolino-shine2hd: correct console uart pinmux ARM: dts: imx6sl-tolino-shine2hd: add second uart ARM: dts: imx6sl-tolino

[PATCH 2/4] ARM: dts: imx6sl-tolino-shine2hd: add second uart

2021-01-12 Thread Andreas Kemnade
There is another uart next to the console uart used by vendor uboot and kernel, enable it and document its location. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot

Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2021-01-12 Thread Andreas Kemnade
> + return regmap_write(priv->ec->regmap, NTXEC_REG_ENABLE, > ntxec_reg8(0)); > + } > +} > + > +static const struct pwm_ops ntxec_pwm_ops = { > + .owner = THIS_MODULE, > + .apply = ntxec_pwm_apply, > + /* > + * No .get_state callback, because the current state cannot be read > + * back from the hardware. > + */ > +}; > + > +static int ntxec_pwm_probe(struct platform_device *pdev) > +{ > + struct ntxec *ec = dev_get_drvdata(pdev->dev.parent); > + struct ntxec_pwm *priv; > + struct pwm_chip *chip; > + > + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + priv->ec = ec; > + priv->dev = &pdev->dev; > + > + platform_set_drvdata(pdev, priv); > + > + chip = &priv->chip; > + chip->dev = &pdev->dev; Hmm, I needed chip->dev = &pdev->dev.parent to use the backlight example in patch 2/7. Not sure what the correct solution is. Maybe the pwm deserves its own devicetree node. Regards, Andreas

Re: [PATCH v7 3/7] mfd: Add base driver for Netronix embedded controller

2021-01-12 Thread Andreas Kemnade
;pm_power_off already assigned\n"); > + else > + pm_power_off = ntxec_poweroff; > + > + res = register_restart_handler(&ntxec_restart_handler); > + if (res) > + dev_err(ec->dev, > + "Failed to register restart handler: %d\n", > res); > + } > + > + i2c_set_clientdata(client, ec); > + > + res = devm_mfd_add_devices(ec->dev, PLATFORM_DEVID_NONE, > ntxec_subdevices, > +ARRAY_SIZE(ntxec_subdevices), NULL, 0, NULL); > + if (res) > + dev_err(ec->dev, "Failed to add subdevices: %d\n", res); > + > + return res; > +} > + > +static int ntxec_remove(struct i2c_client *client) > +{ > + if (client == poweroff_restart_client) { > + poweroff_restart_client = NULL; > + pm_power_off = NULL; > + unregister_restart_handler(&ntxec_restart_handler); > + } > + > + return 0; > +} > + > +static const struct of_device_id of_ntxec_match_table[] = { > + { .compatible = "netronix,ntxec", }, > + {} > +}; > + MODULE_DEVICE_TABLE? > +static struct i2c_driver ntxec_driver = { > + .driver = { > + .name = "ntxec", > + .of_match_table = of_ntxec_match_table, > + }, > + .probe_new = ntxec_probe, > + .remove = ntxec_remove, > +}; > +module_i2c_driver(ntxec_driver); MODULE_LICENSE()? modpost moans about that here. Regards, Andreas

[PATCH] powerpc/vdso: fix clock_gettime_fallback for vdso32

2021-01-11 Thread Andreas Schwab
from the 32-bit vdso. Signed-off-by: Andreas Schwab --- arch/powerpc/include/asm/vdso/gettimeofday.h | 8 1 file changed, 8 insertions(+) diff --git a/arch/powerpc/include/asm/vdso/gettimeofday.h b/arch/powerpc/include/asm/vdso/gettimeofday.h index 81671aa365b3..a26c12df2c9a 100644

Re: [PATCH] ARM: OMAP2+: omap_device: fix idling of devices during probe

2021-01-08 Thread Andreas Kemnade
Hi, On Fri, 8 Jan 2021 13:17:06 -0600 Adam Ford wrote: > On Mon, Dec 7, 2020 at 8:01 AM Tony Lindgren wrote: > > > > * Doug Anderson [201204 16:43]: > > > Hi, > > > > > > On Fri, Dec 4, 2020 at 8:14 AM Andreas Kemnade > > > wrote: &

  1   2   3   4   5   6   7   8   9   10   >