On 8/1/20 9:44 PM, Peilin Ye wrote:
> __smc_diag_dump() is potentially copying uninitialized kernel stack memory
> into socket buffers, since the compiler may leave a 4-byte hole near the
> beginning of `struct smcd_diag_dmbinfo`. Fix it by initializing `dinfo`
> with memset().
>
> Cc: sta...@v
On 9/24/19 4:52 PM, David Miller wrote:
> From: Eugene Syromiatnikov
> Date: Fri, 20 Sep 2019 17:41:47 +0200
>
>> As of now, it's a bit difficult to use SMC protocol, as significant part
>> of definitions related to it are defined in private headers and are not
>> part of UAPI. The following c
On 9/20/19 5:41 PM, Eugene Syromiatnikov wrote:
> Hello.
>
> As of now, it's a bit difficult to use SMC protocol, as significant part
> of definitions related to it are defined in private headers and are not
> part of UAPI. The following commits move some definitions to UAPI,
> making them read
On 9/11/19 5:35 PM, Colin King wrote:
> From: Colin Ian King
>
> There is a spelling mistake in QETH_CARD_TEXT text. Fix it.
>
This spelling mistake is intended, because this qeth trace area is defined for
8 byte length entries. We try to make the entries as speaking as possible - even
at co
On 01/02/2019 12:29 PM, Eric Dumazet wrote:
>
>
> On 01/02/2019 02:41 AM, syzbot wrote:
>> Hello,
>>
>> syzbot found the following crash on:
>>
>> HEAD commit: 28e8c4bc8eb4 Merge tag 'rtc-4.21' of git://git.kernel.org/..
>> git tree: upstream
>> console output: https://syzkaller.appsp
On 12/18/2018 08:03 AM, Myungho Jung wrote:
> On Mon, Dec 17, 2018 at 03:58:58PM +0100, Ursula Braun wrote:
>>
>
> Hi Ursula,
>
> Thank you for your suggestion. I have a question on your comment.
>
>>
>> On 12/17/2018 06:21 AM, Myungho Jung wrot
On 12/17/2018 06:21 AM, Myungho Jung wrote:
> clcsock can be released while kernel_accept() references it in TCP
> listen worker. Also, clcsock needs to wake up before released if TCP
> fallback is used and the clcsock is blocked by accept. Add a lock to
> safely release clcsock and call kernel_
finished.
Thus in state SMC_INIT this patch now calls sock_poll_wait() on the
main SMC socket.
Signed-off-by: Ursula Braun
---
net/smc/af_smc.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index 2d8a1e15e4f9..9c3976bcde46 100644
On 09/15/2018 12:00 PM, YueHaibing wrote:
> Comparing an int to a size, which is unsigned, causes the int to become
> unsigned, giving the wrong result. kernel_sendmsg can return a negative
> error code.
>
Thanks for reporting this issue!
> Signed-off-by: YueHaibing
> ---
> net/smc/smc_clc.
From: Karsten Graul
Remember the fallback reason code and the peer diagnosis code for
smc sockets, and provide them in smc_diag.c to the netlink interface.
And add more detailed reason codes.
Signed-off-by: Karsten Graul
Signed-off-by: Ursula Braun
---
include/uapi/linux/smc_diag.h | 6
Link confirmation will always be sent across the new link being
confirmed. This allows to shrink the parameter list.
No functional change.
Signed-off-by: Ursula Braun
---
net/smc/af_smc.c | 10 ++
net/smc/smc_llc.c | 9 +
net/smc/smc_llc.h | 2 +-
3 files changed, 8
device port, which
is not enabled for the used vlan_id. Add another check whether a
vlan gid exists for a certain IB device port.
Signed-off-by: Ursula Braun
---
net/smc/af_smc.c | 24 +---
net/smc/smc_clc.c | 10 --
net/smc/smc_clc.h | 2 +-
net/smc/smc_core.c | 37
From: Karsten Graul
Send an orderly DELETE LINK request before termination of a link group,
add support for client triggered DELETE LINK processing. And send a
disorderly DELETE LINK before module is unloaded.
Signed-off-by: Karsten Graul
Signed-off-by: Ursula Braun
---
net/smc/smc_core.c
groups.
Thanks, Ursula
Karsten Graul (2):
net/smc: provide fallback reason code
net/smc: improve delete link processing
Ursula Braun (2):
net/smc: fewer parameters for smc_llc_send_confirm_link()
net/smc: use correct vlan gid of RoCE device
include/uapi/linux/smc_diag.h | 6 +++
net/smc
On 03/01/2018 12:31 PM, Arvind Yadav wrote:
> Free memory by calling put_device(), if afiucv_iucv_init is not
> successful.
>
> Signed-off-by: Arvind Yadav
> ---
> changes in v2:
> Calling put_device() before kfree().
> changes in v3:
> No need to call kfree(). So remo
On 03/01/2018 06:25 AM, Arvind Yadav wrote:
> Free memory, if afiucv_iucv_init is not successful. So calling
> put_device() before kfree(). This will decrement the last reference.
>
> Signed-off-by: Arvind Yadav
> ---
> changes in v2:
> Calling put_device() before kfree().
>
> ne
On 01/23/2018 01:31 AM, Joe Perches wrote:
> On Mon, 2018-01-22 at 12:58 +0100, Ursula Braun wrote:
>>
>> On 01/19/2018 09:54 PM, Gustavo A. R. Silva wrote:
>>> Return statements in functions returning bool should use
>>> true/false instead of 1/0.
>>>
Fix function using_ipsec as suggested by Ursula Braun.
> - Update subject line.
>
> net/smc/smc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/smc/smc.h b/net/smc/smc.h
> index 0bee9d1..6328565 100644
> --- a/net/smc/smc.h
> +++ b/n
static inline bool using_ipsec(struct smc_sock *smc)
> {
> - return 0;
> + return false;
> }
> #endif
>
Gustavo,
thanks for reporting, but your improvement seems to be incomplete. Besides
changing
line 260 of net/smc/smc.h, line 255 should be adapted the same way. Will you
come up with a second patch version here?
Kind regards, Ursula Braun
On 11/16/2017 12:22 PM, Geert Uytterhoeven wrote:
> With gcc-4.1.2:
>
> net/smc/smc_core.c: In function ‘__smc_buf_create’:
> net/smc/smc_core.c:567: warning: ‘bufsize’ may be used uninitialized in
> this function
>
> Indeed, if the for-loop is never executed, bufsize is used
> uniniti
Hi lkml,
Linux 4.13.8 hangs on boot very early, so no output or log entries and
just a blank screen after bootloader, on Surface Book.
https://bugzilla.kernel.org/show_bug.cgi?id=197359
A parallel bug report on Ubuntu suggests the problem starts at 4.13.0
and persists to 4.14.0.
https://bugs.la
>
> From: Thomas Gleixner
> To: Dave Jones
> Cc: Linux Kernel , Steven Rostedt
> , Ursula Braun ,
> net...@vger.kernel.org
> Date: 21.03.2017 22:46
> Subject:Re: run_timer_softirq gpf. [smc]
> Sent by:netdev-ow...@vger.kernel.org
>
ACK - compile-tested successfully on s390.
On 01/30/2017 07:47 PM, Fabian Frederick wrote:
> instead of atomic_add_unless(value, -1, 0)
>
> Signed-off-by: Fabian Frederick
> ---
> drivers/s390/net/qeth_core_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers
ACK - smc_splice_read() is just a place holder at the moment. Its
implementation for AF_SMC will follow.
Regards, Ursula Braun
On 01/10/2017 12:59 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (x86_64
> allmodconfig)
Am 09.01.2017 um 09:08 schrieb Johannes Berg:
> Does it make sense to implement the two in separate layers though?
>
> Clearly, this part needs to be implemented in the bridge layer due to
> the snooping knowledge, but the code is very similar to what mac80211
> has now.
Does the bridge always kn
Am 06.01.2017 um 14:54 schrieb Johannes Berg:
>
>> The bridge layer can use IGMP snooping to ensure that the multicast
>> stream is only transmitted to clients that are actually a member of
>> the group. Can the mac80211 feature do the same?
>
> No, it'll convert the packet for all clients that a
the callbacks via the state machine and let the core invoke the
> callbacks on the already online CPUs. The smp function calls in the
> online/downprep callbacks are not required as the callback is guaranteed to
> be invoked on the upcoming/outgoing cpu.
>
> Cc: Ursula Braun
> Cc: &q
Hi Dan,
thanks for reporting this netiucv-problem. There is an implication:
Without fix, buffer values between 2**31 and 2**32 are not detected as
invalid values. Your fix would help, but since we have to touch the
code, I suggest to modernize it, moving from simple_strtoul() to
kstrtouint().
On Sun, 2016-01-03 at 11:02 +0100, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 3 Jan 2016 10:48:05 +0100
>
> Omit explicit initialisation at the beginning for one local variable
> that is redefined before its first use.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/s390/ne
Rasmus,
I do not see a need for your first patch proposal. Our code works fine
in our environment.
But I will pickup your second part to remove the explicit setting of the
0-termination. Thanks!
Regards, Ursula
On Sat, 2015-12-05 at 22:32 +0100, Rasmus Villemoes wrote:
> AFAICT, char is unsigne
Applied to our local git. Thanks. It will be part of my next patch
submission for net-next.
Kind regards, Ursula Braun, IBM Germany
On Tue, 2015-11-17 at 20:20 +0100, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 17 Nov 2015 20:10:02 +0100
>
> The channel_remove() fu
> From:Vaishali Thakkar
> To:Ursula Braun ,
> Cc:Ursula Braun1/Germany/IBM@IBMDE, BOEBLINGEN
> LINUX390/Germany/IBM@IBMDE, mschw...@linux.vnet.ibm.com,
> heica...@linux.vnet.ibm.com, linux-s...@vger.kernel.org, Linux Kernel
> Mailing List
> Date:
Thanks Vaishali. I have added your patch to our local kernel git, and
will submit it within a following upstream shipment.
Regards, Ursula Braun
On Wed, 2015-06-10 at 16:22 +0530, Vaishali Thakkar wrote:
> In little endian cases, the macro htons unfolds to __swab16 which
> provides specia
Joe,
thanks, we will add your qeth patch to our local library and submit it
with one of our next shipments.
Regards, Ursula Braun
>
> From:Joe Perches
> To:Rasmus Villemoes , Evgeny
> Cherkashin/Russia/IBM@IBMRU, Frank Blaschka
> , Ursula Braun
> Cc:
Thanks, Aya. I have added this patch version to our local library.
It will be part of our next upstream shipment to Dave Miller.
Regards, Ursula Braun
On Wed, 2014-11-05 at 21:04 +0200, Aya Mahfouz wrote:
> This patch is concerned with migrating the time variables for the s390
> network
fies_to_usecs(priv->channel[WRITE]->prof.tx_time));
printk(KERN_INFO "Statistics for %s:\n%s",
priv->channel[CTCM_WRITE]->netdev->name,
sbuf);
Regards, Ursula Braun
On Mon, 2014-11-03 at 21:33 +0200, Aya Mahfouz wrote:
> This patch is concerned
I agree with your proposed debug_unregister() changes, but not with your
kfree_fsm() change.
Regards, Ursula Braun
On Fri, 2014-10-31 at 18:40 +0100, SF Markus Elfring wrote:
> The functions debug_unregister() and kfree_fsm() test whether their argument
> is NULL and then return immed
Thx, Aya. Now I will add your patch to our collection for our next
upstream posting on net_next.
The only thing I want to change is removing your
#include
lines. All affected routines use already
#include
Thus these lines are not needed.
Regards, Ursula Braun
On Sat, 2014-11-01
rmation of the send operation. The maximum value is saved and
can be displayed in the statistics.
Regards, Ursula Braun
On Fri, 2014-10-31 at 11:18 +0200, Aya Mahfouz wrote:
> This patch is concerned with migrating the time variables for the s390
> network driver. The changes handle the y20
er
a statistic value. Since the time stamps are used in the hot traffic
path of the ctcm-driver, I prefer the "speed" optimized solution based
on jiffies here.
Regards, Ursula Braun
On Wed, 2014-10-29 at 18:02 +0200, Aya Mahfouz wrote:
> This patch is concerned with migrating the time
On Wed, 2014-07-30 at 22:32 +0200, Rickard Strandqvist wrote:
> Possible error if incorrect in parameter, count = 0.
> And clarified what the code actually does significantly.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/s390/net/claw.c | 24
> 1 file changed
On Tue, 2014-07-29 at 15:21 +0200, Rickard Strandqvist wrote:
>
> Den 29 jul 2014 15:13 skrev "Ursula Braun"
> :
> >
> > On Sat, 2014-07-26 at 16:35 +0200, Rickard Strandqvist wrote:
> > > Replacing strncpy with strlcpy to avoid strings that lacks nul
On Sun, 2014-07-27 at 13:50 +0200, Rickard Strandqvist wrote:
> The MAX_NAME_LEN is larger than sizeof, which could potentially
> giving lots of error here.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/s390/net/claw.c | 31 +++
> 1 file changed, 19 inserti
On Sat, 2014-07-26 at 16:35 +0200, Rickard Strandqvist wrote:
> Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/s390/net/qeth_core_main.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a
On Sat, 2014-07-26 at 16:33 +0200, Rickard Strandqvist wrote:
> Replacing strncpy with strlcpy to avoid strings that lacks null terminate.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/s390/net/ctcm_main.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/
e device works fine. Without, it fails.
I've also tested that USB 148f:5370 (which is another usb wifi device using the
same driver), which worked also without these patches applied, still works
after applying these patches.
Regards,
M. Braun
v2: fix endianness and coding style. Using rt2x
for rt2800usb.
With this patch applied, the 'RF chipset' detection does no longer fail.
Signed-off-by: Michael Braun
---
drivers/net/wireless/rt2x00/rt2800usb.c | 30 +-
drivers/net/wireless/rt2x00/rt2x00usb.h |1 +
2 files changed, 30 insertions(+),
becomes
useful (scan + connect to wpa network works).
Signed-off-by: Michael Braun
---
drivers/net/wireless/rt2x00/rt2800usb.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c
b/drivers/net/wireless/rt2x00/rt2800usb.c
index 11583ca
e device works fine. Without, it fails.
I've also tested that USB 148f:5370 (which is another usb wifi device using the
same driver), which worked also without these patches applied, still works
after applying these patches.
Regards,
M. Braun
---
Michael Braun (2):
rt2800usb:
for rt2800usb.
With this patch applied, the 'RF chipset' detection does no longer fail.
Signed-off-by: Michael Braun
---
drivers/net/wireless/rt2x00/rt2800usb.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rt2x00/rt28
becomes
usefull (scan + connect to wpa network works).
Signed-off-by: Michael Braun
---
drivers/net/wireless/rt2x00/rt2800usb.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c
b/drivers/net/wireless/rt2x00/rt2800usb.c
yes, the callers guarantee that count > 0 here.
Regards, Ursula Braun
On Thu, 2014-05-22 at 12:14 +0200, Ursula Braun1 wrote:
> From:Sebastian Ott
> To:Joe Perches , Ursula
> Braun1/Germany/IBM@IBMDE,
> Cc:Fabian Frederick , linux-kernel
> , akpm
&g
; Signed-off-by: Kees Cook
For the s390-part:
Acked-by: Ursula Braun
> ---
> This is a follow-up to the anti-pattern being fixed in iscsi-target,
> which was exploitable:
> "iscsi-target: fix heap buffer overflow on error"
> http://git.kerne
Hi,
I've got hardware here to test with, so if there any changes to test, I'm
willing to support.
Meanwhile, might it be a good idea to make that check optional - i.e. add a
module parameter or something like this around it?
Regards,
M. Braun
On Thu, Apr 18, 2013 at 05:13:39PM +020
iately?
Thanks,
M. Braun
--- a/drivers/usb/host/ehci-fsl.c 2013-04-15 21:13:52.924403077 +0200
+++ b/drivers/usb/host/ehci-fsl.c 2013-04-15 21:13:57.572410838 +0200
@@ -273,7 +273,6 @@ static int ehci_fsl_setup_phy(struct usb
if (!spin_event_timeout(i
i: USB PHY clock invalid" messages in dmesg and
the lsusb output is empty, so USB host support is not working. When I
apply the following patch, USB host support starts working again, so I
guess 3735ba8db8e6ea22ad3ff524328926d8d780a884 is the cause.
Regards,
M. Braun
--- a/drivers/usb/
thanks, Peter, your patch will be added to our next patch series
submission.
Ursula Braun
From: Peter Senna Tschudin
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the
Thanks, Peter. I will schedule these changes for our next posting.
Ursula Braun
> Peter Senna Tschudin wrote on 12/09/2012 19:03:14:
>
> > From:
> >
> > Peter Senna Tschudin
> >
> > To:
> >
> > Ursula Braun1/Germany/IBM@IBMDE
> &
Equivalent patch submitted for 2.6.25. Thanks.
--On Samstag, 16. Februar 2008 15:52 +0100 Julia Lawall <[EMAIL PROTECTED]>
wrote:
From: Julia Lawall <[EMAIL PROTECTED]>
The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1)
/ (d)) but is perhaps more readable.
An extract
f0abaa
This seems to be related to the new network namespace code by Eric
Biederman (CCed). Can you try the following (untested) patch? I also
CCed Ursula and Peter as they know the ctc code better than me.
CC: Eric W. Biederman <[EMAIL PROTECTED]>
CC: Ursula Braun <[EMAIL PROTECTED]&
From: Ursula Braun <[EMAIL PROTECTED]>
Remove qeth bug caused by commit:
[NET]: Move hardware header operations out of netdevice.
Signed-off-by: Ursula Braun <[EMAIL PROTECTED]>
---
drivers/s390/net/qeth_main.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: lin
--
Remove qeth driver bug introduced by this commit:
commit 3b04ddde02cf1b6f14f2697da5c20eca5715017f
Author: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Tue Oct 9 01:40:57 2007 -0700
[NET]: Move hardware header operations out of netdevice.
-
To unsubscribe from this list: send the line "u
Hi,
I've been trying to upgrade kernel to 2.6.13-rc5. The server boots
normally w/o errors, but after while (from 5 minutes up to 2 hours) the
Kernel hangs (no keyboard input possible). As I am a newbie I cannot
figure out who will be concerned with this error.
Here ist the ksymoops output (done
Update: I compiled a kernel with the radeonfb-massive-update-of-pm-
code.patch. Now I can successfully resume from acpi S3 again. The power
drain issue remains, it still uses about 5W in the suspend state.
-Volker
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the bo
I have no knowledge of the internals of the radeon family, but I am
under the impression that they require some hacks to work around bugs in
the silicon. There is a rather big patch coming, see
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-
rc1/2.6.11-rc1-mm2/broken-out/rad
Hi again,
I have been able to reproduce the locking-up behaviour! It occurs every
time I start Mozilla (0.9.2) or gtkEmbed. Other memory intensive programs
(GIMP) don't have that behaviour.
Strangely enough, the system remains mostly functional: I can switch
consoles, X and Enlightenment remain
Hi there,
I have been experiencing seemingly random lock ups with kernels 2.4.6-pre8
and 2.4.6-final which didn't occur when running on 2.4.6-pre5. I am not
yet able to reproduce this behaviour (I will look into this as soon as I
get some more time) but when it occurs the symptoms are consistent
Hello all,
the following fix from linux-2.4.2 is not yet in 2.2.19pre.
The agpgart module can not be properly unloaded and
reloaded without it.
(see http://uwsg.indiana.edu/hypermail/linux/kernel/0101.2/1273.html
for details)
Martin Braun
--- linux-2.2.19-pre13/drivers/char/agp/agpgart_be.c
Matthias Andree wrote:
>
> On Thu, 08 Feb 2001, Martin Braun wrote:
>
> > I can not get sound working on a computer with a Gigabyte
> > GA-7ZX mainboard (KT133 chipset). Is this a known problem?
>
> "Works for me" on 7ZXR, 2.2.18, ens1371 driver. R == addit
Jeff Garzik wrote:
>
> Martin Braun wrote:
> > I can not get sound working on a computer with a Gigabyte
> > GA-7ZX mainboard (KT133 chipset). Is this a known problem?
> > I have attached some config info. Mail me for further details.
>
> > $ cat /pr
Hello all
I can not get sound working on a computer with a Gigabyte
GA-7ZX mainboard (KT133 chipset). Is this a known problem?
I have attached some config info. Mail me for further details.
Thanks in advance,
Martin Braun
Hello all
I am trying to compile a new kernel with CONFIG_HIGMEM4G=y.
I get compile errors in linux/arch/i386/kernel/traps.c,
linux/mm/vmalloc.c and linux/fs/proc/kcore.c (PKMAP_BASE undeclared).
Is it sufficient to add #include ?
Cheers,
Martin Braun
es anybody else have
these problems? Can anybody help me?
Thanks a lot in advance... Felix
PS: please cc me directly
--
Felix Braun
1910 rue Wellington
Montreal PQ
Canada H3K 1W3
Tel: ++1-514-933 60 58
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the bo
le, go and complain!
>
> Anyway, redhat *is* starting to act immorally. Reminds me of some other
> big company who tries to monopolize his os by making it incompatible to
> anythign else...
Just a quick note : RH 7.0 has bee
74 matches
Mail list logo
