Re: [PATCH] powerpc/time: use get_tb instead of get_vtb in running_clock

Hi Ben I add some printk logs in watchdog_timer_fn in the guest [ 16.025222] get_vtb=8236291881, get_tb=13756711357, get_timestamp=4 [ 20.025624] get_vtb=9745285807, get_tb=15804711283, get_timestamp=7 [ 24.025042] get_vtb=11518119641, get_tb=17852711085, get_timestamp=10 [ 28.024074]

Re: [PATCH] powerpc/time: use get_tb instead of get_vtb in running_clock

Hi Ben I add some printk logs in watchdog_timer_fn in the guest [ 16.025222] get_vtb=8236291881, get_tb=13756711357, get_timestamp=4 [ 20.025624] get_vtb=9745285807, get_tb=15804711283, get_timestamp=7 [ 24.025042] get_vtb=11518119641, get_tb=17852711085, get_timestamp=10 [ 28.024074]

Re: [PATCH v2] mm/vmscan: fix high cpu usage of kswapd if there are no reclaimable pages

Hi Johannes I have another concern: kswapd -> balance_pgdat -> age_active_anon This code path will do some background works to age anon list, will this patch have some impact on it if the retry time is > 16 and kswapd is not waken up? B.R. Jia On 28/02/2017 1:06 AM, Johannes Weiner wrote: On

Re: [PATCH v2] mm/vmscan: fix high cpu usage of kswapd if there are no reclaimable pages

Hi Johannes I have another concern: kswapd -> balance_pgdat -> age_active_anon This code path will do some background works to age anon list, will this patch have some impact on it if the retry time is > 16 and kswapd is not waken up? B.R. Jia On 28/02/2017 1:06 AM, Johannes Weiner wrote: On

Re: [PATCH v2] mm/vmscan: fix high cpu usage of kswapd if there are no reclaimable pages

Hi Tested-by: Jia He cat /proc/meminfo [...] CmaFree: 0 kB HugePages_Total:1831 HugePages_Free: 1831 HugePages_Rsvd:0 HugePages_Surp:0 Hugepagesize: 16384 kB top - 06:50:29 up 1:26, 1 user, load average: 0.00, 0.00, 0.00 Tasks:

Re: [PATCH v2] mm/vmscan: fix high cpu usage of kswapd if there are no reclaimable pages

Hi Tested-by: Jia He cat /proc/meminfo [...] CmaFree: 0 kB HugePages_Total:1831 HugePages_Free: 1831 HugePages_Rsvd:0 HugePages_Surp:0 Hugepagesize: 16384 kB top - 06:50:29 up 1:26, 1 user, load average: 0.00, 0.00, 0.00 Tasks: 1 total, 0

Fwd: Re: [RFC PATCH] mm/vmscan: fix high cpu usage of kswapd if there

resend it to lkml only. Forwarded Message Subject: Re: [RFC PATCH] mm/vmscan: fix high cpu usage of kswapd if there Date: Thu, 23 Feb 2017 10:46:01 +0800 From: hejianet <hejia...@gmail.com> To: Johannes Weiner <han...@cmpxchg.org> CC: linux...@kvack.org,

Fwd: Re: [RFC PATCH] mm/vmscan: fix high cpu usage of kswapd if there

resend it to lkml only. Forwarded Message Subject: Re: [RFC PATCH] mm/vmscan: fix high cpu usage of kswapd if there Date: Thu, 23 Feb 2017 10:46:01 +0800 From: hejianet To: Johannes Weiner CC: linux...@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Mel Gorman

Re: [RFC PATCH] mm/vmscan: fix high cpu usage of kswapd if there

Hi Michal On 22/02/2017 11:48 PM, Michal Hocko wrote: On Wed 22-02-17 22:31:50, hejianet wrote: Hi Michal On 22/02/2017 7:41 PM, Michal Hocko wrote: On Wed 22-02-17 17:04:48, Jia He wrote: When I try to dynamically allocate the hugepages more than system total free memory: e.g. echo 4000

Re: [RFC PATCH] mm/vmscan: fix high cpu usage of kswapd if there

Hi Michal On 22/02/2017 11:48 PM, Michal Hocko wrote: On Wed 22-02-17 22:31:50, hejianet wrote: Hi Michal On 22/02/2017 7:41 PM, Michal Hocko wrote: On Wed 22-02-17 17:04:48, Jia He wrote: When I try to dynamically allocate the hugepages more than system total free memory: e.g. echo 4000

Re: [RFC PATCH] mm/vmscan: fix high cpu usage of kswapd if there

Hi Michal On 22/02/2017 7:41 PM, Michal Hocko wrote: On Wed 22-02-17 17:04:48, Jia He wrote: When I try to dynamically allocate the hugepages more than system total free memory: e.g. echo 4000 >/proc/sys/vm/nr_hugepages I assume that the command has terminated with less huge pages allocated

Re: [RFC PATCH] mm/vmscan: fix high cpu usage of kswapd if there

Hi Michal On 22/02/2017 7:41 PM, Michal Hocko wrote: On Wed 22-02-17 17:04:48, Jia He wrote: When I try to dynamically allocate the hugepages more than system total free memory: e.g. echo 4000 >/proc/sys/vm/nr_hugepages I assume that the command has terminated with less huge pages allocated

Re: [GIT PULL] cputime: Convert core use of cputime_t to nsecs

Hi Frederic Do we need to support CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=n on ppc64le? If yes, I got a compiling error after applying your patch set: arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function ‘cputime_to_nsecs’ [-Werror=implicit-function-declaration] return

Re: [GIT PULL] cputime: Convert core use of cputime_t to nsecs

Hi Frederic Do we need to support CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=n on ppc64le? If yes, I got a compiling error after applying your patch set: arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function ‘cputime_to_nsecs’ [-Werror=implicit-function-declaration] return

Re: [PATCH RFC 2/3] mm, vmscan: limit kswapd loop if no progress is made

On 25/01/2017 12:54 AM, Michal Hocko wrote: On Tue 24-01-17 15:49:03, Jia He wrote: Currently there is no hard limitation for kswapd retry times if no progress is made. Yes, because the main objective of the kswapd is to balance all memory zones. So having a hard limit on retries doesn't

Re: [PATCH RFC 2/3] mm, vmscan: limit kswapd loop if no progress is made

On 25/01/2017 12:54 AM, Michal Hocko wrote: On Tue 24-01-17 15:49:03, Jia He wrote: Currently there is no hard limitation for kswapd retry times if no progress is made. Yes, because the main objective of the kswapd is to balance all memory zones. So having a hard limit on retries doesn't

Re: [PATCH RFC 3/3] mm, vmscan: correct prepare_kswapd_sleep return value

On 25/01/2017 6:01 AM, Rik van Riel wrote: On Tue, 2017-01-24 at 15:49 +0800, Jia He wrote: When there is no reclaimable pages in the zone, even the zone is not balanced, we let kswapd go sleeping. That is prepare_kswapd_sleep will return true in this case. Signed-off-by: Jia He

Re: [PATCH RFC 3/3] mm, vmscan: correct prepare_kswapd_sleep return value

On 25/01/2017 6:01 AM, Rik van Riel wrote: On Tue, 2017-01-24 at 15:49 +0800, Jia He wrote: When there is no reclaimable pages in the zone, even the zone is not balanced, we let kswapd go sleeping. That is prepare_kswapd_sleep will return true in this case. Signed-off-by: Jia He ---

Re: [PATCH RFC 0/3] optimize kswapd when it does reclaim for hugepage

Hi Michal Thanks for the comments, I will resend the patch as per your comment after my 2 weeks vacation. B.R. Jia On 25/01/2017 12:46 AM, Michal Hocko wrote: On Tue 24-01-17 15:49:01, Jia He wrote: If there is a server with uneven numa memory layout: available: 7 nodes (0-6) node 0 cpus: 0 1

Re: [PATCH RFC 0/3] optimize kswapd when it does reclaim for hugepage

Hi Michal Thanks for the comments, I will resend the patch as per your comment after my 2 weeks vacation. B.R. Jia On 25/01/2017 12:46 AM, Michal Hocko wrote: On Tue 24-01-17 15:49:01, Jia He wrote: If there is a server with uneven numa memory layout: available: 7 nodes (0-6) node 0 cpus: 0 1

Re: [PATCH v5 1/2] sysctl: introduce new proc handler proc_dobool

On 05/01/2017 5:09 AM, J. Bruce Fields wrote: On Thu, Dec 15, 2016 at 03:24:20PM +0800, Jia He wrote: This is to let bool variable could be correctly displayed in big/little endian sysctl procfs. sizeof(bool) is arch dependent, proc_dobool should work in all arches. Did Alexey Debriyan agree

Re: [PATCH v5 1/2] sysctl: introduce new proc handler proc_dobool

On 05/01/2017 5:09 AM, J. Bruce Fields wrote: On Thu, Dec 15, 2016 at 03:24:20PM +0800, Jia He wrote: This is to let bool variable could be correctly displayed in big/little endian sysctl procfs. sizeof(bool) is arch dependent, proc_dobool should work in all arches. Did Alexey Debriyan agree

Re: [PATCH v5 0/2] change the proc handler for nsm_use_hostnames

Ping, any comments are welcome. Thanks B.R. Jia On 15/12/2016 3:24 PM, Jia He wrote: nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In

Re: [PATCH v5 0/2] change the proc handler for nsm_use_hostnames

Ping, any comments are welcome. Thanks B.R. Jia On 15/12/2016 3:24 PM, Jia He wrote: nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

On 20/12/2016 8:31 PM, Mel Gorman wrote: On Mon, Dec 12, 2016 at 01:59:07PM +0800, Jia He wrote: In commit b9f00e147f27 ("mm, page_alloc: reduce branches in zone_statistics"), it reconstructed codes to reduce the branch miss rate. Compared with the original logic, it assumed if !(flag &

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

On 20/12/2016 8:31 PM, Mel Gorman wrote: On Mon, Dec 12, 2016 at 01:59:07PM +0800, Jia He wrote: In commit b9f00e147f27 ("mm, page_alloc: reduce branches in zone_statistics"), it reconstructed codes to reduce the branch miss rate. Compared with the original logic, it assumed if !(flag &

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

On 20/12/2016 5:18 PM, Michal Hocko wrote: On Mon 12-12-16 13:59:07, Jia He wrote: In commit b9f00e147f27 ("mm, page_alloc: reduce branches in zone_statistics"), it reconstructed codes to reduce the branch miss rate. Compared with the original logic, it assumed if !(flag & __GFP_OTHER_NODE)

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

On 20/12/2016 5:18 PM, Michal Hocko wrote: On Mon 12-12-16 13:59:07, Jia He wrote: In commit b9f00e147f27 ("mm, page_alloc: reduce branches in zone_statistics"), it reconstructed codes to reduce the branch miss rate. Compared with the original logic, it assumed if !(flag & __GFP_OTHER_NODE)

Re: [RESEND PATCH v4 1/2] sysctl: introduce new proc handler proc_dobool

Thanks, this error is caused by # CONFIG_PROC_SYSCTL is not set Will fixed in next version Jia B.R. On 12/14/16 2:13 PM, kbuild test robot wrote: Hi Jia, [auto build test ERROR on linus/master] [also build test ERROR on v4.9 next-20161214] [if your patch is applied to the wrong git tree,

Re: [RESEND PATCH v4 1/2] sysctl: introduce new proc handler proc_dobool

Thanks, this error is caused by # CONFIG_PROC_SYSCTL is not set Will fixed in next version Jia B.R. On 12/14/16 2:13 PM, kbuild test robot wrote: Hi Jia, [auto build test ERROR on linus/master] [also build test ERROR on v4.9 next-20161214] [if your patch is applied to the wrong git tree,

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

Hi Xinhui Thanks, it really works. Will send out V3 soon afterwards B.R. Jia On 12/12/16 1:43 AM, Pan Xinhui wrote: hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

Hi Xinhui Thanks, it really works. Will send out V3 soon afterwards B.R. Jia On 12/12/16 1:43 AM, Pan Xinhui wrote: hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might

Re: [PATCH v5 0/7] Reduce cache miss for snmp_fold_field

On 9/28/16 5:08 PM, David Miller wrote: From: Jia He Date: Wed, 28 Sep 2016 14:22:21 +0800 v5: - order local variables from longest to shortest line I still see many cases where this problem still exists. Please do not resubmit this patch series until you fix all of

Re: [PATCH v5 0/7] Reduce cache miss for snmp_fold_field

On 9/28/16 5:08 PM, David Miller wrote: From: Jia He Date: Wed, 28 Sep 2016 14:22:21 +0800 v5: - order local variables from longest to shortest line I still see many cases where this problem still exists. Please do not resubmit this patch series until you fix all of them. Patch #2:

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

On 9/22/16 2:24 AM, Marcelo wrote: On Thu, Sep 22, 2016 at 12:18:46AM +0800, hejianet wrote: Hi Marcelo sorry for the late, just came back from a vacation. Hi, no problem. Hope your batteries are recharged now :-) On 9/14/16 7:55 PM, Marcelo wrote: Hi Jia, On Wed, Sep 14, 2016 at 01:58

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

On 9/22/16 2:24 AM, Marcelo wrote: On Thu, Sep 22, 2016 at 12:18:46AM +0800, hejianet wrote: Hi Marcelo sorry for the late, just came back from a vacation. Hi, no problem. Hope your batteries are recharged now :-) On 9/14/16 7:55 PM, Marcelo wrote: Hi Jia, On Wed, Sep 14, 2016 at 01:58

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

Hi Marcelo sorry for the late, just came back from a vacation. On 9/14/16 7:55 PM, Marcelo wrote: Hi Jia, On Wed, Sep 14, 2016 at 01:58:42PM +0800, hejianet wrote: Hi Marcelo On 9/13/16 2:57 AM, Marcelo wrote: On Fri, Sep 09, 2016 at 02:33:57PM +0800, Jia He wrote: This is to use

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

Hi Marcelo sorry for the late, just came back from a vacation. On 9/14/16 7:55 PM, Marcelo wrote: Hi Jia, On Wed, Sep 14, 2016 at 01:58:42PM +0800, hejianet wrote: Hi Marcelo On 9/13/16 2:57 AM, Marcelo wrote: On Fri, Sep 09, 2016 at 02:33:57PM +0800, Jia He wrote: This is to use

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

Hi Marcelo On 9/13/16 2:57 AM, Marcelo wrote: On Fri, Sep 09, 2016 at 02:33:57PM +0800, Jia He wrote: This is to use the generic interface snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Then snmp_seq_show and netstat_seq_show are

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

Hi Marcelo On 9/13/16 2:57 AM, Marcelo wrote: On Fri, Sep 09, 2016 at 02:33:57PM +0800, Jia He wrote: This is to use the generic interface snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Then snmp_seq_show and netstat_seq_show are

Re: [RFC PATCH v3 3/7] proc: Reduce cache miss in snmp6_seq_show

On 9/13/16 3:05 AM, Marcelo wrote: On Fri, Sep 09, 2016 at 02:33:58PM +0800, Jia He wrote: This is to use the generic interface snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Signed-off-by: Jia He ---

Re: [RFC PATCH v3 3/7] proc: Reduce cache miss in snmp6_seq_show

On 9/13/16 3:05 AM, Marcelo wrote: On Fri, Sep 09, 2016 at 02:33:58PM +0800, Jia He wrote: This is to use the generic interface snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Signed-off-by: Jia He --- net/ipv6/proc.c | 32

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

Hi Marcelo On 9/13/16 2:57 AM, Marcelo wrote: On Fri, Sep 09, 2016 at 02:33:57PM +0800, Jia He wrote: This is to use the generic interface snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Then snmp_seq_show and netstat_seq_show are

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

Hi Marcelo On 9/13/16 2:57 AM, Marcelo wrote: On Fri, Sep 09, 2016 at 02:33:57PM +0800, Jia He wrote: This is to use the generic interface snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Then snmp_seq_show and netstat_seq_show are

Re: [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field

Hi Marcelo Thanks for the suggestion Will consider that B.R. Jia On 9/6/16 8:44 PM, Marcelo Ricardo Leitner wrote: On Tue, Sep 06, 2016 at 10:30:03AM +0800, Jia He wrote: ... v2: - 1/6 fix bug in udplite statistics. - 1/6 snmp_seq_show is split into 2 parts Jia He (6): proc: Reduce

Re: [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field

Hi Marcelo Thanks for the suggestion Will consider that B.R. Jia On 9/6/16 8:44 PM, Marcelo Ricardo Leitner wrote: On Tue, Sep 06, 2016 at 10:30:03AM +0800, Jia He wrote: ... v2: - 1/6 fix bug in udplite statistics. - 1/6 snmp_seq_show is split into 2 parts Jia He (6): proc: Reduce

Re: [RFC PATCH v2 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show

On 9/7/16 6:57 AM, David Miller wrote: From: Jia He Date: Tue, 6 Sep 2016 10:30:04 +0800 +#define MAX(a, b) ((u32)(a) >= (u32)(b) ? (a) : (b)) Thanks B.R. Jia Please do not define private min/max macros, use the existing max_t() or similar as needed.

Re: [RFC PATCH v2 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show

On 9/7/16 6:57 AM, David Miller wrote: From: Jia He Date: Tue, 6 Sep 2016 10:30:04 +0800 +#define MAX(a, b) ((u32)(a) >= (u32)(b) ? (a) : (b)) Thanks B.R. Jia Please do not define private min/max macros, use the existing max_t() or similar as needed.

Re: [RFC PATCH 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show

Hi Eric On 8/30/16 12:41 AM, Eric Dumazet wrote: On Tue, 2016-08-30 at 00:03 +0800, Jia He wrote: This patch exchanges the two loop for collecting the percpu statistics data. This can aggregate the data by going through all the items of each cpu sequentially. In snmp_seq_show, just use one

Re: [RFC PATCH 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show

Hi Eric On 8/30/16 12:41 AM, Eric Dumazet wrote: On Tue, 2016-08-30 at 00:03 +0800, Jia He wrote: This patch exchanges the two loop for collecting the percpu statistics data. This can aggregate the data by going through all the items of each cpu sequentially. In snmp_seq_show, just use one

Re: [RFC PATCH 1/3] net: Remove unnecessary memset in __snmp6_fill_stats64

Yes, sorry about it，I am too hasty B.R. Jia He On 8/8/16 7:12 PM, Florian Westphal wrote: Jia He wrote: buff[] will be assigned later, so memset is not necessary. Signed-off-by: Jia He Cc: "David S. Miller" Cc: Alexey Kuznetsov

Re: [RFC PATCH 1/3] net: Remove unnecessary memset in __snmp6_fill_stats64

Yes, sorry about it，I am too hasty B.R. Jia He On 8/8/16 7:12 PM, Florian Westphal wrote: Jia He wrote: buff[] will be assigned later, so memset is not necessary. Signed-off-by: Jia He Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc: Patrick

Re: [RFC PATCH] mm/hugetlb: Avoid soft lockup in set_max_huge_pages()

Hi Dave On 7/26/16 11:58 PM, Dave Hansen wrote: On 07/26/2016 08:44 AM, Jia He wrote: This patch is to fix such soft lockup. I thouhgt it is safe to call cond_resched() because alloc_fresh_gigantic_page and alloc_fresh_huge_page are out of spin_lock/unlock section. Yikes. So the call site

Re: [RFC PATCH] mm/hugetlb: Avoid soft lockup in set_max_huge_pages()

Hi Dave On 7/26/16 11:58 PM, Dave Hansen wrote: On 07/26/2016 08:44 AM, Jia He wrote: This patch is to fix such soft lockup. I thouhgt it is safe to call cond_resched() because alloc_fresh_gigantic_page and alloc_fresh_huge_page are out of spin_lock/unlock section. Yikes. So the call site

Re: [RFC PATCH] mm/hugetlb: Avoid soft lockup in set_max_huge_pages()

On 7/26/16 11:58 PM, Dave Hansen wrote: On 07/26/2016 08:44 AM, Jia He wrote: This patch is to fix such soft lockup. I thouhgt it is safe to call cond_resched() because alloc_fresh_gigantic_page and alloc_fresh_huge_page are out of spin_lock/unlock section. Yikes. So the call site for both

Re: [RFC PATCH] mm/hugetlb: Avoid soft lockup in set_max_huge_pages()

On 7/26/16 11:58 PM, Dave Hansen wrote: On 07/26/2016 08:44 AM, Jia He wrote: This patch is to fix such soft lockup. I thouhgt it is safe to call cond_resched() because alloc_fresh_gigantic_page and alloc_fresh_huge_page are out of spin_lock/unlock section. Yikes. So the call site for both

Re: [PATCH v2 2/3] lib: Introduce 2 bit ops api: all_is_bit_{one,zero}

Thanks， I will add it in next verison B.R. Justin 在 11/19/15 4:40 PM, xinhui 写道: hi, jia Nice patch. But I have one minor question. see inline comments. On 2015/11/19 14:48, Jia He wrote: This patch introduces 2 lightweight bit api. all_bit_is_zero return 1 if the bit string is all zero.

Re: [PATCH v2 2/3] lib: Introduce 2 bit ops api: all_is_bit_{one,zero}

Thanks， I will add it in next verison B.R. Justin 在 11/19/15 4:40 PM, xinhui 写道: hi, jia Nice patch. But I have one minor question. see inline comments. On 2015/11/19 14:48, Jia He wrote: This patch introduces 2 lightweight bit api. all_bit_is_zero return 1 if the bit string is all zero.

Re: [PATCH 3/3] linux/bitmap: Replace find_fisrt_{zero_}bit with the new lightweight api

Thanks, I only compiled and tested in x86_64, will check what's wrong in m68k B.R. Justin 在 11/19/15 10:53 AM, kbuild test robot 写道: Hi Jia, [auto build test ERROR on: v4.4-rc1] [also build test ERROR on: next-20151118] url:

Re: [PATCH 3/3] linux/bitmap: Replace find_fisrt_{zero_}bit with the new lightweight api

Thanks, I only compiled and tested in x86_64, will check what's wrong in m68k B.R. Justin 在 11/19/15 10:53 AM, kbuild test robot 写道: Hi Jia, [auto build test ERROR on: v4.4-rc1] [also build test ERROR on: next-20151118] url:

Re: [PATCH] staging: lustre: Fix sparse warning on address-space

Hi all Ping again, any comments are welcome Justin On Mon, 29 Dec 2014 20:49:40 +0800 from hejia...@gmail.com wrote: > This patch is to fix the below warnings generated by sparse: > warning: incorrect type in argument 1 (different address spaces) > expected void const volatile [noderef] * >

Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration

Hi all Ping again, any comments are welcome Justin On Tue, 16 Dec 2014 22:39:38 +0800 from hejia...@gmail.com wrote: > make sparse happy since these two fuchtion are only used in module.c. > tested by successful compilation. > > Signed-off-by: Jia He > Cc: Oleg Drokin > Cc: Andreas Dilger >

Re: [PATCH] staging: lustre: Fix sparse warning on address-space

Hi all Ping again, any comments are welcome Justin On Mon, 29 Dec 2014 20:49:40 +0800 from hejia...@gmail.com wrote: This patch is to fix the below warnings generated by sparse: warning: incorrect type in argument 1 (different address spaces) expected void const volatile [noderef]

Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration

Hi all Ping again, any comments are welcome Justin On Tue, 16 Dec 2014 22:39:38 +0800 from hejia...@gmail.com wrote: make sparse happy since these two fuchtion are only used in module.c. tested by successful compilation. Signed-off-by: Jia He hejia...@gmail.com Cc: Oleg Drokin

Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration

Ping. Thanks for any comments On Tue, 16 Dec 2014 22:39:38 +0800 from hejia...@gmail.com wrote: > make sparse happy since these two fuchtion are only used in module.c. > tested by successful compilation. > > Signed-off-by: Jia He > Cc: Oleg Drokin > Cc: Andreas Dilger > Cc: Greg Kroah-Hartman

Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration

Ping. Thanks for any comments On Tue, 16 Dec 2014 22:39:38 +0800 from hejia...@gmail.com wrote: make sparse happy since these two fuchtion are only used in module.c. tested by successful compilation. Signed-off-by: Jia He hejia...@gmail.com Cc: Oleg Drokin oleg.dro...@intel.com Cc: Andreas

Re: [PATCH] staging: rtl8188eu: Fix coding style space related ERROR problems

Hi Greg Sorry for the inconvience. Seems I generated the patch @ your master branch instead of staging-test. I will rebase it later. B.R. Justin On Mon, 3 Nov 2014 16:25:57 -0800 from gre...@linuxfoundation.org wrote: > On Fri, Oct 31, 2014 at 10:07:15AM +0800, Jia He wrote: >> This fixes space

Re: [PATCH] staging: rtl8188eu: Fix coding style space related ERROR problems

Hi Greg Sorry for the inconvience. Seems I generated the patch @ your master branch instead of staging-test. I will rebase it later. B.R. Justin On Mon, 3 Nov 2014 16:25:57 -0800 from gre...@linuxfoundation.org wrote: On Fri, Oct 31, 2014 at 10:07:15AM +0800, Jia He wrote: This fixes space

Re: [PATCHv3] staging: rtl8188eu: Fix coding style space related ERROR problems

Hi Greg On Thu, 30 Oct 2014 08:29:14 -0700 from gre...@linuxfoundation.org wrote: > On Thu, Oct 30, 2014 at 11:21:41PM +0800, Jia He wrote: >> >From v2: rebased upon gregkh/staging.git >> >From v1: suggested by j...@perches.com, fixed some points not checked >> or not correctly checked by

Re: [PATCHv3] staging: rtl8188eu: Fix coding style space related ERROR problems

Hi Greg On Thu, 30 Oct 2014 08:29:14 -0700 from gre...@linuxfoundation.org wrote: On Thu, Oct 30, 2014 at 11:21:41PM +0800, Jia He wrote: From v2: rebased upon gregkh/staging.git From v1: suggested by j...@perches.com, fixed some points not checked or not correctly checked by checkpatch.pl

Re: [PATCHv2] staging: rtl8188eu: Fix coding style space related ERROR problems

Hi Greg Just ping it, coz this is a practising patch for Eudyptula Challenge task 10. Any comment is welcome, thank you :) On Tue, 14 Oct 2014 11:28:32 +0800 from hejia...@gmail.com wrote: > This fixes space related ERROR reports by checkpatch.pl > Generated by $ git ls-files

Re: [PATCHv2] staging: rtl8188eu: Fix coding style space related ERROR problems

Hi Greg Just ping it, coz this is a practising patch for Eudyptula Challenge task 10. Any comment is welcome, thank you :) On Tue, 14 Oct 2014 11:28:32 +0800 from hejia...@gmail.com wrote: This fixes space related ERROR reports by checkpatch.pl Generated by $ git ls-files

Re: [PATCH 1/2] staging: rtl8188eu: Fix coding style space missing problems

Thanks for the suggestion, I will update it later On Thu, 09 Oct 2014 07:35:59 -0700 from j...@perches.com wrote: > git ls-files "drivers/staging/rtl8188eu/*.[ch]" | \ > xargs ./scripts/checkpatch.pl -f --fix-inplace --strict --types=SPACING -- To unsubscribe from this list: send the line

Re: [PATCH 1/2] staging: rtl8188eu: Fix coding style space missing problems

Thanks for the suggestion, I will update it later On Thu, 09 Oct 2014 07:35:59 -0700 from j...@perches.com wrote: git ls-files drivers/staging/rtl8188eu/*.[ch] | \ xargs ./scripts/checkpatch.pl -f --fix-inplace --strict --types=SPACING -- To unsubscribe from this list: send the line