[tip:perf/urgent] perf tools: check if -DFORTIFY_SOURCE= 2 is allowed

2013-03-18 Thread tip-bot for Marcin Slusarz
Commit-ID: d2f32479e5526a1ab3b4e43910fcb279871524ce Gitweb: http://git.kernel.org/tip/d2f32479e5526a1ab3b4e43910fcb279871524ce Author: Marcin Slusarz AuthorDate: Sun, 17 Feb 2013 16:03:36 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 13 Mar 2013 16:57:27 -0300 perf tools

Re: nouveau lockdep splat

2013-03-06 Thread Marcin Slusarz
On Wed, Mar 06, 2013 at 01:04:29AM +0100, Borislav Petkov wrote: > On Tue, Mar 05, 2013 at 05:30:52PM +0100, Lucas Stach wrote: > > Dropping Tegra ML, it's not the place where Nouveau mails should go. > > $ ./scripts/get_maintainer.pl -f drivers/gpu/drm/nouveau/nv50_display.c > ... > linux-te...@v

Re: [stable request] fix for nouveau mem corruption [was: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242]

2013-02-20 Thread Marcin Slusarz
On Wed, Feb 20, 2013 at 03:47:05PM +0100, Jiri Slaby wrote: > On 02/19/2013 08:07 AM, Marcin Slusarz wrote: > >>> Crash/warning should be fixed by commit > >>> cfd376b6bfccf33782a0748a9c70f7f752f8b869 > >>> "drm/nouveau/vm: fix memory corruption when

Re: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242

2013-02-19 Thread Marcin Slusarz
On Tue, Feb 19, 2013 at 08:07:44AM +0100, Marcin Slusarz wrote: > On Tue, Feb 19, 2013 at 12:43:06AM +0100, Jiri Slaby wrote: > > On 02/19/2013 12:23 AM, Marcin Slusarz wrote: > > > On Mon, Feb 18, 2013 at 11:27:43AM +0100, Jiri Slaby wrote: > > >> Hi, > > &

Re: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242

2013-02-18 Thread Marcin Slusarz
On Tue, Feb 19, 2013 at 12:43:06AM +0100, Jiri Slaby wrote: > On 02/19/2013 12:23 AM, Marcin Slusarz wrote: > > On Mon, Feb 18, 2013 at 11:27:43AM +0100, Jiri Slaby wrote: > >> Hi, > >> > >> we have a report of WARNING from 3.7.6 in nouveau at > >> dr

Re: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242

2013-02-18 Thread Marcin Slusarz
On Mon, Feb 18, 2013 at 11:27:43AM +0100, Jiri Slaby wrote: > Hi, > > we have a report of WARNING from 3.7.6 in nouveau at > drivers/gpu/drm/nouveau/core/core/mm.c:242 here: > https://bugzilla.novell.com/show_bug.cgi?id=802347#c11 > > There is an order 4 allocation failure in nouveau_drm_open ->

[PATCH] perf: check if -DFORTIFY_SOURCE=2 is allowed

2013-02-17 Thread Marcin Slusarz
: error: "_FORTIFY_SOURCE" redefined [-Werror] :1:0: note: this is the location of the previous definition Signed-off-by: Marcin Slusarz Cc: Peter Zijlstra Cc: Paul Mackerras Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo --- tools/perf/Makefile | 8 +++- 1 file changed, 7 insert

Re: 3.8.0-rc7, nouveau, possible recursive locking, nouveau_instobj_create_ and nv50_disp_data_ctor

2013-02-16 Thread Marcin Slusarz
On Sat, Feb 16, 2013 at 12:57:07AM +0200, Denys Fedoryshchenko wrote: > Hi > > Booted on Toshiba laptop, x86_64, NVIDIA Corporation GT218 [GeForce > 310M], latest rc, and got this. > Please let me know if you need additional information. It's harmless and already quieted down in Linus' tree (pos

Re: [ 61/61] drm/nouveau: add lockdep annotations

2013-02-13 Thread Marcin Slusarz
On Wed, Feb 13, 2013 at 06:46:20PM +0100, Marcin Slusarz wrote: > On Wed, Feb 13, 2013 at 07:43:41PM +1000, Ben Skeggs wrote: > > On Wed, 2013-02-13 at 10:33 +0100, Arend van Spriel wrote: > > > On 02/13/2013 04:35 AM, Peter Hurley wrote: > > > > On Tue, 2013-02

Re: [ 61/61] drm/nouveau: add lockdep annotations

2013-02-13 Thread Marcin Slusarz
On Wed, Feb 13, 2013 at 07:43:41PM +1000, Ben Skeggs wrote: > On Wed, 2013-02-13 at 10:33 +0100, Arend van Spriel wrote: > > On 02/13/2013 04:35 AM, Peter Hurley wrote: > > > On Tue, 2013-02-12 at 12:35 -0800, Greg Kroah-Hartman wrote: > > >> 3.7-stable review patch. If anyone has any objections,

[PATCH] drm/nouveau: add lockdep annotations

2013-02-04 Thread Marcin Slusarz
class. Reported-by: Arend van Spriel Reported-by: Peter Hurley Reported-by: Maarten Lankhorst Reported-by: Daniel J Blueman Signed-off-by: Marcin Slusarz Cc: sta...@vger.kernel.org [3.7, but needs s/const ofuncs/ofuncs/ to build] --- Lightly tested, only on NV4B and NVC1. --- drivers/gpu/drm

Re: [PATCH 59/74] drm/nv17-50: restore fence buffer on resume

2013-01-24 Thread Marcin Slusarz
On Thu, Jan 24, 2013 at 01:27:11AM -0200, Herton Ronaldo Krzesinski wrote: > 3.5.7.4 -stable review patch. If anyone has any objections, please let me > know. > > -- > > From: Marcin Slusarz > > commit f20ebd034eab43fd38c58b11c5bb5fb125e5f7d7 ups

Re: Announcement: STEC EnhanceIO SSD caching software for Linux kernel

2013-01-11 Thread Marcin Slusarz
On Sat, Jan 12, 2013 at 01:18:37AM +0800, Amit Kale wrote: > Greetings, > > STEC is happy to announce hosting of our EnhanceIO SSD caching software on > github. > We would like to invite kernel hackers to try it. We'll appreciate your > valuable feedback to help us improve it to the standards of

Re: drm/nouveau E[ DRM] fail ttm_validate

2013-01-05 Thread Marcin Slusarz
On Fri, Jan 04, 2013 at 10:25:27PM +0100, Kees Bakker wrote: > On 04-01-13 18:49, Marcin Slusarz wrote: > > On Fri, Jan 04, 2013 at 01:21:14PM +0100, Kees Bakker wrote: > >> Hi, > >> > >> Right after I upgraded to Ubuntu quantal I started seeing these >

Re: drm/nouveau E[ DRM] fail ttm_validate

2013-01-04 Thread Marcin Slusarz
On Fri, Jan 04, 2013 at 01:21:14PM +0100, Kees Bakker wrote: > Hi, > > Right after I upgraded to Ubuntu quantal I started seeing these > messages: > Jan 4 12:18:12 koli kernel: [ 3705.970720] nouveau E[ DRM] fail > ttm_validate > Jan 4 12:18:12 koli kernel: [ 3705.970726] nouveau E[ DRM

Re: [RESEND PATCH] drm/nouveau: fix init with agpgart-uninorth

2012-12-31 Thread Marcin Slusarz
On Mon, Dec 31, 2012 at 03:34:59AM +0200, Aaro Koskinen wrote: > Check that the AGP aperture can be mapped. This follows a similar change > done for Radeon (commit 365048ff, drm/radeon: AGP memory is only I/O if > the aperture can be mapped by the CPU.). > > The patch fixes the following error see

Re: [3.7-rc5/rc6 regression] "drm/nvc0/disp: fix regression in vblank semaphore release" broke nouveau driver and mplayer

2012-11-17 Thread Marcin Slusarz
On Sat, Nov 17, 2012 at 08:35:18PM +0100, Mikael Pettersson wrote: > mplayer worked fine on my Dell Latitude E6510 (nVidia GT218 [NVS 3100M] > graphics) > up to and including kernel 3.7-rc4. However, with 3.7-rc5 or -rc6, any > attempt to > run mplayer just blanks the screen, shows some stray whi

Re: [PATCH] nouveau: Fix crash after D3

2012-11-07 Thread Marcin Slusarz
On Tue, Nov 06, 2012 at 10:03:40PM +0800, Daniel J Blueman wrote: > In 3.7-rc4, when starting X with the integrated GPU and suspending the > discrete GPU, > after one or more 32-bit applications are used (eg Skype) and X is stopped, > we hit a panic. > > Prevent this by testing if the fini functi

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-21 Thread Marcin Slusarz
On Sun, Oct 21, 2012 at 07:38:58AM -0700, Linus Torvalds wrote: > On Sun, Oct 21, 2012 at 5:09 AM, Marcin Slusarz > wrote: > > > > This looks like ACPI bug... > > I'm _shocked_ to hear that firmware would be fragile. > > Anyway, here's the

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-21 Thread Marcin Slusarz
On Sun, Oct 21, 2012 at 08:58:07AM +0200, Paweł Sikora wrote: > On Sunday 21 of October 2012 00:19:48 Marcin Slusarz wrote: > > On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: > > > On 20.10.2012, Marcin Slusarz wrote: > > > > > > > Try thi

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: > On 20.10.2012, Marcin Slusarz wrote: > > > Try this one. > > It works, now I can boot again. However, nouveau seems to be dead now. > The dmesg output with your patch on top of 3.7-rc1 is: > > [3.685

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
On Sat, Oct 20, 2012 at 11:42:17PM +0200, Marcin Slusarz wrote: > On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: > > On 20.10.2012, Marcin Slusarz wrote: > > > > > Try this one. > > > > It works, now I can boot again. However, nouveau seems

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: > On 20.10.2012, Marcin Slusarz wrote: > > > Try this one. > > It works, now I can boot again. However, nouveau seems to be dead now. > The dmesg output with your patch on top of 3.7-rc1 is: > > [3.685

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
On Sat, Oct 20, 2012 at 10:28:46PM +0200, Marcin Slusarz wrote: > On Sat, Oct 20, 2012 at 12:42:38PM +0200, Heinz Diehl wrote: > > On 20.10.2012, Martin Peres wrote: > > > > > Can you test the attached patch too ? I rebased the previous one I sent on > > > top

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
; Tried it. Unfortunately, the crash remains the same as reported. Try this one. Now, the question is: could 3.6 kernel get VBIOS by ACPI? If yes, please mount debugfs and send vbios.rom to me please. (cat /sys/kernel/debug/dri/0/vbios.rom > vbios.rom) --- From: Marcin Slusarz Subject: [PATCH]

Re: "netpoll: re-enable irq in poll_napi()" breaks boot with netconsole

2012-08-29 Thread Marcin Slusarz
On Wed, Aug 29, 2012 at 02:59:47PM -0400, David Miller wrote: > From: Marcin Slusarz > Date: Wed, 29 Aug 2012 20:53:29 +0200 > > > Kernel 3.6-rc3 does not boot for me with netconsole enabled, while 3.6-rc2 > > did. > > I bisected it to commit 6bdb7fe31046ac50b47e83

"netpoll: re-enable irq in poll_napi()" breaks boot with netconsole

2012-08-29 Thread Marcin Slusarz
Hi Kernel 3.6-rc3 does not boot for me with netconsole enabled, while 3.6-rc2 did. I bisected it to commit 6bdb7fe31046ac50b47e83c35cd6c6b6160a475d "netpoll: re-enable irq in poll_napi()" and reverting it on top of current Linus' tree restores proper behaviour (disabling netconsole does this too).

Re: drm/nouveau: crash regression in 3.5

2012-08-02 Thread Marcin Slusarz
On Thu, Aug 02, 2012 at 01:26:55PM +0200, Ortwin Glück wrote: > I have managed to turn the crash into a WARN_ON, by adding this to the > begin of nouveau_software_vblank(): > > if (!psw) { > WARN_ON(1); > return; > } Yes, I know about it, but t

Re: drm/nouveau: crash regression in 3.5

2012-07-30 Thread Marcin Slusarz
On Mon, Jul 30, 2012 at 01:16:37PM +0200, Ortwin Glück wrote: > On 29.07.2012 22:15, Marcin Slusarz wrote: > > No, the real problem is: with "noaccel" we don't register "software engine", > > but vblank ISR relies on its existance and happily derefences NULL

Re: drm/nouveau: crash regression in 3.5

2012-07-29 Thread Marcin Slusarz
On Thu, Jul 26, 2012 at 02:56:22PM +0200, Ortwin Glück wrote: > On 25.07.2012 20:42, Marcin Slusarz wrote: > > Good, below patch should fix this panic. > > > > Note that you can hit an oops in drm_handle_vblank because patch from > > http://lists.freedesktop.org/archive

Re: drm/nouveau: crash regression in 3.5

2012-07-26 Thread Marcin Slusarz
On Thu, Jul 26, 2012 at 02:56:22PM +0200, Ortwin Glück wrote: > On 25.07.2012 20:42, Marcin Slusarz wrote: > > Good, below patch should fix this panic. > > > > Note that you can hit an oops in drm_handle_vblank because patch from > > http://lists.freedesktop.org/archive

Re: drm/nouveau: crash regression in 3.5

2012-07-25 Thread Marcin Slusarz
nic. Note that you can hit an oops in drm_handle_vblank because patch from http://lists.freedesktop.org/archives/dri-devel/2012-May/023498.html has not been applied (yet?). -- From: Marcin Slusarz Date: Wed, 25 Jul 2012 20:07:22 +0200 Subject: [PATCH] drm/nouveau: init vblank requests list Fixes kern

Re: drm/nouveau: crash regression in 3.5

2012-07-24 Thread Marcin Slusarz
On Tue, Jul 24, 2012 at 07:22:52PM +0200, Ortwin Glück wrote: > On 24.07.2012 19:00, Marcin Slusarz wrote: > > Please post the crash log. > > Sorry, I was not precise: it boots until drm performs modesetting (so it > seems). The screen goes black and the machine is dead. So the

Re: drm/nouveau: crash regression in 3.5

2012-07-24 Thread Marcin Slusarz
On Mon, Jul 23, 2012 at 08:01:14PM +0200, Ortwin Glück wrote: > Hi, > > My HP Elitebook 8540w now crashes on boot with 3.5. All works fine with > 3.4. Bisected to the following commit: > > 20abd1634a6e2eedb84ca977adea56b8aa06cc3e is the first bad commit > commit 20abd1634a6e2eedb84ca977adea56b8a

[PATCH] video: limit stack usage of ir-kbd-i2c.c

2008-02-25 Thread Marcin Slusarz
ir_probe allocated struct i2c_client on stack; it's pretty big structure, so allocate it with kzalloc make checkstack output without this patch: x059d ir_probe [ir-kbd-i2c]: 1000 compile tested only Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Mau

Re: [PATCH] ufs: [bl]e*_add_cpu conversion

2008-02-19 Thread Marcin Slusarz
On Tue, Feb 19, 2008 at 12:22:19AM +0100, Roel Kluin wrote: > Andrew Morton wrote: > > On Wed, 13 Feb 2008 10:41:44 +0100 Roel Kluin <[EMAIL PROTECTED]> wrote: > > > >> you may also want these: > >> --- > >> [bl]e_add_cpu conversion in return > > > upsets powerpc (at least): > > > > fs/ufs/swab.

Re: [PATCH 4/7] fs/udf/truncate.c: Use BUG_ON

2008-02-17 Thread Marcin Slusarz
On Sun, Feb 17, 2008 at 06:56:18PM +0100, Julia Lawall wrote: > From: Julia Lawall <[EMAIL PROTECTED]> > > if (...) BUG(); should be replaced with BUG_ON(...) when the test has no > side-effects to allow a definition of BUG_ON that drops the code completely. The same change is in my patch which i

Re: 2.6.25-rc2-mm1: build failure (x86)

2008-02-17 Thread Marcin Slusarz
On Sun, Feb 17, 2008 at 02:37:09AM +0100, Rafael J. Wysocki wrote: > On Saturday, 16 of February 2008, Marcin Slusarz wrote: > > On Sat, Feb 16, 2008 at 03:09:49AM -0800, Andrew Morton wrote: > > > On Sat, 16 Feb 2008 11:59:07 +0100 Marcin Slusarz <[EMAIL PRO

Re: 2.6.25-rc2-mm1: build failure (x86)

2008-02-17 Thread Marcin Slusarz
On Sun, Feb 17, 2008 at 01:22:11AM +0100, Rafael J. Wysocki wrote: > On Saturday, 16 of February 2008, Marcin Slusarz wrote: > > On Sat, Feb 16, 2008 at 03:09:49AM -0800, Andrew Morton wrote: > > > On Sat, 16 Feb 2008 11:59:07 +0100 Marcin Slusarz <[EMAIL PRO

Re: 2.6.25-rc2-mm1: build failure (x86)

2008-02-16 Thread Marcin Slusarz
On Sat, Feb 16, 2008 at 03:09:49AM -0800, Andrew Morton wrote: > On Sat, 16 Feb 2008 11:59:07 +0100 Marcin Slusarz <[EMAIL PROTECTED]> wrote: > > > arch/x86/kernel/built-in.o: In function `amd_smp_thermal_interrupt': > > (.text+0xe03b): undefined reference to `mce_lo

Re: 2.6.25-rc2-mm1: build failure (x86)

2008-02-16 Thread Marcin Slusarz
arch/x86/kernel/built-in.o: In function `amd_smp_thermal_interrupt': (.text+0xe03b): undefined reference to `mce_log_therm_throt_event' arch/x86/kernel/built-in.o: In function `acpi_save_state_mem': (.text+0x12239): undefined reference to `setup_trampoline' # # Automatically generated make config:

Re: [PATCH] crypto: be*_add_cpu conversion

2008-02-13 Thread Marcin Slusarz
On Wed, Feb 13, 2008 at 09:25:47AM +0100, Roel Kluin wrote: > [EMAIL PROTECTED] wrote: > > From: Marcin Slusarz <[EMAIL PROTECTED]> > > > > replace all: > > big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) + > >

Re: [PATCH] ufs: [bl]e*_add_cpu conversion

2008-02-13 Thread Marcin Slusarz
der); > > with: > > [bl]eX_add_cpu(&big/little_endian_variable, > > expression_in_cpu_byteorder); > > you may also want these: > --- > [bl]e_add_cpu conversion in return > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> Acked-by: Marcin Slusarz <[E

[PATCH] ufs: [bl]e*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: big/little_endian_variable = cpu_to_[bl]eX([bl]eX_to_cpu(big/little_endian_variable) + expression_in_cpu_byteorder); with: [bl]eX_add_cpu(&big/little_endia

[PATCH] sysv: [bl]e*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: big/little_endian_variable = cpu_to_[bl]eX([bl]eX_to_cpu(big/little_endian_variable) + expression_in_cpu_byteorder); with: [bl]eX_add_cpu(&big/little_endia

[PATCH] reiserfs: le*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) + expression_in_cpu_byteorder); with: leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder); gene

[PATCH] quota: le*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) + expression_in_cpu_byteorder); with: leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder); gene

[PATCH] ocfs2: le*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) + expression_in_cpu_byteorder); with: leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder); gene

[PATCH] ntfs: le*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) + expression_in_cpu_byteorder); with: leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder); gene

[PATCH] jfs: le*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) + expression_in_cpu_byteorder); with: leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder); gene

[PATCH] ext4: le*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) + expression_in_cpu_byteorder); with: leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder); gene

[PATCH] ext2: le*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) + expression_in_cpu_byteorder); with: leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder); gene

[PATCH] scsi: le*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) + expression_in_cpu_byteorder); with: leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder); gene

[PATCH] ipw2200: le*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) + expression_in_cpu_byteorder); with: leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder); gene

[PATCH] hfs/hfsplus: be*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) + expression_in_cpu_byteorder); with: beX_add_cpu(&big_endian_variable, expression_in_cpu_byteorder); generated wit

[PATCH] gfs2: be*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) + expression_in_cpu_byteorder); with: beX_add_cpu(&big_endian_variable, expression_in_cpu_byteorder); generated wit

[PATCH] affs: be*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) + expression_in_cpu_byteorder); with: beX_add_cpu(&big_endian_variable, expression_in_cpu_byteorder); generated wit

[PATCH] infiniband: be*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) + expression_in_cpu_byteorder); with: beX_add_cpu(&big_endian_variable, expression_in_cpu_byteorder); generated wit

[PATCH] ieee 1394: be*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) + expression_in_cpu_byteorder); with: beX_add_cpu(&big_endian_variable, expression_in_cpu_byteorder); generated wit

[PATCH] crypto: be*_add_cpu conversion

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> replace all: big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) + expression_in_cpu_byteorder); with: beX_add_cpu(&big_endian_variable, expression_in_cpu_byteorder); generated wit

[PATCHSET] [bl]e*_add_cpu conversions

2008-02-12 Thread marcin . slusarz
From: Marcin Slusarz <[EMAIL PROTECTED]> Hi This patchset converts big/little_endian_variable = cpu_to_[bl]eX([bl]eX_to_cpu(big/little_endian_variable) + expression_in_cpu_byteorder); to: [bl]eX_add_cpu(&big/little_endia

Re: udf regression: broken directory handling

2008-02-12 Thread Marcin Slusarz
On Tue, Feb 12, 2008 at 12:39:17PM +0100, Jan Kara wrote: > On Mon 11-02-08 20:13:20, Marcin Slusarz wrote: > > On Mon, Feb 11, 2008 at 12:09:10PM +0100, Jan Kara wrote: > > > Hi, > > > > > > On Sun 10-02-08 11:48:17, Marcin Slusarz wrote: > > >

Re: udf regression: broken directory handling

2008-02-11 Thread Marcin Slusarz
On Mon, Feb 11, 2008 at 12:09:10PM +0100, Jan Kara wrote: > Hi, > > On Sun 10-02-08 11:48:17, Marcin Slusarz wrote: > > Current mainline has a problem with reading file list. > > Simple ls prints only 2 out of 8 files on my testing DVD. > > Reverting your patch &qu

Re: bug in checkpatch (on pointers to typedefs?)

2008-02-11 Thread Marcin Slusarz
On Mon, Feb 11, 2008 at 10:23:39AM +, Andy Whitcroft wrote: > On Sun, Feb 10, 2008 at 03:33:02PM +0100, Marcin Slusarz wrote: > > Hi > > > > Checkpatch in current mainline outputs following errors: > > > > $ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c &

[PATCH] udf: fix udf_add_free_space

2008-02-10 Thread Marcin Slusarz
in commit 742ba02a51c8d0bf5446b154531179760c1ed0a2 (udf: create common function for changing free space counter) by accident I reversed safety condition which lead to null pointer dereference in case of media error and wrong counting of free space in normal situation Signed-off-by: Marcin Slusarz

bug in checkpatch (on pointers to typedefs?)

2008-02-10 Thread Marcin Slusarz
Hi Checkpatch in current mainline outputs following errors: $ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c ERROR: need consistent spacing around '*' (ctx:WxV) #205: FILE: fs/udf/misc.c:205: + tag *tag_p; ^ $ ./scripts/checkpatch.pl -q --file ./fs/udf/unicode.c ERROR: need

Re: [3/6] kgdb: core

2008-02-10 Thread Marcin Slusarz
On Sun, Feb 10, 2008 at 02:19:06PM +0100, Jesper Juhl wrote: > On 10/02/2008, Marcin Slusarz <[EMAIL PROTECTED]> wrote: > > On Sun, Feb 10, 2008 at 08:13:31AM +0100, Ingo Molnar wrote: > ... > > > + > > > + if (CACHE_FLUSH_IS_SAFE) { > > >

Re: [3/6] kgdb: core

2008-02-10 Thread Marcin Slusarz
On Sun, Feb 10, 2008 at 08:13:31AM +0100, Ingo Molnar wrote: > + } else { > + while (count-- > 0) { > + unsigned char ch; > + > + if (probe_kernel_address(mem, ch)) { > + kgdb_may_fault = 0; > +

udf regression: broken directory handling

2008-02-10 Thread Marcin Slusarz
Hi Current mainline has a problem with reading file list. Simple ls prints only 2 out of 8 files on my testing DVD. Reverting your patch "udf: cleanup directory offset handling" (af793295bf9ee92660f5e77d337b0493cea3f9b9) fixes the problem. Marcin -- To unsubscribe from this list: send the line "un

Re: [PATCH 6/6] udf: super.c reorganization

2008-02-10 Thread Marcin Slusarz
On Wed, Feb 06, 2008 at 12:09:36PM +0100, Jan Kara wrote: > On Tue 05-02-08 20:34:49, Marcin Slusarz wrote: > > On Tue, Feb 05, 2008 at 05:22:19PM +0100, Jan Kara wrote: > > > Actually, the loop below would be even more readable it you did: > > > > > > if

Re: [PATCH 5/6] udf: remove unneeded kernel_timestamp type

2008-02-10 Thread Marcin Slusarz
atch: udf: convert udf_stamp_to_time and udf_time_to_stamp to use timestamps --- udf: remove unneeded kernel_timestamp type remove now unneeded kernel_timestamp type with conversion functions Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Acked-by: Jan Kara <[EMAIL PROTECTED]>

Re: [PATCH 4/6] udf: convert udf_stamp_to_time and udf_time_to_stamp to use timestamps

2008-02-10 Thread Marcin Slusarz
On Wed, Feb 06, 2008 at 12:10:08PM +0100, Jan Kara wrote: > On Tue 05-02-08 20:21:58, Marcin Slusarz wrote: > > On Tue, Feb 05, 2008 at 04:59:56PM +0100, Jan Kara wrote: > > > On Sun 03-02-08 19:36:09, [EMAIL PROTECTED] wrote: > > > > kernel_timestamp type was a

[PATCH resend] slab: avoid double initialization & do initialization in 1 place

2008-02-10 Thread Marcin Slusarz
- alloc_slabmgmt: initialize all slab fields in 1 place - slab->nodeid was initialized twice: in alloc_slabmgmt and immediately after it in cache_grow Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Christoph Lameter <[EMAIL PROTECTED]> Reviewed-by: Pekka Enberg &l

[PATCH] xfs: convert beX_add to beX_add_cpu (new common API)

2008-02-10 Thread Marcin Slusarz
This patch was in Andrew tree, but it was uncomplete. Here is updated version. --- remove beX_add functions and replace all uses with beX_add_cpu Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> --- fs/xfs/quota/xfs_qm.c |6 ++-- fs/xfs/quota/xfs_trans_dquot.c |6 ++--

[PATCH resend] ext2/3/4: convert byte order of constant instead of variable

2008-02-10 Thread Marcin Slusarz
convert byte order of constant instead of variable which can be done at compile time (vs run time) ext3/4 bits are #if 0'ed, but someone might copy this code into other places Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> --- fs/ext2/super.c |8 +++- fs/ext3/super.c |

[PATCH resend] qla3xxx: convert byte order of constant instead of variable

2008-02-10 Thread Marcin Slusarz
convert byte order of constant instead of variable which can be done at compile time (vs run time) Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> --- drivers/net/qla3xxx.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drive

Re: [PATCH 6/6] udf: super.c reorganization

2008-02-05 Thread Marcin Slusarz
On Tue, Feb 05, 2008 at 05:22:19PM +0100, Jan Kara wrote: > Actually, the loop below would be even more readable it you did: > > if (map->s_partition_num == le16_to_cpu(p->partitionNumber)) > break; > And do the work after we exit from the loop. > > > > for (i = 0; i < sbi->s_parti

Re: [PATCH 4/6] udf: convert udf_stamp_to_time and udf_time_to_stamp to use timestamps

2008-02-05 Thread Marcin Slusarz
On Tue, Feb 05, 2008 at 04:59:56PM +0100, Jan Kara wrote: > On Sun 03-02-08 19:36:09, [EMAIL PROTECTED] wrote: > > kernel_timestamp type was almost unused - only callers of udf_stamp_to_time > > and udf_time_to_stamp used it, so let these functions handle endianness > > internally and don't clutter

Re: [PATCH 02/10] udf: fix udf_build_ustr

2008-02-05 Thread Marcin Slusarz
On Tue, Feb 05, 2008 at 04:29:23PM +0100, Jan Kara wrote: > PS: I'm working on getting access to kernel.org so that I can run UDF git > tree there so we try merging these patches with the new git when I set that > up :). Good to hear that :) Marcin -- To unsubscribe from this list: send the line "

Re: [PATCH 3/6] udf: convert udf_stamp_to_time to return struct timespec

2008-02-05 Thread Marcin Slusarz
s ok. Creation of udf_fill_inode_time was an intermediate state in this cleanup. Every step is obvious and easy. When I tried to create just one patch it didn't look so obvious, so I decided to send it in 4 parts. > > On Sun 03-02-08 19:36:08, [EMAIL PROTECTED] wrote: > > Signed-off-by: Marcin Slusa

Re: [PATCH 02/10] udf: fix udf_build_ustr

2008-02-04 Thread Marcin Slusarz
On Mon, Feb 04, 2008 at 08:31:07PM +0100, Jan Kara wrote: > On Thu 31-01-08 20:57:47, Marcin Slusarz wrote: > > On Thu, Jan 31, 2008 at 11:45:32AM +0100, Jan Kara wrote: > > > On Wed 30-01-08 22:03:52, [EMAIL PROTECTED] wrote: > > > > udf_build_ustr was compl

[PATCH 6/6] udf: super.c reorganization

2008-02-03 Thread Marcin Slusarz
(); if (!sth2) continue; long block of code; } } Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/super.c | 519 1 files changed, 25

[PATCH 5/6] udf: remove unneeded kernel_timestamp type

2008-02-03 Thread marcin . slusarz
remove now unneeded kernel_timestamp type with conversion functions Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/ecma_167.h | 13 - fs/udf/super.c|9 + fs/udf/udfend.h | 22 -- 3 f

[PATCH 4/6] udf: convert udf_stamp_to_time and udf_time_to_stamp to use timestamps

2008-02-03 Thread marcin . slusarz
kernel_timestamp type was almost unused - only callers of udf_stamp_to_time and udf_time_to_stamp used it, so let these functions handle endianness internally and don't clutter code with conversions Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Jan Kara <[EMAIL PROTECTED

[PATCH 2/6] udf: create function for conversion from timestamp to timespec

2008-02-03 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/inode.c | 79 --- 1 files changed, 23 insertions(+), 56 deletions(-) diff --git a/fs/udf/inode.c b/fs/udf/inode.c index 531443d..25

[PATCH 3/6] udf: convert udf_stamp_to_time to return struct timespec

2008-02-03 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/inode.c | 49 ++--- fs/udf/super.c |9 ++--- fs/udf/udfdecl.h |4 ++-- fs/udf/udftime.c | 17 +++-- 4 files

[PATCH 1/6] udf: udf_get_block, inode_bmap - remove unneeded checks

2008-02-03 Thread marcin . slusarz
block cannot be less than 0, because it's sector_t, so remove unneeded checks Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/inode.c | 12 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/fs/udf/inode.c

[PATCH 0/6] udf: next round of cleanups

2008-02-03 Thread marcin . slusarz
ime.c | 39 +-- 6 files changed, 358 insertions(+), 460 deletions(-) Applies on top of patches I've sent lately (http://lkml.org/lkml/2008/1/30/482) Jan: Are you going to create git tree for udf? Marcin Slusarz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&

[PATCH 0/6] udf: next round of cleanups

2008-02-03 Thread marcin . slusarz
ime.c | 39 +-- 6 files changed, 358 insertions(+), 460 deletions(-) Applies on top of patches I've sent lately (http://lkml.org/lkml/2008/1/30/482) Jan: Are you going to create git tree for udf? Marcin Slusarz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&

Re: [PATCH 10/10] udf: constify udf_bitmap_lookup array

2008-02-02 Thread Marcin Slusarz
On Thu, Jan 31, 2008 at 05:52:44PM +0100, Jan Kara wrote: > On Wed 30-01-08 22:04:00, [EMAIL PROTECTED] wrote: > > udf_bitmap_lookup never changes, so constify it > > > > Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> > > Cc: Jan Kara <[EMAIL PROTECTED]>

[PATCH] x86: fix cpu info in dmesg

2008-02-01 Thread Marcin Slusarz
stepping 00 (broken since 04e1ba852132c9ad006affcd5b8c8606295170b0 - x86: cleanup kernel/setup_64.c) Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Thomas Gleixner <[EMAIL PROTECTED]> Cc: Ingo Molnar <[EMAIL PROTECTED]> --- arch/x86/kernel/setup_64.c |2 +- 1 file

Re: [PATCH 02/10] udf: fix udf_build_ustr

2008-01-31 Thread Marcin Slusarz
t; > to acceptable values (constants) > > > > Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> > > Cc: Jan Kara <[EMAIL PROTECTED]> > > --- > > fs/udf/unicode.c | 12 ++-- > > 1 files changed, 6 insertions(+), 6 deletions(-) > > > >

Re: [PATCH 06/10] udf: truncate: create function for updating of Allocation Ext Descriptor

2008-01-31 Thread Marcin Slusarz
On Thu, Jan 31, 2008 at 06:08:58PM +0100, Jan Kara wrote: > On Wed 30-01-08 22:03:56, [EMAIL PROTECTED] wrote: > > Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> > > Cc: Jan Kara <[EMAIL PROTECTED]> > There are at least a few other places in inode.c whi

[PATCH 10/10] udf: constify udf_bitmap_lookup array

2008-01-30 Thread marcin . slusarz
udf_bitmap_lookup never changes, so constify it Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/super.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/udf/super.c b/fs/udf/super.c index 3afe764..6bb2a5b 100

[PATCH 08/10] udf: simplify __udf_read_inode

2008-01-30 Thread marcin . slusarz
- move all brelse(ibh) after main if, because it's called on every path except one where ibh is null - move variables to the most inner blocks Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Jan Kara <[EMAIL PROTECTED]> --- fs/u

[PATCH 09/10] udf: replace udf_*_offset macros with functions

2008-01-30 Thread marcin . slusarz
- translate udf_file_entry_alloc_offset macro into function - translate udf_ext0_offset macro into function - add comment about crypticly named fields in struct udf_inode_info Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/udfdecl.h

[PATCH 07/10] udf: replace all adds to little endians variables with le*_add_cpu

2008-01-30 Thread marcin . slusarz
with this patch Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED] Cc: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/balloc.c | 13 - fs/udf/ialloc.c | 12 fs/udf/inode.c | 16 3 files changed, 12 insertions(+), 29 deletions(-) diff --git a/fs/udf

[PATCH 06/10] udf: truncate: create function for updating of Allocation Ext Descriptor

2008-01-30 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/truncate.c | 56 +--- 1 files changed, 23 insertions(+), 33 deletions(-) diff --git a/fs/udf/truncate.c b/fs/udf/truncate.c index f64f

[PATCH 04/10] udf: constify crc

2008-01-30 Thread marcin . slusarz
- constify internal crc table - mark udf_crc "in" parameter as const Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/crc.c |4 ++-- fs/udf/udfdecl.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --g

[PATCH 05/10] udf: simple cleanup of truncate.c

2008-01-30 Thread marcin . slusarz
- remove one indentation level by little code reorganization - convert "if (smth) BUG();" to "BUG_ON(smth);" Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> Cc: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/truncate.c | 76 +++--

  1   2   3   >