tly and I suspect try-run miht not be defined in this kselftest
build case.
thanks,
-- Shuah
addresses requests from developers and testers to add
support for building from the main Makefile.
Signed-off-by: Shuah Khan
---
Makefile | 4
1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile
index d456746da347..ac4af6fc4b50 100644
--- a/Makefile
+++ b/Makefile
@@ -1233,6
This patch series simplifies kselftest use-cases and addresses requests
from developers and testers to add support for building and installing
from the main Makefile.
Shuah Khan (2):
Makefile: Add kselftest_build target to build tests
selftests: Add kselftest_install target to main Makefile
Makefile.
In addition, make the install directory the same when install is
run using "make kselftest_install" or by running kselftest_install.sh.
Also fix the INSTALL_PATH variable conflict between main Makefile.
Signed-off-by: Shuah Khan
---
Makefile
and commit:
d04e26067d13f01 ("selftests: tpm2: install python files")
Please take the fix from kselftest tree which is the correct
version for this change.
d04e26067d13f01 ("selftests: tpm2: install python files")
Please let me know if you have any questions and/
On 9/25/19 1:48 AM, Paolo Bonzini wrote:
On 24/09/19 22:14, Shuah Khan wrote:
Fix the following build error:
libkvm.a(assert.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be
used when making a PIE object; recompile with -fPIC
Add -fPIC to CFLAGS to fix it.
This is wrong
Fix the following build error:
libkvm.a(assert.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be
used when making a PIE object; recompile with -fPIC
Add -fPIC to CFLAGS to fix it.
Signed-off-by: Shuah Khan
---
tools/testing/selftests/kvm/Makefile | 2 +-
1 file changed, 1
On 9/24/19 1:52 PM, Alexey Dobriyan wrote:
On Tue, Sep 24, 2019 at 12:19:10PM -0600, Shuah Khan wrote:
Fix the following _GNU_SOURCE redefined build warns:
proc-loadavg-001.c:17: warning: "_GNU_SOURCE" redefined
proc-self-syscall.c:16: warning: "_GNU_SOURCE" redefined
Fix build failure:
undefined reference to `pthread_create'
collect2: error: ld returned 1 exit status
Fix CFLAGS to include pthread correctly.
Signed-off-by: Shuah Khan
---
tools/testing/selftests/pidfd/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing
Fix the following _GNU_SOURCE redefined build warn:
execveat.c:8: warning: "_GNU_SOURCE" redefined
Signed-off-by: Shuah Khan
---
No code changes. Sending to right people.
tools/testing/selftests/exec/execveat.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/self
Fix the following _GNU_SOURCE redefined build warns:
proc-loadavg-001.c:17: warning: "_GNU_SOURCE" redefined
proc-self-syscall.c:16: warning: "_GNU_SOURCE" redefined
proc-uptime-002.c:18: warning: "_GNU_SOURCE" redefined
Signed-off-by: Shuah Khan
---
tools/testi
Fix the following _GNU_SOURCE redefined build warn:
execveat.c:8: warning: "_GNU_SOURCE" redefined
Signed-off-by: Shuah Khan
---
tools/testing/selftests/exec/execveat.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/exec/execveat.c
b/tools/testing/self
tion 8 of Documentation/process/coding-style.rst
You don't combine documentation and code patches. I don't think you need
to add this comment in here.
thanks,
-- Shuah
and commit:
d04e26067d13f01 ("selftests: tpm2: install python files")
Please take the fix from kselftest tree which is the correct
version for this change.
d04e26067d13f01 ("selftests: tpm2: install python files")
Please let me know if you have any questions and/
operation */
loff_t offset = dio->iocb->ki_pos;
ssize_t transferred = 0;
int err;
--
2.17.1
ᐧ
ᐧ
thanks,
-- Shuah
On 9/23/19 2:53 PM, Ingo Molnar wrote:
* Shuah Khan wrote:
Right. What you suggesting is very similar to and more complete than
what I have been thinking about and proposed at the KS kselftest track.
i.e move tools/testing/selftests to kselftest at the root level. I like
your idea of moving
On 9/23/19 1:52 PM, Randy Dunlap wrote:
On 9/23/19 12:43 PM, Ingo Molnar wrote:
* Shuah Khan wrote:
I am exploring the possibility to move selftests to a better location
or add a git alias so it can be found easily. With the addition of
KUnit and future work that is planned to connect
e a good place for it.
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.9.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.14.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.2.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
/linux/kernel/git/stable/linux-stable-rc.git
linux-5.3.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
On 9/19/19 3:17 PM, Kees Cook wrote:
On Thu, Sep 19, 2019 at 02:09:37PM -0600, shuah wrote:
On 9/19/19 12:55 PM, Alexandre Belloni wrote:
On 19/09/2019 11:06:44-0700, Kees Cook wrote:
Commit a745f7af3cbd ("selftests/harness: Add 30 second timeout per
test") solves t
explaining. Brendan and I will get this sorted out.
Looks like my previous response didn't make it to the kselftest
and kernel lists.
thanks,
-- Shuah
echo "not ok $test_num $TEST_HDR_MSG # TIMEOUT"
else
- echo "not ok $test_num $TEST_HDR_MSG"
+ echo "not ok $test_num $TEST_HDR_MSG # exit=$rc"
fi)
cd - >/dev/null
fi
diff --git a/tools/testing/selftests/rtc/settings
b/tools/testing/selftests/rtc/settings
new file mode 100644
index ..ba4d85f74cd6
--- /dev/null
+++ b/tools/testing/selftests/rtc/settings
@@ -0,0 +1 @@
+timeout=90
--
2.17.1
--
Kees Cook
thanks,
-- Shuah
underlying struct file.
Signed-off-by: Christian Brauner
Cc: Kees Cook
Cc: Andy Lutomirski
Cc: Will Drewry
Cc: Shuah Khan
Cc: Alexei Starovoitov
Cc: Daniel Borkmann
Cc: Martin KaFai Lau
Cc: Song Liu
Cc: Yonghong Song
Cc: Tycho Andersen
CC: Tyler Hicks
Cc: sta...@vger.kernel.org
Cc
/kernel/git/shuah/linux-kselftest.git/commit/?h=next=69b2d3c5924273a0ae968d3818210fc57a1b9d07
Excuse me, does it mean that you expect each selftest to be self-hosted?
I was (and still is) under impression that selftests should be built
with headers installed from the tree. Is it the case
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.14.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.2.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
Add usage message on how to exit the virtualenv after documentation
work is done.
Signed-off-by: Shuah Khan
---
Changes since v1:
Changed the message based on Mauro's review comments.
scripts/sphinx-pre-install | 8
1 file changed, 8 insertions(+)
diff --git a/scripts/sphinx-pre
On 9/18/19 5:33 AM, Eugeniu Rosca wrote:
Hi Shuah,
On Tue, Sep 17, 2019 at 08:40:22PM +0200, Eugeniu Rosca wrote:
From: "George G. Davis"
The newly added optional file argument does not validate if the
file is indeed a watchdog, e.g.:
./watchdog-test -f /dev/zero
Watchdog Ti
compliance test
- Changed control naming to follow English capitalization rules
- Rebased to Shuah Khan's newest patch series 171283
("Collapse vimc single monolithic driver")
- Change maximum value for mean window size
We did run streaming tests, the value of 1 for mean windo
Add usage message on how to exit the virtualenv after documentation
work is done.
Signed-off-by: Shuah Khan
---
scripts/sphinx-pre-install | 8
1 file changed, 8 insertions(+)
diff --git a/scripts/sphinx-pre-install b/scripts/sphinx-pre-install
index 3b638c0e1a4f..932547791e3c 100755
On 9/17/19 11:50 AM, Eugeniu Rosca wrote:
On Tue, Sep 17, 2019 at 11:44:45AM -0600, shuah wrote:
On 9/17/19 10:54 AM, Eugeniu Rosca wrote:
Shuah,
On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote:
[..]
I want two patches and the first one with
Fixes tag.
These two patches need
On 9/17/19 10:54 AM, Eugeniu Rosca wrote:
Shuah,
On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote:
[..]
I want two patches and the first one with
Fixes tag.
These two patches need to be separate. The first one is a fix and
the second is an enhancement.
Please send two patches
After practically re-writing the driver to collpase it into a monolith,
I am adding myself as a reviewer for vimc driver.
Signed-off-by: Shuah Khan
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7c62b45201d7..4529d257f8db 100644
kernel: [ 4136.716010] entry_SYSCALL_64_after_hwframe+0x4
Signed-off-by: Shuah Khan
---
drivers/media/platform/vimc/vimc-common.c | 3 +--
drivers/media/platform/vimc/vimc-debayer.c | 1 +
drivers/media/platform/vimc/vimc-scaler.c | 1 +
drivers/media/platform/vimc/vimc-sensor.c | 1 +
4 files chan
{
0}}", shape=Mrecord, style=filled, fillcolor=green]
n0013:port0 -> n0015:port0 [style=dashed]
n0015 [label="{{ 0} | Scaler\n/dev/v4l-subdev5 | {
1}}", shape=Mrecord, style=filled, fillcolor=green]
n0015:port1 -> n0018 [style=bold]
:0[fmt:SBGGR8_1X8/640x480]'
v4l2-ctl -z platform:vimc -d "RGB/YUV Capture" -v width=1920,height=1440
v4l2-ctl -z platform:vimc -d "Raw Capture 0" -v pixelformat=BA81
v4l2-ctl -z platform:vimc -d "Raw Capture 1" -v pixelformat=BA81
v4l2-ctl --stream-mmap --stream-count
Move duplicated IS_SRC and IS_SINK dfines to common header. Rename
them to VIMC_IS_SRC and VIM_IS_SINK.
Signed-off-by: Shuah Khan
---
drivers/media/platform/vimc/vimc-common.h | 4
drivers/media/platform/vimc/vimc-debayer.c | 11 ---
drivers/media/platform/vimc/vimc-scaler.c
vimc driver is now a monolithic driver. Update the module parameter
usage information to reflect that.
Signed-off-by: Shuah Khan
---
Documentation/media/v4l-drivers/vimc.rst | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/media/v4l-drivers/vimc.rst
On 9/17/19 8:54 AM, Eugeniu Rosca wrote:
Shuah,
On Mon, Sep 16, 2019 at 07:19:35PM -0600, shuah wrote:
On 9/16/19 12:49 PM, George G. Davis wrote:
As reported by Eugeniu Rosca, a side of affect of commit c3f2490d6e92
("selftests: watchdog: Add optional file argument") is that arbit
to suit older kernel needs.
This definitely isn't a change that is good to make. We have to come
with a better way to solve this. Could you please send me the errors
you are seeing so I can help you find a better solution.
thanks,
-- Shuah
On 9/16/19 4:42 AM, Helen Koike wrote:
On 9/15/19 8:52 PM, Shuah Khan wrote:
On 9/15/19 1:25 PM, Helen Koike wrote:
Hi Shuah,
On 9/6/19 11:42 PM, Shuah Khan wrote:
Move duplicated IS_SRC and IS_SINK dfines to common header. Rename
them to VIMC_IS_SRC and VIM_IS_SINK.
Signed-off-by: Shuah
l allowed to in case it sees
+some use for it.
What would be the scenarios where setting both could be useful? Please
explain.
--
2.23.0.162.g0b9fbb3734-goog
thanks,
-- Shuah
quot;);
+ }
+ break;
+ case MMAP_MAP_HUGETLB:
+ printf("Allocating using MAP_HUGETLB.\n");
+ ptr = mmap(NULL, size,
+ PROT_READ | PROT_WRITE,
+ (private ? (MAP_PRIVATE | MAP_ANONYMOUS) : MAP_SHARED) |
+ MAP_HUGETLB | (populate ?
+ MAP_POPULATE : 0),
+ -1, 0);
+
+ if (ptr == MAP_FAILED)
+ err(1, "mmap");
+
+ printf("Returned address is %p\n", ptr);
+ break;
+ case SHM:
+ printf("Allocating using SHM.\n");
+ shmid = shmget(key, size, SHM_HUGETLB | IPC_CREAT | SHM_R |
+ SHM_W);
+ if (shmid < 0) {
+ shmid = shmget(++key, size, SHM_HUGETLB | IPC_CREAT |
+ SHM_R | SHM_W);
+ if (shmid < 0)
+ err(1, "shmget");
+
+ }
+ printf("shmid: 0x%x, shmget key:%d\n", shmid, key);
+
+ shmaddr = shmat(shmid, NULL, 0);
+ if (shmaddr == (char *)-1) {
+ perror("Shared memory attach failure");
+ shmctl(shmid, IPC_RMID, NULL);
+ exit(2);
+ }
+ printf("shmaddr: %p\n", shmaddr);
+
+ break;
+ default:
+ errno = EINVAL;
+ err(1, "Invalid method.");
+ }
+
+ if (write) {
+ printf("Writing to memory.\n");
+ if (method != SHM) {
+ memset(ptr, 1, size);
+ } else {
+ printf("Starting the writes:\n");
+ for (i = 0; i < size; i++) {
+ shmaddr[i] = (char)(i);
+ if (!(i % (1024 * 1024)))
+ printf(".");
+ }
+ printf("\n");
+
+ printf("Starting the Check...");
+ for (i = 0; i < size; i++)
+ if (shmaddr[i] != (char)i) {
+ printf("\nIndex %lu mismatched\n", i);
+ exit(3);
+ }
+ printf("Done.\n");
+
+
+ }
+ }
+
+ if (want_sleep) {
+ /* Signal to caller that we're done. */
+ printf("DONE\n");
+
+ /* Hold memory until external kill signal is delivered. */
+ while (1)
+ sleep(100);
Please don't add sleeps. This will hold up the kselftest run.
+ }
+
+ close(fd);
Is this close() necessary in all cases? Looks like MMAP_MAP_HUGETLB
is the only case that opens it.
I am not sure if the error legs are correct.
+
+ return 0;
+}
--
2.23.0.162.g0b9fbb3734-goog
thanks,
-- Shuah
),
+ ret = page_counter_set_max(hugetlb_cgroup_get_counter(h_cg, idx,
+ reserved),
nr_pages);
mutex_unlock(_limit_mutex);
break;
--
2.23.0.162.g0b9fbb3734-goog
thanks,
-- Shuah
eab71e210f ("kunit: fix failure to build without
printk") of
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=next
v2: Squashed [1] and [2], and update commit description as discussed in [3].
[1] https://patchwork.kernel.org/patch/1113
printf(cft->name, MAX_CFTYPE_NAME, "%s.reservation_failcnt", buf);
+ cft->private = MEMFILE_PRIVATE(idx, HUGETLB_RES_RESERVATION_FAILCNT);
cft->write = hugetlb_cgroup_reset;
cft->read_u64 = hugetlb_cgroup_read_u64;
/* NULL terminate the last cft */
- cft = >cgroup_files[4];
+ cft = >cgroup_files[HUGETLB_RES_NULL];
memset(cft, 0, sizeof(*cft));
WARN_ON(cgroup_add_legacy_cftypes(_cgrp_subsys,
--
2.23.0.162.g0b9fbb3734-goog
thanks,
-- Shuah
supported.
make kselftest
make -C tools/testing/selftests
O= and KBUILD_OUTPUT cases as well as running make directly
in the clode3 dir.
Please include test output and usage instructions if any to this
commit log as this is the patch that enables it in the default run.
thanks,
-- Shuah
),x86_64)
- TEST_GEN_PROGS := clone3 clone3_set_tid
-endif
+TEST_GEN_PROGS := clone3 clone3_set_tid
include ../lib.mk
This is fine. Where is the code to handle unsupported case?
thanks,
-- Shuah
t_print_msg("[%d] clone3() with flags says :%d expected %d\n",
+ ksft_print_msg("[%d] clone3() with flags says: %d expected %d\n",
getpid(), ret, expected);
if (ret != expected)
ksft_exit_fail_msg(
thanks,
-- Shuah
de);
ksft_print_msg("[%d] clone3() with flags says :%d expected %d\n",
thanks,
-- Shuah
0, -EINVAL,
+ CLONE3_ARGS_BIG_EXIT_SIGNAL))
+ goto on_error;
/*
* Do a clone3() with sizeof(struct clone_args) + 8
* and all members set to 0.
thanks,
-- Shuah
,
-- Shuah
, IPPROTO_UDP, 0,1 },
What failure are you seeing? It sounds arbitrary to use INT_MAX
instead of AF_MAX. I think it is important to understand the
failure first.
Please note that AF_MAX is widely used in the kernel.
thanks,
-- Shuah
On 9/16/19 7:57 AM, Eugeniu Rosca wrote:
Hi Shuah,
CC George
On Mon, Sep 16, 2019 at 07:26:41AM -0600, shuah wrote:
[..]
case 'f':
/* Handled above */
break;
+ case 'i
vhci_finish_attr_group();
return err;
}
Looks good to me.
Acked-by: Shuah Khan
thanks,
-- Shuah
doesn't work
very well.
No worries I will handle this in my pull request.
thanks,
-- Shuah
On 9/16/19 6:08 AM, Eugeniu Rosca wrote:
Hi Shuah,
On Sat, Sep 07, 2019 at 10:58:32AM +0200, Eugeniu Rosca wrote:
From: "George G. Davis"
As reported by Eugeniu Rosca, the newly added optional file
argument does not validate if the file is indeed a watchdog, e.g.:
./watchdog-tes
tion to
show the watchdog_info.
Suggested-by: Eugeniu Rosca
Signed-off-by: George G. Davis
Signed-off-by: Eugeniu Rosca
---
v1: Applied/tested on commit ce54eab71e210f ("kunit: fix failure to build without
printk") of
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-ks
GETSUPPORT ioctl succeeds.
Reported-by: Eugeniu Rosca
Signed-off-by: George G. Davis
Signed-off-by: Eugeniu Rosca
---
v1: Applied/tested on commit ce54eab71e210f ("kunit: fix failure to build without
printk") of
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kself
iled\n");
vhci_finish_attr_group();
return err;
}
Why not include err information in the message. Helps figure out why
it failed.
thanks,
-- Shuah
On 9/15/19 1:25 PM, Helen Koike wrote:
Hi Shuah,
Thanks for the patch.
On 9/6/19 11:42 PM, Shuah Khan wrote:
vimc uses Component API to split the driver into functional components.
The real hardware resembles a monolith structure than component and
component structure added a level
On 9/15/19 1:25 PM, Helen Koike wrote:
Hi Shuah,
On 9/6/19 11:42 PM, Shuah Khan wrote:
Move duplicated IS_SRC and IS_SINK dfines to common header. Rename
them to VIMC_IS_SRC and VIM_IS_SINK.
Signed-off-by: Shuah Khan
---
drivers/media/platform/vimc/vimc-common.h | 4
drivers/media
quot;");
textdomain(PACKAGE);
thanks,
-- Shuah
vimc driver is now a monolithic driver. Update the module parameter
usage information to reflect that.
Signed-off-by: Shuah Khan
---
Documentation/media/v4l-drivers/vimc.rst | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/media/v4l-drivers/vimc.rst
lcolor=yellow]
n0013 [label="{{} | RGB/YUV Input\n/dev/v4l-subdev4 | {
0}}", shape=Mrecord, style=filled, fillcolor=green]
n0013:port0 -> n0015:port0 [style=dashed]
n0015 [label="{{ 0} | Scaler\n/dev/v4l-subdev5 | {
1}}", shape=Mrecord, style=fil
:0[fmt:SBGGR8_1X8/640x480]'
v4l2-ctl -z platform:vimc -d "RGB/YUV Capture" -v width=1920,height=1440
v4l2-ctl -z platform:vimc -d "Raw Capture 0" -v pixelformat=BA81
v4l2-ctl -z platform:vimc -d "Raw Capture 1" -v pixelformat=BA81
v4l2-ctl --stream-mmap --stream-count
After practically re-writing the driver to collpase it into a monolith,
I am adding myself as a reviewer for vimc driver.
Signed-off-by: Shuah Khan
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7c62b45201d7..4529d257f8db 100644
Move duplicated IS_SRC and IS_SINK dfines to common header. Rename
them to VIMC_IS_SRC and VIM_IS_SINK.
Signed-off-by: Shuah Khan
---
drivers/media/platform/vimc/vimc-common.h | 4
drivers/media/platform/vimc/vimc-debayer.c | 11 ---
drivers/media/platform/vimc/vimc-scaler.c
kernel: [ 4136.716010] entry_SYSCALL_64_after_hwframe+0x4
Signed-off-by: Shuah Khan
---
drivers/media/platform/vimc/vimc-common.c | 3 +--
drivers/media/platform/vimc/vimc-debayer.c | 1 +
drivers/media/platform/vimc/vimc-scaler.c | 1 +
drivers/media/platform/vimc/vimc-sensor.c | 1 +
4 files chan
Tested-by: Brendan Higgins
Thanks!
Thanks Brendan! I will apply the patch for 5.4-rc1.
SeongJae Park! In the future, please send tag versions. This should
have been [PATCH v2].
thanks,
-- Shuah
On 9/6/19 10:02 AM, Arnd Bergmann wrote:
On Fri, Sep 6, 2019 at 5:39 PM Shuah Khan wrote:
config KUNIT
bool "Enable support for unit tests (KUnit)"
+ depends on PRINTK
help
Enables support for kernel unit tests (KUnit), a lightweight unit
On 9/6/19 6:05 AM, SeongJae Park wrote:
kunit fails to run with '--build_dir' option because the option is not
properly sent to kernel running procedure. This commit fixes the
problem.
Can you please include the failure you are seeing in the commit log
thanks,
-- Shuah
s is found and fixed already. I am just about to apply Berndan's
patch that fixes this dependency. All of this vprintk_emit() stuff
is redone.
thanks,
-- Shuah
Hi Rafael,
Please pull the following update for Linux 5.4-rc1 or 5.4-rc2 depending
on your pull request schedule for Linus.
This cpupower update for Linux 5.4-rc1 consists of bug fixes and
German translation updates from Benjamin Weis.
diff is attached.
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.2.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.14.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.9.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
xpected
Thanks. I fixed the one in the commit log. I will fix this one as well.
thanks,
-- Shuah
:
```
You should pass
those arguments to each subdevice, not to the vimc module. For example::
vimc_subdevice.param=value
```
(no inline comments)
Thanks Dafna. Yes Documentation needs updates for other reasons and
the module params is on my list as well to fix.
thanks,
-- Shuah
scussion. It helped me clarify my understanding of
the printk.
thanks,
-- Shuah
On 8/30/19 3:31 PM, Steven Rostedt wrote:
On Sat, 3 Aug 2019 09:01:26 +0900
Masanari Iida wrote:
This patch fixes a spelling typo in tigger-snapshot.tc
As Randy said: "trigger-snapshot.tc"
Shuah, can you take this?
Acked-by: Steven Rostedt (VMware)
Done. Applied wit
On 8/30/19 10:13 AM, George G. Davis wrote:
On Fri, Aug 30, 2019 at 09:12:10AM -0600, shuah wrote:
On 8/30/19 6:53 AM, George G. Davis wrote:
diff --git a/tools/testing/selftests/watchdog/watchdog-test.c
b/tools/testing/selftests/watchdog/watchdog-test.c
@@ -69,6 +70,7 @@ static void term(int
On 8/29/19 6:45 PM, shuah wrote:
On 8/29/19 11:06 AM, Kees Cook wrote:
On Mon, Aug 26, 2019 at 08:43:02AM -0600, Tycho Andersen wrote:
The seccomp selftest goes to some length to build against older kernel
headers, viz. all the #ifdefs at the beginning of the file. 201766a20e30
("ptrace
Open watchdog device file (default is
/dev/watchdog)\n");
Can you split this line into two printf's. Checkpatch doesn't like
it.
printf(" -f, --file Open watchdog device file\n");
A second one below for default.
On a separate note, I wish this usage block uses \t instead of spacing
things out.
thanks,
-- Shuah
On 8/30/19 8:09 AM, shuah wrote:
On 8/22/19 3:58 PM, Alakesh Haloi wrote:
Without this patch we see following error while building and kselftest
for secccomp_bpf fails.
seccomp_bpf.c:1787:20: error: ‘PTRACE_EVENTMSG_SYSCALL_ENTRY’
undeclared (first use in this function);
seccomp_bpf.c:1788:6
.4-rc1. Or is this going through bpf tree?
If it is going through bpf tree:
Acked-by: Shuah Khan
thanks,
-- Shuah
-by: Tycho Andersen
Fixes: 201766a20e30 ("ptrace: add PTRACE_GET_SYSCALL_INFO request")
Acked-by: Kees Cook
Alakesh Haloi also sent a fix[1] for this. I prefer Tycho's solution
(one #ifndef and a Fixes line). Shuah, can you please apply this?
Kees,
Yes I will pick this up.
thanks,
-- Shuah
# %s: " fmt, (test)->name, ##__VA_ARGS__)
Is there supposed to be pr_level() - I can find dev_level()
cc'ing Joe Perches for his feedback on this message recommending
pr_level() which isn't in 5.3.
thanks,
-- Shuah
thanks,
-- Shuah
SDEV_EVENT_ERROR_MALLOC);
- return -1;
+ goto err_iso_buffer;
}
- iov[2].iov_base = iso_buffer;
- iov[2].iov_len = len;
+ iov[iovnum].iov_base = iso_buffer;
+ iov[iovnum].iov_len = len;
+ iovnum++;
txsize += len;
}
- ret = kernel_sendmsg(vdev->ud.tcp_socket, , iov, 3, txsize);
+ ret = kernel_sendmsg(vdev->ud.tcp_socket, , iov, iovnum,
+txsize);
if (ret != txsize) {
pr_err("sendmsg failed!, ret=%d for %zd\n", ret,
txsize);
- kfree(iso_buffer);
usbip_event_add(>ud, VDEV_EVENT_ERROR_TCP);
- return -1;
+ err = -EPIPE;
+ goto err_tx;
}
+ kfree(iov);
kfree(iso_buffer);
usbip_dbg_vhci_tx("send txdata\n");
@@ -119,6 +154,13 @@ static int vhci_send_cmd_submit(struct vhci_device *vdev)
}
return total_size;
+
+err_tx:
+ kfree(iso_buffer);
+err_iso_buffer:
+ kfree(iov);
+
+ return err;
}
static struct vhci_unlink *dequeue_from_unlink_tx(struct vhci_device *vdev)
Looks good from usbip perspective.
Christoph! Are your concerns addressed? If so Greg! please
take this.
Acked-by: Shuah khan
thanks,
-- Shuah
with an
appended signature and updates the existing test messages
appropriately.
Reviewed-by: Petr Vorel
Signed-off-by: Mimi Zohar
---
Thanks Mimi. This commit log looks good. My Ack for the patch
to go through the IMA tree.
Acked-by: Shuah Khan
thanks,
-- Shuah
1 ] && [ $ima_signed -eq 0 ]; then
+ if [ $ima_sig_required -eq 1 ] && [ $ima_signed -eq 0 ] \
+&& [ $ima_modsig -eq 0 ]; then
log_fail "$succeed_msg (missing IMA sig)"
fi
@@ -204,5 +231,8 @@ pe_signed=$?
check_for_imasig
ima_signed=$?
+check_for_modsig
+ima_modsig=$?
+
# Test loading the kernel image via kexec_file_load syscall
kexec_file_load_test
thanks,
-- Shuah
On 8/27/19 4:16 PM, Brendan Higgins wrote:
On Tue, Aug 27, 2019 at 3:00 PM shuah wrote:
On 8/27/19 3:36 PM, Brendan Higgins wrote:
On Tue, Aug 27, 2019 at 2:09 PM Brendan Higgins
wrote:
On Tue, Aug 27, 2019 at 2:03 PM Brendan Higgins
wrote:
On Tue, Aug 27, 2019 at 1:21 PM shuah wrote
901 - 1000 of 8581 matches
Mail list logo
