RE: [patch] Revert "block: remove artifical max_hw_sectors cap"

2015-07-29 Thread Elliott, Robert (Server Storage)
hat.com Adding linux-scsi... > Subject: Re: [patch] Revert "block: remove artifical max_hw_sectors cap" > > Christoph Hellwig writes: > > > On Mon, Jul 20, 2015 at 03:17:07PM -0400, Jeff Moyer wrote: > >> For SAN storage, we've seen initial write and

RE: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-23 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Spencer Baugh > Sent: Thursday, July 23, 2015 5:28 PM > To: Christoph Hellwig ; Spencer Baugh > ... > Subject: Re: [PATCH] target: add support for START_STOP_UNIT S

RE: [PATCH] x86/mm/pat: Do a small optimization when dump PAT memtype list

2015-07-23 Thread Elliott, Robert (Server Storage)
kfree(seq->private); > } > Consider adding seq->private = NULL; so the stale pointer isn't left around. There's probably not much risk of accessing it, but NULL is safer in case it is. --- Robert Elliott, HP Server Storage N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�&j:+v���zZ+��+zf���h���~i���z��w���?�&�)ߢf��^jǫy�m��@A�a��� 0��h���i

RE: [PATCH] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-07-22 Thread Elliott, Robert (Server Storage)
EXPORT_SYMBOL(iscsit_increment_maxcmdsn); If there is another change before the atomic_read, this would print a value unrelated to the increment done by this thread. atomic_inc_return would provide the appropriate value to print. --- Robert Elliott, HP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [PATCH V4] x86/mm/pat: Do a small optimization and fix in reserve_memtype

2015-07-22 Thread Elliott, Robert (Server Storage)
--- Robert Elliott, HP Server Storage > -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Pan Xinhui > Sent: Wednesday, July 22, 2015 8:27 AM ... > diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c

RE: [PATCH] cciss: update copyright

2015-06-25 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Don Brace [mailto:don.br...@pmcs.com] > Sent: Thursday, June 25, 2015 7:48 PM > To: gerry.mor...@pmcs.com; ax...@kernel.uk; storage...@pmcs.com; ISS > StorageDev; scott.ben...@pmcs.com > Cc: linux-kernel@vger.kernel.org > Subject:

RE: [PATCH v2 0/3] Add NUMA support for NVDIMM devices

2015-06-10 Thread Elliott, Robert (Server Storage)
ferred block:pmem1 --cpunodebind block:pmem1 fio on-pmem0> > > > > Did you post the patches to numactl somewhere? > > > > numactl already supports this today. numactl does have a bug handling partitions under these devices, because it assumes all storage devices have &quo

RE: [PATCH 1/2] scatterlist: use sg_phys()

2015-06-09 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Dan Williams > Sent: Tuesday, June 09, 2015 10:27 AM > Subject: [PATCH 1/2] scatterlist: use sg_phys() > ... > diff --git a/arch/microblaze/kernel/dma.c b/arch/micr

RE: [PATCH v4 4/9] dax: fix mapping lifetime handling, convert to __pfn_t + kmap_atomic_pfn_t()

2015-06-08 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf > Of Dan Williams > Sent: Friday, June 05, 2015 3:19 PM > Subject: [PATCH v4 4/9] dax: fix mapping lifetime handling, convert to > __pfn_t + kmap_atomic_pfn_t() ... > diff --git a/arch/powerpc/sys

RE: [PATCH v10 12/12] drivers/block/pmem: Map NVDIMM with ioremap_wt()

2015-05-29 Thread Elliott, Robert (Server Storage)
--- Robert Elliott, HP Server Storage > -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > Sent: Friday, May 29, 2015 4:46 PM > To: Elliott, Robert (Server Storage) > Cc: Dan Williams; Kani, Toshimitsu; Borislav Petkov; Ross Zwisler; > H. P

RE: [PATCH v10 12/12] drivers/block/pmem: Map NVDIMM with ioremap_wt()

2015-05-29 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > Sent: Friday, May 29, 2015 1:35 PM ... > Whoa, there! Why would we use non-temporal stores to WB memory to > access persistent memory? I can see two reasons not to: Data written to a block stora

RE: [PATCH v3 20/21] nfit-test: manufactured NFITs for interface development

2015-05-25 Thread Elliott, Robert (Server Storage)
can just comment out the lines related to ioremap_wt. --- Rob Elliott, HP Server Storage 0001-pmem-cache-type Description: 0001-pmem-cache-type

RE: [PATCH v3 18/21] nd_btt: atomic sector updates

2015-05-22 Thread Elliott, Robert (Server Storage)
on Table (atomic sector updates)" > + depends on LIBND > + default LIBND > + select ND_BTT_DEVS The ND_BTT option, which is presented during a kernel build, is missing help text. So is E820_PMEM in patch 3/21. --- Robert Elliott, HP Server Storage -- To unsubscribe from t

RE: [PATCH v3 14/21] libnd: blk labels and namespace instantiation

2015-05-22 Thread Elliott, Robert (Server Storage)
urns NULL, it *doesn't* free the original. So any code of the form 'foo = krealloc(foo, …);' is almost certainly a bug." --- Robert Elliott, HP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [Linux-nvdimm] [PATCH v2 19/20] nd_btt: atomic sector updates

2015-05-20 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: dan.j.willi...@gmail.com [mailto:dan.j.willi...@gmail.com] On > Behalf Of Dan Williams > Sent: Saturday, May 16, 2015 10:22 PM > To: Elliott, Robert (Server Storage) > Cc: linux-nvd...@lists.01.org; Neil Brown; Greg KH; Dave Chi

RE: [Linux-nvdimm] [PATCH v2 07/20] libnd, nd_dimm: dimm driver and base libnd device-driver infrastructure

2015-05-20 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf > Of Dan Williams > Sent: Tuesday, April 28, 2015 1:25 PM > To: linux-nvd...@lists.01.org > Cc: Neil Brown; Greg KH; linux-kernel@vger.kernel.org > Subject: [Linux-nvdimm] [PATCH v2 07/20] libnd

RE: [Linux-nvdimm] [PATCH v2 19/20] nd_btt: atomic sector updates

2015-05-16 Thread Elliott, Robert (Server Storage)
ty 0.52% [kernel] [k] __wake_up_bit 0.52% [kernel] [k] __clear_user --- Robert Elliott, HP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [Linux-nvdimm] [PATCH v2 18/20] libnd: infrastructure for btt devices

2015-05-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf > Of Dan Williams > Sent: Thursday, May 14, 2015 7:42 PM > To: Kani, Toshimitsu > Cc: Neil Brown; Greg KH; linux-kernel@vger.kernel.org; linux- > nvd...@lists.01.org > Subject: Re: [Linux-nvdimm]

RE: [PATCH v5 1/6] x86/mm/pat: use pr_info() and friends

2015-05-06 Thread Elliott, Robert (Server Storage)
> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Luis R. Rodriguez > Sent: Thursday, April 30, 2015 3:25 PM > Subject: [PATCH v5 1/6] x86/mm/pat: use pr_info() and friends > ... > - printk(KERN_ERR "%s:%d map pfn expected ma

RE: [PATCH 0/13] Parallel struct page initialisation v4

2015-05-02 Thread Elliott, Robert (Server Storage)
(10.259 M) WC write iops=10286000 (10286 K)(10.286 M) WT write iops=10294000 (10294 K)(10.294 M) --- Robert Elliott, HP Server Storage N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�&j:+v���zZ+��+zf���h���~i���z��w���?�&�)ߢf��^jǫy�m��@A�a��� 0��h���i

RE: [Linux-nvdimm] [PATCH v2 08/20] libnd, nd_acpi: regions (block-data-window, persistent memory, volatile memory)

2015-04-29 Thread Elliott, Robert (Server Storage)
nd_mapping->nd_dimm; > + > + get_device(&nd_dimm->dev); > + } > + nd_region->ndr_mappings = ndr_desc->num_mappings; > + nd_region->provider_data = ndr_desc->provider_data; > + dev = &nd_region->dev; > + dev_set_na

RE: [Linux-nvdimm] [PATCH v2 00/20] libnd: non-volatile memory device support

2015-04-28 Thread Elliott, Robert (Server Storage)
E_WORM (write once read many ... used for certain optical and tape drives). I'm not sure what nd and pmem are doing to result in that value. 2. To avoid confusing software trying to detect fast storage vs. slow storage devices via sysfs, this value should be 0: /sys/block/pmem0/queue/rotationa

RE: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices

2015-04-22 Thread Elliott, Robert (Server Storage)
functions with prototypes in nd.h, this is the only function that doesn't have a name starting with nd_. Following such a convention helps ease setting up ftrace filters. --- Robert Elliott, HP Server Storage -- To unsubscribe from this list: send the line "unsubscribe

RE: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem

2015-04-22 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of > Dan Williams > Sent: Friday, April 17, 2015 8:35 PM > To: linux-nvd...@lists.01.org > Subject: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem > ... > create mode 100644 dr

RE: [tip:x86/pmem] x86/mm: Add support for the non-standard protected e820 type

2015-04-16 Thread Elliott, Robert (Server Storage)
value was set aside on behalf of this pre-standard usage, to keep future ACPI revisions from standardizing it for anything else. The kernel should be just as safe in continuing to recognize that value as it is now. New legacy BIOS systems should follow ACPI 6.0 going forward and report type 7 in their E820 tables, along with meeting the other ACPI 6.0 requirements. UEFI systems don't provide an E820 table; that's an artificial creation by the bootloader (e.g., grub2) or the kernel with its add_efi_memmmap parameter. These systems will just report the EFI memory type 14. There was no pre-standard EFI type identified that needed to be blocked out. Any software creating a fake E820 table (grub2, etc.) should map EFI type 14 to E820 type 7. --- Robert Elliott, HP Server Storage

RE: [Linux-nvdimm] [GIT PULL] PMEM driver for v4.1

2015-04-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Dan Williams [mailto:dan.j.willi...@intel.com] > Sent: Tuesday, April 14, 2015 11:34 AM > To: Elliott, Robert (Server Storage) > > ... > >> Since it's directly mapped it should just work for most things if it's > >>

RE: [Linux-nvdimm] [GIT PULL] PMEM driver for v4.1

2015-04-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf > Of Ingo Molnar > Sent: Tuesday, April 14, 2015 7:42 AM > To: Christoph Hellwig > Subject: Re: [Linux-nvdimm] [GIT PULL] PMEM driver for v4.1 > > ... > Since it's directly mapped it should ju

pmem and i_dio_count overhead

2015-04-03 Thread Elliott, Robert (Server Storage)
here is some other test environment inconsistency with WT writes - I don't think this change really helped by 76%) --- Robert Elliott, HP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

RE: another pmem variant V2

2015-04-02 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Wednesday, April 1, 2015 2:26 AM > To: Elliott, Robert (Server Storage) > Cc: Christoph Hellwig; linux-nvd...@ml01.01.org; linux- > fsde...@vger.kernel.org; linux-kernel@vger.kernel.or

RE: another pmem variant V2

2015-04-01 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Thursday, March 26, 2015 3:33 AM > To: linux-nvd...@ml01.01.org; linux-fsde...@vger.kernel.org; linux- > ker...@vger.kernel.org; x...@kernel.

RE: another pmem variant V2

2015-03-31 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Thursday, March 26, 2015 3:33 AM > To: linux-nvd...@ml01.01.org; linux-fsde...@vger.kernel.org; linux- > ker...@vger.kernel.org; x...@kerne

RE: [PATCH 2/3] x86: add a is_e820_ram() helper

2015-03-26 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Thursday, March 26, 2015 11:43 AM > To: Boaz Harrosh > Cc: Christoph Hellwig; Ingo Molnar; linux-nvd...@ml01.01.org; linux- > fsde...@vger.

RE: [PATCH 1/8] pmem: Initial version of persistent memory driver

2015-03-25 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Andy Lutomirski > Sent: Wednesday, March 18, 2015 1:07 PM > To: Boaz Harrosh > Cc: Matthew Wilcox; Ross Zwisler; X86 ML; Thomas Gleixner; Dan Williams; > Ingo Molnar

RE: [PATCH 3/3] x86: add support for the non-standard protected e820 type

2015-03-25 Thread Elliott, Robert (Server Storage)
s and ADR protected memory" stanard s/b standard > + help > + Treat memory marked using the non-stard e820 type of 12 as used stard s/b standard > + by the Intel Sandy Bridge-EP reference BIOS as protected memory. > + The kernel will the offer these regio

RE: [PATCH] [RESEND] aic7xxx: replace kmalloc/memset by kzalloc

2015-03-24 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Tuesday, March 24, 2015 3:57 PM > To: Michael Opdenacker > Cc: Hannes Reinecke; jbottom...@parallels.com; Elliott, Robert (Server > Storage); linux-s...@vger.kernel.org; linux-kernel@vger.kernel

RE: [RESEND] [PATCH] block: create ioctl to discard-or-zeroout a range of blocks

2015-01-29 Thread Elliott, Robert (Server Storage)
; is to enable the zeroing discard part -- without it, the call invokes > > the old BLKZEROOUT behavior. start and length have the same meaning > > as in BLKZEROOUT. > > > > Furthermore, because BLKZEROOUT2 issues commands directly to the > > storage device, we must invalid

RE: [PATCH v3 1/2] x86: Add support for the pcommit instruction

2015-01-28 Thread Elliott, Robert (Server Storage)
EXIT_REASON_PCOMMIT 64 to arch/x86/include/uapi/asm/vmx.h and (with a VMX_EXIT_REASONS string) to usr/include/asm/vmx.h. 3. Add a kvm_vmx_exit_handler to arch/x86/kvm/vmx.c. --- Rob ElliottHP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

RE: [PATCH 09/22] [SCSI] mpt2sas, mpt3sas: Added a support to set cpu affinity for each MSIX vector enabled by the HBA

2014-12-10 Thread Elliott, Robert (Server Storage)
n just reported with lpfc on a system with a huge number (6144) of CPUs. See this thread: [BUG] kzalloc overflow in lpfc driver on 6k core system --- Rob ElliottHP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a me

RE: [BUG] kzalloc overflow in lpfc driver on 6k core system

2014-12-02 Thread Elliott, Robert (Server Storage)
;intr[i], get_cpu_mask(cpu)); cpu = cpumask_next(cpu, cpu_online_mask); } get_cpu_mask() uses the global cpu_bit_bitmap array, which is declared in kernel/cpu.c: extern const unsigned long cpu_bit_bitmap[BITS_PER_LONG+1][BITS_TO_LONGS(NR_CPUS)]; That approach shou

RE: [PATCH RESEND v8] iopoll: Introduce memory-mapped IO polling macros

2014-11-24 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Mitchel Humpherys [mailto:mitch...@codeaurora.org] > Sent: Monday, November 24, 2014 7:21 PM > To: Elliott, Robert (Server Storage) ... > > The hpsa SCSI driver used to use usleep_range in a loop like > > that, but we found that it c

RE: [PATCH RESEND v8] iopoll: Introduce memory-mapped IO polling macros

2014-11-24 Thread Elliott, Robert (Server Storage)
ed to use usleep_range in a loop like that, but we found that it caused scheduler problems during boots because it uses TASK_UNINTERRUPTIBLE: [9.260668] [sched_delayed] sched: RT throttling activated msleep() worked much better. --- Rob ElliottHP Server Storage -- To unsub

RE: [PATCH 06/10] libata: use __scsi_format_command()

2014-11-14 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, 06 November, 2014 2:31 AM > To: James Bottomley > Cc: Christoph Hellwig; Ewan Milne; Elliott, Robert (Server Storage); > linux-s...@vger.kernel.org; Hannes Reinecke; linux- > i...@

RE: BUG in scsi_lib.c due to a bad commit

2014-11-12 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Barto > Sent: Wednesday, November 12, 2014 9:28 PM > To: Guenter Roeck; Bjorn Helgaas > Cc: linux-kernel@vger.kernel.org; linux-s...@vger.kernel.org; Joe > Perches >

RE: absurdly high "optimal_io_size" on Seagate SAS disk

2014-11-07 Thread Elliott, Robert (Server Storage)
M TRANSFER LENGTH field indicates the maximum transfer size for one command over the SCSI transport protocol supported by the drive itself It is risky to use transfer sizes larger than linux and Windows can generate, since drives are probably tested in those environments. --- Rob Elliott

RE: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-04 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Boaz Harrosh [mailto:b...@plexistor.com] > Sent: Tuesday, 04 November, 2014 4:38 AM > To: Wilcox, Matthew R; Elliott, Robert (Server Storage); Ross > Zwisler; Jens Axboe; Nick Piggin; Kani, Toshimitsu; Knippers, Linda; > linux-fsde...@vger

RE: [PATCH v4 4/7] x86, mm, pat: Add pgprot_writethrough() for WT

2014-11-03 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > Sent: Monday, November 03, 2014 5:01 PM > To: Thomas Gleixner > Cc: Kani, Toshimitsu; Elliott, Robert (Server Storage); h...@zytor.com; > mi...@redhat.com; a...@linux-foundation.org; a...@ar

RE: [PATCH v4 4/7] x86, mm, pat: Add pgprot_writethrough() for WT

2014-11-03 Thread Elliott, Robert (Server Storage)
ide more flexibility for modules to utilize the new feature? In x86/mm, 18 of 60 current exports are GPL and 42 are not GPL. --- Rob ElliottHP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

RE: [PATCH 2/4] pmem: Add support for getgeo()

2014-11-01 Thread Elliott, Robert (Server Storage)
ector) => void* > * We do not require that sector be page aligned. > @@ -176,6 +185,7 @@ out: > > static const struct block_device_operations pmem_fops = { > .owner =THIS_MODULE, > + .getgeo = pmem_getgeo, > }; > > /* Kernel module stuff */

RE: [PATCH 1/4] pmem: Initial version of persistent memory driver

2014-11-01 Thread Elliott, Robert (Server Storage)
*pmem, struct page > *page, > + unsigned int len, unsigned int off, int rw, > + sector_t sector) > +{ > + void *mem = kmap_atomic(page); > + > + if (rw == READ) { > + copy_from_pmem(mem + off, pmem, sector, len); >

RE: [PATCH] MAINTAINERS: remove list iss_storage...@hp.com

2014-10-30 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Thursday, October 30, 2014 3:29 AM > To: Sudip Mukherjee > Cc: Andrew Morton; Greg Kroah-Hartman; linux-kernel@vger.kernel.org; Don > Brace; Elliott, Robert (Server Storage) >

RE: [PATCH 1/1 linux-next] hpsa: remove set but unused variable rc

2014-10-29 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Sudip Mukherjee > Sent: Thursday, October 30, 2014 12:55 AM > To: Fabian Frederick > Cc: linux-kernel@vger.kernel.org; Stephen M. Cameron; James E.J. > Bottomley; iss_st

RE: [PATCH] aic7xxx: replace kmalloc/memset by kzalloc

2014-10-16 Thread Elliott, Robert (Server Storage)
." BUILD_BUG_ON could be used to trigger a compile-time error, instead of building a kernel that returns a run-time error. --- Rob ElliottHP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord

RE: Locking issues with cpufreq and sysfs

2014-10-14 Thread Elliott, Robert (Server Storage)
frequency transitions > and a new lock, perhaps called policy->lock, to serialize all events. > Please keep performance in mind too. cpufreq_governor_lock contention is a bit of an issue with heavy IO workloads as described in: http://marc.info/?l=linux-pm&m=140924051503827&w=2 --- Rob ElliottHP Server Storage N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�&j:+v���zZ+��+zf���h���~i���z��w���?�&�)ߢf��^jǫy�m��@A�a��� 0��h���i

RE: [PATCH 4/7 linux-next] cpqarray: remove deprecated IRQF_DISABLED

2014-10-06 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Fabian Frederick [mailto:f...@skynet.be] > Sent: Monday, October 06, 2014 10:36 AM > To: linux-kernel@vger.kernel.org > Cc: Greg Kroah-Hartman; Fabian Frederick; ISS StorageDev > Subject: [PATCH 4/7 linux-next] cpqarray: remove deprecated > IRQF_DISABLED > > S

RE: [PATCH] scsi_debug: deadlock between completions and surprise module removal

2014-10-03 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Thursday, 25 September, 2014 7:13 AM > To: Douglas Gilbert > Cc: SCSI development list; linux-kernel; James Bottomley; Christoph Hellwig; > Mil

RE: [PATCH] block: disable entropy contributions from nonrot devices

2014-10-02 Thread Elliott, Robert (Server Storage)
rity perspective it is better to err on the side of > caution than to allow entropy contributions from unreliable "random" > sources. blk-mq defaults to off (QUEUE_FLAG_MQ_DEFAULT does not include QUEUE_FLAG_ADD_RANDOM). Even when it's off in block layer completion processing, all int

RE: [PATCH] MAINTAINERS: remove iss_storage...@hp.com list

2014-10-02 Thread Elliott, Robert (Server Storage)
d; I just tested it from my gmail account. In fact, that's the only working email address of all of those listed. Chirag, Stephen, and Mike are no longer at HP. I'll prod PMC-Sierra to send an update to MAINTAINERS. --- Rob ElliottHP Server Storage -- To unsubscribe from this

RE: [PATCH] MAINTAINERS: fix Mike Miller's e-mail address

2014-10-02 Thread Elliott, Robert (Server Storage)
ill here but the email accounts are not monitored. PMC-Sierra (copying Scott Benesh) will be picking up maintenance of hpsa and maybe cciss. cpqarray should probably be marked unmaintained or removed from the kernel. --- Rob ElliottHP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [PATCH] block: remove artifical max_hw_sectors cap

2014-10-01 Thread Elliott, Robert (Server Storage)
which is expected. Something else is still limiting I/O sizes to 1 MiB, though; probably bio_get_nr_vecs enforcing a maximum size per bio of BIO_MAX_PAGES 256 (which is 1 MiB with 4 KiB pages). Otherwise, Reviewed-by: Robert Elliott Tested-by: Robert Elliott --- Rob ElliottHP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: ftrace function-graph and interprocessor interrupts

2014-09-25 Thread Elliott, Robert (Server Storage)
n() { 10) 0.069 us|scsi_handle_queue_ramp_up(); 10) 0.693 us| } /* scsi_decide_disposition */ 10) 0.062 us| scsi_log_completion(); 10) | s

RE: [PATCH RESEND v3 5/6] AHCI: Optimize single IRQ interrupt processing

2014-09-24 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Tejun Heo ... > The thing I don't get is why multiple MSI handling and this patchset > are tied to threaded interrupt handling. Splitting locks don't > necessarily ha

RE: ftrace function-graph and interprocessor interrupts

2014-09-24 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Andi Kleen [mailto:a...@firstfloor.org] > Sent: Wednesday, 24 September, 2014 4:50 PM > To: Elliott, Robert (Server Storage) > Cc: Steven Rostedt; linux-kernel@vger.kernel.org; Jens Axboe > (ax...@kernel.dk); Christoph Hellwig > Subject

ftrace function-graph and interprocessor interrupts

2014-09-24 Thread Elliott, Robert (Server Storage)
generic_smp_call_function_single_interrupt. blk-mq calls smp_call_function_single_async directly, which can result in generic_smp_call_function_single_interrupt on the local CPU, and that call chain shouldn't be treated as being in a new interrupt context. When this happens, it is already in a interupt context

RE: boot stall regression due to blk-mq: use percpu_ref for mq usage count

2014-09-23 Thread Elliott, Robert (Server Storage)
dmit "This document may not be entirely up to date and comprehensive."). Perhaps a description with an "experimental" warning could be slipped into scsi-parameters.txt in 3.17, with plans to remove that warning in 3.18. --- Rob ElliottHP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [patch 22/26] x86: Add proper vector accounting for HyperV

2014-09-22 Thread Elliott, Robert (Server Storage)
allback_count); > + seq_printf(p, " Hypervisor callback interrupts\n"); > +#endif ... Should this have used a different short string than "THR", which is already used for "Threshold APIC interrupts"? --- Rob ElliottHP Server Storage -- To unsubscr

RE: [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only)

2014-09-22 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Friday, 19 September, 2014 6:22 AM > To: Elliott, Robert (Server Storage) > Cc: Andreas Dilger; Milosz Tanski; linux-kernel@vger.kernel.org; Christoph > Hellwig; linux-fsde...@vger

RE: blk-mq timeout handling fixes

2014-09-17 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Saturday, 13 September, 2014 6:40 PM > To: Jens Axboe > Cc: Elliott, Robert (Server Storage); linux-s...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: blk-mq timeout handling f

RE: [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only)

2014-09-15 Thread Elliott, Robert (Server Storage)
s for SCSI (where are related to, but not necessarily tied to, atomic writes). We discussed them a bit at LSF-MM 2013 - see http://lwn.net/Articles/548116/. --- Rob ElliottHP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

RE: [PATCH] scsi: scsi_devinfo.c: Cleaning up unnecessarily complicated in conjunction with strncpy

2014-09-14 Thread Elliott, Robert (Server Storage)
haracters > and a warning is printed. > > Is not it exactly the functionality that is desired? Ah, I see that in man 3 strcpy: "If the length of src is less than n, strncpy() pads the remainder of dest with null bytes." I agree that should work. --- Rob ElliottHP Server Storage

RE: [PATCH] scsi: scsi_devinfo.c: Cleaning up unnecessarily complicated in conjunction with strncpy

2014-09-14 Thread Elliott, Robert (Server Storage)
uot;, > __func__, name, from); > + } The caller of this function, scsi_dev_info_list_add_keyed, created the "to" destination buffer, devinfo, with kmalloc, so it's not guaranteed to be full of zeros. If from_length is shorter than to_length, then this

RE: [PATCH 1/2] block: default to rq_affinity=2 for blk-mq

2014-09-10 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Jens Axboe [mailto:ax...@kernel.dk] > Sent: Wednesday, 10 September, 2014 1:15 PM > To: Robert Elliott; Elliott, Robert (Server Storage); h...@lst.de; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/2] block: default to rq_affinity=2

RE: [PATCH 0/6] blk-mq: initialize pdu of flush req explicitly

2014-09-08 Thread Elliott, Robert (Server Storage)
w_queues; i++) { int node = blk_mq_hw_queue_to_node(map, i); hctxs[i] = kzalloc_node(sizeof(struct blk_mq_hw_ctx), GFP_KERNEL, node); Per-hctx flush requests would mean following the hctxs[i] approach. --- Rob ElliottHP Server Storage

RE: [PATCH v2 4/6] block: loop: say goodby to bio

2014-08-30 Thread Elliott, Robert (Server Storage)
if (bio->bi_rw & REQ_DISCARD) { > + if (rq->cmd_flags & REQ_DISCARD) { > struct file *file = lo->lo_backing_file; > int mode = FALLOC_FL_PUNCH_HOLE | > FALLOC_FL_KEEP_SIZE; Can a REQ_WRITE_SAME make it through to here? --

RE: [PATCH v2 3/6] block: loop: convert to blk-mq

2014-08-30 Thread Elliott, Robert (Server Storage)
tatic int loop_add(struct loop_device **l, int > i) > > out_free_queue: > blk_cleanup_queue(lo->lo_queue); > +out_cleanup_tags: > + blk_mq_free_tag_set(&lo->tag_set); Although lo is freed a few lines below, setting lo->tag_set to NULL would reduce the window in which

RE: Revert "aio: fix aio request leak when events are reaped by user space"

2014-08-25 Thread Elliott, Robert (Server Storage)
1f96: 41 8b 54 24 78 mov0x78(%r12),%edx 1f9b: 8d 34 12lea(%rdx,%rdx,1),%esi 1f9e: 39 f0 cmp%esi,%eax 1fa0: 73 e6 jae1f88 --- Rob ElliottHP Server Storage -- To unsubscribe from thi

RE: [PATCH] checkpatch: look for common misspellings

2014-08-22 Thread Elliott, Robert (Server Storage)
> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Joe Perches ... > +chang||change Although there are at least 2 misuses in the current kernel, that's also a fairly common name. -- To unsubscribe from this list: send the line "unsubscribe linux

RE: [RFC PATCH -logging 00/10] scsi/constants: Output continuous error messages on trace

2014-08-21 Thread Elliott, Robert (Server Storage)
h would lead to even more confusing output. --- Rob ElliottHP Server Storage

RE: [RFC PATCH 01/10] scsi/constants: Cleanup printk message in __scsi_print_sense()

2014-08-12 Thread Elliott, Robert (Server Storage)
arate call to printk just before each of those, which prints out the name, without []. sg.c: __scsi_print_sense(__func__, sense, That's printing the C function name. st.c:__scsi_print_sense(name, SRpnt->sense, SCSI_SENSE_BUFFERSIZE); st.c: __scs

RE: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread Elliott, Robert (Server Storage)
> From: James Bottomley [mailto:jbottom...@parallels.com] > > On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage) > wrote: ... > > > > Also, in both sd_setup_flush_cmnd and sd_sync_cache: > > cmd->cmnd[0] = SYNCHRONIZE_C

RE: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-17 Thread Elliott, Robert (Server Storage)
HP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-16 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of James Bottomley > Sent: Wednesday, 16 July, 2014 1:02 PM > To: martin.peter...@oracle.com > Cc: linux-kernel@vger.kernel.org; h...@infradead.org; > de...@linuxdriverproj

[PATCH] block: make blkdev_issue_flush check for NULL from bio_alloc

2014-07-14 Thread Elliott, Robert (Server Storage)
sk, 0); + if (!bio) + return -ENOMEM; bio->bi_bdev = bdev; ret = submit_bio_wait(WRITE_FLUSH, bio); --- Rob ElliottHP Server Storage

RE: scsi-mq V2

2014-07-13 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Elliott, Robert (Server Storage) > Sent: Saturday, July 12, 2014 6:20 PM > To: Benjamin LaHaise > Cc: Christoph Hellwig; Jeff Moyer; Jens Axboe; dgi

RE: [RESEND][PATCH 06/10][SCSI]mpt2sas: For >2TB volumes, DirectDrive support sends IO's with LBA bit 31 to IR FW instead of DirectDrive

2014-07-13 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Martin K. Petersen ... > Also, this is not touched by the patch, but you're then doing: > > (*(__be32 *)(&cdb_ptr[i])) = cpu_to_be32(p_lba); > > What if this

RE: scsi-mq V2

2014-07-12 Thread Elliott, Robert (Server Storage)
> I will see if that solves the problem with the scsi-mq-3 tree, or > at least some of the bisect trees leading up to it. scsi-mq-3 is still going after 45 minutes. I'll leave it running overnight. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

RE: scsi-mq V2

2014-07-12 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Benjamin LaHaise [mailto:b...@kvack.org] > Sent: Friday, 11 July, 2014 9:55 AM > To: Elliott, Robert (Server Storage) > Cc: Christoph Hellwig; Jeff Moyer; Jens Axboe; dgilb...@interlog.com; James > Bottomley; Bart Van Assche; linux-s...@vger

RE: mpt2sas stuck installing

2014-07-11 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Joe Lawrence ... > In your crash stack trace, the scsi error handler has issued a host > reset, but then crashed in mpt2sas_base_get_iocstate. Reading through > _scsih_

RE: scsi-mq V2

2014-07-11 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Friday, 11 July, 2014 1:15 AM > To: Elliott, Robert (Server Storage) > Cc: Jeff Moyer; Christoph Hellwig; Jens Axboe; dgilb...@interlog.com; James > Bottomley; Bart Van Assche; Benjami

RE: scsi-mq V2

2014-07-10 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Elliott, Robert (Server Storage) > > I added some prints in aio_setup_ring and ioctx_alloc and > rebooted. This time it took much longer to hi

RE: scsi-mq V2

2014-07-10 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Jeff Moyer [mailto:jmo...@redhat.com] > Sent: Thursday, 10 July, 2014 2:14 PM > To: Elliott, Robert (Server Storage) > Cc: Christoph Hellwig; Jens Axboe; dgilb...@interlog.com; James Bottomley; > Bart Van Assche; Benjamin LaHaise; linux-s.

RE: scsi-mq V2

2014-07-10 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Thursday, 10 July, 2014 11:15 AM > To: Elliott, Robert (Server Storage) > Cc: Jens Axboe; dgilb...@interlog.com; James Bottomley; Bart Van Assche; > Benjamin LaHaise; linux-s...@vger

RE: scsi-mq V2

2014-07-10 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Thursday, 10 July, 2014 1:21 AM > To: Elliott, Robert (Server Storage) > Cc: Jens Axboe; dgilb...@interlog.com; Christoph Hellwig; James Bottomley; > Bart Van Assche; Benjami

RE: scsi-mq V2

2014-07-10 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Jens Axboe [mailto:ax...@kernel.dk] > Sent: Thursday, 10 July, 2014 8:53 AM > To: Christoph Hellwig; Benjamin LaHaise > Cc: Elliott, Robert (Server Storage); dgilb...@interlog.com; James Bottomley; > Bart Van Assche; linux-s...@vger.kernel

RE: scsi-mq V2

2014-07-09 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Jens Axboe [mailto:ax...@kernel.dk] > Sent: Wednesday, 09 July, 2014 2:38 PM > To: dgilb...@interlog.com; Christoph Hellwig; James Bottomley; Bart Van > Assche; Elliott, Robert (Server Storage); linux-s...@vger.kernel.org; linux- > ker.

RE: [PATCH 03/14] scsi: centralize command re-queueing in scsi_dispatch_fn

2014-07-08 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Wednesday, 25 June, 2014 11:52 AM > To: James Bottomley > Cc: Jens Axboe; Bart Van Assche; Elliott, Robert (Server Storage); linux- > s...@vger.kernel.org; linux-kernel@vger.kernel.org >

RE: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

2014-07-04 Thread Elliott, Robert (Server Storage)
bhost_stats, NLMSG_ALIGN(actual_size)); nlhhost_stats->nlmsg_len = actual_size; err = iscsi_multicast_skb(skbhost_stats, ISCSI_NL_GRP_ISCSID, GFP_KERNEL); --- Rob ElliottHP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: scsi-mq V2

2014-06-26 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Jens Axboe [mailto:ax...@kernel.dk] > Sent: Wednesday, 25 June, 2014 11:51 PM > To: Christoph Hellwig; James Bottomley > Cc: Bart Van Assche; Elliott, Robert (Server Storage); linux- > s...@vger.kernel.org; linux-kernel@vger.kernel.org >

RE: [PATCH 10/14] scsi: only maintain target_blocked if the driver has a target queue limit

2014-06-21 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Thursday, 12 June, 2014 8:49 AM > To: James Bottomley > Cc: Jens Axboe; Bart Van Assche; Elliott, Robert (Server Storage); linux- > s...@vger.kernel.org; linux-kernel@vger.kernel.org > Subjec

RE: scsi-mq

2014-06-20 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Bart Van Assche [mailto:bvanass...@acm.org] > Sent: Wednesday, 18 June, 2014 2:09 AM > To: Jens Axboe; Christoph Hellwig; James Bottomley > Cc: Elliott, Robert (Server Storage); linux-s...@vger.kernel.org; linux- > ker...@vger.kernel.org &

RE: scsi-mq

2014-06-18 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Jens Axboe [mailto:ax...@kernel.dk] > Sent: Tuesday, 17 June, 2014 10:45 PM > To: Bart Van Assche; Christoph Hellwig; James Bottomley > Cc: Bart Van Assche; Elliott, Robert (Server Storage); linux- > s...@vger.kernel.org; linux-kern

  1   2   >