Re: [PATCH v2 0/8] MIPS: fixes for PCI legacy drivers (rt2880, rt3883)

2021-04-16 Thread Thomas Bogendoerfer
50 > arch/mips/pci/pci-rt3883.c | 10 ++- > 4 files changed, 35 insertions(+), 83 deletions(-) series applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH] MIPS: Fix strnlen_user access check

2021-04-16 Thread Thomas Bogendoerfer
On Thu, Apr 15, 2021 at 11:26:40PM +0200, Thomas Bogendoerfer wrote: > Commit 04324f44cb69 ("MIPS: Remove get_fs/set_fs") changed the access_ok > for strnlen_user to check the whole range, which broke some callers > of strndup_user(). Restore the old behaviour and just c

Re: [PATCH v3 net-next 06/10] net: korina: Only pass mac address via platform data

2021-04-16 Thread Thomas Bogendoerfer
On Fri, Apr 16, 2021 at 01:30:04AM +0200, Andrew Lunn wrote: > On Thu, Apr 15, 2021 at 01:06:43AM +0200, Thomas Bogendoerfer wrote: > > Get rid of access to struct korina_device by just passing the mac > > address via platform data and use drvdata for passing netdev to remo

[PATCH] MIPS: Fix strnlen_user access check

2021-04-15 Thread Thomas Bogendoerfer
Commit 04324f44cb69 ("MIPS: Remove get_fs/set_fs") changed the access_ok for strnlen_user to check the whole range, which broke some callers of strndup_user(). Restore the old behaviour and just check the first byte. Fixes: 04324f44cb69 ("MIPS: Remove get_fs/set_fs") S

Re: [PATCH v3] hrtimer: avoid retrigger_next_event IPI

2021-04-15 Thread Thomas Gleixner
On Thu, Apr 15 2021 at 12:39, Marcelo Tosatti wrote: > +static bool need_reprogram_timer(struct hrtimer_cpu_base *cpu_base) > +{ > + unsigned int active = 0; > + > + if (cpu_base->softirq_activated) > + return true; > + > + active = cpu_base->active_bases &

Re: [PATCH] hrtimer: Update softirq_expires_next correctly after __hrtimer_get_next_event()

2021-04-15 Thread Thomas Gleixner
On Wed, Apr 14 2021 at 11:49, Lorenzo Colitti wrote: > On Wed, Apr 14, 2021 at 2:14 AM Greg KH wrote: >> To give context, the commit is now 46eb1701c046 ("hrtimer: Update >> softirq_expires_next correctly after __hrtimer_get_next_event()") and is >> attached below. >> >> The f_ncm.c driver is

[tip: sched/core] signal: Hand SIGQUEUE_PREALLOC flag to __sigqueue_alloc()

2021-04-15 Thread tip-bot2 for Thomas Gleixner
The following commit has been merged into the sched/core branch of tip: Commit-ID: 69995ebbb9d3717306a165db88a1292b63f77a37 Gitweb: https://git.kernel.org/tip/69995ebbb9d3717306a165db88a1292b63f77a37 Author:Thomas Gleixner AuthorDate:Mon, 22 Mar 2021 10:19:42 +01:00

[tip: sched/core] signal: Allow tasks to cache one sigqueue struct

2021-04-15 Thread tip-bot2 for Thomas Gleixner
The following commit has been merged into the sched/core branch of tip: Commit-ID: 4bad58ebc8bc4f20d89cff95417c9b4674769709 Gitweb: https://git.kernel.org/tip/4bad58ebc8bc4f20d89cff95417c9b4674769709 Author:Thomas Gleixner AuthorDate:Tue, 23 Mar 2021 22:05:39 +01:00

Re: [tip: core/rcu] softirq: Don't try waking ksoftirqd before it has been spawned

2021-04-14 Thread Thomas Gleixner
Paul, On Wed, Apr 14 2021 at 11:11, Paul E. McKenney wrote: > On Wed, Apr 14, 2021 at 10:57:57AM +0200, Uladzislau Rezki wrote: >> On Wed, Apr 14, 2021 at 09:13:22AM +0200, Sebastian Andrzej Siewior wrote: >> At the same time Paul made another patch: >> >> softirq: Don't try waking ksoftirqd

[PATCH v3 net-next 09/10] net: korina: Make driver COMPILE_TESTable

2021-04-14 Thread Thomas Bogendoerfer
Move structs/defines for ethernet/dma register into driver, since they are only used for this driver and remove any MIPS specific includes. This makes it possible to COMPILE_TEST the driver. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/Kconfig | 2 +- drivers/net/ethernet

[PATCH v3 net-next 05/10] net: korina: Use DMA API

2021-04-14 Thread Thomas Bogendoerfer
Instead of messing with MIPS specific macros use DMA API for mapping descriptors and skbs. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 158 +- 1 file changed, 98 insertions(+), 60 deletions(-) diff --git a/drivers/net/ethernet/korina.c

[PATCH v3 net-next 08/10] net: korina: Get mdio input clock via common clock framework

2021-04-14 Thread Thomas Bogendoerfer
With device tree clock is provided via CCF. For non device tree use a maximum clock value to not overclock the PHY. The non device tree usage will go away after platform is converted to DT. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 19 +-- 1 file

[PATCH v3 net-next 07/10] net: korina: Add support for device tree

2021-04-14 Thread Thomas Bogendoerfer
If there is no mac address passed via platform data try to get it via device tree and fall back to a random mac address, if all fail. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff

[PATCH v3 net-next 03/10] net: korina: Remove not needed cache flushes

2021-04-14 Thread Thomas Bogendoerfer
Descriptors are mapped uncached so there is no need to do any cache handling for them. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 6bef5d590ebe

[PATCH v3 net-next 06/10] net: korina: Only pass mac address via platform data

2021-04-14 Thread Thomas Bogendoerfer
Get rid of access to struct korina_device by just passing the mac address via platform data and use drvdata for passing netdev to remove function. Signed-off-by: Thomas Bogendoerfer --- arch/mips/rb532/devices.c | 5 +++-- drivers/net/ethernet/korina.c | 11 ++- 2 files changed, 9

[PATCH v3 net-next 04/10] net: korina: Remove nested helpers

2021-04-14 Thread Thomas Bogendoerfer
Remove helpers, which are only used in one call site. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 28 +++- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index

[PATCH v3 net-next 02/10] net: korina: Use devres functions

2021-04-14 Thread Thomas Bogendoerfer
Simplify probe/remove code by using devm_ functions. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 64 --- 1 file changed, 21 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index

[PATCH v3 net-next 01/10] net: korina: Fix MDIO functions

2021-04-14 Thread Thomas Bogendoerfer
Fixed MDIO functions to work reliable and not just by accident. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/Kconfig | 1 + drivers/net/ethernet/korina.c | 54 +++ 2 files changed, 36 insertions(+), 19 deletions(-) diff --git a/drivers/net

[PATCH v3 net-next 00/10] net: Korina improvements

2021-04-14 Thread Thomas Bogendoerfer
by storing/using mapped dma addresses (dma controller modifies current address) Thomas Bogendoerfer (10): net: korina: Fix MDIO functions net: korina: Use devres functions net: korina: Remove not needed cache flushes net: korina: Remove nested helpers net: korina: Use DMA API net: korina

Re: [PATCH net-next 1/7] net: korina: Fix MDIO functions

2021-04-14 Thread Thomas Bogendoerfer
- lp->mii_if.mdio_read = mdio_read; > > - lp->mii_if.mdio_write = mdio_write; > > - lp->mii_if.phy_id = lp->phy_addr; > > + lp->mii_if.mdio_read = korina_mdio_read; > > + lp->mii_if.mdio_write = korina_mdio_write; > > +

[PATCH v3] tee: amdtee: unload TA only when its refcount becomes 0

2021-04-14 Thread Rijo Thomas
: 757cc3e9ff1d ("tee: add AMD-TEE driver") Reviewed-by: Devaraj Rangasamy Signed-off-by: Rijo Thomas --- v3: * Updated structure initialization list from {0} to preferred style {} v2: * Unload TA if get_ta_refcount() fails drivers/tee/amdtee/amdtee_private.h | 13 drivers/tee/amd

Re: [PATCH v2] tee: amdtee: unload TA only when its refcount becomes 0

2021-04-14 Thread Rijo Thomas
On 14/04/21 10:16 pm, Jens Wiklander wrote: > Hi Jiro, > > On Mon, Apr 12, 2021 at 12:20 PM Rijo Thomas wrote: >> >> >> >> On 12/04/21 1:06 pm, Jens Wiklander wrote: >>> On Mon, Apr 5, 2021 at 11:43 AM Rijo Thomas >>> wrote: >>>&g

Re: [RFC PATCH 0/7] KVM: Fix tick-based vtime accounting on x86

2021-04-14 Thread Thomas Gleixner
On Tue, Apr 13 2021 at 11:29, Sean Christopherson wrote: > This is an alternative to Wanpeng's series[*] to fix tick-based accounting > on x86. The approach for fixing the bug is identical: defer accounting > until after tick IRQs are handled. The difference is purely in how the > context

Re: [PATCH v2] hrtimer: avoid retrigger_next_event IPI

2021-04-14 Thread Thomas Gleixner
Marcelo, On Tue, Apr 13 2021 at 14:04, Marcelo Tosatti wrote: > Setting the realtime clock triggers an IPI to all CPUs to reprogram > hrtimers. s/hrtimers/clock event device/ > However, only realtime and TAI clocks have their offsets updated > (and therefore potentially require a reprogram). >

[PATCH v2 net-next 8/9] net: korina: Get mdio input clock via common clock framework

2021-04-14 Thread Thomas Bogendoerfer
With device tree clock is provided via CCF. For non device tree use a maximum clock value to not overclock the PHY. The non device tree usage will go away after platform is converted to DT. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 19 +-- 1 file

[PATCH v2 net-next 6/9] net: korina: Only pass mac address via platform data

2021-04-14 Thread Thomas Bogendoerfer
Get rid of access to struct korina_device by just passing the mac address via platform data and use drvdata for passing netdev to remove function. Signed-off-by: Thomas Bogendoerfer --- arch/mips/rb532/devices.c | 5 +++-- drivers/net/ethernet/korina.c | 11 ++- 2 files changed, 9

[PATCH v2 net-next 9/9] net: korina: Make driver COMPILE_TESTable

2021-04-14 Thread Thomas Bogendoerfer
Move structs/defines for ethernet/dma register into driver, since they are only used for this driver and remove any MIPS specific includes. This makes it possible to COMPILE_TEST the driver. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/Kconfig | 2 +- drivers/net/ethernet

[PATCH v2 net-next 7/9] net: korina: Add support for device tree

2021-04-14 Thread Thomas Bogendoerfer
If there is no mac address passed via platform data try to get it via device tree and fall back to a random mac address, if all fail. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff

[PATCH v2 net-next 5/9] net: korina: Use DMA API

2021-04-14 Thread Thomas Bogendoerfer
Instead of messing with MIPS specific macros use DMA API for mapping descriptors and skbs. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 158 +- 1 file changed, 98 insertions(+), 60 deletions(-) diff --git a/drivers/net/ethernet/korina.c

[PATCH v2 net-next 4/9] net: korina: Remove nested helpers

2021-04-14 Thread Thomas Bogendoerfer
Remove helpers, which are only used in one call site. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 28 +++- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index

[PATCH v2 net-next 3/9] net: korina: Remove not needed cache flushes

2021-04-14 Thread Thomas Bogendoerfer
Descriptors are mapped uncached so there is no need to do any cache handling for them. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 3a454f6214b0

[PATCH v2 net-next 2/9] net: korina: Use devres functions

2021-04-14 Thread Thomas Bogendoerfer
Simplify probe/remove code by using devm_ functions. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 64 --- 1 file changed, 21 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index

[PATCH v2 net-next 1/9] net: korina: Fix MDIO functions

2021-04-14 Thread Thomas Bogendoerfer
Fixed MDIO functions to work reliable and not just by accident. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/Kconfig | 1 + drivers/net/ethernet/korina.c | 57 +++ 2 files changed, 39 insertions(+), 19 deletions(-) diff --git a/drivers/net

[PATCH v2 net-next 0/9] net: Korina improvements

2021-04-14 Thread Thomas Bogendoerfer
compile test on 64bit archs - fixed descriptor current address handling by storing/using mapped dma addresses (dma controller modifies current address) Thomas Bogendoerfer (9): net: korina: Fix MDIO functions net: korina: Use devres functions net: korina: Remove not needed cache flushes

Re: [PATCH v5 2/3] x86/bus_lock: Handle #DB for bus lock

2021-04-14 Thread Thomas Gleixner
Fenghua, On Tue, Apr 13 2021 at 23:40, Fenghua Yu wrote: > On Mon, Apr 12, 2021 at 09:15:08AM +0200, Thomas Gleixner wrote: >> Aside of that why are you trying to make this throttling in any way >> accurate? It does not matter at all, really. Limit reached, put it to >>

Re: [PATCH] MIPS: Fix strnlen_user access check

2021-04-14 Thread Thomas Bogendoerfer
On Tue, Apr 13, 2021 at 04:01:13PM +, David Laight wrote: > From: Thomas Bogendoerfer > > Sent: 13 April 2021 16:19 > > > > On Tue, Apr 13, 2021 at 12:37:25PM +, David Laight wrote: > > > From: Thomas Bogendoerfer > > > > Sent: 13 April 2021

Re: bl_list and lockdep

2021-04-13 Thread Thomas Gleixner
Dave, On Tue, Apr 13 2021 at 19:58, Dave Chinner wrote: > On Tue, Apr 13, 2021 at 01:18:35AM +0200, Thomas Gleixner wrote: > So for solving the inode cache scalability issue with RT in mind, > we're left with these choices: > > a) increase memory consumption and cacheline miss

[PATCH net-next 6/7] net: korina: Only pass mac address via platform data

2021-04-13 Thread Thomas Bogendoerfer
Get rid of access to struct korina_device by just passing the mac address via platform data and use drvdata for passing netdev to remove function. Signed-off-by: Thomas Bogendoerfer --- arch/mips/rb532/devices.c | 5 +++-- drivers/net/ethernet/korina.c | 11 ++- 2 files changed, 9

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-13 Thread Thomas Gleixner
Paul, On Mon, Apr 12 2021 at 16:18, Paul E. McKenney wrote: > On Mon, Apr 12, 2021 at 10:37:10PM +0200, Thomas Gleixner wrote: >> On Mon, Apr 12 2021 at 12:57, Paul E. McKenney wrote: >> > On Mon, Apr 12, 2021 at 08:54:03PM +0200, Thomas Gleixner wrote: >> >> > I

[PATCH net-next 5/7] net: korina: Use DMA API

2021-04-13 Thread Thomas Bogendoerfer
Instead of messing with MIPS specific macros use DMA API for mapping descriptors and skbs. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 143 -- 1 file changed, 85 insertions(+), 58 deletions(-) diff --git a/drivers/net/ethernet/korina.c

[PATCH net-next 7/7] net: korina: Make driver COMPILE_TESTable

2021-04-13 Thread Thomas Bogendoerfer
Move structs/defines for ethernet/dma register into driver, since they are only used for this driver and remove any MIPS specific includes. This makes it possible to COMPILE_TEST the driver. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/Kconfig | 2 +- drivers/net/ethernet

[PATCH net-next 4/7] net: korina: Remove nested helpers

2021-04-13 Thread Thomas Bogendoerfer
Remove helpers, which are only used in one call site. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 28 +++- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index

[PATCH net-next 3/7] net: korina: Remove not needed cache flushes

2021-04-13 Thread Thomas Bogendoerfer
Descriptors are mapped uncached so there is no need to do any cache handling for them. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 3a454f6214b0

[PATCH net-next 2/7] net: korina: Use devres functions

2021-04-13 Thread Thomas Bogendoerfer
Simplify probe/remove code by using devm_ functions. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 64 --- 1 file changed, 21 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index

[PATCH net-next 1/7] net: korina: Fix MDIO functions

2021-04-13 Thread Thomas Bogendoerfer
Fixed MDIO functions to work reliable and not just by accident. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 57 +++ 1 file changed, 38 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet

[PATCH net-next 0/7] net: Korina improvements

2021-04-13 Thread Thomas Bogendoerfer
While converting Mikrotik RB532 support to use device tree I stumbled over the korina ethernet driver, which used way too many MIPS specific hacks. This series cleans this all up. Thomas Bogendoerfer (7): net: korina: Fix MDIO functions net: korina: Use devres functions net: korina: Remove

Re: [PATCH] genirq: reduce irqdebug bouncing cachelines

2021-04-13 Thread Thomas Gleixner
On Tue, Apr 13 2021 at 14:16, Cédric Le Goater wrote: >>> We could test irq_settings_no_debug() directly under handle_nested_irq() >>> and handle_irq_event_percpu() to avoid calling note_interrupt(), just >>> like we do for noirqdebug. >> >> We can do that, but then we should not just make it:

Re: [PATCH] MIPS: Fix strnlen_user access check

2021-04-13 Thread Thomas Bogendoerfer
On Tue, Apr 13, 2021 at 12:37:25PM +, David Laight wrote: > From: Thomas Bogendoerfer > > Sent: 13 April 2021 12:15 > ... > > > The __access_ok() is noted with `Ensure that the range [addr, addr+size) > > > is within the process's address space`. Does the rang

Re: [PATCH] MIPS: Fix strnlen_user access check

2021-04-13 Thread Thomas Bogendoerfer
On Tue, Apr 13, 2021 at 09:15:48AM +0800, Jinyang He wrote: > On 04/12/2021 10:27 PM, Thomas Bogendoerfer wrote: > > > diff --git a/arch/mips/include/asm/uaccess.h > > > b/arch/mips/include/asm/uaccess.h > > > index 91bc7fb..eafc99b 100644 > > > --- a/arch

Re: [PATCH] kernel:irq:manage: request threaded irq with a specified priority

2021-04-13 Thread Thomas Gleixner
On Tue, Apr 13 2021 at 14:19, Song Chen wrote: > In general, irq handler thread will be assigned a default priority which > is MAX_RT_PRIO/2, as a result, no one can preempt others. > > Here is the case I found in a real project, an interrupt int_a is > coming, wakes up its handler handler_a and

Re: Candidate Linux ABI for Intel AMX and hypothetical new related features

2021-04-12 Thread Thomas Gleixner
On Mon, Apr 12 2021 at 19:46, Len Brown wrote: > On Mon, Apr 12, 2021 at 11:21 AM Andy Lutomirski wrote: >> Even putting aside all kernel and ABI issues, is it actually a good >> idea for user libraries to transparently use these new features? I'm >> not really convinced. I think that serious

Re: bl_list and lockdep

2021-04-12 Thread Thomas Gleixner
Dave, On Tue, Apr 13 2021 at 08:15, Dave Chinner wrote: > On Mon, Apr 12, 2021 at 05:20:53PM +0200, Thomas Gleixner wrote: >> On Wed, Apr 07 2021 at 07:22, Dave Chinner wrote: >> > And, FWIW, I'm also aware of the problems that RT kernels have with >> > the use of bit

Re: [PATCH 02/11] mm/page_alloc: Convert per-cpu list protection to local_lock

2021-04-12 Thread Thomas Gleixner
On Mon, Apr 12 2021 at 12:56, Mel Gorman wrote: > On Fri, Apr 09, 2021 at 08:55:39PM +0200, Peter Zijlstra wrote: > I'll update the changelog and comment accordingly. I'll decide later > whether to leave it or move the location of the lock at the end of the > series. If the patch is added, it'll

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-12 Thread Thomas Gleixner
On Mon, Apr 12 2021 at 12:57, Paul E. McKenney wrote: > On Mon, Apr 12, 2021 at 08:54:03PM +0200, Thomas Gleixner wrote: >> > I will send a new series out later today, Pacific Time. >> >> Can you do me a favour and send it standalone and not as yet another >> repl

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-12 Thread Thomas Gleixner
Paul, On Mon, Apr 12 2021 at 11:20, Paul E. McKenney wrote: > On Mon, Apr 12, 2021 at 03:08:16PM +0200, Thomas Gleixner wrote: >> The reason for irqsave is again historical AFAICT and nobody bothered to >> clean it up. spin_lock_bh() should be sufficient to serialize against >&g

Re: bl_list and lockdep

2021-04-12 Thread Thomas Gleixner
Dave, On Wed, Apr 07 2021 at 07:22, Dave Chinner wrote: > On Tue, Apr 06, 2021 at 02:28:34PM +0100, Matthew Wilcox wrote: >> On Tue, Apr 06, 2021 at 10:33:43PM +1000, Dave Chinner wrote: >> > +++ b/fs/inode.c >> > @@ -57,8 +57,7 @@ >> > >> > static unsigned int i_hash_mask __read_mostly; >> >

Re: [PATCH -next] MIPS: Alchemy: Use DEFINE_SPINLOCK() for spinlock

2021-04-12 Thread Thomas Bogendoerfer
mips/alchemy/common/clock.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH] MIPS: generic: Update node names to avoid unit addresses

2021-04-12 Thread Thomas Bogendoerfer
+++++----- > 8 files changed, 46 insertions(+), 46 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH v3] MIPS: add support for buggy MT7621S core detection

2021-04-12 Thread Thomas Bogendoerfer
f-by: Ilya Lipnitskiy > --- > arch/mips/include/asm/mips-cps.h | 23 ++- > 1 file changed, 22 insertions(+), 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH] MIPS: uaccess: Reduce number of nested macros

2021-04-12 Thread Thomas Bogendoerfer
On Thu, Apr 08, 2021 at 08:14:37PM +0200, Thomas Bogendoerfer wrote: > Clean up macros even further after removal get_fs/set_fs. > > Signed-off-by: Thomas Bogendoerfer > --- > arch/mips/include/asm/uaccess.h | 157 +++- > 1 file changed, 71

Re: [PATCH 02/17] locking: Add split_lock

2021-04-12 Thread Thomas Gleixner
On Mon, Apr 12 2021 at 15:45, Matthew Wilcox wrote: > On Mon, Apr 12, 2021 at 04:29:28PM +0200, Thomas Gleixner wrote: >> On Fri, Apr 09 2021 at 03:51, Matthew Wilcox wrote: >> > Bitlocks do not currently participate in lockdep. Conceptually, a >> > bit_spinlock is a

Re: [PATCH] MIPS: Fix strnlen_user access check

2021-04-12 Thread Thomas Bogendoerfer
ude/asm/uaccess.h > @@ -630,8 +630,8 @@ static inline long strnlen_user(const char __user *s, > long n) > { > long res; > - if (!access_ok(s, n)) > - return -0; > + if (!access_ok(s, 1)) > + return 0; > might_fault(); > __asm__ __volatile__( that's the fix I'd like to apply. Could someone send it as a formal patch ? Thanks. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH 02/17] locking: Add split_lock

2021-04-12 Thread Thomas Gleixner
On Fri, Apr 09 2021 at 03:51, Matthew Wilcox wrote: > Bitlocks do not currently participate in lockdep. Conceptually, a > bit_spinlock is a split lock, eg across each bucket in a hash table. > The struct split_lock gives us somewhere to record the lockdep_map. I like the concept, but the name is

Re: [tip: core/rcu] softirq: Don't try waking ksoftirqd before it has been spawned

2021-04-12 Thread Thomas Gleixner
On Sun, Apr 11 2021 at 13:43, tip-bot wrote: > The following commit has been merged into the core/rcu branch of tip: > > Commit-ID: 1c0c4bc1ceb580851b2d76fdef9712b3bdae134b > Gitweb: > https://git.kernel.org/tip/1c0c4bc1ceb580851b2d76fdef9712b3bdae134b > Author:Paul E. McKenney

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-12 Thread Thomas Gleixner
On Sun, Apr 11 2021 at 21:21, Paul E. McKenney wrote: > On Sun, Apr 11, 2021 at 09:46:12AM -0700, Paul E. McKenney wrote: >> So I need to is inline clocksource_verify_percpu_wq() >> into clocksource_verify_percpu() and then move the call to >> clocksource_verify_percpu() to

Re: [PATCH RESEND v1 2/4] lib/vdso: Add vdso_data pointer as input to __arch_get_timens_vdso_data()

2021-04-12 Thread Thomas Gleixner
age to vdso_data, provide > vdso_data pointer to __arch_get_timens_vdso_data() in order > to ease the calculation on powerpc in following patches. > > Signed-off-by: Christophe Leroy Reviewed-by: Thomas Gleixner

Re: [PATCH RESEND v1 0/4] powerpc/vdso: Add support for time namespaces

2021-04-12 Thread Thomas Gleixner
On Wed, Mar 31 2021 at 16:48, Christophe Leroy wrote: > [Sorry, resending with complete destination list, I used the wrong script on > the first delivery] > > This series adds support for time namespaces on powerpc. > > All timens selftests are successfull. If PPC people want to pick up the

Re: [PATCH RESEND v1 1/4] lib/vdso: Mark do_hres_timens() and do_coarse_timens() __always_inline()

2021-04-12 Thread Thomas Gleixner
-gettime-monotonic-raw:vdso: 1100 nsec/call > clock-gettime-monotonic-coarse:vdso: 667 nsec/call > clock-gettime-monotonic:vdso: 1025 nsec/call > > Signed-off-by: Christophe Leroy Reviewed-by: Thomas Gleixner

Re: [PATCH] genirq: reduce irqdebug bouncing cachelines

2021-04-12 Thread Thomas Gleixner
Cédric, On Mon, Apr 12 2021 at 11:06, Cédric Le Goater wrote: > On 4/10/21 1:58 PM, Thomas Gleixner wrote: >> --- a/kernel/irq/spurious.c >> +++ b/kernel/irq/spurious.c >> @@ -274,7 +274,7 @@ void note_interrupt(struct irq_desc *des >> unsigned int irq; &g

[PATCH v5] platform/x86: add Gigabyte WMI temperature driver

2021-04-12 Thread Thomas Weißschuh
-by: Thomas Weißschuh Reviewed-by: Guenter Roeck --- Changes since v4: * Style * Wording * Alignment of email addresses --- MAINTAINERS | 6 + drivers/platform/x86/Kconfig| 11 ++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/gigabyte-wmi.c | 195

Re: [PATCH v2] tee: amdtee: unload TA only when its refcount becomes 0

2021-04-12 Thread Rijo Thomas
On 12/04/21 1:06 pm, Jens Wiklander wrote: > On Mon, Apr 5, 2021 at 11:43 AM Rijo Thomas wrote: >> >> Same Trusted Application (TA) can be loaded in multiple TEE contexts. >> >> If it is a single instance TA, the TA should not get unloaded from AMD >> Secure Pr

Re: [PATCH v2] tee: amdtee: unload TA only when its refcount becomes 0

2021-04-12 Thread Rijo Thomas
On 09/04/21 2:15 pm, Dan Carpenter wrote: > On Mon, Apr 05, 2021 at 03:13:09PM +0530, Rijo Thomas wrote: >> @@ -340,7 +398,8 @@ int handle_open_session(struct >> tee_ioctl_open_session_arg *arg, u32 *info, >> >> int handle_load_ta(void *data, u32 size, struct

Re: [PATCH v4] drm/ast: Fixed CVE for DP501

2021-04-12 Thread Thomas Zimmermann
Hi this patch produces a NULL-ptr deref as shown below. The chip is detected as AST 2100. Best regards Thomas == [ 23.641896] BUG: KASAN: null-ptr-deref in ast_device_create.cold+0x137/0x210 [ast] [ 23.642257] Read

Re: [PATCH v5 2/3] x86/bus_lock: Handle #DB for bus lock

2021-04-12 Thread Thomas Gleixner
On Sat, Apr 03 2021 at 01:04, Fenghua Yu wrote: > On Sat, Mar 20, 2021 at 01:42:52PM +0100, Thomas Gleixner wrote: >> On Fri, Mar 19 2021 at 22:19, Fenghua Yu wrote: >> And even with throttling the injection rate further down to 25k per >> second the impact on the workload

Re: [syzbot] general protection fault in drm_client_buffer_vunmap

2021-04-11 Thread Thomas Zimmermann
#syz fix: drm/fb-helper: only unmap if buffer not null Am 11.04.21 um 14:01 schrieb syzbot: #syz fix: drm/fb-helper: only unmap if buffer not null -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg

Re: [PATCH v7 clocksource] Do not mark clocks unstable due to delays for v5.13

2021-04-11 Thread Thomas Gleixner
On Sat, Apr 10 2021 at 16:26, Paul E. McKenney wrote: > On Sat, Apr 10, 2021 at 10:01:58AM +0200, Thomas Gleixner wrote: >> On Fri, Apr 02 2021 at 15:48, Paul E. McKenney wrote: >> I buy the vCPU preemption part and TBH guests should not have that >> watchdog thing acti

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-11 Thread Thomas Gleixner
On Sat, Apr 10 2021 at 17:20, Paul E. McKenney wrote: > On Sat, Apr 10, 2021 at 11:00:25AM +0200, Thomas Gleixner wrote: >> > + if (WARN_ON_ONCE(!cs)) >> > + return; >> > + pr_warn("Checking clocksource %s synchronization from CPU %d.\n", &g

Re: [RFC 1/2] x86/tsc: add a timer to make sure tsc_adjust is always checked

2021-04-10 Thread Thomas Gleixner
Feng, On Sat, Apr 10 2021 at 22:38, Feng Tang wrote: > On Sat, Apr 10, 2021 at 11:27:11AM +0200, Thomas Gleixner wrote: >> > +static int __init start_sync_check_timer(void) >> > +{ >> > + if (!boot_cpu_has(X86_FEATURE_TSC_ADJUST)) >> > +

Re: [RFC 1/2] x86/tsc: add a timer to make sure tsc_adjust is always checked

2021-04-10 Thread Thomas Gleixner
On Sat, Apr 10 2021 at 11:47, Borislav Petkov wrote: > On Sat, Apr 10, 2021 at 11:27:11AM +0200, Thomas Gleixner wrote: >> On Tue, Mar 30 2021 at 16:25, Feng Tang wrote: >> > Normally the tsc_sync will be checked every time system enters idle state, >> > but there is

[PATCH v4] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Thomas Weißschuh
ITE IT8688E chip for management. This chips is also handled by drivers/hwmon/i87.c but as it is also used by the firmware itself it needs an ACPI driver. Unfortunately not all sensor registers are handled by the firmware and even less are exposed via WMI. Signed-off-by: Thomas Weißschuh --- MAINTAIN

[PATCH v3] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Thomas Weißschuh
CPI driver. Unfortunately not all sensor registers are handled by the firmware and even less are exposed via WMI. Signed-off-by: Thomas Weißschuh --- MAINTAINERS | 6 + drivers/platform/x86/Kconfig| 11 ++ drivers/platform/x86/Makefile | 1 + drivers/platf

Re: [PATCH] genirq: reduce irqdebug bouncing cachelines

2021-04-10 Thread Thomas Gleixner
Nicholas, On Fri, Apr 02 2021 at 23:20, Nicholas Piggin wrote: > note_interrupt increments desc->irq_count for each interrupt even for > percpu interrupt handlers, even when they are handled successfully. This > causes cacheline bouncing and limits scalability. > > Instead of incrementing

Re: [PATCH] arch/x86: Encourage rather than discourage x2apic support

2021-04-10 Thread Thomas Gleixner
On Wed, Mar 31 2021 at 05:16, Luke Dashjr wrote: > Multi-core SMP doesn't work on modern Intel CPUs (at least Comet Lake) without > x2apic. Unsure users should say Y. I'd rather make it explicit by also adding default y Thanks, tglx

Re: [RFC 1/2] x86/tsc: add a timer to make sure tsc_adjust is always checked

2021-04-10 Thread Thomas Gleixner
On Tue, Mar 30 2021 at 16:25, Feng Tang wrote: > Normally the tsc_sync will be checked every time system enters idle state, > but there is still caveat that a system won't enter idle, either because > it's too busy or configured purposely to not enter idle. Setup a periodic > timer to make sure

Re: [PATCH v7 clocksource 5/5] clocksource: Do pairwise clock-desynchronization checking

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 02 2021 at 15:49, paulmck wrote: > From: "Paul E. McKenney" > > Although smp_call_function() has the advantage of simplicity, using > it to check for cross-CPU clock desynchronization means that any CPU > being slow reduces the sensitivity of the checking across all CPUs. > And it is

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 02 2021 at 15:49, paulmck wrote: > > +static void clocksource_verify_percpu_wq(struct work_struct *unused) > +{ > + int cpu; > + struct clocksource *cs; > + int64_t cs_nsec; > + u64 csnow_begin; > + u64 csnow_end; > + u64 delta; Please use reverse fir tree

Re: [PATCH v7 clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 02 2021 at 15:49, paulmck wrote: > This commit therefore re-reads the watchdog clock on either side of 'This commit' is not any better than 'This patch' and this sentence makes no sense. I might be missing something, but how exactly does "the commit" re-read the watchdog clock? git

Re: [PATCH v7 clocksource] Do not mark clocks unstable due to delays for v5.13

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 02 2021 at 15:48, Paul E. McKenney wrote: > Hello! > > If there is a sufficient delay between reading the watchdog clock and the > clock under test, the clock under test will be marked unstable through no > fault of its own. This series checks for this, doing limited retries > to get

Re: [PATCH] hrtimer: avoid retrigger_next_event IPI

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 09 2021 at 13:51, Marcelo Tosatti wrote: > On Fri, Apr 09, 2021 at 04:15:13PM +0200, Thomas Gleixner wrote: >> On Wed, Apr 07 2021 at 10:53, Marcelo Tosatti wrote: >> ---> fail because that newly started timer is on the ol

Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Thomas Bogendoerfer
| 1 + > arch/mips/sgi-ip22/ip22-reset.c | 1 + > arch/mips/sgi-ip32/ip32-reset.c | 1 + Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH] hrtimer: avoid retrigger_next_event IPI

2021-04-09 Thread Thomas Gleixner
On Wed, Apr 07 2021 at 10:53, Marcelo Tosatti wrote: > Setting the realtime clock triggers an IPI to all CPUs to reprogram > hrtimers. > > However, only base, boottime and tai clocks have their offsets updated base clock? And why boottime? Boottime is not affected by a clock realtime set. It's

Re: [RFC PATCH 06/10] genirq: Don't mask IRQ within flow handler if IRQ is flow-masked

2021-04-09 Thread Thomas Gleixner
On Thu, Apr 08 2021 at 16:43, Valentin Schneider wrote: > + /* > + * Masking is required if IRQ is ONESHOT and we can't rely on the > + * flow-masking persisting down to irq_finalize_oneshot() > + * (in the IRQ thread). > + */ > + if ((desc->istate & IRQS_ONESHOT) && >

Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

2021-04-09 Thread Thomas Zimmermann
Hi Am 09.04.21 um 15:50 schrieb Kevin Tang: > +static int __init sprd_drm_init(void) > +{ > +     int ret; I think ret should just go away. Like this? "return platform_register_drivers(sprd_drm_drivers, ARRAY_SIZE(sprd_drm_drivers));" Sure. Best reg

Re: [RFC PATCH 05/10] genirq: Let purely flow-masked ONESHOT irqs through unmask_threaded_irq()

2021-04-09 Thread Thomas Gleixner
On Thu, Apr 08 2021 at 16:43, Valentin Schneider wrote: > A subsequent patch will let IRQs end up in irq_finalize_oneshot() without > IRQD_IRQ_MASKED, but with IRQD_IRQ_FLOW_MASKED set instead. Let such IRQs > receive their final ->irq_eoi(). > > Signed-off-by: Valentin Schneider > --- >

Re: [RFC PATCH] Add split_lock

2021-04-09 Thread Thomas Gleixner
ike it, but I'm not sure it'll work for RT as is. It's a bit > like qrwlock in that it only uses the internal (split) lock for > contention, but that doesn't work for PI. > > I've not recently looked at RT, but I think they simply used to bloat a > number of the data structures with a

RE: [PATCH 1/2] x86/traps: call cond_local_irq_disable before returning from exc_general_protection and math_error

2021-04-09 Thread Thomas Tai
> -Original Message- > From: Alexandre CHARTRE > Sent: April 9, 2021 5:06 AM > To: Thomas Tai ; t...@linutronix.de; > mi...@redhat.com; b...@alien8.de; x...@kernel.org > Cc: sean.j.christopher...@intel.com; l...@amacapital.net; > jar...@kernel.org; b...@suse.de; jet..

Re: build failure of malta_qemu_32r6_defconfig

2021-04-09 Thread Thomas Bogendoerfer
On Thu, Apr 08, 2021 at 09:42:11AM +0800, YunQiang Su wrote: > Sudip Mukherjee 于2021年4月8日周四 上午2:26写道: > > > > Hi Thomas, > > > > I was building v5.10.28 with malta_qemu_32r6_defconfig and noticed that > > it fails to build, so tried next-20210407 to see if it h

[tip: x86/urgent] x86/traps: Correct exc_general_protection() and math_error() return paths

2021-04-09 Thread tip-bot2 for Thomas Tai
The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 632a1c209b8773cb0119fe3aada9f1db14fa357c Gitweb: https://git.kernel.org/tip/632a1c209b8773cb0119fe3aada9f1db14fa357c Author:Thomas Tai AuthorDate:Thu, 08 Apr 2021 13:28:33 -04:00 Committer

Re: [PATCH] MIPS: octeon: Add __raw_copy_[from|to|in]_user symbols

2021-04-09 Thread Thomas Bogendoerfer
On Fri, Apr 09, 2021 at 11:42:46AM +0300, Sergei Shtylyov wrote: > Hello! > > On 09.04.2021 0:48, Thomas Bogendoerfer wrote: > > > Cavium Octeon has it's own memcpy implementation and also need the change > >Its. :-) applied (with typo fixed) to mips-next. Th

[PATCH] perf ftrace: Command fails on s390

2021-04-09 Thread Thomas Richter
) | rcu_read_lock_sched_held() { 4) 0.552 us|rcu_lockdep_current_cpu_online(); 4) 6.124 us| } Signed-off-by: Thomas Richter --- tools/perf/builtin-ftrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-ftrace.c b/tools

<    1   2   3   4   5   6   7   8   9   10   >