Re: [PATCH v3 5/8] clk: rockchip: add new clock type and controller for rk3036

Hi Heiko, 发自我的 iPad > 在 2015年10月1日，16:12，Heiko Stübner 写道： > > Am Dienstag, 29. September 2015, 10:13:50 schrieb Xing Zheng: >> The rk3036's pll and clock are different with base on the rk3066(rk3188, >> rk3288, rk3368 use it), there are different adjust foctors and control >> registers, so

Re: [PATCH v3 5/8] clk: rockchip: add new clock type and controller for rk3036

Hi Heiko, 发自我的 iPad > 在 2015年10月1日，16:12，Heiko Stübner 写道： > > Am Dienstag, 29. September 2015, 10:13:50 schrieb Xing Zheng: >> The rk3036's pll and clock are different with base on the rk3066(rk3188, >> rk3288, rk3368 use it), there are different adjust foctors and control >>

Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

+static int snd_rk_mc_remove(struct platform_device *pdev) +{ +struct snd_soc_card *soc_card = platform_get_drvdata(pdev); + +snd_soc_card_set_drvdata(soc_card, NULL); +snd_soc_unregister_card(soc_card); +platform_set_drvdata(pdev, NULL); No need for any of the _set_drvdata()

Re: [PATCH 2/2] ASoC: rockchip: Add machine driver for rt5645/rt5650 codec

Hi Mark, On 2015年07月18日 02:11, Mark Brown wrote: On Wed, Jul 15, 2015 at 11:15:43AM +0800, Xing Zheng wrote: From: zhengxing The driver is used for rockchip board using a rt5645/rt5650. Same comments here, mostly good but some minor issues. The other thing with both of these is that you

Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

On 2015年07月18日 02:04, Mark Brown wrote: On Wed, Jul 15, 2015 at 11:15:42AM +0800, Xing Zheng wrote: This looks pretty good, a couple of minor points below which should be quick to fix. +static int rk_init(struct snd_soc_pcm_runtime *runtime) +{ + struct snd_soc_card *card =

Re: [PATCH 2/2] ASoC: rockchip: Add machine driver for rt5645/rt5650 codec

Hi Mark, On 2015年07月18日 02:11, Mark Brown wrote: On Wed, Jul 15, 2015 at 11:15:43AM +0800, Xing Zheng wrote: From: zhengxingzhengx...@rock-chips.com The driver is used for rockchip board using a rt5645/rt5650. Same comments here, mostly good but some minor issues. The other thing with both

Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

On 2015年07月18日 02:04, Mark Brown wrote: On Wed, Jul 15, 2015 at 11:15:42AM +0800, Xing Zheng wrote: This looks pretty good, a couple of minor points below which should be quick to fix. +static int rk_init(struct snd_soc_pcm_runtime *runtime) +{ + struct snd_soc_card *card =

Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

+static int snd_rk_mc_remove(struct platform_device *pdev) +{ +struct snd_soc_card *soc_card = platform_get_drvdata(pdev); + +snd_soc_card_set_drvdata(soc_card, NULL); +snd_soc_unregister_card(soc_card); +platform_set_drvdata(pdev, NULL); No need for any of the _set_drvdata()

Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

Hi Paul, On 2015年07月16日 22:15, Paul Bolle wrote: That's exactly how I understood MODULE_ALIAS() to work. And it works, in short, because a platform device fires a "MODALIAS=platform:[...]" uevent when it's created. And userspace uses that uevent to load the module carrying that alias. Let's

Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

Hi Paul, I mean that the use of MODALIAS() in this patch, and I refered to tegra_max98090.c(have been upstreamed) that used it like this also. So I didn't care the using. Thanks. On 2015年07月16日 19:49, Paul Bolle wrote: Hi, On do, 2015-07-16 at 19:20 +0800, zhengxing wrote: Did I miss

Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

On 2015年07月16日 19:00, Mark Brown wrote: On Thu, Jul 16, 2015 at 10:05:44AM +0200, Paul Bolle wrote: +static struct platform_driver snd_rk_mc_driver = { + .probe = snd_rk_mc_probe, + .remove = snd_rk_mc_remove, + .driver = { + .name = DRV_NAME,

Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

Hi Paul, Thank you for your reply. On 2015年07月16日 16:05, Paul Bolle wrote: On wo, 2015-07-15 at 11:15 +0800, Xing Zheng wrote: +static const struct of_device_id rockchip_max98090_of_match[] = { + { .compatible = "rockchip,rockchip-audio-max98090", }, + {}, +}; + +static struct

Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

On 2015年07月16日 19:00, Mark Brown wrote: On Thu, Jul 16, 2015 at 10:05:44AM +0200, Paul Bolle wrote: +static struct platform_driver snd_rk_mc_driver = { + .probe = snd_rk_mc_probe, + .remove = snd_rk_mc_remove, + .driver = { + .name = DRV_NAME,

Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

Hi Paul, Thank you for your reply. On 2015年07月16日 16:05, Paul Bolle wrote: On wo, 2015-07-15 at 11:15 +0800, Xing Zheng wrote: +static const struct of_device_id rockchip_max98090_of_match[] = { + { .compatible = rockchip,rockchip-audio-max98090, }, + {}, +}; + +static struct

Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

Hi Paul, I mean that the use of MODALIAS() in this patch, and I refered to tegra_max98090.c(have been upstreamed) that used it like this also. So I didn't care the using. Thanks. On 2015年07月16日 19:49, Paul Bolle wrote: Hi, On do, 2015-07-16 at 19:20 +0800, zhengxing wrote: Did I miss

Re: [PATCH 1/2] ASoC: rockchip: Add machine driver for max98090 codec

Hi Paul, On 2015年07月16日 22:15, Paul Bolle wrote: That's exactly how I understood MODULE_ALIAS() to work. And it works, in short, because a platform device fires a MODALIAS=platform:[...] uevent when it's created. And userspace uses that uevent to load the module carrying that alias. Let's put

Re: [PATCH 1/4] ASoC: rockchip: add rockchip machine driver

On 2015年05月14日 07:11, Dylan Reid wrote: On Wed, May 13, 2015 at 10:21 AM, Dylan Reid wrote: On Wed, May 13, 2015 at 9:42 AM, Mark Brown wrote: On Wed, May 13, 2015 at 09:23:01PM +0800, zhengxing wrote: On 2015年05月13日 03:22, Mark Brown wrote: Is it not possible to extend simple card

Re: [PATCH 2/4] ASoC: rockchip: add rockchip machine driver for max98090

On 2015年05月13日 03:26, Mark Brown wrote: On Tue, May 12, 2015 at 05:26:35PM +0800, Xing Zheng wrote: sound/soc/rockchip/Kconfig | 10 ++ sound/soc/rockchip/Makefile |2 + sound/soc/rockchip/rockchip_machine_driver.c |6 +

Re: [PATCH 1/4] ASoC: rockchip: add rockchip machine driver

On 2015年05月13日 03:22, Mark Brown wrote: On Tue, May 12, 2015 at 05:26:34PM +0800, Xing Zheng wrote: From: zhengxing In most cases, we maybe use simple-card as generic machine driver on next kernel, but there are some issue that jack detection and widgets extandable on simple-card. Own machine

Re: [PATCH 2/4] ASoC: rockchip: add rockchip machine driver for max98090

On 2015年05月13日 03:26, Mark Brown wrote: On Tue, May 12, 2015 at 05:26:35PM +0800, Xing Zheng wrote: sound/soc/rockchip/Kconfig | 10 ++ sound/soc/rockchip/Makefile |2 + sound/soc/rockchip/rockchip_machine_driver.c |6 +

Re: [PATCH 1/4] ASoC: rockchip: add rockchip machine driver

On 2015年05月13日 03:22, Mark Brown wrote: On Tue, May 12, 2015 at 05:26:34PM +0800, Xing Zheng wrote: From: zhengxingzhengx...@rock-chips.com In most cases, we maybe use simple-card as generic machine driver on next kernel, but there are some issue that jack detection and widgets extandable on

Re: [PATCH 1/4] ASoC: rockchip: add rockchip machine driver

On 2015年05月14日 07:11, Dylan Reid wrote: On Wed, May 13, 2015 at 10:21 AM, Dylan Reiddgr...@chromium.org wrote: On Wed, May 13, 2015 at 9:42 AM, Mark Brownbroo...@kernel.org wrote: On Wed, May 13, 2015 at 09:23:01PM +0800, zhengxing wrote: On 2015年05月13日 03:22, Mark Brown wrote